Re: A margin-al question

[Jean-Marc Lasgouttes]

Le 10/12/2015 23:57, Guillaume Munch a écrit :

Concerning the ticket, I think people should just resize their window :)


I tend to disagree with this last assertion, because the size of the
buffer view changes depending on what panels are open, and also because
margins affect readability and comfort too.


One goal of this blunt assertion was to make people who disagree 
disagree, so that we know what we are tlking about :)


Does this mean that the "limit text width" feature of full text handling 
should apply to normal mode too? That would be trivial.


Note that when one opens a panel, the text moves anyway, which is not 
really comfortable. In this case detaching the panels is probably the 
best bet (mac-like opration).



Personally I would love to be able to set margins and the line spacing
as I see it fit like I can do on my kindle
(),
possibly with a maximum line width.


Yes it is sexy, but it is only useful once or twice. Or are you 
constantly changing sizes?


JMarc

Re: A margin-al question

[Jean-Marc Lasgouttes]

Le 10/12/2015 23:34, Scott Kostyshak a écrit :

My patch is much more limited than the ticket, it only ensures that the
margin is of the same size w.r.t. the character sizes. Note a big feature,
just something that seems logical to do.


I have tested this and it works fine for me in limited testing. Please
put it in.


I just did it.

JMarc

Re: A margin-al question

[Liviu Andronic]

On Fri, Dec 11, 2015 at 3:08 PM, Jean-Marc Lasgouttes
 wrote:
> Does this mean that the "limit text width" feature of full text handling
> should apply to normal mode too? That would be trivial.
>
Yes, this is precisely what I hope that bug #9376 would fix. Either
the same checkbox (suitably renamed), or a different checkbox along
the lines of "limit text width in non-fullscreen mode".

Regards,
Liviu


> Note that when one opens a panel, the text moves anyway, which is not really
> comfortable. In this case detaching the panels is probably the best bet
> (mac-like opration).
>
>> Personally I would love to be able to set margins and the line spacing
>> as I see it fit like I can do on my kindle
>>
>> (),
>> possibly with a maximum line width.
>
>
> Yes it is sexy, but it is only useful once or twice. Or are you constantly
> changing sizes?
>
> JMarc
>



-- 
Do you think you know what math is?
http://www.ideasroadshow.com/issues/ian-stewart-2013-08-02
Or what it means to be intelligent?
http://www.ideasroadshow.com/issues/john-duncan-2013-08-30
Think again:
http://www.ideasroadshow.com/library

Re: A margin-al question

[Guillaume Munch]

Le 11/12/2015 14:08, Jean-Marc Lasgouttes a écrit :

Le 10/12/2015 23:57, Guillaume Munch a écrit :

Concerning the ticket, I think people should just resize their window :)


I tend to disagree with this last assertion, because the size of the
buffer view changes depending on what panels are open, and also because
margins affect readability and comfort too.


One goal of this blunt assertion was to make people who disagree
disagree, so that we know what we are tlking about :)


"The best way to get the right answer on the Internet is not to ask a 
question, it is to post the wrong answer"... :)




Does this mean that the "limit text width" feature of full text handling
should apply to normal mode too? That would be trivial.


That would be one of the desired features that we could regroup in the 
preferences under a new "readability" tab (maybe together with the 
screen fonts selection), in addition to a minimal width for the margin, 
a selection of line spacing (which should be different from the LaTeX 
output as discussed recently), and the choice of displaying 
justification on screen or not (which should be moved from a 
per-document setting to a per-user setting as discussed recently).


However, I do not know whether this should be expressed in pixels or in 
ems (zoom-dependent). Also I tested it and it's good to see that it 
interacted well with horizontal scrolling as I hoped.




Note that when one opens a panel, the text moves anyway, which is not
really comfortable.


This is a separate issue, less important to me.


In this case detaching the panels is probably the
best bet (mac-like opration).


So maybe detached panels are more convenient in Mac than in Ubuntu...




Personally I would love to be able to set margins and the line spacing
as I see it fit like I can do on my kindle
(),

possibly with a maximum line width.


Yes it is sexy, but it is only useful once or twice. Or are you
constantly changing sizes?



No, I agree, I am only thinking of new choices in the preferences dialog.


Guillaume

Re: A margin-al question

[Guillaume Munch]

Le 11/12/2015 17:05, Liviu Andronic a écrit :

On Fri, Dec 11, 2015 at 3:08 PM, Jean-Marc Lasgouttes
 wrote:

Does this mean that the "limit text width" feature of full text handling
should apply to normal mode too? That would be trivial.


Yes, this is precisely what I hope that bug #9376 would fix. Either
the same checkbox (suitably renamed), or a different checkbox along
the lines of "limit text width in non-fullscreen mode".


For now, +1. I think, UI-wise, for this, we just need to move the 
widgets before the "Fullscreen" section in the control tab.

Re: A margin-al question

[Scott Kostyshak]

On Sat, Dec 05, 2015 at 10:03:49PM +0100, Jean-Marc Lasgouttes wrote:
> Le 05/12/15 07:17, Scott Kostyshak a écrit :
> >On Fri, Dec 04, 2015 at 07:14:43PM -0500, Scott Kostyshak wrote:
> >>On Thu, Dec 03, 2015 at 10:10:15AM +0100, Jean-Marc Lasgouttes wrote:
> >>>Le 30/11/2015 12:02, Scott Kostyshak a écrit :
> On Sun, Nov 29, 2015 at 11:18:11PM +0100, Murat Yildizoglu wrote:
> >Hello,
> >I would like to know if it would be too difficult for you to implement an
> >option that permits us to fix the margin between the text's border and
> >LyX's window border. Currently, there is nearly zero margin, and that is
> >something that slightly annoyed me for many years.
> 
> Can you send a screenshot? For me there is a margin.
> >>>
> >>>Would this spin-off of my earlier zoomed width patch (which is on hold for
> >>>now) be useful for margins?
> >>
> >>Works fine for me in limited testing. I would say put it in if you think
> >>it is the right thing to do.
> >
> >I believe this is the following issue:
> >http://www.lyx.org/trac/ticket/9376
> 
> My patch is much more limited than the ticket, it only ensures that the
> margin is of the same size w.r.t. the character sizes. Note a big feature,
> just something that seems logical to do.

I have tested this and it works fine for me in limited testing. Please
put it in.

Scott


signature.asc
Description: PGP signature

Re: A margin-al question

[Scott Kostyshak]

On Sat, Dec 05, 2015 at 10:06:27PM +0100, Jean-Marc Lasgouttes wrote:
> Le 29/11/15 23:18, Murat Yildizoglu a écrit :
> >Hello,
> >I would like to know if it would be too difficult for you to implement
> >an option that permits us to fix the margin between the text's border
> >and LyX's window border. Currently, there is nearly zero margin, and
> >that is something that slightly annoyed me for many years.
> >I was wondering if the adoption of the new QT would allow for such an
> >option.
> >This is  a question comfort rather than usability, but nevertheless...
> >Best regards,
> 
> Murat, what kind of value would you choose for the margin? What is the
> difference wrt just resizing the window? We have a ticket that complains
> about line width, but I tend to think that the solution is to qvoid
> full-screen windows.
> 
> Do you have something else in mind?

Murat, do you have any input on the above questions?

Scott


signature.asc
Description: PGP signature

Re: A margin-al question

[Guillaume Munch]

Le 05/12/2015 21:03, Jean-Marc Lasgouttes a écrit :

Le 05/12/15 07:17, Scott Kostyshak a écrit :

On Fri, Dec 04, 2015 at 07:14:43PM -0500, Scott Kostyshak wrote:

On Thu, Dec 03, 2015 at 10:10:15AM +0100, Jean-Marc Lasgouttes wrote:

Le 30/11/2015 12:02, Scott Kostyshak a écrit :

On Sun, Nov 29, 2015 at 11:18:11PM +0100, Murat Yildizoglu wrote:

Hello,
I would like to know if it would be too difficult for you to
implement an
option that permits us to fix the margin between the text's border
and
LyX's window border. Currently, there is nearly zero margin, and
that is
something that slightly annoyed me for many years.


Can you send a screenshot? For me there is a margin.


Would this spin-off of my earlier zoomed width patch (which is on
hold for
now) be useful for margins?


Works fine for me in limited testing. I would say put it in if you think
it is the right thing to do.


I believe this is the following issue:
http://www.lyx.org/trac/ticket/9376


My patch is much more limited than the ticket, it only ensures that the
margin is of the same size w.r.t. the character sizes. Note a big
feature, just something that seems logical to do.

Concerning the ticket, I think people should just resize their window :)



I tend to disagree with this last assertion, because the size of the 
buffer view changes depending on what panels are open, and also because 
margins affect readability and comfort too.


Personally I would love to be able to set margins and the line spacing 
as I see it fit like I can do on my kindle 
(), 
possibly with a maximum line width.



Guillaume

Re: A margin-al question

[Murat Yildizoglu]

Sorry Scott,
It seems that I have missed your original reply. 
I do not use the full screen mode, but even in a normal window, the letters are 
just touching the border of the window, without any gutter or margin. For me 
the text would be easier to read and manipulate if there was a small gutter at 
least between the window border and the letters of the text. I use LyX under 
OSX FYI. 

Murat Yildizoglu

> Le 10 déc. 2015 à 23:35, Scott Kostyshak  a écrit :
> 
>> On Sat, Dec 05, 2015 at 10:06:27PM +0100, Jean-Marc Lasgouttes wrote:
>> Le 29/11/15 23:18, Murat Yildizoglu a écrit :
>>> Hello,
>>> I would like to know if it would be too difficult for you to implement
>>> an option that permits us to fix the margin between the text's border
>>> and LyX's window border. Currently, there is nearly zero margin, and
>>> that is something that slightly annoyed me for many years.
>>> I was wondering if the adoption of the new QT would allow for such an
>>> option.
>>> This is  a question comfort rather than usability, but nevertheless...
>>> Best regards,
>> 
>> Murat, what kind of value would you choose for the margin? What is the
>> difference wrt just resizing the window? We have a ticket that complains
>> about line width, but I tend to think that the solution is to qvoid
>> full-screen windows.
>> 
>> Do you have something else in mind?
> 
> Murat, do you have any input on the above questions?
> 
> Scott

Re: A margin-al question

[Jean-Marc Lasgouttes]

Le 29/11/15 23:18, Murat Yildizoglu a écrit :

Hello,
I would like to know if it would be too difficult for you to implement
an option that permits us to fix the margin between the text's border
and LyX's window border. Currently, there is nearly zero margin, and
that is something that slightly annoyed me for many years.
I was wondering if the adoption of the new QT would allow for such an
option.
This is  a question comfort rather than usability, but nevertheless...
Best regards,


Murat, what kind of value would you choose for the margin? What is the 
difference wrt just resizing the window? We have a ticket that complains 
about line width, but I tend to think that the solution is to qvoid 
full-screen windows.


Do you have something else in mind?

JMarc

Re: A margin-al question

[Jean-Marc Lasgouttes]

Le 05/12/15 07:17, Scott Kostyshak a écrit :

On Fri, Dec 04, 2015 at 07:14:43PM -0500, Scott Kostyshak wrote:

On Thu, Dec 03, 2015 at 10:10:15AM +0100, Jean-Marc Lasgouttes wrote:

Le 30/11/2015 12:02, Scott Kostyshak a écrit :

On Sun, Nov 29, 2015 at 11:18:11PM +0100, Murat Yildizoglu wrote:

Hello,
I would like to know if it would be too difficult for you to implement an
option that permits us to fix the margin between the text's border and
LyX's window border. Currently, there is nearly zero margin, and that is
something that slightly annoyed me for many years.


Can you send a screenshot? For me there is a margin.


Would this spin-off of my earlier zoomed width patch (which is on hold for
now) be useful for margins?


Works fine for me in limited testing. I would say put it in if you think
it is the right thing to do.


I believe this is the following issue:
http://www.lyx.org/trac/ticket/9376


My patch is much more limited than the ticket, it only ensures that the 
margin is of the same size w.r.t. the character sizes. Note a big 
feature, just something that seems logical to do.


Concerning the ticket, I think people should just resize their window :)

JMarc

Re: A margin-al question

[Scott Kostyshak]

On Thu, Dec 03, 2015 at 10:10:15AM +0100, Jean-Marc Lasgouttes wrote:
> Le 30/11/2015 12:02, Scott Kostyshak a écrit :
> >On Sun, Nov 29, 2015 at 11:18:11PM +0100, Murat Yildizoglu wrote:
> >>Hello,
> >>I would like to know if it would be too difficult for you to implement an
> >>option that permits us to fix the margin between the text's border and
> >>LyX's window border. Currently, there is nearly zero margin, and that is
> >>something that slightly annoyed me for many years.
> >
> >Can you send a screenshot? For me there is a margin.
> 
> Would this spin-off of my earlier zoomed width patch (which is on hold for
> now) be useful for margins?

Works fine for me in limited testing. I would say put it in if you think
it is the right thing to do.

Scott


signature.asc
Description: PGP signature

Re: A margin-al question

[Scott Kostyshak]

On Fri, Dec 04, 2015 at 07:14:43PM -0500, Scott Kostyshak wrote:
> On Thu, Dec 03, 2015 at 10:10:15AM +0100, Jean-Marc Lasgouttes wrote:
> > Le 30/11/2015 12:02, Scott Kostyshak a écrit :
> > >On Sun, Nov 29, 2015 at 11:18:11PM +0100, Murat Yildizoglu wrote:
> > >>Hello,
> > >>I would like to know if it would be too difficult for you to implement an
> > >>option that permits us to fix the margin between the text's border and
> > >>LyX's window border. Currently, there is nearly zero margin, and that is
> > >>something that slightly annoyed me for many years.
> > >
> > >Can you send a screenshot? For me there is a margin.
> > 
> > Would this spin-off of my earlier zoomed width patch (which is on hold for
> > now) be useful for margins?
> 
> Works fine for me in limited testing. I would say put it in if you think
> it is the right thing to do.

I believe this is the following issue:
http://www.lyx.org/trac/ticket/9376

Scott


signature.asc
Description: PGP signature

Re: A margin-al question

[Jean-Marc Lasgouttes]

Le 30/11/2015 12:02, Scott Kostyshak a écrit :

On Sun, Nov 29, 2015 at 11:18:11PM +0100, Murat Yildizoglu wrote:

Hello,
I would like to know if it would be too difficult for you to implement an
option that permits us to fix the margin between the text's border and
LyX's window border. Currently, there is nearly zero margin, and that is
something that slightly annoyed me for many years.


Can you send a screenshot? For me there is a margin.


Would this spin-off of my earlier zoomed width patch (which is on hold 
for now) be useful for margins?


JMarc



>From 3cbe881e32f9e1a63963876b2510fa3ed69fa4b0 Mon Sep 17 00:00:00 2001
From: Jean-Marc Lasgouttes 
Date: Thu, 3 Dec 2015 10:07:52 +0100
Subject: [PATCH] Make text margin size dependent on zoom and dpi

---
 src/BufferView.cpp | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 0030f33..dbd485d 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -351,11 +351,13 @@ BufferView::~BufferView()
 
 int BufferView::rightMargin() const
 {
+	// The value used to be hardcoded to 10, which is 2.5mm at 100dpi
+	int const default_margin = Length(2.5, Length::MM).inPixels(0);
 	// The additional test for the case the outliner is opened.
 	if (!full_screen_ ||
 		!lyxrc.full_screen_limit ||
-		width_ < lyxrc.full_screen_width + 20)
-			return 10;
+		width_ < lyxrc.full_screen_width + 2 * default_margin)
+			return default_margin;
 
 	return (width_ - lyxrc.full_screen_width) / 2;
 }
-- 
2.5.0

Re: A margin-al question

[Jean-Marc Lasgouttes]

Le 29/11/2015 23:18, Murat Yildizoglu a écrit :

Hello,
I would like to know if it would be too difficult for you to implement
an option that permits us to fix the margin between the text's border
and LyX's window border. Currently, there is nearly zero margin, and
that is something that slightly annoyed me for many years.
I was wondering if the adoption of the new QT would allow for such an
option.
This is  a question comfort rather than usability, but nevertheless...


Hi Murat,

What is the resolution of your screen (DPI)? At 100dpi, the current 
margin corresponds to 2.5mm. I have a patch that enforces this length 
also when the resolution is higher.


If you are looking for a much larger margin, then your should have a 
look at our fullscreen support, which allows to select the margin value.



JMarc

Re: A margin-al question

[Scott Kostyshak]

On Sun, Nov 29, 2015 at 11:18:11PM +0100, Murat Yildizoglu wrote:
> Hello,
> I would like to know if it would be too difficult for you to implement an
> option that permits us to fix the margin between the text's border and
> LyX's window border. Currently, there is nearly zero margin, and that is
> something that slightly annoyed me for many years.

Can you send a screenshot? For me there is a margin.

> I was wondering if the adoption of the new QT would allow for such an
> option.

> This is  a question comfort rather than usability, but nevertheless...

These questions are important.

Best,

Scott


signature.asc
Description: PGP signature