Re: Preparing for development

2020-01-09 Thread Jean-Marc Lasgouttes

Le 09/01/2020 à 18:40, Yu Jin a écrit :
After some research and trial and error work I finally understand what 
is happening there.
The old imagemagick with the old ghostscript works, that means, that 
magick is found correctly. But then magick searches registry for 
"CoderModulesPath", because it needs some module for converting. 


This is a real pain. I see there is a portable imagemagick in the binary 
download directory. Is there a reason why we are not using this? I 
suspect it would not require ugly registry hacks.


JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-09 Thread Yu Jin
After some research and trial and error work I finally understand what is
happening there.
The old imagemagick with the old ghostscript works, that means, that magick
is found correctly. But then magick searches registry for
"CoderModulesPath", because it needs some module for converting. The
version magick in installed lyx is 7.0.7, LyX installer creates registry
entries for that version, so the installed LyX works. And when I copy them
to compiled LyX, it finds magick in there, but then uses the modules within
the installed LyX version, because the registry entries poin to that one.
The dependencies folder contains 7.0.8 imagemagick, so that magick will
search for the registry entry in a different place, but It is not there,
because noone registers it in there, so it fails.
I had to put following entries for imagemagick into registry with regedit
(the paths are given conform to the INSTALL.Win32 guide):

[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\ImageMagick\7.0.8\Q:16]
"CoderModulesPath"="C:\\lyx\\lyx-windows-deps-msvc2017\\imagemagick\\modules\\coders"
"BinPath"="C:\\lyx\\lyx-windows-deps-msvc2017\\imagemagick"
"ConfigurePath"="C:\\lyx\\lyx-windows-deps-msvc2017\\imagemagick"
"FilterModulesPath"="C:\\lyx\\lyx-windows-deps-msvc2017\\imagemagick\\modules\\filters"
"LibPath"="C:\\lyx\\lyx-windows-deps-msvc2017\\imagemagick"

I just found the entries for the imagemagick in installed LyX under
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\ImageMagick\7.0.7\Q:16] and looked
in there which entries variables I need and to what folder to point them to.

Additionally I needed an registry entry for ghostscript, because by default
magick would try to call "gswin32c.exe" if it needs it, but the
dependencies contain 64 bit ghostscript (so "gswin64c.exe"). This is the
entry I needed to do:

[HKEY_LOCAL_MACHINE\SOFTWARE\GPL Ghostscript\9.50]
"GS_DLL"="gswin64c.exe"

Not sure if the ghostscript in the dependencies is v9.50, but it works like
this. I have installed ghostscript 64 bit from website, experimented with
it a bit and came up with this entry.

This is a usefull information for me for creating the windows installer :)

Now can we let CMake make these entries while configuring for Visual
Studio? because we point CMake to the GNUWIN32 dir, which is the
dependencies folder, anyway... or should I update the INSTALL.Win32 guide?

Eugene
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-08 Thread Pavel Sanda
On Tue, Jan 07, 2020 at 08:40:51PM +0100, Yu Jin wrote:
> >
> > Something similar to PATH (DIR?) environment variable including path to
> > imagemagick is likely missing. I guess VC can setup such thing in
> > settings(?).
> >
> 
> Simply cant get it working, tried adding all of those paths to projects
> properties... to PATH... not working...
> When I copy imagemagick and ghostscript folder from the installed LyX to
> the built one it works, but only if I copy and not move. So there must be
> something in imagemagick folder that points it to the ghostscript folder?
> But when I copy only the ghostscript folder it does not work. At the same
> time when when I copy only the imagemagick folder it does not work either,
> works only if both folders are at both places... I dont get it.

Hmm, isn't possible that RC_PATH_PREFIX is handled differently in installed
lyx and your compiled version?
Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-07 Thread Yu Jin
>
> Something similar to PATH (DIR?) environment variable including path to
> imagemagick is likely missing. I guess VC can setup such thing in
> settings(?).
>

Simply cant get it working, tried adding all of those paths to projects
properties... to PATH... not working...
When I copy imagemagick and ghostscript folder from the installed LyX to
the built one it works, but only if I copy and not move. So there must be
something in imagemagick folder that points it to the ghostscript folder?
But when I copy only the ghostscript folder it does not work. At the same
time when when I copy only the imagemagick folder it does not work either,
works only if both folders are at both places... I dont get it.
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-07 Thread Pavel Sanda
On Tue, Jan 07, 2020 at 03:22:16PM +0100, Yu Jin wrote:
> What also just worked, I copied the LyX.exe which I compiled on my PC
> (stable) into the bin folder of the installed LyX (moved the origional one
> to a different place beforehand) and tried it out with that one, pdf file
> was displayed so the python script succeeded.
> 
> Any idea what is going on there?

Something similar to PATH (DIR?) environment variable including path to
imagemagick is likely missing. I guess VC can setup such thing in settings(?).

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-07 Thread Yu Jin
Thanks :),

In the mean while I have investigated the issue, where pdf files are not
displayed for me.
I have seen that there is a python script generated in a temporary folder,
which is then executed. It first should convert pdf6 to eps and then eps to
png. The first step seems to succeed but the second not. Then LyX can't
load the png file because it does not exist.
As far as I can tell it fails here:

os.system(r'magick ' + '"' + infile + '"' + ' ' + '"' + outfile + '"' + '')

I have tried to type this command manually into python command prompt (of
course after importing "os" and creating all the other variables, which are
created in the script, and making sure that the infile exists), but all I
get is .

Strangely it works on the installed 2.3.3 version, which I downloaded from
lyx.org and installed, but it does not on both versions (master and
stable), which I have compiled on my PC. Even though the scripts are same.

What also just worked, I copied the LyX.exe which I compiled on my PC
(stable) into the bin folder of the installed LyX (moved the origional one
to a different place beforehand) and tried it out with that one, pdf file
was displayed so the python script succeeded.

Any idea what is going on there?


Eugene
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-06 Thread Jürgen Spitzmüller
Am Montag, den 06.01.2020, 12:48 +0100 schrieb Kornel Benko:
> Ah, OK. I committed now his patch, looks good.

... and credits added.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-06 Thread Kornel Benko
Am Mon, 06 Jan 2020 08:12:25 +0100
schrieb Jürgen Spitzmüller :

> Am Sonntag, den 05.01.2020, 22:09 +0100 schrieb Kornel Benko:
> > No problem, but misleading. I suppose that's the reason why you are
> > still
> > not registered as 'has given blanket permission'.
> > 
> > Jürgen, could you add him please?  
> 
> We usually register after the first commit has been pushed.
> 
> Jürgen

Ah, OK. I committed now his patch, looks good.

Kornel


pgpFeKCBK1bKL.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-05 Thread Jürgen Spitzmüller
Am Sonntag, den 05.01.2020, 22:09 +0100 schrieb Kornel Benko:
> No problem, but misleading. I suppose that's the reason why you are
> still
> not registered as 'has given blanket permission'.
> 
> Jürgen, could you add him please?

We usually register after the first commit has been pushed.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-05 Thread Kornel Benko
Am Sun, 5 Jan 2020 21:53:42 +0100
schrieb Yu Jin :

> Am So., 5. Jan. 2020 um 21:38 Uhr schrieb Kornel Benko :
> 
> > We expect qt be installed ...
> >
> 
> Yeah, I have Qt installed and pointed CMake to the right directories, Is
> the "package" target/project supposed to copy the needed dependencies and
> dll files (like Qt5Cored.dll ...)? Then it does not work.
> 
> Could you please evaluate, which procedure feel better.
> > Using 'install' and then copy the files
> > or
> > using 'package' and then unpack/unzip at the desired place?
> >
> 
> I think that using install is better as it is right now.
> 
> A revised patch is welcome, I will commit it.
> >
> > Kornel
> >
> > PS:
> > BTW what's the meaning of having 'Yu Jin' as name in the mail and sign as
> >  'Eugene Chornyi'.
> > The former feels Korean while the second feels Russian.
> >
> 
> Eugene Chornyi is my real name, thats why I sign as Eugene. See Yu Jin as
> my nickname, I have chosen it because it sounds similar to Eugene if you
> pronounce it. Is that a problem? should I change that?
> 
> Eugene

No problem, but misleading. I suppose that's the reason why you are still
not registered as 'has given blanket permission'.

Jürgen, could you add him please?

Kornel


pgpPGvd37lSgA.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-05 Thread Yu Jin
Am So., 5. Jan. 2020 um 21:38 Uhr schrieb Kornel Benko :

> We expect qt be installed ...
>

Yeah, I have Qt installed and pointed CMake to the right directories, Is
the "package" target/project supposed to copy the needed dependencies and
dll files (like Qt5Cored.dll ...)? Then it does not work.

Could you please evaluate, which procedure feel better.
> Using 'install' and then copy the files
> or
> using 'package' and then unpack/unzip at the desired place?
>

I think that using install is better as it is right now.

A revised patch is welcome, I will commit it.
>
> Kornel
>
> PS:
> BTW what's the meaning of having 'Yu Jin' as name in the mail and sign as
>  'Eugene Chornyi'.
> The former feels Korean while the second feels Russian.
>

Eugene Chornyi is my real name, thats why I sign as Eugene. See Yu Jin as
my nickname, I have chosen it because it sounds similar to Eugene if you
pronounce it. Is that a problem? should I change that?

Eugene
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-05 Thread Kornel Benko
Am Sun, 5 Jan 2020 21:21:07 +0100
schrieb Yu Jin :

> > In the description you change 'MSVC 2017' to 'MSVC 2019', but later on
> > you still refer to
> >         'MSVC 2017',
> >         C:\LyX\lyx-windows-deps-msvc2017
> > 
> > Intended?
> > 
> Yes, The Microsoft Visual Studio 2017 is no longer available for download 
> because there
> is the new Visual Studio 2019. But in Qt online installer, there are no MSVC 
> 2019 kits,
> only the 2017 ones, thats why I wrote, that the 2019 MSVC compilers (the 
> build tools
> installed in the Visual Studio installer) are compatible with the MSVC 2017 
> kits in Qt.
> As for the dependencies, well in here http://ftp.lyx.de/LyXWinInstaller/ are 
> only
> dependencies called lyx-windows-deps-msvc2017 :)
> > I'd like to know what happens if you
> > enable 'LYX_CPACK=ON' in cmake gui. Is there a new
> > target 'package'?
> > If yes, I expect created .zip-file if using this target (instead of 
> > 'install').
> > 
> Yeah it works, this folder is created in the build directory: 
> _CPack_Packages\win64\ZIP
> in this folder there is actually a folder called LyX24-2.4.0-win64, it 
> contains the
> stuff which is in LYX_INSTALLED folder if building the INSTALL target/project 
> and
> additionally the ZIP contains this LyX24-2.4.0-win64 folder packed in a zip 
> file, there
> are no dependencies and Qt dlls though...
> 

We expect qt be installed ...

Could you please evaluate, which procedure feel better.
Using 'install' and then copy the files
or
using 'package' and then unpack/unzip at the desired place?

A revised patch is welcome, I will commit it.

Kornel

PS:
BTW what's the meaning of having 'Yu Jin' as name in the mail and sign as
 'Eugene Chornyi'.
The former feels Korean while the second feels Russian.



pgpXcfuqiyzd8.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-05 Thread Yu Jin
Am So., 5. Jan. 2020 um 20:11 Uhr schrieb Kornel Benko :

> Am Sun, 5 Jan 2020 15:56:32 +0100
> schrieb Yu Jin :
>
> > As promised I have updated the description for setting up the tools on
> > windows
> >
> > Eugene
>
> In the description you change 'MSVC 2017' to 'MSVC 2019', but later on
> you still refer to
> 'MSVC 2017',
> C:\LyX\lyx-windows-deps-msvc2017
>
> Intended?
>

Yes, The Microsoft Visual Studio 2017 is no longer available for download
because there is the new Visual Studio 2019.
But in Qt online installer, there are no MSVC 2019 kits, only the 2017
ones, thats why I wrote, that the 2019 MSVC compilers (the build tools
installed in the Visual Studio installer) are compatible with the MSVC 2017
kits in Qt.
As for the dependencies, well in here http://ftp.lyx.de/LyXWinInstaller/
are only dependencies called lyx-windows-deps-msvc2017 :)


> I'd like to know what happens if you enable 'LYX_CPACK=ON' in cmake gui.
> Is there a new
> target 'package'?
> If yes, I expect created .zip-file if using this target (instead of
> 'install').
>

Yeah it works, this folder is created in the build directory:
_CPack_Packages\win64\ZIP in this folder there is actually a folder called
LyX24-2.4.0-win64, it contains the stuff which is in LYX_INSTALLED folder
if building the INSTALL target/project and additionally the ZIP contains
this LyX24-2.4.0-win64 folder packed in a zip file, there are no
dependencies and Qt dlls though...

Kornel
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel


Eugene
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-05 Thread Kornel Benko
Am Sun, 5 Jan 2020 15:56:32 +0100
schrieb Yu Jin :

> As promised I have updated the description for setting up the tools on
> windows
> 
> Eugene

In the description you change 'MSVC 2017' to 'MSVC 2019', but later on
you still refer to
'MSVC 2017',
C:\LyX\lyx-windows-deps-msvc2017

Intended?

I'd like to know what happens if you enable 'LYX_CPACK=ON' in cmake gui. Is 
there a new
target 'package'?
If yes, I expect created .zip-file if using this target (instead of 'install').

Kornel


pgpBsd3f4bpd0.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-05 Thread Yu Jin
As promised I have updated the description for setting up the tools on
windows

Eugene


updated-windows-dev-description.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-05 Thread Jürgen Spitzmüller
Am Sonntag, den 05.01.2020, 10:11 +0100 schrieb Yu Jin:
> You are right, I got it working now :). Debugging works, I just have
> to specify the LyX.exe in the Installed folder as startup file
> manually, then I can set breakpoints and debug as I am used to. I
> will document my experiences in the install.win32 file next.

Before we can commit your hopefully many contributions, could you
please send a mail such as the following to this list?
https://marc.info/?l=lyx-devel&m=142644092217864

Thanks
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-05 Thread Yu Jin
You are right, I got it working now :). Debugging works, I just have to
specify the LyX.exe in the Installed folder as startup file manually, then
I can set breakpoints and debug as I am used to. I will document my
experiences in the install.win32 file next.
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-04 Thread Kornel Benko
Am Sat, 4 Jan 2020 19:16:28 +0100
schrieb Yu Jin :

> I think I actually found a clue. In the LyX.sln there are 36 projects, one
> of them is called install, compiling that one creates a LYX_INSTALLED
> folder. I just went with Build > Build Solution in VS menu bar. Now I see
> that in the stable branch it is described differently with "Compile the
> INSTALL project to get a LyX installation in
> C:\LyX\lyx-23-build\LYX_INSTALLED.", makes sense. So that takes care of
> that.
> Now I just have the issue with the "Debug" folder within the bin folder.
> Note, when compiling the Install project I have not that "Debug" folder,
> the file hierarchy is as it should be.

Why? If compiling for release, one does not need 'Debug'.

> I guess the install project wont do for debugging, right?

No, the install target is orthogonal to debug/release. At least on linux.

> maybe, there is
> another project, which I can compile? I will append pictures with the
> projects hierarchy in the solution file, maybe it makes sense to you.
> [image: prjH1.PNG]
> [image: prjH2.PNG]
> 
> Eugene

Thanks. Looks like everything can be started from under 'LyX.sln'
And you need only 'install' target(==project in Win terminology)
Most of the other targets are done automatically, since 'install' depends on 
them.
Some of the (e.g. lyx_run_tests) are only for tests. But don't use it until we 
are ready
to compile and install everything.

Kornel

Kornel


pgpiTYzW8fWsF.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-04 Thread Yu Jin
I think I actually found a clue. In the LyX.sln there are 36 projects, one
of them is called install, compiling that one creates a LYX_INSTALLED
folder. I just went with Build > Build Solution in VS menu bar. Now I see
that in the stable branch it is described differently with "Compile the
INSTALL project to get a LyX installation in
C:\LyX\lyx-23-build\LYX_INSTALLED.", makes sense. So that takes care of
that.
Now I just have the issue with the "Debug" folder within the bin folder.
Note, when compiling the Install project I have not that "Debug" folder,
the file hierarchy is as it should be.
I guess the install project wont do for debugging, right? maybe, there is
another project, which I can compile? I will append pictures with the
projects hierarchy in the solution file, maybe it makes sense to you.
[image: prjH1.PNG]
[image: prjH2.PNG]

Eugene
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-04 Thread Kornel Benko
Am Sat, 4 Jan 2020 17:42:16 +0100
schrieb Yu Jin :

> Yes, I am 100% sure, that I check the LYX_INSTALL box in the CMake Gui.
> There are these solutions created:
> 
> LyX.sln
> 3rdparty\zlib\zlib.sln
> src\tex2lyx\tex2lyx.sln
> src\tex2lyx\test\testTex2lyx.sln
> src\frontends\tests\testFrontends.sln
> lib\examples\testExamples.sln
> src\support\tests\supporttest.sln
> src\support\support.sln
> po\po.sln
> src\mathed\mathed.sln
> 3rdparty\libiconv\libiconv.sln
> src\insets\insets.sln
> 3rdparty\hunspell\hunspell.sln
> src\graphics\graphics.sln
> src\frontends\frontends.sln
> src\frontends\qt4\frontend_qt.sln
> sourcedoc\doxydoc.sln
> doc\doc.sln
> 3rdparty\boost\libs\regex\boost_regex.sln
> 3rdparty\boost\libs\boost.sln

This is sooo different to what we have as targets in linux. Your solutions
correspond apparently only to project names.

What is the standard handling if one wants to install?

Kornel


pgpX0ATuXu3A6.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-04 Thread Yu Jin
Yes, I am 100% sure, that I check the LYX_INSTALL box in the CMake Gui.
There are these solutions created:

LyX.sln
3rdparty\zlib\zlib.sln
src\tex2lyx\tex2lyx.sln
src\tex2lyx\test\testTex2lyx.sln
src\frontends\tests\testFrontends.sln
lib\examples\testExamples.sln
src\support\tests\supporttest.sln
src\support\support.sln
po\po.sln
src\mathed\mathed.sln
3rdparty\libiconv\libiconv.sln
src\insets\insets.sln
3rdparty\hunspell\hunspell.sln
src\graphics\graphics.sln
src\frontends\frontends.sln
src\frontends\qt4\frontend_qt.sln
sourcedoc\doxydoc.sln
doc\doc.sln
3rdparty\boost\libs\regex\boost_regex.sln
3rdparty\boost\libs\boost.sln
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-04 Thread Kornel Benko
Am Sat, 4 Jan 2020 14:20:38 +0100
schrieb Yu Jin :

> I tried to generate visual studio solution with the CMake gui, but there is
> no install.sln there anywhere. Well, tbh I would like VS more, because it's
> debugger is just much enjoyable to work with. So next I will do is train
> CMake and try to resolve the issues I have with VS. For now I have created
> a bug report and uploaded a patch file as possible fix for the "not
> recognizing python" issue: https://www.lyx.org/trac/ticket/11712

Are you susre, you have set the option LYX_INSTALL to 'ON' ?

Are there some solutions created (*.sln)?

Kornel


pgpNjCLTBvaec.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-04 Thread Yu Jin
I tried to generate visual studio solution with the CMake gui, but there is
no install.sln there anywhere. Well, tbh I would like VS more, because it's
debugger is just much enjoyable to work with. So next I will do is train
CMake and try to resolve the issues I have with VS. For now I have created
a bug report and uploaded a patch file as possible fix for the "not
recognizing python" issue: https://www.lyx.org/trac/ticket/11712
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-03 Thread Kornel Benko
Am Fri, 3 Jan 2020 20:28:19 +0100
schrieb Yu Jin :

> > Is this something that is enforced, or can we change it in our cmake
> > settings?
> > 
> I'm not sure, I have seen that it can be changed in project properties in 
> Visual Studio
> after generating the VS solution with cmake, but it would need to be done for 
> each one
> of the 36 projects separately, which is a pain in the ass. I dont know much 
> about CMake
> yet though, I guess I'm gona train that first. I imagine, that that and the 
> issue,
> where LYX_INSTALLED folder is not created, are probably related to CMake. 

I think that LYX_INSTALLED-folder on Win is created at install target.
(There should be a solution like 'install.sln')

But I don't know the qt-creator on Win, so maybe I'm wrong.

Kornel


pgpf6tkNXLl17.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-03 Thread Yu Jin
Now you got me all excited, I am happy that I can be helpful :)

Am Fr., 3. Jan. 2020 um 14:48 Uhr schrieb Jean-Marc Lasgouttes <
lasgout...@lyx.org>:

> Le 02/01/2020 à 17:31, Yu Jin a écrit :
> > Hi again, thank you for welcoming.
>
> Hi, I do compile on windows, but using a clumsy .bat file. I never
> manage to compile/debug LyX from the Visual Studio IDE. So having a
> working workflow for debugging LyX would be very valuable. In
> particular, getting profiling to work would be great. We have known for
> some time that the performance hits are different on windows, but only
> the most glaring examples have been fixed. I suspect it is possible to
> make LyX faster on windows.
>
> As Pavel wrote, we do not have any real windows developer, and this
> would make our life much easier. There are probably improvements that
> can be made to the cmake files in the windows-related parts.
>
> > I have looked into this a bit more and got LyX to recognize Python, I
> > had to change some strings in the support static library for that, I
> > will send a diff file later and we can discuss that.
>
> Good. I have seen this issue too, the oython detection code is very
> weird to me.
>
> > As for the development environment, I think that QT Creator is a good
> > choice. Visual Studio for example makes "Debug" and "Release" subfolders
> > in the "bin" folder, and because of that things get more complicated.
>
> Is this something that is enforced, or can we change it in our cmake
> settings?
>

I'm not sure, I have seen that it can be changed in project properties in
Visual Studio after generating the VS solution with cmake, but it would
need to be done for each one of the 36 projects separately, which is a pain
in the ass. I dont know much about CMake yet though, I guess I'm gona train
that first. I imagine, that that and the issue, where LYX_INSTALLED folder
is not created, are probably related to CMake.


> > 4. Even though LyX finds Python, it still does not display inserted pdf
> > files (I guess that Python is used to display them). Maybe someone could
> > give me a hint on where to start looking? I have not had a chance to
> > learn Python yet. But if you could point me in the right direction, like
> > which function to debug and what it basically does, it would be helpful.
>
> What pdf viewer do you have installed?
>

I use PDF Xchange Editor Plus 6.0. In 2.3.3 stable it works though, I just
compiled that branch the same way and it does display pdf files.


> > I will extend the windows guide once I get along with the Python issue.
> > I am up for maintaining the windows installer, I will train that and see
> > what I can do.
>
> Great news. Welcome.
>
> JMarc
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-03 Thread Pavel Sanda
On Thu, Jan 02, 2020 at 05:31:15PM +0100, Yu Jin wrote:
> Also you can edit the UI elements in QT Creator. 

You can always use qt designer for that independently of qt-creator/visual
studio choice.

> I could not manage to get into the main window UI yet though, maybe you could
> tell me how it works?

IIRC main window is created manualy in the code, not through .ui file.


> 4. Even though LyX finds Python, it still does not display inserted pdf
> files (I guess that Python is used to display them). Maybe someone could
> give me a hint on where to start looking? I have not had a chance to learn
> Python yet. But if you could point me in the right direction, like which
> function to debug and what it basically does, it would be helpful.

It could be that you are missing some convertor (eg pdf->png).
Turning on debuging messages for conversion could give you some hint
whats going on:
View->Messages Pane->Settings->Selected & turn on "graphics" & try to
insert pdf image.

> I am up for maintaining the windows installer, I will train that and see what
> I can do.

That would be truly helpful. I think Riki can point you to the most recent
documentation how installer is built, you might need to learn little bit about
NSIS.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-02 Thread Yu Jin
 Hi again, thank you for welcoming.
I have looked into this a bit more and got LyX to recognize Python, I had
to change some strings in the support static library for that, I will send
a diff file later and we can discuss that.
As for the development environment, I think that QT Creator is a good
choice. Visual Studio for example makes "Debug" and "Release" subfolders in
the "bin" folder, and because of that things get more complicated. Also you
can edit the UI elements in QT Creator. I could not manage to get into the
main window UI yet though, maybe you could tell me how it works?
As for the other issues I have described, here are a few updates of what I
found:
1. Seems to be a bug with QT Creator, see:
https://bugreports.qt.io/browse/QTCREATORBUG-23060.
3. As said I could resolve that.
4. Even though LyX finds Python, it still does not display inserted pdf
files (I guess that Python is used to display them). Maybe someone could
give me a hint on where to start looking? I have not had a chance to learn
Python yet. But if you could point me in the right direction, like which
function to debug and what it basically does, it would be helpful.

I will extend the windows guide once I get along with the Python issue. I
am up for maintaining the windows installer, I will train that and see what
I can do.

regards,
Eugene


Am Do., 2. Jan. 2020 um 16:32 Uhr schrieb Jürgen Spitzmüller :

> Am Donnerstag, den 02.01.2020, 13:26 +0100 schrieb Pavel Sanda:
> > Hi Eugene,
> >
> > welcome here.
>
> I second that! Welcome aboard.
>
> Alas I cannot help with your windows-specific problems either.
>
> Jürgen
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-02 Thread Jürgen Spitzmüller
Am Donnerstag, den 02.01.2020, 13:26 +0100 schrieb Pavel Sanda:
> Hi Eugene,
> 
> welcome here.

I second that! Welcome aboard.

Alas I cannot help with your windows-specific problems either.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Preparing for development

2020-01-02 Thread Pavel Sanda
On Sat, Dec 28, 2019 at 12:04:57PM +0100, Yu Jin wrote:
> I am using windows machine. For this project I thought to be using Qt
> creator. I just installed everything I need (described in the INSTALL.WIN32
> file) recently so the tools are on the newest version.
..
> Does anyone have experience with these tools and might give me a hint or
> two?

Hi Eugene,

welcome here.

We have almost no windows devs, so there will be rather small feedback
with windows specific questions, the more that you decided for a new
workflow (qt creator instead of visual studio).

So extending INSTALL.Win32 with section how to make things work with
qt creator could be your first contribution :)

Anyway, if you are somewhat profecient with windows we currently lack someone
who would help to maintain windows installer, if that sounds even remotely fun
to you :)

Cheers,
Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel