Re: file-fax
"Arnd Hanses" [EMAIL PROTECTED] writes: | And if you're wise you might consider adding a comment that explains | why this is standard conformant and why C-style coding style is frowned | upon :-) Because it is the standard? :-) Surely I could qoute section numbers, but would that really help? Besides it is at the surface that lyxstring is standard conformant. We are among other not using character traits. Lgb
Re: file->fax
"Arnd Hanses" <[EMAIL PROTECTED]> writes: | And if you're wise you might consider adding a comment that explains | why this is standard conformant and why C-style coding style is frowned | upon :-) Because it is the standard? :-) Surely I could qoute section numbers, but would that really help? Besides it is at the surface that lyxstring is standard conformant. We are among other not using character traits. Lgb
Re: file-fax
Lars Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: | Lars Juergen if (s *s) | | Juergen I already did this so, ... ;) Lars | | OK, it looks reasonable. It's ok to revert changes which are not optimal, but IMVO that if you revert changes which fix a bug then you should at least fix the bug also!!! Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug "May the forces of evil become confused on the way to your house." -- George Carlin -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file-fax
Juergen Vigna [EMAIL PROTECTED] writes: | | Lars Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: | | Lars Juergen if (s *s) | | Juergen I already did this so, ... ;) | Lars | | OK, it looks reasonable. | | | It's ok to revert changes which are not optimal, but IMVO that if you | revert changes which fix a bug then you should at least fix the bug | also!!! If it was obvious I would. I got the impression that the bug was in vspace.C, but a quick scan did not reveal it to me. But you should have fixed the bug correctly... Lgb
Re: file-fax
On 20-Oct-99 Lars Gullik Bjønnes wrote: If it was obvious I would. I got the impression that the bug was in vspace.C, but a quick scan did not reveal it to me. But you should have fixed the bug correctly... If I would have know what means correctly for you, then yes, but I'm no mindreader yet... Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug "I'd love to go out with you, but I'm doing door-to-door collecting for static cling." -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file-fax
Juergen Vigna [EMAIL PROTECTED] writes: | On 20-Oct-99 Lars Gullik Bjønnes wrote: | | If it was obvious I would. I got the impression that the bug was in | vspace.C, but a quick scan did not reveal it to me. | But you should have fixed the bug correctly... | | | If I would have know what means correctly for you, then yes, but I'm | no mindreader yet... A standard is a standard is a standard. (You dont change them you see...) Lgb
Re: file-fax
On 20-Oct-99 Lars Gullik Bjønnes wrote: | If I would have know what means correctly for you, then yes, but I'm | no mindreader yet... A standard is a standard is a standard. (You dont change them you see...) Why, so only people knowing all C++ standards should touch the lyx-code? So I've to retreat as developer as I surely won't go and read all that stuff (I really don't have the time for it)! (as of as Asger did yesterday giving me the right point to have a look instead of only crying around, and this surely does not mean that I read all the stuff I for myself just read the part regarding find_first_of...() stuff which was the part I was interested in!) Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug It's a small world, but I wouldn't want to have to paint it. -- Steven Wright -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file-fax
Juergen Vigna [EMAIL PROTECTED] writes: | Why, so only people knowing all C++ standards should touch the | lyx-code? No, only the part of the code that is written to follow a standard. Lgb
Re: file-fax
Juergen Vigna [EMAIL PROTECTED] writes: | Just to be curious, someone does compile lyx-devel with STL so that | lyxstring is not used? Could that person try to insert a lable in the | code from the menu Insert-Label and see what happens? You mean if it should crash or not :-) The standard uses this wording: "p shall not be a null pointer." So a string lib does not crash when a null is passed it is not standard conforming. We could of course write our code to be more "helpful", but then we would have a problem with standard compilant strings. Lgb
Re: file-fax
On 20-Oct-99 Lars Gullik Bjønnes wrote: Juergen Vigna [EMAIL PROTECTED] writes: | Just to be curious, someone does compile lyx-devel with STL so that | lyxstring is not used? Could that person try to insert a lable in the | code from the menu Insert-Label and see what happens? You mean if it should crash or not :-) The standard uses this wording: "p shall not be a null pointer." So a string lib does not crash when a null is passed it is not standard conforming. We could of course write our code to be more "helpful", but then we would have a problem with standard compilant strings. So the fix was not that wrong :), why not have the Assert only in development versions? Greets Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug For fools rush in where angels fear to tread. -- Alexander Pope -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file-fax
On 20-Oct-99 Lars Gullik Bjønnes wrote: Juergen Vigna [EMAIL PROTECTED] writes: | So the fix was not that wrong :), why not have the Assert only in | development versions? Yes it was that wrong! "shall not" under a requirements heading is pretty adamant. * smile * It still aborts and the STL library does not so what, maybe it's time you send this pretty bad developers a mail to remember them to follow the standard #:O) Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug A professor is one who talks in someone else's sleep. -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file-fax
Juergen Vigna [EMAIL PROTECTED] writes: | It still aborts and the STL library does not so what, maybe it's time | you send this pretty bad developers a mail to remember them to follow | the standard #:O) the STL library? what STL library? Lgb
Re: file-fax
On 19 Oct 1999 17:40:35 +0200, Lars Gullik Bj°nnes wrote: NO!! You have to check the standard before doing _ANY_ changes to lyxstring. | | I'll fix this now and if you don't like it then you (you is general not JMarc;) | can refix this and also all instances in the code where we allocate a string | like this with the warning never do this :) I will just put the Assert back in and remove other changes you have made to lyxstring. | If I would have know what means correctly for you, then yes, but I'm | no mindreader yet... And if you're wise you might consider adding a comment that explains why this is standard conformant and why C-style coding style is frowned upon :-) AH
Re: file->fax
On 19-Oct-99 Jean-Marc Lasgouttes wrote: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > > Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > Lars> Juergen> if (s && *s) | | Juergen> I already did this so, ... ;) > Lars> | | OK, it looks reasonable. > > Lars> No, it does not! > > I think we got the message :) I think too :) Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug Grub first, then ethics. -- Bertolt Brecht -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file->fax
>> >> Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | >> Lars> Juergen> if (s && *s) | | Juergen> I already did this so, ... ;) >> Lars> | | OK, it looks reasonable. >> It's ok to revert changes which are not optimal, but IMVO that if you revert changes which fix a bug then you should at least fix the bug also!!! Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug "May the forces of evil become confused on the way to your house." -- George Carlin -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file->fax
Juergen Vigna <[EMAIL PROTECTED]> writes: | >> | >> Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | | >> Lars> Juergen> if (s && *s) | | Juergen> I already did this so, ... ;) | >> Lars> | | OK, it looks reasonable. | >> | | It's ok to revert changes which are not optimal, but IMVO that if you | revert changes which fix a bug then you should at least fix the bug | also!!! If it was obvious I would. I got the impression that the bug was in vspace.C, but a quick scan did not reveal it to me. But you should have fixed the bug correctly... Lgb
Re: file->fax
On 20-Oct-99 Lars Gullik Bjønnes wrote: > > If it was obvious I would. I got the impression that the bug was in > vspace.C, but a quick scan did not reveal it to me. > But you should have fixed the bug correctly... > If I would have know what means correctly for you, then yes, but I'm no mindreader yet... Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug "I'd love to go out with you, but I'm doing door-to-door collecting for static cling." -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file->fax
Juergen Vigna <[EMAIL PROTECTED]> writes: | On 20-Oct-99 Lars Gullik Bjønnes wrote: | > | > If it was obvious I would. I got the impression that the bug was in | > vspace.C, but a quick scan did not reveal it to me. | > But you should have fixed the bug correctly... | > | | If I would have know what means correctly for you, then yes, but I'm | no mindreader yet... A standard is a standard is a standard. (You dont change them you see...) Lgb
Re: file->fax
On 20-Oct-99 Lars Gullik Bjønnes wrote: >| If I would have know what means correctly for you, then yes, but I'm >| no mindreader yet... > > A standard is a standard is a standard. > (You dont change them you see...) Why, so only people knowing all C++ standards should touch the lyx-code? So I've to retreat as developer as I surely won't go and read all that stuff (I really don't have the time for it)! (as of as Asger did yesterday giving me the right point to have a look instead of only crying around, and this surely does not mean that I read all the stuff I for myself just read the part regarding find_first_of...() stuff which was the part I was interested in!) Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug It's a small world, but I wouldn't want to have to paint it. -- Steven Wright -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file->fax
Juergen Vigna <[EMAIL PROTECTED]> writes: | Why, so only people knowing all C++ standards should touch the | lyx-code? No, only the part of the code that is written to follow a standard. Lgb
Re: file->fax
Juergen Vigna <[EMAIL PROTECTED]> writes: | Just to be curious, someone does compile lyx-devel with STL so that | lyxstring is not used? Could that person try to insert a lable in the | code from the menu Insert->Label and see what happens? You mean if it should crash or not :-) The standard uses this wording: "p shall not be a null pointer." So a string lib does not crash when a null is passed it is not standard conforming. We could of course write our code to be more "helpful", but then we would have a problem with standard compilant strings. Lgb
Re: file->fax
On 20-Oct-99 Lars Gullik Bjønnes wrote: > Juergen Vigna <[EMAIL PROTECTED]> writes: > >| Just to be curious, someone does compile lyx-devel with STL so that >| lyxstring is not used? Could that person try to insert a lable in the >| code from the menu Insert->Label and see what happens? > > You mean if it should crash or not :-) > > The standard uses this wording: "p shall not be a null pointer." > > So a string lib does not crash when a null is passed it is not > standard conforming. We could of course write our code to be more > "helpful", but then we would have a problem with standard compilant > strings. So the fix was not that wrong :), why not have the Assert only in development versions? Greets Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug For fools rush in where angels fear to tread. -- Alexander Pope -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file->fax
On 20-Oct-99 Lars Gullik Bjønnes wrote: > Juergen Vigna <[EMAIL PROTECTED]> writes: > >| So the fix was not that wrong :), why not have the Assert only in >| development versions? > > Yes it was that wrong! "shall not" under a requirements heading is > pretty adamant. * smile * It still aborts and the STL library does not so what, maybe it's time you send this pretty bad developers a mail to remember them to follow the standard #:O) Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug A professor is one who talks in someone else's sleep. -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file->fax
Juergen Vigna <[EMAIL PROTECTED]> writes: | It still aborts and the STL library does not so what, maybe it's time | you send this pretty bad developers a mail to remember them to follow | the standard #:O) the STL library? what STL library? Lgb
Re: file->fax
On 19 Oct 1999 17:40:35 +0200, Lars Gullik Bj°nnes wrote: >NO!! You have to check the standard before doing _ANY_ changes to >lyxstring. > >| >| I'll fix this now and if you don't like it then you (you is general not JMarc;) >| can refix this and also all instances in the code where we allocate a string >| like this with the warning never do this :) > >I will just put the Assert back in and remove other changes you have >made to lyxstring. | If I would have know what means correctly for you, then yes, but I'm | no mindreader yet... And if you're wise you might consider adding a comment that explains why this is standard conformant and why C-style coding style is frowned upon :-) AH
Re: file-fax
On 19-Oct-99 Jan Ulrich Hasecke wrote: CMD: faxspool '4' '/tmp/lyx_tmp22397aaa/lyx_bufrtmp22397aaa/Flyer-1.ps_tmp' /tmp/lyx_tmp22397aaa/lyx_bufrtmp22397aaa/FAX22397aaa 2/tmp/lyx_tmp22397aaa/lyx_bufrtmp22397aaa/FAX22397aaa There is a file in this directory, but it is called: Flyer_1.ps_tmp Why does lyx convert the "-" to "_" as it also does when I export something with a "-" inside a filename? I think this is the problem. Thank's this is exactly what I looked for :). This IS a bug and it should be solved! Did someone already apply the patch for this '-'-'_' problem? Otherwise I'll have a look. Really Lars we should fix this and the problem with xforms_0.89 and release a 1.0.4.1! Greets Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug enhance, v.: To tamper with an image, usually to its detriment. -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file-fax
"Juergen" == Juergen Vigna [EMAIL PROTECTED] writes: Juergen Thank's this is exactly what I looked for :). This IS a bug Juergen and it should be solved! Did someone already apply the patch Juergen for this '-'-'_' problem? Otherwise I'll have a look. This has not been fixed yet. However, this exposes another problem: you should use SpaceLess() on the file name to get them right (there are other characters---like spaces---which can be modified). Juergen Really Lars we should fix this and the problem with Juergen xforms_0.89 and release a 1.0.4.1! Not sure about this one. JMarc
Re: file-fax
On 19-Oct-99 Jean-Marc Lasgouttes wrote: "Juergen" == Juergen Vigna [EMAIL PROTECTED] writes: Juergen Thank's this is exactly what I looked for :). This IS a bug Juergen and it should be solved! Did someone already apply the patch Juergen for this '-'-'_' problem? Otherwise I'll have a look. This has not been fixed yet. However, this exposes another problem: you should use SpaceLess() on the file name to get them right (there are other characters---like spaces---which can be modified). Ok I'll have a look! Juergen Really Lars we should fix this and the problem with Juergen xforms_0.89 and release a 1.0.4.1! Not sure about this one. Ok then at least we should now stop inserting new stuff, fix the bugs and release the first 1.1.0 version :) I just discovered a new bug, try to insert a lable you get a abort! I traced this down to the lyxstring construtor and there is a command like: Assert(s); // we don't allow null pointers But then something like this is not possible: string str = ptr; // ptr could also be 0 but we always have to do something like: string str; if (ptr) str = ptr; I think this should be removed and there should be a check in the constructor which just does not initialize if the pointer is a 0 pointer! I'll fix this now and if you don't like it then you (you is general not JMarc;) can refix this and also all instances in the code where we allocate a string like this with the warning never do this :) Greets Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug Never trust anybody whose arm is bigger than your leg. -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file-fax
"Juergen" == Juergen Vigna [EMAIL PROTECTED] writes: Juergen Ok then at least we should now stop inserting new stuff, fix Juergen the bugs and release the first 1.1.0 version :) Yes, that's the right way. 1.1.1 should be out as soon as possible. If we take too much time, there will be an incentive to add new stuff to 1.0.4, and you know what the result is... Juergen I just discovered a new bug, try to insert a lable you get a Juergen abort! Juergen I traced this down to the lyxstring construtor and there is a Juergen command like: Juergen Assert(s); // we don't allow null pointers The assert is maybe not necessary. Lars? Juergen I think this should be removed and there should be a check in Juergen the constructor which just does not initialize if the pointer Juergen is a 0 pointer! You mean initialize to empty? JMarc
Re: file-fax
Juergen I think this should be removed and there should be a check in Juergen the constructor which just does not initialize if the pointer Juergen is a 0 pointer! You mean initialize to empty? No I mean remove the Assert() and change if (*s) to if (s *s) I already did this so, ... ;) Greets Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug "Boy, life takes a long time to live." -- Steven Wright -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file-fax
"Juergen" == Juergen Vigna [EMAIL PROTECTED] writes: Juergen I think this should be removed and there should be a check in Juergen the constructor which just does not initialize if the pointer Juergen is a 0 pointer! You mean initialize to empty? Juergen No I mean remove the Assert() and change Juergen if (*s) Juergen to Juergen if (s *s) Juergen I already did this so, ... ;) OK, it looks reasonable. JMarc
Re: file-fax
Juergen Vigna [EMAIL PROTECTED] writes: | Really Lars we should fix this and the problem with xforms_0.89 and | release a 1.0.4.1! 1.0.4.1 will not happen. Lgb
Re: file-fax
Juergen Vigna [EMAIL PROTECTED] writes: | No I mean remove the Assert() and change | | if (*s) | | to | | if (s *s) | | I already did this so, ... ;) Plain wrong. Lgb PS: I wonder if the mgs is getting through soon...
Re: file-fax
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: | Juergen Assert(s); // we don't allow null pointers | | The assert is maybe not necessary. Lars? It is very necessary! Lgb
Re: file-fax
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: | Juergen if (s *s) | | Juergen I already did this so, ... ;) | | OK, it looks reasonable. No, it does not! Lgb
Re: file-fax
"Lars" == Lars Gullik Bjønnes [EMAIL PROTECTED] writes: Lars Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: | Lars Juergen if (s *s) | | Juergen I already did this so, ... ;) Lars | | OK, it looks reasonable. Lars No, it does not! I think we got the message :) JMarc
Re: file->fax
On 19-Oct-99 Jan Ulrich Hasecke wrote: > CMD: faxspool '4' > '/tmp/lyx_tmp22397aaa/lyx_bufrtmp22397aaa/Flyer-1.ps_tmp' >>/tmp/lyx_tmp22397aaa/lyx_bufrtmp22397aaa/FAX22397aaa > 2>/tmp/lyx_tmp22397aaa/lyx_bufrtmp22397aaa/FAX22397aaa > > There is a file in this directory, but it is called: > Flyer_1.ps_tmp > > Why does lyx convert the "-" to "_" as it also does when I export > something with a "-" inside a filename? I think this is the > problem. Thank's this is exactly what I looked for :). This IS a bug and it should be solved! Did someone already apply the patch for this '-'->'_' problem? Otherwise I'll have a look. Really Lars we should fix this and the problem with xforms_0.89 and release a 1.0.4.1! Greets Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug enhance, v.: To tamper with an image, usually to its detriment. -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file->fax
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> Thank's this is exactly what I looked for :). This IS a bug Juergen> and it should be solved! Did someone already apply the patch Juergen> for this '-'->'_' problem? Otherwise I'll have a look. This has not been fixed yet. However, this exposes another problem: you should use SpaceLess() on the file name to get them right (there are other characters---like spaces---which can be modified). Juergen> Really Lars we should fix this and the problem with Juergen> xforms_0.89 and release a 1.0.4.1! Not sure about this one. JMarc
Re: file->fax
On 19-Oct-99 Jean-Marc Lasgouttes wrote: >> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: > > Juergen> Thank's this is exactly what I looked for :). This IS a bug > Juergen> and it should be solved! Did someone already apply the patch > Juergen> for this '-'->'_' problem? Otherwise I'll have a look. > > This has not been fixed yet. However, this exposes another problem: > you should use SpaceLess() on the file name to get them right (there > are other characters---like spaces---which can be modified). > Ok I'll have a look! > Juergen> Really Lars we should fix this and the problem with > Juergen> xforms_0.89 and release a 1.0.4.1! > > Not sure about this one. Ok then at least we should now stop inserting new stuff, fix the bugs and release the first 1.1.0 version :) I just discovered a new bug, try to insert a lable you get a abort! I traced this down to the lyxstring construtor and there is a command like: Assert(s); // we don't allow null pointers But then something like this is not possible: string str = ptr; // ptr could also be 0 but we always have to do something like: string str; if (ptr) str = ptr; I think this should be removed and there should be a check in the constructor which just does not initialize if the pointer is a 0 pointer! I'll fix this now and if you don't like it then you (you is general not JMarc;) can refix this and also all instances in the code where we allocate a string like this with the warning never do this :) Greets Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug Never trust anybody whose arm is bigger than your leg. -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file->fax
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> Ok then at least we should now stop inserting new stuff, fix Juergen> the bugs and release the first 1.1.0 version :) Yes, that's the right way. 1.1.1 should be out as soon as possible. If we take too much time, there will be an incentive to add new stuff to 1.0.4, and you know what the result is... Juergen> I just discovered a new bug, try to insert a lable you get a Juergen> abort! Juergen> I traced this down to the lyxstring construtor and there is a Juergen> command like: Juergen> Assert(s); // we don't allow null pointers The assert is maybe not necessary. Lars? Juergen> I think this should be removed and there should be a check in Juergen> the constructor which just does not initialize if the pointer Juergen> is a 0 pointer! You mean initialize to empty? JMarc
Re: file->fax
> > Juergen> I think this should be removed and there should be a check in > Juergen> the constructor which just does not initialize if the pointer > Juergen> is a 0 pointer! > > You mean initialize to empty? No I mean remove the Assert() and change if (*s) to if (s && *s) I already did this so, ... ;) Greets Jürgen -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED] Gerbergasse 60Tel:+39-0471-450260 I-39100 Bozen Fax:+39-0471-970042 ITALY Web:http://www.sad.it/~jug "Boy, life takes a long time to live." -- Steven Wright -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Re: file->fax
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: >> Juergen> I think this should be removed and there should be a check in Juergen> the constructor which just does not initialize if the pointer Juergen> is a 0 pointer! >> You mean initialize to empty? Juergen> No I mean remove the Assert() and change Juergen> if (*s) Juergen> to Juergen> if (s && *s) Juergen> I already did this so, ... ;) OK, it looks reasonable. JMarc
Re: file->fax
Juergen Vigna <[EMAIL PROTECTED]> writes: | Really Lars we should fix this and the problem with xforms_0.89 and | release a 1.0.4.1! 1.0.4.1 will not happen. Lgb
Re: file->fax
Juergen Vigna <[EMAIL PROTECTED]> writes: | Assert(s); // we don't allow null pointers Excatly what the standard says. | But then something like this is not possible: | | string str = ptr; // ptr could also be 0 yes, and this should fail. | but we always have to do something like: | | string str; | | if (ptr) str = ptr; Yes. | I think this should be removed and there should be a check in the constructor | which just does not initialize if the pointer is a 0 pointer! NO!! You have to check the standard before doing _ANY_ changes to lyxstring. | | I'll fix this now and if you don't like it then you (you is general not JMarc;) | can refix this and also all instances in the code where we allocate a string | like this with the warning never do this :) I will just put the Assert back in and remove other changes you have made to lyxstring. Lgb
Re: file->fax
Juergen Vigna <[EMAIL PROTECTED]> writes: | No I mean remove the Assert() and change | | if (*s) | | to | | if (s && *s) | | I already did this so, ... ;) Plain wrong. Lgb PS: I wonder if the mgs is getting through soon...
Re: file->fax
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Juergen> Assert(s); // we don't allow null pointers | | The assert is maybe not necessary. Lars? It is very necessary! Lgb
Re: file->fax
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Juergen> if (s && *s) | | Juergen> I already did this so, ... ;) | | OK, it looks reasonable. No, it does not! Lgb
Re: file->fax
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Lars> Juergen> if (s && *s) | | Juergen> I already did this so, ... ;) Lars> | | OK, it looks reasonable. Lars> No, it does not! I think we got the message :) JMarc
