Re: ams starred environments

2009-06-06 Thread Jürgen Spitzmüller
Russ Woodroofe wrote:
 In any case, it looks closer to the output.

I committed it.

Jürgen


Re: ams starred environments

2009-06-06 Thread Jürgen Spitzmüller
Russ Woodroofe wrote:
> In any case, it looks closer to the output.

I committed it.

Jürgen


Re: ams starred environments

2009-06-05 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote:
Dear lyx developers,
Attached is a diff -u patch fixing a small display bug in the AMS
  article layout, where starred Section, Subsections, etc are not
  displayed correctly.  I fixed it by repeating the modification of
  Sections.
The AMS book layout file seems to have a similar problem, which I
  have taken the liberty of fixing as well.

 This is just a cosmetic change that cannot harm, I think (although I think
 the changes should come after Input stdstarsections.inc).

The attached patch has some minor modifications to amsbook:

* load stdstarsections.inc before the star section redefinitions
* At least here, section and section* is bold in the output, not small caps. I 
adapted both definitions

And one question. Is this definition (in amsbook) really correct?

# Chapter is _not_ prepended
Style Section
LabelString  \arabic{section}
LabelStringAppendix  \arabic{section}
End

At least here, chapter actually _is_ prepended in the output.

Russ, could you check this please, I do not use AMS myself.

Jürgen
Index: lib/layouts/amsbook.layout
===
--- lib/layouts/amsbook.layout	(Revision 29942)
+++ lib/layouts/amsbook.layout	(Arbeitskopie)
@@ -50,8 +50,7 @@
 Style Section
 	Align Center
 	Font
-	  Series  Medium
-	  Shape   Smallcaps
+	  Series  Bold
 	  SizeLarge
 	EndFont
 End
@@ -74,6 +73,33 @@
 
 
 Input stdstarsections.inc
+
+
+Style Section*
+	Align Center
+	Font
+	  Series  Bold
+	  SizeLarge
+	EndFont
+End
+
+
+Style Subsection*
+	Font
+	  Series  Bold
+	  SizeNormal
+	EndFont
+End
+
+
+Style Subsubsection*
+	Font
+	  Shape   Italic
+	  SizeNormal
+	EndFont
+End
+
+
 Input lyxmacros.inc
 Input stdlayouts.inc
 Input stdlists.inc
Index: lib/layouts/amsart.layout
===
--- lib/layouts/amsart.layout	(Revision 29942)
+++ lib/layouts/amsart.layout	(Arbeitskopie)
@@ -71,6 +71,16 @@
 End
 
 
+Style Section*
+	Align Center
+	Font
+	  Series  Medium
+	  Shape   Smallcaps
+	  SizeLarge
+	EndFont
+End
+
+
 Style Subsection
 	Font
 	  Series  Bold
@@ -79,9 +89,25 @@
 End
 
 
+Style Subsection*
+	Font
+	  Series  Bold
+	  SizeNormal
+	EndFont
+End
+
+
 Style Subsubsection
 	Font
 	  Shape   Italic
 	  SizeNormal
 	EndFont
 End
+
+
+Style Subsubsection*
+	Font
+	  Shape   Italic
+	  SizeNormal
+	EndFont
+End


Re: ams starred environments

2009-06-05 Thread rgheck

Jürgen Spitzmüller wrote:

And one question. Is this definition (in amsbook) really correct?

# Chapter is _not_ prepended
Style Section
LabelString  \arabic{section}
LabelStringAppendix  \arabic{section}
End

At least here, chapter actually _is_ prepended in the output.

  

I get it prepended, too.

rh



Re: ams starred environments

2009-06-05 Thread Russ Woodroofe



Dear Jürgen, all,
	I'm pretty sure that the comment Chapter is _not_ prepended should  
be Section is _not_ prepended.  That makes a lot more sense, as  
Section isn't prepended, and especially as it comes just before the  
definition of the Section environment.


	There was also another small formatting error -- Section numbers are  
rendered as 1.1 in amsbook (or A.1 in the appendix).


	I do use AMS article, and one of my papers looked fine in it.  I've  
never used AMS book -- while it's closely related, there may be  
someone who knows it better.


To summarize:
== No changes to amsart.layout
== In amsbook.layout, apply patch below (against stock 1.6.2 file)
* fixes comment error (chapter vs section)
* prepends chapter number to section number in LyX display, more  
closely matching the latex output


	I've also attached a LyX file that tries to put AMS book through its  
paces (with starred and unstarred chapters and an appendix).  I found  
it not quite trivial to figure out everything that needed to be  
tested, and anyway, it's small.


Sincerely,

--Russ



amsbook-rsw2.patch
Description: Binary data


booktest.lyx
Description: Binary data


On Jun 5, 2009, at 6:35 AM, Jürgen Spitzmüller wrote:


Jürgen Spitzmüller wrote:

 Dear lyx developers,
 Attached is a diff -u patch fixing a small display bug in  
the AMS

article layout, where starred Section, Subsections, etc are not
displayed correctly.  I fixed it by repeating the modification of
Sections.
 The AMS book layout file seems to have a similar problem,  
which I

have taken the liberty of fixing as well.


This is just a cosmetic change that cannot harm, I think (although  
I think

the changes should come after Input stdstarsections.inc).


The attached patch has some minor modifications to amsbook:

* load stdstarsections.inc before the star section redefinitions
* At least here, section and section* is bold in the output, not  
small caps. I

adapted both definitions

And one question. Is this definition (in amsbook) really correct?

# Chapter is _not_ prepended
Style Section
LabelString  \arabic{section}
LabelStringAppendix  \arabic{section}
End

At least here, chapter actually _is_ prepended in the output.

Russ, could you check this please, I do not use AMS myself.

Jürgen
ams.diff




Re: ams starred environments

2009-06-05 Thread rgheck

Russ Woodroofe wrote:
I'm pretty sure that the comment Chapter is _not_ prepended 
should be Section is _not_ prepended.  That makes a lot more sense, 
as Section isn't prepended, and especially as it comes just before the 
definition of the Section environment.


No, I think what they meant was what they said, that the chapter number 
does not appear before the section number in a section heading. It's 
just that this is wrong now, so I think you can just remove the comment 
altogether, now that it's fixed.


There was also another small formatting error -- Section numbers 
are rendered as 1.1 in amsbook (or A.1 in the appendix).



This is what's wrong with the comment.

Richard



Re: ams starred environments

2009-06-05 Thread Jürgen Spitzmüller
Russ Woodroofe wrote:
 I'm pretty sure that the comment Chapter is not prepended should  
 be Section is not prepended.  That makes a lot more sense, as  
 Section isn't prepended, and especially as it comes just before the  
 definition of the Section environment.

 There was also another small formatting error -- Section numbers
 are   rendered as 1.1 in amsbook (or A.1 in the appendix).

Actually, this is one and the same problem, IMHO (Chapter is not prepended 
refers to the chapter number, not the word chapter) -- at least it is the 
problem I was referring to. If you delete this whole statement, everything 
should be OK. I.e.

-# Chapter is _not_ prepended
- Style Section
-   LabelString  \arabic{section}
-   LabelStringAppendix  \arabic{section}
- End

Jürgen


Re: ams starred environments

2009-06-05 Thread Russ Woodroofe



	Well, the LyX formatting matches the output in this case, anyway,  
unless I'm overlooking something.  Perhaps the AMS has changed the  
style since the earlier days of LyX?
	In any case, it looks closer to the output.  And as you say, it's  
cosmetic, so unlikely to cause crashes.

Best,

--Russ

On Jun 5, 2009, at 10:52 AM, Jürgen Spitzmüller wrote:


Russ Woodroofe wrote:

I'm pretty sure that the comment Chapter is not prepended should
be Section is not prepended.  That makes a lot more sense, as
Section isn't prepended, and especially as it comes just before the
definition of the Section environment.

   There was also another small formatting error -- Section  
numbers

are   rendered as 1.1 in amsbook (or A.1 in the appendix).


Actually, this is one and the same problem, IMHO (Chapter is not  
prepended
refers to the chapter number, not the word chapter) -- at least it  
is the
problem I was referring to. If you delete this whole statement,  
everything

should be OK. I.e.

-# Chapter is _not_ prepended
- Style Section
-   LabelString  \arabic{section}
-   LabelStringAppendix  \arabic{section}
- End

Jürgen




Re: ams starred environments

2009-06-05 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote:
> >   Dear lyx developers,
> >   Attached is a "diff -u" patch fixing a small display bug in the AMS
> > article layout, where starred Section, Subsections, etc are not
> > displayed correctly.  I fixed it by repeating the modification of
> > Sections.
> >   The AMS book layout file seems to have a similar problem, which I
> > have taken the liberty of fixing as well.
>
> This is just a cosmetic change that cannot harm, I think (although I think
> the changes should come after "Input stdstarsections.inc").

The attached patch has some minor modifications to amsbook:

* load stdstarsections.inc before the star section redefinitions
* At least here, section and section* is bold in the output, not small caps. I 
adapted both definitions

And one question. Is this definition (in amsbook) really correct?

# Chapter is _not_ prepended
Style Section
LabelString  "\arabic{section}"
LabelStringAppendix  "\arabic{section}"
End

At least here, chapter actually _is_ prepended in the output.

Russ, could you check this please, I do not use AMS myself.

Jürgen
Index: lib/layouts/amsbook.layout
===
--- lib/layouts/amsbook.layout	(Revision 29942)
+++ lib/layouts/amsbook.layout	(Arbeitskopie)
@@ -50,8 +50,7 @@
 Style Section
 	Align Center
 	Font
-	  Series  Medium
-	  Shape   Smallcaps
+	  Series  Bold
 	  SizeLarge
 	EndFont
 End
@@ -74,6 +73,33 @@
 
 
 Input stdstarsections.inc
+
+
+Style Section*
+	Align Center
+	Font
+	  Series  Bold
+	  SizeLarge
+	EndFont
+End
+
+
+Style Subsection*
+	Font
+	  Series  Bold
+	  SizeNormal
+	EndFont
+End
+
+
+Style Subsubsection*
+	Font
+	  Shape   Italic
+	  SizeNormal
+	EndFont
+End
+
+
 Input lyxmacros.inc
 Input stdlayouts.inc
 Input stdlists.inc
Index: lib/layouts/amsart.layout
===
--- lib/layouts/amsart.layout	(Revision 29942)
+++ lib/layouts/amsart.layout	(Arbeitskopie)
@@ -71,6 +71,16 @@
 End
 
 
+Style Section*
+	Align Center
+	Font
+	  Series  Medium
+	  Shape   Smallcaps
+	  SizeLarge
+	EndFont
+End
+
+
 Style Subsection
 	Font
 	  Series  Bold
@@ -79,9 +89,25 @@
 End
 
 
+Style Subsection*
+	Font
+	  Series  Bold
+	  SizeNormal
+	EndFont
+End
+
+
 Style Subsubsection
 	Font
 	  Shape   Italic
 	  SizeNormal
 	EndFont
 End
+
+
+Style Subsubsection*
+	Font
+	  Shape   Italic
+	  SizeNormal
+	EndFont
+End


Re: ams starred environments

2009-06-05 Thread rgheck

Jürgen Spitzmüller wrote:

And one question. Is this definition (in amsbook) really correct?

# Chapter is _not_ prepended
Style Section
LabelString  "\arabic{section}"
LabelStringAppendix  "\arabic{section}"
End

At least here, chapter actually _is_ prepended in the output.

  

I get it prepended, too.

rh



Re: ams starred environments

2009-06-05 Thread Russ Woodroofe



Dear Jürgen, all,
	I'm pretty sure that the comment "Chapter is _not_ prepended" should  
be "Section is _not_ prepended".  That makes a lot more sense, as  
Section isn't prepended, and especially as it comes just before the  
definition of the Section environment.


	There was also another small formatting error -- Section numbers are  
rendered as 1.1 in amsbook (or A.1 in the appendix).


	I do use AMS article, and one of my papers looked fine in it.  I've  
never used AMS book -- while it's closely related, there may be  
someone who knows it better.


To summarize:
== No changes to amsart.layout
== In amsbook.layout, apply patch below (against stock 1.6.2 file)
* fixes comment error (chapter vs section)
* prepends chapter number to section number in LyX display, more  
closely matching the latex output


	I've also attached a LyX file that tries to put AMS book through its  
paces (with starred and unstarred chapters and an appendix).  I found  
it not quite trivial to figure out everything that needed to be  
tested, and anyway, it's small.


Sincerely,

--Russ



amsbook-rsw2.patch
Description: Binary data


booktest.lyx
Description: Binary data


On Jun 5, 2009, at 6:35 AM, Jürgen Spitzmüller wrote:


Jürgen Spitzmüller wrote:

 Dear lyx developers,
 Attached is a "diff -u" patch fixing a small display bug in  
the AMS

article layout, where starred Section, Subsections, etc are not
displayed correctly.  I fixed it by repeating the modification of
Sections.
 The AMS book layout file seems to have a similar problem,  
which I

have taken the liberty of fixing as well.


This is just a cosmetic change that cannot harm, I think (although  
I think

the changes should come after "Input stdstarsections.inc").


The attached patch has some minor modifications to amsbook:

* load stdstarsections.inc before the star section redefinitions
* At least here, section and section* is bold in the output, not  
small caps. I

adapted both definitions

And one question. Is this definition (in amsbook) really correct?

# Chapter is _not_ prepended
Style Section
LabelString  "\arabic{section}"
LabelStringAppendix  "\arabic{section}"
End

At least here, chapter actually _is_ prepended in the output.

Russ, could you check this please, I do not use AMS myself.

Jürgen





Re: ams starred environments

2009-06-05 Thread rgheck

Russ Woodroofe wrote:
I'm pretty sure that the comment "Chapter is _not_ prepended" 
should be "Section is _not_ prepended".  That makes a lot more sense, 
as Section isn't prepended, and especially as it comes just before the 
definition of the Section environment.


No, I think what they meant was what they said, that the chapter number 
does not appear before the section number in a section heading. It's 
just that this is wrong now, so I think you can just remove the comment 
altogether, now that it's fixed.


There was also another small formatting error -- Section numbers 
are rendered as 1.1 in amsbook (or A.1 in the appendix).



This is what's wrong with the comment.

Richard



Re: ams starred environments

2009-06-05 Thread Jürgen Spitzmüller
Russ Woodroofe wrote:
> I'm pretty sure that the comment "Chapter is not prepended" should  
> be "Section is not prepended".  That makes a lot more sense, as  
> Section isn't prepended, and especially as it comes just before the  
> definition of the Section environment.
>
> There was also another small formatting error -- Section numbers
> are   rendered as 1.1 in amsbook (or A.1 in the appendix).

Actually, this is one and the same problem, IMHO ("Chapter is not prepended" 
refers to the chapter number, not the word "chapter") -- at least it is the 
problem I was referring to. If you delete this whole statement, everything 
should be OK. I.e.

-# Chapter is _not_ prepended
- Style Section
-   LabelString  "\arabic{section}"
-   LabelStringAppendix  "\arabic{section}"
- End

Jürgen


Re: ams starred environments

2009-06-05 Thread Russ Woodroofe



	Well, the LyX formatting matches the output in this case, anyway,  
unless I'm overlooking something.  Perhaps the AMS has changed the  
style since the earlier days of LyX?
	In any case, it looks closer to the output.  And as you say, it's  
cosmetic, so unlikely to cause crashes.

Best,

--Russ

On Jun 5, 2009, at 10:52 AM, Jürgen Spitzmüller wrote:


Russ Woodroofe wrote:

I'm pretty sure that the comment "Chapter is not prepended" should
be "Section is not prepended".  That makes a lot more sense, as
Section isn't prepended, and especially as it comes just before the
definition of the Section environment.

   There was also another small formatting error -- Section  
numbers

are   rendered as 1.1 in amsbook (or A.1 in the appendix).


Actually, this is one and the same problem, IMHO ("Chapter is not  
prepended"
refers to the chapter number, not the word "chapter") -- at least it  
is the
problem I was referring to. If you delete this whole statement,  
everything

should be OK. I.e.

-# Chapter is _not_ prepended
- Style Section
-   LabelString  "\arabic{section}"
-   LabelStringAppendix  "\arabic{section}"
- End

Jürgen




Re: ams starred environments

2009-06-01 Thread Jürgen Spitzmüller
Russ Woodroofe wrote:
   Dear lyx developers,
   Attached is a diff -u patch fixing a small display bug in the AMS
 article layout, where starred Section, Subsections, etc are not
 displayed correctly.  I fixed it by repeating the modification of
 Sections.
   The AMS book layout file seems to have a similar problem, which I
 have taken the liberty of fixing as well.

This is just a cosmetic change that cannot harm, I think (although I think the 
changes should come after Input stdstarsections.inc).

However, we are just facing 1.6.3, so this will have to wait a bit (until 
1.6.4svn is open for commits).

Jürgen


Re: ams starred environments

2009-06-01 Thread Jürgen Spitzmüller
Russ Woodroofe wrote:
>   Dear lyx developers,
>   Attached is a "diff -u" patch fixing a small display bug in the AMS
> article layout, where starred Section, Subsections, etc are not
> displayed correctly.  I fixed it by repeating the modification of
> Sections.
>   The AMS book layout file seems to have a similar problem, which I
> have taken the liberty of fixing as well.

This is just a cosmetic change that cannot harm, I think (although I think the 
changes should come after "Input stdstarsections.inc").

However, we are just facing 1.6.3, so this will have to wait a bit (until 
1.6.4svn is open for commits).

Jürgen


ams starred environments

2009-05-29 Thread Russ Woodroofe



Dear lyx developers,
	Attached is a diff -u patch fixing a small display bug in the AMS  
article layout, where starred Section, Subsections, etc are not  
displayed correctly.  I fixed it by repeating the modification of  
Sections.
	The AMS book layout file seems to have a similar problem, which I  
have taken the liberty of fixing as well.


	An example where this comes up:  I myself frequently use a starred  
section for acknowledgements in papers.  I've always found the  
different style jarring.


Two questions out of this:
1.  The AMS article file removes the Paragraph and Subparagraph  
environments, but leaves their starred versions.  Code to remove the  
starred versions is commented out.  It seems to me like this should be  
consistent.  Am I wrong?


2.  I don't use many other layout files, but a quick grep makes it  
look like the following layout files probably have the same problem:

aa.layout
aapaper.layout
aastex.layout
agu_stdsections.inc (??)
llncs.layout
ltugboat.layout
manpage.layout
memoir.layout
moderncv.layout (??)
numrevtex.layout
revtex.layout
revtex4.layout
scrclass.layout
siamltex.layout
simplecv.layout (??)
svjour.inc
	This is just the result of a grep Style Section * | less, with some  
obvious ones filtered out.  I don't actually use any of these -- I  
defer to the experts.  (I don't actually use AMS book, either, but I'm  
pretty confident on that one.)

Sincerely,

--Russ Woodroofe



amsart.patch
Description: Binary data


amsbook.patch
Description: Binary data





ams starred environments

2009-05-29 Thread Russ Woodroofe



Dear lyx developers,
	Attached is a "diff -u" patch fixing a small display bug in the AMS  
article layout, where starred Section, Subsections, etc are not  
displayed correctly.  I fixed it by repeating the modification of  
Sections.
	The AMS book layout file seems to have a similar problem, which I  
have taken the liberty of fixing as well.


	An example where this comes up:  I myself frequently use a starred  
section for acknowledgements in papers.  I've always found the  
different style jarring.


Two questions out of this:
1.  The AMS article file removes the Paragraph and Subparagraph  
environments, but leaves their starred versions.  Code to remove the  
starred versions is commented out.  It seems to me like this should be  
consistent.  Am I wrong?


2.  I don't use many other layout files, but a quick grep makes it  
look like the following layout files probably have the same problem:

aa.layout
aapaper.layout
aastex.layout
agu_stdsections.inc (??)
llncs.layout
ltugboat.layout
manpage.layout
memoir.layout
moderncv.layout (??)
numrevtex.layout
revtex.layout
revtex4.layout
scrclass.layout
siamltex.layout
simplecv.layout (??)
svjour.inc
	This is just the result of a grep "Style Section" * | less, with some  
obvious ones filtered out.  I don't actually use any of these -- I  
defer to the experts.  (I don't actually use AMS book, either, but I'm  
pretty confident on that one.)

Sincerely,

--Russ Woodroofe



amsart.patch
Description: Binary data


amsbook.patch
Description: Binary data