Re: filename with space truncated n external insets dialog

[Jean-Marc Lasgouttes]

> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:

Georg> Bernhard Roider wrote:
>> Hello!
>> 
>> The attached patch fixes the problem in trunk. The problem was that
>> for
Georg> the filename one token was
>> retrieved from the lexer instead of the whole remaining line.

Georg> Thanks a lot. The fix is correct (the same code is used in
Georg> InsetGraphicsParams::Read), and I put it in.

Georg> Jean-Marc, I guess this is for 1.4.4, too?

Yes, please.

JMarc

Re: filename with space truncated n external insets dialog

[Georg Baum]

Bernhard Roider wrote:

> Hello!
> 
> The attached patch fixes the problem in trunk. The problem was that for
the filename one token was 
> retrieved from the lexer instead of the whole remaining line.

Thanks a lot. The fix is correct (the same code is used in
InsetGraphicsParams::Read), and I put it in.

Jean-Marc, I guess this is for 1.4.4, too?

> PS: I think the preferred way for contributing should be via a bug report?

The mailing list is fine, especially if something requires discussion. It
can happen that people are too busy with other stuff to answer. In that
case use bugzilla to make sure that nothing gets forgotten. Christian
Ridderström sent a better summary on friday. Is it on the wiki yet?


Georgg

Re: filename with space truncated n external insets dialog

[Bernhard Roider]

by the way 1.4.2 and 1.4.3 (that's all i have installed) also truncate the filename, but i have no 
source at my pc

Re: filename with space truncated n external insets dialog

[Bernhard Roider]

Hello!

The attached patch fixes the problem in trunk. The problem was that for the filename one token was 
retrieved from the lexer instead of the whole remaining line.


Bernhard

PS: I think the preferred way for contributing should be via a bug report?

Abdelrazak Younes wrote:

Bernhard Roider wrote:

hi!

first of all: i took a look at 1.5.0 svn and i think it will be a 
great piece of software!


i just recognized that if in the external insets dialog a file name 
containing a space is inserted (or selected with the file open dialog) 
then the name is truncated at the space character after pressing ok.



Confirmed. I guess the problem is in InsetExternalMailer::string2params().

Abdel.




Index: src/insets/insetexternal.C
===
--- src/insets/insetexternal.C  (revision 16795)
+++ src/insets/insetexternal.C  (working copy)
@@ -290,7 +290,7 @@
break;
 
case EX_FILENAME: {
-   lex.next();
+   lex.eatLine();
string const name = lex.getString();
filename.set(name, buffer.filePath());
break;

Re: filename with space truncated n external insets dialog

[Abdelrazak Younes]

Bernhard Roider wrote:

hi!

first of all: i took a look at 1.5.0 svn and i think it will be a great 
piece of software!


i just recognized that if in the external insets dialog a file name 
containing a space is inserted (or selected with the file open dialog) 
then the name is truncated at the space character after pressing ok.



Confirmed. I guess the problem is in InsetExternalMailer::string2params().

Abdel.

filename with space truncated n external insets dialog

[Bernhard Roider]

hi!

first of all: i took a look at 1.5.0 svn and i think it will be a great piece 
of software!

i just recognized that if in the external insets dialog a file name containing a space is inserted 
(or selected with the file open dialog) then the name is truncated at the space character after 
pressing ok.


bernhard