Re: middle-button paste no longer works properly
Can I revert this patch shortly? I like my working dir to be in sync with the repository. Is it possible this needs to be propagated from trunk to 1.5 branch? Is this in trunk or branch? If things work OK after you revert, I have my OK. (Make sure to test middle paste within and between table and formula as well). Bo Have fun, Darren Index: src/insets/InsetTabular.cpp === --- src/insets/InsetTabular.cpp (revision 19221) +++ src/insets/InsetTabular.cpp (working copy) @@ -3490,6 +3490,7 @@ cell(cur.idx())-dispatch(cur, cmd); break; } + theSelection().haveSelection(bvcur.selection()); } Index: src/Text3.cpp === --- src/Text3.cpp (revision 19221) +++ src/Text3.cpp (working copy) @@ -1586,6 +1586,7 @@ } needsUpdate |= (cur.pos() != cur.lastpos()) cur.selection(); + theSelection().haveSelection(bv-cursor().selection()); // FIXME: The cursor flag is reset two lines below // so we need to check here if some of the LFUN did touch that.
Re: middle-button paste no longer works properly
On Mon, 2007-08-20 at 08:54 -0500, Bo Peng wrote: Can I revert this patch shortly? I like my working dir to be in sync with the repository. Is it possible this needs to be propagated from trunk to 1.5 branch? Is this in trunk or branch? If things work OK after you revert, I have my OK. (Make sure to test middle paste within and between table and formula as well). I'm currently using the 1.5 branch with your patch. I don't think I've done a lot of middle-click pasting with tables and formulae so I should check first. I'm grappling with the incredible slowness problem mainly so I don't tend to notice the bugs anymore as I'm barely getting any work done. Have fun, Darren
Re: middle-button paste no longer works properly
> Can I revert this patch shortly? I like my working dir to be in sync > with the repository. Is it possible this needs to be propagated from > trunk to 1.5 branch? Is this in trunk or branch? If things work OK after you revert, I have my OK. (Make sure to test middle paste within and between table and formula as well). Bo > > Have fun, > Darren > > Index: src/insets/InsetTabular.cpp > === > --- src/insets/InsetTabular.cpp (revision 19221) > +++ src/insets/InsetTabular.cpp (working copy) > @@ -3490,6 +3490,7 @@ > cell(cur.idx())->dispatch(cur, cmd); > break; > } > + theSelection().haveSelection(bvcur.selection()); > } > > > Index: src/Text3.cpp > === > --- src/Text3.cpp (revision 19221) > +++ src/Text3.cpp (working copy) > @@ -1586,6 +1586,7 @@ > } > > needsUpdate |= (cur.pos() != cur.lastpos()) && cur.selection(); > + theSelection().haveSelection(bv->cursor().selection()); > > // FIXME: The cursor flag is reset two lines below > // so we need to check here if some of the LFUN did touch that. > > >
Re: middle-button paste no longer works properly
On Mon, 2007-08-20 at 08:54 -0500, Bo Peng wrote: > > Can I revert this patch shortly? I like my working dir to be in sync > > with the repository. Is it possible this needs to be propagated from > > trunk to 1.5 branch? > > Is this in trunk or branch? If things work OK after you revert, I have > my OK. (Make sure to test middle paste within and between table and > formula as well). I'm currently using the 1.5 branch with your patch. I don't think I've done a lot of middle-click pasting with tables and formulae so I should check first. I'm grappling with the incredible slowness problem mainly so I don't tend to notice the bugs anymore as I'm barely getting any work done. Have fun, Darren
Re: middle-button paste no longer works properly
On Thu, 2007-07-26 at 23:04 -0500, Bo Peng wrote: On 7/26/07, Bo Peng [EMAIL PROTECTED] wrote: Going the other way is even worse - mark something in LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. Could you please test the attached patch? JMarc and I tried to move numerous haveSelection calls to some 'source' locations, and we obviously missed some cases. I have been testing in the 1.5.x-svn for a while and whilst I haven't checked if it is a complete fix, I haven't had any new problems either. Can I revert this patch shortly? I like my working dir to be in sync with the repository. Is it possible this needs to be propagated from trunk to 1.5 branch? Have fun, Darren Index: src/insets/InsetTabular.cpp === --- src/insets/InsetTabular.cpp (revision 19221) +++ src/insets/InsetTabular.cpp (working copy) @@ -3490,6 +3490,7 @@ cell(cur.idx())-dispatch(cur, cmd); break; } + theSelection().haveSelection(bvcur.selection()); } Index: src/Text3.cpp === --- src/Text3.cpp (revision 19221) +++ src/Text3.cpp (working copy) @@ -1586,6 +1586,7 @@ } needsUpdate |= (cur.pos() != cur.lastpos()) cur.selection(); + theSelection().haveSelection(bv-cursor().selection()); // FIXME: The cursor flag is reset two lines below // so we need to check here if some of the LFUN did touch that.
Re: middle-button paste no longer works properly
On Thu, 2007-07-26 at 23:04 -0500, Bo Peng wrote: > On 7/26/07, Bo Peng <[EMAIL PROTECTED]> wrote: > > > Going the other way is even worse - mark something in > > > LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. > > Could you please test the attached patch? > > JMarc and I tried to move numerous haveSelection calls to some > 'source' locations, and we obviously missed some cases. I have been testing in the 1.5.x-svn for a while and whilst I haven't checked if it is a complete fix, I haven't had any new problems either. Can I revert this patch shortly? I like my working dir to be in sync with the repository. Is it possible this needs to be propagated from trunk to 1.5 branch? Have fun, Darren Index: src/insets/InsetTabular.cpp === --- src/insets/InsetTabular.cpp (revision 19221) +++ src/insets/InsetTabular.cpp (working copy) @@ -3490,6 +3490,7 @@ cell(cur.idx())->dispatch(cur, cmd); break; } + theSelection().haveSelection(bvcur.selection()); } Index: src/Text3.cpp === --- src/Text3.cpp (revision 19221) +++ src/Text3.cpp (working copy) @@ -1586,6 +1586,7 @@ } needsUpdate |= (cur.pos() != cur.lastpos()) && cur.selection(); + theSelection().haveSelection(bv->cursor().selection()); // FIXME: The cursor flag is reset two lines below // so we need to check here if some of the LFUN did touch that.
Re: middle-button paste no longer works properly
Bo Peng [EMAIL PROTECTED] writes: On 7/26/07, Bo Peng [EMAIL PROTECTED] wrote: Going the other way is even worse - mark something in LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. Could you please test the attached patch? JMarc and I tried to move numerous haveSelection calls to some 'source' locations, and we obviously missed some cases. Bo, I am surprised that these haveSelection calls are useful, since it is done in the master LyXFunc::dispatch. What is the problem? JMarc
Re: middle-button paste no longer works properly
Bo, I am surprised that these haveSelection calls are useful, since it is done in the master LyXFunc::dispatch. What is the problem? I did not have enough time to investigate, but without my patch (which does not work properly either), mouse selection, table selection does not reach the haveSelection call. Bo
Re: middle-button paste no longer works properly
"Bo Peng" <[EMAIL PROTECTED]> writes: > On 7/26/07, Bo Peng <[EMAIL PROTECTED]> wrote: >> > Going the other way is even worse - mark something in >> > LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. > > Could you please test the attached patch? > > JMarc and I tried to move numerous haveSelection calls to some > 'source' locations, and we obviously missed some cases. Bo, I am surprised that these haveSelection calls are useful, since it is done in the master LyXFunc::dispatch. What is the problem? JMarc
Re: middle-button paste no longer works properly
> Bo, I am surprised that these haveSelection calls are useful, since it > is done in the master LyXFunc::dispatch. What is the problem? I did not have enough time to investigate, but without my patch (which does not work properly either), mouse selection, table selection does not reach the haveSelection call. Bo
Re: middle-button paste no longer works properly
Bo Peng wrote: On 7/26/07, Bo Peng [EMAIL PROTECTED] wrote: Going the other way is even worse - mark something in LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. Could you please test the attached patch? It compiled fine, but didn't help too much. My test: * start lyx, file-new * Type testing followed by an ERT with some more text. * Mark stuff in the ERT by a left mouse button sweep, then middle-click in thunderbird. - before patch: thunderbird pastes whatever was marked before in apps other than LyX. I.e. LyX didn't touch the clipboard in any way at all. - after patch: thunderbird pastes nothing at all. Seems the patch succeeds in emptying the clipboard of other stuff, but don't actually copy the marked stuff there. * Mark plain text instead of ERT content - the problem is the same still. * Mark using shift+arrowkeys - the problem is the same. Helge Hafting
Re: middle-button paste no longer works properly
Bo Peng wrote: On 7/26/07, Bo Peng <[EMAIL PROTECTED]> wrote: Going the other way is even worse - mark something in LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. Could you please test the attached patch? It compiled fine, but didn't help too much. My test: * start lyx, file->new * Type testing followed by an ERT with some more text. * Mark stuff in the ERT by a left mouse button sweep, then middle-click in thunderbird. - before patch: thunderbird pastes whatever was marked before in apps other than LyX. I.e. LyX didn't touch the clipboard in any way at all. - after patch: thunderbird pastes nothing at all. Seems the patch succeeds in emptying the clipboard of "other" stuff, but don't actually copy the marked stuff there. * Mark plain text instead of ERT content - the problem is the same still. * Mark using shift+arrowkeys - the problem is the same. Helge Hafting
middle-button paste no longer works properly
Middle-button paste on Linux no longer participates in X. That is, if I select something in konsole, I cannot paste it in LyX with the middle button. Known bug? john PS congratulations on 1.5.0, looks pretty cool...
Re: middle-button paste no longer works properly
Going the other way is even worse - mark something in LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. Could you submit a bug report about all the problems? Middle-button paste was almost disabled because its previous implementation slowed down lyx significantly, and the new implemenetation does not seem to be well tested. Cheers, Bo
Re: middle-button paste no longer works properly
Darren Freeman wrote: On Thu, 2007-07-26 at 12:08 +0100, John Levon wrote: Middle-button paste on Linux no longer participates in X. That is, if I select something in konsole, I cannot paste it in LyX with the middle button. Known bug? This problem or something similar came up a couple of days ago but was supposed to be fixed in svn before the release. Going the other way is even worse - mark something in LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. Helge Hafting
Re: middle-button paste no longer works properly
On Thu, Jul 26, 2007 at 09:18:41PM +1000, Darren Freeman wrote: On Thu, 2007-07-26 at 12:08 +0100, John Levon wrote: Middle-button paste on Linux no longer participates in X. That is, if I select something in konsole, I cannot paste it in LyX with the middle button. Known bug? This problem or something similar came up a couple of days ago but was supposed to be fixed in svn before the release. Further testing shows it only happens if I select then middle-button-paste something from lyx first. If I then select something from outside of LyX, it does not update the contents regards john
Re: middle-button paste no longer works properly
On Thu, 2007-07-26 at 12:08 +0100, John Levon wrote: Middle-button paste on Linux no longer participates in X. That is, if I select something in konsole, I cannot paste it in LyX with the middle button. Known bug? This problem or something similar came up a couple of days ago but was supposed to be fixed in svn before the release. Have fun, Darren
Re: middle-button paste no longer works properly
On 7/26/07, Bo Peng [EMAIL PROTECTED] wrote: Going the other way is even worse - mark something in LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. Could you please test the attached patch? JMarc and I tried to move numerous haveSelection calls to some 'source' locations, and we obviously missed some cases. Bo Index: src/insets/InsetTabular.cpp === --- src/insets/InsetTabular.cpp (revision 19221) +++ src/insets/InsetTabular.cpp (working copy) @@ -3490,6 +3490,7 @@ cell(cur.idx())-dispatch(cur, cmd); break; } + theSelection().haveSelection(bvcur.selection()); } Index: src/Text3.cpp === --- src/Text3.cpp (revision 19221) +++ src/Text3.cpp (working copy) @@ -1586,6 +1586,7 @@ } needsUpdate |= (cur.pos() != cur.lastpos()) cur.selection(); + theSelection().haveSelection(bv-cursor().selection()); // FIXME: The cursor flag is reset two lines below // so we need to check here if some of the LFUN did touch that.
middle-button paste no longer works properly
Middle-button paste on Linux no longer participates in X. That is, if I select something in konsole, I cannot paste it in LyX with the middle button. Known bug? john PS congratulations on 1.5.0, looks pretty cool...
Re: middle-button paste no longer works properly
Going the other way is even worse - mark something in LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. Could you submit a bug report about all the problems? Middle-button paste was almost disabled because its previous implementation slowed down lyx significantly, and the new implemenetation does not seem to be well tested. Cheers, Bo
Re: middle-button paste no longer works properly
Darren Freeman wrote: On Thu, 2007-07-26 at 12:08 +0100, John Levon wrote: Middle-button paste on Linux no longer participates in X. That is, if I select something in konsole, I cannot paste it in LyX with the middle button. Known bug? This problem or something similar came up a couple of days ago but was supposed to be fixed in svn before the release. Going the other way is even worse - mark something in LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. Helge Hafting
Re: middle-button paste no longer works properly
On Thu, Jul 26, 2007 at 09:18:41PM +1000, Darren Freeman wrote: > On Thu, 2007-07-26 at 12:08 +0100, John Levon wrote: > > Middle-button paste on Linux no longer participates in X. That is, if I > > select something in konsole, I cannot paste it in LyX with the middle > > button. Known bug? > > This problem or something similar came up a couple of days ago but was > supposed to be fixed in svn before the release. Further testing shows it only happens if I select then middle-button-paste something from lyx first. If I then select something from outside of LyX, it does not update the contents regards john
Re: middle-button paste no longer works properly
On Thu, 2007-07-26 at 12:08 +0100, John Levon wrote: > Middle-button paste on Linux no longer participates in X. That is, if I > select something in konsole, I cannot paste it in LyX with the middle > button. Known bug? This problem or something similar came up a couple of days ago but was supposed to be fixed in svn before the release. Have fun, Darren
Re: middle-button paste no longer works properly
On 7/26/07, Bo Peng <[EMAIL PROTECTED]> wrote: > > Going the other way is even worse - mark something in > > LyX 1.5.0 (released) and you (usually) can't paste it into thunderbird. Could you please test the attached patch? JMarc and I tried to move numerous haveSelection calls to some 'source' locations, and we obviously missed some cases. Bo Index: src/insets/InsetTabular.cpp === --- src/insets/InsetTabular.cpp (revision 19221) +++ src/insets/InsetTabular.cpp (working copy) @@ -3490,6 +3490,7 @@ cell(cur.idx())->dispatch(cur, cmd); break; } + theSelection().haveSelection(bvcur.selection()); } Index: src/Text3.cpp === --- src/Text3.cpp (revision 19221) +++ src/Text3.cpp (working copy) @@ -1586,6 +1586,7 @@ } needsUpdate |= (cur.pos() != cur.lastpos()) && cur.selection(); + theSelection().haveSelection(bv->cursor().selection()); // FIXME: The cursor flag is reset two lines below // so we need to check here if some of the LFUN did touch that.
