[Mahara-contributors] [Bug 1515484] Re: Add json pagination to more places
Hi Robert I just created 22 pages to see how the pagination behaves on three pages. After creating them I proceeded to My Groups and selected "All my groups" from the filter. I selected "1" from the "Results per page" drop down and of course I was shown the first of my groups "Pagination Group". I then proceeded to click on the progress arrow which took me to the second page "Pagination Group1". However on the third click I was shown the 10th page which is very wrong because 2 comes after 1 and that's what I was expecting. Unless it's been coded like that to jump from 1 to 10 instead of 1 to 2. Anyway please see the attached. ** Attachment added: "Pagination number jumps" https://bugs.launchpad.net/mahara/+bug/1515484/+attachment/4544745/+files/1515484%20screenshot.mp4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515484 Title: Add json pagination to more places Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: There are some places in Mahara that do not use json pagination - for some minor places like online users page it's not a big deal But for places that are used often we should do json pagination I notice the pages lists do not use json pagination, eg these places htdocs/admin/site/views.php htdocs/view/groupviews.php htdocs/view/index.php htdocs/view/institutionviews.php They should use pagination to allow for faster loading of subsequent data To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1269665] Re: XMLRPC web services don't honor $cfg->usersuniquebyusername
One of our clients is affected by this. I'll put in the changes I made for them. ** Changed in: mahara Assignee: (unassigned) => Ghada El-Zoghbi (ghada-z) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1269665 Title: XMLRPC web services don't honor $cfg->usersuniquebyusername Status in Mahara: Confirmed Bug description: As reported in the forum: https://mahara.org/interaction/forum/topic.php?id=6042 If you set $cfg->usersuniquebyusername, then when a user roams across from XMLRPC, we're supposed to identify their Mahara account by finding the usr.username value that matches their username in the remote system. This is in contrast to the normal method, in which we look up their remote username in the auth_remote_user table, and use that to map them to a Mahara user. The problem is that many of the XMLRPC web services methods, used by the Moodle plugins, call a method api/xmlrpc/lib.php : find_remote_user($username, $wwwroot);. And that method calls User->find_by_instanceid_username(), a method which relies on the auth_remote_user table. What we should do is, if $cfg->usersuniquebyusername is set, find_remote_user() should call User->find_by_username(), the same as what goes on auth/xmlrpc/lib.php : AuthXmlrpc->request_user_authorise() To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1269665/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1507865] Re: Webservice create_users() has old social profile fields
Error message when trying to add a user via web services ** Attachment added: "Error message when trying to add a user via web services" https://bugs.launchpad.net/mahara/+bug/1507865/+attachment/4544720/+files/1507865%20screenshot.mp4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1507865 Title: Webservice create_users() has old social profile fields Status in Mahara: In Progress Bug description: The following fields are still implemented in the Webservice create_users: - aimscreenname - icqnumber - msnnumber - yahoochat - skypusername - jabberusername Which were all replaced by the new blocktype 'social profile' in the internal artefact. If someone were to create a user and specify one of these fields, the set_profile_field() will raise an error when generating the class name (generate_artefact_class_name()) for the field. I haven't actually tried to use the webservice but can see that it will cause an error. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1507865/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515484] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5883 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515484 Title: Add json pagination to more places Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: There are some places in Mahara that do not use json pagination - for some minor places like online users page it's not a big deal But for places that are used often we should do json pagination I notice the pages lists do not use json pagination, eg these places htdocs/admin/site/views.php htdocs/view/groupviews.php htdocs/view/index.php htdocs/view/institutionviews.php They should use pagination to allow for faster loading of subsequent data To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515484] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5885 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515484 Title: Add json pagination to more places Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: There are some places in Mahara that do not use json pagination - for some minor places like online users page it's not a big deal But for places that are used often we should do json pagination I notice the pages lists do not use json pagination, eg these places htdocs/admin/site/views.php htdocs/view/groupviews.php htdocs/view/index.php htdocs/view/institutionviews.php They should use pagination to allow for faster loading of subsequent data To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515484] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5882 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515484 Title: Add json pagination to more places Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: There are some places in Mahara that do not use json pagination - for some minor places like online users page it's not a big deal But for places that are used often we should do json pagination I notice the pages lists do not use json pagination, eg these places htdocs/admin/site/views.php htdocs/view/groupviews.php htdocs/view/index.php htdocs/view/institutionviews.php They should use pagination to allow for faster loading of subsequent data To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515484] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5884 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515484 Title: Add json pagination to more places Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: There are some places in Mahara that do not use json pagination - for some minor places like online users page it's not a big deal But for places that are used often we should do json pagination I notice the pages lists do not use json pagination, eg these places htdocs/admin/site/views.php htdocs/view/groupviews.php htdocs/view/index.php htdocs/view/institutionviews.php They should use pagination to allow for faster loading of subsequent data To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515484] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5876 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515484 Title: Add json pagination to more places Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: There are some places in Mahara that do not use json pagination - for some minor places like online users page it's not a big deal But for places that are used often we should do json pagination I notice the pages lists do not use json pagination, eg these places htdocs/admin/site/views.php htdocs/view/groupviews.php htdocs/view/index.php htdocs/view/institutionviews.php They should use pagination to allow for faster loading of subsequent data To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515484] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5875 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515484 Title: Add json pagination to more places Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: There are some places in Mahara that do not use json pagination - for some minor places like online users page it's not a big deal But for places that are used often we should do json pagination I notice the pages lists do not use json pagination, eg these places htdocs/admin/site/views.php htdocs/view/groupviews.php htdocs/view/index.php htdocs/view/institutionviews.php They should use pagination to allow for faster loading of subsequent data To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515774] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5875 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515774 Title: Add font page looks broken when fonts added Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Released Bug description: The layout for 15.10 looks to be worse than it was in 15.04 see attached screenshot You can test by importing the attached zip file as google fonts To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515774/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515484] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5877 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515484 Title: Add json pagination to more places Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: There are some places in Mahara that do not use json pagination - for some minor places like online users page it's not a big deal But for places that are used often we should do json pagination I notice the pages lists do not use json pagination, eg these places htdocs/admin/site/views.php htdocs/view/groupviews.php htdocs/view/index.php htdocs/view/institutionviews.php They should use pagination to allow for faster loading of subsequent data To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515484] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5878 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515484 Title: Add json pagination to more places Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: There are some places in Mahara that do not use json pagination - for some minor places like online users page it's not a big deal But for places that are used often we should do json pagination I notice the pages lists do not use json pagination, eg these places htdocs/admin/site/views.php htdocs/view/groupviews.php htdocs/view/index.php htdocs/view/institutionviews.php They should use pagination to allow for faster loading of subsequent data To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1482384] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5874 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1482384 Title: Need to fix copy page/collection where the original page has obsolete blocks Status in Mahara: In Progress Bug description: If a user has a page / collection that contains blocks for blocktype plugins that don't exist on the server anymore it causes the copying to fail as certain functions can't be found during the copying process. There needs to be a step where the copy process either: 1) Not copy any plugin blocks where the plugin is not active, or 2) Check to see if the version.php file still exists for the plugin first and not copy any blocks where it doesn't, or 3) Have the table column that keeps track of the 'active' status of blocktype plugins to also have the option of '-1' to indicate not active and also files missing (this info could also be displayed on the Admin -> Extensions screen as well) so that the copy process ignores blocks with active status = -1 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1482384/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1482384] Re: Need to fix copy page/collection where the original page has obsolete blocks
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1482384 Title: Need to fix copy page/collection where the original page has obsolete blocks Status in Mahara: In Progress Bug description: If a user has a page / collection that contains blocks for blocktype plugins that don't exist on the server anymore it causes the copying to fail as certain functions can't be found during the copying process. There needs to be a step where the copy process either: 1) Not copy any plugin blocks where the plugin is not active, or 2) Check to see if the version.php file still exists for the plugin first and not copy any blocks where it doesn't, or 3) Have the table column that keeps track of the 'active' status of blocktype plugins to also have the option of '-1' to indicate not active and also files missing (this info could also be displayed on the Admin -> Extensions screen as well) so that the copy process ignores blocks with active status = -1 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1482384/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515484] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5873 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515484 Title: Add json pagination to more places Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: There are some places in Mahara that do not use json pagination - for some minor places like online users page it's not a big deal But for places that are used often we should do json pagination I notice the pages lists do not use json pagination, eg these places htdocs/admin/site/views.php htdocs/view/groupviews.php htdocs/view/index.php htdocs/view/institutionviews.php They should use pagination to allow for faster loading of subsequent data To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1531048] Re: Incorrect paginator used on /admin/users/suspended.php
*** This bug is a duplicate of bug 1515484 *** https://bugs.launchpad.net/bugs/1515484 The issue has already been fixed in master as a matter of fact, just didn't make it into a stable release of 15.10 yet. ** This bug has been marked a duplicate of bug 1515484 Add json pagination to more places -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1531048 Title: Incorrect paginator used on /admin/users/suspended.php Status in Mahara: In Progress Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: In Progress Bug description: Mahara 15.10+ /admin/users/suspended.php doesn't use the correct paginator yet -> replace with the new one that is used, e.g. on "User search" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1531048/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515484] Re: Add json pagination to more places
** Also affects: mahara/15.10 Importance: Undecided Status: New ** Changed in: mahara/15.10 Milestone: None => 15.10.2 ** Changed in: mahara/15.10 Importance: Undecided => Medium ** Changed in: mahara/15.10 Status: New => In Progress ** Changed in: mahara/15.10 Assignee: (unassigned) => Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515484 Title: Add json pagination to more places Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: There are some places in Mahara that do not use json pagination - for some minor places like online users page it's not a big deal But for places that are used often we should do json pagination I notice the pages lists do not use json pagination, eg these places htdocs/admin/site/views.php htdocs/view/groupviews.php htdocs/view/index.php htdocs/view/institutionviews.php They should use pagination to allow for faster loading of subsequent data To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1438894] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5872 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1438894 Title: Artefacttype "introduction" save data to title rather than description field Status in Mahara: In Progress Bug description: The majority of artefacttypes that use the wysiwyg (TinyMCE) editor save their bulk textual information to the description field. However for some reason the artefacttype = introduction saves it to the title field (and nothing to the description field). It would be good to get this tidied up for consistency sake. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1438894/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1438894] Re: Artefacttype "introduction" save data to title rather than description field
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1438894 Title: Artefacttype "introduction" save data to title rather than description field Status in Mahara: In Progress Bug description: The majority of artefacttypes that use the wysiwyg (TinyMCE) editor save their bulk textual information to the description field. However for some reason the artefacttype = introduction saves it to the title field (and nothing to the description field). It would be good to get this tidied up for consistency sake. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1438894/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515794] Re: phpunit database teardown is incomplete
I first used the wrong bug number (1523499) in my commit so it made a bit of a mess, sorry... Here's the Gerrit review: Patch for "master" branch: https://reviews.mahara.org/5871 It would be appreciate if someone could tell me how to properly recall the bot when this happens so I could do it right the next time ;) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515794 Title: phpunit database teardown is incomplete Status in Mahara: In Progress Bug description: As noticed in Bug 1515473. If you run the Mahara phpunit tests twice against the same database (by doing "make phpunit") you get errors on the second run. Phpunit attempts to tear down the test database and re-create it, but it misses some items and errors out when it tries to recreate them, because they already exist. This happens in Postgres or MySQL. I'm guessing it's because there are some database entities that we create through direct execution of DDL statements rather than through XMLDB and install.xml files. Probably the teardown uses the install.xml files to remove everything, misses the directly-created things, and then the subsequent installer tries to re-create them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515794/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515794] Re: phpunit database teardown is incomplete
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515794 Title: phpunit database teardown is incomplete Status in Mahara: In Progress Bug description: As noticed in Bug 1515473. If you run the Mahara phpunit tests twice against the same database (by doing "make phpunit") you get errors on the second run. Phpunit attempts to tear down the test database and re-create it, but it misses some items and errors out when it tries to recreate them, because they already exist. This happens in Postgres or MySQL. I'm guessing it's because there are some database entities that we create through direct execution of DDL statements rather than through XMLDB and install.xml files. Probably the teardown uses the install.xml files to remove everything, misses the directly-created things, and then the subsequent installer tries to re-create them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515794/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1523499] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5871 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1523499 Title: Broken links in installer Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Hi, when I just started install Mahara 15.10 I saw the message "Before you install Mahara, you may want to check out the release notes for this release.". But link to release notes (https://wiki.mahara.org/Release_Notes/15.10.0) is broken. True link is https://launchpad.net/mahara/15.10/15.10.0#release-notes To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1523499/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1497065] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5870 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1497065 Title: Make multirecipientnotifications module the default one Status in Mahara: In Progress Bug description: When this module was added it was still somewhat unpolished so we made it an optional module. One could either use multirecipient notifications or the existing notifications inbox. Now as we arrive at 15.10 the multirecipient notifications module now the preferred one to use so we need to make it the default for all. If one installs a new site it is the default but may not be if you upgrade from earlier versions We fix this by: 1) Adding some code to htdocs/lib/db/upgrade.php to force the module to install and/or be made active 2) Add public static function can_be_disabled() { return false; } to the module To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1497065/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1515794] Re: phpunit database teardown is incomplete
I found a clean way to fix this issue using the get_installed_plugins_paths function. Pushing the patch right away. ** Changed in: mahara Assignee: (unassigned) => Jean-Philippe Gaudreau (jp-gaudreau) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1515794 Title: phpunit database teardown is incomplete Status in Mahara: Confirmed Bug description: As noticed in Bug 1515473. If you run the Mahara phpunit tests twice against the same database (by doing "make phpunit") you get errors on the second run. Phpunit attempts to tear down the test database and re-create it, but it misses some items and errors out when it tries to recreate them, because they already exist. This happens in Postgres or MySQL. I'm guessing it's because there are some database entities that we create through direct execution of DDL statements rather than through XMLDB and install.xml files. Probably the teardown uses the install.xml files to remove everything, misses the directly-created things, and then the subsequent installer tries to re-create them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1515794/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp