[Mahara-contributors] [Bug 1686860] Re: Account settings sub menus not shown in mobile in 16.10

[Robert Lyon]

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1686860

Title:
  Account settings sub menus not shown in mobile in 16.10

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to their submenu not being part of the normal menu/submenu
  system

  I've added a check for menus that begin with 'settings/' and add a
  class related to this so the submenu does not get hidden on small
  screens

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1686860/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1686860] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7742
Committed: 
https://git.mahara.org/mahara/mahara/commit/056ee10cbfb62d4c104debd802fa6331db1b101a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 056ee10cbfb62d4c104debd802fa6331db1b101a
Author: Robert Lyon 
Date:   Fri Apr 28 12:08:16 2017 +1200

Bug 1686860: Allow the account settings menus show on mobile

This is a problem when we have dropdown menu turned off and are in the
user 'settings' area and are viewing the site on a small screen.

behatnotneeded

Change-Id: Id641080835e4fd61524125ef473b2511f1042a6e
Signed-off-by: Robert Lyon 
(cherry picked from commit 78e43b3a3d2c05de2a8b772e682e5e627bc707f7)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1686860

Title:
  Account settings sub menus not shown in mobile in 16.10

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to their submenu not being part of the normal menu/submenu
  system

  I've added a check for menus that begin with 'settings/' and add a
  class related to this so the submenu does not get hidden on small
  screens

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1686860/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1688165] Re: Image not shown in group description if not a member of a group

[Robert Lyon]

** Changed in: mahara/17.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1688165

Title:
  Image not shown in group description if not a member of a group

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  Seen in Mahara 16.10 and 17.04 but most likely the case also in
  earlier versions.

  When you include an image in the group description and someone who is
  not yet a member of the group looks at the group homepage, that
  someone cannot see the image as only members of the group have access
  to the files that are saved in a group. In contrast to images added to
  a text block on a page and the page then being shared and others can
  see the images, that doesn't work for group homepages. If you add an
  image to an image block though, you can view the image just fine.

  To replicate:

  1. Create a group and save it.
  2. Add an image to the group description (you can only do that after you 
saved the group because before then you don't have group files available) and 
save.
  3. Log in as someone else and view the group homepage. Expected result: You 
see the image. Actual result: You can't and only see the alt text.

  There are two possibilities going forward:

  1. Correct the permissions so you can view images added to the group
  description.

  2. Remove the possibility to add images in a group description. The
  images don't show up in the overview page of the available groups. And
  images can be added easily to the group homepage by using the image
  block.

  It could be worthwhile to discuss not offering the possibility to have
  all the formatting options for description fields such as group
  description and page description. In the past, we wanted more
  formatting options in page descriptions in order to circumvent the
  column layout which was not flexible enough to have a banner across
  the entire page. This has been possible for a number of versions now
  and the need for page description formatting is not so great anymore.

  Therefore, I wonder if we could dispense with either all formatting
  options or at minimum remove the possibility to add images.

  No matter the decision, since it's easy to get around the issue with
  images in the group description, I'm marking this as a low bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1688165/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1688165] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7741
Committed: 
https://git.mahara.org/mahara/mahara/commit/e8e9159aa88c082170f732ead39321c6cd5881bf
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit e8e9159aa88c082170f732ead39321c6cd5881bf
Author: Robert Lyon 
Date:   Mon May 8 08:30:36 2017 +1200

Bug 1688165: Checking if user can view group hompage for embedded images

Rather than checking if user has a group role.
As the embedding of images for group description is linked to the
group homepage, so if you can see that you should be allowed to see
the embedded images within it.

behatnotneeded

Change-Id: I81cbe5cff7229967095a6e2293576861202432c0
Signed-off-by: Robert Lyon 
(cherry picked from commit 4dc2d4891b0108027851fcb70413af4f24b77685)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1688165

Title:
  Image not shown in group description if not a member of a group

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  Seen in Mahara 16.10 and 17.04 but most likely the case also in
  earlier versions.

  When you include an image in the group description and someone who is
  not yet a member of the group looks at the group homepage, that
  someone cannot see the image as only members of the group have access
  to the files that are saved in a group. In contrast to images added to
  a text block on a page and the page then being shared and others can
  see the images, that doesn't work for group homepages. If you add an
  image to an image block though, you can view the image just fine.

  To replicate:

  1. Create a group and save it.
  2. Add an image to the group description (you can only do that after you 
saved the group because before then you don't have group files available) and 
save.
  3. Log in as someone else and view the group homepage. Expected result: You 
see the image. Actual result: You can't and only see the alt text.

  There are two possibilities going forward:

  1. Correct the permissions so you can view images added to the group
  description.

  2. Remove the possibility to add images in a group description. The
  images don't show up in the overview page of the available groups. And
  images can be added easily to the group homepage by using the image
  block.

  It could be worthwhile to discuss not offering the possibility to have
  all the formatting options for description fields such as group
  description and page description. In the past, we wanted more
  formatting options in page descriptions in order to circumvent the
  column layout which was not flexible enough to have a banner across
  the entire page. This has been possible for a number of versions now
  and the need for page description formatting is not so great anymore.

  Therefore, I wonder if we could dispense with either all formatting
  options or at minimum remove the possibility to add images.

  No matter the decision, since it's easy to get around the issue with
  images in the group description, I'm marking this as a low bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1688165/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1686885] A patch has been submitted for review

[Mahara Bot]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1686885

Title:
  Site options - Event log expiry field not enabled

Status in Mahara:
  In Progress
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  In Progress

Bug description:
  Mahara: 17.04
  OS: Linux
  DB: Postgres
  Browser: FF

  After a a vanilla install of mahara 17.04, while setting up the site
  options, the field 'Event log expiry' under the Logging setting is not
  enabled when 'Days', 'Weeks' or 'Months' is selected from the drop
  down.

  I have to select 'Months', save, then come back into the screen. The
  field is then enabled and I'm allowed to enter a number in the field.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1686885/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1686885] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7715
Committed: 
https://git.mahara.org/mahara/mahara/commit/36abf4b9cab3094b5760ca94c7964b50579f8722
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 36abf4b9cab3094b5760ca94c7964b50579f8722
Author: Pramith Dayananda 
Date:   Fri May 5 13:04:04 2017 +1200

Bug 1686885: Site options, fix jquery on fields

Site options > Logging Settings > Event log expiry
Site options > Account Settings > Def reg expiry
Site options > Account Settings > Def acc lifetime
Site options > Account Settings > Def acc inactive time
Site options > Account Settings > Warn time for inactive

behatnotneeded

Change-Id: Ia4596cc6da1842ddedf170d2f707412323dda0c9

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1686885

Title:
  Site options - Event log expiry field not enabled

Status in Mahara:
  In Progress
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  In Progress

Bug description:
  Mahara: 17.04
  OS: Linux
  DB: Postgres
  Browser: FF

  After a a vanilla install of mahara 17.04, while setting up the site
  options, the field 'Event log expiry' under the Logging setting is not
  enabled when 'Days', 'Weeks' or 'Months' is selected from the drop
  down.

  I have to select 'Months', save, then come back into the screen. The
  field is then enabled and I'm allowed to enter a number in the field.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1686885/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1681987] Re: Artefact display page showing owner's name to anonymous viewer

[Robert Lyon]

** Changed in: mahara/17.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681987

Title:
  Artefact display page showing owner's name to anonymous viewer

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  We hide the page owner's name when viewing the page anonymously but we
  fail to hide their name on the artefact display page.

  Will need to take the same check we do on view/view.php page and apply
  it to the artefact/artefact.php page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681987/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1681987] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7740
Committed: 
https://git.mahara.org/mahara/mahara/commit/aa7fa0ca2fbfab801042937a2170d55f3e0e751a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit aa7fa0ca2fbfab801042937a2170d55f3e0e751a
Author: Robert Lyon 
Date:   Wed Apr 12 14:18:28 2017 +1200

Bug 1681987: Hide artefact owner name from artefact details page

When the viewer of the artefact is anonymous

behatnotneeded

Change-Id: Ice5ea6be95209df4a444f901f22ccd43060eba04
Signed-off-by: Robert Lyon 
(cherry picked from commit ef320532ad88b40e75811ed0787d4dbfa9527654)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681987

Title:
  Artefact display page showing owner's name to anonymous viewer

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  We hide the page owner's name when viewing the page anonymously but we
  fail to hide their name on the artefact display page.

  Will need to take the same check we do on view/view.php page and apply
  it to the artefact/artefact.php page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681987/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1424923] Re: Behat bug: A text box isn't clearing text before new text input

[Pramith Dayananda]

Hi,

I picked this bug as I am configuring Behat locally. The test mentioned
in this bug report has changed and the reported issues does not exist
anymore.

Having said that, following step fails.

And I follow "Contact information"
Error Summary:
 is not clickable at point (273, 215). Other element would receive the 
click: ...

When I manually test I cant see the link for "Contact information",
which is overshadowed by "Header".

Thanks,
Pramith.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1424923

Title:
  Behat bug: A text box isn't clearing text before new text input

Status in Mahara:
  Confirmed

Bug description:
  Hi,

  Behat isn't clearing a text box before it inputs new text. However it
  is still passing it. It just fails when it you run a following step
  "And I should see" because it cant see the text.

  I've attached a test for you to see this. It is at the adding user first name 
and last name where it's not adding the correct name.
  The test will still pass because the display name is what it is seeing. 

  
   And I follow "Content"
  And I fill in the following:
  | First name   | Admin  |
  | Last name | User  |
  | Student ID ||
  |  Display name   | Admin User|
  And I press "Save profile"

  Thanks,
  Jinelle

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1424923/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1686860] A patch has been submitted for review

[Mahara Bot]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7742

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1686860

Title:
  Account settings sub menus not shown in mobile in 16.10

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to their submenu not being part of the normal menu/submenu
  system

  I've added a check for menus that begin with 'settings/' and add a
  class related to this so the submenu does not get hidden on small
  screens

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1686860/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1686860] Re: Account settings sub menus not shown in mobile in 16.10

[Robert Lyon]

** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1686860

Title:
  Account settings sub menus not shown in mobile in 16.10

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to their submenu not being part of the normal menu/submenu
  system

  I've added a check for menus that begin with 'settings/' and add a
  class related to this so the submenu does not get hidden on small
  screens

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1686860/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1686860] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7705
Committed: 
https://git.mahara.org/mahara/mahara/commit/78e43b3a3d2c05de2a8b772e682e5e627bc707f7
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit 78e43b3a3d2c05de2a8b772e682e5e627bc707f7
Author: Robert Lyon 
Date:   Fri Apr 28 12:08:16 2017 +1200

Bug 1686860: Allow the account settings menus show on mobile

This is a problem when we have dropdown menu turned off and are in the
user 'settings' area and are viewing the site on a small screen.

behatnotneeded

Change-Id: Id641080835e4fd61524125ef473b2511f1042a6e
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1686860

Title:
  Account settings sub menus not shown in mobile in 16.10

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to their submenu not being part of the normal menu/submenu
  system

  I've added a check for menus that begin with 'settings/' and add a
  class related to this so the submenu does not get hidden on small
  screens

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1686860/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1686860] A patch has been submitted for review

[Mahara Bot]

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/7743

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1686860

Title:
  Account settings sub menus not shown in mobile in 16.10

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to their submenu not being part of the normal menu/submenu
  system

  I've added a check for menus that begin with 'settings/' and add a
  class related to this so the submenu does not get hidden on small
  screens

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1686860/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1688165] Re: Image not shown in group description if not a member of a group

[Kristina Hoeppner]

** Changed in: mahara/17.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1688165

Title:
  Image not shown in group description if not a member of a group

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  Seen in Mahara 16.10 and 17.04 but most likely the case also in
  earlier versions.

  When you include an image in the group description and someone who is
  not yet a member of the group looks at the group homepage, that
  someone cannot see the image as only members of the group have access
  to the files that are saved in a group. In contrast to images added to
  a text block on a page and the page then being shared and others can
  see the images, that doesn't work for group homepages. If you add an
  image to an image block though, you can view the image just fine.

  To replicate:

  1. Create a group and save it.
  2. Add an image to the group description (you can only do that after you 
saved the group because before then you don't have group files available) and 
save.
  3. Log in as someone else and view the group homepage. Expected result: You 
see the image. Actual result: You can't and only see the alt text.

  There are two possibilities going forward:

  1. Correct the permissions so you can view images added to the group
  description.

  2. Remove the possibility to add images in a group description. The
  images don't show up in the overview page of the available groups. And
  images can be added easily to the group homepage by using the image
  block.

  It could be worthwhile to discuss not offering the possibility to have
  all the formatting options for description fields such as group
  description and page description. In the past, we wanted more
  formatting options in page descriptions in order to circumvent the
  column layout which was not flexible enough to have a banner across
  the entire page. This has been possible for a number of versions now
  and the need for page description formatting is not so great anymore.

  Therefore, I wonder if we could dispense with either all formatting
  options or at minimum remove the possibility to add images.

  No matter the decision, since it's easy to get around the issue with
  images in the group description, I'm marking this as a low bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1688165/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1688416] Re: Return to pages & collection button

[Kristina Hoeppner]

** Tags added: nominatedfeature

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1688416

Title:
  Return to pages & collection button

Status in Mahara:
  Fix Committed

Bug description:
  Add a button to the bottom of page edit screen similar to group>page
  edit button

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1688416/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1688165] A patch has been submitted for review

[Mahara Bot]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7741

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1688165

Title:
  Image not shown in group description if not a member of a group

Status in Mahara:
  In Progress
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  In Progress

Bug description:
  Seen in Mahara 16.10 and 17.04 but most likely the case also in
  earlier versions.

  When you include an image in the group description and someone who is
  not yet a member of the group looks at the group homepage, that
  someone cannot see the image as only members of the group have access
  to the files that are saved in a group. In contrast to images added to
  a text block on a page and the page then being shared and others can
  see the images, that doesn't work for group homepages. If you add an
  image to an image block though, you can view the image just fine.

  To replicate:

  1. Create a group and save it.
  2. Add an image to the group description (you can only do that after you 
saved the group because before then you don't have group files available) and 
save.
  3. Log in as someone else and view the group homepage. Expected result: You 
see the image. Actual result: You can't and only see the alt text.

  There are two possibilities going forward:

  1. Correct the permissions so you can view images added to the group
  description.

  2. Remove the possibility to add images in a group description. The
  images don't show up in the overview page of the available groups. And
  images can be added easily to the group homepage by using the image
  block.

  It could be worthwhile to discuss not offering the possibility to have
  all the formatting options for description fields such as group
  description and page description. In the past, we wanted more
  formatting options in page descriptions in order to circumvent the
  column layout which was not flexible enough to have a banner across
  the entire page. This has been possible for a number of versions now
  and the need for page description formatting is not so great anymore.

  Therefore, I wonder if we could dispense with either all formatting
  options or at minimum remove the possibility to add images.

  No matter the decision, since it's easy to get around the issue with
  images in the group description, I'm marking this as a low bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1688165/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1688165] Re: Image not shown in group description if not a member of a group

[Robert Lyon]

** Also affects: mahara/17.04
   Importance: Undecided
   Status: New

** Also affects: mahara/17.10
   Importance: Low
 Assignee: Robert Lyon (robertl-9)
   Status: In Progress

** Changed in: mahara/17.04
   Status: New => In Progress

** Changed in: mahara/17.04
   Importance: Undecided => Low

** Changed in: mahara/17.04
Milestone: None => 17.04.1

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1688165

Title:
  Image not shown in group description if not a member of a group

Status in Mahara:
  In Progress
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  In Progress

Bug description:
  Seen in Mahara 16.10 and 17.04 but most likely the case also in
  earlier versions.

  When you include an image in the group description and someone who is
  not yet a member of the group looks at the group homepage, that
  someone cannot see the image as only members of the group have access
  to the files that are saved in a group. In contrast to images added to
  a text block on a page and the page then being shared and others can
  see the images, that doesn't work for group homepages. If you add an
  image to an image block though, you can view the image just fine.

  To replicate:

  1. Create a group and save it.
  2. Add an image to the group description (you can only do that after you 
saved the group because before then you don't have group files available) and 
save.
  3. Log in as someone else and view the group homepage. Expected result: You 
see the image. Actual result: You can't and only see the alt text.

  There are two possibilities going forward:

  1. Correct the permissions so you can view images added to the group
  description.

  2. Remove the possibility to add images in a group description. The
  images don't show up in the overview page of the available groups. And
  images can be added easily to the group homepage by using the image
  block.

  It could be worthwhile to discuss not offering the possibility to have
  all the formatting options for description fields such as group
  description and page description. In the past, we wanted more
  formatting options in page descriptions in order to circumvent the
  column layout which was not flexible enough to have a banner across
  the entire page. This has been possible for a number of versions now
  and the need for page description formatting is not so great anymore.

  Therefore, I wonder if we could dispense with either all formatting
  options or at minimum remove the possibility to add images.

  No matter the decision, since it's easy to get around the issue with
  images in the group description, I'm marking this as a low bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1688165/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1688416] Re: Return to pages & collection button

[Robert Lyon]

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1688416

Title:
  Return to pages & collection button

Status in Mahara:
  Fix Committed

Bug description:
  Add a button to the bottom of page edit screen similar to group>page
  edit button

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1688416/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1681987] A patch has been submitted for review

[Mahara Bot]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7740

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681987

Title:
  Artefact display page showing owner's name to anonymous viewer

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  We hide the page owner's name when viewing the page anonymously but we
  fail to hide their name on the artefact display page.

  Will need to take the same check we do on view/view.php page and apply
  it to the artefact/artefact.php page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681987/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1688416] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7714
Committed: 
https://git.mahara.org/mahara/mahara/commit/717880941818686d8871ff647603fe55d395d5a4
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 717880941818686d8871ff647603fe55d395d5a4
Author: Robert Lyon 
Date:   Fri May 5 10:54:59 2017 +1200

Bug 1688416: Adding a back to views index button

For user editing a page, similar to what we have for group/site pages
rather than having a 2nd display page link

behatnotneeded

Change-Id: Iabc6dcc8d994cce34ce47a2eb283e271b05beef7
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1688416

Title:
  Return to pages & collection button

Status in Mahara:
  Fix Committed

Bug description:
  Add a button to the bottom of page edit screen similar to group>page
  edit button

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1688416/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1681987] Re: Artefact display page showing owner's name to anonymous viewer

[Robert Lyon]

** Changed in: mahara/17.10
   Status: In Progress => Fix Committed

** Changed in: mahara/17.04
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681987

Title:
  Artefact display page showing owner's name to anonymous viewer

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  We hide the page owner's name when viewing the page anonymously but we
  fail to hide their name on the artefact display page.

  Will need to take the same check we do on view/view.php page and apply
  it to the artefact/artefact.php page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681987/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1688165] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7718
Committed: 
https://git.mahara.org/mahara/mahara/commit/4dc2d4891b0108027851fcb70413af4f24b77685
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 4dc2d4891b0108027851fcb70413af4f24b77685
Author: Robert Lyon 
Date:   Mon May 8 08:30:36 2017 +1200

Bug 1688165: Checking if user can view group hompage for embedded images

Rather than checking if user has a group role.
As the embedding of images for group description is linked to the
group homepage, so if you can see that you should be allowed to see
the embedded images within it.

behatnotneeded

Change-Id: I81cbe5cff7229967095a6e2293576861202432c0
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1688165

Title:
  Image not shown in group description if not a member of a group

Status in Mahara:
  In Progress
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  In Progress

Bug description:
  Seen in Mahara 16.10 and 17.04 but most likely the case also in
  earlier versions.

  When you include an image in the group description and someone who is
  not yet a member of the group looks at the group homepage, that
  someone cannot see the image as only members of the group have access
  to the files that are saved in a group. In contrast to images added to
  a text block on a page and the page then being shared and others can
  see the images, that doesn't work for group homepages. If you add an
  image to an image block though, you can view the image just fine.

  To replicate:

  1. Create a group and save it.
  2. Add an image to the group description (you can only do that after you 
saved the group because before then you don't have group files available) and 
save.
  3. Log in as someone else and view the group homepage. Expected result: You 
see the image. Actual result: You can't and only see the alt text.

  There are two possibilities going forward:

  1. Correct the permissions so you can view images added to the group
  description.

  2. Remove the possibility to add images in a group description. The
  images don't show up in the overview page of the available groups. And
  images can be added easily to the group homepage by using the image
  block.

  It could be worthwhile to discuss not offering the possibility to have
  all the formatting options for description fields such as group
  description and page description. In the past, we wanted more
  formatting options in page descriptions in order to circumvent the
  column layout which was not flexible enough to have a banner across
  the entire page. This has been possible for a number of versions now
  and the need for page description formatting is not so great anymore.

  Therefore, I wonder if we could dispense with either all formatting
  options or at minimum remove the possibility to add images.

  No matter the decision, since it's easy to get around the issue with
  images in the group description, I'm marking this as a low bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1688165/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1689923] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/7739

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689923

Title:
  Problems adding annotation comments to SmartEvidence in 17.04 via
  matrix page

Status in Mahara:
  Confirmed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed

Bug description:
  When adding a comment to a point on the matrix on submission of
  comment the button changes from 'Place feedback' to 'Processing...'
  but doesn't change back.

  I believe this is due to the jQuery changes made recently

  Normally we  submit via pieform and replace the form on success but in
  this case we submit via ajax.

  So we need to add some js to turn the 'Processing...' back to 'Place
  feedback' on return of success or error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689923/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1689975] Re: Alignment of help icon improper

[Kristina Hoeppner]

** Changed in: mahara
   Importance: Undecided => Medium

** Tags added: front-end

** Summary changed:

- Alignment of help icon improper
+ Help icon on "Settings" not aligned correctly

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689975

Title:
  Help icon on "Settings" not aligned correctly

Status in Mahara:
  New

Bug description:
  On the settings page the help icon alignment on "Friends control" &
  "messages from other users"  is improper.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689975/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1689931] A patch has been submitted for review

[Mahara Bot]

Patch for "master" branch: https://reviews.mahara.org/7738

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689931

Title:
  Problem with leaving feedback on copied SE collection annotation

Status in Mahara:
  In Progress
Status in Mahara 16.10 series:
  Confirmed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  In Progress

Bug description:
  When we copy an annotated smart evidence collection we keep the
  annotation blocks but don't keep the feedback comments.

  This is correct behaviour

  But on the copied collection we can't add comments to the annotation
  block any more.

  When trying to add feedback via matrix page it says it's saved but no
  info is actually saved.

  I suspect there must be some disconnect between the copying of the
  annotation within the collection causing the copied annotation to not
  know where to connect it's feedback

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689931/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1689975] [NEW] Alignment of help icon improper

[Niranjan]

Public bug reported:

On the settings page the help icon alignment on "Friends control" &
"messages from other users"  is improper.

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689975

Title:
  Alignment of help icon improper

Status in Mahara:
  New

Bug description:
  On the settings page the help icon alignment on "Friends control" &
  "messages from other users"  is improper.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689975/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1689975] Re: Alignment of help icon improper

[Robert Lyon]

** Changed in: mahara
Milestone: None => 17.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689975

Title:
  Alignment of help icon improper

Status in Mahara:
  New

Bug description:
  On the settings page the help icon alignment on "Friends control" &
  "messages from other users"  is improper.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689975/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1689975] Re: Alignment of help icon improper

[Niranjan]

** Attachment added: "Help icon.jpeg"
   
https://bugs.launchpad.net/mahara/+bug/1689975/+attachment/4874941/+files/Help%20icon.jpeg

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689975

Title:
  Alignment of help icon improper

Status in Mahara:
  New

Bug description:
  On the settings page the help icon alignment on "Friends control" &
  "messages from other users"  is improper.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689975/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1689923] Re: Problems adding annotation comments to SmartEvidence in 17.04 via matrix page

[Robert Lyon]

** Changed in: mahara/17.10
 Assignee: (unassigned) => Robert Lyon (robertl-9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689923

Title:
  Problems adding annotation comments to SmartEvidence in 17.04 via
  matrix page

Status in Mahara:
  Confirmed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed

Bug description:
  When adding a comment to a point on the matrix on submission of
  comment the button changes from 'Place feedback' to 'Processing...'
  but doesn't change back.

  I believe this is due to the jQuery changes made recently

  Normally we  submit via pieform and replace the form on success but in
  this case we submit via ajax.

  So we need to add some js to turn the 'Processing...' back to 'Place
  feedback' on return of success or error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689923/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1689931] [NEW] Problem with leaving feedback on copied SE collection annotation

[Robert Lyon]

Public bug reported:

When we copy an annotated smart evidence collection we keep the
annotation blocks but don't keep the feedback comments.

This is correct behaviour

But on the copied collection we can't add comments to the annotation
block any more.

When trying to add feedback via matrix page it says it's saved but no
info is actually saved.

I suspect there must be some disconnect between the copying of the
annotation within the collection causing the copied annotation to not
know where to connect it's feedback

** Affects: mahara
 Importance: High
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress

** Affects: mahara/16.10
 Importance: High
 Status: Confirmed

** Affects: mahara/17.04
 Importance: High
 Status: Confirmed

** Affects: mahara/17.10
 Importance: High
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689931

Title:
  Problem with leaving feedback on copied SE collection annotation

Status in Mahara:
  In Progress
Status in Mahara 16.10 series:
  Confirmed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  In Progress

Bug description:
  When we copy an annotated smart evidence collection we keep the
  annotation blocks but don't keep the feedback comments.

  This is correct behaviour

  But on the copied collection we can't add comments to the annotation
  block any more.

  When trying to add feedback via matrix page it says it's saved but no
  info is actually saved.

  I suspect there must be some disconnect between the copying of the
  annotation within the collection causing the copied annotation to not
  know where to connect it's feedback

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689931/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1689931] Re: Problem with leaving feedback on copied SE collection annotation

[Robert Lyon]

Ok, on further investigation the issue is with the artefact_annotation
table.

Here we add in the information about what view the annotation is on. It
is setting the copied annotation to the old view rather than the new
one.

** Also affects: mahara/17.10
   Importance: Undecided
   Status: New

** Also affects: mahara/16.10
   Importance: Undecided
   Status: New

** Also affects: mahara/17.04
   Importance: Undecided
   Status: New

** Changed in: mahara/17.10
Milestone: None => 17.10.0

** Changed in: mahara/17.04
Milestone: None => 17.04.1

** Changed in: mahara/16.10
Milestone: None => 16.10.4

** Changed in: mahara/16.10
   Importance: Undecided => High

** Changed in: mahara/17.04
   Importance: Undecided => High

** Changed in: mahara/17.10
   Importance: Undecided => High

** Changed in: mahara/17.10
   Status: New => In Progress

** Changed in: mahara/17.04
   Status: New => Confirmed

** Changed in: mahara/16.10
   Status: New => Confirmed

** Changed in: mahara/17.10
 Assignee: (unassigned) => Robert Lyon (robertl-9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689931

Title:
  Problem with leaving feedback on copied SE collection annotation

Status in Mahara:
  In Progress
Status in Mahara 16.10 series:
  Confirmed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  In Progress

Bug description:
  When we copy an annotated smart evidence collection we keep the
  annotation blocks but don't keep the feedback comments.

  This is correct behaviour

  But on the copied collection we can't add comments to the annotation
  block any more.

  When trying to add feedback via matrix page it says it's saved but no
  info is actually saved.

  I suspect there must be some disconnect between the copying of the
  annotation within the collection causing the copied annotation to not
  know where to connect it's feedback

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689931/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1689923] Re: Problems adding annotation comments to smart evidence in 17.04 via matrix page

[Kristina Hoeppner]

** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => High

** Also affects: mahara/17.04
   Importance: Undecided
   Status: New

** Also affects: mahara/17.10
   Importance: High
   Status: Confirmed

** Changed in: mahara/17.10
Milestone: None => 17.10.0

** Changed in: mahara/17.04
Milestone: None => 17.04.1

** Changed in: mahara/17.04
   Importance: Undecided => High

** Changed in: mahara/17.04
   Status: New => Confirmed

** Summary changed:

- Problems adding annotation comments to smart evidence in 17.04 via matrix page
+ Problems adding annotation comments to SmartEvidence in 17.04 via matrix page

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689923

Title:
  Problems adding annotation comments to SmartEvidence in 17.04 via
  matrix page

Status in Mahara:
  Confirmed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed

Bug description:
  When adding a comment to a point on the matrix on submission of
  comment the button changes from 'Place feedback' to 'Processing...'
  but doesn't change back.

  I believe this is due to the jQuery changes made recently

  Normally we  submit via pieform and replace the form on success but in
  this case we submit via ajax.

  So we need to add some js to turn the 'Processing...' back to 'Place
  feedback' on return of success or error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689923/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1689923] [NEW] Problems adding annotation comments to smart evidence in 17.04 via matrix page

[Robert Lyon]

Public bug reported:

When adding a comment to a point on the matrix on submission of comment
the button changes from 'Place feedback' to 'Processing...' but doesn't
change back.

I believe this is due to the jQuery changes made recently

Normally we  submit via pieform and replace the form on success but in
this case we submit via ajax.

So we need to add some js to turn the 'Processing...' back to 'Place
feedback' on return of success or error.

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689923

Title:
  Problems adding annotation comments to smart evidence in 17.04 via
  matrix page

Status in Mahara:
  New

Bug description:
  When adding a comment to a point on the matrix on submission of
  comment the button changes from 'Place feedback' to 'Processing...'
  but doesn't change back.

  I believe this is due to the jQuery changes made recently

  Normally we  submit via pieform and replace the form on success but in
  this case we submit via ajax.

  So we need to add some js to turn the 'Processing...' back to 'Place
  feedback' on return of success or error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689923/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1643365] A patch has been submitted for review

[Mahara Bot]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7737

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1643365

Title:
  LeapImportArtefactPlugin warning when extending class adds parameters
  in method

Status in Mahara:
  Fix Released

Bug description:
  When trying to import a Leap2A file, the operation in successful but
  shows following warning for several classes:

  [WAR] de (artefact/resume/import/leap/lib.php:0) Declaration of
  LeapImportResume::import_author_data(PluginImport $importer,
  $persondataid) should be compatible with
  LeapImportArtefactPlugin::import_author_data(PluginImportLeap
  $importer, $persondataid)

  [WAR] de (artefact/plans/import/leap/lib.php:0) Declaration of
  LeapImportPlans::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer, $strategy, array $otherentries)

  [WAR] de (artefact/annotation/import/leap/lib.php:0) Declaration of
  LeapImportAnnotation::setup_view_relationships(SimpleXMLElement
  $entry, PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_view_relationships(SimpleXMLElement
  $entry, PluginImportLeap $importer, $strategy, array $otherentries)

  [WAR] de (artefact/comment/import/leap/lib.php:0) Declaration of
  LeapImportComment::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer, $strategy, array $otherentries)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1643365/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1681291] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7728
Committed: 
https://git.mahara.org/mahara/mahara/commit/a407b3791a85b59c1a83d50216d187cc7a53905f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit a407b3791a85b59c1a83d50216d187cc7a53905f
Author: Robert Lyon 
Date:   Mon May 8 11:04:13 2017 +1200

Bug 1681291: Missing params for LeapImportComment::setup_relationships()

When the bug 1643365 was fixed we missed a place where the
setup_relationships() was called. We need to add the extra required
parameters to the call

behatnotneeded

Change-Id: I093937073598d4ff39abfa10aa9725319a40ec55
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681291

Title:
  Unable to import leap2a file

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  Tested on
  Site: https://master-mahara.catalystdemo.net.nz
  Browser: chrome/FF/Safari 10.0.3
  Device: Desktop/MacBook Pro

  Steps to Reproduce:

  1) Navigate to portfolio>Import
  2) choose a Leap2a file
  3) Click on Import

  Actual Result: The following warning message is displayed

  [WAR] 1d (artefact/comment/import/leap/lib.php:249) Missing argument 3
  for LeapImportComment::setup_relationships(), called in
  /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php
  on line 240 and defined

  
  Call stack (most recent first):
  log_message("Missing argument 3 for LeapImportComment::setup_re...", 8, true, 
true, "/home/niranjanbandi/code/mahara/htdocs/artefact/co...", 249) at 
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:521
  error(2, "Missing argument 3 for LeapImportComment::setup_re...", 
"/home/niranjanbandi/code/mahara/htdocs/artefact/co...", 249, array(size 2)) at 
/home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php:249
  LeapImportComment::setup_relationships(object(SimpleXMLElement), 
object(PluginImportLeap)) at 
/home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php:240
  
LeapImportComment::setup_relationships_from_requests(object(PluginImportLeap)) 
at /home/niranjanbandi/code/mahara/htdocs/lib/mahara.php:1771
  call_static_method("LeapImportComment", "setup_relationships_from_requests", 
object(PluginImportLeap)) at 
/home/niranjanbandi/code/mahara/htdocs/import/leap/lib.php:299
  
PluginImportLeap->call_import_method_plugins("setup_relationships_from_requests")
 at /home/niranjanbandi/code/mahara/htdocs/import/leap/lib.php:315
  PluginImportLeap->do_import_from_requests() at 
/home/niranjanbandi/code/mahara/htdocs/import/index.php:311
  do_import() at /home/niranjanbandi/code/mahara/htdocs/import/index.php:71

  [WAR] 1d (lib/errors.php:536) [TypeError]: Argument 4 passed to
  LeapImportComment::setup_relationships() must be of the type array,
  none given, called in
  /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php
  on line 240

  Call stack (most recent first):
  exception(object(TypeError)) at Unknown:0

  And for safari browser it only shows the following error

  
  Mahara: Site unavailable
  A nonrecoverable error occurred. This probably means you have encountered a 
bug in the system

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681291/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1643365] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7737
Committed: 
https://git.mahara.org/mahara/mahara/commit/fee994ca330cb614a084cd169e7c39f2a06b591f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit fee994ca330cb614a084cd169e7c39f2a06b591f
Author: Robert Lyon 
Date:   Mon May 8 11:04:13 2017 +1200

Bug 1681291: Missing params for LeapImportComment::setup_relationships()

When the bug 1643365 was fixed we missed a place where the
setup_relationships() was called. We need to add the extra required
parameters to the call

behatnotneeded

Change-Id: I093937073598d4ff39abfa10aa9725319a40ec55
Signed-off-by: Robert Lyon 
(cherry picked from commit a407b3791a85b59c1a83d50216d187cc7a53905f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1643365

Title:
  LeapImportArtefactPlugin warning when extending class adds parameters
  in method

Status in Mahara:
  Fix Released

Bug description:
  When trying to import a Leap2A file, the operation in successful but
  shows following warning for several classes:

  [WAR] de (artefact/resume/import/leap/lib.php:0) Declaration of
  LeapImportResume::import_author_data(PluginImport $importer,
  $persondataid) should be compatible with
  LeapImportArtefactPlugin::import_author_data(PluginImportLeap
  $importer, $persondataid)

  [WAR] de (artefact/plans/import/leap/lib.php:0) Declaration of
  LeapImportPlans::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer, $strategy, array $otherentries)

  [WAR] de (artefact/annotation/import/leap/lib.php:0) Declaration of
  LeapImportAnnotation::setup_view_relationships(SimpleXMLElement
  $entry, PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_view_relationships(SimpleXMLElement
  $entry, PluginImportLeap $importer, $strategy, array $otherentries)

  [WAR] de (artefact/comment/import/leap/lib.php:0) Declaration of
  LeapImportComment::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer, $strategy, array $otherentries)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1643365/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1643365] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7728
Committed: 
https://git.mahara.org/mahara/mahara/commit/a407b3791a85b59c1a83d50216d187cc7a53905f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit a407b3791a85b59c1a83d50216d187cc7a53905f
Author: Robert Lyon 
Date:   Mon May 8 11:04:13 2017 +1200

Bug 1681291: Missing params for LeapImportComment::setup_relationships()

When the bug 1643365 was fixed we missed a place where the
setup_relationships() was called. We need to add the extra required
parameters to the call

behatnotneeded

Change-Id: I093937073598d4ff39abfa10aa9725319a40ec55
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1643365

Title:
  LeapImportArtefactPlugin warning when extending class adds parameters
  in method

Status in Mahara:
  Fix Released

Bug description:
  When trying to import a Leap2A file, the operation in successful but
  shows following warning for several classes:

  [WAR] de (artefact/resume/import/leap/lib.php:0) Declaration of
  LeapImportResume::import_author_data(PluginImport $importer,
  $persondataid) should be compatible with
  LeapImportArtefactPlugin::import_author_data(PluginImportLeap
  $importer, $persondataid)

  [WAR] de (artefact/plans/import/leap/lib.php:0) Declaration of
  LeapImportPlans::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer, $strategy, array $otherentries)

  [WAR] de (artefact/annotation/import/leap/lib.php:0) Declaration of
  LeapImportAnnotation::setup_view_relationships(SimpleXMLElement
  $entry, PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_view_relationships(SimpleXMLElement
  $entry, PluginImportLeap $importer, $strategy, array $otherentries)

  [WAR] de (artefact/comment/import/leap/lib.php:0) Declaration of
  LeapImportComment::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer, $strategy, array $otherentries)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1643365/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1681291] Re: Unable to import leap2a file

[Robert Lyon]

** Changed in: mahara/17.04
   Status: In Progress => Fix Committed

** Changed in: mahara/17.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681291

Title:
  Unable to import leap2a file

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  Tested on
  Site: https://master-mahara.catalystdemo.net.nz
  Browser: chrome/FF/Safari 10.0.3
  Device: Desktop/MacBook Pro

  Steps to Reproduce:

  1) Navigate to portfolio>Import
  2) choose a Leap2a file
  3) Click on Import

  Actual Result: The following warning message is displayed

  [WAR] 1d (artefact/comment/import/leap/lib.php:249) Missing argument 3
  for LeapImportComment::setup_relationships(), called in
  /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php
  on line 240 and defined

  
  Call stack (most recent first):
  log_message("Missing argument 3 for LeapImportComment::setup_re...", 8, true, 
true, "/home/niranjanbandi/code/mahara/htdocs/artefact/co...", 249) at 
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:521
  error(2, "Missing argument 3 for LeapImportComment::setup_re...", 
"/home/niranjanbandi/code/mahara/htdocs/artefact/co...", 249, array(size 2)) at 
/home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php:249
  LeapImportComment::setup_relationships(object(SimpleXMLElement), 
object(PluginImportLeap)) at 
/home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php:240
  
LeapImportComment::setup_relationships_from_requests(object(PluginImportLeap)) 
at /home/niranjanbandi/code/mahara/htdocs/lib/mahara.php:1771
  call_static_method("LeapImportComment", "setup_relationships_from_requests", 
object(PluginImportLeap)) at 
/home/niranjanbandi/code/mahara/htdocs/import/leap/lib.php:299
  
PluginImportLeap->call_import_method_plugins("setup_relationships_from_requests")
 at /home/niranjanbandi/code/mahara/htdocs/import/leap/lib.php:315
  PluginImportLeap->do_import_from_requests() at 
/home/niranjanbandi/code/mahara/htdocs/import/index.php:311
  do_import() at /home/niranjanbandi/code/mahara/htdocs/import/index.php:71

  [WAR] 1d (lib/errors.php:536) [TypeError]: Argument 4 passed to
  LeapImportComment::setup_relationships() must be of the type array,
  none given, called in
  /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php
  on line 240

  Call stack (most recent first):
  exception(object(TypeError)) at Unknown:0

  And for safari browser it only shows the following error

  
  Mahara: Site unavailable
  A nonrecoverable error occurred. This probably means you have encountered a 
bug in the system

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681291/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1681291] A patch has been submitted for review

[Mahara Bot]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7737

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681291

Title:
  Unable to import leap2a file

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  Tested on
  Site: https://master-mahara.catalystdemo.net.nz
  Browser: chrome/FF/Safari 10.0.3
  Device: Desktop/MacBook Pro

  Steps to Reproduce:

  1) Navigate to portfolio>Import
  2) choose a Leap2a file
  3) Click on Import

  Actual Result: The following warning message is displayed

  [WAR] 1d (artefact/comment/import/leap/lib.php:249) Missing argument 3
  for LeapImportComment::setup_relationships(), called in
  /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php
  on line 240 and defined

  
  Call stack (most recent first):
  log_message("Missing argument 3 for LeapImportComment::setup_re...", 8, true, 
true, "/home/niranjanbandi/code/mahara/htdocs/artefact/co...", 249) at 
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:521
  error(2, "Missing argument 3 for LeapImportComment::setup_re...", 
"/home/niranjanbandi/code/mahara/htdocs/artefact/co...", 249, array(size 2)) at 
/home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php:249
  LeapImportComment::setup_relationships(object(SimpleXMLElement), 
object(PluginImportLeap)) at 
/home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php:240
  
LeapImportComment::setup_relationships_from_requests(object(PluginImportLeap)) 
at /home/niranjanbandi/code/mahara/htdocs/lib/mahara.php:1771
  call_static_method("LeapImportComment", "setup_relationships_from_requests", 
object(PluginImportLeap)) at 
/home/niranjanbandi/code/mahara/htdocs/import/leap/lib.php:299
  
PluginImportLeap->call_import_method_plugins("setup_relationships_from_requests")
 at /home/niranjanbandi/code/mahara/htdocs/import/leap/lib.php:315
  PluginImportLeap->do_import_from_requests() at 
/home/niranjanbandi/code/mahara/htdocs/import/index.php:311
  do_import() at /home/niranjanbandi/code/mahara/htdocs/import/index.php:71

  [WAR] 1d (lib/errors.php:536) [TypeError]: Argument 4 passed to
  LeapImportComment::setup_relationships() must be of the type array,
  none given, called in
  /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php
  on line 240

  Call stack (most recent first):
  exception(object(TypeError)) at Unknown:0

  And for safari browser it only shows the following error

  
  Mahara: Site unavailable
  A nonrecoverable error occurred. This probably means you have encountered a 
bug in the system

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681291/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1681291] A change has been merged

[Mahara Bot]

Reviewed:  https://reviews.mahara.org/7737
Committed: 
https://git.mahara.org/mahara/mahara/commit/fee994ca330cb614a084cd169e7c39f2a06b591f
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit fee994ca330cb614a084cd169e7c39f2a06b591f
Author: Robert Lyon 
Date:   Mon May 8 11:04:13 2017 +1200

Bug 1681291: Missing params for LeapImportComment::setup_relationships()

When the bug 1643365 was fixed we missed a place where the
setup_relationships() was called. We need to add the extra required
parameters to the call

behatnotneeded

Change-Id: I093937073598d4ff39abfa10aa9725319a40ec55
Signed-off-by: Robert Lyon 
(cherry picked from commit a407b3791a85b59c1a83d50216d187cc7a53905f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681291

Title:
  Unable to import leap2a file

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  Tested on
  Site: https://master-mahara.catalystdemo.net.nz
  Browser: chrome/FF/Safari 10.0.3
  Device: Desktop/MacBook Pro

  Steps to Reproduce:

  1) Navigate to portfolio>Import
  2) choose a Leap2a file
  3) Click on Import

  Actual Result: The following warning message is displayed

  [WAR] 1d (artefact/comment/import/leap/lib.php:249) Missing argument 3
  for LeapImportComment::setup_relationships(), called in
  /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php
  on line 240 and defined

  
  Call stack (most recent first):
  log_message("Missing argument 3 for LeapImportComment::setup_re...", 8, true, 
true, "/home/niranjanbandi/code/mahara/htdocs/artefact/co...", 249) at 
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:521
  error(2, "Missing argument 3 for LeapImportComment::setup_re...", 
"/home/niranjanbandi/code/mahara/htdocs/artefact/co...", 249, array(size 2)) at 
/home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php:249
  LeapImportComment::setup_relationships(object(SimpleXMLElement), 
object(PluginImportLeap)) at 
/home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php:240
  
LeapImportComment::setup_relationships_from_requests(object(PluginImportLeap)) 
at /home/niranjanbandi/code/mahara/htdocs/lib/mahara.php:1771
  call_static_method("LeapImportComment", "setup_relationships_from_requests", 
object(PluginImportLeap)) at 
/home/niranjanbandi/code/mahara/htdocs/import/leap/lib.php:299
  
PluginImportLeap->call_import_method_plugins("setup_relationships_from_requests")
 at /home/niranjanbandi/code/mahara/htdocs/import/leap/lib.php:315
  PluginImportLeap->do_import_from_requests() at 
/home/niranjanbandi/code/mahara/htdocs/import/index.php:311
  do_import() at /home/niranjanbandi/code/mahara/htdocs/import/index.php:71

  [WAR] 1d (lib/errors.php:536) [TypeError]: Argument 4 passed to
  LeapImportComment::setup_relationships() must be of the type array,
  none given, called in
  /home/niranjanbandi/code/mahara/htdocs/artefact/comment/import/leap/lib.php
  on line 240

  Call stack (most recent first):
  exception(object(TypeError)) at Unknown:0

  And for safari browser it only shows the following error

  
  Mahara: Site unavailable
  A nonrecoverable error occurred. This probably means you have encountered a 
bug in the system

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681291/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp