[Mahara-contributors] [Bug 1833495] Re: Syncing LDAP usernames with Mahara's internal username leads to incorrect user record matching
** Description changed:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF / Chrome (really n/a)
The LDAP sync_users() functionality is not correctly matching user
records - i.e. LDAP username with Mahara username.
Scenario:
1. Create an institution with and LDAP authentication
- Update user info on login = Yes
- We auto-create users = Yes
- Sync users automatically via cron job = Yes
- Update user info in cron = Yes
- Auto-create users in cron = Yes
- If a user is no longer present in LDAP = Suspend user's account
2. Create an XML-RPC authentication with a Moodle for this institution
- Parent authority = LDAP auth created above
- SSO direction = Yes
- Update user info on login = Yes
- We auto-create users = Yes
- We import content = Yes
* The Moodle instance needs to have LDAP set up as well.
3. Create an internal Mahara user (i.e. not LDAP)
- username: AAA (make sure this username exists in the LDAP directory)
* The username 'AAA' needs to be in Moodle created via LDAP.
4. Login to Moodle with the username AAA - the LDAP user
5. SSO to Mahara
This will do the following
- a new user record is created with username AAA1
- auth_remote_user table will link Mahara user AAA1 to Moodle user AAA
- 6. As Admin, update AAA1's auth metho to LDAP.
+ 6. As Admin, update AAA1's auth method to LDAP.
7. Logout of Mahara and Moodle.
8. Run cron so LDAP syncs users
Expected Results: user AAA1 to remain active in Mahara
Actual Results: user AAA1 is suspended because it matches on username (i.e.
AAA)
That is, this join is correct:
from {usr} u
inner join {auth_ldap_extusers_temp} e on u.username = e.extusername
The username in auth_ldap_extusers_temp is: AAA
The LDAP username in Mahara is: AAA1
Hence, it will not match on username and think the user is no longer in
the LDAP directory and suspend the user.
The join needs to be on another field that is present in both LDAP and
Mahara.
We should also join to the auth_remote_user table to get the correct
external username.
i.e.
select
u.id as id,
aru.remoteusername as username,
u.suspendedreason as suspendedreason,
...
from {usr} u
inner join {auth_remote_user} aru on u.id = aru.localusr
inner join {auth_ldap_extusers_temp} e on aru.remoteusername = e.extusername
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1833495
Title:
Syncing LDAP usernames with Mahara's internal username leads to
incorrect user record matching
Status in Mahara:
New
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF / Chrome (really n/a)
The LDAP sync_users() functionality is not correctly matching user
records - i.e. LDAP username with Mahara username.
Scenario:
1. Create an institution with and LDAP authentication
- Update user info on login = Yes
- We auto-create users = Yes
- Sync users automatically via cron job = Yes
- Update user info in cron = Yes
- Auto-create users in cron = Yes
- If a user is no longer present in LDAP = Suspend user's account
2. Create an XML-RPC authentication with a Moodle for this institution
- Parent authority = LDAP auth created above
- SSO direction = Yes
- Update user info on login = Yes
- We auto-create users = Yes
- We import content = Yes
* The Moodle instance needs to have LDAP set up as well.
3. Create an internal Mahara user (i.e. not LDAP)
- username: AAA (make sure this username exists in the LDAP directory)
* The username 'AAA' needs to be in Moodle created via LDAP.
4. Login to Moodle with the username AAA - the LDAP user
5. SSO to Mahara
This will do the following
- a new user record is created with username AAA1
- auth_remote_user table will link Mahara user AAA1 to Moodle user AAA
6. As Admin, update AAA1's auth method to LDAP.
7. Logout of Mahara and Moodle.
8. Run cron so LDAP syncs users
Expected Results: user AAA1 to remain active in Mahara
Actual Results: user AAA1 is suspended because it matches on username (i.e.
AAA)
That is, this join is correct:
from {usr} u
inner join {auth_ldap_extusers_temp} e on u.username = e.extusername
The username in auth_ldap_extusers_temp is: AAA
The LDAP username in Mahara is: AAA1
Hence, it will not match on username and think the user is no longer
in the LDAP directory and suspend the user.
The join needs to be on another field that is present in both LDAP and
Mahara.
We should also join to the auth_remote_user table to get the correct
external username.
i.e.
select
u.id as id,
aru.remoteusername as username,
u.suspendedreason as suspendedr
[Mahara-contributors] [Bug 1833495] Re: Syncing LDAP usernames with Mahara's internal username leads to incorrect user record matching
** Description changed:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF / Chrome (really n/a)
The LDAP sync_users() functionality is not correctly matching user
records - i.e. LDAP username with Mahara username.
Scenario:
1. Create an institution with and LDAP authentication
- Update user info on login = Yes
- We auto-create users = Yes
- Sync users automatically via cron job = Yes
- Update user info in cron = Yes
- Auto-create users in cron = Yes
- If a user is no longer present in LDAP = Suspend user's account
2. Create an XML-RPC authentication with a Moodle for this institution
- Parent authority = LDAP auth created above
- SSO direction = Yes
- Update user info on login = Yes
- We auto-create users = Yes
- We import content = Yes
* The Moodle instance needs to have LDAP set up as well.
-
3. Create an internal Mahara user (i.e. not LDAP)
- username: AAA (make sure this username exists in the LDAP directory)
-
* The username 'AAA' needs to be in Moodle created via LDAP.
4. Login to Moodle with the username AAA - the LDAP user
5. SSO to Mahara
This will do the following
- a new user record is created with username AAA1
- auth_remote_user table will link Mahara user AAA1 to Moodle user AAA
- 6. Logout of Mahara and Moodle.
+ 6. As Admin, update AAA1's auth metho to LDAP.
- 7. Run cron so LDAP syncs users
+ 7. Logout of Mahara and Moodle.
+
+ 8. Run cron so LDAP syncs users
Expected Results: user AAA1 to remain active in Mahara
Actual Results: user AAA1 is suspended because it matches on username (i.e.
AAA)
That is, this join is correct:
from {usr} u
inner join {auth_ldap_extusers_temp} e on u.username = e.extusername
-
The username in auth_ldap_extusers_temp is: AAA
The LDAP username in Mahara is: AAA1
Hence, it will not match on username and think the user is no longer in
the LDAP directory and suspend the user.
The join needs to be on another field that is present in both LDAP and
Mahara.
We should also join to the auth_remote_user table to get the correct
external username.
i.e.
select
u.id as id,
aru.remoteusername as username,
u.suspendedreason as suspendedreason,
...
from {usr} u
inner join {auth_remote_user} aru on u.id = aru.localusr
inner join {auth_ldap_extusers_temp} e on aru.remoteusername = e.extusername
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1833495
Title:
Syncing LDAP usernames with Mahara's internal username leads to
incorrect user record matching
Status in Mahara:
New
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF / Chrome (really n/a)
The LDAP sync_users() functionality is not correctly matching user
records - i.e. LDAP username with Mahara username.
Scenario:
1. Create an institution with and LDAP authentication
- Update user info on login = Yes
- We auto-create users = Yes
- Sync users automatically via cron job = Yes
- Update user info in cron = Yes
- Auto-create users in cron = Yes
- If a user is no longer present in LDAP = Suspend user's account
2. Create an XML-RPC authentication with a Moodle for this institution
- Parent authority = LDAP auth created above
- SSO direction = Yes
- Update user info on login = Yes
- We auto-create users = Yes
- We import content = Yes
* The Moodle instance needs to have LDAP set up as well.
3. Create an internal Mahara user (i.e. not LDAP)
- username: AAA (make sure this username exists in the LDAP directory)
* The username 'AAA' needs to be in Moodle created via LDAP.
4. Login to Moodle with the username AAA - the LDAP user
5. SSO to Mahara
This will do the following
- a new user record is created with username AAA1
- auth_remote_user table will link Mahara user AAA1 to Moodle user AAA
6. As Admin, update AAA1's auth method to LDAP.
7. Logout of Mahara and Moodle.
8. Run cron so LDAP syncs users
Expected Results: user AAA1 to remain active in Mahara
Actual Results: user AAA1 is suspended because it matches on username (i.e.
AAA)
That is, this join is correct:
from {usr} u
inner join {auth_ldap_extusers_temp} e on u.username = e.extusername
The username in auth_ldap_extusers_temp is: AAA
The LDAP username in Mahara is: AAA1
Hence, it will not match on username and think the user is no longer
in the LDAP directory and suspend the user.
The join needs to be on another field that is present in both LDAP and
Mahara.
We should also join to the auth_remote_user table to get the correct
external username.
i.e.
select
u.id as id,
aru.remoteusername as username,
u.su
[Mahara-contributors] [Bug 1833495] [NEW] Syncing LDAP usernames with Mahara's internal username leads to incorrect user record matching
Public bug reported:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF / Chrome (really n/a)
The LDAP sync_users() functionality is not correctly matching user
records - i.e. LDAP username with Mahara username.
Scenario:
1. Create an institution with and LDAP authentication
- Update user info on login = Yes
- We auto-create users = Yes
- Sync users automatically via cron job = Yes
- Update user info in cron = Yes
- Auto-create users in cron = Yes
- If a user is no longer present in LDAP = Suspend user's account
2. Create an XML-RPC authentication with a Moodle for this institution
- Parent authority = LDAP auth created above
- SSO direction = Yes
- Update user info on login = Yes
- We auto-create users = Yes
- We import content = Yes
* The Moodle instance needs to have LDAP set up as well.
3. Create an internal Mahara user (i.e. not LDAP)
- username: AAA (make sure this username exists in the LDAP directory)
* The username 'AAA' needs to be in Moodle created via LDAP.
4. Login to Moodle with the username AAA - the LDAP user
5. SSO to Mahara
This will do the following
- a new user record is created with username AAA1
- auth_remote_user table will link Mahara user AAA1 to Moodle user AAA
6. Logout of Mahara and Moodle.
7. Run cron so LDAP syncs users
Expected Results: user AAA1 to remain active in Mahara
Actual Results: user AAA1 is suspended because it matches on username (i.e. AAA)
That is, this join is correct:
from {usr} u
inner join {auth_ldap_extusers_temp} e on u.username = e.extusername
The username in auth_ldap_extusers_temp is: AAA
The LDAP username in Mahara is: AAA1
Hence, it will not match on username and think the user is no longer in
the LDAP directory and suspend the user.
The join needs to be on another field that is present in both LDAP and
Mahara.
We should also join to the auth_remote_user table to get the correct
external username.
i.e.
select
u.id as id,
aru.remoteusername as username,
u.suspendedreason as suspendedreason,
...
from {usr} u
inner join {auth_remote_user} aru on u.id = aru.localusr
inner join {auth_ldap_extusers_temp} e on aru.remoteusername = e.extusername
** Affects: mahara
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1833495
Title:
Syncing LDAP usernames with Mahara's internal username leads to
incorrect user record matching
Status in Mahara:
New
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF / Chrome (really n/a)
The LDAP sync_users() functionality is not correctly matching user
records - i.e. LDAP username with Mahara username.
Scenario:
1. Create an institution with and LDAP authentication
- Update user info on login = Yes
- We auto-create users = Yes
- Sync users automatically via cron job = Yes
- Update user info in cron = Yes
- Auto-create users in cron = Yes
- If a user is no longer present in LDAP = Suspend user's account
2. Create an XML-RPC authentication with a Moodle for this institution
- Parent authority = LDAP auth created above
- SSO direction = Yes
- Update user info on login = Yes
- We auto-create users = Yes
- We import content = Yes
* The Moodle instance needs to have LDAP set up as well.
3. Create an internal Mahara user (i.e. not LDAP)
- username: AAA (make sure this username exists in the LDAP directory)
* The username 'AAA' needs to be in Moodle created via LDAP.
4. Login to Moodle with the username AAA - the LDAP user
5. SSO to Mahara
This will do the following
- a new user record is created with username AAA1
- auth_remote_user table will link Mahara user AAA1 to Moodle user AAA
6. Logout of Mahara and Moodle.
7. Run cron so LDAP syncs users
Expected Results: user AAA1 to remain active in Mahara
Actual Results: user AAA1 is suspended because it matches on username (i.e.
AAA)
That is, this join is correct:
from {usr} u
inner join {auth_ldap_extusers_temp} e on u.username = e.extusername
The username in auth_ldap_extusers_temp is: AAA
The LDAP username in Mahara is: AAA1
Hence, it will not match on username and think the user is no longer
in the LDAP directory and suspend the user.
The join needs to be on another field that is present in both LDAP and
Mahara.
We should also join to the auth_remote_user table to get the correct
external username.
i.e.
select
u.id as id,
aru.remoteusername as username,
u.suspendedreason as suspendedreason,
...
from {usr} u
inner join {auth_remote_user} aru on u.id = aru.localusr
inner join {auth_ldap_extusers_temp} e on aru.remoteusername = e.extusername
To manage notifications about this bug go to:
https://bugs
[Mahara-contributors] [Bug 1833481] [NEW] Anchor links not working on Legal page
Public bug reported: BUG SUMMARY: When creating a page I want to link to something further down the page. I create an anchor at bottom of page and a link near top of page. when viewing the page and clicking the link, the page does not scroll to bottom == Environment tested: Master Browser tested: Chrome PRECONDITIONS: n/a TEST STEPS: 1. Create a long "Privacy statement" in Admin menu -> Configure site -> Legal. 2. Place an anchor towards the bottom of the page. 3. At the beginning of the page, link to the anchor. Do not enter a URL, just the anchor. (It should display as "#user_[youranchorname]" 4. View the page via the page footer and click the link to the anchor. Expected result: It jumps to that anchor (right now hidden behind header). Actual result: It doesn't do anything. EXPECTED RESULT: It jumps to that anchor (right now hidden behind header). ACTUAL RESULT: It doesn't do anything. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833481 Title: Anchor links not working on Legal page Status in Mahara: New Bug description: BUG SUMMARY: When creating a page I want to link to something further down the page. I create an anchor at bottom of page and a link near top of page. when viewing the page and clicking the link, the page does not scroll to bottom == Environment tested: Master Browser tested: Chrome PRECONDITIONS: n/a TEST STEPS: 1. Create a long "Privacy statement" in Admin menu -> Configure site -> Legal. 2. Place an anchor towards the bottom of the page. 3. At the beginning of the page, link to the anchor. Do not enter a URL, just the anchor. (It should display as "#user_[youranchorname]" 4. View the page via the page footer and click the link to the anchor. Expected result: It jumps to that anchor (right now hidden behind header). Actual result: It doesn't do anything. EXPECTED RESULT: It jumps to that anchor (right now hidden behind header). ACTUAL RESULT: It doesn't do anything. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833481/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1829803] A change has been merged
Reviewed: https://reviews.mahara.org/10031 Committed: https://git.mahara.org/mahara/mahara/commit/e0df7f630edd14e8efac801b5161bd98573941b0 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit e0df7f630edd14e8efac801b5161bd98573941b0 Author: Robert Lyon Date: Tue May 21 12:14:40 2019 +1200 Bug 1829803: Allow more optional values for the 'showmore' pagination This way if we need to use the showmore paginator elsewhere and need to pass thru things like viewid, blockid we can Also change the 'Show more' button from being a to a behatnotneeded Change-Id: I6c645016b5e9b141aabd2233e4fc9251a0088a69 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1829803 Title: Allow more optional values for the 'showmore' pagination Status in Mahara: In Progress Bug description: Currently there are two hardcoded options, 'group' and 'institution', but it would be easier if we just passed in an array and looped thru it. That way we can send other optional values at a later date To test: Make sure the 'Show more' button still works like before for portfolio page lists in user / group / institution / site areas To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1829803/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833034] Re: Error/warning/success messages remains unless page is refreshed
** Changed in: mahara/19.04 Milestone: None => 19.04.1 ** Changed in: mahara/19.04 Importance: Undecided => Medium ** Changed in: mahara/19.04 Status: New => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833034 Title: Error/warning/success messages remains unless page is refreshed Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome (and others) In the Files upload screen (and other screens that display error message): When a user accidentally clicks on the 'Create folder' icon before entering a folder name, a red error message appears: "Please provide a name for the new folder." When the user enters the folder name and clicks the button again, the folder is created but the red error message still appears. The message is only removed after the user refreshes the page. This can be misleading to the user. Can you lease clear the message when the folder is created - and display a success message? Another scenario: * The user creates a folder successfully. * The user then clicks into the new folder * Clicks the 'Create folder' button (in the child folder) without providing a name * The error message then appears * Clicks the up arrow to go to the parent folder. * The error message still appears - even though the user has moved out of the child folder. Expected, the error message should clear. Ideally, all alert messages in danger, warning, success classes should fade out after perhaps 10 seconds? This should be throughout the entire site not just the above screens. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833034/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833325] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10111 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833325 Title: Navigation block title is not set for other pages in collection Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF The title of a navigation block added to a page in a collection does not set the navigation title on the other pages in the collection. To reproduce: 1. Create 4 pages (Page 1, Page 2, Page 3, Page 4) 2. Create a new collection with Name = "Collection of Pages" 3. Add the 4 pages to the collection. 4. On Page 3, add a navigation block with the following settings: - Block title = "My title for Page 3" - Collection = "Collection of Pages" - Add to all pages = Yes - Save 5. Display the collection. Incorrect result: Pages 1, 2 and 4's navigation block title is: "Collection of Pages" Page 3 navigation block title is: "My title for Page 3" Expected result: All navigation blocks in the collection should be titled: "My title for Page 3" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833325/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833325] A change has been merged
Reviewed: https://reviews.mahara.org/10105 Committed: https://git.mahara.org/mahara/mahara/commit/bfb278addda28be9a4d1c72953c91778244a7135 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit bfb278addda28be9a4d1c72953c91778244a7135 Author: Ghada El-Zoghbi Date: Wed Jun 19 12:09:24 2019 +1000 Bug 1833325: Apply navigation block title to all pages in collection When adding a navigation block to all pages in a collection, include the block's title on all the other pages where the block will be added. Sponsored by The Australian National University behatnotneeded Change-Id: I0126dcbdc0bad5546f2b08f9bee347084b66f42c -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833325 Title: Navigation block title is not set for other pages in collection Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF The title of a navigation block added to a page in a collection does not set the navigation title on the other pages in the collection. To reproduce: 1. Create 4 pages (Page 1, Page 2, Page 3, Page 4) 2. Create a new collection with Name = "Collection of Pages" 3. Add the 4 pages to the collection. 4. On Page 3, add a navigation block with the following settings: - Block title = "My title for Page 3" - Collection = "Collection of Pages" - Add to all pages = Yes - Save 5. Display the collection. Incorrect result: Pages 1, 2 and 4's navigation block title is: "Collection of Pages" Page 3 navigation block title is: "My title for Page 3" Expected result: All navigation blocks in the collection should be titled: "My title for Page 3" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833325/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833034] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10110 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833034 Title: Error/warning/success messages remains unless page is refreshed Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome (and others) In the Files upload screen (and other screens that display error message): When a user accidentally clicks on the 'Create folder' icon before entering a folder name, a red error message appears: "Please provide a name for the new folder." When the user enters the folder name and clicks the button again, the folder is created but the red error message still appears. The message is only removed after the user refreshes the page. This can be misleading to the user. Can you lease clear the message when the folder is created - and display a success message? Another scenario: * The user creates a folder successfully. * The user then clicks into the new folder * Clicks the 'Create folder' button (in the child folder) without providing a name * The error message then appears * Clicks the up arrow to go to the parent folder. * The error message still appears - even though the user has moved out of the child folder. Expected, the error message should clear. Ideally, all alert messages in danger, warning, success classes should fade out after perhaps 10 seconds? This should be throughout the entire site not just the above screens. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833034/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833325] A change has been merged
Reviewed: https://reviews.mahara.org/10111 Committed: https://git.mahara.org/mahara/mahara/commit/93df21b5e657fe82176412df1fa75cf26ad289d5 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 93df21b5e657fe82176412df1fa75cf26ad289d5 Author: Ghada El-Zoghbi Date: Wed Jun 19 12:09:24 2019 +1000 Bug 1833325: Apply navigation block title to all pages in collection When adding a navigation block to all pages in a collection, include the block's title on all the other pages where the block will be added. Sponsored by The Australian National University behatnotneeded Change-Id: I0126dcbdc0bad5546f2b08f9bee347084b66f42c (cherry picked from commit bfb278addda28be9a4d1c72953c91778244a7135) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833325 Title: Navigation block title is not set for other pages in collection Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF The title of a navigation block added to a page in a collection does not set the navigation title on the other pages in the collection. To reproduce: 1. Create 4 pages (Page 1, Page 2, Page 3, Page 4) 2. Create a new collection with Name = "Collection of Pages" 3. Add the 4 pages to the collection. 4. On Page 3, add a navigation block with the following settings: - Block title = "My title for Page 3" - Collection = "Collection of Pages" - Add to all pages = Yes - Save 5. Display the collection. Incorrect result: Pages 1, 2 and 4's navigation block title is: "Collection of Pages" Page 3 navigation block title is: "My title for Page 3" Expected result: All navigation blocks in the collection should be titled: "My title for Page 3" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833325/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833034] A change has been merged
Reviewed: https://reviews.mahara.org/10110 Committed: https://git.mahara.org/mahara/mahara/commit/d05113f59537cdaee39b1d0aa89a13a96015d847 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit d05113f59537cdaee39b1d0aa89a13a96015d847 Author: Robert Lyon Date: Mon Jun 17 17:31:58 2019 +1200 Bug 1833034: Allow folder fail message be removed on success And show a success message Also remove metadata edit error message on form resubmit rather than appending the same message again behatnotneeded Change-Id: I31f99a6ca384b74ca3e2ea795055667811f58e0a Signed-off-by: Robert Lyon (cherry picked from commit e69b8a8546e57fd7c499350574e022bb34e200f1) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833034 Title: Error/warning/success messages remains unless page is refreshed Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome (and others) In the Files upload screen (and other screens that display error message): When a user accidentally clicks on the 'Create folder' icon before entering a folder name, a red error message appears: "Please provide a name for the new folder." When the user enters the folder name and clicks the button again, the folder is created but the red error message still appears. The message is only removed after the user refreshes the page. This can be misleading to the user. Can you lease clear the message when the folder is created - and display a success message? Another scenario: * The user creates a folder successfully. * The user then clicks into the new folder * Clicks the 'Create folder' button (in the child folder) without providing a name * The error message then appears * Clicks the up arrow to go to the parent folder. * The error message still appears - even though the user has moved out of the child folder. Expected, the error message should clear. Ideally, all alert messages in danger, warning, success classes should fade out after perhaps 10 seconds? This should be throughout the entire site not just the above screens. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833034/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833325] Re: Navigation block title is not set for other pages in collection
** Also affects: mahara/19.04 Importance: Undecided Status: New ** Also affects: mahara/19.10 Importance: Undecided Assignee: Ghada El-Zoghbi (ghada-z) Status: New ** Changed in: mahara/19.04 Importance: Undecided => High ** Changed in: mahara/19.10 Importance: Undecided => High ** Changed in: mahara/19.10 Status: New => Fix Committed ** Changed in: mahara/19.04 Status: New => Fix Committed ** Changed in: mahara/19.10 Milestone: None => 19.10.0 ** Changed in: mahara/19.04 Milestone: None => 19.04.1 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833325 Title: Navigation block title is not set for other pages in collection Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF The title of a navigation block added to a page in a collection does not set the navigation title on the other pages in the collection. To reproduce: 1. Create 4 pages (Page 1, Page 2, Page 3, Page 4) 2. Create a new collection with Name = "Collection of Pages" 3. Add the 4 pages to the collection. 4. On Page 3, add a navigation block with the following settings: - Block title = "My title for Page 3" - Collection = "Collection of Pages" - Add to all pages = Yes - Save 5. Display the collection. Incorrect result: Pages 1, 2 and 4's navigation block title is: "Collection of Pages" Page 3 navigation block title is: "My title for Page 3" Expected result: All navigation blocks in the collection should be titled: "My title for Page 3" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833325/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833034] A change has been merged
Reviewed: https://reviews.mahara.org/10090 Committed: https://git.mahara.org/mahara/mahara/commit/e69b8a8546e57fd7c499350574e022bb34e200f1 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit e69b8a8546e57fd7c499350574e022bb34e200f1 Author: Robert Lyon Date: Mon Jun 17 17:31:58 2019 +1200 Bug 1833034: Allow folder fail message be removed on success And show a success message Also remove metadata edit error message on form resubmit rather than appending the same message again behatnotneeded Change-Id: I31f99a6ca384b74ca3e2ea795055667811f58e0a Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833034 Title: Error/warning/success messages remains unless page is refreshed Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome (and others) In the Files upload screen (and other screens that display error message): When a user accidentally clicks on the 'Create folder' icon before entering a folder name, a red error message appears: "Please provide a name for the new folder." When the user enters the folder name and clicks the button again, the folder is created but the red error message still appears. The message is only removed after the user refreshes the page. This can be misleading to the user. Can you lease clear the message when the folder is created - and display a success message? Another scenario: * The user creates a folder successfully. * The user then clicks into the new folder * Clicks the 'Create folder' button (in the child folder) without providing a name * The error message then appears * Clicks the up arrow to go to the parent folder. * The error message still appears - even though the user has moved out of the child folder. Expected, the error message should clear. Ideally, all alert messages in danger, warning, success classes should fade out after perhaps 10 seconds? This should be throughout the entire site not just the above screens. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833034/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833034] Re: Error/warning/success messages remains unless page is refreshed
** Changed in: mahara Status: New => Fix Committed ** Changed in: mahara Milestone: None => 19.10.0 ** Changed in: mahara Importance: Undecided => Medium ** Also affects: mahara/19.04 Importance: Undecided Status: New ** Also affects: mahara/19.10 Importance: Medium Status: Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833034 Title: Error/warning/success messages remains unless page is refreshed Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome (and others) In the Files upload screen (and other screens that display error message): When a user accidentally clicks on the 'Create folder' icon before entering a folder name, a red error message appears: "Please provide a name for the new folder." When the user enters the folder name and clicks the button again, the folder is created but the red error message still appears. The message is only removed after the user refreshes the page. This can be misleading to the user. Can you lease clear the message when the folder is created - and display a success message? Another scenario: * The user creates a folder successfully. * The user then clicks into the new folder * Clicks the 'Create folder' button (in the child folder) without providing a name * The error message then appears * Clicks the up arrow to go to the parent folder. * The error message still appears - even though the user has moved out of the child folder. Expected, the error message should clear. Ideally, all alert messages in danger, warning, success classes should fade out after perhaps 10 seconds? This should be throughout the entire site not just the above screens. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833034/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1828150] Re: clicking on calendar icon doesnt bring up the datepicker on calendar inputs
** Changed in: mahara/19.04 Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1828150 Title: clicking on calendar icon doesnt bring up the datepicker on calendar inputs Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: to replicate: - on a calendar input, click on the calendar icon expected result: the datepicker appears actual result: nothing happens a list of pages where the calendar may appear: -/artefact/resume/index.php -/view/urls.php?id= -> needs an id of the page -/admin/users/edit.php?id= -> needs an id of the page -/admin/users/institutions.php -/group/edit.php?id=__ -> needs an id of the page -/admin/users/statistics.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1828150/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1828150] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10109 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1828150 Title: clicking on calendar icon doesnt bring up the datepicker on calendar inputs Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: to replicate: - on a calendar input, click on the calendar icon expected result: the datepicker appears actual result: nothing happens a list of pages where the calendar may appear: -/artefact/resume/index.php -/view/urls.php?id= -> needs an id of the page -/admin/users/edit.php?id= -> needs an id of the page -/admin/users/institutions.php -/group/edit.php?id=__ -> needs an id of the page -/admin/users/statistics.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1828150/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1828150] Re: clicking on calendar icon doesnt bring up the datepicker on calendar inputs
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1828150 Title: clicking on calendar icon doesnt bring up the datepicker on calendar inputs Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: to replicate: - on a calendar input, click on the calendar icon expected result: the datepicker appears actual result: nothing happens a list of pages where the calendar may appear: -/artefact/resume/index.php -/view/urls.php?id= -> needs an id of the page -/admin/users/edit.php?id= -> needs an id of the page -/admin/users/institutions.php -/group/edit.php?id=__ -> needs an id of the page -/admin/users/statistics.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1828150/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1828150] A change has been merged
Reviewed: https://reviews.mahara.org/10109 Committed: https://git.mahara.org/mahara/mahara/commit/d3af5786deea79f2e7b437f157e256cb9b551759 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit d3af5786deea79f2e7b437f157e256cb9b551759 Author: Liam Date: Wed May 8 15:14:52 2019 +1200 Bug #1828150: clicking on calendar icon doesnt bring up the datepicker on calendar inputs behatnotneeded Change-Id: I39a5df01d3a01abfcd75f078bc8074cb870d424d (cherry picked from commit c27982479e346e4d454c8029161c588ff5dd3630) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1828150 Title: clicking on calendar icon doesnt bring up the datepicker on calendar inputs Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: to replicate: - on a calendar input, click on the calendar icon expected result: the datepicker appears actual result: nothing happens a list of pages where the calendar may appear: -/artefact/resume/index.php -/view/urls.php?id= -> needs an id of the page -/admin/users/edit.php?id= -> needs an id of the page -/admin/users/institutions.php -/group/edit.php?id=__ -> needs an id of the page -/admin/users/statistics.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1828150/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1828150] A change has been merged
Reviewed: https://reviews.mahara.org/9980 Committed: https://git.mahara.org/mahara/mahara/commit/c27982479e346e4d454c8029161c588ff5dd3630 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit c27982479e346e4d454c8029161c588ff5dd3630 Author: Liam Date: Wed May 8 15:14:52 2019 +1200 Bug #1828150: clicking on calendar icon doesnt bring up the datepicker on calendar inputs behatnotneeded Change-Id: I39a5df01d3a01abfcd75f078bc8074cb870d424d -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1828150 Title: clicking on calendar icon doesnt bring up the datepicker on calendar inputs Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: to replicate: - on a calendar input, click on the calendar icon expected result: the datepicker appears actual result: nothing happens a list of pages where the calendar may appear: -/artefact/resume/index.php -/view/urls.php?id= -> needs an id of the page -/admin/users/edit.php?id= -> needs an id of the page -/admin/users/institutions.php -/group/edit.php?id=__ -> needs an id of the page -/admin/users/statistics.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1828150/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] Re: Datepicker doesnt work with different date formats
** Changed in: mahara/19.04 Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] A change has been merged
Reviewed: https://reviews.mahara.org/10108 Committed: https://git.mahara.org/mahara/mahara/commit/d3d2359ff4c12c1f2699da932c5e77c6edfafd21 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit d3d2359ff4c12c1f2699da932c5e77c6edfafd21 Author: Robert Lyon Date: Wed Jun 12 10:26:23 2019 +1200 Bug 1831689: Adjusting how we update dates on the the view access page There was a problem where we set up fields with empty date and then try to add a date to it Instead we should set up the datepicker with the date so that works out what type of date it is first so then can handle it correctly Note: if trying to use format DD/MM/ it will complain that it is a non-compatible date behatnotneeded Change-Id: I401e0812dc2c4189b715033fcf7b745c52425b05 Signed-off-by: Robert Lyon (cherry picked from commit afd9e7a726aef567921b9b275d44ac549947543e) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10108 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Fix Committed Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: Fix Committed Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] A change has been merged
Reviewed: https://reviews.mahara.org/10074 Committed: https://git.mahara.org/mahara/mahara/commit/afd9e7a726aef567921b9b275d44ac549947543e Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit afd9e7a726aef567921b9b275d44ac549947543e Author: Robert Lyon Date: Wed Jun 12 10:26:23 2019 +1200 Bug 1831689: Adjusting how we update dates on the the view access page There was a problem where we set up fields with empty date and then try to add a date to it Instead we should set up the datepicker with the date so that works out what type of date it is first so then can handle it correctly Note: if trying to use format DD/MM/ it will complain that it is a non-compatible date behatnotneeded Change-Id: I401e0812dc2c4189b715033fcf7b745c52425b05 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Fix Committed Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: Fix Committed Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] Re: Datepicker doesnt work with different date formats
** Changed in: mahara/19.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Fix Committed Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: Fix Committed Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833390] [NEW] Anchor hides behind header
Public bug reported: when you place an anchor into text and jump to it, the anchored text is not displayed, but you need to scroll a bit up to see it. The anchor link jumps all the way to the top of the view port. That places the anchor behind the top header with the logo and the navigation. Instead, the anchor should take that strip into consideration and display the text right below it thus effectively making the viewport smaller. The tricky thing here will be to take into consideration that the height of the header can vary depending on the site messages that are displayed. To replicate: 1. Create a page with a very long text, e.g. created via https://www.lipsum.com 2. Create an anchor in the text in the second paragraph. 3. Link to the anchor further down in the text. 4. Click "Display this page" and scroll down to the link. 5. Click the link. Expected result: The text to which the anchor points is displayed. Actual result: A few lines further down from the anchor are visible at the edge of the header and the anchor itself needs to be scrolled to as it is hidden by the header. ** Affects: mahara Importance: High Status: Confirmed ** Affects: mahara/19.04 Importance: High Status: Confirmed ** Affects: mahara/19.10 Importance: High Status: Confirmed ** Also affects: mahara/18.10 Importance: Undecided Status: New ** Also affects: mahara/19.10 Importance: Undecided Status: New ** Also affects: mahara/18.04 Importance: Undecided Status: New ** Also affects: mahara/19.04 Importance: Undecided Status: New ** No longer affects: mahara/18.04 ** No longer affects: mahara/18.10 ** Changed in: mahara/19.04 Status: New => Confirmed ** Changed in: mahara/19.10 Status: New => Confirmed ** Changed in: mahara/19.04 Importance: Undecided => High ** Changed in: mahara/19.10 Importance: Undecided => High ** Changed in: mahara/19.04 Milestone: None => 19.04.1 ** Changed in: mahara/19.10 Milestone: None => 19.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833390 Title: Anchor hides behind header Status in Mahara: Confirmed Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: Confirmed Bug description: when you place an anchor into text and jump to it, the anchored text is not displayed, but you need to scroll a bit up to see it. The anchor link jumps all the way to the top of the view port. That places the anchor behind the top header with the logo and the navigation. Instead, the anchor should take that strip into consideration and display the text right below it thus effectively making the viewport smaller. The tricky thing here will be to take into consideration that the height of the header can vary depending on the site messages that are displayed. To replicate: 1. Create a page with a very long text, e.g. created via https://www.lipsum.com 2. Create an anchor in the text in the second paragraph. 3. Link to the anchor further down in the text. 4. Click "Display this page" and scroll down to the link. 5. Click the link. Expected result: The text to which the anchor points is displayed. Actual result: A few lines further down from the anchor are visible at the edge of the header and the anchor itself needs to be scrolled to as it is hidden by the header. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833390/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
