[Mahara-contributors] [Bug 738263] Re: faulty contact us form with noreplyaddress configdirective
Patch submitted. Would someone please review? ** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/738263 Title: faulty contact us form with noreplyaddress configdirective Status in Mahara ePortfolio: In Progress Bug description: I am using Mahara 1.3.3 clean install on shared hosting with inmotionhosting, linux php 5.3, mysql. Everything works, but my emails sent by mahara are getting blocked. I had the same problem with my moodle installation, but was able to configure it with SMTP email and a defined, working noreply address. However, this is not working with mahara. The mail is actually sent, but is blocked at the destination because the user's profile email address is being used as the from field, instead of the noreplyaddress as defined. Since the email is coming from another domain, but claiming to be from the same domain as the recipient, it's blocked by the receiving mailserver (rightfully so). In doing the testing, I was following the troubleshooting info on the wiki and using the contact us form to send the test emails. Peeking around the code I see that that is a rather "crude" form that takes the email given and passes it on to phpmailer as the from address. The from email field is autopopulated since I am logged in, so the noreplyaddress is never used in this case. After fixing other problems, the contact form submissions still get blocked (obviously). In a case where the noreplyaddress config directive is set, the form should be smart enough to substitute that address for the entered address (or better yet-- apply that address to the reply-to address, and use the noreply address as the "from" or "sender" fields to comply with proper envelope format and accepted relay rules) since in effect mahara is using the mailserver as a relay. If that can't be done, perhaps you could include a switch to turn off the contact form and replace it with a email address url for contact (mailto) so the person trying to contact the admin can use their own mail system (less ideal I guess). Lastly, until this is fixed, and possibly after, the troubleshooting docs shouldn't suggest using this form to troubleshoot email since the form itself is the problem! Forum post with complete details: http://mahara.org/interaction/forum/topic.php?id=3110#post13442 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/738263/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 548021] Re: Option to not have a display name on Views
Does this still need work? I see there was a patch committed earlier, but the discussion seems to have progressed since then. I'm willing to start working on a patch to implement Aaron's ideas in comment 16 if that's desired. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/548021 Title: Option to not have a display name on Views Status in Mahara ePortfolio: In Progress Bug description: Currently all views show a display name. It would be good to have an option to just have a view title without 'by display name'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/548021/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1285862] Re: Block configuration dialog is inconsistent width
Hi Son. Are you still working on this? I'm looking at bugs to address while waiting on other tasks :) Nigel -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1285862 Title: Block configuration dialog is inconsistent width Status in Mahara ePortfolio: In Progress Bug description: In Mahara 1.8 the block configuration dialog is fairly narrow and expands to fit its content (if there is a file browser, HTML editor, etc.) In latest master the dialog can be anything from very narrow (where it cuts off the edge of the file browser) to very wide (where it fills the screen and leaves massive amounts of white space everywhere). I can't reliably reproduce any of these widths. This is probably an issue in setDialogPosition() in views.js, which was changed when the page editor was made keyboard-accessible. I've attached a couple of screenshots showing this inconsistency (not the most extreme examples, but you get the idea ...) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1285862/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1323495] Re: Google Maps URLs not working in Google Apps block
Patch available at https://reviews.mahara.org/#/c/3471/. ** Changed in: mahara/1.10 Status: Confirmed => In Progress ** Changed in: mahara/1.10 Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1323495 Title: Google Maps URLs not working in Google Apps block Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: In Progress Status in Mahara 1.7 series: New Status in Mahara 1.8 series: New Status in Mahara 1.9 series: New Bug description: See forum discussion https://mahara.org/interaction/forum/topic.php?id=5122&offset=10&limit=10#post26773 Posting a map by its sharing iframe works. But posting a map by its URL does not. Dirk also reported a Google Maps iframe with a URL that started with "www.google.com" instead of "maps.google.com". It's not entirely clear whether this is an older Google Maps URL that we've broken compatibility with, a newer one that we need to adapt to. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1323495/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1271420] Re: Duplicate newlines in forum post notifications if you turn off the HTML editor
** Changed in: mahara/1.10 Status: Confirmed => In Progress ** Changed in: mahara/1.10 Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271420 Title: Duplicate newlines in forum post notifications if you turn off the HTML editor Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: In Progress Status in Mahara 1.9 series: Confirmed Bug description: To replicate: 1. Go to your user account settings and turn the HTML editor off 2. Set the forum post delay to 0 minutes (to make testing quicker) 3. Make a forum post that runs across multiple newlines. 4. Look in your Inbox, and look at the email you receive Expected result: You should see one newline in the message for each newline in the original post Actual result: You'll see two newlines in the message for each one in the original post. This does not seem to happen when the HTML editor (TinyMCE) is active. Possibly TinyMCE strips out the newlines from the text before saving it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271420/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1271420] Re: Duplicate newlines in forum post notifications if you turn off the HTML editor
Diagnosis so far (going home for the day now): Text comes in as "Test\r\nTest" Mahara/lib/web.php::format_whitespace (line 3165) changes this to Test\nTest Mahara/interaction/forum/lib.php:ActivityTypeInteractionForumNewPost->__construct (Line 939) then does $post->textbody = trim(html2text($post->body)); giving the two "\n"s. So it looks like format_whitespace needs to just put or just \n... will see tomorrow, Lord willing. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271420 Title: Duplicate newlines in forum post notifications if you turn off the HTML editor Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: In Progress Status in Mahara 1.9 series: Confirmed Bug description: To replicate: 1. Go to your user account settings and turn the HTML editor off 2. Set the forum post delay to 0 minutes (to make testing quicker) 3. Make a forum post that runs across multiple newlines. 4. Look in your Inbox, and look at the email you receive Expected result: You should see one newline in the message for each newline in the original post Actual result: You'll see two newlines in the message for each one in the original post. This does not seem to happen when the HTML editor (TinyMCE) is active. Possibly TinyMCE strips out the newlines from the text before saving it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271420/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1337614] [NEW] Deleting a forum topic works but reports an error
Public bug reported: While testing another bug (#1271240), I decided to delete the topic (while running 1.10dev) and received the following call trace: log_message("Undefined property: stdClass::$reported", 8, true, true, "/home/nigelc/Programming/mahara/htdocs/interaction...", 89) at /home/nigelc/Programming/mahara/htdocs/lib/errors.php:433 error(8, "Undefined property: stdClass::$reported", "/home/nigelc/Programming/mahara/htdocs/interaction...", 89, array(size 6)) at /home/nigelc/Programming/mahara/htdocs/interaction/forum/deletetopic.php:89 deletetopic_submit(object(Pieform), array(size 3)) at Unknown:0 call_user_func_array("deletetopic_submit", array(size 2)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:527 Pieform->__construct(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:162 Pieform::process(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:71 pieform(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/interaction/forum/deletetopic.php:83 The topic was deleted. ** Affects: mahara Importance: Undecided Status: New ** Tags: forums -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1337614 Title: Deleting a forum topic works but reports an error Status in Mahara ePortfolio: New Bug description: While testing another bug (#1271240), I decided to delete the topic (while running 1.10dev) and received the following call trace: log_message("Undefined property: stdClass::$reported", 8, true, true, "/home/nigelc/Programming/mahara/htdocs/interaction...", 89) at /home/nigelc/Programming/mahara/htdocs/lib/errors.php:433 error(8, "Undefined property: stdClass::$reported", "/home/nigelc/Programming/mahara/htdocs/interaction...", 89, array(size 6)) at /home/nigelc/Programming/mahara/htdocs/interaction/forum/deletetopic.php:89 deletetopic_submit(object(Pieform), array(size 3)) at Unknown:0 call_user_func_array("deletetopic_submit", array(size 2)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:527 Pieform->__construct(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:162 Pieform::process(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:71 pieform(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/interaction/forum/deletetopic.php:83 The topic was deleted. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1337614/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1271420] Re: Duplicate newlines in forum post notifications if you turn off the HTML editor
The attached patch deals with the issue as reported. That said, turning back on the HTML editor, I've noted that it suffers from the same problem but for an entirely different reason. Given this is a reply this is a second line of a reply html2text returns this is a reply this is a second line of a reply So then, should this bug have its scope extended? ** Patch added: "Patch for 1271420" https://bugs.launchpad.net/mahara/1.10/+bug/1271420/+attachment/4145103/+files/1271420.patch -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271420 Title: Duplicate newlines in forum post notifications if you turn off the HTML editor Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: In Progress Status in Mahara 1.9 series: Confirmed Bug description: To replicate: 1. Go to your user account settings and turn the HTML editor off 2. Set the forum post delay to 0 minutes (to make testing quicker) 3. Make a forum post that runs across multiple newlines. 4. Look in your Inbox, and look at the email you receive Expected result: You should see one newline in the message for each newline in the original post Actual result: You'll see two newlines in the message for each one in the original post. This does not seem to happen when the HTML editor (TinyMCE) is active. Possibly TinyMCE strips out the newlines from the text before saving it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271420/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1337614] Re: Deleting a forum topic works but reports an error
On further investigation, I think the database upgrade is blocked, due to the chat module: [WAR] f7 (lib/upgrade.php:161) Plugin module chat is not installable: Plugin module chat is missing version.php. Call stack (most recent first): log_message("Plugin module chat is not installable: Plugin modu...", 8, true, true) at /home/nigelc/Programming/mahara/htdocs/lib/errors.php:95 log_warn("Plugin module chat is not installable: Plugin modu...") at /home/nigelc/Programming/mahara/htdocs/lib/upgrade.php:161 check_upgrades() at /home/nigelc/Programming/mahara/htdocs/admin/index.php:31 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1337614 Title: Deleting a forum topic works but reports an error Status in Mahara ePortfolio: New Bug description: While testing another bug (#1271240), I decided to delete the topic (while running 1.10dev) and received the following call trace: log_message("Undefined property: stdClass::$reported", 8, true, true, "/home/nigelc/Programming/mahara/htdocs/interaction...", 89) at /home/nigelc/Programming/mahara/htdocs/lib/errors.php:433 error(8, "Undefined property: stdClass::$reported", "/home/nigelc/Programming/mahara/htdocs/interaction...", 89, array(size 6)) at /home/nigelc/Programming/mahara/htdocs/interaction/forum/deletetopic.php:89 deletetopic_submit(object(Pieform), array(size 3)) at Unknown:0 call_user_func_array("deletetopic_submit", array(size 2)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:527 Pieform->__construct(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:162 Pieform::process(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:71 pieform(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/interaction/forum/deletetopic.php:83 The topic was deleted. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1337614/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1337614] Re: Deleting a forum topic works but reports an error
..nope. The database was fully upgraded. This is just further fallout from the objectionable material refactoring. Patch coming... ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1337614 Title: Deleting a forum topic works but reports an error Status in Mahara ePortfolio: New Bug description: While testing another bug (#1271240), I decided to delete the topic (while running 1.10dev) and received the following call trace: log_message("Undefined property: stdClass::$reported", 8, true, true, "/home/nigelc/Programming/mahara/htdocs/interaction...", 89) at /home/nigelc/Programming/mahara/htdocs/lib/errors.php:433 error(8, "Undefined property: stdClass::$reported", "/home/nigelc/Programming/mahara/htdocs/interaction...", 89, array(size 6)) at /home/nigelc/Programming/mahara/htdocs/interaction/forum/deletetopic.php:89 deletetopic_submit(object(Pieform), array(size 3)) at Unknown:0 call_user_func_array("deletetopic_submit", array(size 2)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:527 Pieform->__construct(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:162 Pieform::process(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:71 pieform(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/interaction/forum/deletetopic.php:83 The topic was deleted. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1337614/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1337614] Re: Deleting a forum topic works but reports an error
** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1337614 Title: Deleting a forum topic works but reports an error Status in Mahara ePortfolio: In Progress Bug description: While testing another bug (#1271240), I decided to delete the topic (while running 1.10dev) and received the following call trace: log_message("Undefined property: stdClass::$reported", 8, true, true, "/home/nigelc/Programming/mahara/htdocs/interaction...", 89) at /home/nigelc/Programming/mahara/htdocs/lib/errors.php:433 error(8, "Undefined property: stdClass::$reported", "/home/nigelc/Programming/mahara/htdocs/interaction...", 89, array(size 6)) at /home/nigelc/Programming/mahara/htdocs/interaction/forum/deletetopic.php:89 deletetopic_submit(object(Pieform), array(size 3)) at Unknown:0 call_user_func_array("deletetopic_submit", array(size 2)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:527 Pieform->__construct(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:162 Pieform::process(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/lib/pieforms/pieform.php:71 pieform(array(size 4)) at /home/nigelc/Programming/mahara/htdocs/interaction/forum/deletetopic.php:83 The topic was deleted. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1337614/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1324316] Re: Old PHP sessions files never get deleted
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1324316 Title: Old PHP sessions files never get deleted Status in Mahara ePortfolio: In Progress Bug description: As reported on the forum: https://mahara.org/interaction/forum/topic.php?id=6331 Normally PHP session files get deleted by a cron job in the filesystem, that is installed as part of the PHP module (in Debian & Ubuntu). But Mahara does not store its session files in the default location. Instead, it overrides session.save_path to save session files in its own custom location under $CFG->dataroot. As a result, Mahara session files do not get regularly deleted, unless the server owner has changed their default location or set up a special cron job to clean them up (or if you're using the memcached patch for session management). We need to add a Mahara internal crontask that checks for old session files and deletes them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1324316/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1324316] Re: Old PHP sessions files never get deleted
This doesn't seem right to me. Mahara's internal cron system includes a task for invoking auth_remove_old_session_files in auth/lib.php. Perhaps the Mahara cron task wasn't being run on the system in question? (Next scheduled run times are recorded in the cron table - if a task has never run, nextrun will be NULL). -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1324316 Title: Old PHP sessions files never get deleted Status in Mahara ePortfolio: In Progress Bug description: As reported on the forum: https://mahara.org/interaction/forum/topic.php?id=6331 Normally PHP session files get deleted by a cron job in the filesystem, that is installed as part of the PHP module (in Debian & Ubuntu). But Mahara does not store its session files in the default location. Instead, it overrides session.save_path to save session files in its own custom location under $CFG->dataroot. As a result, Mahara session files do not get regularly deleted, unless the server owner has changed their default location or set up a special cron job to clean them up (or if you're using the memcached patch for session management). We need to add a Mahara internal crontask that checks for old session files and deletes them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1324316/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1324316] Re: Old PHP sessions files never get deleted
(Not marking Invalid yet because I'm relatively new to Mahara and will therefore leave room for having misdiagnosed things). -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1324316 Title: Old PHP sessions files never get deleted Status in Mahara ePortfolio: In Progress Bug description: As reported on the forum: https://mahara.org/interaction/forum/topic.php?id=6331 Normally PHP session files get deleted by a cron job in the filesystem, that is installed as part of the PHP module (in Debian & Ubuntu). But Mahara does not store its session files in the default location. Instead, it overrides session.save_path to save session files in its own custom location under $CFG->dataroot. As a result, Mahara session files do not get regularly deleted, unless the server owner has changed their default location or set up a special cron job to clean them up (or if you're using the memcached patch for session management). We need to add a Mahara internal crontask that checks for old session files and deletes them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1324316/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1301109] Re: Remove pre-1.1.0 sections of the core plugins' update scripts.
** Changed in: mahara/1.10 Status: Confirmed => In Progress ** Changed in: mahara/1.10 Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1301109 Title: Remove pre-1.1.0 sections of the core plugins' update scripts. Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: In Progress Bug description: In Mahara 1.8, we dropped support for upgrading from Mahara versions prior to 1.1.0, and we removed a big chunk of htdocs/lib/db/upgrade.php that covered all the pre-1.1.0 upgrade stuff. BUT, all the core plugins also have their own db/upgrade.php files, and many of these still have big sections of pre-1.1.0 upgrade stuff as well! We should: 1. Find out what version each core plugin was it in the 1.1.0_RELEASE tag 2. Strip out all the upgrade.php sections where the version number is less than or equal to the 1.1.0 version number. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1301109/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 738263] Re: faulty contact us form with noreplyaddress configdirective
Hi Ghada. If I've understood things correctly, the point wasn't to hide the email address, but rather to enable messages to be delivered that would otherwise rightly be rejected (see the OP's description). Imagine I'm using a Mahara installation running on mahara.example.org. My email address is u...@user1.org and I attempt to send a message to another_u...@user2.net. With the configuration described above, mahara.example.org will attempt to send a message claiming to be from u...@user1.org. If user2.net is properly configured, it will reject mahara.example.org's attempt at sending the email because mahara.example.org is not user1.org. If on the other hand mahara.example.org attempts to send an email from mahara- nore...@mahara.example.org with a Reply-to of u...@user1.org, the message should be accepted. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/738263 Title: faulty contact us form with noreplyaddress configdirective Status in Mahara ePortfolio: In Progress Bug description: I am using Mahara 1.3.3 clean install on shared hosting with inmotionhosting, linux php 5.3, mysql. Everything works, but my emails sent by mahara are getting blocked. I had the same problem with my moodle installation, but was able to configure it with SMTP email and a defined, working noreply address. However, this is not working with mahara. The mail is actually sent, but is blocked at the destination because the user's profile email address is being used as the from field, instead of the noreplyaddress as defined. Since the email is coming from another domain, but claiming to be from the same domain as the recipient, it's blocked by the receiving mailserver (rightfully so). In doing the testing, I was following the troubleshooting info on the wiki and using the contact us form to send the test emails. Peeking around the code I see that that is a rather "crude" form that takes the email given and passes it on to phpmailer as the from address. The from email field is autopopulated since I am logged in, so the noreplyaddress is never used in this case. After fixing other problems, the contact form submissions still get blocked (obviously). In a case where the noreplyaddress config directive is set, the form should be smart enough to substitute that address for the entered address (or better yet-- apply that address to the reply-to address, and use the noreply address as the "from" or "sender" fields to comply with proper envelope format and accepted relay rules) since in effect mahara is using the mailserver as a relay. If that can't be done, perhaps you could include a switch to turn off the contact form and replace it with a email address url for contact (mailto) so the person trying to contact the admin can use their own mail system (less ideal I guess). Lastly, until this is fixed, and possibly after, the troubleshooting docs shouldn't suggest using this form to troubleshoot email since the form itself is the problem! Forum post with complete details: http://mahara.org/interaction/forum/topic.php?id=3110#post13442 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/738263/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1338394] [NEW] Tinymce editor can incorrectly appear in profile edit page
Public bug reported: Mahara version: Master/HEAD OS: Linux with FF30, Windows Vista with IE 9 The upgrade to TinyMCE 4.0.16 (Bug #1282341) added htdocs/js/tinymce/skins/lightgray/skin.min.css. This file includes css: .mce-tinymce { position: relative; visibility: visible !important; } On the profile edit page (http://mahara/artefact/internal/index.php), the only TinyMCE editor in use appears in the first tab, and therefore doesn't normally cause any noticable issue. If a user tries to add an email address via the second tab and their address fails the validation, the Profile page will reload with the focus being on the second tab. After a brief delay, the TinyMCE editor from the Introduction field on the first tab will appear over the top of the email address fields. The editor appears because the non-selected tabs don't have the 'collapsed' class added to them at the time the page is loaded. Instead, the safe-hidden class only is applied. The collapsed class is effective in hiding the editor and the safe-hidden class isn't. I've looked into the git history and Googled the 2 class names, and I couldn't get a clear understanding as to which there are 2 classes. I assume it's somehow related to browser differences, and have therefore provided a simple, minimal patch that ensures both classes are applied to tabs or neither is applied. In my testing on Firefox and IE 9, this addressed the observed bug. ** Affects: mahara Importance: Undecided Status: New ** Patch added: "profile-tabs.patch" https://bugs.launchpad.net/bugs/1338394/+attachment/4146842/+files/profile-tabs.patch -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1338394 Title: Tinymce editor can incorrectly appear in profile edit page Status in Mahara ePortfolio: New Bug description: Mahara version: Master/HEAD OS: Linux with FF30, Windows Vista with IE 9 The upgrade to TinyMCE 4.0.16 (Bug #1282341) added htdocs/js/tinymce/skins/lightgray/skin.min.css. This file includes css: .mce-tinymce { position: relative; visibility: visible !important; } On the profile edit page (http://mahara/artefact/internal/index.php), the only TinyMCE editor in use appears in the first tab, and therefore doesn't normally cause any noticable issue. If a user tries to add an email address via the second tab and their address fails the validation, the Profile page will reload with the focus being on the second tab. After a brief delay, the TinyMCE editor from the Introduction field on the first tab will appear over the top of the email address fields. The editor appears because the non-selected tabs don't have the 'collapsed' class added to them at the time the page is loaded. Instead, the safe-hidden class only is applied. The collapsed class is effective in hiding the editor and the safe-hidden class isn't. I've looked into the git history and Googled the 2 class names, and I couldn't get a clear understanding as to which there are 2 classes. I assume it's somehow related to browser differences, and have therefore provided a simple, minimal patch that ensures both classes are applied to tabs or neither is applied. In my testing on Firefox and IE 9, this addressed the observed bug. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1338394/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 548021] Re: Option to not have a display name on Views
** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/548021 Title: Option to not have a display name on Views Status in Mahara ePortfolio: In Progress Bug description: Currently all views show a display name. It would be good to have an option to just have a view title without 'by display name'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/548021/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1338941] [NEW] type=innodb invalid in MySQL 5.1
Public bug reported: Installation fails when you have MySQL 5.5 and later because type=INNODB has been deprecated and then removed. Google for "type=innodb" to see examples of this being changed in other database creation code. ** Affects: mahara Importance: Undecided Status: Invalid -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1338941 Title: type=innodb invalid in MySQL 5.1 Status in Mahara ePortfolio: Invalid Bug description: Installation fails when you have MySQL 5.5 and later because type=INNODB has been deprecated and then removed. Google for "type=innodb" to see examples of this being changed in other database creation code. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1338941/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1338941] Re: type=innodb invalid in MySQL 5.1
Hmm. Seem to have been working off an old branch. Found the commit that fixed this. ** Changed in: mahara Status: New => Invalid -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1338941 Title: type=innodb invalid in MySQL 5.1 Status in Mahara ePortfolio: Invalid Bug description: Installation fails when you have MySQL 5.5 and later because type=INNODB has been deprecated and then removed. Google for "type=innodb" to see examples of this being changed in other database creation code. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1338941/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 548021] Re: Option to not have a display name on Views
Hi Aaron. Are you imagining that if the system wide option is enabled, each page will then have an option to anonymise the author of that page? From my point of view, I'm thinking this sounds like something you'd want to set on a per-page basis, but perhaps that's not what you're thinking of. Nigel -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/548021 Title: Option to not have a display name on Views Status in Mahara ePortfolio: In Progress Bug description: Currently all views show a display name. It would be good to have an option to just have a view title without 'by display name'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/548021/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 548021] Re: Option to not have a display name on Views
Hi again. The meta field should also be scrubbed, shouldn't it? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/548021 Title: Option to not have a display name on Views Status in Mahara ePortfolio: In Progress Bug description: Currently all views show a display name. It would be good to have an option to just have a view title without 'by display name'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/548021/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 548021] Re: Option to not have a display name on Views
Hi again. I've just submitted for review an early version of the patch that just adds a system-wide config setting and simple anonymisation of the page. I want to get feedback as to whether I'm headed in the direction you're thinking of. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/548021 Title: Option to not have a display name on Views Status in Mahara ePortfolio: In Progress Bug description: Currently all views show a display name. It would be good to have an option to just have a view title without 'by display name'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/548021/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 548021] Re: Option to not have a display name on Views
(Should hasten to add I'm part way through more work, so don't expect the version I posted to work yet - the smarty variable hasn't yet been modified in the version posted to Gerrit!). -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/548021 Title: Option to not have a display name on Views Status in Mahara ePortfolio: In Progress Bug description: Currently all views show a display name. It would be good to have an option to just have a view title without 'by display name'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/548021/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 548021] Re: Option to not have a display name on Views
Another question: I'm starting on adding the per-page settings. Should this be made part of the accessdata? (Would it be useful to be able to say anonymise in some circumstances and not others? ... Sounds like the answer is 'yes' to me). -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/548021 Title: Option to not have a display name on Views Status in Mahara ePortfolio: In Progress Bug description: Currently all views show a display name. It would be good to have an option to just have a view title without 'by display name'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/548021/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 548021] Re: Option to not have a display name on Views
A patch implementing just about everything in comment 16 is now available for review. The only thing I haven't done is notifications if a person views the author of the anonymised page. I'd like to discuss more whether it's worth implementing that (I don't yet see the point). -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/548021 Title: Option to not have a display name on Views Status in Mahara ePortfolio: In Progress Bug description: Currently all views show a display name. It would be good to have an option to just have a view title without 'by display name'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/548021/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1285862] Re: Block configuration dialog is inconsistent width
I'm unable to reproduce this with current HEAD on the Master branch. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1285862 Title: Block configuration dialog is inconsistent width Status in Mahara ePortfolio: In Progress Bug description: In Mahara 1.8 the block configuration dialog is fairly narrow and expands to fit its content (if there is a file browser, HTML editor, etc.) In latest master the dialog can be anything from very narrow (where it cuts off the edge of the file browser) to very wide (where it fills the screen and leaves massive amounts of white space everywhere). I can't reliably reproduce any of these widths. This is probably an issue in setDialogPosition() in views.js, which was changed when the page editor was made keyboard-accessible. I've attached a couple of screenshots showing this inconsistency (not the most extreme examples, but you get the idea ...) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1285862/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1287344] Re: artefact installed upgrade problem
** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1287344 Title: artefact installed upgrade problem Status in Mahara ePortfolio: Confirmed Bug description: When there is an artefact plugin missing and one tries to upgrade another artefact plugin there is an error: [WAR] cb (lib/errors.php:739) Failed to get a recordset: postgres7 error: [-1: ERROR: update or delete on table "artefact_installed_type" violates foreign key constraint "arte_art_fk" on table "artefact", referer: https://mahara-testing/admin/upgrade.php [Tue Mar 04 08:52:46 2014] [error] [client 127.0.0.1] [WAR] cb (lib/errors.php:739) DETAIL: Key (name)=(socialprofile) is still referenced from table "artefact".] in adodb_throw(DELETE FROM "artefact_installed_type" WHERE (plugin = ? AND name NOT IN (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)), Array), referer: https://mahara-testing/admin/upgrade.php This is due to the fact the missing plugin has artefacts in the artefact table. This line in lib/upgrade.php (approx line 500) delete_records_select('artefact_installed_type', $select, array_merge(array($pluginname),$types)); needs to have some sort of checking if associated items exist for the plugin being removed and remove them first (or have some try { } catch (Exception $e) {} to let the user know that there was an issue with plugin A but still allow plugin B to be upgraded. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1287344/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1287344] Re: artefact installed upgrade problem
Tried to reproduce this, without success so far. I'm happy to implement support for deleting the data of missing plugins if that will help this bug along. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1287344 Title: artefact installed upgrade problem Status in Mahara ePortfolio: Confirmed Bug description: When there is an artefact plugin missing and one tries to upgrade another artefact plugin there is an error: [WAR] cb (lib/errors.php:739) Failed to get a recordset: postgres7 error: [-1: ERROR: update or delete on table "artefact_installed_type" violates foreign key constraint "arte_art_fk" on table "artefact", referer: https://mahara-testing/admin/upgrade.php [Tue Mar 04 08:52:46 2014] [error] [client 127.0.0.1] [WAR] cb (lib/errors.php:739) DETAIL: Key (name)=(socialprofile) is still referenced from table "artefact".] in adodb_throw(DELETE FROM "artefact_installed_type" WHERE (plugin = ? AND name NOT IN (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)), Array), referer: https://mahara-testing/admin/upgrade.php This is due to the fact the missing plugin has artefacts in the artefact table. This line in lib/upgrade.php (approx line 500) delete_records_select('artefact_installed_type', $select, array_merge(array($pluginname),$types)); needs to have some sort of checking if associated items exist for the plugin being removed and remove them first (or have some try { } catch (Exception $e) {} to let the user know that there was an issue with plugin A but still allow plugin B to be upgraded. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1287344/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1310861] Re: marking page objectionable now allows feedback
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1310861 Title: marking page objectionable now allows feedback Status in Mahara ePortfolio: Fix Committed Bug description: If user A: - creates a page - turns off feedback/comments - shares it with logged in users And User B comes along and marks it as objectionable The ability to leave comments is activated and so now user C, D, and E can all leave comments. This is all due to the view_access table getting updated with 'allowcomments' column set to a hardcoded 1 rather than respecting the settings of the view. I could imagine that an Admin user, who has the permissions to update a page as 'not objectionable' may also want the ability to leave a comment as well. But I believe for all other users they should not be allowed to leave a comment. So we either need to respect the allow comment setting for the page when saving the view_access 'objectionable' row, or get it so that if the only allowcomments value set to 1 is on the accesstype 'objectionable' for the page then only allow certain users (admins) to be allowed to leave a comment. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1310861/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1316421] Re: Update csstidy to 1.5.2
** Changed in: mahara Assignee: Aaron Wells (u-aaronw) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1316421 Title: Update csstidy to 1.5.2 Status in Mahara ePortfolio: In Progress Bug description: We use csstidy to clean user-supplied CSS (mostly for page skins). We're currently using version 1.4. The latest is 1.5.2. https://github.com/Cerdic/CSSTidy To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1316421/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1318432] Re: Improve error reporting in Ajax installer/upgrader
** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1318432 Title: Improve error reporting in Ajax installer/upgrader Status in Mahara ePortfolio: Confirmed Bug description: We use an Ajax-based page to install & upgrade Mahara. For each upgrade task it: - fires off a separate Ajax request to run the task - shows a "progress" spinner while it waits for a response - and then once it gets a response it updates the page and fires off the next task The problem is that this system doesn't handle errors well. If the Ajax script errors out, it continues showing the "progress" spinner forever. Consequently we get a LOT of error reports where people complain that "installation takes forever", when in fact it errored out after 30 seconds or whatever and it just never told them. We need to update this process so that it actually lets you know when it failed, and why. The simplest solution, suggested by Robert, is that we put a timeout on waiting for the Ajax response. Mahara sets max_execution_time itself, so we could: 1. Make the ajax time out after max_execution_time 2. Show an error icon 3. Fire off a second ajax response to a script that gets any error messages from the session and displays those on the page. That should be pretty robust against any type of error. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1318432/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1318432] Re: Improve error reporting in Ajax installer/upgrader
I've spent some time looking into this this afternoon. It seems to me that some of the issue is already resolved: If I set up my IDE to catch the invocation of an installation in admin/upgrade.json.php, line 42 ($fun()) and just sit on the breakpoint until the request times out, the spinner gets changed to "Failed to upgrade". The problem I saw was where the failure is not an failure of the ajax call itself (like the above), but a successful completion of the request which returns an error. The simplest way to reproduce this was to add throw new Exception("Failure!"); prior to the $fun() invocation mentioned above. The ajax call thus completes, but neither the success or the failure handler passed to sendjsonrequest in line 145 of admin/upgrade.php get invoked. This is because sendjsonrequest uses its own success and error handlers, and there is a path (which we're hitting) wherein neither of our handlers will be invoked by sendjsonrequest's handlers: If an ajax request succeeds, but the data in the result indicates an error (data.error = true), the code in lines 233-236 will be invoked, calling globalErrorHandler. In this case, errtype has not been set, so the successcallback function will rightly not be called, but neither will the errorcallback. My solution is to simply call errorcallback() after globalErrorHandler, as well as after setting errortype = 'error' in the block above. I'm not submitting it as a patch yet, though, because I'm aware that sendjsonrequest is called from many other places, and I'd like to have a discussion with others about it first. The code seems messy to me, and I'm not sure I fully comprehend yet the implications of this change as well as others might (particularly since you're all way more familiar with the code!). Thanks for any feedback! Nigel -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1318432 Title: Improve error reporting in Ajax installer/upgrader Status in Mahara ePortfolio: Confirmed Bug description: We use an Ajax-based page to install & upgrade Mahara. For each upgrade task it: - fires off a separate Ajax request to run the task - shows a "progress" spinner while it waits for a response - and then once it gets a response it updates the page and fires off the next task The problem is that this system doesn't handle errors well. If the Ajax script errors out, it continues showing the "progress" spinner forever. Consequently we get a LOT of error reports where people complain that "installation takes forever", when in fact it errored out after 30 seconds or whatever and it just never told them. We need to update this process so that it actually lets you know when it failed, and why. The simplest solution, suggested by Robert, is that we put a timeout on waiting for the Ajax response. Mahara sets max_execution_time itself, so we could: 1. Make the ajax time out after max_execution_time 2. Show an error icon 3. Fire off a second ajax response to a script that gets any error messages from the session and displays those on the page. That should be pretty robust against any type of error. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1318432/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1262928] Re: Add users by CSV - enforce browse for file button only accepts csv files
** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1262928 Title: Add users by CSV - enforce browse for file button only accepts csv files Status in Mahara ePortfolio: Confirmed Bug description: As an admin I want to add some users by csv - When I CLICK the choose file button I see all of my file types in my newly opened window. What would be nice is for the user to only see and be allowed to load csv files. I had thought of this when I was trying to upload a csv file using my ipad which only gave me the option to upload an image or video. I think this is an easy fix by using the ACCEPT attribute for the input tag for example To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1262928/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1080518] Re: ID numbers are not aligned with their institution in /admin/users/suspended.php
Sorry... I didn't notice the existing activity on this one, and just submitted a patch too! Humble apologies! Nigel -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1080518 Title: ID numbers are not aligned with their institution in /admin/users/suspended.php Status in Mahara ePortfolio: In Progress Bug description: Version: master Platform: all Browser: all In the page /admin/users/suspended.php, if an user belongs to several institutions and one of his student ids is empty, his ID numbers may not be matched to his institutions. For example, user Paula is in the institution School B with the empty ID number. She also in the institution School C with the ID=C01. In the page /admin/users/suspended.php, it seems that the ID 'C01' is with School B (see the attached image). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1080518/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 903534] Re: Users can still login even if their only institution has expired
Hi. I'm starting to consider this and look at the code. My thinking so far: 1) Authentication After attempting to log in, the user is currently taken to a page that says "Access Denied" but which has tabs that allow them to access content and continue per normal. There is a simple fix for that issue - calling $this->logout(); at line 1398 in lib/user.php, prior to throwing the exception that causes the issue. But, given the questions above, it seems to me that something more complicated needs to happen at that point... (Question from above:) "What happens when you are a member of more than one institution?" We could fall back to checking credentials against other institutions' auth configurations. If this is done, should there be some buttons on admin/users/edit.php to allow reordering of institution memberships (Up and down arrows, Ajax)? "What happens when your auth instance is tied to an expired institution?" This implies we should check expiry on page load as well as during the login() function (in auth_setup() or a callee). The behaviour should be consistent with logging in, so if another auth configuration would allow the user access, their session should continue unaffected (assuming we do want to fall back to other authentication options). "If you can still login, what happens to the content that's tied to an expired institution you are a member of?" Access checks pretend you're not a member of that institution? That way if you're in Institution A and Institution B and the page is available to both when Institution A is suspended, your Institution B privileges become the only ones applied. "- Pending registrations" Cancelled. "- User requests" That's requests for joining groups? I think I need more detail on the issue here. "- Configurable theme" If authentication is falling back to another institution, that institution's theming should be used. A message should perhaps be displayed indicating why the theming has changed, at least for the first few times they log in. Perhaps theming in the Institution settings at admin/users/edit.php should also indicate expiry (add an 'expired' class to the form?) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/903534 Title: Users can still login even if their only institution has expired Status in Mahara ePortfolio: In Progress Bug description: Institutions can have an expiry date. However, users who are only members of that institution can still login after the institution has expired. This is not easy to fix. There are lots of things to consider: - what happens when you are a member of more than one institution? - what happens when your auth instance is tied to an expired institution? - if you can still login, what happens to the content that's tied to an expired institution you are a member of? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/903534/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236767] Re: Custom layouts aren't displayed properly and can't be created with more than 4 rows
I've managed to reproduce this with an install of Debian Squeeze PHP 5.3.3-7+squeeze17 mysql 5.1.73 Nginx 0.7.67 I'll see if an upgrade of mysql makes it go away. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236767 Title: Custom layouts aren't displayed properly and can't be created with more than 4 rows Status in Mahara ePortfolio: Incomplete Bug description: I just tested the Mahara 1.8rc1, on a linux server with a MySQL DB. To view the site I am using a Mac OS Laptop with Chrome Version 30.0.1599.69. When using the "create custom layout" feature I have multiple problems: - The preview only is displayed correctly for 1 - 3 rows, after adding the fourth row the preview doesn't update anymore - When adding a custom layout with up to 3 rows, the layout gets added to the other layout options. Adding a 4 row layout does work, but there is just a default thumb, not a picture of the layout. - Even though I can add up to 6 rows the adding of custom layouts with 5 or 6 rows doesn't work at all. I attached a screenshot of the problems. Regards, Angela To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236767/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236767] Re: Custom layouts aren't displayed properly and can't be created with more than 4 rows
An update of MySQL to 5.5.31 (the dotdeb version) doesn't make the problem go away. Will try updating PHP next. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236767 Title: Custom layouts aren't displayed properly and can't be created with more than 4 rows Status in Mahara ePortfolio: Incomplete Bug description: I just tested the Mahara 1.8rc1, on a linux server with a MySQL DB. To view the site I am using a Mac OS Laptop with Chrome Version 30.0.1599.69. When using the "create custom layout" feature I have multiple problems: - The preview only is displayed correctly for 1 - 3 rows, after adding the fourth row the preview doesn't update anymore - When adding a custom layout with up to 3 rows, the layout gets added to the other layout options. Adding a 4 row layout does work, but there is just a default thumb, not a picture of the layout. - Even though I can add up to 6 rows the adding of custom layouts with 5 or 6 rows doesn't work at all. I attached a screenshot of the problems. Regards, Angela To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236767/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236767] Re: Custom layouts aren't displayed properly and can't be created with more than 4 rows
Updating PHP to 5.4.30 (dotdeb again) fixes the issue. If someone says it's worth the time, I'll put the effort into diagnosing the exact cause (but not before Monday). -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236767 Title: Custom layouts aren't displayed properly and can't be created with more than 4 rows Status in Mahara ePortfolio: Incomplete Bug description: I just tested the Mahara 1.8rc1, on a linux server with a MySQL DB. To view the site I am using a Mac OS Laptop with Chrome Version 30.0.1599.69. When using the "create custom layout" feature I have multiple problems: - The preview only is displayed correctly for 1 - 3 rows, after adding the fourth row the preview doesn't update anymore - When adding a custom layout with up to 3 rows, the layout gets added to the other layout options. Adding a 4 row layout does work, but there is just a default thumb, not a picture of the layout. - Even though I can add up to 6 rows the adding of custom layouts with 5 or 6 rows doesn't work at all. I attached a screenshot of the problems. Regards, Angela To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236767/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236767] Re: Custom layouts aren't displayed properly and can't be created with more than 4 rows
5.3.28 - also dotdeb - also works. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236767 Title: Custom layouts aren't displayed properly and can't be created with more than 4 rows Status in Mahara ePortfolio: Incomplete Bug description: I just tested the Mahara 1.8rc1, on a linux server with a MySQL DB. To view the site I am using a Mac OS Laptop with Chrome Version 30.0.1599.69. When using the "create custom layout" feature I have multiple problems: - The preview only is displayed correctly for 1 - 3 rows, after adding the fourth row the preview doesn't update anymore - When adding a custom layout with up to 3 rows, the layout gets added to the other layout options. Adding a 4 row layout does work, but there is just a default thumb, not a picture of the layout. - Even though I can add up to 6 rows the adding of custom layouts with 5 or 6 rows doesn't work at all. I attached a screenshot of the problems. Regards, Angela To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236767/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236767] Re: Custom layouts aren't displayed properly and can't be created with more than 4 rows
On my test system, the issue is caused by the use of Suhosin. In the earlier versions mentioned above, the limit on the length of a POST variable name and request variable in general are both 64 characters. When the number of rows or the length of the action variable exceeds 64 characters, it is discarded by PHP and the JSON request is unable to do anything. The solution for my system was to set both suhosin.request.max_varname_length = 128 suhosin.post.max_name_length = 128 in /etc/php5/conf.d/suhosin.ini. In later versions of PHP, suhosin is uninstalled by default, causing the problem to go away. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236767 Title: Custom layouts aren't displayed properly and can't be created with more than 4 rows Status in Mahara ePortfolio: Incomplete Bug description: I just tested the Mahara 1.8rc1, on a linux server with a MySQL DB. To view the site I am using a Mac OS Laptop with Chrome Version 30.0.1599.69. When using the "create custom layout" feature I have multiple problems: - The preview only is displayed correctly for 1 - 3 rows, after adding the fourth row the preview doesn't update anymore - When adding a custom layout with up to 3 rows, the layout gets added to the other layout options. Adding a 4 row layout does work, but there is just a default thumb, not a picture of the layout. - Even though I can add up to 6 rows the adding of custom layouts with 5 or 6 rows doesn't work at all. I attached a screenshot of the problems. Regards, Angela To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236767/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236767] Re: Custom layouts aren't displayed properly and can't be created with more than 4 rows
I should mention that if variable name length is the issue, you'll also be able to reproduce the issue with 3 rows with a greater number of columns per row. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236767 Title: Custom layouts aren't displayed properly and can't be created with more than 4 rows Status in Mahara ePortfolio: Incomplete Bug description: I just tested the Mahara 1.8rc1, on a linux server with a MySQL DB. To view the site I am using a Mac OS Laptop with Chrome Version 30.0.1599.69. When using the "create custom layout" feature I have multiple problems: - The preview only is displayed correctly for 1 - 3 rows, after adding the fourth row the preview doesn't update anymore - When adding a custom layout with up to 3 rows, the layout gets added to the other layout options. Adding a 4 row layout does work, but there is just a default thumb, not a picture of the layout. - Even though I can add up to 6 rows the adding of custom layouts with 5 or 6 rows doesn't work at all. I attached a screenshot of the problems. Regards, Angela To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236767/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1236767] Re: Custom layouts aren't displayed properly and can't be created with more than 4 rows
I've just come back to this and noticed Angela's PHP info PDF. That shows that Suhosin was indeed the cause - it has the settings I mentioned above with values of 64. I'll therefore be bold enough to close this bug report as Invalid - it's not a bug in Mahara, but rather a PHP config issue. ** Changed in: mahara Status: Incomplete => Invalid -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1236767 Title: Custom layouts aren't displayed properly and can't be created with more than 4 rows Status in Mahara ePortfolio: Invalid Bug description: I just tested the Mahara 1.8rc1, on a linux server with a MySQL DB. To view the site I am using a Mac OS Laptop with Chrome Version 30.0.1599.69. When using the "create custom layout" feature I have multiple problems: - The preview only is displayed correctly for 1 - 3 rows, after adding the fourth row the preview doesn't update anymore - When adding a custom layout with up to 3 rows, the layout gets added to the other layout options. Adding a 4 row layout does work, but there is just a default thumb, not a picture of the layout. - Even though I can add up to 6 rows the adding of custom layouts with 5 or 6 rows doesn't work at all. I attached a screenshot of the problems. Regards, Angela To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1236767/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1328739] Re: Wishlist: Journal's list of entries should show the tags for each entry
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1328739 Title: Wishlist: Journal's list of entries should show the tags for each entry Status in Mahara ePortfolio: In Progress Bug description: Mahara 1.8.1 Hi All, I use the journal tool regularly for my own work purposes, and use tags to I can add journals by tag to my pages. I would like to see what tags I have applied a journal entry when I'm looking at the entries in a journal. As the attached screenshot shows - the post displays without showing tags used. I have to edit the post to see what tags I have used. Easily seeing what tags I am using on posts in a journal helps me to get a clear sense of the taxonomy that is developing for that journal, and therefore keep it consistent. Cheers. Shane. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1328739/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1328739] Re: Wishlist: Journal's list of entries should show the tags for each entry
Hi Shane. I got partway through implementing this before I suddenly noticed the tags are already rendered on the right side of the page. It doesn't seem like the best place to me... and adding a second entry to my test journal confirms that all the tags get bundled together on the right side - you can't see which relate to which post - so I'll carry on adding them to the display of each post (in addition). -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1328739 Title: Wishlist: Journal's list of entries should show the tags for each entry Status in Mahara ePortfolio: In Progress Bug description: Mahara 1.8.1 Hi All, I use the journal tool regularly for my own work purposes, and use tags to I can add journals by tag to my pages. I would like to see what tags I have applied a journal entry when I'm looking at the entries in a journal. As the attached screenshot shows - the post displays without showing tags used. I have to edit the post to see what tags I have used. Easily seeing what tags I am using on posts in a journal helps me to get a clear sense of the taxonomy that is developing for that journal, and therefore keep it consistent. Cheers. Shane. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1328739/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1314890] Re: wishlist: button to reliably copy secret URLs
** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1314890 Title: wishlist: button to reliably copy secret URLs Status in Mahara ePortfolio: Confirmed Bug description: Hi Team! Another Wishlist item - this time regarding copying secret URL's. At the moment we rely on students and staff to accurately select all of the secret URL as seen in attached screenshot. This can be a hit and miss affair and leaving off even one character results in a broken link. My wish is for a "Copy link to clipboard" button - to make the select/copy process simple and painless. This feature can be seen on any Web2 app where someone has to copy embed code (eg. youtube, prezi) and just makes it easy. Thanks very much. Shane. Mahara 1.8 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1314890/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1314890] Re: wishlist: button to reliably copy secret URLs
Subscribing Kristina and Evonne as I need a new button image for this bug. I've prepared a new patch (in Gerrit), and am currently using another button, just for testing. I've spoken to Evonne, who requested that I ask Kristina to add this to the to-do list she has for Evonne. Hope that makes sense! :) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1314890 Title: wishlist: button to reliably copy secret URLs Status in Mahara ePortfolio: In Progress Bug description: Hi Team! Another Wishlist item - this time regarding copying secret URL's. At the moment we rely on students and staff to accurately select all of the secret URL as seen in attached screenshot. This can be a hit and miss affair and leaving off even one character results in a broken link. My wish is for a "Copy link to clipboard" button - to make the select/copy process simple and painless. This feature can be seen on any Web2 app where someone has to copy embed code (eg. youtube, prezi) and just makes it easy. Thanks very much. Shane. Mahara 1.8 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1314890/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1314890] Re: wishlist: button to reliably copy secret URLs
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1314890 Title: wishlist: button to reliably copy secret URLs Status in Mahara ePortfolio: In Progress Bug description: Hi Team! Another Wishlist item - this time regarding copying secret URL's. At the moment we rely on students and staff to accurately select all of the secret URL as seen in attached screenshot. This can be a hit and miss affair and leaving off even one character results in a broken link. My wish is for a "Copy link to clipboard" button - to make the select/copy process simple and painless. This feature can be seen on any Web2 app where someone has to copy embed code (eg. youtube, prezi) and just makes it easy. Thanks very much. Shane. Mahara 1.8 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1314890/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting
I have another suggestion, with a patch that I've just pushed. The required fields form works by hijacking any link that the user has requested, so all we need to do after the user has successfully addressed the requirements is drop out of generating the form and let the normal execution for the requested URL continue. My patch accomplishes that by adding a small amount of code allowing this to happen. It relies on the fact that $form->build() always returns a string (the rendered HTML), and instead returns FALSE if we need to back out of the form generation. I've successfully tested it by running an install on the URL http://mahara, which causes the warning about the noreply email address. I then clicked on the noreply link (fixed by the first patch of the two in the submission) and was taken to the site_options URL, overridden by the required fields form. After the required fields form was submitted with a valid admin password, the page loaded with the requested form for setting the noreply link. At the point where I clicked on the noreply link, I also clicked on other links, opening them in other tabs. All tabs displayed the required fields form under the requested URL, as expected. After successful submission on one of the tabs, reloading all other tabs then displayed the expected page content. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/946880 Title: Broken html error message for no-reply email setting Status in Mahara ePortfolio: Triaged Bug description: error message when upgrading from 1.4 to 1.5: The noreply address setting is either empty or has an invalid email address. Please check the configuration in the http://15stable/admin/site/options.php?fs=emailsettings";>site options in the email settings. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
I'm going to give this a go... ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1348494] [NEW] Bulkdownload invocation of print_export_footer missing a parameter
Public bug reported: admin/users/bulkdownload.php finishes with an invocation of print_export_footer, but the call is missing a parameter. Patch coming! ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1348494 Title: Bulkdownload invocation of print_export_footer missing a parameter Status in Mahara ePortfolio: New Bug description: admin/users/bulkdownload.php finishes with an invocation of print_export_footer, but the call is missing a parameter. Patch coming! To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1348494/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls
After having done some profiling and preparation of patches over the last few days, I think 32M is reasonable for normal operation, but we will definitely still need to raise the memory limit for some operations. The main one I've focused on so far is adding users from a CSV file. Profiling got me focusing on execution time as well as memory use, and I have a few patches that together do better than halving the execution time (one in particular - to handle_event - will probably have far wider implications and accounts for most of the savings) while only raising memory use by a small amount. 64MB is more than enough even for an import of 5000 users. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/785472 Title: Eliminate all raise_memory_limit() calls Status in Mahara ePortfolio: Triaged Bug description: There are very few places in Mahara were we raise PHP's memory limit, but it is bad practice since that memory may not be reclaimed by Apache until that child process is terminated. Unless we are confident that a particular operation is impossible to do without raising the memory limit, we should rewrite code which fails to work within 32 MB of memory. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1352027] [NEW] Uploadcsvusers broken fields - maildisabled and authinstance
Public bug reported: In current master at the time of writing, uploadcsvusers says in its description that the user can include the fields maildisabled and authinstance in a CSV file, but seeking to do so results in the error: Fatal error: Class 'ArtefactTypeMaildisabled' not found (And the same for an authinstance related class). ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1352027 Title: Uploadcsvusers broken fields - maildisabled and authinstance Status in Mahara ePortfolio: New Bug description: In current master at the time of writing, uploadcsvusers says in its description that the user can include the fields maildisabled and authinstance in a CSV file, but seeking to do so results in the error: Fatal error: Class 'ArtefactTypeMaildisabled' not found (And the same for an authinstance related class). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1352027/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1352028] [NEW] Upload users from CSV could do with a progress bar
Public bug reported: When you click the submission button in the form for uploading users from a CSV file, current master displays changes the button to "Processing...". Since the operation can take quite a while, it would be better if a new form along the lines of the progress bar in the bulk user export was displayed. ** Affects: mahara Importance: Undecided Status: New ** Tags: csvupload wishlist -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1352028 Title: Upload users from CSV could do with a progress bar Status in Mahara ePortfolio: New Bug description: When you click the submission button in the form for uploading users from a CSV file, current master displays changes the button to "Processing...". Since the operation can take quite a while, it would be better if a new form along the lines of the progress bar in the bulk user export was displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1352028/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1352028] Re: Upload users from CSV could do with a progress bar
That's entirely doable. We already check the number of lines in the CSV very early in the process (search for $maxcsvlines). I'll prepare a patch when I get done with the memory limit bug that prompted this :) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1352028 Title: Upload users from CSV could do with a progress bar Status in Mahara ePortfolio: New Bug description: When you click the submission button in the form for uploading users from a CSV file, current master displays changes the button to "Processing...". Since the operation can take quite a while, it would be better if a new form along the lines of the progress bar in the bulk user export was displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1352028/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1353770] [NEW] Upload group from CSV error messages displayed as raw HTML
Public bug reported: With current master, when attempting to upload a group from a CSV file, any error messages are displayed as raw HTML in the 'file' field error area. Patch coming which moves the errors to the general section, where they're rendered correctly. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1353770 Title: Upload group from CSV error messages displayed as raw HTML Status in Mahara ePortfolio: New Bug description: With current master, when attempting to upload a group from a CSV file, any error messages are displayed as raw HTML in the 'file' field error area. Patch coming which moves the errors to the general section, where they're rendered correctly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1353770/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1353802] [NEW] Upload users from CSV performance improvements.
Public bug reported: In doing the memory limit work, I've prepared a number of patches to improve the performance of the various import and export functions. This bug is for submitting those patches against master. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1353802 Title: Upload users from CSV performance improvements. Status in Mahara ePortfolio: New Bug description: In doing the memory limit work, I've prepared a number of patches to improve the performance of the various import and export functions. This bug is for submitting those patches against master. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1353802/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
Re: [Mahara-contributors] [Bug 1287344] Re: artefact installed upgrade problem
Thanks Aaron. I've been pulled off Mahara for a while to focus on some Moodle dev for a client, and was going to get stuck into bug fixes and improvements to the CSV import and export functionality. I'll happily look at this too. Would you prioritise it higher than the CSV import/export? Regards, Nigel On 12/08/14 08:44, Aaron Wells wrote: > Hi Nigel, > > If you wanted to implement support for deleting plugins, that'd be > great. It's a long-requested feature. I'd start with > https://bugs.launchpad.net/mahara/+bug/505732 (support for manually > deleting plugins), and from there expand to the ability to clear out the > data of "missing" plugins. > > Cheers, > Aaron > > ** Changed in: mahara > Milestone: 1.10.0 => 1.11.0 > > ** Changed in: mahara >Importance: High => Low > -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1287344 Title: artefact installed upgrade problem Status in Mahara ePortfolio: Confirmed Bug description: When there is an artefact plugin missing and one tries to upgrade another artefact plugin there is an error: [WAR] cb (lib/errors.php:739) Failed to get a recordset: postgres7 error: [-1: ERROR: update or delete on table "artefact_installed_type" violates foreign key constraint "arte_art_fk" on table "artefact", referer: https://mahara-testing/admin/upgrade.php [Tue Mar 04 08:52:46 2014] [error] [client 127.0.0.1] [WAR] cb (lib/errors.php:739) DETAIL: Key (name)=(socialprofile) is still referenced from table "artefact".] in adodb_throw(DELETE FROM "artefact_installed_type" WHERE (plugin = ? AND name NOT IN (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)), Array), referer: https://mahara-testing/admin/upgrade.php This is due to the fact the missing plugin has artefacts in the artefact table. This line in lib/upgrade.php (approx line 500) delete_records_select('artefact_installed_type', $select, array_merge(array($pluginname),$types)); needs to have some sort of checking if associated items exist for the plugin being removed and remove them first (or have some try { } catch (Exception $e) {} to let the user know that there was an issue with plugin A but still allow plugin B to be upgraded. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1287344/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1352028] Re: Upload users from CSV could do with a progress bar
** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1352028 Title: Upload users from CSV could do with a progress bar Status in Mahara ePortfolio: In Progress Bug description: When you click the submission button in the form for uploading users from a CSV file, current master displays changes the button to "Processing...". Since the operation can take quite a while, it would be better if a new form along the lines of the progress bar in the bulk user export was displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1352028/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1363817] [NEW] No progress shown during bulkimport.php operation.
Public bug reported: The bulkimport.php operation doesn't give the user any idea of the progress being made. I have a patch (part of the series made for bug1353802) that addresses this. Making a separate bug so this series can be split up. ** Affects: mahara Importance: Undecided Status: New ** Patch added: "Patch to show progress in page title" https://bugs.launchpad.net/bugs/1363817/+attachment/4192064/+files/0001-Bug1353802-Show-progress-in-title-during-bulkimport..patch -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1363817 Title: No progress shown during bulkimport.php operation. Status in Mahara ePortfolio: New Bug description: The bulkimport.php operation doesn't give the user any idea of the progress being made. I have a patch (part of the series made for bug1353802) that addresses this. Making a separate bug so this series can be split up. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1363817/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1363817] Re: No progress shown during bulkimport.php operation.
** Changed in: mahara Status: New => In Progress ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1363817 Title: No progress shown during bulkimport.php operation. Status in Mahara ePortfolio: In Progress Bug description: The bulkimport.php operation doesn't give the user any idea of the progress being made. I have a patch (part of the series made for bug1353802) that addresses this. Making a separate bug so this series can be split up. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1363817/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364227] [NEW] In clean_html, skip html purifier if no tags are found
Public bug reported: In clean_html, check for a less than sign in the text at the start of execution. If there isn't one, the text can't have any HTML tags and can be returned after escaping HTML special characters. This avoids the execution time and memory requirements (at least potentially) of the HTML purifier library. ** Affects: mahara Importance: Undecided Assignee: Nigel Cunningham (nigelc-g) Status: In Progress ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364227 Title: In clean_html, skip html purifier if no tags are found Status in Mahara ePortfolio: In Progress Bug description: In clean_html, check for a less than sign in the text at the start of execution. If there isn't one, the text can't have any HTML tags and can be returned after escaping HTML special characters. This avoids the execution time and memory requirements (at least potentially) of the HTML purifier library. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364227/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364229] [NEW] Uploadcsv email addr and username cache
Public bug reported: We can speed the validation of email addresses and usernames by doing a single query for each of usernames, email addresses and internal email addresses prior to entering the validation loop. Test runs with 2000 preexisting users using XHProf showed a reduction in execution time from 6.5 seconds to 3.8 seconds, with an increase in memory use of approximately 1.3MB. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364229 Title: Uploadcsv email addr and username cache Status in Mahara ePortfolio: New Bug description: We can speed the validation of email addresses and usernames by doing a single query for each of usernames, email addresses and internal email addresses prior to entering the validation loop. Test runs with 2000 preexisting users using XHProf showed a reduction in execution time from 6.5 seconds to 3.8 seconds, with an increase in memory use of approximately 1.3MB. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364229/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364669] [NEW] ArtfactType::commit - don't delete records when none exist
Public bug reported: In ArtefactType::commit, we shouldn't bother calling delete_records if we know the artefact that is being committed is new. In testing the addition 2000 users from a CSV file, this patch shaved 4 seconds off the completion time. ** Affects: mahara Importance: Undecided Assignee: Nigel Cunningham (nigelc-g) Status: In Progress ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364669 Title: ArtfactType::commit - don't delete records when none exist Status in Mahara ePortfolio: In Progress Bug description: In ArtefactType::commit, we shouldn't bother calling delete_records if we know the artefact that is being committed is new. In testing the addition 2000 users from a CSV file, this patch shaved 4 seconds off the completion time. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364669/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364687] [NEW] Avoid query for existing artefact record when we know it's new.
Public bug reported: When importing users from a CSV file, we can avoid the query for an existing artefact record when we know it doesn't exist (because we're being called from create_user). This shaves approximately 40% off the time for creating a user. ** Affects: mahara Importance: Undecided Assignee: Nigel Cunningham (nigelc-g) Status: In Progress ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364687 Title: Avoid query for existing artefact record when we know it's new. Status in Mahara ePortfolio: In Progress Bug description: When importing users from a CSV file, we can avoid the query for an existing artefact record when we know it doesn't exist (because we're being called from create_user). This shaves approximately 40% off the time for creating a user. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364687/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364689] [NEW] Don't assume the user has any views when doing an export.
Public bug reported: We should not assume the user has any views when doing an export. If they were imported from a CSV file, none will have been created for them initially. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364689 Title: Don't assume the user has any views when doing an export. Status in Mahara ePortfolio: New Bug description: We should not assume the user has any views when doing an export. If they were imported from a CSV file, none will have been created for them initially. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364688] [NEW] Make bulkdownload progress bar work under Nginx
Public bug reported: This bug is for a patch to make the progress bar that bulkdownload.php uses work under Nginx. We need to disable gzip and Nginx's buffering, and output enough filler to overcome any buffering on the client side. ** Affects: mahara Importance: Undecided Assignee: Nigel Cunningham (nigelc-g) Status: In Progress ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364688 Title: Make bulkdownload progress bar work under Nginx Status in Mahara ePortfolio: In Progress Bug description: This bug is for a patch to make the progress bar that bulkdownload.php uses work under Nginx. We need to disable gzip and Nginx's buffering, and output enough filler to overcome any buffering on the client side. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364688/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364691] [NEW] Add support for getting multiple artefacts from an array
Public bug reported: Add support for getting multiple artefacts from an array of IDs, all at once. The main saving is that we then do one SQL query for the whole array instead of one for each element in the array. In testing admin/users/bulkexport.php, this reduced execution time for an export of 1000 users by 12 seconds (approx 10 percent). ** Affects: mahara Importance: Undecided Assignee: Nigel Cunningham (nigelc-g) Status: In Progress ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364691 Title: Add support for getting multiple artefacts from an array Status in Mahara ePortfolio: In Progress Bug description: Add support for getting multiple artefacts from an array of IDs, all at once. The main saving is that we then do one SQL query for the whole array instead of one for each element in the array. In testing admin/users/bulkexport.php, this reduced execution time for an export of 1000 users by 12 seconds (approx 10 percent). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364691/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364690] [NEW] Fix the missing argument in print_export_footer
Public bug reported: Fix the missing argument in print_export_footer and clear the messages so they don't redisplay on the next page view, when we run bulkdownload.php. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364690 Title: Fix the missing argument in print_export_footer Status in Mahara ePortfolio: New Bug description: Fix the missing argument in print_export_footer and clear the messages so they don't redisplay on the next page view, when we run bulkdownload.php. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364690/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364705] [NEW] Save another 17 seconds off a 1000 user export by caching the value of $updated in LeapExportElementInternal's assign_smarty_vars function.
Public bug reported: This bug/patch lets us save another 17 seconds off a 1000 user export by caching the value of $updated in LeapExportElementInternal's assign_smarty_vars function. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364705 Title: Save another 17 seconds off a 1000 user export by caching the value of $updated in LeapExportElementInternal's assign_smarty_vars function. Status in Mahara ePortfolio: New Bug description: This bug/patch lets us save another 17 seconds off a 1000 user export by caching the value of $updated in LeapExportElementInternal's assign_smarty_vars function. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364705/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364703] [NEW] Add caching of results to ArtefactType::get_plugin_name.
Public bug reported: Add caching of results to ArtefactType::get_plugin_name. In a test export of 1000 users via admin/users/bulkexport.php, the patch that goes with this bug reduced the number of calls to get_field from 78,000 to 26 and reduced the execution time from 115 seconds to 92 seconds. ** Affects: mahara Importance: Undecided Assignee: Nigel Cunningham (nigelc-g) Status: In Progress ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364703 Title: Add caching of results to ArtefactType::get_plugin_name. Status in Mahara ePortfolio: In Progress Bug description: Add caching of results to ArtefactType::get_plugin_name. In a test export of 1000 users via admin/users/bulkexport.php, the patch that goes with this bug reduced the number of calls to get_field from 78,000 to 26 and reduced the execution time from 115 seconds to 92 seconds. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364703/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1353802] Re: Upload users from CSV performance improvements.
Hi Kristina. Thanks for your email - yes, I wanted to split them up, and have found time to do that this morning. I've made new bugs for each of the patches, so this one can now be closed. Not sure what status to pick though. Suggestions? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1353802 Title: Upload users from CSV performance improvements. Status in Mahara ePortfolio: In Progress Bug description: In doing the memory limit work, I've prepared a number of patches to improve the performance of the various import and export functions. This bug is for submitting those patches against master. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1353802/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364689] Re: Don't assume the user has any views when doing an export.
I generated some users for import from a CSV file, which went fine. I then sought to use those same users to test the exporting of data. No views etc had been created for the users when they were imported but the queries as they stand don't allow for that possibility, causing the script to die. This patch modifies the queries so they don't cause errors if there are no views for the user being exported. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364689 Title: Don't assume the user has any views when doing an export. Status in Mahara ePortfolio: Confirmed Status in Mahara 1.10 series: Confirmed Status in Mahara 1.11 series: In Progress Bug description: We should not assume the user has any views when doing an export. If they were imported from a CSV file, none will have been created for them initially. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1348494] Re: Bulkdownload invocation of print_export_footer missing a parameter
Already fixed in commit for Bug 1364690. ** Changed in: mahara/1.11 Status: In Progress => Fix Committed ** Changed in: mahara/1.10 Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1348494 Title: Bulkdownload invocation of print_export_footer missing a parameter Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.11 series: Fix Committed Bug description: admin/users/bulkdownload.php finishes with an invocation of print_export_footer, but the call is missing a parameter. Patch coming! To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1348494/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364687] Re: Avoid query for existing artefact record when we know it's new.
** Tags added: performance -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364687 Title: Avoid query for existing artefact record when we know it's new. Status in Mahara ePortfolio: In Progress Bug description: When importing users from a CSV file, we can avoid the query for an existing artefact record when we know it doesn't exist (because we're being called from create_user). This shaves approximately 40% off the time for creating a user. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364687/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364669] Re: ArtfactType::commit - don't delete records when none exist
** Tags added: performance -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364669 Title: ArtfactType::commit - don't delete records when none exist Status in Mahara ePortfolio: In Progress Bug description: In ArtefactType::commit, we shouldn't bother calling delete_records if we know the artefact that is being committed is new. In testing the addition 2000 users from a CSV file, this patch shaved 4 seconds off the completion time. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364669/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1364227] Re: In clean_html, skip html purifier if no tags are found
** Tags added: performance -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1364227 Title: In clean_html, skip html purifier if no tags are found Status in Mahara ePortfolio: In Progress Bug description: In clean_html, check for a less than sign in the text at the start of execution. If there isn't one, the text can't have any HTML tags and can be returned after escaping HTML special characters. This avoids the execution time and memory requirements (at least potentially) of the HTML purifier library. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1364227/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1352028] Re: Upload users from CSV could do with a progress bar
** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1352028 Title: Upload users from CSV could do with a progress bar Status in Mahara ePortfolio: In Progress Bug description: When you click the submission button in the form for uploading users from a CSV file, current master displays changes the button to "Processing...". Since the operation can take quite a while, it would be better if a new form along the lines of the progress bar in the bulk user export was displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1352028/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1353770] Re: Upload group from CSV error messages displayed as raw HTML
I don't remember the context now. I thought perhaps it was related to those 2 fields that were listed as valid in the page, but couldn't actually be used (Bug1352027). I tried reversing the patch applied there and uploading a CSV with those fields, but I just got a PHP error, not an error message on the page. I'll close it as invalid and learn to give better info for reproducing the issue in future. ** Changed in: mahara Status: New => Invalid -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1353770 Title: Upload group from CSV error messages displayed as raw HTML Status in Mahara ePortfolio: Invalid Bug description: With current master, when attempting to upload a group from a CSV file, any error messages are displayed as raw HTML in the 'file' field error area. Patch coming which moves the errors to the general section, where they're rendered correctly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1353770/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1262928] Re: Add users by CSV - enforce browse for file button only accepts csv files
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1262928 Title: Add users by CSV - enforce browse for file button only accepts csv files Status in Mahara ePortfolio: In Progress Bug description: As an admin I want to add some users by csv - When I CLICK the choose file button I see all of my file types in my newly opened window. What would be nice is for the user to only see and be allowed to load csv files. I had thought of this when I was trying to upload a csv file using my ipad which only gave me the option to upload an image or video. I think this is an easy fix by using the ACCEPT attribute for the input tag for example To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1262928/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1271420] Re: Duplicate newlines in forum post notifications if you turn off the HTML editor
** Changed in: mahara/1.10 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1271420 Title: Duplicate newlines in forum post notifications if you turn off the HTML editor Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: In Progress Status in Mahara 1.11 series: In Progress Bug description: To replicate: 1. Go to your user account settings and turn the HTML editor off 2. Set the forum post delay to 0 minutes (to make testing quicker) 3. Make a forum post that runs across multiple newlines. 4. Look in your Inbox, and look at the email you receive Expected result: You should see one newline in the message for each newline in the original post Actual result: You'll see two newlines in the message for each one in the original post. This does not seem to happen when the HTML editor (TinyMCE) is active. Possibly TinyMCE strips out the newlines from the text before saving it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1271420/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 505732] Re: Plugins cannot be uninstalled
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/505732 Title: Plugins cannot be uninstalled Status in Mahara ePortfolio: In Progress Bug description: Plugins cannot be completely removed from Mahara. They can only be enabled/disabled via the Administer Extensions page. A plugin could presumably be removed completely with some SQL hacking, but a feature should be added that does this when needed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/505732/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1373226] [NEW] Missing plugins not disabled cleanly.
Public bug reported: While working on bug505732, I've found that having data but not files for a plugin results in the same errors described in bug629209 (Mahara: Site unavailable. A nonrecoverable error occured. This probably means you have encountered a bug in the system). This is because the plugin isnot marked inactive when the safe_require fails, and later code doesn't check whether a plugin is active before attempting to again require and use the plugin. With the patch that I intend to submit to Gerrit, the page is loaded as normal, with the missingplugindisabled message included. (Currently tested with the extensions page; I've seen that I need to make further changes to cover other cases where the plugin is also used without the active flag being checked). ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1373226 Title: Missing plugins not disabled cleanly. Status in Mahara ePortfolio: New Bug description: While working on bug505732, I've found that having data but not files for a plugin results in the same errors described in bug629209 (Mahara: Site unavailable. A nonrecoverable error occured. This probably means you have encountered a bug in the system). This is because the plugin isnot marked inactive when the safe_require fails, and later code doesn't check whether a plugin is active before attempting to again require and use the plugin. With the patch that I intend to submit to Gerrit, the page is loaded as normal, with the missingplugindisabled message included. (Currently tested with the extensions page; I've seen that I need to make further changes to cover other cases where the plugin is also used without the active flag being checked). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1373226/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
Re: [Mahara-contributors] [Bug 1373226] Re: Missing plugins not disabled cleanly.
Hi. I've just pushed a patch for testing to Gerrit. I haven't yet done a thorough search of the source to see whether there are other cases I need to check for but this seems to do the trick for most pages. Hopefully it will help you for now, Aaron. Regards, Nigel On 24/09/14 15:30, Aaron Wells wrote: > This probably explains all the mysterious cases of "A nonrecoverable > error occurred" that I've been having as I switch around between > different gerrit patches lately, since we just added the > "blocktype/text" plugin via db/upgrade.php. > -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1373226 Title: Missing plugins not disabled cleanly. Status in Mahara ePortfolio: New Bug description: While working on bug505732, I've found that having data but not files for a plugin results in the same errors described in bug629209 (Mahara: Site unavailable. A nonrecoverable error occured. This probably means you have encountered a bug in the system). This is because the plugin isnot marked inactive when the safe_require fails, and later code doesn't check whether a plugin is active before attempting to again require and use the plugin. With the patch that I intend to submit to Gerrit, the page is loaded as normal, with the missingplugindisabled message included. (Currently tested with the extensions page; I've seen that I need to make further changes to cover other cases where the plugin is also used without the active flag being checked). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1373226/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1356638] Re: Can not see the image in the static page "Home" for logged-in users
Hi Son. How did you add the image into the static page? If I copy and paste the URL, it works here with current master. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1356638 Title: Can not see the image in the static page "Home" for logged-in users Status in Mahara ePortfolio: New Status in Mahara 1.10 series: New Status in Mahara 1.11 series: New Status in Mahara 1.8 series: New Status in Mahara 1.9 series: New Bug description: Version: master(1.10), 1.9, 1.8 Platform: any Browser: any Steps to reproduce the issue 1. Login as a site admin, add a site image file out of the 'public' folder 2. Add the image into the static page Home (Dashboard) 3. Logout and login as a normal user Expected result: the image should display in my dashboard Actual result: the image is not accessible To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1356638/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1051844] Re: when editing a file download artefact and the licence acceptance is on, the entire screen is used
** Changed in: mahara/1.10 Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1051844 Title: when editing a file download artefact and the licence acceptance is on, the entire screen is used Status in Mahara ePortfolio: Confirmed Status in Mahara 1.10 series: Confirmed Status in Mahara 1.11 series: Confirmed Status in Mahara 1.9 series: Confirmed Bug description: using chrome 21.0.1180.89 Debian wheezy/sid (154005) It uses the entire screen, whereas I would think it should use a text wrap and use the normal size (without the agreement). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1051844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1051844] Re: when editing a file download artefact and the licence acceptance is on, the entire screen is used
** Changed in: mahara/1.10 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1051844 Title: when editing a file download artefact and the licence acceptance is on, the entire screen is used Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: In Progress Status in Mahara 1.11 series: Confirmed Status in Mahara 1.9 series: Confirmed Bug description: using chrome 21.0.1180.89 Debian wheezy/sid (154005) It uses the entire screen, whereas I would think it should use a text wrap and use the normal size (without the agreement). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1051844/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1376073] [NEW] Soft copies of templates
Public bug reported: Feature idea from ePortfolio workshop: Make templates do soft copies (by default?), saving a link to the original content rather than actually copying it. Updates to the original template could then be automatically reflected in copies. When a user edits their copy, the soft link is broken so that updates to the template don't overwrite the modified content. Soft copies would also reduce the cost in time and disk usage of creating a copy. ** Affects: mahara Importance: Wishlist Assignee: Nigel Cunningham (nigelc-g) Status: New ** Changed in: mahara Importance: Undecided => Wishlist ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1376073 Title: Soft copies of templates Status in Mahara ePortfolio: New Bug description: Feature idea from ePortfolio workshop: Make templates do soft copies (by default?), saving a link to the original content rather than actually copying it. Updates to the original template could then be automatically reflected in copies. When a user edits their copy, the soft link is broken so that updates to the template don't overwrite the modified content. Soft copies would also reduce the cost in time and disk usage of creating a copy. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1376073/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1376073] Re: Soft copies of templates
Mmm. With this change, they'll still get any modifications made to the template afterwards. A further idea, to be put in another wishlist item when I find the time, is to start recording revisions to artefacts. Combining this idea with that would then allow users to see what changes had been made to a template, even after they'd modified their own version. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1376073 Title: Soft copies of templates Status in Mahara ePortfolio: New Bug description: Feature idea from ePortfolio workshop: Make templates do soft copies (by default?), saving a link to the original content rather than actually copying it. Updates to the original template could then be automatically reflected in copies. When a user edits their copy, the soft link is broken so that updates to the template don't overwrite the modified content. Soft copies would also reduce the cost in time and disk usage of creating a copy. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1376073/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1157543] Re: Record page editing history
As discussed with Kristina and Ghada last week after the ePortfolio forum, this is a good idea, and could also be integrated with the soft- copies of templates idea. I'm going to start work on it. ** Changed in: mahara Assignee: (unassigned) => Nigel Cunningham (nigelc-g) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1157543 Title: Record page editing history Status in Mahara ePortfolio: Confirmed Bug description: I'd like to "dogfood" Mahara's developer documentation by moving it from Mediawiki to the Mahara platform itself, probably as group pages so it could still be edited by many people. One of the features that is lacking to make this feasible, though, is having an edit history. The wiki allows us to keep track of who made what edits, and to revert to older versions if necessary. So, I'd like to see Mahara gain the ability to keep track of a page's edit history. At a minimum it needs: 1. Who made changes, at what time 2. What the page looked like at each revision 3. Ability to revert the page to a previous version Also good would be: 4. Ability to "diff" versions and highlight what changed 5. Comments that go in the history log 6. "Publish" ability (including publishing at a later time/date) 7. Versioning file attachments, see also https://bugs.launchpad.net/mahara/+bug/548195 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1157543/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1157543] Re: Record page editing history
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1157543 Title: Record page editing history Status in Mahara ePortfolio: In Progress Bug description: I'd like to "dogfood" Mahara's developer documentation by moving it from Mediawiki to the Mahara platform itself, probably as group pages so it could still be edited by many people. One of the features that is lacking to make this feasible, though, is having an edit history. The wiki allows us to keep track of who made what edits, and to revert to older versions if necessary. So, I'd like to see Mahara gain the ability to keep track of a page's edit history. At a minimum it needs: 1. Who made changes, at what time 2. What the page looked like at each revision 3. Ability to revert the page to a previous version Also good would be: 4. Ability to "diff" versions and highlight what changed 5. Comments that go in the history log 6. "Publish" ability (including publishing at a later time/date) 7. Versioning file attachments, see also https://bugs.launchpad.net/mahara/+bug/548195 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1157543/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1317320] Re: wishlist: ability to add rows in page edit mode
I wonder whether, rather than all the buttons, it might be better to indicate the addition of a new area based on where the position of the mouse when you're dragging and dropping. In some software I already use, if I take a 'pane' and drag it down to the bottom quarter of the screen, the bottom quarter gets a semi- transparent overlay, indicating that if I drop there, I'll add a new row to the bottom of the layout. Perhaps something like that would make the UI cleaner. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1317320 Title: wishlist: ability to add rows in page edit mode Status in Mahara ePortfolio: Triaged Bug description: Hi All, I would like to pick up on a number of points with the process/tools for laying out pages. Currently there are two ways to customize the layout in Mahara - layout form or directly on the page. Layout form: many times I have created a layout - added content and then changed the layout in the form again, Sometimes I get an error, sometimes the layout doesn't change, and I have also seen pages refusing to load again after a layout change. Layout in directly on page: this works well for columns, but there is no option for adding rows. Worse however, the in-page layout changes are not captured by the layout editor form, none of the options are selected or created based on what I do directly on the page. This means that once I begin making changes directly on the page the layout editor is of no use to me. Both approaches have limitations/bugs, is it possible to have just one approach? I would opt for flexibly laying out directly the page. In which case my wishlist is 1) that layout editing is consolidated with page editing with the ability to add-remove rows added, and 2) the "edit layout" page/system is hidden/removed/made redundant. In addition I would also like the option to save any layout I make as a template layout (with a name I choose) so I can use it on other pages - like I can with a skin or theme. Maybe even share layouts with ratings and intended purpose attached! This approach may save dev time having to maintain two ways of laying out a page. Thanks, Shane. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1317320/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1157543] Re: Record page editing history
Sorry for my slow response. I'm working on full-on page versioning, and am trying to make it as simple as possible. My implementation plan is as follows: X Make tables to store incremental diffs between versions of the database row that stores the artefact/block/page (simply item ID, revision ID for item, mtime, diff; item ID + rev ID = Primary key). X Add lib/revision.php to do the work of calculating the diff and storing it (hooks into commit fns and called between generating the new version of a DB row and actually saving it). - Modify existing database structures where possible so that all of the data related to a revision is in the row. At the moment, I'm reworking the code for storing block locations within a layout, putting them into a serialised array in a field in view, and adding a view_block table to implement what will now be a many-to-many relationship between views and blocks. _ Design and add a UI for viewing past versions of a page and its components. Kristina was thinking of a slider at the bottom of the page. _ Also provide support for deleting/merging old revisions, and cascade delete unneeded blocks/artefacts as required _ Provide a UI for en/disabling revisions (sitewide and more granular) Regards, Nigel -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1157543 Title: Record page editing history Status in Mahara ePortfolio: In Progress Bug description: I'd like to "dogfood" Mahara's developer documentation by moving it from Mediawiki to the Mahara platform itself, probably as group pages so it could still be edited by many people. One of the features that is lacking to make this feasible, though, is having an edit history. The wiki allows us to keep track of who made what edits, and to revert to older versions if necessary. So, I'd like to see Mahara gain the ability to keep track of a page's edit history. At a minimum it needs: 1. Who made changes, at what time 2. What the page looked like at each revision 3. Ability to revert the page to a previous version Also good would be: 4. Ability to "diff" versions and highlight what changed 5. Comments that go in the history log 6. "Publish" ability (including publishing at a later time/date) 7. Versioning file attachments, see also https://bugs.launchpad.net/mahara/+bug/548195 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1157543/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1157543] Re: Record page editing history
Thanks for the reply. Good questions - I've just been given some other work to do, but will give these both further consideration when I get the opportunity. Nigel -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1157543 Title: Record page editing history Status in Mahara ePortfolio: In Progress Bug description: I'd like to "dogfood" Mahara's developer documentation by moving it from Mediawiki to the Mahara platform itself, probably as group pages so it could still be edited by many people. One of the features that is lacking to make this feasible, though, is having an edit history. The wiki allows us to keep track of who made what edits, and to revert to older versions if necessary. So, I'd like to see Mahara gain the ability to keep track of a page's edit history. At a minimum it needs: 1. Who made changes, at what time 2. What the page looked like at each revision 3. Ability to revert the page to a previous version Also good would be: 4. Ability to "diff" versions and highlight what changed 5. Comments that go in the history log 6. "Publish" ability (including publishing at a later time/date) 7. Versioning file attachments, see also https://bugs.launchpad.net/mahara/+bug/548195 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1157543/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1157543] Re: Record page editing history
Hi again. I gave this some more thought over the weekend. For DB field changes, I think the best approach going forward would be as follows: When viewing a past revision of an asset, we first apply the diffs to get back to the record as it actually was at the time. We then apply the modifications that would have happened to that row as a result of changes to the database since that date (giving it default values for fields that have been added and removing fields that are no longer used). This would give us a version that should be able to be passed to the current API without causing errors. Hopefully, most of this could be achieved by tracking the DB structure in a similar way to the record changes, but I think we'd need some sort of hook functionality to allow for transformations that are more complicated than the simple addition or removal of fields. And lots of unit tests! -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1157543 Title: Record page editing history Status in Mahara ePortfolio: In Progress Bug description: I'd like to "dogfood" Mahara's developer documentation by moving it from Mediawiki to the Mahara platform itself, probably as group pages so it could still be edited by many people. One of the features that is lacking to make this feasible, though, is having an edit history. The wiki allows us to keep track of who made what edits, and to revert to older versions if necessary. So, I'd like to see Mahara gain the ability to keep track of a page's edit history. At a minimum it needs: 1. Who made changes, at what time 2. What the page looked like at each revision 3. Ability to revert the page to a previous version Also good would be: 4. Ability to "diff" versions and highlight what changed 5. Comments that go in the history log 6. "Publish" ability (including publishing at a later time/date) 7. Versioning file attachments, see also https://bugs.launchpad.net/mahara/+bug/548195 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1157543/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1157543] Re: Record page editing history
PS: Will give more consideration to whether we can avoid serializing the data. Re using JSON instead, fine - I wasn't aware of those issues. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1157543 Title: Record page editing history Status in Mahara ePortfolio: In Progress Bug description: I'd like to "dogfood" Mahara's developer documentation by moving it from Mediawiki to the Mahara platform itself, probably as group pages so it could still be edited by many people. One of the features that is lacking to make this feasible, though, is having an edit history. The wiki allows us to keep track of who made what edits, and to revert to older versions if necessary. So, I'd like to see Mahara gain the ability to keep track of a page's edit history. At a minimum it needs: 1. Who made changes, at what time 2. What the page looked like at each revision 3. Ability to revert the page to a previous version Also good would be: 4. Ability to "diff" versions and highlight what changed 5. Comments that go in the history log 6. "Publish" ability (including publishing at a later time/date) 7. Versioning file attachments, see also https://bugs.launchpad.net/mahara/+bug/548195 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1157543/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1407511] [NEW] usr_institution uses institution name as foreign key
Public bug reported: In current Mahara dev at the time of writing (15.04-dev), the usr_institution table uses the institution name rather than its ID as a foreign key. This will slow things down because it forces string comparisons to be done instead of simple numeric value comparisons. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1407511 Title: usr_institution uses institution name as foreign key Status in Mahara ePortfolio: New Bug description: In current Mahara dev at the time of writing (15.04-dev), the usr_institution table uses the institution name rather than its ID as a foreign key. This will slow things down because it forces string comparisons to be done instead of simple numeric value comparisons. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1407511/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1157543] Re: Record page editing history
Hi guys. Getting back to this for at least a little while. Kristina, I agree that you might not want to keep versions of everything. Perhaps there could be a sitewide or finer grained configuration (per institution / group / user and/or per object type?) option that controls whether revisions are automatically saved. If that's disabled, there would then be a button that let the user manually choose to save a new revision. I like the idea of being able to tag revisions and easily access them. That should be done no matter what else is decided. Regarding when revisions are made, it's got to be when the data is saved (regardless of whether that's by ajax or by clicking 'Done'). Thinking of what was written above again, I'd suggest that if revisions are being automatically saved, there should be an easily accessible way of controlling things (Radio button / drop down for switching between Don't save revisions / Combine all the changes being made into 1 revision / New revision on each change). -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1157543 Title: Record page editing history Status in Mahara ePortfolio: In Progress Bug description: I'd like to "dogfood" Mahara's developer documentation by moving it from Mediawiki to the Mahara platform itself, probably as group pages so it could still be edited by many people. One of the features that is lacking to make this feasible, though, is having an edit history. The wiki allows us to keep track of who made what edits, and to revert to older versions if necessary. So, I'd like to see Mahara gain the ability to keep track of a page's edit history. At a minimum it needs: 1. Who made changes, at what time 2. What the page looked like at each revision 3. Ability to revert the page to a previous version Also good would be: 4. Ability to "diff" versions and highlight what changed 5. Comments that go in the history log 6. "Publish" ability (including publishing at a later time/date) 7. Versioning file attachments, see also https://bugs.launchpad.net/mahara/+bug/548195 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1157543/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1409546] [NEW] Smart Evidence - Phase 1 - SmartEvidence Module
Public bug reported: This bug is for implementation of the following aspects of bug 1397759: 2 - Smartevidence artefact/plugin OR Site admin flag to enable SmartEvidence.: * For this phase, perhaps just dummy stubs to enable smartevidence(?). If not enough time, for now, a flag in site options page that can be pulled out later into its own smartevidence plugin. * A site administrator can turn on the “SmartEvidence” functionality for the entire site, e.g. enabling a plugin. Once allowed in general, institution administrators can decide whether to allow “SmartEvidence” in their institutions or not. The functionality needs to be turned on specifically, as it will add a lot of functionality, at least one menu item etc. to the Mahara instance. Once the functionality has been turned on and changes have been made either on the site or institution level, it cannot be turned off anymore. 3 - Institution configuration to enable SmartEvidence for an institution. * Still need to work out affect on users with multiple institutions (who are admins in one but not the others). 4 - New Admin menu for 'Smart Evidence': * New menu item in Administration – 'Smart Evidence'. With sub-menu 'Page Categories' – like group categories page. * Menu will appear only if Smartevidence plugin is installed. * For institutions, will appear if institution has switched on the flag. 5 - Page/Collection Category : * New fixed system category 'SmartEvidence'. * Site administrators can set up categories for pages and collections similarly to the concept of group categories. * The category “SmartEvidence” is provided by default when the site administrator allowed the functionality in general and can only be selected and seen by site and institution administrators when they create institution or site pages / collections as these pages and collections will need to be set up on the institution or site level. Institution administrators only see the category when their institution allows “SmartEvidence”. * Only institution and site administrators will be able to see the category chooser when creating pages and collections. * Pages and collections get categories added so that it will be easier in the future to categorize pages and collections ** Affects: mahara Importance: Undecided Assignee: Nigel Cunningham (nigelc-g) Status: New ** Tags: smartevidence -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1409546 Title: Smart Evidence - Phase 1 - SmartEvidence Module Status in Mahara ePortfolio: New Bug description: This bug is for implementation of the following aspects of bug 1397759: 2 - Smartevidence artefact/plugin OR Site admin flag to enable SmartEvidence.: * For this phase, perhaps just dummy stubs to enable smartevidence(?). If not enough time, for now, a flag in site options page that can be pulled out later into its own smartevidence plugin. * A site administrator can turn on the “SmartEvidence” functionality for the entire site, e.g. enabling a plugin. Once allowed in general, institution administrators can decide whether to allow “SmartEvidence” in their institutions or not. The functionality needs to be turned on specifically, as it will add a lot of functionality, at least one menu item etc. to the Mahara instance. Once the functionality has been turned on and changes have been made either on the site or institution level, it cannot be turned off anymore. 3 - Institution configuration to enable SmartEvidence for an institution. * Still need to work out affect on users with multiple institutions (who are admins in one but not the others). 4 - New Admin menu for 'Smart Evidence': * New menu item in Administration – 'Smart Evidence'. With sub-menu 'Page Categories' – like group categories page. * Menu will appear only if Smartevidence plugin is installed. * For institutions, will appear if institution has switched on the flag. 5 - Page/Collection Category : * New fixed system category 'SmartEvidence'. * Site administrators can set up categories for pages and collections similarly to the concept of group categories. * The category “SmartEvidence” is provided by default when the site administrator allowed the functionality in general and can only be selected and seen by site and institution administrators when they create institution or site pages / collections as these pages and collections will need to be set up on the institution or site level. Institution administrators only see the category when their institution allows “SmartEvidence”. * Only institution and site administrator
[Mahara-contributors] [Bug 1397759] Re: SmartEvidence Enhancement - Phase 1
** Tags added: smartevidence -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1397759 Title: SmartEvidence Enhancement - Phase 1 Status in Mahara ePortfolio: In Progress Bug description: University of Canberra would like to fund an enhancement for SmartEvidence - where the user may upload evidence to support a particular standard related to their field of study/work - for evidence based learning. A summary of some of the features (for later phases include): - A standards framework will be input/uploaded in the Admin area for the relevant standard for a site and/or instution. - Each standard has a "descriptor" which the user can use to link a piece of evidence to. - Site/institution templates are create with the fixed category 'SmartEvidence'. - Traditionally, organisations use paper based evidence maps. This will be digitised as a Standards grid (SmartEvidence map) - based on the standards framework used for the site/institution. - Interactive elements are added to the grid for managing evidence against standards and accessing information about the standards framework, thus forming the essential elements of SmartEvidence. - The user creates annotations linking a piece of evidence to a particular standard in the framework. - Evaluators can "rate" the quality of the evidence. - Lots more... In this initial phase, we'll introduce (as much as possible of the following): 1- Annotation artefact - a new artefact similar to the comment artefact but with less functionality (i.e. no attached files, etc). It's an explenation of why a particular evidence meets a particular standard. * An annotation can consist only of a text field (WYSIWYG editor is OK). * Users can add as many “Annotation” blocks to their page as they wish since they can associate their page with a number of standards descriptors. Once the annotations are converted to the full functionality, there will be a way to select the associated standards descriptor. For the moment, the user would enter that manually into the text field. * It will not be possible to attach files or star ratings to an annotation. If a user wants to leave those on a page or an artefact, they should use the standard feedback functionality. * Annotations can be changed until the first comment was made to prevent changes to the annotation after another user made a comment. * Comments on annotations cannot be deleted if they have been made by staff or administrators. If they were made by others, they can be deleted, and the comment author would receive an email about it like happens for deleted feedback. * The title of the block cannot be changed. The University of Canberra provides a short title that should be used. The title shall not be changed because in the future, with the full functionality available, these blocks need to be converted and a standard string will be used for the title then depending on the SmartEvidence map that is set up. 2 - Smartevidence artefact/plugin OR Site admin flag to enable SmartEvidence.: * For this phase, perhaps just dummy stubs to enable smartevidence(?). If not enough time, for now, a flag in site options page that can be pulled out later into its own smartevidence plugin. * A site administrator can turn on the “SmartEvidence” functionality for the entire site, e.g. enabling a plugin. Once allowed in general, institution administrators can decide whether to allow “SmartEvidence” in their institutions or not. The functionality needs to be turned on specifically, as it will add a lot of functionality, at least one menu item etc. to the Mahara instance. Once the functionality has been turned on and changes have been made either on the site or institution level, it cannot be turned off anymore. 3 - Institution configuration to enable SmartEvidence for an institution. * Still need to work out affect on users with multiple institutions (who are admins in one but not the others). 4 - New Admin menu for 'Smart Evidence': * New menu item in Administration – 'Smart Evidence'. With sub-menu 'Page Categories' – like group categories page. * Menu will appear only if Smartevidence plugin is installed. * For institutions, will appear if institution has switched on the flag. 5 - Page/Collection Category : * New fixed system category 'SmartEvidence'. * Site administrators can set up categories for pages and collections similarly to the concept of group categories. * The category “SmartEvidence” is provided by default when the site administrator allowed the functionality in general and can only be select