[MediaWiki-commits] [Gerrit] Avoid PHP notices in MessageCollection - change (mediawiki...Translate[master])
Nikerabbit has uploaded a new change for review. Change subject: Avoid PHP notices in MessageCollection .. Avoid PHP notices in MessageCollection Triggered by the API when using filters in unexpected order. Fixed by making sure the message map is built before any keys are filtered from the list. Change-Id: I7a6011042c8856812339b714186a56bebfbb1ef7 --- M MessageCollection.php 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/92/32692/1 -- To view, visit https://gerrit.wikimedia.org/r/32692 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a6011042c8856812339b714186a56bebfbb1ef7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add grammar tests for Hebrew - change (mediawiki/core[master])
Amire80 has uploaded a new change for review. Change subject: Add grammar tests for Hebrew .. Add grammar tests for Hebrew Change-Id: I0114c87ec63cc224f42c81497af41fe6e72a59bc --- M tests/phpunit/languages/LanguageHeTest.php 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/93/32693/1 -- To view, visit https://gerrit.wikimedia.org/r/32693 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0114c87ec63cc224f42c81497af41fe6e72a59bc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove broken link, consolidate GitHub links - change (operations/mediawiki-config[master])
Eloquence has uploaded a new change for review. Change subject: Remove broken link, consolidate GitHub links .. Remove broken link, consolidate GitHub links Change-Id: Ide637b45142bf7b4d474676df95dbbc6428923a3 --- M docroot/noc/index.html 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/94/32694/1 -- To view, visit https://gerrit.wikimedia.org/r/32694 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide637b45142bf7b4d474676df95dbbc6428923a3 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Eloquence e...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Avoid PHP notices in MessageCollection - change (mediawiki...Translate[master])
Siebrand has submitted this change and it was merged. Change subject: Avoid PHP notices in MessageCollection .. Avoid PHP notices in MessageCollection Triggered by the API when using filters in unexpected order. Fixed by making sure the message map is built before any keys are filtered from the list. Change-Id: I7a6011042c8856812339b714186a56bebfbb1ef7 --- M MessageCollection.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32692 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a6011042c8856812339b714186a56bebfbb1ef7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make sure that SQLite uses no prefix - change (mediawiki/core[master])
MaxSem has uploaded a new change for review. Change subject: Make sure that SQLite uses no prefix .. Make sure that SQLite uses no prefix Otherwise, when user selects MySQL, sets the prefix, then switches to SQLite, the tables will created with prefix however the prefix will be absent from LocalSettings, making the wiki dead on arrival. Change-Id: I6360af819f87b03c2e9967207c43bca95f931a00 --- M includes/installer/SqliteInstaller.php 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/95/32695/1 -- To view, visit https://gerrit.wikimedia.org/r/32695 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6360af819f87b03c2e9967207c43bca95f931a00 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: MaxSem maxsem.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Moved RecentAdditionsMessageGroup.php to the right dir - change (mediawiki...Translate[master])
Amire80 has uploaded a new change for review. Change subject: Moved RecentAdditionsMessageGroup.php to the right dir .. Moved RecentAdditionsMessageGroup.php to the right dir Change-Id: Idb2ee77d320bf59755905c9fa6a736966649c264 --- R messagegroups/RecentAdditionsMessageGroup.php 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/96/32696/1 -- To view, visit https://gerrit.wikimedia.org/r/32696 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idb2ee77d320bf59755905c9fa6a736966649c264 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 35923) tweaks to mediawiki.action.history.diff.css - change (mediawiki/core[master])
TheDJ has submitted this change and it was merged. Change subject: (bug 35923) tweaks to mediawiki.action.history.diff.css .. (bug 35923) tweaks to mediawiki.action.history.diff.css This is a followup from bug 11374. This patch has some fixes and final tweaks for the code currently in trunk. * Reorganized the CSS to specificallity. * Changed table width to 100%, and added zero margin for table, so no horizontal scrollbars. * Changed horizontal padding in table.diff td from 0.66em to 0.5em, making max use of expensive horizontal real estate. * Override default vertical 0.33em padding in td.diff-marker with 0.25em to compensate for increased fontsize of the marker (+ and -), which caused unwanted padding at the bottom in one-line diff rules. * Changed the background for td.diff-context to #f9f9f9, which is the same as the background for wikitables. (BTW, the default background for Vector is #f6f6f6, not the current #f3f3f3 as stated on wikitech-l). * Removed 'overflow: auto' fallback for table.diff td div, as this creates unwanted scrollbars in IE 8 and 9. The fallback targeted a very limited set of older browsers anyway. The NewDiff gadget on enwiki has all these fixes implemented, so you can evaluate this code. Change-Id: Ic9da00bc13ad8c322c19648c7d3ac8abec2eaa07 --- M resources/mediawiki.action/mediawiki.action.history.diff.css 1 file changed, 35 insertions(+), 45 deletions(-) Approvals: Edokter: Looks good to me, but someone else must approve Matmarex: Looks good to me, but someone else must approve TheDJ: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/25743 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9da00bc13ad8c322c19648c7d3ac8abec2eaa07 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex matma@gmail.com Gerrit-Reviewer: Catrope roan.katt...@gmail.com Gerrit-Reviewer: Edokter er...@darcoury.nl Gerrit-Reviewer: Isarra zhoris...@gmail.com Gerrit-Reviewer: MarkTraceur mtrac...@member.fsf.org Gerrit-Reviewer: Matmarex matma@gmail.com Gerrit-Reviewer: TheDJ hartman.w...@gmail.com Gerrit-Reviewer: Trevor Parscal tpars...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Follow-up I3df95f84: Put file in correct folder - change (mediawiki...Translate[master])
Siebrand has uploaded a new change for review. Change subject: Follow-up I3df95f84: Put file in correct folder .. Follow-up I3df95f84: Put file in correct folder Change-Id: Iba1db695ea395f738fa92999a40f524480f2ec44 --- R messagegroups/RecentAdditionsMessageGroup.php 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/97/32697/1 -- To view, visit https://gerrit.wikimedia.org/r/32697 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iba1db695ea395f738fa92999a40f524480f2ec44 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Follow-up I3df95f84: Put file in correct folder - change (mediawiki...Translate[master])
Siebrand has submitted this change and it was merged. Change subject: Follow-up I3df95f84: Put file in correct folder .. Follow-up I3df95f84: Put file in correct folder Change-Id: Iba1db695ea395f738fa92999a40f524480f2ec44 --- R messagegroups/RecentAdditionsMessageGroup.php 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Siebrand: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32697 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba1db695ea395f738fa92999a40f524480f2ec44 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding configuration variable for ESI support - change (mediawiki...MobileFrontend[master])
awjrichards has uploaded a new change for review. Change subject: Adding configuration variable for ESI support .. Adding configuration variable for ESI support Change-Id: Ibfcd7a4d3eb6d70dd94110474049dc0569609951 --- M MobileFrontend.php 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/98/32698/1 -- To view, visit https://gerrit.wikimedia.org/r/32698 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibfcd7a4d3eb6d70dd94110474049dc0569609951 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: awjrichards aricha...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add grammar tests for Hebrew - change (mediawiki/core[master])
Siebrand has submitted this change and it was merged. Change subject: Add grammar tests for Hebrew .. Add grammar tests for Hebrew Change-Id: I0114c87ec63cc224f42c81497af41fe6e72a59bc --- M tests/phpunit/languages/LanguageHeTest.php 1 file changed, 37 insertions(+), 0 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32693 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0114c87ec63cc224f42c81497af41fe6e72a59bc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il Gerrit-Reviewer: Logicwiki srik@gmail.com Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding config variable for ESI support - change (mediawiki...MobileFrontend[esisupport])
awjrichards has uploaded a new change for review. Change subject: Adding config variable for ESI support .. Adding config variable for ESI support Change-Id: Ie5d7833fcd81724555460f1a7ec6af41e09409ad --- M MobileFrontend.php 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/99/32699/1 -- To view, visit https://gerrit.wikimedia.org/r/32699 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie5d7833fcd81724555460f1a7ec6af41e09409ad Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: esisupport Gerrit-Owner: awjrichards aricha...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding config variable for ESI support - change (mediawiki...MobileFrontend[esisupport])
MaxSem has submitted this change and it was merged. Change subject: Adding config variable for ESI support .. Adding config variable for ESI support Change-Id: Ie5d7833fcd81724555460f1a7ec6af41e09409ad --- M MobileFrontend.php 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: MaxSem: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32699 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5d7833fcd81724555460f1a7ec6af41e09409ad Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: esisupport Gerrit-Owner: awjrichards aricha...@wikimedia.org Gerrit-Reviewer: MaxSem maxsem.w...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 41291- Get browser info w/ user permission - change (mediawiki/core[master])
Nischayn22 has uploaded a new change for review. Change subject: Bug 41291- Get browser info w/ user permission .. Bug 41291- Get browser info w/ user permission Adds a checkbox in the dialog form with a label asking for permissions to send browser information along with feedback. The browser info is only sent if the checkbox is checked. Change-Id: I37b1a271af115ed07012544d1beaea13601b3c62 --- M languages/messages/MessagesEn.php M languages/messages/MessagesQqq.php M resources/Resources.php M resources/mediawiki/mediawiki.feedback.js 4 files changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/00/32700/1 -- To view, visit https://gerrit.wikimedia.org/r/32700 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I37b1a271af115ed07012544d1beaea13601b3c62 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Nischayn22 nischay...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Moar memory - change (operations/mediawiki-config[master])
Reedy has uploaded a new change for review. Change subject: Moar memory .. Moar memory Change-Id: Ic94a77bcb9e1917304deaa09e74e96a58dc9165d --- M wmf-config/InitialiseSettings.php 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/01/32701/1 -- To view, visit https://gerrit.wikimedia.org/r/32701 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic94a77bcb9e1917304deaa09e74e96a58dc9165d Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 41827 - Dynamic message groups not in list=messagecollec... - change (mediawiki...Translate[master])
Malkum has uploaded a new change for review. Change subject: Bug 41827 - Dynamic message groups not in list=messagecollection API .. Bug 41827 - Dynamic message groups not in list=messagecollection API Fixed by copying the code from SpecialTranslate.php to get the groups collection working in the api. Change-Id: I602454e90aa35bb13fdbc242687db1971ea79a4a --- M api/ApiQueryMessageCollection.php 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/02/32702/1 -- To view, visit https://gerrit.wikimedia.org/r/32702 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I602454e90aa35bb13fdbc242687db1971ea79a4a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Malkum dev.mal...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Moar memory - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: Moar memory .. Moar memory Change-Id: Ic94a77bcb9e1917304deaa09e74e96a58dc9165d --- M wmf-config/InitialiseSettings.php 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32701 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic94a77bcb9e1917304deaa09e74e96a58dc9165d Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wm3 - wmf3 - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: wm3 - wmf3 .. wm3 - wmf3 Change-Id: I8b7656bb8a62334f7bf8d5aabf4a27a7612dc0d7 --- M wikiversions.dat 1 file changed, 272 insertions(+), 272 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved Hashar: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32255 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b7656bb8a62334f7bf8d5aabf4a27a7612dc0d7 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Hashar has...@free.fr Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 41827 - Dynamic message groups not in list=messagecollec... - change (mediawiki...Translate[master])
Nikerabbit has submitted this change and it was merged. Change subject: Bug 41827 - Dynamic message groups not in list=messagecollection API .. Bug 41827 - Dynamic message groups not in list=messagecollection API Fixed by copying the code from SpecialTranslate.php to get the groups collection working in the api. Change-Id: I602454e90aa35bb13fdbc242687db1971ea79a4a --- M api/ApiQueryMessageCollection.php 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32702 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I602454e90aa35bb13fdbc242687db1971ea79a4a Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Malkum dev.mal...@gmail.com Gerrit-Reviewer: Malkum dev.mal...@gmail.com Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add UserMerge to branched extensions - change (mediawiki...release[master])
Reedy has submitted this change and it was merged. Change subject: Add UserMerge to branched extensions .. Add UserMerge to branched extensions Change-Id: Ibaae723dcdede17515e6226782559e76a8a79130 --- M make-wmf-branch/default.conf 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32010 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibaae723dcdede17515e6226782559e76a8a79130 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/release Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Swap for regex matching - change (mediawiki...release[master])
Reedy has submitted this change and it was merged. Change subject: Swap for regex matching .. Swap for regex matching Add case to cater for Update foo to master etc Change-Id: If3f936a915738d6321aeafb58b8fea40343cfc23 --- M make-deploy-notes/make-deploy-notes 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32224 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3f936a915738d6321aeafb58b8fea40343cfc23 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/release Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added message documentation - change (mediawiki...SemanticExtraSpecialProperties[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Added message documentation .. Added message documentation Change-Id: Ib8bbfa1b8b22529731e7f9fd18a0642d7023d2a0 --- M SemanticExtraSpecialProperties.i18n.php 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Mwjames: Looks good to me, but someone else must approve Nischayn22: Looks good to me, but someone else must approve Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32602 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8bbfa1b8b22529731e7f9fd18a0642d7023d2a0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticExtraSpecialProperties Gerrit-Branch: master Gerrit-Owner: Rotsee leo_wallen...@hotmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix fatal error with the dynamic message groups - change (mediawiki...Translate[master])
Nikerabbit has uploaded a new change for review. Change subject: Fix fatal error with the dynamic message groups .. Fix fatal error with the dynamic message groups Change-Id: Ie8ad7b5f8a3b53dc4e784eb94a62afd9e70009c5 --- M api/ApiQueryMessageCollection.php 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/03/32703/1 -- To view, visit https://gerrit.wikimedia.org/r/32703 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie8ad7b5f8a3b53dc4e784eb94a62afd9e70009c5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Special page for outputting ESI chunks - change (mediawiki...MobileFrontend[esisupport])
MaxSem has uploaded a new change for review. Change subject: Special page for outputting ESI chunks .. Special page for outputting ESI chunks Change-Id: Ife73c62555ba2b032c65fd36cd273e8796fdc778 --- M MobileFrontend.alias.php M MobileFrontend.php A includes/specials/SpecialEsi.php 3 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/04/32704/1 -- To view, visit https://gerrit.wikimedia.org/r/32704 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ife73c62555ba2b032c65fd36cd273e8796fdc778 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: esisupport Gerrit-Owner: MaxSem maxsem.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Lint: Go-go-gadget jshint! Passing entire JS code base (agai... - change (mediawiki/core[master])
Hashar has submitted this change and it was merged.
Change subject: Lint: Go-go-gadget jshint! Passing entire JS code base (again).
..
Lint: Go-go-gadget jshint! Passing entire JS code base (again).
There were still some files not passing jshint, and for files
that did, we managed to screw 'em up again.
Added more explicit settings in .jshintrc to avoid relying on a
kind of default somewhere. There are too many default-factors:
closest(.jshintrc), ~/.jshintrc, IDE/editor, node-jshint..
Added node_modules/ and extensions/ to .jshintignore.
Previously $ jshint . would recurse over all kinds of
unrelated code. Extensions should have their own jshint
dotfiles. When linting from Jenkins this won't be a problem as
those will be ran per repo (so when linting core it will skip extensions and
when in an extension dir, the core dotfiles
don't apply as they'll be out of scope).
Some of our modules are really messy and should be refactored
to be less spaghetti-ish and have more descriptive variable
names and more manageable function-level complexity.
But for this commit, I'm keeping it as much as-is as possible,
because its hard/large enough to review as it is.
A few errors are cited below to give an impression of the kind
of warnings I addressed (for cases where the diff isn't
so obvious):
* jquery.hidpi.js: line 110, col 15, Empty block.
* mediawiki.jqueryMsg.js: line 34, col 17, Too many var statements.
* mediawiki.jqueryMsg.js: line 145, col 33, Strings must use singlequote.
* mediawiki.action.edit.js: line 74, col 73, 'selectText' is defined but never
used.
* startup.js: line 19, col 22, 'isCompatible' is defined but never used.
* jquery.byteLength.test.js: line 26, col 9, Identifier 'U_00A2' is not in
camel case.
* jquery.localize.test.js: line 63, col 29, 'attrs' is defined but never used.
* mediawiki.cldr.test.js: line 72, col 27, 'mw' is not defined.
* mediawiki.jscompat.test.js: line 6, col 17, Strings must use singlequote.
* mediawiki.api.parse.test.js: line 9, col 17, Strings must use singlequote.
* mediawiki.api.parse.test.js: line 7, col 15, 'mw' is not defined.
* mediawiki.api.parse.test.js: line 14, col 24, '$' is not defined.
* mediawiki.api.test.js: line 43, col 28, 'data' is defined but never used.
Other fixes:
* Add closures fix implied global errors ($, mw and more),
and prevents local variables from becoming globals.
* Avoid jQ magic map arg etc. (per code conventions).
* Fix incorrect usage of jQuery methods (prop instead of attr,
prop false instead of removeProp, ..).
* Unquote keys in object literals for consistency, and
enforce single quotes (no magic quotes in javascript, as much
as we might think \n and '/n' are really exactly the same).
Chose single quotes over double quotes since that's what most
code already had and what conventions seemed to prefer
(both the old generic ones and the new per-lang ones since
2011/2012).
* Enforce camelCase variable names with jshint per code
conventions.
* $foo.on('x', fn).trigger('x') - $foo.on('x', fn); fn()
(No event simulation overhead, unless intended of course)
* Incorrect indentation (ignore whitespace in the diff!).
* Avoid proprietary selectors like ':first' when .eq(0)
afterwards is just as possible (significantly faster in
jQuery due to mostly avoiding the Sizzle engine and going
native in modern browsers).
* When at it, convert deprecated jQuery methods to new ones.
Mostly just .delegate(sel, type, fn) - .on(type, sel, fn).
* Addressed whitespace here and there.
Interesting:
* mediawiki.js: local function compare wasn't used anymore
(hasn't been in a while!) removed per jshint warning.
* mediawiki.special.recentchanges.js: Was a mess, only a few
lines of code, rewritten.
Pfew, let's hope it's the last one before we lint from Jenkins!
Change-Id: I23ad60a1d804c542d9b91454aaa20ce7be4ff289
---
M .gitignore
M .jshintignore
M .jshintrc
M resources/jquery/jquery.checkboxShiftClick.js
M resources/jquery/jquery.client.js
M resources/jquery/jquery.collapsibleTabs.js
M resources/jquery/jquery.colorUtil.js
M resources/jquery/jquery.expandableField.js
M resources/jquery/jquery.hidpi.js
M resources/jquery/jquery.highlightText.js
M resources/jquery/jquery.mw-jump.js
M resources/jquery/jquery.mwExtension.js
M resources/jquery/jquery.qunit.completenessTest.js
M resources/jquery/jquery.suggestions.js
M resources/jquery/jquery.textSelection.js
M resources/mediawiki.action/mediawiki.action.edit.js
M resources/mediawiki.language/mediawiki.cldr.js
M resources/mediawiki.language/mediawiki.language.init.js
M resources/mediawiki.language/mediawiki.language.js
M resources/mediawiki.page/mediawiki.page.ready.js
M resources/mediawiki.page/mediawiki.page.watch.ajax.js
M resources/mediawiki.special/mediawiki.special.block.js
M resources/mediawiki.special/mediawiki.special.javaScriptTest.js
M resources/mediawiki.special/mediawiki.special.js
M
[MediaWiki-commits] [Gerrit] More update to master variants - change (mediawiki...release[master])
Reedy has uploaded a new change for review. Change subject: More update to master variants .. More update to master variants Change-Id: I34f384b59e89e43a04f41da385dfa88f9c3b87bb --- M make-deploy-notes/make-deploy-notes 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release refs/changes/05/32705/1 -- To view, visit https://gerrit.wikimedia.org/r/32705 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I34f384b59e89e43a04f41da385dfa88f9c3b87bb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/release Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] More update to master variants - change (mediawiki...release[master])
Reedy has submitted this change and it was merged. Change subject: More update to master variants .. More update to master variants Change-Id: I34f384b59e89e43a04f41da385dfa88f9c3b87bb --- M make-deploy-notes/make-deploy-notes 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32705 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34f384b59e89e43a04f41da385dfa88f9c3b87bb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/release Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Simplify cached check in Special:SpecialPages - change (mediawiki/core[master])
IAlex has submitted this change and it was merged. Change subject: Simplify cached check in Special:SpecialPages .. Simplify cached check in Special:SpecialPages There is no need to repeat the condition from QueryPage::isCached and check the misermode self. Moved the method QueryPage::isCached to SpecialPage::isCached for easy calling. Maybe in future some special pages would get cached and define its own condition for that, so making false as default. Simplify a count and add some spaces. Change-Id: I71c9991e136f9c1a6a0123ae5305b39777d9135c --- M includes/SpecialPage.php M includes/specials/SpecialSpecialpages.php 2 files changed, 21 insertions(+), 5 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/29987 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71c9991e136f9c1a6a0123ae5305b39777d9135c Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender umherirrender_de...@web.de Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org Gerrit-Reviewer: Asher afeld...@wikimedia.org Gerrit-Reviewer: IAlex ialex.w...@gmail.com Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: Tim Starling tstarl...@wikimedia.org Gerrit-Reviewer: Umherirrender umherirrender_de...@web.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Take a git hash too - change (mediawiki...release[master])
Reedy has uploaded a new change for review. Change subject: Take a git hash too .. Take a git hash too Change-Id: Ib031909f8dd48ca823bfab2dbd3428f960f92d37 --- M make-deploy-notes/make-deploy-notes 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release refs/changes/06/32706/1 -- To view, visit https://gerrit.wikimedia.org/r/32706 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib031909f8dd48ca823bfab2dbd3428f960f92d37 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/release Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Take a git hash too - change (mediawiki...release[master])
Reedy has submitted this change and it was merged. Change subject: Take a git hash too .. Take a git hash too Change-Id: Ib031909f8dd48ca823bfab2dbd3428f960f92d37 --- M make-deploy-notes/make-deploy-notes 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32706 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib031909f8dd48ca823bfab2dbd3428f960f92d37 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/release Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update location for toolserver files - change (translatewiki[master])
Siebrand has uploaded a new change for review. Change subject: Update location for toolserver files .. Update location for toolserver files Change-Id: Icad88e54a5ba2aa968cf811a38130c6b1bbfc493 --- M REPOCONF M bin/repocommit M bin/repocreate M bin/repoupdate 4 files changed, 4 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/translatewiki refs/changes/07/32707/1 -- To view, visit https://gerrit.wikimedia.org/r/32707 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icad88e54a5ba2aa968cf811a38130c6b1bbfc493 Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update tags - change (translatewiki[master])
Siebrand has uploaded a new change for review. Change subject: Update tags .. Update tags Change-Id: I80a664f08d128b94e60c1acd554635236eae --- M FreeCol/FreeCol.yaml 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/translatewiki refs/changes/08/32708/1 -- To view, visit https://gerrit.wikimedia.org/r/32708 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I80a664f08d128b94e60c1acd554635236eae Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Special page for outputting ESI chunks - change (mediawiki...MobileFrontend[esisupport])
awjrichards has submitted this change and it was merged. Change subject: Special page for outputting ESI chunks .. Special page for outputting ESI chunks Change-Id: Ife73c62555ba2b032c65fd36cd273e8796fdc778 --- M MobileFrontend.alias.php M MobileFrontend.php A includes/specials/SpecialEsi.php 3 files changed, 29 insertions(+), 0 deletions(-) Approvals: awjrichards: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32704 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife73c62555ba2b032c65fd36cd273e8796fdc778 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: esisupport Gerrit-Owner: MaxSem maxsem.w...@gmail.com Gerrit-Reviewer: awjrichards aricha...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update location for toolserver files - change (translatewiki[master])
Nikerabbit has submitted this change and it was merged. Change subject: Update location for toolserver files .. Update location for toolserver files Change-Id: Icad88e54a5ba2aa968cf811a38130c6b1bbfc493 --- M REPOCONF M bin/repocommit M bin/repocreate M bin/repoupdate 4 files changed, 4 insertions(+), 7 deletions(-) Approvals: Nikerabbit: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32707 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icad88e54a5ba2aa968cf811a38130c6b1bbfc493 Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update tags - change (translatewiki[master])
Nikerabbit has submitted this change and it was merged. Change subject: Update tags .. Update tags Change-Id: I80a664f08d128b94e60c1acd554635236eae --- M FreeCol/FreeCol.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Nikerabbit: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32708 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80a664f08d128b94e60c1acd554635236eae Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Rewritten SQLStore3 writing methods - change (mediawiki...SemanticMediaWiki[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Rewritten SQLStore3 writing methods .. Rewritten SQLStore3 writing methods This is a rewrite of large parts of SMW_SQLStore3_Writers.php. The only methods that are almost unaffected are the ones related to cahning titles and processing redirects (may appear changed in diff since they have been moved to the end). This change should fix the property statistics computation. It also prepares an acurate semantic diff implementation later on. Main changes/key points: * Cleaned up code, splitting everything into smaller methods with a clear task. * Changed writing workflow to compute a full diff of table rows before writing anything * The new writing code deletes only the table rows that are really obsolete, and inserts only those that are added. If a change only deletes or adds one value, then this is all that will be done. * The property statistics are updeated by comparing the real DB contents to the new contents that is to be written. No higher-level data structures or SMW objects are invloved. * There is no longer a separate delete method. To delete all data, we update it to be empty. This ensures that all necessary updates really happen whenever the store is changed (since there are fewer methods that change the store at all). * The new code has no issues with input errors or redirects any more. * The code is now properly documented. Patch set 2: Small change. * Improve some details in method design (e.g. pass a table object where a table name was passed). * Improve the construction of DELETE conditions for (supposed) performance gain. * Fix a few typos in inline comments. * Call freeResult() on a DB result where this had been forgotten. Change-Id: I78596341b4427604c31b6d3b15acd894e47ccec0 --- M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php 5 files changed, 499 insertions(+), 397 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32397 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78596341b4427604c31b6d3b15acd894e47ccec0 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Beware that getContent() may return null - change (mediawiki/core[master])
IAlex has submitted this change and it was merged. Change subject: Beware that getContent() may return null .. Beware that getContent() may return null Before the introduction of the content handler, missing content was signified by getText() returning null instead of a string. null will work much like an empty string in most contexts, so in many places, it was not checked explcitely whether the conent was null. Now, when getContent() returns null, this often caused a fatal error, because the code would access whatever getContent() returned as an object, without checking whether it was null (because no such check was performed previously, when the content was represented as a string). This check introduces explicite checks for getContent() returning null in the most essential core classes. Change-Id: I551a90b0b67b8edc7570ca5d252ecc1de903f097 --- M includes/Article.php M includes/Revision.php M includes/Title.php M includes/WikiPage.php M includes/diff/DifferenceEngine.php M includes/job/jobs/DoubleRedirectJob.php M includes/job/jobs/RefreshLinksJob.php M includes/parser/Parser.php M includes/resourceloader/ResourceLoaderWikiModule.php M includes/search/SearchEngine.php 10 files changed, 64 insertions(+), 46 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32588 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I551a90b0b67b8edc7570ca5d252ecc1de903f097 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Demon ch...@wikimedia.org Gerrit-Reviewer: IAlex ialex.w...@gmail.com Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Store3: tablenames, usage count init, style - change (mediawiki...SemanticMediaWiki[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Store3: tablenames, usage count init, style .. Store3: tablenames, usage count init, style This complex change prepares SQLStore3 for release. After updating, you *must* delete and recreate all Store3 tables, e.g., as follows: * first run php SMW_refreshData.php -b SMWSQLStore3 -fp to recreate tables and initialise property pages, * then run php SMW_refreshData.php -b SMWSQLStore3 again to refresh all normal pages. This will not affect the functionality of Store2, if still used. The change does three things: * Change the names of the tables formerly known as smw_ids, smw_conccache, smw_stats (the first two are used by Store2 already; the last was just not very well named and easy to update with the rest); the new names are smw_object_ids, smw_concept_cache, smw_prop_stats. The rename of smw_ids is the reason why a normal setup+refresh will not do. * Update the batch computation of usage counts (in SMW_SQLStore3_SetupHandlers.php); the old computation counted only values of a property that are stored in the table that the property uses *now* to store its data, missing uses in other tables (e.g., due to new special tables being created or due to plain type changes) * The maintenance script SMW_resetStats.php is removed since its job is now done by SMW_setup.php (its old code was outdated anyway) * The broken maintenance script SMW_migration.php is disabled, printing a message on what to do instead. * Many smaller style improvements, especially in documentation. The change depends on the recent writer change, since it is not possible to separate this. Change-Id: I1a163ac23121c373fb9ef5c93eb1a50ed33d85a6 --- M includes/storage/SQLStore/SMW_DataItemHandler.php M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php M maintenance/SMW_migration.php D maintenance/SMW_resetStats.php 10 files changed, 338 insertions(+), 292 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32583 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a163ac23121c373fb9ef5c93eb1a50ed33d85a6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 38811 - change (mediawiki...SemanticMediaWiki[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix Bug 38811 .. Fix Bug 38811 Special:UnusedProperties was not checking if a property is special (pre-defined in SMW). This is fixed now, and thus the datatype information for unused special properties shows correctly and the standard tooltip is given. The formatting code for special properties is copied from Special:Properties, so the formatting will be the same as it is there. The change depends on the recent updates done to fix Bug 33610. Patch set 2: Also make a small change in the Proeprty datavalue to make sure that the CSS styles for highlighting special properties are really included whenever they are needed. Fixes the missing italics for special properties in all Special pages that list properties. Change-Id: I0a49c1dae5e27ca12dd52e00fff6c3df1d0b006f --- M includes/datavalues/SMW_DV_Property.php M specials/QueryPages/SMW_SpecialUnusedProperties.php 2 files changed, 23 insertions(+), 13 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32206 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a49c1dae5e27ca12dd52e00fff6c3df1d0b006f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Better fix for Bug 39392 - change (mediawiki...SemanticMediaWiki[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Better fix for Bug 39392 .. Better fix for Bug 39392 Changed the behaviour to be as follows: * if linking is enabled (link=all, default), URLs will be made into an explicit link using [ ] in wiki and a in HTML * if linking is disabled or outputformat empty is used (#- or simply #), then URLs will be returned as plain strings in wiki and HTML; in wiki this will mean that the URL will still be linked if MW is configured to link such strings automatically (default) * if the new outputformat nowiki is used (#nowiki), then the URL string will be escaped to prevent MW from making a link of it, so it appears as a plain string in HTML and wiki alike; this changes the string so that it is no longer a valid URL All of this only applies to URL values that can be linked at all (MW knows protocol). URLs that are not linkable in MW are always returned as plain strings in all contexts. Change-Id: If3a91ea6f9fc988e156b64850e428ecbae096228 --- M includes/datavalues/SMW_DV_URI.php 1 file changed, 14 insertions(+), 5 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32555 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3a91ea6f9fc988e156b64850e428ecbae096228 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 41963 - TMH: Call to a member function isLocal() on a no... - change (mediawiki...TimedMediaHandler[master])
Reedy has uploaded a new change for review. Change subject: Bug 41963 - TMH: Call to a member function isLocal() on a non-object .. Bug 41963 - TMH: Call to a member function isLocal() on a non-object Added some profiling calls. Remove unused variables De-globali[sz]e Remove unused method return values Change-Id: I247a0bb1163c0df14ca296990ec95bd16a120784 --- M TimedTextPage.php 1 file changed, 41 insertions(+), 21 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/09/32709/1 -- To view, visit https://gerrit.wikimedia.org/r/32709 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I247a0bb1163c0df14ca296990ec95bd16a120784 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Revert Enable lucene for wikidatawiki - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: Revert Enable lucene for wikidatawiki .. Revert Enable lucene for wikidatawiki This reverts commit 059eefc5d048aa7ea4aee7d10bca61e428484bd5 --- M wmf-config/CommonSettings.php 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32710 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47035c9c0579443a3ad484f67bc6a6d26f87b131 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add a reason for disabling of Lucene for wikidatawiki - change (operations/mediawiki-config[master])
Reedy has uploaded a new change for review. Change subject: Add a reason for disabling of Lucene for wikidatawiki .. Add a reason for disabling of Lucene for wikidatawiki Change-Id: Ia4975d2678bcc0710ea6b37c1207180fa4d1f643 --- M wmf-config/CommonSettings.php 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/11/32711/1 -- To view, visit https://gerrit.wikimedia.org/r/32711 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia4975d2678bcc0710ea6b37c1207180fa4d1f643 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add a reason for disabling of Lucene for wikidatawiki - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: Add a reason for disabling of Lucene for wikidatawiki .. Add a reason for disabling of Lucene for wikidatawiki Change-Id: Ia4975d2678bcc0710ea6b37c1207180fa4d1f643 --- M wmf-config/CommonSettings.php 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32711 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4975d2678bcc0710ea6b37c1207180fa4d1f643 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix a type bug in EntityPerPageTable introduce by the creati... - change (mediawiki...Wikibase[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix a type bug in EntityPerPageTable introduce by the creation of EntityId. .. Fix a type bug in EntityPerPageTable introduce by the creation of EntityId. Change-Id: Id10fab84058867d8caf3d7d6be83f862f60558a2 --- M repo/includes/specials/SpecialWikibaseQueryPage.php M repo/includes/store/sql/EntityPerPageTable.php 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32498 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id10fab84058867d8caf3d7d6be83f862f60558a2 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tpt thoma...@hotmail.fr Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Tpt thoma...@hotmail.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding ESI support detection - change (mediawiki...MobileFrontend[master])
Debarshiban has uploaded a new change for review. Change subject: Adding ESI support detection .. Adding ESI support detection Change-Id: I0f0b954d6c065ae69e583cbe815949d6ab620355 --- M includes/skins/SkinMobile.php M scripts/pre-commit 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/12/32712/1 -- To view, visit https://gerrit.wikimedia.org/r/32712 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0f0b954d6c065ae69e583cbe815949d6ab620355 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Debarshiban debarshi@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Display copying/Copied msg when copying metadata - change (mediawiki...UploadWizard[master])
Nischayn22 has uploaded a new change for review. Change subject: Display copying/Copied msg when copying metadata .. Display copying/Copied msg when copying metadata When the metadata is being copied show the copy message, when done show Copied. After 2 seconds show 'Copy' again. Change-Id: I9410c780663f11a01f23b16da2d6186c1ce19338 --- M UploadWizard.i18n.php M UploadWizardHooks.php M resources/mw.UploadWizardDetails.js 3 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/13/32713/1 -- To view, visit https://gerrit.wikimedia.org/r/32713 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9410c780663f11a01f23b16da2d6186c1ce19338 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Nischayn22 nischay...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Beware that getContent() may return null - change (mediawiki/core[wmf/1.21wmf3])
Reedy has uploaded a new change for review. Change subject: Beware that getContent() may return null .. Beware that getContent() may return null Before the introduction of the content handler, missing content was signified by getText() returning null instead of a string. null will work much like an empty string in most contexts, so in many places, it was not checked explcitely whether the conent was null. Now, when getContent() returns null, this often caused a fatal error, because the code would access whatever getContent() returned as an object, without checking whether it was null (because no such check was performed previously, when the content was represented as a string). This check introduces explicite checks for getContent() returning null in the most essential core classes. Change-Id: I551a90b0b67b8edc7570ca5d252ecc1de903f097 --- M includes/Article.php M includes/Revision.php M includes/Title.php M includes/WikiPage.php M includes/diff/DifferenceEngine.php M includes/job/jobs/DoubleRedirectJob.php M includes/job/jobs/RefreshLinksJob.php M includes/parser/Parser.php M includes/resourceloader/ResourceLoaderWikiModule.php M includes/search/SearchEngine.php 10 files changed, 64 insertions(+), 46 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/14/32714/1 -- To view, visit https://gerrit.wikimedia.org/r/32714 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I551a90b0b67b8edc7570ca5d252ecc1de903f097 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Beware that getContent() may return null - change (mediawiki/core[wmf/1.21wmf3])
Reedy has submitted this change and it was merged. Change subject: Beware that getContent() may return null .. Beware that getContent() may return null Before the introduction of the content handler, missing content was signified by getText() returning null instead of a string. null will work much like an empty string in most contexts, so in many places, it was not checked explcitely whether the conent was null. Now, when getContent() returns null, this often caused a fatal error, because the code would access whatever getContent() returned as an object, without checking whether it was null (because no such check was performed previously, when the content was represented as a string). This check introduces explicite checks for getContent() returning null in the most essential core classes. Change-Id: I551a90b0b67b8edc7570ca5d252ecc1de903f097 --- M includes/Article.php M includes/Revision.php M includes/Title.php M includes/WikiPage.php M includes/diff/DifferenceEngine.php M includes/job/jobs/DoubleRedirectJob.php M includes/job/jobs/RefreshLinksJob.php M includes/parser/Parser.php M includes/resourceloader/ResourceLoaderWikiModule.php M includes/search/SearchEngine.php 10 files changed, 64 insertions(+), 46 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32714 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I551a90b0b67b8edc7570ca5d252ecc1de903f097 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Follow-up I551a90b0 (c2172d4): add one more check for null c... - change (mediawiki/core[master])
IAlex has uploaded a new change for review. Change subject: Follow-up I551a90b0 (c2172d4): add one more check for null content .. Follow-up I551a90b0 (c2172d4): add one more check for null content Change-Id: Ifa26ea8df0c5dd1f4c6ecabb9c8020bb84401ea3 --- M includes/Revision.php 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/15/32715/1 -- To view, visit https://gerrit.wikimedia.org/r/32715 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifa26ea8df0c5dd1f4c6ecabb9c8020bb84401ea3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex ialex.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Follow-up I551a90b0 (c2172d4): add one more check for null c... - change (mediawiki/core[master])
Reedy has submitted this change and it was merged. Change subject: Follow-up I551a90b0 (c2172d4): add one more check for null content .. Follow-up I551a90b0 (c2172d4): add one more check for null content Change-Id: Ifa26ea8df0c5dd1f4c6ecabb9c8020bb84401ea3 --- M includes/Revision.php 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32715 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa26ea8df0c5dd1f4c6ecabb9c8020bb84401ea3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex ialex.w...@gmail.com Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding ESI support - change (mediawiki...MobileFrontend[master])
Debarshiban has uploaded a new change for review. Change subject: Adding ESI support .. Adding ESI support Change-Id: If56235716ac73fd36792091c09864368910800b4 --- M includes/skins/SkinMobile.php 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/16/32716/1 -- To view, visit https://gerrit.wikimedia.org/r/32716 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If56235716ac73fd36792091c09864368910800b4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Debarshiban debarshi@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Grunt: Add task file for jshint. - change (mediawiki/core[master])
Krinkle has uploaded a new change for review. Change subject: Grunt: Add task file for jshint. .. Grunt: Add task file for jshint. Change-Id: I5f73f554ec8d7fd114d10d927a8992c949a493a9 --- M .gitignore A gruntfile.js A package.json 3 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/17/32717/1 -- To view, visit https://gerrit.wikimedia.org/r/32717 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5f73f554ec8d7fd114d10d927a8992c949a493a9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle ttij...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Document 'variant' as a parameter to action=mobileview - change (mediawiki...MobileFrontend[master])
Brion VIBBER has uploaded a new change for review. Change subject: Document 'variant' as a parameter to action=mobileview .. Document 'variant' as a parameter to action=mobileview For bug 38101, bug 32906, etc (variant switching on mobile). Not actually required for the functionality, but makes me happier! Processing of the 'variant' URL parameter is actually handled by LanguageConverter secretly without our knowledge or consent. :P Change-Id: I0e9a4b73a778602c6142aae473a9fd2b87b4e893 --- M includes/api/ApiMobileView.php 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/18/32718/1 -- To view, visit https://gerrit.wikimedia.org/r/32718 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0e9a4b73a778602c6142aae473a9fd2b87b4e893 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Brion VIBBER br...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Follow-up I551a90b0 (c2172d4): add one more check for null c... - change (mediawiki/core[wmf/1.21wmf3])
Reedy has uploaded a new change for review. Change subject: Follow-up I551a90b0 (c2172d4): add one more check for null content .. Follow-up I551a90b0 (c2172d4): add one more check for null content Change-Id: Ifa26ea8df0c5dd1f4c6ecabb9c8020bb84401ea3 --- M includes/Revision.php 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/19/32719/1 -- To view, visit https://gerrit.wikimedia.org/r/32719 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifa26ea8df0c5dd1f4c6ecabb9c8020bb84401ea3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: IAlex ialex.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Follow-up I551a90b0 (c2172d4): add one more check for null c... - change (mediawiki/core[wmf/1.21wmf3])
Reedy has submitted this change and it was merged. Change subject: Follow-up I551a90b0 (c2172d4): add one more check for null content .. Follow-up I551a90b0 (c2172d4): add one more check for null content Change-Id: Ifa26ea8df0c5dd1f4c6ecabb9c8020bb84401ea3 --- M includes/Revision.php 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32719 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa26ea8df0c5dd1f4c6ecabb9c8020bb84401ea3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: IAlex ialex.w...@gmail.com Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Renamed two new constants - change (mediawiki...SemanticMediaWiki[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Renamed two new constants .. Renamed two new constants Change-Id: Ib58dffd8de7b11f4a357ba70f4d4fb099f7798d2 --- M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php 6 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/20/32720/1 -- To view, visit https://gerrit.wikimedia.org/r/32720 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib58dffd8de7b11f4a357ba70f4d4fb099f7798d2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Point php to 1.21wmf3 - change (operations/mediawiki-config[master])
Reedy has uploaded a new change for review. Change subject: Point php to 1.21wmf3 .. Point php to 1.21wmf3 Change-Id: I56e504e4d395495b12693eef7ab55fab401cdd35 --- M php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/21/32721/1 -- To view, visit https://gerrit.wikimedia.org/r/32721 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I56e504e4d395495b12693eef7ab55fab401cdd35 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Point php to 1.21wmf3 - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: Point php to 1.21wmf3 .. Point php to 1.21wmf3 Change-Id: I56e504e4d395495b12693eef7ab55fab401cdd35 --- M php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32721 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56e504e4d395495b12693eef7ab55fab401cdd35 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 41352) Proper fix for vanishing content. - change (mediawiki/core[master])
Reedy has submitted this change and it was merged. Change subject: (Bug 41352) Proper fix for vanishing content. .. (Bug 41352) Proper fix for vanishing content. This reverts the temporary fix in I4c2055be and instead fixes the resolution of merge conflicts using Contenthandler::merge3. Change-Id: I0b1db6d76c0678d0ce795720e513e16e28e907d4 --- M includes/EditPage.php 1 file changed, 7 insertions(+), 31 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/29981 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b1db6d76c0678d0ce795720e513e16e28e907d4 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Demon ch...@wikimedia.org Gerrit-Reviewer: Hashar has...@free.fr Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: TheDJ hartman.w...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use voy for wikivoyage NOT y - change (mediawiki...WikimediaMaintenance[master])
Reedy has uploaded a new change for review. Change subject: Use voy for wikivoyage NOT y .. Use voy for wikivoyage NOT y Change-Id: Id7b05c62dc6b53d31b9552b82d00648bef63b18d --- M rebuildInterwiki.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMaintenance refs/changes/23/32723/1 -- To view, visit https://gerrit.wikimedia.org/r/32723 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id7b05c62dc6b53d31b9552b82d00648bef63b18d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikimediaMaintenance Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed a bunch of field names, improved docs and removed publ... - change (mediawiki...SemanticMediaWiki[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Fixed a bunch of field names, improved docs and removed public write access to fields .. Fixed a bunch of field names, improved docs and removed public write access to fields Change-Id: I1b2b6617de74521e0d996faca9379c3c1444cb46 --- M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3Table.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php 7 files changed, 195 insertions(+), 105 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/24/32724/1 -- To view, visit https://gerrit.wikimedia.org/r/32724 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1b2b6617de74521e0d996faca9379c3c1444cb46 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use voy for wikivoyage NOT y - change (mediawiki...WikimediaMaintenance[master])
Reedy has submitted this change and it was merged. Change subject: Use voy for wikivoyage NOT y .. Use voy for wikivoyage NOT y Change-Id: Id7b05c62dc6b53d31b9552b82d00648bef63b18d --- M rebuildInterwiki.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32723 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7b05c62dc6b53d31b9552b82d00648bef63b18d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikimediaMaintenance Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update WikimediaMaintenance to master - change (mediawiki/core[wmf/1.21wmf3])
Reedy has uploaded a new change for review. Change subject: Update WikimediaMaintenance to master .. Update WikimediaMaintenance to master Change-Id: I73ef374fa14c031da658516de009fb6cb3408b22 --- M extensions/WikimediaMaintenance 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/25/32725/1 -- To view, visit https://gerrit.wikimedia.org/r/32725 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I73ef374fa14c031da658516de009fb6cb3408b22 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update WikimediaMaintenance to master - change (mediawiki/core[wmf/1.21wmf3])
Reedy has submitted this change and it was merged. Change subject: Update WikimediaMaintenance to master .. Update WikimediaMaintenance to master Change-Id: I73ef374fa14c031da658516de009fb6cb3408b22 --- M extensions/WikimediaMaintenance 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32725 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73ef374fa14c031da658516de009fb6cb3408b22 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Merge branch 'master' into 1.9.x - change (mediawiki...SemanticMediaWiki[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Merge branch 'master' into 1.9.x .. Merge branch 'master' into 1.9.x Change-Id: If2bcc593f13ca2c153ff888a43d63edb3fe0e317 --- 0 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/26/32726/1 -- To view, visit https://gerrit.wikimedia.org/r/32726 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2bcc593f13ca2c153ff888a43d63edb3fe0e317 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Merge branch 'master' into 1.9.x - change (mediawiki...SemanticMediaWiki[1.9.x])
Jeroen De Dauw has uploaded a new change for review. Change subject: Merge branch 'master' into 1.9.x .. Merge branch 'master' into 1.9.x Change-Id: If2bcc593f13ca2c153ff888a43d63edb3fe1e318 --- 0 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/27/32727/1 -- To view, visit https://gerrit.wikimedia.org/r/32727 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2bcc593f13ca2c153ff888a43d63edb3fe1e318 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: 1.9.x Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Merge branch 'master' into 1.9.x - change (mediawiki...SemanticMediaWiki[1.9.x])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Merge branch 'master' into 1.9.x .. Merge branch 'master' into 1.9.x Change-Id: If2bcc593f13ca2c153ff888a43d63edb3fe1e318 --- 0 files changed, 0 insertions(+), 0 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32727 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2bcc593f13ca2c153ff888a43d63edb3fe1e318 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: 1.9.x Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] updates gruntjs v0.3.17 - devel (3eff3f8) - change (integration/jenkins[master])
Hashar has uploaded a new change for review. Change subject: updates gruntjs v0.3.17 - devel (3eff3f8) .. updates gruntjs v0.3.17 - devel (3eff3f8) Change-Id: Id26b5e946474377dfdc0d54a37e26d85dd1a1493 --- M tools/gruntjs 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins refs/changes/28/32728/1 -- To view, visit https://gerrit.wikimedia.org/r/32728 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id26b5e946474377dfdc0d54a37e26d85dd1a1493 Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] updates gruntjs v0.3.17 - devel (3eff3f8) - change (integration/jenkins[master])
Krinkle has submitted this change and it was merged. Change subject: updates gruntjs v0.3.17 - devel (3eff3f8) .. updates gruntjs v0.3.17 - devel (3eff3f8) Change-Id: Id26b5e946474377dfdc0d54a37e26d85dd1a1493 --- M tools/gruntjs 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Krinkle: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32728 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id26b5e946474377dfdc0d54a37e26d85dd1a1493 Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr Gerrit-Reviewer: Krinkle ttij...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Explicitly define member variables - change (mediawiki/core[master])
Reedy has uploaded a new change for review. Change subject: Explicitly define member variables .. Explicitly define member variables Change-Id: Ib2b8dfb84570557f1aeab474f4939e3a657c5732 --- M includes/specials/SpecialChangePassword.php 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/29/32729/1 -- To view, visit https://gerrit.wikimedia.org/r/32729 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2b8dfb84570557f1aeab474f4939e3a657c5732 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 41244) Gracefully handle failure to load text blob. - change (mediawiki/core[master])
Reedy has submitted this change and it was merged. Change subject: (Bug 41244) Gracefully handle failure to load text blob. .. (Bug 41244) Gracefully handle failure to load text blob. This change fixes fatal errors ocurring when Revision::loadText returns false because of a failure to load the text blob. Revision::getContent() should simply return null in such a case. Change-Id: I1e13de14ff15b124b5a2e07155d368595a16fda7 --- M includes/Revision.php M tests/phpunit/includes/RevisionStorageTest.php 2 files changed, 38 insertions(+), 10 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30624 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e13de14ff15b124b5a2e07155d368595a16fda7 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Demon ch...@wikimedia.org Gerrit-Reviewer: IAlex ialex.w...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Liangent liang...@gmail.com Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix case of E_STRICT violation in ForeignAPIRepo - change (mediawiki/core[master])
TheDJ has uploaded a new change for review. Change subject: Fix case of E_STRICT violation in ForeignAPIRepo .. Fix case of E_STRICT violation in ForeignAPIRepo This is a follow up to Ib6473773 Change-Id: I0cd62ffdbc5367edcc1913c883ffaac5846eda3f --- M includes/filerepo/ForeignAPIRepo.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/30/32730/1 -- To view, visit https://gerrit.wikimedia.org/r/32730 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0cd62ffdbc5367edcc1913c883ffaac5846eda3f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: TheDJ hartman.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] * (bug 41966) Follow-up I551a90b0 (c2172d4): fix fatal error... - change (mediawiki/core[master])
IAlex has uploaded a new change for review. Change subject: * (bug 41966) Follow-up I551a90b0 (c2172d4): fix fatal error in PoolWorkArticleView::doWork() .. * (bug 41966) Follow-up I551a90b0 (c2172d4): fix fatal error in PoolWorkArticleView::doWork() The error is Fatal error: Call to a member function getParserOutput() on a non-object in includes/WikiPage.php on line 3363. The problem is that if the fifth parameter passed to PoolWorkArticleView::__construct() is not given or is null, which is now the case since the change mentioned on the first line of this commit summary, the content is fetched from Page::getContent(). When the Page object is a WikiPage instance there is no problem, but when this is an Article instance, Article::getContent() actually returns the content as *string* and not as object, like it did before the Wikidata branch merge. Worked arround this by passing the WikiPage object to PoolWorkArticleView from Article::view(). Also removed non-existing sixth parameter to PoolWorkArticleView::__construct(). Change-Id: I537862f519542de4f034be29bba4b75898382f59 --- M includes/Article.php 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/31/32731/1 -- To view, visit https://gerrit.wikimedia.org/r/32731 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I537862f519542de4f034be29bba4b75898382f59 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex ialex.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] * (bug 41966) Follow-up I551a90b0 (c2172d4): fix fatal error... - change (mediawiki/core[master])
Reedy has submitted this change and it was merged. Change subject: * (bug 41966) Follow-up I551a90b0 (c2172d4): fix fatal error in PoolWorkArticleView::doWork() .. * (bug 41966) Follow-up I551a90b0 (c2172d4): fix fatal error in PoolWorkArticleView::doWork() The error is Fatal error: Call to a member function getParserOutput() on a non-object in includes/WikiPage.php on line 3363. The problem is that if the fifth parameter passed to PoolWorkArticleView::__construct() is not given or is null, which is now the case since the change mentioned on the first line of this commit summary, the content is fetched from Page::getContent(). When the Page object is a WikiPage instance there is no problem, but when this is an Article instance, Article::getContent() actually returns the content as *string* and not as object, like it did before the Wikidata branch merge. Worked arround this by passing the WikiPage object to PoolWorkArticleView from Article::view(). Also removed non-existing sixth parameter to PoolWorkArticleView::__construct(). Change-Id: I537862f519542de4f034be29bba4b75898382f59 --- M includes/Article.php 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32731 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I537862f519542de4f034be29bba4b75898382f59 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex ialex.w...@gmail.com Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] * (bug 41966) Follow-up I551a90b0 (c2172d4): fix fatal error... - change (mediawiki/core[wmf/1.21wmf3])
Reedy has submitted this change and it was merged. Change subject: * (bug 41966) Follow-up I551a90b0 (c2172d4): fix fatal error in PoolWorkArticleView::doWork() .. * (bug 41966) Follow-up I551a90b0 (c2172d4): fix fatal error in PoolWorkArticleView::doWork() The error is Fatal error: Call to a member function getParserOutput() on a non-object in includes/WikiPage.php on line 3363. The problem is that if the fifth parameter passed to PoolWorkArticleView::__construct() is not given or is null, which is now the case since the change mentioned on the first line of this commit summary, the content is fetched from Page::getContent(). When the Page object is a WikiPage instance there is no problem, but when this is an Article instance, Article::getContent() actually returns the content as *string* and not as object, like it did before the Wikidata branch merge. Worked arround this by passing the WikiPage object to PoolWorkArticleView from Article::view(). Also removed non-existing sixth parameter to PoolWorkArticleView::__construct(). Change-Id: I537862f519542de4f034be29bba4b75898382f59 --- M includes/Article.php 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32732 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I537862f519542de4f034be29bba4b75898382f59 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: IAlex ialex.w...@gmail.com Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] initial commit - change (integration/grunt-contrib-wikimedia[master])
Hashar has submitted this change and it was merged. Change subject: initial commit .. initial commit --- A .gitignore A .gitreview A .jshintignore A node_modules/.bin/jshint A node_modules/jshint/LICENSE A node_modules/jshint/README.md A node_modules/jshint/bin/hint A node_modules/jshint/lib/cli.js A node_modules/jshint/lib/hint.js A node_modules/jshint/lib/reporters/checkstyle.js A node_modules/jshint/lib/reporters/default.js A node_modules/jshint/lib/reporters/jslint_xml.js A node_modules/jshint/lib/reporters/non_error.js A node_modules/jshint/node_modules/cli/README.md A node_modules/jshint/node_modules/cli/cli.js A node_modules/jshint/node_modules/cli/examples/cat.js A node_modules/jshint/node_modules/cli/examples/command.js A node_modules/jshint/node_modules/cli/examples/echo.js A node_modules/jshint/node_modules/cli/examples/glob.js A node_modules/jshint/node_modules/cli/examples/long_desc.js A node_modules/jshint/node_modules/cli/examples/progress.js A node_modules/jshint/node_modules/cli/examples/sort.js A node_modules/jshint/node_modules/cli/examples/spinner.js A node_modules/jshint/node_modules/cli/examples/static.coffee A node_modules/jshint/node_modules/cli/examples/static.js A node_modules/jshint/node_modules/cli/index.js A node_modules/jshint/node_modules/cli/node_modules/glob/.npmignore A node_modules/jshint/node_modules/cli/node_modules/glob/.travis.yml A node_modules/jshint/node_modules/cli/node_modules/glob/LICENSE A node_modules/jshint/node_modules/cli/node_modules/glob/README.md A node_modules/jshint/node_modules/cli/node_modules/glob/examples/g.js A node_modules/jshint/node_modules/cli/node_modules/glob/examples/usr-local.js A node_modules/jshint/node_modules/cli/node_modules/glob/glob.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/graceful-fs/.npmignore A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/graceful-fs/LICENSE A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/graceful-fs/README.md A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/graceful-fs/graceful-fs.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/graceful-fs/package.json A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/graceful-fs/test/open.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/inherits/README.md A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/inherits/inherits.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/inherits/package.json A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/.travis.yml A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/LICENSE A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/README.md A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/minimatch.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/lru-cache/.npmignore A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/lru-cache/AUTHORS A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/lru-cache/LICENSE A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/lru-cache/README.md A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/lru-cache/lib/lru-cache.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/lru-cache/package.json A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/lru-cache/test/basic.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/sigmund/LICENSE A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/sigmund/README.md A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/sigmund/bench.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/sigmund/package.json A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/sigmund/sigmund.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/node_modules/sigmund/test/basic.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/package.json A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/test/basic.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/test/brace-expand.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/test/caching.js A node_modules/jshint/node_modules/cli/node_modules/glob/node_modules/minimatch/test/defaults.js A
[MediaWiki-commits] [Gerrit] Disable MobileFrontend on wikidatawikis and wikivyoage due t... - change (operations/mediawiki-config[master])
Reedy has uploaded a new change for review. Change subject: Disable MobileFrontend on wikidatawikis and wikivyoage due to lack of domain setup .. Disable MobileFrontend on wikidatawikis and wikivyoage due to lack of domain setup Change-Id: I6b56f3c863dd2533eb6598c8da0aec7aaad283b2 --- M wmf-config/InitialiseSettings.php 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/34/32734/1 -- To view, visit https://gerrit.wikimedia.org/r/32734 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6b56f3c863dd2533eb6598c8da0aec7aaad283b2 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Disable MobileFrontend on wikidatawikis and wikivyoage due t... - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: Disable MobileFrontend on wikidatawikis and wikivyoage due to lack of domain setup .. Disable MobileFrontend on wikidatawikis and wikivyoage due to lack of domain setup Change-Id: I6b56f3c863dd2533eb6598c8da0aec7aaad283b2 --- M wmf-config/InitialiseSettings.php 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32734 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b56f3c863dd2533eb6598c8da0aec7aaad283b2 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Explicitly define member variables - change (mediawiki/core[master])
IAlex has submitted this change and it was merged. Change subject: Explicitly define member variables .. Explicitly define member variables Change-Id: Ib2b8dfb84570557f1aeab474f4939e3a657c5732 --- M includes/specials/SpecialChangePassword.php 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32729 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2b8dfb84570557f1aeab474f4939e3a657c5732 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: IAlex ialex.w...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Follow-up Ib2b8dfb8 (803abc7): fix a typo in a variable name - change (mediawiki/core[master])
IAlex has uploaded a new change for review. Change subject: Follow-up Ib2b8dfb8 (803abc7): fix a typo in a variable name .. Follow-up Ib2b8dfb8 (803abc7): fix a typo in a variable name $mRetypePass should exist, the correct name is $mRetype. Change-Id: I0bd65951f42a244a8810087f900b4a3c82358405 --- M includes/specials/SpecialChangePassword.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/35/32735/1 -- To view, visit https://gerrit.wikimedia.org/r/32735 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0bd65951f42a244a8810087f900b4a3c82358405 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex ialex.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added ClaimsSerializer and did a lot of cleanup, mainly reve... - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Added ClaimsSerializer and did a lot of cleanup, mainly reverting most of 5c29e13798dd31cd233ffbd2d28ca6854177bb8b .. Added ClaimsSerializer and did a lot of cleanup, mainly reverting most of 5c29e13798dd31cd233ffbd2d28ca6854177bb8b Change-Id: I03568da54414c828f3932376f6243f2edcc6db9c --- M repo/Wikibase.hooks.php M repo/Wikibase.php M repo/includes/api/serializers/ByPropertyListSerializer.php M repo/includes/api/serializers/ClaimSerializer.php A repo/includes/api/serializers/ClaimsSerializer.php M repo/includes/api/serializers/EntitySerializer.php M repo/includes/api/serializers/ItemSerializer.php M repo/tests/phpunit/includes/api/ApiGetEntitiesTest.php M repo/tests/phpunit/includes/api/serializers/ByPropertyListSerializerTest.php M repo/tests/phpunit/includes/api/serializers/ClaimSerializerTest.php A repo/tests/phpunit/includes/api/serializers/ClaimsSerializerTest.php M repo/tests/phpunit/includes/api/serializers/ItemSerializerTest.php 12 files changed, 174 insertions(+), 124 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/36/32736/1 -- To view, visit https://gerrit.wikimedia.org/r/32736 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I03568da54414c828f3932376f6243f2edcc6db9c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove unneeded third param - change (mediawiki/core[master])
Umherirrender has uploaded a new change for review. Change subject: Remove unneeded third param .. Remove unneeded third param the 'messages' are already part of 'preload', so there is no need for that. Last changes there: r101507/r102304 Change-Id: I6c9daa3c46bd7f1db851cc4620ecf59f81e6f9aa --- M includes/LocalisationCache.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/37/32737/1 -- To view, visit https://gerrit.wikimedia.org/r/32737 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6c9daa3c46bd7f1db851cc4620ecf59f81e6f9aa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender umherirrender_de...@web.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 41963 - TMH: Call to a member function isLocal() on a no... - change (mediawiki...TimedMediaHandler[master])
Mdale has submitted this change and it was merged. Change subject: Bug 41963 - TMH: Call to a member function isLocal() on a non-object .. Bug 41963 - TMH: Call to a member function isLocal() on a non-object Added some profiling calls. Remove unused variables De-globali[sz]e Remove unused method return values Change-Id: I247a0bb1163c0df14ca296990ec95bd16a120784 --- M TimedTextPage.php 1 file changed, 41 insertions(+), 21 deletions(-) Approvals: Mdale: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32709 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I247a0bb1163c0df14ca296990ec95bd16a120784 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: J jger...@wikimedia.org Gerrit-Reviewer: Mdale md...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] avoid STDERR diff3 messages when using wfMerge() - change (mediawiki/core[master])
Hashar has uploaded a new change for review. Change subject: avoid STDERR diff3 messages when using wfMerge() .. avoid STDERR diff3 messages when using wfMerge() diff3 issues a warning to stderr if any of the files does not end with a newline character. TextContent::preSaveTransform() does normalize revision text by simply calling trim(). Thus to avoid a diff3 error we simply apply the same normalization and add a newline to please the command. Change-Id: I7baa3df95dd70cbc865b2491ccc791e60f8b9e6e --- M includes/GlobalFunctions.php 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/38/32738/1 -- To view, visit https://gerrit.wikimedia.org/r/32738 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7baa3df95dd70cbc865b2491ccc791e60f8b9e6e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41841) Add wikidata and wikivoyage to wgNoFollowDomainE... - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: (bug 41841) Add wikidata and wikivoyage to wgNoFollowDomainExceptions .. (bug 41841) Add wikidata and wikivoyage to wgNoFollowDomainExceptions Also fix indentation Change-Id: If5b4e1e1ec37a643e426874116c75ec5413782e1 --- M wmf-config/InitialiseSettings.php 1 file changed, 13 insertions(+), 11 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved Hydriz: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32226 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5b4e1e1ec37a643e426874116c75ec5413782e1 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Alex Monk kren...@gmail.com Gerrit-Reviewer: Hydriz ad...@alphacorp.tk Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add wikivoyage to missing.php for future redirects to incuba... - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: Add wikivoyage to missing.php for future redirects to incubator .. Add wikivoyage to missing.php for future redirects to incubator Change-Id: Ibef9f4c8a864783c7d053d9c2a6a6679030d6d63 --- M wmf-config/missing.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved Hydriz: Looks good to me, but someone else must approve MF-Warburg: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32258 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibef9f4c8a864783c7d053d9c2a6a6679030d6d63 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: SPQRobin robinp.1...@gmail.com Gerrit-Reviewer: Hydriz ad...@alphacorp.tk Gerrit-Reviewer: MF-Warburg mfwarb...@googlemail.com Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add redirect for wikivoyage.de to .org - change (operations/apache-config[master])
Dzahn has submitted this change and it was merged. Change subject: add redirect for wikivoyage.de to .org .. add redirect for wikivoyage.de to .org Change-Id: I072af39e015f8b85c4da4903ad7052c5e022a607 --- M redirects.conf 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Dzahn: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32680 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072af39e015f8b85c4da4903ad7052c5e022a607 Gerrit-PatchSet: 1 Gerrit-Project: operations/apache-config Gerrit-Branch: master Gerrit-Owner: Dzahn dz...@wikimedia.org Gerrit-Reviewer: CSteipp cste...@wikimedia.org Gerrit-Reviewer: Dzahn dz...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add SUL login configuration for Wikivoyage - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: Add SUL login configuration for Wikivoyage .. Add SUL login configuration for Wikivoyage Change-Id: I9f2f10ae50fe321dacc8b37cf3de4d18abffae5b --- A images/sul/wikivoyage.png M wmf-config/CommonSettings.php M wmf-config/InitialiseSettings.php 3 files changed, 2 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/31998 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f2f10ae50fe321dacc8b37cf3de4d18abffae5b Gerrit-PatchSet: 3 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: CSteipp cste...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] drop orm_test table on teardown - change (mediawiki/core[master])
Umherirrender has uploaded a new change for review. Change subject: drop orm_test table on teardown .. drop orm_test table on teardown No need to keep this table after the test Change-Id: Id6814ceca063294da0761caa9a0d9975118dd4f1 --- M tests/phpunit/includes/db/TestORMRowTest.php 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/39/32739/1 -- To view, visit https://gerrit.wikimedia.org/r/32739 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id6814ceca063294da0761caa9a0d9975118dd4f1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender umherirrender_de...@web.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 41352) Provide tests for edit conflicts. - change (mediawiki/core[master])
Hashar has submitted this change and it was merged. Change subject: (Bug 41352) Provide tests for edit conflicts. .. (Bug 41352) Provide tests for edit conflicts. This provides several test cases for EditPage, including some for detecting and resolving edit conflicts. This is in preparation for finding and eliminating the root cause of bug 41352. Change-Id: I8f23c6535f7b3ee6462d9c5a19dd06070e77f9d1 --- M tests/phpunit/includes/EditPageTest.php 1 file changed, 390 insertions(+), 1 deletion(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/29973 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f23c6535f7b3ee6462d9c5a19dd06070e77f9d1 Gerrit-PatchSet: 8 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Hashar has...@free.fr Gerrit-Reviewer: Platonides platoni...@gmail.com Gerrit-Reviewer: TheDJ hartman.w...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Kill wikidata docroot - change (operations/mediawiki-config[master])
Reedy has uploaded a new change for review. Change subject: Kill wikidata docroot .. Kill wikidata docroot Change-Id: Iea7c053d6c497b21aba1ed614e4cef54b9b83806 --- D docroot/wikidata/404.html D docroot/wikidata/503.html D docroot/wikidata/favicon.ico D docroot/wikidata/images D docroot/wikidata/robots.txt D docroot/wikidata/w 6 files changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/41/32741/1 -- To view, visit https://gerrit.wikimedia.org/r/32741 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iea7c053d6c497b21aba1ed614e4cef54b9b83806 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Kill wikidata docroot - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: Kill wikidata docroot .. Kill wikidata docroot Change-Id: Iea7c053d6c497b21aba1ed614e4cef54b9b83806 --- D docroot/wikidata/404.html D docroot/wikidata/503.html D docroot/wikidata/favicon.ico D docroot/wikidata/images D docroot/wikidata/robots.txt D docroot/wikidata/w 6 files changed, 0 insertions(+), 6 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32741 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea7c053d6c497b21aba1ed614e4cef54b9b83806 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add config for www.wikivoyage.org portal - change (operations/apache-config[master])
Reedy has uploaded a new change for review. Change subject: Add config for www.wikivoyage.org portal .. Add config for www.wikivoyage.org portal Change-Id: Ifb4eb67e969f582887e606ff177746ce3e5a998e --- M www.wikipedia.conf 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/apache-config refs/changes/42/32742/1 -- To view, visit https://gerrit.wikimedia.org/r/32742 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb4eb67e969f582887e606ff177746ce3e5a998e Gerrit-PatchSet: 1 Gerrit-Project: operations/apache-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Renamed two new constants - change (mediawiki...SemanticMediaWiki[master])
Foxtrott has submitted this change and it was merged. Change subject: Renamed two new constants .. Renamed two new constants Change-Id: Ib58dffd8de7b11f4a357ba70f4d4fb099f7798d2 --- M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php 6 files changed, 20 insertions(+), 20 deletions(-) Approvals: Foxtrott: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32720 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib58dffd8de7b11f4a357ba70f4d4fb099f7798d2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add www.wikivoyage.org docroot - change (operations/mediawiki-config[master])
Reedy has uploaded a new change for review. Change subject: Add www.wikivoyage.org docroot .. Add www.wikivoyage.org docroot Change-Id: Iefcf1cfae4ffe35aba14be99e5c07eef9fcaa249 --- A docroot/www.wikivoyage.org/favicon.ico A docroot/www.wikivoyage.org/w/extract2.php A docroot/www.wikivoyage.org/w/search-redirect.php 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/43/32743/1 -- To view, visit https://gerrit.wikimedia.org/r/32743 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iefcf1cfae4ffe35aba14be99e5c07eef9fcaa249 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] main.conf - turn wikivoyage ServerAlias into * again vs. sin... - change (operations/apache-config[master])
Dzahn has uploaded a new change for review. Change subject: main.conf - turn wikivoyage ServerAlias into * again vs. single languages .. main.conf - turn wikivoyage ServerAlias into * again vs. single languages Change-Id: I92cab01821bece1f2341a517af47443adcbdd1a7 --- M main.conf 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/apache-config refs/changes/44/32744/1 -- To view, visit https://gerrit.wikimedia.org/r/32744 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I92cab01821bece1f2341a517af47443adcbdd1a7 Gerrit-PatchSet: 1 Gerrit-Project: operations/apache-config Gerrit-Branch: master Gerrit-Owner: Dzahn dz...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed a bunch of field names, improved docs and removed publ... - change (mediawiki...SemanticMediaWiki[master])
Foxtrott has submitted this change and it was merged. Change subject: Fixed a bunch of field names, improved docs and removed public write access to fields .. Fixed a bunch of field names, improved docs and removed public write access to fields Change-Id: I1b2b6617de74521e0d996faca9379c3c1444cb46 --- M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3Table.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php 7 files changed, 195 insertions(+), 105 deletions(-) Approvals: Foxtrott: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32724 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b2b6617de74521e0d996faca9379c3c1444cb46 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add www.wikivoyage.org docroot - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: Add www.wikivoyage.org docroot .. Add www.wikivoyage.org docroot Change-Id: Iefcf1cfae4ffe35aba14be99e5c07eef9fcaa249 --- A docroot/www.wikivoyage.org/favicon.ico A docroot/www.wikivoyage.org/w/extract2.php A docroot/www.wikivoyage.org/w/search-redirect.php 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/32743 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefcf1cfae4ffe35aba14be99e5c07eef9fcaa249 Gerrit-PatchSet: 2 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy re...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] main.conf - turn wikivoyage ServerAlias into * again vs. sin... - change (operations/apache-config[master])
Dzahn has submitted this change and it was merged. Change subject: main.conf - turn wikivoyage ServerAlias into * again vs. single languages .. main.conf - turn wikivoyage ServerAlias into * again vs. single languages Change-Id: I92cab01821bece1f2341a517af47443adcbdd1a7 --- M main.conf 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Reedy: Looks good to me, but someone else must approve Dzahn: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32744 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92cab01821bece1f2341a517af47443adcbdd1a7 Gerrit-PatchSet: 1 Gerrit-Project: operations/apache-config Gerrit-Branch: master Gerrit-Owner: Dzahn dz...@wikimedia.org Gerrit-Reviewer: Dzahn dz...@wikimedia.org Gerrit-Reviewer: Reedy re...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
