[MediaWiki-commits] [Gerrit] Fatal error: Call to a member function makeLinkObj() on a n... - change (mediawiki...ReaderFeedback[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Fatal error:  Call to a member function makeLinkObj() on a 
non-object in 
/usr/local/apache/common-local/php-1.21wmf3/extensions/ReaderFeedback/specialpages/RatingHistory_body.php
 on line 655
..

Fatal error:  Call to a member function makeLinkObj() on a non-object in 
/usr/local/apache/common-local/php-1.21wmf3/extensions/ReaderFeedback/specialpages/RatingHistory_body.php
 on line 655

Change-Id: I54d6659711f1e53393e6dd71a4f1727e4bea6a2d
---
M specialpages/RatingHistory_body.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ReaderFeedback 
refs/changes/55/33055/1
--
To view, visit https://gerrit.wikimedia.org/r/33055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54d6659711f1e53393e6dd71a4f1727e4bea6a2d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReaderFeedback
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Cleanup of wikibase.utilities.jQuery.ui.js - change (mediawiki...Wikibase[master])

2012-11-12 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

Change subject: Cleanup of wikibase.utilities.jQuery.ui.js
..

Cleanup of wikibase.utilities.jQuery.ui.js

Change set removes call to deprecated jQuery.browser.

Change-Id: I3e34b580bc1aa9b5fb483722fd05aec5faeadffb
---
M lib/resources/wikibase.utilities/wikibase.utilities.jQuery.ui.js
1 file changed, 22 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/56/33056/1
--
To view, visit https://gerrit.wikimedia.org/r/33056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e34b580bc1aa9b5fb483722fd05aec5faeadffb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Auto-expand test refactoring - change (mediawiki...Wikibase[master])

2012-11-12 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

Change subject: Auto-expand test refactoring
..

Auto-expand test refactoring

Change-Id: I7decc30a6dbe6edd106e7d30691f06e1e2b9bec8
---
M 
lib/tests/qunit/wikibase.utilities/wikibase.utilities.jQuery.ui.inputAutoExpand.tests.js
1 file changed, 57 insertions(+), 59 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/57/33057/1
--
To view, visit https://gerrit.wikimedia.org/r/33057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7decc30a6dbe6edd106e7d30691f06e1e2b9bec8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] There is no need to use an expanded URL for this downloadlin... - change (mediawiki...Collection[master])

2012-11-12 Thread schmir (Code Review)
schmir has submitted this change and it was merged.

Change subject: There is no need to use an expanded URL for this downloadlink.
..


There is no need to use an expanded URL for this downloadlink.

Change-Id: I069c5f42a14b230dacec54e3598d7ca346bcbe99
---
M Collection.body.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  schmir: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/31066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I069c5f42a14b230dacec54e3598d7ca346bcbe99
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: TheDJ 
Gerrit-Reviewer: schmir 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Enable CombineUserTalk for enwiki - change (operations/mediawiki-config[master])

2012-11-12 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review.

Change subject: Enable CombineUserTalk for enwiki
..

Enable CombineUserTalk for enwiki

Change-Id: Iee4212fc77a0af3521ef597d3969be27325c095b
---
M wmf-config/InitialiseSettings.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/58/33058/1
--
To view, visit https://gerrit.wikimedia.org/r/33058
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee4212fc77a0af3521ef597d3969be27325c095b
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] swift: include Ubuntu Cloud archive for folsom - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: swift: include Ubuntu Cloud archive for folsom
..

swift: include Ubuntu Cloud archive for folsom

Ubuntu provides the Ubuntu Cloud Archive with a long-term supported
release of Openstack, under the same terms of a Ubuntu stable release.

Hence, instead of adding packages to our repository, use the ones
provided by Ubuntu directly, for Swift 1.7 onwards.

https://wiki.ubuntu.com/ServerTeam/CloudArchive

Change-Id: I3992a97deb98dd42515c8cfb2ca497055d000ae8
---
A files/misc/ubuntu-cloud.key
M manifests/swift.pp
2 files changed, 73 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/59/33059/1
--
To view, visit https://gerrit.wikimedia.org/r/33059
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3992a97deb98dd42515c8cfb2ca497055d000ae8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Enable CombineUserTalk for enwiki - change (operations/mediawiki-config[master])

2012-11-12 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: Enable CombineUserTalk for enwiki
..


Enable CombineUserTalk for enwiki

Change-Id: Iee4212fc77a0af3521ef597d3969be27325c095b
---
M wmf-config/InitialiseSettings.php
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33058
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee4212fc77a0af3521ef597d3969be27325c095b
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add wikivoyage to site group map - change (mediawiki...Wikibase[master])

2012-11-12 Thread Aude (Code Review)
Aude has uploaded a new change for review.

Change subject: add wikivoyage to site group map
..

add wikivoyage to site group map

Change-Id: Iafed9e46c22f9f5121fedc05a2fee82a518f70fd
---
M lib/includes/Utils.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/60/33060/1
--
To view, visit https://gerrit.wikimedia.org/r/33060
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafed9e46c22f9f5121fedc05a2fee82a518f70fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Revert "There is no need to use an expanded URL for this dow... - change (mediawiki...Collection[master])

2012-11-12 Thread schmir (Code Review)
schmir has submitted this change and it was merged.

Change subject: Revert "There is no need to use an expanded URL for this 
downloadlink."
..


Revert "There is no need to use an expanded URL for this downloadlink."

This reverts commit 01362f9688b4b145e862529fbaf2e82fc2ab6cba
---
M Collection.body.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  schmir: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33061
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I918a85c690d2b21289761a817fb2b94e2c77e0e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: schmir 
Gerrit-Reviewer: schmir 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] swift: include Ubuntu Cloud archive for folsom - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: swift: include Ubuntu Cloud archive for folsom
..


swift: include Ubuntu Cloud archive for folsom

Ubuntu provides the Ubuntu Cloud Archive with a long-term supported
release of Openstack, under the same terms of a Ubuntu stable release.

Hence, instead of adding packages to our repository, use the ones
provided by Ubuntu directly, for Swift 1.7 onwards.

https://wiki.ubuntu.com/ServerTeam/CloudArchive

Change-Id: I3992a97deb98dd42515c8cfb2ca497055d000ae8
---
A files/misc/ubuntu-cloud.key
M manifests/swift.pp
2 files changed, 73 insertions(+), 2 deletions(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33059
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3992a97deb98dd42515c8cfb2ca497055d000ae8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove spurious notify, doesn't work across stages - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: Remove spurious notify, doesn't work across stages
..

Remove spurious notify, doesn't work across stages

Change-Id: I4de2c34516b9192592b08c0296247545bd53c7d6
---
M manifests/swift.pp
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/62/33062/1
--
To view, visit https://gerrit.wikimedia.org/r/33062
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4de2c34516b9192592b08c0296247545bd53c7d6
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove spurious notify, doesn't work across stages - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: Remove spurious notify, doesn't work across stages
..


Remove spurious notify, doesn't work across stages

Change-Id: I4de2c34516b9192592b08c0296247545bd53c7d6
---
M manifests/swift.pp
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33062
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4de2c34516b9192592b08c0296247545bd53c7d6
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] more selenium security tests - change (mediawiki...Wikibase[master])

2012-11-12 Thread Henning Snater (Code Review)
Henning Snater has submitted this change and it was merged.

Change subject: more selenium security tests
..


more selenium security tests

- added checks for JS injection for property aliases

Change-Id: If79ae562c6fd595f4f45cb4dcaf2ae828326dd04
---
M repo/tests/selenium/item/security_spec.rb
1 file changed, 19 insertions(+), 5 deletions(-)

Approvals:
  Henning Snater: Verified; Looks good to me, approved
  Jeroen De Dauw: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/32567
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If79ae562c6fd595f4f45cb4dcaf2ae828326dd04
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher 
Gerrit-Reviewer: Henning Snater 
Gerrit-Reviewer: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Repurpose ms[1-3] - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: Repurpose ms[1-3]
..

Repurpose ms[1-3]

Remove swift from ms[1-3]; repurposing to a test cluster, no puppet
manifests for now.

Change-Id: I5c67fa7cbad4e42cf3fa8b57b7ecaa10f744e46d
---
M manifests/site.pp
1 file changed, 1 insertion(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/63/33063/1
--
To view, visit https://gerrit.wikimedia.org/r/33063
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c67fa7cbad4e42cf3fa8b57b7ecaa10f744e46d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix problems with saving properties, concepts, etc - change (mediawiki...SemanticWatchlist[master])

2012-11-12 Thread Nischayn22 (Code Review)
Nischayn22 has uploaded a new change for review.

Change subject: Fix problems with saving properties, concepts, etc
..

Fix problems with saving properties, concepts, etc

Reworked code for saving properties/concepts/categories which wasn't
working before.
Removed usage of msg 'swl-group-save'

Change-Id: Id4a692e00a43cabcce117efcddff480f6f353ac6
---
M SemanticWatchlist.i18n.php
M SemanticWatchlist.php
M api/ApiEditWatchlistGroup.php
M includes/SWL_Group.php
M specials/SpecialWatchlistConditions.php
M specials/ext.swl.watchlistconditions.js
M specials/jquery.watchlistcondition.js
7 files changed, 6 insertions(+), 54 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticWatchlist 
refs/changes/64/33064/1
--
To view, visit https://gerrit.wikimedia.org/r/33064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4a692e00a43cabcce117efcddff480f6f353ac6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticWatchlist
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Repurpose ms[1-3] - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: Repurpose ms[1-3]
..


Repurpose ms[1-3]

Remove swift from ms[1-3]; repurposing to a test cluster, no puppet
manifests for now.

Change-Id: I5c67fa7cbad4e42cf3fa8b57b7ecaa10f744e46d
---
M manifests/site.pp
1 file changed, 1 insertion(+), 24 deletions(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33063
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5c67fa7cbad4e42cf3fa8b57b7ecaa10f744e46d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Kill last references to Solaris - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: Kill last references to Solaris
..

Kill last references to Solaris

Our puppet repo doesn't work well with Solaris and Solaris doesn't work
well with us. Kill the last remaining bits, as we're not going to
attempt doing this again (and if we do, reverting this would be the
least of our problems).

Change-Id: I6baa042f41dd930da3e596f26ed5587a0b915288
---
M manifests/base.pp
M modules/ntp/templates/ntp-server.erb
2 files changed, 25 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/65/33065/1
--
To view, visit https://gerrit.wikimedia.org/r/33065
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6baa042f41dd930da3e596f26ed5587a0b915288
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Cleanup the base class - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: Cleanup the base class
..

Cleanup the base class

Delete old references to Solaris that is not supported anymore, and
split base to base::production and base::labs to make both a little
cleaner. Also delete a few "if $realm == labs" calls for classes that
aren't included into production anymore. A small step towards the goal
of parameterizing labs, rather than having ifs and elses in every other
class.

Change-Id: I27f3060dec76c01bbb87cd9003e768a9028bf8a3
---
M manifests/base.pp
1 file changed, 60 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/66/33066/1
--
To view, visit https://gerrit.wikimedia.org/r/33066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27f3060dec76c01bbb87cd9003e768a9028bf8a3
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Kill last references to Solaris - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: Kill last references to Solaris
..


Kill last references to Solaris

Our puppet repo doesn't work well with Solaris and Solaris doesn't work
well with us. Kill the last remaining bits, as we're not going to
attempt doing this again (and if we do, reverting this would be the
least of our problems).

Change-Id: I6baa042f41dd930da3e596f26ed5587a0b915288
---
M manifests/base.pp
M modules/ntp/templates/ntp-server.erb
2 files changed, 25 insertions(+), 37 deletions(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33065
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6baa042f41dd930da3e596f26ed5587a0b915288
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add ms1-3 to autoinstall - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: Add ms1-3 to autoinstall
..

Add ms1-3 to autoinstall

Fortunately the thumper partman config was already there, so just re-add
a single line to netboot.cfg.

Change-Id: I5236e6ce2bad300e6d07f9f6b2f7db2fcf547adb
---
M files/autoinstall/netboot.cfg
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/67/33067/1
--
To view, visit https://gerrit.wikimedia.org/r/33067
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5236e6ce2bad300e6d07f9f6b2f7db2fcf547adb
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add ms1-3 to autoinstall - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: Add ms1-3 to autoinstall
..


Add ms1-3 to autoinstall

Fortunately the thumper partman config was already there, so just re-add
a single line to netboot.cfg.

Change-Id: I5236e6ce2bad300e6d07f9f6b2f7db2fcf547adb
---
M files/autoinstall/netboot.cfg
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33067
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5236e6ce2bad300e6d07f9f6b2f7db2fcf547adb
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix ntp template brekage - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: Fix ntp template brekage
..

Fix ntp template brekage

Commit 20e792b broke the ntp template, in an attempt to get rid of the
Solaris if/elses. Fix it.

Change-Id: Ied383396f38d3654a61ecfd0a1a5fbb67d52b282
---
M modules/ntp/templates/ntp-server.erb
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/68/33068/1
--
To view, visit https://gerrit.wikimedia.org/r/33068
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied383396f38d3654a61ecfd0a1a5fbb67d52b282
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix ntp template brekage - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: Fix ntp template brekage
..


Fix ntp template brekage

Commit 20e792b broke the ntp template, in an attempt to get rid of the
Solaris if/elses. Fix it.

Change-Id: Ied383396f38d3654a61ecfd0a1a5fbb67d52b282
---
M modules/ntp/templates/ntp-server.erb
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33068
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied383396f38d3654a61ecfd0a1a5fbb67d52b282
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Bug 42043 - LotteryOdds incorrect calculation - change (mediawiki...ArticleFeedbackv5[master])

2012-11-12 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review.

Change subject: Bug 42043 - LotteryOdds incorrect calculation
..

Bug 42043 - LotteryOdds incorrect calculation

Change-Id: I4f0c531d069fb8068ad044d07be14a8cff5b1912
---
M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.verify.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5 
refs/changes/69/33069/1
--
To view, visit https://gerrit.wikimedia.org/r/33069
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f0c531d069fb8068ad044d07be14a8cff5b1912
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] change rebuildrc option to rebuild and also clear entity cac... - change (mediawiki...Wikibase[master])

2012-11-12 Thread Aude (Code Review)
Aude has uploaded a new change for review.

Change subject: change rebuildrc option to rebuild and also clear entity cache 
and items per site
..

change rebuildrc option to rebuild and also clear entity cache and items per 
site

Change-Id: I69a3b3bd5d99e304cf961f7d5efdf3f3cd67cdbe
---
M lib/maintenance/pollForChanges.php
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/70/33070/1
--
To view, visit https://gerrit.wikimedia.org/r/33070
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69a3b3bd5d99e304cf961f7d5efdf3f3cd67cdbe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] make "Return to ..." work again in CollectionFinishedTemplat... - change (mediawiki...Collection[master])

2012-11-12 Thread schmir (Code Review)
schmir has uploaded a new change for review.

Change subject: make "Return to ..." work again in CollectionFinishedTemplate
..

make "Return to ..." work again in CollectionFinishedTemplate

the text contained raw html markup instead of a link

Change-Id: I0065e2598787a571f5732d161ec4301546fa49cf
---
M Collection.templates.php
1 file changed, 5 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection 
refs/changes/71/33071/1
--
To view, visit https://gerrit.wikimedia.org/r/33071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0065e2598787a571f5732d161ec4301546fa49cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: schmir 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix conflict marker in comment - change (mediawiki/core[master])

2012-11-12 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has uploaded a new change for review.

Change subject: fix conflict marker in comment
..

fix conflict marker in comment

Change-Id: I23e9593890ab5899e10d8eb61f63f38fb98072a7
---
M includes/Revision.php
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/72/33072/1
--
To view, visit https://gerrit.wikimedia.org/r/33072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I23e9593890ab5899e10d8eb61f63f38fb98072a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] re-adding es4 to db.php - change (operations/mediawiki-config[master])

2012-11-12 Thread Pyoungmeister (Code Review)
Pyoungmeister has uploaded a new change for review.

Change subject: re-adding es4 to db.php
..

re-adding es4 to db.php

Change-Id: I386202bcfdd4dfbea924e53a013b01d95f279ddb
---
M wmf-config/db.php
1 file changed, 15 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/73/33073/1
--
To view, visit https://gerrit.wikimedia.org/r/33073
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I386202bcfdd4dfbea924e53a013b01d95f279ddb
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Pyoungmeister 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] re-adding es4 to db.php - change (operations/mediawiki-config[master])

2012-11-12 Thread Pyoungmeister (Code Review)
Pyoungmeister has submitted this change and it was merged.

Change subject: re-adding es4 to db.php
..


re-adding es4 to db.php

Change-Id: I386202bcfdd4dfbea924e53a013b01d95f279ddb
---
M wmf-config/db.php
1 file changed, 15 insertions(+), 15 deletions(-)

Approvals:
  Pyoungmeister: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33073
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I386202bcfdd4dfbea924e53a013b01d95f279ddb
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Pyoungmeister 
Gerrit-Reviewer: Pyoungmeister 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] partman: remove mdadm/boot_degraded from recipes - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: partman: remove mdadm/boot_degraded from recipes
..

partman: remove mdadm/boot_degraded from recipes

mdadm/boot_degraded is defined (with the same value, true) in
common.cfg, no reason to repeat it in several recipes.

Change-Id: Ia6d8f617c87bcb70a9060156fd2a634c50277cf5
---
M files/autoinstall/partman/analytics-cisco.cfg
M files/autoinstall/partman/raid1-1partition.cfg
M files/autoinstall/partman/raid1-30G.cfg
M files/autoinstall/partman/raid1-gpt.cfg
M files/autoinstall/partman/raid1-lvm.cfg
M files/autoinstall/partman/raid1-squid.cfg
M files/autoinstall/partman/raid1-varnish.cfg
M files/autoinstall/partman/raid1.cfg
M files/autoinstall/partman/virt-raid10-cisco-ceph.cfg
M files/autoinstall/partman/virt-raid10-cisco.cfg
M files/autoinstall/partman/virt-raid10.cfg
11 files changed, 0 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/74/33074/1
--
To view, visit https://gerrit.wikimedia.org/r/33074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6d8f617c87bcb70a9060156fd2a634c50277cf5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] partman: new recipe for thumpers - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: partman: new recipe for thumpers
..

partman: new recipe for thumpers

Thumper was very similar to raid1-1partition (same, modulo sdy/sdac).
Use that instead and move into the raid1-* family.

Change-Id: Iad113459ca5b267d18d654219e02e54354e2cb81
---
M files/autoinstall/netboot.cfg
A files/autoinstall/partman/raid1-1partition-thumper.cfg
D files/autoinstall/partman/thumper.cfg
3 files changed, 43 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/75/33075/1
--
To view, visit https://gerrit.wikimedia.org/r/33075
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad113459ca5b267d18d654219e02e54354e2cb81
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] partman: remove mdadm/boot_degraded from recipes - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: partman: remove mdadm/boot_degraded from recipes
..


partman: remove mdadm/boot_degraded from recipes

mdadm/boot_degraded is defined (with the same value, true) in
common.cfg, no reason to repeat it in several recipes.

Change-Id: Ia6d8f617c87bcb70a9060156fd2a634c50277cf5
---
M files/autoinstall/partman/analytics-cisco.cfg
M files/autoinstall/partman/raid1-1partition.cfg
M files/autoinstall/partman/raid1-30G.cfg
M files/autoinstall/partman/raid1-gpt.cfg
M files/autoinstall/partman/raid1-lvm.cfg
M files/autoinstall/partman/raid1-squid.cfg
M files/autoinstall/partman/raid1-varnish.cfg
M files/autoinstall/partman/raid1.cfg
M files/autoinstall/partman/virt-raid10-cisco-ceph.cfg
M files/autoinstall/partman/virt-raid10-cisco.cfg
M files/autoinstall/partman/virt-raid10.cfg
11 files changed, 0 insertions(+), 20 deletions(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6d8f617c87bcb70a9060156fd2a634c50277cf5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] partman: new recipe for thumpers - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: partman: new recipe for thumpers
..


partman: new recipe for thumpers

Thumper was very similar to raid1-1partition (same, modulo sdy/sdac).
Use that instead and move into the raid1-* family.

Change-Id: Iad113459ca5b267d18d654219e02e54354e2cb81
---
M files/autoinstall/netboot.cfg
A files/autoinstall/partman/raid1-1partition-thumper.cfg
D files/autoinstall/partman/thumper.cfg
3 files changed, 43 insertions(+), 29 deletions(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33075
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iad113459ca5b267d18d654219e02e54354e2cb81
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Porting SiteIdInterface blur event handling to site selector... - change (mediawiki...Wikibase[master])

2012-11-12 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

Change subject: Porting SiteIdInterface blur event handling to site selector 
widget
..

Porting SiteIdInterface blur event handling to site selector widget

Change-Id: I10e2249a7d9bb8c411c37354a1a41b932b6cf05e
---
M lib/resources/jquery.ui/jquery.ui.siteselector.js
M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js
2 files changed, 28 insertions(+), 53 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/76/33076/1
--
To view, visit https://gerrit.wikimedia.org/r/33076
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I10e2249a7d9bb8c411c37354a1a41b932b6cf05e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix conflict marker in comment - change (mediawiki/core[master])

2012-11-12 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged.

Change subject: fix conflict marker in comment
..


fix conflict marker in comment

Change-Id: I23e9593890ab5899e10d8eb61f63f38fb98072a7
---
M includes/Revision.php
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  IAlex: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I23e9593890ab5899e10d8eb61f63f38fb98072a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler 
Gerrit-Reviewer: IAlex 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Bug 42039 - Fix some file-related issues in the distribution... - change (mediawiki/core[master])

2012-11-12 Thread MarkAHershberger (Code Review)
MarkAHershberger has uploaded a new change for review.

Change subject: Bug 42039 - Fix some file-related issues in the distribution 
Minor issues.
..

Bug 42039 - Fix some file-related issues in the distribution
Minor issues.

Tested the removal of
maintenance/postgres/archives/patch-ipb_address_unique.sql in a new
installation but haven't tested it on an upgrade.

Change-Id: I58aa11c5acab5de427cbc000e6786a208fc6b26f
---
M maintenance/cleanupPreferences.php
D maintenance/postgres/archives/patch-ipb_address_unique.sql
2 files changed, 52 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/77/33077/1
--
To view, visit https://gerrit.wikimedia.org/r/33077
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58aa11c5acab5de427cbc000e6786a208fc6b26f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MarkAHershberger 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Bug 42039 - Fix some file-related issues in the distribution - change (mediawiki...WikiEditor[master])

2012-11-12 Thread MarkAHershberger (Code Review)
MarkAHershberger has uploaded a new change for review.

Change subject: Bug 42039 - Fix some file-related issues in the distribution
..

Bug 42039 - Fix some file-related issues in the distribution

Change-Id: I725b7ca86d037dafc1ea7ac4e744f8e822953841
---
M modules/jquery.wikiEditor.toolbar.config.js
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/78/33078/1
--
To view, visit https://gerrit.wikimedia.org/r/33078
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I725b7ca86d037dafc1ea7ac4e744f8e822953841
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: MarkAHershberger 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update CentralNotice to master - change (mediawiki/core[wmf/1.21wmf3])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Update CentralNotice to master
..

Update CentralNotice to master

Change-Id: I9b608d5fd404a73515976ebcd5f86c58511367c3
---
M extensions/CentralNotice
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/79/33079/1
--
To view, visit https://gerrit.wikimedia.org/r/33079
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b608d5fd404a73515976ebcd5f86c58511367c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf3
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update CentralNotice to master - change (mediawiki/core[wmf/1.21wmf3])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Update CentralNotice to master
..


Update CentralNotice to master

Change-Id: I9b608d5fd404a73515976ebcd5f86c58511367c3
---
M extensions/CentralNotice
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33079
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b608d5fd404a73515976ebcd5f86c58511367c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf3
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41990) Fix regression in API edit of redirect - change (mediawiki/core[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: (bug 41990) Fix regression in API edit of redirect
..


(bug 41990) Fix regression in API edit of redirect

Before ContentHandler, an API edit passing a redirect for title and
redirect=true and omitting basetimestamp would use the last revision
timestamp of the target page. When ContentHandler was merged, this was
accidentally changed to use the last revision timestamp of the redirect
page, which was likely much earlier than the target page's last revision
and so causes an edit conflict in almost all cases.

Some scripts took advantage of this along with appendtext to add notices
to users' talk pages, so restore that old behavior. We'll also adjust
the contentmodel/contentformat detection added by ContentHandler to use
the model and format of the target page rather than the redirect in this
case, as that seems more likely to be less wrong.

Change-Id: If0c674e26a4deb54ec14f0bf45418d666a397347
---
M RELEASE-NOTES-1.21
M includes/api/ApiEditPage.php
2 files changed, 27 insertions(+), 22 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33049
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0c674e26a4deb54ec14f0bf45418d666a397347
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Bug 41643 - AFTv5: The token parameter must be set - change (mediawiki...ArticleFeedbackv5[master])

2012-11-12 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review.

Change subject: Bug 41643 - AFTv5: The token parameter must be set
..

Bug 41643 - AFTv5: The token parameter must be set

Change-Id: I4a527b12f3032d20a69ea321abeaa3da5c9a5261
---
M ArticleFeedbackv5.hooks.php
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5 
refs/changes/80/33080/1
--
To view, visit https://gerrit.wikimedia.org/r/33080
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a527b12f3032d20a69ea321abeaa3da5c9a5261
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix sortkey retrieval in Store3 (Bug 42033, ...) - change (mediawiki...SemanticMediaWiki[master])

2012-11-12 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review.

Change subject: Fix sortkey retrieval in Store3 (Bug 42033, ...)
..

Fix sortkey retrieval in Store3 (Bug 42033, ...)

Since sortkeys are not stored in a property table, but in the SMW IDs table, 
methods need special code to handle them. This was missing everywhere, but has 
a practical impact only for getPropertyValues(). Where unexpected, this caused 
warnings and errors (Bug 42033, Bug 42034) but also spurious problems with 
ordering of results (only in certain cases).

The change fixes this for getPropertyValues and adds remarks/todos in all cases 
where sortkeys are not currently supported (but not practically needed either).

Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d
---
M includes/storage/SQLStore/SMW_SQLStore3_Queries.php
M includes/storage/SQLStore/SMW_SQLStore3_Readers.php
2 files changed, 27 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/81/33081/1
--
To view, visit https://gerrit.wikimedia.org/r/33081
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41990) Fix regression in API edit of redirect - change (mediawiki/core[wmf/1.21wmf3])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: (bug 41990) Fix regression in API edit of redirect
..

(bug 41990) Fix regression in API edit of redirect

Before ContentHandler, an API edit passing a redirect for title and
redirect=true and omitting basetimestamp would use the last revision
timestamp of the target page. When ContentHandler was merged, this was
accidentally changed to use the last revision timestamp of the redirect
page, which was likely much earlier than the target page's last revision
and so causes an edit conflict in almost all cases.

Some scripts took advantage of this along with appendtext to add notices
to users' talk pages, so restore that old behavior. We'll also adjust
the contentmodel/contentformat detection added by ContentHandler to use
the model and format of the target page rather than the redirect in this
case, as that seems more likely to be less wrong.

Change-Id: If0c674e26a4deb54ec14f0bf45418d666a397347
---
M RELEASE-NOTES-1.21
M includes/api/ApiEditPage.php
2 files changed, 27 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/82/33082/1
--
To view, visit https://gerrit.wikimedia.org/r/33082
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If0c674e26a4deb54ec14f0bf45418d666a397347
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf3
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Anomie 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41990) Fix regression in API edit of redirect - change (mediawiki/core[wmf/1.21wmf3])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: (bug 41990) Fix regression in API edit of redirect
..


(bug 41990) Fix regression in API edit of redirect

Before ContentHandler, an API edit passing a redirect for title and
redirect=true and omitting basetimestamp would use the last revision
timestamp of the target page. When ContentHandler was merged, this was
accidentally changed to use the last revision timestamp of the redirect
page, which was likely much earlier than the target page's last revision
and so causes an edit conflict in almost all cases.

Some scripts took advantage of this along with appendtext to add notices
to users' talk pages, so restore that old behavior. We'll also adjust
the contentmodel/contentformat detection added by ContentHandler to use
the model and format of the target page rather than the redirect in this
case, as that seems more likely to be less wrong.

Change-Id: If0c674e26a4deb54ec14f0bf45418d666a397347
---
M RELEASE-NOTES-1.21
M includes/api/ApiEditPage.php
2 files changed, 27 insertions(+), 22 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33082
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0c674e26a4deb54ec14f0bf45418d666a397347
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf3
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update EducationProgram to master - change (mediawiki/core[wmf/1.21wmf3])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Update EducationProgram to master
..

Update EducationProgram to master

Change-Id: I4fb2cd65a1dff4f534695851090b9c138a908a12
---
M extensions/EducationProgram
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/83/33083/1
--
To view, visit https://gerrit.wikimedia.org/r/33083
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fb2cd65a1dff4f534695851090b9c138a908a12
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf3
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update EducationProgram to master - change (mediawiki/core[wmf/1.21wmf3])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Update EducationProgram to master
..


Update EducationProgram to master

Change-Id: I4fb2cd65a1dff4f534695851090b9c138a908a12
---
M extensions/EducationProgram
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33083
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4fb2cd65a1dff4f534695851090b9c138a908a12
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf3
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Enable RTing of style invalid self-closing ... - change (mediawiki...Parsoid[master])

2012-11-12 Thread Subramanya Sastry (Code Review)
Subramanya Sastry has uploaded a new change for review.

Change subject: Enable RTing of  style invalid self-closing 
tags.
..

Enable RTing of  style invalid self-closing tags.

Change-Id: I4a26a02cf5ec969e4b357e4e2d991d7c701ad533
---
M js/lib/pegTokenizer.pegjs.txt
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/84/33084/1
--
To view, visit https://gerrit.wikimedia.org/r/33084
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a26a02cf5ec969e4b357e4e2d991d7c701ad533
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Regression test for detecting edit conflicts. - change (mediawiki/core[master])

2012-11-12 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has uploaded a new change for review.

Change subject: Regression test for detecting edit conflicts.
..

Regression test for detecting edit conflicts.

Change-Id: I9f8f3850ff0d6d51f173f5be73ffcb3b64886235
---
M tests/phpunit/includes/api/ApiEditPageTest.php
1 file changed, 102 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/85/33085/1
--
To view, visit https://gerrit.wikimedia.org/r/33085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f8f3850ff0d6d51f173f5be73ffcb3b64886235
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] cleaning up some code in wikibase client hooks - change (mediawiki...Wikibase[master])

2012-11-12 Thread Aude (Code Review)
Aude has uploaded a new change for review.

Change subject: cleaning up some code in wikibase client hooks
..

cleaning up some code in wikibase client hooks

Change-Id: Ife7952b92b616e40501be1a7c1c6d00ae744e6f1
---
M client/WikibaseClient.hooks.php
1 file changed, 4 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/86/33086/1
--
To view, visit https://gerrit.wikimedia.org/r/33086
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife7952b92b616e40501be1a7c1c6d00ae744e6f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Removed unused use statements - change (mediawiki...Wikibase[master])

2012-11-12 Thread Aude (Code Review)
Aude has submitted this change and it was merged.

Change subject: Removed unused use statements
..


Removed unused use statements

Change-Id: I1dc297fa12bc680252991dd918150bfa10ffcba9
---
M lib/tests/phpunit/claim/ClaimListTest.php
M lib/tests/phpunit/reference/ReferenceListTest.php
M lib/tests/phpunit/snak/SnakListTest.php
M lib/tests/phpunit/statement/StatementListTest.php
M repo/includes/specials/SpecialCreateEntity.php
5 files changed, 1 insertion(+), 5 deletions(-)

Approvals:
  Aude: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/32756
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1dc297fa12bc680252991dd918150bfa10ffcba9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Overwriting valueCompare in SiteIdInterface - change (mediawiki...Wikibase[master])

2012-11-12 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

Change subject: Overwriting valueCompare in SiteIdInterface
..

Overwriting valueCompare in SiteIdInterface

Overwriting valueCompare ensures proper enter key handling in Firefox.

Change-Id: Ib31ab66935375c1fa7756ef63be62b8d7b6a6144
---
M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js
M lib/tests/qunit/wikibase.ui.SiteLinksEditTool.tests.js
2 files changed, 24 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/87/33087/1
--
To view, visit https://gerrit.wikimedia.org/r/33087
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib31ab66935375c1fa7756ef63be62b8d7b6a6144
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Bug 41507 - Switching filters with an action flyout open bre... - change (mediawiki...ArticleFeedbackv5[master])

2012-11-12 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review.

Change subject: Bug 41507 - Switching filters with an action flyout open breaks 
AFT5
..

Bug 41507 - Switching filters with an action flyout open breaks AFT5

Change-Id: I5cd7fcba80f45ef3deaa191dea5ea1e822c52363
---
M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js
1 file changed, 14 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5 
refs/changes/88/33088/1
--
To view, visit https://gerrit.wikimedia.org/r/33088
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5cd7fcba80f45ef3deaa191dea5ea1e822c52363
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Disable bonding for ms1-3 - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: Disable bonding for ms1-3
..

Disable bonding for ms1-3

It's currently broken on precise and the trials don't need 2x GbE from
day zero. Be lazy.

Change-Id: I75be936bb3d4a8fc3c53d90784875d8fe180eef7
---
M manifests/site.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/89/33089/1
--
To view, visit https://gerrit.wikimedia.org/r/33089
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I75be936bb3d4a8fc3c53d90784875d8fe180eef7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Disable bonding for ms1-3 - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: Disable bonding for ms1-3
..


Disable bonding for ms1-3

It's currently broken on precise and the trials don't need 2x GbE from
day zero. Be lazy.

Change-Id: I75be936bb3d4a8fc3c53d90784875d8fe180eef7
---
M manifests/site.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33089
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I75be936bb3d4a8fc3c53d90784875d8fe180eef7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Trying to create a submodule with a git hash isn't going ot ... - change (mediawiki...release[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Trying to create a submodule with a git hash isn't going ot get 
too far, we need the name!
..

Trying to create a submodule with a git hash isn't going ot get too far, we 
need the name!

Change-Id: I900ce418b94668c15377a4b6c349dc551ab3e3f3
---
M make-wmf-branch/make-wmf-branch
1 file changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release 
refs/changes/90/33090/1
--
To view, visit https://gerrit.wikimedia.org/r/33090
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I900ce418b94668c15377a4b6c349dc551ab3e3f3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Trying to create a submodule with a git hash isn't going ot ... - change (mediawiki...release[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Trying to create a submodule with a git hash isn't going ot get 
too far, we need the name!
..


Trying to create a submodule with a git hash isn't going ot get too far, we 
need the name!

Change-Id: I900ce418b94668c15377a4b6c349dc551ab3e3f3
---
M make-wmf-branch/make-wmf-branch
1 file changed, 8 insertions(+), 6 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33090
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I900ce418b94668c15377a4b6c349dc551ab3e3f3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixing Diff and Wikibase referenced commits - change (mediawiki/core[wmf/1.21wmf4])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Fixing Diff and Wikibase referenced commits
..

Fixing Diff and Wikibase referenced commits

Change-Id: Ibb5ebddda23462fee6381a61f56e24f0cf016a62
---
M extensions/Diff
M extensions/Wikibase
2 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/91/33091/1
--
To view, visit https://gerrit.wikimedia.org/r/33091
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb5ebddda23462fee6381a61f56e24f0cf016a62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf4
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixing Diff and Wikibase referenced commits - change (mediawiki/core[wmf/1.21wmf4])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Fixing Diff and Wikibase referenced commits
..


Fixing Diff and Wikibase referenced commits

Change-Id: Ibb5ebddda23462fee6381a61f56e24f0cf016a62
---
M extensions/Diff
M extensions/Wikibase
2 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33091
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb5ebddda23462fee6381a61f56e24f0cf016a62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf4
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update pom - change (mediawiki...mwdumper[master])

2012-11-12 Thread Bean49 (Code Review)
Bean49 has uploaded a new change for review.

Change subject: Update pom
..

Update pom

Fix compiler warnings.

Change-Id: I074ce1df8f5cb6526573747d338c164d51c2225a
---
M pom.xml
1 file changed, 77 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/mwdumper 
refs/changes/92/33092/1
--
To view, visit https://gerrit.wikimedia.org/r/33092
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I074ce1df8f5cb6526573747d338c164d51c2225a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/mwdumper
Gerrit-Branch: master
Gerrit-Owner: Bean49 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Replaced $.extend; Pass NL-state to nested serializeTokens c... - change (mediawiki...Parsoid[master])

2012-11-12 Thread Subramanya Sastry (Code Review)
Subramanya Sastry has uploaded a new change for review.

Change subject: Replaced $.extend; Pass NL-state to nested serializeTokens 
calls.
..

Replaced $.extend; Pass NL-state to nested serializeTokens calls.

* $.extend(x, o) sets x.k = o.k if x.k is false.  We don't
  necessarily want this behavior for the serializer where initial
  state properties might be set to false.  Added a home-grown
  extendProps to only extend keys with undefined/null values.

* Nested serializeTokens calls now accept a start-line state so
  they dont assume that they start on a newline.  This matters for
  things like link-text tokens, figure captions.  We don't want
  the serializer to assume that for wikitext like [[Foo| bar]],
  link text " bar" is an indent-pre and nowiki-escape it.

* 2 more wt2wt tests green.  This should also eliminate more
  nowiki escapes in round trip testing.

Change-Id: I29ff8d20784d5fe457e0aaa1489d308d5656209f
---
M js/lib/mediawiki.Util.js
M js/lib/mediawiki.WikitextSerializer.js
2 files changed, 42 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/93/33093/1
--
To view, visit https://gerrit.wikimedia.org/r/33093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29ff8d20784d5fe457e0aaa1489d308d5656209f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Added compat for 0.1 and 0.2 serialization - change (mediawiki...Wikibase[master])

2012-11-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Added compat for 0.1 and 0.2 serialization
..

Added compat for 0.1 and 0.2 serialization

Only covers the ID field. Serialization of other unstubbed stuff such as claims 
is not covered by this

Change-Id: I3bb04263bf0d69d09e09512c5a07b746da6ca1d6
---
M lib/includes/entity/EntityObject.php
M lib/tests/phpunit/entity/EntityObjectTest.php
2 files changed, 53 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/94/33094/1
--
To view, visit https://gerrit.wikimedia.org/r/33094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bb04263bf0d69d09e09512c5a07b746da6ca1d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add new docroot stuff for 1.21wmf4 - change (operations/mediawiki-config[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Add new docroot stuff for 1.21wmf4
..

Add new docroot stuff for 1.21wmf4

Change-Id: If0e066c74d905beab64a6b3325c19c5becc9513f
---
A docroot/bits/static-1.21wmf4/extensions
A docroot/bits/static-1.21wmf4/resources
A docroot/bits/static-1.21wmf4/skins
A docroot/secure/skins-1.21wmf4
A live-1.5/static-1.21wmf4/extensions
A live-1.5/static-1.21wmf4/resources
A live-1.5/static-1.21wmf4/skins
7 files changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/95/33095/1
--
To view, visit https://gerrit.wikimedia.org/r/33095
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If0e066c74d905beab64a6b3325c19c5becc9513f
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add new docroot stuff for 1.21wmf4 - change (operations/mediawiki-config[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Add new docroot stuff for 1.21wmf4
..


Add new docroot stuff for 1.21wmf4

Change-Id: If0e066c74d905beab64a6b3325c19c5becc9513f
---
A docroot/bits/static-1.21wmf4/extensions
A docroot/bits/static-1.21wmf4/resources
A docroot/bits/static-1.21wmf4/skins
A docroot/secure/skins-1.21wmf4
A live-1.5/static-1.21wmf4/extensions
A live-1.5/static-1.21wmf4/resources
A live-1.5/static-1.21wmf4/skins
7 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33095
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0e066c74d905beab64a6b3325c19c5becc9513f
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Implement Serializable interface for the entities - change (mediawiki...Wikibase[master])

2012-11-12 Thread Aude (Code Review)
Aude has submitted this change and it was merged.

Change subject: Implement Serializable interface for the entities
..


Implement Serializable interface for the entities

This should prevent future breakage of the entity cache, change table and 
anything else doing serialize() when the object changes

And it actually makes the serialization a lot more compact, saving space! :)

Change-Id: I7d8b5679ca203cc286d30a2f672e2cc8de135de0
---
M lib/includes/entity/Entity.php
M lib/includes/entity/EntityObject.php
M lib/tests/phpunit/entity/EntityObjectTest.php
3 files changed, 57 insertions(+), 1 deletion(-)

Approvals:
  Aude: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33041
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7d8b5679ca203cc286d30a2f672e2cc8de135de0
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Removed ScanSet from extension-list - change (operations/mediawiki-config[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Removed ScanSet from extension-list
..

Removed ScanSet from extension-list

Change-Id: Id6b4f306184be5cad94d59bafdd38a97e3dd38e2
---
M wmf-config/extension-list
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/97/33097/1
--
To view, visit https://gerrit.wikimedia.org/r/33097
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6b4f306184be5cad94d59bafdd38a97e3dd38e2
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Removed ScanSet from extension-list - change (operations/mediawiki-config[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Removed ScanSet from extension-list
..


Removed ScanSet from extension-list

Change-Id: Id6b4f306184be5cad94d59bafdd38a97e3dd38e2
---
M wmf-config/extension-list
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33097
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id6b4f306184be5cad94d59bafdd38a97e3dd38e2
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] apt: re-add support for commenting old apt entries - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: apt: re-add support for commenting old apt entries
..

apt: re-add support for commenting old apt entries

Add support for sed'ing sources.list to comment-out apt.wikimedia.org
entries. Commit 4a4bc6d removed those thinking they were old artifacts,
since nothing created those in the puppet repo; however, they seem to be
created by the autoinstall/d-i machinery and hence are needed to fix new
installs.

Change-Id: I5e7282b70735eda290c90bc6d5420b915a439586
---
M modules/apt/manifests/init.pp
M modules/apt/manifests/repository.pp
2 files changed, 17 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/98/33098/1
--
To view, visit https://gerrit.wikimedia.org/r/33098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e7282b70735eda290c90bc6d5420b915a439586
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] apt: re-add support for commenting old apt entries - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: apt: re-add support for commenting old apt entries
..


apt: re-add support for commenting old apt entries

Add support for sed'ing sources.list to comment-out apt.wikimedia.org
entries. Commit 4a4bc6d removed those thinking they were old
artifacts, since nothing created those in the puppet repo; however,
they seem to be created by the autoinstall/d-i machinery and hence are
needed to fix new installs.

Change-Id: I5e7282b70735eda290c90bc6d5420b915a439586
---
M modules/apt/manifests/init.pp
M modules/apt/manifests/repository.pp
2 files changed, 17 insertions(+), 3 deletions(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e7282b70735eda290c90bc6d5420b915a439586
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix some JSHint issues - change (mediawiki...UniversalLanguageSelector[master])

2012-11-12 Thread Siebrand (Code Review)
Siebrand has submitted this change and it was merged.

Change subject: Fix some JSHint issues
..


Fix some JSHint issues

Change-Id: Iecb1f2d2d326260075755070882b7706c1ae7db4
---
M resources/js/ext.uls.geoclient.js
M resources/js/ext.uls.init.js
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  John Erling Blad: Looks good to me, but someone else must approve
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecb1f2d2d326260075755070882b7706c1ae7db4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: John Erling Blad 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix add/remove groups for sysops - change (mediawiki...EducationProgram[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Fix add/remove groups for sysops
..

Fix add/remove groups for sysops

Change-Id: Ifd1247d6471f69c63406ca04513d23780149d842
---
M EducationProgram.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EducationProgram 
refs/changes/99/33099/1
--
To view, visit https://gerrit.wikimedia.org/r/33099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd1247d6471f69c63406ca04513d23780149d842
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix add/remove groups for sysops - change (mediawiki...EducationProgram[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Fix add/remove groups for sysops
..


Fix add/remove groups for sysops

Change-Id: Ifd1247d6471f69c63406ca04513d23780149d842
---
M EducationProgram.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd1247d6471f69c63406ca04513d23780149d842
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update EducationProgram to master - change (mediawiki/core[wmf/1.21wmf3])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Update EducationProgram to master
..

Update EducationProgram to master

Change-Id: Ie4f7bbc92dd84e84accaf12a56bbd07ce0b671a5
---
M extensions/EducationProgram
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/00/33100/1
--
To view, visit https://gerrit.wikimedia.org/r/33100
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4f7bbc92dd84e84accaf12a56bbd07ce0b671a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf3
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update EducationProgram to master - change (mediawiki/core[wmf/1.21wmf4])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Update EducationProgram to master
..

Update EducationProgram to master

Change-Id: Ic2457b4cb80099cf858286bf3f0127f0ce54bd78
---
M extensions/EducationProgram
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/01/33101/1
--
To view, visit https://gerrit.wikimedia.org/r/33101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2457b4cb80099cf858286bf3f0127f0ce54bd78
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf4
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update EducationProgram to master - change (mediawiki/core[wmf/1.21wmf3])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Update EducationProgram to master
..


Update EducationProgram to master

Change-Id: Ie4f7bbc92dd84e84accaf12a56bbd07ce0b671a5
---
M extensions/EducationProgram
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33100
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4f7bbc92dd84e84accaf12a56bbd07ce0b671a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf3
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update EducationProgram to master - change (mediawiki/core[wmf/1.21wmf4])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Update EducationProgram to master
..


Update EducationProgram to master

Change-Id: Ic2457b4cb80099cf858286bf3f0127f0ce54bd78
---
M extensions/EducationProgram
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2457b4cb80099cf858286bf3f0127f0ce54bd78
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf4
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] apt: minor syntax/whitespace fixes - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: apt: minor syntax/whitespace fixes
..

apt: minor syntax/whitespace fixes

Run a newer version of puppet-lint and fix a few whitespace errors and
syntax warnings. Besides the style aspect of this, this fixes actual,
real bugs (quoting variables and naming a class with a dash).

Change-Id: Icb7320ed7b28ff154502f0ad32c44609364c083c
---
M manifests/base.pp
M modules/apt/manifests/conf.pp
M modules/apt/manifests/init.pp
M modules/apt/manifests/pin.pp
M modules/apt/manifests/repository.pp
R modules/apt/manifests/unattendedupgrades.pp
6 files changed, 35 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/02/33102/1
--
To view, visit https://gerrit.wikimedia.org/r/33102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb7320ed7b28ff154502f0ad32c44609364c083c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] apt: minor syntax/whitespace fixes - change (operations/puppet[production])

2012-11-12 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: apt: minor syntax/whitespace fixes
..


apt: minor syntax/whitespace fixes

Run a newer version of puppet-lint and fix a few whitespace errors and
syntax warnings. Besides the style aspect of this, this fixes actual,
real bugs (quoting variables and naming a class with a dash).

Change-Id: Icb7320ed7b28ff154502f0ad32c44609364c083c
---
M manifests/base.pp
M modules/apt/manifests/conf.pp
M modules/apt/manifests/init.pp
M modules/apt/manifests/pin.pp
M modules/apt/manifests/repository.pp
R modules/apt/manifests/unattendedupgrades.pp
6 files changed, 35 insertions(+), 35 deletions(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb7320ed7b28ff154502f0ad32c44609364c083c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix problems with saving properties, concepts, etc - change (mediawiki...SemanticWatchlist[master])

2012-11-12 Thread Yaron Koren (Code Review)
Yaron Koren has submitted this change and it was merged.

Change subject: Fix problems with saving properties, concepts, etc
..


Fix problems with saving properties, concepts, etc

Reworked code for saving properties/concepts/categories which wasn't
working before.
Removed usage of msg 'swl-group-save'

Change-Id: Id4a692e00a43cabcce117efcddff480f6f353ac6
---
M SemanticWatchlist.i18n.php
M SemanticWatchlist.php
M api/ApiEditWatchlistGroup.php
M includes/SWL_Group.php
M specials/SpecialWatchlistConditions.php
M specials/jquery.watchlistcondition.js
6 files changed, 6 insertions(+), 44 deletions(-)

Approvals:
  Yaron Koren: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4a692e00a43cabcce117efcddff480f6f353ac6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SemanticWatchlist
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 
Gerrit-Reviewer: Nischayn22 
Gerrit-Reviewer: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Bug 41706) preload to convert content as needed. - change (mediawiki/core[master])

2012-11-12 Thread Anomie (Code Review)
Anomie has submitted this change and it was merged.

Change subject: (Bug 41706) preload to convert content as needed.
..


(Bug 41706) preload to convert content as needed.

Use the new Content::convert function to convert preloaded content
if the page being edited uses a different content model. This allows
e.g. a page like User:Foo/bar to be preloaded when creating
User:Foo/common.css. This currently fails, because it is not possible
to use wikitext to pre-fill a CSS page.

Change-Id: I70656b41bd203e5722528e889a242fa54cbfbf62
---
M RELEASE-NOTES-1.21
M includes/EditPage.php
2 files changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Anomie: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/32057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I70656b41bd203e5722528e889a242fa54cbfbf62
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] This reverts commit 65e200f65f4e0a61cf0e3cf92ab7e12f1bf1c51b - change (operations/mediawiki-config[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: This reverts commit 65e200f65f4e0a61cf0e3cf92ab7e12f1bf1c51b
..


This reverts commit 65e200f65f4e0a61cf0e3cf92ab7e12f1bf1c51b
---
A docroot/wikidata/404.html
A docroot/wikidata/503.html
A docroot/wikidata/favicon.ico
A docroot/wikidata/images
A docroot/wikidata/robots.txt
A docroot/wikidata/w
6 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33103
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6fd3ed294f99f15dfe0a1c4c1971765d2bf098d2
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Various small fixes - change (mediawiki...SemanticWatchlist[master])

2012-11-12 Thread Yaron Koren (Code Review)
Yaron Koren has uploaded a new change for review.

Change subject: Various small fixes
..

Various small fixes

Change-Id: Ie3b6c7c38808ee61f7f71c621049ec4dcc4213ff
---
M SemanticWatchlist.php
M specials/SpecialSemanticWatchlist.php
M specials/SpecialWatchlistConditions.php
3 files changed, 7 insertions(+), 7 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticWatchlist 
refs/changes/04/33104/1
--
To view, visit https://gerrit.wikimedia.org/r/33104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3b6c7c38808ee61f7f71c621049ec4dcc4213ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticWatchlist
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Various small fixes - change (mediawiki...SemanticWatchlist[master])

2012-11-12 Thread Yaron Koren (Code Review)
Yaron Koren has submitted this change and it was merged.

Change subject: Various small fixes
..


Various small fixes

Change-Id: Ie3b6c7c38808ee61f7f71c621049ec4dcc4213ff
---
M SemanticWatchlist.php
M specials/SpecialSemanticWatchlist.php
M specials/SpecialWatchlistConditions.php
3 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Yaron Koren: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3b6c7c38808ee61f7f71c621049ec4dcc4213ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticWatchlist
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Drop "My ..." from lqt_newmesages / lqt-newmessages-n - change (mediawiki...LiquidThreads[master])

2012-11-12 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review.

Change subject: Drop "My ..." from lqt_newmesages / lqt-newmessages-n
..

Drop "My ..." from lqt_newmesages / lqt-newmessages-n

Change-Id: Id5635bb3e2d954e2a5383ec672c5a75ca907b375
---
M i18n/Lqt.i18n.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LiquidThreads 
refs/changes/05/33105/1
--
To view, visit https://gerrit.wikimedia.org/r/33105
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5635bb3e2d954e2a5383ec672c5a75ca907b375
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] New version: 0.1.7 - change (mediawiki...AdminLinks[master])

2012-11-12 Thread Yaron Koren (Code Review)
Yaron Koren has uploaded a new change for review.

Change subject: New version: 0.1.7
..

New version: 0.1.7

Change-Id: I07b27247e2d7e04a243fe9b57fc1c18607cf656d
---
M AdminLinks.php
M README
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AdminLinks 
refs/changes/06/33106/1
--
To view, visit https://gerrit.wikimedia.org/r/33106
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07b27247e2d7e04a243fe9b57fc1c18607cf656d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AdminLinks
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Style + docs stuff - change (mediawiki...Wikibase[master])

2012-11-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Style + docs stuff
..

Style + docs stuff

Change-Id: I37ed2092052f3ded321203893962f7084beb4637
---
M repo/includes/specials/SpecialCreateEntity.php
M repo/includes/specials/SpecialCreateItem.php
M repo/includes/specials/SpecialEntitiesWithoutLabel.php
M repo/includes/specials/SpecialItemByTitle.php
M repo/includes/specials/SpecialItemDisambiguation.php
M repo/includes/specials/SpecialItemResolver.php
M repo/includes/specials/SpecialListDatatypes.php
M repo/includes/specials/SpecialNewProperty.php
M repo/includes/specials/SpecialSetLabel.php
M repo/includes/specials/SpecialWikibasePage.php
M repo/includes/specials/SpecialWikibaseQueryPage.php
11 files changed, 175 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/07/33107/1
--
To view, visit https://gerrit.wikimedia.org/r/33107
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I37ed2092052f3ded321203893962f7084beb4637
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Do not interpret spaces as underscores when doing /langcode/... - change (mediawiki...Wikibase[master])

2012-11-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Do not interpret spaces as underscores when doing 
/langcode/text-with-spaces
..

Do not interpret spaces as underscores when doing /langcode/text-with-spaces

Change-Id: I18ee8abcf7093fc0c4c57819679382c8ba833215
---
M repo/includes/specials/SpecialItemByTitle.php
M repo/includes/specials/SpecialItemDisambiguation.php
2 files changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/08/33108/1
--
To view, visit https://gerrit.wikimedia.org/r/33108
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I18ee8abcf7093fc0c4c57819679382c8ba833215
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Style + docs stuff - change (mediawiki...Wikibase[master])

2012-11-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: Style + docs stuff
..


Style + docs stuff

Change-Id: I37ed2092052f3ded321203893962f7084beb4637
---
M repo/includes/specials/SpecialCreateEntity.php
M repo/includes/specials/SpecialCreateItem.php
M repo/includes/specials/SpecialEntitiesWithoutLabel.php
M repo/includes/specials/SpecialItemByTitle.php
M repo/includes/specials/SpecialItemDisambiguation.php
M repo/includes/specials/SpecialItemResolver.php
M repo/includes/specials/SpecialListDatatypes.php
M repo/includes/specials/SpecialNewProperty.php
M repo/includes/specials/SpecialSetLabel.php
M repo/includes/specials/SpecialWikibasePage.php
M repo/includes/specials/SpecialWikibaseQueryPage.php
11 files changed, 175 insertions(+), 2 deletions(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33107
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I37ed2092052f3ded321203893962f7084beb4637
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Point Wikibase to 856bad9d6083d5ac1f8eb6ffa36cf0374a36e9e5 - change (mediawiki/core[wmf/1.21wmf4])

2012-11-12 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Point Wikibase to 856bad9d6083d5ac1f8eb6ffa36cf0374a36e9e5
..

Point Wikibase to 856bad9d6083d5ac1f8eb6ffa36cf0374a36e9e5

Change-Id: I10eff88b29b57f20145d13abf95c1e923b408f6a
---
M extensions/Wikibase
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/09/33109/1
--
To view, visit https://gerrit.wikimedia.org/r/33109
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I10eff88b29b57f20145d13abf95c1e923b408f6a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf4
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Point Wikibase to 856bad9d6083d5ac1f8eb6ffa36cf0374a36e9e5 - change (mediawiki/core[wmf/1.21wmf4])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Point Wikibase to 856bad9d6083d5ac1f8eb6ffa36cf0374a36e9e5
..


Point Wikibase to 856bad9d6083d5ac1f8eb6ffa36cf0374a36e9e5

Change-Id: I10eff88b29b57f20145d13abf95c1e923b408f6a
---
M extensions/Wikibase
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33109
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I10eff88b29b57f20145d13abf95c1e923b408f6a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf4
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] New version: 0.1.7 - change (mediawiki...AdminLinks[master])

2012-11-12 Thread Yaron Koren (Code Review)
Yaron Koren has submitted this change and it was merged.

Change subject: New version: 0.1.7
..


New version: 0.1.7

Change-Id: I07b27247e2d7e04a243fe9b57fc1c18607cf656d
---
M AdminLinks.php
M README
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yaron Koren: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33106
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07b27247e2d7e04a243fe9b57fc1c18607cf656d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AdminLinks
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Drop "My ..." from lqt_newmesages / lqt-newmessages-n - change (mediawiki...LiquidThreads[master])

2012-11-12 Thread MarkTraceur (Code Review)
MarkTraceur has submitted this change and it was merged.

Change subject: Drop "My ..." from lqt_newmesages / lqt-newmessages-n
..


Drop "My ..." from lqt_newmesages / lqt-newmessages-n

Change-Id: Id5635bb3e2d954e2a5383ec672c5a75ca907b375
---
M i18n/Lqt.i18n.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  MarkTraceur: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33105
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id5635bb3e2d954e2a5383ec672c5a75ca907b375
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: MarkTraceur 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Enable wgVectorCombineUserTalk for {test|mw}wikis - change (operations/mediawiki-config[master])

2012-11-12 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review.

Change subject: Enable wgVectorCombineUserTalk for {test|mw}wikis
..

Enable wgVectorCombineUserTalk for {test|mw}wikis

Change-Id: I8a53e4741a9254baedd3f285d50b001cfc8ffe02
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/10/33110/1
--
To view, visit https://gerrit.wikimedia.org/r/33110
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a53e4741a9254baedd3f285d50b001cfc8ffe02
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add VisualEditor namespace creation to wmf-config - change (operations/mediawiki-config[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Add VisualEditor namespace creation to wmf-config
..


Add VisualEditor namespace creation to wmf-config

Removed from the VE extension in
https://gerrit.wikimedia.org/r/#/c/31889/

Change-Id: I8fd1c156de9597b6010c6092041f6ed6dbb34553
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
2 files changed, 28 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/31949
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fd1c156de9597b6010c6092041f6ed6dbb34553
Gerrit-PatchSet: 3
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Hydriz 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Enable wgVectorCombineUserTalk for {test|mw}wikis - change (operations/mediawiki-config[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Enable wgVectorCombineUserTalk for {test|mw}wikis
..


Enable wgVectorCombineUserTalk for {test|mw}wikis

Change-Id: I8a53e4741a9254baedd3f285d50b001cfc8ffe02
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33110
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a53e4741a9254baedd3f285d50b001cfc8ffe02
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Hide the VE preference on mw.org and enable it by default - change (operations/mediawiki-config[master])

2012-11-12 Thread Catrope (Code Review)
Catrope has uploaded a new change for review.

Change subject: Hide the VE preference on mw.org and enable it by default
..

Hide the VE preference on mw.org and enable it by default

Change-Id: I50fd767297498295b7375c9d5ba8ab860d1bb55e
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
2 files changed, 18 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/11/33111/1
--
To view, visit https://gerrit.wikimedia.org/r/33111
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50fd767297498295b7375c9d5ba8ab860d1bb55e
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix sortkey retrieval in Store3 (Bug 42033, ...) - change (mediawiki...SemanticMediaWiki[master])

2012-11-12 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Fix sortkey retrieval in Store3 (Bug 42033, ...)
..


Fix sortkey retrieval in Store3 (Bug 42033, ...)

Since sortkeys are not stored in a property table, but in the SMW IDs table, 
methods need special code to handle them. This was missing everywhere, but has 
a practical impact only for getPropertyValues(). Where unexpected, this caused 
warnings and errors (Bug 42033, Bug 42034) but also spurious problems with 
ordering of results (only in certain cases).

The change fixes this for getPropertyValues and adds remarks/todos in all cases 
where sortkeys are not currently supported (but not practically needed either).

Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d
---
M includes/storage/SQLStore/SMW_SQLStore3_Queries.php
M includes/storage/SQLStore/SMW_SQLStore3_Readers.php
2 files changed, 27 insertions(+), 4 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved
  Jeroen De Dauw: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/33081
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch 
Gerrit-Reviewer: Daniel Werner 
Gerrit-Reviewer: Denny Vrandecic 
Gerrit-Reviewer: Foxtrott 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: Kghbln 
Gerrit-Reviewer: Markus Kroetzsch 
Gerrit-Reviewer: Mwjames 
Gerrit-Reviewer: Nischayn22 
Gerrit-Reviewer: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Hide the VE preference on mw.org and enable it by default - change (operations/mediawiki-config[master])

2012-11-12 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Hide the VE preference on mw.org and enable it by default
..


Hide the VE preference on mw.org and enable it by default

Change-Id: I50fd767297498295b7375c9d5ba8ab860d1bb55e
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
2 files changed, 18 insertions(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33111
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50fd767297498295b7375c9d5ba8ab860d1bb55e
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Merge branch 'master' into 1.9.x - change (mediawiki...SemanticMediaWiki[1.9.x])

2012-11-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Merge branch 'master' into 1.9.x
..

Merge branch 'master' into 1.9.x

Change-Id: I1005443f5f34eb6513ff910433d523d0f0062ae0
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/12/33112/1
--
To view, visit https://gerrit.wikimedia.org/r/33112
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1005443f5f34eb6513ff910433d523d0f0062ae0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: 1.9.x
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Merge branch 'master' into 1.9.x - change (mediawiki...SemanticMediaWiki[1.9.x])

2012-11-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: Merge branch 'master' into 1.9.x
..


Merge branch 'master' into 1.9.x

Change-Id: I1005443f5f34eb6513ff910433d523d0f0062ae0
---
0 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33112
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1005443f5f34eb6513ff910433d523d0f0062ae0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: 1.9.x
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 42049) Parse timedmedia-subtitle-new-desc - change (mediawiki...TimedMediaHandler[master])

2012-11-12 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review.

Change subject: (bug 42049) Parse timedmedia-subtitle-new-desc
..

(bug 42049) Parse timedmedia-subtitle-new-desc

Change-Id: Iabb7be71a2862b5843592ee1815ab5f459f98c5d
---
M TimedTextPage.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/13/33113/1
--
To view, visit https://gerrit.wikimedia.org/r/33113
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabb7be71a2862b5843592ee1815ab5f459f98c5d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


  1   2   >