[MediaWiki-commits] [Gerrit] Moving site selector widget to wikibase namespace - change (mediawiki...Wikibase[master])

2012-11-13 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

Change subject: Moving site selector widget to wikibase namespace
..

Moving site selector widget to wikibase namespace

Change-Id: Ib6e87ca7d6a56ac6d5cc393319fea4221756eb02
---
M lib/resources/Resources.php
R lib/resources/jquery.wikibase/jquery.wikibase.siteselector.js
2 files changed, 13 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/58/33158/1
--
To view, visit https://gerrit.wikimedia.org/r/33158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6e87ca7d6a56ac6d5cc393319fea4221756eb02
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update TimedMediaHandler to master - change (mediawiki/core[wmf/1.21wmf4])

2012-11-13 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Update TimedMediaHandler to master
..

Update TimedMediaHandler to master

Change-Id: Ibdd8b85ef85e23a5bd3bf9e5155cabf62d122ffd
---
M extensions/TimedMediaHandler
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/59/33159/1
--
To view, visit https://gerrit.wikimedia.org/r/33159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdd8b85ef85e23a5bd3bf9e5155cabf62d122ffd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf4
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update TimedMediaHandler to master - change (mediawiki/core[wmf/1.21wmf3])

2012-11-13 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Update TimedMediaHandler to master
..

Update TimedMediaHandler to master

Change-Id: I10c41193f7df9a70d977ab11f60cb6c2f8c62a8b
---
M extensions/TimedMediaHandler
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/60/33160/1
--
To view, visit https://gerrit.wikimedia.org/r/33160
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I10c41193f7df9a70d977ab11f60cb6c2f8c62a8b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf3
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update TimedMediaHandler to master - change (mediawiki/core[wmf/1.21wmf4])

2012-11-13 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Update TimedMediaHandler to master
..


Update TimedMediaHandler to master

Change-Id: Ibdd8b85ef85e23a5bd3bf9e5155cabf62d122ffd
---
M extensions/TimedMediaHandler
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdd8b85ef85e23a5bd3bf9e5155cabf62d122ffd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf4
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update TimedMediaHandler to master - change (mediawiki/core[wmf/1.21wmf3])

2012-11-13 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Update TimedMediaHandler to master
..


Update TimedMediaHandler to master

Change-Id: I10c41193f7df9a70d977ab11f60cb6c2f8c62a8b
---
M extensions/TimedMediaHandler
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33160
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I10c41193f7df9a70d977ab11f60cb6c2f8c62a8b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf3
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update jquery.ime from upstream - change (mediawiki...UniversalLanguageSelector[master])

2012-11-13 Thread Santhosh (Code Review)
Santhosh has uploaded a new change for review.

Change subject: Update jquery.ime from upstream
..

Update jquery.ime from upstream

Change-Id: I2bf298173918b8b4c8a14fd69242e858f6ec4744
---
M lib/jquery.ime/css/jquery.ime.css
A lib/jquery.ime/images/ime-active.png
D lib/jquery.ime/images/ime-active.svg
A lib/jquery.ime/images/tick.png
D lib/jquery.ime/images/tick.svg
M lib/jquery.ime/jquery.ime.js
6 files changed, 570 insertions(+), 638 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/61/33161/1
--
To view, visit https://gerrit.wikimedia.org/r/33161
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bf298173918b8b4c8a14fd69242e858f6ec4744
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] QUnit test for site selector widget - change (mediawiki...Wikibase[master])

2012-11-13 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

Change subject: QUnit test for site selector widget
..

QUnit test for site selector widget

Change-Id: Icc312c124afe70c626fbb1c5d444999ed4b43827
---
M lib/WikibaseLib.hooks.php
A lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
M 
lib/tests/qunit/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.tests.js
3 files changed, 118 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/62/33162/1
--
To view, visit https://gerrit.wikimedia.org/r/33162
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc312c124afe70c626fbb1c5d444999ed4b43827
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 2865) Add lang attribute to firstHeading - change (mediawiki/core[master])

2012-11-13 Thread Amire80 (Code Review)
Amire80 has uploaded a new change for review.

Change subject: (bug 2865) Add lang attribute to firstHeading
..

(bug 2865) Add lang attribute to firstHeading

Adds a lang attribute to h1 id=firstHeading.

Interface language is applied to html and content language is
applied to div id=mw-content-text. This leaves firstHeading
with the interface language, which is wrong in general. It
also causes incorrect display of the title for languages that
have custom line-height.

This patch is based on code written by Munirathnam M at
the Bangalore DevCamp (he couldn't submit it because of network
issues). It looks OK to me, but it's my first time doing anything
with $this-data in a skin, so please correct me if I'm wrong.

Change-Id: I55dd392dbf0d4f768344b66e6ceb3a023b1d5c9b
---
M skins/Modern.php
M skins/MonoBook.php
M skins/Vector.php
3 files changed, 12 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/63/33163/1
--
To view, visit https://gerrit.wikimedia.org/r/33163
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I55dd392dbf0d4f768344b66e6ceb3a023b1d5c9b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Overwriting autocomplete's search delay in site selector wid... - change (mediawiki...Wikibase[master])

2012-11-13 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

Change subject: Overwriting autocomplete's search delay in site selector widget
..

Overwriting autocomplete's search delay in site selector widget

Change-Id: Ibda3da66573a560a2290c068e450269056bd0512
---
M lib/resources/jquery.wikibase/jquery.wikibase.siteselector.js
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/64/33164/1
--
To view, visit https://gerrit.wikimedia.org/r/33164
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibda3da66573a560a2290c068e450269056bd0512
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update docs - change (mediawiki...UniversalLanguageSelector[master])

2012-11-13 Thread Nikerabbit (Code Review)
Nikerabbit has submitted this change and it was merged.

Change subject: Update docs
..


Update docs

Change-Id: I68c0751bf044aa1e35b8db0f85ac2b54270860e9
---
M UniversalLanguageSelector.hooks.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Nikerabbit: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68c0751bf044aa1e35b8db0f85ac2b54270860e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Siebrand siebr...@wikimedia.org
Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com
Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Updated Ruby gems - change (qa/browsertests[master])

2012-11-13 Thread Zfilipin (Code Review)
Zfilipin has uploaded a new change for review.

Change subject: Updated Ruby gems
..

Updated Ruby gems

Change-Id: I81db9816273d4b5de3b6b780cbffb3eeafe835f1
---
M Gemfile.lock
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/65/33165/1
--
To view, visit https://gerrit.wikimedia.org/r/33165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81db9816273d4b5de3b6b780cbffb3eeafe835f1
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Sync with GitHub repository. - change (mediawiki...HostStats[master])

2012-11-13 Thread Hydriz (Code Review)
Hydriz has submitted this change and it was merged.

Change subject: Sync with GitHub repository.
..


Sync with GitHub repository.

As per a simple code review by SPQRobin, this change:
1) Removes the dependency on globals and replacing it with
$this-getOutput().
2) Escapes the extension messages to make it safer.

Also with this change is:
1) Assigning protection for the functions.

Change-Id: I3055168b08fbaf9f5fe2bc71c428b92e4fb361cf
---
M SpecialHostStats.php
1 file changed, 6 insertions(+), 7 deletions(-)

Approvals:
  Hydriz: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33047
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3055168b08fbaf9f5fe2bc71c428b92e4fb361cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/HostStats
Gerrit-Branch: master
Gerrit-Owner: Hydriz ad...@alphacorp.tk
Gerrit-Reviewer: Hydriz ad...@alphacorp.tk
Gerrit-Reviewer: SPQRobin robinp.1...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Display link to Sauce Labs job in console output - change (qa/browsertests[master])

2012-11-13 Thread Zfilipin (Code Review)
Zfilipin has uploaded a new change for review.

Change subject: Display link to Sauce Labs job in console output
..

Display link to Sauce Labs job in console output

Useful for debugging.

Change-Id: I4275d3d64194697181f0d9435663a04c4fd08ec0
---
M features/support/env.rb
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/66/33166/1
--
To view, visit https://gerrit.wikimedia.org/r/33166
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4275d3d64194697181f0d9435663a04c4fd08ec0
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Moving label/value definition from SiteIdInterface to site s... - change (mediawiki...Wikibase[master])

2012-11-13 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

Change subject: Moving label/value definition from SiteIdInterface to site 
selector
..

Moving label/value definition from SiteIdInterface to site selector

Comes along with added/updated tests.

Change-Id: Ia1a7f4b802cd57d5be742645444888d03b958eae
---
M lib/resources/jquery.wikibase/jquery.wikibase.siteselector.js
M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
M 
lib/tests/qunit/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.tests.js
4 files changed, 78 insertions(+), 45 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/67/33167/1
--
To view, visit https://gerrit.wikimedia.org/r/33167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1a7f4b802cd57d5be742645444888d03b958eae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fixed entity links in client recent changes - change (mediawiki...Wikibase[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: fixed entity links in client recent changes
..


fixed entity links in client recent changes

- the entity links in the client RC contained the id-prefix twice and were
  broken

Change-Id: I4a7f5fafcbe81a1de91047075f63832b35830861
---
M client/WikibaseClient.hooks.php
M client/includes/ClientUtils.php
M client/includes/ExternalChangesList.php
3 files changed, 27 insertions(+), 17 deletions(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/32502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a7f5fafcbe81a1de91047075f63832b35830861
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41672) Drop My from My courses toplink - change (mediawiki...EducationProgram[master])

2012-11-13 Thread Eloquence (Code Review)
Eloquence has uploaded a new change for review.

Change subject: (bug 41672) Drop My from My courses toplink
..

(bug 41672) Drop My from My courses toplink

Change-Id: I43af468e858994fd7c62ad6c9dcf3e8598d9c604
---
M EducationProgram.i18n.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EducationProgram 
refs/changes/68/33168/1
--
To view, visit https://gerrit.wikimedia.org/r/33168
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43af468e858994fd7c62ad6c9dcf3e8598d9c604
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Eloquence e...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Install syntax highlighting gem for Cucumber HTML reports - change (qa/browsertests[master])

2012-11-13 Thread Zfilipin (Code Review)
Zfilipin has uploaded a new change for review.

Change subject: Install syntax highlighting gem for Cucumber HTML reports
..

Install syntax highlighting gem for Cucumber HTML reports

Change-Id: I07f148488aa0608c9e96f4098692c2f60b162f60
---
M Gemfile
M Gemfile.lock
2 files changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/69/33169/1
--
To view, visit https://gerrit.wikimedia.org/r/33169
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07f148488aa0608c9e96f4098692c2f60b162f60
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Constant SECRET is now needed locally too - change (qa/browsertests[master])

2012-11-13 Thread Zfilipin (Code Review)
Zfilipin has uploaded a new change for review.

Change subject: Constant SECRET is now needed locally too
..

Constant SECRET is now needed locally too

Upload wizard test requires that the user is logged in, and password is
stored in config/secret.yml.

Change-Id: Ia6f0c44f07bc9cbd174d9616852b4cbfd7ee04e9
---
M features/support/env.rb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/70/33170/1
--
To view, visit https://gerrit.wikimedia.org/r/33170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6f0c44f07bc9cbd174d9616852b4cbfd7ee04e9
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Some cleanup in ExternalChangesList - change (mediawiki...Wikibase[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Some cleanup in ExternalChangesList
..

Some cleanup in ExternalChangesList

* titleTextFromEntityData now works with Entities not of type Item in all cases
* $titleText is always defined before used (ie no longer a fatal in some cases)
* added a fixme and todo
* properly obtain a prefixed id (no need to construct an EntityObject)

Change-Id: I019138b1b01623ca08f1b836c14dc3ccf49bbae5
---
M client/includes/ExternalChangesList.php
1 file changed, 21 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/71/33171/1
--
To view, visit https://gerrit.wikimedia.org/r/33171
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I019138b1b01623ca08f1b836c14dc3ccf49bbae5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41672) Drop My from My courses toplink - change (mediawiki...EducationProgram[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: (bug 41672) Drop My from My courses toplink
..


(bug 41672) Drop My from My courses toplink

Change-Id: I43af468e858994fd7c62ad6c9dcf3e8598d9c604
---
M EducationProgram.i18n.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33168
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43af468e858994fd7c62ad6c9dcf3e8598d9c604
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Eloquence e...@wikimedia.org
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Added local MediaWiki install to config file - change (qa/browsertests[master])

2012-11-13 Thread Zfilipin (Code Review)
Zfilipin has uploaded a new change for review.

Change subject: Added local MediaWiki install to config file
..

Added local MediaWiki install to config file

Instructions on how to install MediaWiki are here: 
https://github.com/wikimedia/wmf-vagrant

Change-Id: Ib93f1c14a6ab6850d07770bb2dfde76e03636698
---
M config/config.yml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/72/33172/1
--
To view, visit https://gerrit.wikimedia.org/r/33172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib93f1c14a6ab6850d07770bb2dfde76e03636698
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Use bits cortado url for commons videos - change (mediawiki...TimedMediaHandler[master])

2012-11-13 Thread J (Code Review)
J has uploaded a new change for review.

Change subject: Use bits cortado url for commons videos
..

Use bits cortado url for commons videos

there is a crossdomain.xml file on upload.wikimedia.org,
and 99.9% of clients use a Java version which supports
crossdomain.xml so no need to special case this.

Related OggHandler commit: Ic0a87184

Change-Id: I657ac15c63002613c5fde7c5584007eef37fcec3
---
M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerJava.js
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/73/33173/1
--
To view, visit https://gerrit.wikimedia.org/r/33173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I657ac15c63002613c5fde7c5584007eef37fcec3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J jger...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Put API test in medium group - change (mediawiki...DataValues[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Put API test in medium group
..

Put API test in medium group

Change-Id: I2b6558eb99301e3d469d336d5dd4155b23a8a493
---
M ValueParsers/tests/includes/api/ApiParseValueTest.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues 
refs/changes/74/33174/1
--
To view, visit https://gerrit.wikimedia.org/r/33174
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b6558eb99301e3d469d336d5dd4155b23a8a493
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Removed unused use statements - change (mediawiki...DataValues[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Removed unused use statements
..

Removed unused use statements

Change-Id: I7ebb52d934f8da43d437b70028b3519a73f09293
---
M ValueParsers/includes/ValueParserFactory.php
M ValueParsers/tests/includes/ValueParserFactoryTest.php
2 files changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues 
refs/changes/75/33175/1
--
To view, visit https://gerrit.wikimedia.org/r/33175
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ebb52d934f8da43d437b70028b3519a73f09293
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add job for testing Diff extension - change (integration/jenkins[master])

2012-11-13 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: Add job for testing Diff extension
..


Add job for testing Diff extension

Change-Id: I13af61540d72c6d32a04fbaf89b34b61f9b20fe6
---
A jobs/Ext-Diff/ExtraSettings.php
A jobs/Ext-Diff/build.xml
A jobs/Ext-Diff/config.xml
A jobs/Ext-Diff/default.properties
4 files changed, 91 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/32833
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I13af61540d72c6d32a04fbaf89b34b61f9b20fe6
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Hashar has...@free.fr

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Added value validator factory - change (mediawiki...DataValues[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Added value validator factory
..

Added value validator factory

Change-Id: I05157fb6a4d11725de61a84c2c55c42026e93a29
---
M ValueValidators/ValueValidators.classes.php
M ValueValidators/ValueValidators.mw.php
M ValueValidators/ValueValidators.php
A ValueValidators/includes/ValueValidatorFactory.php
A ValueValidators/tests/phpunit/ValueValidatorFactoryTest.php
5 files changed, 202 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues 
refs/changes/76/33176/1
--
To view, visit https://gerrit.wikimedia.org/r/33176
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05157fb6a4d11725de61a84c2c55c42026e93a29
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Uniform $rtl usage in Arabic-script Messages*.php - change (mediawiki/core[master])

2012-11-13 Thread Amire80 (Code Review)
Amire80 has uploaded a new change for review.

Change subject: Uniform $rtl usage in Arabic-script Messages*.php
..

Uniform $rtl usage in Arabic-script Messages*.php

Also fix the name of aeb (Tunisian Arabic).

Change-Id: I63c414c090d67e61b16df234eeb2043733203e1a
---
M languages/messages/MessagesAeb.php
M languages/messages/MessagesArz.php
M languages/messages/MessagesBcc.php
M languages/messages/MessagesBqi.php
M languages/messages/MessagesGlk.php
M languages/messages/MessagesKu_arab.php
M languages/messages/MessagesPs.php
7 files changed, 15 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/77/33177/1
--
To view, visit https://gerrit.wikimedia.org/r/33177
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63c414c090d67e61b16df234eeb2043733203e1a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Use bits cortado url for commons videos - change (mediawiki...TimedMediaHandler[master])

2012-11-13 Thread J (Code Review)
J has submitted this change and it was merged.

Change subject: Use bits cortado url for commons videos
..


Use bits cortado url for commons videos

there is a crossdomain.xml file on upload.wikimedia.org,
and 99.9% of clients use a Java version which supports
crossdomain.xml so no need to special case this.

Related OggHandler commit: Ic0a87184

Change-Id: I657ac15c63002613c5fde7c5584007eef37fcec3
---
M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerJava.js
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  J: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I657ac15c63002613c5fde7c5584007eef37fcec3
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J jger...@wikimedia.org
Gerrit-Reviewer: Faidon fai...@wikimedia.org
Gerrit-Reviewer: J jger...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Some cleanup in ExternalChangesList - change (mediawiki...Wikibase[master])

2012-11-13 Thread Aude (Code Review)
Aude has submitted this change and it was merged.

Change subject: Some cleanup in ExternalChangesList
..


Some cleanup in ExternalChangesList

* titleTextFromEntityData now works with Entities not of type Item in all cases
* $titleText is always defined before used (ie no longer a fatal in some cases)
* added a fixme and todo
* properly obtain a prefixed id (no need to construct an EntityObject)

Change-Id: I019138b1b01623ca08f1b836c14dc3ccf49bbae5
---
M client/includes/ExternalChangesList.php
1 file changed, 21 insertions(+), 11 deletions(-)

Approvals:
  Aude: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33171
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I019138b1b01623ca08f1b836c14dc3ccf49bbae5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Put API test in medium group - change (mediawiki...DataValues[master])

2012-11-13 Thread Henning Snater (Code Review)
Henning Snater has submitted this change and it was merged.

Change subject: Put API test in medium group
..


Put API test in medium group

Change-Id: I2b6558eb99301e3d469d336d5dd4155b23a8a493
---
M ValueParsers/tests/includes/api/ApiParseValueTest.php
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Henning Snater: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33174
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b6558eb99301e3d469d336d5dd4155b23a8a493
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Improved docs - change (mediawiki...Diff[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Improved docs
..

Improved docs

Change-Id: I57fb115057b8861636ca23719a8758a70af4d1d3
---
M includes/Diff.php
M includes/DiffOpAdd.php
M includes/DiffOpChange.php
M includes/DiffOpRemove.php
M includes/IDiff.php
5 files changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Diff 
refs/changes/78/33178/1
--
To view, visit https://gerrit.wikimedia.org/r/33178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I57fb115057b8861636ca23719a8758a70af4d1d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Removed static method from interface as this is not allowed ... - change (mediawiki...Diff[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Removed static method from interface as this is not allowed in 
strict mode
..

Removed static method from interface as this is not allowed in strict mode

Change-Id: I6632f674505d62a02e6f8846cc54180d7af397e3
---
M includes/IDiff.php
1 file changed, 0 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Diff 
refs/changes/79/33179/1
--
To view, visit https://gerrit.wikimedia.org/r/33179
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6632f674505d62a02e6f8846cc54180d7af397e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] updated rel notes - change (mediawiki...Diff[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: updated rel notes
..

updated rel notes

Change-Id: I5ca0d7814f0b828f404986897a22d754559c58a1
---
M Diff.credits.php
M RELEASE-NOTES
2 files changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Diff 
refs/changes/80/33180/1
--
To view, visit https://gerrit.wikimedia.org/r/33180
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ca0d7814f0b828f404986897a22d754559c58a1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Ext-Diff no more block Gerrit changes - change (integration/jenkins[master])

2012-11-13 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: Ext-Diff no more block Gerrit changes
..


Ext-Diff no more block Gerrit changes

Made job failure to be Verified 0 to avoid blocking change submitted in
Gerrit while the tests are being fixed.

Change-Id: I4daf327080f49480e2bf19b027dd120854674cef
---
M jobs/Ext-Diff/config.xml
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4daf327080f49480e2bf19b027dd120854674cef
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Support EntityId in Entity::setId - change (mediawiki...Wikibase[master])

2012-11-13 Thread Aude (Code Review)
Aude has submitted this change and it was merged.

Change subject: Support EntityId in Entity::setId
..


Support EntityId in Entity::setId

Change-Id: I2008d6b4ed1ed5c979ee39f34560030a4bc41708
---
M lib/includes/Hashable.php
M lib/includes/Immutable.php
M lib/includes/entity/Entity.php
M lib/includes/entity/EntityId.php
M lib/includes/entity/EntityObject.php
M lib/tests/phpunit/entity/EntityObjectTest.php
M repo/includes/store/sql/EntityPerPageTable.php
7 files changed, 76 insertions(+), 22 deletions(-)

Approvals:
  Aude: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/32660
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2008d6b4ed1ed5c979ee39f34560030a4bc41708
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] remove wikibase client from jenkins wikibase repo settings - change (integration/jenkins[master])

2012-11-13 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: remove wikibase client from jenkins wikibase repo settings
..


remove wikibase client from jenkins wikibase repo settings

- wikibase client can be setup as a separate job, but
should not co-exist in the same wiki as the repo.

Change-Id: I89047bd68d9d95f5ec1811d45b8ee040cc782bf3
---
M jobs/Ext-Wikibase/ExtraSettings.php
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/32848
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89047bd68d9d95f5ec1811d45b8ee040cc782bf3
Gerrit-PatchSet: 2
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Aude aude.w...@gmail.com
Gerrit-Reviewer: Demon ch...@wikimedia.org
Gerrit-Reviewer: Hashar has...@free.fr

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Created $.valueview and sub-system for creating DataValue ed... - change (mediawiki...DataValues[master])

2012-11-13 Thread Daniel Werner (Code Review)
Daniel Werner has uploaded a new change for review.

Change subject: Created $.valueview and sub-system for creating DataValue edit 
view widgets
..

Created $.valueview and sub-system for creating DataValue edit view widgets

This introduces $.fn.valueview as well as $.valueview.widget. The later serves 
as a widget factory, similar to $.widget but with the purpose to create widgets 
which will be used by $.fn.valueview and for a specific kind of DataValue.
Also created $.valueview.Widget which inherits from $.Widget and extends it 
with functions required for the views. This is not yet done, the definition 
will be enhanced in a follow-up.

Change-Id: I9285c50f74e26910360258b7a6f09165eacd5022
---
M DataTypes/DataTypes.mw.php
A DataTypes/Resources.php
M DataTypes/includes/DataTypeFactory.php
A DataTypes/resources/DataType.js
A DataTypes/resources/dataTypes.js
A DataTypes/resources/jquery.valueview.Widget.js
A DataTypes/resources/jquery.valueview.js
M ValueParsers/includes/ValueParserFactory.php
8 files changed, 486 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues 
refs/changes/83/33183/1
--
To view, visit https://gerrit.wikimedia.org/r/33183
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9285c50f74e26910360258b7a6f09165eacd5022
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Provide arguments for constructor test - change (mediawiki...Diff[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Provide arguments for constructor test
..

Provide arguments for constructor test

Also improved registration of exception class so myIDE does not go mad :)

Change-Id: I24f925aa47590c722a34ddd8c682bc8cc6106e2e
---
M Diff.php
M includes/MapDiff.php
M tests/MapDiffTest.php
3 files changed, 89 insertions(+), 55 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Diff 
refs/changes/84/33184/1
--
To view, visit https://gerrit.wikimedia.org/r/33184
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I24f925aa47590c722a34ddd8c682bc8cc6106e2e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] updated rel notes and bumped version to 0.3 alpha - change (mediawiki...Diff[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: updated rel notes and bumped version to 0.3 alpha
..


updated rel notes and bumped version to 0.3 alpha

Change-Id: I5ca0d7814f0b828f404986897a22d754559c58a1
---
M Diff.credits.php
M RELEASE-NOTES
2 files changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33180
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ca0d7814f0b828f404986897a22d754559c58a1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Provide arguments for constructor test - change (mediawiki...Diff[master])

2012-11-13 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: Provide arguments for constructor test
..


Provide arguments for constructor test

Also improved registration of exception class so myIDE does not go mad :)

Change-Id: I24f925aa47590c722a34ddd8c682bc8cc6106e2e
---
M Diff.php
M includes/MapDiff.php
M tests/ListDiffTest.php
M tests/MapDiffTest.php
4 files changed, 131 insertions(+), 63 deletions(-)

Approvals:
  Jens Ohlig: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33184
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24f925aa47590c722a34ddd8c682bc8cc6106e2e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Cosmetic improvements - change (mediawiki...DataTransfer[master])

2012-11-13 Thread Yaron Koren (Code Review)
Yaron Koren has uploaded a new change for review.

Change subject: Cosmetic improvements
..

Cosmetic improvements

Change-Id: Id79c0dbef07cdaaa1909a3c919a823c749390366
---
M README
M specials/DT_ViewXML.php
2 files changed, 51 insertions(+), 49 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataTransfer 
refs/changes/86/33186/1
--
To view, visit https://gerrit.wikimedia.org/r/33186
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id79c0dbef07cdaaa1909a3c919a823c749390366
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataTransfer
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren yaro...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Revert Ext-Diff no more block Gerrit changes - change (integration/jenkins[master])

2012-11-13 Thread Hashar (Code Review)
Hashar has submitted this change and it was merged.

Change subject: Revert Ext-Diff no more block Gerrit changes
..


Revert Ext-Diff no more block Gerrit changes

Tests are fixed by https://gerrit.wikimedia.org/r/#/c/33184/

This reverts commit 837303288d15c11611e5cc02c99e9e4daeb22658
---
M jobs/Ext-Diff/config.xml
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Hashar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33185
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If724b6de5d90b43b6d08f9e491829c4ecc651e0c
Gerrit-PatchSet: 2
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Hashar has...@free.fr

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add wikivoyage to site group map - change (mediawiki...Wikibase[master])

2012-11-13 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: add wikivoyage to site group map
..


add wikivoyage to site group map

Change-Id: Iafed9e46c22f9f5121fedc05a2fee82a518f70fd
---
M lib/includes/Utils.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jens Ohlig: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33060
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafed9e46c22f9f5121fedc05a2fee82a518f70fd
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Silke Meyer silke.me...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Cosmetic improvements - change (mediawiki...DataTransfer[master])

2012-11-13 Thread Yaron Koren (Code Review)
Yaron Koren has submitted this change and it was merged.

Change subject: Cosmetic improvements
..


Cosmetic improvements

Change-Id: Id79c0dbef07cdaaa1909a3c919a823c749390366
---
M README
M specials/DT_ViewXML.php
2 files changed, 51 insertions(+), 49 deletions(-)

Approvals:
  Yaron Koren: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33186
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id79c0dbef07cdaaa1909a3c919a823c749390366
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataTransfer
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren yaro...@gmail.com
Gerrit-Reviewer: Yaron Koren yaro...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] use \pZ (separator) and \pC (control) to squash whitespace i... - change (mediawiki...Wikibase[master])

2012-11-13 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: use \pZ (separator) and \pC (control) to squash whitespace 
instead of \s
..


use \pZ (separator) and \pC (control) to squash whitespace instead of \s

- \s doesn't work 100% of the time and failing with some test cases for me
- see http://www.unicode.org/reports/tr18/#Categories for details
- this fixes annoying bug!

Change-Id: Ia157c3f4fb41e59da09a233f8b64d10ffdd88e96
---
M lib/includes/Utils.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jens Ohlig: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/32580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia157c3f4fb41e59da09a233f8b64d10ffdd88e96
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude aude.w...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de
Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com
Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] New version: 0.3.12 - change (mediawiki...DataTransfer[master])

2012-11-13 Thread Yaron Koren (Code Review)
Yaron Koren has uploaded a new change for review.

Change subject: New version: 0.3.12
..

New version: 0.3.12

Change-Id: I430ffd4165e3ea6a58a501b97e71ef26b075c01e
---
M DataTransfer.php
M INSTALL
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataTransfer 
refs/changes/87/33187/1
--
To view, visit https://gerrit.wikimedia.org/r/33187
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I430ffd4165e3ea6a58a501b97e71ef26b075c01e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataTransfer
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren yaro...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] New version: 0.3.12 - change (mediawiki...DataTransfer[master])

2012-11-13 Thread Yaron Koren (Code Review)
Yaron Koren has submitted this change and it was merged.

Change subject: New version: 0.3.12
..


New version: 0.3.12

Change-Id: I430ffd4165e3ea6a58a501b97e71ef26b075c01e
---
M DataTransfer.php
M INSTALL
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yaron Koren: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33187
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I430ffd4165e3ea6a58a501b97e71ef26b075c01e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataTransfer
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren yaro...@gmail.com
Gerrit-Reviewer: Yaron Koren yaro...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Removed static method from interface as this is not allowed ... - change (mediawiki...Diff[master])

2012-11-13 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: Removed static method from interface as this is not allowed in 
strict mode
..


Removed static method from interface as this is not allowed in strict mode

Change-Id: I6632f674505d62a02e6f8846cc54180d7af397e3
---
M includes/IDiff.php
1 file changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Jens Ohlig: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33179
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6632f674505d62a02e6f8846cc54180d7af397e3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Bug 42057 - Feedback link on article pages - change (mediawiki...ArticleFeedbackv5[master])

2012-11-13 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review.

Change subject: Bug 42057 - Feedback link on article pages
..

Bug 42057 - Feedback link on article pages

* Add API endpoint to fetch amount of entries for a given page/filter
* Code for above functionality was in use on special page already; moved that 
code to utils so both can access this and avoid code duplication
* add Javascript ajax call to fetch the amount of feedback and display a link 
on article page
* Update talk-page link to also only display if there is feedback

Change-Id: If48e3534e0407c20c666151c595106c3d7a27c3c
---
M ArticleFeedbackv5.hooks.php
M ArticleFeedbackv5.i18n.php
M ArticleFeedbackv5.php
M SpecialArticleFeedbackv5.php
M api/ApiArticleFeedbackv5Utils.php
A api/ApiGetCountArticleFeedbackv5.php
M modules/ext.articleFeedbackv5/ext.articleFeedbackv5.css
M modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js
M modules/ext.articleFeedbackv5/ext.articleFeedbackv5.talk.js
M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.verify.js
10 files changed, 269 insertions(+), 56 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5 
refs/changes/88/33188/1
--
To view, visit https://gerrit.wikimedia.org/r/33188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If48e3534e0407c20c666151c595106c3d7a27c3c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie mmul...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Merge branch 'master' into 1.9.x - change (mediawiki...SemanticMediaWiki[1.9.x])

2012-11-13 Thread Mwjames (Code Review)
Mwjames has uploaded a new change for review.

Change subject: Merge branch 'master' into 1.9.x
..

Merge branch 'master' into 1.9.x

Change-Id: I3ef8b0e1e13e184363f5220ab892e42ecc77571d
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/89/33189/1
--
To view, visit https://gerrit.wikimedia.org/r/33189
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ef8b0e1e13e184363f5220ab892e42ecc77571d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: 1.9.x
Gerrit-Owner: Mwjames jamesin.hongkon...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Added value factory and newFromArray methods + tests - change (mediawiki...DataValues[master])

2012-11-13 Thread Henning Snater (Code Review)
Henning Snater has submitted this change and it was merged.

Change subject: Added value factory and newFromArray methods + tests
..


Added value factory and newFromArray methods + tests

Change-Id: Ie0cb6dd87c6598b5539e395bf0c0bdfd1882177e
---
M DataValues/DataValues.classes.php
M DataValues/DataValues.mw.php
M DataValues/DataValues.php
M DataValues/includes/DataValue.php
A DataValues/includes/DataValueFactory.php
M DataValues/includes/values/BooleanValue.php
M DataValues/includes/values/GeoCoordinateValue.php
M DataValues/includes/values/IriValue.php
M DataValues/includes/values/MediaWikiTitleValue.php
M DataValues/includes/values/MonolingualTextValue.php
M DataValues/includes/values/MultilingualTextValue.php
M DataValues/includes/values/NumberValue.php
M DataValues/includes/values/QuantityValue.php
M DataValues/includes/values/StringValue.php
M DataValues/includes/values/UnknownValue.php
A DataValues/tests/includes/DataValueFactoryTest.php
M DataValues/tests/includes/DataValueTest.php
17 files changed, 424 insertions(+), 7 deletions(-)

Approvals:
  Henning Snater: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/32830
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0cb6dd87c6598b5539e395bf0c0bdfd1882177e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Merge branch 'master' into 1.9.x - change (mediawiki...SemanticMediaWiki[1.9.x])

2012-11-13 Thread Mwjames (Code Review)
Mwjames has submitted this change and it was merged.

Change subject: Merge branch 'master' into 1.9.x
..


Merge branch 'master' into 1.9.x

Change-Id: I3ef8b0e1e13e184363f5220ab892e42ecc77571d
---
0 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Mwjames: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33189
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ef8b0e1e13e184363f5220ab892e42ecc77571d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: 1.9.x
Gerrit-Owner: Mwjames jamesin.hongkon...@gmail.com
Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Follow up to 5fe2b5ec39b4b8c2812cd56ceec9cb814aebb438: minor... - change (mediawiki...DataValues[master])

2012-11-13 Thread Henning Snater (Code Review)
Henning Snater has submitted this change and it was merged.

Change subject: Follow up to 5fe2b5ec39b4b8c2812cd56ceec9cb814aebb438: minor 
tweaks
..


Follow up to 5fe2b5ec39b4b8c2812cd56ceec9cb814aebb438: minor tweaks

Change-Id: Ic784f545b12359f08d6d174136ef6af35b9316a8
---
M ValueParsers/resources/valueParsers.util.js
M ValueParsers/tests/qunit/ValueParser.tests.js
2 files changed, 6 insertions(+), 23 deletions(-)

Approvals:
  Henning Snater: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/31836
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic784f545b12359f08d6d174136ef6af35b9316a8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] JS refactoring: Api.js - change (mediawiki...Wikibase[master])

2012-11-13 Thread Henning Snater (Code Review)
Henning Snater has submitted this change and it was merged.

Change subject: JS refactoring: Api.js
..


JS refactoring: Api.js

still to do:
- tests
- decide how to publish response (e.g. events), see TODOs
- integrate into EditableValue

patchset 2: baserevid is now a parameter; removed obsolet method
performApiAction; fixed whitespaces;
patchset 3: fixed documentation; added missing apicall parameters;
patch set 4: Extending mw.Api instead of instantiating mw.Api on each AJAX 
request.
patch set 5: minor documentation update
patch set 6: simplified and renamed queryApi/post method
patch set 7: added newEntity method to API
patch set 8: rebased

Change-Id: Ie6ca0805517d225a4712b772c8abbeed0977c772
---
M lib/resources/wikibase.store/wikibase.Api.js
1 file changed, 122 insertions(+), 2 deletions(-)

Approvals:
  Henning Snater: Verified; Looks good to me, approved
  Jeroen De Dauw: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/31206
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6ca0805517d225a4712b772c8abbeed0977c772
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Bug 40238) Add dir=auto to sitelinks - change (mediawiki...Wikibase[master])

2012-11-13 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: (Bug 40238) Add dir=auto to sitelinks
..


(Bug 40238) Add dir=auto to sitelinks

Change-Id: I47337650ac53c518d8278d4bb99255fc1de5e1c5
---
M lib/resources/templates.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jens Ohlig: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33046
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I47337650ac53c518d8278d4bb99255fc1de5e1c5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: John Erling Blad john.b...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] change rebuildrc option to rebuild and also clear entity cac... - change (mediawiki...Wikibase[master])

2012-11-13 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: change rebuildrc option to rebuild and also clear entity cache 
and items per site
..


change rebuildrc option to rebuild and also clear entity cache and items per 
site

Change-Id: I69a3b3bd5d99e304cf961f7d5efdf3f3cd67cdbe
---
M lib/maintenance/pollForChanges.php
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  Jens Ohlig: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33070
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I69a3b3bd5d99e304cf961f7d5efdf3f3cd67cdbe
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude aude.w...@gmail.com
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Improved setup and entry point code - change (mediawiki...Diff[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Improved setup and entry point code
..

Improved setup and entry point code

Change-Id: I11d11659193359019f58619811e66450902e79c3
---
A Diff.mw.php
M Diff.php
M Diff.standalone.php
M RELEASE-NOTES
M includes/DiffOpAdd.php
M includes/DiffOpChange.php
M includes/DiffOpRemove.php
7 files changed, 91 insertions(+), 55 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Diff 
refs/changes/90/33190/1
--
To view, visit https://gerrit.wikimedia.org/r/33190
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11d11659193359019f58619811e66450902e79c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Include test commented out for unknown reason - change (mediawiki...Diff[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Include test commented out for unknown reason
..

Include test commented out for unknown reason

Change-Id: Ief1be59046853313b591f9032c4b246ce036074e
---
M Diff.mw.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Diff 
refs/changes/91/33191/1
--
To view, visit https://gerrit.wikimedia.org/r/33191
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief1be59046853313b591f9032c4b246ce036074e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Cleanup of wikibase.utilities.jQuery.ui.js - change (mediawiki...Wikibase[master])

2012-11-13 Thread Daniel Werner (Code Review)
Daniel Werner has submitted this change and it was merged.

Change subject: Cleanup of wikibase.utilities.jQuery.ui.js
..


Cleanup of wikibase.utilities.jQuery.ui.js

Change set removes call to deprecated jQuery.browser.

Change-Id: I3e34b580bc1aa9b5fb483722fd05aec5faeadffb
---
M lib/resources/wikibase.utilities/wikibase.utilities.jQuery.ui.js
1 file changed, 23 insertions(+), 18 deletions(-)

Approvals:
  Daniel Werner: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3e34b580bc1aa9b5fb483722fd05aec5faeadffb
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Bug 36309) Introduce +sep= as a multiple value identifier i... - change (mediawiki...SemanticMediaWiki[1.9.x])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: (Bug 36309) Introduce +sep= as a multiple value identifier in 
#set
..


(Bug 36309) Introduce +sep= as a multiple value identifier in #set

## Description
Setting multiple values for the same property using the +sep= marker
in the #set parser function

|+sep= is a succeeding identifier that follows a property/value parameter
pair and is used to specifiy a separator by either using |+sep=; or in
case of an empty |+sep=/|+sep declaration, the comma is used as the default
separator.

## Example
{{#set:
 |has set test 1=Example 1;Example 2;Example 3;Example 4|+sep=;
 |has set test 2=More examples
 |has set test 3=12+22+3+4+5+6+7+8+9+10|+sep=+
 |has set test 4=In between example
 |has set test 5=123,1234,12345,|+sep=
 |has set test 6=One,or,two,more,examples|+sep
 |has set test 6=Last example
}}

## Patch Set 6
+ Allows to define values as |Has property=Test1|Test2|Test3 equally to
the subobject parser funtion.
+ Add unit test
+ Remove all logic from the #set classs and transferred it into a separated
ParserParameter class
+ Move #set into SMW namespace

## Tests
OK (8 tests, 16 assertions)

Change-Id: Ia5b05ce8fcb21acc5d70d6dc283ebb79b118f6f5
---
M SemanticMediaWiki.hooks.php
M includes/SMW_Setup.php
A includes/parserhooks/ParserParameter.php
D includes/parserhooks/SMW_Set.php
A includes/parserhooks/Set.php
A tests/phpunit/includes/parserhooks/ParserParameterTest.php
6 files changed, 295 insertions(+), 44 deletions(-)

Approvals:
  Mwjames: Verified
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/32347
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5b05ce8fcb21acc5d70d6dc283ebb79b118f6f5
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: 1.9.x
Gerrit-Owner: Mwjames jamesin.hongkon...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Do not interpret spaces as underscores when doing /langcode/... - change (mediawiki...Wikibase[master])

2012-11-13 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: Do not interpret spaces as underscores when doing 
/langcode/text-with-spaces
..


Do not interpret spaces as underscores when doing /langcode/text-with-spaces

Change-Id: I18ee8abcf7093fc0c4c57819679382c8ba833215
---
M repo/includes/specials/SpecialItemByTitle.php
M repo/includes/specials/SpecialItemDisambiguation.php
2 files changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Jens Ohlig: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33108
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I18ee8abcf7093fc0c4c57819679382c8ba833215
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Removed unused use statements - change (mediawiki...DataValues[master])

2012-11-13 Thread Jens Ohlig (Code Review)
Jens Ohlig has submitted this change and it was merged.

Change subject: Removed unused use statements
..


Removed unused use statements

Change-Id: I7ebb52d934f8da43d437b70028b3519a73f09293
---
M ValueParsers/includes/ValueParserFactory.php
M ValueParsers/tests/includes/ValueParserFactoryTest.php
2 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jens Ohlig: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33175
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ebb52d934f8da43d437b70028b3519a73f09293
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add EntityChange base class to handle common stuff for all c... - change (mediawiki...Wikibase[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: add EntityChange base class to handle common stuff for all 
change types
..


add EntityChange base class to handle common stuff for all change types

Change-Id: I80aad549472c9c107e4b336e8e6fe4b507d4eca7
---
M client/WikibaseClient.hooks.php
M lib/WikibaseLib.hooks.php
M lib/WikibaseLib.php
M lib/includes/changes/Change.php
M lib/includes/changes/ChangeRow.php
M lib/includes/changes/DiffChange.php
A lib/includes/changes/EntityChange.php
M lib/includes/changes/EntityCreation.php
M lib/includes/changes/EntityDeletion.php
M lib/includes/changes/EntityRefresh.php
M lib/includes/changes/EntityRestore.php
M lib/includes/changes/EntityUpdate.php
M lib/includes/entity/EntityFactory.php
M lib/tests/phpunit/changes/ChangeRowTest.php
A lib/tests/phpunit/changes/EntityChangeTest.php
M lib/tests/phpunit/changes/EntityCreationTest.php
M lib/tests/phpunit/changes/EntityDeletionTest.php
M lib/tests/phpunit/changes/EntityRefreshTest.php
A lib/tests/phpunit/changes/EntityRestoreTest.php
M lib/tests/phpunit/changes/EntityUpdateTest.php
M lib/tests/phpunit/changes/TestChanges.php
M repo/Wikibase.hooks.php
22 files changed, 460 insertions(+), 363 deletions(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33033
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80aad549472c9c107e4b336e8e6fe4b507d4eca7
Gerrit-PatchSet: 17
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude aude.w...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Adding labsdb3 to dhcpd file - change (operations/puppet[production])

2012-11-13 Thread Cmjohnson (Code Review)
Cmjohnson has uploaded a new change for review.

Change subject: Adding labsdb3 to dhcpd file
..

Adding labsdb3 to dhcpd file

Change-Id: I899f4fac4274d960d4fe8783f77b5f65d01e07b0
---
M files/dhcpd/linux-host-entries.ttyS0-115200
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/92/33192/1
--
To view, visit https://gerrit.wikimedia.org/r/33192
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I899f4fac4274d960d4fe8783f77b5f65d01e07b0
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Cmjohnson cmjohn...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Added ClaimsSerializer and did a lot of cleanup, mainly reve... - change (mediawiki...Wikibase[master])

2012-11-13 Thread Daniel Werner (Code Review)
Daniel Werner has submitted this change and it was merged.

Change subject: Added ClaimsSerializer and did a lot of cleanup, mainly 
reverting most of 5c29e13798dd31cd233ffbd2d28ca6854177bb8b
..


Added ClaimsSerializer and did a lot of cleanup, mainly reverting most of 
5c29e13798dd31cd233ffbd2d28ca6854177bb8b

- patch-set 4: fixed test failure in 'ApiGetEntitiesTest'

Change-Id: I03568da54414c828f3932376f6243f2edcc6db9c
---
M repo/Wikibase.hooks.php
M repo/Wikibase.php
M repo/includes/api/serializers/ByPropertyListSerializer.php
M repo/includes/api/serializers/ClaimSerializer.php
A repo/includes/api/serializers/ClaimsSerializer.php
M repo/includes/api/serializers/EntitySerializer.php
M repo/includes/api/serializers/ItemSerializer.php
M repo/tests/phpunit/includes/api/ApiGetEntitiesTest.php
M repo/tests/phpunit/includes/api/serializers/ByPropertyListSerializerTest.php
M repo/tests/phpunit/includes/api/serializers/ClaimSerializerTest.php
A repo/tests/phpunit/includes/api/serializers/ClaimsSerializerTest.php
M repo/tests/phpunit/includes/api/serializers/ItemSerializerTest.php
12 files changed, 175 insertions(+), 125 deletions(-)

Approvals:
  Daniel Werner: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/32736
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03568da54414c828f3932376f6243f2edcc6db9c
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Adding labsdb3 to dhcpd file - change (operations/puppet[production])

2012-11-13 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: Adding labsdb3 to dhcpd file
..


Adding labsdb3 to dhcpd file

Change-Id: I899f4fac4274d960d4fe8783f77b5f65d01e07b0
---
M files/dhcpd/linux-host-entries.ttyS0-115200
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33192
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I899f4fac4274d960d4fe8783f77b5f65d01e07b0
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Cmjohnson cmjohn...@wikimedia.org
Gerrit-Reviewer: Faidon fai...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Auto-expand test refactoring - change (mediawiki...Wikibase[master])

2012-11-13 Thread Daniel Werner (Code Review)
Daniel Werner has submitted this change and it was merged.

Change subject: Auto-expand test refactoring
..


Auto-expand test refactoring

Change-Id: I7decc30a6dbe6edd106e7d30691f06e1e2b9bec8
---
M 
lib/tests/qunit/wikibase.utilities/wikibase.utilities.jQuery.ui.inputAutoExpand.tests.js
1 file changed, 57 insertions(+), 59 deletions(-)

Approvals:
  Daniel Werner: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7decc30a6dbe6edd106e7d30691f06e1e2b9bec8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Bug 39019) Add +sep= as a multiple value identifier in #sub... - change (mediawiki...SemanticMediaWiki[1.9.x])

2012-11-13 Thread Mwjames (Code Review)
Mwjames has uploaded a new change for review.

Change subject: (Bug 39019) Add +sep= as a multiple value identifier in 
#subobject
..

(Bug 39019) Add +sep= as a multiple value identifier in #subobject

## Description
+ Use new ParserParameter class to enable multiple values using the +sep=
identifier
+ Move to the SMW namespace
+ Add docs++

Change-Id: I6a163494d13c18ee49876a59c11a2c6f443f473b
---
M SemanticMediaWiki.hooks.php
M includes/SMW_Setup.php
D includes/parserhooks/SMW_Subobject.php
A includes/parserhooks/Subobject.php
4 files changed, 110 insertions(+), 96 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/93/33193/1
--
To view, visit https://gerrit.wikimedia.org/r/33193
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a163494d13c18ee49876a59c11a2c6f443f473b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: 1.9.x
Gerrit-Owner: Mwjames jamesin.hongkon...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Porting SiteIdInterface blur event handling to site selector... - change (mediawiki...Wikibase[master])

2012-11-13 Thread Daniel Werner (Code Review)
Daniel Werner has submitted this change and it was merged.

Change subject: Porting SiteIdInterface blur event handling to site selector 
widget
..


Porting SiteIdInterface blur event handling to site selector widget

Change-Id: I10e2249a7d9bb8c411c37354a1a41b932b6cf05e
---
M lib/resources/jquery.ui/jquery.ui.siteselector.js
M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js
2 files changed, 28 insertions(+), 53 deletions(-)

Approvals:
  Daniel Werner: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33076
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I10e2249a7d9bb8c411c37354a1a41b932b6cf05e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Added compat for 0.1 and 0.2 serialization - change (mediawiki...Wikibase[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: Added compat for 0.1 and 0.2 serialization
..


Added compat for 0.1 and 0.2 serialization

Only covers the ID field. Serialization of other unstubbed stuff such as claims 
is not covered by this

Change-Id: I3bb04263bf0d69d09e09512c5a07b746da6ca1d6
---
M lib/includes/entity/EntityObject.php
M lib/tests/phpunit/entity/EntityObjectTest.php
2 files changed, 53 insertions(+), 0 deletions(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3bb04263bf0d69d09e09512c5a07b746da6ca1d6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Updated Ruby gems - change (qa/browsertests[master])

2012-11-13 Thread Cmcmahon (Code Review)
Cmcmahon has submitted this change and it was merged.

Change subject: Updated Ruby gems
..


Updated Ruby gems

Change-Id: I81db9816273d4b5de3b6b780cbffb3eeafe835f1
---
M Gemfile.lock
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Cmcmahon: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I81db9816273d4b5de3b6b780cbffb3eeafe835f1
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org
Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Display link to Sauce Labs job in console output - change (qa/browsertests[master])

2012-11-13 Thread Cmcmahon (Code Review)
Cmcmahon has submitted this change and it was merged.

Change subject: Display link to Sauce Labs job in console output
..


Display link to Sauce Labs job in console output

Useful for debugging.

Change-Id: I4275d3d64194697181f0d9435663a04c4fd08ec0
---
M features/support/env.rb
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Cmcmahon: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33166
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4275d3d64194697181f0d9435663a04c4fd08ec0
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org
Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update to the latest released Ruby version - change (qa/browsertests[master])

2012-11-13 Thread Cmcmahon (Code Review)
Cmcmahon has submitted this change and it was merged.

Change subject: Update to the latest released Ruby version
..


Update to the latest released Ruby version

RVM 1.9.3p327, Cloudbees 1.9.3p286

More information at:
http://www.ruby-lang.org/en/news/2012/11/09/ruby-1-9-3-p327-is-released/
https://repository-cloudbees.forge.cloudbees.com/distributions/ci-addons/ruby/?C=M;O=D

Change-Id: I643e0eb2fc77b3cca62374e774bf429ed166fdd0
---
M .rvmrc
M README.md
M docs/jenkins.md
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Cmcmahon: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33096
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I643e0eb2fc77b3cca62374e774bf429ed166fdd0
Gerrit-PatchSet: 2
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org
Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org
Gerrit-Reviewer: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Added local MediaWiki install to config file - change (qa/browsertests[master])

2012-11-13 Thread Cmcmahon (Code Review)
Cmcmahon has submitted this change and it was merged.

Change subject: Added local MediaWiki install to config file
..


Added local MediaWiki install to config file

Instructions on how to install MediaWiki are here: 
https://github.com/wikimedia/wmf-vagrant

Change-Id: Ib93f1c14a6ab6850d07770bb2dfde76e03636698
---
M config/config.yml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Cmcmahon: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib93f1c14a6ab6850d07770bb2dfde76e03636698
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org
Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixed a bunch of issues with feed printer - change (mediawiki...SemanticMediaWiki[master])

2012-11-13 Thread Mwjames (Code Review)
Mwjames has submitted this change and it was merged.

Change subject: Fixed a bunch of issues with feed printer
..


Fixed a bunch of issues with feed printer

* Improved docs
* Fixed indent
* Fixed incorrect ref to var name (fatal error)
* Added forewards compat for ContentHandler
* Fixed methods retruning void instead of string on error

Change-Id: I08e73188b3b941b98b3ab318a0ef36b634246c32
---
M includes/queryprinters/SMW_QP_Feed.php
1 file changed, 54 insertions(+), 31 deletions(-)

Approvals:
  Mwjames: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08e73188b3b941b98b3ab318a0ef36b634246c32
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de
Gerrit-Reviewer: Foxtrott s7ep...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com
Gerrit-Reviewer: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Yaron Koren yaro...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Clean up database cloning for tests. - change (mediawiki/core[master])

2012-11-13 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has uploaded a new change for review.

Change subject: Clean up database cloning for tests.
..

Clean up database cloning for tests.

This change makes the operation for overlaying the wiki database
with a structurally equivalent test database statically accessible,
and adds a function to revert that operation.

This is a precondition to logging profiling info to the database
after the test run has finished.

Change-Id: I2e8335d50eefcc7a97c1cd122b509f0939eacc92
---
M tests/phpunit/MediaWikiTestCase.php
1 file changed, 68 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/94/33194/1
--
To view, visit https://gerrit.wikimedia.org/r/33194
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e8335d50eefcc7a97c1cd122b509f0939eacc92
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Log profiling data when tests have finished. - change (mediawiki/core[master])

2012-11-13 Thread Daniel Kinzler (Code Review)
Daniel Kinzler has uploaded a new change for review.

Change subject: Log profiling data when tests have finished.
..

Log profiling data when tests have finished.

Previously, no profiling data was recorded from unit test runs.
That made it impossible to a) use unit tests for selective profiling
of individual functions, and b) made it impossibel to profile
the tests themselves.

This change fixes this problem by calling wfLogProfilingData()
after the test runner has finished.

Change-Id: Iaa295115f3c4eb3b529388dcd953fe8932448b3e
---
M tests/phpunit/MediaWikiPHPUnitCommand.php
1 file changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/95/33195/1
--
To view, visit https://gerrit.wikimedia.org/r/33195
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa295115f3c4eb3b529388dcd953fe8932448b3e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] QUnit test for site selector widget - change (mediawiki...Wikibase[master])

2012-11-13 Thread Daniel Werner (Code Review)
Daniel Werner has submitted this change and it was merged.

Change subject: QUnit test for site selector widget
..


QUnit test for site selector widget

Change-Id: Icc312c124afe70c626fbb1c5d444999ed4b43827
---
M lib/WikibaseLib.hooks.php
A lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
M 
lib/tests/qunit/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.tests.js
3 files changed, 118 insertions(+), 9 deletions(-)

Approvals:
  Daniel Werner: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33162
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc312c124afe70c626fbb1c5d444999ed4b43827
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Overwriting autocomplete's search delay in site selector wid... - change (mediawiki...Wikibase[master])

2012-11-13 Thread Daniel Werner (Code Review)
Daniel Werner has submitted this change and it was merged.

Change subject: Overwriting autocomplete's search delay in site selector widget
..


Overwriting autocomplete's search delay in site selector widget

Change-Id: Ibda3da66573a560a2290c068e450269056bd0512
---
M lib/resources/jquery.wikibase/jquery.wikibase.siteselector.js
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Daniel Werner: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33164
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibda3da66573a560a2290c068e450269056bd0512
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Merge branch 'master' into 1.9.x - change (mediawiki...SemanticMediaWiki[1.9.x])

2012-11-13 Thread Mwjames (Code Review)
Mwjames has uploaded a new change for review.

Change subject: Merge branch 'master' into 1.9.x
..

Merge branch 'master' into 1.9.x

Change-Id: I5bae4c28541b7eafcacb46de346d1b329215955b
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/96/33196/1
--
To view, visit https://gerrit.wikimedia.org/r/33196
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bae4c28541b7eafcacb46de346d1b329215955b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: 1.9.x
Gerrit-Owner: Mwjames jamesin.hongkon...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Merge branch 'master' into 1.9.x - change (mediawiki...SemanticMediaWiki[1.9.x])

2012-11-13 Thread Mwjames (Code Review)
Mwjames has submitted this change and it was merged.

Change subject: Merge branch 'master' into 1.9.x
..


Merge branch 'master' into 1.9.x

Change-Id: I5bae4c28541b7eafcacb46de346d1b329215955b
---
0 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Mwjames: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33196
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5bae4c28541b7eafcacb46de346d1b329215955b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: 1.9.x
Gerrit-Owner: Mwjames jamesin.hongkon...@gmail.com
Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix change type for EntityUpdate to include prefix - change (mediawiki...Wikibase[master])

2012-11-13 Thread Aude (Code Review)
Aude has uploaded a new change for review.

Change subject: fix change type for EntityUpdate to include prefix
..

fix change type for EntityUpdate to include prefix

Change-Id: I520e4ff6d4e7f4da9107994be5b88beaca17ce6d
---
M lib/includes/changes/EntityUpdate.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/97/33197/1
--
To view, visit https://gerrit.wikimedia.org/r/33197
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I520e4ff6d4e7f4da9107994be5b88beaca17ce6d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude aude.w...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Install syntax highlighting gem for Cucumber HTML reports - change (qa/browsertests[master])

2012-11-13 Thread Cmcmahon (Code Review)
Cmcmahon has submitted this change and it was merged.

Change subject: Install syntax highlighting gem for Cucumber HTML reports
..


Install syntax highlighting gem for Cucumber HTML reports

Change-Id: I07f148488aa0608c9e96f4098692c2f60b162f60
---
M Gemfile
M Gemfile.lock
2 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Cmcmahon: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33169
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07f148488aa0608c9e96f4098692c2f60b162f60
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org
Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix typos - change (qa/browsertests[master])

2012-11-13 Thread Cmcmahon (Code Review)
Cmcmahon has uploaded a new change for review.

Change subject: fix typos
..

fix typos

Change-Id: Ice52d091a45166bb92ea48db9453e1b54a6bbd72
---
M features/support/pages/aftv5_page.rb
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/98/33198/1
--
To view, visit https://gerrit.wikimedia.org/r/33198
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice52d091a45166bb92ea48db9453e1b54a6bbd72
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon cmcma...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix more typos - change (qa/browsertests[master])

2012-11-13 Thread Cmcmahon (Code Review)
Cmcmahon has uploaded a new change for review.

Change subject: fix more typos
..

fix more typos

Change-Id: Ie8ad58996b4893eaca8a87de1a948c440fddbc49
---
M features/support/pages/aftv5_page.rb
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/99/33199/1
--
To view, visit https://gerrit.wikimedia.org/r/33199
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8ad58996b4893eaca8a87de1a948c440fddbc49
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon cmcma...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix for ve.ce.BranchNode.setupSlugs - insert each slug only ... - change (mediawiki...VisualEditor[master])

2012-11-13 Thread Trevor Parscal (Code Review)
Trevor Parscal has submitted this change and it was merged.

Change subject: Fix for ve.ce.BranchNode.setupSlugs - insert each slug only once
..


Fix for ve.ce.BranchNode.setupSlugs - insert each slug only once

When using jQuery insertBefore and insertAfter make sure to pass as a parameter 
jQuery selection of only one element (first for insertBefore and last for 
insertAfter).

Change-Id: Id469ed775642ab5be8e274ab3cb7730899e9487a
---
M modules/ve/ce/ve.ce.BranchNode.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Trevor Parscal: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33151
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id469ed775642ab5be8e274ab3cb7730899e9487a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez i...@wikia-inc.com
Gerrit-Reviewer: Trevor Parscal tpars...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix change type for EntityUpdate to include prefix - change (mediawiki...Wikibase[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: fix change type for EntityUpdate to include prefix
..


fix change type for EntityUpdate to include prefix

Change-Id: I520e4ff6d4e7f4da9107994be5b88beaca17ce6d
---
M lib/includes/changes/EntityUpdate.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33197
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I520e4ff6d4e7f4da9107994be5b88beaca17ce6d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude aude.w...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] typo and change string to regex to avoid unparseable non-lat... - change (qa/browsertests[master])

2012-11-13 Thread Cmcmahon (Code Review)
Cmcmahon has uploaded a new change for review.

Change subject: typo and change string to regex to avoid unparseable non-latin 
character
..

typo and change string to regex to avoid unparseable non-latin character

Change-Id: I77b0726b7ccf181a0ee9ea64237a6865d023ea16
---
M features/support/pages/aftv5_page.rb
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/00/33200/1
--
To view, visit https://gerrit.wikimedia.org/r/33200
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I77b0726b7ccf181a0ee9ea64237a6865d023ea16
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon cmcma...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add nfs::netapp::thumbs for the new thumbs volume - change (operations/puppet[production])

2012-11-13 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: Add nfs::netapp::thumbs for the new thumbs volume
..

Add nfs::netapp::thumbs for the new thumbs volume

Change-Id: Ie7b58a42d008cf39eab2accddf42658fdcce1a18
---
M manifests/nfs.pp
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/01/33201/1
--
To view, visit https://gerrit.wikimedia.org/r/33201
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7b58a42d008cf39eab2accddf42658fdcce1a18
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon fai...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Unmount /mnt/thumbs - change (operations/puppet[production])

2012-11-13 Thread Faidon (Code Review)
Faidon has uploaded a new change for review.

Change subject: Unmount /mnt/thumbs
..

Unmount /mnt/thumbs

We've long stopped using ms5  /mnt/thumbs. Unmount it.

Change-Id: Ibc4d01426dbf7125c2a84afb7cc42633c8f191b1
---
M manifests/nfs.pp
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/02/33202/1
--
To view, visit https://gerrit.wikimedia.org/r/33202
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc4d01426dbf7125c2a84afb7cc42633c8f191b1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon fai...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add nfs::netapp::thumbs for the new thumbs volume - change (operations/puppet[production])

2012-11-13 Thread Faidon (Code Review)
Faidon has submitted this change and it was merged.

Change subject: Add nfs::netapp::thumbs for the new thumbs volume
..


Add nfs::netapp::thumbs for the new thumbs volume

Change-Id: Ie7b58a42d008cf39eab2accddf42658fdcce1a18
---
M manifests/nfs.pp
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Faidon: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/33201
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7b58a42d008cf39eab2accddf42658fdcce1a18
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon fai...@wikimedia.org
Gerrit-Reviewer: Faidon fai...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Adding editEntity to wikibase.Api - change (mediawiki...Wikibase[master])

2012-11-13 Thread Henning Snater (Code Review)
Henning Snater has uploaded a new change for review.

Change subject: Adding editEntity to wikibase.Api
..

Adding editEntity to wikibase.Api

Comes along with first API QUnit test.

Change-Id: I85f2c0b9fc17e32d0428e87f8458945fae2fea6c
---
M lib/WikibaseLib.hooks.php
M lib/resources/wikibase.store/wikibase.Api.js
A lib/tests/qunit/wikibase.store/wikibase.Api.tests.js
3 files changed, 99 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/03/33203/1
--
To view, visit https://gerrit.wikimedia.org/r/33203
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I85f2c0b9fc17e32d0428e87f8458945fae2fea6c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Updated release notes - change (mediawiki...Wikibase[master])

2012-11-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

Change subject: Updated release notes
..

Updated release notes

Change-Id: I39bfeac8c303221a5c02e3a1c5d5cecf947c68c8
---
M client/RELEASE-NOTES
M client/includes/ExternalChangesList.php
M lib/RELEASE-NOTES
M lib/includes/Term.php
M repo/RELEASE-NOTES
5 files changed, 34 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/04/33204/1
--
To view, visit https://gerrit.wikimedia.org/r/33204
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39bfeac8c303221a5c02e3a1c5d5cecf947c68c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Scenario: Navigate to UploadWizard - change (qa/browsertests[master])

2012-11-13 Thread Zfilipin (Code Review)
Zfilipin has uploaded a new change for review.

Change subject: Scenario: Navigate to UploadWizard
..

Scenario: Navigate to UploadWizard

Change-Id: I57d5fed2bf6c8f656f4a52acc3544fe9d2ee886a
Feature: UploadWizard
---
M features/step_definitions/uploadwizard_steps.rb
A features/support/pages/learn_page.rb
M features/support/pages/login_page.rb
M features/support/pages/upload_wizard_page.rb
M features/uploadwizard.feature
5 files changed, 58 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/05/33205/1
--
To view, visit https://gerrit.wikimedia.org/r/33205
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I57d5fed2bf6c8f656f4a52acc3544fe9d2ee886a
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Updated release notes - change (mediawiki...Wikibase[master])

2012-11-13 Thread Aude (Code Review)
Aude has submitted this change and it was merged.

Change subject: Updated release notes
..


Updated release notes

Change-Id: I39bfeac8c303221a5c02e3a1c5d5cecf947c68c8
---
M client/RELEASE-NOTES
M client/includes/ExternalChangesList.php
M lib/RELEASE-NOTES
M lib/includes/Term.php
M repo/RELEASE-NOTES
5 files changed, 34 insertions(+), 6 deletions(-)

Approvals:
  Aude: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33204
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39bfeac8c303221a5c02e3a1c5d5cecf947c68c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] make UW click the :categories element, not just check it exi... - change (qa/browsertests[master])

2012-11-13 Thread Cmcmahon (Code Review)
Cmcmahon has uploaded a new change for review.

Change subject: make UW click the :categories element, not just check it exists
..

make UW click the :categories element, not just check it exists

Change-Id: I1d98e112378d38c51f57a6ed6fe6a08caf52db2e
---
M features/step_definitions/uploadwizard_steps.rb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/06/33206/1
--
To view, visit https://gerrit.wikimedia.org/r/33206
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d98e112378d38c51f57a6ed6fe6a08caf52db2e
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon cmcma...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] page object and cuke steps for AFTv5 browser test - change (qa/browsertests[master])

2012-11-13 Thread Zfilipin (Code Review)
Zfilipin has submitted this change and it was merged.

Change subject: page object and cuke steps for AFTv5 browser test
..


page object and cuke steps for AFTv5 browser test

Change-Id: I8a88a23f8592975aab4c0de9f598d977133ff24e
---
A features/aftv5.feature
A features/support/pages/aftv5_page.rb
2 files changed, 34 insertions(+), 0 deletions(-)

Approvals:
  Zfilipin: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/32407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a88a23f8592975aab4c0de9f598d977133ff24e
Gerrit-PatchSet: 2
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon cmcma...@wikimedia.org
Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org
Gerrit-Reviewer: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix typos - change (qa/browsertests[master])

2012-11-13 Thread Zfilipin (Code Review)
Zfilipin has submitted this change and it was merged.

Change subject: fix typos
..


fix typos

Change-Id: Ice52d091a45166bb92ea48db9453e1b54a6bbd72
---
M features/support/pages/aftv5_page.rb
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Zfilipin: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33198
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ice52d091a45166bb92ea48db9453e1b54a6bbd72
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon cmcma...@wikimedia.org
Gerrit-Reviewer: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix more typos - change (qa/browsertests[master])

2012-11-13 Thread Zfilipin (Code Review)
Zfilipin has submitted this change and it was merged.

Change subject: fix more typos
..


fix more typos

Change-Id: Ie8ad58996b4893eaca8a87de1a948c440fddbc49
---
M features/support/pages/aftv5_page.rb
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Zfilipin: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/33199
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8ad58996b4893eaca8a87de1a948c440fddbc49
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon cmcma...@wikimedia.org
Gerrit-Reviewer: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add 'aeb' to LocalNamesEn.php - change (mediawiki...cldr[master])

2012-11-13 Thread Amire80 (Code Review)
Amire80 has uploaded a new change for review.

Change subject: Add 'aeb' to LocalNamesEn.php
..

Add 'aeb' to LocalNamesEn.php

Change-Id: I91a5125d40f0a5cb9206353599e802f92db104ab
---
M LocalNames/LocalNamesEn.php
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/cldr 
refs/changes/07/33207/1
--
To view, visit https://gerrit.wikimedia.org/r/33207
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91a5125d40f0a5cb9206353599e802f92db104ab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/cldr
Gerrit-Branch: master
Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


  1   2   3   >