[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: MetaContactPages: Temporarily de-require the trademark reque...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373339 )

Change subject: MetaContactPages: Temporarily de-require the trademark 
request's ProposedUse field
..

MetaContactPages: Temporarily de-require the trademark request's ProposedUse 
field

It doesn't work right now.

Bug: T173839
Change-Id: Idcd932bc544882121b2a07c76284a9d12f292f8a
---
M wmf-config/MetaContactPages.php
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/39/373339/1

diff --git a/wmf-config/MetaContactPages.php b/wmf-config/MetaContactPages.php
index 45af40b..5f25e28 100644
--- a/wmf-config/MetaContactPages.php
+++ b/wmf-config/MetaContactPages.php
@@ -145,7 +145,6 @@
'contactpage-license-request-use-tv' => 'tv',
],
'default' => 'online',
-   'required' => true,
],
 
'Description' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/373339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcd932bc544882121b2a07c76284a9d12f292f8a
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (94532edbf)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373166 )

Change subject: Update VE core submodule to master (94532edbf)
..

Update VE core submodule to master (94532edbf)

New changes:
1a726e3ed VisualDiff: Show internal list remove-inserts
94532edbf Update OOjs UI to v0.22.5

Bug: T171377
Change-Id: Ifced78dd25c218d671e1bb4d08ee7494ec0bf808
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/66/373166/1

diff --git a/lib/ve b/lib/ve
index 6111ca5..94532ed 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 6111ca575375b26620d87d616382f9cb6d492d80
+Subproject commit 94532edbf9c215beac5fa7ff65f198dfb7199a5e

-- 
To view, visit https://gerrit.wikimedia.org/r/373166
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifced78dd25c218d671e1bb4d08ee7494ec0bf808
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: EditPage: Remove temporary OOUI page class name

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373164 )

Change subject: EditPage: Remove temporary OOUI page class name
..

EditPage: Remove temporary OOUI page class name

Follow-up to I2b468c8b84, broken out for simplicity.

Change-Id: I16578dafafbcf7df909ceb89cd64d5b40a82
---
M includes/EditPage.php
M resources/Resources.php
D resources/src/mediawiki.action/mediawiki.action.edit.styles.css
A resources/src/mediawiki.action/mediawiki.action.edit.styles.less
4 files changed, 58 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/64/373164/1

diff --git a/includes/EditPage.php b/includes/EditPage.php
index 0e1438f..72a072d 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -2658,8 +2658,7 @@
$wgOut->addHTML( Html::openElement(
'form',
[
-   // Keep mw-editform-ooui class for 
backwards-compatibility temporarily
-   'class' => 'mw-editform mw-editform-ooui',
+   'class' => 'mw-editform',
'id' => self::EDITFORM_ID,
'name' => self::EDITFORM_ID,
'method' => 'post',
diff --git a/resources/Resources.php b/resources/Resources.php
index 4a7f3e4..004c13b 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1428,7 +1428,7 @@
],
'mediawiki.action.edit.styles' => [
'targets' => [ 'desktop', 'mobile' ],
-   'styles' => 
'resources/src/mediawiki.action/mediawiki.action.edit.styles.css',
+   'styles' => 
'resources/src/mediawiki.action/mediawiki.action.edit.styles.less',
],
'mediawiki.action.edit.collapsibleFooter' => [
'scripts' => 
'resources/src/mediawiki.action/mediawiki.action.edit.collapsibleFooter.js',
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.styles.css 
b/resources/src/mediawiki.action/mediawiki.action.edit.styles.css
deleted file mode 100644
index 7b6aaa8..000
--- a/resources/src/mediawiki.action/mediawiki.action.edit.styles.css
+++ /dev/null
@@ -1,57 +0,0 @@
-/*!
- * Styles for elements of the editing form.
- */
-
-/* General layout */
-#wpTextbox1 {
-   margin: 0;
-   display: block;
-   /* Ensure the textarea is not higher than browser's viewport on small 
screens */
-   max-height: 100vh;
-   /* But don't let it collapse into nothingness on really tiny screens */
-   min-height: 5em;
-}
-
-/*
- * Add a bit of margin space between the preview and the toolbar.
- * This replaces the ugly  we used to insert into the page source
- */
-#wikiPreview.ontop {
-   margin-bottom: 1em;
-}
-
-/* Adjustments to edit form elements */
-#editpage-copywarn {
-   font-size: 0.9em;
-}
-
-.mw-editform-ooui #wpSummaryWidget {
-   display: block;
-   margin-bottom: 1em;
-   max-width: none;
-}
-
-.mw-editform-ooui #editpage-copywarn {
-   line-height: 1.26;
-}
-
-.mw-editform-ooui #wpSummaryLabel {
-   margin: 0;
-}
-
-.mw-editform-ooui .editCheckboxes .oo-ui-fieldLayout {
-   margin-right: 1em;
-}
-
-.mw-editform-ooui .editHelp {
-   margin-left: 0.5em;
-   vertical-align: middle;
-}
-
-.mw-editform-ooui .editHelp a {
-   font-weight: bold;
-}
-
-.mw-editform-ooui .editOptions {
-   border-radius: 0 0 2px 2px;
-}
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.styles.less 
b/resources/src/mediawiki.action/mediawiki.action.edit.styles.less
new file mode 100644
index 000..dc6a366
--- /dev/null
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.styles.less
@@ -0,0 +1,56 @@
+/*!
+ * Styles for elements of the editing form.
+ */
+
+/*
+ * Add a bit of margin space between the preview and the toolbar.
+ * This replaces the ugly  we used to insert into the page source
+ */
+#wikiPreview.ontop {
+   margin-bottom: 1em;
+}
+
+.mw-editform {
+   /* General layout */
+   #wpTextbox1 {
+   margin: 0;
+   display: block;
+   /* Ensure the textarea is not higher than browser's viewport on 
small screens */
+   max-height: 100vh;
+   /* But don't let it collapse into nothingness on really tiny 
screens */
+   min-height: 5em;
+   }
+
+   /* Adjustments to edit form elements */
+   #editpage-copywarn {
+   font-size: 0.9em;
+   line-height: 1.26;
+   }
+
+   #wpSummaryWidget {
+   display: block;
+   margin-bottom: 1em;
+   max-width: none;
+   }
+
+   #wpSummaryLabel {
+   margin: 0;
+   }
+
+   .editCheckboxes .oo-ui-fieldLayout {
+   margin-right: 1em;
+   }
+
+   .editHelp {
+

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] icons: Remove 'wikitrail' icon, renamed in...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373162 )

Change subject: [BREAKING CHANGE] icons: Remove 'wikitrail' icon, renamed in 
v0.20.1
..

[BREAKING CHANGE] icons: Remove 'wikitrail' icon, renamed in v0.20.1

Change-Id: I7635187698046eda96405a1e11672687938d9b62
---
M src/themes/wikimediaui/icons-location.json
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/62/373162/1

diff --git a/src/themes/wikimediaui/icons-location.json 
b/src/themes/wikimediaui/icons-location.json
index 58feb23..b3da3cb 100644
--- a/src/themes/wikimediaui/icons-location.json
+++ b/src/themes/wikimediaui/icons-location.json
@@ -34,11 +34,6 @@
"mapTrail": { "file": {
"ltr": "images/icons/mapTrail-ltr.svg",
"rtl": "images/icons/mapTrail-rtl.svg"
-   } },
-   "wikitrail": { "file": {
-   "ltr": "images/icons/mapTrail-ltr.svg",
-   "rtl": "images/icons/mapTrail-rtl.svg"
-   }, "deprecated": "Renamed to 'mapTrail' since v0.20.1."
}
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/373162
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7635187698046eda96405a1e11672687938d9b62
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372906 )

Change subject: build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0
..

build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0

Change-Id: I06010cd6367c1884b5536e7929d3345feba7f305
---
M package.json
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
5 files changed, 8 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/06/372906/1

diff --git a/package.json b/package.json
index 8507238..96a425f 100644
--- a/package.json
+++ b/package.json
@@ -9,7 +9,7 @@
   "devDependencies": {
 "deepmerge": "1.3.2",
 "eslint": "3.12.2",
-"eslint-config-wikimedia": "0.4.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.6.0",
 "grunt-contrib-copy": "1.0.0",
diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
index c066a1f..81c8306 100644
--- 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
+++ 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
@@ -42,7 +42,7 @@
/**
 * Get an object representing the state of this item
 *
-* @returns {Object} Object representing the current data state
+* @return {Object} Object representing the current data state
 *  of the object
 */
mw.rcfilters.dm.SavedQueryItemModel.prototype.getState = function () {
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index c24e6c6..209e7c8 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -458,11 +458,9 @@
this.filtersModel.toggleInvertedNamespaces();
 
if (
-   this.filtersModel.getFiltersByView( 'namespaces' )
-   .filter( function ( filterItem ) {
-   return filterItem.isSelected();
-   } )
-   .length
+   this.filtersModel.getFiltersByView( 'namespaces' 
).filter(
+   function ( filterItem ) { return 
filterItem.isSelected(); }
+   ).length
) {
// Only re-fetch results if there are namespace items 
that are actually selected
this.updateChangesList();
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
index 70a2227..bb837e0 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
@@ -125,7 +125,7 @@
 * Respond to input keyup event, this is the way to intercept 'escape' 
key
 *
 * @param {jQuery.Event} e Event data
-* @returns {boolean} false
+* @return {boolean} false
 */
mw.rcfilters.ui.SaveFiltersPopupButtonWidget.prototype.onInputKeyup = 
function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
index cac1059..3655c16 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
@@ -212,7 +212,7 @@
 * Respond to input keyup event, this is the way to intercept 'escape' 
key
 *
 * @param {jQuery.Event} e Event data
-* @returns {boolean} false
+* @return {boolean} false
 */
mw.rcfilters.ui.SavedLinksListItemWidget.prototype.onInputKeyup = 
function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
@@ -307,7 +307,7 @@
/**
 * Get item ID
 *
-* @returns {string} Query identifier
+* @return {string} Query identifier
 */
mw.rcfilters.ui.SavedLinksListItemWidget.prototype.getID = function () {
return this.model.getID();

-- 
To view, visit https://gerrit.wikimedia.org/r/372906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Provide the WikimediaUI LESS config vars for all ...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372904 )

Change subject: resources: Provide the WikimediaUI LESS config vars for all 
OOjs UI users
..

resources: Provide the WikimediaUI LESS config vars for all OOjs UI users

Bug: T123359
Change-Id: I11677b9bacdbba9e17574891ca30428051b13606
---
M maintenance/resources/update-oojs-ui.sh
M resources/Resources.php
A resources/lib/oojs-ui/wikimedia-ui-base.less
3 files changed, 158 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/04/372904/1

diff --git a/maintenance/resources/update-oojs-ui.sh 
b/maintenance/resources/update-oojs-ui.sh
index bfa359f..799af4c 100755
--- a/maintenance/resources/update-oojs-ui.sh
+++ b/maintenance/resources/update-oojs-ui.sh
@@ -59,6 +59,7 @@
 cp ./node_modules/oojs-ui/src/themes/wikimediaui/*.json 
"$REPO_DIR/$TARGET_DIR/themes/wikimediaui"
 cp -R ./node_modules/oojs-ui/dist/themes/apex/images 
"$REPO_DIR/$TARGET_DIR/themes/apex"
 cp ./node_modules/oojs-ui/src/themes/apex/*.json 
"$REPO_DIR/$TARGET_DIR/themes/apex"
+cp ./node_modules/oojs-ui/dist/wikimedia-ui-base.less "$REPO_DIR/$TARGET_DIR"
 
 # Clean up temporary area
 rm -rf "$NPM_DIR"
diff --git a/resources/Resources.php b/resources/Resources.php
index 89eab94..d5b9702 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -2695,7 +2695,10 @@
// This contains only the styles required by core widgets.
'oojs-ui-core.styles' => [
'class' => 'ResourceLoaderOOUIFileModule',
-   'styles' => 'resources/src/oojs-ui-local.css', // HACK, see 
inside the file
+   'styles' => [
+   'resources/lib/wikimedia-ui-base.less' // Providing 
Wikimedia UI LESS variables to all
+   'resources/src/oojs-ui-local.css', // HACK, see inside 
the file
+   ],
'themeStyles' => 'core',
'targets' => [ 'desktop', 'mobile' ],
],
diff --git a/resources/lib/oojs-ui/wikimedia-ui-base.less 
b/resources/lib/oojs-ui/wikimedia-ui-base.less
new file mode 100644
index 000..d450dbc
--- /dev/null
+++ b/resources/lib/oojs-ui/wikimedia-ui-base.less
@@ -0,0 +1,153 @@
+/**
+ * WikimediaUI Base v0.9.2
+ * Wikimedia Foundation user interface base variables
+ */
+
+/* Colors */
+// WikimediaUI (WMUI) color palette
+@wmui-color-base0:#000;// = HSB 0°, 0%, 0%
+@wmui-color-base10:   #222;// = HSB 0°, 0%, 13%
+@wmui-color-base20:   #54595d; // = HSB 207°, 10%, 36%; WCAG 2.0 level AAA 
7.09:1 contrast ratio on `#fff`
+@wmui-color-base30:   #72777d; // = HSB 210°, 9%, 49%; WCAG 2.0 level AA at 
4.52:1 contrast ratio on `#fff`
+@wmui-color-base50:   #a2a9b1; // = HSB 212°, 8%, 69%
+@wmui-color-base70:   #c8ccd1; // = HSB 213°, 4%, 82%
+@wmui-color-base80:   #eaecf0; // = HSB 220°, 3%, 94%
+@wmui-color-base90:   #f8f9fa; // = HSB 210°, 1%, 98%
+@wmui-color-base100:  #fff;// = HSB 0°, 0%, 100%
+
+@wmui-color-accent30: #2a4b8d; // = HSB 220°, 70%, 55%
+@wmui-color-accent50: #36c;// = HSB 220°, 75%, 80%
+@wmui-color-accent90: #eaf3ff; // = HSB 214°, 8%, 100%
+
+@wmui-color-red30:#b32424; // = HSB 360°, 80%, 70%
+@wmui-color-red50:#d33;// = HSB 360°, 77%, 87%
+@wmui-color-red90:#fee7e6; // = HSB 3°, 9%, 100%
+
+@wmui-color-yellow30: #ac6600; // = HSB 36°, 100%, 67%
+@wmui-color-yellow50: #fc3;// = HSB 45°, 80%, 100%
+@wmui-color-yellow90: #fef6e7; // = HSB 39°, 9%, 100%
+
+@wmui-color-green30:  #14866d; // = HSB 167°, 85%, 53%
+@wmui-color-green50:  #00af89; // = HSB 167°, 100%, 69%
+@wmui-color-green90:  #d5fdf4; // = HSB 166°, 16%, 99%
+
+// Background Colors
+@background-color-base:   @wmui-color-base100;
+@background-color-code:   @wmui-color-base90;
+// 'Framed' UI elements (Framed Buttons, Dropdowns, ToggleSwitches...)
+@background-color-framed: @wmui-color-base90;
+@background-color-framed--hover: @wmui-color-base100;
+@background-color-framed--active: @wmui-color-base70;
+// Tabs Navigation Background Color
+@background-color-tabs:   @wmui-color-base80;
+// Highlight Colors, RGBA Colors include hex fallback on `#fff` for IE 6/7/8
+@background-color-highlight:  rgba( 255, 182, 13, 0.4 );
+@background-color-highlight--fallback: #ffe29e;
+
+// Foreground Colors
+@color-base:  @wmui-color-base10;
+@color-base--hover:   #444;
+@color-base--active:  @wmui-color-base0;
+@color-base--inverted:@wmui-color-base100;
+@color-base--emphasized:  @wmui-color-base0;
+@color-base--subtle:  @wmui-color-base30;
+@color-base--disabled:@wmui-color-base30;
+@color-filled--disabled:  @color-base--inverted;
+@color-placeholder:   @wmui-color-base30;
+// Primary 'Progressive' Color, Background Color and states
+@background-color-primary:@wmui-color-accent90;
+@background-color-primary--hover: rgba( 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (72cc043b7)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372842 )

Change subject: Update VE core submodule to master (72cc043b7)
..

Update VE core submodule to master (72cc043b7)

New changes:
c0ce8519c ce.GeneratedContentNode: helper for waiting for generation
fec19de11 Use version 0.5.0 of eslint-config-wikimedia
5716d2bb2 Localisation updates from https://translatewiki.net.
385d925ed Follow-up 5716d2bb2c: Add ko-kp to build to unbreak the repo

Bug: T168932
Change-Id: I50fcf1cb3f517b50dc373243dd876bc117030790
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/42/372842/1

diff --git a/lib/ve b/lib/ve
index 4314b9e..72cc043 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 4314b9ead058aec90a43b605787ca59bad96d322
+Subproject commit 72cc043b7a73f972ff777c00fbda071af404e573

-- 
To view, visit https://gerrit.wikimedia.org/r/372842
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50fcf1cb3f517b50dc373243dd876bc117030790
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (4314b9ead)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371655 )

Change subject: Update VE core submodule to master (4314b9ead)
..

Update VE core submodule to master (4314b9ead)

New changes:
4ff864094 VisualDiff: Merge old internal list into new document
4314b9ead ve.ce.BranchNode.css: Correct dated comment about styling

Bug: T173100
Change-Id: I68d95d0ce809481f45583eac5d9f4562826b2314
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/55/371655/1

diff --git a/lib/ve b/lib/ve
index 81a4760..4314b9e 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 81a4760ea38c793575afb1612f954e4efcb4f2dc
+Subproject commit 4314b9ead058aec90a43b605787ca59bad96d322

-- 
To view, visit https://gerrit.wikimedia.org/r/371655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68d95d0ce809481f45583eac5d9f4562826b2314
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable responsive reference columns on enwiki

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371630 )

Change subject: Enable responsive reference columns on enwiki
..

Enable responsive reference columns on enwiki

Bug: T173176
Change-Id: I604ba9a10132dda9583eec3477d9851c419d23fc
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/30/371630/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 2fd0ca6..da31d5c 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -14924,6 +14924,7 @@
'cawiki' => true, // T161307
'frwiki' => true, // T160609
'elwiki' => true, // T163074
+   'enwiki' => true, // T173176
'hewiki' => true, // T161804
'ilowiki' => true, // T164230
'itwiki' => true, // T160932

-- 
To view, visit https://gerrit.wikimedia.org/r/371630
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I604ba9a10132dda9583eec3477d9851c419d23fc
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.ce.BranchNode.css: Correct dated comment about styling

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371626 )

Change subject: ve.ce.BranchNode.css: Correct dated comment about styling
..

ve.ce.BranchNode.css: Correct dated comment about styling

Change-Id: I4758972d2c1a60888b56ee198692cac95c65af32
---
M src/ce/styles/nodes/ve.ce.BranchNode.css
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/26/371626/2

diff --git a/src/ce/styles/nodes/ve.ce.BranchNode.css 
b/src/ce/styles/nodes/ve.ce.BranchNode.css
index 754ed46..559ee3b 100644
--- a/src/ce/styles/nodes/ve.ce.BranchNode.css
+++ b/src/ce/styles/nodes/ve.ce.BranchNode.css
@@ -22,7 +22,7 @@
 .ve-ce-branchNode-newSlug {
margin: -0.3em 0 -0.1em 0;
outline: 1px dashed #ccc;
-   /* rgba( #f1f7fb, 0.5 ) */
+   /* rgba( #f1f7fb, 0.75 ) */
background-color: rgba( 241, 247, 251, 0.75 );
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371626
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4758972d2c1a60888b56ee198692cac95c65af32
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: extension.json: Depend on MediaWiki 1.30+, not 1.29+

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371476 )

Change subject: extension.json: Depend on MediaWiki 1.30+, not 1.29+
..

extension.json: Depend on MediaWiki 1.30+, not 1.29+

We're using newer versions of OOjs UI than 1.29 provide.

Change-Id: I7691b231c7f139fccf5c35a06a21bb2826910d52
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/76/371476/1

diff --git a/extension.json b/extension.json
index 41984bb..18b9a49 100644
--- a/extension.json
+++ b/extension.json
@@ -21,7 +21,7 @@
"license-name": "MIT",
"type": "other",
"requires": {
-   "MediaWiki": ">= 1.29.0"
+   "MediaWiki": ">= 1.30.0"
},
"callback": "VisualEditorHooks::onRegistration",
"config": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7691b231c7f139fccf5c35a06a21bb2826910d52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (81a4760ea)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371128 )

Change subject: Update VE core submodule to master (81a4760ea)
..

Update VE core submodule to master (81a4760ea)

New changes:
e100628de build: Ignore package-lock.json for fewer surprising npm outcomes
3764b2c60 Localisation updates from https://translatewiki.net.
c62271fbd Localisation updates from https://translatewiki.net.
8517f4c0a Localisation updates from https://translatewiki.net.
0ca19ca2c Localisation updates from https://translatewiki.net.
79cfd3119 Follow-up 0ca19ca2c6: Add skr-arab to build to unbreak the repo
81a4760ea VisualDiff: Refactor for historical diffs

Bug: T170269
Change-Id: I4ed78533be41317e12cd1d94af902323475af68b
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/28/371128/1

diff --git a/lib/ve b/lib/ve
index 18ae400..81a4760 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 18ae4004fc776e102f90d2e7c078f8bcd98a410a
+Subproject commit 81a4760ea38c793575afb1612f954e4efcb4f2dc

-- 
To view, visit https://gerrit.wikimedia.org/r/371128
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ed78533be41317e12cd1d94af902323475af68b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Follow-up 0ca19ca2c6: Add skr-arab to build to unbreak the repo

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371112 )

Change subject: Follow-up 0ca19ca2c6: Add skr-arab to build to unbreak the repo
..

Follow-up 0ca19ca2c6: Add skr-arab to build to unbreak the repo

Change-Id: I612da2ca1fbcbe8e294781b1846f52c3ccdc31d7
---
M .jsduck/eg-iframe.html
M demos/ve/desktop-dist.html
M demos/ve/desktop.html
M demos/ve/mobile-dist.html
M demos/ve/mobile.html
5 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/12/371112/1

diff --git a/.jsduck/eg-iframe.html b/.jsduck/eg-iframe.html
index bdb5658..99dc9a5 100644
--- a/.jsduck/eg-iframe.html
+++ b/.jsduck/eg-iframe.html
@@ -67,7 +67,7 @@
 

ve.messagePaths = ["../i18n/","../lib/oojs-ui/i18n/"];
-   ve.availableLanguages = 
["ace","af","am","ang","ar","arc","arq","as","ast","av","az","azb","ba","bcc","bcl","be-tarask","be","bg","bho","bn","bqi","br","bs","ca","cdo","ce","cjy-hant","ckb","co","cs","cu","cy","da","de","diq","dsb","dty","egl","el","eml","en-ca","en-gb","en","eo","es","et","eu","fa","fi","fo","fr","frp","frr","fur","fy","ga","gd","gl","glk","gn","gom-latn","gor","gsw","gu","gv","he","hi","hr","hrx","hsb","hu-formal","hu","hy","ia","id","ie","ilo","inh","io","is","it","ja","jv","ka","khw","kk-cyrl","km","kn","ko","krc","kri","krl","ksh","ku-latn","kw","ky","la","lb","lez","li","lki","lmo","lrc","lt","luz","lv","lzh","lzz","mg","min","mk","ml","mn","mr","ms","mt","nan","nap","nb","nds-nl","nds","ne","nl","nn","oc","olo","om","or","os","pa","pam","pfl","pl","pms","ps","pt-br","pt","qqq","qu","rm","ro","roa-tara","ru","rue","sa","sah","sc","scn","sco","sd","sgs","sh","shn","si","sk","sl","sq","sr-ec","sr-el","su","sv","sw","ta","te","tg-cyrl","th","tl","tr","tt-cyrl","tyv","tzm","ug-arab","uk","ur","uz","vec","vep","vi","vo","war","wuu","xmf","yi","yue","zh-hans","zh-hant","ace","af","am","ar","arc","arq","as","ast","awa","az","azb","ba","bcc","bcl","be-tarask","be","bg","bho","bn","bqi","br","bs","ca","cdo","ce","ckb","co","crh-cyrl","crh-latn","cs","cu","cy","da","de","diq","dsb","dty","egl","el","eml","en-ca","en","eo","es","et","eu","fa","fi","fo","fr","frr","fur","fy","gd","gl","glk","gom-latn","gor","gu","he","hi","hif-latn","hr","hrx","hsb","hu-formal","hu","hy","ia","id","ie","ilo","inh","io","is","it","ja","jv","ka","khw","kk-cyrl","km","kn","ko","krc","krl","ksh","ku-latn","kw","ky","la","lb","li","lki","lmo","lt","luz","lv","lzh","mg","min","mk","ml","mn","mr","ms","nan","nap","nb","nds-nl","nds","ne","nl","nn","oc","olo","om","or","pa","pfl","pl","pms","pnb","ps","pt-br","pt","qqq","qu","ro","roa-tara","ru","sa","sah","scn","sco","sd","sh","shn","si","sk","sl","sq","sr-ec","sr-el","su","sv","sw","ta","te","tg-cyrl","th","tl","tr","tt-cyrl","ug-arab","uk","ur","uz","vec","vep","vi","vo","war","wuu","xmf","yi","yo","yue","zh-hans","zh-hant"];
+   ve.availableLanguages = 

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: Fix "JQMIGRATE: jQuery.fn.load() is deprecated"

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371065 )

Change subject: Fix "JQMIGRATE: jQuery.fn.load() is deprecated"
..

Fix "JQMIGRATE: jQuery.fn.load() is deprecated"

Bug: T169388
Change-Id: Ib088fd64f23ac03266800de850701e0eb316fd03
---
M modules/external/jquery.waypoints.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage 
refs/changes/65/371065/1

diff --git a/modules/external/jquery.waypoints.js 
b/modules/external/jquery.waypoints.js
index 0f69a33..11a3cf0 100644
--- a/modules/external/jquery.waypoints.js
+++ b/modules/external/jquery.waypoints.js
@@ -175,7 +175,7 @@
}
}, this));
 
-   $w.load($.proxy(function() {
+   $w.on( "load", $.proxy(function() {
/*
Fire a scroll check, should the page be loaded at a 
non-zero scroll value,
as with a fragment id link or a page refresh.
@@ -659,7 +659,7 @@
scrollThrottle: 100
};
 
-   $w.load(function() {
+   $w.on( "load", function() {
// Calculate everything once on load.
$[wps]('refresh');
});

-- 
To view, visit https://gerrit.wikimedia.org/r/371065
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib088fd64f23ac03266800de850701e0eb316fd03
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikiLove[master]: Fix "JQMIGRATE: jQuery.fn.unbind() is deprecated" in WikiLove

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371037 )

Change subject: Fix "JQMIGRATE: jQuery.fn.unbind() is deprecated" in WikiLove
..

Fix "JQMIGRATE: jQuery.fn.unbind() is deprecated" in WikiLove

Replaced method in jQuery 3.

Bug: T169387
Change-Id: Ic456700c3e685aa67727f38e5002318da4ade52a
---
M resources/ext.wikiLove.core.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLove 
refs/changes/37/371037/1

diff --git a/resources/ext.wikiLove.core.js b/resources/ext.wikiLove.core.js
index 1dfa64b..7b1f1b2 100644
--- a/resources/ext.wikiLove.core.js
+++ b/resources/ext.wikiLove.core.js
@@ -835,7 +835,7 @@
} else { // legacy skins
$wikiLoveLink = $( '#topbar a:contains(' + mw.msg( 
'wikilove-tab-text' ) + ')' );
}
-   $wikiLoveLink.unbind( 'click' );
+   $wikiLoveLink.off( 'click' );
$wikiLoveLink.click( function ( e ) {
e.preventDefault();
$.wikiLove.openDialog();

-- 
To view, visit https://gerrit.wikimedia.org/r/371037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic456700c3e685aa67727f38e5002318da4ade52a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiLove
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: [WIP] VisualDiffs: Describe simple template changes

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370864 )

Change subject: [WIP] VisualDiffs: Describe simple template changes
..

[WIP] VisualDiffs: Describe simple template changes

Change-Id: I9f478d2b63193e41b2545df29569fb7649403f95
---
M modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js
M modules/ve-mw/i18n/en.json
2 files changed, 51 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/64/370864/1

diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js 
b/modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js
index 0d757c3..e18920d 100644
--- a/modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js
+++ b/modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js
@@ -210,8 +210,52 @@
return els;
 };
 
-ve.dm.MWTransclusionNode.static.describeChanges = function () {
-   // TODO: Provide a more detailed description of template changes
+ve.dm.MWTransclusionNode.static.describeChange = function ( key, change ) {
+   var field, oldFields, newFields, oldValue, newValue, introducedFields,
+   messages = [];
+
+   if (
+   key === 'mw' &&
+   // Skip multi-part transclusions
+   change.from.parts.length === 1 &&
+   change.to.parts.length === 1
+   ) {
+   oldFields = change.from.parts[ 0 ].params.getKeys();
+   newFields = change.to.parts[ 0 ].params.getKeys();
+
+   for ( field in oldFields ) {
+   if ( !oldFields.hasOwnProperty( field ) ) {
+   continue;
+   }
+
+   if ( newFields.indexOf( field ) === -1 ) {
+   messages.push( ve.msg( 
'visualeditor-changedesc-mwtransclusion-removedfield', field ) );
+   } else {
+   oldValue = change.from.parts[ 0 ].params[ field 
].wt;
+   newValue = change.to.parts[ 0 ].params[ field 
].wt;
+
+   if ( oldValue !== newValue ) {
+   messages.push( ve.msg( 
'visualeditor-changedesc-mwtransclusion-changedfield', field, oldValue, 
newValue ) );
+   }
+   }
+   }
+
+   introducedFields = newFields.filter( function ( item ) { return 
oldFields.indexOf( item ) === -1; } );
+
+   for ( field in introducedFields ) {
+   if ( !introducedFields.hasOwnProperty( field ) ) {
+   continue;
+   }
+
+   newValue = change.to.parts[ 0 ].params[ field ].wt;
+
+   messages.push( ve.msg( 
'visualeditor-changedesc-mwtransclusion-newfield', field, newValue ) );
+   }
+
+   return messages;
+   }
+
+   // Fallback if we don't know anything more
return [ ve.msg( 'visualeditor-changedesc-mwtransclusion' ) ];
 };
 
diff --git a/modules/ve-mw/i18n/en.json b/modules/ve-mw/i18n/en.json
index f6ae9f4..e777314 100644
--- a/modules/ve-mw/i18n/en.json
+++ b/modules/ve-mw/i18n/en.json
@@ -81,7 +81,11 @@
"visualeditor-ca-ve-edit-section": "VisualEditor",
"visualeditor-categories-tool": "Categories",
"visualeditor-changedesc-mwlanguagevariant": "Language variant markup 
changed",
-   "visualeditor-changedesc-mwtransclusion": "Template parameters changed",
+   "visualeditor-changedesc-mwtransclusion": "Template changed",
+   "visualeditor-changedesc-mwtransclusion-changedfield": "Field \"$1\" 
changed value from \"$2\" to \"$3\".",
+   "visualeditor-changedesc-mwtransclusion-newfield": "Field \"$1\" added 
with value \"$2\".",
+   "visualeditor-changedesc-mwtransclusion-removedfield": "Field \"$1\" 
removed.",
+   "visualeditor-changedesc-mwtransclusion-reordered": "Template syntax 
re-ordered.",
"visualeditor-desc": "Visual editor for MediaWiki",
"visualeditor-descriptionpagelink": "Project:VisualEditor",
"visualeditor-dialog-media-alttext-section": "Alternative text",

-- 
To view, visit https://gerrit.wikimedia.org/r/370864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f478d2b63193e41b2545df29569fb7649403f95
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: build: Upgrade devDependencies to latest and make pass

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370299 )

Change subject: build: Upgrade devDependencies to latest and make pass
..

build: Upgrade devDependencies to latest and make pass

 grunt-contrib-clean  1.0.0  →   1.1.0
 grunt-contrib-cssmin 2.0.0  →   2.2.1
 grunt-contrib-uglify 2.2.0  →   3.0.1
 grunt-eslint19.0.0  →  20.0.0
 grunt-exec   1.0.1  →   3.0.0
 karma1.1.1  →   1.7.0
 karma-chrome-launcher1.0.1  →   2.2.0
 karma-coverage   1.1.0  →   1.1.1
 karma-firefox-launcher   1.0.0  →   1.0.1
 karma-qunit  1.1.0  →   1.2.1
 q1.4.1  →   1.5.0
 qunitjs 1.22.0  →   2.4.0

Held back grunt-image (2.x doesn't work on Macs) and stylelint (Wikimedia
config preset needs updating to be compatible with 8.x first).

Change-Id: I736ff8215dc0329319a90c3883e857ccf663ec64
---
M package.json
M src/Tool.js
M src/mixins/IconElement.js
M src/mixins/IndicatorElement.js
M src/widgets/MenuSelectWidget.js
M src/widgets/SelectWidget.js
M src/widgets/TagMultiselectWidget.js
7 files changed, 23 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/99/370299/1

diff --git a/package.json b/package.json
index a6a2365..7c8947f 100644
--- a/package.json
+++ b/package.json
@@ -31,16 +31,16 @@
 "eslint-config-wikimedia": "0.4.0",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.6.0",
-"grunt-contrib-clean": "1.0.0",
+"grunt-contrib-clean": "1.1.0",
 "grunt-contrib-concat": "1.0.1",
 "grunt-contrib-copy": "1.0.0",
-"grunt-contrib-cssmin": "2.0.0",
+"grunt-contrib-cssmin": "2.2.1",
 "grunt-contrib-less": "1.4.1",
-"grunt-contrib-uglify": "2.2.0",
+"grunt-contrib-uglify": "3.0.1",
 "grunt-contrib-watch": "1.0.0",
 "grunt-cssjanus": "0.4.0",
-"grunt-eslint": "19.0.0",
-"grunt-exec": "1.0.1",
+"grunt-eslint": "20.0.0",
+"grunt-exec": "3.0.0",
 "grunt-file-exists": "0.1.4",
 "grunt-image": "1.5.2",
 "grunt-jsonlint": "1.1.0",
@@ -51,15 +51,15 @@
 "grunt-svg2png": 
"git://github.com/jdforrester/grunt-svg2png.git#v0.2.7-wmf.1",
 "grunt-tyops": "0.1.0",
 "javascript-stringify": "1.6.0",
-"karma": "1.1.1",
-"karma-chrome-launcher": "1.0.1",
-"karma-coverage": "1.1.0",
-"karma-firefox-launcher": "1.0.0",
-"karma-qunit": "1.1.0",
+"karma": "1.7.0",
+"karma-chrome-launcher": "2.2.0",
+"karma-coverage": "1.1.1",
+"karma-firefox-launcher": "1.0.1",
+"karma-qunit": "1.2.1",
 "karma-remap-istanbul": "0.6.0",
 "prismjs": "1.6.0",
-"q": "1.4.1",
-"qunitjs": "1.22.0",
+"q": "1.5.0",
+"qunitjs": "2.4.0",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }
diff --git a/src/Tool.js b/src/Tool.js
index d1319d3..ab9af2f 100644
--- a/src/Tool.js
+++ b/src/Tool.js
@@ -84,7 +84,7 @@
this.$element
.data( 'oo-ui-tool', this )
.addClass( 'oo-ui-tool' )
-   .addClass( 'oo-ui-tool-name-' + 
this.constructor.static.name.replace( /^([^\/]+)\/([^\/]+).*$/, '$1-$2' ) )
+   .addClass( 'oo-ui-tool-name-' + 
this.constructor.static.name.replace( /^([^/]+)\/([^/]+).*$/, '$1-$2' ) )
.toggleClass( 'oo-ui-tool-with-label', 
this.constructor.static.displayBothIconAndLabel )
.append( this.$link );
this.setTitle( config.title || this.constructor.static.title );
diff --git a/src/mixins/IconElement.js b/src/mixins/IconElement.js
index 85e7f59..c969de9 100644
--- a/src/mixins/IconElement.js
+++ b/src/mixins/IconElement.js
@@ -152,8 +152,8 @@
  * @chainable
  */
 OO.ui.mixin.IconElement.prototype.setIconTitle = function ( iconTitle ) {
-   iconTitle = typeof iconTitle === 'function' ||
-   ( typeof iconTitle === 'string' && iconTitle.length ) ?
+   iconTitle =
+   ( typeof iconTitle === 'function' || ( typeof iconTitle === 
'string' && iconTitle.length ) ) ?
OO.ui.resolveMsg( iconTitle ) : null;
 
if ( this.iconTitle !== iconTitle ) {
diff --git a/src/mixins/IndicatorElement.js b/src/mixins/IndicatorElement.js
index 953584d..9fd2bcf 100644
--- a/src/mixins/IndicatorElement.js
+++ b/src/mixins/IndicatorElement.js
@@ -131,8 +131,8 @@
  * @chainable
  */
 OO.ui.mixin.IndicatorElement.prototype.setIndicatorTitle = function ( 
indicatorTitle ) {
-   indicatorTitle = typeof indicatorTitle === 'function' ||
-   ( typeof indicatorTitle === 'string' && indicatorTitle.length ) 
?
+   indicatorTitle =
+   ( typeof indicatorTitle === 'function' || ( typeof 
indicatorTitle === 'string' && indicatorTitle.length ) ) ?
OO.ui.resolveMsg( indicatorTitle ) : null;
 
if ( this.indicatorTitle !== indicatorTitle ) {
diff --git 

[MediaWiki-commits] [Gerrit] oojs/ui[master]: tests: Prepare for qunit 2.x

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370287 )

Change subject: tests: Prepare for qunit 2.x
..

tests: Prepare for qunit 2.x

Change-Id: I60c6f267bc95563a40a2fa14db6f53aa84dcc5d4
---
M tests/Element.test.js
M tests/JSPHP.test.karma.js
M tests/JSPHP.test.standalone.js
M tests/QUnit.assert.equalDomElement.js
M tests/core.test.js
M tests/widgets/NumberInputWidget.test.js
6 files changed, 18 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/87/370287/1

diff --git a/tests/Element.test.js b/tests/Element.test.js
index 723781e..c5be298 100644
--- a/tests/Element.test.js
+++ b/tests/Element.test.js
@@ -1,5 +1,5 @@
 QUnit.module( 'Element', {
-   setup: function () {
+   beforeEach: function () {
this.fixture = document.createElement( 'div' );
document.body.appendChild( this.fixture );
 
@@ -9,7 +9,7 @@
return ( frame.contentWindow && 
frame.contentWindow.document ) || frame.contentDocument;
};
},
-   teardown: function () {
+   afterEach: function () {
this.fixture.parentNode.removeChild( this.fixture );
this.fixture = null;
}
diff --git a/tests/JSPHP.test.karma.js b/tests/JSPHP.test.karma.js
index 0d5e75b..c0d3e33 100644
--- a/tests/JSPHP.test.karma.js
+++ b/tests/JSPHP.test.karma.js
@@ -18,8 +18,11 @@
}
 
function makeTest( theme, klassName, infuseOnly, tests, output ) {
-   QUnit.test( theme + ': ' + klassName, tests.length * ( 
infuseOnly ? 1 : 2 ), function ( assert ) {
+   QUnit.test( theme + ': ' + klassName, function ( assert ) {
var test, config, instance, infused, $fromPhp, i, 
testName;
+
+   assert.expect( tests.length * ( infuseOnly ? 1 : 2 ) );
+
OO.ui.theme = themes[ theme ];
for ( i = 0; i < tests.length; i++ ) {
test = tests[ i ];
diff --git a/tests/JSPHP.test.standalone.js b/tests/JSPHP.test.standalone.js
index 20b926f..66fe8ed 100644
--- a/tests/JSPHP.test.standalone.js
+++ b/tests/JSPHP.test.standalone.js
@@ -18,8 +18,11 @@
}
 
function makeTest( theme, klassName, infuseOnly, tests ) {
-   QUnit.test( theme + ': ' + klassName, tests.length * ( 
infuseOnly ? 1 : 2 ), function ( assert ) {
+   QUnit.test( theme + ': ' + klassName, function ( assert ) {
var test, config, instance, infused, id, fromPhp, i, 
testName;
+
+   assert.expect( tests.length * ( infuseOnly ? 1 : 2 ) );
+
OO.ui.theme = themes[ theme ];
for ( i = 0; i < tests.length; i++ ) {
test = tests[ i ];
diff --git a/tests/QUnit.assert.equalDomElement.js 
b/tests/QUnit.assert.equalDomElement.js
index 7a86a6b..3caa15f 100644
--- a/tests/QUnit.assert.equalDomElement.js
+++ b/tests/QUnit.assert.equalDomElement.js
@@ -162,7 +162,7 @@
actualSummaryHtml = JSON.stringify( actualSummaryHtml, null, 2 
);
expectedSummaryHtml = JSON.stringify( expectedSummaryHtml, 
null, 2 );
 
-   QUnit.push(
+   this.pushResult(
QUnit.equiv( actualSummary, expectedSummary ), 
actualSummaryHtml, expectedSummaryHtml, message
);
};
diff --git a/tests/core.test.js b/tests/core.test.js
index 8624a72..a758e65 100644
--- a/tests/core.test.js
+++ b/tests/core.test.js
@@ -85,7 +85,7 @@
}
];
 
-   QUnit.expect( cases.length );
+   assert.expect( cases.length );
for ( i = 0; i < cases.length; i++ ) {
$html = $( cases[ i ].html ).appendTo( 'body' );
result = OO.ui.isFocusableElement( cases[ i ].selector ? 
$html.find( cases[ i ].selector ) : $html );
diff --git a/tests/widgets/NumberInputWidget.test.js 
b/tests/widgets/NumberInputWidget.test.js
index 21abf64..b05b733 100644
--- a/tests/widgets/NumberInputWidget.test.js
+++ b/tests/widgets/NumberInputWidget.test.js
@@ -1,7 +1,7 @@
 ( function () {
QUnit.module( 'NumberInputWidget' );
 
-   QUnit.test( 'validate number', 7, function ( assert ) {
+   QUnit.test( 'validate number', function ( assert ) {
var widget = new OO.ui.NumberInputWidget( {
allowInteger: true,
min: -10,
@@ -9,6 +9,8 @@
step: 1,
required: false
} );
+
+   assert.expect( 7 );
 
assert.ok(
widget.validateNumber( 0 ),
@@ -44,7 +46,7 @@
);
} );
 
-   QUnit.test( 'adjust value', 4, function ( assert ) {
+   QUnit.test( 'adjust 

[MediaWiki-commits] [Gerrit] mediawiki...PronunciationRecording[master]: build: Replace jshint/jscs with eslint and csslint with styl...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370118 )

Change subject: build: Replace jshint/jscs with eslint and csslint with 
stylelint
..

build: Replace jshint/jscs with eslint and csslint with stylelint

Also upgrade banana and jsonlint to latest.

Change-Id: Ief51508b119300abc64a42260ccb72505e4b52dd
---
A .eslintrc.json
A .stylelintrc
M Gruntfile.js
M package.json
M resources/ext.pronunciationRecording.pronunciationRecorder.js
M resources/ext.pronunciationRecording.specialPage.js
6 files changed, 63 insertions(+), 49 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PronunciationRecording 
refs/changes/18/370118/1

diff --git a/.eslintrc.json b/.eslintrc.json
new file mode 100644
index 000..b8371ee
--- /dev/null
+++ b/.eslintrc.json
@@ -0,0 +1,13 @@
+{
+   "extends": "wikimedia",
+   "env": {
+   "browser": true,
+   "jquery": true,
+   "qunit": true
+   },
+   "globals": {
+   "mediaWiki": false,
+   "Recorder": false
+   },
+   "rules": {}
+}
diff --git a/.stylelintrc b/.stylelintrc
new file mode 100644
index 000..0fc57dc
--- /dev/null
+++ b/.stylelintrc
@@ -0,0 +1,3 @@
+{
+"extends": "stylelint-config-wikimedia"
+}
diff --git a/Gruntfile.js b/Gruntfile.js
index 362c2f7..1246162 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -4,49 +4,45 @@
  * @package PronunciationRecording
  */
 
-/*jshint node:true */
+/* eslint-env node, es6 */
 module.exports = function ( grunt ) {
grunt.loadNpmTasks( 'grunt-banana-checker' );
-   grunt.loadNpmTasks( 'grunt-contrib-csslint' );
-   grunt.loadNpmTasks( 'grunt-contrib-jshint' );
grunt.loadNpmTasks( 'grunt-contrib-watch' );
-   grunt.loadNpmTasks( 'grunt-jscs' );
+   grunt.loadNpmTasks( 'grunt-eslint' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
+   grunt.loadNpmTasks( 'grunt-stylelint' );
 
grunt.initConfig( {
-   jshint: {
-   options: {
-   jshintrc: true
-   },
+   eslint: {
all: [
'*.js',
'resources/**/*.js',
'!resources/mediawiki.libs.recorderjs/*'
]
},
-   jscs: {
-   src: '<%= jshint.all %>'
-   },
-   csslint: {
+   stylelint: {
src: 'resources/**/*.css'
-   },
-   jsonlint: {
-   all: 'i18n/*.json'
},
banana: {
all: 'i18n/'
},
+   jsonlint: {
+   all: [
+   '*.json',
+   '.stylelintrc',
+   'i18n/*.json'
+   ]
+   },
watch: {
files: [
-   '.{jshintignore,jshintrc,jscsrc,csslintrc}',
-   '<%= jshint.all %>',
-   '<%= csslint.all %>',
-   '<%= jsonlint.all %>'
+   '.{stylelintrc,eslintrc.json}',
+   '<%= eslint.all %>',
+   '<%= stylelint.all %>'
],
tasks: 'test'
}
} );
 
-   grunt.registerTask( 'test', [ 'jshint', 'jscs', 'csslint', 'jsonlint', 
'banana' ] );
+   grunt.registerTask( 'test', [ 'eslint', 'stylelint', 'jsonlint', 
'banana' ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/package.json b/package.json
index e77148c..c7757c7 100644
--- a/package.json
+++ b/package.json
@@ -1,22 +1,24 @@
 {
-  "name": "PronunciationRecording",
-  "version": "0.0.0",
-  "private": true,
-  "description": "Build tools for PronunciationRecording.",
-  "scripts": {
-"test": "grunt test"
-  },
-  "repository": {
-"type": "git",
-"url": 
"https://gerrit.wikimedia.org/r/p/mediawiki/extensions/PronunciationRecording.git;
-  },
-  "devDependencies": {
-"grunt": "1.0.1",
-"grunt-banana-checker": "0.4.0",
-"grunt-contrib-csslint": "0.5.0",
-"grunt-contrib-jshint": "0.11.3",
-"grunt-contrib-watch": "1.0.0",
-"grunt-jscs": "2.1.0",
-"grunt-jsonlint": "1.0.7"
-  }
+   "name": "PronunciationRecording",
+   "version": "0.0.0",
+   "private": true,
+   "description": "Build tools for the PronunciationRecording extension.",
+   "scripts": {
+   "test": "grunt test"
+   },
+   "repository": {
+   "type": "git",
+   "url": 

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[master]: build: Replace jshint and jscs with eslint; drop csslint

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370114 )

Change subject: build: Replace jshint and jscs with eslint; drop csslint
..

build: Replace jshint and jscs with eslint; drop csslint

Removing csslint rather than replacing it with stylelint as there
are no CSS or LESS files in this repo.

Also bumping banana and jsonlint to latest.

Change-Id: I9ffce273f63b061e07c3fa90ab4e82b5e551aa92
---
A .eslintrc.json
M Gruntfile.js
M modules/ext.thanks.flowthank.js
M modules/ext.thanks.mobilediff.js
M modules/ext.thanks.revthank.js
M modules/ext.thanks.thank.js
M package.json
M tests/qunit/test_ext.thanks.mobilediff.js
8 files changed, 110 insertions(+), 106 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Thanks 
refs/changes/14/370114/1

diff --git a/.eslintrc.json b/.eslintrc.json
new file mode 100644
index 000..31380ab
--- /dev/null
+++ b/.eslintrc.json
@@ -0,0 +1,13 @@
+{
+   "extends": "wikimedia",
+   "env": {
+   "browser": true,
+   "jquery": true,
+   "qunit": true
+   },
+   "globals": {
+   "mediaWiki": false,
+   "OO": false
+   },
+   "rules": {}
+}
diff --git a/Gruntfile.js b/Gruntfile.js
index 0f76c86..7695dc6 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,58 +1,43 @@
 /*!
  * Grunt file
  *
- * @package Flow
+ * @package Thanks
  */
 
-/*jshint node:true */
+/* eslint-env node, es6 */
 module.exports = function ( grunt ) {
-   grunt.loadNpmTasks( 'grunt-contrib-csslint' );
-   grunt.loadNpmTasks( 'grunt-contrib-jshint' );
-   grunt.loadNpmTasks( 'grunt-contrib-watch' );
-   grunt.loadNpmTasks( 'grunt-jsonlint' );
+
grunt.loadNpmTasks( 'grunt-banana-checker' );
-   grunt.loadNpmTasks( 'grunt-jscs' );
+   grunt.loadNpmTasks( 'grunt-contrib-watch' );
+   grunt.loadNpmTasks( 'grunt-eslint' );
+   grunt.loadNpmTasks( 'grunt-jsonlint' );
 
grunt.initConfig( {
-   jshint: {
-   options: {
-   jshintrc: true
-   },
+   eslint: {
all: [
'*.js',
'modules/**/*.js',
'tests/qunit/**/*.js'
]
},
-   jscs: {
-   src: '<%= jshint.all %>'
-   },
-   csslint: {
-   options: {
-   csslintrc: '.csslintrc'
-   },
-   all: 'modules/**/*.css'
-   },
banana: {
all: 'i18n/'
},
watch: {
files: [
-   '.{csslintrc,jscsrc,jshintignore,jshintrc}',
-   '<%= jshint.all %>',
-   '<%= csslint.all %>'
+   '.eslintrc.json',
+   '<%= eslint.all %>'
],
tasks: 'test'
},
jsonlint: {
all: [
-   '**/*.json',
-   '!node_modules/**'
+   '*.json',
+   'i18n/*.json'
]
}
} );
 
-   grunt.registerTask( 'lint', [ 'jscs', 'jshint', 'csslint', 'jsonlint', 
'banana' ] );
-   grunt.registerTask( 'test', 'lint' );
+   grunt.registerTask( 'test', [ 'eslint', 'jsonlint', 'banana' ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/modules/ext.thanks.flowthank.js b/modules/ext.thanks.flowthank.js
index bf2d203..64f8a0d 100644
--- a/modules/ext.thanks.flowthank.js
+++ b/modules/ext.thanks.flowthank.js
@@ -38,33 +38,33 @@
action: 'flowthank',
postid: $thankLink.closest( '.flow-post' ).attr( 
mw.thanks.thanked.attrName )
} )
-   .then(
-   // Success
-   function ( data ) {
-   var author = findPostAuthorFromThankLink( 
$thankLink );
-   // Get the user who was thanked (for gender 
purposes)
-   return mw.thanks.getUserGender( author );
-   },
-   // Failure
-   function ( errorCode, details ) {
-   switch ( errorCode ) {
-   case 'ratelimited':
-   OO.ui.alert( mw.msg( 
'thanks-error-ratelimited', mw.user ) );
-   break;
-

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: OOjs UI: Bring forward upstream fix for WikimediaUI colour i...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369994 )

Change subject: OOjs UI: Bring forward upstream fix for WikimediaUI colour issue
..

OOjs UI: Bring forward upstream fix for WikimediaUI colour issue

* 4412e21bef698d76ad73b98c33a177cf4b9e7466
  WikimediaUI theme: Fix regression on disabled border

Bug: T172402
Change-Id: Ibf1335313505af2abb9ba69314c427cffc79e266
---
M resources/lib/oojs-ui/oojs-ui-apex.js
M resources/lib/oojs-ui/oojs-ui-core-apex.css
M resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-core.js
M resources/lib/oojs-ui/oojs-ui-toolbars-apex.css
M resources/lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-toolbars.js
M resources/lib/oojs-ui/oojs-ui-widgets-apex.css
M resources/lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-widgets.js
M resources/lib/oojs-ui/oojs-ui-wikimediaui.js
M resources/lib/oojs-ui/oojs-ui-windows-apex.css
M resources/lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-windows.js
14 files changed, 30 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/94/369994/1

diff --git a/resources/lib/oojs-ui/oojs-ui-apex.js 
b/resources/lib/oojs-ui/oojs-ui-apex.js
index 0253ff5..717df5d 100644
--- a/resources/lib/oojs-ui/oojs-ui-apex.js
+++ b/resources/lib/oojs-ui/oojs-ui-apex.js
@@ -6,7 +6,7 @@
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2017-08-01T23:45:14Z
+ * Date: 2017-08-03T19:36:51Z
  */
 ( function ( OO ) {
 
diff --git a/resources/lib/oojs-ui/oojs-ui-core-apex.css 
b/resources/lib/oojs-ui/oojs-ui-core-apex.css
index 5a49a2d..718ae20 100644
--- a/resources/lib/oojs-ui/oojs-ui-core-apex.css
+++ b/resources/lib/oojs-ui/oojs-ui-core-apex.css
@@ -6,7 +6,7 @@
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2017-08-01T20:24:44Z
+ * Date: 2017-08-03T19:36:56Z
  */
 .oo-ui-element-hidden {
   display: none !important;
diff --git a/resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css 
b/resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css
index d7b1429..551dda9 100644
--- a/resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css
+++ b/resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css
@@ -6,7 +6,7 @@
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2017-08-01T20:24:44Z
+ * Date: 2017-08-03T19:36:56Z
  */
 /**
  * WikimediaUI Base v0.9.2
@@ -297,7 +297,7 @@
 .oo-ui-buttonElement-framed.oo-ui-widget-disabled > 
.oo-ui-buttonElement-button {
   background-color: #c8ccd1;
   color: #fff;
-  border-color: #72777d;
+  border-color: #c8ccd1;
 }
 .oo-ui-buttonElement-framed.oo-ui-widget-enabled > .oo-ui-buttonElement-button 
{
   background-color: #f8f9fa;
@@ -1176,11 +1176,11 @@
 }
 .oo-ui-checkboxInputWidget [type='checkbox']:disabled + span {
   background-color: #c8ccd1;
-  border-color: #72777d;
+  border-color: #c8ccd1;
 }
 .oo-ui-checkboxInputWidget [type='checkbox']:disabled:hover + span {
   background-color: #c8ccd1;
-  border-color: #72777d;
+  border-color: #c8ccd1;
 }
 .oo-ui-checkboxInputWidget.oo-ui-widget-enabled [type='checkbox'] {
   cursor: pointer;
@@ -1316,7 +1316,7 @@
 .oo-ui-dropdownInputWidget.oo-ui-widget-disabled select {
   background-color: #eaecf0;
   color: #72777d;
-  border-color: #72777d;
+  border-color: #c8ccd1;
 }
 .oo-ui-radioInputWidget {
   position: relative;
@@ -1366,7 +1366,7 @@
 }
 .oo-ui-radioInputWidget [type='radio']:disabled + span {
   background-color: #c8ccd1;
-  border-color: #72777d;
+  border-color: #c8ccd1;
 }
 .oo-ui-radioInputWidget [type='radio']:disabled:checked + span {
   background-color: #fff;
@@ -1607,7 +1607,7 @@
   -webkit-text-fill-color: #72777d;
   color: #72777d;
   text-shadow: 0 1px 1px #fff;
-  border-color: #72777d;
+  border-color: #c8ccd1;
 }
 .oo-ui-textInputWidget.oo-ui-widget-disabled .oo-ui-iconElement-icon,
 .oo-ui-textInputWidget.oo-ui-widget-disabled .oo-ui-indicatorElement-indicator 
{
@@ -1792,7 +1792,7 @@
 .oo-ui-dropdownWidget.oo-ui-widget-disabled .oo-ui-dropdownWidget-handle {
   color: #72777d;
   text-shadow: 0 1px 1px #fff;
-  border-color: #72777d;
+  border-color: #c8ccd1;
   background-color: #eaecf0;
 }
 .oo-ui-dropdownWidget.oo-ui-widget-disabled .oo-ui-dropdownWidget-handle:focus 
{
diff --git a/resources/lib/oojs-ui/oojs-ui-core.js 
b/resources/lib/oojs-ui/oojs-ui-core.js
index 4300e88..a988269 100644
--- a/resources/lib/oojs-ui/oojs-ui-core.js
+++ b/resources/lib/oojs-ui/oojs-ui-core.js
@@ -6,7 +6,7 @@
  * Released under the MIT license
  * http://oojs.mit-license.org
  *
- * Date: 2017-08-01T23:45:14Z
+ * Date: 2017-08-03T19:36:51Z
  */
 ( function ( OO ) {
 
diff --git a/resources/lib/oojs-ui/oojs-ui-toolbars-apex.css 
b/resources/lib/oojs-ui/oojs-ui-toolbars-apex.css
index 8033773..a842a1c 100644
--- 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: jsduck: Explcitly name library files so we don't pull in CSS...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369758 )

Change subject: jsduck: Explcitly name library files so we don't pull in CSS 
files
..

jsduck: Explcitly name library files so we don't pull in CSS files

Change-Id: I402988a3c27c2f3191010046ae9b83bd74a50bee
---
M jsduck.json
1 file changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/58/369758/1

diff --git a/jsduck.json b/jsduck.json
index bfcf528..8fe2e5f 100644
--- a/jsduck.json
+++ b/jsduck.json
@@ -12,10 +12,15 @@
"--": [
".jsduck/external.js",
"lib/ve/.jsduck/external.js",
-   "lib/ve/lib/oojs",
-   "lib/ve/lib/oojs-ui",
-   "lib/ve/lib/unicodejs",
-   "lib/ve/lib/treeDiffer",
+   "lib/ve/lib/oojs/oojs.jquery.js",
+   "lib/ve/lib/oojs-ui/oojs-ui-core.js",
+   "lib/ve/lib/oojs-ui/oojs-ui-widgets.js",
+   "lib/ve/lib/oojs-ui/oojs-ui-toolbars.js",
+   "lib/ve/lib/oojs-ui/oojs-ui-windows.js",
+   "lib/ve/lib/oojs-ui/oojs-ui-wikimediaui.js",
+   "lib/ve/lib/oojs-ui/oojs-ui-apex.js",
+   "lib/ve/lib/unicodejs/unicodejs.js",
+   "lib/ve/lib/treeDiffer/treeDiffer-dist.js",
"lib/ve/src",
"lib/ve/tests",
"modules/ve-mw"

-- 
To view, visit https://gerrit.wikimedia.org/r/369758
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I402988a3c27c2f3191010046ae9b83bd74a50bee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Rename the "live preview" preference to be clearer what it p...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369582 )

Change subject: Rename the "live preview" preference to be clearer what it 
provides
..

Rename the "live preview" preference to be clearer what it provides

Bug: T171176
Change-Id: I2a9f94fa36245593163197707ae13bcb86aa62b8
---
M languages/i18n/en.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/82/369582/1

diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 039d617..68f4468 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -30,7 +30,7 @@
"tog-shownumberswatching": "Show the number of watching users",
"tog-oldsig": "Your existing signature:",
"tog-fancysig": "Treat signature as wikitext (without an automatic 
link)",
-   "tog-uselivepreview": "Use live preview",
+   "tog-uselivepreview": "Show previews without reloading the page",
"tog-forceeditsummary": "Prompt me when entering a blank edit summary",
"tog-watchlisthideown": "Hide my edits from the watchlist",
"tog-watchlisthidebots": "Hide bot edits from the watchlist",

-- 
To view, visit https://gerrit.wikimedia.org/r/369582
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a9f94fa36245593163197707ae13bcb86aa62b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: OOjs UI: Bring forward upstream fix for jQuery access key issue

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369578 )

Change subject: OOjs UI: Bring forward upstream fix for jQuery access key issue
..

OOjs UI: Bring forward upstream fix for jQuery access key issue

Change-Id: Ib188d2bdb359c7bb2db755240c50943d5d1713d7
---
M resources/lib/oojs-ui/oojs-ui-apex.js
M resources/lib/oojs-ui/oojs-ui-core.js
M resources/lib/oojs-ui/oojs-ui-core.js.map
M resources/lib/oojs-ui/oojs-ui-toolbars.js
M resources/lib/oojs-ui/oojs-ui-widgets.js
M resources/lib/oojs-ui/oojs-ui-wikimediaui.js
M resources/lib/oojs-ui/oojs-ui-windows.js
7 files changed, 18 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/78/369578/1


-- 
To view, visit https://gerrit.wikimedia.org/r/369578
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib188d2bdb359c7bb2db755240c50943d5d1713d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.12]: Follow-up 31be7d0: send tags list if experimental mode is di...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369574 )

Change subject: Follow-up 31be7d0: send tags list if experimental mode is 
disabled
..

Follow-up 31be7d0: send tags list if experimental mode is disabled

Change-Id: Ia9f44ed47d79f02c5d14ce756133e64c7ae926f9
(cherry picked from commit 7f8cbb602f04095c7a06820311f5b0479d876ffb)
---
M includes/specials/SpecialRecentchanges.php
1 file changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/74/369574/1

diff --git a/includes/specials/SpecialRecentchanges.php 
b/includes/specials/SpecialRecentchanges.php
index 1f8e3c5..157c3ed 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -189,12 +189,10 @@
'wgStructuredChangeFiltersEnableLiveUpdate',
$this->getConfig()->get( 
'StructuredChangeFiltersEnableLiveUpdate' )
);
-   if ( $experimentalStructuredChangeFilters ) {
-   $out->addJsConfigVars(
-   'wgRCFiltersChangeTags',
-   $this->buildChangeTagList()
-   );
-   }
+   $out->addJsConfigVars(
+   'wgRCFiltersChangeTags',
+   $this->buildChangeTagList()
+   );
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/369574
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9f44ed47d79f02c5d14ce756133e64c7ae926f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.12
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (18ae4004f)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369564 )

Change subject: Update VE core submodule to master (18ae4004f)
..

Update VE core submodule to master (18ae4004f)

New changes:
887ebb1a4 Clarify comments that certain 'html' parameters must be whole 
documents
cc50757ee LinearTabKeyDownHandler: Abort if modifiers are used
23f70f760 jsduck: Explcitly name library files so we don't pull in CSS files
18ae4004f Update OOjs UI to v0.22.4

Bug: T171600
Bug: T172168
Change-Id: I2510174db0f650113702674e37e768aa558f02cc
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/64/369564/1

diff --git a/lib/ve b/lib/ve
index 4d6745b..18ae400 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 4d6745b2f8ea2dc89dfb7e22855983e0469cf859
+Subproject commit 18ae4004fc776e102f90d2e7c078f8bcd98a410a

-- 
To view, visit https://gerrit.wikimedia.org/r/369564
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2510174db0f650113702674e37e768aa558f02cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: jsduck: Explcitly name library files so we don't pull in CSS...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369528 )

Change subject: jsduck: Explcitly name library files so we don't pull in CSS 
files
..

jsduck: Explcitly name library files so we don't pull in CSS files

Change-Id: I8ee7c8a609543237f8280c190a9806cf5079de96
---
M jsduck.json
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/28/369528/1

diff --git a/jsduck.json b/jsduck.json
index cbd4676..7e59432 100644
--- a/jsduck.json
+++ b/jsduck.json
@@ -37,7 +37,12 @@
"resources/src/jquery/jquery.suggestions.js",
"resources/src/jquery/jquery.tabIndex.js",
"resources/lib/jquery.client/jquery.client.js",
-   "resources/lib/oojs",
-   "resources/lib/oojs-ui"
+   "resources/lib/oojs/oojs.jquery.js",
+   "resources/lib/oojs-ui/oojs-ui-core.js",
+   "resources/lib/oojs-ui/oojs-ui-widgets.js",
+   "resources/lib/oojs-ui/oojs-ui-toolbars.js",
+   "resources/lib/oojs-ui/oojs-ui-windows.js",
+   "resources/lib/oojs-ui/oojs-ui-wikimediaui.js",
+   "resources/lib/oojs-ui/oojs-ui-apex.js"
]
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/369528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ee7c8a609543237f8280c190a9806cf5079de96
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: jsduck: Explcitly name library files so we don't pull in CSS...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369510 )

Change subject: jsduck: Explcitly name library files so we don't pull in CSS 
files
..

jsduck: Explcitly name library files so we don't pull in CSS files

Change-Id: Ib35dc36ac3798c8d4af002796f4e97d665904f55
---
M jsduck.json
1 file changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/10/369510/1

diff --git a/jsduck.json b/jsduck.json
index 7071952..c7a2067 100644
--- a/jsduck.json
+++ b/jsduck.json
@@ -11,10 +11,15 @@
"--external": 
"HTMLDocument,Window,Node,Text,Set,Range,Selection,ClientRect,File,Blob,DataTransfer,DataTransferItem,KeyboardEvent,MouseEvent",
"--": [
".jsduck/external.js",
-   "lib/oojs",
-   "lib/oojs-ui",
-   "lib/unicodejs",
-   "lib/treeDiffer",
+   "lib/oojs/oojs.jquery.js",
+   "lib/oojs-ui/oojs-ui-core.js",
+   "lib/oojs-ui/oojs-ui-widgets.js",
+   "lib/oojs-ui/oojs-ui-toolbars.js",
+   "lib/oojs-ui/oojs-ui-windows.js",
+   "lib/oojs-ui/oojs-ui-wikimediaui.js",
+   "lib/oojs-ui/oojs-ui-apex.js",
+   "lib/unicodejs/unicodejs.js",
+   "lib/treeDiffer/treeDiffer-dist.js",
"src",
"tests"
]

-- 
To view, visit https://gerrit.wikimedia.org/r/369510
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib35dc36ac3798c8d4af002796f4e97d665904f55
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs UI to v0.22.4

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369480 )

Change subject: Update OOjs UI to v0.22.4
..

Update OOjs UI to v0.22.4

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.4

Change-Id: I505e7c612b70a949d2b101172964bd7433fb8d5e
---
M lib/oojs-ui/i18n/as.json
M lib/oojs-ui/i18n/bs.json
M lib/oojs-ui/i18n/pt-br.json
M lib/oojs-ui/oojs-ui-apex-icons-alerts.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-content.css
M lib/oojs-ui/oojs-ui-apex-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-media.css
M lib/oojs-ui/oojs-ui-apex-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-user.css
M lib/oojs-ui/oojs-ui-apex-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-apex.css
M lib/oojs-ui/oojs-ui-apex.js
M lib/oojs-ui/oojs-ui-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-apex.css
M lib/oojs-ui/oojs-ui-core-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-mediawiki.css
M lib/oojs-ui/oojs-ui-core-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-core.js
M lib/oojs-ui/oojs-ui-core.js.map
M lib/oojs-ui/oojs-ui-images-apex.css
M lib/oojs-ui/oojs-ui-images-apex.rtl.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-accessibility.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki.css
M lib/oojs-ui/oojs-ui-mediawiki.js
M lib/oojs-ui/oojs-ui-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-apex.css
M lib/oojs-ui/oojs-ui-toolbars-apex.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars.js
M lib/oojs-ui/oojs-ui-widgets-apex.css
M lib/oojs-ui/oojs-ui-widgets-apex.rtl.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-widgets.js
M lib/oojs-ui/oojs-ui-widgets.js.map
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.css
M 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update OOjs UI to v0.22.4

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369479 )

Change subject: Update OOjs UI to v0.22.4
..

Update OOjs UI to v0.22.4

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.4

Depends-On: I505e7c612b70a949d2b101172964bd7433fb8d5e
Change-Id: Ice2c56b035c5b9e6525d5b9c0d9b45eb07bb2943
---
M composer.json
M resources/lib/oojs-ui/i18n/as.json
M resources/lib/oojs-ui/i18n/bs.json
M resources/lib/oojs-ui/i18n/pt-br.json
M resources/lib/oojs-ui/oojs-ui-apex.js
M resources/lib/oojs-ui/oojs-ui-core-apex.css
M resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-core.js
M resources/lib/oojs-ui/oojs-ui-core.js.map
M resources/lib/oojs-ui/oojs-ui-toolbars-apex.css
M resources/lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-toolbars.js
M resources/lib/oojs-ui/oojs-ui-widgets-apex.css
M resources/lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-widgets.js
M resources/lib/oojs-ui/oojs-ui-widgets.js.map
M resources/lib/oojs-ui/oojs-ui-wikimediaui.js
M resources/lib/oojs-ui/oojs-ui-windows-apex.css
M resources/lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-windows.js
M resources/lib/oojs-ui/themes/apex/icons-media.json
A resources/lib/oojs-ui/themes/apex/images/icons/play-ltr.png
A resources/lib/oojs-ui/themes/apex/images/icons/play-ltr.svg
A resources/lib/oojs-ui/themes/apex/images/icons/play-rtl.png
A resources/lib/oojs-ui/themes/apex/images/icons/play-rtl.svg
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-ltr-invert.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-ltr-invert.svg
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-ltr-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-ltr-progressive.svg
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-ltr.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-ltr.svg
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-rtl-invert.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-rtl-invert.svg
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-rtl-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-rtl-progressive.svg
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-rtl.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/play-rtl.svg
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/stop-invert.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/stop-invert.svg
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/stop-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/stop-progressive.svg
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/stop.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/stop.svg
43 files changed, 352 insertions(+), 130 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/79/369479/1


-- 
To view, visit https://gerrit.wikimedia.org/r/369479
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice2c56b035c5b9e6525d5b9c0d9b45eb07bb2943
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOjs UI to v0.22.4

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369478 )

Change subject: Update OOjs UI to v0.22.4
..

Update OOjs UI to v0.22.4

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.4

Change-Id: I505e7c612b70a949d2b101172964bd7433fb8d5e
---
M composer.json
M composer.lock
M composer/installed.json
M oojs/oojs-ui/History.md
A oojs/oojs-ui/bin/dependencytree.rb
M oojs/oojs-ui/demos/classes/DraggableHandledItemWidget.js
M oojs/oojs-ui/demos/classes/DraggableItemWidget.js
A oojs/oojs-ui/demos/classes/DynamicLabelTextInputWidget.js
A oojs/oojs-ui/demos/classes/SimpleWidget.css
A oojs/oojs-ui/demos/classes/SimpleWidget.js
M oojs/oojs-ui/demos/index.html
M oojs/oojs-ui/demos/pages/widgets.js
M oojs/oojs-ui/demos/pages/widgets.php
M oojs/oojs-ui/demos/styles/demo.css
M oojs/oojs-ui/i18n/as.json
M oojs/oojs-ui/i18n/bs.json
M oojs/oojs-ui/i18n/pt-br.json
M oojs/oojs-ui/package.json
M oojs/oojs-ui/php/Tag.php
M oojs/oojs-ui/php/Widget.php
M oojs/oojs-ui/php/layouts/FieldLayout.php
M oojs/oojs-ui/php/layouts/FieldsetLayout.php
M oojs/oojs-ui/php/mixins/AccessKeyedElement.php
M oojs/oojs-ui/php/mixins/TabIndexedElement.php
M oojs/oojs-ui/php/mixins/TitledElement.php
25 files changed, 412 insertions(+), 125 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/78/369478/1

diff --git a/composer.json b/composer.json
index 8410b2d..2dcfd8d 100644
--- a/composer.json
+++ b/composer.json
@@ -45,7 +45,7 @@
"monolog/monolog": "1.22.1",
"mustangostang/spyc": "0.6.2",
"nmred/kafka-php": "0.1.5",
-   "oojs/oojs-ui": "0.22.3",
+   "oojs/oojs-ui": "0.22.4",
"oyejorge/less.php": "1.7.0.14",
"pear/console_getopt": "1.4.1",
"pear/mail": "1.4.1",
diff --git a/composer.lock b/composer.lock
index f2711f6..355956c 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"content-hash": "d3e0811f4f6f8eb8bd96e36bd53702ea",
+"content-hash": "301c4a097e044e617ab5b804f5b99a22",
 "packages": [
 {
 "name": "composer/semver",
@@ -516,16 +516,16 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.22.3",
+"version": "v0.22.4",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "796f52473294e923d0133bb1b0b3629d9b1332bc"
+"reference": "bb1b15c47835468f133a56aa56a721f8793c61f7"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/796f52473294e923d0133bb1b0b3629d9b1332bc;,
-"reference": "796f52473294e923d0133bb1b0b3629d9b1332bc",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/bb1b15c47835468f133a56aa56a721f8793c61f7;,
+"reference": "bb1b15c47835468f133a56aa56a721f8793c61f7",
 "shasum": ""
 },
 "require": {
@@ -591,7 +591,7 @@
 ],
 "description": "Provides library of common widgets, layouts, and 
windows.",
 "homepage": "https://www.mediawiki.org/wiki/OOjs_UI;,
-"time": "2017-07-11T21:50:03+00:00"
+"time": "2017-08-01T19:55:30+00:00"
 },
 {
 "name": "oyejorge/less.php",
diff --git a/composer/installed.json b/composer/installed.json
index 36c3a06..f37cf29 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -2161,87 +2161,6 @@
 ]
 },
 {
-"name": "oojs/oojs-ui",
-"version": "v0.22.3",
-"version_normalized": "0.22.3.0",
-"source": {
-"type": "git",
-"url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "796f52473294e923d0133bb1b0b3629d9b1332bc"
-},
-"dist": {
-"type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/796f52473294e923d0133bb1b0b3629d9b1332bc;,
-"reference": "796f52473294e923d0133bb1b0b3629d9b1332bc",
-"shasum": ""
-},
-"require": {
-"mediawiki/at-ease": "1.1.0",
-"php": ">=5.5.9"
-},
-"require-dev": {
-"jakub-onderka/php-parallel-lint": "0.9.2",
-"mediawiki/mediawiki-codesniffer": "0.10.0",
-"phpunit/phpunit": "4.8.21"
-},
-"time": "2017-07-11T21:50:03+00:00",
-"type": "library",
-"installation-source": "dist",
-"autoload": {
-"classmap": [
-  

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Tag v0.22.4

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369463 )

Change subject: Tag v0.22.4
..

Tag v0.22.4

Change-Id: I3df3227b1ef3653db73e35c1bff4b4eec014c231
---
M History.md
M package.json
2 files changed, 37 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/63/369463/1

diff --git a/History.md b/History.md
index 8be0c72..f427087 100644
--- a/History.md
+++ b/History.md
@@ -1,4 +1,40 @@
 # OOjs UI Release History
+## v0.22.4 / 2017-08-01
+### Features
+* CheckboxMultiselectInputWidget: setValue when CheckboxMultiselect changes 
(Prateek Saxena)
+* FieldLayout: Show widget's accesskey in our title (Bartosz Dziewoński)
+* TextInputWidget: When positioning label, don't clear padding if we will set 
it again (Bartosz Dziewoński)
+* TitledElement: When an AccessKeyedElement, show access key in the title 
(Bartosz Dziewoński)
+
+### Styles
+* icons: Vertically align 'play' & 'stop' icons (Volker E.)
+* Apex theme: Add focus styles to Tag-/CapsuleMultiselectWidget (Volker E.)
+* Apex theme: Add focus styles to frameless buttons (Volker E.)
+* Apex theme: Add play icon (copied from WikimediaUI theme) (Roan Kattouw)
+* Apex theme: Align ButtonGroup-/ButtonSelectWidget focus logic to WikimediaUI 
(Volker E.)
+* Apex theme: Align Dropdown*Widget's focus state with other widgets (Volker 
E.)
+* Apex theme: Align TextInputWidget focus to variablized way (Volker E.)
+* Apex theme: Align ToggleSwitchWidget focus style to other widgets (Volker E.)
+* Apex theme: Improve alignment of TextInputWidget and its elements (Volker E.)
+* Apex theme: Introduce framed button focus indication (Volker E.)
+* Apex theme: Replace and unify `border-radius` with variables (Volker E.)
+* WikimediaUI theme: Set ButtonElement's height per default (Volker E.)
+* WikimediaUI theme: Work around a Firefox rendering bug for checkboxes and 
radios (Bartosz Dziewoński)
+
+### Code
+* DraggableGroupElement: Remove ARIA roles & attributes (Volker E.)
+* FieldsetLayout: Use `` now that Chrome 55 bug is less important 
(James D. Forrester)
+* Apex theme: Align remaining values to coding convention (Volker E.)
+* WikimediaUI theme: Align `*-fallback` var with notation elsewhere (Volker E.)
+* WikimediaUI theme: Code comment hygiene (Volker E.)
+* WikimediaUI theme: Directly use the Less values rather than via copy-paste 
(James D. Forrester)
+* demos: Add examples of TextInputWidget with dynamic label (Bartosz 
Dziewoński)
+* demos: Demo.DraggableItemWidget should not inherit from OO.ui.OptionWidget 
(Bartosz Dziewoński)
+* demos: Show example link on `:focus` (Volker E.)
+* doc: Fix some PHPDoc `@return` tags (Ricordisamoa)
+* build: Add a script to print the dependency tree of everything (Bartosz 
Dziewoński)
+
+
 ## v0.22.3 / 2017-07-11
 ### Features
 * Tag-/CapsuleMultiselectWidget: Avoid visual focusTrap feedback (Volker E.)
diff --git a/package.json b/package.json
index 139a202..a6a2365 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "oojs-ui",
-  "version": "0.22.3",
+  "version": "0.22.4",
   "description": "User interface classes built on the OOjs framework.",
   "keywords": [
 "oojs-plugin",

-- 
To view, visit https://gerrit.wikimedia.org/r/369463
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3df3227b1ef3653db73e35c1bff4b4eec014c231
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Genealogy[master]: build: Bump mediawiki-codesniffer to 0.10.1

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368968 )

Change subject: build: Bump mediawiki-codesniffer to 0.10.1
..

build: Bump mediawiki-codesniffer to 0.10.1

Change-Id: I35996e8fa9f35df6247971805d05a6d534a812d8
---
M composer.json
M phpcs.xml
M src/Hooks.php
M src/Person.php
M src/Tree.php
5 files changed, 7 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Genealogy 
refs/changes/68/368968/1

diff --git a/composer.json b/composer.json
index b920e0e..64ac8b5 100644
--- a/composer.json
+++ b/composer.json
@@ -28,7 +28,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "^0.9",
-   "mediawiki/mediawiki-codesniffer": "0.10.0",
+   "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index e1dcde4..74e9072 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,6 +2,4 @@
 

.
-   node_modules
-   vendor
 
diff --git a/src/Hooks.php b/src/Hooks.php
index 131ee61..267dff2 100644
--- a/src/Hooks.php
+++ b/src/Hooks.php
@@ -13,7 +13,7 @@
/**
 * Hooked to ParserFirstCallInit.
 * @param Parser &$parser The parser.
-* @return boolean
+* @return bool
 */
public static function onParserFirstCallInit( Parser &$parser ) {
$parser->setFunctionHook( 'genealogy', 
self::class.'::renderParserFunction' );
@@ -150,7 +150,7 @@
 * @param Parser $parser The parser object.
 * @param string $prop The property name; it will be prefixed with 
'genealogy '.
 * @param string|Title $val The property value ('full text' will be 
used if this is a Title).
-* @param boolean $multi Whether this property can have multiple values 
(will be stored as
+* @param bool $multi Whether this property can have multiple values 
(will be stored as
 * multiple properties, with an integer appended to their name.
 */
public static function saveProp( Parser $parser, $prop, $val, $multi = 
true ) {
diff --git a/src/Person.php b/src/Person.php
index 4764559..76744ad 100644
--- a/src/Person.php
+++ b/src/Person.php
@@ -112,7 +112,7 @@
 
/**
 * Whether or not this person has a birth or death date.
-* @return boolean
+* @return bool
 */
public function hasDates() {
return $this->getBirthDate() !== false || $this->getDeathDate() 
!== false;
@@ -177,7 +177,7 @@
 
/**
 * Get all partners (optionally excluding those that are defined within 
the current page).
-* @param boolean $onlyDefinedElsewhere Only return those partners that 
are *not* defined
+* @param bool $onlyDefinedElsewhere Only return those partners that 
are *not* defined
 * within this Person's page.
 * @return Person[] An array of partners, possibly empty. Keyed by the 
partner's page DB key.
 */
@@ -229,7 +229,7 @@
/**
 * Get the value of a single-valued page property.
 * @param string $prop The property.
-* @return string|boolean The property value, or false if not found.
+* @return string|bool The property value, or false if not found.
 */
public function getPropSingle( $prop ) {
$dbr = wfGetDB( DB_SLAVE );
diff --git a/src/Tree.php b/src/Tree.php
index febf0d9..ef6afc0 100644
--- a/src/Tree.php
+++ b/src/Tree.php
@@ -70,7 +70,7 @@
 
/**
 * Whether any ancestors or descendants have been added to this tree.
-* @return boolean
+* @return bool
 */
public function hasAncestorsOrDescendants() {
return 0 < ( count( $this->ancestors ) + count( 
$this->descendants ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/368968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35996e8fa9f35df6247971805d05a6d534a812d8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Genealogy
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OAuthAuthentication[master]: build: Bump mediawiki-codesniffer to 0.10.1

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368966 )

Change subject: build: Bump mediawiki-codesniffer to 0.10.1
..

build: Bump mediawiki-codesniffer to 0.10.1

Change-Id: Iead9802b3cfb19823617f6a0377b2d40c8747c14
---
M composer.json
M handlers/AuthenticationHandler.php
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuthAuthentication 
refs/changes/66/368966/1

diff --git a/composer.json b/composer.json
index 54f8620..3c8225d 100644
--- a/composer.json
+++ b/composer.json
@@ -24,7 +24,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.0"
+   "mediawiki/mediawiki-codesniffer": "0.10.1"
},
"scripts": {
"test": [
diff --git a/handlers/AuthenticationHandler.php 
b/handlers/AuthenticationHandler.php
index 25afabc..7e944f4 100644
--- a/handlers/AuthenticationHandler.php
+++ b/handlers/AuthenticationHandler.php
@@ -26,11 +26,11 @@
$exUser->setIdentifyTS( new \MWTimestamp() );
 
if ( $exUser->attached() ) {
-   $status = AuthenticationHandler::doLogin( $exUser, 
$request );
+   $status = self::doLogin( $exUser, $request );
$s = \Status::newGood( [ 'successfulLogin', 
$status->getValue() ] );
$s->merge( $status );
} else {
-   $status = AuthenticationHandler::doCreateAndLogin( 
$exUser, $request );
+   $status = self::doCreateAndLogin( $exUser, $request );
$s = \Status::newGood( [ 'successfulCreation', 
$status->getValue() ] );
$s->merge( $status );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/368966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iead9802b3cfb19823617f6a0377b2d40c8747c14
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuthAuthentication
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GoogleLogin[master]: build: Bump mediawiki-codesniffer to 0.10.1

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368965 )

Change subject: build: Bump mediawiki-codesniffer to 0.10.1
..

build: Bump mediawiki-codesniffer to 0.10.1

Change-Id: I74a8ff7a7287cc4e15689da74630eba5c9d86707
---
M composer.json
M includes/GoogleLogin.body.php
M includes/GoogleLogin.hooks.php
M includes/specials/SpecialManageGoogleLogin.php
4 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GoogleLogin 
refs/changes/65/368965/1

diff --git a/composer.json b/composer.json
index cca0acc..efd81f3 100644
--- a/composer.json
+++ b/composer.json
@@ -7,7 +7,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.0",
+   "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/GoogleLogin.body.php b/includes/GoogleLogin.body.php
index 81edee3..7c54b9a 100755
--- a/includes/GoogleLogin.body.php
+++ b/includes/GoogleLogin.body.php
@@ -51,7 +51,7 @@
/**
 * If restriction of domains is enabled, check if the user E-Mail is 
valid before do anything.
 * @param string $mailDomain The domain of email address
-* @return boolean
+* @return bool
 */
public static function isValidDomain( $mailDomain ) {
$glConfig = self::getGLConfig();
diff --git a/includes/GoogleLogin.hooks.php b/includes/GoogleLogin.hooks.php
index 476b72a..8e06aba 100644
--- a/includes/GoogleLogin.hooks.php
+++ b/includes/GoogleLogin.hooks.php
@@ -152,7 +152,7 @@
 *
 * @param \EchoEvent $event The triggering event
 * @param String &$bundleString The message of the bundle
-* @return boolean
+* @return bool
 */
public static function onEchoGetBundleRules( \EchoEvent $event, 
&$bundleString ) {
if (
diff --git a/includes/specials/SpecialManageGoogleLogin.php 
b/includes/specials/SpecialManageGoogleLogin.php
index 39fdd54..667573a 100644
--- a/includes/specials/SpecialManageGoogleLogin.php
+++ b/includes/specials/SpecialManageGoogleLogin.php
@@ -77,7 +77,7 @@
 * Checks, if a user with the entered username exists.
 *
 * @param array $data Formdata
-* @return boolean
+* @return bool
 */
public function submitUserName( array $data ) {
$this->submitForm( $data, false );
@@ -156,7 +156,7 @@
 *
 * @param array $data Formdata
 * @param boolean $checkSession If true, checks, if the form was 
submitted by the user itself
-* @return boolean
+* @return bool
 */
public function submitForm( array $data, $checkSession = true ) {
$user = $this->getUser();

-- 
To view, visit https://gerrit.wikimedia.org/r/368965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74a8ff7a7287cc4e15689da74630eba5c9d86707
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GoogleLogin
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CookieWarning[master]: build: Bump mediawiki-codesniffer to 0.10.1

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368964 )

Change subject: build: Bump mediawiki-codesniffer to 0.10.1
..

build: Bump mediawiki-codesniffer to 0.10.1

Change-Id: Ia9b79a81d7e7d2b47467c743745bb13f611af17f
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CookieWarning 
refs/changes/64/368964/1

diff --git a/composer.json b/composer.json
index 8c9facf..d368985 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.0",
+   "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/368964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9b79a81d7e7d2b47467c743745bb13f611af17f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CookieWarning
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CollapsibleVector[master]: build: Bump mediawiki-codesniffer to 0.10.1

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368963 )

Change subject: build: Bump mediawiki-codesniffer to 0.10.1
..

build: Bump mediawiki-codesniffer to 0.10.1

Change-Id: Iccd7e1466ecd0918f5d3eb427aa1ebc6896951fa
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollapsibleVector 
refs/changes/63/368963/1

diff --git a/composer.json b/composer.json
index 9b2aa08..30bb966 100644
--- a/composer.json
+++ b/composer.json
@@ -22,7 +22,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.0",
+   "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/368963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccd7e1466ecd0918f5d3eb427aa1ebc6896951fa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollapsibleVector
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AdManager[master]: build: Bump mediawiki-codingstandards to 0.10.1

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368962 )

Change subject: build: Bump mediawiki-codingstandards to 0.10.1
..

build: Bump mediawiki-codingstandards to 0.10.1

Change-Id: Ifbfe9c81c6acfd0d7322d77e47a29a920fff254e
---
M AdManager.class.php
M AdManager.hooks.php
M AdManagerZones.class.php
M composer.json
M specials/SpecialAdManagerZones.php
5 files changed, 21 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AdManager 
refs/changes/62/368962/1

diff --git a/AdManager.class.php b/AdManager.class.php
index b90682e..ec9e457 100644
--- a/AdManager.class.php
+++ b/AdManager.class.php
@@ -27,7 +27,7 @@
/**
 * Check if the correct table exists
 *
-* @return boolean
+* @return bool
 */
public static function tableExists() {
$dbr = self::getReadDbConnection();
@@ -114,7 +114,7 @@
 * Insert an array of ads into the db
 *
 * @param array $allAds
-* @return boolean
+* @return bool
 */
protected function addAllAds( $allAds = null ) {
if ( !$allAds ) {
@@ -137,7 +137,7 @@
 *
 * @param string $type either Page or Category
 * @param array $someAds
-* @return boolean
+* @return bool
 */
protected function addSomeAds( $type, $someAds ) {
foreach ( $someAds as $adZoneID => $ads ) {
@@ -206,18 +206,18 @@
 * Get HTML for all ads that should be displayed for this page
 *
 * @param Title $title Title of the page
-* @return boolean|array false on error or an array with HTML for each 
ad
+* @return bool|array false on error or an array with HTML for each ad
 */
public static function getAdOutputFor( Title $title ) {
-   if ( !AdManager::tableExists() ) {
+   if ( !self::tableExists() ) {
return false;
}
-   $adManagerCode = AdManager::getAdManagerCode();
+   $adManagerCode = self::getAdManagerCode();
if ( !isset( $adManagerCode ) ) {
return false; // TODO: show error
}
 
-   $thisPageAdZones = AdManager::getAdZonesFor( $title );
+   $thisPageAdZones = self::getAdZonesFor( $title );
if ( empty( $thisPageAdZones ) ) { // No zone set for this page 
or its categories
return [];
}
@@ -282,7 +282,7 @@
 * @return array
 */
public static function getCategoryAdZonesFor( $title ) {
-   $fullTableName = AdManager::getTableName();
+   $fullTableName = self::getTableName();
$dbr = self::getReadDbConnection();
$thisPageAdZones = [];
// check if an ad zone was set for any of this page's categories
diff --git a/AdManager.hooks.php b/AdManager.hooks.php
index c6d715a..1544978 100644
--- a/AdManager.hooks.php
+++ b/AdManager.hooks.php
@@ -21,7 +21,7 @@
 * @global string $wgAdManagerPlacement
 * @param Skin $skin
 * @param array $sidebar
-* @return boolean
+* @return bool
 */
public static function SkinBuildSidebar( $skin, &$sidebar ) {
global $wgAdManagerPlacement;
@@ -44,7 +44,7 @@
 * @global string $wgAdManagerPlacement
 * @param OutputPage $out
 * @param Skin $skin
-* @return boolean
+* @return bool
 */
public static function onBeforePageDisplay( OutputPage &$out, Skin 
&$skin ) {
$out->addModules( 'ext.adManager' );
diff --git a/AdManagerZones.class.php b/AdManagerZones.class.php
index b5d4331..6fc4e65 100644
--- a/AdManagerZones.class.php
+++ b/AdManagerZones.class.php
@@ -16,12 +16,12 @@
private $zonesToRemove = [];
 
/**
-* @var boolean $zonesAddedSuccessfully
+* @var bool $zonesAddedSuccessfully
 */
private $zonesAddedSuccessfully;
 
/**
-* @var boolean $zonesRemovedSuccessfully
+* @var bool $zonesRemovedSuccessfully
 */
private $zonesRemovedSuccessfully;
 
@@ -79,7 +79,7 @@
 * Check if the zone is valid
 *
 * @param string $zone
-* @return boolean
+* @return bool
 */
public static function isValidZone( $zone ) {
if ( empty( $zone ) ) {
@@ -95,7 +95,7 @@
 * Validate single zone name and throw an error if invalid
 *
 * @param string $zone
-* @return boolean
+* @return bool
 * @throws ErrorPageError
 */
public static function validateZone( $zone ) {
@@ -110,7 +110,7 @@
 * Validate array of zones
 *
 * @param array 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "mw.widgets.visibleByteLimit: Temporarily disable whi...

[Jforrester (Code Review)]

Hello Bartosz Dziewoński, jenkins-bot,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/368960

to review the following change.


Change subject: Revert "mw.widgets.visibleByteLimit: Temporarily disable whilst 
OOjs UI label bug is fixed"
..

Revert "mw.widgets.visibleByteLimit: Temporarily disable whilst OOjs UI label 
bug is fixed"

This reverts commit b6f39380938223a25ee280a96c25ce0d05a4c207.

Not to be merged before the new version of OOjs UI.

Change-Id: Ia194f5835a5d62ad46b498938a4764f0c0964589
---
M 
resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/60/368960/1

diff --git 
a/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
 
b/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
index 51b9815..5678a80 100644
--- 
a/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
+++ 
b/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
@@ -9,15 +9,12 @@
 mediaWiki.widgets.visibleByteLimit = function ( textInputWidget, limit ) {
limit = limit || +textInputWidget.$input.attr( 'maxlength' );
 
-   // Temporarily disabled whilst upstream bug is fixed; T169982
-   /*
function updateCount() {
textInputWidget.setLabel( ( limit - $.byteLength( 
textInputWidget.getValue() ) ).toString() );
}
textInputWidget.on( 'change', updateCount );
// Initialise value
updateCount();
-   */
 
// Actually enforce limit
textInputWidget.$input.byteLimit( limit );

-- 
To view, visit https://gerrit.wikimedia.org/r/368960
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia194f5835a5d62ad46b498938a4764f0c0964589
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (4d6745b2f)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368830 )

Change subject: Update VE core submodule to master (4d6745b2f)
..

Update VE core submodule to master (4d6745b2f)

New changes:
d7ca44b84 Localisation updates from https://translatewiki.net.
addd343a0 Localisation updates from https://translatewiki.net.
0ca48126b Abstract definition of type equality when comparing inline nodes
8c9e9dd0a Disable Grammarly
9eb3f29cb Don't throw an exception if observed annotation is alien to us

Bug: T165746
Bug: T166801
Change-Id: I6b8f60432352c468e8c3f2946802ac33d1e9604f
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/30/368830/1

diff --git a/lib/ve b/lib/ve
index f444fa1..4d6745b 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit f444fa19b9fa4d785d3b3a0cbac31a317f63bb60
+Subproject commit 4d6745b2f8ea2dc89dfb7e22855983e0469cf859

-- 
To view, visit https://gerrit.wikimedia.org/r/368830
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b8f60432352c468e8c3f2946802ac33d1e9604f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: [DNM] ContInt: Upgrade npm from 2.15.2 to 3.8.3 in CI

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368459 )

Change subject: [DNM] ContInt: Upgrade npm from 2.15.2 to 3.8.3 in CI
..

[DNM] ContInt: Upgrade npm from 2.15.2 to 3.8.3 in CI

Bug: T161861
Change-Id: Ia4a7431523efc616dcab8eb96c32fe4c2eef8a90
---
M modules/contint/manifests/packages/javascript.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/59/368459/1

diff --git a/modules/contint/manifests/packages/javascript.pp 
b/modules/contint/manifests/packages/javascript.pp
index eb59054..9b2078e 100644
--- a/modules/contint/manifests/packages/javascript.pp
+++ b/modules/contint/manifests/packages/javascript.pp
@@ -15,7 +15,7 @@
 #
 # https://wikitech.wikimedia.org/wiki/Nova_Resource:Integration/Setup
 $versions = {
-'npm'   => '2.15.2',
+'npm'   => '3.8.3',
 }
 
 # Provide 'node' alias for 'nodejs' because Debian/Ubuntu

-- 
To view, visit https://gerrit.wikimedia.org/r/368459
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4a7431523efc616dcab8eb96c32fe4c2eef8a90
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (1521f24a1)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367840 )

Change subject: Update VE core submodule to master (1521f24a1)
..

Update VE core submodule to master (1521f24a1)

New changes:
d23bd1e79 Localisation updates from https://translatewiki.net.
71807dedb Localisation updates from https://translatewiki.net.
fdac5539b Doc comment improvement to ve.ui.LanguageInputWidget.
22f2e8531 ve.ce.Surface: Fix lint error

Change-Id: I02883793afb120cd3751988bb11b4068af0bd317
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/40/367840/1

diff --git a/lib/ve b/lib/ve
index be80158..1521f24 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit be80158a97dea36f0a22fcc938cd7ed716790a1b
+Subproject commit 1521f24a176e49b6c320b702200a8de88bff7edb

-- 
To view, visit https://gerrit.wikimedia.org/r/367840
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02883793afb120cd3751988bb11b4068af0bd317
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Follow-up 2454f51b274: Upgrade qunit from 1.x to 2.x too

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367838 )

Change subject: Follow-up 2454f51b274: Upgrade qunit from 1.x to 2.x too
..

Follow-up 2454f51b274: Upgrade qunit from 1.x to 2.x too

 karma-qunit 1.0.0  →   1.2.1
 qunitjs1.23.1  →   2.4.0

Change-Id: Ibc0909ed5fbde715814b0ddb1a1d1c9668d10a85
---
M package.json
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/38/367838/1

diff --git a/package.json b/package.json
index 8507238..484c293 100644
--- a/package.json
+++ b/package.json
@@ -23,9 +23,9 @@
 "karma-chrome-launcher": "2.0.0",
 "karma-firefox-launcher": "1.0.1",
 "karma-mocha-reporter": "2.2.3",
-"karma-qunit": "1.0.0",
+"karma-qunit": "1.2.1",
 "nodemw": "0.10.1",
-"qunitjs": "1.23.1",
+"qunitjs": "2.4.0",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1",
 "wdio-junit-reporter": "0.2.0",

-- 
To view, visit https://gerrit.wikimedia.org/r/367838
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc0909ed5fbde715814b0ddb1a1d1c9668d10a85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SpecialUndelete: Don't try to add a form to the page unless ...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367562 )

Change subject: SpecialUndelete: Don't try to add a form to the page unless it 
exists
..

SpecialUndelete: Don't try to add a form to the page unless it exists

Bug: T171523
Change-Id: I1083ce168797a698c76c3fdff4eac06edfb0ac6a
---
M includes/specials/SpecialUndelete.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/62/367562/1

diff --git a/includes/specials/SpecialUndelete.php 
b/includes/specials/SpecialUndelete.php
index 810f8fb..cd218e6 100644
--- a/includes/specials/SpecialUndelete.php
+++ b/includes/specials/SpecialUndelete.php
@@ -858,9 +858,9 @@
$misc = Html::hidden( 'target', $this->mTarget );
$misc .= Html::hidden( 'wpEditToken', 
$this->getUser()->getEditToken() );
$history .= $misc;
-   }
 
-   $form->appendContent( new OOUI\HtmlSnippet( $history ) );
+   $form->appendContent( new OOUI\HtmlSnippet( $history ) 
);
+   }
 
$out->addHTML( $form );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/367562
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1083ce168797a698c76c3fdff4eac06edfb0ac6a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable response reference lists on all Wikiquotes

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367404 )

Change subject: Enable response reference lists on all Wikiquotes
..

Enable response reference lists on all Wikiquotes

Bug: T159895
Change-Id: Ib5d70e6579e1107f2fbbcc1aa11a105155210040
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/04/367404/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index a1f5e16..a4e52b3 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -14838,6 +14838,8 @@
'nowiki' => true, // T160362
 
'enwiktionary' => true, // T160933
+
+   'wikiquote' => true, // T159895
 ],
 
 'wmgUseRSSExtension' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/367404
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5d70e6579e1107f2fbbcc1aa11a105155210040
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[wmf/1.30.0-wmf.10]: Fix layout regression in notification popup footer

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366952 )

Change subject: Fix layout regression in notification popup footer
..

Fix layout regression in notification popup footer

Caused by a new margin rule in OOUI.

Bug: T171302
Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
(cherry picked from commit 0bf4861d929a21d4f80a1a466e04f04e61ea9642)
---
M modules/styles/mw.echo.ui.NotificationBadgeWidget.less
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/52/366952/1

diff --git a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less 
b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
index 2c2f0aa..183edf9 100644
--- a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -56,6 +56,9 @@
border-top: 1px solid #ddd;
width: 100%;
 
+   // Override the margins that OOUI suddenly 
added to popup footers (T171302)
+   margin: 0;
+
> .oo-ui-buttonGroupWidget {
display: block;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/366952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.30.0-wmf.10
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] EditPage: Remove legacy non-OOUI render mode

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366872 )

Change subject: [WIP] EditPage: Remove legacy non-OOUI render mode
..

[WIP] EditPage: Remove legacy non-OOUI render mode

Change-Id: I2b468c8b846db015b5a1e3d2500abb8ea252c442
---
M includes/DefaultSettings.php
M includes/EditPage.php
M resources/src/mediawiki.action/mediawiki.action.edit.js
M resources/src/mediawiki.action/mediawiki.action.edit.preview.js
M resources/src/mediawiki.action/mediawiki.action.edit.styles.css
5 files changed, 72 insertions(+), 189 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/72/366872/1

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index f35715e..6d0b252 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -3219,14 +3219,6 @@
 $wgUseMediaWikiUIEverywhere = false;
 
 /**
- * Temporary variable that determines whether the EditPage class should use 
OOjs UI or not.
- * This will be removed later and OOjs UI will become the only option.
- *
- * @since 1.29
- */
-$wgOOUIEditPage = true;
-
-/**
  * Whether to label the store-to-database-and-show-to-others button in the 
editor
  * as "Save page"/"Save changes" if false (the default) or, if true, instead as
  * "Publish page"/"Publish changes".
diff --git a/includes/EditPage.php b/includes/EditPage.php
index 973327b..deb212e 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -414,11 +414,6 @@
private $isOldRev = false;
 
/**
-* @var bool Whether OOUI should be enabled here
-*/
-   private $oouiEnabled = false;
-
-   /**
 * @param Article $article
 */
public function __construct( Article $article ) {
@@ -431,8 +426,6 @@
 
$handler = ContentHandler::getForModelID( $this->contentModel );
$this->contentFormat = $handler->getDefaultFormat();
-
-   $this->oouiEnabled = $this->context->getConfig()->get( 
'OOUIEditPage' );
}
 
/**
@@ -481,14 +474,6 @@
} else {
return $this->mContextTitle;
}
-   }
-
-   /**
-* Check if the edit page is using OOUI controls
-* @return bool
-*/
-   public function isOouiEnabled() {
-   return $this->oouiEnabled;
}
 
/**
@@ -857,9 +842,6 @@
 */
public function importFormData( &$request ) {
global $wgContLang, $wgUser;
-
-   # Allow users to change the mode for testing
-   $this->oouiEnabled = $request->getFuzzyBool( 'ooui', 
$this->oouiEnabled );
 
# Section edit can come from either the form or a link
$this->section = $request->getVal( 'wpSection', 
$request->getVal( 'section' ) );
@@ -2667,7 +2649,7 @@
$wgOut->addHTML( Html::openElement(
'form',
[
-   'class' => $this->oouiEnabled ? 
'mw-editform-ooui' : 'mw-editform-legacy',
+   'class' => 'mw-editform-ooui',
'id' => self::EDITFORM_ID,
'name' => self::EDITFORM_ID,
'method' => 'post',
@@ -2767,13 +2749,8 @@
$wgOut->addHTML( Html::hidden( 'format', $this->contentFormat ) 
);
$wgOut->addHTML( Html::hidden( 'model', $this->contentModel ) );
 
-   // Preserve =1 / =0 from URL parameters after 
submitting the page for preview
-   $wgOut->addHTML( Html::hidden( 'ooui', $this->oouiEnabled ? '1' 
: '0' ) );
-
// following functions will need OOUI, enable it only once; 
here.
-   if ( $this->oouiEnabled ) {
-   $wgOut->enableOOUI();
-   }
+   $wgOut->enableOOUI();
 
if ( $this->section == 'new' ) {
$this->showSummaryInput( true, $this->summary );
@@ -3173,19 +3150,11 @@
}
 
$labelText = $this->context->msg( $isSubjectPreview ? 'subject' 
: 'summary' )->parse();
-   if ( $this->oouiEnabled ) {
-   $wgOut->addHTML( $this->getSummaryInputOOUI(
-   $summary,
-   $labelText,
-   [ 'class' => $summaryClass ]
-   ) );
-   } else {
-   list( $label, $input ) = $this->getSummaryInput(
-   $summary,
-   $labelText,
-   [ 'class' => $summaryClass ]
-   );
-   $wgOut->addHTML( "{$label} {$input}" );
+   $wgOut->addHTML( $this->getSummaryInputOOUI(
+   $summary,

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable OOjs UI EditPage on all wikis except Commons

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366867 )

Change subject: Enable OOjs UI EditPage on all wikis except Commons
..

Enable OOjs UI EditPage on all wikis except Commons

Change-Id: I208f3b4f04b70cf8a32a6267b2cc1dad2793d7c6
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/67/366867/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 6d7302b..7657363 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -14800,10 +14800,8 @@
 // Whether to use OOUI to render the buttons on EditPage.php
 // Temporarily disabled during testing of the feature, 2017-03-24 – T162849.
 'wgOOUIEditPage' => [
-   'default' => false,
-   'mediawikiwiki' => true,
-   'wikipedia' => true,
-   'metawiki' => true,
+   'default' => true,
+   'commonswiki' => false,
 ],
 
 'wgCiteResponsiveReferences' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/366867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I208f3b4f04b70cf8a32a6267b2cc1dad2793d7c6
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable OOjs UI EditPage on all wikis

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366868 )

Change subject: Enable OOjs UI EditPage on all wikis
..

Enable OOjs UI EditPage on all wikis

Change-Id: Ifab9ab17d5bb121f695f16e45803f1e57cf303f7
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
2 files changed, 3 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/68/366868/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 5d77216..8fa3454 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -3479,6 +3479,9 @@
 
 $wgDefaultUserOptions['watchlistdays'] = $wmgWatchlistNumberOfDaysShow;
 
+// Use OOUI to render the buttons on EditPage.php
+$wgOOUIEditPage = true;
+
 if ( $wmgUseWikidataPageBanner ) {
wfLoadExtension( 'WikidataPageBanner' );
 }
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 7657363..ad61dc7 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -14797,13 +14797,6 @@
'default' => false, // T124742
 ],
 
-// Whether to use OOUI to render the buttons on EditPage.php
-// Temporarily disabled during testing of the feature, 2017-03-24 – T162849.
-'wgOOUIEditPage' => [
-   'default' => true,
-   'commonswiki' => false,
-],
-
 'wgCiteResponsiveReferences' => [
'default' => false,
 

-- 
To view, visit https://gerrit.wikimedia.org/r/366868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifab9ab17d5bb121f695f16e45803f1e57cf303f7
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove setting no longer in MediaWiki

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366869 )

Change subject: Remove setting no longer in MediaWiki
..

Remove setting no longer in MediaWiki

Change-Id: I9927c3dae7e1bef098ccf24346a4d13c786c9643
---
M wmf-config/CommonSettings.php
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/69/366869/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 8fa3454..5d77216 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -3479,9 +3479,6 @@
 
 $wgDefaultUserOptions['watchlistdays'] = $wmgWatchlistNumberOfDaysShow;
 
-// Use OOUI to render the buttons on EditPage.php
-$wgOOUIEditPage = true;
-
 if ( $wmgUseWikidataPageBanner ) {
wfLoadExtension( 'WikidataPageBanner' );
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9927c3dae7e1bef098ccf24346a4d13c786c9643
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (be80158a9)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366619 )

Change subject: Update VE core submodule to master (be80158a9)
..

Update VE core submodule to master (be80158a9)

New changes:
e5603a38f Fix indentation of internal list diff spacers

Bug: T171055
Change-Id: I2c646baafd525bfea581e3882ec977885f8c3b65
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/19/366619/1

diff --git a/lib/ve b/lib/ve
index 154f192..be80158 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 154f192b3806aafb68f9d374c27fe42e4921000b
+Subproject commit be80158a97dea36f0a22fcc938cd7ed716790a1b

-- 
To view, visit https://gerrit.wikimedia.org/r/366619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c646baafd525bfea581e3882ec977885f8c3b65
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.action.edit: Add TODO referencing T6714

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366616 )

Change subject: mediawiki.action.edit: Add TODO referencing T6714
..

mediawiki.action.edit: Add TODO referencing T6714

Change-Id: Ifa5ba02d8e45b2529c17ba045e13fd6360569f4b
---
M resources/src/mediawiki.action/mediawiki.action.edit.js
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/16/366616/1

diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.js 
b/resources/src/mediawiki.action/mediawiki.action.edit.js
index 5b81017..1b2fbf5 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.js
@@ -17,7 +17,9 @@
 */
 
$( function () {
-   var editBox, scrollTop, $editForm;
+   var editBox, scrollTop, $editForm,
+   // TOOD T6714: Once this can be adjusted, read this 
from config.
+   summaryByteLimit = 255;
 
if ( $( '#editform' ).hasClass( 'mw-editform-ooui' ) ) {
mw.loader.using( 'oojs-ui-core' ).then( function () {
@@ -30,11 +32,11 @@
// Show a byte-counter to users with how many 
bytes are left for their edit summary.
// TODO: This looks a bit weird, as there is no 
unit in the UI, just numbers; showing
// 'bytes' confused users in testing, and 
showing 'chars' would be a lie. See T42035.
-   mw.widgets.visibleByteLimit( wpSummary, 255 );
+   mw.widgets.visibleByteLimit( wpSummary, 
summaryByteLimit );
} );
} else {
// Make sure edit summary does not exceed byte limit
-   $( '#wpSummary' ).byteLimit( 255 );
+   $( '#wpSummary' ).byteLimit( summaryByteLimit );
}
 
// Restore the edit box scroll state following a preview 
operation,

-- 
To view, visit https://gerrit.wikimedia.org/r/366616
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa5ba02d8e45b2529c17ba045e13fd6360569f4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change 'editfont' default preference to 'monospace'

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366615 )

Change subject: Change 'editfont' default preference to 'monospace'
..

Change 'editfont' default preference to 'monospace'

Also change the user preference order to put the default first and the
least-good option last.

Bug: T171201
Change-Id: Ib4c6cd7f2d98824313c2bfcdf3f71d89fc48c929
---
M includes/DefaultSettings.php
M includes/Preferences.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/15/366615/1

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index f35715e..ac6e558 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -4838,7 +4838,7 @@
'date' => 'default',
'diffonly' => 0,
'disablemail' => 0,
-   'editfont' => 'default',
+   'editfont' => 'monospace',
'editondblclick' => 0,
'editsectiononrightclick' => 0,
'enotifminoredits' => 0,
diff --git a/includes/Preferences.php b/includes/Preferences.php
index 008963b..c572373 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -832,10 +832,10 @@
'section' => 'editing/editor',
'label-message' => 'editfont-style',
'options' => [
-   $context->msg( 'editfont-default' 
)->text() => 'default',
$context->msg( 'editfont-monospace' 
)->text() => 'monospace',
$context->msg( 'editfont-sansserif' 
)->text() => 'sans-serif',
$context->msg( 'editfont-serif' 
)->text() => 'serif',
+   $context->msg( 'editfont-default' 
)->text() => 'default',
]
];
}

-- 
To view, visit https://gerrit.wikimedia.org/r/366615
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4c6cd7f2d98824313c2bfcdf3f71d89fc48c929
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: EditPage: Drop 80% width restriction on wpSummary

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366584 )

Change subject: EditPage: Drop 80% width restriction on wpSummary
..

EditPage: Drop 80% width restriction on wpSummary

Unnecessary, and restricts the flow of the page a little.

Change-Id: I007a92e32a62cdf8a1b3ac479386e32fb54469f5
---
M resources/src/mediawiki.action/mediawiki.action.edit.styles.css
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/84/366584/1

diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.styles.css 
b/resources/src/mediawiki.action/mediawiki.action.edit.styles.css
index 093a26d..3814d21 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.styles.css
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.styles.css
@@ -28,7 +28,6 @@
 .mw-editform-ooui #wpSummaryWidget,
 .mw-editform-legacy #wpSummary {
display: block;
-   width: 80%;
margin-bottom: 1em;
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/366584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I007a92e32a62cdf8a1b3ac479386e32fb54469f5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Live Preview: Cope with the edit summary being an OOjs UI wi...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366570 )

Change subject: Live Preview: Cope with the edit summary being an OOjs UI widget
..

Live Preview: Cope with the edit summary being an OOjs UI widget

Bug: T171156
Change-Id: Idb9118421ffbd438dd7b018a8dbf8bb991036232
---
M resources/src/mediawiki.action/mediawiki.action.edit.preview.js
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/70/366570/1

diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js 
b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
index 2b6fc9d..688a5ab 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
@@ -3,6 +3,8 @@
  */
 ( function ( mw, $ ) {
 
+   var oojsuieditform = $( '#editform' ).hasClass( 'mw-editform-ooui' );
+
/**
 * @ignore
 * @param {jQuery.Event} e
@@ -16,7 +18,15 @@
$wikiDiff = $( '#wikiDiff' );
$editform = $( '#editform' );
$textbox = $editform.find( '#wpTextbox1' );
-   $summary = $editform.find( '#wpSummary' );
+
+   if ( oojsuieditform ) {
+   mw.loader.using( 'oojs-ui-core' ).then( function () {
+   $summary = OO.ui.infuse( $( '#wpSummaryWidget' 
) );
+   } );
+   } else {
+   $summary = $editform.find( '#wpSummary' );
+   }
+
$spinner = $( '.mw-spinner-preview' );
$errorBox = $( '.errorbox' );
section = $editform.find( '[name="wpSection"]' ).val();
@@ -78,7 +88,7 @@
formatversion: 2,
action: 'parse',
title: mw.config.get( 'wgPageName' ),
-   summary: $summary.textSelection( 'getContents' ),
+   summary: oojsuieditform ? $summary.getValue() : 
$summary.val(),
prop: ''
};
 

-- 
To view, visit https://gerrit.wikimedia.org/r/366570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb9118421ffbd438dd7b018a8dbf8bb991036232
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.widgets.visibleByteLimit: Temporarily disable whilst OOjs...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366569 )

Change subject: mw.widgets.visibleByteLimit: Temporarily disable whilst OOjs UI 
label bug is fixed
..

mw.widgets.visibleByteLimit: Temporarily disable whilst OOjs UI label bug is 
fixed

Bug: T169982
Change-Id: If5d2b3d705b121c450f99d3ef61b535e7fc89c04
---
M 
resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/69/366569/1

diff --git 
a/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
 
b/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
index 5678a80..51b9815 100644
--- 
a/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
+++ 
b/resources/src/mediawiki.widgets.visibleByteLimit/mediawiki.widgets.visibleByteLimit.js
@@ -9,12 +9,15 @@
 mediaWiki.widgets.visibleByteLimit = function ( textInputWidget, limit ) {
limit = limit || +textInputWidget.$input.attr( 'maxlength' );
 
+   // Temporarily disabled whilst upstream bug is fixed; T169982
+   /*
function updateCount() {
textInputWidget.setLabel( ( limit - $.byteLength( 
textInputWidget.getValue() ) ).toString() );
}
textInputWidget.on( 'change', updateCount );
// Initialise value
updateCount();
+   */
 
// Actually enforce limit
textInputWidget.$input.byteLimit( limit );

-- 
To view, visit https://gerrit.wikimedia.org/r/366569
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5d2b3d705b121c450f99d3ef61b535e7fc89c04
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: phpcs: Enable MediaWiki.ExtraCharacters.ParenthesesAroundKey...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366494 )

Change subject: phpcs: Enable 
MediaWiki.ExtraCharacters.ParenthesesAroundKeyword.ParenthesesAroundKeywords 
and make pass
..

phpcs: Enable 
MediaWiki.ExtraCharacters.ParenthesesAroundKeyword.ParenthesesAroundKeywords 
and make pass

Also MediaWiki.ExtraCharacters.CharacterBeforePHPOpeningTag.Found whilst we're 
at
it, as there are no issues.

Change-Id: I9310f590e88f97ef9d9f3390426e8c023a09eda8
---
M phpcs.xml
M tests/dbconfigTest.php
M wmf-config/CommonSettings-labs.php
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
M wmf-config/Wikibase.php
M wmf-config/flaggedrevs.php
M wmf-config/liquidthreads.php
M wmf-config/mobile.php
M wmf-config/wikitech.php
10 files changed, 39 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/94/366494/1

diff --git a/phpcs.xml b/phpcs.xml
index 0d80989..5eac3a2 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -11,8 +11,6 @@



-   
-   



diff --git a/tests/dbconfigTest.php b/tests/dbconfigTest.php
index b0acaf7..0122a7e 100644
--- a/tests/dbconfigTest.php
+++ b/tests/dbconfigTest.php
@@ -41,7 +41,7 @@
$wmfMasterDatacenter = $masterdatacenter;
$wmfRealm = $realm;
$wmfDatacenter = $datacenter;
-   include( getRealmSpecificFilename( __DIR__ . 
'/../wmf-config/db.php' ) );
+   include getRealmSpecificFilename( __DIR__ . 
'/../wmf-config/db.php'  );
 
$this->restoreGlobals();
return $wgLBFactoryConf;
diff --git a/wmf-config/CommonSettings-labs.php 
b/wmf-config/CommonSettings-labs.php
index dc724f0..f0f0fd6 100644
--- a/wmf-config/CommonSettings-labs.php
+++ b/wmf-config/CommonSettings-labs.php
@@ -268,7 +268,7 @@
 }
 
 if ( $wmgUseSentry ) {
-   require_once( "$IP/extensions/Sentry/Sentry.php" );
+   require_once "$IP/extensions/Sentry/Sentry.php" ;
$wgSentryDsn = $wmgSentryDsn;
$wgSentryLogPhpErrors = false;
 }
@@ -348,7 +348,7 @@
 
 // Test of new import source configuration on labs cluster
 $wgImportSources = false;
-include( "$wmfConfigDir/import.php" );
+include "$wmfConfigDir/import.php" ;
 $wgHooks['ImportSources'][] = 'wmfImportSources';
 
 // Reenable Preview and Changes tabs for wikieditor preview
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index d213a1c..2f69902 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -109,10 +109,10 @@
 $wmfUdp2logDest = $wmfLocalServices['udp2log'];
 
 # Initialise wgConf
-require( "$wmfConfigDir/wgConf.php" );
+require "$wmfConfigDir/wgConf.php" ;
 function wmfLoadInitialiseSettings( $conf ) {
global $wmfConfigDir;
-   require( "$wmfConfigDir/InitialiseSettings.php" );
+   require "$wmfConfigDir/InitialiseSettings.php" ;
 }
 
 $wgLocalVirtualHosts = [
@@ -138,7 +138,7 @@
if ( $wgCommandLineMode ) {
print "Database name $wgDBname is not listed in dblist\n";
} else {
-   require( "$wmfConfigDir/missing.php" );
+   require "$wmfConfigDir/missing.php" ;
}
exit;
 }
@@ -165,7 +165,7 @@
 
 if ( !$globals ) {
# Get configuration from SiteConfiguration object
-   require( "$wmfConfigDir/InitialiseSettings.php" );
+   require "$wmfConfigDir/InitialiseSettings.php" ;
 
$wikiTags = [];
foreach ( [ 'private', 'fishbowl', 'special', 'closed', 'flow', 
'flaggedrevs', 'small', 'medium',
@@ -210,7 +210,7 @@
 
 # Private settings such as passwords, that shouldn't be published
 # Needs to be before db.php
-require( "$wmfConfigDir/PrivateSettings.php" );
+require "$wmfConfigDir/PrivateSettings.php" ;
 
 $wgMemCachedServers = [];
 
@@ -564,13 +564,13 @@
 if ( $wmfRealm === 'production' ) {
if ( $wmgUseClusterSquid ) {
$wgUseSquid = true;
-   require( "$wmfConfigDir/squid.php" );
+   require "$wmfConfigDir/squid.php" ;
}
 } elseif ( $wmfRealm === 'labs' ) {
$wgStatsdMetricPrefix = 'BetaMediaWiki';
if ( $wmgUseClusterSquid ) {
$wgUseSquid = true;
-   require( "$wmfConfigDir/squid-labs.php" );
+   require "$wmfConfigDir/squid-labs.php" ;
}
 }
 
@@ -683,7 +683,7 @@
 };
 
 if ( $wmgUseTimeline ) {
-   include( "$wmfConfigDir/timeline.php" );
+   include "$wmfConfigDir/timeline.php" ;
 }
 # Most probably only used by EasyTimeline which is conditionally included above
 # but it is hard know whether there other use cases.
@@ -788,7 +788,7 @@
 
 // Per-wiki config for Flagged Revisions
 if ( $wmgUseFlaggedRevs ) {
-   include( "$wmfConfigDir/flaggedrevs.php" );
+   

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: phpcs: Enable MediaWiki.ControlStructures.IfElseStructure.Sp...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366493 )

Change subject: phpcs: Enable 
MediaWiki.ControlStructures.IfElseStructure.Space*Else and make pass
..

phpcs: Enable MediaWiki.ControlStructures.IfElseStructure.Space*Else and make 
pass

Change-Id: Iaa61cc465aa6db0076b57ced482bba3693e40e26
---
M phpcs.xml
M wmf-config/flaggedrevs.php
2 files changed, 45 insertions(+), 132 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/93/366493/1

diff --git a/phpcs.xml b/phpcs.xml
index 3708c21..0d80989 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -11,8 +11,6 @@



-   
-   



diff --git a/wmf-config/flaggedrevs.php b/wmf-config/flaggedrevs.php
index 4fdb13c..1d2bd98 100644
--- a/wmf-config/flaggedrevs.php
+++ b/wmf-config/flaggedrevs.php
@@ -30,23 +30,17 @@
 if ( $wgDBname == 'alswiki' ) {
$wgFlaggedRevsOverride = false;
$wgGroupPermissions['sysop']['stablesettings'] = true; // -aaron 3/20/10
-}
-
-elseif ( $wgDBname == 'arwiki' ) {
+} elseif ( $wgDBname == 'arwiki' ) {
$wgFlaggedRevsWhitelist = [ 'الصفحة_الرئيسية' ];
$wgFlaggedRevsNamespaces = array_merge( $wgFlaggedRevsNamespaces, [ 
100, 104 ] ); // T21332
-}
-
-elseif ( $wgDBname == 'bewiki' ) {
+} elseif ( $wgDBname == 'bewiki' ) {
$wgFlaggedRevsOverride = false;
$wgFlaggedRevsNamespaces[] = NS_CATEGORY;
$wgFlaggedRevsTags['accuracy']['levels'] = 1;
$wgGroupPermissions['autoeditor']['autoreview'] = true;
$wgGroupPermissions['autoeditor']['autoconfirmed'] = true;
$wgGroupPermissions['sysop']['stablesettings'] = true;
-}
-
-elseif ( $wgDBname == 'bnwiki' ) { // T30717
+} elseif ( $wgDBname == 'bnwiki' ) { // T30717
$wgFlaggedRevsNamespaces = [ NS_MAIN, NS_PROJECT ];
# Show only on a per-page basis
$wgFlaggedRevsOverride = false;
@@ -77,9 +71,7 @@
unset( $wgGroupPermissions['editor'] );
$wgAddGroups['sysop'] = array_diff( $wgAddGroups['sysop'], [ 'editor' ] 
);
$wgRemoveGroups['sysop'] = array_diff( $wgRemoveGroups['sysop'], [ 
'editor' ] );
-}
-
-elseif ( $wgDBname == 'bswiki' ) { //T158662
+} elseif ( $wgDBname == 'bswiki' ) { //T158662
 
$wgFlaggedRevsTags = [
'status' => [ 'levels' => 1, 'quality' => 2, 'pristine' => 3 ],
@@ -88,9 +80,7 @@
$wgGroupPermissions['sysop']['stablesettings'] = true;
#Remove reviewer group
unset( $wgGroupPermissions['reviewer'] );
-}
-
-elseif ( $wgDBname == 'cewiki' ) { // based on ruwiki settings
+} elseif ( $wgDBname == 'cewiki' ) { // based on ruwiki settings
 
// T58408
$wgFlaggedRevsNamespaces = [ NS_MAIN, NS_FILE, NS_TEMPLATE, 
NS_CATEGORY, 100, 828 ];
@@ -102,9 +92,7 @@
$wgGroupPermissions['autoeditor']['autoconfirmed'] = true;
 
$wgGroupPermissions['sysop']['stablesettings'] = true;
-}
-
-elseif ( $wgDBname == 'ckbwiki' ) {
+} elseif ( $wgDBname == 'ckbwiki' ) {
# Namespaces
$wgFlaggedRevsNamespaces = [ NS_MAIN, NS_PROJECT, NS_HELP, NS_TEMPLATE, 
NS_CATEGORY, NS_FILE, 100, 102, 828 ];
# Show only on a per-page basis
@@ -137,18 +125,14 @@
unset( $wgGroupPermissions['editor'], $wgGroupPermissions['autoreview'] 
);
$wgAddGroups['sysop'] = array_diff( $wgAddGroups['sysop'], [ 'editor', 
'autoreview' ] );
$wgRemoveGroups['sysop'] = array_diff( $wgRemoveGroups['sysop'], [ 
'editor', 'autoreview' ] );
-}
-
-elseif ( $wgDBname == 'testwiki' && false ) {
+} elseif ( $wgDBname == 'testwiki' && false ) {
// Disabled temporarily, give testwiki enwiki's settings instead --Roan 
May 7 2012
$wgGroupsAddToSelf['*'][] = 'editor';
$wgGroupsAddToSelf['*'][] = 'reviewer';
$wgGroupsRemoveFromSelf['*'][] = 'editor';
$wgGroupsRemoveFromSelf['*'][] = 'reviewer';
$wgFlaggedRevsAutopromote = $wmfStandardAutoPromote;
-}
-
-elseif ( $wgDBname == 'test2wiki' ) {
+} elseif ( $wgDBname == 'test2wiki' ) {
$wgFlaggedRevsNamespaces[] = NS_CATEGORY;
$wgFlaggedRevsTags['accuracy']['levels'] = 1;
 
@@ -173,9 +157,7 @@
];
 
$wgGroupPermissions['sysop']['stablesettings'] = true; // -aaron 3/20/10
-}
-
-elseif ( $wgDBname == 'cawikinews' ) {
+} elseif ( $wgDBname == 'cawikinews' ) {
$wgFlaggedRevsNamespaces[] = 102; // T36135
 
$wgGroupPermissions['editor']['autopatrol'] = true; // T95085
@@ -194,8 +176,7 @@
 }
 
 // New deployment 2008-05-03
-// --brion
-elseif ( $wgDBname == 'dewiki' ) {
+ elseif ( $wgDBname == 'dewiki' ) {
$wgFlaggedRevsNamespaces[] = NS_CATEGORY;
$wgFlaggedRevsTags['accuracy']['levels'] = 1;
 
@@ -220,13 +201,9 @@
];
 
$wgGroupPermissions['sysop']['stablesettings'] = true; // -aaron 3/20/10

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: phpcs: Enable MediaWiki.WhiteSpace.MultipleEmptyLines.Multip...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366495 )

Change subject: phpcs: Enable 
MediaWiki.WhiteSpace.MultipleEmptyLines.MultipleEmptyLines and make pass
..

phpcs: Enable MediaWiki.WhiteSpace.MultipleEmptyLines.MultipleEmptyLines and 
make pass

Change-Id: I13051dc8bd3e3b354627793f36bf62028d730da7
---
M phpcs.xml
M search-redirect.php
M tests/dblistTest.php
M tests/timelineTest.php
M wmf-config/CirrusSearch-common.php
M wmf-config/CommonSettings-labs.php
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
M wmf-config/StartProfiler.php
M wmf-config/db-eqiad.php
M wmf-config/flaggedrevs.php
M wmf-config/logging.php
12 files changed, 0 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/95/366495/1

diff --git a/phpcs.xml b/phpcs.xml
index 5eac3a2..808266a 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -15,7 +15,6 @@



-   



diff --git a/search-redirect.php b/search-redirect.php
index ea7169f..12afdd3 100644
--- a/search-redirect.php
+++ b/search-redirect.php
@@ -14,7 +14,6 @@
$proto = 'http';
 }
 
-
 // validate $language
 if ( !preg_match( '/^[a-zA-Z\-]*$/', $language ) ) {
$language = 'en';
diff --git a/tests/dblistTest.php b/tests/dblistTest.php
index 9af9d62..b3c9b49 100644
--- a/tests/dblistTest.php
+++ b/tests/dblistTest.php
@@ -8,7 +8,6 @@
  * @file
  */
 
-
 class DbListTests extends PHPUnit_Framework_TestCase {
 
public static function provideProjectDbnames() {
@@ -51,7 +50,6 @@
 
// Content of all.dblist
$all = $lists['all'];
-
 
// dblist files that are exceptions
$skip = array(
diff --git a/tests/timelineTest.php b/tests/timelineTest.php
index 90993a4..4540d75 100644
--- a/tests/timelineTest.php
+++ b/tests/timelineTest.php
@@ -13,7 +13,6 @@
$this->assertStringEndsNotWith( '.ttf', $filename );
}
 
-
/**
 * @dataProvider wgTimelineFontFileValues
 */
diff --git a/wmf-config/CirrusSearch-common.php 
b/wmf-config/CirrusSearch-common.php
index a99774e..46e4aef 100644
--- a/wmf-config/CirrusSearch-common.php
+++ b/wmf-config/CirrusSearch-common.php
@@ -94,7 +94,6 @@
$wgCirrusSearchWikimediaExtraPlugin['token_count_router'] = true;
 }
 
-
 # Enable the "experimental" highlighter on all wikis
 $wgCirrusSearchUseExperimentalHighlighter = true;
 $wgCirrusSearchOptimizeIndexForExperimentalHighlighter = true;
diff --git a/wmf-config/CommonSettings-labs.php 
b/wmf-config/CommonSettings-labs.php
index f0f0fd6..bb47338 100644
--- a/wmf-config/CommonSettings-labs.php
+++ b/wmf-config/CommonSettings-labs.php
@@ -367,7 +367,6 @@
$wg3dProcessor = ['/usr/bin/xvfb-run', '-a', '-s', '-ac -screen 0 
1280x1024x24' ,'/srv/deployment/3d2png/deploy/src/3d2png.js'];
 }
 
-
 $wgAuthManagerAutoConfig['preauth'][GuanacoProvider::class] = [
'class' => GuanacoProvider::class,
'sort' => 0,
@@ -405,6 +404,5 @@
return \StatusValue::newGood();
}
 }
-
 
 } # end safeguard
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 2f69902..8a9d5f9 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -465,7 +465,6 @@
 $wgBotPasswordsCluster = $wmgBotPasswordsCluster;
 $wgBotPasswordsDatabase = $wmgBotPasswordsDatabase;
 
-
 if ( PHP_SAPI === 'cli' ) {
$wgShowExceptionDetails = true;
$wgShowDBErrorBacktrace = true;
@@ -929,7 +928,6 @@
];
$wgUrlShortenerReadOnly = true;
 }
-
 
 if ( $wmgPFEnableStringFunctions ) {
$wgPFEnableStringFunctions = true;
@@ -2765,7 +2763,6 @@
 if ( $wmgUseThanks ) {
wfLoadExtension( 'Thanks' );
 }
-
 
 // Flow configuration
 
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 686dfdb..d01fd86 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -1462,8 +1462,6 @@
'zhwiki' => [ '1.5x' => '/static/images/project-logos/zhwiki-1.5x.png', 
'2x' => '/static/images/project-logos/zhwiki-2x.png' ],
'zh_yuewiki' => [ '1.5x' => 
'/static/images/project-logos/zh_yuewiki-1.5x.png', '2x' => 
'/static/images/project-logos/zh_yuewiki-2x.png' ], // T150618
 
-
-
 # Wiktionary
 'amwiktionary' => [ '1.5x' => 
'/static/images/project-logos/amwiktionary-1.5x.png', '2x' => 
'/static/images/project-logos/amwiktionary-2x.png' ], // T150618
'arwiktionary' => [ '1.5x' => 
'/static/images/project-logos/arwiktionary-1.5x.png', '2x' => 
'/static/images/project-logos/arwiktionary-2x.png' ], // T150618
@@ -1556,7 +1554,6 @@
'suwikiquote' => [ '1.5x' => 
'/static/images/project-logos/suwikiquote-1.5x.png', '2x' => 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RC Filters: Tweak i18n for latest/not latest revision filter

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366313 )

Change subject: RC Filters: Tweak i18n for latest/not latest revision filter
..

RC Filters: Tweak i18n for latest/not latest revision filter

Bug: T166600
Change-Id: I5237cb0f87b3a340eb3fb8198a4ba39d679c6fe3
---
M languages/i18n/en.json
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/13/366313/1

diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index e0ac829..43d579d 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1436,11 +1436,11 @@
"rcfilters-hideminor-conflicts-typeofchange-global": "The \"Minor 
edits\" filter conflicts with one or more Type of change filters, because 
certain types of change cannot be designated as \"minor\". The conflicting 
filters are marked in the Active filters area, above.",
"rcfilters-hideminor-conflicts-typeofchange": "Certain types of change 
cannot be designated as \"minor\", so this filter conflicts with the following 
Type of Change filters: $1",
"rcfilters-typeofchange-conflicts-hideminor": "This Type of change 
filter conflicts with the \"Minor edits\" filter. Certain types of change 
cannot be designated as \"minor\".",
-   "rcfilters-filtergroup-lastRevision": "Last revision",
-   "rcfilters-filter-lastrevision-label": "Last revision",
-   "rcfilters-filter-lastrevision-description": "The most recent change to 
a page.",
-   "rcfilters-filter-previousrevision-label": "Earlier revisions",
-   "rcfilters-filter-previousrevision-description": "All changes that are 
not the most recent change to a page.",
+   "rcfilters-filtergroup-lastRevision": "Latest revisions",
+   "rcfilters-filter-lastrevision-label": "Latest revision",
+   "rcfilters-filter-lastrevision-description": "Only the most recent 
change to a page.",
+   "rcfilters-filter-previousrevision-label": "Not the latest revision",
+   "rcfilters-filter-previousrevision-description": "All changes that are 
not the \"latest revision\".",
"rcfilters-filter-excluded": "Excluded",
"rcfilters-tag-prefix-namespace": ":$1",
"rcfilters-tag-prefix-namespace-inverted": ":not $1",

-- 
To view, visit https://gerrit.wikimedia.org/r/366313
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5237cb0f87b3a340eb3fb8198a4ba39d679c6fe3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: mw.Upload.Dialog: Define .static.name

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366262 )

Change subject: mw.Upload.Dialog: Define .static.name
..

mw.Upload.Dialog: Define .static.name

Bug: T164999
Change-Id: I0e5d11bdeac1ea60caaa146041057e7a9faf351c
(cherry picked from commit 75c3d36ff7bf3c5dc1c37341ddfb9c4160be11df)
---
M resources/src/mediawiki/mediawiki.Upload.Dialog.js
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/62/366262/1

diff --git a/resources/src/mediawiki/mediawiki.Upload.Dialog.js 
b/resources/src/mediawiki/mediawiki.Upload.Dialog.js
index 9d9c0a6..1809617 100644
--- a/resources/src/mediawiki/mediawiki.Upload.Dialog.js
+++ b/resources/src/mediawiki/mediawiki.Upload.Dialog.js
@@ -58,6 +58,12 @@
 
/**
 * @inheritdoc
+* @property name
+*/
+   mw.Upload.Dialog.static.name = 'mwUploadDialog';
+
+   /**
+* @inheritdoc
 * @property title
 */
mw.Upload.Dialog.static.title = mw.msg( 'upload-dialog-title' );

-- 
To view, visit https://gerrit.wikimedia.org/r/366262
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e5d11bdeac1ea60caaa146041057e7a9faf351c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_29
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[master]: Hooks::onBeforePageDisplay: Don't show a Beta Features invit...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366172 )

Change subject: Hooks::onBeforePageDisplay: Don't show a Beta Features invite 
on non-BF wikis
..

Hooks::onBeforePageDisplay: Don't show a Beta Features invite on non-BF wikis

Bug: T165822
Change-Id: If770a109e24eae741ac8767a00cfd99752a3e95a
---
M WikimediaMessages.hooks.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMessages 
refs/changes/72/366172/1

diff --git a/WikimediaMessages.hooks.php b/WikimediaMessages.hooks.php
index 4733df2..685794f 100644
--- a/WikimediaMessages.hooks.php
+++ b/WikimediaMessages.hooks.php
@@ -1300,6 +1300,7 @@
GuidedTourLauncher::launchTourByCookie( 
'RcFiltersInvite', 'Confirm' );
}
} elseif (
+   class_exists( 'BetaFeatures' ) &&
!$user->getOption( 
'rcenhancedfilters-seen-invite' ) &&
!$user->getOption( 
'rcenhancedfilters-seen-tour' )
) {

-- 
To view, visit https://gerrit.wikimedia.org/r/366172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If770a109e24eae741ac8767a00cfd99752a3e95a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMessages
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Change `What's this?` i18n based on user testing

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366169 )

Change subject: RCFilters: Change `What's this?` i18n based on user testing
..

RCFilters: Change `What's this?` i18n based on user testing

Also minor tweak to the qqq to help translators understand.

Bug: T169053
Change-Id: If5aebae20d2e0037b28090d85cd9b076ac4b3178
---
M languages/i18n/en.json
M languages/i18n/qqq.json
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/69/366169/1

diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 64f9b7b..a76eafc 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1371,7 +1371,7 @@
"rcfilters-invalid-filter": "Invalid filter",
"rcfilters-empty-filter": "No active filters. All contributions are 
shown.",
"rcfilters-filterlist-title": "Filters",
-   "rcfilters-filterlist-whatsthis": "What's this?",
+   "rcfilters-filterlist-whatsthis": "How do these work?",
"rcfilters-filterlist-feedbacklink": "Provide feedback on the new 
(beta) filters",
"rcfilters-highlightbutton-title": "Highlight results",
"rcfilters-highlightmenu-title": "Select a color",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index d98f8b0..c8f0e06 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -1561,7 +1561,7 @@
"rcfilters-invalid-filter": "A label for an invalid filter.",
"rcfilters-empty-filter": "Placeholder for the filter list when no 
filters were chosen.",
"rcfilters-filterlist-title": "Title for the filters 
list.\n{{Identical|Filter}}",
-   "rcfilters-filterlist-whatsthis": "Caption for the link that opens a 
popup with explanations about this filter group.",
+   "rcfilters-filterlist-whatsthis": "Caption for the link that opens a 
popup with explanations about this filter group, explaining what it is and how 
it works.",
"rcfilters-filterlist-feedbacklink": "Caption for the link to the 
feedback page about the filters beta feature.",
"rcfilters-highlightbutton-title": "Title for the highlight button used 
to toggle the highlight feature on and off.",
"rcfilters-highlightmenu-title": "Title for the highlight menu used to 
select the highlight color for an individual filter.",

-- 
To view, visit https://gerrit.wikimedia.org/r/366169
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5aebae20d2e0037b28090d85cd9b076ac4b3178
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: tests: Move QUnit fiddles to VE-core-only file

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366027 )

Change subject: tests: Move QUnit fiddles to VE-core-only file
..

tests: Move QUnit fiddles to VE-core-only file

Change-Id: I3f214fb1d5d78a82b367cdb6b896a1020b00685e
---
M build/modules.json
M tests/index.html
M tests/ve.qunit.js
A tests/ve.qunit.local.js
M tests/ve.test.utils.js
5 files changed, 37 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/27/366027/1

diff --git a/build/modules.json b/build/modules.json
index dd14f92..da2c0de 100644
--- a/build/modules.json
+++ b/build/modules.json
@@ -663,6 +663,7 @@
"visualEditor.test": {
"scripts": [
"tests/ve.qunit.js",
+   "tests/ve.qunit.local.js",
"tests/ve.test.utils.js",
"tests/ve.test.js",
"tests/ve.EventSequencer.test.js",
diff --git a/tests/index.html b/tests/index.html
index 0769b6e..f54e1d6 100644
--- a/tests/index.html
+++ b/tests/index.html
@@ -447,6 +447,7 @@
 


+   



diff --git a/tests/ve.qunit.js b/tests/ve.qunit.js
index 12697b3..380800e 100644
--- a/tests/ve.qunit.js
+++ b/tests/ve.qunit.js
@@ -341,5 +341,4 @@
 
return $div.html();
};
-
 }( QUnit ) );
diff --git a/tests/ve.qunit.local.js b/tests/ve.qunit.local.js
new file mode 100644
index 000..c9a712f
--- /dev/null
+++ b/tests/ve.qunit.local.js
@@ -0,0 +1,35 @@
+/*!
+ * VisualEditor core-only plugin for QUnit.
+ *
+ * @copyright 2011-2017 VisualEditor Team and others; see 
http://ve.mit-license.org
+ */
+
+// Extend QUnit.module to provide a fixture element. This used to be in 
tests/index.html, but
+// dynamic test runners like Karma build their own web page.
+( function ( QUnit ) {
+   var orgModule = QUnit.module;
+
+   QUnit.dump.maxDepth = 10;
+
+   QUnit.module = function ( name, localEnv ) {
+   localEnv = localEnv || {};
+   orgModule( name, {
+   beforeEach: function () {
+   this.fixture = document.createElement( 'div' );
+   this.fixture.id = 'qunit-fixture';
+   document.body.appendChild( this.fixture );
+
+   if ( localEnv.beforeEach ) {
+   localEnv.beforeEach.call( this );
+   }
+   },
+   afterEach: function () {
+   if ( localEnv.afterEach ) {
+   localEnv.afterEach.call( this );
+   }
+
+   this.fixture.parentNode.removeChild( 
this.fixture );
+   }
+   } );
+   };
+}( QUnit ) );
diff --git a/tests/ve.test.utils.js b/tests/ve.test.utils.js
index 5c833b5..bb9ff2a 100644
--- a/tests/ve.test.utils.js
+++ b/tests/ve.test.utils.js
@@ -52,36 +52,6 @@
// Disable scroll animatinos
ve.scrollIntoView = function () {};
 
-   // Extend QUnit.module to provide a fixture element. This used to be in 
tests/index.html, but
-   // dynamic test runners like Karma build their own web page.
-   ( function () {
-   var orgModule = QUnit.module;
-
-   QUnit.dump.maxDepth = 10;
-
-   QUnit.module = function ( name, localEnv ) {
-   localEnv = localEnv || {};
-   orgModule( name, {
-   beforeEach: function () {
-   this.fixture = document.createElement( 
'div' );
-   this.fixture.id = 'qunit-fixture';
-   document.body.appendChild( this.fixture 
);
-
-   if ( localEnv.beforeEach ) {
-   localEnv.beforeEach.call( this 
);
-   }
-   },
-   afterEach: function () {
-   if ( localEnv.afterEach ) {
-   localEnv.afterEach.call( this );
-   }
-
-   this.fixture.parentNode.removeChild( 
this.fixture );
-   }
-   } );
-   };
-   }() );
-
ve.test.utils.runIsolateTest = function ( assert, type, range, 
expected, label ) {
var data,
doc = ve.dm.example.createExampleDocument( 
'isolationData' ),

-- 
To view, visit 

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Drop MFAllowNonJavaScriptEditing and Special:Mobile...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365997 )

Change subject: Hygiene: Drop MFAllowNonJavaScriptEditing and 
Special:MobileEditor
..

Hygiene: Drop MFAllowNonJavaScriptEditing and Special:MobileEditor

Bug: T125174
Change-Id: I33c990e8399174a59ab022e6ed770f8592680f71
---
M MobileFrontend.alias.php
M README.md
M extension.json
M includes/MobileFrontend.hooks.php
D includes/specials/SpecialMobileEditor.php
5 files changed, 1 insertion(+), 141 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/97/365997/1

diff --git a/MobileFrontend.alias.php b/MobileFrontend.alias.php
index d393cd7..02850bc 100644
--- a/MobileFrontend.alias.php
+++ b/MobileFrontend.alias.php
@@ -15,7 +15,6 @@
'MobileOptions' => [ 'MobileOptions' ],
'Uploads' => [ 'Uploads' ],
'MobileDiff' => [ 'MobileDiff' ],
-   'MobileEditor' => [ 'MobileEditor' ],
'MobileMenu' => [ 'MobileMenu' ],
'MobileLanguages' => [ 'MobileLanguages' ],
'Nearby' => [ 'Nearby' ],
@@ -34,7 +33,6 @@
'MobileOptions' => [ 'خيارات_المحمول' ],
'Uploads' => [ 'مرفوعات' ],
'MobileDiff' => [ 'فرق_المحمول' ],
-   'MobileEditor' => [ 'محرر_المحمول' ],
'MobileMenu' => [ 'قائمة_المحمول' ],
'MobileLanguages' => [ 'لغات_المحمول' ],
'Nearby' => [ 'قريب' ],
@@ -46,7 +44,6 @@
'MobileOptions' => [ 'خيارات_الموبايل' ],
'Uploads' => [ 'مرفوعات' ],
'MobileDiff' => [ 'فرق_الموبايل' ],
-   'MobileEditor' => [ 'محرر_الموبايل' ],
'MobileMenu' => [ 'قايمه_الموبايل' ],
'MobileLanguages' => [ 'لغات_الموبايل' ],
'Nearby' => [ 'قريب' ],
@@ -79,7 +76,6 @@
'MobileOptions' => [ 'موبایل_ئی_تنزیمان' ],
'Uploads' => [ 'بُرز_بوته_ئینان' ],
'MobileDiff' => [ 'موبایل_ئی_پرک' ],
-   'MobileEditor' => [ 'موبایل_ئی_دستکار' ],
'MobileMenu' => [ 'موبایل_ئی_مینو' ],
'MobileLanguages' => [ 'موبایل_ئی_زبانان' ],
'Nearby' => [ 'بئ_نزینکی_ئا' ],
@@ -92,7 +88,6 @@
'MobileOptions' => [ 'মোবাইল_বিকল্প' ],
'Uploads' => [ 'আপলোডসমূহ' ],
'MobileDiff' => [ 'মোবাইল_পার্থক্য' ],
-   'MobileEditor' => [ 'মোবাইল_সম্পাদক' ],
'MobileMenu' => [ 'মোবাইল_মেনু' ],
'MobileLanguages' => [ 'মোবাইল_ভাষাসমূহ' ],
'Nearby' => [ 'কাছাকাছি' ],
@@ -119,7 +114,6 @@
'MobileOptions' => [ 'Mobilní_nastavení' ],
'Uploads' => [ 'Vaše_soubory' ],
'MobileDiff' => [ 'Mobilní_rozdíl' ],
-   'MobileEditor' => [ 'Mobilní_editor' ],
'MobileMenu' => [ 'Mobilní_menu' ],
'MobileLanguages' => [ 'Mobilní_jazyky' ],
'Nearby' => [ 'Poblíž' ],
@@ -131,7 +125,6 @@
'MobileOptions' => [ 'Mobile_Optionen' ],
'Uploads' => [ 'Hochgeladene_Dateien' ],
'MobileDiff' => [ 'Mobiler_Unterschied' ],
-   'MobileEditor' => [ 'Mobiler_Editor' ],
'MobileMenu' => [ 'Mobiles_Menü' ],
'MobileLanguages' => [ 'Mobile_Sprachen' ],
'Nearby' => [ 'In_der_Nähe' ],
@@ -143,7 +136,6 @@
'MobileOptions' => [ 'MobilWeçenegi' ],
'Uploads' => [ 'Barkerdışi' ],
'MobileDiff' => [ 'MobilVer' ],
-   'MobileEditor' => [ 'MobilVurnayoğ' ],
'MobileMenu' => [ 'MıobilMenu' ],
'MobileLanguages' => [ 'MobilZıwani' ],
'Nearby' => [ 'Nezdıra' ],
@@ -170,7 +162,6 @@
'MobileOptions' => [ 'Mobiili_suvandid' ],
'Uploads' => [ 'Üleslaaditud_failid' ],
'MobileDiff' => [ 'Mobiilierinevus' ],
-   'MobileEditor' => [ 'Mobiiliredaktor' ],
'MobileMenu' => [ 'Mobiili_menüü' ],
'MobileLanguages' => [ 'Mobiilikeeled' ],
'Nearby' => [ 'Lähikond' ],
@@ -182,7 +173,6 @@
'MobileOptions' => [ 'گزینه‌های_گوشی_همراه' ],
'Uploads' => [ 'بارگذاری‌ها' ],
'MobileDiff' => [ 'تفاوت_گوشی_همراه' ],
-   'MobileEditor' => [ 'ویرایشگر_گوشی_همراه' ],
'MobileMenu' => [ 'گزینگان_گوشی_همراه' ],
'MobileLanguages' => [ 'زبان‌های_گوشی_همراه' ],
'Nearby' => [ 'درنزدیکی', 'در_نزدیکی' ],
@@ -200,7 +190,6 @@
'MobileOptions' => [ 'הגדרות_נייד', 'הגדרות_פלאפון', 'הגדרות_סלולרי' ],
'Uploads' => [ 'העלאות' ],
'MobileDiff' => [ 'השוואה_ניידת' ],
-   'MobileEditor' => [ 'עריכה_ניידת' ],
'MobileMenu' => [ 'תפריט_נייד' ],
'MobileLanguages' => [ 'שפות_בנייד' ],
'Nearby' => [ 'בסביבה', 'קרוב' ],
@@ -210,7 +199,6 @@
 $specialPageAliases['hi'] = [
'History' => [ 'इतिहास' ],
'MobileOptions' => [ 'मोबाइल_विकल्प' ],
-   'MobileEditor' => [ 'मोबाइल_सम्पादक' ],
'MobileLanguages' => [ 'मोबाइल_भाषा' ],
'Nearby' => [ 'आस-पास' ],
 ];
@@ -221,7 +209,6 @@
'MobileOptions' => [ 'Mobilne_opcije' ],
'Uploads' => [ 'Nahrate_dataje' ],
'MobileDiff' => [ 'Mobilny_rozdźěl' ],
-   

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: build: Pin npm packages for CI stability

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365996 )

Change subject: build: Pin npm packages for CI stability
..

build: Pin npm packages for CI stability

This makes the repo consistent with general Wikimedia practice.

Change-Id: I0021620c27e9bcfcd62b1d4fbb94b949c4b2b3ad
---
M package.json
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/96/365996/1

diff --git a/package.json b/package.json
index 4f10976..59d8ab9 100644
--- a/package.json
+++ b/package.json
@@ -11,14 +11,14 @@
},
"devDependencies": {
"eslint-config-wikimedia": "0.4.0",
-   "grunt": "^1.0.1",
-   "grunt-banana-checker": "^0.6.0",
-   "grunt-contrib-watch": "^1.0.0",
+   "grunt": "1.0.1",
+   "grunt-banana-checker": "0.6.0",
+   "grunt-contrib-watch": "1.0.0",
"grunt-eslint": "20.0.0",
-   "grunt-jsonlint": "^1.1.0",
-   "grunt-notify": "^0.4.5",
+   "grunt-jsonlint": "1.1.0",
+   "grunt-notify": "0.4.5",
"grunt-stylelint": "0.8.0",
-   "resource-modules": "^1.0.17",
+   "resource-modules": "1.0.17",
"stylelint": "7.8.0",
"stylelint-config-wikimedia": "0.4.1"
}

-- 
To view, visit https://gerrit.wikimedia.org/r/365996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0021620c27e9bcfcd62b1d4fbb94b949c4b2b3ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (354a4738a)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365791 )

Change subject: Update VE core submodule to master (354a4738a)
..

Update VE core submodule to master (354a4738a)

New changes:
86913b32a build: Upgrade QUnit to 2.x
af71dc077 tests: Simplify Platform test beforeEach/afterEach logic

Bug: T170585
Change-Id: I741bc01734922e9df15fbab87ffaa173110e
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/91/365791/1

diff --git a/lib/ve b/lib/ve
index 31ed225..354a473 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 31ed225570437c6f42ecfb9ff8d9b265bd0ec66c
+Subproject commit 354a4738ac5d625b2210b014e6db6425d31a1ba2

-- 
To view, visit https://gerrit.wikimedia.org/r/365791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I741bc01734922e9df15fbab87ffaa173110e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: tests: Make Cite compatible with QUnit 2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365685 )

Change subject: tests: Make Cite compatible with QUnit 2
..

tests: Make Cite compatible with QUnit 2

Replacing QUnit.setup()/QUnit.teardown() with the already-available-
in-qunit-1.x QUnit.beforeEach()/QUnit.afterEach() methods.

Bug: T170873
Change-Id: I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7
---
M modules/ve-cite/tests/ve.ui.MWWikitextStringTransferHandler.test.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cite 
refs/changes/85/365685/1

diff --git 
a/modules/ve-cite/tests/ve.ui.MWWikitextStringTransferHandler.test.js 
b/modules/ve-cite/tests/ve.ui.MWWikitextStringTransferHandler.test.js
index 9072a8e..9617e6a 100644
--- a/modules/ve-cite/tests/ve.ui.MWWikitextStringTransferHandler.test.js
+++ b/modules/ve-cite/tests/ve.ui.MWWikitextStringTransferHandler.test.js
@@ -8,12 +8,12 @@
 window.MWWIKITEXT_MOCK_API = true;
 
 QUnit.module( 've.ui.MWWikitextStringTransferHandler (Cite)', 
QUnit.newMwEnvironment( {
-   setup: function () {
+   beforeEach: function () {
// Mock XHR for mw.Api()
this.server = window.MWWIKITEXT_MOCK_API ? 
this.sandbox.useFakeServer() : null;
ve.test.utils.mwEnvironment.setup.call( this );
},
-   teardown: ve.test.utils.mwEnvironment.teardown
+   afterEach: ve.test.utils.mwEnvironment.teardown
 } ) );
 
 /* Tests */

-- 
To view, visit https://gerrit.wikimedia.org/r/365685
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: tests: Make VisualEditor-MediaWiki compatible with QUnit 2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365682 )

Change subject: tests: Make VisualEditor-MediaWiki compatible with QUnit 2
..

tests: Make VisualEditor-MediaWiki compatible with QUnit 2

Replacing QUnit.setup()/QUnit.teardown() with the already-available-
in-qunit-1.x QUnit.beforeEach()/QUnit.afterEach() methods.

Bug: T170872
Change-Id: I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7
---
M 
modules/ve-mw/tests/ui/datatransferhandlers/ve.ui.MWWikitextStringTransferHandler.test.js
M modules/ve-mw/tests/ve.test.utils.js
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/82/365682/1

diff --git 
a/modules/ve-mw/tests/ui/datatransferhandlers/ve.ui.MWWikitextStringTransferHandler.test.js
 
b/modules/ve-mw/tests/ui/datatransferhandlers/ve.ui.MWWikitextStringTransferHandler.test.js
index f6eda3e..1c736e8 100644
--- 
a/modules/ve-mw/tests/ui/datatransferhandlers/ve.ui.MWWikitextStringTransferHandler.test.js
+++ 
b/modules/ve-mw/tests/ui/datatransferhandlers/ve.ui.MWWikitextStringTransferHandler.test.js
@@ -7,12 +7,12 @@
 window.MWWIKITEXT_MOCK_API = true;
 
 QUnit.module( 've.ui.MWWikitextStringTransferHandler', QUnit.newMwEnvironment( 
{
-   setup: function () {
+   beforeEach: function () {
// Mock XHR for mw.Api()
this.server = window.MWWIKITEXT_MOCK_API ? 
this.sandbox.useFakeServer() : null;
ve.test.utils.mwEnvironment.setup.call( this );
},
-   teardown: ve.test.utils.mwEnvironment.teardown
+   afterEach: ve.test.utils.mwEnvironment.teardown
 } ) );
 
 /* Tests */
diff --git a/modules/ve-mw/tests/ve.test.utils.js 
b/modules/ve-mw/tests/ve.test.utils.js
index b140dae..907f006 100644
--- a/modules/ve-mw/tests/ve.test.utils.js
+++ b/modules/ve-mw/tests/ve.test.utils.js
@@ -96,8 +96,8 @@
teardownOverrides();
 
return QUnit.newMwEnvironment( {
-   setup: setupOverrides,
-   teardown: teardownOverrides
+   beforeEach: setupOverrides,
+   afterEach: teardownOverrides
} );
 }() );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/365682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (a0a86ff48)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365423 )

Change subject: Update VE core submodule to master (a0a86ff48)
..

Update VE core submodule to master (a0a86ff48)

New changes:
9ba233409 VisualDiff: Use  and  on whole paragraphs
8d9068029 Update OOjs UI to v0.22.3
d12bb03d7 Avoid deprecated QUnit.asyncTest() in ve.init.sa.Platform.test
a0a86ff48 tests: Avoid deprecated QUnit.push()

Bug: T170136
Change-Id: I50c45fc9826a21810ebd4f4fed5f7b0acb341d13
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/23/365423/1

diff --git a/lib/ve b/lib/ve
index c9b0d1a..a0a86ff 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit c9b0d1a232fa8ab7d160c2e88691799252a56853
+Subproject commit a0a86ff48ec98003731ad10229412e2b97bdea21

-- 
To view, visit https://gerrit.wikimedia.org/r/365423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50c45fc9826a21810ebd4f4fed5f7b0acb341d13
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: [WIP] build: Upgrade QUnit to 2.x

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365039 )

Change subject: [WIP] build: Upgrade QUnit to 2.x
..

[WIP] build: Upgrade QUnit to 2.x

 karma-qunit  1.0.0  →   1.2.1
 qunitjs 1.23.1  →   2.4.0

Bug: T170585
Change-Id: I76777cd5ff96d13588b8bc25744bb41402a495cd
---
M package.json
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/39/365039/1

diff --git a/package.json b/package.json
index 9ac2929..2861be3 100644
--- a/package.json
+++ b/package.json
@@ -40,8 +40,8 @@
 "karma-firefox-launcher": "1.0.0",
 "karma-coverage": "1.1.1",
 "karma-mocha-reporter": "2.2.3",
-"karma-qunit": "1.0.0",
-"qunitjs": "1.23.1",
+"karma-qunit": "1.2.1",
+"qunitjs": "2.4.0",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/365039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76777cd5ff96d13588b8bc25744bb41402a495cd
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: tests: Avoid deprecated QUnit.push()

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365038 )

Change subject: tests: Avoid deprecated QUnit.push()
..

tests: Avoid deprecated QUnit.push()

Change-Id: I1605f0f3035cc5861fd9d1ea52f00fbd32f00d58
---
M tests/ve.qunit.js
1 file changed, 60 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/38/365038/1

diff --git a/tests/ve.qunit.js b/tests/ve.qunit.js
index 4bb3f0e..12697b3 100644
--- a/tests/ve.qunit.js
+++ b/tests/ve.qunit.js
@@ -142,9 +142,12 @@
}
actualSummary = getNodeTreeSummary( actual, shallow );
expectedSummary = getNodeTreeSummary( expected, shallow );
-   QUnit.push(
-   QUnit.equiv( actualSummary, expectedSummary ), 
actualSummary, expectedSummary, message
-   );
+   this.pushResult( {
+   result: QUnit.equiv( actualSummary, expectedSummary ),
+   actual: actualSummary,
+   expected: expectedSummary,
+   message: message
+   } );
};
 
/**
@@ -161,15 +164,21 @@
 
for ( i = 0; i < actual.length; i++ ) {
if ( expected[ i ] && expected[ i ].node !== actual[ i 
].node ) {
-   QUnit.push( false, actualSummary, 
expectedSummary,
-   message + ' (reference equality for 
selection[' + i + '].node)'
-   );
+   this.pushResult( {
+   result: false,
+   actual: actualSummary,
+   expected: expectedSummary,
+   message: message + ' (reference 
equality for selection[' + i + '].node)'
+   } );
return;
}
}
-   QUnit.push(
-   QUnit.equiv( actualSummary, expectedSummary ), 
actualSummary, expectedSummary, message
-   );
+   this.pushResult( {
+   result: QUnit.equiv( actualSummary, expectedSummary ),
+   actual: actualSummary,
+   expected: expectedSummary,
+   message: message
+   } );
};
 
/**
@@ -185,9 +194,12 @@
actualSummaryHtml = ve.getDomElementSummary( actual, 
true ),
expectedSummaryHtml = ve.getDomElementSummary( 
expected, true );
 
-   QUnit.push(
-   QUnit.equiv( actualSummary, expectedSummary ), 
actualSummaryHtml, expectedSummaryHtml, message
-   );
+   this.pushResult( {
+   result: QUnit.equiv( actualSummary, expectedSummary ),
+   actual: actualSummaryHtml,
+   expected: expectedSummaryHtml,
+   message: message
+   } );
};
 
QUnit.assert.equalLinearData = function ( actual, expected, message ) {
@@ -205,7 +217,12 @@
actual = ve.copy( actual, null, removeOriginalDomElements );
expected = ve.copy( expected, null, removeOriginalDomElements );
 
-   QUnit.push( QUnit.equiv( actual, expected ), actual, expected, 
message );
+   this.pushResult( {
+   result: QUnit.equiv( actual, expected ),
+   actual: actual,
+   expected: expected,
+   message: message
+   } );
};
 
QUnit.assert.equalLinearDataWithDom = function ( store, actual, 
expected, message ) {
@@ -221,7 +238,12 @@
actual = ve.copy( actual, ve.convertDomElements, 
addOriginalDomElements );
expected = ve.copy( expected, ve.convertDomElements, 
addOriginalDomElements );
 
-   QUnit.push( QUnit.equiv( actual, expected ), actual, expected, 
message );
+   this.pushResult( {
+   result: QUnit.equiv( actual, expected ),
+   actual: actual,
+   expected: expected,
+   message: message
+   } );
};
 
/**
@@ -238,7 +260,12 @@
actual = ve.copy( actual, ve.convertDomElements );
expected = ve.copy( expected, ve.convertDomElements );
 
-   QUnit.push( QUnit.equiv( actual, expected ), actual, expected, 
message );
+   this.pushResult( {
+   result: QUnit.equiv( actual, expected ),
+   actual: actual,
+   expected: expected,
+   message: message
+   

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [WIP] WikimediaUI theme: Directly use the LESS values rather...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364634 )

Change subject: [WIP] WikimediaUI theme: Directly use the LESS values rather 
than via copy-paste
..

[WIP] WikimediaUI theme: Directly use the LESS values rather than via copy-paste

Bug: T165650
Change-Id: I92322d8c4c31868153f0d85173b2a3127cfd6b69
---
M src/themes/wikimediaui/common.less
1 file changed, 35 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/34/364634/1

diff --git a/src/themes/wikimediaui/common.less 
b/src/themes/wikimediaui/common.less
index ecb1cb3..535d51c 100644
--- a/src/themes/wikimediaui/common.less
+++ b/src/themes/wikimediaui/common.less
@@ -4,16 +4,20 @@
 @oo-ui-font-size-browser: 16; // assumed browser default of `16px`
 @oo-ui-font-size-base: 0.8em; // equals `12.8px` at browser default of `16px`
 
-@background-color-base: #fff;
+// Pull in the main set of variables from the shared UI base; reaching into 
node_modules like this
+// to avoid a symlink that Windows users won't like.
+@import '../../../node_modules/wikimedia-ui-base/wikimedia-ui-base.less';
+
+// @background-color-base: #fff;
 @background-color-base--hover: #eaecf0;
 @background-color-base--read-only: #f8f9fa;
 
-@color-base: #222;
-@color-base--hover: #444;
-@color-base--active: #000;
-@color-base--inverted: #fff;
+// @color-base: #222;
+// @color-base--hover: #444;
+// @color-base--active: #000;
+// @color-base--inverted: #fff;
 @color-emphasized: @color-base--active;
-@color-placeholder: #72777d; // equals HSB 210°/9%/49%, aligns to WCAG 2.0 
level AA at 4.52:1 contrast ratio
+// @color-placeholder: #72777d; // equals HSB 210°/9%/49%, aligns to WCAG 2.0 
level AA at 4.52:1 contrast ratio
 @color-subtle: #72777d;
 
 // Primary 'Progressive' and 'Destructive' Colors
@@ -25,33 +29,33 @@
 @color-progressive--active-hover: @color-progressive;
 @color-progressive--focus: @color-progressive;
 
-@background-color-destructive: #fee7e6;
-@color-destructive: #d33; // equals HSB 360°/77%/87%
-@color-destructive--hover: #ff4242; // equals HSB 360°/74%/100%
-@color-destructive--active: #b32424; // equals HSB 360°/80%/70%
-@color-destructive--focus: @color-destructive;
+// @background-color-destructive: #fee7e6;
+// @color-destructive: #d33; // equals HSB 360°/77%/87%
+// @color-destructive--hover: #ff4242; // equals HSB 360°/74%/100%
+// @color-destructive--active: #b32424; // equals HSB 360°/80%/70%
+// @color-destructive--focus: @color-destructive;
 @color-destructive-non-primary: #d7; // Exemption for non-primary buttons, 
foremost used in VE, lightened up R50 to align to AA contrast ratio
 
 // Disabled Widgets
 @background-color-base--disabled: #eaecf0;
 @background-color-filled--disabled: #c8ccd1;
-@color-base--disabled: #72777d;
-@color-filled--disabled: @color-base--inverted;
+// @color-base--disabled: #72777d;
+// @color-filled--disabled: @color-base--inverted;
 @opacity--disabled: 0.51; // `0.51` equals `#7d7d7d` on background-color 
`#fff`, HSB 0°/0%/49%
 @opacity-filled--disabled: 1;
 @opacity-indicator--disabled: 0.15; // equals `#c7c8cc` on background-color 
`#fff`
 @opacity-tool--disabled: 0.3;
 
 // Invalid Widget (validation error feedback)
-@color-erroneous: @color-destructive;
+// @color-erroneous: @color-destructive;
 
 // "Framed" Widgets (Framed ButtonWidget, ToggleSwitchWidget...)
-@background-color-framed: #f8f9fa;
-@background-color-framed--hover: @background-color-base; // equals `lighten( 
#f8f9fa, 10% )`, although `2%` is already resulting in `#fff`
-@background-color-framed--active: #c8ccd1;
+// @background-color-framed: #f8f9fa;
+// @background-color-framed--hover: @background-color-base; // equals 
`lighten( #f8f9fa, 10% )`, although `2%` is already resulting in `#fff`
+// @background-color-framed--active: #c8ccd1;
 
 // Tabbed Navigation
-@background-color-tabs: #eaecf0;
+// @background-color-tabs: #eaecf0;
 
 // Toolbar, Tools & Menus
 @background-color-toolbar: @background-color-base;
@@ -111,19 +115,19 @@
 @margin-top-fieldsetlayout-help: -( 6 / @oo-ui-font-size-browser / 
@oo-ui-font-size-base ) / 2;
 @margin-bottom-fieldset-header: 8 / @oo-ui-font-size-browser / ( 
@oo-ui-font-size-base * @font-size-fieldset-header );
 
-@border-base: @border-width-base solid @border-color-base;
+// @border-base: @border-width-base solid @border-color-base;
 @border-base--disabled: @border-width-base solid @border-color-base--disabled;
 @border-filled--disabled: @border-width-base solid 
@border-color-filled--disabled;
-@border-dialog: @border-base;
+// @border-dialog: @border-base;
 @border-dialog-bar: @border-width-base solid @border-color-dialog-bar;
-@border-menu: @border-base;
+// @border-menu: @border-base;
 
-@border-color-base: #a2a9b1;
-@border-color-base--hover: #a2a9b1;
-@border-color-base--active: #72777d;
+// @border-color-base: #a2a9b1;
+// @border-color-base--hover: #a2a9b1;
+// 

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOjs UI to v0.22.3

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364614 )

Change subject: Update OOjs UI to v0.22.3
..

Update OOjs UI to v0.22.3

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.3

Change-Id: If676bfab1d2040a9d360c741a5ab4e1c81b36b87
---
M composer.json
M composer.lock
M composer/installed.json
M oojs/oojs-ui/History.md
M oojs/oojs-ui/bin/testsuitegenerator.rb
M oojs/oojs-ui/demos/demos.php
M oojs/oojs-ui/demos/pages/widgets.js
M oojs/oojs-ui/package.json
M oojs/oojs-ui/php/Element.php
M oojs/oojs-ui/php/HtmlSnippet.php
M oojs/oojs-ui/php/Tag.php
M oojs/oojs-ui/php/Theme.php
M oojs/oojs-ui/php/layouts/FieldLayout.php
M oojs/oojs-ui/php/mixins/AccessKeyedElement.php
M oojs/oojs-ui/php/mixins/ButtonElement.php
M oojs/oojs-ui/php/mixins/FlaggedElement.php
M oojs/oojs-ui/php/mixins/GroupElement.php
M oojs/oojs-ui/php/mixins/IconElement.php
M oojs/oojs-ui/php/mixins/IndicatorElement.php
M oojs/oojs-ui/php/mixins/LabelElement.php
M oojs/oojs-ui/php/mixins/TabIndexedElement.php
M oojs/oojs-ui/php/mixins/TitledElement.php
M oojs/oojs-ui/php/widgets/HiddenInputWidget.php
M oojs/oojs-ui/php/widgets/InputWidget.php
M oojs/oojs-ui/php/widgets/ProgressBarWidget.php
25 files changed, 182 insertions(+), 124 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/14/364614/1

diff --git a/composer.json b/composer.json
index 46cf220..ca0c907 100644
--- a/composer.json
+++ b/composer.json
@@ -45,7 +45,7 @@
"monolog/monolog": "1.22.1",
"mustangostang/spyc": "0.6.2",
"nmred/kafka-php": "0.1.5",
-   "oojs/oojs-ui": "0.22.2",
+   "oojs/oojs-ui": "0.22.3",
"oyejorge/less.php": "1.7.0.14",
"pear/console_getopt": "1.4.1",
"pear/mail": "1.3.0",
diff --git a/composer.lock b/composer.lock
index fe25852..ac09db5 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"content-hash": "5c4ef9054eed327bfd6cee4e658c4fea",
+"content-hash": "6ca887a2dbd1d8050bbc5727c0ac9619",
 "packages": [
 {
 "name": "composer/semver",
@@ -516,16 +516,16 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.22.2",
+"version": "v0.22.3",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "ca5f31425138961c4a779d8e0d7674f16dbc7d24"
+"reference": "796f52473294e923d0133bb1b0b3629d9b1332bc"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/ca5f31425138961c4a779d8e0d7674f16dbc7d24;,
-"reference": "ca5f31425138961c4a779d8e0d7674f16dbc7d24",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/796f52473294e923d0133bb1b0b3629d9b1332bc;,
+"reference": "796f52473294e923d0133bb1b0b3629d9b1332bc",
 "shasum": ""
 },
 "require": {
@@ -534,7 +534,7 @@
 },
 "require-dev": {
 "jakub-onderka/php-parallel-lint": "0.9.2",
-"mediawiki/mediawiki-codesniffer": "0.6.0",
+"mediawiki/mediawiki-codesniffer": "0.10.0",
 "phpunit/phpunit": "4.8.21"
 },
 "type": "library",
@@ -591,7 +591,7 @@
 ],
 "description": "Provides library of common widgets, layouts, and 
windows.",
 "homepage": "https://www.mediawiki.org/wiki/OOjs_UI;,
-"time": "2017-06-28T19:15:29+00:00"
+"time": "2017-07-11T21:50:03+00:00"
 },
 {
 "name": "oyejorge/less.php",
diff --git a/composer/installed.json b/composer/installed.json
index 1f23170..df92c7d 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -2205,87 +2205,6 @@
 "homepage": "https://www.mediawiki.org/wiki/Css-sanitizer;
 },
 {
-"name": "oojs/oojs-ui",
-"version": "v0.22.2",
-"version_normalized": "0.22.2.0",
-"source": {
-"type": "git",
-"url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "ca5f31425138961c4a779d8e0d7674f16dbc7d24"
-},
-"dist": {
-"type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/ca5f31425138961c4a779d8e0d7674f16dbc7d24;,
-"reference": "ca5f31425138961c4a779d8e0d7674f16dbc7d24",
-"shasum": ""
-},
-"require": {
-"mediawiki/at-ease": "1.1.0",
-

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update OOjs UI to v0.22.3

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364612 )

Change subject: Update OOjs UI to v0.22.3
..

Update OOjs UI to v0.22.3

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.3

Depends-On: If676bfab1d2040a9d360c741a5ab4e1c81b36b87
Change-Id: I684822b564663a94e03fc8b559617974502c8e52
---
M composer.json
M resources/lib/oojs-ui/oojs-ui-apex.js
M resources/lib/oojs-ui/oojs-ui-core-apex.css
M resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-core.js
M resources/lib/oojs-ui/oojs-ui-core.js.map
M resources/lib/oojs-ui/oojs-ui-toolbars-apex.css
M resources/lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-toolbars.js
M resources/lib/oojs-ui/oojs-ui-toolbars.js.map
M resources/lib/oojs-ui/oojs-ui-widgets-apex.css
M resources/lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-widgets.js
M resources/lib/oojs-ui/oojs-ui-widgets.js.map
M resources/lib/oojs-ui/oojs-ui-wikimediaui.js
M resources/lib/oojs-ui/oojs-ui-windows-apex.css
M resources/lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-windows.js
M resources/lib/oojs-ui/oojs-ui-windows.js.map
M resources/lib/oojs-ui/themes/apex/icons-content.json
M resources/lib/oojs-ui/themes/apex/icons-editing-advanced.json
A resources/lib/oojs-ui/themes/apex/images/icons/article-ltr.png
A resources/lib/oojs-ui/themes/apex/images/icons/article-ltr.svg
A resources/lib/oojs-ui/themes/apex/images/icons/article-rtl.png
A resources/lib/oojs-ui/themes/apex/images/icons/article-rtl.svg
D resources/lib/oojs-ui/themes/apex/images/icons/puzzle-ltr.png
D resources/lib/oojs-ui/themes/apex/images/icons/puzzle-ltr.svg
D resources/lib/oojs-ui/themes/apex/images/icons/puzzle-rtl.png
D resources/lib/oojs-ui/themes/apex/images/icons/puzzle-rtl.svg
A resources/lib/oojs-ui/themes/apex/images/icons/puzzle.png
A resources/lib/oojs-ui/themes/apex/images/icons/puzzle.svg
M resources/lib/oojs-ui/themes/wikimediaui/icons-editing-advanced.json
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/mapPin-invert.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/mapPin-invert.svg
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/mapPin-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/mapPin-progressive.svg
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/mapPin.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/mapPin.svg
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-ltr-invert.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-ltr-invert.svg
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-ltr-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-ltr-progressive.svg
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-ltr.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-ltr.svg
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-rtl-invert.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-rtl-invert.svg
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-rtl-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-rtl-progressive.svg
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-rtl.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/ongoingConversation-rtl.svg
A resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-invert.png
A resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-invert.svg
D resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-ltr-invert.png
D resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-ltr-invert.svg
D 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-ltr-progressive.png
D 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-ltr-progressive.svg
D resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-ltr.png
D resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-ltr.svg
A resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-progressive.png
A resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-progressive.svg
D resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-rtl-invert.png
D resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-rtl-invert.svg
D 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-rtl-progressive.png
D 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-rtl-progressive.svg
D resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-rtl.png
D resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle-rtl.svg
A resources/lib/oojs-ui/themes/wikimediaui/images/icons/puzzle.png
A 

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs UI to v0.22.3

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364611 )

Change subject: Update OOjs UI to v0.22.3
..

Update OOjs UI to v0.22.3

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.3

Change-Id: I684822b564663a94e03fc8b559617974502c8e52
---
M lib/oojs-ui/oojs-ui-apex-icons-alerts.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-content.css
M lib/oojs-ui/oojs-ui-apex-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-media.css
M lib/oojs-ui/oojs-ui-apex-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-user.css
M lib/oojs-ui/oojs-ui-apex-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-apex.css
M lib/oojs-ui/oojs-ui-apex.js
M lib/oojs-ui/oojs-ui-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-apex.css
M lib/oojs-ui/oojs-ui-core-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-mediawiki.css
M lib/oojs-ui/oojs-ui-core-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-core.js
M lib/oojs-ui/oojs-ui-core.js.map
M lib/oojs-ui/oojs-ui-images-apex.css
M lib/oojs-ui/oojs-ui-images-apex.rtl.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-accessibility.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki.css
M lib/oojs-ui/oojs-ui-mediawiki.js
M lib/oojs-ui/oojs-ui-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-apex.css
M lib/oojs-ui/oojs-ui-toolbars-apex.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars.js
M lib/oojs-ui/oojs-ui-toolbars.js.map
M lib/oojs-ui/oojs-ui-widgets-apex.css
M lib/oojs-ui/oojs-ui-widgets-apex.rtl.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-widgets.js
M lib/oojs-ui/oojs-ui-widgets.js.map
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.rtl.css
M 

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Tag v0.22.3

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364598 )

Change subject: Tag v0.22.3
..

Tag v0.22.3

Change-Id: I6f9008458b898877bac88aae4bd4382b0ec87ed9
---
M History.md
M package.json
2 files changed, 33 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/98/364598/1

diff --git a/History.md b/History.md
index b5bf1a2..f318692 100644
--- a/History.md
+++ b/History.md
@@ -1,4 +1,36 @@
 # OOjs UI Release History
+## v0.22.3 / 2017-07-11
+### Features
+* Tag-/CapsuleMultiselectWidget: Avoid visual focusTrap feedback (Volker E.)
+* WindowManager: Avoid inconsistent state due to asynchronous promise 
resolution (Bartosz Dziewoński)
+* WindowManager: fix closing promise state check (David Lynch)
+
+### Styles
+* icons: Align ongoingConversation to grid (Ed Sanders)
+* icons: Replace the puzzle icon, using the one from VisualEditor (James D. 
Forrester)
+* icons: Vertically center mapPin icon (Volker E.)
+
+### Code
+* DropdownWidget, MenuSelectWidget: Set aria-expanded attribute (Prateek 
Saxena)
+* FieldLayout: Add role='alert' for error messages (Prateek Saxena)
+* FieldLayout: Set 'aria-describedby' on the fieldWidget (Prateek Saxena)
+* PopupWidget: Update function name in a comment (Bartosz Dziewoński)
+* TagMultiselectWidget: Skip updateInputSize() for invisible inputs (Roan 
Kattouw)
+* Toolbar: Add comment for greppability of dynamic CSS classes (Bartosz 
Dziewoński)
+* themes: Align read-only variable names to pseudo-class selector scheme 
(Volker E.)
+* themes: Align variable names to WikimediaUI Base scheme (Volker E.)
+* WikimediaUI theme: Align `opacity-icon*` variable names to WikimediaUI Base 
(Volker E.)
+* WikimediaUI theme: Align checked variable names to pseudo-class scheme 
(Volker E.)
+* WikimediaUI theme: Align disabled variable names to pseudo-class scheme 
(Volker E.)
+* WikimediaUI theme: Align variable pseudo classes names to WikimediaUI Base 
(Volker E.)
+* WikimediaUI theme: Replace `@color-base-light` with `@color-base--inverted` 
(Volker E.)
+* WikimediaUI theme: Variablize PopupWidget values (Volker E.)
+* WikimediaUI theme: Pull in the upstream WikimediaUI package (James D. 
Forrester)
+* build: Updating mediawiki/mediawiki-codesniffer to 0.10.0 (Kunal Mehta)
+* phpcs: Enable more rules, or document why they are disabled (Bartosz 
Dziewoński)
+* testsuitegenerator: Blacklist deprecated 'multiline' config option (Bartosz 
Dziewoński)
+
+
 ## v0.22.2 / 2017-06-28
 ### Deprecations
 * [DEPRECATING CHANGE] TextInputWidget: Move multi-line support out (Prateek 
Saxena)
diff --git a/package.json b/package.json
index f48ad87..139a202 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "oojs-ui",
-  "version": "0.22.2",
+  "version": "0.22.3",
   "description": "User interface classes built on the OOjs framework.",
   "keywords": [
 "oojs-plugin",

-- 
To view, visit https://gerrit.wikimedia.org/r/364598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f9008458b898877bac88aae4bd4382b0ec87ed9
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (c9b0d1a23)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364335 )

Change subject: Update VE core submodule to master (c9b0d1a23)
..

Update VE core submodule to master (c9b0d1a23)

New changes:
56e7afa47 Follow-up I93bb2b5dcc: Insert newline if fragment ends in '/paragraph'
70b378298 Workaround for Flow bottom toolbars conflicting with inspectors
c9b0d1a23 Workaround for nested toolbars hack being terrible

Bug: T169076
Bug: T169617
Change-Id: I69dd105d26edcbec8136fbafd337462478ab3349
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/35/364335/1

diff --git a/lib/ve b/lib/ve
index b76c969..c9b0d1a 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit b76c9699b7463845d9e9e942bed0a04d60309ac5
+Subproject commit c9b0d1a232fa8ab7d160c2e88691799252a56853

-- 
To view, visit https://gerrit.wikimedia.org/r/364335
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69dd105d26edcbec8136fbafd337462478ab3349
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (b76c9699b)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364229 )

Change subject: Update VE core submodule to master (b76c9699b)
..

Update VE core submodule to master (b76c9699b)

New changes:
cc1214901 Fix word wrapping CSS in source mode
fed88cc3a Localisation updates from https://translatewiki.net.
d648467a5 DiffElement: hide strikethrough on hover
0428407a0 getSourceText: Fix edge case

Bug: T159271
Bug: T169851
Bug: T170133
Change-Id: I942e3cf4251d6435cadceae92680e8d471966efa
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/29/364229/1

diff --git a/lib/ve b/lib/ve
index 5d7b237..b76c969 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 5d7b2376224cc8e016ff77d5489b730bca909b48
+Subproject commit b76c9699b7463845d9e9e942bed0a04d60309ac5

-- 
To view, visit https://gerrit.wikimedia.org/r/364229
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I942e3cf4251d6435cadceae92680e8d471966efa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (5d7b23762)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363984 )

Change subject: Update VE core submodule to master (5d7b23762)
..

Update VE core submodule to master (5d7b23762)

New changes:
34999f2ce Move linear model -> source text conversion to ElementLinearData
a2ab4fa95 build: Bump grunt clean and stylelint to latest
dab49847a Fix infinite loop in ve.BranchNode#getNodeFromOffset
b4319e29d LanguageInputWidget: optionally suppress directionality input

Change-Id: I800085eb3a5f7332eab356b62a34bfc603a29839
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/84/363984/1

diff --git a/lib/ve b/lib/ve
index 1934b77..5d7b237 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 1934b77e72f79d7bceb9d21dd6c0a90dadc61b0e
+Subproject commit 5d7b2376224cc8e016ff77d5489b730bca909b48

-- 
To view, visit https://gerrit.wikimedia.org/r/363984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I800085eb3a5f7332eab356b62a34bfc603a29839
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SpecialRecentchanges: Globals for config are bad, m'kay

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363976 )

Change subject: SpecialRecentchanges: Globals for config are bad, m'kay
..

SpecialRecentchanges: Globals for config are bad, m'kay

Change-Id: I9ca7aead42ffee1e891525fc80f3438157f4fb2f
---
M includes/specials/SpecialRecentchanges.php
1 file changed, 3 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/76/363976/1

diff --git a/includes/specials/SpecialRecentchanges.php 
b/includes/specials/SpecialRecentchanges.php
index bec87c5..05bcc4d 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -138,10 +138,6 @@
 * @param string $subpage
 */
public function execute( $subpage ) {
-   global $wgStructuredChangeFiltersEnableSaving,
-   $wgStructuredChangeFiltersEnableExperimentalViews,
-   $wgStructuredChangeFiltersEnableLiveUpdate;
-
// Backwards-compatibility: redirect to new feed URLs
$feedFormat = $this->getRequest()->getVal( 'feed' );
if ( !$this->including() && $feedFormat ) {
@@ -184,15 +180,15 @@
$out->addJsConfigVars( 'wgStructuredChangeFilters', 
$jsData['groups'] );
$out->addJsConfigVars(
'wgStructuredChangeFiltersEnableSaving',
-   $wgStructuredChangeFiltersEnableSaving
+   $this->getConfig()->get( 
'StructuredChangeFiltersEnableSaving' )
);
$out->addJsConfigVars(

'wgStructuredChangeFiltersEnableExperimentalViews',
-   
$wgStructuredChangeFiltersEnableExperimentalViews
+   $this->getConfig()->get( 
'StructuredChangeFiltersEnableExperimentalViews' )
);
$out->addJsConfigVars(
'wgStructuredChangeFiltersEnableLiveUpdate',
-   $wgStructuredChangeFiltersEnableLiveUpdate
+   $this->getConfig()->get( 
'StructuredChangeFiltersEnableLiveUpdate' )
);
$out->addJsConfigVars(
'wgRCFiltersChangeTags',

-- 
To view, visit https://gerrit.wikimedia.org/r/363976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ca7aead42ffee1e891525fc80f3438157f4fb2f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: build: Bump a couple of devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363692 )

Change subject: build: Bump a couple of devDependencies to latest
..

build: Bump a couple of devDependencies to latest

 grunt-banana-checker   0.5.0  →   0.6.0
 grunt-stylelint0.7.0  →   0.8.0

Added stylelint peerdependency directly.

Change-Id: Ib5da82ae60f4f49e572459c8e53f9125ad422ee8
---
M package.json
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/92/363692/1

diff --git a/package.json b/package.json
index 255aea0..56826cc 100644
--- a/package.json
+++ b/package.json
@@ -12,18 +12,19 @@
"babel-polyfill": "6.9.1",
"eslint-config-wikimedia": "0.4.0",
"grunt": "1.0.1",
-   "grunt-banana-checker": "0.5.0",
+   "grunt-banana-checker": "0.6.0",
"grunt-contrib-copy": "1.0.0",
"grunt-contrib-watch": "1.0.0",
"grunt-eslint": "19.0.0",
"grunt-jsonlint": "1.1.0",
"grunt-image": "2.2.3",
"grunt-mocha-test": "0.12.7",
-   "grunt-stylelint": "0.7.0",
+   "grunt-stylelint": "0.8.0",
"grunt-tyops": "0.1.0",
"jimp": "0.2.24",
"mocha": "2.5.3",
"selenium-webdriver": "2.53.2",
+   "stylelint": "7.8.0",
"stylelint-config-wikimedia": "0.4.1"
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/363692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5da82ae60f4f49e572459c8e53f9125ad422ee8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (1934b77e7)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363691 )

Change subject: Update VE core submodule to master (1934b77e7)
..

Update VE core submodule to master (1934b77e7)

New changes:
2ffadb015 ui.FormatAction: fixup selection for empty conversions
eb1c82b57 Minimal demo: update deprecated TextInputWidget
e9951799c Localisation updates from https://translatewiki.net.
7e80419bb ve.fixBase: Fix protocol-relative base href for Chrome
6b0fa8b40 Localisation updates from https://translatewiki.net.
a4a0be2da ve.ui.TableLineContext: restore the z-index hack

Bug: T151594
Bug: T167936
Bug: T169389
Change-Id: If9c8208f4c549800488acc799c677875bd233283
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/91/363691/1

diff --git a/lib/ve b/lib/ve
index 65ea4cf..1934b77 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 65ea4cf36d125ac95de1d658fe10f0664d3a4e69
+Subproject commit 1934b77e72f79d7bceb9d21dd6c0a90dadc61b0e

-- 
To view, visit https://gerrit.wikimedia.org/r/363691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9c8208f4c549800488acc799c677875bd233283
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: build: Exclude /vendor from stylelint to avoid errors

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363690 )

Change subject: build: Exclude /vendor from stylelint to avoid errors
..

build: Exclude /vendor from stylelint to avoid errors

Change-Id: I0505925ada34d951fd8d0cc810b47ebeccadf6bb
---
M Gruntfile.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/90/363690/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 0ed9734..db86d70 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -136,7 +136,8 @@
'!dist/**',
'!docs/**',
'!lib/**',
-   '!node_modules/**'
+   '!node_modules/**',
+   '!vendor/**'
]
},
banana: {

-- 
To view, visit https://gerrit.wikimedia.org/r/363690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0505925ada34d951fd8d0cc810b47ebeccadf6bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Use a better page for the beta feature discussion link

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363666 )

Change subject: Use a better page for the beta feature discussion link
..

Use a better page for the beta feature discussion link

Change-Id: I5ce29e4bf47abf509afde0a57f64b5d1189f1234
---
M CodeMirror.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror 
refs/changes/66/363666/1

diff --git a/CodeMirror.hooks.php b/CodeMirror.hooks.php
index 34364fa..53f1306 100644
--- a/CodeMirror.hooks.php
+++ b/CodeMirror.hooks.php
@@ -165,7 +165,7 @@
'rtl' => $wgExtensionAssetsPath . 
'/CodeMirror/resources/images/codemirror-beta-RTL.svg'
],
'info-link' => 
'https://meta.wikimedia.org/wiki/Community_Tech/Wikitext_editor_syntax_highlighting',
-   'discussion-link' => 
'https://meta.wikimedia.org/wiki/Talk:Community_Tech/Wikitext_editor_syntax_highlighting'
+   'discussion-link' => 
'https://www.mediawiki.org/wiki/Extension_talk:CodeMirror/BetaFeature'
];
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/363666
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ce29e4bf47abf509afde0a57f64b5d1189f1234
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Crush the beta feature screenshot images using svgo

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363667 )

Change subject: Crush the beta feature screenshot images using svgo
..

Crush the beta feature screenshot images using svgo

Change-Id: I5ce29e4bf47abf509afde0a57f64b5d1189f4321
---
M resources/images/codemirror-beta-LTR.svg
M resources/images/codemirror-beta-RTL.svg
2 files changed, 44 insertions(+), 193 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror 
refs/changes/67/363667/1

diff --git a/resources/images/codemirror-beta-LTR.svg 
b/resources/images/codemirror-beta-LTR.svg
index 36e08df..bc08caf 100644
--- a/resources/images/codemirror-beta-LTR.svg
+++ b/resources/images/codemirror-beta-LTR.svg
@@ -1,97 +1,23 @@
-http://www.w3.org/2000/svg; viewBox="0 0 264 162" width="264" 
height="162">
-
-   .st0{fill:#3466CC;}
-   .st1{fill:#E5E5E5;}
-   .st2{fill:#FF;}
-   .st3{opacity:6.00e-02;enable-background:new;}
-   .st4{opacity:7.00e-02;enable-background:new;}
-   
.st5{opacity:0.25;fill:none;stroke:#FF;stroke-width:0.5;stroke-miterlimit:10;enable-background:new
;}
-   .st6{fill:#00AF89;}
-   .st7{opacity:0.23;fill:#F5A623;enable-background:new;}
-   .st8{fill:#F5A623;}
-
-
-   
-   
-
-
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-
-
-   
-   
-
-
-   
-   
-
-
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-
-
-
-
-
-
-
-
-
-   
-
-
-   
-   
-   
-   
-   
-   
-   
-
+
+http://www.w3.org/2000/svg; viewBox="0 0 264 162" width="264" 
height="162">
+
+
.st0{fill:#3466cc}.st1{fill:#e5e5e5}.st2{fill:#fff}.st3{opacity:6e-2}.st3,.st4,.st5{enable-background:new}.st4{opacity:7e-2}.st5{opacity:.25;fill:none;stroke:#fff;stroke-width:.5;stroke-miterlimit:10}.st6{fill:#00af89}.st7{opacity:.23;enable-background:new}.st7,.st8{fill:#f5a623}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 
diff --git a/resources/images/codemirror-beta-RTL.svg 
b/resources/images/codemirror-beta-RTL.svg
index c791296..17efeed 100644
--- a/resources/images/codemirror-beta-RTL.svg
+++ b/resources/images/codemirror-beta-RTL.svg
@@ -1,98 +1,23 @@
-http://www.w3.org/2000/svg; viewBox="0 0 264 162" width="264" 
height="162">
-
-   .st0{fill:#3466CC;}
-   .st1{fill:#E5E5E5;}
-   .st2{fill:#FF;}
-   .st3{opacity:6.00e-02;enable-background:new;}
-   .st4{opacity:7.00e-02;enable-background:new;}
-   
.st5{opacity:0.25;fill:none;stroke:#FF;stroke-width:0.5;stroke-miterlimit:10;enable-background:new
;}
-   .st6{fill:#00AF89;}
-   .st7{opacity:0.23;fill:#F5A623;enable-background:new;}
-   .st8{fill:#F5A623;}
-
-
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-
+
+http://www.w3.org/2000/svg; viewBox="0 0 264 162" width="264" 
height="162">
+
+
.st0{fill:#3466cc}.st1{fill:#e5e5e5}.st2{fill:#fff}.st3{opacity:6e-2}.st3,.st4,.st5{enable-background:new}.st4{opacity:7e-2}.st5{opacity:.25;fill:none;stroke:#fff;stroke-width:.5;stroke-miterlimit:10}.st6{fill:#00af89}.st7{opacity:.23;enable-background:new}.st7,.st8{fill:#f5a623}
+
+
+
+
+
+
+
+
+
+
+
+
+
+

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Drop local 'template' icon, use 'puzzle' from upstream

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363631 )

Change subject: Drop local 'template' icon, use 'puzzle' from upstream
..

Drop local 'template' icon, use 'puzzle' from upstream

Now that our template icon has been upstreamed thereto.

Bug: T111041
Change-Id: If101018de284dcc1be086d92427de0d88adb0e02
---
M modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
M modules/ve-mw/ui/contextitems/ve.ui.MWTransclusionContextItem.js
M modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
M modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js
M modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
M modules/ve-mw/ui/pages/ve.ui.MWTemplatesUsedPage.js
M modules/ve-mw/ui/styles/apex/ve.ui.Icons.json
D modules/ve-mw/ui/styles/images/icons/template.svg
M modules/ve-mw/ui/styles/wikimediaui/ve.ui.Icons.json
M modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js
M modules/ve-mw/ui/tools/ve.ui.MWTransclusionDialogTool.js
11 files changed, 11 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/31/363631/1

diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js 
b/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
index 5a37a5f..304947b 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
@@ -42,7 +42,7 @@
 
 ve.ce.MWTransclusionNode.static.primaryCommandName = 'transclusion';
 
-ve.ce.MWTransclusionNode.static.iconWhenInvisible = 'template';
+ve.ce.MWTransclusionNode.static.iconWhenInvisible = 'puzzle';
 
 /* Static Methods */
 
diff --git a/modules/ve-mw/ui/contextitems/ve.ui.MWTransclusionContextItem.js 
b/modules/ve-mw/ui/contextitems/ve.ui.MWTransclusionContextItem.js
index baf712c..d93f361 100644
--- a/modules/ve-mw/ui/contextitems/ve.ui.MWTransclusionContextItem.js
+++ b/modules/ve-mw/ui/contextitems/ve.ui.MWTransclusionContextItem.js
@@ -34,7 +34,7 @@
 
 ve.ui.MWTransclusionContextItem.static.name = 'transclusion';
 
-ve.ui.MWTransclusionContextItem.static.icon = 'template';
+ve.ui.MWTransclusionContextItem.static.icon = 'puzzle';
 
 ve.ui.MWTransclusionContextItem.static.label =
OO.ui.deferMsg( 'visualeditor-dialogbutton-template-tooltip' );
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
index 7ac6395..bcb489b 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
@@ -345,7 +345,7 @@
// Properties
this.addTemplateButton = new OO.ui.ButtonWidget( {
framed: false,
-   icon: 'template',
+   icon: 'puzzle',
title: ve.msg( 'visualeditor-dialog-transclusion-add-template' )
} );
this.addContentButton = new OO.ui.ButtonWidget( {
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js
index 6adf3ac..8e6c3c6 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js
@@ -43,7 +43,7 @@
.connect( this, { click: 'onRemoveButtonClick' } );
this.infoFieldset = new OO.ui.FieldsetLayout( {
label: this.spec.getLabel(),
-   icon: 'template'
+   icon: 'puzzle'
} );
this.addButton = new OO.ui.ButtonWidget( {
framed: false,
@@ -112,7 +112,7 @@
 
if ( this.outlineItem ) {
this.outlineItem
-   .setIcon( 'template' )
+   .setIcon( 'puzzle' )
.setMovable( true )
.setRemovable( true )
.setLabel( this.spec.getLabel() );
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
index a75eabd..cc833de 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
@@ -67,7 +67,7 @@
 
this.addTemplateFieldset = new OO.ui.FieldsetLayout( {
label: ve.msg( 'visualeditor-dialog-transclusion-placeholder' ),
-   icon: 'template',
+   icon: 'puzzle',
classes: [ 've-ui-mwTransclusionDialog-addTemplateFieldset' ],
items: [ addTemplateActionFieldLayout ]
} );
@@ -93,7 +93,7 @@
 
if ( this.outlineItem ) {
this.outlineItem
-   .setIcon( 'template' )
+   .setIcon( 'puzzle' )
.setMovable( true )
.setRemovable( true )
.setFlags( [ 'placeholder' ] )
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTemplatesUsedPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWTemplatesUsedPage.js

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Bump grunt clean and stylelint to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362381 )

Change subject: build: Bump grunt clean and stylelint to latest
..

build: Bump grunt clean and stylelint to latest

 grunt-contrib-clean  1.0.0  →  1.1.0
 grunt-stylelint  0.7.0  →  0.8.0

Also, explicitly add stylelint which is now required as a peer.

Change-Id: Idd1f03e9853e5799bce15b6dbfcf858245229ce8
---
M package.json
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/81/362381/1

diff --git a/package.json b/package.json
index cdd4d2f..6f26448 100644
--- a/package.json
+++ b/package.json
@@ -24,7 +24,7 @@
 "eslint-config-wikimedia": "0.4.0",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.6.0",
-"grunt-contrib-clean": "1.0.0",
+"grunt-contrib-clean": "1.1.0",
 "grunt-contrib-concat": "1.0.1",
 "grunt-contrib-copy": "1.0.0",
 "grunt-contrib-watch": "1.0.0",
@@ -33,7 +33,7 @@
 "grunt-eslint": "20.0.0",
 "grunt-jsonlint": "1.1.0",
 "grunt-karma": "2.0.0",
-"grunt-stylelint": "0.7.0",
+"grunt-stylelint": "0.8.0",
 "grunt-tyops": "0.1.0",
 "karma": "1.1.2",
 "karma-chrome-launcher": "1.0.1",
@@ -42,6 +42,7 @@
 "karma-mocha-reporter": "2.2.3",
 "karma-qunit": "1.0.0",
 "qunitjs": "1.23.1",
+"stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/362381
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd1f03e9853e5799bce15b6dbfcf858245229ce8
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Upgrade grunt-eslint from 19.0.0 to 20.0.0

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362378 )

Change subject: build: Upgrade grunt-eslint from 19.0.0 to 20.0.0
..

build: Upgrade grunt-eslint from 19.0.0 to 20.0.0

Lots of indent fixes (some of them a little dubious), plus a few
unnecessary regex and quote character escapes.

Change-Id: I18e13186f34756ca9c75a6e64d7e78baa819c629
---
M package.json
M src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
M src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
M src/ce/nodes/ve.ce.TableNode.js
M src/ce/ve.ce.ResizableNode.js
M src/ce/ve.ce.Surface.js
M src/ce/ve.ce.TextState.js
M src/dm/lineardata/ve.dm.ElementLinearData.js
M src/dm/ve.dm.Converter.js
M src/dm/ve.dm.IndexValueStore.js
M src/dm/ve.dm.MetaList.js
M src/dm/ve.dm.Scalable.js
M src/dm/ve.dm.TransactionBuilder.js
M src/dm/ve.dm.TransactionProcessor.js
M src/dm/ve.dm.VisualDiff.js
M src/init/sa/ve.init.sa.Platform.js
M src/ui/actions/ve.ui.LinkAction.js
M src/ui/contextitems/ve.ui.MergeCellsContextItem.js
M src/ui/ve.ui.Surface.js
M src/ui/widgets/ve.ui.LinkAnnotationWidget.js
M src/ui/widgets/ve.ui.MediaSizeWidget.js
M src/ve.Filibuster.js
M tests/ce/ve.ce.Surface.test.js
M tests/dm/ve.dm.RebaseServer.test.js
M tests/dm/ve.dm.SurfaceFragment.test.js
M tests/init/ve.init.sa.Platform.test.js
M tests/ui/ve.ui.DiffElement.test.js
M tests/ve.test.js
M tests/ve.test.utils.js
29 files changed, 155 insertions(+), 142 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/78/362378/1

diff --git a/package.json b/package.json
index 2f7edd3..cdd4d2f 100644
--- a/package.json
+++ b/package.json
@@ -30,7 +30,7 @@
 "grunt-contrib-watch": "1.0.0",
 "grunt-css-url-embed": "1.10.0",
 "grunt-cssjanus": "0.4.0",
-"grunt-eslint": "19.0.0",
+"grunt-eslint": "20.0.0",
 "grunt-jsonlint": "1.1.0",
 "grunt-karma": "2.0.0",
 "grunt-stylelint": "0.7.0",
diff --git a/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js 
b/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
index df3e3c0..26dd80a 100644
--- a/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
+++ b/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
@@ -186,8 +186,8 @@
}
newRange = (
afterDirection > 0 ?
-   viewNode.getOuterRange() :
-   viewNode.getOuterRange().flip()
+   viewNode.getOuterRange() :
+   viewNode.getOuterRange().flip()
);
} else {
// Check where the range has moved to
diff --git a/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js 
b/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
index 71c9778..6a6d082 100644
--- a/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
+++ b/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
@@ -82,8 +82,8 @@
// then preventDefault
if (
direction > 0 ?
-   skipNode.classList.contains( 've-ce-nail-pre-open' ) :
-   skipNode.classList.contains( 've-ce-nail-post-close' )
+   skipNode.classList.contains( 
've-ce-nail-pre-open' ) :
+   skipNode.classList.contains( 
've-ce-nail-post-close' )
) {
position = ve.adjacentDomPosition(
position,
@@ -104,19 +104,19 @@
skipNode.classList &&
skipNode.classList.contains(
direction > 0 ?
-   've-ce-nail-pre-close' :
-   've-ce-nail-post-open'
+   've-ce-nail-pre-close' :
+   've-ce-nail-post-open'
) &&
( pairNode = (
direction > 0 ?
-   skipNode.previousSibling :
-   skipNode.nextSibling
+   skipNode.previousSibling :
+   skipNode.nextSibling
) ) &&
pairNode.classList &&
pairNode.classList.contains(
direction > 0 ?
-   've-ce-nail-post-open' :
-   've-ce-nail-pre-close'
+   've-ce-nail-post-open' :
+   've-ce-nail-pre-close'
)
) {
linkNode = skipNode.parentNode;
@@ -142,8 +142,8 @@
   

[MediaWiki-commits] [Gerrit] oojs/ui[master]: icons: Replace the puzzle icon, using the one from VisualEditor

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362242 )

Change subject: icons: Replace the puzzle icon, using the one from VisualEditor
..

icons: Replace the puzzle icon, using the one from VisualEditor

Also abandon having the LTR/RTL variance; the additional cost isn't worth
it for a relatively rare usage.

Bug: T111041
Change-Id: I3c6447e1280abf3db5a60e96eb581d8d3fea618c
---
M src/themes/apex/icons-editing-advanced.json
D src/themes/apex/images/icons/puzzle-ltr.svg
D src/themes/apex/images/icons/puzzle-rtl.svg
A src/themes/apex/images/icons/template.svg
M src/themes/wikimediaui/icons-editing-advanced.json
D src/themes/wikimediaui/images/icons/puzzle-ltr.svg
D src/themes/wikimediaui/images/icons/puzzle-rtl.svg
A src/themes/wikimediaui/images/icons/template.svg
8 files changed, 14 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/42/362242/1

diff --git a/src/themes/apex/icons-editing-advanced.json 
b/src/themes/apex/icons-editing-advanced.json
index ea2e2ec..92878a4 100644
--- a/src/themes/apex/icons-editing-advanced.json
+++ b/src/themes/apex/icons-editing-advanced.json
@@ -39,10 +39,7 @@
"ltr": "images/icons/outline-ltr.svg",
"rtl": "images/icons/outline-rtl.svg"
} },
-   "puzzle": { "file": {
-   "ltr": "images/icons/puzzle-ltr.svg",
-   "rtl": "images/icons/puzzle-rtl.svg"
-   } },
+   "puzzle": { "file": "images/icons/template.svg" },
"quotes": { "file": {
"ltr": "images/icons/quotes-ltr.svg",
"rtl": "images/icons/quotes-rtl.svg"
diff --git a/src/themes/apex/images/icons/puzzle-ltr.svg 
b/src/themes/apex/images/icons/puzzle-ltr.svg
deleted file mode 100644
index fb9d338..000
--- a/src/themes/apex/images/icons/puzzle-ltr.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-
-http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24">
-
-
diff --git a/src/themes/apex/images/icons/puzzle-rtl.svg 
b/src/themes/apex/images/icons/puzzle-rtl.svg
deleted file mode 100644
index 1d48308..000
--- a/src/themes/apex/images/icons/puzzle-rtl.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-
-http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24">
-
-
diff --git a/src/themes/apex/images/icons/template.svg 
b/src/themes/apex/images/icons/template.svg
new file mode 100644
index 000..af872de
--- /dev/null
+++ b/src/themes/apex/images/icons/template.svg
@@ -0,0 +1,6 @@
+
+http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24">
+
+
+
+
diff --git a/src/themes/wikimediaui/icons-editing-advanced.json 
b/src/themes/wikimediaui/icons-editing-advanced.json
index 7cbbced..c70d0cb 100644
--- a/src/themes/wikimediaui/icons-editing-advanced.json
+++ b/src/themes/wikimediaui/icons-editing-advanced.json
@@ -59,10 +59,7 @@
"ltr": "images/icons/outline-ltr.svg",
"rtl": "images/icons/outline-rtl.svg"
} },
-   "puzzle": { "file": {
-   "ltr": "images/icons/puzzle-ltr.svg",
-   "rtl": "images/icons/puzzle-rtl.svg"
-   } },
+   "puzzle": { "file": "images/icons/template.svg" },
"quotes": { "file": {
"ltr": "images/icons/quotes-ltr.svg",
"rtl": "images/icons/quotes-rtl.svg"
diff --git a/src/themes/wikimediaui/images/icons/puzzle-ltr.svg 
b/src/themes/wikimediaui/images/icons/puzzle-ltr.svg
deleted file mode 100644
index fb9d338..000
--- a/src/themes/wikimediaui/images/icons/puzzle-ltr.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-
-http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24">
-
-
diff --git a/src/themes/wikimediaui/images/icons/puzzle-rtl.svg 
b/src/themes/wikimediaui/images/icons/puzzle-rtl.svg
deleted file mode 100644
index 1d48308..000
--- a/src/themes/wikimediaui/images/icons/puzzle-rtl.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-
-http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24">
-
-
diff --git a/src/themes/wikimediaui/images/icons/template.svg 
b/src/themes/wikimediaui/images/icons/template.svg
new file mode 100644
index 000..af872de
--- /dev/null
+++ b/src/themes/wikimediaui/images/icons/template.svg
@@ -0,0 +1,6 @@
+
+http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24">
+
+
+
+

-- 
To view, visit https://gerrit.wikimedia.org/r/362242
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c6447e1280abf3db5a60e96eb581d8d3fea618c
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOjs UI to v0.22.2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362144 )

Change subject: Update OOjs UI to v0.22.2
..

Update OOjs UI to v0.22.2

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.2

Change-Id: If6a7aa1d924b416fc95831e1a1b26313e6482cbf
---
M composer.json
M composer.lock
M composer/installed.json
M oojs/oojs-ui/History.md
M oojs/oojs-ui/bin/docparser.rb
M oojs/oojs-ui/bin/testsuitegenerator.rb
M oojs/oojs-ui/demos/demo.js
M oojs/oojs-ui/demos/demos.php
M oojs/oojs-ui/demos/index.html
M oojs/oojs-ui/demos/pages/icons.js
M oojs/oojs-ui/demos/pages/widgets.js
M oojs/oojs-ui/demos/styles/demo.css
M oojs/oojs-ui/i18n/jv.json
M oojs/oojs-ui/package.json
M oojs/oojs-ui/php/mixins/TabIndexedElement.php
15 files changed, 433 insertions(+), 204 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/44/362144/1

diff --git a/composer.json b/composer.json
index 4a05d97..587d9d8 100644
--- a/composer.json
+++ b/composer.json
@@ -45,7 +45,7 @@
"monolog/monolog": "1.22.1",
"mustangostang/spyc": "0.6.2",
"nmred/kafka-php": "0.1.5",
-   "oojs/oojs-ui": "0.22.1",
+   "oojs/oojs-ui": "0.22.2",
"oyejorge/less.php": "1.7.0.14",
"pear/console_getopt": "1.4.1",
"pear/mail": "1.3.0",
diff --git a/composer.lock b/composer.lock
index 167b31a..daa16e8 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"content-hash": "52a3bd30d59872778eaf081e7734b7c9",
+"content-hash": "d5635cfadceb2bfc5954f0657124a504",
 "packages": [
 {
 "name": "composer/semver",
@@ -516,16 +516,16 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.22.1",
+"version": "v0.22.2",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "610ed06f7aa8d915e689efad93c45a2d54206031"
+"reference": "ca5f31425138961c4a779d8e0d7674f16dbc7d24"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/610ed06f7aa8d915e689efad93c45a2d54206031;,
-"reference": "610ed06f7aa8d915e689efad93c45a2d54206031",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/ca5f31425138961c4a779d8e0d7674f16dbc7d24;,
+"reference": "ca5f31425138961c4a779d8e0d7674f16dbc7d24",
 "shasum": ""
 },
 "require": {
@@ -591,7 +591,7 @@
 ],
 "description": "Provides library of common widgets, layouts, and 
windows.",
 "homepage": "https://www.mediawiki.org/wiki/OOjs_UI;,
-"time": "2017-05-31T18:50:29+00:00"
+"time": "2017-06-28T19:15:29+00:00"
 },
 {
 "name": "oyejorge/less.php",
diff --git a/composer/installed.json b/composer/installed.json
index 9097952..1e05c03 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -2215,18 +2215,67 @@
 ]
 },
 {
-"name": "oojs/oojs-ui",
-"version": "v0.22.1",
-"version_normalized": "0.22.1.0",
+"name": "wikimedia/css-sanitizer",
+"version": "v1.0.2",
+"version_normalized": "1.0.2.0",
 "source": {
 "type": "git",
-"url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "610ed06f7aa8d915e689efad93c45a2d54206031"
+"url": "https://github.com/wikimedia/css-sanitizer.git;,
+"reference": "53071d588f7ac20f1467fb5952e968c1f8e2bb69"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/610ed06f7aa8d915e689efad93c45a2d54206031;,
-"reference": "610ed06f7aa8d915e689efad93c45a2d54206031",
+"url": 
"https://api.github.com/repos/wikimedia/css-sanitizer/zipball/53071d588f7ac20f1467fb5952e968c1f8e2bb69;,
+"reference": "53071d588f7ac20f1467fb5952e968c1f8e2bb69",
+"shasum": ""
+},
+"require": {
+"ext-iconv": "*",
+"ext-mbstring": "*",
+"mediawiki/at-ease": "1.1.0",
+"php": ">=5.5.9",
+"wikimedia/utfnormal": "1.1.0"
+},
+"require-dev": {
+"jakub-onderka/php-parallel-lint": "0.9.2",
+"mediawiki/mediawiki-codesniffer": "0.7.2",
+"phpunit/phpunit": "4.8.31",
+"wikimedia/testing-access-wrapper": "1.0.0"
+},
+"time": 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update OOjs UI to v0.22.2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362142 )

Change subject: Update OOjs UI to v0.22.2
..

Update OOjs UI to v0.22.2

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.2

Depends-On: If6a7aa1d924b416fc95831e1a1b26313e6482cbf
Change-Id: I36a5329fe7d6e134ec1f7b5583017ddff64ca03a
---
M composer.json
M resources/lib/oojs-ui/i18n/jv.json
M resources/lib/oojs-ui/oojs-ui-apex.js
M resources/lib/oojs-ui/oojs-ui-core-apex.css
M resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-core.js
M resources/lib/oojs-ui/oojs-ui-core.js.map
M resources/lib/oojs-ui/oojs-ui-toolbars-apex.css
M resources/lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-toolbars.js
M resources/lib/oojs-ui/oojs-ui-widgets-apex.css
M resources/lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-widgets.js
M resources/lib/oojs-ui/oojs-ui-widgets.js.map
M resources/lib/oojs-ui/oojs-ui-wikimediaui.js
M resources/lib/oojs-ui/oojs-ui-windows-apex.css
M resources/lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-windows.js
M resources/lib/oojs-ui/themes/apex/icons-layout.json
M resources/lib/oojs-ui/themes/apex/icons-movement.json
R resources/lib/oojs-ui/themes/apex/images/icons/draggable.png
R resources/lib/oojs-ui/themes/apex/images/icons/draggable.svg
M resources/lib/oojs-ui/themes/wikimediaui/icons-layout.json
M resources/lib/oojs-ui/themes/wikimediaui/icons-movement.json
R resources/lib/oojs-ui/themes/wikimediaui/images/icons/draggable-invert.png
R resources/lib/oojs-ui/themes/wikimediaui/images/icons/draggable-invert.svg
R 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/draggable-progressive.png
R 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/draggable-progressive.svg
R resources/lib/oojs-ui/themes/wikimediaui/images/icons/draggable.png
R resources/lib/oojs-ui/themes/wikimediaui/images/icons/draggable.svg
30 files changed, 426 insertions(+), 329 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/42/362142/1


-- 
To view, visit https://gerrit.wikimedia.org/r/362142
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I36a5329fe7d6e134ec1f7b5583017ddff64ca03a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs UI to v0.22.2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362143 )

Change subject: Update OOjs UI to v0.22.2
..

Update OOjs UI to v0.22.2

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.2

Change-Id: If6a7aa1d924b416fc95831e1a1b26313e6482cbf
---
M lib/oojs-ui/i18n/jv.json
M lib/oojs-ui/oojs-ui-apex-icons-alerts.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-content.css
M lib/oojs-ui/oojs-ui-apex-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-media.css
M lib/oojs-ui/oojs-ui-apex-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-user.css
M lib/oojs-ui/oojs-ui-apex-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-apex.css
M lib/oojs-ui/oojs-ui-apex.js
M lib/oojs-ui/oojs-ui-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-apex.css
M lib/oojs-ui/oojs-ui-core-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-mediawiki.css
M lib/oojs-ui/oojs-ui-core-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-core.js
M lib/oojs-ui/oojs-ui-core.js.map
M lib/oojs-ui/oojs-ui-images-apex.css
M lib/oojs-ui/oojs-ui-images-apex.rtl.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-accessibility.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki.css
M lib/oojs-ui/oojs-ui-mediawiki.js
M lib/oojs-ui/oojs-ui-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-apex.css
M lib/oojs-ui/oojs-ui-toolbars-apex.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars.js
M lib/oojs-ui/oojs-ui-widgets-apex.css
M lib/oojs-ui/oojs-ui-widgets-apex.rtl.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-widgets.js
M lib/oojs-ui/oojs-ui-widgets.js.map
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.rtl.css
M 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (b528a5321)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/361940 )

Change subject: Update VE core submodule to master (b528a5321)
..

Update VE core submodule to master (b528a5321)

New changes:
44d2d666c Remove custom icon sizing from block slugs
793d131f9 Ignore covering annotations when looking for plain text pastes
b0025f3ab dm.Document fixupInsertion: check suggestedParents as well
73ce638f1 ve.ui.TableLineContext: Fancier popups
9d54d531e Visual Diff: add internal list diff
4f4e121b5 DiffElement: Add hacky support for template-defined references

Bug: T153315
Bug: T162819
Bug: T164017
Bug: T165865
Change-Id: Id7c434af397367f4f9e12a8f4cc282b1500c7054
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/40/361940/1

diff --git a/lib/ve b/lib/ve
index b3ce196..b528a53 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit b3ce1967f504c6c6b8632150934fa5765d736276
+Subproject commit b528a532135f0806a310d1cb4832ac0cff20c00b

-- 
To view, visit https://gerrit.wikimedia.org/r/361940
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7c434af397367f4f9e12a8f4cc282b1500c7054
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: VisualEditorHooks#onDiffViewHeader: Don't add type hint as t...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/361938 )

Change subject: VisualEditorHooks#onDiffViewHeader: Don't add type hint as the 
hook sucks
..

VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks

It'd be nice if the hook didn't.

Bug: T169132
Change-Id: Iabe75448bbedebf8164d9c8223a4d59d0281e66e
---
M VisualEditor.hooks.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/38/361938/1

diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 3d3eaaa..1415e4b 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -79,8 +79,8 @@
 
public static function onDiffViewHeader(
DifferenceEngine $diff,
-   Revision $oldRev,
-   Revision $newRev
+   /* Revision */ $oldRev,
+   /* Revision */ $newRev
) {
$config = ConfigFactory::getDefaultInstance()->makeConfig( 
'visualeditor' );
$output = RequestContext::getMain()->getOutput();

-- 
To view, visit https://gerrit.wikimedia.org/r/361938
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabe75448bbedebf8164d9c8223a4d59d0281e66e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: build: Drop all Ruby-related CI files

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/361929 )

Change subject: build: Drop all Ruby-related CI files
..

build: Drop all Ruby-related CI files

Since the conversion of the browser tests to be JavaScript-based, we
don't really need these, and they're certainly not being used.

Change-Id: Iec5a6dae3040e6507b8f61640c5dccd15cf113b9
---
D .rubocop.yml
D .rubocop_todo.yml
D Gemfile
D Gemfile.lock
D Rakefile
5 files changed, 0 insertions(+), 175 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/29/361929/1

diff --git a/.rubocop.yml b/.rubocop.yml
deleted file mode 100644
index c4d7615..000
--- a/.rubocop.yml
+++ /dev/null
@@ -1,23 +0,0 @@
-inherit_from: .rubocop_todo.yml
-
-AllCops:
-  StyleGuideCopsOnly: true
-
-# uncomment when the offense is fixed
-# Metrics/LineLength:
-#   Max: 100
-
-Metrics/MethodLength:
-  Enabled: false
-
-Style/Alias:
-  Enabled: false
-
-Style/SignalException:
-  Enabled: false
-
-Style/StringLiterals:
-  EnforcedStyle: single_quotes
-
-Style/TrivialAccessors:
-  ExactNameMatch: true
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
deleted file mode 100644
index 26e59ec..000
--- a/.rubocop_todo.yml
+++ /dev/null
@@ -1,15 +0,0 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2016-02-15 14:53:20 +0100 using RuboCop version 0.32.1.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 1
-Lint/HandleExceptions:
-  Enabled: false
-
-# Offense count: 56
-# Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 398
diff --git a/Gemfile b/Gemfile
deleted file mode 100644
index 3f10f1d..000
--- a/Gemfile
+++ /dev/null
@@ -1,6 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'commons_upload', '~> 1.0', '>= 1.0.1'
-gem 'mediawiki_selenium', '~> 1.8'
-gem 'rake', '~> 10.4', '>= 10.4.2'
-gem 'rubocop', '~> 0.32.1', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
deleted file mode 100644
index e67ecc9..000
--- a/Gemfile.lock
+++ /dev/null
@@ -1,114 +0,0 @@
-GEM
-  remote: https://rubygems.org/
-  specs:
-ast (2.3.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
-builder (3.2.3)
-childprocess (0.6.2)
-  ffi (~> 1.0, >= 1.0.11)
-commons_upload (1.0.1)
-  mediawiki_api (~> 0.7.0)
-cucumber (1.3.20)
-  builder (>= 2.1.2)
-  diff-lcs (>= 1.1.3)
-  gherkin (~> 2.12)
-  multi_json (>= 1.7.5, < 2.0)
-  multi_test (>= 0.1.2)
-data_magic (1.0)
-  faker (>= 1.1.2)
-  yml_reader (>= 0.6)
-diff-lcs (1.3)
-domain_name (0.5.20160615)
-  unf (>= 0.0.5, < 1.0.0)
-faker (1.7.3)
-  i18n (~> 0.5)
-faraday (0.9.2)
-  multipart-post (>= 1.2, < 3)
-faraday-cookie_jar (0.0.6)
-  faraday (>= 0.7.4)
-  http-cookie (~> 1.0.0)
-faraday_middleware (0.10.0)
-  faraday (>= 0.7.4, < 0.10)
-ffi (1.9.17)
-gherkin (2.12.2)
-  multi_json (~> 1.3)
-headless (2.3.1)
-http-cookie (1.0.2)
-  domain_name (~> 0.5)
-i18n (0.8.1)
-json (2.0.3)
-mediawiki_api (0.7.0)
-  faraday (~> 0.9, >= 0.9.0)
-  faraday-cookie_jar (~> 0.0, >= 0.0.6)
-  faraday_middleware (~> 0.10, >= 0.10.0)
-mediawiki_selenium (1.8.0)
-  cucumber (~> 1.3, >= 1.3.20)
-  headless (~> 2.0, >= 2.1.0)
-  json (~> 2.0, >= 2.0.2)
-  mediawiki_api (~> 0.7, >= 0.7.0)
-  page-object (~> 2.0)
-  rest-client (~> 1.6, >= 1.6.7)
-  rspec-core (~> 2.14, >= 2.14.4)
-  rspec-expectations (~> 2.14, >= 2.14.4)
-  selenium-webdriver (~> 3.1.0)
-  syntax (~> 1.2, >= 1.2.0)
-  thor (~> 0.19, >= 0.19.1)
-mime-types (2.99.3)
-multi_json (1.12.1)
-multi_test (0.1.2)
-multipart-post (2.0.0)
-net-http-persistent (2.9.4)
-netrc (0.11.0)
-page-object (2.0.0)
-  net-http-persistent (~> 2.9.4)
-  page_navigation (>= 0.9)
-  selenium-webdriver (~> 3.0)
-  watir (~> 6.0)
-page_navigation (0.10)
-  data_magic (>= 0.22)
-parser (2.3.1.2)
-  ast (~> 2.2)
-powerpack (0.1.1)
-rainbow (2.1.0)
-rake (10.5.0)
-rest-client (1.8.0)
-  http-cookie (>= 1.0.2, < 2.0)
-  mime-types (>= 1.16, < 3.0)
-  netrc (~> 0.7)
-rspec-core (2.99.2)
-rspec-expectations (2.99.2)
-  diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.32.1)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.2.5, < 3.0)
-  powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.4)
-ruby-progressbar (1.8.1)
-rubyzip (1.2.1)
-selenium-webdriver (3.1.0)
-  childprocess (~> 0.5)
-  rubyzip (~> 1.0)
-  websocket (~> 1.0)
-syntax (1.2.1)
-

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Tag v0.22.2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/361908 )

Change subject: Tag v0.22.2
..

Tag v0.22.2

Change-Id: Ia6869683152b7a4910a3ff3d06aec3463552f98e
---
M History.md
M package.json
2 files changed, 39 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/08/361908/1

diff --git a/History.md b/History.md
index 2a800a6..1c58818 100644
--- a/History.md
+++ b/History.md
@@ -1,4 +1,42 @@
 # OOjs UI Release History
+## v0.22.2 / 2017-06-28
+### Deprecations
+* [DEPRECATING CHANGE] TextInputWidget: Move multi-line support out (Prateek 
Saxena)
+* [DEPRECATING CHANGE] icons: Move and rename 'stripeSideMenu' to 'draggable' 
(Volker E.)
+
+### Features
+* DropdownInputWidget: Unbreak setting 'value' via config options (Bartosz 
Dziewoński)
+* Element: Work around browsers that set fractional scrollTop values (Roan 
Kattouw)
+
+### Styles
+* BookletLayout: Workaround for horizontal scrollbars on menu when editable 
(Bartosz Dziewoński)
+* icons: Let's stop referring to removed icons, hmm? (James D. Forrester)
+* Rewrite all styling for "outline controls" (Bartosz Dziewoński)
+* Apex theme: Fix HorizontalLayout containing FieldLayouts (Bartosz Dziewoński)
+* WikimediaUI theme: Remove default DraggableElement styling (Ed Sanders)
+* WikimediaUI theme: Use icon instead of indicator in Tag-/CapsuleItemWidget 
(Volker E.)
+* WikimediaUI: Strengthen Radio*Widget's `:checked` state (Volker E.)
+
+### Code
+* MenuSelectWidget: Fix item hiding when menu contents change (Roan Kattouw)
+* MultilineTextInputWidget: Fix autosizing (Bartosz Dziewoński)
+* PopupWidget: Replace CSS with Less comments for smaller dist (Volker E.)
+* SearchInputWidget: Fix ability to clear the input (Bartosz Dziewoński)
+* TabIndexedElement: Fix validation and make consistent in PHP and JS (Bartosz 
Dziewoński)
+* Use javascript-stringify instead of JSON.stringify (Ed Sanders)
+* Apex theme: Fix order of selectors for :first-child FieldLayout (Bartosz 
Dziewoński)
+* demos: Add links to documentation from code examples (Prateek Saxena)
+* demos: Allow linking to specific widgets (Bartosz Dziewoński)
+* demos: Indicate code toggle clearer (Volker E.)
+* demos: Pull out all links to docs/sources to the top of the code (Bartosz 
Dziewoński)
+* demos: Simplify code generation, now that we use javascript-stringify 
(Bartosz Dziewoński)
+* demos: Use URL 'query' part for linking to demo sections rather than URL 
'fragment' (Bartosz Dziewoński)
+* docs: Fix some typos in documentation (Bartosz Dziewoński)
+* docparser: Fix handling for fake trait constructors (Bartosz Dziewoński)
+* docparser: Make matching '(default: ...)' case-insensitive (Bartosz 
Dziewoński)
+* docparser: Tighter check for 'use' statements in PHP (Bartosz Dziewoński)
+
+
 ## v0.22.1 / 2017-05-31
 ### Code
 * WindowManager: Do not use return value of `#closeWindow` as promise (Bartosz 
Dziewoński)
diff --git a/package.json b/package.json
index bd141c2..fb48d4d 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "oojs-ui",
-  "version": "0.22.1",
+  "version": "0.22.2",
   "description": "User interface classes built on the OOjs framework.",
   "keywords": [
 "oojs-plugin",

-- 
To view, visit https://gerrit.wikimedia.org/r/361908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6869683152b7a4910a3ff3d06aec3463552f98e
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (b3ce1967f)

[Jforrester (Code Review)]

Jforrester has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/361683 )

Change subject: Update VE core submodule to master (b3ce1967f)
..


Update VE core submodule to master (b3ce1967f)

New changes:
217103924 ce.TextState#getChunks: Use instanceof to check for LeafNodes

Bug: T167009
Change-Id: Ic356ce49b4f12bcfc4f6f70361f929d3ec283a19
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Deskana: Looks good to me, approved
  Jforrester: Verified



diff --git a/lib/ve b/lib/ve
index b3a7707..b3ce196 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit b3a77074a69b9e9785b0bda4916d326aa2fbe958
+Subproject commit b3ce1967f504c6c6b8632150934fa5765d736276

-- 
To view, visit https://gerrit.wikimedia.org/r/361683
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic356ce49b4f12bcfc4f6f70361f929d3ec283a19
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Deskana 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Ensure MWInlineImages get the ve-ce-leafNode class

[Jforrester (Code Review)]

Jforrester has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/360907 )

Change subject: Ensure MWInlineImages get the ve-ce-leafNode class
..


Ensure MWInlineImages get the ve-ce-leafNode class

Without this class, offset calculations fail and model/view
sync can be lost.

Bug: T167009
Change-Id: Ie7b6551ac5a532949c14122b9ee7584a794af0f2
---
M VisualEditor.hooks.php
M modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
M modules/ve-mw/tests/ce/ve.ce.ContentBranchNode.test.js
A modules/ve-mw/tests/ce/ve.ce.Document.test.js
M modules/ve-mw/tests/ce/ve.ce.Surface.test.js
M modules/ve-mw/tests/dm/ve.dm.mwExample.js
6 files changed, 51 insertions(+), 11 deletions(-)

Approvals:
  Divec: Looks good to me, approved
  Jforrester: Verified; Looks good to me, but someone else must approve



diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 68b7622..620728d 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -926,6 +926,7 @@
// VisualEditor ContentEditable Tests
'lib/ve/tests/ce/ve.ce.test.js',
'lib/ve/tests/ce/ve.ce.Document.test.js',
+   'modules/ve-mw/tests/ce/ve.ce.Document.test.js',
'lib/ve/tests/ce/ve.ce.Surface.test.js',
'modules/ve-mw/tests/ce/ve.ce.Surface.test.js',
'lib/ve/tests/ce/ve.ce.RangeState.test.js',
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js 
b/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
index c7314e6..a258af9 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
@@ -16,20 +16,16 @@
  * @param {ve.dm.MWInlineImageNode} model Model to observe
  * @param {Object} [config] Configuration options
  */
-ve.ce.MWInlineImageNode = function VeCeMWInlineImageNode() {
-   var isError, $image;
-   // Parent constructor
-   ve.ce.MWInlineImageNode.super.apply( this, arguments );
+ve.ce.MWInlineImageNode = function VeCeMWInlineImageNode( model, config ) {
+   var $image;
 
-   isError = this.model.getAttribute( 'isError' );
-
-   if ( isError ) {
+   if ( model.getAttribute( 'isError' ) ) {
this.$element = $( '' )
.addClass( 'new' )
-   .text( this.model.getFilename() );
+   .text( model.getFilename() );
$image = $( [] );
} else {
-   if ( this.model.getAttribute( 'isLinked' ) ) {
+   if ( model.getAttribute( 'isLinked' ) ) {
this.$element = $( '' ).addClass( 'image' );
$image = $( '' ).appendTo( this.$element );
} else {
@@ -37,6 +33,11 @@
}
}
 
+   // Parent constructor
+   // this.$element has already been created and styled, so pass through 
as config.$element
+   // The constructor will add more classes to this.$element, such as 
ve-ce-leafNode
+   ve.ce.MWInlineImageNode.super.call( this, model, ve.extendObject( {}, 
config, { $element: this.$element } ) );
+
// Mixin constructors
ve.ce.MWImageNode.call( this, this.$element, $image );
 
diff --git a/modules/ve-mw/tests/ce/ve.ce.ContentBranchNode.test.js 
b/modules/ve-mw/tests/ce/ve.ce.ContentBranchNode.test.js
index c02dcbc..1f328fc 100644
--- a/modules/ve-mw/tests/ce/ve.ce.ContentBranchNode.test.js
+++ b/modules/ve-mw/tests/ce/ve.ce.ContentBranchNode.test.js
@@ -1,5 +1,5 @@
 /*!
- * VisualEditor ContentEditable MediaWiki-specific ContentBranchNode tests.
+ * VisualEditor MediaWiki-specific ContentEditable ContentBranchNode tests.
  *
  * @copyright 2011-2017 VisualEditor Team and others; see AUTHORS.txt
  * @license The MIT License (MIT); see LICENSE.txt
diff --git a/modules/ve-mw/tests/ce/ve.ce.Document.test.js 
b/modules/ve-mw/tests/ce/ve.ce.Document.test.js
new file mode 100644
index 000..f4224dc
--- /dev/null
+++ b/modules/ve-mw/tests/ce/ve.ce.Document.test.js
@@ -0,0 +1,31 @@
+/*!
+ * VisualEditor MediaWiki-specific ContentEditable Document tests.
+ *
+ * @copyright 2011-2017 VisualEditor Team and others; see 
http://ve.mit-license.org
+ */
+
+QUnit.module( 've.ce.Document (MW)' );
+
+/* Tests */
+
+QUnit.test( 'Converter tests', function ( assert ) {
+   var msg, model, view, caseItem, $documentElement,
+   cases = ve.dm.mwExample.domToDataCases;
+
+   for ( msg in cases ) {
+   if ( cases[ msg ].ceHtml ) {
+   caseItem = ve.copy( cases[ msg ] );
+   model = ve.test.utils.getModelFromTestCase( caseItem );
+   view = new ve.ce.Document( model );
+   $documentElement = view.getDocumentNode().$element;
+   // 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (b3ce1967f)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/361683 )

Change subject: Update VE core submodule to master (b3ce1967f)
..

Update VE core submodule to master (b3ce1967f)

New changes:
217103924 ce.TextState#getChunks: Use instanceof to check for LeafNodes

Bug: T167009
Change-Id: Ic356ce49b4f12bcfc4f6f70361f929d3ec283a19
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/83/361683/1

diff --git a/lib/ve b/lib/ve
index b3a7707..b3ce196 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit b3a77074a69b9e9785b0bda4916d326aa2fbe958
+Subproject commit b3ce1967f504c6c6b8632150934fa5765d736276

-- 
To view, visit https://gerrit.wikimedia.org/r/361683
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic356ce49b4f12bcfc4f6f70361f929d3ec283a19
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits