Re: [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

[Michael Schellenberger Costa]

Hi Jason,

Am 19.05.2016 um 09:20 schrieb Jason Ekstrand:
> Right now, we're just setting the range to [0, MAX_UINT32] which, while
> correct isn't helpful.  With DrawIndirect, you can't really know what the
> actual range is so we may as well flag it as being an invalid range.  This
> is what we do for draws with index buffer which is similar (the indices
> aren't statically known) if a bit simpler.
> 
> Cc: "10.2" 
> ---
>  src/mesa/vbo/vbo_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c
> index 9f807a1..ae5d265 100644
> --- a/src/mesa/vbo/vbo_context.c
> +++ b/src/mesa/vbo/vbo_context.c
> @@ -170,7 +170,7 @@ vbo_draw_indirect_prims(struct gl_context *ctx,
> }
>  
> vbo->draw_prims(ctx, prim, draw_count,
> -   ib, GL_TRUE, 0, ~0,
> +   ib, false, ~0, ~0,
Out of curiosity. The former was GL_TRUE so shouldn't you use GL_FALSE
here or do you plan to migrate that? If you do you might want to sed
them for that file?
--Michael
> NULL, 0,
> ctx->DrawIndirectBuffer);
>  
> 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

[Kenneth Graunke]

On Thursday, May 19, 2016 12:20:58 AM PDT Jason Ekstrand wrote:
> Right now, we're just setting the range to [0, MAX_UINT32] which, while
> correct isn't helpful.  With DrawIndirect, you can't really know what the
> actual range is so we may as well flag it as being an invalid range.  This
> is what we do for draws with index buffer which is similar (the indices
> aren't statically known) if a bit simpler.
> 
> Cc: "10.2" 
> ---
>  src/mesa/vbo/vbo_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c
> index 9f807a1..ae5d265 100644
> --- a/src/mesa/vbo/vbo_context.c
> +++ b/src/mesa/vbo/vbo_context.c
> @@ -170,7 +170,7 @@ vbo_draw_indirect_prims(struct gl_context *ctx,
> }
>  
> vbo->draw_prims(ctx, prim, draw_count,
> -   ib, GL_TRUE, 0, ~0,
> +   ib, false, ~0, ~0,
> NULL, 0,
> ctx->DrawIndirectBuffer);
>  
> 


Patches 1-3 are:
Reviewed-by: Kenneth Graunke 


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

[Ian Romanick]

On 05/19/2016 12:20 AM, Jason Ekstrand wrote:
> Right now, we're just setting the range to [0, MAX_UINT32] which, while
> correct isn't helpful.  With DrawIndirect, you can't really know what the
> actual range is so we may as well flag it as being an invalid range.  This
> is what we do for draws with index buffer which is similar (the indices
> aren't statically known) if a bit simpler.
> 
> Cc: "10.2" 

I don't think this is the stable tagging that you intended. :)  These
are definitely candidates for as far back as Emil is cherry-picking
patches.  Maybe "11.0 11.1 11.2" ?

In any case, as discussed on IRC, this patch is

Reviewed-by: Ian Romanick 

> ---
>  src/mesa/vbo/vbo_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c
> index 9f807a1..ae5d265 100644
> --- a/src/mesa/vbo/vbo_context.c
> +++ b/src/mesa/vbo/vbo_context.c
> @@ -170,7 +170,7 @@ vbo_draw_indirect_prims(struct gl_context *ctx,
> }
>  
> vbo->draw_prims(ctx, prim, draw_count,
> -   ib, GL_TRUE, 0, ~0,
> +   ib, false, ~0, ~0,

I'd be in favor of a follow-up patch that converts this GLboolean to
bool everywhere. :)

> NULL, 0,
> ctx->DrawIndirectBuffer);
>  

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

[Iago Toral]

I left a minor comment in patch 4,  but other than that patches 1-4 are:
Reviewed-by: Iago Toral Quiroga 

On Thu, 2016-05-19 at 00:20 -0700, Jason Ekstrand wrote:
> Right now, we're just setting the range to [0, MAX_UINT32] which, while
> correct isn't helpful.  With DrawIndirect, you can't really know what the
> actual range is so we may as well flag it as being an invalid range.  This
> is what we do for draws with index buffer which is similar (the indices
> aren't statically known) if a bit simpler.
> 
> Cc: "10.2" 
> ---
>  src/mesa/vbo/vbo_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c
> index 9f807a1..ae5d265 100644
> --- a/src/mesa/vbo/vbo_context.c
> +++ b/src/mesa/vbo/vbo_context.c
> @@ -170,7 +170,7 @@ vbo_draw_indirect_prims(struct gl_context *ctx,
> }
>  
> vbo->draw_prims(ctx, prim, draw_count,
> -   ib, GL_TRUE, 0, ~0,
> +   ib, false, ~0, ~0,
> NULL, 0,
> ctx->DrawIndirectBuffer);
>  


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

[Marek Olšák]

Reviewed-by: Marek Olšák 

Marek

On Thu, May 19, 2016 at 9:20 AM, Jason Ekstrand  wrote:
> Right now, we're just setting the range to [0, MAX_UINT32] which, while
> correct isn't helpful.  With DrawIndirect, you can't really know what the
> actual range is so we may as well flag it as being an invalid range.  This
> is what we do for draws with index buffer which is similar (the indices
> aren't statically known) if a bit simpler.
>
> Cc: "10.2" 
> ---
>  src/mesa/vbo/vbo_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c
> index 9f807a1..ae5d265 100644
> --- a/src/mesa/vbo/vbo_context.c
> +++ b/src/mesa/vbo/vbo_context.c
> @@ -170,7 +170,7 @@ vbo_draw_indirect_prims(struct gl_context *ctx,
> }
>
> vbo->draw_prims(ctx, prim, draw_count,
> -   ib, GL_TRUE, 0, ~0,
> +   ib, false, ~0, ~0,
> NULL, 0,
> ctx->DrawIndirectBuffer);
>
> --
> 2.5.0.400.gff86faf
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

[Jason Ekstrand]

Right now, we're just setting the range to [0, MAX_UINT32] which, while
correct isn't helpful.  With DrawIndirect, you can't really know what the
actual range is so we may as well flag it as being an invalid range.  This
is what we do for draws with index buffer which is similar (the indices
aren't statically known) if a bit simpler.

Cc: "10.2" 
---
 src/mesa/vbo/vbo_context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c
index 9f807a1..ae5d265 100644
--- a/src/mesa/vbo/vbo_context.c
+++ b/src/mesa/vbo/vbo_context.c
@@ -170,7 +170,7 @@ vbo_draw_indirect_prims(struct gl_context *ctx,
}
 
vbo->draw_prims(ctx, prim, draw_count,
-   ib, GL_TRUE, 0, ~0,
+   ib, false, ~0, ~0,
NULL, 0,
ctx->DrawIndirectBuffer);
 
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev