Re: [Mesa-dev] [PATCH V4 00/19] ARB_texture_multisample support
On 26 February 2013 02:10, Chris Forbes chr...@ijw.co.nz wrote: This series adds the core mesa bits for ARB_texture_multisample, and support in the i965 driver for Gen6 and Gen7. I've addressed the issues that were raised for V3, and also fixed some other bugs which I found while beefing up the piglit coverage for this. - Proxy texture targets were denied in glTexImage*Multisample. - I was lying to the i965 fs regalloc about how many regs were written by the sampler message, so it was clobbering the results in nontrivial shaders. Things for another day: - CMS layout support on Gen7. - Verify multisample depth arrays. Until this is done, we only advertise MAX_DEPTH_TEXTURE_SAMPLES=1. A follow-up series addresses the interactions between this extension, classic multisample renderbuffer creation, and internalformat_query, which resolves the remaining TODO in 12/19. -- Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev I just ran this series through a full piglit run on my Ivy Bridge machine, and got two regressions: - spec/!OpenGL 1.1/push-pop-texture-state - spec/ARB_internalformat_query/minmax Are you aware of these regressions? Do you know what's causing them? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH V4 00/19] ARB_texture_multisample support
The minmax regression is addressed by my followup series, which adds the internalformat_query interactions. Do I need to fold that into this one? On Sat, Mar 2, 2013 at 7:59 AM, Paul Berry stereotype...@gmail.com wrote: On 26 February 2013 02:10, Chris Forbes chr...@ijw.co.nz wrote: This series adds the core mesa bits for ARB_texture_multisample, and support in the i965 driver for Gen6 and Gen7. I've addressed the issues that were raised for V3, and also fixed some other bugs which I found while beefing up the piglit coverage for this. - Proxy texture targets were denied in glTexImage*Multisample. - I was lying to the i965 fs regalloc about how many regs were written by the sampler message, so it was clobbering the results in nontrivial shaders. Things for another day: - CMS layout support on Gen7. - Verify multisample depth arrays. Until this is done, we only advertise MAX_DEPTH_TEXTURE_SAMPLES=1. A follow-up series addresses the interactions between this extension, classic multisample renderbuffer creation, and internalformat_query, which resolves the remaining TODO in 12/19. -- Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev I just ran this series through a full piglit run on my Ivy Bridge machine, and got two regressions: - spec/!OpenGL 1.1/push-pop-texture-state - spec/ARB_internalformat_query/minmax Are you aware of these regressions? Do you know what's causing them? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH V4 00/19] ARB_texture_multisample support
I've had a quick look at the push-pop-texture-state regression, and that looks like a real bug I've introduced. I'm looking into it. On Sat, Mar 2, 2013 at 8:44 AM, Chris Forbes chr...@ijw.co.nz wrote: The minmax regression is addressed by my followup series, which adds the internalformat_query interactions. Do I need to fold that into this one? On Sat, Mar 2, 2013 at 7:59 AM, Paul Berry stereotype...@gmail.com wrote: On 26 February 2013 02:10, Chris Forbes chr...@ijw.co.nz wrote: This series adds the core mesa bits for ARB_texture_multisample, and support in the i965 driver for Gen6 and Gen7. I've addressed the issues that were raised for V3, and also fixed some other bugs which I found while beefing up the piglit coverage for this. - Proxy texture targets were denied in glTexImage*Multisample. - I was lying to the i965 fs regalloc about how many regs were written by the sampler message, so it was clobbering the results in nontrivial shaders. Things for another day: - CMS layout support on Gen7. - Verify multisample depth arrays. Until this is done, we only advertise MAX_DEPTH_TEXTURE_SAMPLES=1. A follow-up series addresses the interactions between this extension, classic multisample renderbuffer creation, and internalformat_query, which resolves the remaining TODO in 12/19. -- Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev I just ran this series through a full piglit run on my Ivy Bridge machine, and got two regressions: - spec/!OpenGL 1.1/push-pop-texture-state - spec/ARB_internalformat_query/minmax Are you aware of these regressions? Do you know what's causing them? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH V4 00/19] ARB_texture_multisample support
I missed a case in attrib.c; this small patch should be folded in with the rest of the changes which add support for the new targets: commit 8b16367bab07cfe2eb44cc96a22bb925593b1e20 Author: Chris Forbes chr...@ijw.co.nz Date: Sat Mar 2 09:10:25 2013 +1300 fixup glPopAttrib(GL_TEXTURE_BIT) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index a951283..5bb63ea 100644 --- a/src/mesa/main/attrib.c +++ b/src/mesa/main/attrib.c @@ -767,6 +767,9 @@ pop_texture_group(struct gl_context *ctx, struct texture_state *texstate) continue; else if (obj-Target == GL_TEXTURE_EXTERNAL_OES) continue; + else if (obj-Target == GL_TEXTURE_2D_MULTISAMPLE || + obj-Target == GL_TEXTURE_2D_MULTISAMPLE_ARRAY) +continue; target = obj-Target; ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH V4 00/19] ARB_texture_multisample support
This series adds the core mesa bits for ARB_texture_multisample, and support in the i965 driver for Gen6 and Gen7. I've addressed the issues that were raised for V3, and also fixed some other bugs which I found while beefing up the piglit coverage for this. - Proxy texture targets were denied in glTexImage*Multisample. - I was lying to the i965 fs regalloc about how many regs were written by the sampler message, so it was clobbering the results in nontrivial shaders. Things for another day: - CMS layout support on Gen7. - Verify multisample depth arrays. Until this is done, we only advertise MAX_DEPTH_TEXTURE_SAMPLES=1. A follow-up series addresses the interactions between this extension, classic multisample renderbuffer creation, and internalformat_query, which resolves the remaining TODO in 12/19. -- Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH V4 00/19] ARB_texture_multisample support
On 02/26/2013 02:10 AM, Chris Forbes wrote: This series adds the core mesa bits for ARB_texture_multisample, and support in the i965 driver for Gen6 and Gen7. I've addressed the issues that were raised for V3, and also fixed some other bugs which I found while beefing up the piglit coverage for this. - Proxy texture targets were denied in glTexImage*Multisample. - I was lying to the i965 fs regalloc about how many regs were written by the sampler message, so it was clobbering the results in nontrivial shaders. Things for another day: - CMS layout support on Gen7. - Verify multisample depth arrays. Until this is done, we only advertise MAX_DEPTH_TEXTURE_SAMPLES=1. A follow-up series addresses the interactions between this extension, classic multisample renderbuffer creation, and internalformat_query, which resolves the remaining TODO in 12/19. I'm pretty stoked to see this code land. :) Patches 1 through 9 and 11 are Reviewed-by: Ian Romanick ian.d.roman...@intel.com I don't know the material of patch 10 well enough to give a R-b, but Paul's opinion is good enough for me. Call that Acked-by: Ian Romanick ian.d.roman...@intel.com I sent a minor comment / question about 12. For the rest, I'll defer to people more familiar with the driver back-end. -- Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
