Re: [Musicpd-dev-team] Empty fields
On 09/03/06 10:30 +0100, Max Kellermann wrote: On 2009/03/06 10:24, Jerome Quelin jque...@gmail.com wrote: definitely sure: i had to update the test-suite of the perl modules audio::mpd and poe::component::client::mpd to take this into account. i'm not saying it's right or wrong, but it has definitely changed Ok, so let's talk about whether it's right or wrong. Does it make any sense to have an empty string in a tag value? Should MPD discard the whole tag item in this case? My opinion: kill empty values. that's also my opinion, but then i can understand people wanting to have empty values. indeed, they would not be able to say whether all songs have an album, or if some don't have an album. in the end, i don't really care. just pick a behaviour and stick with it. i would hate to have to update the test suite every mpd version! :-) jérôme -- jque...@gmail.com -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Empty fields
Hi, This behavior has been introduced in MPD 0.14: When MPD returns an empty value, it doesn't mean that the tag is empty but that the tag is unknown (not set in the music file). As a client developer I find this behavior very useful for example if you want to build a tree like this: The Doors L.A. Woman Strange Days Unknown Album It's also useful if some of your music files are badly tagged. Marc 2009/3/6 Jerome Quelin jque...@gmail.com On 09/03/06 10:30 +0100, Max Kellermann wrote: On 2009/03/06 10:24, Jerome Quelin jque...@gmail.com wrote: definitely sure: i had to update the test-suite of the perl modules audio::mpd and poe::component::client::mpd to take this into account. i'm not saying it's right or wrong, but it has definitely changed Ok, so let's talk about whether it's right or wrong. Does it make any sense to have an empty string in a tag value? Should MPD discard the whole tag item in this case? My opinion: kill empty values. that's also my opinion, but then i can understand people wanting to have empty values. indeed, they would not be able to say whether all songs have an album, or if some don't have an album. in the end, i don't really care. just pick a behaviour and stick with it. i would hate to have to update the test suite every mpd version! :-) jérôme -- jque...@gmail.com -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Empty fields
Was that change made on purpose, or is it accidental? I guess this is due to the difference between no genre specified and genre specified, it's an empty string. Do you have one or more files which have an empty string defined there? I don't think distinguishing between there's an empty tag and there's no tag is a good idea. As for whether it's a good idea to show such (empty or missing) tags in the output of list, I can see why it'd be useful, but it breaks my MPC.el client (not in a serious way, mind you). Which is why I'm asking here: depending on the answer I'll fix the corresponding problem or not. Stefan -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Empty fields
On 2009/03/06 05:59, Stefan Monnier monn...@iro.umontreal.ca wrote: Was that change made on purpose, or is it accidental? I guess this is due to the difference between no genre specified and genre specified, it's an empty string. Do you have one or more files which have an empty string defined there? Are you sure that's different from 0.13? Max -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
