Re: [PATCH] Re: [mythtv-users] How well does commercial detection work?

2005-04-12 Thread Risto Treksler
Fixed it myself :)

The patch is attached and it replaces the previous patch and
addresses all four issues.

1) in strict mode - treat frames as blank only if logo is absent
2) more fixes for the long long issue
3) fix for white frames triggering commercials
4) do not detect commercials less than 60 sec long, in the middle of a show


PS
I also highly recommend changing the default max and min comm break lengths

-#define MIN_COMM_BREAK_LENGTH   60
-#define MAX_COMM_BREAK_LENGTH  485
+#define MIN_COMM_BREAK_LENGTH   55
+#define MAX_COMM_BREAK_LENGTH  335

The combination of the above changes seems to detect at 99% accuracy 
with no false positives so far for me.


PPS

On Monday 11 April 2005 11:07 pm, Risto Treksler wrote:
 1) I DO NOT ignore logos in blank frames in STRICT mode

what I meant is that i do not ignore the logo area in strict mode
in effect i do ignore the logo
:)


commercial_skip.updated.diff.bz2
Description: BZip2 compressed data
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [PATCH] Re: [mythtv-users] How well does commercial detection work?

2005-04-12 Thread Risto Treksler
Hmm, 

I sent this last night but it never showed up on the list, 
So I am resending
...
Fixed it myself :)

The patch is attached and it replaces the previous patch and
addresses all four issues.

1) in strict mode - treat frames as blank only if logo is absent
2) more fixes for the long long issue
3) fix for white frames triggering commercials
4) do not detect commercials less than 60 sec long, in the middle of a show


PS
I also highly recommend changing the default max and min comm break lengths

-#define MIN_COMM_BREAK_LENGTH   60
-#define MAX_COMM_BREAK_LENGTH  485
+#define MIN_COMM_BREAK_LENGTH   55
+#define MAX_COMM_BREAK_LENGTH  335

The combination of the above changes seems to detect at 99% accuracy 
with no false positives so far for me.


PPS

On Monday 11 April 2005 11:07 pm, Risto Treksler wrote:
 1) I DO NOT ignore logos in blank frames in STRICT mode

what I meant is that i do not ignore the logo area in strict mode
in effect i do ignore the logo
:)


commercial_skip.updated.diff.bz2
Description: BZip2 compressed data
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-11 Thread Risto Treksler
Hi,

downloaded todays CVS and reflagged
it detected and flagged an obviously false commercial of just 8 frames long

white frames like those in explosions and in scene transitions in Cold Case 
also trigger false positives every time



2005-04-11 14:31:23.170 Final Commercial Break Map
2005-04-11 14:31:23.170 ---

2005-04-11 14:31:23.170 d : 7639 (00:04:00.04) (14)
2005-04-11 14:31:23.171 d : 7646 (00:05:00.04) (14)
2005-04-11 14:31:23.171 d : 102549 (00:04:00.56) (58)
2005-04-11 14:31:23.171 d : 107739 (00:05:00.59) (51)
2005-04-11 14:31:23.171 ---
2















On Sunday 03 April 2005 03:56 pm, Chris Pinkham wrote:
  I send this to you directly.  From the relevant portions I can see it
  did detect the 12 second and ~0 second break again.  If I read it right,
  that's at frame 18625 and then at 67576.  I am using the ALL detection
  method with strict detection enabled.
 
  2005-04-03 12:07:33.803   18625 : 4 (00:10:20.25) (620)
  2005-04-03 12:07:33.803   19014 : 5 (00:10:33.24) (633)
 
  2005-04-03 12:07:33.804   67576 : 4 (00:37:32.16) (2252)
  2005-04-03 12:07:33.804   67586 : 5 (00:37:32.26) (2252)

 Thanks for the debug info (although I'm not sure the whole list wanted
 to see the mythcommflag.out.bz2 file). :)  This should be fixed in
 current CVS, can you update and reflag this show to see if it does it
 correctly now?

 When going from a block that looks like a commercial to a block that
 doesn't, I had a bug that was checking the min commercial break length
 against the end of the new block instead of the start of the block.
 This same bug caused both of these scenarios.  The bug was allowing these
 short commercial breaks to be flagged when they shouldn't have been.

 If you don't want to update to current CVS, you can try the 1-line patch
 here:

 http://cvs.mythtv.org/cgi-bin/viewcvs.cgi/mythtv/libs/libmythtv/commercial_
skip.cpp?r1=1.45r2=1.46

-- 
Risto Treksler
Elkhorn Lodge
Banff, Alberta, Canada
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-11 Thread Chris Pinkham
 downloaded todays CVS and reflagged
 it detected and flagged an obviously false commercial of just 8 frames long
 
 white frames like those in explosions and in scene transitions in Cold Case 
 also trigger false positives every time

If you use the same instructions I gave the others earlier in this thread
and email me (privately) the debug output, it might help me find and fix this.

 2005-04-11 14:31:23.170 Final Commercial Break Map
 2005-04-11 14:31:23.170 ---
 
 2005-04-11 14:31:23.170 d : 7639 (00:04:00.04) (14)
 2005-04-11 14:31:23.171 d : 7646 (00:05:00.04) (14)
 2005-04-11 14:31:23.171 d : 102549 (00:04:00.56) (58)
 2005-04-11 14:31:23.171 d : 107739 (00:05:00.59) (51)
 2005-04-11 14:31:23.171 ---

On second thought, something looks plain weird about this output anyway.  The
output is all weird.  Have you done a make distclean lately?  If not, can
you do that then remake and rerun flagging and see if you get the same
results. 

-- 
Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


[PATCH] Re: [mythtv-users] How well does commercial detection work?

2005-04-11 Thread Risto Treksler
Hi,

I haven't figured out why the minimum length is still not being honoured 
and so I am going to privately send you the full debug output
from a couple of such shows

NOTE:
I think it's OK to have commercials shorter than 60sec 
right in the beginning of the show!! 
these are detected fine all the time and should continue to be detected as is

however there shouldn't be any really short commercial sections 
in the middle of the show, but it's flagging them nonetheless
- (using method all with strict checking enabled)


ALSO here's a patch that fixes a few things

1) I DO NOT ignore logos in blank frames in STRICT mode

- this alone has eliminated virtually all false positives
- it even works reasonably well with shows that leave the logo up
  i end up having to watch the first or the last commercial, 
  but that's ok b/c there are no false positives.
  (There has got to be a way to: ONLY ignore these logos
   if there are no completely blank frames at all in the show)

2) fix for the messed up data in my previous post 

- long long vs. long
- (long)it.key()  probably would have done it as well
- it didn't like %7lld either

3) fix for white frames triggering false positives

- NOT ONLY  (max - min) = blankFrameMaxDiff
- BUT ALSO max  some reasonable amount



On Monday 11 April 2005 04:07 pm, Chris Pinkham wrote:
  downloaded todays CVS and reflagged
  it detected and flagged an obviously false commercial of just 8 frames
  long
 
  white frames like those in explosions and in scene transitions in Cold
  Case also trigger false positives every time

 If you use the same instructions I gave the others earlier in this thread
 and email me (privately) the debug output, it might help me find and fix
 this.

  2005-04-11 14:31:23.170 Final Commercial Break Map
  2005-04-11 14:31:23.170
  ---
 
  2005-04-11 14:31:23.170 d : 7639 (00:04:00.04) (14)
  2005-04-11 14:31:23.171 d : 7646 (00:05:00.04) (14)
  2005-04-11 14:31:23.171 d : 102549 (00:04:00.56) (58)
  2005-04-11 14:31:23.171 d : 107739 (00:05:00.59) (51)
  2005-04-11 14:31:23.171
  ---

 On second thought, something looks plain weird about this output anyway. 
 The output is all weird.  Have you done a make distclean lately?  If not,
 can you do that then remake and rerun flagging and see if you get the same
 results.

-- 
Risto Treksler
Elkhorn Lodge
Banff, Alberta, Canada


commercial_skip.diff.gz
Description: GNU Zip compressed data
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-04 Thread Ramon Redondo
 I could also mention Jeopardy!.  Commercial detection is flawless for my
 recordings of Jeopardy!, with the one exception being that it misses
 the end of the commercial break before Final Jeopardy.  So my wife and
 I have to remember to NOT skip that break, or we end up at the end of
 the show.

Just a follow-up on commercial flagging on Jeopardy!

I think I've figured out why the show is consistently flagging well,
but consistently dropping the 'Final Jeopardy' portion of the show. 
It turns out, at least on my local channel, that all of the program
segments show the local station and/or network logo, EXCEPT for the
Final Jeopardy portion of the program.

I assume that in general if the 'All' method is used that it would not
fail to catch the new segment solely on the lack on logo, but I don't
know that for certain.  It may just be that the commercials are
'difficult' to catch on this program and that they can't be found
without the logo.

If this is interesting enough I can post a comm flag log somewhere to
be looked at.  If not, I won't worry about it for now.
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-03 Thread Kevin Kuphal
Chris Pinkham wrote:
I wonder if it would help to apply a narrow filter to get rid of high
frequency noise before testing whether a frame is blank?  This might
help for noisy signals without hurting things much for clean
signals...
 

I'd be interested in this.  In going through my programs last night, I 
found that all my non-CBS recordings were about as close to 100% as I 
   

The commercial flagger calls NuppelVideoPlayer::InitVideo which calls
NuppelVideoPlayer::InitFilters, so if you have any playback filters
enabled, I believe they are also used for commercial flagging.  You can
test by setting up a playback filter to see if it makes any difference,
if so, we could possibly make a different setting for flagging filters
so we could apply filters for flagging but not for playback (if the user
so desired).
 

can imagine.  The only one with issue was CBS and with strict detection 
turned on I believe it missed on break and had one short 12 second false 
positive and another 0 second false positive (makes me think we should 
have some kind of minimum bound on commercial length inclusive with 
strict detection to eliminate such short and obvious non-commercials). 
   

There already is a minimum length, if you are saw a 12-second or 0-second
false positive, there is a bug somewhere.  If you see something like
this again, can you re-run mythcommflag manually on that show with the
following command line (add in your own chanid/starttime of course) and
gzip and email me the output:
DEBUGCOMMFLAG=1 mythcommflag -v commflag --chanid CHANID --starttime STARTTIME  
mythcommflag.out 21
That will turn on a bunch of debug statements that I have in the code
and will print out information about every frame, as well as the blocks
that were defined/found and how the scores were adjusted for the blocks
based on the stats for the frames in each block.   This log may be huge,
so you probably need to gzip or even better bzip2 the file before emailing.
 

I send this to you directly.  From the relevant portions I can see it 
did detect the 12 second and ~0 second break again.  If I read it right, 
that's at frame 18625 and then at 67576.  I am using the ALL detection 
method with strict detection enabled.

2005-04-03 12:07:33.803 Final Commercial Break Map
2005-04-03 12:07:33.803 ---
2005-04-03 12:07:33.803   0 : 4 (00:00:00.00) (0)
2005-04-03 12:07:33.8031166 : 5 (00:00:38.26) (38)
2005-04-03 12:07:33.8036601 : 4 (00:03:40.01) (220)
2005-04-03 12:07:33.803   11894 : 5 (00:06:36.14) (396)
2005-04-03 12:07:33.803   18625 : 4 (00:10:20.25) (620)
2005-04-03 12:07:33.803   19014 : 5 (00:10:33.24) (633)
2005-04-03 12:07:33.803   28951 : 4 (00:16:05.01) (965)
2005-04-03 12:07:33.803   37411 : 5 (00:20:47.01) (1247)
2005-04-03 12:07:33.804   55782 : 4 (00:30:59.12) (1859)
2005-04-03 12:07:33.804   61748 : 5 (00:34:18.08) (2058)
2005-04-03 12:07:33.804   67576 : 4 (00:37:32.16) (2252)
2005-04-03 12:07:33.804   67586 : 5 (00:37:32.26) (2252)
2005-04-03 12:07:33.804   74797 : 4 (00:41:33.07) (2493)
2005-04-03 12:07:33.804   83172 : 5 (00:46:12.12) (2772)
2005-04-03 12:07:33.804  104496 : 4 (00:58:03.06) (3483)
2005-04-03 12:07:33.804  109512 : 5 (01:00:50.12) (3650)
2005-04-03 12:07:33.804 ---
Kevin
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-03 Thread Chris Pinkham
 I send this to you directly.  From the relevant portions I can see it 
 did detect the 12 second and ~0 second break again.  If I read it right, 
 that's at frame 18625 and then at 67576.  I am using the ALL detection 
 method with strict detection enabled.
 
 2005-04-03 12:07:33.803   18625 : 4 (00:10:20.25) (620)
 2005-04-03 12:07:33.803   19014 : 5 (00:10:33.24) (633)

 2005-04-03 12:07:33.804   67576 : 4 (00:37:32.16) (2252)
 2005-04-03 12:07:33.804   67586 : 5 (00:37:32.26) (2252)

Thanks for the debug info (although I'm not sure the whole list wanted
to see the mythcommflag.out.bz2 file). :)  This should be fixed in
current CVS, can you update and reflag this show to see if it does it
correctly now?

When going from a block that looks like a commercial to a block that
doesn't, I had a bug that was checking the min commercial break length
against the end of the new block instead of the start of the block.
This same bug caused both of these scenarios.  The bug was allowing these
short commercial breaks to be flagged when they shouldn't have been.

If you don't want to update to current CVS, you can try the 1-line patch
here:

http://cvs.mythtv.org/cgi-bin/viewcvs.cgi/mythtv/libs/libmythtv/commercial_skip.cpp?r1=1.45r2=1.46
-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-03 Thread Chris Pinkham
 Thanks for the debug info (although I'm not sure the whole list wanted
 to see the mythcommflag.out.bz2 file). :)  This should be fixed in
 current CVS, can you update and reflag this show to see if it does it
 correctly now?

 http://cvs.mythtv.org/cgi-bin/viewcvs.cgi/mythtv/libs/libmythtv/commercial_skip.cpp?r1=1.45r2=1.46

Kevin, sorry I typoed your name in the commit log. :(

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-03 Thread Kevin Kuphal
Chris Pinkham wrote:
Thanks for the debug info (although I'm not sure the whole list wanted
to see the mythcommflag.out.bz2 file). :)  This should be fixed in
current CVS, can you update and reflag this show to see if it does it
correctly now?
 

I checked out and reran mythcommflag and based on the debug output it 
did not detect those breaks this time.  Thanks for the quick fix.   My 
WAF just increased.  :)  I'll let this version run on next week's shows 
and if I encounter any missed breaks or false positives, I'll try 
adjusting the detection per your previous patch.

BTW, any insight on the narrow filter?  I looked through the filters 
listed on mythtv.org but didn't see one resembling that.

Thanks,
Kevin
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-03 Thread Chris Pinkham
 I checked out and reran mythcommflag and based on the debug output it 
 did not detect those breaks this time.  Thanks for the quick fix.   My 
 WAF just increased.  :)  I'll let this version run on next week's shows 

Great, glad it worked.  Not sure how I missed that initially.

 BTW, any insight on the narrow filter?  I looked through the filters 
 listed on mythtv.org but didn't see one resembling that.

Might work, haven't messed with filters much.  If anyone wants to point
me to some code or code it themeselves, we can try it.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-03 Thread Dan Christensen
Chris Pinkham [EMAIL PROTECTED] writes:

 BTW, any insight on the narrow filter?  I looked through the filters 
 listed on mythtv.org but didn't see one resembling that.

 Might work, haven't messed with filters much.  If anyone wants to point
 me to some code or code it themeselves, we can try it.

I'm *far* from an expert on this sort of thing, but all I was thinking
of was using the average of each 3x3 (or larger?) block of pixels when
computing the max and min brightness for the frame.  This is crude,
but I think just about any non-blank frame should have brightness
variations on a length scale longer than this.

Dan
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-02 Thread Kevin Kuphal
Dan Christensen wrote:
Kevin Kuphal [EMAIL PROTECTED] writes:
 

Chris Pinkham wrote:
   

I'd be interested to see what you find.  Are the channels you're talking
about fuzzy or what?
 

Yeah, they have a bit of a haze to them compared to my other channels.  
   

I wonder if it would help to apply a narrow filter to get rid of high
frequency noise before testing whether a frame is blank?  This might
help for noisy signals without hurting things much for clean
signals...
 

I'd be interested in this.  In going through my programs last night, I 
found that all my non-CBS recordings were about as close to 100% as I 
can imagine.  The only one with issue was CBS and with strict detection 
turned on I believe it missed on break and had one short 12 second false 
positive and another 0 second false positive (makes me think we should 
have some kind of minimum bound on commercial length inclusive with 
strict detection to eliminate such short and obvious non-commercials). 

Anyways, if you have an example of how to apply this filter to that 
channel, I'd appreciate it and would love to test it's results.

Kevin
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-02 Thread Chris Pinkham
 I wonder if it would help to apply a narrow filter to get rid of high
 frequency noise before testing whether a frame is blank?  This might
 help for noisy signals without hurting things much for clean
 signals...
   
 
 I'd be interested in this.  In going through my programs last night, I 
 found that all my non-CBS recordings were about as close to 100% as I 

The commercial flagger calls NuppelVideoPlayer::InitVideo which calls
NuppelVideoPlayer::InitFilters, so if you have any playback filters
enabled, I believe they are also used for commercial flagging.  You can
test by setting up a playback filter to see if it makes any difference,
if so, we could possibly make a different setting for flagging filters
so we could apply filters for flagging but not for playback (if the user
so desired).

 can imagine.  The only one with issue was CBS and with strict detection 
 turned on I believe it missed on break and had one short 12 second false 
 positive and another 0 second false positive (makes me think we should 
 have some kind of minimum bound on commercial length inclusive with 
 strict detection to eliminate such short and obvious non-commercials). 

There already is a minimum length, if you are saw a 12-second or 0-second
false positive, there is a bug somewhere.  If you see something like
this again, can you re-run mythcommflag manually on that show with the
following command line (add in your own chanid/starttime of course) and
gzip and email me the output:


DEBUGCOMMFLAG=1 mythcommflag -v commflag --chanid CHANID --starttime STARTTIME 
 mythcommflag.out 21

That will turn on a bunch of debug statements that I have in the code
and will print out information about every frame, as well as the blocks
that were defined/found and how the scores were adjusted for the blocks
based on the stats for the frames in each block.   This log may be huge,
so you probably need to gzip or even better bzip2 the file before emailing.

 Anyways, if you have an example of how to apply this filter to that 
 channel, I'd appreciate it and would love to test it's results.

Try setting a playback filter and see if that makes any difference.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-01 Thread Loren H. Burlingame
On Mar 27, 2005 12:46 PM, SpikeyGG [EMAIL PROTECTED] wrote:
  
 All, 
   
 I'm wondering how well everyone else's commercial detection is working? 
 From what I've seen it seems like it gives me the basic jist of where a
 commercial IS and I go in and set the breakpoints to where the commercial
 really starts and stops.  However, I noticed from a recent recording of
 American Idol the breaks get further and further apart as the program
 continues.  Here's what I've found: 
   

I have found that for whatever reason, network tv shows are the worst
for commercial flagging. MythTV does not seem to have a problem at all
with any of the Cable shows I record.

-- 
Loren H. Burlingame [EMAIL PROTECTED]
GPG Key ID: 0x112DCF4F
Irony can be pretty ironic sometimes.
   -William Shatner (a.k.a. Buck Murdock)
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-01 Thread Kevin Kuphal
Chris Pinkham wrote:
I agree, the strict option does help a lot. It's hard to be objective 
about it but it seems just about as good as it was when the ALL option 
was first introduced. I'm wondering if my picture is confusing it. My 
cable box produces light and dark lines that scroll up the picture 
constantly. Very subtle, but it might confuse the commercial scanner.

Curtis
   

Yes, wavy lines or static can play havoc with the detection.  If you
have a noisy signal, the blank frames won't seem blank since they
may have very dark pixels and a some very light pixels so the code
won't pick them up.  I tried to work around this one time by assuming
the frame was blank if only X% was light while the rest was dark,
but that caused false positives as well like for instance a nighttime
scene of people driving in a car where most of the frame is dark but
there are a few light spots.  It's definitely an art but getting
better over time I believe.
 

Is there a chance that those blank detection values for light and dark 
could be made to be read from the DB and controlled from setup?  I have 
a couple channels that suffer from slightly poorer signal than others 
and the strict detection only really fails me on those poor channels.  
I'd love to see if minor tweaks to the numbers made a difference here 
but I'm not 100% sure where in the code to change them and thought maybe 
that's a place where configuring them in setup would help people get 
better results (which large disclaimers about changing the defaults 
affecting commflag reliability)

Kevin
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-01 Thread Brad Templeton
On Fri, Apr 01, 2005 at 12:01:42AM -0500, Chris Pinkham wrote:
  I suspect a better behaviour when you hit End (Skip to next commercial mark)
  if there is no next mark (or the next mark is end of program) to not seek
  at all, giving a message like the not-flagged message.   The user can
  choose to quit watching or hit D at that point easily enough.
 
 It already does the first part, it did not allow skipping if you were at the 
 end
 and there were no more commercial flagging marks after your current position.
 
 I just committed a patch to CVS to disable skipping when the last commercial
 flagging marker is less than 10 seconds from the end of the recording.  It
 will instead display the At End, can not Skip message that it normally
 does when you are at the end of the recording and there are no more commercial
 flagging marks after your current position.
 
Thanks, that sounds good, worth doing a checkout for. (I've not been
checking out the last couple of weeks for fear of the giant flood of
patches that got applied, I think it's now pretty stable.)

I did like the other suggestion we saw here, that the OSD's display-bar
be coloured or marked with the cutlist and/or commercial skip list, as
well as of course the cursor and the not-yet-recorded segment.   Flashing
that up with the OSD on every commercial skip and other move would give
a much greater sense of the commercial layout and provide a much more
robust system.   Misreads by the commercial skip heuristics would become
obvous and less troublesome.Of course, this is a different piece of
code, not nearly so simple a change as those above.
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-01 Thread Chris Pinkham
 Is there a chance that those blank detection values for light and dark 
 could be made to be read from the DB and controlled from setup?  I have 
 a couple channels that suffer from slightly poorer signal than others 
 and the strict detection only really fails me on those poor channels.  
 I'd love to see if minor tweaks to the numbers made a difference here 
 but I'm not 100% sure where in the code to change them and thought maybe 
 that's a place where configuring them in setup would help people get 
 better results (which large disclaimers about changing the defaults 
 affecting commflag reliability)

How about an undocumented setting? :)  For now, I'd rather not start
making settings like this available on the setup screens because it is
so easy to really screw things up by changing one or two values, so I
made a new CommBlankFrameMaxDiff setting value that will be used for
the blank-frame detection.  Previously this was hardcoded in the blank-
frame detection routine.  Both the strict and non-strict blank-frame
code use this value.  If the difference between the max Y (as in YUV)
value in a frame and the min Y value in the frame is less than this
CommBlankFrameMaxDiff value (which defaults to 25), then the frame
is assumed blank.  The non-strict code also checks a few other things
like the average brightness, maximum Y value less than a certain
threshold, etc..

This is also a CommBorder setting value that determines the border
width of the frame to ignore when checking for blank, scene-changes,
etc..  The default CommBorder value is 20.

If you want to make the strict mode a little less strict, try
creating a setting in the settings table like this:

insert settings ( value, data ) values ( CommBlankFrameMaxDiff, 30 );

then rerun flagging for a show.

I think I found that 35 was really bad on some fo my test cases because
it caused too many false positives (ie, thought the frame was blank
when it wasn't), so your best bet may be trying numbers less than 35,
but you can give it a shot and see.  If we find that 25 is a bit too
tight, the default could be bumped up, although it probably varies
per card especially when using software encoding since that has both
the analog - digital conversion and gives the user the ability to
change the levels on this conversion.

I'd be interested to see what you find.  Are the channels you're talking
about fuzzy or what?
-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-04-01 Thread Chris Pinkham
  I just committed a patch to CVS to disable skipping when the last commercial
  flagging marker is less than 10 seconds from the end of the recording.  It
  will instead display the At End, can not Skip message that it normally
  does when you are at the end of the recording and there are no more 
  commercial
  flagging marks after your current position.
  
 Thanks, that sounds good, worth doing a checkout for. (I've not been
 checking out the last couple of weeks for fear of the giant flood of
 patches that got applied, I think it's now pretty stable.)

Yeah, I told my wife about it tonight and it really helped the WFA go up some. 
:)

 I did like the other suggestion we saw here, that the OSD's display-bar
 be coloured or marked with the cutlist and/or commercial skip list, as
 well as of course the cursor and the not-yet-recorded segment.   Flashing
 that up with the OSD on every commercial skip and other move would give

I saved a couple posts that were talking about this and may look into it
sometime if no-one else does.  Might be something that might work better
with the UI interface changes that are being talked about.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-31 Thread Risto Treksler

  Also, like mentioned above, some shows will put a 5 second teaser
  before or after a commercial break.  I know that Food Network does
  this alot and myth will detect it as part of the commericial only
  about 5% of the time. HTH.

i always saw this as a feature, that these spots aren't skipped

besides trying to detect spots that short will probably result in a lot of 
false positives, which is much much worse
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-31 Thread John Patrick Poet

On Wed, 30 Mar 2005, Chris Pinkham wrote:

   With the new ALL method, the Strict Commercial Detection setting wasn't
   being used, so I just committed a change to CVS to use it in the 
   blank-frame
   detection code to allow reverting to the stricter black-frame detection 
   that was

  Now that I have my system working again, I gave this a try.  My impression
  is positive.  I believe that this has helped quite a bit.
 
  I need to go back and re-flag the shows with Strict Commercial Detection
  turned OFF to make a proper comparison.  I will let you know after I have
  the time to do that.

 Thanks.  The strict code is too strict for some people, possibly because of
 noisy TV signals or the fact that different analog capture cards will not
 have the same exact output when converted to digital.  I turned Strict on
 myself as I think the original code worked better for me on a lot of shows
 as well so I'll see if it helps in my case also.


The strict code definitely works better for me.  Not 100% perfect, but I
doubt it can ever be 100%.

When it does make a mistake, it is the right kind.  In other words it
shows a commercial, rather than skipping part of the show.  After checking a
dozen shows, it only wanted to skip a small part of the show twice.

Great work.  Thank you.

John
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-31 Thread Curtis Stanford
On Mar 31, 2005, at 3:03 PM, John Patrick Poet wrote:
On Wed, 30 Mar 2005, Chris Pinkham wrote:
With the new ALL method, the Strict Commercial Detection setting 
wasn't
being used, so I just committed a change to CVS to use it in the 
blank-frame
detection code to allow reverting to the stricter black-frame 
detection that was
Thanks.  The strict code is too strict for some people, possibly 
because of
noisy TV signals or the fact that different analog capture cards will 
not
have the same exact output when converted to digital.  I turned 
Strict on
myself as I think the original code worked better for me on a lot of 
shows
as well so I'll see if it helps in my case also.

The strict code definitely works better for me.  Not 100% perfect, 
but I
doubt it can ever be 100%.

When it does make a mistake, it is the right kind.  In other words it
shows a commercial, rather than skipping part of the show.  After 
checking a
dozen shows, it only wanted to skip a small part of the show twice.

Great work.  Thank you.
I agree, the strict option does help a lot. It's hard to be objective 
about it but it seems just about as good as it was when the ALL option 
was first introduced. I'm wondering if my picture is confusing it. My 
cable box produces light and dark lines that scroll up the picture 
constantly. Very subtle, but it might confuse the commercial scanner.

Curtis
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-31 Thread Chris Pinkham
 I agree, the strict option does help a lot. It's hard to be objective 
 about it but it seems just about as good as it was when the ALL option 
 was first introduced. I'm wondering if my picture is confusing it. My 
 cable box produces light and dark lines that scroll up the picture 
 constantly. Very subtle, but it might confuse the commercial scanner.
 
 Curtis

Yes, wavy lines or static can play havoc with the detection.  If you
have a noisy signal, the blank frames won't seem blank since they
may have very dark pixels and a some very light pixels so the code
won't pick them up.  I tried to work around this one time by assuming
the frame was blank if only X% was light while the rest was dark,
but that caused false positives as well like for instance a nighttime
scene of people driving in a car where most of the frame is dark but
there are a few light spots.  It's definitely an art but getting
better over time I believe.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-31 Thread Chris Pinkham
 It's also a little annoying when the commercials are incorrectly marked
 and pressing forward skips some random large value, there is no easy way
 to go back because where you jumped from wasn't a marked point. So you
 have to just manually skip back to the correct place
 
 Would it be possible to remember a temporary last jumped from position
 so rewinding would jump back there?

See, this is one of those times when the situation described was itching
the developer bad enough that he decided to go ahead and scratch it.

I just added this ability to CVS.  Description is in the commit log:

http://www.mythtv.org/pipermail/mythtv-commits/2005-April/005558.html

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-31 Thread Curtis Stanford
On Mar 31, 2005, at 7:57 PM, Chris Pinkham wrote:
I agree, the strict option does help a lot. It's hard to be objective
about it but it seems just about as good as it was when the ALL option
was first introduced. I'm wondering if my picture is confusing it. My
cable box produces light and dark lines that scroll up the picture
constantly. Very subtle, but it might confuse the commercial scanner.
Curtis
Yes, wavy lines or static can play havoc with the detection.  If you
have a noisy signal, the blank frames won't seem blank since they
may have very dark pixels and a some very light pixels so the code
won't pick them up.  I tried to work around this one time by assuming
the frame was blank if only X% was light while the rest was dark,
but that caused false positives as well like for instance a nighttime
scene of people driving in a car where most of the frame is dark but
there are a few light spots.  It's definitely an art but getting
better over time I believe.
Yes, it absolutely is getting better. It's a very hard problem and 
you've done a great job getting it working as well as it is, even with 
the wavy lines... :-)

Curtis
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-31 Thread Chris Pinkham
 On Mon, Mar 28, 2005 at 08:54:19AM -0600, Ramon Redondo wrote:
  Since we're talking about consistent commercial detection problems, I
  could also mention Jeopardy!.  Commercial detection is flawless for my
  recordings of Jeopardy!, with the one exception being that it misses
  the end of the commercial break before Final Jeopardy.  So my wife and
  I have to remember to NOT skip that break, or we end up at the end of
  the show.
 
 Of course this is very frustrating, as you have to say don't delete
 then re-watch, then seek to the place you were and find the real
 programming at the end.
 
 I suspect a better behaviour when you hit End (Skip to next commercial mark)
 if there is no next mark (or the next mark is end of program) to not seek
 at all, giving a message like the not-flagged message.   The user can
 choose to quit watching or hit D at that point easily enough.

It already does the first part, it did not allow skipping if you were at the end
and there were no more commercial flagging marks after your current position.

I just committed a patch to CVS to disable skipping when the last commercial
flagging marker is less than 10 seconds from the end of the recording.  It
will instead display the At End, can not Skip message that it normally
does when you are at the end of the recording and there are no more commercial
flagging marks after your current position.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-31 Thread Ian Campbell
On Thu, 2005-03-31 at 23:25 -0500, Chris Pinkham wrote:
  It's also a little annoying when the commercials are incorrectly marked
  and pressing forward skips some random large value, there is no easy way
  to go back because where you jumped from wasn't a marked point. So you
  have to just manually skip back to the correct place
  
  Would it be possible to remember a temporary last jumped from position
  so rewinding would jump back there?
 
 See, this is one of those times when the situation described was itching
 the developer bad enough that he decided to go ahead and scratch it.
 
 I just added this ability to CVS.  Description is in the commit log:
 
 http://www.mythtv.org/pipermail/mythtv-commits/2005-April/005558.html

Looks cool, thank you very much!

Ian.
-- 
Ian Campbell

It's not easy, being green.
-- Kermit the Frog


signature.asc
Description: This is a digitally signed message part
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-30 Thread John Patrick Poet

On Sun, 27 Mar 2005, Chris Pinkham wrote:

  Within the first week that you introduced the ALL method, detection was
  simply amazing.  I have never seen it work so well.
 
  Then I saw a message from you saying that you had to loosen up the
  concept of black.  After that, detection really took a hit.  Ever
  since then it is not that much better than it was before you add the ALL
  method.

 Thanks, this is helpful, thanks.

 With the new ALL method, the Strict Commercial Detection setting wasn't
 being used, so I just committed a change to CVS to use it in the blank-frame
 detection code to allow reverting to the stricter black-frame detection that 
 was
 put into CVS when I first added the ALL method.  If you are using ALL and 
 you
 don't have Strict Commercial Detection turned ON, can you try turning that 
 ON
 and seeing if it helps detection for you?



Now that I have my system working again, I gave this a try.  My impression
is positive.  I believe that this has helped quite a bit.

I need to go back and re-flag the shows with Strict Commercial Detection
turned OFF to make a proper comparison.  I will let you know after I have
the time to do that.

Thank you very much!

John

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-30 Thread Chris Pinkham
  With the new ALL method, the Strict Commercial Detection setting wasn't
  being used, so I just committed a change to CVS to use it in the blank-frame
  detection code to allow reverting to the stricter black-frame detection 
  that was

 Now that I have my system working again, I gave this a try.  My impression
 is positive.  I believe that this has helped quite a bit.
 
 I need to go back and re-flag the shows with Strict Commercial Detection
 turned OFF to make a proper comparison.  I will let you know after I have
 the time to do that.

Thanks.  The strict code is too strict for some people, possibly because of
noisy TV signals or the fact that different analog capture cards will not
have the same exact output when converted to digital.  I turned Strict on
myself as I think the original code worked better for me on a lot of shows
as well so I'll see if it helps in my case also.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-30 Thread Scot L. Harris
On Wed, 2005-03-30 at 11:40, John Patrick Poet wrote:

 
 Now that I have my system working again, I gave this a try.  My impression
 is positive.  I believe that this has helped quite a bit.
 
 I need to go back and re-flag the shows with Strict Commercial Detection
 turned OFF to make a proper comparison.  I will let you know after I have
 the time to do that.
 
 Thank you very much!
 
 John
 

I have found that commercial detection works well for most shows. One
show that appears to have serious problems however is Blind Justice. 
Might make a good test show to record and flag.

-- 
Scot L. Harris
[EMAIL PROTECTED]

The knowledge that makes us cherish innocence makes innocence unattainable.
-- Irving Howe 

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-30 Thread Chris Pinkham
 I have found that commercial detection works well for most shows. One
 show that appears to have serious problems however is Blind Justice. 
 Might make a good test show to record and flag.

I'm already recording that, so I'll make a note to see how well detection
is working on there.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-30 Thread Tom E. Craddock Jr.
Scot L. Harris wrote:
I have found that commercial detection works well for most shows. One
show that appears to have serious problems however is Blind Justice. 
You mean besides the acting, writing, overall plot, camera work and just 
over all being a bad show?

Tom
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-30 Thread Michael J. Lynch
Tom E. Craddock Jr. wrote:
Scot L. Harris wrote:
I have found that commercial detection works well for most shows. One
show that appears to have serious problems however is Blind Justice. 

You mean besides the acting, writing, overall plot, camera work and 
just over all being a bad show?

Tom
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users
:-D :-D :-D :-D
--
Michael J. Lynch
What if the hokey pokey IS what it's all about -- author unknown

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-30 Thread Scot L. Harris
On Wed, 2005-03-30 at 14:30, Tom E. Craddock Jr. wrote:
 Scot L. Harris wrote:
  I have found that commercial detection works well for most shows. One
  show that appears to have serious problems however is Blind Justice. 
 
 You mean besides the acting, writing, overall plot, camera work and just 
 over all being a bad show?

Ah! Did not realize that the commercial skipping also checked for those
items.  :D

I have new found appreciation for mythtv, if it is able to cutout the
really bad shows and save us from ourselves.  :) :)

But if that was working that way I would only need about 4GB of disk
space a month for the good shows.  :)

-- 
Scot L. Harris
[EMAIL PROTECTED]

Traceroute says that there is a routing problem in the backbone.  It's not our 
problem. 

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-30 Thread Blammo
On Tue, 29 Mar 2005 14:57:52 -0500 (EST), Chris Pinkham
[EMAIL PROTECTED] wrote:
 Can you let me know sometime if the Strict/Aggressive changes I made
 the other day to CVS have made an impact for you?

24 was on to the millisecond, first time since 0.16 and non-HD content
that's happened. Well done.. /clap clap

we'll see how the rest of the week comes out. I'm going to go back and
reflag everything in my playlist. :)
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-29 Thread Ian Campbell
On Mon, 2005-03-28 at 10:34 -0800, Brad Templeton wrote:
 I suspect a better behaviour when you hit End (Skip to next commercial mark)
 if there is no next mark (or the next mark is end of program) to not seek
 at all, giving a message like the not-flagged message.   The user can
 choose to quit watching or hit D at that point easily enough.

It's also a little annoying when the commercials are incorrectly marked
and pressing forward skips some random large value, there is no easy way
to go back because where you jumped from wasn't a marked point. So you
have to just manually skip back to the correct place

Would it be possible to remember a temporary last jumped from position
so rewinding would jump back there?

Or perhaps the interface could refuse to skip breaks longer than X mins?
Commercials here are rarely as long as 5 minutes for example. Or put up
a prompt Commercial break is Y (longer than X) mins and have you press
fwd again to really skip that far.

Ian.

-- 
Ian Campbell

Whoa...I did a 'zcat /vmlinuz  /dev/audio' and I think I heard God...
-- mikecd on #Linux


signature.asc
Description: This is a digitally signed message part
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-29 Thread Ajay Sharma
Dan Wilga wrote:
 At 11:27 PM -0800 3/27/05, Ajay Sharma wrote:
 
 Daily Show:  Sometimes when they jump to a news clip they flash the
 screen white for a second that that is picked up as a start of a
 commercial.
 
 
 Interesting. The only problem I have with Daily Show is that the last
 commercial break (right before the Moment of Zen) is incorrectly
 detected as going past the MOZ, all the way to the end of the recording.
 I have to remember not to hit Skip when I get to this point in the show,
 or I end up at the You've finished watching prompt.
 
 Perhaps the one difference between you and me is the source: I watch
 Comedy Central on Dish Network.

I'm watching it through Adelphia Cable.

--Ajay
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-29 Thread Brad Templeton
On Tue, Mar 29, 2005 at 12:13:44PM -0500, James Armstrong wrote:
 
 
 Ian Campbell wrote:
 On Mon, 2005-03-28 at 10:34 -0800, Brad Templeton wrote:
 
 I suspect a better behaviour when you hit End (Skip to next commercial 
 mark)
 if there is no next mark (or the next mark is end of program) to not seek
 at all, giving a message like the not-flagged message.   The user can
 choose to quit watching or hit D at that point easily enough.
 
 
 It's also a little annoying when the commercials are incorrectly marked
 and pressing forward skips some random large value, there is no easy way
 to go back because where you jumped from wasn't a marked point. So you
 have to just manually skip back to the correct place
 
 Would it be possible to remember a temporary last jumped from position
 so rewinding would jump back there?
 
 Or perhaps the interface could refuse to skip breaks longer than X mins?
 Commercials here are rarely as long as 5 minutes for example. Or put up
 a prompt Commercial break is Y (longer than X) mins and have you press
 fwd again to really skip that far.
 
 Ian.
 
 
 One thing that might make a usefull feature is to show the commercial 
 detection marks on the progress bar on the osd when watching previously 
 recorded shows. If it looked just like it does when the commercial list 
 is loaded in the cutlist editor you would get a visual feedback and can 
 usually tell which commercials are bad based on the position and size.
 

That is a very good idea, though probably a lot more coding than simple mods
to the action of a keystroke.   The long-gap problem is harder because
the skip, as you may know, skips to the next mark, be it Start or End
of commercial break.  Though it does know the difference so could act
differentely in these cases.

One could also display the cutlist in the seek bar, in a similar manner
to the way it is displayed when in edit mode.

But in general, the right thing is to expect the detection algorithms will
fail sometimes, and to design the UI to anticipate the occasional failure
and handle it with grace.

I could probably code up the 'don't terminate by pressing End' feature
but don't have time for the more complex one.
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-29 Thread Chris Pinkham
 On Mar 27, 2005, at 6:40 PM, John Patrick Poet wrote:
  Chris Pinkham wrote:
 
  I've been using the All option since it was introduced and, I have 
  to agree that it was MUCH better then than it is now. Must be 
  sensitive to the type of signal or something.

  When is then?

 Yes, by then, I meant when ALL was first introduced.

Can you let me know sometime if the Strict/Aggressive changes I made
the other day to CVS have made an impact for you?

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-29 Thread Curtis Stanford
On Mar 29, 2005, at 12:57 PM, Chris Pinkham wrote:
On Mar 27, 2005, at 6:40 PM, John Patrick Poet wrote:
Chris Pinkham wrote:
I've been using the All option since it was introduced and, I have
to agree that it was MUCH better then than it is now. Must be
sensitive to the type of signal or something.

When is then?

Yes, by then, I meant when ALL was first introduced.
Can you let me know sometime if the Strict/Aggressive changes I made
the other day to CVS have made an impact for you?
Yes, I've set the strict option on and I'll let you know how it goes. 
Thanks.

Curtis
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-29 Thread Chris Pinkham
 Of course this is very frustrating, as you have to say don't delete
 then re-watch, then seek to the place you were and find the real
 programming at the end.
 
 I suspect a better behaviour when you hit End (Skip to next commercial mark)
 if there is no next mark (or the next mark is end of program) to not seek
 at all, giving a message like the not-flagged message.   The user can
 choose to quit watching or hit D at that point easily enough.

There are 2 things related to this that have been on my TODO list for a while
but I haven't got around to them yet.

The first is something like you describe above, ie, don't Skip if the place
we would skip to is within about 5 seconds of the end of the program.  Instead
just popup a message saying we didn't skip and why.

The second is the ability to remember where we skipped from, so you could
hit 'Q' immediately after hitting 'Z' and 'Q' would take you back to the point
you skipped from.  This would be effective for maybe 2-3 seconds and the
remembered position would be reset once you hit 'Q' the first time, so you
could hit 'Q' another time and skip further back in the recording.  The same
would hold true for the reverse, hitting 'Z' immediately after an initial 'Q'
would take you back to where you started at.

If anyone wants to tackle these two, feel free.  They are annoying but haven't
bugged me enough yet to push them to the top of my TODO list, there's still
a few items above them.  They are fairly easy to implement though.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-29 Thread Chris Pinkham
 Chris (and other developers working on mythcommflag),

 I just wanted to let you know that one network I seem to have more
 problems on than others is VH1.  I find that on quite a few of their

Thanks, I'll see if there is something I can record off there to test
with.

 Also, like mentioned above, some shows will put a 5 second teaser
 before or after a commercial break.  I know that Food Network does
 this alot and myth will detect it as part of the commericial only
 about 5% of the time. HTH.

Yeah, the 5-second spots don't have enough things to trigger the score
code to think they are commercials right now.  There are probably ways
I can tweak this though.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-28 Thread Dan Wilga
At 11:27 PM -0800 3/27/05, Ajay Sharma wrote:
Daily Show:  Sometimes when they jump to a news clip they flash the
screen white for a second that that is picked up as a start of a commercial.
Interesting. The only problem I have with Daily Show is that the last 
commercial break (right before the Moment of Zen) is incorrectly 
detected as going past the MOZ, all the way to the end of the 
recording. I have to remember not to hit Skip when I get to this 
point in the show, or I end up at the You've finished watching 
prompt.

Perhaps the one difference between you and me is the source: I watch 
Comedy Central on Dish Network.
--
Dan Wilga [EMAIL PROTECTED]
Web Administrator http://www.mtholyoke.edu
Mount Holyoke CollegeTel: 413-538-3027
South Hadley, MA  01075Who left the cake out in the rain?
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-28 Thread Ramon Redondo
Since we're talking about consistent commercial detection problems, I
could also mention Jeopardy!.  Commercial detection is flawless for my
recordings of Jeopardy!, with the one exception being that it misses
the end of the commercial break before Final Jeopardy.  So my wife and
I have to remember to NOT skip that break, or we end up at the end of
the show.

But I also have to add that in my personal use, the 'All' method has
been working very well in general.
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-28 Thread Curtis Stanford
On Mar 27, 2005, at 6:40 PM, John Patrick Poet wrote:
Chris Pinkham wrote:
I've been using the All option since it was introduced and, I have 
to agree that it was MUCH better then than it is now. Must be 
sensitive to the type of signal or something.

When is then?
I am not sure who you are quoting in this message, but I will chime in.
Within the first week that you introduced the ALL method, detection 
was simply amazing.  I have never seen it work so well.

Then I saw a message from you saying that you had to loosen up the 
concept of black.  After that, detection really took a hit.  Ever 
since then it is not that much better than it was before you add the 
ALL method.

I almost exclusively record HD material on my HD-3000 cards.  I watch 
*very* few non-HD shows.


Yes, by then, I meant when ALL was first introduced.
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-28 Thread Craig Partin
On Mon, 28 Mar 2005 08:17:57 -0700, Curtis Stanford
[EMAIL PROTECTED] wrote:
 
 On Mar 27, 2005, at 6:40 PM, John Patrick Poet wrote:
 
  Chris Pinkham wrote:
 
  I've been using the All option since it was introduced and, I have
  to agree that it was MUCH better then than it is now. Must be
  sensitive to the type of signal or something.
 
 
  When is then?
 
 
  I am not sure who you are quoting in this message, but I will chime in.
 
  Within the first week that you introduced the ALL method, detection
  was simply amazing.  I have never seen it work so well.
 
  Then I saw a message from you saying that you had to loosen up the
  concept of black.  After that, detection really took a hit.  Ever
  since then it is not that much better than it was before you add the
  ALL method.
 
  I almost exclusively record HD material on my HD-3000 cards.  I watch
  *very* few non-HD shows.
 
 
 Yes, by then, I meant when ALL was first introduced.
 
 
 ___
 mythtv-users mailing list
 mythtv-users@mythtv.org
 http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users
 
 
 

Another Daily Show note.  It consistently marks the Lewis Black
segment as a commercial .  I suspect this is due to the segment's
having a start logo that looks much different from the rest of the
program.  Otherwise 'ALL' with 0.17 is damn near perfect and one of my
favorite features.  Thank You!
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-28 Thread Brad Templeton
On Mon, Mar 28, 2005 at 08:54:19AM -0600, Ramon Redondo wrote:
 Since we're talking about consistent commercial detection problems, I
 could also mention Jeopardy!.  Commercial detection is flawless for my
 recordings of Jeopardy!, with the one exception being that it misses
 the end of the commercial break before Final Jeopardy.  So my wife and
 I have to remember to NOT skip that break, or we end up at the end of
 the show.

Of course this is very frustrating, as you have to say don't delete
then re-watch, then seek to the place you were and find the real
programming at the end.

I suspect a better behaviour when you hit End (Skip to next commercial mark)
if there is no next mark (or the next mark is end of program) to not seek
at all, giving a message like the not-flagged message.   The user can
choose to quit watching or hit D at that point easily enough.
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-28 Thread Matt
Chris (and other developers working on mythcommflag),

  I know that you're aware of a few instances where certain shows can
play some havoc with the flagging of commericals... Lost is my
favorite show right now and it's never correct, glad to see you are
testing with it.  I will let you know it's getting better than it
was since the begining of the season.

I just wanted to let you know that one network I seem to have more
problems on than others is VH1.  I find that on quite a few of their
shows, they'll seem to almost edit the commercials into the show in
such a way that it can fool mythcommflag.  Someshows will be 100% some
shows will be less than 50%.  Just another option for you to test. 
Also, like mentioned above, some shows will put a 5 second teaser
before or after a commercial break.  I know that Food Network does
this alot and myth will detect it as part of the commericial only
about 5% of the time. HTH.

Thanks!
Matt


On Sun, 27 Mar 2005 20:20:39 -0500 (EST), Chris Pinkham
[EMAIL PROTECTED] wrote:
  Well, this is still pre 1.0 software.  I dont think flawless is going to
  happen any time soon.  Pretty damn well? Yup, Ive got that.  Only a
  couple HD shows get screwy, Alias and Lost off the top of my head.  SD
 
 Well, I record Lost regularly and just started recording Alias a week or two
 ago in order to test with that also, so hopefully I'll be able to figure out
 what's going on with these.  Don't expect anything before 0.18 though,
 because I don't want to make any detection changes that could make detection
 worse for other cases.
 
  shows are spot on except for maybe a sec or two.  I have to say tho,
  about 90-95% of the time, commflagg works fine for me using the Blank
  Frame Detection.
 
 For a lot of shows, blank frame works great, probably even 100% for some
 shows.  It has been shown to have a hard time with dark shows including
 the Law  Order type series.  I personally use the All method and have
 AutoSkip Off.
 
 --
 
 Chris
 
 
 ___
 mythtv-users mailing list
 mythtv-users@mythtv.org
 http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users
 
 

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


[mythtv-users] How well does commercial detection work?

2005-03-27 Thread SpikeyGG



All,

I'm wondering how well everyone else's commercial 
detection is working? From what I've seen it seems like it gives me the 
basic jist of where a commercialIS and I go in and set the breakpoints to 
wherethe commercialreally starts and stops. However, I noticed 
from a recent recording of American Idol the breaks get further and further 
apart as the program continues. Here's what I've found:

Using default, blank frame detection.

1st commercial break
Enter off by 25.13 seconds
Exit off by 19.17 seconds
2nd commercial break
Enter off by 28.62 seconds
Exit off by 34.68 seconds
3rd commercial break
Enter off by 49.70 seconds
Exit off by 49.28 seconds
4th commercial break
Enter off by 58.18 seconds
Exit off by 91.65 seconds
5th commercial break
Enter off by 81.06 seconds
Exit off by 78.30 seconds

Does anyone have the commercial detection working 
flawlessly (or is that not possible)?

Thanks,
-Greg
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Jarod Wilson
On Sunday 27 March 2005 10:46, SpikeyGG wrote:
 Does anyone have the commercial detection working flawlessly (or is that
 not possible)?

Since the 0.17 release, commercial detection has been damned near flawless for 
me. I'm using more than just the default though. Can't remember the exact 
setting, but basically just turned on everything.

-- 
Jarod Wilson
[EMAIL PROTECTED]

Got a question? Read this first...
 http://catb.org/~esr/faqs/smart-questions.html
MythTV, Fedora Core  ATrpms documentation:
 http://wilsonet.com/mythtv/
MythTV Searchable Mailing List Archive
 http://www.gossamer-threads.com/lists/mythtv/


pgpVERCApQVU4.pgp
Description: PGP signature
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Tom E. Craddock Jr.
SpikeyGG wrote:
All,
 
I'm wondering how well everyone else's commercial detection is working?  
From what I've seen it seems like it gives me the basic jist of where a 
commercial IS and I go in and set the breakpoints to where the 
commercial really starts and stops.  However, I noticed from a recent 
recording of American Idol the breaks get further and further apart as 
the program continues.  Here's what I've found:
Using default, blank frame detection.
Does anyone have the commercial detection working flawlessly (or is that 
not possible)?
 
Thanks,
-Greg



Well, this is still pre 1.0 software.  I dont think flawless is going to 
happen any time soon.  Pretty damn well? Yup, Ive got that.  Only a 
couple HD shows get screwy, Alias and Lost off the top of my head.  SD 
shows are spot on except for maybe a sec or two.  I have to say tho, 
about 90-95% of the time, commflagg works fine for me using the Blank 
Frame Detection.

Tom
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Scot L. Harris
On Sun, 2005-03-27 at 14:04, Tom E. Craddock Jr. wrote:
 SpikeyGG wrote:
  All,
   
  I'm wondering how well everyone else's commercial detection is working?  
  From what I've seen it seems like it gives me the basic jist of where a 
  commercial IS and I go in and set the breakpoints to where the 
  commercial really starts and stops.  However, I noticed from a recent 
  recording of American Idol the breaks get further and further apart as 
  the program continues.  Here's what I've found:
  Using default, blank frame detection.
  Does anyone have the commercial detection working flawlessly (or is that 
  not possible)?
   
  Thanks,
  -Greg
  
  
 
 
 Well, this is still pre 1.0 software.  I dont think flawless is going to 
 happen any time soon.  Pretty damn well? Yup, Ive got that.  Only a 
 couple HD shows get screwy, Alias and Lost off the top of my head.  SD 
 shows are spot on except for maybe a sec or two.  I have to say tho, 
 about 90-95% of the time, commflagg works fine for me using the Blank 
 Frame Detection.

I have it set to use all detection modes.  I can not say it is 100% but
it is very very close.  With only a few exceptions about the only
commercials it seems to miss consistently are those sponsor bits usually
at the end of a show that appear to be part of the actual show just
before it rolls into the real commercials.  

All in all I have been very pleased with the picture quality and
especially the commercial skipping feature.  

 
-- 
Scot L. Harris
[EMAIL PROTECTED]

No guts, no glory. 

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Alex Cruz
On Sunday 27 March 2005 12:46 pm, SpikeyGG wrote:
 Does anyone have the commercial detection working flawlessly (or is that
 not possible)?

 Thanks,
 -Greg


 I'm using all modes of detction and I can say that it's pretty darn close to 
perfect especially when using the auto skip commercial option. Like someone 
else mentioned, those commercials that are inserted into the closing credits 
(usually for the station like what Sci-Fi does) aren't detected. But by that 
point, I'm already exiting from viewing the recording. As the saying goes, 
Your mileage may vary but, it sure beats the hell out of a VCR  :-)

-alex
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Curtis Stanford
On Mar 27, 2005, at 3:04 PM, Alex Cruz wrote:
On Sunday 27 March 2005 12:46 pm, SpikeyGG wrote:
Does anyone have the commercial detection working flawlessly (or is 
that
not possible)?

Thanks,
-Greg

 I'm using all modes of detction and I can say that it's pretty darn 
close to
perfect especially when using the auto skip commercial option. Like 
someone
else mentioned, those commercials that are inserted into the closing 
credits
(usually for the station like what Sci-Fi does) aren't detected. But 
by that
point, I'm already exiting from viewing the recording. As the saying 
goes,
Your mileage may vary but, it sure beats the hell out of a VCR  :-)


I've been using the All option since it was introduced and, I have to 
agree that it was MUCH better then than it is now. Must be sensitive to 
the type of signal or something.

Curtis
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Chris Pinkham
 Using default, blank frame detection.

You're probably better off using the new All method.

 1st commercial break
  Enter off by 25.13 seconds
  Exit off by 19.17 seconds
 2nd commercial break
  Enter off by 28.62 seconds
  Exit off by 34.68 seconds
 3rd commercial break
  Enter off by 49.70 seconds
  Exit off by 49.28 seconds

What kind of TV cards are you using?  It sounds like this
could be related to the fact that some recordings have show
that is recorded at one FPS while the commercials are at another
FPS.  This would account for the commercial markers being off
more and more as you get further into the recording.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Chris Pinkham
 Well, this is still pre 1.0 software.  I dont think flawless is going to 
 happen any time soon.  Pretty damn well? Yup, Ive got that.  Only a 
 couple HD shows get screwy, Alias and Lost off the top of my head.  SD 

Well, I record Lost regularly and just started recording Alias a week or two
ago in order to test with that also, so hopefully I'll be able to figure out
what's going on with these.  Don't expect anything before 0.18 though,
because I don't want to make any detection changes that could make detection
worse for other cases.

 shows are spot on except for maybe a sec or two.  I have to say tho, 
 about 90-95% of the time, commflagg works fine for me using the Blank 
 Frame Detection.

For a lot of shows, blank frame works great, probably even 100% for some
shows.  It has been shown to have a hard time with dark shows including
the Law  Order type series.  I personally use the All method and have
AutoSkip Off.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Chris Pinkham
 I have it set to use all detection modes.  I can not say it is 100% but
 it is very very close.  With only a few exceptions about the only
 commercials it seems to miss consistently are those sponsor bits usually
 at the end of a show that appear to be part of the actual show just
 before it rolls into the real commercials.  

Are you using current CVS or a release version?  I made a change related
to this a while back and am curious if it is still happening for some people.

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Chris Pinkham
 I've been using the All option since it was introduced and, I have to 
 agree that it was MUCH better then than it is now. Must be sensitive to 
 the type of signal or something.

When is then?

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread John Patrick Poet
Chris Pinkham wrote:
I've been using the All option since it was introduced and, I have to 
agree that it was MUCH better then than it is now. Must be sensitive to 
the type of signal or something.
   

When is then?
 

I am not sure who you are quoting in this message, but I will chime in.
Within the first week that you introduced the ALL method, detection was 
simply amazing.  I have never seen it work so well.

Then I saw a message from you saying that you had to loosen up the 
concept of black.  After that, detection really took a hit.  Ever 
since then it is not that much better than it was before you add the ALL 
method.

I almost exclusively record HD material on my HD-3000 cards.  I watch 
*very* few non-HD shows.

John
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Chris Pinkham
 Within the first week that you introduced the ALL method, detection was 
 simply amazing.  I have never seen it work so well.
 
 Then I saw a message from you saying that you had to loosen up the 
 concept of black.  After that, detection really took a hit.  Ever 
 since then it is not that much better than it was before you add the ALL 
 method.

Thanks, this is helpful, thanks.

With the new ALL method, the Strict Commercial Detection setting wasn't
being used, so I just committed a change to CVS to use it in the blank-frame
detection code to allow reverting to the stricter black-frame detection that was
put into CVS when I first added the ALL method.  If you are using ALL and you
don't have Strict Commercial Detection turned ON, can you try turning that ON
and seeing if it helps detection for you?

-- 

Chris

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Scot L. Harris
On Sun, 2005-03-27 at 20:25, Chris Pinkham wrote:
  I have it set to use all detection modes.  I can not say it is 100% but
  it is very very close.  With only a few exceptions about the only
  commercials it seems to miss consistently are those sponsor bits usually
  at the end of a show that appear to be part of the actual show just
  before it rolls into the real commercials.  
 
 Are you using current CVS or a release version?  I made a change related
 to this a while back and am curious if it is still happening for some people.

I am using ATRPMS 0.17 version.


-- 
Scot L. Harris
[EMAIL PROTECTED]

The early worm gets the late bird. 

___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users


Re: [mythtv-users] How well does commercial detection work?

2005-03-27 Thread Ajay Sharma

I'm wondering how well everyone else's commercial detection is working?  

I was using the ALL method because everyone was talking about how
great it is.  I'm not that impressed with it but it might be because I'm
watching those shows that still have issues with it:

Lost:  Very dark at times, scene changes in the middle of the episode
get caught

Survivor:  Good most of the time, but the it jumps around at the end
during the tribal counsel part.

Daily Show:  Sometimes when they jump to a news clip they flash the
screen white for a second that that is picked up as a start of a commercial.

Earlier today I switched the commercial detection to Scene Change +
Black Screen or something like that.  I also took off the Auto Skip.
 Most of the time it's great, but leave Auto Skip turned off.

--Ajay
___
mythtv-users mailing list
mythtv-users@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users