Re: Updating the LM-SENSORS MIB (Issue #752)

2024-03-26 Thread Niels Baggesen

Den 26-03-2024 kl. 10:10 skrev Craig Small via Net-snmp-coders:
> Hi,
>   This email is about working out how the LM-SENSORS MIB should be 
updated. If it was just a matter of updating the SNMP agent, I'd just 
create a pull request but the MIB is (might be?) different.


Great!

> How do I get this MIB updated? I'm willing to write it up and the 
change for the agent, would a PR for the MIB be enough or does it need 
to go through some sort of other approval process?


There is nothing special about updating the MIB, so just include the 
update in your PR.


Personally I would prefer that that new object had

UNITS "Cel"
DISPLAY-HINT "d-3"

instead of displaying a milli-value, but that is personal taste.

Remember to add a REVISION section to the MIB when you update it.

/Niels

--
Niels Baggesen -- @home -- Ã…rhus -- Denmark -- ni...@baggesen.net
The purpose of computing is insight, not numbers  --  R W Hamming



___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


Re: Updating the LM-SENSORS MIB (Issue #752)

2024-03-26 Thread Bart Van Assche

On 3/26/24 02:10, Craig Small via Net-snmp-coders wrote:
This email is about working out how the LM-SENSORS MIB should be 
updated. If it was just a matter of updating the SNMP agent, I'd just 
create a pull request but the MIB is (might be?) different.


The issue is that Gauge32 can only represent a non-negative integer 
(ref RFC 2578). which means if the temperature sensor reads negative 
values, which does happen.


How do I get this MIB updated? I'm willing to write it up and the 
change for the agent, would a PR for the MIB be enough or does it need 
to go through some sort of other approval process?


Please submit a pull request that adds a new MIB object with the desired 
characteristics (MIB changes + code changes). Anyone who disagrees can 
speak up now or can comment on the pull request.


Thanks,

Bart.



___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


Updating the LM-SENSORS MIB (Issue #752)

2024-03-26 Thread Craig Small via Net-snmp-coders
Hi,
 This email is about working out how the LM-SENSORS MIB should be updated.
If it was just a matter of updating the SNMP agent, I'd just create a pull
request but the MIB is (might be?) different.

The issue is that Gauge32 can only represent a non-negative integer (ref
RFC 2578). which means if the temperature sensor reads negative values,
which does happen.

How do I get this MIB updated? I'm willing to write it up and the change
for the agent, would a PR for the MIB be enough or does it need to go
through some sort of other approval process?

 - Craig
Reference: https://github.com/net-snmp/net-snmp/issues/752

-- 

Craig Small https://dropbear.xyz/  csmall at : dropbear.xyz
Debian GNU/Linuxhttps://www.debian.org/
  csmall at : debian.org
GPG fingerprint: 5D2F B320 B825 D939 04D2  0519 3938 F96B DF50 FEA5
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders