Change in asterixdb[master]: Index-only plan

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 18: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/134/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No


Change in asterixdb[master]: Fulltext search initial implementation

2016-07-21 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change.

Change subject: Fulltext search initial implementation
..


Patch Set 5:

(1 comment)

Sent you an e-mail.

https://asterix-gerrit.ics.uci.edu/#/c/989/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:

Line 298: // Full-text search consideration: an (un)ordered 
list of string type can be compatible with string
> duplicate comments?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/989
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: Fulltext search initial implementation

2016-07-21 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change.

Change subject: Fulltext search initial implementation
..


Patch Set 5:

I don't see any comments on that file, can you let me know how to see what 
you're seeing?  (maybe a screenshot?)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/989
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Add Maven Plugin for Grammar Extension

2016-07-21 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change.

Change subject: Add Maven Plugin for Grammar Extension
..


Patch Set 2:

(14 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1011/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/AQLAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/AQLAPIServlet.java:

Line 42: for (Byte k : Statement.KINDS) {
> CRITICAL SonarQube violation:
This is a false-positive, but I suspect you can just do new 
ArrayList<>(Statement.KINDS) in the ctor and eliminate this block altogether.  
Seems like allowedStatements should be an immutable list as well.


Line 53: protected List getAllowedStatements() {
Wouldn't this be better suited as a Set?


https://asterix-gerrit.ics.uci.edu/#/c/1011/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/DDLAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/DDLAPIServlet.java:

Line 31: private static final List STATEMENTS = Arrays.asList(new 
Byte[] { Statement.DATAVERSE_DECL,
Seems like STATEMENTS should be immutable.


Line 48: protected List getAllowedStatements() {
Wouldn't this be better suited as a Set?


https://asterix-gerrit.ics.uci.edu/#/c/1011/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryAPIServlet.java:

Line 31: private static final List STATEMENTS = Arrays.asList(new 
Byte[] { Statement.DATAVERSE_DECL,
Seems like STATEMENTS should be immutable.


Line 44: protected List getAllowedStatements() {
Wouldn't this be better suited as a Set?


https://asterix-gerrit.ics.uci.edu/#/c/1011/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java:

Line 233: protected abstract List getAllowedStatements();
Wouldn't this be better suited as a Set?


https://asterix-gerrit.ics.uci.edu/#/c/1011/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/UpdateAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/UpdateAPIServlet.java:

Line 31: private static final List STATEMENTS = Arrays.asList(new 
Byte[] { Statement.DATAVERSE_DECL, Statement.DELETE,
Seems like STATEMENTS should be immutable.


Line 46: protected List getAllowedStatements() {
Wouldn't this be better suited as a Set?


https://asterix-gerrit.ics.uci.edu/#/c/1011/2/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/Statement.java
File 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/Statement.java:

Line 26: public static final byte DATASET_DECL = 0x00;
If you kept the constants into a nested class 'Kind' inside of Statement, you 
wouldn't be violating the constants in an interface rule, and also you would be 
able to eliminate a lot of the diff (since Statement.Kind.INSERT would still be 
Statement.Kind.INSERT), just a differing type.

If you leave these here, the public static final modifiers are redundant.


Line 82: while (b >= start && b <= end) {
if you check that end > start, can't you just do:

for (byte b = start; b <= end; b++) {
  bytes.add(b);
}

seems easier to understand (to me)


https://asterix-gerrit.ics.uci.edu/#/c/1011/2/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/InsertStatement.java
File 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/InsertStatement.java:

Line 31: private final Query query;
> MAJOR SonarQube violation:
Sort of a strange rule, but it would go away if you move the constants under 
Statement.Kind


https://asterix-gerrit.ics.uci.edu/#/c/1011/2/asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/src/main/java/org/apache/asterix/lang/extension/EchoStatement.java
File 
asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/src/main/java/org/apache/asterix/lang/extension/EchoStatement.java:

Line 25: public class EchoStatement implements Statement {
Does this belong in src/test/?


Line 40: return -0x01;
What is the significance of -0x01 here?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1011
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2d11782d43dd8f27d69e347ed0fc8797d79dad
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: Fulltext search initial implementation

2016-07-21 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change.

Change subject: Fulltext search initial implementation
..


Patch Set 5:

@Mike: most of the files that you put the comments are not the file that I have 
changed. Do you know what could be the reason for this? :-) 

For example - 
https://asterix-gerrit.ics.uci.edu/#/c/989/5/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/TypeExpression.java
File 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/TypeExpression.java

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/989
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Add init parameter option for external functions.

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add init parameter option for external functions.
..


Patch Set 5: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/133/ : 
UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1006
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I437880a700f61440ffab9f44035798e538fb9ff5
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Refactor General Active Classes

2016-07-21 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: Refactor General Active Classes
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/977
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8f33ee5b45c5e090b08c24a102e369aae43c04
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Index-only plan

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 18:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No


Change in asterixdb[master]: Index-only plan

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1964/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No


Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

2016-07-21 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: Cast Record Before Insert for Open Indexes
..


Patch Set 6: Code-Review+1

(3 comments)

Still needs Yingyi's rewriting expertise ...

https://asterix-gerrit.ics.uci.edu/#/c/997/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java:

Line 145: }
This indicates that we haven't gotten this part of exception handling right 
yet. Needs to be fixed, but not in this change.


https://asterix-gerrit.ics.uci.edu/#/c/997/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java:

Line 238: requiredTypeTag.toString());
Don't need the toString() here ..


https://asterix-gerrit.ics.uci.edu/#/c/997/6/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
File 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java:

Line 181: "Error evaluating tuple %1$s in 
AssignRuntime", e, tupleIndex);
Seems that $1s would be replaced by 'e', not 'tupleIndex'. 
Is that intended?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/997
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes


Change in asterixdb[master]: Add init parameter option for external functions.

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add init parameter option for external functions.
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/133/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1006
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I437880a700f61440ffab9f44035798e538fb9ff5
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Cleanup / Prune Repository References

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cleanup / Prune Repository References
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/132/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c654a8e74edce035933731885958df0e0d7cc6b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Support CASE expression in SQL++.

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Support CASE expression in SQL++.
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/131/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1015
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9de7c3df70be43456e38a61ce767cc14f09e661
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..


Patch Set 13:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/130/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Add init parameter option for external functions.

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add init parameter option for external functions.
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1963/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1006
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I437880a700f61440ffab9f44035798e538fb9ff5
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Add init parameter option for external functions.

2016-07-21 Thread Xikui Wang (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1006

to look at the new patch set (#4).

Change subject: Add init parameter option for external functions.
..

Add init parameter option for external functions.

1. Add one attribute to the external function descriptor.xml
STRING_VALUE
2. Add one test case 'Keyword detector' as a toy example for this
feature.

This init parameter option allows user to reuse the same external
function with different initialization parameters or configuration
files, such as keyword list, module file, etc.

Change-Id: I437880a700f61440ffab9f44035798e538fb9ff5
---
A asterixdb/asterix-app/data/external_function/KeywordsDetector_List1.txt
A asterixdb/asterix-app/data/external_function/KeywordsDetector_List2.txt
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta06/meta06.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/keyword_detector/keyword_detector.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/keyword_detector/keyword_detector.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/keyword_detector/keyword_detector.3.lib.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/keyword_detector/keyword_detector.4.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/keyword_detector/keyword_detector.5.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/keyword_detector/keyword_detector.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/user-defined-functions/single-line-definition/single-line-definition.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf28/udf28.1.adm
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IFunctionHelper.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JavaFunctionHelper.java
M asterixdb/asterix-external-data/src/main/resources/schema/library.xsd
A 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/KeywordsDetecterFactory.java
A 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/KeywordsDetecterFunction.java
M asterixdb/asterix-external-data/src/test/resources/library_descriptor.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Function.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FunctionTupleTranslator.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/AsterixExternalScalarFunctionInfo.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/ExternalFunctionCompilerUtil.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixExternalFunctionInfo.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/IExternalFunctionInfo.java
M 
asterixdb/asterix-yarn/src/test/resources/library/results/library-metadata/functionDataset/functionDataset.1.adm
29 files changed, 330 insertions(+), 24 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/06/1006/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1006
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I437880a700f61440ffab9f44035798e538fb9ff5
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 


Change in incubator-asterixdb-site[asf-site]: community and dev-setup fixes

2016-07-21 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged.

Change subject: community and dev-setup fixes
..


community and dev-setup fixes

* remove incubator from mailing lists
* specify Eclipse version
* add IntelliJ IDEA to prerequisites
* some code formatting
* fix the "Manual Trigger" section

Change-Id: Ic7b3c53ed39b1465954162e7e1f31b67f9df699c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/998
Reviewed-by: Yingyi Bu 
---
M community.md
M content/community.html
M content/dev-setup.html
M dev-setup.md
4 files changed, 131 insertions(+), 103 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved



diff --git a/community.md b/community.md
index 0755fbc..593be05 100644
--- a/community.md
+++ b/community.md
@@ -14,12 +14,12 @@
 Most AsterixDB and Hyracks related discussion takes place on these mailing 
lists. To subscribe, send a blank email to the subscription address.
 
 {:.table .table-striped .table-bordered}
-| Name  | Address  | Subscribe 
Address  | Archives |
-|---|--||--|
-| dev   | d...@asterixdb.incubator.apache.org   | 
dev-subscr...@asterixdb.incubator.apache.org   | 
[link](https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-dev/)|
-| users | us...@asterixdb.incubator.apache.org | 
users-subscr...@asterixdb.incubator.apache.org | 
[link](https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-users/)|
-| commits   | comm...@asterixdb.incubator.apache.org   | 
commits-subscr...@asterixdb.incubator.apache.org   | 
[link](https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-commits/)|
-| notifications | notificati...@asterixdb.incubator.apache.org | 
notifications-subscr...@asterixdb.incubator.apache.org | 
[link](https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-notifications/)|
+| Name  | Address| Subscribe Address   
 | Archives |
+|---||--|--|
+| dev   | d...@asterixdb.apache.org   | 
dev-subscr...@asterixdb.apache.org   | 
[link](https://mail-archives.apache.org/mod_mbox/asterixdb-dev/)|
+| users | us...@asterixdb.apache.org | 
users-subscr...@asterixdb.apache.org | 
[link](https://mail-archives.apache.org/mod_mbox/asterixdb-users/)|
+| commits   | comm...@asterixdb.apache.org   | 
commits-subscr...@asterixdb.apache.org   | 
[link](https://mail-archives.apache.org/mod_mbox/asterixdb-commits/)|
+| notifications | notifications@asterixdb.apache.org | 
notifications-subscr...@asterixdb.apache.org | 
[link](https://mail-archives.apache.org/mod_mbox/asterixdb-notifications/)|
 
 ### IRC
 
diff --git a/content/community.html b/content/community.html
index a9f0987..d4e0b8a 100644
--- a/content/community.html
+++ b/content/community.html
@@ -129,27 +129,27 @@
   
 
   dev
-  d...@asterixdb.incubator.apache.org
-  dev-subscr...@asterixdb.incubator.apache.org
-  https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-dev/;>link
+  d...@asterixdb.apache.org
+  dev-subscr...@asterixdb.apache.org
+  https://mail-archives.apache.org/mod_mbox/asterixdb-dev/;>link
 
 
   users
-  us...@asterixdb.incubator.apache.org
-  users-subscr...@asterixdb.incubator.apache.org
-  https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-users/;>link
+  us...@asterixdb.apache.org
+  users-subscr...@asterixdb.apache.org
+  https://mail-archives.apache.org/mod_mbox/asterixdb-users/;>link
 
 
   commits
-  comm...@asterixdb.incubator.apache.org
-  commits-subscr...@asterixdb.incubator.apache.org
-  https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-commits/;>link
+  comm...@asterixdb.apache.org
+  commits-subscr...@asterixdb.apache.org
+  https://mail-archives.apache.org/mod_mbox/asterixdb-commits/;>link
 
 
   notifications
-  notificati...@asterixdb.incubator.apache.org
-  notifications-subscr...@asterixdb.incubator.apache.org
-  https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-notifications/;>link
+  notifications@asterixdb.apache.org
+  notifications-subscr...@asterixdb.apache.org
+  https://mail-archives.apache.org/mod_mbox/asterixdb-notifications/;>link
 
   
 
diff --git a/content/dev-setup.html b/content/dev-setup.html
index 09fe42e..d252ee6 100644
--- a/content/dev-setup.html
+++ b/content/dev-setup.html
@@ -159,7 +159,7 @@
   A suitable *nix environment (Linux, OSX)
   JDK 1.8+
   Maven 3.3.9 or greater
-  A relatively recent 

Change in incubator-asterixdb-site[asf-site]: community and dev-setup fixes

2016-07-21 Thread Yingyi Bu (Code Review)
Yingyi Bu has posted comments on this change.

Change subject: community and dev-setup fixes
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/998
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b3c53ed39b1465954162e7e1f31b67f9df699c
Gerrit-PatchSet: 4
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in incubator-asterixdb-site[asf-site]: community and dev-setup fixes

2016-07-21 Thread Till Westmann (Code Review)
Hello Yingyi Bu, Ian Maxon,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/998

to look at the new patch set (#4).

Change subject: community and dev-setup fixes
..

community and dev-setup fixes

* remove incubator from mailing lists
* specify Eclipse version
* add IntelliJ IDEA to prerequisites
* some code formatting
* fix the "Manual Trigger" section

Change-Id: Ic7b3c53ed39b1465954162e7e1f31b67f9df699c
---
M community.md
M content/community.html
M content/dev-setup.html
M dev-setup.md
4 files changed, 131 insertions(+), 103 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/incubator-asterixdb-site 
refs/changes/98/998/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/998
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7b3c53ed39b1465954162e7e1f31b67f9df699c
Gerrit-PatchSet: 4
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 


Change in asterixdb[master]: Cleanup / Prune Repository References

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cleanup / Prune Repository References
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/132/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c654a8e74edce035933731885958df0e0d7cc6b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Support CASE expression in SQL++.

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Support CASE expression in SQL++.
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/131/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1015
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9de7c3df70be43456e38a61ce767cc14f09e661
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in incubator-asterixdb-site[asf-site]: community and dev-setup fixes

2016-07-21 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change.

Change subject: community and dev-setup fixes
..


Patch Set 3:

(1 comment)

Since we are dealing with two IDEs, it may be nice to point both.

https://asterix-gerrit.ics.uci.edu/#/c/998/3/dev-setup.md
File dev-setup.md:

Line 38:   * Eclipse Juno or later
Either Eclipse Juno or later / IntelliJ IDEA?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/998
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b3c53ed39b1465954162e7e1f31b67f9df699c
Gerrit-PatchSet: 3
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes


Change in incubator-asterixdb-site[asf-site]: community and dev-setup fixes

2016-07-21 Thread Yingyi Bu (Code Review)
Yingyi Bu has posted comments on this change.

Change subject: community and dev-setup fixes
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/998
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b3c53ed39b1465954162e7e1f31b67f9df699c
Gerrit-PatchSet: 3
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Cleanup / Prune Repository References

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cleanup / Prune Repository References
..


Patch Set 1: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/129/ : 
ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c654a8e74edce035933731885958df0e0d7cc6b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1960/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1959/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1958/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: TweetParser Extension

2016-07-21 Thread Xikui Wang (Code Review)
Xikui Wang has posted comments on this change.

Change subject: TweetParser Extension
..


Patch Set 4:

@Till

Thanks for your explanation. That makes totally sense to me. Will apply the 
formatter and add test cases at the next submit. Thanks! :)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1002
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cast Record Before Insert for Open Indexes
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/128/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/997
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1957/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Cleanup / Prune Repository References

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cleanup / Prune Repository References
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/129/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c654a8e74edce035933731885958df0e0d7cc6b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


[jira] [Created] (ASTERIXDB-1541) Update all Hadoop dependencies to the latest 2.6.X version.

2016-07-21 Thread Till Westmann (JIRA)
Till Westmann created ASTERIXDB-1541:


 Summary: Update all Hadoop dependencies to the latest 2.6.X 
version.
 Key: ASTERIXDB-1541
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1541
 Project: Apache AsterixDB
  Issue Type: Task
  Components: Adapters, AsterixDB
Reporter: Till Westmann
Assignee: Ian Maxon


Currently that's 2.6.4 ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ASTERIXDB-1540) Support different HDFS versions

2016-07-21 Thread Till Westmann (JIRA)
Till Westmann created ASTERIXDB-1540:


 Summary: Support different HDFS versions
 Key: ASTERIXDB-1540
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1540
 Project: Apache AsterixDB
  Issue Type: Improvement
  Components: Adapters, AsterixDB
Reporter: Till Westmann


We currently support external datasets for data stored in HDFS. However, we 
currently only support a single version of HDFS. 
We should be able to support external datasets on different HDFS instances 
using different versions of HDFS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Change in asterixdb[master]: Cleanup / Prune Repository References

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cleanup / Prune Repository References
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1956/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c654a8e74edce035933731885958df0e0d7cc6b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


[jira] [Commented] (ASTERIXDB-1484) NCService installation: "managix describe" equivalence

2016-07-21 Thread Till Westmann (JIRA)

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388421#comment-15388421
 ] 

Till Westmann commented on ASTERIXDB-1484:
--

This seems not really deployment related, but rather like a new servlet that 
provides information that's (more or less) equivalent to what {{managix 
describe}} provides. 
I think that Mike could look into this.


> NCService installation: "managix describe" equivalence
> --
>
> Key: ASTERIXDB-1484
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1484
> Project: Apache AsterixDB
>  Issue Type: Improvement
>Reporter: Yingyi Bu
>Assignee: Chris Hillery
>
> We need a "managix describe"-equivalent REST API to describe the instance 
> configurations, when we use NCService to install an instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cast Record Before Insert for Open Indexes
..


Patch Set 6:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/997
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Some Cleanup, Additions to .gitignore

2016-07-21 Thread Michael Blow (Code Review)
Michael Blow has submitted this change and it was merged.

Change subject: Some Cleanup, Additions to .gitignore
..


Some Cleanup, Additions to .gitignore

Change-Id: I624e42a2719065c26ff4cb70ab317bcce150471c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1013
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
Integration-Tests: Jenkins 
---
M .gitignore
1 file changed, 17 insertions(+), 26 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; Verified



diff --git a/.gitignore b/.gitignore
index 636fb2f..b4129bf 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,34 +11,27 @@
 ittest
 asterix_logs
 build
-bin
-asterixdb/asterix-opt/
-asterixdb/asterix-app/src/test/resources/externallib/
-asterixdb/asterix-app/rttest/
-asterixdb/asterix-app/mdtest/
-asterixdb/asterix-app/opttest/
-asterixdb/asterix-app/parserts/
-asterixdb/asterix-app/library/
-asterixdb/asterix-app/opt_parserts/
-asterixdb/asterix-app/runtime_parserts/
+asterixdb/asterix-opt
+asterixdb/asterix-app/src/test/resources/externallib
+asterixdb/asterix-app/rttest
+asterixdb/asterix-app/mdtest
+asterixdb/asterix-app/opttest
+asterixdb/asterix-app/parserts
+asterixdb/asterix-app/library
+asterixdb/asterix-app/opt_parserts
+asterixdb/asterix-app/runtime_parserts
 asterixdb/asterix-app/data/csv/beer.csv
-asterixdb/asterix-installer/ittest/
-asterixdb/asterix-installer/repliationtest/
-asterixdb/asterix-installer/src/test/resources/clusterts/asterix-installer-*-SNAPSHOT-binary-assembly/
-build
-asterix_logs
-bin/
+asterixdb/asterix-installer/ittest
+asterixdb/asterix-installer/repliationtest
+asterixdb/asterix-installer/src/test/resources/clusterts/asterix-installer-*-SNAPSHOT-binary-assembly
 *-coredump
 *.pyc
 *.iml
-asterix-app/data/csv/beer.csv
-.idea/
-asterix.ipr
-asterix.iws
+.idea
+*.ipr
+*.iws
 git.properties
 actual
-build
-edu.uci.ics.hyracks.control.nc.NodeControllerService
 exception
 expected
 teststore1
@@ -54,8 +47,6 @@
 output
 tmp
 dist
-*.iml
-.idea/
-asterixdb/asterix-opt
 *~
-
+*.swp
+.m2*

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1013
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I624e42a2719065c26ff4cb70ab317bcce150471c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[master]: Some Cleanup, Additions to .gitignore

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Some Cleanup, Additions to .gitignore
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/127/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1013
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I624e42a2719065c26ff4cb70ab317bcce150471c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Some Cleanup, Additions to .gitignore

2016-07-21 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: Some Cleanup, Additions to .gitignore
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1013
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I624e42a2719065c26ff4cb70ab317bcce150471c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: TweetParser Extension

2016-07-21 Thread Xikui Wang (Code Review)
Xikui Wang has posted comments on this change.

Change subject: TweetParser Extension
..


Patch Set 4:

@Till

Another submit addresses the Line # fix.

Just a side note on the coding style part. I got quite a few comments from 
SonarQube that says Missing curly brace for  if clause. Most of them are just 
one line statements. I am wondering is there any particular reason for that or 
it's just a fail-proof for future changes. I don't have strong opinion on this. 
Just out of curiosity due to my lack of project experience. :)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1002
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: TweetParser Extension

2016-07-21 Thread Xikui Wang (Code Review)
Xikui Wang has posted comments on this change.

Change subject: TweetParser Extension
..


Patch Set 4:

@Abdullah,

I checked the TwitterObjectFactory.getRawJSON method. When the JsonStoreEnabled 
is turned on. The TwitterObjectFactory will maintain an internal map which maps 
the existed Status object to JSON string, thus I think it will not trigger two 
requests to Twitter.

On the performance side, my actual concern is that I created one JSONObject per 
record, which may cause memory overhead. The reason to use JSONObject is in 
order to iterate over all fields. I couldn't find any other workaround on that 
part. Any suggestions?

For the test case part, the test cases I understood are the queries under  
asterixdb/asterixdb/asterix-app/src/test/resources/runtimets . I think you are 
referring to test cases elsewhere using mock objects. Any existed test case 
that I can refer to? I will put my test queries under the queries section.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1002
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7021e7b779de05b9ec999a8d5f8464fb0ab413c0
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cast Record Before Insert for Open Indexes
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/997
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cast Record Before Insert for Open Indexes
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1954/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/997
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

2016-07-21 Thread abdullah alamoudi (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/997

to look at the new patch set (#5).

Change subject: Cast Record Before Insert for Open Indexes
..

Cast Record Before Insert for Open Indexes

This change modifies the insert plan to perform cast for open
indexes before inserting to primary index. This avoids modification
of indexes and then doing complex work to try and undo the insert.
In addition, feeds can simply log and remove tuples which have
open fields of incompatible type.

Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
A asterixdb/asterix-app/data/external-parser/dropbox2/jobads3.txt
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.1.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.2.lib.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.3.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.4.update.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.5.query.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.6.lib.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.7.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.1.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.2.lib.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.3.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.4.update.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.5.query.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.6.lib.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.7.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineVariablesRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/ExceptionUtils.java
29 files changed, 8,077 insertions(+), 443 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/97/997/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/997
To unsubscribe, visit 

Change in asterixdb[master]: Some Cleanup, Additions to .gitignore

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Some Cleanup, Additions to .gitignore
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1953/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1013
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I624e42a2719065c26ff4cb70ab317bcce150471c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Some Cleanup, Additions to .gitignore

2016-07-21 Thread Michael Blow (Code Review)
Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1013

Change subject: Some Cleanup, Additions to .gitignore
..

Some Cleanup, Additions to .gitignore

Change-Id: I624e42a2719065c26ff4cb70ab317bcce150471c
---
M .gitignore
1 file changed, 17 insertions(+), 26 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/13/1013/1

diff --git a/.gitignore b/.gitignore
index 636fb2f..b4129bf 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,34 +11,27 @@
 ittest
 asterix_logs
 build
-bin
-asterixdb/asterix-opt/
-asterixdb/asterix-app/src/test/resources/externallib/
-asterixdb/asterix-app/rttest/
-asterixdb/asterix-app/mdtest/
-asterixdb/asterix-app/opttest/
-asterixdb/asterix-app/parserts/
-asterixdb/asterix-app/library/
-asterixdb/asterix-app/opt_parserts/
-asterixdb/asterix-app/runtime_parserts/
+asterixdb/asterix-opt
+asterixdb/asterix-app/src/test/resources/externallib
+asterixdb/asterix-app/rttest
+asterixdb/asterix-app/mdtest
+asterixdb/asterix-app/opttest
+asterixdb/asterix-app/parserts
+asterixdb/asterix-app/library
+asterixdb/asterix-app/opt_parserts
+asterixdb/asterix-app/runtime_parserts
 asterixdb/asterix-app/data/csv/beer.csv
-asterixdb/asterix-installer/ittest/
-asterixdb/asterix-installer/repliationtest/
-asterixdb/asterix-installer/src/test/resources/clusterts/asterix-installer-*-SNAPSHOT-binary-assembly/
-build
-asterix_logs
-bin/
+asterixdb/asterix-installer/ittest
+asterixdb/asterix-installer/repliationtest
+asterixdb/asterix-installer/src/test/resources/clusterts/asterix-installer-*-SNAPSHOT-binary-assembly
 *-coredump
 *.pyc
 *.iml
-asterix-app/data/csv/beer.csv
-.idea/
-asterix.ipr
-asterix.iws
+.idea
+*.ipr
+*.iws
 git.properties
 actual
-build
-edu.uci.ics.hyracks.control.nc.NodeControllerService
 exception
 expected
 teststore1
@@ -54,8 +47,6 @@
 output
 tmp
 dist
-*.iml
-.idea/
-asterixdb/asterix-opt
 *~
-
+*.swp
+.m2*

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1013
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I624e42a2719065c26ff4cb70ab317bcce150471c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 


Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cast Record Before Insert for Open Indexes
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/997
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cast Record Before Insert for Open Indexes
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1952/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/997
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

2016-07-21 Thread abdullah alamoudi (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/997

to look at the new patch set (#4).

Change subject: Cast Record Before Insert for Open Indexes
..

Cast Record Before Insert for Open Indexes

This change modifies the insert plan to perform cast for open
indexes before inserting to primary index. This avoids modification
of indexes and then doing complex work to try and undo the insert.
In addition, feeds can simply log and remove tuples which have
open fields of incompatible type.

Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/ExternalDataLookupPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceRandomPartitioningFeedComputationRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-app/data/external-parser/dropbox2/jobads3.txt
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
D 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/JSONUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryClassLoader.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/external/TestLibrarian.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-issue697.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/exists.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/in.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/in_correlated.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/subquery/not_exists.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/disjunction-to-join-delete-1.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/disjunction-to-join-delete-2.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/disjunction-to-join-delete-3.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/scan-delete-all.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/scan-delete-rtree-secondary-index.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/scan-delete.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/skip-index/dont-skip-primary-index-search-in-delete.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/skip-index/skip-ngram-index-search-in-delete.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/skip-index/skip-rtree-index-search-in-delete.sqlpp
M 

Change in asterixdb[master]: Refactor General Active Classes

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Refactor General Active Classes
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/126/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/977
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8f33ee5b45c5e090b08c24a102e369aae43c04
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Refactor General Active Classes

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Refactor General Active Classes
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/126/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/977
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8f33ee5b45c5e090b08c24a102e369aae43c04
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Refactor General Active Classes

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Refactor General Active Classes
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/977
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8f33ee5b45c5e090b08c24a102e369aae43c04
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


[jira] [Closed] (ASTERIXDB-1506) non-responsive after some data is ingested

2016-07-21 Thread Abdullah Alamoudi (JIRA)

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abdullah Alamoudi closed ASTERIXDB-1506.

Resolution: Fixed

> non-responsive after some data is ingested
> --
>
> Key: ASTERIXDB-1506
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1506
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Feeds
>Reporter: Christopher Green
>Assignee: Michael Blow
>
> I updated the code and recreated the dataset.  Once the feeder is started, it 
> will ingest a couple hundred entries and then the database becomes 
> non-responsive.  I can restart the instance, but about the same amount of 
> entries will be ingested before is stops working again.  
> Let what I need to provide to start working this issue and thank you for your 
> help. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ASTERIXDB-1506) non-responsive after some data is ingested

2016-07-21 Thread Abdullah Alamoudi (JIRA)

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387839#comment-15387839
 ] 

Abdullah Alamoudi commented on ASTERIXDB-1506:
--

Great. Closing the issue as Fixed.

> non-responsive after some data is ingested
> --
>
> Key: ASTERIXDB-1506
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1506
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Feeds
>Reporter: Christopher Green
>Assignee: Michael Blow
>
> I updated the code and recreated the dataset.  Once the feeder is started, it 
> will ingest a couple hundred entries and then the database becomes 
> non-responsive.  I can restart the instance, but about the same amount of 
> entries will be ingested before is stops working again.  
> Let what I need to provide to start working this issue and thank you for your 
> help. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ASTERIXDB-1506) non-responsive after some data is ingested

2016-07-21 Thread Christopher Green (JIRA)

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387781#comment-15387781
 ] 

Christopher Green commented on ASTERIXDB-1506:
--

This is working.  Thank you for the help.  

> non-responsive after some data is ingested
> --
>
> Key: ASTERIXDB-1506
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1506
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Feeds
>Reporter: Christopher Green
>Assignee: Michael Blow
>
> I updated the code and recreated the dataset.  Once the feeder is started, it 
> will ingest a couple hundred entries and then the database becomes 
> non-responsive.  I can restart the instance, but about the same amount of 
> entries will be ingested before is stops working again.  
> Let what I need to provide to start working this issue and thank you for your 
> help. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Change in asterixdb[master]: Add Test NodeController, Test Data Generator, and Marker Logs

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add Test NodeController, Test Data Generator, and Marker Logs
..


Patch Set 12: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/125/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/962
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9aa8de758b7d26ca34868b16e5ce693e0c0243
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Add Test NodeController, Test Data Generator, and Marker Logs

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add Test NodeController, Test Data Generator, and Marker Logs
..


Patch Set 12:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/125/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/962
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9aa8de758b7d26ca34868b16e5ce693e0c0243
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Add Test NodeController, Test Data Generator, and Marker Logs

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add Test NodeController, Test Data Generator, and Marker Logs
..


Patch Set 12:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/962
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9aa8de758b7d26ca34868b16e5ce693e0c0243
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Add Test NodeController, Test Data Generator, and Marker Logs

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add Test NodeController, Test Data Generator, and Marker Logs
..


Patch Set 12:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1950/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/962
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9aa8de758b7d26ca34868b16e5ce693e0c0243
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Add Test NodeController, Test Data Generator, and Marker Logs

2016-07-21 Thread abdullah alamoudi (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/962

to look at the new patch set (#12).

Change subject: Add Test NodeController, Test Data Generator, and Marker Logs
..

Add Test NodeController, Test Data Generator, and Marker Logs

This test enable creating a node controller for unit test purposes.
The Node controller is identical to the regular node controller
except that it doesn't communicate with a cluster controller at all.

In this change, Test Data Generator is introduced which should
facilitate writing unit test cases which requires data generation.
The change also includes enabling feeds to send progress data. progress
information can then be sent through the pipeline and persisted in the
transaction logs and primary index component. A Unit test case has
been created to test adding progress markers to logs and index
components and then reading them.

The last part of this change is the addition of marker logs and their
callbacks. They enable components to create arbitrary logs and get a
callback when they are written to the transaction logs. Initial set of
unit tests were added for marker logs.

Change-Id: I3b9aa8de758b7d26ca34868b16e5ce693e0c0243
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
M asterixdb/asterix-app/pom.xml
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/ABooleanFieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/ADoubleFieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/AInt32FieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/AInt64FieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/ARecordValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/AStringFieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/IAsterixFieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/TestTupleCounterFrameWriter.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/TupleGenerator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestTupleGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestTupleReference.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java
D 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestRecordDescriptorFactory.java
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogMarkerCallback.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogType.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/PrimaryIndexLogMarkerCallback.java
C 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/AsterixConstants.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/FrameStack.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/TransactionUtil.java
M 
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/util/PatternCreator.java
C 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IFeedMarker.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordConverter.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M 

Change in asterixdb[master]: Add Test NodeController, Test Data Generator, and Marker Logs

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add Test NodeController, Test Data Generator, and Marker Logs
..


Patch Set 11:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/962
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9aa8de758b7d26ca34868b16e5ce693e0c0243
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Add Test NodeController, Test Data Generator, and Marker Logs

2016-07-21 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: Add Test NodeController, Test Data Generator, and Marker Logs
..


Patch Set 10:

(16 comments)

https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java:

Line 89: logRecord = new LogRecord(callback);
> This is a nice improvement.
Thank you :)


https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java:

Line 275: AsterixRuntimeComponentsProvider.RUNTIME_PROVIDER, 
LSMBTreeIOOperationCallbackFactory.INSTANCE, 0.01,
> What is the meaning of "0.01"? Could we have a symbolic name?
Done


Line 288: AsterixRuntimeComponentsProvider.RUNTIME_PROVIDER, 
LSMBTreeIOOperationCallbackFactory.INSTANCE, 0.01,
> s.a.
Done


https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java:

Line 733: : 
storageProperties.getMemoryComponentNumPages();
> not a fan, i think the original version is much easier to read
Done


Line 759: int numPages =
> not a fan, i think the original version is much easier to read
Done


https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java:

Line 49: // we already have an index field!! should we add another pointer 
to the same object?
> Could you elaborate more on the comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogMarkerCallback.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogMarkerCallback.java:

Line 28: public static final String KEY_MARKER_CALLBACK = "MARKER_CALLBACK";
> Should we remove the redundant modifiers (public static final) given that t
Done


Line 36: public void before(ByteBuffer buffer);
> remove public
Done


Line 43: public void after(long lsn);
> remove public
Done


https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java:

Line 134: switch (logType) {
> Much better with the switch.
:)


Line 258: switch (logType) {
> Can we restore the default case?  Even if a no-op, this is good documentati
Done


https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java:

Line 92: file.getParentFile().mkdirs();
> Isn't the issue still present, (reported in patch 7)
That is right. I just added a comment because I don't think it should be taken 
care of in this static method. It is the responsibility of the caller.


https://asterix-gerrit.ics.uci.edu/#/c/962/10/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java:

Line 220: // TODO (amoudi): find a better reactive 
way to do this
> It might be helpful to add a JIRA issue for yourself for this that describe
Will do once this makes it to master. As of now, this issue doesn't exist 
(yet!) :-)


https://asterix-gerrit.ics.uci.edu/#/c/962/10/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksTaskContext.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksTaskContext.java:

Line 48: public void set(String key, Object value);
> I'm confused about this interface change. The idea of the shared object was
Done.

Notice that we sometimes need to store multiple objects in the taskCtx. Now, 
take a look in the next patch as to which classes had to change because of this.


https://asterix-gerrit.ics.uci.edu/#/c/962/10/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/io/MessagingFrameTupleAppender.java
File 

Change in asterixdb[master]: Add Test NodeController, Test Data Generator, and Marker Logs

2016-07-21 Thread abdullah alamoudi (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/962

to look at the new patch set (#11).

Change subject: Add Test NodeController, Test Data Generator, and Marker Logs
..

Add Test NodeController, Test Data Generator, and Marker Logs

This test enable creating a node controller for unit test purposes.
The Node controller is identical to the regular node controller
except that it doesn't communicate with a cluster controller at all.

In this change, Test Data Generator is introduced which should
facilitate writing unit test cases which requires data generation.
The change also includes enabling feeds to send progress data. progress
information can then be sent through the pipeline and persisted in the
transaction logs and primary index component. A Unit test case has
been created to test adding progress markers to logs and index
components and then reading them.

The last part of this change is the addition of marker logs and their
callbacks. They enable components to create arbitrary logs and get a
callback when they are written to the transaction logs. Initial set of
unit tests were added for marker logs.

Change-Id: I3b9aa8de758b7d26ca34868b16e5ce693e0c0243
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
M asterixdb/asterix-app/pom.xml
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/ABooleanFieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/ADoubleFieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/AInt32FieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/AInt64FieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/ARecordValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/AStringFieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/IAsterixFieldValueGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/TestTupleCounterFrameWriter.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/data/gen/TupleGenerator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestTupleGenerator.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestTupleReference.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java
D 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestRecordDescriptorFactory.java
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogMarkerCallback.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogType.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/PrimaryIndexLogMarkerCallback.java
C 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/AsterixConstants.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/FrameStack.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/TransactionUtil.java
M 
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/util/PatternCreator.java
C 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IFeedMarker.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordConverter.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedWithMetaDataFlowController.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
M 

Change in asterixdb[master]: Add Maven Plugin for Grammar Extension

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add Maven Plugin for Grammar Extension
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/124/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1011
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2d11782d43dd8f27d69e347ed0fc8797d79dad
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Add Maven Plugin for Grammar Extension

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add Maven Plugin for Grammar Extension
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/124/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1011
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2d11782d43dd8f27d69e347ed0fc8797d79dad
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Add Maven Plugin for Grammar Extension

2016-07-21 Thread abdullah alamoudi (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1011

to look at the new patch set (#2).

Change subject: Add Maven Plugin for Grammar Extension
..

Add Maven Plugin for Grammar Extension

This change introduces a new asterix maven plugin for grammar
extension. The plugin takes a base grammar file and an extension
file and combine them to generate an extended grammar. A base
grammar can be extended by overriding production nodes, adding
extending existing nodes, or introducing new terminals and
non terminals.

In addition, a mvn verify goal was added to generate the parser
java files from the grammar generated by the test.

Change-Id: Iaa2d11782d43dd8f27d69e347ed0fc8797d79dad
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AbstractLangTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/AQLAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/DDLAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/UpdateAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/statement/SubscribeFeedStatement.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/util/RangeMapBuilder.java
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/base/Statement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CompactStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/ConnectFeedStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CreateDataverseStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CreateFeedPolicyStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CreateFeedStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CreateFunctionStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CreateIndexStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CreatePrimaryFeedStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CreateSecondaryFeedStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DatasetDecl.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DataverseDecl.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DataverseDropStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DeleteStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DisconnectFeedStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/DropStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/FeedDropStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/FeedPolicyDropStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/FunctionDecl.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/FunctionDropStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/IndexDecl.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/IndexDropStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/InsertStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/LoadStatement.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/NodeGroupDropStatement.java
M 

Change in asterixdb[master]: Add Maven Plugin for Grammar Extension

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add Maven Plugin for Grammar Extension
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1011
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2d11782d43dd8f27d69e347ed0fc8797d79dad
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Add Maven Plugin for Grammar Extension

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add Maven Plugin for Grammar Extension
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1948/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1011
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2d11782d43dd8f27d69e347ed0fc8797d79dad
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Add Maven Plugin for Grammar Extension

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add Maven Plugin for Grammar Extension
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/123/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1011
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2d11782d43dd8f27d69e347ed0fc8797d79dad
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


[jira] [Updated] (ASTERIXDB-1448) Cache central repositories for Jenkins jobs

2016-07-21 Thread Till Westmann (JIRA)

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till Westmann updated ASTERIXDB-1448:
-
Assignee: Ian Maxon

> Cache central repositories for Jenkins jobs
> ---
>
> Key: ASTERIXDB-1448
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1448
> Project: Apache AsterixDB
>  Issue Type: Task
>Reporter: Michael Blow
>Assignee: Ian Maxon
>
> As seen in ASTERIXDB-1446, Jenkins relies on external repositories to pull 
> all content referenced by each run.  We should mirror / cache the content 
> internally to avoid pulling over the WAN on each request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ASTERIXDB-1471) ADM DataParser/Lexer outputs wrong line number for exception

2016-07-21 Thread Till Westmann (JIRA)

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387238#comment-15387238
 ] 

Till Westmann commented on ASTERIXDB-1471:
--

All done wit commit 8f7c7c6bf76a7e42dc4f7b700fdfb01cb40485f2 .

Thanks, [~idleft] !

> ADM DataParser/Lexer outputs wrong line number for exception
> 
>
> Key: ASTERIXDB-1471
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1471
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Data Formats
>Reporter: Ian Maxon
>Assignee: Xikui Wang
>
> When an ADM file contains invalid syntax according to the ADM loader, the 
> wrong line number is given for the offending line. For some reason the given 
> line # is 2x the actual one (so for 64052557 it would be 32026279). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Change in asterixdb[master]: Fix for ASTERIXDB-1471

2016-07-21 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged.

Change subject: Fix for ASTERIXDB-1471
..


Fix for ASTERIXDB-1471

The line number is increased twice in setBuffer and updateLineColumn
which causes the line number is 2x larger.

Change-Id: Ibd91bc13c3adbbbe1dbfa0dccbdf6b378b280eae
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1012
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 
---
M 
asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Michael Blow: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java
 
b/asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java
index 60e6e89..495a95e 100644
--- 
a/asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java
+++ 
b/asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java
@@ -85,7 +85,6 @@
 this.buffer = buffer;
 tokenBegin = bufpos = 0;
 containsEscapes = false;
-line++;
 tokenBegin = -1;
 }
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1012
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd91bc13c3adbbbe1dbfa0dccbdf6b378b280eae
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[master]: Fix for ASTERIXDB-1471

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Fix for ASTERIXDB-1471
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/122/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1012
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd91bc13c3adbbbe1dbfa0dccbdf6b378b280eae
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


[jira] [Commented] (ASTERIXDB-1534) NPE when restart the server

2016-07-21 Thread Jianfeng Jia (JIRA)

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387233#comment-15387233
 ] 

Jianfeng Jia commented on ASTERIXDB-1534:
-

to make issue consistent, I checked out the same master version in the 
environment section.

> NPE when restart the server
> ---
>
> Key: ASTERIXDB-1534
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1534
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Storage
> Environment: master 
> commit a89fae64ac21fb8eefde79f79d2dbe1a0e54c364
> Date:   Wed Jul 6 07:58:55 2016 -0700
>Reporter: Jianfeng Jia
>Assignee: Michael Blow
> Attachments: asterix-configuration.xml, ingest.sh
>
>
> When I stop and start the cluster by managix, I hit the following error:
> {code}
> ERROR: 
> /rhome/jianfeng/managix/home/asterix/cloudberry/.nfs02180534118e 
> (No such file or directory)
> j
> {code}
> And no nc and cc got started.
> After a while, I ran the managix start again, the cluster restart 
> successfully. 
> But one of the dataset  can't answer any queries. The simplest select query
> {code}
> for $t in dataset twitter.ds_tweet limit 5 return $t
> {code}
>  will give me the following error:
> {code}
> Caused by: org.apache.hyracks.api.exceptions.HyracksDataException: 
> org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.util.concurrent.ExecutionException: 
> org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.lang.NullPointerException
> at 
> org.apache.hyracks.control.common.utils.ExceptionUtils.setNodeIds(ExceptionUtils.java:45)
> at org.apache.hyracks.control.nc.Task.run(Task.java:319)
> ... 3 more
> Caused by: org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.util.concurrent.ExecutionException: 
> org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.lang.NullPointerException
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.runInParallel(SuperActivityOperatorNodePushable.java:218)
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.initialize(SuperActivityOperatorNodePushable.java:83)
> at org.apache.hyracks.control.nc.Task.run(Task.java:263)
> ... 3 more
> Caused by: java.util.concurrent.ExecutionException: 
> org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.lang.NullPointerException
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.runInParallel(SuperActivityOperatorNodePushable.java:212)
> ... 5 more
> Caused by: org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.lang.NullPointerException
> at 
> org.apache.hyracks.storage.am.common.dataflow.IndexSearchOperatorNodePushable.nextFrame(IndexSearchOperatorNodePushable.java:187)
> at 
> org.apache.hyracks.dataflow.common.comm.io.AbstractFrameAppender.write(AbstractFrameAppender.java:93)
> at 
> org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushAndReset(AbstractOneInputOneOutputOneFramePushRuntime.java:63)
> at 
> org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushIfNotFailed(AbstractOneInputOneOutputOneFramePushRuntime.java:69)
> at 
> org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.close(AbstractOneInputOneOutputOneFramePushRuntime.java:55)
> at 
> org.apache.hyracks.algebricks.runtime.operators.std.AssignRuntimeFactory$1.close(AssignRuntimeFactory.java:122)
> at 
> org.apache.hyracks.algebricks.runtime.operators.std.EmptyTupleSourceRuntimeFactory$1.close(EmptyTupleSourceRuntimeFactory.java:60)
> at 
> org.apache.hyracks.algebricks.runtime.operators.meta.AlgebricksMetaOperatorDescriptor$1.initialize(AlgebricksMetaOperatorDescriptor.java:116)
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.lambda$initialize$0(SuperActivityOperatorNodePushable.java:83)
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$$Lambda$1/350086994.runAction(Unknown
>  Source)
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$1.call(SuperActivityOperatorNodePushable.java:205)
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$1.call(SuperActivityOperatorNodePushable.java:202)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ... 3 more
> Caused by: java.lang.NullPointerException
> at 
> org.apache.hyracks.storage.am.common.frames.TreeIndexNSMFrame.getTupleCount(TreeIndexNSMFrame.java:287)
> at 
> 

[jira] [Commented] (ASTERIXDB-1534) NPE when restart the server

2016-07-21 Thread Jianfeng Jia (JIRA)

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387232#comment-15387232
 ] 

Jianfeng Jia commented on ASTERIXDB-1534:
-

I got it reproduced on a single node cluster!
Here is the data file: 
https://drive.google.com/open?id=0B423M7wGZj9dUjJodEoySUtIVUU
I also upload the `ingest.sh` which is to ingest this file into the db using 
file feed.

After ingesting is done ( the way I verify it is done was to verify these is no 
job running in the hostname:/adminconsole), run managix stop to stop the 
cluster.
Then after restart the cluster, just query 
{code}
for $d in dataset twitter.ds_tweet limit 5 return $d
{code}

The error should appear.

> NPE when restart the server
> ---
>
> Key: ASTERIXDB-1534
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1534
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Storage
> Environment: master 
> commit a89fae64ac21fb8eefde79f79d2dbe1a0e54c364
> Date:   Wed Jul 6 07:58:55 2016 -0700
>Reporter: Jianfeng Jia
>Assignee: Michael Blow
> Attachments: asterix-configuration.xml, ingest.sh
>
>
> When I stop and start the cluster by managix, I hit the following error:
> {code}
> ERROR: 
> /rhome/jianfeng/managix/home/asterix/cloudberry/.nfs02180534118e 
> (No such file or directory)
> j
> {code}
> And no nc and cc got started.
> After a while, I ran the managix start again, the cluster restart 
> successfully. 
> But one of the dataset  can't answer any queries. The simplest select query
> {code}
> for $t in dataset twitter.ds_tweet limit 5 return $t
> {code}
>  will give me the following error:
> {code}
> Caused by: org.apache.hyracks.api.exceptions.HyracksDataException: 
> org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.util.concurrent.ExecutionException: 
> org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.lang.NullPointerException
> at 
> org.apache.hyracks.control.common.utils.ExceptionUtils.setNodeIds(ExceptionUtils.java:45)
> at org.apache.hyracks.control.nc.Task.run(Task.java:319)
> ... 3 more
> Caused by: org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.util.concurrent.ExecutionException: 
> org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.lang.NullPointerException
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.runInParallel(SuperActivityOperatorNodePushable.java:218)
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.initialize(SuperActivityOperatorNodePushable.java:83)
> at org.apache.hyracks.control.nc.Task.run(Task.java:263)
> ... 3 more
> Caused by: java.util.concurrent.ExecutionException: 
> org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.lang.NullPointerException
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.runInParallel(SuperActivityOperatorNodePushable.java:212)
> ... 5 more
> Caused by: org.apache.hyracks.api.exceptions.HyracksDataException: 
> java.lang.NullPointerException
> at 
> org.apache.hyracks.storage.am.common.dataflow.IndexSearchOperatorNodePushable.nextFrame(IndexSearchOperatorNodePushable.java:187)
> at 
> org.apache.hyracks.dataflow.common.comm.io.AbstractFrameAppender.write(AbstractFrameAppender.java:93)
> at 
> org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushAndReset(AbstractOneInputOneOutputOneFramePushRuntime.java:63)
> at 
> org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushIfNotFailed(AbstractOneInputOneOutputOneFramePushRuntime.java:69)
> at 
> org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.close(AbstractOneInputOneOutputOneFramePushRuntime.java:55)
> at 
> org.apache.hyracks.algebricks.runtime.operators.std.AssignRuntimeFactory$1.close(AssignRuntimeFactory.java:122)
> at 
> org.apache.hyracks.algebricks.runtime.operators.std.EmptyTupleSourceRuntimeFactory$1.close(EmptyTupleSourceRuntimeFactory.java:60)
> at 
> org.apache.hyracks.algebricks.runtime.operators.meta.AlgebricksMetaOperatorDescriptor$1.initialize(AlgebricksMetaOperatorDescriptor.java:116)
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.lambda$initialize$0(SuperActivityOperatorNodePushable.java:83)
> at 
> org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$$Lambda$1/350086994.runAction(Unknown
>  Source)
> at 
> 

Change in asterixdb[master]: Add Maven Plugin for Grammar Extension

2016-07-21 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add Maven Plugin for Grammar Extension
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/123/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1011
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2d11782d43dd8f27d69e347ed0fc8797d79dad
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No