Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3056/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Yingyi Bu has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1316/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 31: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4056/ (8/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 31: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/671/ (7/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 31: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/857/ (4/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 31: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5534/ (5/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1618 to look at the new patch set (#31). Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Ensure nextFrame and flush are not called in a failed pipeline Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMTreeInsertDeleteOperatorDescriptor.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JobUtils.java M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/DistributeFeedFrameWriter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandlerFactory.java D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameCollector.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameDistributor.java D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/SyncFeedRuntimeInputHandler.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterExecutor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedCollectOperatorNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedFrameUtil.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/common/AOrderedListBinaryTokenizer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/common/AUnorderedListBinaryTokenizer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AOrderedListSerializerDeserializer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AUnorderedListSerializerDeserializer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AListPointable.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/NonTaggedFormatUtil.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/AbstractAsterixListIterator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/ListAccessor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/OrderedListIterator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardPrefixEvaluator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/eva
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 31: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 31: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/246/ (3/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 31: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/589/ (6/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 31: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3057/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 31: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/36/ (2/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1316/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 31: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/678/ (1/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 31 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-1929) Factor out isAntimatter from TupleWriter and TupleWriterFactory
[ https://issues.apache.org/jira/browse/ASTERIXDB-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035837#comment-16035837 ] Chen Luo commented on ASTERIXDB-1929: - This should be doable (and better than keep tracking the created tuple writers by the factory)! I've updated my patch with this change. > Factor out isAntimatter from TupleWriter and TupleWriterFactory > --- > > Key: ASTERIXDB-1929 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929 > Project: Apache AsterixDB > Issue Type: Improvement > Components: Storage >Reporter: Yingyi Bu >Assignee: Chen Luo > > isAntimatter is a property of the tuple that we're writing, but not a > property of the Writer. Hence, we probably should remove setAntimatter(...) > from the TupleWriter. > Currently, for each tuple write operation, we need to call setAntimatter() in > both TupleWriterFactory and TupleWriter. This is painful and potentially > buggy -- a XxxFactory typically is one per NC. > Instead, we can add a parameter to write tuple method: > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) > -> > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, > boolean isDelete) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4055/ (8/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/670/ (7/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/588/ (6/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5533/ (5/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3056/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/856/ (4/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/677/ (1/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/35/ (2/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Hello Yingyi Bu, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1796 to look at the new patch set (#7). Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Allow insert anti-matter tuples when bulk loading LSM index Previously, when we bulk load an LSM index, we are not allowed to insert anti-matter tuples to the disk component. However, creating secondary index for correlated datasets requires anti-matter tuples to be inserted as well. Thus, this patch mainly contains the following changes: - When bulk loading LSM index, allow the user to switch between insert mode and delete mode - Extended the LSMDiskComponentBulkLoader with the delete method. For LSM index with anti-matter tuples, the delete method simply sets the TupleWriter to delete mode, and inserts the anti-matter tuple. For LSM index with buddy btree, it simply inserts the deleted tuple into the buddy btree. - Since the LSMDiskComponentBulkLoader would have a delete method anyway, added a new ILSMDiskComponentBulkLoader interface containing the delete method. Change-Id: I6665f56a5d2183697197298fa24824eeb827686a --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTree.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java D hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeRefrencingTupleWriterFactory.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriterFactory.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponentBulkLoader.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIndex.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTreeTupleWriter.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentWithBuddyBulkLoader.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTree.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuples.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/tuples/LSMRTreeTupleWriter.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/tuples/LSMRTreeTupleWriterFactory.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/tuples/LSMRTreeTupleWriterFactoryForPointMBR.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/tuples/LSMRTreeTupleWriterForPointMBR.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/tuples/LSMTypeAwareTupleWriterFactory.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/utils/LSMRTreeUtils.java 21 files changed, 243 insertions(+), 157 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/96/1796/7 -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Jenkins has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/245/ (3/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
[jira] [Issue Comment Deleted] (ASTERIXDB-1929) Factor out isAntimatter from TupleWriter and TupleWriterFactory
[ https://issues.apache.org/jira/browse/ASTERIXDB-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen Luo updated ASTERIXDB-1929: Comment: was deleted (was: I think the answer is NO. Actually I saw this referencing factory idea initially was used by ExternalBtree, which also needs to insert anti-matter tuples during bulkload. The current workflow of this tuple writer is as follows. When we create a LSMBTree, we would specify its LeafFrameFactory, which depends on the provided TupleWriterFactory. Then, BTree would call LeafFrameFactory to create leaf frames, which calls the TupleWriterFactory to create the corresponding tuple writer. Thus, the tuple writer is only managed by the leaf frame, and BTree calls its insertTuple method to do insertion. The problem here is that LSMBTree or even BTree couldn't track the corresponding TupleWriter. So currently, this LSMTreeRefrencingTupleWriterFactory would track it and set it to delete mode when necessary.) > Factor out isAntimatter from TupleWriter and TupleWriterFactory > --- > > Key: ASTERIXDB-1929 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929 > Project: Apache AsterixDB > Issue Type: Improvement > Components: Storage >Reporter: Yingyi Bu >Assignee: Chen Luo > > isAntimatter is a property of the tuple that we're writing, but not a > property of the Writer. Hence, we probably should remove setAntimatter(...) > from the TupleWriter. > Currently, for each tuple write operation, we need to call setAntimatter() in > both TupleWriterFactory and TupleWriter. This is painful and potentially > buggy -- a XxxFactory typically is one per NC. > Instead, we can add a parameter to write tuple method: > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) > -> > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, > boolean isDelete) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ASTERIXDB-1929) Factor out isAntimatter from TupleWriter and TupleWriterFactory
[ https://issues.apache.org/jira/browse/ASTERIXDB-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035832#comment-16035832 ] Chen Luo commented on ASTERIXDB-1929: - I think the answer is NO. Actually I saw this referencing factory idea initially was used by ExternalBtree, which also needs to insert anti-matter tuples during bulkload. The current workflow of this tuple writer is as follows. When we create a LSMBTree, we would specify its LeafFrameFactory, which depends on the provided TupleWriterFactory. Then, BTree would call LeafFrameFactory to create leaf frames, which calls the TupleWriterFactory to create the corresponding tuple writer. Thus, the tuple writer is only managed by the leaf frame, and BTree calls its insertTuple method to do insertion. The problem here is that LSMBTree or even BTree couldn't track the corresponding TupleWriter. So currently, this LSMTreeRefrencingTupleWriterFactory would track it and set it to delete mode when necessary. > Factor out isAntimatter from TupleWriter and TupleWriterFactory > --- > > Key: ASTERIXDB-1929 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929 > Project: Apache AsterixDB > Issue Type: Improvement > Components: Storage >Reporter: Yingyi Bu >Assignee: Chen Luo > > isAntimatter is a property of the tuple that we're writing, but not a > property of the Writer. Hence, we probably should remove setAntimatter(...) > from the TupleWriter. > Currently, for each tuple write operation, we need to call setAntimatter() in > both TupleWriterFactory and TupleWriter. This is painful and potentially > buggy -- a XxxFactory typically is one per NC. > Instead, we can add a parameter to write tuple method: > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) > -> > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, > boolean isDelete) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4054/ (8/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/669/ (7/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/676/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/587/ (6/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5532/ (4/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/244/ (2/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/34/ (3/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/855/ (5/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-1929) Factor out isAntimatter from TupleWriter and TupleWriterFactory
[
https://issues.apache.org/jira/browse/ASTERIXDB-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035813#comment-16035813
]
Yingyi Bu commented on ASTERIXDB-1929:
--
OK, I see the point. The current implementation makes some sense to me now.
Then, my only left concern is the usage of factory -- can we remove
setAntimatter from the LSMTreeRefrencingTupleWriterFactory, and instead, only
set/unset antimatter in the tuple writer ?
{noformat}
public class LSMTreeRefrencingTupleWriterFactory implements
ITreeIndexTupleWriterFactory {
private static final long serialVersionUID = 1L;
private final ITreeIndexTupleWriterFactory factory;
private transient ILSMTreeTupleWriter createdTupleWriter;
public LSMTreeRefrencingTupleWriterFactory(ITreeIndexTupleWriterFactory
factory) {
this.factory = factory;
}
@Override
public ITreeIndexTupleWriter createTupleWriter() {
createdTupleWriter = (ILSMTreeTupleWriter) factory.createTupleWriter();
return createdTupleWriter;
}
public void setAntimatter(boolean isAntimatter) {
if (this.createdTupleWriter != null) {
this.createdTupleWriter.setAntimatter(isAntimatter);
}
}
}
{noformat}
> Factor out isAntimatter from TupleWriter and TupleWriterFactory
> ---
>
> Key: ASTERIXDB-1929
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929
> Project: Apache AsterixDB
> Issue Type: Improvement
> Components: Storage
>Reporter: Yingyi Bu
>Assignee: Chen Luo
>
> isAntimatter is a property of the tuple that we're writing, but not a
> property of the Writer. Hence, we probably should remove setAntimatter(...)
> from the TupleWriter.
> Currently, for each tuple write operation, we need to call setAntimatter() in
> both TupleWriterFactory and TupleWriter. This is painful and potentially
> buggy -- a XxxFactory typically is one per NC.
> Instead, we can add a parameter to write tuple method:
> public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff)
> ->
> public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff,
> boolean isDelete)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ASTERIXDB-1929) Factor out isAntimatter from TupleWriter and TupleWriterFactory
[ https://issues.apache.org/jira/browse/ASTERIXDB-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035795#comment-16035795 ] Chen Luo commented on ASTERIXDB-1929: - In order not to disturb too much about the existing storage codebase, this parameter isDelete should be false by default. However, if we add the new method in ILSMTreeTupleWriter, then there is no way for BTree to call this method. The actual insertion into a BTree happens in TreeIndexNSMFrame.insert (e.g., its subclass BTreeNSMLeafFrame), and this method has no idea of ILSMTreeTupleWriter, which belongs to LSM index. It seems to me the only way of adding this method is to expose anti-matter tuples to BTree (though I think it's potentially dangerous to do so...) > Factor out isAntimatter from TupleWriter and TupleWriterFactory > --- > > Key: ASTERIXDB-1929 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929 > Project: Apache AsterixDB > Issue Type: Improvement > Components: Storage >Reporter: Yingyi Bu >Assignee: Chen Luo > > isAntimatter is a property of the tuple that we're writing, but not a > property of the Writer. Hence, we probably should remove setAntimatter(...) > from the TupleWriter. > Currently, for each tuple write operation, we need to call setAntimatter() in > both TupleWriterFactory and TupleWriter. This is painful and potentially > buggy -- a XxxFactory typically is one per NC. > Instead, we can add a parameter to write tuple method: > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) > -> > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, > boolean isDelete) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ASTERIXDB-1929) Factor out isAntimatter from TupleWriter and TupleWriterFactory
[ https://issues.apache.org/jira/browse/ASTERIXDB-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035793#comment-16035793 ] Yingyi Bu commented on ASTERIXDB-1929: -- Alternatively, we can have the method with isDelete flag only appear in ILSMTreeTupleWriter? > Factor out isAntimatter from TupleWriter and TupleWriterFactory > --- > > Key: ASTERIXDB-1929 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929 > Project: Apache AsterixDB > Issue Type: Improvement > Components: Storage >Reporter: Yingyi Bu >Assignee: Chen Luo > > isAntimatter is a property of the tuple that we're writing, but not a > property of the Writer. Hence, we probably should remove setAntimatter(...) > from the TupleWriter. > Currently, for each tuple write operation, we need to call setAntimatter() in > both TupleWriterFactory and TupleWriter. This is painful and potentially > buggy -- a XxxFactory typically is one per NC. > Instead, we can add a parameter to write tuple method: > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) > -> > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, > boolean isDelete) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ASTERIXDB-1929) Factor out isAntimatter from TupleWriter and TupleWriterFactory
[ https://issues.apache.org/jira/browse/ASTERIXDB-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035791#comment-16035791 ] Yingyi Bu commented on ASTERIXDB-1929: -- Can parameter isDelete always be false at the caller from in-place B-Tree? > Factor out isAntimatter from TupleWriter and TupleWriterFactory > --- > > Key: ASTERIXDB-1929 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929 > Project: Apache AsterixDB > Issue Type: Improvement > Components: Storage >Reporter: Yingyi Bu >Assignee: Chen Luo > > isAntimatter is a property of the tuple that we're writing, but not a > property of the Writer. Hence, we probably should remove setAntimatter(...) > from the TupleWriter. > Currently, for each tuple write operation, we need to call setAntimatter() in > both TupleWriterFactory and TupleWriter. This is painful and potentially > buggy -- a XxxFactory typically is one per NC. > Instead, we can add a parameter to write tuple method: > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) > -> > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, > boolean isDelete) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Yingyi Bu has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 6: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-1929) Factor out isAntimatter from TupleWriter and TupleWriterFactory
[ https://issues.apache.org/jira/browse/ASTERIXDB-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035788#comment-16035788 ] Chen Luo commented on ASTERIXDB-1929: - Still have one concern of this issue. Currently, antimatter tuple is a property of LSM index (e.g., LSMBTree), but not the normal tree index (e.g., BTree). The writeTuple method is essentially called inside by tree index (BTree) since the insertion happens there. Thus, it would break the current abstraction by making anti-matter visible to BTree. Any comments by devs? > Factor out isAntimatter from TupleWriter and TupleWriterFactory > --- > > Key: ASTERIXDB-1929 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929 > Project: Apache AsterixDB > Issue Type: Improvement > Components: Storage >Reporter: Yingyi Bu >Assignee: Chen Luo > > isAntimatter is a property of the tuple that we're writing, but not a > property of the Writer. Hence, we probably should remove setAntimatter(...) > from the TupleWriter. > Currently, for each tuple write operation, we need to call setAntimatter() in > both TupleWriterFactory and TupleWriter. This is painful and potentially > buggy -- a XxxFactory typically is one per NC. > Instead, we can add a parameter to write tuple method: > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) > -> > public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, > boolean isDelete) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Yingyi Bu has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1796/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java: PS6, Line 88: setAntimatter > This makes sense. However, adding this method would make a lot of changes t Sure, we can do the refactoring in a separate change. I created ASTERIXDB-1929 and assigned you. -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
[jira] [Created] (ASTERIXDB-1929) Factor out isAntimatter from TupleWriter and TupleWriterFactory
Yingyi Bu created ASTERIXDB-1929: Summary: Factor out isAntimatter from TupleWriter and TupleWriterFactory Key: ASTERIXDB-1929 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929 Project: Apache AsterixDB Issue Type: Improvement Components: Storage Reporter: Yingyi Bu Assignee: Chen Luo isAntimatter is a property of the tuple that we're writing, but not a property of the Writer. Hence, we probably should remove setAntimatter(...) from the TupleWriter. Currently, for each tuple write operation, we need to call setAntimatter() in both TupleWriterFactory and TupleWriter. This is painful and potentially buggy -- a XxxFactory typically is one per NC. Instead, we can add a parameter to write tuple method: public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) -> public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, boolean isDelete) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Change in asterixdb[master]: Add Disk Component Scan operation for primary LSM index
Luo Chen has posted comments on this change. Change subject: Add Disk Component Scan operation for primary LSM index .. Patch Set 3: (2 comments) > (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1791/3/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java: PS3, Line 46: LSMBTreeDiskComponentScanCursor > It feels like a lot of this code is shared with the normal cursor. Is that Yes, so it extends LSMIndexSearchCursor for code re-use. Most of work of maintaining the priority queue is done there. However, this scan cursor needs to append extra fields, and generate proper tuples for anti-matter tuples (basically completing the anti-matter tuples, since in the primary BTree we only have the primary key) https://asterix-gerrit.ics.uci.edu/#/c/1791/3/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/LSMOperationType.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/LSMOperationType.java: PS3, Line 28: DISK_COMPONENT_SCAN > I see. Still though, at the base of it, a search is a component scan as wel I was thinking "search" is still a little bit different from "scan" since search often returns tuples satisfying a given predicate, while scan returns everything in that index. In this patch, I didn't allow the caller to set a predicate for this operation (unless there are some valid use cases for doing this). Thus, I think scan might be a better term, what about RAW_SCAN then? -- To view, visit https://asterix-gerrit.ics.uci.edu/1791 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31b2c67c58cb0a440c1d2c26400af322e2f1c1e5 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Luo Chen has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1796/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java: PS5, Line 32: isAntima > Well, maybe it's a bias, but I think antimatter is a more orthogonal term f Got it. I already change it back to isAntimatter. -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3055/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Luo Chen has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1796/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java: PS6, Line 88: setAntimatter > I think the abstraction was not right. This makes sense. However, adding this method would make a lot of changes to the existing LSM indexes. Take BTree (and LSMBTree) as an example. Anti-matter tuple is only a special property for LSMBTree, but not BTree. When we insert a tuple (matter or anti-matter) into a LSMBTree, we first choose a proper leaf frame of BTree (insertLeafFrame or deleteLeafFrame), and let the BTree to do the actual insert based on that frame. Adding this method would totally change this workflow, since BTree now has to know whether it's a anti-matter tuple or not. I would suggest maybe we can make this refactoring as a separate patch? -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3052/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5531/ (5/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/243/ (3/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/586/ (6/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 29: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/32/ (1/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 29 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 29: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/674/ (3/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 29 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/33/ (2/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4053/ (8/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Log filter values for redo during recovery
Jenkins has posted comments on this change. Change subject: Log filter values for redo during recovery .. Patch Set 4: Integration-Tests-1 Integration Tests Timed Out https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3051/ : ABORTED -- To view, visit https://asterix-gerrit.ics.uci.edu/1798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/668/ (7/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3055/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/854/ (4/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 30: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/675/ (1/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 30 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 29: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 29 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1618 to look at the new patch set (#29). Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Ensure nextFrame and flush are not called in a failed pipeline Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMTreeInsertDeleteOperatorDescriptor.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JobUtils.java M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/DistributeFeedFrameWriter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandlerFactory.java D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameCollector.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameDistributor.java D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/SyncFeedRuntimeInputHandler.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterExecutor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedCollectOperatorNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedFrameUtil.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/common/AOrderedListBinaryTokenizer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/common/AUnorderedListBinaryTokenizer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AOrderedListSerializerDeserializer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AUnorderedListSerializerDeserializer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AListPointable.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/NonTaggedFormatUtil.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/AbstractAsterixListIterator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/ListAccessor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/OrderedListIterator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardPrefixEvaluator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/eva
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 29: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/242/ (2/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 29 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1315/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 28: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/585/ (6/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 28: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/853/ (4/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 28: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4052/ (8/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 28: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5530/ (5/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 28: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/667/ (7/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 28: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 28: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/673/ (2/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 28: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3053/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1618 to look at the new patch set (#28). Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Ensure nextFrame and flush are not called in a failed pipeline Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ConnectorDescriptorWithMessagingTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMTreeInsertDeleteOperatorDescriptor.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JobUtils.java M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/DistributeFeedFrameWriter.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java A asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandlerFactory.java D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameCollector.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameDistributor.java D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/SyncFeedRuntimeInputHandler.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/AdapterExecutor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedCollectOperatorNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaComputeNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedFrameUtil.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/common/AOrderedListBinaryTokenizer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/common/AUnorderedListBinaryTokenizer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AOrderedListSerializerDeserializer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AUnorderedListSerializerDeserializer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AListPointable.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/NonTaggedFormatUtil.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/AbstractAsterixListIterator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/ListAccessor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/OrderedListIterator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardPrefixEvaluator.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/eva
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 28: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/241/ (1/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Ensure nextFrame and flush are not called in a failed pipeline
Jenkins has posted comments on this change. Change subject: Ensure nextFrame and flush are not called in a failed pipeline .. Patch Set 28: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/31/ (3/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1618 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9827b06f640858f27ec1bcca2a39991780bee3b1 Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1315/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Add Disk Component Scan operation for primary LSM index
Ian Maxon has posted comments on this change. Change subject: Add Disk Component Scan operation for primary LSM index .. Patch Set 3: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1791/3/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java: PS3, Line 46: LSMBTreeDiskComponentScanCursor It feels like a lot of this code is shared with the normal cursor. Is that the case? https://asterix-gerrit.ics.uci.edu/#/c/1791/3/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/LSMOperationType.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/LSMOperationType.java: PS3, Line 28: DISK_COMPONENT_SCAN > Currently this operation is solely used by creating new secondary index. I see. Still though, at the base of it, a search is a component scan as well. If it has to be two separate operations, maybe RAW_SEARCH or something? -- To view, visit https://asterix-gerrit.ics.uci.edu/1791 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31b2c67c58cb0a440c1d2c26400af322e2f1c1e5 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Log filter values for redo during recovery
Jenkins has posted comments on this change. Change subject: Log filter values for redo during recovery .. Patch Set 4: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1314/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Yingyi Bu has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 6: (1 comment) So my major concern is that "antimatter" should be factored out from TupleWriter/TupleWriterFactory. https://asterix-gerrit.ics.uci.edu/#/c/1796/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java: PS6, Line 119: updateFilter > I think it has to. You have to search for the antimatter just as you would OK, got it! -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Log filter values for redo during recovery
Jenkins has posted comments on this change. Change subject: Log filter values for redo during recovery .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1314/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-HasComments: No
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Ian Maxon has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 6: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1796/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java: PS5, Line 32: isAntima > Across code base, I saw some places use isAntimatter (like here), and some Well, maybe it's a bias, but I think antimatter is a more orthogonal term for the behavior. A 'delete' tuple can lead to confusing phrases. https://asterix-gerrit.ics.uci.edu/#/c/1796/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java: PS6, Line 119: updateFilter > Should updateFilter(...) behave differently for add(..) and delete(...)? I think it has to. You have to search for the antimatter just as you would a matter tuple. You wouldn't want the filter to restrict it from being found. https://asterix-gerrit.ics.uci.edu/#/c/1796/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentWithBuddyBulkLoader.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentWithBuddyBulkLoader.java: PS5, Line 87: : updateFilter(tuple) > Currently, when we delete a tuple (insert antimatter tuple or insert into t Ah, right, that makes sense now that I think about it more. One needs to search for the antimatter tuple as part of the filtered query. -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4051/ (8/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/584/ (6/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/852/ (4/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/666/ (7/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3052/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5529/ (5/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/240/ (3/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/672/ (1/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Clean up numeric type conversion code
Jenkins has posted comments on this change. Change subject: Clean up numeric type conversion code .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/30/ (2/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1800 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Clean up numeric type conversion code
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1800
to look at the new patch set (#4).
Change subject: Clean up numeric type conversion code
..
Clean up numeric type conversion code
- Add new conversion methods to ITypeConvertorComputer interface
- Move remaining type conversion code from ATypeHierarchy
to ITypeConvertorComputer implementations
- Add type demotion parameter to chose whether it fails
if input value is out of range for the target type ('strict' mode)
or not ('lax' mode)
- Clean up error messages
Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SimilarityCheckRule.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
D
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/common/SerializationUtil.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/AMurmurHash3BinaryHashFunctionFamily.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ACastVisitor.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/ATypeHierarchy.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/AbstractIntegerTypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/DoubleToFloatTypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/DoubleToInt16TypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/DoubleToInt32TypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/DoubleToInt64TypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/DoubleToInt8TypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/FloatToDoubleTypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/FloatToInt16TypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/FloatToInt32TypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/FloatToInt64TypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/FloatToInt8TypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/ITypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/IntegerToDoubleTypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/IntegerToFloatTypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/IntegerToInt16TypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/IntegerToInt32TypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/IntegerToInt64TypeConvertComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/IntegerToInt8TypeConvertComputer.java
29 files changed, 1,064 insertions(+), 855 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/00/1800/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/1800
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68b78e2dc9ebf78799698a1c90bcd7cb5150137d
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: Allow insert anti-matter tuples when bulk loading LSM index
Yingyi Bu has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index .. Patch Set 6: (2 comments) It looks the property "antimatter" (more precisely, "isDelete") should be factored out from TupleWriter and TupleWriterFactory. It is a property of a tuple that we're writing rather than a property of the writer. https://asterix-gerrit.ics.uci.edu/#/c/1796/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java: PS6, Line 88: setAntimatter I think the abstraction was not right. isAntimatter is a property of the tuple that we're writing, but not a property of the Writer. Hence, we probably should remove setAntimatter(...) from the TupleWriter. Instead, we add a parameter to write tuple method: public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) -> public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, boolean isDelete) https://asterix-gerrit.ics.uci.edu/#/c/1796/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java: PS6, Line 119: updateFilter Should updateFilter(...) behave differently for add(..) and delete(...)? I don't think a delete operation can affect the existing filter? -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Log filter values for redo during recovery
Jenkins has posted comments on this change. Change subject: Log filter values for redo during recovery .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4050/ (8/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-HasComments: No
Change in asterixdb[master]: Log filter values for redo during recovery
Jenkins has posted comments on this change. Change subject: Log filter values for redo during recovery .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/665/ (7/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-HasComments: No
Change in asterixdb[master]: Log filter values for redo during recovery
Jenkins has posted comments on this change. Change subject: Log filter values for redo during recovery .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-HasComments: No
Change in asterixdb[master]: Log filter values for redo during recovery
Jenkins has posted comments on this change. Change subject: Log filter values for redo during recovery .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/583/ (6/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-HasComments: No
Change in asterixdb[master]: Log filter values for redo during recovery
Jenkins has posted comments on this change. Change subject: Log filter values for redo during recovery .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/851/ (4/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/1798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-HasComments: No
Change in asterixdb[master]: Log filter values for redo during recovery
Jenkins has posted comments on this change. Change subject: Log filter values for redo during recovery .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3051/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-HasComments: No
