Re: [PR] Add TripleConfig to ProtocolConfig as nest configuration [dubbo]

2024-05-14 Thread via GitHub


sonarcloud[bot] commented on PR #14077:
URL: https://github.com/apache/dubbo/pull/14077#issuecomment-2111580924

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14077) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [14 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14077&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14077&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14077&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14077&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [20.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14077&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14077)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Using safe serialize executor in triple protocol [dubbo]

2024-05-14 Thread via GitHub


finefuture closed pull request #13196: Using safe serialize executor in triple 
protocol
URL: https://github.com/apache/dubbo/pull/13196


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Optimize deadline message when occur timeout exception [dubbo]

2024-05-14 Thread via GitHub


finefuture closed pull request #13096: Optimize deadline message when occur 
timeout exception
URL: https://github.com/apache/dubbo/pull/13096


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Zero trust security mechanism in mesh [dubbo]

2024-05-14 Thread via GitHub


sonarcloud[bot] commented on PR #14002:
URL: https://github.com/apache/dubbo/pull/14002#issuecomment-2111511406

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14002) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [204 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14002&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14002&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14002&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14002&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.4% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14002&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14002)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] 使用配置来提供服务,filter不生效 [dubbo-go]

2024-05-14 Thread via GitHub


YarBor commented on issue #2670:
URL: https://github.com/apache/dubbo-go/issues/2670#issuecomment-2111490986

   我查看了现有的实现,
   一种可能的解决办法是:
   ```yaml
   dubbo:
 registries:
   demoZK:
 protocol: nacos
 timeout: 10s
 address: 127.0.0.1:8848
 protocols:
   tripleProtocol:
 name: tri
 port: 2
 provider:
   filter: ValidateFilter
   services:
 GreetTripleServer:
   interface: com.apache.dubbo.sample.Greeter
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] Dubbo 各版本总结与升级建议 [dubbo]

2024-05-14 Thread via GitHub


Johnson-Jia commented on issue #5669:
URL: https://github.com/apache/dubbo/issues/5669#issuecomment-2111454648

   @zkbean  具体原因没找到,升级到 dubbo 3.x 版本 、nacos 2.2.x ,目前没发现问题


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump io.netty.incubator:netty-incubator-codec-quic from 0.0.14.Final to 0.0.20.Final [dubbo-spi-extensions]

2024-05-14 Thread via GitHub


songxiaosheng merged PR #319:
URL: https://github.com/apache/dubbo-spi-extensions/pull/319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump org.apache.httpcomponents:fluent-hc from 4.5.5 to 4.5.14 [dubbo-spi-extensions]

2024-05-14 Thread via GitHub


songxiaosheng merged PR #320:
URL: https://github.com/apache/dubbo-spi-extensions/pull/320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump fabric8_kubernetes_version from 6.9.2 to 6.12.0 [dubbo-spi-extensions]

2024-05-14 Thread via GitHub


songxiaosheng merged PR #321:
URL: https://github.com/apache/dubbo-spi-extensions/pull/321


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump com.google.code.gson:gson from 2.8.9 to 2.10.1 [dubbo-spi-extensions]

2024-05-14 Thread via GitHub


songxiaosheng merged PR #324:
URL: https://github.com/apache/dubbo-spi-extensions/pull/324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump spring-boot.version from 2.4.1 to 2.7.18 [dubbo-spi-extensions]

2024-05-14 Thread via GitHub


songxiaosheng merged PR #327:
URL: https://github.com/apache/dubbo-spi-extensions/pull/327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump rocketmq.version from 4.9.2 to 4.9.8 [dubbo-spi-extensions]

2024-05-14 Thread via GitHub


songxiaosheng merged PR #326:
URL: https://github.com/apache/dubbo-spi-extensions/pull/326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump sofa_registry_version from 5.2.0 to 5.4.3 [dubbo-spi-extensions]

2024-05-14 Thread via GitHub


songxiaosheng merged PR #328:
URL: https://github.com/apache/dubbo-spi-extensions/pull/328


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-05-14 Thread via GitHub


songxiaosheng commented on issue #13957:
URL: https://github.com/apache/dubbo/issues/13957#issuecomment-2110338558

   ref https://github.com/apache/dubbo-spi-extensions/pull/307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-05-14 Thread via GitHub


songxiaosheng closed issue #13957: [Feature] Move Mesh Rule Router to SPI 
Extensions
URL: https://github.com/apache/dubbo/issues/13957


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump protobuf-java_version from 3.16.3 to 3.25.3 [dubbo-spi-extensions]

2024-05-14 Thread via GitHub


songxiaosheng merged PR #329:
URL: https://github.com/apache/dubbo-spi-extensions/pull/329


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Bump org.apache.maven.plugins:maven-assembly-plugin from 3.1.0 to 3.7.1 [dubbo-spi-extensions]

2024-05-14 Thread via GitHub


songxiaosheng merged PR #331:
URL: https://github.com/apache/dubbo-spi-extensions/pull/331


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-05-14 Thread via GitHub


sonarcloud[bot] commented on PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2110280513

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [240 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-05-14 Thread via GitHub


sonarcloud[bot] commented on PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2110252644

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [240 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-05-14 Thread via GitHub


walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599973393


##
dubbo-metrics/dubbo-metrics-config-center/pom.xml:
##
@@ -27,7 +27,7 @@
   
 
   org.apache.dubbo
-  dubbo-metrics-api
+  dubbo-metrics-core

Review Comment:
   Well, it's actually just a matter of package naming. I committed the changes 
and restored the 'dubbo-metrics-api' package name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-05-14 Thread via GitHub


walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599989372


##
dubbo-metrics/dubbo-metrics-config-center/pom.xml:
##
@@ -27,7 +27,7 @@
   
 
   org.apache.dubbo
-  dubbo-metrics-api
+  dubbo-metrics-core

Review Comment:
   Well, it's actually just a matter of package naming. I committed the 
changes. Please confirm whether it is consistent with your suggestion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-05-14 Thread via GitHub


walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599973393


##
dubbo-metrics/dubbo-metrics-config-center/pom.xml:
##
@@ -27,7 +27,7 @@
   
 
   org.apache.dubbo
-  dubbo-metrics-api
+  dubbo-metrics-core

Review Comment:
   Well, it's actually just a matter of package naming. I committed the changes 
and restored the 'dubbo-metrics-api' package name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] feat:remove old zookeeper [dubbo]

2024-05-14 Thread via GitHub


sonarcloud[bot] commented on PR #14028:
URL: https://github.com/apache/dubbo/pull/14028#issuecomment-2110042209

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14028) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [44 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14028&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14028&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14028&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14028&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14028&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14028)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[PR] Add namespace for traditionalStore [dubbo-kubernetes]

2024-05-14 Thread via GitHub


Flying-Tom opened a new pull request, #281:
URL: https://github.com/apache/dubbo-kubernetes/pull/281

   ## What is the purpose of the change
   
   `opts.name` in traditionalStore.get is default to be 
`core_model.DefaultMesh` (`"default"`), which cannot pass 
`util_k8s.CoreNameToK8sName`'s check. A namespace appended may be needed to 
integrate the name processing of the `universal` and `k8s` mode.
   
   ## Brief changelog
   
   
   ## Verifying this change
   
   
   
   
   ## CheckList
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo-kubernetes/issues) field for the 
change (usually before you start working on it). Trivial changes like typos do 
not require a GitHub issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. 
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-05-14 Thread via GitHub


songxiaosheng commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599813560


##
dubbo-metrics/dubbo-metrics-config-center/pom.xml:
##
@@ -27,7 +27,7 @@
   
 
   org.apache.dubbo
-  dubbo-metrics-api
+  dubbo-metrics-core

Review Comment:
   We can move towards abstraction, so I suggest relying on APIs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[I] [Bug] enable-empty-protection default value is different between doc and code [dubbo]

2024-05-14 Thread via GitHub


neal-wyz opened a new issue, #14190:
URL: https://github.com/apache/dubbo/issues/14190

   ### Pre-check
   
   - [X] I am sure that all the content I provide is in English.
   
   
   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Apache Dubbo Component
   
   Java SDK (apache/dubbo)
   
   ### Dubbo Version
   
   Dubbo java 3.2.12, Openjdk 1.8, idea 2024
   
   ### Steps to reproduce this issue
   
   
![微信截图_20240514181741](https://github.com/apache/dubbo/assets/18344122/c89f8737-d52e-4207-905d-c69d2bb81ecd)
   
![微信截图_20240514181757](https://github.com/apache/dubbo/assets/18344122/3c418a0c-de85-4f2d-82ac-839a5ee41f82)
   
![微信图片_20240514181611](https://github.com/apache/dubbo/assets/18344122/e2083752-87d9-4428-af7f-8831ff8628a9)
   
![微信图片_20240514181703](https://github.com/apache/dubbo/assets/18344122/7b0d37e3-2a53-4adc-902a-85969e1e2791)
   
   
   ### What you expected to happen
   
   I get some WARN info in console window, if the default value is true, the 
WARN info is unexpected.
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit a pull request to fix on your own?
   
   - [ ] Yes I am willing to submit a pull request on my own!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[PR] Ftr: supports interface exposure mode [dubbo-rust]

2024-05-14 Thread via GitHub


kwsc98 opened a new pull request, #196:
URL: https://github.com/apache/dubbo-rust/pull/196

   supports interface exposure mode
   
   ftr: supports interface exposure mode
   
   add: Add a dubco-macro package
   
   tst: Add a examples/interface Test
   
   fix: fix some bug


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [I] [Bug] override url with configurator from "service-name.configurators" in interface mode not as expected [dubbo]

2024-05-14 Thread via GitHub


laywin commented on issue #14185:
URL: https://github.com/apache/dubbo/issues/14185#issuecomment-2109731403

   currently, when update dynamic configuration in dubbo-admin,  the key is 
only serviceName, no group and version to be registered in registry center. so 
it can't be matched. temporarily, You can manually add group and version to the 
dynamic configuration to solve this problem. just like this:
   
   ```java
   
   configVersion: v2.7
   enabled: true
   configs:
 - side: consumer
   addresses:
 - 0.0.0.0
   parameters:
 timeout: 2900
 group: test
 version: 1.0.0
   ```
   
   I think it is best to modify the registration behavior of dubbo-admin.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] chore[docs]: Migration cmd dubboctl docs [dubbo-kubernetes]

2024-05-14 Thread via GitHub


mfordjody merged PR #280:
URL: https://github.com/apache/dubbo-kubernetes/pull/280


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



[PR] chore[docs]: Migration cmd dubboctl docs [dubbo-kubernetes]

2024-05-14 Thread via GitHub


mfordjody opened a new pull request, #280:
URL: https://github.com/apache/dubbo-kubernetes/pull/280

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] feat: Validator supports automatic switch [dubbo]

2024-05-14 Thread via GitHub


aofall commented on PR #13923:
URL: https://github.com/apache/dubbo/pull/13923#issuecomment-2109623323

   a demo
   
   
https://github.com/aofall/dubbo/tree/3.3-validation/dubbo-plugin/dubbo-filter-validation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-05-14 Thread via GitHub


walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599610701


##
dubbo-metrics/dubbo-metrics-config-center/pom.xml:
##
@@ -27,7 +27,7 @@
   
 
   org.apache.dubbo
-  dubbo-metrics-api
+  dubbo-metrics-core

Review Comment:
   Or should I keep the original 'dubbo-metrics-api' (even though it contains a 
lot of non-API classes) and name the new 'dubbo-metrics-api' something like 
'dubbo-metrics-client'? Looking forward to your suggestions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-05-14 Thread via GitHub


walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599606336


##
dubbo-metrics/dubbo-metrics-config-center/pom.xml:
##
@@ -27,7 +27,7 @@
   
 
   org.apache.dubbo
-  dubbo-metrics-api
+  dubbo-metrics-core

Review Comment:
   I think the current primary goal is to strip the dubbo project of its 
dependence on metrics and only retain its dependence on the api, so only a very 
small amount of content necessary for the dubbo project will be retained in the 
api. 
   In fact, I renamed the 'dubbo-metrics-api' package to 'dubbo-metrics-core' 
because it contains many classes that are not APIs, such as 
'CombMetricsCollector'. Then a new 'dubbo-metrics-api' was added for dubbo 
projects to integrate.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-05-14 Thread via GitHub


walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1599606336


##
dubbo-metrics/dubbo-metrics-config-center/pom.xml:
##
@@ -27,7 +27,7 @@
   
 
   org.apache.dubbo
-  dubbo-metrics-api
+  dubbo-metrics-core

Review Comment:
   I think the current primary goal is to strip the dubbo project of its 
dependence on metrics and only retain its dependence on the api, so only a very 
small amount of content necessary for the dubbo project will be retained in the 
api. 
   In fact, I renamed the 'dubbo-metrics-api' package to 'dubbo-metrics-core' 
because it contains many classes that are not APIs, such as 
'CombMetricsCollector'. Then a new 'dubbo-metrics-api' was added for dubbo 
project integration.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org