Re: [PR] Infinitelifetime [logging-log4cxx]
swebb2066 commented on PR #271:
URL: https://github.com/apache/logging-log4cxx/pull/271#issuecomment-1758816350
I suggest multithreadtest needs to use a layout to properly test this PR.
For example
```diff --git a/src/test/cpp/multithreadtest.cpp
b/src/test/cpp/multithreadtest.cpp
index 15ce4881..73042378 100644
--- a/src/test/cpp/multithreadtest.cpp
+++ b/src/test/cpp/multithreadtest.cpp
@@ -19,8 +19,8 @@
#include
#include
-#include
-#include
+#include
+#include
#include
#include
#include
@@ -29,23 +29,12 @@
using log4cxx::Logger;
using log4cxx::LoggerPtr;
using log4cxx::LogManager;
+using log4cxx::WriterAppender;
-class NullWriterAppender : public log4cxx::AppenderSkeleton
+class NullWriterAppender : public WriterAppender
{
public:
- NullWriterAppender() {}
-
- virtual void close() {}
-
- virtual bool requiresLayout() const
- {
- return false;
- }
-
- virtual void append(const log4cxx::spi::LoggingEventPtr&
event, log4cxx::helpers::Pool& p)
- {
- // Do nothing but discard the data
- }
+ NullWriterAppender() :
WriterAppender(std::make_shared()) {}
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.9 [logging-log4j-samples]
github-actions[bot] commented on PR #75: URL: https://github.com/apache/logging-log4j-samples/pull/75#issuecomment-1758739364 Changes are applied by CI in 795f3f2a00e98df938e624fd19a514f3a21deb82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.9 [logging-log4j-samples]
dependabot[bot] commented on PR #75: URL: https://github.com/apache/logging-log4j-samples/pull/75#issuecomment-1758739398 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.9 [logging-log4j-samples]
github-actions[bot] closed pull request #75: Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.9 URL: https://github.com/apache/logging-log4j-samples/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.9 [logging-log4j-samples]
dependabot[bot] opened a new pull request, #75: URL: https://github.com/apache/logging-log4j-samples/pull/75 Bumps org.slf4j:slf4j-api from 1.7.36 to 2.0.9. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Infinitelifetime [logging-log4cxx]
rm5248 commented on PR #271: URL: https://github.com/apache/logging-log4cxx/pull/271#issuecomment-1758684795 The segfault on crash is rather sporadic, you can run the following to stress it: ``` while [ 1 ]; do make test ARGS="-R multithreadtest"; if [ $? -ne 0 ]; then break; fi; done; ``` The testing that I have done does show that it works fine, without any memory leaks as I was expecting which is rather surprising to me. Some of the statics that are declared do have strings or maps in them, which do allocate memory internally, so I was expecting that memory to be leaked. I checked with both valgrind and lsan(with `-fsanitize=leak`). Perhaps it is not picking up on leaks that are caused by statically allocated memory. This looks good to me; if it fixes the "my program crashes because I'm logging after calling `exit()`" problem with no bad side effects it sounds good to me and could be something that we enable by default. Any thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.eclipse.jetty:jetty-bom from 9.4.52.v20230823 to 9.4.53.v20231009 (logging-log4j2)
ppkarwasz commented on PR #1852: URL: https://github.com/apache/logging-log4j2/pull/1852#issuecomment-1758213776 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.cassandra:cassandra-all from 3.11.16 to 4.0.10 in /log4j-parent (logging-log4j2)
ppkarwasz closed pull request #1858: Bump org.apache.cassandra:cassandra-all from 3.11.16 to 4.0.10 in /log4j-parent URL: https://github.com/apache/logging-log4j2/pull/1858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump io.netty:netty-bom from 4.1.97.Final to 4.1.100.Final (logging-log4j2)
ppkarwasz commented on PR #1857: URL: https://github.com/apache/logging-log4j2/pull/1857#issuecomment-1758212497 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for ZSTD Compression (logging-log4j2)
anuragagarwal561994 commented on PR #1514: URL: https://github.com/apache/logging-log4j2/pull/1514#issuecomment-1758017705 Thanks @vy can finally remove a tech debt from our projects :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Issue 1501: increase default StatusLogger level to warn (logging-log4j2)
lukaszspyra commented on PR #1592: URL: https://github.com/apache/logging-log4j2/pull/1592#issuecomment-1758014731 > I am not in favor of this. We should fix the original problem that a JSON or YAML configuration is found but dependencies are missing to log at error instead. Looking at the thread on dev, I believe majority did not like the idea of changing default StatusLogger level, so changes reverted and error logged as suggested (JSON/YAML ConfigurationFactory is not active and found corresponding config file). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] (doc) Missing taglib documentation (logging-log4j2)
vy commented on issue #1230: URL: https://github.com/apache/logging-log4j2/issues/1230#issuecomment-1757795435 The page is available under [https://logging.apache.org/log4j/2.x/log4j-taglib.html], which is linked from the menu. That should be good enough for this hardly ever used component, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for ZSTD Compression (logging-log4j2)
vy commented on PR #1514: URL: https://github.com/apache/logging-log4j2/pull/1514#issuecomment-1757782564 @anuragagarwal561994, I have merged this. Thanks for the contribution. This will be available in the `2.21.0` release that should come out sometime this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Zstd compression support (logging-log4j2)
vy closed issue #1508: Zstd compression support URL: https://github.com/apache/logging-log4j2/issues/1508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for ZSTD Compression (logging-log4j2)
vy merged PR #1514: URL: https://github.com/apache/logging-log4j2/pull/1514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Javadoc is broken (logging-log4j2)
vy commented on issue #1275: URL: https://github.com/apache/logging-log4j2/issues/1275#issuecomment-1757448766 Thanks to hard work of @lukaszspyra in #1753, the situation is improved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Javadoc is broken (logging-log4j2)
vy closed issue #1275: Javadoc is broken URL: https://github.com/apache/logging-log4j2/issues/1275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Issue 1275 broken javadoc (logging-log4j2)
vy merged PR #1753: URL: https://github.com/apache/logging-log4j2/pull/1753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Issue 1275 broken javadoc (logging-log4j2)
vy commented on PR #1753: URL: https://github.com/apache/logging-log4j2/pull/1753#issuecomment-1757399973 @lukaszspyra, you know what, nevermind. I will implement the requested changes myself. We are on a roll with `2.21.0` release and I want to get your changes in before we seal it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LOG4J2-3672) Avoid invoking DateFormatSymbols.getZoneStrings() in FastDateParser
[
https://issues.apache.org/jira/browse/LOG4J2-3672?focusedWorklogId=884445=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-884445
]
ASF GitHub Bot logged work on LOG4J2-3672:
--
Author: ASF GitHub Bot
Created on: 11/Oct/23 09:26
Start Date: 11/Oct/23 09:26
Worklog Time Spent: 10m
Work Description: tristantarrant commented on PR #1848:
URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1757250950
Hi @vy, I agree we need a better solution.
- avoid constructing that ridiculous regex with all the timezone names
anyway. A simple `[A-Za-z0-9\+\-/\s]+` should be enough
- if the user uses a `GMT-xx` or RFC822-style timezone, use the quick path
- if the user uses a _primary_ timezone name (e.g. `Europe/Rome`), use
`TimeZone.getTimeZone()`
- otherwise fallback to obtaining the full list of zone names and aliases.
Unfortunately there is no other way to look up timezones by alias... By using
the approach used in my PR we can save ~700K of heap over the use of
`DateFormatSymbols.getInstance(locale).getZoneStrings();` (as you can see from
the table I've put in the Jira)
Unfortunately this does not solve the bigger issue: if someone uses
`SimpleDateFormat` in their code, they are going to trigger the full JDK
caching of timezones, rendering our fix useless anyway.
A possibility, aside from fixing this in the JDK in some way, is to install
an alternate `ZoneRulesProvider` using the
`java.time.zone.DefaultZoneRulesProvider` system property. Such a provider
would avoid caching the full TZ dataset.
Issue Time Tracking
---
Worklog Id: (was: 884445)
Time Spent: 0.5h (was: 20m)
> Avoid invoking DateFormatSymbols.getZoneStrings() in FastDateParser
> ---
>
> Key: LOG4J2-3672
> URL: https://issues.apache.org/jira/browse/LOG4J2-3672
> Project: Log4j 2
> Issue Type: Bug
>Reporter: Tristan Tarrant
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {{FastDateParser}} uses {{DateFormatSymbols.getZoneStrings()}} to construct a
> table of all possible timezone names to be used in parsing date patterns in
> pattern layouts.
> Unfortunately the above call (and the equivalent call used by the JDK's
> {{SimpleDateFormat)}} causes initialization and caching of all timezones,
> resulting in a ~3MB heap overhead on x86_64. The following table summarizes
> the cost of triggering the caching of all timezones, including the number of
> instances of some related types and the amount of extra heap required.
>
> || ||LocalDateTime||LocalDate||ZoneInfo||ZoneOffset||Heap delta||
> |Baseline (no TZ calls)|180|0|0| | |
> |Single timezone|180|0|0|0|298|
> |DateFormatSymbols.getZoneStrings()|57076|32212|602|1455|3760106|
> |TimeZone.getAvailableIds() + TimeZone.getName()|36678|21674|632|1155|3024946|
> |TimeZone.getAvalableIDs()|180|0|632|0|452578|
> By avoiding constructions of such tables, and relying only on
> {{{}FastDateParser{}}}'s support for RFC-822 and GMT-style timezone names, we
> can avoid allocating the extra heap.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] LOG4J2-3672 Avoid invoking `DateFormatSymbols.getZoneStrings()` in `FastDateParser` (logging-log4j2)
tristantarrant commented on PR #1848: URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1757250950 Hi @vy, I agree we need a better solution. - avoid constructing that ridiculous regex with all the timezone names anyway. A simple `[A-Za-z0-9\+\-/\s]+` should be enough - if the user uses a `GMT-xx` or RFC822-style timezone, use the quick path - if the user uses a _primary_ timezone name (e.g. `Europe/Rome`), use `TimeZone.getTimeZone()` - otherwise fallback to obtaining the full list of zone names and aliases. Unfortunately there is no other way to look up timezones by alias... By using the approach used in my PR we can save ~700K of heap over the use of `DateFormatSymbols.getInstance(locale).getZoneStrings();` (as you can see from the table I've put in the Jira) Unfortunately this does not solve the bigger issue: if someone uses `SimpleDateFormat` in their code, they are going to trigger the full JDK caching of timezones, rendering our fix useless anyway. A possibility, aside from fixing this in the JDK in some way, is to install an alternate `ZoneRulesProvider` using the `java.time.zone.DefaultZoneRulesProvider` system property. Such a provider would avoid caching the full TZ dataset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump spring-boot.version from 2.7.15 to 2.7.16 [logging-log4j-samples]
dependabot[bot] commented on PR #70: URL: https://github.com/apache/logging-log4j-samples/pull/70#issuecomment-1757207571 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump spring-boot.version from 2.7.15 to 2.7.16 [logging-log4j-samples]
vy closed pull request #70: Bump spring-boot.version from 2.7.15 to 2.7.16 URL: https://github.com/apache/logging-log4j-samples/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for disruptor-4.0.0 (logging-log4j2)
ppkarwasz commented on PR #1856: URL: https://github.com/apache/logging-log4j2/pull/1856#issuecomment-1757166532 @Dreeam-qwq, Take your time. We won't be able to include this PR into `2.21.0` anyway, since the release process is already in motion. You can also resubmit this PR against the `main` branch, which is based on Java 11, so most of the problems disappear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Infinitelifetime [logging-log4cxx]
vopl commented on PR #271: URL: https://github.com/apache/logging-log4cxx/pull/271#issuecomment-1757159734 > Have you tried this with the multithread test enabled? The CMake option is ENABLE_MULTITHREAD_TEST. That test should provide a decent test to see if this actually changes anything. Yes, the test 'multithreadtest' passes with а LOG4CXX_INFINITELIFETIME=On option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump spring-boot.version from 2.7.15 to 2.7.16 [logging-log4j-samples]
vy commented on PR #70: URL: https://github.com/apache/logging-log4j-samples/pull/70#issuecomment-1757136096 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.16 to 10.0.17 [logging-log4j-samples]
dependabot[bot] commented on PR #74: URL: https://github.com/apache/logging-log4j-samples/pull/74#issuecomment-1757114640 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.16 to 10.0.17 [logging-log4j-samples]
github-actions[bot] closed pull request #74: Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.16 to 10.0.17 URL: https://github.com/apache/logging-log4j-samples/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.16 to 10.0.17 [logging-log4j-samples]
github-actions[bot] commented on PR #74: URL: https://github.com/apache/logging-log4j-samples/pull/74#issuecomment-1757114512 Changes are applied by CI in d94a0aeb48e9fea8256519ef527d47eaabd31cd1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.16 to 10.0.17 [logging-log4j-samples]
vy commented on PR #74: URL: https://github.com/apache/logging-log4j-samples/pull/74#issuecomment-1757100613 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump spring-boot.version from 2.7.15 to 2.7.16 [logging-log4j-samples]
vy commented on PR #70: URL: https://github.com/apache/logging-log4j-samples/pull/70#issuecomment-1757099151 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Request to expose certain protected APIs as public (logging-log4j2)
vy commented on issue #1365: URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1757095162 @garydgregory, I see the points you raise. We already expect users to implement `RolloverStrategy`s, which is a public interface. In *all* of our own implementations of `RolloverStrategy`, we reach out to `FileExtension` methods the user is requesting to expose. Hence, I find it fair that custom `RolloverStrategy`s should have access to those methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for disruptor-4.0.0 (logging-log4j2)
Dreeam-qwq closed pull request #1856: Support for disruptor-4.0.0 URL: https://github.com/apache/logging-log4j2/pull/1856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for disruptor-4.0.0 (logging-log4j2)
Dreeam-qwq commented on PR #1856: URL: https://github.com/apache/logging-log4j2/pull/1856#issuecomment-1757093891 I'm sorry that I have no enough time to do this recently, I'll close this pr, sorry to waste your time to review it, also thanks for you to give explanation to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Request to expose certain protected APIs as public (logging-log4j2)
vy closed issue #1365: Request to expose certain protected APIs as public URL: https://github.com/apache/logging-log4j2/issues/1365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Open `FileExtension` accessors (#1365) (logging-log4j2)
vy merged PR #1683: URL: https://github.com/apache/logging-log4j2/pull/1683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Open `FileExtension` accessors (#1365) (logging-log4j2)
vy commented on PR #1683: URL: https://github.com/apache/logging-log4j2/pull/1683#issuecomment-1757031463 @Karthi1711, I am fine with these changes; except the `length()`. Let's keep the opened up methods to minimum: `createCompressAction()` and `getExtension()` are fine, but we don't need `length()`, which is accessible by `getExtension().length()` anyway. I will 1. merge the changes 2. make `length()` package-private again 3. add a changelog entry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]
github-actions[bot] commented on PR #73: URL: https://github.com/apache/logging-log4j-samples/pull/73#issuecomment-1757005932 Changes are applied by CI in cedcc932e3181a4f4a8b9664d382b3d71516f123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]
dependabot[bot] commented on PR #73: URL: https://github.com/apache/logging-log4j-samples/pull/73#issuecomment-1757005992 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]
github-actions[bot] closed pull request #73: Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre URL: https://github.com/apache/logging-log4j-samples/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (LOG4J2-3595) Supporting disruptor 4.x
[ https://issues.apache.org/jira/browse/LOG4J2-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz resolved LOG4J2-3595. --- Resolution: Duplicate Issue moved to [Github Issues|https://github.com/apache/logging-log4j2/issues/1829]. > Supporting disruptor 4.x > - > > Key: LOG4J2-3595 > URL: https://issues.apache.org/jira/browse/LOG4J2-3595 > Project: Log4j 2 > Issue Type: New Feature >Reporter: Rohitdev >Priority: Major > > I'm using disruptor 4.x RC release for a project i'm working on. Using jdk 11 > and above. > I'm unable to use it with log4j2 asynclogger as due to API changes in > disruptor 4.x log4j is broken.I cant use older version of disruptor in my > code. as its a primary project dependency. > > I get the following stacktrace > java.lang.NoClassDefFoundError: > com/lmax/disruptor/SequenceReportingEventHandler > at java.base/java.lang.ClassLoader.defineClass1(Native Method) > at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012) > at > java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150) > at > java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862) > at > java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760) > at > java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681) > at > java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639) > at > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) > at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520) > at > org.apache.logging.log4j.core.async.AsyncLoggerConfigDisruptor.start(AsyncLoggerConfigDisruptor.java:226) > at > org.apache.logging.log4j.core.config.AbstractConfiguration.start(AbstractConfiguration.java:311) > at > org.apache.logging.log4j.core.LoggerContext.setConfiguration(LoggerContext.java:621) > at > org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:694) > at > org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:711) > at > org.apache.logging.log4j.core.LoggerContext.start(LoggerContext.java:253) > at > org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:155) > at > org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:47) > at org.apache.logging.log4j.LogManager.getContext(LogManager.java:196) > at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:599) > at > tests.ut.pipeline.app.ingestionmgr.IngestionPipelineBuilderTests.(IngestionPipelineBuilderTests.java:10) > at > java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native > Method) > at > java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) > at > java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at > java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) > at > java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480) > at > org.junit.platform.commons.util.ReflectionUtils.newInstance(ReflectionUtils.java:550) > at > org.junit.jupiter.engine.execution.ConstructorInvocation.proceed(ConstructorInvocation.java:56) > at > org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131) > at > org.junit.jupiter.api.extension.InvocationInterceptor.interceptTestClassConstructor(InvocationInterceptor.java:73) > at > org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105) > at > org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106) > at > org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64) > at > org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45) > at > org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37) > at > org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104) > at > org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:77) > at > org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeTestClassConstructor(ClassBasedTestDescriptor.java:355) > at >
Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]
vy commented on PR #73: URL: https://github.com/apache/logging-log4j-samples/pull/73#issuecomment-1756995018 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]
dependabot[bot] commented on PR #73: URL: https://github.com/apache/logging-log4j-samples/pull/73#issuecomment-1756989701 Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]
vy commented on PR #73: URL: https://github.com/apache/logging-log4j-samples/pull/73#issuecomment-1756989627 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Spotbugs alerts up to rank 9 (logging-log4j2)
ppkarwasz merged PR #1855: URL: https://github.com/apache/logging-log4j2/pull/1855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for disruptor-4.0.0 (logging-log4j2)
ppkarwasz commented on PR #1856: URL: https://github.com/apache/logging-log4j2/pull/1856#issuecomment-1756963010 Closes #1829 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for disruptor-4.0.0 (logging-log4j2)
ppkarwasz commented on PR #1856:
URL: https://github.com/apache/logging-log4j2/pull/1856#issuecomment-1756951260
@Dreeam-qwq,
All 2.x releases must run on JDK 8. Since Disruptor 4.x requires a Java 11
runtime, we can not drop support for Disruptor 3.x.
Looking at your patch, the only breaking change that occurred is the
disappearance of the `SequenceReportingEventHandler` and `LifecycleAware`
interfaces, so you can work around these restrictions by:
- restoring version `3.4.4` in the POM file,
- removing the `@Override` annotations from the new `EventHandler` methods,
- create a `RingBufferLogEventHandler3` and
`AsyncLoggerConfigDisruptor#Log4jEventWrapperHandler3` classes that extend
their v4 counterparts and differ just in the `implements` clause:
```java
public class RingBufferLogEventHandler3 extends RingBufferLogEventHandler
implements SequenceReportingEventHandler,
LifecycleAware {}
```
- add logic to switch between `RingBufferLogEventHandler3` and
`RingBufferLogEventHandler` based on the existence of the
`SequenceReportingEventHandler` interface.
- add some logic to switch between our `TimeoutBlockingWaitStrategy` and
the one shipped with Disruptor 4.x.
To test the PR run:
```
./mvnw install -pl log4j-core
```
followed by:
```
./mvnw verify -Pjava8-tests -Dtest="org/apache/logging/log4j/core/async/*"
```
to test on JDK 8 (you need a Maven toolchains configuration) and Disruptor
3.x and
```
./mvnw verify -Dtest="org/apache/logging/log4j/core/async/*"
-Ddisruptor.version=4.0.0
```
to test on JDK 11 and Disruptor 4.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
