[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3906: Make the shadow feature more complete
coveralls edited a comment on issue #3906: Make the shadow feature more complete URL: https://github.com/apache/incubator-shardingsphere/pull/3906#issuecomment-572079585 ## Pull Request Test Coverage Report for [Build 1333](https://coveralls.io/builds/28022288) * **13** of **30** **(43.33%)** changed or added relevant lines in **5** files are covered. * **136** unchanged lines in **12** files lost coverage. * Overall coverage increased (+**0.4%**) to **66.094%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/condition/ShadowCondition.java](https://coveralls.io/builds/28022288/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Fcondition%2FShadowCondition.java#L61) | 2 | 3 | 66.67% | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShadowStatement.java](https://coveralls.io/builds/28022288/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShadowStatement.java#L238) | 6 | 8 | 75.0% | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShadowPreparedStatement.java](https://coveralls.io/builds/28022288/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShadowPreparedStatement.java#L282) | 4 | 9 | 44.44% | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/connection/ShadowConnection.java](https://coveralls.io/builds/28022288/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fconnection%2FShadowConnection.java#L104) | 0 | 9 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/parameter/impl/EncryptInsertOnDuplicateKeyUpdateValueParameterRewriter.java](https://coveralls.io/builds/28022288/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fparameter%2Fimpl%2FEncryptInsertOnDuplicateKeyUpdateValueParameterRewriter.java#L58) | 1 | 95.65% | | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/PreparedStatementRoutingEngine.java](https://coveralls.io/builds/28022288/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Froute%2FPreparedStatementRoutingEngine.java#L58) | 2 | 80.0% | | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/StatementRoutingEngine.java](https://coveralls.io/builds/28022288/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Froute%2FStatementRoutingEngine.java#L55) | 2 | 77.78% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/insert/OnDuplicateKeyColumnsExtractor.java](https://coveralls.io/builds/28022288/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Finsert%2FOnDuplicateKeyColumnsExtractor.java#L50) | 3 | 16.67% | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/response/query/QueryHeader.java](https://coveralls.io/builds/28022288/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fresponse%2Fquery%2FQueryHeader.java#L79) | 4 | 73.08% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java](https://coveralls.io/builds/28022288/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingPreparedStatement.java#L254) | 5 | 84.48% | | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/router/sharding/ShardingRouter.java](https://coveralls.io/builds/28022288/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Froute%2Frouter%2Fsharding%2FShardingRouter.java#L64) | 8 | 88.57% | |
[GitHub] [incubator-shardingsphere-doc] tianbin1001 closed pull request #420: add sql parser document
tianbin1001 closed pull request #420: add sql parser document URL: https://github.com/apache/incubator-shardingsphere-doc/pull/420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request #3928: fixed for #2997. Use guave cache instead of AbstractHashedMap
xiyelife opened a new pull request #3928: fixed for #2997. Use guave cache instead of AbstractHashedMap URL: https://github.com/apache/incubator-shardingsphere/pull/3928 Fixes #2997. Changes proposed in this pull request: - Use guave soft reference cache instead of AbstractHashedMap - initialCapacity 2000 - maximumSize 65535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #3926: add SQLVisitorEngine.java
dongzl merged pull request #3926: add SQLVisitorEngine.java URL: https://github.com/apache/incubator-shardingsphere/pull/3926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy commented on a change in pull request #3906: Make the shadow feature more complete
yanyzy commented on a change in pull request #3906: Make the shadow feature
more complete
URL:
https://github.com/apache/incubator-shardingsphere/pull/3906#discussion_r365095228
##
File path:
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/connection/ShadowConnection.java
##
@@ -93,13 +102,14 @@ public PreparedStatement prepareStatement(final String
sql, final String[] colum
@Override
public void setAutoCommit(final boolean autoCommit) throws SQLException {
+this.autoCommit = autoCommit;
actualConnection.setAutoCommit(autoCommit);
shadowConnection.setAutoCommit(autoCommit);
}
@Override
public boolean getAutoCommit() {
-return false;
+return autoCommit;
Review comment:
getAutoCommit()、isClosed()、isReadOnly() extends from Connection interface ,
can not use
lombok's @getter to instead of them.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] longjy opened a new issue #3927: Whether the database field desensitization logic can only process the SQL of the specified encrypted table without disturbing the n
longjy opened a new issue #3927: Whether the database field desensitization logic can only process the SQL of the specified encrypted table without disturbing the normal operation of other SQL URL: https://github.com/apache/incubator-shardingsphere/issues/3927 Whether the database field desensitization logic can only process the SQL of the specified encrypted table without disturbing the normal operation of other SQL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #3926: add SQLVisitorEngine.java
tristaZero opened a new pull request #3926: add SQLVisitorEngine.java URL: https://github.com/apache/incubator-shardingsphere/pull/3926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #3902: Remove old orchestration module.
dongzl merged pull request #3902: Remove old orchestration module. URL: https://github.com/apache/incubator-shardingsphere/pull/3902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #3923: add SQLVisitor interface
dongzl merged pull request #3923: add SQLVisitor interface URL: https://github.com/apache/incubator-shardingsphere/pull/3923 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] minghu-zhang opened a new pull request #3925: Itrus bug fix
minghu-zhang opened a new pull request #3925: Itrus bug fix URL: https://github.com/apache/incubator-shardingsphere/pull/3925 Fixes #3924. Changes proposed in this pull request: - org.apache.shardingsphere.encrypt.strategy.impl.AESEncryptor - org.apache.shardingsphere.encrypt.strategy.impl.MD5Encryptor - org.apache.shardingsphere.underlying.common.util.StringUtil This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] minghu-zhang opened a new issue #3924: the method get a 'null' string value when the encryption field value is null.
minghu-zhang opened a new issue #3924: the method get a 'null' string value when the encryption field value is null. URL: https://github.com/apache/incubator-shardingsphere/issues/3924 the method get a 'null' string value when the encryption field value is null. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao opened a new issue #3922: Optimize model of ColumnMetaData
cherrylzhao opened a new issue #3922: Optimize model of ColumnMetaData
URL: https://github.com/apache/incubator-shardingsphere/issues/3922
currently our ColumnMetaData defined in this way
```
public class ColumnMetaData {
private final String name;
private final String dataType;
private final boolean primaryKey;
private final boolean notNull;
private final boolean autoIncrement;
}
```
but `Sharding-Proxy` need entire meta to support database protocol, so we
get others from underlying resultSetMetaData in this way
```
columnLabel = resultSetMetaData.getColumnLabel(columnIndex);
columnName = resultSetMetaData.getColumnName(columnIndex);
columnLength = resultSetMetaData.getColumnDisplaySize(columnIndex);
columnType = resultSetMetaData.getColumnType(columnIndex);
decimals = resultSetMetaData.getScale(columnIndex);
signed = resultSetMetaData.isSigned(columnIndex);
notNull = resultSetMetaData.isNullable(columnIndex) ==
ResultSetMetaData.columnNoNulls;
autoIncrement = resultSetMetaData.isAutoIncrement(columnIndex);
```
consider about enhancing metadata like this
1. adding these missing meta field into `ColumnMetaData`, only maintain it
in `TableMetaDataLoader`
2. for `sharding-proxy` should provide a way to get logicTableName of
ResultSetMetaData Column
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #3921: Add MasterSlaveDataSourceRouter
tristaZero merged pull request #3921: Add MasterSlaveDataSourceRouter URL: https://github.com/apache/incubator-shardingsphere/pull/3921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3921: Update CODE_OF_CONDUCT
terrymanu opened a new pull request #3921: Update CODE_OF_CONDUCT URL: https://github.com/apache/incubator-shardingsphere/pull/3921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed pull request #3921: Update CODE_OF_CONDUCT
terrymanu closed pull request #3921: Update CODE_OF_CONDUCT URL: https://github.com/apache/incubator-shardingsphere/pull/3921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3921: Update CODE_OF_CONDUCT
terrymanu commented on issue #3921: Update CODE_OF_CONDUCT URL: https://github.com/apache/incubator-shardingsphere/pull/3921#issuecomment-572867677 Invalid This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3921: Update CODE_OF_CONDUCT
terrymanu opened a new pull request #3921: Update CODE_OF_CONDUCT URL: https://github.com/apache/incubator-shardingsphere/pull/3921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #426: year of notice file
terrymanu merged pull request #426: year of notice file URL: https://github.com/apache/incubator-shardingsphere-doc/pull/426 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao closed pull request #3920: Revert "QueryHeader load logic table metadata"
cherrylzhao closed pull request #3920: Revert "QueryHeader load logic table metadata" URL: https://github.com/apache/incubator-shardingsphere/pull/3920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request #3920: Revert "QueryHeader load logic table metadata"
cherrylzhao opened a new pull request #3920: Revert "QueryHeader load logic table metadata" URL: https://github.com/apache/incubator-shardingsphere/pull/3920 Reverts apache/incubator-shardingsphere#3918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao merged pull request #3918: QueryHeader load logic table metadata
cherrylzhao merged pull request #3918: QueryHeader load logic table metadata URL: https://github.com/apache/incubator-shardingsphere/pull/3918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao closed issue #3905: proxy select table throw NullPointerException!
cherrylzhao closed issue #3905: proxy select table throw NullPointerException! URL: https://github.com/apache/incubator-shardingsphere/issues/3905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3917: Add support for Literal and Parameter encrypt for insert into ... on …
terrymanu merged pull request #3917: Add support for Literal and Parameter encrypt for insert into ... on … URL: https://github.com/apache/incubator-shardingsphere/pull/3917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3918: QueryHeader load logic table metadata
coveralls edited a comment on issue #3918: QueryHeader load logic table metadata URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572603130 ## Pull Request Test Coverage Report for [Build 1327](https://coveralls.io/builds/28019681) * **16** of **18** **(88.89%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.004%**) to **65.715%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/response/query/QueryHeader.java](https://coveralls.io/builds/28019681/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fresponse%2Fquery%2FQueryHeader.java#L79) | 16 | 18 | 88.89% | Totals | [](https://coveralls.io/builds/28019681) | | :-- | --: | | Change from base [Build 663](https://coveralls.io/builds/28000463): | 0.004% | | Covered Lines: | 10726 | | Relevant Lines: | 16322 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-example] gshkb opened a new issue #206: not found jars
gshkb opened a new issue #206: not found jars URL: https://github.com/apache/incubator-shardingsphere-example/issues/206 ## not found jars I'm chinese。 use idea。 **start ** Cannot resolve org.apache.shardingsphere:sharding-core-api:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-spring-boot-starter:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-orchestration-reg-zookeeper-curator:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-core:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-transaction-xa-core:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-orchestration-spring-namespace:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-orchestration-spring-boot-starter:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-spring-namespace:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-orchestration-reg-nacos:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-transaction-base-seata-at:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere.example:config-utility:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-orchestration:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-core-api:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-spring-boot-starter:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-orchestration-reg-zookeeper-curator:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-core:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-transaction-xa-core:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-orchestration-spring-namespace:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-orchestration-spring-boot-starter:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-spring-namespace:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-orchestration-reg-nacos:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-transaction-base-seata-at:4.0.0-RC4-SNAPSHOT Cannot resolve org.apache.shardingsphere:sharding-jdbc-orchestration:4.0.0-RC4-SNAPSHOT **close it**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-example] gshkb commented on issue #193: Sharding-jdbc4.0-RC2 and seata0.8.1 integration reported the following error
gshkb commented on issue #193: Sharding-jdbc4.0-RC2 and seata0.8.1 integration reported the following error URL: https://github.com/apache/incubator-shardingsphere-example/issues/193#issuecomment-572838456  not found jars。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #3918: QueryHeader load logic table metadata
dongzl commented on issue #3918: QueryHeader load logic table metadata URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572830814 The `QueryHeader`'s primarykey info is for this issue #3005 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository. zhaoyanan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new aab7f29 for performance aab7f29 is described below commit aab7f29d9f72bfec429fa2999aa775780d28a146 Author: nancyzrh AuthorDate: Fri Jan 10 09:02:57 2020 +0800 for performance --- report/data/3.0_single_delete_merge.log_plot| 1 + report/data/3.0_single_insert_merge.log_plot| 1 + report/data/3.0_single_select_merge.log_plot| 1 + report/data/3.0_single_update_merge.log_plot| 1 + report/data/3.0_sp_delete_raw_merge.log_plot| 1 + report/data/3.0_sp_insert_raw_merge.log_plot| 1 + report/data/3.0_sp_select_raw_merge.log_plot| 1 + report/data/3.0_sp_update_raw_merge.log_plot| 1 + report/data/4.0_single_delete_merge.log_plot| 1 + report/data/4.0_single_insert_merge.log_plot| 1 + report/data/4.0_single_update_merge.log_plot| 1 + report/data/4.0_sp_delete_raw_merge.log_plot| 1 + report/data/4.0_sp_insert_raw_merge.log_plot| 1 + report/data/4.0_sp_update_raw_merge.log_plot| 1 + report/data/direct_delete_merge.log_plot| 1 + report/data/direct_update_merge.log_plot| 1 + report/data/encrypt/4.0_sp_delete_enc.log_plot | 1 + report/data/encrypt/4.0_sp_delete_enc_sharding.log_plot | 1 + report/data/encrypt/4.0_sp_insert_enc.log_plot | 1 + report/data/encrypt/4.0_sp_insert_enc_sharding.log_plot | 1 + report/data/encrypt/4.0_sp_update_enc.log_plot | 1 + report/data/encrypt/4.0_sp_update_enc_sharding.log_plot | 1 + report/data/jdbc/3.0_sj_ms_delete.log_plot | 1 + report/data/jdbc/3.0_sj_ms_insert.log_plot | 1 + report/data/jdbc/3.0_sj_ms_select.log_plot | 1 + report/data/jdbc/3.0_sj_ms_sharding_delete.log_plot | 1 + report/data/jdbc/3.0_sj_ms_sharding_insert.log_plot | 1 + report/data/jdbc/3.0_sj_ms_sharding_update.log_plot | 1 + report/data/jdbc/3.0_sj_sharding_delete.log_plot| 1 + report/data/jdbc/3.0_sj_sharding_insert.log_plot| 1 + report/data/jdbc/3.0_sj_sharding_update.log_plot| 1 + report/data/jdbc/4.0_sj_delete_raw.log_plot | 1 + report/data/jdbc/4.0_sj_enc_delete.log_plot | 1 + report/data/jdbc/4.0_sj_enc_delete_sharding.log_plot| 1 + report/data/jdbc/4.0_sj_enc_insert.log_plot | 1 + report/data/jdbc/4.0_sj_enc_insert_sharding.log_plot| 1 + report/data/jdbc/4.0_sj_enc_update.log_plot | 1 + report/data/jdbc/4.0_sj_enc_update_sharding.log_plot| 1 + report/data/jdbc/4.0_sj_insert_raw.log_plot | 1 + report/data/jdbc/4.0_sj_ms_delete.log_plot | 1 + report/data/jdbc/4.0_sj_ms_insert.log_plot | 1 + report/data/jdbc/4.0_sj_ms_sharding_delete.log_plot | 1 + report/data/jdbc/4.0_sj_ms_sharding_insert.log_plot | 1 + report/data/jdbc/4.0_sj_ms_sharding_update.log_plot | 1 + report/data/jdbc/4.0_sj_ms_update.log_plot | 1 + report/data/jdbc/4.0_sj_sharding_delete.log_plot| 1 + report/data/jdbc/4.0_sj_sharding_insert.log_plot| 1 + report/data/jdbc/4.0_sj_sharding_update.log_plot| 1 + report/data/jdbc/4.0_sj_update_raw.log_plot | 1 + report/data/master_slave/3.0_sp_delete_ms.log_plot | 1 + report/data/master_slave/3.0_sp_delete_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_insert_ms.log_plot | 1 + report/data/master_slave/3.0_sp_insert_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_select_ms.log_plot | 1 + report/data/master_slave/3.0_sp_select_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_update_ms.log_plot | 1 + report/data/master_slave/3.0_sp_update_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_delete_ms.log_plot | 1 + report/data/master_slave/4.0_sp_delete_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_insert_ms.log_plot | 1 + report/data/master_slave/4.0_sp_insert_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_update_ms.log_plot | 1 + report/data/master_slave/4.0_sp_update_ms_sharding.log_plot | 1 + report/jtl_json/full_route_test.json| 2 +- report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +- report/jtl_json/master_slave_test.json | 2 +- report/jtl_json/single_route_test.json | 2 +- 67 files changed, 67
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3918: QueryHeader load logic table metadata
coveralls edited a comment on issue #3918: QueryHeader load logic table metadata URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572603130 ## Pull Request Test Coverage Report for [Build 1323](https://coveralls.io/builds/28009995) * **15** of **17** **(88.24%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.002%**) to **65.713%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/response/query/QueryHeader.java](https://coveralls.io/builds/28009995/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fresponse%2Fquery%2FQueryHeader.java#L77) | 15 | 17 | 88.24% | Totals | [](https://coveralls.io/builds/28009995) | | :-- | --: | | Change from base [Build 663](https://coveralls.io/builds/28000463): | 0.002% | | Covered Lines: | 10725 | | Relevant Lines: | 16321 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3918: QueryHeader load logic table metadata
coveralls edited a comment on issue #3918: QueryHeader load logic table metadata URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572603130 ## Pull Request Test Coverage Report for [Build 1322](https://coveralls.io/builds/28009501) * **15** of **17** **(88.24%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.002%**) to **65.713%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/response/query/QueryHeader.java](https://coveralls.io/builds/28009501/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fresponse%2Fquery%2FQueryHeader.java#L77) | 15 | 17 | 88.24% | Totals | [](https://coveralls.io/builds/28009501) | | :-- | --: | | Change from base [Build 663](https://coveralls.io/builds/28000463): | 0.002% | | Covered Lines: | 10725 | | Relevant Lines: | 16321 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2997: cpu load 100% when using sqlstatement cache
terrymanu commented on issue #2997: cpu load 100% when using sqlstatement cache URL: https://github.com/apache/incubator-shardingsphere/issues/2997#issuecomment-572629943 @xiyelife Thank you, I just assign this issue to you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] erstens opened a new issue #2997: cpu load 100% when using sqlstatement cache
erstens opened a new issue #2997: cpu load 100% when using sqlstatement cache URL: https://github.com/apache/incubator-shardingsphere/issues/2997 **jstack** `"DubboServerHandler-172.16.42.151:9503-thread-483" #734 daemon prio=5 os_prio=0 tid=0x7f36bc17e000 nid=0x4c92 runnable [0x7f36465c1000] java.lang.Thread.State: RUNNABLE at org.apache.commons.collections4.map.AbstractHashedMap.getEntry(AbstractHashedMap.java:461) at org.apache.commons.collections4.map.AbstractReferenceMap.getEntry(AbstractReferenceMap.java:427) at org.apache.commons.collections4.map.AbstractReferenceMap.get(AbstractReferenceMap.java:244) at org.apache.shardingsphere.core.parse.cache.ParsingResultCache.getSQLStatement(ParsingResultCache.java:53) at org.apache.shardingsphere.core.parse.SQLParsingEngine.getSQLStatementFromCache(SQLParsingEngine.java:69) at org.apache.shardingsphere.core.parse.SQLParsingEngine.parse(SQLParsingEngine.java:56) at org.apache.shardingsphere.core.route.router.sharding.ParsingSQLRouter.parse(ParsingSQLRouter.java:78) at org.apache.shardingsphere.core.route.PreparedStatementRoutingEngine.route(PreparedStatementRoutingEngine.java:64) at org.apache.shardingsphere.core.PreparedQueryShardingEngine.route(PreparedQueryShardingEngine.java:60) at org.apache.shardingsphere.core.BaseShardingEngine.shard(BaseShardingEngine.java:64) at org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.ShardingPreparedStatement.shard(ShardingPreparedStatement.java:224) at org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.ShardingPreparedStatement.executeQuery(ShardingPreparedStatement.java:109) at org.springframework.jdbc.core.JdbcTemplate$1.doInPreparedStatement(JdbcTemplate.java:692) ... at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:684) at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:716) at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:726) at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:776) . ` **top threads** PID USER PR NIVIRTRESSHR S %CPU %MEM TIME+ COMMAND 19602 root 20 0 8773700 2.766g 23436 R 94.1 17.8 8:29.27 java 19617 root 20 0 8773700 2.766g 23436 R 88.2 17.8 18:27.23 java 19606 root 20 0 8773700 2.766g 23436 R 47.1 17.8 12:36.25 java 19611 root 20 0 8773700 2.766g 23436 R 41.2 17.8 7:58.80 java 19608 root 20 0 8773700 2.766g 23436 R 29.4 17.8 24:20.39 java 19612 root 20 0 8773700 2.766g 23436 R 29.4 17.8 31:49.70 java 19601 root 20 0 8773700 2.766g 23436 R 23.5 17.8 0:00.82 java **version** ` org.apache.shardingsphere sharding-jdbc-core 4.0.0-RC1 ` please help me ,thanks all . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife edited a comment on issue #2997: cpu load 100% when using sqlstatement cache
xiyelife edited a comment on issue #2997: cpu load 100% when using sqlstatement cache URL: https://github.com/apache/incubator-shardingsphere/issues/2997#issuecomment-572629017 I have the same problem, and plan to use guave cache instead of AbstractHashedMap，please reopen it and assign it to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #2997: cpu load 100% when using sqlstatement cache
xiyelife commented on issue #2997: cpu load 100% when using sqlstatement cache URL: https://github.com/apache/incubator-shardingsphere/issues/2997#issuecomment-572629017 I have the same problem, and plan to use guave cache instead of AbstractHashedMap This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3900: sql bug
terrymanu commented on issue #3900: sql bug URL: https://github.com/apache/incubator-shardingsphere/issues/3900#issuecomment-572608811 Hi, what is the reason to close this issue, did you solve the issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3893: Need spring xml configuration of hint strategy sample
terrymanu commented on issue #3893: Need spring xml configuration of hint strategy sample URL: https://github.com/apache/incubator-shardingsphere/issues/3893#issuecomment-572607994 @affiliate Hi, have you create the issue on example repo? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #3691: Pluggable platform of ShardingSphere
terrymanu opened a new issue #3691: Pluggable platform of ShardingSphere URL: https://github.com/apache/incubator-shardingsphere/issues/3691 I'd like to establish a pluggable platform of ShardingSphere. The proposal of pluggable platform is decoupling all features and technical implementations. I plan split all features from sharding-core first, and then use SPI to introduce features into the pluggable platform(same thing with sharding, sharding can be remove from main process too). The pluggable platform is a blank JDBC and database protocol finally, and provide assist technical features such as SQL parser and SQL rewrite. More background can reference: https://lists.apache.org/thread.html/9d00ada223b9f058c69e39173181219c00fa019c913b07f97b0e%40%3Cdev.shardingsphere.apache.org%3E - [x] Create encrypt-core project - [ ] Create master-slave-core project - [ ] Refactor orchestration module can work independently - [ ] Refactor transaction module can work independently - [ ] Corporate with all features together - [ ] Use SPI to introduce all features - [ ] Redesign configuration - [ ] Redesign java configuration - [ ] Redesign yaml configuration - [ ] Redesign spring namespace - [ ] Redesign spring boot starter This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3918: Alter table metadata refresh logic and actual table metadata
terrymanu commented on issue #3918: Alter table metadata refresh logic and actual table metadata URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572603898 We need to make sure first, the key of table meta should be `logic table`, not `actual table`, is it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3918: Alter table metadata refresh logic and actual table metadata
coveralls commented on issue #3918: Alter table metadata refresh logic and actual table metadata URL: https://github.com/apache/incubator-shardingsphere/pull/3918#issuecomment-572603130 ## Pull Request Test Coverage Report for [Build 1313](https://coveralls.io/builds/28005607) * **0** of **10** **(0.0%)** changed or added relevant lines in **2** files are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage decreased (**-0.04%**) to **65.675%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/28005607/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L149) | 0 | 3 | 0.0% | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java](https://coveralls.io/builds/28005607/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FShardingRule.java#L407) | 0 | 7 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/28005607/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L152) | 1 | 0.0% | | Totals | [](https://coveralls.io/builds/28005607) | | :-- | --: | | Change from base [Build 663](https://coveralls.io/builds/28000463): | -0.04% | | Covered Lines: | 10726 | | Relevant Lines: | 16332 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] 852675742 commented on issue #527: 动态增加数据源支持吗？
852675742 commented on issue #527: 动态增加数据源支持吗？ URL: https://github.com/apache/incubator-shardingsphere/issues/527#issuecomment-572592136 请问具体在哪个章节或者example? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] 852675742 opened a new issue #3919: config datasource dynamic by program or outside order？
852675742 opened a new issue #3919: config datasource dynamic by program or outside order？ URL: https://github.com/apache/incubator-shardingsphere/issues/3919 ## Question **For English only**, other languages will not accept. I have the question,now because our datasource config is dead write in config yaml file,can program dynamic config the datasource by listener outside order？ Before asking a question, make sure you have: - Googled your question. - Searched open and closed [GitHub issues](https://github.com/apache/incubator-shardingsphere/issues). - Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview). Please pay attention on issues you submitted, because we maybe need more details. If no response **more than 7 days** and we cannot reproduce it on current information, we will **close it**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] 852675742 commented on issue #3180: Method of dynamically adding data sources
852675742 commented on issue #3180: Method of dynamically adding data sources URL: https://github.com/apache/incubator-shardingsphere/issues/3180#issuecomment-572590966 i have the same question,now because our datasource config is dead write in config yaml file,can program dynamic config the datasource by listener outside order？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request #3918: Alter table metadata refresh logic and actual table metadata
SteNicholas opened a new pull request #3918: Alter table metadata refresh logic and actual table metadata URL: https://github.com/apache/incubator-shardingsphere/pull/3918 Fixes #3905. `ShardingSchema` executes `AlterTableStatement` with logic table metadata refresh, but acutal table metadata doesn't refresh. This cause than after executing alter table add column operation, the operation for proxy that select * from table exists actual table metadata inconsistency. Changes proposed in this pull request: - Modify method `refreshTableMetaDataForAlterTable` of `ShardingSchema` to refresh logic and actual table metadata. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas removed a comment on issue #3905: proxy select table throw NullPointerException!
SteNicholas removed a comment on issue #3905: proxy select table throw NullPointerException! URL: https://github.com/apache/incubator-shardingsphere/issues/3905#issuecomment-572359907 @wangjing112 Could u please provider your configuration? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas removed a comment on issue #3905: proxy select table throw NullPointerException!
SteNicholas removed a comment on issue #3905: proxy select table throw NullPointerException! URL: https://github.com/apache/incubator-shardingsphere/issues/3905#issuecomment-572426322 > i found when alter table add columu varchar then throw exception on select the table. > but restart proxy service,is work fine! Please provide your sharding-sphere version and configuration. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request #3917: Add support for Literal and Parameter encrypt for insert into ... on …
xiyelife opened a new pull request #3917: Add support for Literal and Parameter encrypt for insert into ... on … URL: https://github.com/apache/incubator-shardingsphere/pull/3917 Changes proposed in this pull request: - Add support for Literal and Parameter encrypt for insert into ... on key update ... - - This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3902: Remove old orchestration module.
sunbufu commented on issue #3902: Remove old orchestration module. URL: https://github.com/apache/incubator-shardingsphere/pull/3902#issuecomment-572548249 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3915: Add interface for antlr visitors
terrymanu merged pull request #3915: Add interface for antlr visitors URL: https://github.com/apache/incubator-shardingsphere/pull/3915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new issue #3916: SQL should not be cached if it does not contain a question mark
tuohai666 opened a new issue #3916: SQL should not be cached if it does not contain a question mark URL: https://github.com/apache/incubator-shardingsphere/issues/3916 For now, SQLs will be cached when use a PreparedStatement regardless of the question mark. This may lead to all SQLs of a service be cached and performance declined. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #3915: Parser1
tristaZero commented on a change in pull request #3915: Parser1 URL: https://github.com/apache/incubator-shardingsphere/pull/3915#discussion_r364700488 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/pom.xml ## @@ -49,8 +49,8 @@ antlr src/main/antlr4/imports/mysql/ -false -false +true Review comment: Listeners are used for checking later and not necessary now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull request #3902: Remove old orchestration module.
wgy8283335 commented on a change in pull request #3902: Remove old
orchestration module.
URL:
https://github.com/apache/incubator-shardingsphere/pull/3902#discussion_r364685966
##
File path: sharding-distribution/shardingsphere-src-distribution/pom.xml
##
@@ -179,17 +179,27 @@
org.apache.shardingsphere
-sharding-orchestration-core
+sharding-orchestration-core-new
${project.version}
org.apache.shardingsphere
-sharding-orchestration-reg-api
+sharding-orchestration-center-api
Review comment:
Why not use
sharding-orchestration-center
It includes :
sharding-orchestration-center-api
sharding-orchestration-center-apollo
sharding-orchestration-center-zookeeper-curator
sharding-orchestration-center-nacos
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull request #3902: Remove old orchestration module.
wgy8283335 commented on a change in pull request #3902: Remove old
orchestration module.
URL:
https://github.com/apache/incubator-shardingsphere/pull/3902#discussion_r364685881
##
File path: sharding-distribution/sharding-jdbc-distribution/pom.xml
##
@@ -129,17 +129,27 @@
org.apache.shardingsphere
-sharding-orchestration-core
+sharding-orchestration-core-new
${project.version}
org.apache.shardingsphere
-sharding-orchestration-reg-api
+sharding-orchestration-center-api
Review comment:
Why not use
sharding-orchestration-center
It includes :
sharding-orchestration-center-api
sharding-orchestration-center-apollo
sharding-orchestration-center-zookeeper-curator
sharding-orchestration-center-nacos
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #3852: shardingjdcb 4.0.0-rc2 cannot convert sqlserver timestamp field
dongzl commented on issue #3852: shardingjdcb 4.0.0-rc2 cannot convert sqlserver timestamp field URL: https://github.com/apache/incubator-shardingsphere/issues/3852#issuecomment-572483235 Hi @tuohai666 , I debug this problem, at sqlserver database, `timestamp` column type is binary type, I think it should deal with `ResultSet.getBinaryStream()`, but now ShardingSphere deal with `ResultSet.getBlob()`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3915: Parser1
terrymanu commented on a change in pull request #3915: Parser1 URL: https://github.com/apache/incubator-shardingsphere/pull/3915#discussion_r364647387 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/pom.xml ## @@ -49,8 +49,8 @@ antlr src/main/antlr4/imports/mysql/ -false -false +true Review comment: Do we need generate listener too? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3854: ‘NullPointerException’ when getting database index
terrymanu closed issue #3854: ‘NullPointerException’ when getting database index URL: https://github.com/apache/incubator-shardingsphere/issues/3854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3912: Fixed #3854, fix NullPointerException when call CachedDatabaseMetaData.getIndexInfo
terrymanu merged pull request #3912: Fixed #3854, fix NullPointerException when call CachedDatabaseMetaData.getIndexInfo URL: https://github.com/apache/incubator-shardingsphere/pull/3912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3912: Fixed #3854, fix NullPointerException when call CachedDatabaseMetaData.getIndexInfo
coveralls commented on issue #3912: Fixed #3854, fix NullPointerException when call CachedDatabaseMetaData.getIndexInfo URL: https://github.com/apache/incubator-shardingsphere/pull/3912#issuecomment-572481183 ## Pull Request Test Coverage Report for [Build 1305](https://coveralls.io/builds/27999730) * **1** of **1** **(100.0%)** changed or added relevant line in **1** file are covered. * **123** unchanged lines in **7** files lost coverage. * Overall coverage increased (+**0.002%**) to **65.711%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java](https://coveralls.io/builds/27999730/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingPreparedStatement.java#L254) | 5 | 84.48% | | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/router/sharding/ShardingRouter.java](https://coveralls.io/builds/27999730/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Froute%2Frouter%2Fsharding%2FShardingRouter.java#L64) | 7 | 88.57% | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/27999730/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L69) | 16 | 2.38% | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/27999730/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L72) | 17 | 2.22% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/executor/AbstractStatementExecutor.java](https://coveralls.io/builds/27999730/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fexecutor%2FAbstractStatementExecutor.java#L191) | 20 | 47.92% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlaveStatement.java](https://coveralls.io/builds/27999730/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlaveStatement.java#L65) | 27 | 13.68% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlavePreparedStatement.java](https://coveralls.io/builds/27999730/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlavePreparedStatement.java#L56) | 31 | 6.49% | | Totals | [](https://coveralls.io/builds/27999730) | | :-- | --: | | Change from base [Build 660](https://coveralls.io/builds/27998018): | 0.002% | | Covered Lines: | 10726 | | Relevant Lines: | 16323 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3906: Make the shadow feature more complete
terrymanu commented on a change in pull request #3906: Make the shadow feature
more complete
URL:
https://github.com/apache/incubator-shardingsphere/pull/3906#discussion_r364640344
##
File path:
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/connection/ShadowConnection.java
##
@@ -132,24 +143,26 @@ public DatabaseMetaData getMetaData() throws
SQLException {
@Override
public void setReadOnly(final boolean readOnly) throws SQLException {
+this.readOnly = readOnly;
actualConnection.setReadOnly(readOnly);
shadowConnection.setReadOnly(readOnly);
}
@Override
public boolean isReadOnly() {
-return false;
+return readOnly;
}
@Override
public void setTransactionIsolation(final int level) throws SQLException {
+transactionIsolation = level;
actualConnection.setTransactionIsolation(level);
shadowConnection.setTransactionIsolation(level);
}
@Override
public int getTransactionIsolation() {
-return 0;
+return transactionIsolation;
Review comment:
Can we use lombok's @Getter to instead of it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3906: Make the shadow feature more complete
terrymanu commented on a change in pull request #3906: Make the shadow feature
more complete
URL:
https://github.com/apache/incubator-shardingsphere/pull/3906#discussion_r364640920
##
File path:
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShadowStatement.java
##
@@ -181,7 +183,8 @@ private Statement getStatementAndReplay(final String sql)
throws SQLException {
SQLStatement sqlStatement =
connection.getRuntimeContext().getParseEngine().parse(sql, false);
sqlStatementContext =
SQLStatementContextFactory.newInstance(getRelationMetas(connection.getRuntimeContext().getMetaData().getTables()),
sql, Collections.emptyList(), sqlStatement);
ShadowJudgementEngine shadowJudgementEngine = new
SimpleJudgementEngine(connection.getRuntimeContext().getRule(),
sqlStatementContext);
-statement =
shadowStatementGenerator.createStatement(shadowJudgementEngine);
+isShadowSQL = shadowJudgementEngine.isShadowSQL();
+statement = shadowStatementGenerator.createStatement();
return statement;
Review comment:
We should name as `result` for return value
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3906: Make the shadow feature more complete
terrymanu commented on a change in pull request #3906: Make the shadow feature
more complete
URL:
https://github.com/apache/incubator-shardingsphere/pull/3906#discussion_r364640264
##
File path:
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/connection/ShadowConnection.java
##
@@ -116,13 +126,14 @@ public void rollback() throws SQLException {
@Override
public void close() throws SQLException {
+closed = true;
actualConnection.close();
shadowConnection.close();
}
@Override
public boolean isClosed() {
-return false;
+return closed;
Review comment:
Can we use lombok's @Getter to instead of it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3906: Make the shadow feature more complete
terrymanu commented on a change in pull request #3906: Make the shadow feature more complete URL: https://github.com/apache/incubator-shardingsphere/pull/3906#discussion_r364639824 ## File path: sharding-integration-test/sharding-jdbc-test/src/test/resources/integrate/env/shadow/sharding-rule.yaml ## @@ -36,7 +36,4 @@ shadowRule: column: item_id defaultDataSourceName: db defaultTableStrategy: - none: - -props: - sql.show: true \ No newline at end of file + none: Review comment: We need a blank line for the end of file This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3906: Make the shadow feature more complete
terrymanu commented on a change in pull request #3906: Make the shadow feature
more complete
URL:
https://github.com/apache/incubator-shardingsphere/pull/3906#discussion_r364640163
##
File path:
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/connection/ShadowConnection.java
##
@@ -93,13 +102,14 @@ public PreparedStatement prepareStatement(final String
sql, final String[] colum
@Override
public void setAutoCommit(final boolean autoCommit) throws SQLException {
+this.autoCommit = autoCommit;
actualConnection.setAutoCommit(autoCommit);
shadowConnection.setAutoCommit(autoCommit);
}
@Override
public boolean getAutoCommit() {
-return false;
+return autoCommit;
Review comment:
Can we use lombok's @Getter to instead of it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3906: Make the shadow feature more complete
terrymanu commented on a change in pull request #3906: Make the shadow feature
more complete
URL:
https://github.com/apache/incubator-shardingsphere/pull/3906#discussion_r364640621
##
File path:
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/connection/ShadowConnection.java
##
@@ -169,6 +182,6 @@ public void setHoldability(final int holdability) throws
SQLException {
@Override
public int getHoldability() {
-return 0;
+return ResultSet.CLOSE_CURSORS_AT_COMMIT;
Review comment:
Is it correct for default value forever?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3906: Make the shadow feature more complete
terrymanu commented on a change in pull request #3906: Make the shadow feature
more complete
URL:
https://github.com/apache/incubator-shardingsphere/pull/3906#discussion_r364640301
##
File path:
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/connection/ShadowConnection.java
##
@@ -132,24 +143,26 @@ public DatabaseMetaData getMetaData() throws
SQLException {
@Override
public void setReadOnly(final boolean readOnly) throws SQLException {
+this.readOnly = readOnly;
actualConnection.setReadOnly(readOnly);
shadowConnection.setReadOnly(readOnly);
}
@Override
public boolean isReadOnly() {
-return false;
+return readOnly;
Review comment:
Can we use lombok's @Getter to instead of it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3911: refine .asf.yaml
terrymanu merged pull request #3911: refine .asf.yaml URL: https://github.com/apache/incubator-shardingsphere/pull/3911 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #3915: Parser1
tristaZero opened a new pull request #3915: Parser1 URL: https://github.com/apache/incubator-shardingsphere/pull/3915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero closed pull request #3913: Parser1
tristaZero closed pull request #3913: Parser1 URL: https://github.com/apache/incubator-shardingsphere/pull/3913 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion closed issue #3869: version:4.0.0-RC1 group by bug
KomachiSion closed issue #3869: version:4.0.0-RC1 group by bug URL: https://github.com/apache/incubator-shardingsphere/issues/3869 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion closed issue #3644: part of sharding key in multiple sharding strategy can not null
KomachiSion closed issue #3644: part of sharding key in multiple sharding strategy can not null URL: https://github.com/apache/incubator-shardingsphere/issues/3644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3912: Fixed #3854, fix NullPointerException when call CachedDatabaseMetaData.getIndexInfo
KomachiSion commented on issue #3912: Fixed #3854, fix NullPointerException when call CachedDatabaseMetaData.getIndexInfo URL: https://github.com/apache/incubator-shardingsphere/pull/3912#issuecomment-572456761 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3906: Make the shadow feature more complete
coveralls edited a comment on issue #3906: Make the shadow feature more complete URL: https://github.com/apache/incubator-shardingsphere/pull/3906#issuecomment-572079585 ## Pull Request Test Coverage Report for [Build 1303](https://coveralls.io/builds/27998759) * **11** of **28** **(39.29%)** changed or added relevant lines in **5** files are covered. * **123** unchanged lines in **7** files lost coverage. * Overall coverage increased (+**0.3%**) to **66.026%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/condition/ShadowCondition.java](https://coveralls.io/builds/27998759/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Fcondition%2FShadowCondition.java#L61) | 2 | 3 | 66.67% | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShadowStatement.java](https://coveralls.io/builds/27998759/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShadowStatement.java#L237) | 4 | 6 | 66.67% | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShadowPreparedStatement.java](https://coveralls.io/builds/27998759/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShadowPreparedStatement.java#L282) | 4 | 9 | 44.44% | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/connection/ShadowConnection.java](https://coveralls.io/builds/27998759/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fconnection%2FShadowConnection.java#L105) | 0 | 9 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java](https://coveralls.io/builds/27998759/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingPreparedStatement.java#L254) | 5 | 84.48% | | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/router/sharding/ShardingRouter.java](https://coveralls.io/builds/27998759/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Froute%2Frouter%2Fsharding%2FShardingRouter.java#L64) | 7 | 88.57% | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/27998759/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L69) | 16 | 2.38% | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/27998759/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L72) | 17 | 2.22% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/executor/AbstractStatementExecutor.java](https://coveralls.io/builds/27998759/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fexecutor%2FAbstractStatementExecutor.java#L191) | 20 | 47.92% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlaveStatement.java](https://coveralls.io/builds/27998759/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlaveStatement.java#L65) | 27 | 13.68% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlavePreparedStatement.java](https://coveralls.io/builds/27998759/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlavePreparedStatement.java#L56) | 31 | 6.49% | | Totals | [![Coverage
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #3914: Optimization for Sharing Parser with Antlr Visitor
tristaZero opened a new issue #3914: Optimization for Sharing Parser with Antlr Visitor URL: https://github.com/apache/incubator-shardingsphere/issues/3914 It is not common practice and prone to low performance that `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed result based on AST generated by ANTLR at present. Upon investigation, we would like to replace them with ANTLR visitor. It is scheduled as a long-term task and a big change for our 5.x release, and currently i am trying to do some basic work for our new branch[1]. After the groundwork (Roughly estimated time is one week. ) is basically laid, we would like to welcome anyone who is interested in it to join us for this wonderful sharding parser. Please watch this ISSUE for follow-up. What’s more, welcome your any comment and suggestion! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #3913: Parser1
tristaZero opened a new pull request #3913: Parser1 URL: https://github.com/apache/incubator-shardingsphere/pull/3913 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
