Re: some issues with emacs 25
Matthew Learwrites: > I'm of the opinion that this is probably some sort of set up / > configuration issue specific to 25, but I'm quite surprised. I don't > have many settings for handling html stuff: > > (setq mm-text-html-renderer 'shr) > (setq shr-inhibit-images nil) > (setq mime-view-text/html-previewer 'shr) > (setq mm-inline-text-html-with-images t) > (setq notmuch-multipart/alternative-discouraged '("text/plain")) > > Is this reproducible for anyone else with notmuch from git/master as of > today? According to emacs upstream, this problem (or at least my reduced test case) is fixed in emacs 26.1 https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29273 Can you confirm that? ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
Hi David. Finally got back round to checking this with recent sw. Apologies for the long delay. I can confirm that the problem still exists as before, ie replying to my test html emails when composing the message in a new frame throws the bodypart errors. ...But I'm not too fussed about it because I've got used to not composing messages in new frames ;-) I've synced my emacs.git to: * c3ff6712ad - (HEAD, origin/emacs-25) * lisp/net/tls.el (tls-program): Fix :version (do not merge to master). (2017-09-14 16:38:29 -0400) Emacs version is reported as 25.3.50.1. And notmuch.git to: * ab8b40f7 - (HEAD -> master, origin/master, origin/HEAD) cli: make notmuch count --exclude a boolean argument (2017-10-15 19:22:40 -0300) Using the tiny .emacs below is enough to trigger the problem: (require 'shr) (setq mm-text-html-renderer 'shr) (setq mime-view-text/html-previewer 'shr) (setq mm-html-inhibit-images nil) (setq mm-html-blocked-images nil) (require 'notmuch) (setq notmuch-mua-compose-in 'new-frame) (setq notmuch-multipart/alternative-discouraged '("text/plain")) Not sure what you'd like to do with this from here... Cheers, -- Matt On Fri, Jun 30, 2017 at 1:47 PM, David Bremnerwrote: > Matthew Lear writes: > > > > It was indeed fixed...that is until I updated my emacs git tree to > 25.2.1. > > I've given up composing emails in new frames as it's now broken again - > > this time when replying to emails which have quoted/embedded html in the > > body. Feels like two steps forward, one step back :-( > > -- Matt > > Unfortunately I don't have easy access to emacs25.2; I've been waiting > for it show up in Debian. Can you see if the relevant fix referenced in > that bug log included in 25.2? I did wonder if maybe you had a local > modification that was lost when you updated to 25.2. > > d > ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
Matthew Learwrites: > It was indeed fixed...that is until I updated my emacs git tree to 25.2.1. > I've given up composing emails in new frames as it's now broken again - > this time when replying to emails which have quoted/embedded html in the > body. Feels like two steps forward, one step back :-( > -- Matt Unfortunately I don't have easy access to emacs25.2; I've been waiting for it show up in Debian. Can you see if the relevant fix referenced in that bug log included in 25.2? I did wonder if maybe you had a local modification that was lost when you updated to 25.2. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
On 4 Mar 2017 11:03, "David Bremner"wrote: David Bremner writes: > Matthew Lear writes: > > >> Thanks David. Yes it does. After recompiling the v25 lisp with these >> changes, I'm unable to reproduce the problems with both the test emails I >> sent you. Wonderful :-) >> Are you going to raise this with upstream? >> Cheers, >> Matt > > Yes, I've filed > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25828 > That bug should be fixed in emacs master branch. d It was indeed fixed...that is until I updated my emacs git tree to 25.2.1. I've given up composing emails in new frames as it's now broken again - this time when replying to emails which have quoted/embedded html in the body. Feels like two steps forward, one step back :-( -- Matt ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
David Bremnerwrites: > Matthew Lear writes: > > >> Thanks David. Yes it does. After recompiling the v25 lisp with these >> changes, I'm unable to reproduce the problems with both the test emails I >> sent you. Wonderful :-) >> Are you going to raise this with upstream? >> Cheers, >> Matt > > Yes, I've filed > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25828 > That bug should be fixed in emacs master branch. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
Matthew Learwrites: > Thanks David. Yes it does. After recompiling the v25 lisp with these > changes, I'm unable to reproduce the problems with both the test emails I > sent you. Wonderful :-) > Are you going to raise this with upstream? > Cheers, > Matt Yes, I've filed https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25828 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
On 18 Feb 2017 01:01, "David Bremner"wrote: So I _finally_ got around to looking at these, and I think it's roughly the same shr bug as before but some different functions. I could actually only duplicate the bug with emacs-reply-fail-ec message, but that was fixed by the following patch against the emacs-25 branch. Does this patch fix both failures for you? diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 6c35a33c9c..2bc37c64bd 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1993,6 +1993,9 @@ shr-pixel-buffer-width (if (get-buffer-window) (car (window-text-pixel-size nil (point-min) (point-max))) (save-window-excursion +;; Avoid errors if the selected window is a dedicated one, +;; and they just want to insert a document into it. +(set-window-dedicated-p nil nil) (set-window-buffer nil (current-buffer)) (car (window-text-pixel-size nil (point-min) (point-max))) @@ -2036,6 +2039,9 @@ shr-render-td-1 (shr-indentation 0)) (shr-descend dom)) (save-window-excursion +;; Avoid errors if the selected window is a dedicated one, +;; and they just want to insert a document into it. +(set-window-dedicated-p nil nil) (set-window-buffer nil (current-buffer)) (unless fill (setq natural-width Thanks David. Yes it does. After recompiling the v25 lisp with these changes, I'm unable to reproduce the problems with both the test emails I sent you. Wonderful :-) Are you going to raise this with upstream? Cheers, Matt ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
Matthew Learwrites: > On 03/12/16 01:58, David Bremner wrote: >> Matthew Lear writes: >> >>> >>> I'd happily post some debug info to help analyse this if somebody could >>> give me a few pointers about what would be needed and the emacs-fu >>> needed to generate this. >>> >> >> I think the best thing at this point would be to find (or create) >> another public message where you can duplicate the problem. > > I've sent two test emails directly to David for analysis. > -- Matt So I _finally_ got around to looking at these, and I think it's roughly the same shr bug as before but some different functions. I could actually only duplicate the bug with emacs-reply-fail-ec message, but that was fixed by the following patch against the emacs-25 branch. Does this patch fix both failures for you? diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 6c35a33c9c..2bc37c64bd 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1993,6 +1993,9 @@ shr-pixel-buffer-width (if (get-buffer-window) (car (window-text-pixel-size nil (point-min) (point-max))) (save-window-excursion +;; Avoid errors if the selected window is a dedicated one, +;; and they just want to insert a document into it. +(set-window-dedicated-p nil nil) (set-window-buffer nil (current-buffer)) (car (window-text-pixel-size nil (point-min) (point-max))) @@ -2036,6 +2039,9 @@ shr-render-td-1 (shr-indentation 0)) (shr-descend dom)) (save-window-excursion +;; Avoid errors if the selected window is a dedicated one, +;; and they just want to insert a document into it. +(set-window-dedicated-p nil nil) (set-window-buffer nil (current-buffer)) (unless fill (setq natural-width ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
On 03/12/16 01:58, David Bremner wrote: > Matthew Learwrites: > >> >> I'd happily post some debug info to help analyse this if somebody could >> give me a few pointers about what would be needed and the emacs-fu >> needed to generate this. >> > > I think the best thing at this point would be to find (or create) > another public message where you can duplicate the problem. I've sent two test emails directly to David for analysis. -- Matt ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
Matthew Learwrites: > > I'd happily post some debug info to help analyse this if somebody could > give me a few pointers about what would be needed and the emacs-fu > needed to generate this. > I think the best thing at this point would be to find (or create) another public message where you can duplicate the problem. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
On 23/11/16 11:57, David Bremner wrote: > In a fresh emacs, can you generate an error using the recipe in > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24950 ? No. I can evaluate the recipe ok and eval of the last line yields: 10 (#o12, #xa, ?\C-j) ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
Matthew Learwrites: > I'd happily post some debug info to help analyse this if somebody could > give me a few pointers about what would be needed and the emacs-fu > needed to generate this. > > Cheers, > -- Matt In a fresh emacs, can you generate an error using the recipe in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24950 ? d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
On 22/11/16 14:24, Matthew Lear wrote: > I can confirm that it is indeed fixed. I'm not able to reproduce it with > the latest emacs 25 from git. Unfortunately, it seems I was too hasty in confirming this. For some reason unknown to me, replying to the html in some multipart/alternative works fine, but others cause the same error to be thrown. I've also seen the error occur when replying to a multipart/mixed message, too. Even more bizarrely, I'm currently looking at a thread with two emails where both are multipart/alternative and contain text/plain and text/html parts, and replying to the first message triggers the error/bug but replying to the second message does not. I can't see any formatting difference between the two. Sorry, but it would appear as though there is still some work needed to resolve this in it's entirety. I suppose it's likely that this could be an emacs-25 issue, but what I mentioned above makes no sense to me so I can't say for sure. I'd happily post some debug info to help analyse this if somebody could give me a few pointers about what would be needed and the emacs-fu needed to generate this. Cheers, -- Matt ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
On 20/11/16 20:01, David Bremner wrote: >> I have reported https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24950 >> upstream. We'll see if they agree it's bug in shr. > > This bug will be fixed in the next release of emacs 25, so I'm tagging > it fixed. I can confirm that it is indeed fixed. I'm not able to reproduce it with the latest emacs 25 from git. Thanks for raising it with upstream, David. Cheers, -- Matt ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
David Bremnerwrites: > Yes, I can replicate this bug in emacs 25.1 by > > 1) ./devel/try-emacs-mua -q > > 2) (setq notmuch-mua-compose-in 'new-frame) > > 3) reply to an html only message. > > If I M-x toggle-debug-on-error I get a backtrace ending in > > set-window-buffer(nil #) > shr-pixel-column > shr-string-pixe-width > shr-insert-document > notmuch-show--insert-part-text/html-shr > I have reported https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24950 upstream. We'll see if they agree it's bug in shr. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
Matthew Learwrites: > (setq notmuch-mua-compose-in 'new-frame) > (setq notmuch-multipart/alternative-discouraged '("text/plain")) Using devel/try-emacs-mua in the source tree, only these last two lines are needed. But yes agree, after discouraging text/plain, multipart messages can also duplicate this bug > ...and load it using 'emacs-25 -q --load ~/.emacs.d/tiny-init.el', > searching for any mimetype:text/html and replying to it triggers the bug > for me. > > Commenting out the setting of notmuch-mua-compose-in is enough to > prevent the problem from occurring. > Cheers, > -- Matt ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
On 12/11/16 00:20, David Bremner wrote: > Matthew Learwrites: > >> I can trigger the bug if I discard text/plain though. Did you try that? > > I'm not sure what you mean by "discard", but closing it isn't enough. I > think more of your settings are needed to replicate the problem with a > multipart/alternative message. > Apologies, David. I wasn't clear at all. I meant that if I discourage text/plain in a multipart/alternative message, I can trigger the bug. If I use the following tiny-init.el... (require 'shr) (setq mm-text-html-renderer 'shr) (setq mime-view-text/html-previewer 'shr) (setq mm-html-inhibit-images nil) (setq mm-html-blocked-images nil) (require 'notmuch) (global-set-key [f1] 'notmuch) (setq notmuch-mua-compose-in 'new-frame) (setq notmuch-multipart/alternative-discouraged '("text/plain")) ...and load it using 'emacs-25 -q --load ~/.emacs.d/tiny-init.el', searching for any mimetype:text/html and replying to it triggers the bug for me. Commenting out the setting of notmuch-mua-compose-in is enough to prevent the problem from occurring. Cheers, -- Matt ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
Matthew Lear <m...@bubblegen.co.uk> writes: > I can trigger the bug if I discard text/plain though. Did you try that? > Original message From: David Bremner <da...@tethera.net> > Date: 11/11/2016 11:40 (GMT+00:00) To: Matthew Lear <m...@bubblegen.co.uk>, > Matt Armstrong <marmstr...@google.com> Cc: notmuch@notmuchmail.org Subject: > Re: some issues with emacs 25 > Matthew Lear <m...@bubblegen.co.uk> writes: > >> On 09/11/16 23:55, David Bremner wrote: >>> I can't find an html only public-message so far to give a full >>> backtrace. >> If it helps, here is some text in *bold *with some changes in red that >> you can test with :-D > > FWIW, this doesn't trigger the bug with default settings + (setq > notmuch-mua-compose-in 'new-window) because it has a text part. > I'm not sure what you mean by "discard", but closing it isn't enough. I think more of your settings are needed to replicate the problem with a multipart/alternative message. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
I can trigger the bug if I discard text/plain though. Did you try that? Original message From: David Bremner <da...@tethera.net> Date: 11/11/2016 11:40 (GMT+00:00) To: Matthew Lear <m...@bubblegen.co.uk>, Matt Armstrong <marmstr...@google.com> Cc: notmuch@notmuchmail.org Subject: Re: some issues with emacs 25 Matthew Lear <m...@bubblegen.co.uk> writes: > On 09/11/16 23:55, David Bremner wrote: >> I can't find an html only public-message so far to give a full >> backtrace. > If it helps, here is some text in *bold *with some changes in red that > you can test with :-D FWIW, this doesn't trigger the bug with default settings + (setq notmuch-mua-compose-in 'new-window) because it has a text part. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
Matthew Learwrites: > On 09/11/16 23:55, David Bremner wrote: >> I can't find an html only public-message so far to give a full >> backtrace. > If it helps, here is some text in *bold *with some changes in red that > you can test with :-D FWIW, this doesn't trigger the bug with default settings + (setq notmuch-mua-compose-in 'new-window) because it has a text part. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
On 09/11/16 23:55, David Bremner wrote: > Matthew Learwrites: > >> On 28/10/16 22:34, Matthew Lear wrote: >>> I will commence with trying to figure out what is causing the problem. I've >>> seen some weirdness with margins when viewing HTML messages too. Maybe >>> that's some kind of bizarre toolkit thing... Anyway, thanks a lot for >>> testing and for confirming that there's no problem. >> From what I can tell, this is purely caused by using: >> >> (setq notmuch-mua-compose-in 'new-frame) >> or >> (setq notmuch-mua-compose-in 'new-window) > Yes, I can replicate this bug in emacs 25.1 by > > 1) ./devel/try-emacs-mua -q > > 2) (setq notmuch-mua-compose-in 'new-frame) > > 3) reply to an html only message. > > > If I M-x toggle-debug-on-error I get a backtrace ending in > > set-window-buffer(nil #) > shr-pixel-column > shr-string-pixe-width > shr-insert-document > notmuch-show--insert-part-text/html-shr > > I can't find an html only public-message so far to give a full > backtrace. If it helps, here is some text in *bold *with some changes in red that you can test with :-D ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
Matthew Learwrites: > On 28/10/16 22:34, Matthew Lear wrote: >> >> I will commence with trying to figure out what is causing the problem. I've >> seen some weirdness with margins when viewing HTML messages too. Maybe >> that's some kind of bizarre toolkit thing... Anyway, thanks a lot for >> testing and for confirming that there's no problem. > > From what I can tell, this is purely caused by using: > > (setq notmuch-mua-compose-in 'new-frame) > or > (setq notmuch-mua-compose-in 'new-window) Yes, I can replicate this bug in emacs 25.1 by 1) ./devel/try-emacs-mua -q 2) (setq notmuch-mua-compose-in 'new-frame) 3) reply to an html only message. If I M-x toggle-debug-on-error I get a backtrace ending in set-window-buffer(nil #) shr-pixel-column shr-string-pixe-width shr-insert-document notmuch-show--insert-part-text/html-shr I can't find an html only public-message so far to give a full backtrace. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
On 28/10/16 22:34, Matthew Lear wrote: > > I will commence with trying to figure out what is causing the problem. I've > seen some weirdness with margins when viewing HTML messages too. Maybe that's > some kind of bizarre toolkit thing... Anyway, thanks a lot for testing and > for confirming that there's no problem. From what I can tell, this is purely caused by using: (setq notmuch-mua-compose-in 'new-frame) or (setq notmuch-mua-compose-in 'new-window) when using (setq mm-text-html-renderer 'shr) If I keep shr and use (setq notmuch-mua-compose-in 'current-window) or remove this setting completely (to get the default behaviour), there is no problem in replying to an html message and the html text being quoted. If I switch to using different values of mm-text-html-renderer such as w3m, links, lynx or html2text there is no problem replying when using a new-frame or new-window via notmuch-mua-compose-in. Seems like the problem I've seen is purely limited to using mm-text-html-renderer equal to 'shr along with notmuch settings to compose in either a new frame or a new window. I've tested this with a .emacs of only a few lines and am convinced. Please can this be verified by somebody else? Cheers, -- Matt ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
> On 28 Oct 2016, at 01:52, Matt Armstrongwrote: > > Matthew Lear writes: > >> Hi, >> I switched to trying emacs 25 (25.1) with notmuch the other day. > > I'm on 25.1 as well, but haven't experienced the symptoms you describe. Thanks Matt. I feel reassured! :-) I will commence with trying to figure out what is causing the problem. I've seen some weirdness with margins when viewing HTML messages too. Maybe that's some kind of bizarre toolkit thing... Anyway, thanks a lot for testing and for confirming that there's no problem. Cheers, Matt ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: some issues with emacs 25
Matthew Learwrites: > Hi, > I switched to trying emacs 25 (25.1) with notmuch the other day. I'm on 25.1 as well, but haven't experienced the symptoms you describe. >> !!! Bodypart handler `notmuch-show-insert-part-text/html' threw an error: >> !!! Window is dedicated to ‘*unsent mail to u...@domain.com*’ > > Errors like these are generated by replying from either notmuch-tree or > notmuch-show. Below I tried replying from notmuch-show. > I'm of the opinion that this is probably some sort of set up / > configuration issue specific to 25, but I'm quite surprised. I don't > have many settings for handling html stuff: > > (setq mm-text-html-renderer 'shr) > (setq shr-inhibit-images nil) > (setq mime-view-text/html-previewer 'shr) > (setq mm-inline-text-html-with-images t) > (setq notmuch-multipart/alternative-discouraged '("text/plain")) > > Is this reproducible for anyone else with notmuch from git/master as of > today? Matt, I couldn't resist helping another, Matt, so I copy-pasted your setq incantations, executed them (thus "poisoning" my precious Emacs!), and was able to initiate replies to several emails. Some were multipart/mixed with HTML alternatives, some (like yours) were text/plain. I'm running recent-ish notmuch binaries from git/master, running even fresher elisp from git/master (I think I pulled last night). It may be necessary for you to play around with the various Emacs options to eliminate site specific stuff: -Q, -q, etc. Here at work a bunch of people are moving to Emacs 25 and a common theme is some old package in their setup somehow conflicts with Emacs 25 (e.g. it shadows something that is now part of Emacs but has changed in subtle ways, etc.). ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch