Re: [PATCH] Add support for Option iCON 451

2010-04-14 Thread Daniel Wagner
Hi Gustavo,

On Wed, Apr 14, 2010 at 07:43:47AM +0200, Gustavo F. Padovan wrote:
 Hi Daniel,
 
 * Daniel Wagner daniel.wag...@bmw-carit.de [2010-04-14 07:45:11 +0200]:
 
  Signed-off-by: Daniel Wagner daniel.wag...@bmw-carit.de
 
 We do not use the signed-off line in oFono.

Ah, sorry about that . Didn't know that. Do you want me to resend the
patch without signoff?

daniel
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH] Add support for Option iCON 451

2010-04-14 Thread Gustavo F. Padovan
Hi Daniel,

* Daniel Wagner daniel.wag...@bmw-carit.de [2010-04-14 08:00:05 +0200]:

 Hi Gustavo,
 
 On Wed, Apr 14, 2010 at 07:43:47AM +0200, Gustavo F. Padovan wrote:
  Hi Daniel,
  
  * Daniel Wagner daniel.wag...@bmw-carit.de [2010-04-14 07:45:11 +0200]:
  
   Signed-off-by: Daniel Wagner daniel.wag...@bmw-carit.de
  
  We do not use the signed-off line in oFono.
 
 Ah, sorry about that . Didn't know that. Do you want me to resend the
 patch without signoff?

I don't know. Denis will tell that to you.


-- 
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


calypso does not power up from 0.17

2010-04-14 Thread Nicola Mfb
Hi!

0.16 is the last release that works (well) on the openmoko freerunner
while from 0.17 to 0.20 I have:

r...@om-gta02 ~ $ dbus-send --system --dest=org.ofono --print-reply
/freerunner org.ofono.Modem.SetProperty string:Powered
variant:boolean:true
Error org.ofono.Error.Timedout: Operation failure due to timeout

I'm sorry I do not have much time in this period to dig deeply, anyway
I found the commit that introduced the problem with git bisect.

Thanks and Regards

 Niko

commit aec5b8a44fa2fbece87441656eaf7ffb9a53fc6e
Author: Denis Kenzior denk...@gmail.com
Date:   Thu Jan 14 10:25:14 2010 -0600

Fix: Make remote disconnect detection work

diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c
index ea17335..8af927e 100644
--- a/gatchat/gatchat.c
+++ b/gatchat/gatchat.c
@@ -801,7 +801,7 @@ static gboolean received_data(GIOChannel *channel,
GIOCondition cond,
if (cond  (G_IO_HUP | G_IO_ERR))
return FALSE;

-   if (err != G_IO_ERROR_NONE  err != G_IO_ERROR_AGAIN)
+   if (rbytes == 0  err != G_IO_ERROR_AGAIN)
return FALSE;

return TRUE;
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: calypso does not power up from 0.17

2010-04-14 Thread Zhenhua Zhang

Hi,

On 04/14/2010 04:52 PM, Nicola Mfb wrote:

Hi!

0.16 is the last release that works (well) on the openmoko freerunner
while from 0.17 to 0.20 I have:

r...@om-gta02 ~ $ dbus-send --system --dest=org.ofono --print-reply
/freerunner org.ofono.Modem.SetProperty string:Powered
variant:boolean:true
Error org.ofono.Error.Timedout: Operation failure due to timeout

I'm sorry I do not have much time in this period to dig deeply, anyway
I found the commit that introduced the problem with git bisect.


You could set environment variable OFONO_AT_DEBUG to debug AT 
conversation, like:

export set OFONO_AT_DEBUG=1

And I found the commit fb918d39ba275cdd327 in Jan 28th has changed the 
code to:

 if (read_count  0  rbytes == 0  err != G_IO_ERROR_AGAIN)
  return FALSE;

What's the err value in freerunner?


Thanks and Regards

  Niko

commit aec5b8a44fa2fbece87441656eaf7ffb9a53fc6e
Author: Denis Kenziordenk...@gmail.com
Date:   Thu Jan 14 10:25:14 2010 -0600

 Fix: Make remote disconnect detection work

diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c
index ea17335..8af927e 100644
--- a/gatchat/gatchat.c
+++ b/gatchat/gatchat.c
@@ -801,7 +801,7 @@ static gboolean received_data(GIOChannel *channel,
GIOCondition cond,
 if (cond  (G_IO_HUP | G_IO_ERR))
 return FALSE;

-   if (err != G_IO_ERROR_NONE  err != G_IO_ERROR_AGAIN)
+   if (rbytes == 0  err != G_IO_ERROR_AGAIN)
 return FALSE;

 return TRUE;
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono



___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: calypso does not power up from 0.17

2010-04-14 Thread Dario

Hi Zhenhua,


You could set environment variable OFONO_AT_DEBUG to debug AT 
conversation, like:

export set OFONO_AT_DEBUG=1

And I found the commit fb918d39ba275cdd327 in Jan 28th has changed the 
code to:

 if (read_count  0  rbytes == 0  err != G_IO_ERROR_AGAIN)
  return FALSE;

What's the err value in freerunner?


I discussed this problem with Denis some time ago sending in IRC the log 
of OFONO_AT_DEBUG=1, the problem seems a timeout in the response from 
the Calypso, we tried to patch (as suggested by Denis) the code waiting 
more than 20 secs (we used 40 secs) but this gave no results.
As Nicola mentioned, 0.16 version works very well and we use it as daily 
in our distro without any problem so we thought there could be some 
other difference since 0.17 because no other newer version solves the 
problem.
Is there any other test we can do on our devices to make you able to 
investigate the problem?

Thank you very much in advance,
best regards,
Dario.
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH] Add support for Option iCON 451

2010-04-14 Thread Marcel Holtmann
Hi Daniel,

  * Daniel Wagner daniel.wag...@bmw-carit.de [2010-04-14 07:45:11 +0200]:
  
   Signed-off-by: Daniel Wagner daniel.wag...@bmw-carit.de
  
  We do not use the signed-off line in oFono.
 
 Ah, sorry about that . Didn't know that. Do you want me to resend the
 patch without signoff?

I just fixed that up for you manually. Just keep it in mind next time.
Patch has been applied. Thanks.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: calypso does not power up from 0.17

2010-04-14 Thread Denis Kenzior
Hi Niko,

 Hi!
 
 0.16 is the last release that works (well) on the openmoko freerunner
 while from 0.17 to 0.20 I have:
 
 r...@om-gta02 ~ $ dbus-send --system --dest=org.ofono --print-reply
 /freerunner org.ofono.Modem.SetProperty string:Powered
 variant:boolean:true
 Error org.ofono.Error.Timedout: Operation failure due to timeout
 
 I'm sorry I do not have much time in this period to dig deeply, anyway
 I found the commit that introduced the problem with git bisect.

I have a hunch that the GAtMux code might need some love.  Can you try the 
following patch?

diff --git a/gatchat/gatmux.c b/gatchat/gatmux.c
index b70f6a0..139edd2 100644
--- a/gatchat/gatmux.c
+++ b/gatchat/gatmux.c
@@ -433,6 +433,9 @@ static GIOStatus channel_read(GIOChannel *channel, gchar 
*buf, gsize count,
 
*bytes_read = ring_buffer_read(mux_channel-buffer, buf, avail);
 
+   if (*bytes_read == 0)
+   return G_IO_STATUS_AGAIN;
+
return G_IO_STATUS_NORMAL;
 }
 
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


oFono build configuration: delta between Git repo and Meego source RPM.

2010-04-14 Thread Berthier, Emmanuel
Hi,

I work with oFono 0.18 and Meego Handset build 03-23-2010.

To build ofonod manually from Git repo, I use:
 ./bootstrap-configure
 make
I can use and debug this daemon without problem.

To build ofonod from source RPM provided by Meego, I use:
 build --clean --target i586 --arch i586:i686 --root $BUILD_ROOT --rpms 
 $BUILD_RPMS ofono.spec
When I launch this binary manually in non-daemon mode, I obtain many errors:

  ./ofonod -nd *
ofonod[736]: oFono version 0.18
ofonod[736]: src/plugin.c:__ofono_plugin_init()
(ofonod:736): GConf-WARNING **: Client failed to connect to the D-BUS daemon:
Failed to connect to socket /tmp/dbus-kq3vrFoKcH: Connection refused
GConf Error: No D-BUS daemon running
(ofonod:736): GConf-WARNING **: Client failed to connect to the D-BUS daemon:
Failed to connect to socket /tmp/dbus-kq3vrFoKcH: Connection refused
GConf Error: No D-BUS daemon running
(ofonod:736): GConf-WARNING **: Client failed to connect to the D-BUS daemon:
Failed to connect to socket /tmp/dbus-kq3vrFoKcH: Connection refused
GConf Error: No D-BUS daemon running
(ofonod:736): libecal-WARNING **: Cannot activate ECal: Failed to connect to 
socket /tmp/dbus-kq3vrFoKcH: Connection refused
(ofonod:736): libecal-CRITICAL **: e_cal_get_uri: assertion `ecal != NULL' 
failed
(ofonod:736): GConf-WARNING **: Client failed to connect to the D-BUS daemon:
Failed to connect to socket /tmp/dbus-kq3vrFoKcH: Connection refused
GConf Error: No D-BUS daemon running
(ofonod:736): GConf-WARNING **: Client failed to connect to the D-BUS daemon:
Failed to connect to socket /tmp/dbus-kq3vrFoKcH: Connection refused
GConf Error: No D-BUS daemon running
(ofonod:736): libecal-WARNING **: Cannot activate ECal: Failed to connect to 
socket /tmp/dbus-kq3vrFoKcH: Connection refused
(ofonod:736): GConf-WARNING **: Client failed to connect to the D-BUS daemon:
Failed to connect to socket /tmp/dbus-kq3vrFoKcH: Connection refused
GConf Error: No D-BUS daemon running
(ofonod:736): GConf-WARNING **: Client failed to connect to the D-BUS daemon:
Failed to connect to socket /tmp/dbus-kq3vrFoKcH: Connection refused
GConf Error: No D-BUS daemon running
(ofonod:736): libecal-WARNING **: Cannot activate ECal: Failed to connect to 
socket /tmp/dbus-kq3vrFoKcH: Connection refused

I realized that these errors are generated during the callHistory plugin 
initialization.

The difference comes from the --enable_maintainer_mode option which is used 
in Git env (in bootstrap-configure) but not in RPM env (in ofono.spec).
This options configures the PLUGINDIR path:

-  In Git env: PLUGINDIR is set to  ofono/plugins/.libs which is empty

-  In RPM env: PLUGINDIR is set to /usr/lib/ofono/plugins which 
contains the callHistory.so (0.1.5) plugins.

So:

-  Is CallHistory.so plugins supported by ofono0.18?

-  What is the reference build script and options 
(Git/bootstrap-configure or Source RPM / ofono.spec)?

Thanks.

Emmanuel.


-
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: Les Montalets- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: calypso does not power up from 0.17

2010-04-14 Thread Denis Kenzior
Hi Niko,

 On Wed, Apr 14, 2010 at 12:43 PM, Denis Kenzior denk...@gmail.com wrote:
 [...]
 
  I have a hunch that the GAtMux code might need some love.  Can you try
  the following patch?
 
 [...]
 
 It works :)
 
 Just need a couple of days to verify how the version bump affects our
 freerunners.

Good to know, thanks for doing the hard work that made the problem much more 
obvious.  Patch has now been pushed upstream.

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH] ppp: nak unknown auth protocol

2010-04-14 Thread Denis Kenzior
Hi Kristen,

 If we are sent a Config-Request for an auth proto other than
 CHAP with MD5, send a NAK.

This patch has been applied, thanks.

Regards,
-Denis
 
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono