Re: [Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Olivier Churlaud 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128436/
---

(Updated July 14, 2016, 1:17 a.m.)


Status
--

This change has been discarded.


Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl 
Sandsmark.


Repository: okular


Description
---

As I didn't know what unique was exactly for, here is what I considered (if I'm 
wrong, please correct me):

User wants only one instance of okular so he starts it with --unique flag. From 
now on, every time he starts okular without the flag, it will raise the current 
instance. Opening a new file /should/ open a tab (currently overwrites the last 
one).

In my opinion, if another --unique is started, it should drop the --unique (it 
is not the case now: it starts a new instance).

Still to do as I see it: 
 - open new documents in new tabs by default (in unique mode)
 - allow opening several documents at once in unique mode
 - Drop --unique if another session already exist


Diffs
-

  shell/okular_main.cpp 2285f64 

Diff: https://git.reviewboard.kde.org/r/128436/diff/


Testing
---

Compile, behave as described above.


Thanks,

Olivier Churlaud

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

2016-07-13 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/#review97361
---



It looks like a workaround to me. But workarounds are often required.


shell/shell.cpp (line 435)


Why? Shouldn't this depend on the standard in the platform? Why would we 
need to hide this?



shell/shell.cpp (line 440)


Use foreach or qAsConst.



shell/shell.cpp (line 441)


I think it would make sense to move that logic upstream.

It's not something specific about okular.


- Aleix Pol Gonzalez


On July 13, 2016, 11:57 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128435/
> ---
> 
> (Updated July 13, 2016, 11:57 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Without the Plasma QPA now the file open dialog just lets you select a single 
> random filetype to view at the time. This tries to improve that, but I'm not 
> sure if that's something you/we want?
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp bca7206 
> 
> Diff: https://git.reviewboard.kde.org/r/128435/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 » Linux,gcc - Build # 36 - Fixed!

2016-07-13 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/36/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 21:49:07 +
Build duration: 5 min 9 sec

CHANGE SET
Revision dd8fa351ce87be2b46243e5de641b9c104a024cc by olivier: (Fonts are 
scanned again by poppler5 Fonts are filtered as well to only)
  change: edit core/fontinfo.cpp
  change: edit core/document.cpp
  change: edit generators/poppler/generator_pdf.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
14 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/22 (91%)FILES 131/258 (51%)CLASSES 131/258 (51%)LINE 12300/37808 
(33%)CONDITIONAL 5478/25002 (22%)

By packages
  

FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 881/1631 
(54%)CONDITIONAL 414/1167 (35%)
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1708/1725 
(99%)CONDITIONAL 941/1760 (53%)
conf
FILES 1/17 (6%)CLASSES 1/17 (6%)LINE 54/829 (7%)CONDITIONAL 
2/284 (1%)
conf.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 17/17 (100%)CONDITIONAL 
7/14 (50%)
core
FILES 41/48 (85%)CLASSES 41/48 (85%)LINE 4347/9114 
(48%)CONDITIONAL 2020/5895 (34%)
core.script
FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/499 (0%)CONDITIONAL 0/230 
(0%)
generators.comicbook
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 10/415 (2%)CONDITIONAL 
0/418 (0%)
generators.djvu
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 26/826 (3%)CONDITIONAL 
3/570 (1%)
generators.dvi
FILES 1/47 (2%)CLASSES 1/47 (2%)LINE 10/3584 (0%)CONDITIONAL 
1/2389 (0%)
generators.epub
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 181/327 (55%)CONDITIONAL 
76/181 (42%)
generators.fax
FILES 1/6 (17%)CLASSES 1/6 (17%)LINE 7/437 (2%)CONDITIONAL 
1/589 (0%)
generators.fictionbook
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 16/534 (3%)CONDITIONAL 
4/432 (1%)
generators.ooo
FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 14/1172 (1%)CONDITIONAL 
2/669 (0%)
generators.plucker
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 5/101 (5%)CONDITIONAL 
0/40 (0%)
generators.plucker.unpluck
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/1614 (0%)CONDITIONAL 0/871 
(0%)
generators.poppler
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 615/1275 (48%)CONDITIONAL 
255/781 (33%)
generators.tiff
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 10/219 (5%)CONDITIONAL 
0/121 (0%)
generators.txt
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 13/48 (27%)CONDITIONAL 
2/30 (7%)
generators.xps
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 10/1257 (1%)CONDITIONAL 
1/1221 (0%)
interfaces
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/13 (92%)CONDITIONAL 
8/16 (50%)
shell
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 402/547 (73%)CONDITIONAL 
223/406 (55%)
ui
FILES 35/53 (66%)CLASSES 35/53 (66%)LINE 3962/11624 
(34%)CONDITIONAL 1518/6918 (22%)___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 » Linux,gcc - Build # 36 - Fixed!

2016-07-13 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/36/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 21:49:07 +
Build duration: 5 min 9 sec

CHANGE SET
Revision dd8fa351ce87be2b46243e5de641b9c104a024cc by olivier: (Fonts are 
scanned again by poppler5 Fonts are filtered as well to only)
  change: edit core/fontinfo.cpp
  change: edit core/document.cpp
  change: edit generators/poppler/generator_pdf.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
14 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/22 (91%)FILES 131/258 (51%)CLASSES 131/258 (51%)LINE 12300/37808 
(33%)CONDITIONAL 5478/25002 (22%)

By packages
  

FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 881/1631 
(54%)CONDITIONAL 414/1167 (35%)
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1708/1725 
(99%)CONDITIONAL 941/1760 (53%)
conf
FILES 1/17 (6%)CLASSES 1/17 (6%)LINE 54/829 (7%)CONDITIONAL 
2/284 (1%)
conf.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 17/17 (100%)CONDITIONAL 
7/14 (50%)
core
FILES 41/48 (85%)CLASSES 41/48 (85%)LINE 4347/9114 
(48%)CONDITIONAL 2020/5895 (34%)
core.script
FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/499 (0%)CONDITIONAL 0/230 
(0%)
generators.comicbook
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 10/415 (2%)CONDITIONAL 
0/418 (0%)
generators.djvu
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 26/826 (3%)CONDITIONAL 
3/570 (1%)
generators.dvi
FILES 1/47 (2%)CLASSES 1/47 (2%)LINE 10/3584 (0%)CONDITIONAL 
1/2389 (0%)
generators.epub
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 181/327 (55%)CONDITIONAL 
76/181 (42%)
generators.fax
FILES 1/6 (17%)CLASSES 1/6 (17%)LINE 7/437 (2%)CONDITIONAL 
1/589 (0%)
generators.fictionbook
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 16/534 (3%)CONDITIONAL 
4/432 (1%)
generators.ooo
FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 14/1172 (1%)CONDITIONAL 
2/669 (0%)
generators.plucker
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 5/101 (5%)CONDITIONAL 
0/40 (0%)
generators.plucker.unpluck
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/1614 (0%)CONDITIONAL 0/871 
(0%)
generators.poppler
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 615/1275 (48%)CONDITIONAL 
255/781 (33%)
generators.tiff
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 10/219 (5%)CONDITIONAL 
0/121 (0%)
generators.txt
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 13/48 (27%)CONDITIONAL 
2/30 (7%)
generators.xps
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 10/1257 (1%)CONDITIONAL 
1/1221 (0%)
interfaces
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/13 (92%)CONDITIONAL 
8/16 (50%)
shell
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 402/547 (73%)CONDITIONAL 
223/406 (55%)
ui
FILES 35/53 (66%)CLASSES 35/53 (66%)LINE 3962/11624 
(34%)CONDITIONAL 1518/6918 (22%)___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128441: Fonts are scanned again by poppler5

2016-07-13 Thread Olivier Churlaud 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128441/
---

(Updated July 13, 2016, 9:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl 
Sandsmark.


Changes
---

Submitted with commit dd8fa351ce87be2b46243e5de641b9c104a024cc by Olivier 
CHURLAUD to branch frameworks.


Repository: okular


Description
---

The fonts were not scanned anymore in poppler because the function was 
commented.

2 things to review:
1) I removed in the equality comparaison of FontInfo the native identifier. I 
add to do this because it was always false. If it's wrong to do this, how 
should I do?
2) It's very unefficient to recreate a page iterator for each page instead of 
iterating over the pages directly. (see the code)


Diffs
-

  core/document.cpp af842e1 
  core/fontinfo.cpp 59ea79f 
  generators/poppler/generator_pdf.cpp 3b53f41 

Diff: https://git.reviewboard.kde.org/r/128441/diff/


Testing
---

No influence on tests
Compile, show the fonts


Thanks,

Olivier Churlaud

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128441: Fonts are scanned again by poppler5

2016-07-13 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128441/#review97360
---


Ship it!




Ship It!

- Albert Astals Cid


On July 13, 2016, 6:40 p.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128441/
> ---
> 
> (Updated July 13, 2016, 6:40 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl 
> Sandsmark.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> The fonts were not scanned anymore in poppler because the function was 
> commented.
> 
> 2 things to review:
> 1) I removed in the equality comparaison of FontInfo the native identifier. I 
> add to do this because it was always false. If it's wrong to do this, how 
> should I do?
> 2) It's very unefficient to recreate a page iterator for each page instead of 
> iterating over the pages directly. (see the code)
> 
> 
> Diffs
> -
> 
>   core/document.cpp af842e1 
>   core/fontinfo.cpp 59ea79f 
>   generators/poppler/generator_pdf.cpp 3b53f41 
> 
> Diff: https://git.reviewboard.kde.org/r/128441/diff/
> 
> 
> Testing
> ---
> 
> No influence on tests
> Compile, show the fonts
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Albert Astals Cid 


> On July 13, 2016, 2:04 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > did you run the tests (especially the mainshelltest, which has tests for 
> > the "unique" behaviour?
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> but fwiw, your description of the behaviour seems correct to me, but I 
> think it should be up to Albert to decide what should actually happen.

What should actually happen is what the master branch does.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128436/#review97351
---


On July 13, 2016, 7:06 p.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128436/
> ---
> 
> (Updated July 13, 2016, 7:06 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl 
> Sandsmark.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> As I didn't know what unique was exactly for, here is what I considered (if 
> I'm wrong, please correct me):
> 
> User wants only one instance of okular so he starts it with --unique flag. 
> From now on, every time he starts okular without the flag, it will raise the 
> current instance. Opening a new file /should/ open a tab (currently 
> overwrites the last one).
> 
> In my opinion, if another --unique is started, it should drop the --unique 
> (it is not the case now: it starts a new instance).
> 
> Still to do as I see it: 
>  - open new documents in new tabs by default (in unique mode)
>  - allow opening several documents at once in unique mode
>  - Drop --unique if another session already exist
> 
> 
> Diffs
> -
> 
>   shell/okular_main.cpp 2285f64 
> 
> Diff: https://git.reviewboard.kde.org/r/128436/diff/
> 
> 
> Testing
> ---
> 
> Compile, behave as described above.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 » Linux,gcc - Build # 35 - Unstable!

2016-07-13 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/35/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 13 Jul 2016 19:00:59 +
Build duration: 13 min

CHANGE SET
Revision ec0b68a75672ad2413fefbed81ebe08c46080bd7 by olivier: (Update 
deprecated KArchive method + remove unused variable in)
  change: edit core/document.cpp
  change: edit generators/poppler/generator_pdf.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
14 test(s)Failed: TestSuite.mainshelltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/22 (91%)FILES 131/258 (51%)CLASSES 131/258 (51%)LINE 12291/37805 
(33%)CONDITIONAL 5470/25000 (22%)

By packages
  

FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 881/1631 
(54%)CONDITIONAL 414/1167 (35%)
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1702/1725 
(99%)CONDITIONAL 963/1760 (55%)
conf
FILES 1/17 (6%)CLASSES 1/17 (6%)LINE 54/829 (7%)CONDITIONAL 
2/284 (1%)
conf.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 17/17 (100%)CONDITIONAL 
7/14 (50%)
core
FILES 41/48 (85%)CLASSES 41/48 (85%)LINE 4341/9114 
(48%)CONDITIONAL 2018/5895 (34%)
core.script
FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/499 (0%)CONDITIONAL 0/230 
(0%)
generators.comicbook
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 10/415 (2%)CONDITIONAL 
0/418 (0%)
generators.djvu
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 26/826 (3%)CONDITIONAL 
3/570 (1%)
generators.dvi
FILES 1/47 (2%)CLASSES 1/47 (2%)LINE 10/3584 (0%)CONDITIONAL 
1/2389 (0%)
generators.epub
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 181/327 (55%)CONDITIONAL 
76/181 (42%)
generators.fax
FILES 1/6 (17%)CLASSES 1/6 (17%)LINE 7/437 (2%)CONDITIONAL 
0/589 (0%)
generators.fictionbook
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 16/534 (3%)CONDITIONAL 
4/432 (1%)
generators.ooo
FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 14/1172 (1%)CONDITIONAL 
2/669 (0%)
generators.plucker
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 5/101 (5%)CONDITIONAL 
0/40 (0%)
generators.plucker.unpluck
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/1614 (0%)CONDITIONAL 0/871 
(0%)
generators.poppler
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 615/1272 (48%)CONDITIONAL 
255/779 (33%)
generators.tiff
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 10/219 (5%)CONDITIONAL 
0/121 (0%)
generators.txt
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 13/48 (27%)CONDITIONAL 
2/30 (7%)
generators.xps
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 10/1257 (1%)CONDITIONAL 
1/1221 (0%)
interfaces
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/13 (92%)CONDITIONAL 
8/16 (50%)
shell
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 387/547 (71%)CONDITIONAL 
192/406 (47%)
ui
FILES 35/53 (66%)CLASSES 35/53 (66%)LINE 3980/11624 
(34%)CONDITIONAL 1522/6918 (22%)___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Olivier Churlaud 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128436/
---

(Updated July 13, 2016, 9:06 p.m.)


Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl 
Sandsmark.


Repository: okular


Description
---

As I didn't know what unique was exactly for, here is what I considered (if I'm 
wrong, please correct me):

User wants only one instance of okular so he starts it with --unique flag. From 
now on, every time he starts okular without the flag, it will raise the current 
instance. Opening a new file /should/ open a tab (currently overwrites the last 
one).

In my opinion, if another --unique is started, it should drop the --unique (it 
is not the case now: it starts a new instance).

Still to do as I see it: 
 - open new documents in new tabs by default (in unique mode)
 - allow opening several documents at once in unique mode
 - Drop --unique if another session already exist


Diffs
-

  shell/okular_main.cpp 2285f64 

Diff: https://git.reviewboard.kde.org/r/128436/diff/


Testing
---

Compile, behave as described above.


Thanks,

Olivier Churlaud

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 128441: Fonts are scanned again by poppler5

2016-07-13 Thread Olivier Churlaud 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128441/
---

Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl 
Sandsmark.


Repository: okular


Description
---

The fonts were not scanned anymore in poppler because the function was 
commented.

2 things to review:
1) I removed in the equality comparaison of FontInfo the native identifier. I 
add to do this because it was always false. If it's wrong to do this, how 
should I do?
2) It's very unefficient to recreate a page iterator for each page instead of 
iterating over the pages directly. (see the code)


Diffs
-

  core/document.cpp af842e1 
  core/fontinfo.cpp 59ea79f 
  generators/poppler/generator_pdf.cpp 3b53f41 

Diff: https://git.reviewboard.kde.org/r/128441/diff/


Testing
---

No influence on tests
Compile, show the fonts


Thanks,

Olivier Churlaud

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 365460] PDF Version 1.7 - Document Password needed

2016-07-13 Thread via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=365460

--- Comment #2 from jan-hendrik.reu...@ofd-z.niedersachsen.de ---
Yes, our current okular/poppler seems to be too old. 
Higher versions are working. Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 365460] PDF Version 1.7 - Document Password needed

2016-07-13 Thread via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=365460

jan-hendrik.reu...@ofd-z.niedersachsen.de changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 342735] when viewing .dvi with included .eps files, these .eps figures are shown in wrong places

2016-07-13 Thread Martin Sandsmark via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=342735

--- Comment #8 from Martin Sandsmark  ---
I'm fairly certain that ghostscript either has a regression or somehow changed
behavior. Okular doesn't render the EPS files itself, it just calls
ghostscript:
https://github.com/KDE/okular/blob/master/generators/dvi/psgs.cpp#L147-L292

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Martin Tobias Holmedahl Sandsmark 


> On July 13, 2016, 2:04 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > did you run the tests (especially the mainshelltest, which has tests for 
> > the "unique" behaviour?

but fwiw, your description of the behaviour seems correct to me, but I think it 
should be up to Albert to decide what should actually happen.


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128436/#review97351
---


On July 13, 2016, 10:56 a.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128436/
> ---
> 
> (Updated July 13, 2016, 10:56 a.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl 
> Sandsmark.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> As I didn't know what unique was exactly for, here is what I considered (if 
> I'm wrong, please correct me):
> 
> User wants only one instance of okular so he starts it with --unique flag. 
> From now on, every time he starts okular without the flag, it will raise the 
> current instance. Opening a new file /should/ open a tab (currently 
> overwrites the last one).
> 
> In my opinion, if another --unique is started, it should drop the --unique 
> (it is not the case now: it starts a new instance).
> 
> Still to do as I see it: 
>  - open new documents in new tabs by default (in unique mode)
>  - allow opening several documents at once in unique mode
>  - Drop --unique if another session already exist
> 
> 
> Diffs
> -
> 
>   shell/okular_main.cpp 2285f64 
> 
> Diff: https://git.reviewboard.kde.org/r/128436/diff/
> 
> 
> Testing
> ---
> 
> Compile, behave as described above.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Martin Tobias Holmedahl Sandsmark 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128436/#review97351
---



did you run the tests (especially the mainshelltest, which has tests for the 
"unique" behaviour?

- Martin Tobias Holmedahl Sandsmark


On July 13, 2016, 10:56 a.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128436/
> ---
> 
> (Updated July 13, 2016, 10:56 a.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl 
> Sandsmark.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> As I didn't know what unique was exactly for, here is what I considered (if 
> I'm wrong, please correct me):
> 
> User wants only one instance of okular so he starts it with --unique flag. 
> From now on, every time he starts okular without the flag, it will raise the 
> current instance. Opening a new file /should/ open a tab (currently 
> overwrites the last one).
> 
> In my opinion, if another --unique is started, it should drop the --unique 
> (it is not the case now: it starts a new instance).
> 
> Still to do as I see it: 
>  - open new documents in new tabs by default (in unique mode)
>  - allow opening several documents at once in unique mode
>  - Drop --unique if another session already exist
> 
> 
> Diffs
> -
> 
>   shell/okular_main.cpp 2285f64 
> 
> Diff: https://git.reviewboard.kde.org/r/128436/diff/
> 
> 
> Testing
> ---
> 
> Compile, behave as described above.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

2016-07-13 Thread Martin Sandsmark via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #17 from Martin Sandsmark  ---
Git commit c110c65401a97877eb8b1cd3c6be04e2bdcbc5ec by Martin T. H. Sandsmark.
Committed on 13/07/2016 at 13:41.
Pushed by sandsmark into branch 'frameworks'.

Improve page breaks and batch up cursor edits in epub generator

Patch by Guillaume Maudoux (layus).

M  +14   -11   generators/epub/converter.cpp

http://commits.kde.org/okular/c110c65401a97877eb8b1cd3c6be04e2bdcbc5ec

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 342735] when viewing .dvi with included .eps files, these .eps figures are shown in wrong places

2016-07-13 Thread Andrey Grozin via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=342735

--- Comment #7 from Andrey Grozin  ---
Currently 9.19. When I filed this bug, surely, I had an older version.

I tried to do bisection. Compiled okular-0.14.3 (which was in KDE SC 4.8.4)
which was mentioned in comment #3.  But the bug was already present. I have not
compiled the whole KDE SC 4.8.4 together with all libraries and programs on
which okular depends. So, it seems that the bug is *not* in okular itself.
Behaviour of some external library or program has changed some time ago, and
induced the buggy behaviour in okular.

I'll try to compile some old version of ghostscript. Does anybody know what
version of ghostscript was in Debian 7.8?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 128436: Restore --unique behavior

2016-07-13 Thread Olivier Churlaud 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128436/
---

Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl 
Sandsmark.


Repository: okular


Description
---

As I didn't know what unique was exactly for, here is what I considered (if I'm 
wrong, please correct me):

User wants only one instance of okular so he starts it with --unique flag. From 
now on, every time he starts okular without the flag, it will raise the current 
instance. Opening a new file /should/ open a tab (currently overwrites the last 
one).

In my opinion, if another --unique is started, it should drop the --unique (it 
is not the case now: it starts a new instance).

Still to do as I see it: 
 - open new documents in new tabs by default (in unique mode)
 - allow opening several documents at once in unique mode
 - Drop --unique if another session already exist


Diffs
-

  shell/okular_main.cpp 2285f64 

Diff: https://git.reviewboard.kde.org/r/128436/diff/


Testing
---

Compile, behave as described above.


Thanks,

Olivier Churlaud

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel