Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-09-08 Thread Yichao Zhou

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated set. 8, 2014, 2:33 p.m.)


Status
--

This change has been discarded.


Review request for Okular.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-04-29 Thread Yichao Zhou


 On April 28, 2014, 10:09 p.m., Albert Astals Cid wrote:
  Hmmm, Yichao, there's still work to be done about this, no? At least it 
  seems to me we had a conversation in Feb 7 that needed you to do some 
  changes and the last diff is from Feb 4.

Yes.  I will do that.  But as an student I'm a little busy this semester.  I 
think I will finish all these patches in June.


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review56802
---


On Feb. 4, 2014, 4:39 a.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Feb. 4, 2014, 4:39 a.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   conf/dlgaccessibilitybase.ui 9e76a75 
   conf/okular.kcfg deabd07 
   ui/pageview.h 9c15af6 
   ui/pageview.cpp 65967bf 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-04-29 Thread Albert Astals Cid


 On April 28, 2014, 10:09 p.m., Albert Astals Cid wrote:
  Hmmm, Yichao, there's still work to be done about this, no? At least it 
  seems to me we had a conversation in Feb 7 that needed you to do some 
  changes and the last diff is from Feb 4.
 
 Yichao Zhou wrote:
 Yes.  I will do that.  But as an student I'm a little busy this semester. 
  I think I will finish all these patches in June.

No worries :)


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review56802
---


On Feb. 4, 2014, 4:39 a.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Feb. 4, 2014, 4:39 a.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   conf/dlgaccessibilitybase.ui 9e76a75 
   conf/okular.kcfg deabd07 
   ui/pageview.h 9c15af6 
   ui/pageview.cpp 65967bf 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-04-28 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review56802
---


Hmmm, Yichao, there's still work to be done about this, no? At least it seems 
to me we had a conversation in Feb 7 that needed you to do some changes and the 
last diff is from Feb 4. 

- Albert Astals Cid


On Feb. 4, 2014, 4:39 a.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Feb. 4, 2014, 4:39 a.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   conf/dlgaccessibilitybase.ui 9e76a75 
   conf/okular.kcfg deabd07 
   ui/pageview.h 9c15af6 
   ui/pageview.cpp 65967bf 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-06 Thread Albert Astals Cid


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 4485
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485
 
  Can you explain why the need for a timer?
 
 Yichao Zhou wrote:
 This is because, in scroll mode, user just moves their mouse a little bit 
 and then does nothing.  The screen will automatically scroll until user exits 
 scroll mode (by another mouse click).
 
 In order to let the screen scroll duratively, you will need a timer.
 
 Albert Astals Cid wrote:
 And this is why the whole bug makes no sense. Okular already has a way to 
 scroll that is using the left mouse button. And now you want to make the fact 
 that middle mouse button also scrolls but in a different way. This makes no 
 sense at all. I'm not going to continue reviewing this unless someone 
 explains me why Okular should have two different ways of scrolling.
 
 Yichao Zhou wrote:
 I do not quite understand this.  How can I use the left mouse to do 
 scroll?  If you mean in Broswer mode and use the mouse to drag the page, 
 then I can argue that
 
 1.  Using the middle mouse is more suitable when you want to scroll a 
 large distance.   The drag method is not very convenient when you want to 
 scroll more than a screen:  you need to move the mouse to the bottom of the 
 screen, drag it to the top and then repeat this until you scroll to your 
 target.  _You need move your mouse a lot_.  But for middle mouse, it is 
 relatively simpler:  You do a middle click.  Then you move you mouse down a 
 little bit (the scroll speed is determined by this displacement).  Then the 
 page starts to scroll.  You wait until the page scrolls to the target 
 position and then you do another click to stop the scroll.  _You do not need 
 to move your mouse a lot and you can achieve a higher scroll speed than using 
 left mouse's method_.
 
 2.  For people migrated from adobe reader (or Windows), they maybe more 
 happier using middle wheel to scroll according to their habit.  (Although 
 this is short, I think this is the main reason people request this feature on 
 the KDE Bugtracking System).
 
 3.  Using middle mouse to scroll works in all mode including the 
 Broswer mode.
 
 Albert Astals Cid wrote:
 1. Really? Have you even tried Okular? Because you do *not* need to drag 
 your mouse to the top...
 
 2. Do you know of any other app that uses that totally non standard way 
 of scrolling?
 
 3. So?
 
 Yichao Zhou wrote:
 1.  I have said I do not quite understand what you mean by scroll using 
 the left mouse button.  I only know I can drag the page, which really needs 
 me to move my mouse up a lot if I want to scroll *a large distance down*.  
 (Of course I can just set the page number or use the page up/down button, but 
 that also requires me to move my mouse for viewer to toolbar, which may not 
 be a small distance.)  If I'm wrong, maybe you could described the desired 
 behaviour of okular so I can see if I'm missing any feature.
 
 2.  
   (a).  Firefox, there is an option Use autoscrolling, which enables 
 you to use this way of scrolling.
   (b).  Libreoffice, I'm sure there is also a similar setting,  even 
 through middle click is important because it is a paste command by default, 
 which is not a problem for Okular.
   (c).  Evince, the gnome's pdf reader also enable you using middle click 
 to scroll *by default*.  Although its behaviour is a bit different compared 
 to this patch, it is at least compatible to people's habit. 
 
   What I list are the applications under Linux.  Almost all the 
 applications under Windows Operation System use this method to scroll, like 
 Adobe reader, firefox, chrome, IE, Office and [[name any application using 
 scroll heavily]].  Maybe it is a non standard way of scrolling under X, it is 
 definitely the de facto scroll standard (except for using wheel) under 
 Windows without doubt.
 
   When I was new to okular (and Linux), the accidental resize of the 
 document when you want to scroll is really really annoying!  Although it is 
 accpetable for me,  since I'm used to use the wheel to scroll the page under 
 Okular now.  I just want to share a patch which may solve the similar problem 
 that I have suffered!
 
   In fact, in application such as Web Browser and Document Reader, what 
 people mainly does is just scrolling page down!  Maybe you do not really need 
 it;  maybe the code in pageview.h is in a little disorder now; but IMHO it 
 totally is worth it!
 
 3.  So maybe it is more convenient for some people?  People do not need 
 to switch back for scroll if they want to stay, for example, at text 
 selection mode?  (I pretty like to stay at text selection mode since I can 
 highlight the text that I'm reading.)
 
 Albert Astals Cid wrote:
 1. You said You need to move the mouse to the bottom of the screen, 

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-06 Thread Yichao Zhou


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 4485
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485
 
  Can you explain why the need for a timer?
 
 Yichao Zhou wrote:
 This is because, in scroll mode, user just moves their mouse a little bit 
 and then does nothing.  The screen will automatically scroll until user exits 
 scroll mode (by another mouse click).
 
 In order to let the screen scroll duratively, you will need a timer.
 
 Albert Astals Cid wrote:
 And this is why the whole bug makes no sense. Okular already has a way to 
 scroll that is using the left mouse button. And now you want to make the fact 
 that middle mouse button also scrolls but in a different way. This makes no 
 sense at all. I'm not going to continue reviewing this unless someone 
 explains me why Okular should have two different ways of scrolling.
 
 Yichao Zhou wrote:
 I do not quite understand this.  How can I use the left mouse to do 
 scroll?  If you mean in Broswer mode and use the mouse to drag the page, 
 then I can argue that
 
 1.  Using the middle mouse is more suitable when you want to scroll a 
 large distance.   The drag method is not very convenient when you want to 
 scroll more than a screen:  you need to move the mouse to the bottom of the 
 screen, drag it to the top and then repeat this until you scroll to your 
 target.  _You need move your mouse a lot_.  But for middle mouse, it is 
 relatively simpler:  You do a middle click.  Then you move you mouse down a 
 little bit (the scroll speed is determined by this displacement).  Then the 
 page starts to scroll.  You wait until the page scrolls to the target 
 position and then you do another click to stop the scroll.  _You do not need 
 to move your mouse a lot and you can achieve a higher scroll speed than using 
 left mouse's method_.
 
 2.  For people migrated from adobe reader (or Windows), they maybe more 
 happier using middle wheel to scroll according to their habit.  (Although 
 this is short, I think this is the main reason people request this feature on 
 the KDE Bugtracking System).
 
 3.  Using middle mouse to scroll works in all mode including the 
 Broswer mode.
 
 Albert Astals Cid wrote:
 1. Really? Have you even tried Okular? Because you do *not* need to drag 
 your mouse to the top...
 
 2. Do you know of any other app that uses that totally non standard way 
 of scrolling?
 
 3. So?
 
 Yichao Zhou wrote:
 1.  I have said I do not quite understand what you mean by scroll using 
 the left mouse button.  I only know I can drag the page, which really needs 
 me to move my mouse up a lot if I want to scroll *a large distance down*.  
 (Of course I can just set the page number or use the page up/down button, but 
 that also requires me to move my mouse for viewer to toolbar, which may not 
 be a small distance.)  If I'm wrong, maybe you could described the desired 
 behaviour of okular so I can see if I'm missing any feature.
 
 2.  
   (a).  Firefox, there is an option Use autoscrolling, which enables 
 you to use this way of scrolling.
   (b).  Libreoffice, I'm sure there is also a similar setting,  even 
 through middle click is important because it is a paste command by default, 
 which is not a problem for Okular.
   (c).  Evince, the gnome's pdf reader also enable you using middle click 
 to scroll *by default*.  Although its behaviour is a bit different compared 
 to this patch, it is at least compatible to people's habit. 
 
   What I list are the applications under Linux.  Almost all the 
 applications under Windows Operation System use this method to scroll, like 
 Adobe reader, firefox, chrome, IE, Office and [[name any application using 
 scroll heavily]].  Maybe it is a non standard way of scrolling under X, it is 
 definitely the de facto scroll standard (except for using wheel) under 
 Windows without doubt.
 
   When I was new to okular (and Linux), the accidental resize of the 
 document when you want to scroll is really really annoying!  Although it is 
 accpetable for me,  since I'm used to use the wheel to scroll the page under 
 Okular now.  I just want to share a patch which may solve the similar problem 
 that I have suffered!
 
   In fact, in application such as Web Browser and Document Reader, what 
 people mainly does is just scrolling page down!  Maybe you do not really need 
 it;  maybe the code in pageview.h is in a little disorder now; but IMHO it 
 totally is worth it!
 
 3.  So maybe it is more convenient for some people?  People do not need 
 to switch back for scroll if they want to stay, for example, at text 
 selection mode?  (I pretty like to stay at text selection mode since I can 
 highlight the text that I'm reading.)
 
 Albert Astals Cid wrote:
 1. You said You need to move the mouse to the bottom of the screen, 

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-06 Thread Albert Astals Cid


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 4485
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485
 
  Can you explain why the need for a timer?
 
 Yichao Zhou wrote:
 This is because, in scroll mode, user just moves their mouse a little bit 
 and then does nothing.  The screen will automatically scroll until user exits 
 scroll mode (by another mouse click).
 
 In order to let the screen scroll duratively, you will need a timer.
 
 Albert Astals Cid wrote:
 And this is why the whole bug makes no sense. Okular already has a way to 
 scroll that is using the left mouse button. And now you want to make the fact 
 that middle mouse button also scrolls but in a different way. This makes no 
 sense at all. I'm not going to continue reviewing this unless someone 
 explains me why Okular should have two different ways of scrolling.
 
 Yichao Zhou wrote:
 I do not quite understand this.  How can I use the left mouse to do 
 scroll?  If you mean in Broswer mode and use the mouse to drag the page, 
 then I can argue that
 
 1.  Using the middle mouse is more suitable when you want to scroll a 
 large distance.   The drag method is not very convenient when you want to 
 scroll more than a screen:  you need to move the mouse to the bottom of the 
 screen, drag it to the top and then repeat this until you scroll to your 
 target.  _You need move your mouse a lot_.  But for middle mouse, it is 
 relatively simpler:  You do a middle click.  Then you move you mouse down a 
 little bit (the scroll speed is determined by this displacement).  Then the 
 page starts to scroll.  You wait until the page scrolls to the target 
 position and then you do another click to stop the scroll.  _You do not need 
 to move your mouse a lot and you can achieve a higher scroll speed than using 
 left mouse's method_.
 
 2.  For people migrated from adobe reader (or Windows), they maybe more 
 happier using middle wheel to scroll according to their habit.  (Although 
 this is short, I think this is the main reason people request this feature on 
 the KDE Bugtracking System).
 
 3.  Using middle mouse to scroll works in all mode including the 
 Broswer mode.
 
 Albert Astals Cid wrote:
 1. Really? Have you even tried Okular? Because you do *not* need to drag 
 your mouse to the top...
 
 2. Do you know of any other app that uses that totally non standard way 
 of scrolling?
 
 3. So?
 
 Yichao Zhou wrote:
 1.  I have said I do not quite understand what you mean by scroll using 
 the left mouse button.  I only know I can drag the page, which really needs 
 me to move my mouse up a lot if I want to scroll *a large distance down*.  
 (Of course I can just set the page number or use the page up/down button, but 
 that also requires me to move my mouse for viewer to toolbar, which may not 
 be a small distance.)  If I'm wrong, maybe you could described the desired 
 behaviour of okular so I can see if I'm missing any feature.
 
 2.  
   (a).  Firefox, there is an option Use autoscrolling, which enables 
 you to use this way of scrolling.
   (b).  Libreoffice, I'm sure there is also a similar setting,  even 
 through middle click is important because it is a paste command by default, 
 which is not a problem for Okular.
   (c).  Evince, the gnome's pdf reader also enable you using middle click 
 to scroll *by default*.  Although its behaviour is a bit different compared 
 to this patch, it is at least compatible to people's habit. 
 
   What I list are the applications under Linux.  Almost all the 
 applications under Windows Operation System use this method to scroll, like 
 Adobe reader, firefox, chrome, IE, Office and [[name any application using 
 scroll heavily]].  Maybe it is a non standard way of scrolling under X, it is 
 definitely the de facto scroll standard (except for using wheel) under 
 Windows without doubt.
 
   When I was new to okular (and Linux), the accidental resize of the 
 document when you want to scroll is really really annoying!  Although it is 
 accpetable for me,  since I'm used to use the wheel to scroll the page under 
 Okular now.  I just want to share a patch which may solve the similar problem 
 that I have suffered!
 
   In fact, in application such as Web Browser and Document Reader, what 
 people mainly does is just scrolling page down!  Maybe you do not really need 
 it;  maybe the code in pageview.h is in a little disorder now; but IMHO it 
 totally is worth it!
 
 3.  So maybe it is more convenient for some people?  People do not need 
 to switch back for scroll if they want to stay, for example, at text 
 selection mode?  (I pretty like to stay at text selection mode since I can 
 highlight the text that I'm reading.)
 
 Albert Astals Cid wrote:
 1. You said You need to move the mouse to the bottom of the screen, 

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-05 Thread Albert Astals Cid


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 4485
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485
 
  Can you explain why the need for a timer?
 
 Yichao Zhou wrote:
 This is because, in scroll mode, user just moves their mouse a little bit 
 and then does nothing.  The screen will automatically scroll until user exits 
 scroll mode (by another mouse click).
 
 In order to let the screen scroll duratively, you will need a timer.
 
 Albert Astals Cid wrote:
 And this is why the whole bug makes no sense. Okular already has a way to 
 scroll that is using the left mouse button. And now you want to make the fact 
 that middle mouse button also scrolls but in a different way. This makes no 
 sense at all. I'm not going to continue reviewing this unless someone 
 explains me why Okular should have two different ways of scrolling.
 
 Yichao Zhou wrote:
 I do not quite understand this.  How can I use the left mouse to do 
 scroll?  If you mean in Broswer mode and use the mouse to drag the page, 
 then I can argue that
 
 1.  Using the middle mouse is more suitable when you want to scroll a 
 large distance.   The drag method is not very convenient when you want to 
 scroll more than a screen:  you need to move the mouse to the bottom of the 
 screen, drag it to the top and then repeat this until you scroll to your 
 target.  _You need move your mouse a lot_.  But for middle mouse, it is 
 relatively simpler:  You do a middle click.  Then you move you mouse down a 
 little bit (the scroll speed is determined by this displacement).  Then the 
 page starts to scroll.  You wait until the page scrolls to the target 
 position and then you do another click to stop the scroll.  _You do not need 
 to move your mouse a lot and you can achieve a higher scroll speed than using 
 left mouse's method_.
 
 2.  For people migrated from adobe reader (or Windows), they maybe more 
 happier using middle wheel to scroll according to their habit.  (Although 
 this is short, I think this is the main reason people request this feature on 
 the KDE Bugtracking System).
 
 3.  Using middle mouse to scroll works in all mode including the 
 Broswer mode.
 
 Albert Astals Cid wrote:
 1. Really? Have you even tried Okular? Because you do *not* need to drag 
 your mouse to the top...
 
 2. Do you know of any other app that uses that totally non standard way 
 of scrolling?
 
 3. So?
 
 Yichao Zhou wrote:
 1.  I have said I do not quite understand what you mean by scroll using 
 the left mouse button.  I only know I can drag the page, which really needs 
 me to move my mouse up a lot if I want to scroll *a large distance down*.  
 (Of course I can just set the page number or use the page up/down button, but 
 that also requires me to move my mouse for viewer to toolbar, which may not 
 be a small distance.)  If I'm wrong, maybe you could described the desired 
 behaviour of okular so I can see if I'm missing any feature.
 
 2.  
   (a).  Firefox, there is an option Use autoscrolling, which enables 
 you to use this way of scrolling.
   (b).  Libreoffice, I'm sure there is also a similar setting,  even 
 through middle click is important because it is a paste command by default, 
 which is not a problem for Okular.
   (c).  Evince, the gnome's pdf reader also enable you using middle click 
 to scroll *by default*.  Although its behaviour is a bit different compared 
 to this patch, it is at least compatible to people's habit. 
 
   What I list are the applications under Linux.  Almost all the 
 applications under Windows Operation System use this method to scroll, like 
 Adobe reader, firefox, chrome, IE, Office and [[name any application using 
 scroll heavily]].  Maybe it is a non standard way of scrolling under X, it is 
 definitely the de facto scroll standard (except for using wheel) under 
 Windows without doubt.
 
   When I was new to okular (and Linux), the accidental resize of the 
 document when you want to scroll is really really annoying!  Although it is 
 accpetable for me,  since I'm used to use the wheel to scroll the page under 
 Okular now.  I just want to share a patch which may solve the similar problem 
 that I have suffered!
 
   In fact, in application such as Web Browser and Document Reader, what 
 people mainly does is just scrolling page down!  Maybe you do not really need 
 it;  maybe the code in pageview.h is in a little disorder now; but IMHO it 
 totally is worth it!
 
 3.  So maybe it is more convenient for some people?  People do not need 
 to switch back for scroll if they want to stay, for example, at text 
 selection mode?  (I pretty like to stay at text selection mode since I can 
 highlight the text that I'm reading.)

1. You said You need to move the mouse to the bottom of the screen, drag it to 
the top and then 

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-05 Thread Yichao Zhou


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 4485
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485
 
  Can you explain why the need for a timer?
 
 Yichao Zhou wrote:
 This is because, in scroll mode, user just moves their mouse a little bit 
 and then does nothing.  The screen will automatically scroll until user exits 
 scroll mode (by another mouse click).
 
 In order to let the screen scroll duratively, you will need a timer.
 
 Albert Astals Cid wrote:
 And this is why the whole bug makes no sense. Okular already has a way to 
 scroll that is using the left mouse button. And now you want to make the fact 
 that middle mouse button also scrolls but in a different way. This makes no 
 sense at all. I'm not going to continue reviewing this unless someone 
 explains me why Okular should have two different ways of scrolling.
 
 Yichao Zhou wrote:
 I do not quite understand this.  How can I use the left mouse to do 
 scroll?  If you mean in Broswer mode and use the mouse to drag the page, 
 then I can argue that
 
 1.  Using the middle mouse is more suitable when you want to scroll a 
 large distance.   The drag method is not very convenient when you want to 
 scroll more than a screen:  you need to move the mouse to the bottom of the 
 screen, drag it to the top and then repeat this until you scroll to your 
 target.  _You need move your mouse a lot_.  But for middle mouse, it is 
 relatively simpler:  You do a middle click.  Then you move you mouse down a 
 little bit (the scroll speed is determined by this displacement).  Then the 
 page starts to scroll.  You wait until the page scrolls to the target 
 position and then you do another click to stop the scroll.  _You do not need 
 to move your mouse a lot and you can achieve a higher scroll speed than using 
 left mouse's method_.
 
 2.  For people migrated from adobe reader (or Windows), they maybe more 
 happier using middle wheel to scroll according to their habit.  (Although 
 this is short, I think this is the main reason people request this feature on 
 the KDE Bugtracking System).
 
 3.  Using middle mouse to scroll works in all mode including the 
 Broswer mode.
 
 Albert Astals Cid wrote:
 1. Really? Have you even tried Okular? Because you do *not* need to drag 
 your mouse to the top...
 
 2. Do you know of any other app that uses that totally non standard way 
 of scrolling?
 
 3. So?
 
 Yichao Zhou wrote:
 1.  I have said I do not quite understand what you mean by scroll using 
 the left mouse button.  I only know I can drag the page, which really needs 
 me to move my mouse up a lot if I want to scroll *a large distance down*.  
 (Of course I can just set the page number or use the page up/down button, but 
 that also requires me to move my mouse for viewer to toolbar, which may not 
 be a small distance.)  If I'm wrong, maybe you could described the desired 
 behaviour of okular so I can see if I'm missing any feature.
 
 2.  
   (a).  Firefox, there is an option Use autoscrolling, which enables 
 you to use this way of scrolling.
   (b).  Libreoffice, I'm sure there is also a similar setting,  even 
 through middle click is important because it is a paste command by default, 
 which is not a problem for Okular.
   (c).  Evince, the gnome's pdf reader also enable you using middle click 
 to scroll *by default*.  Although its behaviour is a bit different compared 
 to this patch, it is at least compatible to people's habit. 
 
   What I list are the applications under Linux.  Almost all the 
 applications under Windows Operation System use this method to scroll, like 
 Adobe reader, firefox, chrome, IE, Office and [[name any application using 
 scroll heavily]].  Maybe it is a non standard way of scrolling under X, it is 
 definitely the de facto scroll standard (except for using wheel) under 
 Windows without doubt.
 
   When I was new to okular (and Linux), the accidental resize of the 
 document when you want to scroll is really really annoying!  Although it is 
 accpetable for me,  since I'm used to use the wheel to scroll the page under 
 Okular now.  I just want to share a patch which may solve the similar problem 
 that I have suffered!
 
   In fact, in application such as Web Browser and Document Reader, what 
 people mainly does is just scrolling page down!  Maybe you do not really need 
 it;  maybe the code in pageview.h is in a little disorder now; but IMHO it 
 totally is worth it!
 
 3.  So maybe it is more convenient for some people?  People do not need 
 to switch back for scroll if they want to stay, for example, at text 
 selection mode?  (I pretty like to stay at text selection mode since I can 
 highlight the text that I'm reading.)
 
 Albert Astals Cid wrote:
 1. You said You need to move the mouse to the bottom of the screen, 

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-04 Thread Albert Astals Cid


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 4485
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485
 
  Can you explain why the need for a timer?
 
 Yichao Zhou wrote:
 This is because, in scroll mode, user just moves their mouse a little bit 
 and then does nothing.  The screen will automatically scroll until user exits 
 scroll mode (by another mouse click).
 
 In order to let the screen scroll duratively, you will need a timer.
 
 Albert Astals Cid wrote:
 And this is why the whole bug makes no sense. Okular already has a way to 
 scroll that is using the left mouse button. And now you want to make the fact 
 that middle mouse button also scrolls but in a different way. This makes no 
 sense at all. I'm not going to continue reviewing this unless someone 
 explains me why Okular should have two different ways of scrolling.
 
 Yichao Zhou wrote:
 I do not quite understand this.  How can I use the left mouse to do 
 scroll?  If you mean in Broswer mode and use the mouse to drag the page, 
 then I can argue that
 
 1.  Using the middle mouse is more suitable when you want to scroll a 
 large distance.   The drag method is not very convenient when you want to 
 scroll more than a screen:  you need to move the mouse to the bottom of the 
 screen, drag it to the top and then repeat this until you scroll to your 
 target.  _You need move your mouse a lot_.  But for middle mouse, it is 
 relatively simpler:  You do a middle click.  Then you move you mouse down a 
 little bit (the scroll speed is determined by this displacement).  Then the 
 page starts to scroll.  You wait until the page scrolls to the target 
 position and then you do another click to stop the scroll.  _You do not need 
 to move your mouse a lot and you can achieve a higher scroll speed than using 
 left mouse's method_.
 
 2.  For people migrated from adobe reader (or Windows), they maybe more 
 happier using middle wheel to scroll according to their habit.  (Although 
 this is short, I think this is the main reason people request this feature on 
 the KDE Bugtracking System).
 
 3.  Using middle mouse to scroll works in all mode including the 
 Broswer mode.

1. Really? Have you even tried Okular? Because you do *not* need to drag your 
mouse to the top...

2. Do you know of any other app that uses that totally non standard way of 
scrolling?

3. So?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Feb. 4, 2014, 4:39 a.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Feb. 4, 2014, 4:39 a.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   conf/dlgaccessibilitybase.ui 9e76a75 
   conf/okular.kcfg deabd07 
   ui/pageview.h 9c15af6 
   ui/pageview.cpp 65967bf 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-04 Thread Yichao Zhou


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 4485
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485
 
  Can you explain why the need for a timer?
 
 Yichao Zhou wrote:
 This is because, in scroll mode, user just moves their mouse a little bit 
 and then does nothing.  The screen will automatically scroll until user exits 
 scroll mode (by another mouse click).
 
 In order to let the screen scroll duratively, you will need a timer.
 
 Albert Astals Cid wrote:
 And this is why the whole bug makes no sense. Okular already has a way to 
 scroll that is using the left mouse button. And now you want to make the fact 
 that middle mouse button also scrolls but in a different way. This makes no 
 sense at all. I'm not going to continue reviewing this unless someone 
 explains me why Okular should have two different ways of scrolling.
 
 Yichao Zhou wrote:
 I do not quite understand this.  How can I use the left mouse to do 
 scroll?  If you mean in Broswer mode and use the mouse to drag the page, 
 then I can argue that
 
 1.  Using the middle mouse is more suitable when you want to scroll a 
 large distance.   The drag method is not very convenient when you want to 
 scroll more than a screen:  you need to move the mouse to the bottom of the 
 screen, drag it to the top and then repeat this until you scroll to your 
 target.  _You need move your mouse a lot_.  But for middle mouse, it is 
 relatively simpler:  You do a middle click.  Then you move you mouse down a 
 little bit (the scroll speed is determined by this displacement).  Then the 
 page starts to scroll.  You wait until the page scrolls to the target 
 position and then you do another click to stop the scroll.  _You do not need 
 to move your mouse a lot and you can achieve a higher scroll speed than using 
 left mouse's method_.
 
 2.  For people migrated from adobe reader (or Windows), they maybe more 
 happier using middle wheel to scroll according to their habit.  (Although 
 this is short, I think this is the main reason people request this feature on 
 the KDE Bugtracking System).
 
 3.  Using middle mouse to scroll works in all mode including the 
 Broswer mode.
 
 Albert Astals Cid wrote:
 1. Really? Have you even tried Okular? Because you do *not* need to drag 
 your mouse to the top...
 
 2. Do you know of any other app that uses that totally non standard way 
 of scrolling?
 
 3. So?

1.  I have said I do not quite understand what you mean by scroll using the 
left mouse button.  I only know I can drag the page, which really needs me to 
move my mouse up a lot if I want to scroll *a large distance down*.  (Of course 
I can just set the page number or use the page up/down button, but that also 
requires me to move my mouse for viewer to toolbar, which may not be a small 
distance.)  If I'm wrong, maybe you could described the desired behaviour of 
okular so I can see if I'm missing any feature.

2.  
  (a).  Firefox, there is an option Use autoscrolling, which enables you to 
use this way of scrolling.
  (b).  Libreoffice, I'm sure there is also a similar setting,  even through 
middle click is important because it is a paste command by default, which is 
not a problem for Okular.
  (c).  Evince, the gnome's pdf reader also enable you using middle click to 
scroll *by default*.  Although its behaviour is a bit different compared to 
this patch, it is at least compatible to people's habit. 

  What I list are the applications under Linux.  Almost all the applications 
under Windows Operation System use this method to scroll, like Adobe reader, 
firefox, chrome, IE, Office and [[name any application using scroll heavily]].  
Maybe it is a non standard way of scrolling under X, it is definitely the de 
facto scroll standard (except for using wheel) under Windows without doubt.

  When I was new to okular (and Linux), the accidental resize of the document 
when you want to scroll is really really annoying!  Although it is accpetable 
for me,  since I'm used to use the wheel to scroll the page under Okular now.  
I just want to share a patch which may solve the similar problem that I have 
suffered!

  In fact, in application such as Web Browser and Document Reader, what people 
mainly does is just scrolling page down!  Maybe you do not really need it;  
maybe the code in pageview.h is in a little disorder now; but IMHO it totally 
is worth it!

3.  So maybe it is more convenient for some people?  People do not need to 
switch back for scroll if they want to stay, for example, at text selection 
mode?  (I pretty like to stay at text selection mode since I can highlight the 
text that I'm reading.)


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-03 Thread Albert Astals Cid


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 4485
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485
 
  Can you explain why the need for a timer?
 
 Yichao Zhou wrote:
 This is because, in scroll mode, user just moves their mouse a little bit 
 and then does nothing.  The screen will automatically scroll until user exits 
 scroll mode (by another mouse click).
 
 In order to let the screen scroll duratively, you will need a timer.

And this is why the whole bug makes no sense. Okular already has a way to 
scroll that is using the left mouse button. And now you want to make the fact 
that middle mouse button also scrolls but in a different way. This makes no 
sense at all. I'm not going to continue reviewing this unless someone explains 
me why Okular should have two different ways of scrolling.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Jan. 28, 2014, 7:02 a.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Jan. 28, 2014, 7:02 a.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   conf/dlgaccessibilitybase.ui 9e76a75 
   conf/okular.kcfg deabd07 
   ui/pageview.h 9c15af6 
   ui/pageview.cpp 65967bf 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-03 Thread Yichao Zhou


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 4485
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485
 
  Can you explain why the need for a timer?
 
 Yichao Zhou wrote:
 This is because, in scroll mode, user just moves their mouse a little bit 
 and then does nothing.  The screen will automatically scroll until user exits 
 scroll mode (by another mouse click).
 
 In order to let the screen scroll duratively, you will need a timer.
 
 Albert Astals Cid wrote:
 And this is why the whole bug makes no sense. Okular already has a way to 
 scroll that is using the left mouse button. And now you want to make the fact 
 that middle mouse button also scrolls but in a different way. This makes no 
 sense at all. I'm not going to continue reviewing this unless someone 
 explains me why Okular should have two different ways of scrolling.

I do not quite understand this.  How can I use the left mouse to do scroll?  If 
you mean in Broswer mode and use the mouse to drag the page, then I can argue 
that

1.  Using the middle mouse is more suitable when you want to scroll a large 
distance.   The drag method is not very convenient when you want to scroll 
more than a screen:  you need to move the mouse to the bottom of the screen, 
drag it to the top and then repeat this until you scroll to your target.  _You 
need move your mouse a lot_.  But for middle mouse, it is relatively simpler:  
You do a middle click.  Then you move you mouse down a little bit (the scroll 
speed is determined by this displacement).  Then the page starts to scroll.  
You wait until the page scrolls to the target position and then you do another 
click to stop the scroll.  _You do not need to move your mouse a lot and you 
can achieve a higher scroll speed than using left mouse's method_.

2.  For people migrated from adobe reader (or Windows), they maybe more happier 
using middle wheel to scroll according to their habit.  (Although this is 
short, I think this is the main reason people request this feature on the KDE 
Bugtracking System).

3.  Using middle mouse to scroll works in all mode including the Broswer mode.


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Jan. 28, 2014, 7:02 a.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Jan. 28, 2014, 7:02 a.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   conf/dlgaccessibilitybase.ui 9e76a75 
   conf/okular.kcfg deabd07 
   ui/pageview.h 9c15af6 
   ui/pageview.cpp 65967bf 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-03 Thread Yichao Zhou

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Feb. 4, 2014, 4:28 a.m.)


Review request for Okular.


Changes
---

Bug Fix: now scroll works correctly after a single middle click.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-02-03 Thread Yichao Zhou

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Feb. 4, 2014, 4:39 a.m.)


Review request for Okular.


Changes
---

Add d-mousePressPos = QPoint(); before every 
d-middleMouseScrollTimer-stop();


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-31 Thread Yichao Zhou


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  * In scroll mode, now okular can load new page correctly
  
  What does this mean?
 
 Yichao Zhou wrote:
 It means that the orignal patch in Bugs 219121 will not load new page due 
 to the guard code in PageView::slotRequestVisiblePixmaps().

Hello!

I have implemented an another prototype feature for smooth scroll: 
https://bugs.kde.org/show_bug.cgi?id=319870

The problem is I need to modify the UI so I can add some configuration.  I need 
to add some configuration under the accessibility configuration page again.  
But adding it on the master branch will conflict with this one, since git 
cannot handle UI written in XML.  Should I build my smooth scroll patch based 
on this patch?

Maybe we should add another configuration page for Control Setting since 
Accessibility is not a very appropriate name for them.


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Jan. 28, 2014, 7:02 a.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Jan. 28, 2014, 7:02 a.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   conf/dlgaccessibilitybase.ui 9e76a75 
   conf/okular.kcfg deabd07 
   ui/pageview.h 9c15af6 
   ui/pageview.cpp 65967bf 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


* In scroll mode, now okular can load new page correctly

What does this mean?


conf/dlgaccessibilitybase.ui
https://git.reviewboard.kde.org/r/115335/#comment34237

Click - Press? See below



conf/okular.kcfg
https://git.reviewboard.kde.org/r/115335/#comment34236

What About MiddlePress and not MiddleClick? Since it's more about stuff 
that happens when you press the button and not release it yet more than stuff 
that happens on click



ui/pageview.h
https://git.reviewboard.kde.org/r/115335/#comment34234

missing r in Scoll



ui/pageview.cpp
https://git.reviewboard.kde.org/r/115335/#comment34235

const

Also not sure i like he zoomAllowed name, what about middlePressZooms?



ui/pageview.cpp
https://git.reviewboard.kde.org/r/115335/#comment34238

What's the change in this block?



ui/pageview.cpp
https://git.reviewboard.kde.org/r/115335/#comment34239

Since you're repeating these blocks over and over you may want to add it 
into a quick function maybe, so that if in the future we need to change 
something we don't mistakingly forget one of the places.



ui/pageview.cpp
https://git.reviewboard.kde.org/r/115335/#comment34240

Can you explain why the need for a timer?



ui/pageview.cpp
https://git.reviewboard.kde.org/r/115335/#comment34241

repaint is a bit bad, does update work?


- Albert Astals Cid


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Jan. 27, 2014, 5:13 p.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   ui/pageview.cpp 65967bf 
   ui/pageview.h 9c15af6 
   conf/okular.kcfg deabd07 
   conf/dlgaccessibilitybase.ui 9e76a75 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 2112
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line2112
 
  What's the change in this block?
 
 Yichao Zhou wrote:
 The indentation of that line is not correct.  It just lets me feel bad.

The indentation of that line is not correct.  It just lets me feel bad.


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 2112
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line2112
 
  What's the change in this block?
 
 Yichao Zhou wrote:
 The indentation of that line is not correct.  It just lets me feel bad.

The indentation of that line is not correct.  It just lets me feel bad.


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Jan. 27, 2014, 5:13 p.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   ui/pageview.cpp 65967bf 
   ui/pageview.h 9c15af6 
   conf/okular.kcfg deabd07 
   conf/dlgaccessibilitybase.ui 9e76a75 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  * In scroll mode, now okular can load new page correctly
  
  What does this mean?

It means that the orignal patch in Bugs 219121 will not load new page due to 
the guard code in PageView::slotRequestVisiblePixmaps().


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Jan. 27, 2014, 5:13 p.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   ui/pageview.cpp 65967bf 
   ui/pageview.h 9c15af6 
   conf/okular.kcfg deabd07 
   conf/dlgaccessibilitybase.ui 9e76a75 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.h, line 221
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240732#file240732line221
 
  missing r in Scoll

OK.  But slotAutoScoll() is also missing a r.  I have fixed that also.


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 4497
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4497
 
  repaint is a bit bad, does update work?

repaint is unnecessary.  I have fixed that.


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Jan. 27, 2014, 5:13 p.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   ui/pageview.cpp 65967bf 
   ui/pageview.h 9c15af6 
   conf/okular.kcfg deabd07 
   conf/dlgaccessibilitybase.ui 9e76a75 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 4485
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485
 
  Can you explain why the need for a timer?

This is because, in scroll mode, user just moves their mouse a little bit and 
then does nothing.  The screen will automatically scroll until user exits 
scroll mode (by another mouse click).

In order to let the screen scroll duratively, you will need a timer.


 On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 2307
  https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line2307
 
  Since you're repeating these blocks over and over you may want to add 
  it into a quick function maybe, so that if in the future we need to change 
  something we don't mistakingly forget one of the places.

bool middlePressZooms();
bool middlePressScrolls();


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115335/
 ---
 
 (Updated Jan. 27, 2014, 5:13 p.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 219121
 http://bugs.kde.org/show_bug.cgi?id=219121
 
 
 Repository: okular
 
 
 Description
 ---
 
 According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
 implemented that feature with an option in accessibility pages.
 
 
 This patch also fixes some problems in the original patch, and provides more 
 features, including
 * In scroll mode, you can press ctrl key to enter zoom mode
 * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
 selection, etc.)
 * In scroll mode, now okular can load new page correctly
 
 
 Diffs
 -
 
   ui/pageview.cpp 65967bf 
   ui/pageview.h 9c15af6 
   conf/okular.kcfg deabd07 
   conf/dlgaccessibilitybase.ui 9e76a75 
 
 Diff: https://git.reviewboard.kde.org/r/115335/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yichao Zhou
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Jan. 28, 2014, 3:49 a.m.)


Review request for Okular.


Changes
---

A new version which handles all the comments.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Jan. 28, 2014, 5:31 a.m.)


Review request for Okular.


Changes
---

Bug fix:  Now left-click after a middle-click can exit scroll mode correctly.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Jan. 28, 2014, 5:44 a.m.)


Review request for Okular.


Changes
---

Now escape key can exit scroll mode correctly.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Jan. 28, 2014, 5:55 a.m.)


Review request for Okular.


Changes
---

Adjust the scroll speed so that it is similar to the speed in firefox.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Jan. 28, 2014, 7:02 a.m.)


Review request for Okular.


Changes
---

Bug fix: now scroll mode exits correctly under Text Selection Tools.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel