[OE-core][PATCH] json-c: avoid ptest failure caused by valgrind

2024-09-19 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

json-c's ptest will automatically detect valgrind and use it to run
tests. This will fail in case valgrind does not work, e.g., intel-x86-64
(corei7-64) + lib32 image. The error is about illegal instruction.
Error message is like below:

  Illegal instruction (core dumped) valgrind --tool=memcheck ...
  ERROR: "test1Formatted spaced pretty" exited with non-zero exit status: 132

So we explicitly disable valgrind by exporting USE_VALGRIND=0.

Signed-off-by: Chen Qi 
---
 meta/recipes-devtools/json-c/json-c/run-ptest | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-devtools/json-c/json-c/run-ptest 
b/meta/recipes-devtools/json-c/json-c/run-ptest
index 2d0e94cd3a..acdce54f3e 100644
--- a/meta/recipes-devtools/json-c/json-c/run-ptest
+++ b/meta/recipes-devtools/json-c/json-c/run-ptest
@@ -3,6 +3,8 @@
 # This script is used to run json-c test suites
 cd tests
 
+export USE_VALGRIND=0
+
 ret_val=0
 for i in test*.test; do
 # test_basic is not an own testcase, just
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#204721): 
https://lists.openembedded.org/g/openembedded-core/message/204721
Mute This Topic: https://lists.openembedded.org/mt/108552917/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][scarthgap][PATCH] qemu: back port patches to fix riscv64 build failure

2024-09-13 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Backport patches to fix riscv64 build failure.

Signed-off-by: Chen Qi 
---
 meta/recipes-devtools/qemu/qemu.inc   |   3 +
 ...kvm-change-KVM_REG_RISCV_FP_F-to-u32.patch |  75 
 ...kvm-change-KVM_REG_RISCV_FP_D-to-u64.patch |  73 
 ...cv-kvm-change-timer-regs-size-to-u64.patch | 107 ++
 4 files changed, 258 insertions(+)
 create mode 100644 
meta/recipes-devtools/qemu/qemu/0001-target-riscv-kvm-change-KVM_REG_RISCV_FP_F-to-u32.patch
 create mode 100644 
meta/recipes-devtools/qemu/qemu/0002-target-riscv-kvm-change-KVM_REG_RISCV_FP_D-to-u64.patch
 create mode 100644 
meta/recipes-devtools/qemu/qemu/0003-target-riscv-kvm-change-timer-regs-size-to-u64.patch

diff --git a/meta/recipes-devtools/qemu/qemu.inc 
b/meta/recipes-devtools/qemu/qemu.inc
index a1d8a309a0..e9f63b9eaf 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -49,6 +49,9 @@ SRC_URI = "https://download.qemu.org/${BPN}-${PV}.tar.xz \
file://CVE-2024-7409-0002.patch \
file://CVE-2024-7409-0003.patch \
file://CVE-2024-7409-0004.patch \
+   file://0001-target-riscv-kvm-change-KVM_REG_RISCV_FP_F-to-u32.patch 
\
+   file://0002-target-riscv-kvm-change-KVM_REG_RISCV_FP_D-to-u64.patch 
\
+   file://0003-target-riscv-kvm-change-timer-regs-size-to-u64.patch \
"
 UPSTREAM_CHECK_REGEX = "qemu-(?P\d+(\.\d+)+)\.tar"
 
diff --git 
a/meta/recipes-devtools/qemu/qemu/0001-target-riscv-kvm-change-KVM_REG_RISCV_FP_F-to-u32.patch
 
b/meta/recipes-devtools/qemu/qemu/0001-target-riscv-kvm-change-KVM_REG_RISCV_FP_F-to-u32.patch
new file mode 100644
index 00..39a6a85162
--- /dev/null
+++ 
b/meta/recipes-devtools/qemu/qemu/0001-target-riscv-kvm-change-KVM_REG_RISCV_FP_F-to-u32.patch
@@ -0,0 +1,75 @@
+From bbdcc89678daa5cb131ef22a6cd41a5f7f9dcea9 Mon Sep 17 00:00:00 2001
+From: Daniel Henrique Barboza 
+Date: Fri, 8 Dec 2023 15:38:31 -0300
+Subject: [PATCH 1/3] target/riscv/kvm: change KVM_REG_RISCV_FP_F to u32
+
+KVM_REG_RISCV_FP_F regs have u32 size according to the API, but by using
+kvm_riscv_reg_id() in RISCV_FP_F_REG() we're returning u64 sizes when
+running with TARGET_RISCV64. The most likely reason why no one noticed
+this is because we're not implementing kvm_cpu_synchronize_state() in
+RISC-V yet.
+
+Create a new helper that returns a KVM ID with u32 size and use it in
+RISCV_FP_F_REG().
+
+Reported-by: Andrew Jones 
+Signed-off-by: Daniel Henrique Barboza 
+Reviewed-by: Andrew Jones 
+Message-ID: <20231208183835.2411523-2-dbarb...@ventanamicro.com>
+Signed-off-by: Alistair Francis 
+(cherry picked from commit 49c211ffca00fdf7c0c29072c224e88527a14838)
+Signed-off-by: Michael Tokarev 
+
+Upstream-Status: Backport [bbdcc89678daa5cb131ef22a6cd41a5f7f9dcea9]
+
+Signed-off-by: Chen Qi 
+---
+ target/riscv/kvm/kvm-cpu.c | 11 ---
+ 1 file changed, 8 insertions(+), 3 deletions(-)
+
+diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c
+index c1675158fe..2eef2be86a 100644
+--- a/target/riscv/kvm/kvm-cpu.c
 b/target/riscv/kvm/kvm-cpu.c
+@@ -72,6 +72,11 @@ static uint64_t kvm_riscv_reg_id(CPURISCVState *env, 
uint64_t type,
+ return id;
+ }
+ 
++static uint64_t kvm_riscv_reg_id_u32(uint64_t type, uint64_t idx)
++{
++return KVM_REG_RISCV | KVM_REG_SIZE_U32 | type | idx;
++}
++
+ #define RISCV_CORE_REG(env, name)  kvm_riscv_reg_id(env, KVM_REG_RISCV_CORE, \
+  KVM_REG_RISCV_CORE_REG(name))
+ 
+@@ -81,7 +86,7 @@ static uint64_t kvm_riscv_reg_id(CPURISCVState *env, 
uint64_t type,
+ #define RISCV_TIMER_REG(env, name)  kvm_riscv_reg_id(env, 
KVM_REG_RISCV_TIMER, \
+  KVM_REG_RISCV_TIMER_REG(name))
+ 
+-#define RISCV_FP_F_REG(env, idx)  kvm_riscv_reg_id(env, KVM_REG_RISCV_FP_F, 
idx)
++#define RISCV_FP_F_REG(idx)  kvm_riscv_reg_id_u32(KVM_REG_RISCV_FP_F, idx)
+ 
+ #define RISCV_FP_D_REG(env, idx)  kvm_riscv_reg_id(env, KVM_REG_RISCV_FP_D, 
idx)
+ 
+@@ -586,7 +591,7 @@ static int kvm_riscv_get_regs_fp(CPUState *cs)
+ if (riscv_has_ext(env, RVF)) {
+ uint32_t reg;
+ for (i = 0; i < 32; i++) {
+-ret = kvm_get_one_reg(cs, RISCV_FP_F_REG(env, i), ®);
++ret = kvm_get_one_reg(cs, RISCV_FP_F_REG(i), ®);
+ if (ret) {
+ return ret;
+ }
+@@ -620,7 +625,7 @@ static int kvm_riscv_put_regs_fp(CPUState *cs)
+ uint32_t reg;
+ for (i = 0; i < 32; i++) {
+ reg = env->fpr[i];
+-ret = kvm_set_one_reg(cs, RISCV_FP_F_REG(env, i), ®);
++ret = kvm_set_one_reg(cs, RISCV_FP_F_REG(i), ®);
+ if (ret) {
+ return ret;
+ }
+-- 
+2.25.1
+
diff --git 
a/meta/recipes-devtools/qemu/qemu/0002-target-riscv-kvm-change-KVM_REG_RISCV_FP_D-to-u64.patch
 
b/meta/recipes-devtools/qemu/qemu/0002-target-riscv-kvm-change-KVM_REG_RISCV_FP_D-to-u64.patch
new 

Re: [OE-core] why does EXTRA_IMAGE_FEATURES += "ptest-pkgs" not install *all* ptest pkgs?

2024-09-02 Thread Chen Qi via lists.openembedded.org

On 9/2/24 19:04, Robert P. J. Day wrote:

On Mon, 2 Sep 2024, Richard Purdie wrote:


On Mon, 2024-09-02 at 06:39 -0400, Robert P. J. Day via lists.openembedded.org 
wrote:

   i'm sure i've overlooked something silly, but in building a
qemuarm64 image to demo ptest to some colleagues, poky by default sets
the "ptest" DISTRO_FEATURES setting so all of the corresponding ptest
packages are *built*, but when adding:

   EXTRA_IMAGE_FEATURES += "ptest-pkgs"

only *some* of the ptest packages are added to the image. eg: while
bzip2-ptest is built, it is not added to the image, as are a number of
other ptest packages. if i *explicitly* add that package, then it gets
included.

   is there some obvious reason that a number of ptest packages are not
included in the resulting image, despite them being built?

In your example, was bzip2 actually in your image or was it only built?

I suspect it only installs ptests for things actually in the image.

   yup, i read in the ptest wiki page that the ptests are installed
only when the associated regular package is also installed, and i did
verify that bzip2 was installed.

   oh, wait ... damn it ... just noticed that my build incorporates
busybox, which probably gets in the way of installing *numerous*
ptest packages that would normally be installed. does that sound like
the culprit?

rday


As far as I know, if bzip2 is brought in by some other package's ptest 
(e.g., A-ptest rdepends on bzip2), then bzip2-ptest will not be 
installed. It's not just ptest, all complementary packages have this 
problem.


Regards,

Qi








-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#204115): 
https://lists.openembedded.org/g/openembedded-core/message/204115
Mute This Topic: https://lists.openembedded.org/mt/108224395/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH 1/2] util-linux/util-linux-libuuid: upgrade from 2.40.1 to 2.40.2

2024-08-29 Thread Chen Qi via lists.openembedded.org
Got it. I looked at the script and the output, but got no clue what might be 
wrong.
I'll keep this intermittent error in mind, when I saw it next time (maybe while 
upgrading util-linux), I'll keep the environment and see what's going on.

Regards,
Qi

-Original Message-
From: openembedded-core@lists.openembedded.org 
 On Behalf Of Alexandre Belloni via 
lists.openembedded.org
Sent: Wednesday, August 28, 2024 4:34 AM
To: joaomarcos.co...@bootlin.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 1/2] util-linux/util-linux-libuuid: upgrade from 
2.40.1 to 2.40.2

On 27/08/2024 11:02:47+0200, Joao Marcos Costa via lists.openembedded.org wrote:
> Hello, Chen
> 
> On 8/22/24 11:26, Chen Qi via lists.openembedded.org wrote:
> > From: Chen Qi
> > 
> > Upgrade util-linux from 2.40.1 to 2.40.2.
> > 
> > 0001-Revert-autotools-make-pam-install-path-configurable.patch
> > is added to solve a problem of lastlog2 pam module not installed in 
> > the expected location.
> > 
> > Signed-off-by: Chen Qi
> 
> This update might be causing the ptest failure below, in the autobuilder:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/6937
> /steps/12/logs/stdio
> 
> Could you please take a look?

This is a know, rare AB-INT:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=15188

Can you triage it as such?

> 
> --
> Best regards,
> João Marcos Costa

> 
> 
> 


--
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel 
engineering https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203906): 
https://lists.openembedded.org/g/openembedded-core/message/203906
Mute This Topic: https://lists.openembedded.org/mt/108035181/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [PATCH] [OE-core] [PATCH] systemd: use update-alternatives to solve conflicts with polkit

2024-08-28 Thread Chen Qi via lists.openembedded.org
Hi Khem, the owner/permission change is from the following commit in meta-oe:

commit 6da0fd21c900e32a0693a6b27d38182f19c8c76c
Author: Luca Boccassi bl...@debian.org
Date:   Mon Aug 12 12:15:40 2024 +0100

polkit: stop overriding DAC on /usr/share/polkit-1/rules.d

This is no longer required by upstream for data in /usr/, as it ships
in packages so there's no point hiding its content. Still required for
/etc/ as that's for local modifications.

So either other recipes (e.g., systemd) adapt to this change, or we revert this 
change.

Regards,
Qi

From: openembedded-core@lists.openembedded.org 
 On Behalf Of Khem Raj
Sent: Thursday, August 29, 2024 9:46 AM
To: wan...@fujitsu.com
Cc: Alexander Kanavin ; 
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] [OE-core] [PATCH] systemd: use update-alternatives to 
solve conflicts with polkit



On Wed, Aug 28, 2024 at 6:22 PM wangmy via 
lists.openembedded.org
 
mailto:fujitsu@lists.openembedded.org>>
 wrote:
| Are you using package_rpm and dnf to compose the image?
Yes.

I checked the permission of rules.d, they are different:

systemd: %attr(700,polkitd,root) %dir "/usr/share/polkit-1/rules.d"
polkit:  %attr(755,root,root) %dir "/usr/share/polkit-1/rules.d"

If the permission need to be unified, which one should be unified into?

Stricter is better so 700 seems good from security pov but we need to ensure it 
works with polkit

  --
Best Regards
---
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST)
No.6 Wenzhu Road, Nanjing, 210012, 
China
TEL:+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: wan...@fujitsu.com

> -Original Message-
> From: Alexander Kanavin 
> mailto:alex.kana...@gmail.com>>
> Sent: Wednesday, August 28, 2024 5:15 PM
> To: Wang, Mingyu/王 鸣瑜 mailto:wan...@fujitsu.com>>
> Cc: 
> openembedded-core@lists.openembedded.org
> Subject: Re: [PATCH] [OE-core] [PATCH] systemd: use update-alternatives to
> solve conflicts with polkit
>
> On Wed, 28 Aug 2024 at 11:04, Mingyu Wang (Fujitsu) 
> mailto:wan...@fujitsu.com>>
> wrote:
> >
> > The name of /usr/share/polkit-1/rules.d are the same, but the files 
> > contained
> in the path are different.
> > What methods can be chosen to solve this problem in this situation?
>
> Are you using package_rpm and dnf to compose the image? If so, you can look at
> the spec files used to produce the packages in ${WORKDIR} of systemd and
> polkit to see how /usr/share/polkit-1/rules.d is specified in both. It might 
> be that
> permissions or ownership are different and dnf can't resolve that.
>
> Alex



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203900): 
https://lists.openembedded.org/g/openembedded-core/message/203900
Mute This Topic: https://lists.openembedded.org/mt/108138529/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH 1/2] util-linux/util-linux-libuuid: upgrade from 2.40.1 to 2.40.2

2024-08-27 Thread Chen Qi via lists.openembedded.org
Before I sent out this patch, I did test util-linux-ptest for both glibc and 
musl.
I’ll check this failure ASAP.

Regards,
Qi

From: openembedded-core@lists.openembedded.org 
 On Behalf Of Joao Marcos Costa via 
lists.openembedded.org
Sent: Tuesday, August 27, 2024 5:03 PM
To: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 1/2] util-linux/util-linux-libuuid: upgrade from 
2.40.1 to 2.40.2


Hello, Chen
On 8/22/24 11:26, Chen Qi via lists.openembedded.org wrote:

From: Chen Qi <mailto:qi.c...@windriver.com>



Upgrade util-linux from 2.40.1 to 2.40.2.



0001-Revert-autotools-make-pam-install-path-configurable.patch

is added to solve a problem of lastlog2 pam module not installed

in the expected location.



Signed-off-by: Chen Qi <mailto:qi.c...@windriver.com>

This update might be causing the ptest failure below, in the autobuilder:

https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/6937/steps/12/logs/stdio

Could you please take a look?

--

Best regards,

João Marcos Costa

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203820): 
https://lists.openembedded.org/g/openembedded-core/message/203820
Mute This Topic: https://lists.openembedded.org/mt/108035181/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 2/2] shadow: upgrade from 4.15.1 to 4.16.0

2024-08-22 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Upgrade shadow from 4.15.1 to 4.16.0.

Signed-off-by: Chen Qi 
---
 meta/recipes-extended/shadow/shadow.inc | 2 +-
 .../shadow/{shadow_4.15.1.bb => shadow_4.16.0.bb}   | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-extended/shadow/{shadow_4.15.1.bb => shadow_4.16.0.bb} 
(100%)

diff --git a/meta/recipes-extended/shadow/shadow.inc 
b/meta/recipes-extended/shadow/shadow.inc
index 3991006b43..b5e77b9874 100644
--- a/meta/recipes-extended/shadow/shadow.inc
+++ b/meta/recipes-extended/shadow/shadow.inc
@@ -24,7 +24,7 @@ SRC_URI:append:class-target = " \
 SRC_URI:append:class-native = " \
file://commonio.c-fix-unexpected-open-failure-in-chroot-env.patch \
"
-SRC_URI[sha256sum] = 
"b34686b89b279887ffbf1f33128902ccc0fa1a998a3add44213bb12d7385b218"
+SRC_URI[sha256sum] = 
"1744f339e07a2b41056347ddd612839762ff565d7e9494fb049428002fa2e7e0"
 
 # Additional Policy files for PAM
 PAM_SRC_URI = "file://pam.d/chfn \
diff --git a/meta/recipes-extended/shadow/shadow_4.15.1.bb 
b/meta/recipes-extended/shadow/shadow_4.16.0.bb
similarity index 100%
rename from meta/recipes-extended/shadow/shadow_4.15.1.bb
rename to meta/recipes-extended/shadow/shadow_4.16.0.bb
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203615): 
https://lists.openembedded.org/g/openembedded-core/message/203615
Mute This Topic: https://lists.openembedded.org/mt/108035182/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 1/2] util-linux/util-linux-libuuid: upgrade from 2.40.1 to 2.40.2

2024-08-22 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Upgrade util-linux from 2.40.1 to 2.40.2.

0001-Revert-autotools-make-pam-install-path-configurable.patch
is added to solve a problem of lastlog2 pam module not installed
in the expected location.

Signed-off-by: Chen Qi 
---
 ...2.40.1.bb => util-linux-libuuid_2.40.2.bb} |  0
 meta/recipes-core/util-linux/util-linux.inc   |  3 +-
 ...s-make-pam-install-path-configurable.patch | 65 +++
 ...l-linux_2.40.1.bb => util-linux_2.40.2.bb} |  0
 4 files changed, 67 insertions(+), 1 deletion(-)
 rename meta/recipes-core/util-linux/{util-linux-libuuid_2.40.1.bb => 
util-linux-libuuid_2.40.2.bb} (100%)
 create mode 100644 
meta/recipes-core/util-linux/util-linux/0001-Revert-autotools-make-pam-install-path-configurable.patch
 rename meta/recipes-core/util-linux/{util-linux_2.40.1.bb => 
util-linux_2.40.2.bb} (100%)

diff --git a/meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb 
b/meta/recipes-core/util-linux/util-linux-libuuid_2.40.2.bb
similarity index 100%
rename from meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
rename to meta/recipes-core/util-linux/util-linux-libuuid_2.40.2.bb
diff --git a/meta/recipes-core/util-linux/util-linux.inc 
b/meta/recipes-core/util-linux/util-linux.inc
index 0f5f838e84..ff47131d12 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -38,6 +38,7 @@ SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-lin
file://display_testname_for_subtest.patch \
file://avoid_parallel_tests.patch \
file://fcntl-lock.c \
+   
file://0001-Revert-autotools-make-pam-install-path-configurable.patch \
"
 
-SRC_URI[sha256sum] = 
"59e676aa53ccb44b6c39f0ffe01a8fa274891c91bef1474752fad92461def24f"
+SRC_URI[sha256sum] = 
"d78b37a66f5922d70edf3bdfb01a6b33d34ed3c3cafd6628203b2a2b67c8e8b3"
diff --git 
a/meta/recipes-core/util-linux/util-linux/0001-Revert-autotools-make-pam-install-path-configurable.patch
 
b/meta/recipes-core/util-linux/util-linux/0001-Revert-autotools-make-pam-install-path-configurable.patch
new file mode 100644
index 00..e9f01fd0be
--- /dev/null
+++ 
b/meta/recipes-core/util-linux/util-linux/0001-Revert-autotools-make-pam-install-path-configurable.patch
@@ -0,0 +1,65 @@
+From af5b58cb77fc8e2e2e2f26aadef4b773b950eafc Mon Sep 17 00:00:00 2001
+From: Chen Qi 
+Date: Wed, 21 Aug 2024 07:50:57 -0700
+Subject: [PATCH] Revert "autotools: make pam install path configurable"
+
+This reverts commit 0539b1ebd26f6a168b822374d7b167f8ef4a1997.
+
+If people want to use /lib instead of /usr/lib as $(libdir) and want
+lastlog2 pam module installed in /lib/security, there's no way to do so.
+
+Beside, we have:
+pam_lastlog2/meson.build:pamlibdir = get_option('libdir') / 'security'
+
+So things are not in sync between Makemodule.am and meson.build with
+the original commit.
+
+Upstream-Status: Submitted [https://github.com/util-linux/util-linux/pull/3173]
+
+Signed-off-by: Chen Qi 
+---
+ Makefile.am| 1 -
+ configure.ac   | 3 ---
+ pam_lastlog2/src/Makemodule.am | 3 ++-
+ 3 files changed, 2 insertions(+), 5 deletions(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index 54e0fd497..3f801c686 100644
+--- a/Makefile.am
 b/Makefile.am
+@@ -56,7 +56,6 @@ usrsbin_exec_PROGRAMS =
+ man_MANS =
+ pkgconfig_DATA =
+ usrlib_exec_LTLIBRARIES =
+-usrsecurelib_exec_LTLIBRARIES =
+ bin_PROGRAMS =
+ sbin_PROGRAMS =
+ dist_usrbin_exec_SCRIPTS =
+diff --git a/configure.ac b/configure.ac
+index 82d0e4bf9..35a70aba4 100644
+--- a/configure.ac
 b/configure.ac
+@@ -120,9 +120,6 @@ AS_CASE([$libdir],
+ )
+ AC_SUBST([usrlib_execdir])
+ 
+-usrsecurelib_execdir='${usrlib_execdir}/security'
+-AC_SUBST([usrsecurelib_execdir])
+-
+ # static configuration maintaned by packages (e.g. /usr/lib)
+ AC_ARG_VAR([SYSCONFSTATICDIR],
+  [Path to static system configuration, default ${prefix}/lib])
+diff --git a/pam_lastlog2/src/Makemodule.am b/pam_lastlog2/src/Makemodule.am
+index 6d2365378..f9a9b6b41 100644
+--- a/pam_lastlog2/src/Makemodule.am
 b/pam_lastlog2/src/Makemodule.am
+@@ -1,4 +1,5 @@
+-usrsecurelib_exec_LTLIBRARIES += pam_lastlog2.la
++securelibdir = $(libdir)/security
++securelib_LTLIBRARIES = pam_lastlog2.la
+ 
+ pam_lastlog2_la_SOURCES = \
+   pam_lastlog2/src/pam_lastlog2.c
+-- 
+2.25.1
+
diff --git a/meta/recipes-core/util-linux/util-linux_2.40.1.bb 
b/meta/recipes-core/util-linux/util-linux_2.40.2.bb
similarity index 100%
rename from meta/recipes-core/util-linux/util-linux_2.40.1.bb
rename to meta/recipes-core/util-linux/util-linux_2.40.2.bb
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203614): 
https://lists.openembedded.org/g/openembedded-core/message/203614
Mute This Topic: https://lists.openembedded.org/mt/1080351

Re: [OE-core] [PATCH 10/24] kmod: upgrade 32 -> 33

2024-08-20 Thread Chen Qi via lists.openembedded.org
The 0001-Use-portable-implementation-for-basename-API.patch should be dropped, 
as it has been merged upstream, with some changes.

Regards,
Qi

-Original Message-
From: openembedded-core@lists.openembedded.org 
 On Behalf Of wangmy via 
lists.openembedded.org
Sent: Tuesday, August 20, 2024 2:51 PM
To: openembedded-core@lists.openembedded.org
Cc: Wang Mingyu 
Subject: [OE-core] [PATCH 10/24] kmod: upgrade 32 -> 33

From: Wang Mingyu 

0001-Use-portable-implementation-for-basename-API.patch
avoid_parallel_tests.patch
gtkdocdir.patch
refreshed for 33

Signed-off-by: Wang Mingyu 
---
 ...able-implementation-for-basename-API.patch | 50 +++
 .../kmod/kmod/avoid_parallel_tests.patch  | 10 ++--
 meta/recipes-kernel/kmod/kmod/gtkdocdir.patch |  9 ++--
 .../kmod/{kmod_32.bb => kmod_33.bb}   |  2 +-
 4 files changed, 26 insertions(+), 45 deletions(-)  rename 
meta/recipes-kernel/kmod/{kmod_32.bb => kmod_33.bb} (98%)

diff --git 
a/meta/recipes-kernel/kmod/kmod/0001-Use-portable-implementation-for-basename-API.patch
 
b/meta/recipes-kernel/kmod/kmod/0001-Use-portable-implementation-for-basename-API.patch
index 6a7f9ded4f..57330ff2a6 100644
--- 
a/meta/recipes-kernel/kmod/kmod/0001-Use-portable-implementation-for-basename-API.patch
+++ b/meta/recipes-kernel/kmod/kmod/0001-Use-portable-implementation-for
+++ -basename-API.patch
@@ -1,4 +1,4 @@
-From 721ed6040c7aa47070faf6378c433089e178bd43 Mon Sep 17 00:00:00 2001
+From 1ea666f8a2384581b5a960020acb958310cae95b Mon Sep 17 00:00:00 2001
 From: Khem Raj 
 Date: Sat, 9 Dec 2023 17:35:59 -0800
 Subject: [PATCH] Use portable implementation for basename API @@ -22,18 +22,18 
@@ Suggested-by: Rich Felker
 Signed-off-by: Khem Raj 
 ---
  libkmod/libkmod-config.c | 2 +-
- shared/util.c| 4 ++--
- shared/util.h| 7 +++
+ shared/util.c| 2 +-
+ shared/util.h| 6 ++
  testsuite/testsuite.c| 2 +-
  tools/depmod.c   | 2 +-
  tools/kmod.c | 4 ++--
- 6 files changed, 14 insertions(+), 7 deletions(-)
+ 6 files changed, 12 insertions(+), 6 deletions(-)
 
 diff --git a/libkmod/libkmod-config.c b/libkmod/libkmod-config.c -index 
e83621b..8aa555a 100644
+index 919f4ed..02aca03 100644
 --- a/libkmod/libkmod-config.c
 +++ b/libkmod/libkmod-config.c
-@@ -794,7 +794,7 @@ static int conf_files_insert_sorted(struct kmod_ctx *ctx,
+@@ -957,7 +957,7 @@ static int conf_files_insert_sorted(struct kmod_ctx 
+*ctx,
bool is_single = false;
  
if (name == NULL) {
@@ -43,15 +43,12 @@ index e83621b..8aa555a 100644
}
  
 diff --git a/shared/util.c b/shared/util.c -index e2bab83..0e16670 100644
+index 66a7622..c46af99 100644
 --- a/shared/util.c
 +++ b/shared/util.c
-@@ -172,9 +172,9 @@ char *modname_normalize(const char *modname, char 
buf[static PATH_MAX], size_t *
-
- char *path_to_modname(const char *path, char buf[static PATH_MAX], size_t 
*len)
+@@ -160,7 +160,7 @@ char *path_to_modname(const char *path, char 
+buf[static PATH_MAX], size_t *len)
  {
--  char *modname;
-+  const char *modname;
+   const char *modname;
  
 -  modname = basename(path);
 +  modname = gnu_basename(path);
@@ -59,18 +56,10 @@ index e2bab83..0e16670 100644
return NULL;
  
 diff --git a/shared/util.h b/shared/util.h -index c4a3916..073dc5a 100644
+index 2a377dd..073dc5a 100644
 --- a/shared/util.h
 +++ b/shared/util.h
-@@ -5,6 +5,7 @@
- #include 
- #include 
- #include 
-+#include 
- #include 
- #include 
- #include 
-@@ -76,6 +77,12 @@ do {\
+@@ -77,6 +77,12 @@ do {\
__p->__v = (val);   \
  } while(0)
  
@@ -84,10 +73,10 @@ index c4a3916..073dc5a 100644
  {
return 1 << ((sizeof(u) * 8) - __builtin_clz(u - 1));  diff --git 
a/testsuite/testsuite.c b/testsuite/testsuite.c -index 318343a..aafc987 100644
+index a567839..1af8702 100644
 --- a/testsuite/testsuite.c
 +++ b/testsuite/testsuite.c
-@@ -70,7 +70,7 @@ static void help(void)
+@@ -59,7 +59,7 @@ static void help(void)
  
printf("Usage:\n"
   "\t%s [options] \n"
@@ -97,10 +86,10 @@ index 318343a..aafc987 100644
for (itr = options, itr_short = options_short;
itr->name != NULL; itr++, itr_short++)  diff 
--git a/tools/depmod.c b/tools/depmod.c -index 43fc354..cfb15b1 100644
+index 8b0a428..e8e3869 100644
 --- a/tools/depmod.c
 +++ b/tools/depmod.c
-@@ -762,7 +762,7 @@ static int cfg_files_insert_sorted(struct cfg_file 
***p_files, size_t *p_n_files
+@@ -724,7 +724,7 @@ static int cfg_files_insert_sorted(struct cfg_file 
+***p_files, size_t *p_n_files
if (name != NULL)
namelen = strlen(name);
else {
@@ -110,10 +99,10 @@ index 43fc354..cfb15b1 100644
dirlen -= namelen + 1;
}
 diff --git a/tools/kmod.c b/tools/kmod.c -index 55689c0..df91e5c 100644
+index d28ec7b..4e5c4

Re: [OE-core] [PATCH v2] util-linux: Add PACKAGECONFIG option to mitigate rootfs remount error

2024-08-19 Thread Chen Qi via lists.openembedded.org
I agree with Alex, if we really need to add this PACKAGECONFIG, the 
default should be enabling mountfd support.


Regards,
Qi

On 8/19/24 16:42, Chen Qi via lists.openembedded.org wrote:

Please see my comments in your v1 patch.
I don't think we should add this PACKAGECONFIG, instead the 
util-linux's check codes need to be improved.


Regards,
Qi

On 8/19/24 16:22, Niko Mauno via lists.openembedded.org wrote:

The 2.39 version of util-linux took new file descriptors based mount
kernel API into use. In relation to this change, the upstream release
notes in
https://github.com/util-linux/util-linux/blob/v2.39/Documentation/releases/v2.39-ReleaseNotes#L14-L21 


mention that

   This change is very aggressive to libmount code, but hopefully, it 
does not introduce regressions in traditional mount(8) behavior.


After observing following failure when booting a board using a bit
older 6.1 series kernel together with initramfs rootfs based boot flow

   [FAILED] Failed to start Remount Root and Kernel File Systems.
   See 'systemctl status systemd-remount-fs.service' for details.

closer inspection revealed:

   demoboard ~ # systemctl status -l systemd-remount-fs.service
   x systemd-remount-fs.service - Remount Root and Kernel File Systems
    Loaded: loaded 
(/usr/lib/systemd/system/systemd-remount-fs.service; enabled-runtime; 
preset: disabled)
    Active: failed (Result: exit-code) since Wed 2024-08-14 
14:53:48 UTC; 1min 22s ago

  Docs: man:systemd-remount-fs.service(8)
https://www.freedesktop.org/wiki/Software/systemd/APIFileSystems
   Process: 76 ExecStart=/usr/lib/systemd/systemd-remount-fs 
(code=exited, status=1/FAILURE)

  Main PID: 76 (code=exited, status=1/FAILURE)

   Aug 14 14:53:48 demoboard systemd-remount-fs[76]: /usr/bin/mount 
for / exited with exit status 32.
   Aug 14 14:53:48 demoboard systemd-remount-fs[81]: mount: /: mount 
point not mounted or bad option.
   Aug 14 14:53:48 demoboard systemd-remount-fs[81]: dmesg(1) may 
have more information after failed mount system call.
   Aug 14 14:53:48 demoboard systemd[1]: systemd-remount-fs.service: 
Main process exited, code=exited, status=1/FAILURE
   Aug 14 14:53:48 demoboard systemd[1]: systemd-remount-fs.service: 
Failed with result 'exit-code'.
   Aug 14 14:53:48 demoboard systemd[1]: Failed to start Remount Root 
and Kernel File Systems.


also consequentially, 'systemctl status' reported:

   State: degraded

When issuing 'strace -ff mount -o remount /' the failure occurred at

   mount_setattr(3, "", AT_EMPTY_PATH, 
{attr_set=MOUNT_ATTR_RDONLY|MOUNT_ATTR_NOATIME|MOUNT_ATTR_NODIRATIME, 
attr_clr=MOUNT_ATTR_NOSUID|MOUNT_ATTR_NODEV|MOUNT_ATTR_NOEXEC|MOUNT_ATTR_NOATIME|MOUNT_ATTR_STRICTATIME|MOUNT_ATTR_NOSYMFOLLOW|0x40, 
propagation=0 /* MS_??? */, userns_fd=0}, 32) = -1 EINVAL (Invalid 
argument)


After further investigation, The issue was pinpointed to lack of Linux
kernel commit
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=95de4ad173ca0e61034f3145d66917970961c210 


("fs: relax mount_setattr() permission checks") in the kernel version
that was being used. Above mitigation was discussed in email related to
then-rejected CVE-2024-26821:
https://lore.kernel.org/linux-cve-announce/2024051606-imaging-entrench-b327@gregkh/T/ 



After testing with qemuarm64 machine different linux-yocto versions,
it was observed that the issue impacts following versions of currently
supported LTS kernels:
  - 6.6.17 (fixed since 6.6.18 i.e. mount_setattr() returns 0)
  - 6.1.78 (fixed since 6.1.79 i.e. mount_setattr() returns 0)
  - 5.15.164 which is currently the newest of 5.15.y series (i.e. no
    known working version)

Taking the above findings into consideration, add a new PACKAGECONFIG
option which by default opts users out from using the feature which
can cause issues with some older kernels.

Versions 5.10.223, 5.4.279 and 4.10.317 were also tested but the issue
was not reproduced with those versions - using strace showed that the
mount_setattr call associated with the new mount API problem was not
issued with these LTS kernel versions, which seemed to be confirmed
also by following libmount debug message in these cases:

   415: libmount: HOOK: [0x7fa115e818]: failed to init new API

Note: In addition to the aforementioned, this change was
tested also briefly using the current latest kernel versions 6.1.104,
6.6.45 and 6.10.3 that using the old mount API with newest kernels
did not introduce any observable regression to the boot flow.

Signed-off-by: Niko Mauno 
---
  meta/recipes-core/util-linux/util-linux_2.40.1.bb | 7 +++
  1 file changed, 7 insertions(+)

diff --git a/meta/recipes-core/util-linux/util-linux_2.40.1.bb 
b/meta/recipes-core/util-linux/util-linux_2.40.1.bb

index a1aab94055..2d89eb6745 100644
--- a/meta/recipes-core/util-linux/util-linux_2.40.1.bb
+++ b/meta/recipes-core/util-linux/util-lin

Re: [OE-core] [PATCH v2] util-linux: Add PACKAGECONFIG option to mitigate rootfs remount error

2024-08-19 Thread Chen Qi via lists.openembedded.org

Please see my comments in your v1 patch.
I don't think we should add this PACKAGECONFIG, instead the util-linux's 
check codes need to be improved.


Regards,
Qi

On 8/19/24 16:22, Niko Mauno via lists.openembedded.org wrote:

The 2.39 version of util-linux took new file descriptors based mount
kernel API into use. In relation to this change, the upstream release
notes in
https://github.com/util-linux/util-linux/blob/v2.39/Documentation/releases/v2.39-ReleaseNotes#L14-L21
mention that

   This change is very aggressive to libmount code, but hopefully, it does not 
introduce regressions in traditional mount(8) behavior.

After observing following failure when booting a board using a bit
older 6.1 series kernel together with initramfs rootfs based boot flow

   [FAILED] Failed to start Remount Root and Kernel File Systems.
   See 'systemctl status systemd-remount-fs.service' for details.

closer inspection revealed:

   demoboard ~ # systemctl status -l systemd-remount-fs.service
   x systemd-remount-fs.service - Remount Root and Kernel File Systems
Loaded: loaded (/usr/lib/systemd/system/systemd-remount-fs.service; 
enabled-runtime; preset: disabled)
Active: failed (Result: exit-code) since Wed 2024-08-14 14:53:48 UTC; 
1min 22s ago
  Docs: man:systemd-remount-fs.service(8)
https://www.freedesktop.org/wiki/Software/systemd/APIFileSystems
   Process: 76 ExecStart=/usr/lib/systemd/systemd-remount-fs (code=exited, 
status=1/FAILURE)
  Main PID: 76 (code=exited, status=1/FAILURE)

   Aug 14 14:53:48 demoboard systemd-remount-fs[76]: /usr/bin/mount for / 
exited with exit status 32.
   Aug 14 14:53:48 demoboard systemd-remount-fs[81]: mount: /: mount point not 
mounted or bad option.
   Aug 14 14:53:48 demoboard systemd-remount-fs[81]:dmesg(1) may have 
more information after failed mount system call.
   Aug 14 14:53:48 demoboard systemd[1]: systemd-remount-fs.service: Main 
process exited, code=exited, status=1/FAILURE
   Aug 14 14:53:48 demoboard systemd[1]: systemd-remount-fs.service: Failed 
with result 'exit-code'.
   Aug 14 14:53:48 demoboard systemd[1]: Failed to start Remount Root and 
Kernel File Systems.

also consequentially, 'systemctl status' reported:

   State: degraded

When issuing 'strace -ff mount -o remount /' the failure occurred at

   mount_setattr(3, "", AT_EMPTY_PATH, 
{attr_set=MOUNT_ATTR_RDONLY|MOUNT_ATTR_NOATIME|MOUNT_ATTR_NODIRATIME, 
attr_clr=MOUNT_ATTR_NOSUID|MOUNT_ATTR_NODEV|MOUNT_ATTR_NOEXEC|MOUNT_ATTR_NOATIME|MOUNT_ATTR_STRICTATIME|MOUNT_ATTR_NOSYMFOLLOW|0x40,
 propagation=0 /* MS_??? */, userns_fd=0}, 32) = -1 EINVAL (Invalid argument)

After further investigation, The issue was pinpointed to lack of Linux
kernel commit
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=95de4ad173ca0e61034f3145d66917970961c210
("fs: relax mount_setattr() permission checks") in the kernel version
that was being used. Above mitigation was discussed in email related to
then-rejected CVE-2024-26821:
https://lore.kernel.org/linux-cve-announce/2024051606-imaging-entrench-b327@gregkh/T/

After testing with qemuarm64 machine different linux-yocto versions,
it was observed that the issue impacts following versions of currently
supported LTS kernels:
  - 6.6.17 (fixed since 6.6.18 i.e. mount_setattr() returns 0)
  - 6.1.78 (fixed since 6.1.79 i.e. mount_setattr() returns 0)
  - 5.15.164 which is currently the newest of 5.15.y series (i.e. no
known working version)

Taking the above findings into consideration, add a new PACKAGECONFIG
option which by default opts users out from using the feature which
can cause issues with some older kernels.

Versions 5.10.223, 5.4.279 and 4.10.317 were also tested but the issue
was not reproduced with those versions - using strace showed that the
mount_setattr call associated with the new mount API problem was not
issued with these LTS kernel versions, which seemed to be confirmed
also by following libmount debug message in these cases:

   415: libmount: HOOK: [0x7fa115e818]: failed to init new API

Note: In addition to the aforementioned, this change was
tested also briefly using the current latest kernel versions 6.1.104,
6.6.45 and 6.10.3 that using the old mount API with newest kernels
did not introduce any observable regression to the boot flow.

Signed-off-by: Niko Mauno 
---
  meta/recipes-core/util-linux/util-linux_2.40.1.bb | 7 +++
  1 file changed, 7 insertions(+)

diff --git a/meta/recipes-core/util-linux/util-linux_2.40.1.bb 
b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
index a1aab94055..2d89eb6745 100644
--- a/meta/recipes-core/util-linux/util-linux_2.40.1.bb
+++ b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
@@ -107,6 +107,13 @@ PACKAGECONFIG[cryptsetup] = 
"--with-cryptsetup,--without-cryptsetup,cryptsetup"
  PACKAGECONFIG[chfn-chsh] = "--enable-chfn-chsh,--disable-chfn-chsh,"
  PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
 

Re: [OE-core] [PATCH] util-linux: Add 'no-libmount-mountfd' PACKAGECONFIG option

2024-08-19 Thread Chen Qi via lists.openembedded.org
I'm a little concerned about this patch because PACKAGECONFIG like this 
is likely to sit there forever.
The master branch's kernel version is at least 6.6. So this patch does 
not have any effect for master branch, right? If this PACKAGECONFIG is 
added, when should we remove it?
Also, if the automatic detection codes determine util-linux could build 
with mountfd support, but it fails at runtime, then it sounds like 
something to fix for the auto detection codes in 
configure.ac/meson.build. So if we really want to improve something, 
maybe we should work with the util-linux community to add more checks 
about mountfd. Maybe start by filing an issue for util-linux?


Regards,
Qi


On 8/16/24 22:04, Niko Mauno via lists.openembedded.org wrote:

The 2.39 version of util-linux took new file descriptors based mount
kernel API into use. In relation to this change, the upstream release
notes in
https://github.com/util-linux/util-linux/blob/v2.39/Documentation/releases/v2.39-ReleaseNotes#L14-L21
mention that

   This change is very aggressive to libmount code, but hopefully, it does not 
introduce regressions in traditional mount(8) behavior.

While testing with a board using a 6.1 version kernel, an initramfs
rootfs based boot flow contains the error

   [FAILED] Failed to start Remount Root and Kernel File Systems.
   See 'systemctl status systemd-remount-fs.service' for details.

on closer inspection:

   demoboard ~ # systemctl status -l systemd-remount-fs.service
   x systemd-remount-fs.service - Remount Root and Kernel File Systems
Loaded: loaded (/usr/lib/systemd/system/systemd-remount-fs.service; 
enabled-runtime; preset: disabled)
Active: failed (Result: exit-code) since Wed 2024-08-14 14:53:48 UTC; 
1min 22s ago
  Docs: man:systemd-remount-fs.service(8)
https://www.freedesktop.org/wiki/Software/systemd/APIFileSystems
   Process: 76 ExecStart=/usr/lib/systemd/systemd-remount-fs (code=exited, 
status=1/FAILURE)
  Main PID: 76 (code=exited, status=1/FAILURE)

   Aug 14 14:53:48 demoboard systemd-remount-fs[76]: /usr/bin/mount for / 
exited with exit status 32.
   Aug 14 14:53:48 demoboard systemd-remount-fs[81]: mount: /: mount point not 
mounted or bad option.
   Aug 14 14:53:48 demoboard systemd-remount-fs[81]:dmesg(1) may have 
more information after failed mount system call.
   Aug 14 14:53:48 demoboard systemd[1]: systemd-remount-fs.service: Main 
process exited, code=exited, status=1/FAILURE
   Aug 14 14:53:48 demoboard systemd[1]: systemd-remount-fs.service: Failed 
with result 'exit-code'.
   Aug 14 14:53:48 demoboard systemd[1]: Failed to start Remount Root and 
Kernel File Systems.

also consequentially, 'systemctl status' reported:

   State: degraded

When issuing 'strace -ff mount -o remount /' the failure occurs at

   mount_setattr(3, "", AT_EMPTY_PATH, 
{attr_set=MOUNT_ATTR_RDONLY|MOUNT_ATTR_NOATIME|MOUNT_ATTR_NODIRATIME, 
attr_clr=MOUNT_ATTR_NOSUID|MOUNT_ATTR_NODEV|MOUNT_ATTR_NOEXEC|MOUNT_ATTR_NOATIME|MOUNT_ATTR_STRICTATIME|MOUNT_ATTR_NOSYMFOLLOW|0x40,
 propagation=0 /* MS_??? */, userns_fd=0}, 32) = -1 EINVAL (Invalid argument)

however the failure didn't occur when using qemuarm64 with 6.6 version
kernel to boot a corresponding initramfs image, in that case the exact
same call under strace returned 0.

Taking the above findings into consideration, add a new PACKAGECONFIG
option which allows to conveniently opt-out from prematurely using a
feature which can cause issues with a bit older kernels.

Signed-off-by: Niko Mauno 
---
  meta/recipes-core/util-linux/util-linux_2.40.1.bb | 1 +
  1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/util-linux/util-linux_2.40.1.bb 
b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
index a1aab94055..3ecc55f61e 100644
--- a/meta/recipes-core/util-linux/util-linux_2.40.1.bb
+++ b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
@@ -107,6 +107,7 @@ PACKAGECONFIG[cryptsetup] = 
"--with-cryptsetup,--without-cryptsetup,cryptsetup"
  PACKAGECONFIG[chfn-chsh] = "--enable-chfn-chsh,--disable-chfn-chsh,"
  PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
  PACKAGECONFIG[lastlog2] = "--enable-liblastlog2,--disable-liblastlog2,sqlite3"
+PACKAGECONFIG[no-libmount-mountfd] = "--disable-libmount-mountfd-support"
  
  EXTRA_OEMAKE = "ARCH=${TARGET_ARCH} CPU= CPUOPT= 'OPT=${CFLAGS}'"
  







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203489): 
https://lists.openembedded.org/g/openembedded-core/message/203489
Mute This Topic: https://lists.openembedded.org/mt/107932364/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH v2] python3: skip readline limited history tests

2024-08-14 Thread Chen Qi via lists.openembedded.org
How about using INCOMPITABLE_LICENSE to determine the default PACAKGECONFIG, so 
that the default is readline? Maybe this would be part of the new meta-gplv2 
replacement work (@Khem Raj). I'm not very sure about it, though. As far as I 
can see, very few people care about this GPLv3 problem. The evidence is that 
meta-gplv2 is NOT supported for a long time and nobody ever devotes any real 
effort to develop an alternative. 

I guess when the commit was made, the underlying API incompatibility was NOT 
made clear. 

I'm OK with any choice, as long as clear statements are there to tell people 
why, though I prefer to use readline as the default, as it would provide better 
user experience.

Regards,
Qi

-Original Message-
From: Trevor Gamblin  
Sent: Wednesday, August 14, 2024 9:04 PM
To: Chen, Qi ; openembedded-core@lists.openembedded.org
Cc: alex.kana...@gmail.com; alexandre.bell...@bootlin.com
Subject: Re: [OE-core][PATCH v2] python3: skip readline limited history tests


On 2024-08-13 10:56 p.m., ChenQi wrote:
> The github issue you referenced here is not an issue that tracks this 
> test failure. It's an issue that introduced the original commit, and 
> has been closed. If a problem is 100% reproducible, at least some open 
> issue should be there for tracking to validate an explicit skip. As 
> far as I can see, tests that were skipped are rarely revisited.
>
> Also, looking at the issue you referenced, it seems that the problem 
> is that we're using editline instead of readline as the default 
> PACKAGECONFIG. It looks like that this new test case correctly reveals 
> our specific configuration problem.
> PACKAGECONFIG ??= "editline gdbm ${@bb.utils.filter('DISTRO_FEATURES',
> 'lto', d)}"
> PACKAGECONFIG[readline] = "--with-readline=readline,,readline,,,editline"
> PACKAGECONFIG[editline] = "--with-readline=editline,,libedit,,,readline"
>
> Can you try using readline as the default PACKAGECONFIG and see if 
> things work?
Yes, the test passes with readline. I didn't make this change for the test 
because I had assumed we want to use editline in the PACKAGECONFIG instead of 
readline, based on commit ce6add6f8aca0. Is this not the case? Do we want to 
switch back to using readline by default?
>
> Regards,
> Qi
>
> On 8/14/24 00:41, Trevor Gamblin wrote:
>> Python 3.12.5 is failing a newer ptest for reading/writing limited 
>> history. Skip it for now until a proper fix (if any) is determined.
>>
>> The new test was added in
>> https://github.com/python/cpython/commit/263c7e611bb24715e513d457a347
>> 7a61fff15162
>>
>>
>> The GitHub issue is here: 
>> https://github.com/python/cpython/issues/121160
>>
>> The aforementioned bug report suggests that OSErrors like that show 
>> up when using the GNU readline-based readline module if a workaround 
>> isn't also incorporated. It also mentions a new readline backend will 
>> be available in 3.13 that might help, but that won't be available for 
>> a year.
>>
>> Signed-off-by: Trevor Gamblin 
>> ---
>> v2 adds extra info in the commit message and carried patch about the 
>> source of the test failure.
>>
>>   ...t_readline-skip-limited-history-test.patch | 40 
>> +++
>>   .../recipes-devtools/python/python3_3.12.5.bb |  1 +
>>   2 files changed, 41 insertions(+)
>>   create mode 100644
>> meta/recipes-devtools/python/python3/0001-test_readline-skip-limited-
>> history-test.patch
>>
>> diff --git
>> a/meta/recipes-devtools/python/python3/0001-test_readline-skip-limite
>> d-history-test.patch 
>> b/meta/recipes-devtools/python/python3/0001-test_readline-skip-limite
>> d-history-test.patch
>>
>> new file mode 100644
>> index 00..851ddd571a
>> --- /dev/null
>> +++ 
>> b/meta/recipes-devtools/python/python3/0001-test_readline-skip-limite
>> d-history-test.patch
>> @@ -0,0 +1,40 @@
>> +From d9d916d5ea946c945323679d1709de1b87029b96 Mon Sep 17 00:00:00 
>> +2001
>> +From: Trevor Gamblin 
>> +Date: Tue, 13 Aug 2024 11:07:05 -0400
>> +Subject: [PATCH] test_readline: skip limited history test
>> +
>> +This test was added recently and is failing on the ptest image. 
>> +Disable it until the proper fix is determined.
>> +
>> +See also: https://github.com/python/cpython/issues/121160
>> +
>> +Upstream-Status: Inappropriate [OE-specific]
>> +
>> +Signed-off-by: Trevor Gamblin 
>> +---
>> + Lib/test/test_readline.py | 2 ++
>> + 1 file changed, 2 insertions(+)
>> +
>> +diff --git a/Lib/test/test_readline.py b/Lib/test/test_readl

Re: [OE-core][PATCH v2] python3: skip readline limited history tests

2024-08-13 Thread Chen Qi via lists.openembedded.org
The github issue you referenced here is not an issue that tracks this 
test failure. It's an issue that introduced the original commit, and has 
been closed. If a problem is 100% reproducible, at least some open issue 
should be there for tracking to validate an explicit skip. As far as I 
can see, tests that were skipped are rarely revisited.


Also, looking at the issue you referenced, it seems that the problem is 
that we're using editline instead of readline as the default 
PACKAGECONFIG. It looks like that this new test case correctly reveals 
our specific configuration problem.
PACKAGECONFIG ??= "editline gdbm ${@bb.utils.filter('DISTRO_FEATURES', 
'lto', d)}"

PACKAGECONFIG[readline] = "--with-readline=readline,,readline,,,editline"
PACKAGECONFIG[editline] = "--with-readline=editline,,libedit,,,readline"

Can you try using readline as the default PACKAGECONFIG and see if 
things work?


Regards,
Qi

On 8/14/24 00:41, Trevor Gamblin wrote:

Python 3.12.5 is failing a newer ptest for reading/writing limited
history. Skip it for now until a proper fix (if any) is determined.

The new test was added in
https://github.com/python/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162

The GitHub issue is here: https://github.com/python/cpython/issues/121160

The aforementioned bug report suggests that OSErrors like that show up
when using the GNU readline-based readline module if a workaround isn't
also incorporated. It also mentions a new readline backend will be
available in 3.13 that might help, but that won't be available for a year.

Signed-off-by: Trevor Gamblin 
---
v2 adds extra info in the commit message and carried patch about the
source of the test failure.

  ...t_readline-skip-limited-history-test.patch | 40 +++
  .../recipes-devtools/python/python3_3.12.5.bb |  1 +
  2 files changed, 41 insertions(+)
  create mode 100644 
meta/recipes-devtools/python/python3/0001-test_readline-skip-limited-history-test.patch

diff --git 
a/meta/recipes-devtools/python/python3/0001-test_readline-skip-limited-history-test.patch
 
b/meta/recipes-devtools/python/python3/0001-test_readline-skip-limited-history-test.patch
new file mode 100644
index 00..851ddd571a
--- /dev/null
+++ 
b/meta/recipes-devtools/python/python3/0001-test_readline-skip-limited-history-test.patch
@@ -0,0 +1,40 @@
+From d9d916d5ea946c945323679d1709de1b87029b96 Mon Sep 17 00:00:00 2001
+From: Trevor Gamblin 
+Date: Tue, 13 Aug 2024 11:07:05 -0400
+Subject: [PATCH] test_readline: skip limited history test
+
+This test was added recently and is failing on the ptest image. Disable
+it until the proper fix is determined.
+
+See also: https://github.com/python/cpython/issues/121160
+
+Upstream-Status: Inappropriate [OE-specific]
+
+Signed-off-by: Trevor Gamblin 
+---
+ Lib/test/test_readline.py | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/Lib/test/test_readline.py b/Lib/test/test_readline.py
+index 91fd7dd13f9..d81f9bf8eed 100644
+--- a/Lib/test/test_readline.py
 b/Lib/test/test_readline.py
+@@ -132,6 +132,7 @@ def test_nonascii_history(self):
+ self.assertEqual(readline.get_history_item(1), "entrée 1")
+ self.assertEqual(readline.get_history_item(2), "entrée 22")
+
++@unittest.skip("Skipping problematic test")
+ def test_write_read_limited_history(self):
+ previous_length = readline.get_history_length()
+ self.addCleanup(readline.set_history_length, previous_length)
+@@ -349,6 +350,7 @@ def test_history_size(self):
+ self.assertEqual(len(lines), history_size)
+ self.assertEqual(lines[-1].strip(), b"last input")
+
++@unittest.skip("Skipping problematic test")
+ def test_write_read_limited_history(self):
+ previous_length = readline.get_history_length()
+ self.addCleanup(readline.set_history_length, previous_length)
+--
+2.39.2
+
diff --git a/meta/recipes-devtools/python/python3_3.12.5.bb 
b/meta/recipes-devtools/python/python3_3.12.5.bb
index 5665c90fa9..cc2e14baf0 100644
--- a/meta/recipes-devtools/python/python3_3.12.5.bb
+++ b/meta/recipes-devtools/python/python3_3.12.5.bb
@@ -33,6 +33,7 @@ SRC_URI = 
"http://www.python.org/ftp/python/${PV}/Python-${PV}.tar.xz \
 
file://0001-gh-107811-tarfile-treat-overflow-in-UID-GID-as-failu.patch \
   file://0001-test_deadlock-skip-problematic-test.patch \
   file://0001-test_active_children-skip-problematic-test.patch \
+   file://0001-test_readline-skip-limited-history-test.patch \
 "
  
  SRC_URI:append:class-native = " \







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203301): 
https://lists.openembedded.org/g/openembedded-core/message/203301
Mute This Topic: https://lists.openembedded.org/mt/107879487/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=

Re: [OE-core] [oe]printhello

2024-08-12 Thread Chen Qi via lists.openembedded.org

I think it's because do_build is not executed.

meta/classes-global/base.bbclass:do_build[noexec] = "1"

Regards,
Qi

On 8/9/24 14:41, Andrej Valek wrote:

Dear community!

I know this could be a funny question, but I wanted to use the 
"printhello" recipe as a basic example. But looks like, that is little 
bit "out-of-date".


I know, that I can crate a custom recipe, but I wanted to use 
something "standard", so I took 
poky/bitbake/doc/bitbake-user-manual/bitbake-user-manual-hello.rst and 
created an "printhello.bb" out of it. I made some modifications to try 
to make it working.


 DESCRIPTION = "Prints Hello World"
+LICENSE = "CLOSED"
 PN = 'printhello'
 PV = '1'

+ inherit allarch

 python do_build() {
-   bb.plain("");
-   bb.plain("*  *");
-   bb.plain("*  Hello, World!   *");
-   bb.plain("*  *");
-   bb.plain("");
+   bb.warn("");
+   bb.warn("*  *");
+   bb.warn("*  Hello, World!   *");
+   bb.warn("*  *");
+   bb.warn("");
 }

+SSTATE_SKIP_CREATION = "1"

Even if I made these modifications nothing has been printed in terminal.
So the question is how good is the example?

Thank you,
Andy






-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203207): 
https://lists.openembedded.org/g/openembedded-core/message/203207
Mute This Topic: https://lists.openembedded.org/mt/107804007/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] json-c: change SUMMARY and DESCRIPTION

2024-08-12 Thread Chen Qi via lists.openembedded.org

Thanks. I've sent out V2.

Regards,
Qi

On 8/12/24 15:53, Alexander Kanavin wrote:

A better commit header would be:
'json-c: use upstream texts for SUMMARY and DESCRIPTION'

'Change' is vague.

Alex

On Mon, 12 Aug 2024 at 09:01, Chen Qi via lists.openembedded.org
 wrote:

From: Chen Qi 

Change SUMMARY and DESCRIPTION according to json-c's homepage
https://github.com/json-c/json-c/wiki.

Signed-off-by: Chen Qi 
---
  meta/recipes-devtools/json-c/json-c_0.17.bb | 6 --
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/json-c/json-c_0.17.bb 
b/meta/recipes-devtools/json-c/json-c_0.17.bb
index 20bcece768..92ab612175 100644
--- a/meta/recipes-devtools/json-c/json-c_0.17.bb
+++ b/meta/recipes-devtools/json-c/json-c_0.17.bb
@@ -1,5 +1,7 @@
-SUMMARY = "C bindings for apps which will manipulate JSON data"
-DESCRIPTION = "JSON-C implements a reference counting object model that allows you 
to easily construct JSON objects in C."
+SUMMARY = "A JSON implementation in C"
+DESCRIPTION = "JSON-C implements a reference counting object model that allows 
\
+you to easily construct JSON objects in C, output them as JSON formatted 
strings \
+and parse JSON formatted strings back into the C representation of JSON 
objects."
  HOMEPAGE = "https://github.com/json-c/json-c/wiki";
  LICENSE = "MIT"
  LIC_FILES_CHKSUM = "file://COPYING;md5=de54b60fbbc35123ba193fea8ee216f2"
--
2.25.1







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203206): 
https://lists.openembedded.org/g/openembedded-core/message/203206
Mute This Topic: https://lists.openembedded.org/mt/107852568/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH V2] json-c: use upstream texts for SUMMARY and DESCRIPTION

2024-08-12 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Change SUMMARY and DESCRIPTION according to json-c's homepage
https://github.com/json-c/json-c/wiki.

Signed-off-by: Chen Qi 
---
 meta/recipes-devtools/json-c/json-c_0.17.bb | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/json-c/json-c_0.17.bb 
b/meta/recipes-devtools/json-c/json-c_0.17.bb
index 20bcece768..92ab612175 100644
--- a/meta/recipes-devtools/json-c/json-c_0.17.bb
+++ b/meta/recipes-devtools/json-c/json-c_0.17.bb
@@ -1,5 +1,7 @@
-SUMMARY = "C bindings for apps which will manipulate JSON data"
-DESCRIPTION = "JSON-C implements a reference counting object model that allows 
you to easily construct JSON objects in C."
+SUMMARY = "A JSON implementation in C"
+DESCRIPTION = "JSON-C implements a reference counting object model that allows 
\
+you to easily construct JSON objects in C, output them as JSON formatted 
strings \
+and parse JSON formatted strings back into the C representation of JSON 
objects."
 HOMEPAGE = "https://github.com/json-c/json-c/wiki";
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=de54b60fbbc35123ba193fea8ee216f2"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203205): 
https://lists.openembedded.org/g/openembedded-core/message/203205
Mute This Topic: https://lists.openembedded.org/mt/107853060/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH] json-c: change SUMMARY and DESCRIPTION

2024-08-12 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Change SUMMARY and DESCRIPTION according to json-c's homepage
https://github.com/json-c/json-c/wiki.

Signed-off-by: Chen Qi 
---
 meta/recipes-devtools/json-c/json-c_0.17.bb | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/json-c/json-c_0.17.bb 
b/meta/recipes-devtools/json-c/json-c_0.17.bb
index 20bcece768..92ab612175 100644
--- a/meta/recipes-devtools/json-c/json-c_0.17.bb
+++ b/meta/recipes-devtools/json-c/json-c_0.17.bb
@@ -1,5 +1,7 @@
-SUMMARY = "C bindings for apps which will manipulate JSON data"
-DESCRIPTION = "JSON-C implements a reference counting object model that allows 
you to easily construct JSON objects in C."
+SUMMARY = "A JSON implementation in C"
+DESCRIPTION = "JSON-C implements a reference counting object model that allows 
\
+you to easily construct JSON objects in C, output them as JSON formatted 
strings \
+and parse JSON formatted strings back into the C representation of JSON 
objects."
 HOMEPAGE = "https://github.com/json-c/json-c/wiki";
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=de54b60fbbc35123ba193fea8ee216f2"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203201): 
https://lists.openembedded.org/g/openembedded-core/message/203201
Mute This Topic: https://lists.openembedded.org/mt/107852568/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH V2] kexec-tools: avoid kernel warning

2024-08-06 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Running command 'kexec -p /path/to/crash-kernel --reuse-cmdline' will
give out the following warning:

  kexec[970]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set

Add MFD_NOEXEC_SEAL explicitly to avoid such warning.

Signed-off-by: Chen Qi 
---
 ...-add-MFD_NOEXEC_SEAL-flag-explicitly.patch | 46 +++
 .../kexec/kexec-tools_2.0.29.bb   |  1 +
 2 files changed, 47 insertions(+)
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch

diff --git 
a/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch
 
b/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch
new file mode 100644
index 00..dc52981025
--- /dev/null
+++ 
b/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch
@@ -0,0 +1,46 @@
+From a6a9e17dfeb5627f3e6f569b66f243f50f8a3645 Mon Sep 17 00:00:00 2001
+From: Chen Qi 
+Date: Tue, 6 Aug 2024 21:42:43 -0700
+Subject: [PATCH] kexec.c: add MFD_NOEXEC_SEAL flag explicitly
+
+Add MFD_NOEXEC_SEAL to avoid kernel warning like below:
+
+  kexec[970]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set
+
+For old kernels, there will be no MFD_NOEXEC_SEAL definition, so fallback
+to define it to 0.
+
+Upstream-Status: Submitted [https://github.com/horms/kexec-tools/pull/7]
+
+Signed-off-by: Chen Qi 
+---
+ kexec/kexec.c | 6 +-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/kexec/kexec.c b/kexec/kexec.c
+index 7c614b0..41d285d 100644
+--- a/kexec/kexec.c
 b/kexec/kexec.c
+@@ -60,6 +60,10 @@
+ #define KEXEC_LOADED_PATH "/sys/kernel/kexec_loaded"
+ #define KEXEC_CRASH_LOADED_PATH "/sys/kernel/kexec_crash_loaded"
+ 
++#ifndef MFD_NOEXEC_SEAL
++#define MFD_NOEXEC_SEAL 0
++#endif
++
+ unsigned long long mem_min = 0;
+ unsigned long long mem_max = ULONG_MAX;
+ unsigned long elfcorehdrsz = 0;
+@@ -655,7 +659,7 @@ static int copybuf_memfd(const char *kernel_buf, size_t 
size)
+ {
+   int fd, count;
+ 
+-  fd = memfd_create("kernel", MFD_ALLOW_SEALING);
++  fd = memfd_create("kernel", MFD_ALLOW_SEALING | MFD_NOEXEC_SEAL);
+   if (fd == -1)
+   return fd;
+ 
+-- 
+2.25.1
+
diff --git a/meta/recipes-kernel/kexec/kexec-tools_2.0.29.bb 
b/meta/recipes-kernel/kexec/kexec-tools_2.0.29.bb
index b88db60ee8..2c2901f19e 100644
--- a/meta/recipes-kernel/kexec/kexec-tools_2.0.29.bb
+++ b/meta/recipes-kernel/kexec/kexec-tools_2.0.29.bb
@@ -16,6 +16,7 @@ SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/kernel/kexec/kexec-tools-${PV}.tar.gz
file://0002-purgatory-Pass-r-directly-to-linker.patch \
file://0005-Disable-PIE-during-link.patch \

file://0001-arm64-kexec-disabled-check-if-kaslr-seed-dtb-propert.patch \
+   file://0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch \
"
 
 SRC_URI[sha256sum] = 
"0756dd54dab2f2a437e5d4df64b9760c3e6cf6a7d29fb296bdeeeb749f6ea28e"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203059): 
https://lists.openembedded.org/g/openembedded-core/message/203059
Mute This Topic: https://lists.openembedded.org/mt/107764868/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] kexec-tools: avoid kernel warning

2024-08-06 Thread Chen Qi via lists.openembedded.org

On 8/7/24 12:25, Alexander Kanavin wrote:
Yes and I don’t understand why it’s not appropriate for upstream 
submission. The patch is fixing a kernel warning which is not specific 
to oe. So why can’t it be sent upstream?


Alex


Because an ideal solution should consider old kernels. I think when 
kexec fixes the warning (they haven't in their latest 2.0.29 release), 
they'll consider both old and new kernels. My patch only works on new 
kernels. As OE master/scarthgap's kernels are new, so this patch should 
work for us. But it's not good for upstream.


Now, given it a second thought, I've decided to write a new patch and 
send it to upstream. I'll send out V2.


Regards,

Qi



On Wed 7. Aug 2024 at 7.22, ChenQi  wrote:

On 8/7/24 12:17, Alexander Kanavin wrote:

What is oe specific in this patch and why that makes it
inappropriate for upstream? Please do explain.

I think it should be sent upstream.

Alex


I've explained in the patch right above the Upstream-Status line.




    On Wed 7. Aug 2024 at 6.34, Chen Qi via lists.openembedded.org

<https://urldefense.com/v3/__http://lists.openembedded.org__;!!AjveYdw8EvQ!dhPgsDclJDntowFvKeG85mLWqOhRHEUplkPeTrqYRxBm02VFUpgqNW76DDtGXPgGWMp7bYr8CTxzNf-nvWp306Q$>
 wrote:

From: Chen Qi 

Running command 'kexec -p /path/to/crash-kernel
--reuse-cmdline' will
give out the following warning:

  kexec[970]: memfd_create() called without MFD_EXEC or
MFD_NOEXEC_SEAL set

Add MFD_NOEXEC_SEAL explicitly to avoid such warning.

Signed-off-by: Chen Qi 
---
 ...-add-MFD_NOEXEC_SEAL-flag-explicitly.patch | 36
+++
 .../kexec/kexec-tools_2.0.28.bb

<https://urldefense.com/v3/__http://kexec-tools_2.0.28.bb__;!!AjveYdw8EvQ!dhPgsDclJDntowFvKeG85mLWqOhRHEUplkPeTrqYRxBm02VFUpgqNW76DDtGXPgGWMp7bYr8CTxzNf-nqfERVjA$>
             |  1 +
 2 files changed, 37 insertions(+)
 create mode 100644

meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch

diff --git

a/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch

b/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch
new file mode 100644
index 00..3b11555a1b
--- /dev/null
+++

b/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch
@@ -0,0 +1,36 @@
+From 6436da0b58b59e1b4cd3924bd007108b8ddf73dc Mon Sep 17
00:00:00 2001
+From: Chen Qi 
+Date: Tue, 6 Aug 2024 19:41:30 -0700
+Subject: [PATCH] kexec.c: add MFD_NOEXEC_SEAL flag explicitly
+
+Add MFD_NOEXEC_SEAL to avoid kernel warning like below:
+
+  kexec[970]: memfd_create() called without MFD_EXEC or
MFD_NOEXEC_SEAL set
+
+As the above two flags are only available in newer kernels,
ideally
+we need to do some fallback. But we know for sure that OE
scarthgap/master
+is using >6.6 kernel, so we don't need to do such fallback.
+
+Upstream-Status: Inappropriate [OE Specific]
+
+Signed-off-by: Chen Qi 
+---
+ kexec/kexec.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/kexec/kexec.c b/kexec/kexec.c
+index 08edfca..c5f52d4 100644
+--- a/kexec/kexec.c
 b/kexec/kexec.c
+@@ -655,7 +655,7 @@ static int copybuf_memfd(const char
*kernel_buf, size_t size)
+ {
+       int fd, count;
+
+-      fd = memfd_create("kernel", MFD_ALLOW_SEALING);
++      fd = memfd_create("kernel", MFD_ALLOW_SEALING |
MFD_NOEXEC_SEAL);
+       if (fd == -1)
+               return fd;
+
+--
+2.25.1
+
diff --git a/meta/recipes-kernel/kexec/kexec-tools_2.0.28.bb

<https://urldefense.com/v3/__http://kexec-tools_2.0.28.bb__;!!AjveYdw8EvQ!dhPgsDclJDntowFvKeG85mLWqOhRHEUplkPeTrqYRxBm02VFUpgqNW76DDtGXPgGWMp7bYr8CTxzNf-nqfERVjA$>
b/meta/recipes-kernel/kexec/kexec-tools_2.0.28.bb

<https://urldefense.com/v3/__http://kexec-tools_2.0.28.bb__;!!AjveYdw8EvQ!dhPgsDclJDntowFvKeG85mLWqOhRHEUplkPeTrqYRxBm02VFUpgqNW76DDtGXPgGWMp7bYr8CTxzNf-nqfERVjA$>
index f0a484f884..830d9ce585 100644
--- a/meta/recipes-kernel/kexec/kexec-tools_2.0.28.bb

<https://urldefense.com/v3/__http://kexec-tools_2.0.28.bb__;!!AjveYdw8EvQ!dhPgsDclJDntowFvKeG85mLWqOhRHEUplkPeTrqYRxBm02VFUpgqNW76DDtGXPgGWMp7bYr8CTxzNf-nqfERVjA$>
+++ b/meta/recipes-kernel/kexec/k

Re: [OE-core][PATCH] kexec-tools: avoid kernel warning

2024-08-06 Thread Chen Qi via lists.openembedded.org

On 8/7/24 12:17, Alexander Kanavin wrote:
What is oe specific in this patch and why that makes it inappropriate 
for upstream? Please do explain.


I think it should be sent upstream.

Alex


I've explained in the patch right above the Upstream-Status line.




On Wed 7. Aug 2024 at 6.34, Chen Qi via lists.openembedded.org 
<https://urldefense.com/v3/__http://lists.openembedded.org__;!!AjveYdw8EvQ!dhPgsDclJDntowFvKeG85mLWqOhRHEUplkPeTrqYRxBm02VFUpgqNW76DDtGXPgGWMp7bYr8CTxzNf-nvWp306Q$> 
 wrote:


    From: Chen Qi 

Running command 'kexec -p /path/to/crash-kernel --reuse-cmdline' will
give out the following warning:

  kexec[970]: memfd_create() called without MFD_EXEC or
MFD_NOEXEC_SEAL set

Add MFD_NOEXEC_SEAL explicitly to avoid such warning.

    Signed-off-by: Chen Qi 
---
 ...-add-MFD_NOEXEC_SEAL-flag-explicitly.patch | 36
+++
 .../kexec/kexec-tools_2.0.28.bb

<https://urldefense.com/v3/__http://kexec-tools_2.0.28.bb__;!!AjveYdw8EvQ!dhPgsDclJDntowFvKeG85mLWqOhRHEUplkPeTrqYRxBm02VFUpgqNW76DDtGXPgGWMp7bYr8CTxzNf-nqfERVjA$>
             |  1 +
 2 files changed, 37 insertions(+)
 create mode 100644

meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch

diff --git

a/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch

b/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch
new file mode 100644
index 00..3b11555a1b
--- /dev/null
+++

b/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch
@@ -0,0 +1,36 @@
+From 6436da0b58b59e1b4cd3924bd007108b8ddf73dc Mon Sep 17 00:00:00
2001
+From: Chen Qi 
+Date: Tue, 6 Aug 2024 19:41:30 -0700
+Subject: [PATCH] kexec.c: add MFD_NOEXEC_SEAL flag explicitly
+
+Add MFD_NOEXEC_SEAL to avoid kernel warning like below:
+
+  kexec[970]: memfd_create() called without MFD_EXEC or
MFD_NOEXEC_SEAL set
+
+As the above two flags are only available in newer kernels, ideally
+we need to do some fallback. But we know for sure that OE
scarthgap/master
+is using >6.6 kernel, so we don't need to do such fallback.
+
+Upstream-Status: Inappropriate [OE Specific]
+
+Signed-off-by: Chen Qi 
+---
+ kexec/kexec.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/kexec/kexec.c b/kexec/kexec.c
+index 08edfca..c5f52d4 100644
+--- a/kexec/kexec.c
 b/kexec/kexec.c
+@@ -655,7 +655,7 @@ static int copybuf_memfd(const char
*kernel_buf, size_t size)
+ {
+       int fd, count;
+
+-      fd = memfd_create("kernel", MFD_ALLOW_SEALING);
++      fd = memfd_create("kernel", MFD_ALLOW_SEALING |
MFD_NOEXEC_SEAL);
+       if (fd == -1)
+               return fd;
+
+--
+2.25.1
+
diff --git a/meta/recipes-kernel/kexec/kexec-tools_2.0.28.bb

<https://urldefense.com/v3/__http://kexec-tools_2.0.28.bb__;!!AjveYdw8EvQ!dhPgsDclJDntowFvKeG85mLWqOhRHEUplkPeTrqYRxBm02VFUpgqNW76DDtGXPgGWMp7bYr8CTxzNf-nqfERVjA$>
b/meta/recipes-kernel/kexec/kexec-tools_2.0.28.bb

<https://urldefense.com/v3/__http://kexec-tools_2.0.28.bb__;!!AjveYdw8EvQ!dhPgsDclJDntowFvKeG85mLWqOhRHEUplkPeTrqYRxBm02VFUpgqNW76DDtGXPgGWMp7bYr8CTxzNf-nqfERVjA$>
index f0a484f884..830d9ce585 100644
--- a/meta/recipes-kernel/kexec/kexec-tools_2.0.28.bb

<https://urldefense.com/v3/__http://kexec-tools_2.0.28.bb__;!!AjveYdw8EvQ!dhPgsDclJDntowFvKeG85mLWqOhRHEUplkPeTrqYRxBm02VFUpgqNW76DDtGXPgGWMp7bYr8CTxzNf-nqfERVjA$>
+++ b/meta/recipes-kernel/kexec/kexec-tools_2.0.28.bb

<https://urldefense.com/v3/__http://kexec-tools_2.0.28.bb__;!!AjveYdw8EvQ!dhPgsDclJDntowFvKeG85mLWqOhRHEUplkPeTrqYRxBm02VFUpgqNW76DDtGXPgGWMp7bYr8CTxzNf-nqfERVjA$>
@@ -19,6 +19,7 @@ SRC_URI =
"${KERNELORG_MIRROR}/linux/utils/kernel/kexec/kexec-tools-${PV}.tar.gz
file://0001-arm64-kexec-disabled-check-if-kaslr-seed-dtb-propert.patch
\
file://Fix-building-on-x86_64-with-binutils-2.41.patch \
file://0001-x86-linux-setup.c-Use-POSIX-basename-API.patch \
+ file://0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch \
            "

 SRC_URI[sha256sum] =
"f33d2660b3e38d25a127e87097978e0f7a9a73ab5151a29eb80974d169ff6a29"
-- 
2.25.1






-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203054): 
https://lists.openembedded.org/g/openembedded-core/message/203054
Mute This Topic: https://lists.openembedded.org/mt/107763946/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH] kexec-tools: avoid kernel warning

2024-08-06 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Running command 'kexec -p /path/to/crash-kernel --reuse-cmdline' will
give out the following warning:

  kexec[970]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set

Add MFD_NOEXEC_SEAL explicitly to avoid such warning.

Signed-off-by: Chen Qi 
---
 ...-add-MFD_NOEXEC_SEAL-flag-explicitly.patch | 36 +++
 .../kexec/kexec-tools_2.0.28.bb   |  1 +
 2 files changed, 37 insertions(+)
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch

diff --git 
a/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch
 
b/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch
new file mode 100644
index 00..3b11555a1b
--- /dev/null
+++ 
b/meta/recipes-kernel/kexec/kexec-tools/0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch
@@ -0,0 +1,36 @@
+From 6436da0b58b59e1b4cd3924bd007108b8ddf73dc Mon Sep 17 00:00:00 2001
+From: Chen Qi 
+Date: Tue, 6 Aug 2024 19:41:30 -0700
+Subject: [PATCH] kexec.c: add MFD_NOEXEC_SEAL flag explicitly
+
+Add MFD_NOEXEC_SEAL to avoid kernel warning like below:
+
+  kexec[970]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set
+
+As the above two flags are only available in newer kernels, ideally
+we need to do some fallback. But we know for sure that OE scarthgap/master
+is using >6.6 kernel, so we don't need to do such fallback.
+
+Upstream-Status: Inappropriate [OE Specific]
+
+Signed-off-by: Chen Qi 
+---
+ kexec/kexec.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/kexec/kexec.c b/kexec/kexec.c
+index 08edfca..c5f52d4 100644
+--- a/kexec/kexec.c
 b/kexec/kexec.c
+@@ -655,7 +655,7 @@ static int copybuf_memfd(const char *kernel_buf, size_t 
size)
+ {
+   int fd, count;
+ 
+-  fd = memfd_create("kernel", MFD_ALLOW_SEALING);
++  fd = memfd_create("kernel", MFD_ALLOW_SEALING | MFD_NOEXEC_SEAL);
+   if (fd == -1)
+   return fd;
+ 
+-- 
+2.25.1
+
diff --git a/meta/recipes-kernel/kexec/kexec-tools_2.0.28.bb 
b/meta/recipes-kernel/kexec/kexec-tools_2.0.28.bb
index f0a484f884..830d9ce585 100644
--- a/meta/recipes-kernel/kexec/kexec-tools_2.0.28.bb
+++ b/meta/recipes-kernel/kexec/kexec-tools_2.0.28.bb
@@ -19,6 +19,7 @@ SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/kernel/kexec/kexec-tools-${PV}.tar.gz

file://0001-arm64-kexec-disabled-check-if-kaslr-seed-dtb-propert.patch \
file://Fix-building-on-x86_64-with-binutils-2.41.patch \
file://0001-x86-linux-setup.c-Use-POSIX-basename-API.patch \
+   file://0001-kexec.c-add-MFD_NOEXEC_SEAL-flag-explicitly.patch \
"
 
 SRC_URI[sha256sum] = 
"f33d2660b3e38d25a127e87097978e0f7a9a73ab5151a29eb80974d169ff6a29"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203052): 
https://lists.openembedded.org/g/openembedded-core/message/203052
Mute This Topic: https://lists.openembedded.org/mt/107763946/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH v5 2/3] openssh: systemd notification was implemented upstream

2024-07-17 Thread Chen Qi via lists.openembedded.org
Hi Jose,

The changes in the patch have already done an implicit check:

if ((path = getenv("NOTIFY_SOCKET")) == NULL || strlen(path) == 0)
return;

return;
This means if it’s not systemd who starts sshd (notify type starting), then the 
function ssh_systemd_notify just does nothing.

I looked at the changes in the patch and the codes around it, if I understand 
it correctly, in case of ‘-i’ option, sshd does not notify systemd. So the 
ssd@.service<mailto:ssd@.service> should not use the notify type.

Regards,
Qi

From: openembedded-core@lists.openembedded.org 
 On Behalf Of Jose Quaresma
Sent: Wednesday, July 17, 2024 6:53 PM
To: Chen, Qi 
Cc: Khem Raj ; openembedded-core@lists.openembedded.org; 
Jose Quaresma 
Subject: Re: [OE-core][PATCH v5 2/3] openssh: systemd notification was 
implemented upstream



ChenQi mailto:qi.c...@windriver.com>> escreveu (quarta, 
17/07/2024 à(s) 10:25):
I think the problem might be related to the "+Type=notify-reload" change in 
sshd@.service<mailto:sshd@.service>. It's in inetd mode so the upstream change 
about SYSTEMD_NOTIFY should have nothing to do with it.
I also doubt if the following line should be removed from sshd.service.

-ExecReload=@BASE_BINDIR@/kill -HUP $MAINPID
Make sense.
Maybe the service changes in the patch need to be conditional on whether or not 
we are using systemd.
I'm going to try this path a little.

but I am now facing some issues with testimage without the overall openssh 
patch series.

Jose

Regards,
Qi

On 7/17/24 16:46, Jose Quaresma wrote:

Khem Raj mailto:raj.k...@gmail.com>> escreveu (quarta, 
17/07/2024 à(s) 07:38):
actually I narrowed down my problem of disconnection to this patch in
the series. Earlier I thought it might be related to the openssh
upgrade patch
but reverting that still causes the problem but this patch when
reverted, the problem is gone.

I will jump on this today and try to find the root cause.
The ptest goes well in my local tests but I didn't do anything with testimage.
I'll see if the testimage picks up something.

Thanks for the feedback.

Jose


On Tue, Jul 16, 2024 at 7:17 AM Jose Quaresma via
lists.openembedded.org<https://urldefense.com/v3/__http:/lists.openembedded.org__;!!AjveYdw8EvQ!dyDMDTQfmXOSDtp_OINCHZKvb_Jx8re27vm6ogUDwMTZlQz2eu2WGexbqUYAYEPhX7AfK0o33vSBIxkkcgx8BUuo8VXD$>
mailto:gmail@lists.openembedded.org>>
 wrote:
>
> Still side effects of the XZ backdoor. The systemd sd-notify patch
> was rejected [1] upstream and was chosen a standalone implementation
> that does not depend on libsystemd [2].
>
> Racional [1]:
>
> License incompatibility and library bloatedness were the reasons.
> Given recent events we're never going to take a dependency on libsystemd,
> though we might implement the notification protocol ourselves if it isn't too 
> much work.
>
> [1] 
> https://github.com/openssh/openssh-portable/pull/375#issuecomment-2027749729<https://urldefense.com/v3/__https:/github.com/openssh/openssh-portable/pull/375*issuecomment-2027749729__;Iw!!AjveYdw8EvQ!dyDMDTQfmXOSDtp_OINCHZKvb_Jx8re27vm6ogUDwMTZlQz2eu2WGexbqUYAYEPhX7AfK0o33vSBIxkkcgx8BXB1d9mL$>
> [2] 
> https://github.com/openssh/openssh-portable/commit/08f579231cd38a1c657aaa6ddeb8ab57a1fd4f5c<https://urldefense.com/v3/__https:/github.com/openssh/openssh-portable/commit/08f579231cd38a1c657aaa6ddeb8ab57a1fd4f5c__;!!AjveYdw8EvQ!dyDMDTQfmXOSDtp_OINCHZKvb_Jx8re27vm6ogUDwMTZlQz2eu2WGexbqUYAYEPhX7AfK0o33vSBIxkkcgx8Bcg4kaOm$>
>
> Signed-off-by: Jose Quaresma 
> mailto:jose.quare...@foundries.io>>
> ---
>
> v4:
>  - split update of Upstream-Status in new patches in the serie
>
> v5:
>  - use the upstream solution
>
>  ...-notify-systemd-on-listen-and-reload.patch | 225 ++
>  ...tional-support-for-systemd-sd_notify.patch |  96 
>  .../openssh/openssh/sshd.service  |   2 +-
>  .../openssh/openssh/sshd@.service<mailto:.../openssh/openssh/sshd@.service>  
>|   1 +
>  
> .../openssh/openssh_9.7p1.bb<https://urldefense.com/v3/__http:/openssh_9.7p1.bb__;!!AjveYdw8EvQ!dyDMDTQfmXOSDtp_OINCHZKvb_Jx8re27vm6ogUDwMTZlQz2eu2WGexbqUYAYEPhX7AfK0o33vSBIxkkcgx8Bamvaj4m$>
>   |   4 +-
>  5 files changed, 228 insertions(+), 100 deletions(-)
>  create mode 100644 
> meta/recipes-connectivity/openssh/openssh/0001-notify-systemd-on-listen-and-reload.patch
>  delete mode 100644 
> meta/recipes-connectivity/openssh/openssh/0001-systemd-Add-optional-support-for-systemd-sd_notify.patch
>
> diff --git 
> a/meta/recipes-connectivity/openssh/openssh/0001-notify-systemd-on-listen-and-reload.patch
>  
> b/meta/recipes-connectivity/openssh/openssh/0001-notify-systemd-on-listen-and-reload.patch
> new file mode 100644
> index 00..4925c969fe
> --- /dev/nul

Re: [OE-core][PATCH v5 2/3] openssh: systemd notification was implemented upstream

2024-07-17 Thread Chen Qi via lists.openembedded.org
I think the problem might be related to the "+Type=notify-reload" change 
in sshd@.service. It's in inetd mode so the upstream change about 
SYSTEMD_NOTIFY should have nothing to do with it.

I also doubt if the following line should be removed from sshd.service.

-ExecReload=@BASE_BINDIR@/kill -HUP $MAINPID

Regards,
Qi

On 7/17/24 16:46, Jose Quaresma wrote:


Khem Raj  escreveu (quarta, 17/07/2024 à(s) 07:38):

actually I narrowed down my problem of disconnection to this patch in
the series. Earlier I thought it might be related to the openssh
upgrade patch
but reverting that still causes the problem but this patch when
reverted, the problem is gone.


I will jump on this today and try to find the root cause.
The ptest goes well in my local tests but I didn't do anything with 
testimage.

I'll see if the testimage picks up something.

Thanks for the feedback.

Jose


On Tue, Jul 16, 2024 at 7:17 AM Jose Quaresma via
lists.openembedded.org


 wrote:
>
> Still side effects of the XZ backdoor. The systemd sd-notify patch
> was rejected [1] upstream and was chosen a standalone implementation
> that does not depend on libsystemd [2].
>
> Racional [1]:
>
> License incompatibility and library bloatedness were the reasons.
> Given recent events we're never going to take a dependency on
libsystemd,
> though we might implement the notification protocol ourselves if
it isn't too much work.
>
> [1]
https://github.com/openssh/openssh-portable/pull/375#issuecomment-2027749729


> [2]

https://github.com/openssh/openssh-portable/commit/08f579231cd38a1c657aaa6ddeb8ab57a1fd4f5c


>
> Signed-off-by: Jose Quaresma 
> ---
>
> v4:
>  - split update of Upstream-Status in new patches in the serie
>
> v5:
>  - use the upstream solution
>
>  ...-notify-systemd-on-listen-and-reload.patch | 225
++
>  ...tional-support-for-systemd-sd_notify.patch |  96 
>  .../openssh/openssh/sshd.service              |   2 +-
>  .../openssh/openssh/sshd@.service             |   1 +
>  .../openssh/openssh_9.7p1.bb


                |   4 +-
>  5 files changed, 228 insertions(+), 100 deletions(-)
>  create mode 100644

meta/recipes-connectivity/openssh/openssh/0001-notify-systemd-on-listen-and-reload.patch
>  delete mode 100644

meta/recipes-connectivity/openssh/openssh/0001-systemd-Add-optional-support-for-systemd-sd_notify.patch
>
> diff --git

a/meta/recipes-connectivity/openssh/openssh/0001-notify-systemd-on-listen-and-reload.patch

b/meta/recipes-connectivity/openssh/openssh/0001-notify-systemd-on-listen-and-reload.patch
> new file mode 100644
> index 00..4925c969fe
> --- /dev/null
> +++

b/meta/recipes-connectivity/openssh/openssh/0001-notify-systemd-on-listen-and-reload.patch
> @@ -0,0 +1,225 @@
> +From fc73e2405a8ca928465580b74a4d76112919367b Mon Sep 17
00:00:00 2001
> +From: Damien Miller 
> +Date: Wed, 3 Apr 2024 14:40:32 +1100
> +Subject: [PATCH] notify systemd on listen and reload
> +
> +Standalone implementation that does not depend on libsystemd.
> +With assistance from Luca Boccassi, and feedback/testing from Colin
> +Watson. bz2641
> +
> +Upstream-Status: Backport

[https://github.com/openssh/openssh-portable/commit/08f579231cd38a1c657aaa6ddeb8ab57a1fd4f5c

]
> +
> +Signed-off-by: Jose Quaresma 
> +---
> + configure.ac


              |  1 +
> + openbsd-compat/port-linux.c | 97
-
> + openbsd-compat/port-linux.h |  5 ++
> + platform.c                  | 11 +
> + platform.h         

[OE-core][PATCH V2 2/5] systemd-boot: upgrade from 255.6 to 256

2024-07-11 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Patch 0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch
is added to resolve build time error.

Signed-off-by: Chen Qi 
---
 ...ve_255.6.bb => systemd-boot-native_256.bb} |  0
 ...temd-boot_255.6.bb => systemd-boot_256.bb} |  2 ++
 ...on.build-ensure-VERSION_TAG-exists-i.patch | 32 +++
 3 files changed, 34 insertions(+)
 rename meta/recipes-core/systemd/{systemd-boot-native_255.6.bb => 
systemd-boot-native_256.bb} (100%)
 rename meta/recipes-core/systemd/{systemd-boot_255.6.bb => 
systemd-boot_256.bb} (95%)
 create mode 100644 
meta/recipes-core/systemd/systemd/0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch

diff --git a/meta/recipes-core/systemd/systemd-boot-native_255.6.bb 
b/meta/recipes-core/systemd/systemd-boot-native_256.bb
similarity index 100%
rename from meta/recipes-core/systemd/systemd-boot-native_255.6.bb
rename to meta/recipes-core/systemd/systemd-boot-native_256.bb
diff --git a/meta/recipes-core/systemd/systemd-boot_255.6.bb 
b/meta/recipes-core/systemd/systemd-boot_256.bb
similarity index 95%
rename from meta/recipes-core/systemd/systemd-boot_255.6.bb
rename to meta/recipes-core/systemd/systemd-boot_256.bb
index 9a6d8e9d6e..dd06b6218b 100644
--- a/meta/recipes-core/systemd/systemd-boot_255.6.bb
+++ b/meta/recipes-core/systemd/systemd-boot_256.bb
@@ -1,6 +1,8 @@
 require systemd.inc
 FILESEXTRAPATHS =. "${FILE_DIRNAME}/systemd:"
 
+SRC_URI += 
"file://0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch"
+
 require conf/image-uefi.conf
 
 DEPENDS = "intltool-native libcap util-linux gperf-native 
python3-jinja2-native python3-pyelftools-native"
diff --git 
a/meta/recipes-core/systemd/systemd/0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch
 
b/meta/recipes-core/systemd/systemd/0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch
new file mode 100644
index 00..6f02ea2f43
--- /dev/null
+++ 
b/meta/recipes-core/systemd/systemd/0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch
@@ -0,0 +1,32 @@
+From 9df06062cebd0390d33de9694e9cb1c9fa7b8697 Mon Sep 17 00:00:00 2001
+From: Chen Qi 
+Date: Wed, 3 Jul 2024 23:18:41 -0700
+Subject: [PATCH] src/boot/efi/meson.build: ensure VERSION_TAG exists in case
+ of cross build
+
+The GIT_VERSION is changed to use VERSION_TAG, but in case of cross build
+for src/boot/efi, it's not set, causing build error because the compiler cannot
+know it's a macro thus treating it as some variable and error out.
+
+Upstream-Status: Submitted [https://github.com/systemd/systemd/pull/33612]
+
+Signed-off-by: Chen Qi 
+---
+ src/boot/efi/meson.build | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/boot/efi/meson.build b/src/boot/efi/meson.build
+index 7a60b0ec7e..99d108d6e8 100644
+--- a/src/boot/efi/meson.build
 b/src/boot/efi/meson.build
+@@ -65,6 +65,7 @@ endforeach
+ 
+ if meson.is_cross_build() and get_option('sbat-distro') == 'auto'
+ warning('Auto detection of SBAT information not supported when 
cross-building, disabling SBAT.')
++efi_conf.set_quoted('VERSION_TAG', version_tag)
+ elif get_option('sbat-distro') != ''
+ efi_conf.set_quoted('SBAT_PROJECT', meson.project_name())
+ efi_conf.set_quoted('PROJECT_VERSION', 
meson.project_version().split('~')[0])
+-- 
+2.45.1
+
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#201765): 
https://lists.openembedded.org/g/openembedded-core/message/201765
Mute This Topic: https://lists.openembedded.org/mt/107158893/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH V2 4/5] libssh2: remove util-linux-col from ptest dependencies

2024-07-11 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

After util-linux upgrade to 2.40.1, we got the following QA issue
on musl:

  WARNING: libssh2-1.11.0-r0 do_package_qa: QA Issue: libssh2-ptest
  rdepends on util-linux-col, but it isn't a build dependency? [build-deps]

The issue appeared because new version util-linux has disabled
building out col on musl[1]. In short, the reason is that col in
util-linux requires something that musl does not provide.

This 'util-linux-col' dependency was added in 2021, at that time
the libssh2's version is 1.9.0. Now the version is 1.11.0 and I tested
its ptest, it does not require util-linux-col to succeed.

[1] 
https://github.com/util-linux/util-linux/commit/8886d84e25a457702b45194d69a47313f76dc6bc

Signed-off-by: Chen Qi 
---
 meta/recipes-support/libssh2/libssh2_1.11.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/libssh2/libssh2_1.11.0.bb 
b/meta/recipes-support/libssh2/libssh2_1.11.0.bb
index 5100e6f7f9..dc9b9ae364 100644
--- a/meta/recipes-support/libssh2/libssh2_1.11.0.bb
+++ b/meta/recipes-support/libssh2/libssh2_1.11.0.bb
@@ -31,7 +31,7 @@ PACKAGECONFIG[gcrypt] = "--with-crypto=libgcrypt 
--with-libgcrypt-prefix=${STAGI
 BBCLASSEXTEND = "native nativesdk"
 
 # required for ptest on documentation
-RDEPENDS:${PN}-ptest = "bash man-db openssh util-linux-col"
+RDEPENDS:${PN}-ptest = "bash man-db openssh"
 RDEPENDS:${PN}-ptest:append:libc-glibc = " locale-base-en-us"
 
 do_compile_ptest() {
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#201764): 
https://lists.openembedded.org/g/openembedded-core/message/201764
Mute This Topic: https://lists.openembedded.org/mt/107158892/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH V2 5/5] pciutils: remove textrel INSANE_SKIP

2024-07-11 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

The current pciutils does not have this textrel problem any more.

Signed-off-by: Chen Qi 
---
 meta/recipes-bsp/pciutils/pciutils_3.13.0.bb | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-bsp/pciutils/pciutils_3.13.0.bb 
b/meta/recipes-bsp/pciutils/pciutils_3.13.0.bb
index 0b876c7070..74edd8686b 100644
--- a/meta/recipes-bsp/pciutils/pciutils_3.13.0.bb
+++ b/meta/recipes-bsp/pciutils/pciutils_3.13.0.bb
@@ -47,8 +47,6 @@ DESCRIPTION:${PN}-ids = "Package providing the PCI device ID 
database for pciuti
 RDEPENDS:${PN} += "${PN}-ids"
 
 FILES:libpci = "${libdir}/libpci.so.*"
-# The versioned symbols in libpci appear to be causing relocations
-INSANE_SKIP:libpci += "textrel"
 
 ALTERNATIVE:${PN} = "lspci"
 ALTERNATIVE_PRIORITY = "100"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#201763): 
https://lists.openembedded.org/g/openembedded-core/message/201763
Mute This Topic: https://lists.openembedded.org/mt/107158891/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH V2 1/5] systemd: upgrade from 255.6 to 256

2024-07-11 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

The 'cgroupv2' PACKAGECONFIG is dropped as systemd now only supports
cgroupv2.

The 'kmod' PACKAGECONFIG is now added 'libkmod' as a runtime dependency.
This is because systemd 256 uses dlopen to make use of libkmod, and there's
no way for our library detection codes to know this and add such dependency
automatically. So we add it explicitly.

mime is now inherited because ${datadir}/mime/packages/io.systemd.xml
is a mime type file.

For musl specific patches, most are refreshed. One old patch is dropped,
and four new ones are added.
Newly added:
  build-path.c: avoid boot time segfault for musl
  adjust header inclusion order to avoid redeclaration
  undef stdin for references using stdin as a struct member
  include signal.h to avoid the 'undeclared' error
Dropped:
  src/basic/missing.h: check for missing strndupa
  (drop reason: systemd does not use strndupa any more)

Signed-off-by: Chen Qi 
---
 meta/recipes-core/systemd/systemd.inc |   4 +-
 ...all-dependency-links-at-install-tim.patch} |  21 +-
 ...mplment-systemd-sysv-install-for-OE.patch} |   7 +-
 ...agate-sysroot-for-cross-compilation.patch} |  10 +-
 ...missing.h-check-for-missing-strndupa.patch | 696 --
 ...-missing_type.h-add-comparison_fn_t.patch} |  15 +-
 ...-parse_printf_format-implementation.patch} |  25 +-
 ...B_BRACE-and-GLOB_ALTDIRFUNC-is-not-.patch} |  22 +-
 ...07-add-missing-FTW_-macros-for-musl.patch} |   9 +-
 ...8-Use-uintmax_t-for-handling-rlim_t.patch} |  23 +-
 ..._SYMLINK_NOFOLLOW-flag-to-faccessat.patch} |   9 +-
 ...atible-basename-for-non-glibc-syste.patch} |  10 +-
 ...ffering-when-writing-to-oom_score_a.patch} |  11 +-
 ...ompliant-strerror_r-from-GNU-specif.patch} |   9 +-
 ...efinition-of-prctl_mm_map-structure.patch} |  13 +-
 ...not-disable-buffer-in-writing-files.patch} | 151 ++--
 ...tch => 0015-Handle-__cpu_mask-usage.patch} |   9 +-
 ...atch => 0016-Handle-missing-gshadow.patch} |  50 +-
 h-Define-MIPS-ABI-defines-for-musl.patch} |   7 +-
 ...ss-correct-parameters-to-getdents64.patch} |  11 +-
 ...tch => 0019-Adjust-for-musl-headers.patch} | 165 ++---
 ...rerror-is-assumed-to-be-GNU-specifi.patch} |  13 +-
 ...til-Make-STRERROR-portable-for-musl.patch} |   9 +-
 ...ke-malloc_trim-conditional-on-glibc.patch} |  13 +-
 ...ared-Do-not-use-malloc_info-on-musl.patch} |  11 +-
 ...4-avoid-missing-LOCK_EX-declaration.patch} |  24 +-
 ...gnal.h-to-avoid-the-undeclared-error.patch |  27 +
 ...references-using-stdin-as-a-struct-m.patch |  48 ++
 ...clusion-order-to-avoid-redeclaration.patch |  76 ++
 c-avoid-boot-time-segfault-for-musl.patch |  31 +
 .../{systemd_255.6.bb => systemd_256.bb}  |  62 +-
 31 files changed, 564 insertions(+), 1027 deletions(-)
 rename 
meta/recipes-core/systemd/systemd/{0002-binfmt-Don-t-install-dependency-links-at-install-tim.patch
 => 0001-binfmt-Don-t-install-dependency-links-at-install-tim.patch} (85%)
 rename 
meta/recipes-core/systemd/systemd/{0008-implment-systemd-sysv-install-for-OE.patch
 => 0002-implment-systemd-sysv-install-for-OE.patch} (91%)
 rename 
meta/recipes-core/systemd/systemd/{0023-meson-bpf-propagate-sysroot-for-cross-compilation.patch
 => 0003-meson-bpf-propagate-sysroot-for-cross-compilation.patch} (78%)
 delete mode 100644 
meta/recipes-core/systemd/systemd/0003-src-basic-missing.h-check-for-missing-strndupa.patch
 rename 
meta/recipes-core/systemd/systemd/{0001-missing_type.h-add-comparison_fn_t.patch
 => 0004-missing_type.h-add-comparison_fn_t.patch} (87%)
 rename 
meta/recipes-core/systemd/systemd/{0002-add-fallback-parse_printf_format-implementation.patch
 => 0005-add-fallback-parse_printf_format-implementation.patch} (96%)
 rename 
meta/recipes-core/systemd/systemd/{0004-don-t-fail-if-GLOB_BRACE-and-GLOB_ALTDIRFUNC-is-not-.patch
 => 0006-don-t-fail-if-GLOB_BRACE-and-GLOB_ALTDIRFUNC-is-not-.patch} (91%)
 rename 
meta/recipes-core/systemd/systemd/{0005-add-missing-FTW_-macros-for-musl.patch 
=> 0007-add-missing-FTW_-macros-for-musl.patch} (85%)
 rename 
meta/recipes-core/systemd/systemd/{0006-Use-uintmax_t-for-handling-rlim_t.patch 
=> 0008-Use-uintmax_t-for-handling-rlim_t.patch} (88%)
 rename 
meta/recipes-core/systemd/systemd/{0007-don-t-pass-AT_SYMLINK_NOFOLLOW-flag-to-faccessat.patch
 => 0009-don-t-pass-AT_SYMLINK_NOFOLLOW-flag-to-faccessat.patch} (96%)
 rename 
meta/recipes-core/systemd/systemd/{0008-Define-glibc-compatible-basename-for-non-glibc-syste.patch
 => 0010-Define-glibc-compatible-basename-for-non-glibc-syste.patch} (82%)
 rename 
meta/recipes-core/systemd/systemd/{0009-Do-not-disable-buffering-when-writing-to-oom_score_a.patch
 => 0011-Do-not-disable-buffering-when-writing-to-oom_score_a.patch} (82%)
 rename 
meta/recipes-core/systemd/systemd/{0010-distinguish-XSI-compliant-strerror_r-from-GNU-specif.patch
 => 0012-distinguish-XSI-compliant-strerror_r-from-GNU-specif.patch} (92%)
 rename 
meta/recipes

[OE-core][PATCH V2 3/5] util-linux/util-linux-libuuid: upgrade from 2.39.3 to 2.40.1

2024-07-11 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

License-Update:
===
GPL-2.0 is changed to GPL-2.0-only in README.licensing.

The following two patches are removed as they've been there in new release:

  0001-login-utils-include-libgen.h-for-basename-API.patch
  mit-license.patch

Other existing patches are refreshed to avoid patch-fuzz error.

A new PACKAGECONFIG, lastlog2, is added, which serves as a switch to build Y2038
safe lastlog pam module. This is a new functionality added in 2.40.

This 2.40.1 version has the problem of unnecessary remake, causing
intermmittent errors at parallel make. The do_compile:prepend is a
workaround for this. Upstream issue and PR are:
https://github.com/util-linux/util-linux/issues/3061
https://github.com/util-linux/util-linux/pull/3064

do_install is changed to do_install:append, the legacy codes are
removed. They've been there since the born of oe-core. I tested
with ccache, there's no error.

A new dependency, diffutils, is added to ptest. Because the mkswap-offset
test case needs 'cmp' from diffutils.

The tests/ts/misc/enosys test case is deleted for musl. This is because
the test case is comparing error description output and that's libc
specific. Results below can demonstrate the case.
'''
root@qemux86-64:/usr/lib/util-linux/ptest# cat 
/usr/lib/util-linux/ptest/tests/expected/misc/enosys-ioctl
test_enosys: ioctl r=0 errno=Success
test_enosys: ioctl r=-1 errno=Function not implemented
test_enosys: ioctl r=-1 errno=Inappropriate ioctl for device
test_enosys: ioctl r=-1 errno=Inappropriate ioctl for device
test_enosys: ioctl r=-1 errno=Function not implemented
root@qemux86-64:/usr/lib/util-linux/ptest# cat 
/usr/lib/util-linux/ptest/tests/output/misc/enosys-ioctl
test_enosys: ioctl r=0 errno=No error information
test_enosys: ioctl r=-1 errno=Function not implemented
test_enosys: ioctl r=-1 errno=Not a tty
test_enosys: ioctl r=-1 errno=Not a tty
test_enosys: ioctl r=-1 errno=Function not implemented
'''

Signed-off-by: Chen Qi 
---
 ...2.39.3.bb => util-linux-libuuid_2.40.1.bb} |  0
 meta/recipes-core/util-linux/util-linux.inc   |  8 +--
 ...ls-include-libgen.h-for-basename-API.patch | 60 ---
 .../util-linux/avoid_parallel_tests.patch |  5 +-
 .../util-linux/configure-sbindir.patch|  7 +--
 .../display_testname_for_subtest.patch|  7 +--
 .../util-linux/util-linux/mit-license.patch   | 45 --
 .../util-linux/util-linux/ptest.patch | 11 ++--
 ...l-linux_2.39.3.bb => util-linux_2.40.1.bb} | 24 +---
 9 files changed, 31 insertions(+), 136 deletions(-)
 rename meta/recipes-core/util-linux/{util-linux-libuuid_2.39.3.bb => 
util-linux-libuuid_2.40.1.bb} (100%)
 delete mode 100644 
meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
 delete mode 100644 meta/recipes-core/util-linux/util-linux/mit-license.patch
 rename meta/recipes-core/util-linux/{util-linux_2.39.3.bb => 
util-linux_2.40.1.bb} (94%)

diff --git a/meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb 
b/meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
similarity index 100%
rename from meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb
rename to meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
diff --git a/meta/recipes-core/util-linux/util-linux.inc 
b/meta/recipes-core/util-linux/util-linux.inc
index d506783f9a..0f5f838e84 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -6,7 +6,7 @@ disk partitioning, kernel message management, filesystem 
creation, and system lo
 
 SECTION = "base"
 
-LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & 
BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
+LICENSE = "GPL-1.0-or-later & GPL-2.0-only & GPL-2.0-or-later & 
LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
 LICENSE:${PN}-fcntl-lock = "MIT"
 LICENSE:${PN}-fdisk = "GPL-1.0-or-later"
 LICENSE:${PN}-libblkid = "LGPL-2.1-or-later"
@@ -14,7 +14,7 @@ LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
 LICENSE:${PN}-libmount = "LGPL-2.1-or-later"
 LICENSE:${PN}-libsmartcols = "LGPL-2.1-or-later"
 
-LIC_FILES_CHKSUM = 
"file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba \
+LIC_FILES_CHKSUM = 
"file://README.licensing;md5=ddd58b6c94da86ff4f03e91208eb9cfc \
 file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
 
file://Documentation/licenses/COPYING.GPL-2.0-or-later;md5=b234ee4d69f5fce4486a80fdaf4a4263
 \
 
file://Documentation/licenses/COPYING.LGPL-2.1-or-later;md5=4fbd65380cdd255951079008b364516c
 \
@@ -30,7 +30,6 @@ LIC_FILES_CHKSUM = 
"file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba
 FILESEXTRAPATHS:prepend 

Re: [OE-core][PATCH 3/4] util-linux/util-linux-libuuid: upgrade from 2.39.3 to 2.40.1

2024-07-10 Thread Chen Qi via lists.openembedded.org

On 7/10/24 04:54, Richard Purdie wrote:

On Thu, 2024-07-04 at 01:24 -0700, Chen Qi via lists.openembedded.org
wrote:

From: Chen Qi 

License-Update:
===
GPL-2.0 is changed to GPL-2.0-only in README.licensing.

The following two patches are removed as they've been there in new
release:

   0001-login-utils-include-libgen.h-for-basename-API.patch
   mit-license.patch

Other existing patches are refreshed to avoid patch-fuzz error.

A new PACKAGECONFIG, lastlog2, is added, which serves as a switch to
build Y2038
safe lastlog pam module. This is a new functionality added in 2.40.

This 2.40.1 version has the problem of unnecessary remake, causing
intermmittent errors at parallel make. The do_compile:prepend is a
workaround for this. Upstream issue and PR are:
https://github.com/util-linux/util-linux/issues/3061
https://github.com/util-linux/util-linux/pull/3064

do_install is changed to do_install:append, the legacy codes are
removed. They've been there since the born of oe-core. I tested
with ccache, there's no error.

Signed-off-by: Chen Qi 


I think these warnings in musl builds may be related to this:

https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/9230/steps/11/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/9241

I've reproduced the above issue. I'm looking into it now.


As well as this ptest regressions:

https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/6786

(arm ptest is still building at present:
https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/6608)


I'll look into the ptest failure ASAP.

Regards,

Qi




Cheers,

Richard




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#201690): 
https://lists.openembedded.org/g/openembedded-core/message/201690
Mute This Topic: https://lists.openembedded.org/mt/107034514/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 1/4] systemd: upgrade from 255.6 to 256

2024-07-04 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

The 'cgroupv2' PACKAGECONFIG is dropped as systemd now only supports
cgroupv2.

mime is now inherited because ${datadir}/mime/packages/io.systemd.xml
is a mime type file.

For musl specific patches, most are refreshed. One old patch is dropped,
and three new ones are added.
Newly added:
  build-path.c: avoid boot time segfault for musl
  adjust header inclusion order to avoid redeclaration
  undef stdin for references using stdin as a struct member
  include signal.h to avoid the 'undeclared' error
Dropped:
  src/basic/missing.h: check for missing strndupa
  (drop reason: systemd does not use strndupa any more)

Signed-off-by: Chen Qi 
---
 meta/recipes-core/systemd/systemd.inc |   4 +-
 ...all-dependency-links-at-install-tim.patch} |  21 +-
 ...mplment-systemd-sysv-install-for-OE.patch} |   7 +-
 ...agate-sysroot-for-cross-compilation.patch} |  10 +-
 ...missing.h-check-for-missing-strndupa.patch | 696 --
 ...-missing_type.h-add-comparison_fn_t.patch} |  15 +-
 ...-parse_printf_format-implementation.patch} |  25 +-
 ...B_BRACE-and-GLOB_ALTDIRFUNC-is-not-.patch} |  22 +-
 ...07-add-missing-FTW_-macros-for-musl.patch} |   9 +-
 ...8-Use-uintmax_t-for-handling-rlim_t.patch} |  23 +-
 ..._SYMLINK_NOFOLLOW-flag-to-faccessat.patch} |   9 +-
 ...atible-basename-for-non-glibc-syste.patch} |  10 +-
 ...ffering-when-writing-to-oom_score_a.patch} |  11 +-
 ...ompliant-strerror_r-from-GNU-specif.patch} |   9 +-
 ...efinition-of-prctl_mm_map-structure.patch} |  13 +-
 ...not-disable-buffer-in-writing-files.patch} | 151 ++--
 ...tch => 0015-Handle-__cpu_mask-usage.patch} |   9 +-
 ...atch => 0016-Handle-missing-gshadow.patch} |  50 +-
 h-Define-MIPS-ABI-defines-for-musl.patch} |   7 +-
 ...ss-correct-parameters-to-getdents64.patch} |  11 +-
 ...tch => 0019-Adjust-for-musl-headers.patch} | 165 ++---
 ...rerror-is-assumed-to-be-GNU-specifi.patch} |  13 +-
 ...til-Make-STRERROR-portable-for-musl.patch} |   9 +-
 ...ke-malloc_trim-conditional-on-glibc.patch} |  13 +-
 ...ared-Do-not-use-malloc_info-on-musl.patch} |  11 +-
 ...4-avoid-missing-LOCK_EX-declaration.patch} |  24 +-
 ...gnal.h-to-avoid-the-undeclared-error.patch |  27 +
 ...references-using-stdin-as-a-struct-m.patch |  48 ++
 ...clusion-order-to-avoid-redeclaration.patch |  76 ++
 c-avoid-boot-time-segfault-for-musl.patch |  31 +
 .../{systemd_255.6.bb => systemd_256.bb}  |  60 +-
 31 files changed, 563 insertions(+), 1026 deletions(-)
 rename 
meta/recipes-core/systemd/systemd/{0002-binfmt-Don-t-install-dependency-links-at-install-tim.patch
 => 0001-binfmt-Don-t-install-dependency-links-at-install-tim.patch} (85%)
 rename 
meta/recipes-core/systemd/systemd/{0008-implment-systemd-sysv-install-for-OE.patch
 => 0002-implment-systemd-sysv-install-for-OE.patch} (91%)
 rename 
meta/recipes-core/systemd/systemd/{0023-meson-bpf-propagate-sysroot-for-cross-compilation.patch
 => 0003-meson-bpf-propagate-sysroot-for-cross-compilation.patch} (78%)
 delete mode 100644 
meta/recipes-core/systemd/systemd/0003-src-basic-missing.h-check-for-missing-strndupa.patch
 rename 
meta/recipes-core/systemd/systemd/{0001-missing_type.h-add-comparison_fn_t.patch
 => 0004-missing_type.h-add-comparison_fn_t.patch} (87%)
 rename 
meta/recipes-core/systemd/systemd/{0002-add-fallback-parse_printf_format-implementation.patch
 => 0005-add-fallback-parse_printf_format-implementation.patch} (96%)
 rename 
meta/recipes-core/systemd/systemd/{0004-don-t-fail-if-GLOB_BRACE-and-GLOB_ALTDIRFUNC-is-not-.patch
 => 0006-don-t-fail-if-GLOB_BRACE-and-GLOB_ALTDIRFUNC-is-not-.patch} (91%)
 rename 
meta/recipes-core/systemd/systemd/{0005-add-missing-FTW_-macros-for-musl.patch 
=> 0007-add-missing-FTW_-macros-for-musl.patch} (85%)
 rename 
meta/recipes-core/systemd/systemd/{0006-Use-uintmax_t-for-handling-rlim_t.patch 
=> 0008-Use-uintmax_t-for-handling-rlim_t.patch} (88%)
 rename 
meta/recipes-core/systemd/systemd/{0007-don-t-pass-AT_SYMLINK_NOFOLLOW-flag-to-faccessat.patch
 => 0009-don-t-pass-AT_SYMLINK_NOFOLLOW-flag-to-faccessat.patch} (96%)
 rename 
meta/recipes-core/systemd/systemd/{0008-Define-glibc-compatible-basename-for-non-glibc-syste.patch
 => 0010-Define-glibc-compatible-basename-for-non-glibc-syste.patch} (82%)
 rename 
meta/recipes-core/systemd/systemd/{0009-Do-not-disable-buffering-when-writing-to-oom_score_a.patch
 => 0011-Do-not-disable-buffering-when-writing-to-oom_score_a.patch} (82%)
 rename 
meta/recipes-core/systemd/systemd/{0010-distinguish-XSI-compliant-strerror_r-from-GNU-specif.patch
 => 0012-distinguish-XSI-compliant-strerror_r-from-GNU-specif.patch} (92%)
 rename 
meta/recipes-core/systemd/systemd/{0011-avoid-redefinition-of-prctl_mm_map-structure.patch
 => 0013-avoid-redefinition-of-prctl_mm_map-structure.patch} (71%)
 rename 
meta/recipes-core/systemd/systemd/{0012-do-not-disable-buffer-in-writing-files.patch
 => 0014-do-not-disable-buffer-in-writing

[OE-core][PATCH 4/4] pciutils: remove textrel INSANE_SKIP

2024-07-04 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

The current pciutils does not have this textrel problem any more.

Signed-off-by: Chen Qi 
---
 meta/recipes-bsp/pciutils/pciutils_3.13.0.bb | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-bsp/pciutils/pciutils_3.13.0.bb 
b/meta/recipes-bsp/pciutils/pciutils_3.13.0.bb
index 0b876c7070..74edd8686b 100644
--- a/meta/recipes-bsp/pciutils/pciutils_3.13.0.bb
+++ b/meta/recipes-bsp/pciutils/pciutils_3.13.0.bb
@@ -47,8 +47,6 @@ DESCRIPTION:${PN}-ids = "Package providing the PCI device ID 
database for pciuti
 RDEPENDS:${PN} += "${PN}-ids"
 
 FILES:libpci = "${libdir}/libpci.so.*"
-# The versioned symbols in libpci appear to be causing relocations
-INSANE_SKIP:libpci += "textrel"
 
 ALTERNATIVE:${PN} = "lspci"
 ALTERNATIVE_PRIORITY = "100"
-- 
2.45.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#201524): 
https://lists.openembedded.org/g/openembedded-core/message/201524
Mute This Topic: https://lists.openembedded.org/mt/107034512/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 3/4] util-linux/util-linux-libuuid: upgrade from 2.39.3 to 2.40.1

2024-07-04 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

License-Update:
===
GPL-2.0 is changed to GPL-2.0-only in README.licensing.

The following two patches are removed as they've been there in new release:

  0001-login-utils-include-libgen.h-for-basename-API.patch
  mit-license.patch

Other existing patches are refreshed to avoid patch-fuzz error.

A new PACKAGECONFIG, lastlog2, is added, which serves as a switch to build Y2038
safe lastlog pam module. This is a new functionality added in 2.40.

This 2.40.1 version has the problem of unnecessary remake, causing
intermmittent errors at parallel make. The do_compile:prepend is a
workaround for this. Upstream issue and PR are:
https://github.com/util-linux/util-linux/issues/3061
https://github.com/util-linux/util-linux/pull/3064

do_install is changed to do_install:append, the legacy codes are
removed. They've been there since the born of oe-core. I tested
with ccache, there's no error.

Signed-off-by: Chen Qi 
---
 ...2.39.3.bb => util-linux-libuuid_2.40.1.bb} |  0
 meta/recipes-core/util-linux/util-linux.inc   |  8 +--
 ...ls-include-libgen.h-for-basename-API.patch | 60 ---
 .../util-linux/avoid_parallel_tests.patch |  5 +-
 .../util-linux/configure-sbindir.patch|  7 +--
 .../display_testname_for_subtest.patch|  7 +--
 .../util-linux/util-linux/mit-license.patch   | 45 --
 .../util-linux/util-linux/ptest.patch | 11 ++--
 ...l-linux_2.39.3.bb => util-linux_2.40.1.bb} | 21 ---
 9 files changed, 29 insertions(+), 135 deletions(-)
 rename meta/recipes-core/util-linux/{util-linux-libuuid_2.39.3.bb => 
util-linux-libuuid_2.40.1.bb} (100%)
 delete mode 100644 
meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
 delete mode 100644 meta/recipes-core/util-linux/util-linux/mit-license.patch
 rename meta/recipes-core/util-linux/{util-linux_2.39.3.bb => 
util-linux_2.40.1.bb} (95%)

diff --git a/meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb 
b/meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
similarity index 100%
rename from meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb
rename to meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
diff --git a/meta/recipes-core/util-linux/util-linux.inc 
b/meta/recipes-core/util-linux/util-linux.inc
index d506783f9a..0f5f838e84 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -6,7 +6,7 @@ disk partitioning, kernel message management, filesystem 
creation, and system lo
 
 SECTION = "base"
 
-LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & 
BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
+LICENSE = "GPL-1.0-or-later & GPL-2.0-only & GPL-2.0-or-later & 
LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
 LICENSE:${PN}-fcntl-lock = "MIT"
 LICENSE:${PN}-fdisk = "GPL-1.0-or-later"
 LICENSE:${PN}-libblkid = "LGPL-2.1-or-later"
@@ -14,7 +14,7 @@ LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
 LICENSE:${PN}-libmount = "LGPL-2.1-or-later"
 LICENSE:${PN}-libsmartcols = "LGPL-2.1-or-later"
 
-LIC_FILES_CHKSUM = 
"file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba \
+LIC_FILES_CHKSUM = 
"file://README.licensing;md5=ddd58b6c94da86ff4f03e91208eb9cfc \
 file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
 
file://Documentation/licenses/COPYING.GPL-2.0-or-later;md5=b234ee4d69f5fce4486a80fdaf4a4263
 \
 
file://Documentation/licenses/COPYING.LGPL-2.1-or-later;md5=4fbd65380cdd255951079008b364516c
 \
@@ -30,7 +30,6 @@ LIC_FILES_CHKSUM = 
"file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba
 FILESEXTRAPATHS:prepend := "${THISDIR}/util-linux:"
 MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
 SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-linux-${PV}.tar.xz
 \
-   file://mit-license.patch \
file://configure-sbindir.patch \
file://runuser.pamd \
file://runuser-l.pamd \
@@ -38,8 +37,7 @@ SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-lin
file://run-ptest \
file://display_testname_for_subtest.patch \
file://avoid_parallel_tests.patch \
-   file://0001-login-utils-include-libgen.h-for-basename-API.patch \
file://fcntl-lock.c \
"
 
-SRC_URI[sha256sum] = 
"7b6605e48d1a49f43cc4b4cfc59f313d0dd5402fa40b96810bd572e167dfed0f"
+SRC_URI[sha256sum] = 
"59e676aa53ccb44b6c39f0ffe01a8fa274891c91bef1474752fad92461def24f"
diff --git 
a/meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patc

[OE-core][PATCH 2/4] systemd-boot: upgrade from 255.6 to 256

2024-07-04 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Patch 0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch
is added to resolve build time error.

Signed-off-by: Chen Qi 
---
 ...ve_255.6.bb => systemd-boot-native_256.bb} |  0
 ...temd-boot_255.6.bb => systemd-boot_256.bb} |  2 ++
 ...on.build-ensure-VERSION_TAG-exists-i.patch | 32 +++
 3 files changed, 34 insertions(+)
 rename meta/recipes-core/systemd/{systemd-boot-native_255.6.bb => 
systemd-boot-native_256.bb} (100%)
 rename meta/recipes-core/systemd/{systemd-boot_255.6.bb => 
systemd-boot_256.bb} (95%)
 create mode 100644 
meta/recipes-core/systemd/systemd/0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch

diff --git a/meta/recipes-core/systemd/systemd-boot-native_255.6.bb 
b/meta/recipes-core/systemd/systemd-boot-native_256.bb
similarity index 100%
rename from meta/recipes-core/systemd/systemd-boot-native_255.6.bb
rename to meta/recipes-core/systemd/systemd-boot-native_256.bb
diff --git a/meta/recipes-core/systemd/systemd-boot_255.6.bb 
b/meta/recipes-core/systemd/systemd-boot_256.bb
similarity index 95%
rename from meta/recipes-core/systemd/systemd-boot_255.6.bb
rename to meta/recipes-core/systemd/systemd-boot_256.bb
index 9a6d8e9d6e..dd06b6218b 100644
--- a/meta/recipes-core/systemd/systemd-boot_255.6.bb
+++ b/meta/recipes-core/systemd/systemd-boot_256.bb
@@ -1,6 +1,8 @@
 require systemd.inc
 FILESEXTRAPATHS =. "${FILE_DIRNAME}/systemd:"
 
+SRC_URI += 
"file://0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch"
+
 require conf/image-uefi.conf
 
 DEPENDS = "intltool-native libcap util-linux gperf-native 
python3-jinja2-native python3-pyelftools-native"
diff --git 
a/meta/recipes-core/systemd/systemd/0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch
 
b/meta/recipes-core/systemd/systemd/0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch
new file mode 100644
index 00..6f02ea2f43
--- /dev/null
+++ 
b/meta/recipes-core/systemd/systemd/0001-src-boot-efi-meson.build-ensure-VERSION_TAG-exists-i.patch
@@ -0,0 +1,32 @@
+From 9df06062cebd0390d33de9694e9cb1c9fa7b8697 Mon Sep 17 00:00:00 2001
+From: Chen Qi 
+Date: Wed, 3 Jul 2024 23:18:41 -0700
+Subject: [PATCH] src/boot/efi/meson.build: ensure VERSION_TAG exists in case
+ of cross build
+
+The GIT_VERSION is changed to use VERSION_TAG, but in case of cross build
+for src/boot/efi, it's not set, causing build error because the compiler cannot
+know it's a macro thus treating it as some variable and error out.
+
+Upstream-Status: Submitted [https://github.com/systemd/systemd/pull/33612]
+
+Signed-off-by: Chen Qi 
+---
+ src/boot/efi/meson.build | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/boot/efi/meson.build b/src/boot/efi/meson.build
+index 7a60b0ec7e..99d108d6e8 100644
+--- a/src/boot/efi/meson.build
 b/src/boot/efi/meson.build
+@@ -65,6 +65,7 @@ endforeach
+ 
+ if meson.is_cross_build() and get_option('sbat-distro') == 'auto'
+ warning('Auto detection of SBAT information not supported when 
cross-building, disabling SBAT.')
++efi_conf.set_quoted('VERSION_TAG', version_tag)
+ elif get_option('sbat-distro') != ''
+ efi_conf.set_quoted('SBAT_PROJECT', meson.project_name())
+ efi_conf.set_quoted('PROJECT_VERSION', 
meson.project_version().split('~')[0])
+-- 
+2.45.1
+
-- 
2.45.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#201525): 
https://lists.openembedded.org/g/openembedded-core/message/201525
Mute This Topic: https://lists.openembedded.org/mt/107034513/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] VOLATILE_TMP_DIR: Extend to specify the persistence of /var/tmp

2024-07-04 Thread Chen Qi via lists.openembedded.org
I'd suggest we look at this patch again. IMHO, this patch brings the 
following benefits.


1) Variable names are more consistent

The current situation:
VOLATILE_LOG_DIR handles /var/log.
VOLATILE_TMP_DIR handles /tmp.

After this patch, the situation is:
VOLATILE_LOG_DIR hanldes /var/log.
VOLATILE_TMP_DIR handles /var/tmp.

2) /var/tmp being persistent in fact indicates that /tmp is persistent

This is because /tmp is a symlink to /var/tmp by default. And the 
tmp.mount has been handled well in systemd recipe.


3) Yocto can now build out container image inside which tools using 
/var/tmp can run.


4) When people use a separate partition for /var, they probably want 
persistent /var/tmp. This patch makes it easy to build out such image.


Regards,
Qi



On 6/12/24 08:56, Changqing Li via lists.openembedded.org wrote:


Hi,

Any concern about this patch? VOLATILE_TMP_DIR is originally added to 
specify the persistence of /tmp,


and I think it named as "VOLATILE_TMP", so maybe it is ok to extend to 
specify the persistence of /var/tmp (which by default is 
/var/volatile/tmp).


And this will cause doc change.

Regards

Changqing

On 5/30/24 17:02, Changqing Li wrote:

From: Changqing Li

Currently, set VOLATILE_TMP_DIR to "no", only make /tmp as persistent.
This patch extends VOLATILE_TMP_DIR to also specify the persistence of
/var/tmp by following changes:

* change FILESYSTEM_PERMS_TABLES to remove symlink /var/tmp -> /var/volatile/tmp
   for the packaging process
* update base-files to create /var/tmp as a dir not symlink to /var/volatile/tmp

Here is an use case:
Steps:
1. docker import core-image-minimal-qemux86-64.tar.bz2 poky:latest
2. docker run -it --rm poky:latest /bin/sh
3. /var/log /var/tmp are deadlinks, and cause "No such file or directory" errors

Root cause:
By default, /var/tmp links to /var/volatile/tmp, and /var/volatile/tmp
usually created by initscript(sysV) or systemd-tmpfile.d(systemd) during
boot up, but for container, initscript/systemd-tmpfile.d will not be
executed, so /var/volatile/tmp is not created.

This patch provides an option for user want to use container, set
VOLATILE_TMP_DIR to "no" can resolve above case.

Signed-off-by: Changqing Li
---
  meta/conf/bitbake.conf|  5 ++-
  ...fs-perms.txt => fs-perms-volatile-log.txt} | 32 ---
  ...tent-log.txt => fs-perms-volatile-tmp.txt} | 27 
  meta/files/fs-perms.txt   |  3 --
  .../base-files/base-files_3.0.14.bb   |  5 +--
  5 files changed, 7 insertions(+), 65 deletions(-)
  copy meta/files/{fs-perms.txt => fs-perms-volatile-log.txt} (53%)
  rename meta/files/{fs-perms-persistent-log.txt => fs-perms-volatile-tmp.txt} 
(59%)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 3ef2deb088..e6ec640809 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -384,7 +384,10 @@ FILESEXTRAPATHS ?= "__default:"
  #  base_prefix, prefix, exec_prefix, base_bindir, base_sbindir, base_libdir,
  #  datadir, sysconfdir, servicedir, sharedstatedir, localstatedir, infodir,
  #  mandir, docdir, bindir, sbindir, libexecdir, libdir and includedir
-FILESYSTEM_PERMS_TABLES ?="${@'files/fs-perms.txt' if 
oe.types.boolean(d.getVar('VOLATILE_LOG_DIR')) else 
'files/fs-perms-persistent-log.txt'}"

+FILESYSTEM_PERMS_TABLES ?=  " files/fs-perms.txt \
+  ${@'files/fs-perms-volatile-log.txt' if 
oe.types.boolean(d.getVar('VOLATILE_LOG_DIR')) else ''} \
+  ${@'files/fs-perms-volatile-tmp.txt' if 
oe.types.boolean(d.getVar('VOLATILE_TMP_DIR')) else ''} \
+"
  
  ##

  # General work and output directories for the build system.
diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms-volatile-log.txt
similarity index 53%
copy from meta/files/fs-perms.txt
copy to meta/files/fs-perms-volatile-log.txt
index 48191f504c..fc846bbdc5 100644
--- a/meta/files/fs-perms.txt
+++ b/meta/files/fs-perms-volatile-log.txt
@@ -28,39 +28,7 @@
  # Note: all standard config directories are automatically assigned "0755 root root 
false - - -"
  
  # Documentation should always be corrected

-${mandir}  0755rootroottrue0644rootroot
-${infodir} 0755rootroottrue0644rootroot
-${docdir}  0755rootroottrue0644rootroot
-${datadir}/gtk-doc 0755rootroottrue0644rootroot
-
-# Fixup locales
-${datadir}/locale  0755rootroottrue0644rootroot
-
-# Cleanup headers
-${includedir}  0755rootroottrue0644rootroot
-
-# Cleanup debug src
-/usr/src/debug 0755rootroottrue0644rootroot
  
  # Items from base-files

  # Links
-${localstatedir}/run   link/run
  ${localstatedir}/log  linkvolatile/log
-${localstatedir}/lock  

Re: [OE-core] [PATCH 1/2] systemd: Mitigate /var/tmp type mismatch issue

2024-07-04 Thread Chen Qi via lists.openembedded.org

There's a pending patch from Changqing, which also handles /var/tmp.
The title is: [OE-core] [PATCH] VOLATILE_TMP_DIR: Extend to specify the 
persistence of /var/tmp


I think we'd better handle that patch first because you may need to 
change to the way you used in your second patch to handle this /var/tmp 
link.


Regards,
Qi


On 7/4/24 15:15, Niko Mauno via lists.openembedded.org wrote:

From: Niko Mauno 

The base-files recipe provides /var/tmp -> /var/volatile/tmp symlink
which is in conflict with systemd upstream tmpfiles.d/tmp.conf which
defines it as a directory (or subvolume on btrfs).

This generates following error in journal:

   Jul 03 15:37:21 qemux86-64 systemd-tmpfiles[158]: "/var/tmp" already exists 
and is not a directory.

Mitigate the issue by defining /var/tmp as symlink corresponding to
the one created by base-files.

Signed-off-by: Niko Mauno 
---
  meta/recipes-core/systemd/systemd/00-create-volatile.conf | 1 +
  1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/systemd/systemd/00-create-volatile.conf 
b/meta/recipes-core/systemd/systemd/00-create-volatile.conf
index c4277221a2..043b2ef1d8 100644
--- a/meta/recipes-core/systemd/systemd/00-create-volatile.conf
+++ b/meta/recipes-core/systemd/systemd/00-create-volatile.conf
@@ -6,3 +6,4 @@
  d /run/lock   1777-   -   -
  d /var/volatile/log   -   -   -   -
  d /var/volatile/tmp   1777-   -
+L  /var/tmp-   -   -   -   
/var/volatile/tmp






-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#201522): 
https://lists.openembedded.org/g/openembedded-core/message/201522
Mute This Topic: https://lists.openembedded.org/mt/107033957/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [scarthgap][PATCH] OpenSSL: Security fix for CVE-2024-5535

2024-07-03 Thread Chen Qi via lists.openembedded.org
Yes, indeed. The fixup commits are squashed into the original ones.

Regards,
Qi

From: openembedded-core@lists.openembedded.org 
 On Behalf Of Siddharth Doshi via 
lists.openembedded.org
Sent: Wednesday, July 3, 2024 5:44 PM
To: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [scarthgap][PATCH] OpenSSL: Security fix for 
CVE-2024-5535

You're backporting the first 10. Are the remaining 6 needed?

- Essentially all 16 commits mentioned in 
https://github.com/openssl/openssl/pull/24717 are needed to solve the issue 
though 15 and 16th commit are just whitespace nit changes.

- However, when Matt merged all those 16 commits mentioned in above link, in 
the openssl stable branches, he kind of incorporated the last 6 patches in the 
main 10 patches as they were being applied in the same files of first 10 
patches which somewhere down the line makes sense.
- So, the 10 patches i committed has content of all 16 patches (even the last 
6) and i committed it in the same fashion as of openssl stable branches.

Regards,

Siddharth

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#201472): 
https://lists.openembedded.org/g/openembedded-core/message/201472
Mute This Topic: https://lists.openembedded.org/mt/107004007/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][scarthgap][PATCH] OpenSSL: Security fix for CVE-2024-5535

2024-07-03 Thread Chen Qi via lists.openembedded.org
The https://github.com/openssl/openssl/pull/24717 has 16 commits. You're 
backporting the first 10. Are the remaining 6 needed?


Regards,
Qi

On 7/3/24 01:11, Siddharth Doshi via lists.openembedded.org wrote:

From: Siddharth Doshi 

Upstream-Status: Backport from 
[https://github.com/openssl/openssl/commit/99fb785a5f85315b95288921a321a935ea29a51e]

CVE's Fixed:
CVE-2024-5535 openssl: SSL_select_next_proto buffer overread

Signed-off-by: Siddharth Doshi 
---
  .../openssl/openssl/CVE-2024-5535_1.patch |  113 ++
  .../openssl/openssl/CVE-2024-5535_10.patch|  203 +++
  .../openssl/openssl/CVE-2024-5535_2.patch |   43 +
  .../openssl/openssl/CVE-2024-5535_3.patch |   38 +
  .../openssl/openssl/CVE-2024-5535_4.patch |   82 ++
  .../openssl/openssl/CVE-2024-5535_5.patch |  176 +++
  .../openssl/openssl/CVE-2024-5535_6.patch | 1173 +
  .../openssl/openssl/CVE-2024-5535_7.patch |   43 +
  .../openssl/openssl/CVE-2024-5535_8.patch |   66 +
  .../openssl/openssl/CVE-2024-5535_9.patch |  271 
  .../openssl/openssl_3.2.2.bb  |   10 +
  11 files changed, 2218 insertions(+)
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_1.patch
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_10.patch
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_2.patch
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_3.patch
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_4.patch
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_5.patch
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_6.patch
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_7.patch
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_8.patch
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_9.patch

diff --git a/meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_1.patch 
b/meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_1.patch
new file mode 100644
index 00..d5c178eeab
--- /dev/null
+++ b/meta/recipes-connectivity/openssl/openssl/CVE-2024-5535_1.patch
@@ -0,0 +1,113 @@
+From b63b4db52e10677db4ab46b608aabd55a44668aa Mon Sep 17 00:00:00 2001
+From: Matt Caswell 
+Date: Fri, 31 May 2024 11:14:33 +0100
+Subject: [PATCH 01/10] Fix SSL_select_next_proto
+
+Ensure that the provided client list is non-NULL and starts with a valid
+entry. When called from the ALPN callback the client list should already
+have been validated by OpenSSL so this should not cause a problem. When
+called from the NPN callback the client list is locally configured and
+will not have already been validated. Therefore SSL_select_next_proto
+should not assume that it is correctly formatted.
+
+We implement stricter checking of the client protocol list. We also do the
+same for the server list while we are about it.
+
+CVE-2024-5535
+
+Reviewed-by: Neil Horman 
+Reviewed-by: Tomas Mraz 
+(Merged from https://github.com/openssl/openssl/pull/24717)
+
+Upstream-Status: Backport from 
[https://github.com/openssl/openssl/commit/99fb785a5f85315b95288921a321a935ea29a51e]
+CVE: CVE-2024-5535
+Signed-off-by: Siddharth Doshi 
+---
+ ssl/ssl_lib.c | 63 ---
+ 1 file changed, 40 insertions(+), 23 deletions(-)
+
+diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c
+index 016135f..cf52b31 100644
+--- a/ssl/ssl_lib.c
 b/ssl/ssl_lib.c
+@@ -3518,37 +3518,54 @@ int SSL_select_next_proto(unsigned char **out, 
unsigned char *outlen,
+   unsigned int server_len,
+   const unsigned char *client, unsigned int 
client_len)
+ {
+-unsigned int i, j;
+-const unsigned char *result;
+-int status = OPENSSL_NPN_UNSUPPORTED;
++PACKET cpkt, csubpkt, spkt, ssubpkt;
++
++if (!PACKET_buf_init(&cpkt, client, client_len)
++|| !PACKET_get_length_prefixed_1(&cpkt, &csubpkt)
++|| PACKET_remaining(&csubpkt) == 0) {
++*out = NULL;
++*outlen = 0;
++return OPENSSL_NPN_NO_OVERLAP;
++}
++
++/*
++ * Set the default opportunistic protocol. Will be overwritten if we find
++ * a match.
++ */
++*out = (unsigned char *)PACKET_data(&csubpkt);
++*outlen = (unsigned char)PACKET_remaining(&csubpkt);
+
+ /*
+  * For each protocol in server preference order, see if we support it.
+  */
+-for (i = 0; i < server_len;) {
+-for (j = 0; j < client_len;) {
+-if (server[i] == client[j] &&
+-memcmp(&server[i + 1], &client[j + 1], server[i]) == 0) {
+-/* We found a match */
+-result = &server[i];
+-status = OPENSSL_NPN_NEGOTIATED;
+-goto found;
++if (PACKET_buf_init(&spkt, server, server_len)) {
++   

Re: [OE-core] [PATCH] acl: Add attr to RDEPENDS:${PN}-ptest

2024-06-26 Thread Chen Qi via lists.openembedded.org
Just one question: the testcase's name looks like it's supposed to be run on 
some NFS. Does it?

Regards,
Qi

-Original Message-
From: openembedded-core@lists.openembedded.org 
 On Behalf Of Yu, Mingli via 
lists.openembedded.org
Sent: Thursday, June 27, 2024 2:18 PM
To: openembedded-core@lists.openembedded.org
Subject: [OE-core] [PATCH] acl: Add attr to RDEPENDS:${PN}-ptest

From: Mingli Yu 

* Add attr which provides getfattr to RDEPENDS:${PN}-ptest to fix below 
test/nfs/nfsacl failure.
  [19] $ getfattr -m- test/sub -- failed\n'
'Can\'t exec "getfattr": Nosuch file or directory at ./test/run line '
369,  line 24. != # file: test/sub\n'
'getfattr: No such file or directory   != system.posix_acl_access\n'
'~ != system.posix_acl_default\n'
'~

Signed-off-by: Mingli Yu 
---
 meta/recipes-support/attr/acl_2.3.2.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-support/attr/acl_2.3.2.bb 
b/meta/recipes-support/attr/acl_2.3.2.bb
index ee86ce2cae..5ac085c322 100644
--- a/meta/recipes-support/attr/acl_2.3.2.bb
+++ b/meta/recipes-support/attr/acl_2.3.2.bb
@@ -68,6 +68,7 @@ do_install_ptest:append:libc-musl() {  }
 
 RDEPENDS:${PN}-ptest = "acl \
+attr \
 bash \
 coreutils \
 perl \
--
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#201184): 
https://lists.openembedded.org/g/openembedded-core/message/201184
Mute This Topic: https://lists.openembedded.org/mt/106904612/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH 2/2] findutils: upgrade from 4.9.0 to 4.10.0

2024-06-14 Thread Chen Qi via lists.openembedded.org
I just checked. The problem could not be reproduced on my side. Commands and 
output are as below:

root@qemux86-64:/usr/lib/findutils/ptest# grep FAIL log
root@qemux86-64:/usr/lib/findutils/ptest# grep PASS log
PASS: tests/find/arg-nan.sh
PASS: tests/find/debug-missing-arg.sh
PASS: tests/find/exec-plus-last-file.sh
PASS: tests/find/execdir-fd-leak.sh
PASS: tests/find/files0-from.sh
PASS: tests/find/name-lbracket-literal.sh
PASS: tests/find/name-slash.sh
PASS: tests/find/newer.sh
PASS: tests/find/opt-numeric-arg.sh
PASS: tests/find/printf_escape_c.sh
PASS: tests/find/printf_escapechars.sh
PASS: tests/find/printf_inode.sh
PASS: tests/find/refuse-noop.sh
PASS: tests/find/type_list.sh
PASS: tests/find/used.sh
PASS: tests/find/user-group-max.sh
PASS: tests/misc/help-version.sh
PASS: tests/xargs/conflicting_opts.sh
PASS: tests/xargs/verbose-quote.sh
root@qemux86-64:/usr/lib/findutils/ptest# rpm
rpmrpmbuild   rpmgraph   rpmlua rpmsignrpmspec
rpm2cpio   rpmdb  rpmkeysrpmquery   rpmsortrpmverify
root@qemux86-64:/usr/lib/findutils/ptest# rpm -qa | grep musl
musl-1.2.4+git0+79bdacff83-r0.core2_64

Regards,
Qi

-Original Message-
From: Khem Raj  
Sent: Saturday, June 15, 2024 6:57 AM
To: Chen, Qi 
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 2/2] findutils: upgrade from 4.9.0 to 4.10.0

This fails ptests with qemux86_64/musl

bitbake core-image-ptest-findutils
results in

-find: invalid user name or UID argument to -user: '4294967296'
+find: invalid user name or UID argument to -user: ‘4294967296’
--- exp
+++ err
@@ -1 +1 @@
-find: invalid group name or GID argument to -group: '4294967296'
+find: invalid group name or GID argument to -group: ‘4294967296’
FAIL: tests/find/user-group-max.sh


On Thu, Jun 6, 2024 at 5:20 AM Chen Qi via lists.openembedded.org 
 wrote:
>
> From: Chen Qi 
>
> autoconf-2.73.patch is dropped as it's not needed any more.
>
> The run-ptest script is fixed. Instead copying function definitions 
> from init.cfg file, we should just install init.cfg file in the ptest 
> package. The coreutils-getlimits is added as a runtime dependency of 
> the ptest package because the getlimits command is needed.
>
> Signed-off-by: Chen Qi 
> ---
>  meta/recipes-extended/findutils/findutils.inc |  1 -
>  .../findutils/findutils/autoconf-2.73.patch   | 24 
>  .../findutils/findutils/run-ptest | 28 ---
>  ...findutils_4.9.0.bb => findutils_4.10.0.bb} |  6 ++--
>  4 files changed, 3 insertions(+), 56 deletions(-)  delete mode 100644 
> meta/recipes-extended/findutils/findutils/autoconf-2.73.patch
>  rename meta/recipes-extended/findutils/{findutils_4.9.0.bb => 
> findutils_4.10.0.bb} (78%)
>
> diff --git a/meta/recipes-extended/findutils/findutils.inc 
> b/meta/recipes-extended/findutils/findutils.inc
> index 03cf2a8d72..ddcc05750b 100644
> --- a/meta/recipes-extended/findutils/findutils.inc
> +++ b/meta/recipes-extended/findutils/findutils.inc
> @@ -7,7 +7,6 @@ BUGTRACKER = "http://savannah.gnu.org/bugs/?group=findutils";
>  SECTION = "console/utils"
>
>  SRC_URI = "${GNU_MIRROR}/${BPN}/${BP}.tar.xz \
> -  file://autoconf-2.73.patch \
>file://run-ptest \
>"
>
> diff --git 
> a/meta/recipes-extended/findutils/findutils/autoconf-2.73.patch 
> b/meta/recipes-extended/findutils/findutils/autoconf-2.73.patch
> deleted file mode 100644
> index 63728b5f91..00
> --- a/meta/recipes-extended/findutils/findutils/autoconf-2.73.patch
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -The gnulib largefile macro needs updating to work with autoconf 2.73. 
> Rather -than the full code:
> -
> -https://git.savannah.gnu.org/cgit/gnulib.git/commit/m4/largefile.m4?i
> d=f91f633858cf132e50924224c50d6264a92caabb
> -
> -Just tweak the exiting code to work with 2.73. The next findutils 
> upgrade should -update to new gnulib
> -
> -Upstream-Status: Inappropriate
> -Signed-off-by: Richard Purdie 
> -
> -Index: findutils-4.9.0/gl/m4/largefile.m4
> -===
>  findutils-4.9.0.orig/gl/m4/largefile.m4
> -+++ findutils-4.9.0/gl/m4/largefile.m4
> -@@ -26,7 +26,7 @@ AC_DEFUN([gl_SET_LARGEFILE_SOURCE],
> - # with _TIME_BITS.  Also, work around a problem in autoconf <= 2.69:
> - # AC_SYS_LARGEFILE does not configure for large inodes on Mac OS X 
> 10.5,
> - # or configures them incorrectly in some cases.
> --m4_version_prereq([2.70], [], [
> -+m4_version_prereq([2.73], [], [
> -
> - # _AC_SYS_LARGEFILE_TEST_INCLUDES
> - # ---
> diff --git a/meta/recipes-extended/findutils/findutils/run-ptest 
> b/meta/recipes-extended/findutils/findutils/run-ptest
&g

Re: [OE-core][PATCH 1/2] coreutils: split out coreutils-getlimits

2024-06-07 Thread Chen Qi via lists.openembedded.org
For OE, the finduitls package before 4.10.0 does not require getlimits to run 
its ptest. But for the new 4.10.0 version, its test cases need getlimits.

For other distros, I'm not sure if they have similar mechanisms like ptest and 
I'm not sure if they have met this problem. I just checked debian:latest and 
its finduitls package is of version 4.9.0. So chances are that they haven't met 
this problem or that their build system will not reveal such problem to them.

Regards,
Qi

-Original Message-
From: Ross Burton  
Sent: Friday, June 7, 2024 10:46 PM
To: Chen, Qi 
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 1/2] coreutils: split out coreutils-getlimits

On 7 Jun 2024, at 14:41, Chen Qi via lists.openembedded.org 
 wrote:
> 
> Because unlike other commands, getlimits is a noinst_PROGRAM. It's expected 
> to be used by its tests only. I checked Ubuntu, Debian and Fedora, none of 
> them provides getlimits. So if not for the ptest packages, we would not be 
> using this command either.

So if nobody installs it, how does anyone else run the findutils test suite?

Ross

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#200450): 
https://lists.openembedded.org/g/openembedded-core/message/200450
Mute This Topic: https://lists.openembedded.org/mt/106521746/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH 1/2] coreutils: split out coreutils-getlimits

2024-06-07 Thread Chen Qi via lists.openembedded.org
Because unlike other commands, getlimits is a noinst_PROGRAM. It's expected to 
be used by its tests only. I checked Ubuntu, Debian and Fedora, none of them 
provides getlimits. So if not for the ptest packages, we would not be using 
this command either.

Regards,
Qi

-Original Message-
From: Ross Burton  
Sent: Friday, June 7, 2024 9:34 PM
To: Chen, Qi 
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 1/2] coreutils: split out coreutils-getlimits

On 6 Jun 2024, at 13:20, Chen Qi via lists.openembedded.org 
 wrote:
> 
> From: Chen Qi 
> 
> Previously, the noinst_PROGRAM getlimits is put in coreutils-ptest 
> package in order to execute the ptest. However, this command might 
> also be needed by other ptest packages. As an example, findutils
> 4.10.0 ptest pacakge would need this command. So we split it out into 
> a new package.

Why would we not just put this in the main coreutils package?  What’s so 
special about getlimits that it needs a standalone package?

Ross

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#200443): 
https://lists.openembedded.org/g/openembedded-core/message/200443
Mute This Topic: https://lists.openembedded.org/mt/106521746/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][RFC 0/2] Write out file manifest in do_unpack

2024-06-06 Thread Chen Qi via lists.openembedded.org
If I understand it correctly, spdx uses patched source, so in order to 
be potentially used by spdx, the function should be called after do_patch


Regards,
Qi

On 6/6/24 22:03, Joshua Watt via lists.openembedded.org wrote:

This patch series implements a mechanism for do_unpack to write out a
manifest of unpacked files, which is now possible due to the UNPACKDIR
changes. This manifest can be consumed by downstream tasks to report the
source files for the recipe; specifically SPDX can use this instead of
the current behavior where it re-runs do_unpack on it's own.


Joshua Watt (2):
   utils: Add write_files_manifest helper
   classes-global/base: Add manifest to do_unpack

  meta/classes-global/base.bbclass |  4 +-
  meta/lib/oe/utils.py | 67 
  2 files changed, 70 insertions(+), 1 deletion(-)







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#200422): 
https://lists.openembedded.org/g/openembedded-core/message/200422
Mute This Topic: https://lists.openembedded.org/mt/106523630/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 1/2] coreutils: split out coreutils-getlimits

2024-06-06 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Previously, the noinst_PROGRAM getlimits is put in coreutils-ptest
package in order to execute the ptest. However, this command might
also be needed by other ptest packages. As an example, findutils
4.10.0 ptest pacakge would need this command. So we split it out
into a new package.

Signed-off-by: Chen Qi 
---
 meta/recipes-core/coreutils/coreutils_9.5.bb | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/coreutils/coreutils_9.5.bb 
b/meta/recipes-core/coreutils/coreutils_9.5.bb
index 9a5f836ebe..178dadc3c5 100644
--- a/meta/recipes-core/coreutils/coreutils_9.5.bb
+++ b/meta/recipes-core/coreutils/coreutils_9.5.bb
@@ -76,6 +76,11 @@ RDEPENDS:coreutils:class-target += 
"${@bb.utils.contains('PACKAGECONFIG', 'singl
 # regardless of whether single-binary is in effect.
 RPROVIDES:coreutils += "${@bb.utils.contains('PACKAGECONFIG', 'single-binary', 
'coreutils-stdbuf', '', d)}"
 
+# put getlimits into coreutils-getlimits, because other ptest packages such as
+# findutils-ptest may need this command. Note that getlimits is a 
noinst_PROGRAM
+PACKAGE_BEFORE_PN:class-target += "${PN}-getlimits"
+FILES:${PN}-getlimits = "${bindir}/getlimits"
+
 # Let aclocal use the relative path for the m4 file rather than the
 # absolute since coreutils has a lot of m4 files, otherwise there might
 # be an "Argument list too long" error when it is built in a long/deep
@@ -109,6 +114,9 @@ do_install:append() {
# in update-alternatives to fail, therefore use lbracket - the name used
# for the actual source file.
mv ${D}${bindir}/[ ${D}${bindir}/lbracket.${BPN}
+
+   # this getlimits noinst_PROGRAM would possibly be needed by other ptest 
packages
+   install ${B}/src/getlimits ${D}/${bindir}
 }
 
 inherit update-alternatives
@@ -204,7 +212,6 @@ do_install_ptest () {
 
 # Tweak test d_type-check to use python3 instead of python
 sed -i "1s@.*@#!/usr/bin/python3@" ${D}${PTEST_PATH}/tests/d_type-check
-install ${B}/src/getlimits ${D}/${bindir}
 
 # handle multilib
 sed -i s:@libdir@:${libdir}:g ${D}${PTEST_PATH}/run-ptest
@@ -216,4 +223,4 @@ do_install_ptest:append:libc-musl () {
 sed -i -e '/tests\/dd\/no-allocate.sh/d' ${D}${PTEST_PATH}/Makefile
 sed -i -e '/tests\/split\/line-bytes.sh/d' ${D}${PTEST_PATH}/Makefile
 }
-FILES:${PN}-ptest += "${bindir}/getlimits"
+RDEPENDS:${PN}-ptest += "${PN}-getlimits"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#200398): 
https://lists.openembedded.org/g/openembedded-core/message/200398
Mute This Topic: https://lists.openembedded.org/mt/106521746/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 2/2] findutils: upgrade from 4.9.0 to 4.10.0

2024-06-06 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

autoconf-2.73.patch is dropped as it's not needed any more.

The run-ptest script is fixed. Instead copying function definitions
from init.cfg file, we should just install init.cfg file in the ptest
package. The coreutils-getlimits is added as a runtime dependency of
the ptest package because the getlimits command is needed.

Signed-off-by: Chen Qi 
---
 meta/recipes-extended/findutils/findutils.inc |  1 -
 .../findutils/findutils/autoconf-2.73.patch   | 24 
 .../findutils/findutils/run-ptest | 28 ---
 ...findutils_4.9.0.bb => findutils_4.10.0.bb} |  6 ++--
 4 files changed, 3 insertions(+), 56 deletions(-)
 delete mode 100644 
meta/recipes-extended/findutils/findutils/autoconf-2.73.patch
 rename meta/recipes-extended/findutils/{findutils_4.9.0.bb => 
findutils_4.10.0.bb} (78%)

diff --git a/meta/recipes-extended/findutils/findutils.inc 
b/meta/recipes-extended/findutils/findutils.inc
index 03cf2a8d72..ddcc05750b 100644
--- a/meta/recipes-extended/findutils/findutils.inc
+++ b/meta/recipes-extended/findutils/findutils.inc
@@ -7,7 +7,6 @@ BUGTRACKER = "http://savannah.gnu.org/bugs/?group=findutils";
 SECTION = "console/utils"
 
 SRC_URI = "${GNU_MIRROR}/${BPN}/${BP}.tar.xz \
-  file://autoconf-2.73.patch \
   file://run-ptest \
   "
 
diff --git a/meta/recipes-extended/findutils/findutils/autoconf-2.73.patch 
b/meta/recipes-extended/findutils/findutils/autoconf-2.73.patch
deleted file mode 100644
index 63728b5f91..00
--- a/meta/recipes-extended/findutils/findutils/autoconf-2.73.patch
+++ /dev/null
@@ -1,24 +0,0 @@
-The gnulib largefile macro needs updating to work with autoconf 2.73. Rather
-than the full code:
-
-https://git.savannah.gnu.org/cgit/gnulib.git/commit/m4/largefile.m4?id=f91f633858cf132e50924224c50d6264a92caabb
-
-Just tweak the exiting code to work with 2.73. The next findutils upgrade 
should
-update to new gnulib
-
-Upstream-Status: Inappropriate
-Signed-off-by: Richard Purdie 
-
-Index: findutils-4.9.0/gl/m4/largefile.m4
-===
 findutils-4.9.0.orig/gl/m4/largefile.m4
-+++ findutils-4.9.0/gl/m4/largefile.m4
-@@ -26,7 +26,7 @@ AC_DEFUN([gl_SET_LARGEFILE_SOURCE],
- # with _TIME_BITS.  Also, work around a problem in autoconf <= 2.69:
- # AC_SYS_LARGEFILE does not configure for large inodes on Mac OS X 10.5,
- # or configures them incorrectly in some cases.
--m4_version_prereq([2.70], [], [
-+m4_version_prereq([2.73], [], [
- 
- # _AC_SYS_LARGEFILE_TEST_INCLUDES
- # ---
diff --git a/meta/recipes-extended/findutils/findutils/run-ptest 
b/meta/recipes-extended/findutils/findutils/run-ptest
index ec71583c51..3dec117067 100644
--- a/meta/recipes-extended/findutils/findutils/run-ptest
+++ b/meta/recipes-extended/findutils/findutils/run-ptest
@@ -10,34 +10,6 @@ export built_programs="find xargs locate updatedb"
 # this gets substituted by sed during build
 export VERSION="__run_ptest_version__"
 
-# define missing functions for tests/init.sh
-fu_path_prepend_ () {
-   path_prepend_ $@
-}
-
-print_ver_ () {
-   :
-}
-
-skip_if_root_ () {
-   [ $(id -u) = 0 ] && exit 77;
-}
-
-require_root_ () {
-   [ $(id -u) = 0 ] || exit 77;
-}
-
-expensive_ () {
-   :
-}
-
-export -f fu_path_prepend_
-export -f print_ver_
-export -f skip_if_root_
-export -f require_root_
-export -f expensive_
-
-
 for f in tests/*/*.sh; do
bash $f ;
case $? in
diff --git a/meta/recipes-extended/findutils/findutils_4.9.0.bb 
b/meta/recipes-extended/findutils/findutils_4.10.0.bb
similarity index 78%
rename from meta/recipes-extended/findutils/findutils_4.9.0.bb
rename to meta/recipes-extended/findutils/findutils_4.10.0.bb
index 074817df27..57f77de16f 100644
--- a/meta/recipes-extended/findutils/findutils_4.9.0.bb
+++ b/meta/recipes-extended/findutils/findutils_4.10.0.bb
@@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=1ebbd3e34237af26da5dc08a4e440464"
 
 DEPENDS = "bison-native"
 
-SRC_URI[sha256sum] = 
"a2bfb8c09d436770edc59f50fa483e785b161a3b7b9d547573cb08065fd462fe"
+SRC_URI[sha256sum] = 
"1387e0b67ff247d2abde998f90dfbf70c1491391a59ddfecb8ae698789f0a4f5"
 
 PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
 # http://savannah.gnu.org/bugs/?27299
@@ -15,13 +15,13 @@ CACHED_CONFIGUREVARS += "gl_cv_func_wcwidth_works=yes"
 EXTRA_OECONF += "ac_cv_path_SORT=${bindir}/sort"
 
 # need od from coreutils for -t option
-RDEPENDS:${PN}-ptest += "bash sed grep coreutils"
+RDEPENDS:${PN}-ptest += "bash sed grep coreutils coreutils-getlimits"
 
 do_install_ptest:class-target() {
mkdir -p ${D}${PTEST_PATH}/tests/
+   cp ${S}/init.cfg ${D}${PTEST_PATH}
cp -r ${S}/tests/* ${D}${PTEST_PATH}/tests/
 
# substitute val

Re: [OE-core][PATCH V2] util-linux/util-linux-libuuid: upgrade from 2.39.3 to 2.40.1

2024-05-28 Thread Chen Qi via lists.openembedded.org

On 5/29/24 02:06, Alexandre Belloni wrote:

Hello,

This breaks all the qemu*-alt build this way:

https://autobuilder.yoctoproject.org/typhoon/#/builders/109/builds/7875/steps/14/logs/stdio


Hi Alexandre,

I checked the error. This is a problem in systemd 255 that is exposed by 
new util-linux agetty.


See https://github.com/util-linux/util-linux/issues/2896.

The fix in systemd is: https://github.com/systemd/systemd/pull/31202

Looking at the contents, I don't think the above fix is appropriate to 
backport to 255. So we have two options:


1) Modify meta/lib/oeqa/runtime/cases/parselogs-ignores-common.txt to 
include the above error message so that the parselogs testcase does not 
fail. We'll then remove it when we upgrade systemd to 256 in the future.


2) Hold this util-linux upgrade until systemd 256 is released. I'll do 
the upgrade and check this problem again at that time.


Which one do you prefer?

Regards,

Qi






On 25/05/2024 13:03:48+0800, Chen Qi via lists.openembedded.org wrote:

From: Chen Qi 

License-Update:
===
GPL-2.0 is changed to GPL-2.0-only in README.licensing.

The following two patches are removed as they've been there in new release:

   0001-login-utils-include-libgen.h-for-basename-API.patch
   mit-license.patch

Other existing patches are refreshed to avoid patch-fuzz error.

A new PACKAGECONFIG, lastlog2, is added, which serves as a switch to build Y2038
safe lastlog pam module. This is a new functionality added in 2.40.

This 2.40.1 version has the problem of unnecessary remake, causing
intermmittent errors at parallel make. The do_compile:prepend is a
workaround for this. Upstream issue and PR are:
https://github.com/util-linux/util-linux/issues/3061
https://github.com/util-linux/util-linux/pull/3064

do_install is changed to do_install:append, the legacy codes are
removed. They've been there since the born of oe-core. I tested
with ccache, there's no error.

Signed-off-by: Chen Qi 
---
  ...2.39.3.bb => util-linux-libuuid_2.40.1.bb} |  0
  meta/recipes-core/util-linux/util-linux.inc   |  8 +--
  ...ls-include-libgen.h-for-basename-API.patch | 60 ---
  .../util-linux/avoid_parallel_tests.patch |  5 +-
  .../util-linux/configure-sbindir.patch|  7 +--
  .../display_testname_for_subtest.patch|  7 +--
  .../util-linux/util-linux/mit-license.patch   | 45 --
  .../util-linux/util-linux/ptest.patch | 11 ++--
  ...l-linux_2.39.3.bb => util-linux_2.40.1.bb} | 21 ---
  9 files changed, 29 insertions(+), 135 deletions(-)
  rename meta/recipes-core/util-linux/{util-linux-libuuid_2.39.3.bb => 
util-linux-libuuid_2.40.1.bb} (100%)
  delete mode 100644 
meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
  delete mode 100644 meta/recipes-core/util-linux/util-linux/mit-license.patch
  rename meta/recipes-core/util-linux/{util-linux_2.39.3.bb => 
util-linux_2.40.1.bb} (95%)

diff --git a/meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb 
b/meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
similarity index 100%
rename from meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb
rename to meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
diff --git a/meta/recipes-core/util-linux/util-linux.inc 
b/meta/recipes-core/util-linux/util-linux.inc
index d506783f9a..0f5f838e84 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -6,7 +6,7 @@ disk partitioning, kernel message management, filesystem 
creation, and system lo
  
  SECTION = "base"
  
-LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"

+LICENSE = "GPL-1.0-or-later & GPL-2.0-only & GPL-2.0-or-later & LGPL-2.1-or-later & 
BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
  LICENSE:${PN}-fcntl-lock = "MIT"
  LICENSE:${PN}-fdisk = "GPL-1.0-or-later"
  LICENSE:${PN}-libblkid = "LGPL-2.1-or-later"
@@ -14,7 +14,7 @@ LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
  LICENSE:${PN}-libmount = "LGPL-2.1-or-later"
  LICENSE:${PN}-libsmartcols = "LGPL-2.1-or-later"
  
-LIC_FILES_CHKSUM = "file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba \

+LIC_FILES_CHKSUM = 
"file://README.licensing;md5=ddd58b6c94da86ff4f03e91208eb9cfc \
  file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
  
file://Documentation/licenses/COPYING.GPL-2.0-or-later;md5=b234ee4d69f5fce4486a80fdaf4a4263
 \
  
file://Documentation/licenses/COPYING.LGPL-2.1-or-later;md5=4fbd65380cdd255951079008b364516c
 \
@@ -30,7 +30,6 @@ LIC_FILES_CHKSUM = 
"file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba
  FILESEXTRAPATHS:prepend := "${THISDIR

[OE-core][PATCH] libnl: change HOMEPAGE

2024-05-25 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

http://www.infradead.org/~tgr/libnl/ stops at 2014, the
current official home page should be the github one.

Signed-off-by: Chen Qi 
---
 meta/recipes-support/libnl/libnl_3.9.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/libnl/libnl_3.9.0.bb 
b/meta/recipes-support/libnl/libnl_3.9.0.bb
index db9d93e8cb..b2825374cf 100644
--- a/meta/recipes-support/libnl/libnl_3.9.0.bb
+++ b/meta/recipes-support/libnl/libnl_3.9.0.bb
@@ -4,7 +4,7 @@ APIs to netlink protocol based Linux kernel interfaces. libnl 
is the core \
 library implementing the fundamentals required to use the netlink protocol \
 such as socket handling, message construction and parsing, and sending \
 and receiving of data."
-HOMEPAGE = "http://www.infradead.org/~tgr/libnl/";
+HOMEPAGE = "https://github.com/thom311/libnl";
 SECTION = "libs/network"
 
 PE = "1"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199878): 
https://lists.openembedded.org/g/openembedded-core/message/199878
Mute This Topic: https://lists.openembedded.org/mt/106309876/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH V2] kmod: upgrade from 31 to 32

2024-05-25 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

kmod now installs symlinks in 'make install'.
https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/commit/?
id=e98cef6f3f8cd6f8bfb26d147b2c209297453cca

Changes are made in do_install to ensure that we can to continue to
use sbin. This is because our kernel has: CONFIG_MODPROBE_PATH='/sbin/modprobe'.
We'll need to sync our kmod path settings with our kernel config. Otherwise,
things would fail. For example, libnl's some ptest cases fail.

Signed-off-by: Chen Qi 
---
 meta/recipes-kernel/kmod/{kmod_31.bb => kmod_32.bb} | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 rename meta/recipes-kernel/kmod/{kmod_31.bb => kmod_32.bb} (95%)

diff --git a/meta/recipes-kernel/kmod/kmod_31.bb 
b/meta/recipes-kernel/kmod/kmod_32.bb
similarity index 95%
rename from meta/recipes-kernel/kmod/kmod_31.bb
rename to meta/recipes-kernel/kmod/kmod_32.bb
index 718a5565b4..1c4e5a94db 100644
--- a/meta/recipes-kernel/kmod/kmod_31.bb
+++ b/meta/recipes-kernel/kmod/kmod_32.bb
@@ -15,7 +15,7 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
"
 inherit autotools bash-completion gtk-doc pkgconfig manpages 
update-alternatives
 
-SRCREV = "aff617ea871d0568cc491bd116c0be1e857463bb"
+SRCREV = "41faa59711742c1476d59985011ee0f27ed91d30"
 
 SRC_URI = 
"git://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git;branch=master;protocol=https
 \
file://depmod-search.conf \
@@ -52,8 +52,9 @@ do_install:append () {
 install -dm755 ${D}${base_bindir}
 install -dm755 ${D}${base_sbindir}
 # add symlinks to kmod
-ln -rs ${D}${base_bindir}/kmod ${D}${base_bindir}/lsmod
+[ -e ${D}${base_bindir}/lsmod ] || ln -rs ${D}${base_bindir}/kmod 
${D}${base_bindir}/lsmod
 for tool in insmod rmmod depmod modinfo modprobe; do
+rm -f ${D}${base_bindir}/${tool}
 ln -rs ${D}${base_bindir}/kmod ${D}${base_sbindir}/${tool}
 done
 # configuration directories
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199877): 
https://lists.openembedded.org/g/openembedded-core/message/199877
Mute This Topic: https://lists.openembedded.org/mt/106309875/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH V2] util-linux/util-linux-libuuid: upgrade from 2.39.3 to 2.40.1

2024-05-24 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

License-Update:
===
GPL-2.0 is changed to GPL-2.0-only in README.licensing.

The following two patches are removed as they've been there in new release:

  0001-login-utils-include-libgen.h-for-basename-API.patch
  mit-license.patch

Other existing patches are refreshed to avoid patch-fuzz error.

A new PACKAGECONFIG, lastlog2, is added, which serves as a switch to build Y2038
safe lastlog pam module. This is a new functionality added in 2.40.

This 2.40.1 version has the problem of unnecessary remake, causing
intermmittent errors at parallel make. The do_compile:prepend is a
workaround for this. Upstream issue and PR are:
https://github.com/util-linux/util-linux/issues/3061
https://github.com/util-linux/util-linux/pull/3064

do_install is changed to do_install:append, the legacy codes are
removed. They've been there since the born of oe-core. I tested
with ccache, there's no error.

Signed-off-by: Chen Qi 
---
 ...2.39.3.bb => util-linux-libuuid_2.40.1.bb} |  0
 meta/recipes-core/util-linux/util-linux.inc   |  8 +--
 ...ls-include-libgen.h-for-basename-API.patch | 60 ---
 .../util-linux/avoid_parallel_tests.patch |  5 +-
 .../util-linux/configure-sbindir.patch|  7 +--
 .../display_testname_for_subtest.patch|  7 +--
 .../util-linux/util-linux/mit-license.patch   | 45 --
 .../util-linux/util-linux/ptest.patch | 11 ++--
 ...l-linux_2.39.3.bb => util-linux_2.40.1.bb} | 21 ---
 9 files changed, 29 insertions(+), 135 deletions(-)
 rename meta/recipes-core/util-linux/{util-linux-libuuid_2.39.3.bb => 
util-linux-libuuid_2.40.1.bb} (100%)
 delete mode 100644 
meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
 delete mode 100644 meta/recipes-core/util-linux/util-linux/mit-license.patch
 rename meta/recipes-core/util-linux/{util-linux_2.39.3.bb => 
util-linux_2.40.1.bb} (95%)

diff --git a/meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb 
b/meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
similarity index 100%
rename from meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb
rename to meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
diff --git a/meta/recipes-core/util-linux/util-linux.inc 
b/meta/recipes-core/util-linux/util-linux.inc
index d506783f9a..0f5f838e84 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -6,7 +6,7 @@ disk partitioning, kernel message management, filesystem 
creation, and system lo
 
 SECTION = "base"
 
-LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & 
BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
+LICENSE = "GPL-1.0-or-later & GPL-2.0-only & GPL-2.0-or-later & 
LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
 LICENSE:${PN}-fcntl-lock = "MIT"
 LICENSE:${PN}-fdisk = "GPL-1.0-or-later"
 LICENSE:${PN}-libblkid = "LGPL-2.1-or-later"
@@ -14,7 +14,7 @@ LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
 LICENSE:${PN}-libmount = "LGPL-2.1-or-later"
 LICENSE:${PN}-libsmartcols = "LGPL-2.1-or-later"
 
-LIC_FILES_CHKSUM = 
"file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba \
+LIC_FILES_CHKSUM = 
"file://README.licensing;md5=ddd58b6c94da86ff4f03e91208eb9cfc \
 file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
 
file://Documentation/licenses/COPYING.GPL-2.0-or-later;md5=b234ee4d69f5fce4486a80fdaf4a4263
 \
 
file://Documentation/licenses/COPYING.LGPL-2.1-or-later;md5=4fbd65380cdd255951079008b364516c
 \
@@ -30,7 +30,6 @@ LIC_FILES_CHKSUM = 
"file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba
 FILESEXTRAPATHS:prepend := "${THISDIR}/util-linux:"
 MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
 SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-linux-${PV}.tar.xz
 \
-   file://mit-license.patch \
file://configure-sbindir.patch \
file://runuser.pamd \
file://runuser-l.pamd \
@@ -38,8 +37,7 @@ SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-lin
file://run-ptest \
file://display_testname_for_subtest.patch \
file://avoid_parallel_tests.patch \
-   file://0001-login-utils-include-libgen.h-for-basename-API.patch \
file://fcntl-lock.c \
"
 
-SRC_URI[sha256sum] = 
"7b6605e48d1a49f43cc4b4cfc59f313d0dd5402fa40b96810bd572e167dfed0f"
+SRC_URI[sha256sum] = 
"59e676aa53ccb44b6c39f0ffe01a8fa274891c91bef1474752fad92461def24f"
diff --git 
a/meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patc

Re: [OE-core][PATCH 6/6] kmod: upgrade from 31 to 32

2024-05-21 Thread Chen Qi via lists.openembedded.org

Thanks. I'll fix it and send out V2.

Regards,
Qi

On 5/22/24 06:26, Richard Purdie wrote:

On Mon, 2024-05-20 at 16:10 +0800, Chen Qi via lists.openembedded.org wrote:

From: Chen Qi 

kmod now installs symlinks in 'make install'.
https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/commit/?
id=e98cef6f3f8cd6f8bfb26d147b2c209297453cca

With this change, we no longer need to deal with the symlinks in
do_install. Besides, as upstream chooses 'bin' instead of 'sbin'
to hold the tools, we'd better sync with it. That's the reason for
the sbindir -> bindir changes.

Signed-off-by: Chen Qi 
---
  .../kmod/{kmod_31.bb => kmod_32.bb}   | 24 +++
  1 file changed, 8 insertions(+), 16 deletions(-)
  rename meta/recipes-kernel/kmod/{kmod_31.bb => kmod_32.bb} (78%)

I think this is causing libnl ptest failures:

https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/6437/steps/12/logs/stdio

https://autobuilder.yocto.io/pub/non-release/20240521-26/testresults/qemuarm64-ptest/libnl.log


Cheers,

Richard




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199679): 
https://lists.openembedded.org/g/openembedded-core/message/199679
Mute This Topic: https://lists.openembedded.org/mt/106199577/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH 2/6] util-linux/util-linux-libuuid: upgrade from 2.39.3 to 2.40.1

2024-05-21 Thread Chen Qi via lists.openembedded.org
Got it. I'll look into this error, and also the other one you pointed out in 
another email.

Regards,
Qi

-Original Message-
From: Alexandre Belloni  
Sent: Tuesday, May 21, 2024 5:32 PM
To: Chen, Qi 
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 2/6] util-linux/util-linux-libuuid: upgrade from 
2.39.3 to 2.40.1

This fails on the autobuilders:

ERROR: util-linux-2.40.1-r0 do_package: QA Issue: util-linux: Files/directories 
were installed but not shipped in any package:
  /lib/security/pam_lastlog2.so

https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/9011/steps/15/logs/stdio

On 20/05/2024 16:10:36+0800, Chen Qi via lists.openembedded.org wrote:
> From: Chen Qi 
> 
> License-Update:
> ===
> GPL-2.0 is changed to GPL-2.0-only in README.licensing.
> 
> The following two patches are removed as they've been there in new release:
> 
>   0001-login-utils-include-libgen.h-for-basename-API.patch
>   mit-license.patch
> 
> Other existing patches are refreshed to avoid patch-fuzz error.
> 
> A new PACKAGECONFIG, lastlog2, is added, which serves as a switch to 
> build Y2038 safe lastlog pam module. This is a new functionality added in 
> 2.40.
> 
> Signed-off-by: Chen Qi 
> ---
>  ...2.39.3.bb => util-linux-libuuid_2.40.1.bb} |  0
>  meta/recipes-core/util-linux/util-linux.inc   |  8 +--
>  ...ls-include-libgen.h-for-basename-API.patch | 60 ---
>  .../util-linux/avoid_parallel_tests.patch |  5 +-
>  .../util-linux/configure-sbindir.patch|  7 +--
>  .../display_testname_for_subtest.patch|  7 +--
>  .../util-linux/util-linux/mit-license.patch   | 45 --
>  .../util-linux/util-linux/ptest.patch | 11 ++--
>  ...l-linux_2.39.3.bb => util-linux_2.40.1.bb} |  3 +-
>  9 files changed, 18 insertions(+), 128 deletions(-)  rename 
> meta/recipes-core/util-linux/{util-linux-libuuid_2.39.3.bb => 
> util-linux-libuuid_2.40.1.bb} (100%)  delete mode 100644 
> meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libge
> n.h-for-basename-API.patch  delete mode 100644 
> meta/recipes-core/util-linux/util-linux/mit-license.patch
>  rename meta/recipes-core/util-linux/{util-linux_2.39.3.bb => 
> util-linux_2.40.1.bb} (99%)
> 
> diff --git a/meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb 
> b/meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
> similarity index 100%
> rename from meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb
> rename to meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
> diff --git a/meta/recipes-core/util-linux/util-linux.inc 
> b/meta/recipes-core/util-linux/util-linux.inc
> index d506783f9a..0f5f838e84 100644
> --- a/meta/recipes-core/util-linux/util-linux.inc
> +++ b/meta/recipes-core/util-linux/util-linux.inc
> @@ -6,7 +6,7 @@ disk partitioning, kernel message management, 
> filesystem creation, and system lo
>  
>  SECTION = "base"
>  
> -LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & 
> BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
> +LICENSE = "GPL-1.0-or-later & GPL-2.0-only & GPL-2.0-or-later & 
> LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
>  LICENSE:${PN}-fcntl-lock = "MIT"
>  LICENSE:${PN}-fdisk = "GPL-1.0-or-later"
>  LICENSE:${PN}-libblkid = "LGPL-2.1-or-later"
> @@ -14,7 +14,7 @@ LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
>  LICENSE:${PN}-libmount = "LGPL-2.1-or-later"
>  LICENSE:${PN}-libsmartcols = "LGPL-2.1-or-later"
>  
> -LIC_FILES_CHKSUM = 
> "file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba \
> +LIC_FILES_CHKSUM = 
> +"file://README.licensing;md5=ddd58b6c94da86ff4f03e91208eb9cfc \
>  file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
>  
> file://Documentation/licenses/COPYING.GPL-2.0-or-later;md5=b234ee4d69f5fce4486a80fdaf4a4263
>  \
>  
> file://Documentation/licenses/COPYING.LGPL-2.1-or-later;md5=4fbd65380c
> dd255951079008b364516c \ @@ -30,7 +30,6 @@ LIC_FILES_CHKSUM = 
> "file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba
>  FILESEXTRAPATHS:prepend := "${THISDIR}/util-linux:"
>  MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
>  SRC_URI = 
> "${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-linux-${PV}.tar.xz
>  \
> -   file://mit-license.patch \
> file://configure-sbindir.patch \
> file://runuser.pamd \
> file://runuser-l.pamd \

Re: [OE-core][PATCH 1/6] systemd/systemd-boot: upgrade from 255.4 to 255.6

2024-05-21 Thread Chen Qi via lists.openembedded.org
I didn't find the 0001-basic-add-PIDFS-magic-31709.patch file in poky.
Is it from some other people's patch? If so, then that patch could be dropped 
as the error message says 'can be reverse-applied'.

Regards,
Qi

-Original Message-
From: Alexandre Belloni  
Sent: Tuesday, May 21, 2024 5:38 PM
To: Chen, Qi 
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 1/6] systemd/systemd-boot: upgrade from 255.4 to 
255.6

This also fails on the autobuilders:

ERROR: systemd-1_255.6-r0 do_patch: Applying patch 
'0001-basic-add-PIDFS-magic-31709.patch' on target directory 
'/home/pokybuild/yocto-worker/qemux86-alt/build/build/tmp/work/core2-32-poky-linux/systemd/255.6/git'
CmdError('quilt --quiltrc 
/home/pokybuild/yocto-worker/qemux86-alt/build/build/tmp/work/core2-32-poky-linux/systemd/255.6/recipe-sysroot-native/etc/quiltrc
 push', 0, 'stdout: Applying patch 0001-basic-add-PIDFS-magic-31709.patch
patching file src/basic/filesystems-gperf.gperf
Hunk #1 FAILED at 91.
1 out of 1 hunk FAILED -- rejects in file src/basic/filesystems-gperf.gperf
patching file src/basic/missing_magic.h
Hunk #1 succeeded at 133 with fuzz 1 (offset 5 lines).
Patch 0001-basic-add-PIDFS-magic-31709.patch can be reverse-applied
stderr: ')

https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/7736/steps/13/logs/stdio

On 20/05/2024 16:10:35+0800, Chen Qi via lists.openembedded.org wrote:
> From: Chen Qi 
> 
> musl patches are refreshed to avoid 'patch-fuzz' error.
> 
> Signed-off-by: Chen Qi 
> ---
>  ..._255.4.bb => systemd-boot-native_255.6.bb} |  0
>  ...md-boot_255.4.bb => systemd-boot_255.6.bb} |  0
>  meta/recipes-core/systemd/systemd.inc |  2 +-
>  ...1-missing_type.h-add-comparison_fn_t.patch |  7 +--
>  ...k-parse_printf_format-implementation.patch | 13 ++---
>  ...tall-dependency-links-at-install-tim.patch |  9 +--
>  ...missing.h-check-for-missing-strndupa.patch | 55 +--
>  ...OB_BRACE-and-GLOB_ALTDIRFUNC-is-not-.patch | 14 ++---
>  ...005-add-missing-FTW_-macros-for-musl.patch |  7 +--
>  ...06-Use-uintmax_t-for-handling-rlim_t.patch | 11 ++--
>  ...T_SYMLINK_NOFOLLOW-flag-to-faccessat.patch | 11 ++--
>  ...patible-basename-for-non-glibc-syste.patch |  8 +--
>  ...implment-systemd-sysv-install-for-OE.patch |  5 +-
>  ...uffering-when-writing-to-oom_score_a.patch |  9 +--
>  ...compliant-strerror_r-from-GNU-specif.patch | 13 ++---
>  ...definition-of-prctl_mm_map-structure.patch |  7 +--
>  ...-not-disable-buffer-in-writing-files.patch | 35 ++--
>  .../0013-Handle-__cpu_mask-usage.patch|  7 +--
>  .../systemd/0014-Handle-missing-gshadow.patch |  7 +--
>  ...l.h-Define-MIPS-ABI-defines-for-musl.patch | 11 ++--
>  ...ass-correct-parameters-to-getdents64.patch |  7 +--
>  .../0017-Adjust-for-musl-headers.patch| 17 +++---
>  ...trerror-is-assumed-to-be-GNU-specifi.patch |  9 +--
>  ...util-Make-STRERROR-portable-for-musl.patch |  7 +--
>  ...ake-malloc_trim-conditional-on-glibc.patch |  9 +--
>  ...hared-Do-not-use-malloc_info-on-musl.patch |  7 +--
>  ...22-avoid-missing-LOCK_EX-declaration.patch |  9 +--
>  .../{systemd_255.4.bb => systemd_255.6.bb}|  0
>  28 files changed, 111 insertions(+), 185 deletions(-)
>  rename meta/recipes-core/systemd/{systemd-boot-native_255.4.bb => 
> systemd-boot-native_255.6.bb} (100%)
>  rename meta/recipes-core/systemd/{systemd-boot_255.4.bb => 
> systemd-boot_255.6.bb} (100%)
>  rename meta/recipes-core/systemd/{systemd_255.4.bb => systemd_255.6.bb} 
> (100%)
> 
> diff --git a/meta/recipes-core/systemd/systemd-boot-native_255.4.bb 
> b/meta/recipes-core/systemd/systemd-boot-native_255.6.bb
> similarity index 100%
> rename from meta/recipes-core/systemd/systemd-boot-native_255.4.bb
> rename to meta/recipes-core/systemd/systemd-boot-native_255.6.bb
> diff --git a/meta/recipes-core/systemd/systemd-boot_255.4.bb 
> b/meta/recipes-core/systemd/systemd-boot_255.6.bb
> similarity index 100%
> rename from meta/recipes-core/systemd/systemd-boot_255.4.bb
> rename to meta/recipes-core/systemd/systemd-boot_255.6.bb
> diff --git a/meta/recipes-core/systemd/systemd.inc 
> b/meta/recipes-core/systemd/systemd.inc
> index a35db5091e..8bda47dd38 100644
> --- a/meta/recipes-core/systemd/systemd.inc
> +++ b/meta/recipes-core/systemd/systemd.inc
> @@ -15,7 +15,7 @@ LICENSE:libsystemd = "LGPL-2.1-or-later"
>  LIC_FILES_CHKSUM = "file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe 
> \
>  
> file://LICENSE.LGPL2.1;md5=4fbd65380cdd255951079008b364516c"
>  
> -SRCREV = "387a14a7b67b8b76adaed4175e14bb7e39b2f738"
> +SRCREV = "5810c25792d4268282dd3892af1a253b690423c9"
>  SRCBR

[OE-core][PATCH 3/6] pciutils: upgrade from 3.11.1 to 3.12.0

2024-05-20 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

configure.patch is rebased against the new version.

Signed-off-by: Chen Qi 
---
 meta/recipes-bsp/pciutils/pciutils/configure.patch  | 13 -
 .../{pciutils_3.11.1.bb => pciutils_3.12.0.bb}  |  2 +-
 2 files changed, 9 insertions(+), 6 deletions(-)
 rename meta/recipes-bsp/pciutils/{pciutils_3.11.1.bb => pciutils_3.12.0.bb} 
(95%)

diff --git a/meta/recipes-bsp/pciutils/pciutils/configure.patch 
b/meta/recipes-bsp/pciutils/pciutils/configure.patch
index 5015cf4884..0ff151b8cf 100644
--- a/meta/recipes-bsp/pciutils/pciutils/configure.patch
+++ b/meta/recipes-bsp/pciutils/pciutils/configure.patch
@@ -1,4 +1,4 @@
-From 561216c8cbc280aaa9aecf30cb11835a4a0a78ed Mon Sep 17 00:00:00 2001
+From 6af07e1f812b2444d33ce199308c87e04b2f5dc7 Mon Sep 17 00:00:00 2001
 From: Richard Purdie 
 Date: Wed, 31 Dec 2008 17:20:38 +
 Subject: [PATCH] pciutils: Upgarde 2.2.4 -> 3.0.3
@@ -23,20 +23,20 @@ Upstream-Status: Inappropriate [embedded specific]
  2 files changed, 11 insertions(+), 5 deletions(-)
 
 diff --git a/Makefile b/Makefile
-index aaec04e..9c1dab0 100644
+index be23593..aa13be5 100644
 --- a/Makefile
 +++ b/Makefile
 @@ -123,7 +123,7 @@ pcilmr$(EXEEXT): pcilmr.o $(LMROBJS) $(COMMON) 
lib/$(PCIIMPLIB)
  pcilmr.o: pcilmr.c $(LMRINC)
  
  %$(EXEEXT): %.o
--  $(CC) $(LDFLAGS) $(TARGET_ARCH) $^ $(LDLIBS) -o $@
-+  $(CC) $(LDFLAGS) $(TARGET_ARCH) $^ $(LIB_LDLIBS) $(LDLIBS) -o $@
+-  $(CC) $(CFLAGS) $(LDFLAGS) $(TARGET_ARCH) $^ $(LDLIBS) -o $@
++  $(CC) $(CFLAGS) $(LDFLAGS) $(TARGET_ARCH) $^ $(LIB_LDLIBS) $(LDLIBS) -o 
$@
  
  ifdef PCI_OS_WINDOWS
  comma := ,
 diff --git a/lib/configure b/lib/configure
-index 3df057a..c87e71c 100755
+index d02160b..52c1eee 100755
 --- a/lib/configure
 +++ b/lib/configure
 @@ -9,6 +9,10 @@ echo_n() {
@@ -88,3 +88,6 @@ index 3df057a..c87e71c 100755
  c=config.h
  m=config.mk
  echo >$c '#define PCI_CONFIG_H'
+-- 
+2.42.0
+
diff --git a/meta/recipes-bsp/pciutils/pciutils_3.11.1.bb 
b/meta/recipes-bsp/pciutils/pciutils_3.12.0.bb
similarity index 95%
rename from meta/recipes-bsp/pciutils/pciutils_3.11.1.bb
rename to meta/recipes-bsp/pciutils/pciutils_3.12.0.bb
index 044074ccc3..480a338696 100644
--- a/meta/recipes-bsp/pciutils/pciutils_3.11.1.bb
+++ b/meta/recipes-bsp/pciutils/pciutils_3.12.0.bb
@@ -14,7 +14,7 @@ DEPENDS = "zlib kmod make-native"
 SRC_URI = "${KERNELORG_MIRROR}/software/utils/pciutils/pciutils-${PV}.tar.xz \
file://configure.patch"
 
-SRC_URI[sha256sum] = 
"3f472ad864473de5ba17f765cc96ef5f33e1b730918d3adda6f945a2a9290df4"
+SRC_URI[sha256sum] = 
"f185d116d5ff99b797497efce8f19f1ee8ccc5a668b97a159e3d13472f674154"
 
 inherit multilib_header pkgconfig update-alternatives
 
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199558): 
https://lists.openembedded.org/g/openembedded-core/message/199558
Mute This Topic: https://lists.openembedded.org/mt/106199573/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 5/6] cups: upgrade from 2.4.7 to 2.4.8

2024-05-20 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Signed-off-by: Chen Qi 
---
 meta/recipes-extended/cups/{cups_2.4.7.bb => cups_2.4.8.bb} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-extended/cups/{cups_2.4.7.bb => cups_2.4.8.bb} (51%)

diff --git a/meta/recipes-extended/cups/cups_2.4.7.bb 
b/meta/recipes-extended/cups/cups_2.4.8.bb
similarity index 51%
rename from meta/recipes-extended/cups/cups_2.4.7.bb
rename to meta/recipes-extended/cups/cups_2.4.8.bb
index f4b0282e4c..c0cddf7e99 100644
--- a/meta/recipes-extended/cups/cups_2.4.7.bb
+++ b/meta/recipes-extended/cups/cups_2.4.8.bb
@@ -2,4 +2,4 @@ require cups.inc
 
 LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
 
-SRC_URI[sha256sum] = 
"dd54228dd903526428ce7e37961afaed230ad310788141da75cebaa08362cf6c"
+SRC_URI[sha256sum] = 
"75c326b4ba73975efcc9a25078c4b04cdb4ee333caaad0d0823dbd522c6479a0"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199560): 
https://lists.openembedded.org/g/openembedded-core/message/199560
Mute This Topic: https://lists.openembedded.org/mt/106199576/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 1/6] systemd/systemd-boot: upgrade from 255.4 to 255.6

2024-05-20 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

musl patches are refreshed to avoid 'patch-fuzz' error.

Signed-off-by: Chen Qi 
---
 ..._255.4.bb => systemd-boot-native_255.6.bb} |  0
 ...md-boot_255.4.bb => systemd-boot_255.6.bb} |  0
 meta/recipes-core/systemd/systemd.inc |  2 +-
 ...1-missing_type.h-add-comparison_fn_t.patch |  7 +--
 ...k-parse_printf_format-implementation.patch | 13 ++---
 ...tall-dependency-links-at-install-tim.patch |  9 +--
 ...missing.h-check-for-missing-strndupa.patch | 55 +--
 ...OB_BRACE-and-GLOB_ALTDIRFUNC-is-not-.patch | 14 ++---
 ...005-add-missing-FTW_-macros-for-musl.patch |  7 +--
 ...06-Use-uintmax_t-for-handling-rlim_t.patch | 11 ++--
 ...T_SYMLINK_NOFOLLOW-flag-to-faccessat.patch | 11 ++--
 ...patible-basename-for-non-glibc-syste.patch |  8 +--
 ...implment-systemd-sysv-install-for-OE.patch |  5 +-
 ...uffering-when-writing-to-oom_score_a.patch |  9 +--
 ...compliant-strerror_r-from-GNU-specif.patch | 13 ++---
 ...definition-of-prctl_mm_map-structure.patch |  7 +--
 ...-not-disable-buffer-in-writing-files.patch | 35 ++--
 .../0013-Handle-__cpu_mask-usage.patch|  7 +--
 .../systemd/0014-Handle-missing-gshadow.patch |  7 +--
 ...l.h-Define-MIPS-ABI-defines-for-musl.patch | 11 ++--
 ...ass-correct-parameters-to-getdents64.patch |  7 +--
 .../0017-Adjust-for-musl-headers.patch| 17 +++---
 ...trerror-is-assumed-to-be-GNU-specifi.patch |  9 +--
 ...util-Make-STRERROR-portable-for-musl.patch |  7 +--
 ...ake-malloc_trim-conditional-on-glibc.patch |  9 +--
 ...hared-Do-not-use-malloc_info-on-musl.patch |  7 +--
 ...22-avoid-missing-LOCK_EX-declaration.patch |  9 +--
 .../{systemd_255.4.bb => systemd_255.6.bb}|  0
 28 files changed, 111 insertions(+), 185 deletions(-)
 rename meta/recipes-core/systemd/{systemd-boot-native_255.4.bb => 
systemd-boot-native_255.6.bb} (100%)
 rename meta/recipes-core/systemd/{systemd-boot_255.4.bb => 
systemd-boot_255.6.bb} (100%)
 rename meta/recipes-core/systemd/{systemd_255.4.bb => systemd_255.6.bb} (100%)

diff --git a/meta/recipes-core/systemd/systemd-boot-native_255.4.bb 
b/meta/recipes-core/systemd/systemd-boot-native_255.6.bb
similarity index 100%
rename from meta/recipes-core/systemd/systemd-boot-native_255.4.bb
rename to meta/recipes-core/systemd/systemd-boot-native_255.6.bb
diff --git a/meta/recipes-core/systemd/systemd-boot_255.4.bb 
b/meta/recipes-core/systemd/systemd-boot_255.6.bb
similarity index 100%
rename from meta/recipes-core/systemd/systemd-boot_255.4.bb
rename to meta/recipes-core/systemd/systemd-boot_255.6.bb
diff --git a/meta/recipes-core/systemd/systemd.inc 
b/meta/recipes-core/systemd/systemd.inc
index a35db5091e..8bda47dd38 100644
--- a/meta/recipes-core/systemd/systemd.inc
+++ b/meta/recipes-core/systemd/systemd.inc
@@ -15,7 +15,7 @@ LICENSE:libsystemd = "LGPL-2.1-or-later"
 LIC_FILES_CHKSUM = "file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe \
 
file://LICENSE.LGPL2.1;md5=4fbd65380cdd255951079008b364516c"
 
-SRCREV = "387a14a7b67b8b76adaed4175e14bb7e39b2f738"
+SRCREV = "5810c25792d4268282dd3892af1a253b690423c9"
 SRCBRANCH = "v255-stable"
 SRC_URI = 
"git://github.com/systemd/systemd-stable.git;protocol=https;branch=${SRCBRANCH}"
 
diff --git 
a/meta/recipes-core/systemd/systemd/0001-missing_type.h-add-comparison_fn_t.patch
 
b/meta/recipes-core/systemd/systemd/0001-missing_type.h-add-comparison_fn_t.patch
index 2aa5dee6b5..49871d16a8 100644
--- 
a/meta/recipes-core/systemd/systemd/0001-missing_type.h-add-comparison_fn_t.patch
+++ 
b/meta/recipes-core/systemd/systemd/0001-missing_type.h-add-comparison_fn_t.patch
@@ -1,7 +1,7 @@
-From 01195eb9f7d59139fb45df506ac6b3968c14a57f Mon Sep 17 00:00:00 2001
+From d4b0bb9c7651017985fdd75469f37c34ce2f2c50 Mon Sep 17 00:00:00 2001
 From: Chen Qi 
 Date: Mon, 25 Feb 2019 13:55:12 +0800
-Subject: [PATCH 01/22] missing_type.h: add comparison_fn_t
+Subject: [PATCH] missing_type.h: add comparison_fn_t
 
 Make it work with musl where comparison_fn_t and is not provided.
 
@@ -56,6 +56,3 @@ index ae91534198..7f67eea38b 100644
  
  const char * const catalog_file_dirs[] = {
  "/usr/local/lib/systemd/catalog/",
--- 
-2.34.1
-
diff --git 
a/meta/recipes-core/systemd/systemd/0002-add-fallback-parse_printf_format-implementation.patch
 
b/meta/recipes-core/systemd/systemd/0002-add-fallback-parse_printf_format-implementation.patch
index 900a931632..593d6261e1 100644
--- 
a/meta/recipes-core/systemd/systemd/0002-add-fallback-parse_printf_format-implementation.patch
+++ 
b/meta/recipes-core/systemd/systemd/0002-add-fallback-parse_printf_format-implementation.patch
@@ -1,7 +1,7 @@
-From 872b72739e62123867ce6c4f82aa37de24cc3f75 Mon Sep 17 00:00:00 2001
+From 776913624aaf696a3b2920b8d7506b3aae042bf1 Mon Sep 17 00:00:00 2001
 From: Alexander Kanavin 
 Date: Sat, 22 May 2021 20:26:24 +0200
-Subject: [PATCH 02/22] add fallback parse_printf_format i

[OE-core][PATCH 6/6] kmod: upgrade from 31 to 32

2024-05-20 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

kmod now installs symlinks in 'make install'.
https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/commit/?
id=e98cef6f3f8cd6f8bfb26d147b2c209297453cca

With this change, we no longer need to deal with the symlinks in
do_install. Besides, as upstream chooses 'bin' instead of 'sbin'
to hold the tools, we'd better sync with it. That's the reason for
the sbindir -> bindir changes.

Signed-off-by: Chen Qi 
---
 .../kmod/{kmod_31.bb => kmod_32.bb}   | 24 +++
 1 file changed, 8 insertions(+), 16 deletions(-)
 rename meta/recipes-kernel/kmod/{kmod_31.bb => kmod_32.bb} (78%)

diff --git a/meta/recipes-kernel/kmod/kmod_31.bb 
b/meta/recipes-kernel/kmod/kmod_32.bb
similarity index 78%
rename from meta/recipes-kernel/kmod/kmod_31.bb
rename to meta/recipes-kernel/kmod/kmod_32.bb
index 718a5565b4..1235bc1bf8 100644
--- a/meta/recipes-kernel/kmod/kmod_31.bb
+++ b/meta/recipes-kernel/kmod/kmod_32.bb
@@ -15,7 +15,7 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
"
 inherit autotools bash-completion gtk-doc pkgconfig manpages 
update-alternatives
 
-SRCREV = "aff617ea871d0568cc491bd116c0be1e857463bb"
+SRCREV = "41faa59711742c1476d59985011ee0f27ed91d30"
 
 SRC_URI = 
"git://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git;branch=master;protocol=https
 \
file://depmod-search.conf \
@@ -50,12 +50,6 @@ EXTRA_OECONF += "--bindir=${base_bindir} 
--sbindir=${base_sbindir}"
 
 do_install:append () {
 install -dm755 ${D}${base_bindir}
-install -dm755 ${D}${base_sbindir}
-# add symlinks to kmod
-ln -rs ${D}${base_bindir}/kmod ${D}${base_bindir}/lsmod
-for tool in insmod rmmod depmod modinfo modprobe; do
-ln -rs ${D}${base_bindir}/kmod ${D}${base_sbindir}/${tool}
-done
 # configuration directories
 install -dm755 ${D}${nonarch_base_libdir}/depmod.d
 install -dm755 ${D}${nonarch_base_libdir}/modprobe.d
@@ -71,16 +65,14 @@ do_install:append () {
 
 ALTERNATIVE_PRIORITY = "70"
 
-ALTERNATIVE:kmod = "insmod modprobe rmmod modinfo bin-lsmod lsmod depmod"
+ALTERNATIVE:kmod = "insmod modprobe rmmod modinfo lsmod depmod"
 
-ALTERNATIVE_LINK_NAME[depmod] = "${base_sbindir}/depmod"
-ALTERNATIVE_LINK_NAME[insmod] = "${base_sbindir}/insmod"
-ALTERNATIVE_LINK_NAME[modprobe] = "${base_sbindir}/modprobe"
-ALTERNATIVE_LINK_NAME[rmmod] = "${base_sbindir}/rmmod"
-ALTERNATIVE_LINK_NAME[modinfo] = "${base_sbindir}/modinfo"
-ALTERNATIVE_LINK_NAME[bin-lsmod] = "${base_bindir}/lsmod"
-ALTERNATIVE_LINK_NAME[lsmod] = "${base_sbindir}/lsmod"
-ALTERNATIVE_TARGET[lsmod] = "${base_bindir}/lsmod.${BPN}"
+ALTERNATIVE_LINK_NAME[depmod] = "${base_bindir}/depmod"
+ALTERNATIVE_LINK_NAME[insmod] = "${base_bindir}/insmod"
+ALTERNATIVE_LINK_NAME[modprobe] = "${base_bindir}/modprobe"
+ALTERNATIVE_LINK_NAME[rmmod] = "${base_bindir}/rmmod"
+ALTERNATIVE_LINK_NAME[modinfo] = "${base_bindir}/modinfo"
+ALTERNATIVE_LINK_NAME[lsmod] = "${base_bindir}/lsmod"
 
 PACKAGES =+ "libkmod"
 FILES:libkmod = "${base_libdir}/libkmod*${SOLIBS} ${libdir}/libkmod*${SOLIBS}"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199561): 
https://lists.openembedded.org/g/openembedded-core/message/199561
Mute This Topic: https://lists.openembedded.org/mt/106199577/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 4/6] shadow: upgrade from 4.15.0 to 4.15.1

2024-05-20 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

0001-lib-copydir-copy_entry-use-temporary-stat-buffer.patch is dropped
as it has been merged and is in this new release.

Signed-off-by: Chen Qi 
---
 ...copy_entry-use-temporary-stat-buffer.patch | 37 ---
 meta/recipes-extended/shadow/shadow.inc   |  3 +-
 .../{shadow_4.15.0.bb => shadow_4.15.1.bb}|  0
 3 files changed, 1 insertion(+), 39 deletions(-)
 delete mode 100644 
meta/recipes-extended/shadow/files/0001-lib-copydir-copy_entry-use-temporary-stat-buffer.patch
 rename meta/recipes-extended/shadow/{shadow_4.15.0.bb => shadow_4.15.1.bb} 
(100%)

diff --git 
a/meta/recipes-extended/shadow/files/0001-lib-copydir-copy_entry-use-temporary-stat-buffer.patch
 
b/meta/recipes-extended/shadow/files/0001-lib-copydir-copy_entry-use-temporary-stat-buffer.patch
deleted file mode 100644
index 2e5503bfd4..00
--- 
a/meta/recipes-extended/shadow/files/0001-lib-copydir-copy_entry-use-temporary-stat-buffer.patch
+++ /dev/null
@@ -1,37 +0,0 @@
-From af4b8cb780587aa736692a3baa76b60474f19c5d Mon Sep 17 00:00:00 2001
-From: Enrico Scholz 
-Date: Mon, 18 Mar 2024 12:14:21 +0100
-Subject: [PATCH] lib/copydir:copy_entry(): use temporary stat buffer
-
-There are no guarantees that fstatat() does not clobber the stat
-buffer on errors.
-
-Use a temporary buffer so that the following code sees correct
-attributes of the source entry.
-
-Upstream-Status: Submitted [https://github.com/shadow-maint/shadow/pull/974]
-
-Signed-off-by: Enrico Scholz 

- lib/copydir.c | 3 ++-
- 1 file changed, 2 insertions(+), 1 deletion(-)
-
 a/lib/copydir.c
-+++ b/lib/copydir.c
-@@ -400,6 +400,7 @@ static int copy_entry (const struct path
- {
-   int err = 0;
-   struct stat sb;
-+  struct stat tmp_sb;
-   struct link_name *lp;
-   struct timespec mt[2];
- 
-@@ -423,7 +424,7 @@ static int copy_entry (const struct path
-   * If the destination already exists do nothing.
-   * This is after the copy_dir above to still iterate into subdirectories.
-   */
--  if (fstatat(dst->dirfd, dst->name, &sb, AT_SYMLINK_NOFOLLOW) != -1) {
-+  if (fstatat(dst->dirfd, dst->name, &tmp_sb, AT_SYMLINK_NOFOLLOW) != -1) 
{
-   return err;
-   }
- 
diff --git a/meta/recipes-extended/shadow/shadow.inc 
b/meta/recipes-extended/shadow/shadow.inc
index 25930b64c1..3991006b43 100644
--- a/meta/recipes-extended/shadow/shadow.inc
+++ b/meta/recipes-extended/shadow/shadow.inc
@@ -12,7 +12,6 @@ DEPENDS = "virtual/crypt"
 
 GITHUB_BASE_URI = "https://github.com/shadow-maint/shadow/releases";
 SRC_URI = "${GITHUB_BASE_URI}/download/${PV}/${BP}.tar.gz \
-   file://0001-lib-copydir-copy_entry-use-temporary-stat-buffer.patch \
${@bb.utils.contains('PACKAGECONFIG', 'pam', '${PAM_SRC_URI}', '', 
d)} \
file://useradd \
"
@@ -25,7 +24,7 @@ SRC_URI:append:class-target = " \
 SRC_URI:append:class-native = " \
file://commonio.c-fix-unexpected-open-failure-in-chroot-env.patch \
"
-SRC_URI[sha256sum] = 
"377fe0d7c1a0aa5e3514c08fdf5ddc70c9dcbb391678c2134445ed97326bcc26"
+SRC_URI[sha256sum] = 
"b34686b89b279887ffbf1f33128902ccc0fa1a998a3add44213bb12d7385b218"
 
 # Additional Policy files for PAM
 PAM_SRC_URI = "file://pam.d/chfn \
diff --git a/meta/recipes-extended/shadow/shadow_4.15.0.bb 
b/meta/recipes-extended/shadow/shadow_4.15.1.bb
similarity index 100%
rename from meta/recipes-extended/shadow/shadow_4.15.0.bb
rename to meta/recipes-extended/shadow/shadow_4.15.1.bb
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199559): 
https://lists.openembedded.org/g/openembedded-core/message/199559
Mute This Topic: https://lists.openembedded.org/mt/106199574/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 2/6] util-linux/util-linux-libuuid: upgrade from 2.39.3 to 2.40.1

2024-05-20 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

License-Update:
===
GPL-2.0 is changed to GPL-2.0-only in README.licensing.

The following two patches are removed as they've been there in new release:

  0001-login-utils-include-libgen.h-for-basename-API.patch
  mit-license.patch

Other existing patches are refreshed to avoid patch-fuzz error.

A new PACKAGECONFIG, lastlog2, is added, which serves as a switch to build Y2038
safe lastlog pam module. This is a new functionality added in 2.40.

Signed-off-by: Chen Qi 
---
 ...2.39.3.bb => util-linux-libuuid_2.40.1.bb} |  0
 meta/recipes-core/util-linux/util-linux.inc   |  8 +--
 ...ls-include-libgen.h-for-basename-API.patch | 60 ---
 .../util-linux/avoid_parallel_tests.patch |  5 +-
 .../util-linux/configure-sbindir.patch|  7 +--
 .../display_testname_for_subtest.patch|  7 +--
 .../util-linux/util-linux/mit-license.patch   | 45 --
 .../util-linux/util-linux/ptest.patch | 11 ++--
 ...l-linux_2.39.3.bb => util-linux_2.40.1.bb} |  3 +-
 9 files changed, 18 insertions(+), 128 deletions(-)
 rename meta/recipes-core/util-linux/{util-linux-libuuid_2.39.3.bb => 
util-linux-libuuid_2.40.1.bb} (100%)
 delete mode 100644 
meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
 delete mode 100644 meta/recipes-core/util-linux/util-linux/mit-license.patch
 rename meta/recipes-core/util-linux/{util-linux_2.39.3.bb => 
util-linux_2.40.1.bb} (99%)

diff --git a/meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb 
b/meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
similarity index 100%
rename from meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb
rename to meta/recipes-core/util-linux/util-linux-libuuid_2.40.1.bb
diff --git a/meta/recipes-core/util-linux/util-linux.inc 
b/meta/recipes-core/util-linux/util-linux.inc
index d506783f9a..0f5f838e84 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -6,7 +6,7 @@ disk partitioning, kernel message management, filesystem 
creation, and system lo
 
 SECTION = "base"
 
-LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & 
BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
+LICENSE = "GPL-1.0-or-later & GPL-2.0-only & GPL-2.0-or-later & 
LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
 LICENSE:${PN}-fcntl-lock = "MIT"
 LICENSE:${PN}-fdisk = "GPL-1.0-or-later"
 LICENSE:${PN}-libblkid = "LGPL-2.1-or-later"
@@ -14,7 +14,7 @@ LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
 LICENSE:${PN}-libmount = "LGPL-2.1-or-later"
 LICENSE:${PN}-libsmartcols = "LGPL-2.1-or-later"
 
-LIC_FILES_CHKSUM = 
"file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba \
+LIC_FILES_CHKSUM = 
"file://README.licensing;md5=ddd58b6c94da86ff4f03e91208eb9cfc \
 file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
 
file://Documentation/licenses/COPYING.GPL-2.0-or-later;md5=b234ee4d69f5fce4486a80fdaf4a4263
 \
 
file://Documentation/licenses/COPYING.LGPL-2.1-or-later;md5=4fbd65380cdd255951079008b364516c
 \
@@ -30,7 +30,6 @@ LIC_FILES_CHKSUM = 
"file://README.licensing;md5=cc80239f106687ab39ef0271ff5cf4ba
 FILESEXTRAPATHS:prepend := "${THISDIR}/util-linux:"
 MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
 SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-linux-${PV}.tar.xz
 \
-   file://mit-license.patch \
file://configure-sbindir.patch \
file://runuser.pamd \
file://runuser-l.pamd \
@@ -38,8 +37,7 @@ SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-lin
file://run-ptest \
file://display_testname_for_subtest.patch \
file://avoid_parallel_tests.patch \
-   file://0001-login-utils-include-libgen.h-for-basename-API.patch \
file://fcntl-lock.c \
"
 
-SRC_URI[sha256sum] = 
"7b6605e48d1a49f43cc4b4cfc59f313d0dd5402fa40b96810bd572e167dfed0f"
+SRC_URI[sha256sum] = 
"59e676aa53ccb44b6c39f0ffe01a8fa274891c91bef1474752fad92461def24f"
diff --git 
a/meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
 
b/meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
deleted file mode 100644
index 6258710e1e..00
--- 
a/meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
+++ /dev/null
@@ -1,60 +0,0 @@
-From d44e3ad1f6f8b5c1b3098bb7d537943a4c21d22f Mon Sep 17 00:00:00 2001
-From: Khem Raj 
-Date: Sun, 3 Dec 2023 19:59:46 -0800
-Subject: [PATCH] login-utils: include 

[OE-core][PATCH] ovmf: set CVE_STATUS for a few CVEs

2024-04-08 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

For all those CVE-2019-x CVEs, following the links in NVD, we
can see they have all been fixed.

For CVE-2014-4859 and CVE-2014-4860, there's no useful links in NVD,
but according to the following two links, they have also been fixed.

  https://security-tracker.debian.org/tracker/CVE-2014-4859
  https://security-tracker.debian.org/tracker/CVE-2014-4860

Signed-off-by: Chen Qi 
---
 meta/recipes-core/ovmf/ovmf_git.bb | 9 +
 1 file changed, 9 insertions(+)

diff --git a/meta/recipes-core/ovmf/ovmf_git.bb 
b/meta/recipes-core/ovmf/ovmf_git.bb
index 97651faf62..35ca8d1834 100644
--- a/meta/recipes-core/ovmf/ovmf_git.bb
+++ b/meta/recipes-core/ovmf/ovmf_git.bb
@@ -34,6 +34,15 @@ CVE_PRODUCT = "edk2"
 CVE_VERSION = "${@d.getVar('PV').split('stable')[1]}"
 
 CVE_STATUS[CVE-2014-8271] = "fixed-version: Fixed in svn_16280, which is an 
unusual versioning breaking version comparison."
+CVE_STATUS[CVE-2014-4859] = "fixed-version: The CPE in the NVD database 
doesn't reflect correctly the vulnerable versions."
+CVE_STATUS[CVE-2014-4860] = "fixed-version: The CPE in the NVD database 
doesn't reflect correctly the vulnerable versions."
+CVE_STATUS[CVE-2019-14553] = "fixed-version: The CPE in the NVD database 
doesn't reflect correctly the vulnerable versions."
+CVE_STATUS[CVE-2019-14559] = "fixed-version: The CPE in the NVD database 
doesn't reflect correctly the vulnerable versions."
+CVE_STATUS[CVE-2019-14562] = "fixed-version: The CPE in the NVD database 
doesn't reflect correctly the vulnerable versions."
+CVE_STATUS[CVE-2019-14563] = "fixed-version: The CPE in the NVD database 
doesn't reflect correctly the vulnerable versions."
+CVE_STATUS[CVE-2019-14575] = "fixed-version: The CPE in the NVD database 
doesn't reflect correctly the vulnerable versions."
+CVE_STATUS[CVE-2019-14586] = "fixed-version: The CPE in the NVD database 
doesn't reflect correctly the vulnerable versions."
+CVE_STATUS[CVE-2019-14587] = "fixed-version: The CPE in the NVD database 
doesn't reflect correctly the vulnerable versions."
 
 inherit deploy
 
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#198015): 
https://lists.openembedded.org/g/openembedded-core/message/198015
Mute This Topic: https://lists.openembedded.org/mt/105402982/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] OE-core CVE metrics for master on Sun 07 Apr 2024 01:00:01 AM HST

2024-04-08 Thread Chen Qi via lists.openembedded.org
Yes, of course.
I've briefly checked all these CVE-2019-xxx links, they have all been fixed.
I'll send out a patch.

Regards,
Qi

-Original Message-
From: Richard Purdie  
Sent: Monday, April 8, 2024 7:57 PM
To: Steve Sakoman ; 
openembedded-core@lists.openembedded.org; yocto-secur...@lists.yoctoproject.org
Cc: Chen, Qi 
Subject: Re: [OE-core] OE-core CVE metrics for master on Sun 07 Apr 2024 
01:00:01 AM HST

On Sun, 2024-04-07 at 01:19 -1000, Steve Sakoman wrote:
> Branch: master
> 
> New this week: 21 CVEs
> CVE-2014-4859 (CVSS3: 6.8 MEDIUM): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2014-4859 *
> CVE-2014-4860 (CVSS3: 6.8 MEDIUM): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2014-4860 *

Qi sent a patch for this, thanks.

> CVE-2019-14553 (CVSS3: 4.9 MEDIUM): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2019-14553 *
> CVE-2019-14559 (CVSS3: 7.5 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2019-14559 *
> CVE-2019-14562 (CVSS3: 5.5 MEDIUM): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2019-14562 *
> CVE-2019-14563 (CVSS3: 7.8 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2019-14563 *
> CVE-2019-14575 (CVSS3: 7.8 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2019-14575 *
> CVE-2019-14586 (CVSS3: 8.0 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2019-14586 *
> CVE-2019-14587 (CVSS3: 6.5 MEDIUM): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2019-14587 *

I think we will need a patch for these for now as the CPE entries are missing 
in NVD. Would you be able to help there please Qi?

> CVE-2022-36763 (CVSS3: 7.8 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2022-36763 *
> CVE-2022-36764 (CVSS3: 7.8 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2022-36764 *
> CVE-2022-36765 (CVSS3: 7.8 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2022-36765 *
> CVE-2023-45229 (CVSS3: 6.5 MEDIUM): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-45229 *
> CVE-2023-45230 (CVSS3: 8.8 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-45230 *
> CVE-2023-45231 (CVSS3: 6.5 MEDIUM): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-45231 *
> CVE-2023-45232 (CVSS3: 7.5 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-45232 *
> CVE-2023-45233 (CVSS3: 7.5 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-45233 *
> CVE-2023-45234 (CVSS3: 8.8 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-45234 *
> CVE-2023-45235 (CVSS3: 8.8 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-45235 *
> CVE-2023-45236 (CVSS3: 7.5 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-45236 *
> CVE-2023-45237 (CVSS3: 7.5 HIGH): ovmf:ovmf-native 
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-45237 *

These are genuine issues and I've merged an upgrade to address them.

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#198014): 
https://lists.openembedded.org/g/openembedded-core/message/198014
Mute This Topic: https://lists.openembedded.org/mt/105380934/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH V2 1/2] ovmf: set CVE_PRODUCT and CVE_VERSION

2024-04-05 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Set CVE_PRODUCT and CVE_VERSION for ovmf. NVD uses 'edk2' and the
version should be the date only. Here's an example:
https://nvd.nist.gov/vuln/detail/CVE-2023-45232

Signed-off-by: Chen Qi 
---
 meta/recipes-core/ovmf/ovmf_git.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-core/ovmf/ovmf_git.bb 
b/meta/recipes-core/ovmf/ovmf_git.bb
index 3dc031d3b6..5b1353b8e8 100644
--- a/meta/recipes-core/ovmf/ovmf_git.bb
+++ b/meta/recipes-core/ovmf/ovmf_git.bb
@@ -30,6 +30,9 @@ PV = "edk2-stable202308"
 SRCREV = "819cfc6b42a68790a23509e4fcc58ceb70e1965e"
 UPSTREAM_CHECK_GITTAGREGEX = "(?Pedk2-stable.*)"
 
+CVE_PRODUCT = "edk2"
+CVE_VERSION = "${@d.getVar('PV').split('stable')[1]}"
+
 inherit deploy
 
 PARALLEL_MAKE = ""
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#197989): 
https://lists.openembedded.org/g/openembedded-core/message/197989
Mute This Topic: https://lists.openembedded.org/mt/105362148/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH V2 2/2] ovmf: set CVE_STATUS for CVE-2014-8271

2024-04-05 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

CVE-2014-8271 has an unusual versioning, svn_16280, which breaks
the version comparison and gives us warning like below:

  Failed to compare 202308 < svn_16280 for CVE-2014-8271

The fix has been there since 2014, our current version has included
the fix.

Signed-off-by: Chen Qi 
---
 meta/recipes-core/ovmf/ovmf_git.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-core/ovmf/ovmf_git.bb 
b/meta/recipes-core/ovmf/ovmf_git.bb
index 5b1353b8e8..f98cec8035 100644
--- a/meta/recipes-core/ovmf/ovmf_git.bb
+++ b/meta/recipes-core/ovmf/ovmf_git.bb
@@ -33,6 +33,8 @@ UPSTREAM_CHECK_GITTAGREGEX = "(?Pedk2-stable.*)"
 CVE_PRODUCT = "edk2"
 CVE_VERSION = "${@d.getVar('PV').split('stable')[1]}"
 
+CVE_STATUS[CVE-2014-8271] = "fixed-version: Fixed in svn_16280, which is an 
unusual versioning breaking version comparison."
+
 inherit deploy
 
 PARALLEL_MAKE = ""
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#197988): 
https://lists.openembedded.org/g/openembedded-core/message/197988
Mute This Topic: https://lists.openembedded.org/mt/105362147/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH V2] ovmf: set CVE_PRODUCT and CVE_VERSION

2024-03-26 Thread Chen Qi via lists.openembedded.org

ping

On 3/6/24 14:54, Chen Qi via lists.openembedded.org wrote:

From: Chen Qi 

Set CVE_PRODUCT and CVE_VERSION for ovmf. NVD uses 'edk2' and the
version should be the date only. Here's an example:
https://nvd.nist.gov/vuln/detail/CVE-2023-45232

Signed-off-by: Chen Qi 
---
  meta/recipes-core/ovmf/ovmf_git.bb | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/meta/recipes-core/ovmf/ovmf_git.bb 
b/meta/recipes-core/ovmf/ovmf_git.bb
index 3dc031d3b6..5b1353b8e8 100644
--- a/meta/recipes-core/ovmf/ovmf_git.bb
+++ b/meta/recipes-core/ovmf/ovmf_git.bb
@@ -30,6 +30,9 @@ PV = "edk2-stable202308"
  SRCREV = "819cfc6b42a68790a23509e4fcc58ceb70e1965e"
  UPSTREAM_CHECK_GITTAGREGEX = "(?Pedk2-stable.*)"
  
+CVE_PRODUCT = "edk2"

+CVE_VERSION = "${@d.getVar('PV').split('stable')[1]}"
+
  inherit deploy
  
  PARALLEL_MAKE = ""







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#197547): 
https://lists.openembedded.org/g/openembedded-core/message/197547
Mute This Topic: https://lists.openembedded.org/mt/104761710/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] Yocto rpm packages do not keep the modified CONFFILES

2024-03-11 Thread Chen Qi via lists.openembedded.org
Packages + overrides are a very common way to configure/customize images.

Take OE itself as an example, the sshd_config is a conffile for openssh, but in 
rootfs-postcommands.bbclass, it is customized.
This means sshd_config might be different from the one that is recorded in rpm 
database. This is a similar situation with the original question.
The original question is basically equal to: are we going to keep the 
sshd_config we customized when we upgrade the openssh on target?

Ideally, packages should be designed to allow config snippets 
(/etc/xxx.conf.d/) or some override mechanism (default conf in /usr/lib and 
override in /etc). But there'll always be packages that lack such mechanisms. 
Using 'noreplace' seems a reasonable choice.

For the default behavior of OE, I'd suggest we change to use 'noreplace'. 
Because the more unlikely people modify their target files (as Alex pointed out 
for embedded devices), the more important those modifications might be.

Regards,
Qi

-Original Message-
From: openembedded-core@lists.openembedded.org 
 On Behalf Of Alexander Kanavin
Sent: Monday, March 11, 2024 6:20 PM
To: Böszörményi Zoltán 
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] Yocto rpm packages do not keep the modified CONFFILES

On Mon, 11 Mar 2024 at 11:09, Böszörményi Zoltán  wrote:
> Yes, I am aware. But why not use the package manager's own features 
> instead of adding a workaround?

Because I see it the opposite way: noreplace in this case is a workaround for a 
file name conflict between what the tool generates and what the package 
installs. If you're going to generate a file on target, then you shouldn't be 
installing it from a package.

Alex

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196968): 
https://lists.openembedded.org/g/openembedded-core/message/196968
Mute This Topic: https://lists.openembedded.org/mt/104859795/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH V2] dnf: remove log_lock.pid before exit

2024-03-07 Thread Chen Qi via lists.openembedded.org
Hi Alex,

You can see dnf's solution is: 
https://github.com/rpm-software-management/dnf/blob/master/etc/tmpfiles.d/dnf.conf

I don't think dnf community will look into this issue. And I would expect it to 
be a complicated one. Because dnf's own solution looks like more of a 
workaround. At the same time, yocto based systems will sometimes have 
log_lock.pid left in target filesystems. Users typing 'ls /' will notice it.

We have an OE specific patch: 
https://git.openembedded.org/openembedded-core/commit/?id=742a1b71249f4da1c8d8e13e270b0eb6128a3f66
I can see that this OE specific patch, 
0001-dnf-write-the-log-lock-to-root.patch, does solve some issue. 
Unfortunately, at the same time, it introduces this specific issue, a 
easy-to-notice one. 

My suggestion is that we merge this fix into 
0001-dnf-write-the-log-lock-to-root.patch, because they really belong together. 
I guess we can't expect dnf community to devote time into this, as they've 
already got a solution. And I'm not sure if anyone in OE community is familiar 
with dnf enough to solve this issue. So let's make things a little better, 
avoiding users of Yocto systems see this log_lock.pid file when they type 'ls 
/'.

If you have any other suggestion, please let us know.

Regards,
Qi


-Original Message-
From: openembedded-core@lists.openembedded.org 
 On Behalf Of Alexander Kanavin via 
lists.openembedded.org
Sent: Thursday, March 7, 2024 5:57 PM
To: Li, Changqing ; Richard Purdie 

Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH V2] dnf: remove log_lock.pid before exit

On Thu, 7 Mar 2024 at 10:19, Changqing Li  
wrote:
> ++for arg in args:
> ++if arg.startswith("--installroot="):
> ++root=arg.split("=")[1]
> ++if os.path.exists(os.path.join(root, "log_lock.pid")):
> ++os.unlink(os.path.join(root, "log_lock.pid"))
> ++break

Apologies, but after looking at this more carefully I have to say no once more. 
The obstacle is that the code checks for existence before removing the lock, 
which means the issue of why the lock is left in place to begin with is still 
unresolved. This doesn't always happen, and we need to get to the bottom of 
*why*.

Alex

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196784): 
https://lists.openembedded.org/g/openembedded-core/message/196784
Mute This Topic: https://lists.openembedded.org/mt/104784184/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: Patchtest results for [OE-core][PATCH 2/2] systemd: remove systemd-bus-proxy settings

2024-03-06 Thread Chen Qi via lists.openembedded.org
Is this a patchtest bug? I can see the 'Signed-off-by:' is there.

Regards,
Qi

-Original Message-
From: patcht...@automation.yoctoproject.org 
 
Sent: Thursday, March 7, 2024 10:36 AM
To: Chen, Qi 
Cc: openembedded-core@lists.openembedded.org
Subject: Patchtest results for [OE-core][PATCH 2/2] systemd: remove 
systemd-bus-proxy settings

Thank you for your submission. Patchtest identified one or more issues with the 
patch. Please see the log below for more information:

---
Testing patch 
/home/patchtest/share/mboxes/2-2-systemd-remove-systemd-bus-proxy-settings.patch

FAIL: test Signed-off-by presence: Mbox is missing Signed-off-by. Add it 
manually or with "git commit --amend -s" 
(test_mbox.TestMbox.test_signed_off_by_presence)

PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence 
(test_mbox.TestMbox.test_commit_message_presence)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)

SKIP: pretest pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: No modified recipes, skipping pretest 
(test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes or older target branch, 
skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced 
(test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced 
(test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced 
(test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found 
(test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, 
skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest 
(test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other mailing 
lists (test_mbox.TestMbox.test_target_mailing_list)

---

Please address the issues identified and submit a new revision of the patch, or 
alternatively, reply to this email with an explanation of why the patch should 
be accepted. If you believe these results are due to an error in patchtest, 
please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' 
category under 'Yocto Project Subprojects'). For more information on specific 
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196764): 
https://lists.openembedded.org/g/openembedded-core/message/196764
Mute This Topic: https://lists.openembedded.org/mt/104780624/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 1/2] systemd: use RDEPENDS for systemd-vconsole-setup

2024-03-06 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

With NO_RECOMMENDATIONS set to "1", systemd-vonsole-setup.service
will fail because it invokes /usr/bin/loadkeys, which is from kbd.

The RRECOMMENDATION should be changed to RDEPENDS, because it's not
a recommenation, instead it's necessary.

Signed-off-by: Chen Qi 
---
 meta/recipes-core/systemd/systemd_255.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/systemd/systemd_255.1.bb 
b/meta/recipes-core/systemd/systemd_255.1.bb
index a907d60e84..d6fa99a5f8 100644
--- a/meta/recipes-core/systemd/systemd_255.1.bb
+++ b/meta/recipes-core/systemd/systemd_255.1.bb
@@ -490,7 +490,7 @@ FILES:${PN}-binfmt = "${sysconfdir}/binfmt.d/ \
   ${systemd_system_unitdir}/systemd-binfmt.service"
 RRECOMMENDS:${PN}-binfmt = "${@bb.utils.contains('PACKAGECONFIG', 'binfmt', 
'kernel-module-binfmt-misc', '', d)}"
 
-RRECOMMENDS:${PN}-vconsole-setup = "${@bb.utils.contains('PACKAGECONFIG', 
'vconsole', 'kbd kbd-consolefonts kbd-keymaps', '', d)}"
+RDEPENDS:${PN}-vconsole-setup = "${@bb.utils.contains('PACKAGECONFIG', 
'vconsole', 'kbd kbd-consolefonts kbd-keymaps', '', d)}"
 
 
 FILES:${PN}-journal-gatewayd = 
"${rootlibexecdir}/systemd/systemd-journal-gatewayd \
-- 
2.42.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196761): 
https://lists.openembedded.org/g/openembedded-core/message/196761
Mute This Topic: https://lists.openembedded.org/mt/104780513/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 2/2] systemd: remove systemd-bus-proxy settings

2024-03-06 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

systemd-bus-proxy was removed since v230.
>From the NEWS file:
"""
  * systemd-bus-proxyd has been removed, as kdbus is unlikely to still be
merged into the kernel in its current form.
"""

Signed-off-by: Chen Qi 
---
 meta/recipes-core/systemd/systemd_255.1.bb | 6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/meta/recipes-core/systemd/systemd_255.1.bb 
b/meta/recipes-core/systemd/systemd_255.1.bb
index d6fa99a5f8..0f09c56fe2 100644
--- a/meta/recipes-core/systemd/systemd_255.1.bb
+++ b/meta/recipes-core/systemd/systemd_255.1.bb
@@ -437,7 +437,7 @@ SYSTEMD_PACKAGES = "${@bb.utils.contains('PACKAGECONFIG', 
'binfmt', '${PN}-binfm
 "
 SYSTEMD_SERVICE:${PN}-binfmt = "systemd-binfmt.service"
 
-USERADD_PACKAGES = "${PN} ${PN}-extra-utils \
+USERADD_PACKAGES = "${PN} \
 udev \
 ${@bb.utils.contains('PACKAGECONFIG', 'microhttpd', 
'${PN}-journal-gatewayd', '', d)} \
 ${@bb.utils.contains('PACKAGECONFIG', 'microhttpd', 
'${PN}-journal-remote', '', d)} \
@@ -452,7 +452,6 @@ USERADD_PARAM:${PN} += 
"${@bb.utils.contains('PACKAGECONFIG', 'polkit', '--syste
 USERADD_PARAM:${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'resolved', 
'--system -d / -M --shell /sbin/nologin systemd-resolve;', '', d)}"
 USERADD_PARAM:${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'timesyncd', 
'--system -d / -M --shell /sbin/nologin systemd-timesync;', '', d)}"
 USERADD_PARAM:${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'oomd', 
'--system -d / -M --shell /sbin/nologin systemd-oom;', '', d)}"
-USERADD_PARAM:${PN}-extra-utils = "--system -d / -M --shell /sbin/nologin 
systemd-bus-proxy"
 USERADD_PARAM:${PN}-journal-gatewayd = "--system -d / -M --shell /sbin/nologin 
systemd-journal-gateway"
 USERADD_PARAM:${PN}-journal-remote = "--system -d / -M --shell /sbin/nologin 
systemd-journal-remote"
 USERADD_PARAM:${PN}-journal-upload = "--system -d / -M --shell /sbin/nologin 
systemd-journal-upload"
@@ -591,9 +590,6 @@ FILES:${PN}-extra-utils = "\
 ${rootlibexecdir}/systemd/systemd-resolve-host \
 ${rootlibexecdir}/systemd/systemd-ac-power \
 ${rootlibexecdir}/systemd/systemd-activate \
-${rootlibexecdir}/systemd/systemd-bus-proxyd \
-${systemd_system_unitdir}/systemd-bus-proxyd.service \
-${systemd_system_unitdir}/systemd-bus-proxyd.socket \
 ${rootlibexecdir}/systemd/systemd-measure \
 ${rootlibexecdir}/systemd/systemd-pcrphase \
 ${rootlibexecdir}/systemd/systemd-socket-proxyd \
-- 
2.42.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196762): 
https://lists.openembedded.org/g/openembedded-core/message/196762
Mute This Topic: https://lists.openembedded.org/mt/104780514/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH V2] ovmf: set CVE_PRODUCT and CVE_VERSION

2024-03-05 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Set CVE_PRODUCT and CVE_VERSION for ovmf. NVD uses 'edk2' and the
version should be the date only. Here's an example:
https://nvd.nist.gov/vuln/detail/CVE-2023-45232

Signed-off-by: Chen Qi 
---
 meta/recipes-core/ovmf/ovmf_git.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-core/ovmf/ovmf_git.bb 
b/meta/recipes-core/ovmf/ovmf_git.bb
index 3dc031d3b6..5b1353b8e8 100644
--- a/meta/recipes-core/ovmf/ovmf_git.bb
+++ b/meta/recipes-core/ovmf/ovmf_git.bb
@@ -30,6 +30,9 @@ PV = "edk2-stable202308"
 SRCREV = "819cfc6b42a68790a23509e4fcc58ceb70e1965e"
 UPSTREAM_CHECK_GITTAGREGEX = "(?Pedk2-stable.*)"
 
+CVE_PRODUCT = "edk2"
+CVE_VERSION = "${@d.getVar('PV').split('stable')[1]}"
+
 inherit deploy
 
 PARALLEL_MAKE = ""
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196659): 
https://lists.openembedded.org/g/openembedded-core/message/196659
Mute This Topic: https://lists.openembedded.org/mt/104761710/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH] ovmf: set CVE_PRODUCT and CVE_VERSION

2024-03-05 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Set CVE_PRODUCT and CVE_VERSION for ovmf. NVD uses 'edk2' and the
version should be the date only. Here's an example:
https://nvd.nist.gov/vuln/detail/CVE-2023-45232

Signed-off-by: Chen Qi 
---
 meta/recipes-core/ovmf/ovmf_git.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-core/ovmf/ovmf_git.bb 
b/meta/recipes-core/ovmf/ovmf_git.bb
index 3dc031d3b6..6931536229 100644
--- a/meta/recipes-core/ovmf/ovmf_git.bb
+++ b/meta/recipes-core/ovmf/ovmf_git.bb
@@ -30,6 +30,9 @@ PV = "edk2-stable202308"
 SRCREV = "819cfc6b42a68790a23509e4fcc58ceb70e1965e"
 UPSTREAM_CHECK_GITTAGREGEX = "(?Pedk2-stable.*)"
 
+CVE_PRODUCT = "edk2"
+CVE_VERSION = "202308"
+
 inherit deploy
 
 PARALLEL_MAKE = ""
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196657): 
https://lists.openembedded.org/g/openembedded-core/message/196657
Mute This Topic: https://lists.openembedded.org/mt/104760677/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC OE-core][PATCH 3/3] goarch: disable dynamic linking globally

2024-02-27 Thread Chen Qi via lists.openembedded.org

Is this 1.21 upgrade going to be merged in LTS 5.0?
The reason I'm asking is that I'm going to upgrade some recipes in 
meta-virt and I'd like to check what would be the go version in the next 
release.


P.S.
Is this runtime error OE specific? Is it caused by some OE specific patch?

Regards,
Qi

On 2/27/24 18:07, Jose Quaresma wrote:

With go-1.21 dynamic linking cause a runtime panic:

| root@qemux86-64:~# go-helloworld
| panic: runtime error: index out of range [0] with length 0
|
| goroutine 1 [running]:
| flag.init()
| /usr/lib/go/src/flag/flag.go:1199 +0xf9

In my opinion, this would be a good trade-off so that we can update and
leave the version 1.20 for the next LTS 5.0 since we are already quite
behind on the version available upstream which already has the 1.22 available.

Signed-off-by: Jose Quaresma 
---
  meta/classes-recipe/goarch.bbclass | 14 +++---
  1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/meta/classes-recipe/goarch.bbclass 
b/meta/classes-recipe/goarch.bbclass
index 1ebe03864f..6899ec28e4 100644
--- a/meta/classes-recipe/goarch.bbclass
+++ b/meta/classes-recipe/goarch.bbclass
@@ -38,13 +38,13 @@ BASE_GOARM:armv5 = '5'
  # Go supports dynamic linking on a limited set of architectures.
  # See the supportsDynlink function in go/src/cmd/compile/internal/gc/main.go
  GO_DYNLINK = ""
-GO_DYNLINK:arm ?= "1"
-GO_DYNLINK:aarch64 ?= "1"
-GO_DYNLINK:x86 ?= "1"
-GO_DYNLINK:x86-64 ?= "1"
-GO_DYNLINK:powerpc64 ?= "1"
-GO_DYNLINK:powerpc64le ?= "1"
-GO_DYNLINK:class-native ?= ""
+GO_DYNLINK:arm = ""
+GO_DYNLINK:aarch64 = ""
+GO_DYNLINK:x86 = ""
+GO_DYNLINK:x86-64 = ""
+GO_DYNLINK:powerpc64 = ""
+GO_DYNLINK:powerpc64le = ""
+GO_DYNLINK:class-native = ""
  GO_DYNLINK:class-nativesdk = ""
  
  # define here because everybody inherits this class







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196319): 
https://lists.openembedded.org/g/openembedded-core/message/196319
Mute This Topic: https://lists.openembedded.org/mt/104600087/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 1/3] useradd.bbclass: Fix order of postinst-useradd-*

2024-02-23 Thread Chen Qi via lists.openembedded.org
1. I can see what this patch mainly does is ensuring groups first, then 
user, then groupmems. But the current useradd_preinst, which is called 
by useradd_sysroot has already ensured this. Is that not working?


2. You're using bb.warn as a method of outputting debugging information, 
which I don't think is appropriate.


Regards,
Qi

On 2/22/24 22:53, Eilís 'pidge' Ní Fhlannagáin wrote:

From: Piotr Łobacz 

postinst-useradd-* haven't been running in order of dependency.

This patch is reworked from Piotr Łobacz's patch and fixes:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=15084
https://bugzilla.yoctoproject.org/show_bug.cgi?id=13904

It ensures that groups, users and groupmems are all run in the correct order.

Signed-off-by: Eilís 'pidge' Ní Fhlannagáin 
---
  meta/classes-global/staging.bbclass |  7 +--
  meta/classes/useradd.bbclass| 72 ++---
  2 files changed, 49 insertions(+), 30 deletions(-)

diff --git a/meta/classes-global/staging.bbclass 
b/meta/classes-global/staging.bbclass
index ab3e1d71b5..6c21510377 100644
--- a/meta/classes-global/staging.bbclass
+++ b/meta/classes-global/staging.bbclass
@@ -245,8 +245,9 @@ def staging_populate_sysroot_dir(targetsysroot, 
nativesysroot, native, d):
  continue
  
  staging_processfixme(fixme, targetdir, targetsysroot, nativesysroot, d)

-for p in postinsts:
-bb.note("Running postinst {}, output:\n{}".format(p, 
subprocess.check_output(p, shell=True, stderr=subprocess.STDOUT)))
+bb.warn(sorted(postinsts))
+for p in sorted(postinsts):
+bb.warn("Running postinst {}, output:\n{}".format(p, 
subprocess.check_output(p, shell=True, stderr=subprocess.STDOUT)))
  
  #

  # Manifests here are complicated. The main sysroot area has the unpacked 
sstate
@@ -629,7 +630,7 @@ python extend_recipe_sysroot() {
  for f in fixme:
  staging_processfixme(fixme[f], f, recipesysroot, recipesysrootnative, 
d)
  
-for p in postinsts:

+for p in sorted(postinsts):
  bb.note("Running postinst {}, output:\n{}".format(p, 
subprocess.check_output(p, shell=True, stderr=subprocess.STDOUT)))
  
  for dep in manifests:

diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
index a58f8287c9..924eeadf9c 100644
--- a/meta/classes/useradd.bbclass
+++ b/meta/classes/useradd.bbclass
@@ -103,6 +103,18 @@ fi
  }
  
  useradd_sysroot () {

+   user_group_groupmems_add_sysroot user
+}
+
+groupadd_sysroot () {
+   user_group_groupmems_add_sysroot group
+}
+
+groupmemsadd_sysroot () {
+   user_group_groupmems_add_sysroot groupmems
+}
+
+user_group_groupmems_add_sysroot () {
# Pseudo may (do_prepare_recipe_sysroot) or may not 
(do_populate_sysroot_setscene) be running
# at this point so we're explicit about the environment so pseudo can 
load if
# not already present.
@@ -130,10 +142,19 @@ useradd_sysroot () {
exit 0
fi
  
-	# Add groups and users defined for all recipe packages

-   GROUPADD_PARAM="${@get_all_cmd_params(d, 'groupadd')}"
-   USERADD_PARAM="${@get_all_cmd_params(d, 'useradd')}"
-   GROUPMEMS_PARAM="${@get_all_cmd_params(d, 'groupmems')}"
+   # Add groups and users defined for all recipe packages
+   if test "x$1" = "xgroup"; then
+   GROUPADD_PARAM="${@get_all_cmd_params(d, 'groupadd')}"
+   fi
+   if test "x$1" = "xuser"; then
+   USERADD_PARAM="${@get_all_cmd_params(d, 'useradd')}"
+   fi
+   if test "x$1" = "xgroupmems"; then
+   GROUPMEMS_PARAM="${@get_all_cmd_params(d, 'groupmems')}"
+   fi
+   if test "x$1" = "x"; then
+   bbwarn "missing type of passwd db action"
+fi 
  
  	# Tell the system to use the environment vars

UA_SYSROOT=1
@@ -148,29 +169,26 @@ useradd_sysroot () {
  EXTRA_STAGING_FIXMES += "PSEUDO_SYSROOT PSEUDO_LOCALSTATEDIR LOGFIFO"
  
  python useradd_sysroot_sstate () {

-scriptfile = None
-task = d.getVar("BB_CURRENTTASK")
-if task == "package_setscene":
-bb.build.exec_func("useradd_sysroot", d)
-elif task == "prepare_recipe_sysroot":
-# Used to update this recipe's own sysroot so the user/groups are 
available to do_install
-
-# If do_populate_sysroot is triggered and we write the file here, 
there would be an overlapping
-# files. See 
usergrouptests.UserGroupTests.test_add_task_between_p_sysroot_and_package
-scriptfile = 
d.expand("${RECIPE_SYSROOT}${bindir}/postinst-useradd-${PN}-recipedebug")
-
-bb.build.exec_func("useradd_sysroot", d)
-elif task == "populate_sysroot":
-# Used when installed in dependent task sysroots
-scriptfile = 
d.expand("${SYSROOT_DESTDIR}${bindir}/postinst-useradd-${PN}")
-
-if scriptfile:
-bb.utils.mkdirhier(os.path.dirname(scriptfile))
-with open(scriptfile, 'w') as script:
-script.write("#!/bin/sh -e\n")
- 

Re: [OE-core] [PATCH] sanity.bbclass: raise_sanity_error if /tmp is noexec

2024-02-20 Thread Chen Qi via lists.openembedded.org

Hi Michal,

I just noticed the change. I can't find the V2 in my mailbox, so I'm 
going to reply here.
I'm a little concerned about forcing such requirement here. It does not 
seem *necessary*.
As far as I know, the whole oe-core does not need /tmp to be exec. The 
commit message says 'old meson', this means the current version of meson 
works well, right?
Also, why is there 'no simple way to workaround'? Is the recipe 
hardcoding '/tmp' instead of using API or command? Does exporting TMPDIR 
work?

e.g.,
export TMPDIR="${B}/tmp"

Regards,
Qi

On 2/9/24 23:57, Ross Burton wrote:

On 9 Feb 2024, at 14:09, Michal Sieron via lists.openembedded.org 
 wrote:

+# Ensure /tmp is NOT mounted with noexec
+with open("/proc/mounts", "r") as f:
+for line in f:
+# format is described in fstab(5)
+_, fs_file, _, fs_mntops, *_ = line.split()
+
+# we only want to check /tmp
+if fs_file != "/tmp":
+continue
+
+# iterate through the options from the end
+for opt in reversed(fs_mntops.split(",")):
+if opt == "noexec":
+raise_sanity_error("/tmp shouldn't be mounted with 
noexec.", d)
+

Alternatively, this is neater:

os.statvfs("/tmp").f_flag & os.ST_NOEXEC

Ross






-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#195957): 
https://lists.openembedded.org/g/openembedded-core/message/195957
Mute This Topic: https://lists.openembedded.org/mt/104258828/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] systemd-firstboot not triggered on read/write /etc folder

2024-02-18 Thread Chen Qi via lists.openembedded.org

Does adding 'stateless-rootfs' to IMAGE_FEATURES work for you?

meta/classes-recipe/image.bbclass:IMAGE_PREPROCESS_COMMAND:append = " 
${@ 'systemd_preset_all systemd_disable_units' if 
bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d) and not 
bb.utils.contains('IMAGE_FEATURES', 'stateless-rootfs', True, False, d) 
else ''} reproducible_final_image_task "


Regards,
Qi

On 2/18/24 17:43, dave.elek...@gmail.com wrote:

Hi!

In the systemd-systemctl there is a *systemctl* script used for some 
configuration/settings for the systemd services (e.g. enabling services).


In this script if we call the *preset_all* command, it will create an 
empty //etc/machine-id/ file. This is required on read-only //etc/ 
folder, otherwise the systemd will fail to boot. However on read-write 
/etc folder this file is still created, which prevents systemd to 
satisfy the ConditionFirstBoot condition. This is used in systemd 
services, for example for systemd-firstboot, where you can configure 
the root password, localization, hostname, etc.


The preset_all command is triggered from the /image.bbclass/ file. A 
quick solution in my case was to add a task in my own layer, which 
deletes the //etc/machine-id/ file, but I think it would be great, to 
prevent others from the headache it can cause to investigate/fix this.


I attached the patch file about my proposed solution.

Waiting for you reply soon,
David




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#195861): 
https://lists.openembedded.org/g/openembedded-core/message/195861
Mute This Topic: https://lists.openembedded.org/mt/104425254/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH] gnupg: disable tests to avoid running target binaries at build time

2024-02-17 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

By default, the tests are built and run at do_compile and we can see
errors like below in log.do_compile:

  gnupg-2.4.4/tests/cms/inittests: line 99: ../../sm/gpgsm: cannot execute 
binary file: Exec format error

Note that the do_compile process still succeeds. However, we'd better avoid
executing these target binaries at build time.

Signed-off-by: Chen Qi 
---
 meta/recipes-support/gnupg/gnupg_2.4.4.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-support/gnupg/gnupg_2.4.4.bb 
b/meta/recipes-support/gnupg/gnupg_2.4.4.bb
index 5b9869b4f3..fff7d8c6da 100644
--- a/meta/recipes-support/gnupg/gnupg_2.4.4.bb
+++ b/meta/recipes-support/gnupg/gnupg_2.4.4.bb
@@ -32,6 +32,7 @@ EXTRA_OECONF = "--disable-ldap \
--with-readline=${STAGING_LIBDIR}/.. \
--with-mailprog=${sbindir}/sendmail \
--enable-gpg-is-gpg2 \
+   --disable-tests \
"
 # yat2m can be found from recipe-sysroot-native non-deterministically with 
different versioning otherwise
 CACHED_CONFIGUREVARS += "ac_cv_path_YAT2M=./yat2m"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#195819): 
https://lists.openembedded.org/g/openembedded-core/message/195819
Mute This Topic: https://lists.openembedded.org/mt/104422992/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH 1/3] systemd: upgrade to 255.1

2024-01-22 Thread Chen Qi via lists.openembedded.org

On 1/22/24 16:04, Alexandre Belloni wrote:

On 22/01/2024 12:38:15+0800, ChenQi wrote:

On 1/20/24 02:14, Alexandre Belloni wrote:

On 19/01/2024 19:13:25+0100, Alexandre Belloni wrote:

On 19/01/2024 11:09:20+0800, Chen Qi via lists.openembedded.org wrote:

What's the status of this patch series?
Is there any issue or concern that I missed?

I'm glad you asked, I got this today:

https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/8466/steps/26/logs/warnings

and I know you sent a patch for this but it didn't make it yet.

I just double checked with the following settings from the "Sysvinit with
systemd" entry in config.json, there's no warning.

DISTRO_FEATURES:append = ' systemd usrmerge'
ROOT_HOME = '/root'
VIRTUAL-RUNTIME_init_manager = 'sysvinit'

So I further checked the build's settings.
https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/8466

In the second step, "Fetch yocto-autobuilder-helper", I can see the
following logs:

HEAD is now at ebb7e65 config.json: Fix syntax errors

So the build is not using the latest repo. The latest commit is:

This is not correct, it was using the latest commit at the time, the
patch was applied after my email.


OK... Do you mean that the warning appeared in autobuilder, and then you 
applied the patch to yocto-autobuilder-helper to make the warning 
disappear? I thought you meant that the warning continued to exist even 
with the patch.


To clarify, we can now wait for autobuiler's results and I don't need to 
do anything more, right?


Regards,

Qi


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194121): 
https://lists.openembedded.org/g/openembedded-core/message/194121
Mute This Topic: https://lists.openembedded.org/mt/103380516/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] devtool/standard: avoid KeyError

2024-01-21 Thread Chen Qi via lists.openembedded.org

On 1/22/24 13:00, Chen Qi via lists.openembedded.org wrote:

On 1/20/24 01:19, Richard Purdie wrote:

On Tue, 2023-12-26 at 12:44 +0800, Chen Qi via lists.openembedded.org
wrote:

From: Chen Qi 

The initial_revs["."] does not have an initial value, resulting
in the following error:

   KeyError: '.'

The problem could be reproduced by running:

   devtool modify -n systemd 

Signed-off-by: Chen Qi 
---
  scripts/lib/devtool/standard.py | 1 +
  1 file changed, 1 insertion(+)

diff --git a/scripts/lib/devtool/standard.py 
b/scripts/lib/devtool/standard.py

index 559fd45676..5d9b86ed6a 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -905,6 +905,7 @@ def modify(args, config, basepath, workspace):
  (stdout, _) = bb.process.run('git rev-list 
--reverse devtool-base..HEAD', cwd=submodule_path)

  commits[submodule] = stdout.split()
  else:
+    initial_revs["."] = None
  if os.path.exists(os.path.join(srctree, '.git')):
  # Check if it's a tree previously extracted by us. 
This is done
  # by ensuring that devtool-base and args.branch 
(devtool) exist.

Why aren't we seeing other reports of this? How is it reproduced?


I checked the devtool OEQA, there' no test case to cover this.

You can see my reproduce step in my commit message.

When I was trying to add an oeqa to this case just now, I found the 
problem has been fixed by the following commit.


"""

commit 64d5db2f89b4f3712b55127215ae02ce50dd747a
Author: Jamin Lin 
Date:   Wed Jan 3 18:13:44 2024 +0800

    devtool: modify: fix exception

    Root Cause:
    initial_revs is an empty dictionary and do not have "." key.

    Traceback (most recent call last):
  File "scripts/devtool", line 349, in 
    ret = main()
  File "scripts/devtool", line 336, in main
    ret = args.func(args, config, basepath, workspace)
  File "scripts/lib/devtool/standard.py", line 922, in modify
    if not initial_revs["."]:
    KeyError: '.'

    Solution:
    check key exists, then get its value.

    (From OE-Core rev: fb0db5c48abb4d56233a175fdd349d18b972e452)

    Signed-off-by: Jamin Lin 
    Signed-off-by: Alexandre Belloni 
    Signed-off-by: Richard Purdie 

"""

So my patch can be ignored.

Regards,

Qi


To avoid any regression, I just sent out a patch to add a test case, 
devtool.DevtoolModifyTests.test_devtool_modify_git_no_extract.


Regards,

Qi




Should we be adding an extra test to improve coverage?

I'm assuming this isn't related to:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=15318

?

Cheers,

Richard








-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194115): 
https://lists.openembedded.org/g/openembedded-core/message/194115
Mute This Topic: https://lists.openembedded.org/mt/10330/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH] oeqa/selftest: add test case to cover 'devtool modify -n' for a git recipe

2024-01-21 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Add a test case to ensure the following error does not happen again for
'devtool modify -n'.

Traceback (most recent call last):
  File "/buildarea2/chenqi/poky/scripts/devtool", line 349, in 
ret = main()
  File "/buildarea2/chenqi/poky/scripts/devtool", line 336, in main
ret = args.func(args, config, basepath, workspace)
  File "/buildarea2/chenqi/poky/scripts/lib/devtool/standard.py", line 924, in 
modify
if not initial_revs["."]:
KeyError: '.'

Signed-off-by: Chen Qi 
---
 meta/lib/oeqa/selftest/cases/devtool.py | 22 ++
 1 file changed, 22 insertions(+)

diff --git a/meta/lib/oeqa/selftest/cases/devtool.py 
b/meta/lib/oeqa/selftest/cases/devtool.py
index a877720769..22ea0ecba9 100644
--- a/meta/lib/oeqa/selftest/cases/devtool.py
+++ b/meta/lib/oeqa/selftest/cases/devtool.py
@@ -917,6 +917,28 @@ class DevtoolModifyTests(DevtoolBase):
 # Try building
 bitbake(testrecipe)
 
+def test_devtool_modify_git_no_extract(self):
+# Check preconditions
+testrecipe = 'psplash'
+src_uri = get_bb_var('SRC_URI', testrecipe)
+self.assertIn('git://', src_uri, 'This test expects the %s recipe to 
be a git recipe' % testrecipe)
+# Clean up anything in the workdir/sysroot/sstate cache
+bitbake('%s -c cleansstate' % testrecipe)
+# Try modifying a recipe
+tempdir = tempfile.mkdtemp(prefix='devtoolqa')
+self.track_for_cleanup(tempdir)
+self.track_for_cleanup(self.workspacedir)
+self.add_command_to_tearDown('bitbake -c clean %s' % testrecipe)
+self.add_command_to_tearDown('bitbake-layers remove-layer */workspace')
+result = runCmd('git clone https://git.yoctoproject.org/psplash %s && 
devtool modify -n %s %s' % (tempdir, testrecipe, tempdir))
+self.assertExists(os.path.join(self.workspacedir, 'conf', 
'layer.conf'), 'Workspace directory not created. devtool output: %s' % 
result.output)
+matches = glob.glob(os.path.join(self.workspacedir, 'appends', 
'psplash_*.bbappend'))
+self.assertTrue(matches, 'bbappend not created')
+# Test devtool status
+result = runCmd('devtool status')
+self.assertIn(testrecipe, result.output)
+self.assertIn(tempdir, result.output)
+
 def test_devtool_modify_git_crates_subpath(self):
 # This tests two things in devtool context:
 #   - that we support local git dependencies for cargo based recipe
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194114): 
https://lists.openembedded.org/g/openembedded-core/message/194114
Mute This Topic: https://lists.openembedded.org/mt/103881323/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] devtool/standard: avoid KeyError

2024-01-21 Thread Chen Qi via lists.openembedded.org

On 1/20/24 01:19, Richard Purdie wrote:

On Tue, 2023-12-26 at 12:44 +0800, Chen Qi via lists.openembedded.org
wrote:

From: Chen Qi 

The initial_revs["."] does not have an initial value, resulting
in the following error:

   KeyError: '.'

The problem could be reproduced by running:

   devtool modify -n systemd 

Signed-off-by: Chen Qi 
---
  scripts/lib/devtool/standard.py | 1 +
  1 file changed, 1 insertion(+)

diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index 559fd45676..5d9b86ed6a 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -905,6 +905,7 @@ def modify(args, config, basepath, workspace):
  (stdout, _) = bb.process.run('git rev-list --reverse 
devtool-base..HEAD', cwd=submodule_path)
  commits[submodule] = stdout.split()
  else:
+initial_revs["."] = None
  if os.path.exists(os.path.join(srctree, '.git')):
  # Check if it's a tree previously extracted by us. This is 
done
  # by ensuring that devtool-base and args.branch (devtool) 
exist.

Why aren't we seeing other reports of this? How is it reproduced?


I checked the devtool OEQA, there' no test case to cover this.

You can see my reproduce step in my commit message.

When I was trying to add an oeqa to this case just now, I found the 
problem has been fixed by the following commit.


"""

commit 64d5db2f89b4f3712b55127215ae02ce50dd747a
Author: Jamin Lin 
Date:   Wed Jan 3 18:13:44 2024 +0800

    devtool: modify: fix exception

    Root Cause:
    initial_revs is an empty dictionary and do not have "." key.

    Traceback (most recent call last):
  File "scripts/devtool", line 349, in 
    ret = main()
  File "scripts/devtool", line 336, in main
    ret = args.func(args, config, basepath, workspace)
  File "scripts/lib/devtool/standard.py", line 922, in modify
    if not initial_revs["."]:
    KeyError: '.'

    Solution:
    check key exists, then get its value.

    (From OE-Core rev: fb0db5c48abb4d56233a175fdd349d18b972e452)

    Signed-off-by: Jamin Lin 
    Signed-off-by: Alexandre Belloni 
    Signed-off-by: Richard Purdie 

"""

So my patch can be ignored.

Regards,

Qi


Should we be adding an extra test to improve coverage?

I'm assuming this isn't related to:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=15318

?

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194112): 
https://lists.openembedded.org/g/openembedded-core/message/194112
Mute This Topic: https://lists.openembedded.org/mt/10330/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH 1/3] systemd: upgrade to 255.1

2024-01-21 Thread Chen Qi via lists.openembedded.org

On 1/20/24 02:14, Alexandre Belloni wrote:

On 19/01/2024 19:13:25+0100, Alexandre Belloni wrote:

On 19/01/2024 11:09:20+0800, Chen Qi via lists.openembedded.org wrote:

What's the status of this patch series?
Is there any issue or concern that I missed?

I'm glad you asked, I got this today:

https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/8466/steps/26/logs/warnings

and I know you sent a patch for this but it didn't make it yet.


I just double checked with the following settings from the "Sysvinit 
with systemd" entry in config.json, there's no warning.


DISTRO_FEATURES:append = ' systemd usrmerge'
ROOT_HOME = '/root'
VIRTUAL-RUNTIME_init_manager = 'sysvinit'

So I further checked the build's settings. 
https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/8466


In the second step, "Fetch yocto-autobuilder-helper", I can see the 
following logs:


HEAD is now at ebb7e65 config.json: Fix syntax errors

So the build is not using the latest repo. The latest commit is:

97bb07f (HEAD -> master, origin/master, origin/HEAD) config.json: set 
ROOT_HOME to /root for sysvinit with systemd


Regards,

Qi





Regards,
Qi

On 12/27/23 12:20, Chen Qi via lists.openembedded.org wrote:

From: Chen Qi

1. Patch changes:

0004-Move-sysusers.d-sysctl.d-binfmt.d-modules-load.d-to-.patch
is removed because it has no real effect now. The /lib is now
/usr/lib because 'usrmerge' is a required distro feature for systemd.

0002-binfmt-Don-t-install-dependency-links-at-install-tim.patch is
refreshed for the new version to avoid patch-fuzz issue.

2. root user's home directory now defaults to "/root":

The sysuers.d/basic.conf is still modified to respect the ROOT_HOME
value, so if users set ROOT_HOME to "/home/root", the behavior is the
same as before. However, this is only for backward compatibility. With
this patch, The ROOT_HOME value is set to "/root" in init-manager-systemd.inc.
This is because systemd's source codes are hardcoding "/root", and other
values are not officially supported. See the list below.
$ grep -rl '"/root"' src/ | grep -v 'src/test'
src/core/namespace.c
src/basic/user-util.c
src/nss-systemd/nss-systemd.c
src/nspawn/nspawn.c
src/firstboot/firstboot.c
src/shared/userdb.c
src/shared/user-record.c
$ grep -rl /root network/ factory/ sysctl.d/ sysusers.d/ rules.d/ tmpfiles.d/ 
units/ xorg/ tools/
sysusers.d/basic.conf.in
tmpfiles.d/provision.conf
units/emergency.service.in
units/rescue.service.in
tools/list-discoverable-partitions.py
Previously, the recipe was just substituting sysusers.d/basic.conf.in,
which is not enough to be treated as 'fully support'. I deliberately put
a warning message in do_install to warn users about non "/root" ROOT_HOME
value. Don't remove it until all above places are handled.

3. cgroupv2 is now the default.
cgroupv2 is the default for systemd for many years and it's the default
for distros such as ubuntu and fedora. Let's also use it as the default.

Signed-off-by: Chen Qi
---
   .../distro/include/init-manager-systemd.inc   |  2 +
   meta/recipes-core/systemd/systemd.inc |  4 +-
   ...tall-dependency-links-at-install-tim.patch | 22 +++---
   ...sysctl.d-binfmt.d-modules-load.d-to-.patch | 73 ---
   .../systemd/systemd/basic.conf.in | 40 --
   .../{systemd_254.4.bb => systemd_255.1.bb}| 16 ++--
   6 files changed, 25 insertions(+), 132 deletions(-)
   delete mode 100644 
meta/recipes-core/systemd/systemd/0004-Move-sysusers.d-sysctl.d-binfmt.d-modules-load.d-to-.patch
   delete mode 100644 meta/recipes-core/systemd/systemd/basic.conf.in
   rename meta/recipes-core/systemd/{systemd_254.4.bb => systemd_255.1.bb} (98%)

diff --git a/meta/conf/distro/include/init-manager-systemd.inc 
b/meta/conf/distro/include/init-manager-systemd.inc
index 595d1f2644..0a76647459 100644
--- a/meta/conf/distro/include/init-manager-systemd.inc
+++ b/meta/conf/distro/include/init-manager-systemd.inc
@@ -5,3 +5,5 @@ VIRTUAL-RUNTIME_init_manager ??= "systemd"
   VIRTUAL-RUNTIME_initscripts ??= "systemd-compat-units"
   VIRTUAL-RUNTIME_login_manager ??= "shadow-base"
   VIRTUAL-RUNTIME_dev_manager ??= "systemd"
+# systemd hardcodes /root in its source codes, other values are not offically 
supported
+ROOT_HOME ?= "/root"
diff --git a/meta/recipes-core/systemd/systemd.inc 
b/meta/recipes-core/systemd/systemd.inc
index ccc3236457..1417e0150f 100644
--- a/meta/recipes-core/systemd/systemd.inc
+++ b/meta/recipes-core/systemd/systemd.inc
@@ -15,8 +15,8 @@ LICENSE:libsystemd = "LGPL-2.1-or-later"
   LIC_FILES_CHKSUM ="file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe \ 
file://LICENSE.LGPL2.1;md5=4fbd65380cdd255951079008b364516c"

-SRCREV = "2e

Re: [OE-core] [PATCH v3 1/2] shadow: update 4.13 -> 4.14.2

2024-01-19 Thread Chen Qi via lists.openembedded.org
I didn't do anything particular, but as several people are sharing the server, 
it's possible that its environment is somewhat messed up. I'll check more and 
fix the environment. Thanks for your double check.

Regards,
Qi

-Original Message-
From: Alexander Kanavin  
Sent: Friday, January 19, 2024 6:12 PM
To: Chen, Qi 
Cc: openembedded-core@lists.openembedded.org; Alexander Kanavin 

Subject: Re: [OE-core] [PATCH v3 1/2] shadow: update 4.13 -> 4.14.2

I just tried poky master on ubuntu 20.04, and the issues do not appear. Do you 
have a custom setup?

Alex

On Fri, 19 Jan 2024 at 04:06, ChenQi  wrote:
>
> I'm seeing build failures on Ubuntu 20.04.
> GCC version: 9.4.0
>
> 1. error: parameter name omitted
> The problem is that the active_sessions_count function's definition 
> lacks parameter. I did change like below:
> -unsigned long active_sessions_count(const char *name, unsigned long 
> unused)
> +unsigned long active_sessions_count(const char *name, unsigned long
> unused unused_parameter)
> But then I observed another error, as shown below.
>
> 2. undefined reference to `dlsym'.
> | /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/hosttools/ld:
> ../lib/.libs/libshadow.a(libshadow_la-nss.o): in function `nss_exit':
> | nss.c:(.text+0x32): undefined reference to `dlclose'
> | /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/hosttools/ld:
> ../lib/.libs/libshadow.a(libshadow_la-nss.o): in function `nss_init':
> | nss.c:(.text+0x1dd): undefined reference to `dlopen'
> | /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/hosttools/ld:
> nss.c:(.text+0x21c): undefined reference to `dlsym'
> | /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/hosttools/ld:
> nss.c:(.text+0x237): undefined reference to `dlsym'
> | /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/hosttools/ld:
> nss.c:(.text+0x253): undefined reference to `dlsym'
> | /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/hosttools/ld:
> nss.c:(.text+0x365): undefined reference to `dlclose'
> | /ala-lpggp72/qichen/Yocto/builds/build-master/tmp/hosttools/ld:
> nss.c:(.text+0x3b2): undefined reference to `dlerror'
> | collect2: error: ld returned 1 exit status
> | make[2]: *** [Makefile:1130: su] Error 1
>
> On Ubuntu22.04, there's no such issue.
>
> Regards,
> Qi
>
> On 1/11/24 21:15, Alexander Kanavin wrote:
> > License-Update: formatting, spdx conversion
> >
> > Drop:
> > 0001-Disable-use-of-syslog-for-sysroot.patch
> > (issue fixed upstream)
> >
> > 0001-Fix-can-not-print-full-login.patch
> > 0001-Overhaul-valid_field.patch
> > CVE-2023-29383.patch
> > (backports)
> >
> > libbsd is a new native dependency, as otherwise glibc >= 2.38 is 
> > needed.
> >
> > A similar fix is added to musl in order to define non-standard 
> > __BEGIN_DECLS/__END_DECLS.
> >
> > Signed-off-by: Alexander Kanavin 
> > ---
> >   ...01-Disable-use-of-syslog-for-sysroot.patch |  52 ---
> >   .../0001-Fix-can-not-print-full-login.patch   |  41 -
> >   .../files/0001-Overhaul-valid_field.patch |  65 
> >   .../shadow/files/CVE-2023-29383.patch |  53 ---
> >   .../shadow/files/CVE-2023-4641.patch  | 147 --
> >   ...nexpected-open-failure-in-chroot-env.patch |  16 +-
> >   meta/recipes-extended/shadow/shadow.inc   |  20 +--
> >   .../{shadow_4.13.bb => shadow_4.14.2.bb}  |   0
> >   8 files changed, 16 insertions(+), 378 deletions(-)
> >   delete mode 100644 
> > meta/recipes-extended/shadow/files/0001-Disable-use-of-syslog-for-sysroot.patch
> >   delete mode 100644 
> > meta/recipes-extended/shadow/files/0001-Fix-can-not-print-full-login.patch
> >   delete mode 100644 
> > meta/recipes-extended/shadow/files/0001-Overhaul-valid_field.patch
> >   delete mode 100644 meta/recipes-extended/shadow/files/CVE-2023-29383.patch
> >   delete mode 100644 meta/recipes-extended/shadow/files/CVE-2023-4641.patch
> >   rename meta/recipes-extended/shadow/{shadow_4.13.bb => 
> > shadow_4.14.2.bb} (100%)
> >
> > diff --git 
> > a/meta/recipes-extended/shadow/files/0001-Disable-use-of-syslog-for-
> > sysroot.patch 
> > b/meta/recipes-extended/shadow/files/0001-Disable-use-of-syslog-for-
> > sysroot.patch
> > deleted file mode 100644
> > index fa1532c8317..000
> > --- 
> > a/meta/recipes-extended/shadow/files/0001-Disable-use-of-syslog-for-
> > sysroot.patch
> > +++ /dev/null
> > @@ -1,52 +0,0 @@
> > -From 85d0444229ee3d14fefcf10d093f49c862826f82 Mon Sep 17 00:00:00 
> > 2001
> > -From: Ric

Re: [OE-core][PATCH] devtool/standard: avoid KeyError

2024-01-18 Thread Chen Qi via lists.openembedded.org

ping

On 12/26/23 12:44, Chen Qi via lists.openembedded.org wrote:

From: Chen Qi 

The initial_revs["."] does not have an initial value, resulting
in the following error:

   KeyError: '.'

The problem could be reproduced by running:

   devtool modify -n systemd 

Signed-off-by: Chen Qi 
---
  scripts/lib/devtool/standard.py | 1 +
  1 file changed, 1 insertion(+)

diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index 559fd45676..5d9b86ed6a 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -905,6 +905,7 @@ def modify(args, config, basepath, workspace):
  (stdout, _) = bb.process.run('git rev-list --reverse 
devtool-base..HEAD', cwd=submodule_path)
  commits[submodule] = stdout.split()
  else:
+initial_revs["."] = None
  if os.path.exists(os.path.join(srctree, '.git')):
  # Check if it's a tree previously extracted by us. This is 
done
  # by ensuring that devtool-base and args.branch (devtool) 
exist.






-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194008): 
https://lists.openembedded.org/g/openembedded-core/message/194008
Mute This Topic: https://lists.openembedded.org/mt/10330/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH 1/3] systemd: upgrade to 255.1

2024-01-18 Thread Chen Qi via lists.openembedded.org

What's the status of this patch series?
Is there any issue or concern that I missed?

Regards,
Qi

On 12/27/23 12:20, Chen Qi via lists.openembedded.org wrote:

From: Chen Qi 

1. Patch changes:

0004-Move-sysusers.d-sysctl.d-binfmt.d-modules-load.d-to-.patch
is removed because it has no real effect now. The /lib is now
/usr/lib because 'usrmerge' is a required distro feature for systemd.

0002-binfmt-Don-t-install-dependency-links-at-install-tim.patch is
refreshed for the new version to avoid patch-fuzz issue.

2. root user's home directory now defaults to "/root":

The sysuers.d/basic.conf is still modified to respect the ROOT_HOME
value, so if users set ROOT_HOME to "/home/root", the behavior is the
same as before. However, this is only for backward compatibility. With
this patch, The ROOT_HOME value is set to "/root" in init-manager-systemd.inc.
This is because systemd's source codes are hardcoding "/root", and other
values are not officially supported. See the list below.
$ grep -rl '"/root"' src/ | grep -v 'src/test'
src/core/namespace.c
src/basic/user-util.c
src/nss-systemd/nss-systemd.c
src/nspawn/nspawn.c
src/firstboot/firstboot.c
src/shared/userdb.c
src/shared/user-record.c
$ grep -rl /root network/ factory/ sysctl.d/ sysusers.d/ rules.d/ tmpfiles.d/ 
units/ xorg/ tools/
sysusers.d/basic.conf.in
tmpfiles.d/provision.conf
units/emergency.service.in
units/rescue.service.in
tools/list-discoverable-partitions.py
Previously, the recipe was just substituting sysusers.d/basic.conf.in,
which is not enough to be treated as 'fully support'. I deliberately put
a warning message in do_install to warn users about non "/root" ROOT_HOME
value. Don't remove it until all above places are handled.

3. cgroupv2 is now the default.
cgroupv2 is the default for systemd for many years and it's the default
for distros such as ubuntu and fedora. Let's also use it as the default.

Signed-off-by: Chen Qi 
---
  .../distro/include/init-manager-systemd.inc   |  2 +
  meta/recipes-core/systemd/systemd.inc |  4 +-
  ...tall-dependency-links-at-install-tim.patch | 22 +++---
  ...sysctl.d-binfmt.d-modules-load.d-to-.patch | 73 ---
  .../systemd/systemd/basic.conf.in | 40 --
  .../{systemd_254.4.bb => systemd_255.1.bb}| 16 ++--
  6 files changed, 25 insertions(+), 132 deletions(-)
  delete mode 100644 
meta/recipes-core/systemd/systemd/0004-Move-sysusers.d-sysctl.d-binfmt.d-modules-load.d-to-.patch
  delete mode 100644 meta/recipes-core/systemd/systemd/basic.conf.in
  rename meta/recipes-core/systemd/{systemd_254.4.bb => systemd_255.1.bb} (98%)

diff --git a/meta/conf/distro/include/init-manager-systemd.inc 
b/meta/conf/distro/include/init-manager-systemd.inc
index 595d1f2644..0a76647459 100644
--- a/meta/conf/distro/include/init-manager-systemd.inc
+++ b/meta/conf/distro/include/init-manager-systemd.inc
@@ -5,3 +5,5 @@ VIRTUAL-RUNTIME_init_manager ??= "systemd"
  VIRTUAL-RUNTIME_initscripts ??= "systemd-compat-units"
  VIRTUAL-RUNTIME_login_manager ??= "shadow-base"
  VIRTUAL-RUNTIME_dev_manager ??= "systemd"
+# systemd hardcodes /root in its source codes, other values are not offically 
supported
+ROOT_HOME ?= "/root"
diff --git a/meta/recipes-core/systemd/systemd.inc 
b/meta/recipes-core/systemd/systemd.inc
index ccc3236457..1417e0150f 100644
--- a/meta/recipes-core/systemd/systemd.inc
+++ b/meta/recipes-core/systemd/systemd.inc
@@ -15,8 +15,8 @@ LICENSE:libsystemd = "LGPL-2.1-or-later"
  LIC_FILES_CHKSUM = "file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe \
  
file://LICENSE.LGPL2.1;md5=4fbd65380cdd255951079008b364516c"
  
-SRCREV = "2e7504449a51fb38db9cd2da391c6434f82def51"

-SRCBRANCH = "v254-stable"
+SRCREV = "2018ccef6645ce00c784369a22dc4e98f6d7061d"
+SRCBRANCH = "v255-stable"
  SRC_URI = 
"git://github.com/systemd/systemd-stable.git;protocol=https;branch=${SRCBRANCH}"
  
  S = "${WORKDIR}/git"

diff --git 
a/meta/recipes-core/systemd/systemd/0002-binfmt-Don-t-install-dependency-links-at-install-tim.patch
 
b/meta/recipes-core/systemd/systemd/0002-binfmt-Don-t-install-dependency-links-at-install-tim.patch
index 085f1e9052..be231cf6b2 100644
--- 
a/meta/recipes-core/systemd/systemd/0002-binfmt-Don-t-install-dependency-links-at-install-tim.patch
+++ 
b/meta/recipes-core/systemd/systemd/0002-binfmt-Don-t-install-dependency-links-at-install-tim.patch
@@ -1,8 +1,8 @@
-From ca7d9a8d9c81702af9c599bb79706f12b1a465cf Mon Sep 17 00:00:00 2001
+From 29a58009a172e369ad7166e16dab2f4945c6b0d2 Mon Sep 17 00:00:00 2001
  From: Chen Qi 
  Date: Thu, 21 Feb 2019 16:23:24 +0800
-Subject: [PATCH] binfmt: Don't install dependency links at install time for
- the binfmt services
+Subject: [PATCH 1/2] b

Re: [OE-core] [PATCH v3 1/2] shadow: update 4.13 -> 4.14.2

2024-01-18 Thread Chen Qi via lists.openembedded.org
eftover from other processes.
->
-> The avenues available for reading the memory:
-> -  /dev/mem and /dev/kmem (requires root, not available with Secure Boot)
-> -  /proc/pid/mem (requires ptrace privileges, mediated by YAMA)
-> -  ptrace (requires ptrace privileges, mediated by YAMA)
-> -  causing memory to be swapped to disk, and then inspecting the swap
->
-> These all require a certain amount of privileges.
-
-How to fix it?
-~~
-
-memzero(), which internally calls explicit_bzero(3), or whatever
-alternative the system provides with a slightly different name, will
-make sure that the buffer is zeroed in memory, and optimizations are not
-allowed to impede this zeroing.
-
-This is not really 100% effective, since compilers may place copies of
-the string somewhere hidden in the stack.  Those copies won't get zeroed
-by explicit_bzero(3).  However, that's arguably a compiler bug, since
-compilers should make everything possible to avoid optimizing strings
-that are later passed to explicit_bzero(3).  But we all know that
-sometimes it's impossible to have perfect knowledge in the compiler, so
-this is plausible.  Nevertheless, there's nothing we can do against such
-issues, except minimizing the time such passwords are stored in plain
-text.
-
-Security concerns
-~
-
-We believe this isn't easy to exploit.  Nevertheless, and since the fix
-is trivial, this fix should probably be applied soon, and backported to
-all supported distributions, to prevent someone else having more
-imagination than us to find a way.
-
-Affected versions
-~
-
-All.  Bug introduced in shadow 19990709.  That's the second commit in
-the git history.
-
-Fixes: 45c6603cc86c ("[svn-upgrade] Integrating new upstream version, shadow 
(19990709)")
-
-CVE: CVE-2023-4641
-Upstream-Status: Backport 
[https://github.com/shadow-maint/shadow/commit/65c88a43a23c2391dcc90c0abda3e839e9c57904]
-
-Reported-by: Alejandro Colomar 
-Cc: Serge Hallyn 
-Cc: Iker Pedrosa 
-Cc: Seth Arnold 
-Cc: Christian Brauner 
-Cc: Balint Reczey 
-Cc: Sam James 
-Cc: David Runge 
-Cc: Andreas Jaeger 
-Cc: <~hallyn/sha...@lists.sr.ht>
-Signed-off-by: Alejandro Colomar 
-Signed-off-by: Xiangyu Chen 

- src/gpasswd.c | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/src/gpasswd.c b/src/gpasswd.c
-index 5983f787..2d8869ef 100644
 a/src/gpasswd.c
-+++ b/src/gpasswd.c
-@@ -896,6 +896,7 @@ static void change_passwd (struct group *gr)
-   strzero (cp);
-   cp = getpass (_("Re-enter new password: "));
-   if (NULL == cp) {
-+  memzero (pass, sizeof pass);
-   exit (1);
-   }
-
---
-2.34.1
-
diff --git 
a/meta/recipes-extended/shadow/files/commonio.c-fix-unexpected-open-failure-in-chroot-env.patch
 
b/meta/recipes-extended/shadow/files/commonio.c-fix-unexpected-open-failure-in-chroot-env.patch
index 85d91751056..4a932d2dbb1 100644
--- 
a/meta/recipes-extended/shadow/files/commonio.c-fix-unexpected-open-failure-in-chroot-env.patch
+++ 
b/meta/recipes-extended/shadow/files/commonio.c-fix-unexpected-open-failure-in-chroot-env.patch
@@ -1,4 +1,4 @@
-From 21583da072aa66901d859ac00ce209bac87ddecc Mon Sep 17 00:00:00 2001
+From a773c6b240d27e23d6be41decef0edf24fcee523 Mon Sep 17 00:00:00 2001
  From: Chen Qi 
  Date: Thu, 17 Jul 2014 15:53:34 +0800
  Subject: [PATCH] commonio.c-fix-unexpected-open-failure-in-chroot-env
@@ -15,35 +15,37 @@ Note that this patch doesn't change the logic in the code, 
it just expands
  the codes.
  
  Signed-off-by: Chen Qi 

-
  ---
   lib/commonio.c | 16 
   1 file changed, 12 insertions(+), 4 deletions(-)
  
  diff --git a/lib/commonio.c b/lib/commonio.c

-index 9a02ce1..61384ec 100644
+index 73fdb3a..d1231e9 100644
  --- a/lib/commonio.c
  +++ b/lib/commonio.c
-@@ -616,10 +616,18 @@ int commonio_open (struct commonio_db *db, int mode)
+@@ -606,10 +606,18 @@ int commonio_open (struct commonio_db *db, int mode)
db->cursor = NULL;
db->changed = false;
   
  -	fd = open (db->filename,

  -  (db->readonly ? O_RDONLY : O_RDWR)
-- | O_NOCTTY | O_NONBLOCK | O_NOFOLLOW);
+- | O_NOCTTY | O_NONBLOCK | O_NOFOLLOW | O_CLOEXEC);
  - saved_errno = errno;
  + if (db->readonly) {
  + fd = open (db->filename,
  +(true ? O_RDONLY : O_RDWR)
-+ | O_NOCTTY | O_NONBLOCK | O_NOFOLLOW);
++ | O_NOCTTY | O_NONBLOCK | O_NOFOLLOW | O_CLOEXEC);
  + saved_errno = errno;
  + } else {
  + fd = open (db->filename,
  +(false ? O_RDONLY : O_RDWR)
-+ | O_NOCTTY | O_NONBLOCK | O_NOFOLLOW);
++ | O_NOCTTY | O_NONBLOCK | O_NOFOLLOW| O_CLOEXEC);
  + saved_errno = errno;
  

Re: [OE-core] [PATCH 2/2] openssl: Fix ptest dependencies on perl-module-* being ignored by COMPLEMENTARY_GLOB

2024-01-16 Thread Chen Qi via lists.openembedded.org

Can we change the perl recipe to simply use 'RDEPENDS' for perl-modules?
I don't see what benefit the 'RRECOMMENDS' could give us.

Regards,
Qi


On 1/17/24 02:56, Tim Orling wrote:



On Tue, Jan 16, 2024 at 9:21 AM Alexander Kanavin 
 wrote:


How about simple depending on specific module packages? I don’t
think OpenSSL truly needs all modules.


Agreed. I don’t see a compelling reason to add the 
perl-modules-force-all complication. This will add confusion in my 
opinion.


Iterate the tests and add the required perl-module-* sub-packages one 
by one (or by inspection if the test cases)


In almost all cases, RDEPENDS on perl-modules is a short cut and 
should be avoided in favor of being explicit.



Alex

On Tue 16. Jan 2024 at 17.56, Lyu, William via
lists.openembedded.org


 wrote:

From: William Lyu 

Change the openssl-ptest RDEPENDS from perl-modules to
perl-modules-force-all which RDEPENDS on the same set of packages
perl-module-* recommended by perl-modules. So, when
openssl-ptest is
added via COMPLEMENTARY_GLOB "ptest-pkgs", its dependencies on
these
perl-module-* packages still get added.

Signed-off-by: William Lyu 
---
 meta/recipes-connectivity/openssl/openssl_3.2.0.bb


| 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git
a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb


b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb


index d041d2d214..7076bd3a7b 100644
--- a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb


+++ b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb


@@ -247,7 +247,7 @@ CONFFILES:openssl-conf =
"${sysconfdir}/ssl/openssl.cnf"

 RRECOMMENDS:libcrypto += "openssl-conf ${PN}-ossl-module-legacy"
 RDEPENDS:${PN}-misc = "perl"
-RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
+RDEPENDS:${PN}-ptest += "openssl-bin perl
perl-modules-force-all bash sed"

 RDEPENDS:${PN}-bin += "openssl-conf"

-- 
2.43.0












-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193888): 
https://lists.openembedded.org/g/openembedded-core/message/193888
Mute This Topic: https://lists.openembedded.org/mt/103766390/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] kernel-devsrc: copy source files under tools/

2024-01-11 Thread Chen Qi via lists.openembedded.org

On 1/12/24 11:22, Bruce Ashfield wrote:

On Thu, Jan 11, 2024 at 10:12 PM ChenQi  wrote:

On 1/12/24 10:50, Bruce Ashfield wrote:

On Thu, Jan 11, 2024 at 9:44 PM Chen Qi via lists.openembedded.org
 wrote:

From: Chen Qi 

The source files under tools/ also need to be copied because in
some case, they'll be needed. For example, in case that the
CONFIG_DEBUG_INFO_BTF is enabled, we'll get the following error
without this patch when doing 'make prepare'.

No rule to make target '/.../tools/bpf/resolve_btfids/main.o',
needed by '/.../tools/bpf/resolve_btfids/resolve_btfids-in.o'. Stop.


Tools has been excluded on purpose, as it is relatively large
(and complex) compared to the rest of the curated files.

Figure out just what you need for bpf, and copy only those
files.

Bruce

I can do that. However, I want to raise my concern here first. Does the
30M really matter, compared to the potential errors that would possibly
give users bad impression?

Yes, it actually does matter.

That's the entire design principle behind devsrc. It is carefully curated.

Considering something like this pops up every couple of years, I'm
quite confident that there are very few bad impressions to be made.

As you could see from the file that there are many specific copies from
the tools/ directory structure. That should be the hint that if we wanted
to copy tools in its entirety .. we would have done that long ago.


Before enabling CONFIG_DEBUG_INFO_BTF, things were working pretty well
for us. In fact, I was a little surprised that adding extra configs
would result in failure of 'make prepare'.

Not sure if CONFIG_DEBUG_INFO_BTF is the last one. I guess it's probably
not.

Again, if users are using kernel-devsrc for compiling things, do they
really care about the 30M size?

It's not relevant if they do or don't care. It is the principle of keeping it
as minimal as possible and not doing things "just in case".

There's a bugzilla that I've attached a patch that creates a parallel
full source copy of the kernel, but we've never merged it as keeping
to the low footprint design principle is important.

Bruce


Got it. Thanks for the info.

Regards,

Qi


Regards,

Qi



Signed-off-by: Chen Qi 
---
   meta/recipes-kernel/linux/kernel-devsrc.bb | 1 +
   1 file changed, 1 insertion(+)

diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb 
b/meta/recipes-kernel/linux/kernel-devsrc.bb
index ce5777fbe9..c2aeb8e216 100644
--- a/meta/recipes-kernel/linux/kernel-devsrc.bb
+++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
@@ -62,6 +62,7 @@ do_install() {
  cd ${S}
  cp --parents $(find  -type f -name "Makefile*" -o -name "Kconfig*") 
$kerneldir/build
  cp --parents $(find  -type f -name "Build" -o -name "Build.include") 
$kerneldir/build
+   cp --parents $(find tools/  -type f -name "*.c" -o -name "*.h") 
$kerneldir/build
   )

   # then drop all but the needed Makefiles/Kconfig files
--
2.34.1









-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193568): 
https://lists.openembedded.org/g/openembedded-core/message/193568
Mute This Topic: https://lists.openembedded.org/mt/103676210/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] kernel-devsrc: copy source files under tools/

2024-01-11 Thread Chen Qi via lists.openembedded.org

On 1/12/24 10:50, Bruce Ashfield wrote:

On Thu, Jan 11, 2024 at 9:44 PM Chen Qi via lists.openembedded.org
 wrote:

From: Chen Qi 

The source files under tools/ also need to be copied because in
some case, they'll be needed. For example, in case that the
CONFIG_DEBUG_INFO_BTF is enabled, we'll get the following error
without this patch when doing 'make prepare'.

   No rule to make target '/.../tools/bpf/resolve_btfids/main.o',
   needed by '/.../tools/bpf/resolve_btfids/resolve_btfids-in.o'. Stop.


Tools has been excluded on purpose, as it is relatively large
(and complex) compared to the rest of the curated files.

Figure out just what you need for bpf, and copy only those
files.

Bruce


I can do that. However, I want to raise my concern here first. Does the 
30M really matter, compared to the potential errors that would possibly 
give users bad impression?


Before enabling CONFIG_DEBUG_INFO_BTF, things were working pretty well 
for us. In fact, I was a little surprised that adding extra configs 
would result in failure of 'make prepare'.


Not sure if CONFIG_DEBUG_INFO_BTF is the last one. I guess it's probably 
not.


Again, if users are using kernel-devsrc for compiling things, do they 
really care about the 30M size?


Regards,

Qi



Signed-off-by: Chen Qi 
---
  meta/recipes-kernel/linux/kernel-devsrc.bb | 1 +
  1 file changed, 1 insertion(+)

diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb 
b/meta/recipes-kernel/linux/kernel-devsrc.bb
index ce5777fbe9..c2aeb8e216 100644
--- a/meta/recipes-kernel/linux/kernel-devsrc.bb
+++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
@@ -62,6 +62,7 @@ do_install() {
 cd ${S}
 cp --parents $(find  -type f -name "Makefile*" -o -name "Kconfig*") 
$kerneldir/build
 cp --parents $(find  -type f -name "Build" -o -name "Build.include") 
$kerneldir/build
+   cp --parents $(find tools/  -type f -name "*.c" -o -name "*.h") 
$kerneldir/build
  )

  # then drop all but the needed Makefiles/Kconfig files
--
2.34.1









-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193566): 
https://lists.openembedded.org/g/openembedded-core/message/193566
Mute This Topic: https://lists.openembedded.org/mt/103676210/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH] kernel-devsrc: copy source files under tools/

2024-01-11 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

The source files under tools/ also need to be copied because in
some case, they'll be needed. For example, in case that the
CONFIG_DEBUG_INFO_BTF is enabled, we'll get the following error
without this patch when doing 'make prepare'.

  No rule to make target '/.../tools/bpf/resolve_btfids/main.o',
  needed by '/.../tools/bpf/resolve_btfids/resolve_btfids-in.o'. Stop.

Signed-off-by: Chen Qi 
---
 meta/recipes-kernel/linux/kernel-devsrc.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb 
b/meta/recipes-kernel/linux/kernel-devsrc.bb
index ce5777fbe9..c2aeb8e216 100644
--- a/meta/recipes-kernel/linux/kernel-devsrc.bb
+++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
@@ -62,6 +62,7 @@ do_install() {
cd ${S}
cp --parents $(find  -type f -name "Makefile*" -o -name "Kconfig*") 
$kerneldir/build
cp --parents $(find  -type f -name "Build" -o -name "Build.include") 
$kerneldir/build
+   cp --parents $(find tools/  -type f -name "*.c" -o -name "*.h") 
$kerneldir/build
 )
 
 # then drop all but the needed Makefiles/Kconfig files
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193563): 
https://lists.openembedded.org/g/openembedded-core/message/193563
Mute This Topic: https://lists.openembedded.org/mt/103676210/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH 1/3] systemd: upgrade to 255.1

2024-01-09 Thread Chen Qi via lists.openembedded.org
I just sent out a patch for the yocto-autobuilder-helper repo to use '/root' as 
the ROOT_HOME's value in case of 'sysvinit with systemd'.

Regards,
Qi

-Original Message-
From: Alexandre Belloni  
Sent: Tuesday, January 9, 2024 3:47 PM
To: Chen, Qi 
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 1/3] systemd: upgrade to 255.1

I got this today:

https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/8420/steps/25/logs/stdio

WARNING: systemd-1_255.1-r0 do_install: Using /home/root as root user's home 
directory is not fully supported by systemd

On 07/01/2024 14:05:35+, Chen Qi via lists.openembedded.org wrote:
> Another patch in this series fixes the warning:
> rootfs-postcommands.bbclass: ignore comment mismatch in 
> systemd_user_check
> 
> Is that patch also staged?
> 
> Regards,
> Qi
> 
> -Original Message-
> From: Alexandre Belloni 
> Sent: Saturday, January 6, 2024 12:02 AM
> To: Chen, Qi 
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core][PATCH 1/3] systemd: upgrade to 255.1
> 
> Hello,
> 
> This fails with:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/736
> 1/steps/12/logs/warnings
> 
> WARNING: core-image-full-cmdline-1.0-r0 do_rootfs: User root has been 
> defined as (root, 0, 0, root, /root, /bin/sh) but sysusers.d expects 
> it as (root, 0, 0, Super User, /root, -)
> WARNING: core-image-full-cmdline-1.0-r0 do_rootfs: User nobody has 
> been defined as (nobody, 65534, 65534, nobody, /nonexistent, 
> /usr/sbin/nologin) but sysusers.d expects it as (nobody, 65534, 65534, 
> Kernel Overflow User, -, -)
> WARNING: core-image-sato-1.0-r0 do_rootfs: User root has been defined 
> as (root, 0, 0, root, /root, /bin/sh) but sysusers.d expects it as 
> (root, 0, 0, Super User, /root, -)
> WARNING: core-image-sato-1.0-r0 do_rootfs: User nobody has been 
> defined as (nobody, 65534, 65534, nobody, /nonexistent, 
> /usr/sbin/nologin) but sysusers.d expects it as (nobody, 65534, 65534, 
> Kernel Overflow User, -, -)
> WARNING: core-image-sato-sdk-1.0-r0 do_rootfs: User root has been 
> defined as (root, 0, 0, root, /root, /bin/sh) but sysusers.d expects 
> it as (root, 0, 0, Super User, /root, -)
> WARNING: core-image-sato-sdk-1.0-r0 do_rootfs: User nobody has been 
> defined as (nobody, 65534, 65534, nobody, /nonexistent, 
> /usr/sbin/nologin) but sysusers.d expects it as (nobody, 65534, 65534, 
> Kernel Overflow User, -, -)
> 
> On 27/12/2023 12:20:34+0800, Chen Qi via lists.openembedded.org wrote:
> > From: Chen Qi 
> > 
> > 1. Patch changes:
> > 
> > 0004-Move-sysusers.d-sysctl.d-binfmt.d-modules-load.d-to-.patch
> > is removed because it has no real effect now. The /lib is now 
> > /usr/lib because 'usrmerge' is a required distro feature for systemd.
> > 
> > 0002-binfmt-Don-t-install-dependency-links-at-install-tim.patch is 
> > refreshed for the new version to avoid patch-fuzz issue.
> > 
> > 2. root user's home directory now defaults to "/root":
> > 
> > The sysuers.d/basic.conf is still modified to respect the ROOT_HOME 
> > value, so if users set ROOT_HOME to "/home/root", the behavior is 
> > the same as before. However, this is only for backward 
> > compatibility. With this patch, The ROOT_HOME value is set to "/root" in 
> > init-manager-systemd.inc.
> > This is because systemd's source codes are hardcoding "/root", and 
> > other values are not officially supported. See the list below.
> > $ grep -rl '"/root"' src/ | grep -v 'src/test'
> > src/core/namespace.c
> > src/basic/user-util.c
> > src/nss-systemd/nss-systemd.c
> > src/nspawn/nspawn.c
> > src/firstboot/firstboot.c
> > src/shared/userdb.c
> > src/shared/user-record.c
> > $ grep -rl /root network/ factory/ sysctl.d/ sysusers.d/ rules.d/ 
> > tmpfiles.d/ units/ xorg/ tools/ sysusers.d/basic.conf.in 
> > tmpfiles.d/provision.conf units/emergency.service.in 
> > units/rescue.service.in tools/list-discoverable-partitions.py
> > Previously, the recipe was just substituting 
> > sysusers.d/basic.conf.in, which is not enough to be treated as 
> > 'fully support'. I deliberately put a warning message in do_install to warn 
> > users about non "/root"
> > ROOT_HOME value. Don't remove it until all above places are handled.
> > 
> > 3. cgroupv2 is now the default.
> > cgroupv2 is the default for systemd for many years and it's the 
> > default for distros such as ubuntu and fedora. Let's also use it as the 
&

Re: [OE-core][PATCH 1/3] systemd: upgrade to 255.1

2024-01-07 Thread Chen Qi via lists.openembedded.org
Another patch in this series fixes the warning:
rootfs-postcommands.bbclass: ignore comment mismatch in systemd_user_check

Is that patch also staged?

Regards,
Qi

-Original Message-
From: Alexandre Belloni  
Sent: Saturday, January 6, 2024 12:02 AM
To: Chen, Qi 
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 1/3] systemd: upgrade to 255.1

Hello,

This fails with:

https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/7361/steps/12/logs/warnings

WARNING: core-image-full-cmdline-1.0-r0 do_rootfs: User root has been defined 
as (root, 0, 0, root, /root, /bin/sh) but sysusers.d expects it as (root, 0, 0, 
Super User, /root, -)
WARNING: core-image-full-cmdline-1.0-r0 do_rootfs: User nobody has been defined 
as (nobody, 65534, 65534, nobody, /nonexistent, /usr/sbin/nologin) but 
sysusers.d expects it as (nobody, 65534, 65534, Kernel Overflow User, -, -)
WARNING: core-image-sato-1.0-r0 do_rootfs: User root has been defined as (root, 
0, 0, root, /root, /bin/sh) but sysusers.d expects it as (root, 0, 0, Super 
User, /root, -)
WARNING: core-image-sato-1.0-r0 do_rootfs: User nobody has been defined as 
(nobody, 65534, 65534, nobody, /nonexistent, /usr/sbin/nologin) but sysusers.d 
expects it as (nobody, 65534, 65534, Kernel Overflow User, -, -)
WARNING: core-image-sato-sdk-1.0-r0 do_rootfs: User root has been defined as 
(root, 0, 0, root, /root, /bin/sh) but sysusers.d expects it as (root, 0, 0, 
Super User, /root, -)
WARNING: core-image-sato-sdk-1.0-r0 do_rootfs: User nobody has been defined as 
(nobody, 65534, 65534, nobody, /nonexistent, /usr/sbin/nologin) but sysusers.d 
expects it as (nobody, 65534, 65534, Kernel Overflow User, -, -)

On 27/12/2023 12:20:34+0800, Chen Qi via lists.openembedded.org wrote:
> From: Chen Qi 
> 
> 1. Patch changes:
> 
> 0004-Move-sysusers.d-sysctl.d-binfmt.d-modules-load.d-to-.patch
> is removed because it has no real effect now. The /lib is now /usr/lib 
> because 'usrmerge' is a required distro feature for systemd.
> 
> 0002-binfmt-Don-t-install-dependency-links-at-install-tim.patch is 
> refreshed for the new version to avoid patch-fuzz issue.
> 
> 2. root user's home directory now defaults to "/root":
> 
> The sysuers.d/basic.conf is still modified to respect the ROOT_HOME 
> value, so if users set ROOT_HOME to "/home/root", the behavior is the 
> same as before. However, this is only for backward compatibility. With 
> this patch, The ROOT_HOME value is set to "/root" in init-manager-systemd.inc.
> This is because systemd's source codes are hardcoding "/root", and 
> other values are not officially supported. See the list below.
> $ grep -rl '"/root"' src/ | grep -v 'src/test'
> src/core/namespace.c
> src/basic/user-util.c
> src/nss-systemd/nss-systemd.c
> src/nspawn/nspawn.c
> src/firstboot/firstboot.c
> src/shared/userdb.c
> src/shared/user-record.c
> $ grep -rl /root network/ factory/ sysctl.d/ sysusers.d/ rules.d/ 
> tmpfiles.d/ units/ xorg/ tools/ sysusers.d/basic.conf.in 
> tmpfiles.d/provision.conf units/emergency.service.in 
> units/rescue.service.in tools/list-discoverable-partitions.py
> Previously, the recipe was just substituting sysusers.d/basic.conf.in, 
> which is not enough to be treated as 'fully support'. I deliberately 
> put a warning message in do_install to warn users about non "/root" 
> ROOT_HOME value. Don't remove it until all above places are handled.
> 
> 3. cgroupv2 is now the default.
> cgroupv2 is the default for systemd for many years and it's the 
> default for distros such as ubuntu and fedora. Let's also use it as the 
> default.
> 
> Signed-off-by: Chen Qi 
> ---
>  .../distro/include/init-manager-systemd.inc   |  2 +
>  meta/recipes-core/systemd/systemd.inc |  4 +-
>  ...tall-dependency-links-at-install-tim.patch | 22 +++---  
> ...sysctl.d-binfmt.d-modules-load.d-to-.patch | 73 ---
>  .../systemd/systemd/basic.conf.in | 40 --
>  .../{systemd_254.4.bb => systemd_255.1.bb}| 16 ++--
>  6 files changed, 25 insertions(+), 132 deletions(-)  delete mode 
> 100644 
> meta/recipes-core/systemd/systemd/0004-Move-sysusers.d-sysctl.d-binfmt
> .d-modules-load.d-to-.patch  delete mode 100644 
> meta/recipes-core/systemd/systemd/basic.conf.in
>  rename meta/recipes-core/systemd/{systemd_254.4.bb => 
> systemd_255.1.bb} (98%)
> 
> diff --git a/meta/conf/distro/include/init-manager-systemd.inc 
> b/meta/conf/distro/include/init-manager-systemd.inc
> index 595d1f2644..0a76647459 100644
> --- a/meta/conf/distro/include/init-manager-systemd.inc
> +++ b/meta/conf/distro/include/init-manager-systemd.inc
> @@ -5,3 +5,5 @@ VIRTUAL-RUNTIME_init_mana

Re: [OE-core][PATCH] debugedit: add UPSTREAM_CHECK settings

2024-01-03 Thread Chen Qi via lists.openembedded.org

On 1/3/24 16:28, Alexander Kanavin wrote:

On Wed, 3 Jan 2024 at 08:45, Chen Qi via lists.openembedded.org
 wrote:

On 1/3/24 15:21, Alexander Kanavin via lists.openembedded.org wrote:

This works as expected. What made you think it’s broken and needs changing?

The 404 ERROR that 'devtool check-ugprade-status' prints out to me 
unconditionally, which is all upper case to catch people's notice and can't be 
avoided by any option.

The version check detects if the tarball is in a versioned directory,
and if so, it goes one level up, and tries to list all subdirectories
from there, attempting to find a newer tarball. So the real issue is,
why is it trying to go into a non-existent 'sha512' directory? There's
a sha512.sum file in here:
https://sourceware.org/ftp/debugedit/
but it's a file.

If this patch is applied, on the other hand, it would only check the
names of those versioned directories, and not the actual tarballs.
Which could produce bogus results if for example 5.0/ directory would
contain 5.0.0, 5.0.1, etc tarballs.

Sounds reasonable.


It would also help to suppress the noisy output from wget altogether
by default, but last time I looked into it, it turned into invasive
changes at the heart of bitbake logging, so I abandoned the attempt.

Alex


Thanks for the info.

Regards,

Qi


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193278): 
https://lists.openembedded.org/g/openembedded-core/message/193278
Mute This Topic: https://lists.openembedded.org/mt/103478272/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] debugedit: add UPSTREAM_CHECK settings

2024-01-02 Thread Chen Qi via lists.openembedded.org

On 1/3/24 15:21, Alexander Kanavin via lists.openembedded.org wrote:
This works as expected. What made you think it’s broken and needs 
changing?


The 404 ERROR that 'devtool check-ugprade-status' prints out to me 
unconditionally, which is all upper case to catch people's notice and 
can't be avoided by any option.




Alex

On Wed 3. Jan 2024 at 3.47, ChenQi  wrote:

On 1/3/24 00:54, Alexander Kanavin wrote:
> The check already works, at least for me it correctly checks
both the
> top level directory and the 'latest' directory:
> ...
> --2024-01-02 16:51:30-- https://sourceware.org/ftp/debugedit/
> ...
> --2024-01-02 16:51:30-- https://sourceware.org/ftp/debugedit/5.0/
> ...
> INFO: debugedit                 5.0             MATCH          Chen
> Qi 
>
> What does devtool output for you, without the patch?
>
> Alex

The command and output are as below. Pure poky master. No local
patches.

$ devtool check-upgrade-status debugedit
NOTE: Starting bitbake server...
NOTE: Reconnecting to bitbake server...
NOTE: Retrying server connection (#1)... (18:44:43.533538)
Loading cache: 100%

|###|

Time: 0:00:00
Loaded 1848 entries from dependency cache.
--2024-01-02 18:44:46-- https://sourceware.org/ftp/debugedit/
Resolving sourceware.org <http://sourceware.org> (sourceware.org
<http://sourceware.org>)... 8.43.85.97,
2620:52:3:1:0:246e:9693:128c
Connecting to sourceware.org <http://sourceware.org>
(sourceware.org <http://sourceware.org>)|8.43.85.97|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 2602 (2.5K) [text/html]
Saving to: ‘/tmp/wget-index-e1dsj90e/wget-listing-vrofeac4’


2024-01-02 18:44:46 (330 MB/s) -
‘/tmp/wget-index-e1dsj90e/wget-listing-vrofeac4’ saved [2602/2602]

--2024-01-02 18:44:46-- https://sourceware.org/ftp/debugedit/5.0/
Resolving sourceware.org <http://sourceware.org> (sourceware.org
<http://sourceware.org>)... 8.43.85.97,
2620:52:3:1:0:246e:9693:128c
Connecting to sourceware.org <http://sourceware.org>
(sourceware.org <http://sourceware.org>)|8.43.85.97|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1353 (1.3K) [text/html]
Saving to: ‘/tmp/wget-index-qwu98rgj/wget-listing-8esd1gn0’


2024-01-02 18:44:47 (179 MB/s) -
‘/tmp/wget-index-qwu98rgj/wget-listing-8esd1gn0’ saved [1353/1353]

--2024-01-02 18:44:47-- https://sourceware.org/ftp/debugedit/sha512/
Resolving sourceware.org <http://sourceware.org> (sourceware.org
<http://sourceware.org>)... 8.43.85.97,
2620:52:3:1:0:246e:9693:128c
Connecting to sourceware.org <http://sourceware.org>
(sourceware.org <http://sourceware.org>)|8.43.85.97|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-01-02 18:44:47 ERROR 404: Not Found.


    >
> On Tue, 2 Jan 2024 at 09:38, Chen Qi via lists.openembedded.org
<http://lists.openembedded.org>
>  wrote:
    >> From: Chen Qi 
>>
>> Add UPSTREAM_CHECK_URI(REGEX) to allow for checking new releases
>> for debugedit recipe.
>>
>> Signed-off-by: Chen Qi 
>> ---
>>   meta/recipes-devtools/debugedit/debugedit_5.0.bb
<http://debugedit_5.0.bb> | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/meta/recipes-devtools/debugedit/debugedit_5.0.bb
<http://debugedit_5.0.bb>
b/meta/recipes-devtools/debugedit/debugedit_5.0.bb
<http://debugedit_5.0.bb>
>> index 63ad7babd9..3a596f5fea 100644
>> --- a/meta/recipes-devtools/debugedit/debugedit_5.0.bb
<http://debugedit_5.0.bb>
>> +++ b/meta/recipes-devtools/debugedit/debugedit_5.0.bb
<http://debugedit_5.0.bb>
>> @@ -9,6 +9,9 @@ LIC_FILES_CHKSUM =
"file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
>> file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1 \
>> file://COPYING3;md5=d32239bcb673463ab874e80d47fae504"
>>
>> +UPSTREAM_CHECK_URI = "https://sourceware.org/ftp/debugedit/";
>> +UPSTREAM_CHECK_REGEX = "(?P(\d\.\d))/"
>> +
>>   SRC_URI =
"https://sourceware.org/ftp/debugedit/${PV}/debugedit-${PV}.tar.xz
<https://sourceware.org/ftp/debugedit/$%7BPV%7D/debugedit-$%7BPV%7D.tar.xz>"
>>
>>   SRC_URI:append:libc-musl = "\
>> --
>> 2.34.1
>>
>>
>>
>>





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193273): 
https://lists.openembedded.org/g/openembedded-core/message/193273
Mute This Topic: https://lists.openembedded.org/mt/103478272/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 3/3] sudo: upgrade from 1.9.15p2 to 1.9.15p5

2024-01-02 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Signed-off-by: Chen Qi 
---
 .../sudo/{sudo_1.9.15p2.bb => sudo_1.9.15p5.bb} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-extended/sudo/{sudo_1.9.15p2.bb => sudo_1.9.15p5.bb} (96%)

diff --git a/meta/recipes-extended/sudo/sudo_1.9.15p2.bb 
b/meta/recipes-extended/sudo/sudo_1.9.15p5.bb
similarity index 96%
rename from meta/recipes-extended/sudo/sudo_1.9.15p2.bb
rename to meta/recipes-extended/sudo/sudo_1.9.15p5.bb
index 431dfba3c2..8e542015ad 100644
--- a/meta/recipes-extended/sudo/sudo_1.9.15p2.bb
+++ b/meta/recipes-extended/sudo/sudo_1.9.15p5.bb
@@ -7,7 +7,7 @@ SRC_URI = "https://www.sudo.ws/dist/sudo-${PV}.tar.gz \
 
 PAM_SRC_URI = "file://sudo.pam"
 
-SRC_URI[sha256sum] = 
"199c0cdbfa7efcfffa9c88684a8e2fb206a62b70a316507e4a91c89c873bbcc8"
+SRC_URI[sha256sum] = 
"558d10b9a1991fb3b9fa7fa7b07ec4405b7aefb5b3cb0b0871dbc81e3a88e558"
 
 DEPENDS += " virtual/crypt ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 
'libpam', '', d)}"
 RDEPENDS:${PN} += " ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 
'pam-plugin-limits pam-plugin-keyinit', '', d)}"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193271): 
https://lists.openembedded.org/g/openembedded-core/message/193271
Mute This Topic: https://lists.openembedded.org/mt/103497078/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 1/3] util-linux/util-linux-libuuid: ugprade from 2.39.2 to 2.39.3

2024-01-02 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

License-Update:
===
GPL-1.0-or-later is added. fdisk.c is licensed under it.

0001-lscpu-Use-4K-buffer-size-instead-of-BUFSIZ.patch is dropped as
it's been in the new version.

Signed-off-by: Chen Qi 
---
 ...2.39.2.bb => util-linux-libuuid_2.39.3.bb} |  0
 meta/recipes-core/util-linux/util-linux.inc   |  8 ++--
 ...ls-include-libgen.h-for-basename-API.patch |  9 +++--
 ...Use-4K-buffer-size-instead-of-BUFSIZ.patch | 38 ---
 .../util-linux/avoid_parallel_tests.patch |  4 +-
 .../util-linux/configure-sbindir.patch| 19 +++---
 .../display_testname_for_subtest.patch| 12 +++---
 .../util-linux/util-linux/ptest.patch |  4 +-
 ...l-linux_2.39.2.bb => util-linux_2.39.3.bb} |  0
 9 files changed, 34 insertions(+), 60 deletions(-)
 rename meta/recipes-core/util-linux/{util-linux-libuuid_2.39.2.bb => 
util-linux-libuuid_2.39.3.bb} (100%)
 delete mode 100644 
meta/recipes-core/util-linux/util-linux/0001-lscpu-Use-4K-buffer-size-instead-of-BUFSIZ.patch
 rename meta/recipes-core/util-linux/{util-linux_2.39.2.bb => 
util-linux_2.39.3.bb} (100%)

diff --git a/meta/recipes-core/util-linux/util-linux-libuuid_2.39.2.bb 
b/meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb
similarity index 100%
rename from meta/recipes-core/util-linux/util-linux-libuuid_2.39.2.bb
rename to meta/recipes-core/util-linux/util-linux-libuuid_2.39.3.bb
diff --git a/meta/recipes-core/util-linux/util-linux.inc 
b/meta/recipes-core/util-linux/util-linux.inc
index e3bef5acfc..4e9d22f269 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -6,13 +6,14 @@ disk partitioning, kernel message management, filesystem 
creation, and system lo
 
 SECTION = "base"
 
-LICENSE = "GPL-2.0-or-later & LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause 
& BSD-4-Clause"
+LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & 
BSD-2-Clause & BSD-3-Clause & BSD-4-Clause"
+LICENSE:${PN}-fdisk = "GPL-1.0-or-later"
 LICENSE:${PN}-libblkid = "LGPL-2.1-or-later"
 LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
 LICENSE:${PN}-libmount = "LGPL-2.1-or-later"
 LICENSE:${PN}-libsmartcols = "LGPL-2.1-or-later"
 
-LIC_FILES_CHKSUM = 
"file://README.licensing;md5=12ae7768a65ec8f2e44d930df9cb43fa \
+LIC_FILES_CHKSUM = 
"file://README.licensing;md5=6b0e0a2320e66e62eef9b8149a6faec4 \
 file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
 
file://Documentation/licenses/COPYING.GPL-2.0-or-later;md5=b234ee4d69f5fce4486a80fdaf4a4263
 \
 
file://Documentation/licenses/COPYING.LGPL-2.1-or-later;md5=4fbd65380cdd255951079008b364516c
 \
@@ -35,8 +36,7 @@ SRC_URI = 
"${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-lin
file://run-ptest \
file://display_testname_for_subtest.patch \
file://avoid_parallel_tests.patch \
-   file://0001-lscpu-Use-4K-buffer-size-instead-of-BUFSIZ.patch \
file://0001-login-utils-include-libgen.h-for-basename-API.patch \
"
 
-SRC_URI[sha256sum] = 
"87abdfaa8e490f8be6dde976f7c80b9b5ff9f301e1b67e3899e1f05a59a1531f"
+SRC_URI[sha256sum] = 
"7b6605e48d1a49f43cc4b4cfc59f313d0dd5402fa40b96810bd572e167dfed0f"
diff --git 
a/meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
 
b/meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
index 2b9897ade1..6258710e1e 100644
--- 
a/meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
+++ 
b/meta/recipes-core/util-linux/util-linux/0001-login-utils-include-libgen.h-for-basename-API.patch
@@ -1,4 +1,4 @@
-From 6581cf8ac95b99b5a35fea88c52646558d05b5e7 Mon Sep 17 00:00:00 2001
+From d44e3ad1f6f8b5c1b3098bb7d537943a4c21d22f Mon Sep 17 00:00:00 2001
 From: Khem Raj 
 Date: Sun, 3 Dec 2023 19:59:46 -0800
 Subject: [PATCH] login-utils: include libgen.h for basename API
@@ -17,10 +17,13 @@ Fixes
 
 Upstream-Status: Submitted [https://github.com/util-linux/util-linux/pull/2615]
 Signed-off-by: Khem Raj 
+
 ---
- login-utils/su-common.c | 8 ++--
- 1 file changed, 6 insertions(+), 2 deletions(-)
+ login-utils/su-common.c | 10 +++---
+ 1 file changed, 7 insertions(+), 3 deletions(-)
 
+diff --git a/login-utils/su-common.c b/login-utils/su-common.c
+index b674920..3297c78 100644
 --- a/login-utils/su-common.c
 +++ b/login-utils/su-common.c
 @@ -26,6 +26,7 @@
diff --git 
a/meta/recipes-core/util-linux/util-linux/0001-lscpu-Use-4K-buffer-size-instead-of-BUFSIZ.patch
 
b/meta/recipes-core/util-linux/util-linux/0001-lscpu-Use-4K-buffer-size-instead-of-BUFSIZ.patch
deleted file mode 100644
index 4d7487c4f7..00
--- 
a/meta/recipes-core/util-linux/util-l

[OE-core][PATCH 2/3] dbus-wait: bump srcrev

2024-01-02 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

This upgrade only includes one new commit:
64bc7c8 SECURITY.md: Add file

Signed-off-by: Chen Qi 
---
 meta/recipes-core/dbus-wait/dbus-wait_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/dbus-wait/dbus-wait_git.bb 
b/meta/recipes-core/dbus-wait/dbus-wait_git.bb
index 1cdf07d03d..39363b9b3a 100644
--- a/meta/recipes-core/dbus-wait/dbus-wait_git.bb
+++ b/meta/recipes-core/dbus-wait/dbus-wait_git.bb
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 DEPENDS = "dbus"
 
-SRCREV = "6cc6077a36fe2648a5f993fe7c16c9632f946517"
+SRCREV = "64bc7c8fae61ded0c4e555aa775911f84c56e438"
 PV = "0.1+git"
 
 SRC_URI = "git://git.yoctoproject.org/${BPN};branch=master;protocol=https"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193269): 
https://lists.openembedded.org/g/openembedded-core/message/193269
Mute This Topic: https://lists.openembedded.org/mt/103497076/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] debugedit: add UPSTREAM_CHECK settings

2024-01-02 Thread Chen Qi via lists.openembedded.org

On 1/3/24 00:54, Alexander Kanavin wrote:

The check already works, at least for me it correctly checks both the
top level directory and the 'latest' directory:
...
--2024-01-02 16:51:30--  https://sourceware.org/ftp/debugedit/
...
--2024-01-02 16:51:30--  https://sourceware.org/ftp/debugedit/5.0/
...
INFO: debugedit 5.0 MATCH       Chen
Qi 

What does devtool output for you, without the patch?

Alex


The command and output are as below. Pure poky master. No local patches.

$ devtool check-upgrade-status debugedit
NOTE: Starting bitbake server...
NOTE: Reconnecting to bitbake server...
NOTE: Retrying server connection (#1)... (18:44:43.533538)
Loading cache: 100% 
|###| 
Time: 0:00:00

Loaded 1848 entries from dependency cache.
--2024-01-02 18:44:46--  https://sourceware.org/ftp/debugedit/
Resolving sourceware.org (sourceware.org)... 8.43.85.97, 
2620:52:3:1:0:246e:9693:128c

Connecting to sourceware.org (sourceware.org)|8.43.85.97|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 2602 (2.5K) [text/html]
Saving to: ‘/tmp/wget-index-e1dsj90e/wget-listing-vrofeac4’


2024-01-02 18:44:46 (330 MB/s) - 
‘/tmp/wget-index-e1dsj90e/wget-listing-vrofeac4’ saved [2602/2602]


--2024-01-02 18:44:46--  https://sourceware.org/ftp/debugedit/5.0/
Resolving sourceware.org (sourceware.org)... 8.43.85.97, 
2620:52:3:1:0:246e:9693:128c

Connecting to sourceware.org (sourceware.org)|8.43.85.97|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1353 (1.3K) [text/html]
Saving to: ‘/tmp/wget-index-qwu98rgj/wget-listing-8esd1gn0’


2024-01-02 18:44:47 (179 MB/s) - 
‘/tmp/wget-index-qwu98rgj/wget-listing-8esd1gn0’ saved [1353/1353]


--2024-01-02 18:44:47-- https://sourceware.org/ftp/debugedit/sha512/
Resolving sourceware.org (sourceware.org)... 8.43.85.97, 
2620:52:3:1:0:246e:9693:128c

Connecting to sourceware.org (sourceware.org)|8.43.85.97|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-01-02 18:44:47 ERROR 404: Not Found.




On Tue, 2 Jan 2024 at 09:38, Chen Qi via lists.openembedded.org
 wrote:

From: Chen Qi 

Add UPSTREAM_CHECK_URI(REGEX) to allow for checking new releases
for debugedit recipe.

Signed-off-by: Chen Qi 
---
  meta/recipes-devtools/debugedit/debugedit_5.0.bb | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/meta/recipes-devtools/debugedit/debugedit_5.0.bb 
b/meta/recipes-devtools/debugedit/debugedit_5.0.bb
index 63ad7babd9..3a596f5fea 100644
--- a/meta/recipes-devtools/debugedit/debugedit_5.0.bb
+++ b/meta/recipes-devtools/debugedit/debugedit_5.0.bb
@@ -9,6 +9,9 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
  file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1 \
  file://COPYING3;md5=d32239bcb673463ab874e80d47fae504"

+UPSTREAM_CHECK_URI = "https://sourceware.org/ftp/debugedit/";
+UPSTREAM_CHECK_REGEX = "(?P(\d\.\d))/"
+
  SRC_URI = "https://sourceware.org/ftp/debugedit/${PV}/debugedit-${PV}.tar.xz";

  SRC_URI:append:libc-musl = "\
--
2.34.1







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193263): 
https://lists.openembedded.org/g/openembedded-core/message/193263
Mute This Topic: https://lists.openembedded.org/mt/103478272/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH] devtool: use straight print in check-upgrade-status output

2024-01-02 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

'devtool check-upgrade-status' is for reporting upgradable
status for recipes. The output should always be printed out. So
we should just use 'print' instead of 'logger.info' as the latter
will be suppressed if '-q' parameter is supplied to devtool.

Signed-off-by: Chen Qi 
---
 scripts/lib/devtool/upgrade.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/devtool/upgrade.py b/scripts/lib/devtool/upgrade.py
index a98370bc10..ef58523dc8 100644
--- a/scripts/lib/devtool/upgrade.py
+++ b/scripts/lib/devtool/upgrade.py
@@ -631,7 +631,7 @@ def check_upgrade_status(args, config, basepath, workspace):
 for result in results:
 # pn, update_status, current, latest, maintainer, latest_commit, 
no_update_reason
 if args.all or result[1] != 'MATCH':
-logger.info("{:25} {:15} {:15} {} {} {}".format(   result[0],
+print("{:25} {:15} {:15} {} {} {}".format(   result[0],
result[2],
result[1] if 
result[1] != 'UPDATE' else (result[3] if not 
result[3].endswith("new-commits-available") else "new commits"),
result[4],
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193221): 
https://lists.openembedded.org/g/openembedded-core/message/193221
Mute This Topic: https://lists.openembedded.org/mt/103478277/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH] debugedit: add UPSTREAM_CHECK settings

2024-01-02 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Add UPSTREAM_CHECK_URI(REGEX) to allow for checking new releases
for debugedit recipe.

Signed-off-by: Chen Qi 
---
 meta/recipes-devtools/debugedit/debugedit_5.0.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-devtools/debugedit/debugedit_5.0.bb 
b/meta/recipes-devtools/debugedit/debugedit_5.0.bb
index 63ad7babd9..3a596f5fea 100644
--- a/meta/recipes-devtools/debugedit/debugedit_5.0.bb
+++ b/meta/recipes-devtools/debugedit/debugedit_5.0.bb
@@ -9,6 +9,9 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
 file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1 \
 file://COPYING3;md5=d32239bcb673463ab874e80d47fae504"
 
+UPSTREAM_CHECK_URI = "https://sourceware.org/ftp/debugedit/";
+UPSTREAM_CHECK_REGEX = "(?P(\d\.\d))/"
+
 SRC_URI = "https://sourceware.org/ftp/debugedit/${PV}/debugedit-${PV}.tar.xz";
 
 SRC_URI:append:libc-musl = "\
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193220): 
https://lists.openembedded.org/g/openembedded-core/message/193220
Mute This Topic: https://lists.openembedded.org/mt/103478272/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 1/2] gawk: upgrade from 5.2.2 to 5.3.0

2024-01-01 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

Signed-off-by: Chen Qi 
---
 meta/recipes-extended/gawk/{gawk_5.2.2.bb => gawk_5.3.0.bb} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-extended/gawk/{gawk_5.2.2.bb => gawk_5.3.0.bb} (97%)

diff --git a/meta/recipes-extended/gawk/gawk_5.2.2.bb 
b/meta/recipes-extended/gawk/gawk_5.3.0.bb
similarity index 97%
rename from meta/recipes-extended/gawk/gawk_5.2.2.bb
rename to meta/recipes-extended/gawk/gawk_5.3.0.bb
index 3c18b6911a..3d652da6e5 100644
--- a/meta/recipes-extended/gawk/gawk_5.2.2.bb
+++ b/meta/recipes-extended/gawk/gawk_5.3.0.bb
@@ -19,7 +19,7 @@ SRC_URI = "${GNU_MIRROR}/gawk/gawk-${PV}.tar.gz \
file://run-ptest \
"
 
-SRC_URI[sha256sum] = 
"945aef7ccff101f20b22a10802bc005e994ab2b8ea3e724cc1a197c62f41f650"
+SRC_URI[sha256sum] = 
"378f8864ec21cfceaa048f7e1869ac9b4597b449087caf1eb55e440d30273336"
 
 inherit autotools gettext texinfo update-alternatives
 
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193205): 
https://lists.openembedded.org/g/openembedded-core/message/193205
Mute This Topic: https://lists.openembedded.org/mt/103477344/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH 2/2] systemd-bootchart: upgrade from 234 to 235

2024-01-01 Thread Chen Qi via lists.openembedded.org
From: Chen Qi 

0001-architecture-Recognise-RISCV-32-RISCV-64.patch is dropped because
it has some problem. It's a patch from systemd repo, yet it's marked
as 'Backport' for systemd-bootchart. systemd and systemd-bootchart are
two different projects. Now in 235, RISCV64 has been officially supported,
but RISCV32 is not. So drop this patch. People who want RISCV32 support
need to work with systemd-bootchart upstream first.

Signed-off-by: Chen Qi 
---
 ...itecture-Recognise-RISCV-32-RISCV-64.patch | 45 ---
 ...tchart_234.bb => systemd-bootchart_235.bb} |  5 +--
 2 files changed, 2 insertions(+), 48 deletions(-)
 delete mode 100644 
meta/recipes-devtools/systemd-bootchart/systemd-bootchart/0001-architecture-Recognise-RISCV-32-RISCV-64.patch
 rename meta/recipes-devtools/systemd-bootchart/{systemd-bootchart_234.bb => 
systemd-bootchart_235.bb} (90%)

diff --git 
a/meta/recipes-devtools/systemd-bootchart/systemd-bootchart/0001-architecture-Recognise-RISCV-32-RISCV-64.patch
 
b/meta/recipes-devtools/systemd-bootchart/systemd-bootchart/0001-architecture-Recognise-RISCV-32-RISCV-64.patch
deleted file mode 100644
index fc03812bb9..00
--- 
a/meta/recipes-devtools/systemd-bootchart/systemd-bootchart/0001-architecture-Recognise-RISCV-32-RISCV-64.patch
+++ /dev/null
@@ -1,45 +0,0 @@
-From 4a6ace0a965965ea15e88c3418c7158ca5cc9f8f Mon Sep 17 00:00:00 2001
-From: Khem Raj 
-Date: Thu, 21 Nov 2019 10:12:05 -0800
-Subject: [PATCH] architecture: Recognise RISCV-32/RISCV-64
-
-Upstream-Status: Backport 
[https://github.com/systemd/systemd/commit/171b53380085b1288b03b19a2b978f36a5c003d0]
-Signed-off-by: Khem Raj 

- src/architecture.h | 13 +
- 1 file changed, 13 insertions(+)
-
-diff --git a/src/architecture.h b/src/architecture.h
-index 26679e2..89c7d32 100644
 a/src/architecture.h
-+++ b/src/architecture.h
-@@ -57,6 +57,8 @@ enum {
- ARCHITECTURE_M68K,
- ARCHITECTURE_TILEGX,
- ARCHITECTURE_CRIS,
-+   ARCHITECTURE_RISCV32,
-+   ARCHITECTURE_RISCV64,
- _ARCHITECTURE_MAX,
- _ARCHITECTURE_INVALID = -1
- };
-@@ -194,6 +196,17 @@ int uname_architecture(void);
- #elif defined(__cris__)
- #  define native_architecture() ARCHITECTURE_CRIS
- #  error "Missing LIB_ARCH_TUPLE for CRIS"
-+#elif defined(__riscv)
-+#  if __SIZEOF_POINTER__ == 4
-+#define native_architecture() ARCHITECTURE_RISCV32
-+#define LIB_ARCH_TUPLE "riscv32-linux-gnu"
-+#  elif __SIZEOF_POINTER__ == 8
-+#define native_architecture() ARCHITECTURE_RISCV64
-+#define LIB_ARCH_TUPLE "riscv64-linux-gnu"
-+#  else
-+#error "Unrecognized riscv architecture variant"
-+#  endif
-+#  define PROC_CPUINFO_MODEL "cpu model"
- #else
- #  error "Please register your architecture here!"
- #endif
--- 
-2.24.0
-
diff --git a/meta/recipes-devtools/systemd-bootchart/systemd-bootchart_234.bb 
b/meta/recipes-devtools/systemd-bootchart/systemd-bootchart_235.bb
similarity index 90%
rename from meta/recipes-devtools/systemd-bootchart/systemd-bootchart_234.bb
rename to meta/recipes-devtools/systemd-bootchart/systemd-bootchart_235.bb
index bc3eee2093..25544029d5 100644
--- a/meta/recipes-devtools/systemd-bootchart/systemd-bootchart_234.bb
+++ b/meta/recipes-devtools/systemd-bootchart/systemd-bootchart_235.bb
@@ -8,8 +8,7 @@ LICENSE = "LGPL-2.1-only & GPL-2.0-only"
 LIC_FILES_CHKSUM = 
"file://LICENSE.LGPL2.1;md5=4fbd65380cdd255951079008b364516c \
 file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe"
 
-SRC_URI = 
"git://github.com/systemd/systemd-bootchart.git;protocol=https;branch=master \
-   file://0001-architecture-Recognise-RISCV-32-RISCV-64.patch \
+SRC_URI = 
"git://github.com/systemd/systemd-bootchart.git;protocol=https;branch=main \
file://mips64.patch \
file://no_lto.patch \
 "
@@ -21,7 +20,7 @@ SRC_URI:append:libc-musl = " \
 "
 
 
-SRCREV = "8183cfd9dad8beca5434d625cf6b2df87775e956"
+SRCREV = "8ab9680a1bd5eb8fe7a7dcc44897af7ee41e56e7"
 
 S = "${WORKDIR}/git"
 
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193206): 
https://lists.openembedded.org/g/openembedded-core/message/193206
Mute This Topic: https://lists.openembedded.org/mt/103477345/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



  1   2   3   4   5   6   7   8   9   10   >