[OE-core] [scarthgap][PATCH] gstreamer1.0-plugins-good: Include qttools-native during the build with qt5 PACKAGECONFIG

2024-05-21 Thread Marek Vasut
The qttools provide 'lrelease' tool, which is checked by recent
versions of meson build system. Unless the qttools are available
in sysroot, meson will fail to detect qt5 installation at build
time and the gstreamer build will fail. Fix this by including
the qttools-native.

Signed-off-by: Marek Vasut 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Richard Purdie 
(cherry picked from commit ae2ca4af54695003638da38f8548aa8573d18201)
---
 .../gstreamer/gstreamer1.0-plugins-good_1.22.11.bb  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.22.11.bb 
b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.22.11.bb
index edd8609b7c..85143aa1b9 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.22.11.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.22.11.bb
@@ -52,7 +52,7 @@ PACKAGECONFIG[libpng] = 
"-Dpng=enabled,-Dpng=disabled,libpng"
 PACKAGECONFIG[libv4l2]= 
"-Dv4l2-libv4l2=enabled,-Dv4l2-libv4l2=disabled,v4l-utils"
 PACKAGECONFIG[mpg123] = "-Dmpg123=enabled,-Dmpg123=disabled,mpg123"
 PACKAGECONFIG[pulseaudio] = "-Dpulse=enabled,-Dpulse=disabled,pulseaudio"
-PACKAGECONFIG[qt5]= "-Dqt5=enabled,-Dqt5=disabled,qtbase qtdeclarative 
qtbase-native ${QT5WAYLANDDEPENDS}"
+PACKAGECONFIG[qt5]= "-Dqt5=enabled,-Dqt5=disabled,qtbase qtdeclarative 
qtbase-native qttools-native ${QT5WAYLANDDEPENDS}"
 PACKAGECONFIG[soup2]  = "-Dsoup=enabled,,libsoup-2.4,,,soup3"
 PACKAGECONFIG[soup3]  = "-Dsoup=enabled,,libsoup,,,soup2"
 PACKAGECONFIG[speex]  = "-Dspeex=enabled,-Dspeex=disabled,speex"
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199631): 
https://lists.openembedded.org/g/openembedded-core/message/199631
Mute This Topic: https://lists.openembedded.org/mt/106221479/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] gstreamer1.0-plugins-good: Include qttools-native during the build with qt5 PACKAGECONFIG

2024-04-17 Thread Marek Vasut
The qttools provide 'lrelease' tool, which is checked by recent
versions of meson build system. Unless the qttools are available
in sysroot, meson will fail to detect qt5 installation at build
time and the gstreamer build will fail. Fix this by including
the qttools-native.

Signed-off-by: Marek Vasut 
---
Cc: Alexandre Belloni 
Cc: Anuj Mittal 
Cc: Randy MacLeod 
Cc: Richard Purdie 
Cc: Wang Mingyu 
---
 .../gstreamer/gstreamer1.0-plugins-good_1.22.11.bb  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.22.11.bb 
b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.22.11.bb
index edd8609b7c..85143aa1b9 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.22.11.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.22.11.bb
@@ -52,7 +52,7 @@ PACKAGECONFIG[libpng] = 
"-Dpng=enabled,-Dpng=disabled,libpng"
 PACKAGECONFIG[libv4l2]= 
"-Dv4l2-libv4l2=enabled,-Dv4l2-libv4l2=disabled,v4l-utils"
 PACKAGECONFIG[mpg123] = "-Dmpg123=enabled,-Dmpg123=disabled,mpg123"
 PACKAGECONFIG[pulseaudio] = "-Dpulse=enabled,-Dpulse=disabled,pulseaudio"
-PACKAGECONFIG[qt5]= "-Dqt5=enabled,-Dqt5=disabled,qtbase qtdeclarative 
qtbase-native ${QT5WAYLANDDEPENDS}"
+PACKAGECONFIG[qt5]= "-Dqt5=enabled,-Dqt5=disabled,qtbase qtdeclarative 
qtbase-native qttools-native ${QT5WAYLANDDEPENDS}"
 PACKAGECONFIG[soup2]  = "-Dsoup=enabled,,libsoup-2.4,,,soup3"
 PACKAGECONFIG[soup3]  = "-Dsoup=enabled,,libsoup,,,soup2"
 PACKAGECONFIG[speex]  = "-Dspeex=enabled,-Dspeex=disabled,speex"
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#198486): 
https://lists.openembedded.org/g/openembedded-core/message/198486
Mute This Topic: https://lists.openembedded.org/mt/105586391/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2] Revert "lzop: remove recipe from oe-core"

2024-01-20 Thread Marek Vasut
This reverts commit dea5e8863792dc7bb3324b543e04da4c94a060aa.

The original commit claims that lzop is unused in OE-core.
That is not correct, the following places still use it and
became unbuildable now:
"
meta/classes-recipe/image_types.bbclass:CONVERSION_CMD:lzo = "lzop -9 
${IMAGE_NAME}.${type}"
meta/classes-recipe/image_types.bbclass:CONVERSION_DEPENDS_lzo = "lzop-native"
meta/classes-recipe/kernel-uboot.bbclass:   lzop -9 
linux.bin
meta/classes-recipe/kernel.bbclass:DEPENDS += 
"${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lzo", "lzop-native", "", d)}"
meta/classes-recipe/kernel.bbclass: lzop -df 
${B}/usr/${INITRAMFS_IMAGE_NAME}.$img
"

Furthermore, LZO is the best compromise between kernel decompression
time and size on low end ARM systems, that is why it is often used
with e.g.:
FIT_KERNEL_COMP_ALG = "lzo"
FIT_KERNEL_COMP_ALG_EXTENSION = ".lzo"

Reinstate the package to avoid breaking this use case.

Signed-off-by: Marek Vasut 
---
Cc: Martin Jansa 
Cc: Ross Burton 
Cc: Richard Purdie 
---
V2: Replace Denys in maintainers.inc file for this recipe
---
 meta/conf/distro/include/maintainers.inc|   1 +
 meta/recipes-support/lzop/lzop/acinclude.m4 | 390 
 meta/recipes-support/lzop/lzop_1.04.bb  |  27 ++
 3 files changed, 418 insertions(+)
 create mode 100644 meta/recipes-support/lzop/lzop/acinclude.m4
 create mode 100644 meta/recipes-support/lzop/lzop_1.04.bb

diff --git a/meta/conf/distro/include/maintainers.inc 
b/meta/conf/distro/include/maintainers.inc
index 31023021ac..735e1c2230 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -485,6 +485,7 @@ RECIPE_MAINTAINER:pn-lua = "Alexander Kanavin 
"
 RECIPE_MAINTAINER:pn-lz4 = "Denys Dmytriyenko "
 RECIPE_MAINTAINER:pn-lzo = "Denys Dmytriyenko "
 RECIPE_MAINTAINER:pn-lzip = "Denys Dmytriyenko "
+RECIPE_MAINTAINER:pn-lzop = "Marek Vasut "
 RECIPE_MAINTAINER:pn-m4 = "Robert Yang "
 RECIPE_MAINTAINER:pn-m4-native = "Robert Yang "
 RECIPE_MAINTAINER:pn-make = "Robert Yang "
diff --git a/meta/recipes-support/lzop/lzop/acinclude.m4 
b/meta/recipes-support/lzop/lzop/acinclude.m4
new file mode 100644
index 00..0029c19c7d
--- /dev/null
+++ b/meta/recipes-support/lzop/lzop/acinclude.m4
@@ -0,0 +1,390 @@
+
+AC_DEFUN([mfx_ACC_CHECK_ENDIAN], [
+AC_C_BIGENDIAN([AC_DEFINE(ACC_ABI_BIG_ENDIAN,1,[Define to 1 if your machine is 
big endian.])],[AC_DEFINE(ACC_ABI_LITTLE_ENDIAN,1,[Define to 1 if your machine 
is little endian.])])
+])#
+
+AC_DEFUN([mfx_ACC_CHECK_HEADERS], [
+AC_HEADER_TIME
+AC_CHECK_HEADERS([assert.h ctype.h dirent.h errno.h fcntl.h float.h limits.h 
malloc.h memory.h setjmp.h signal.h stdarg.h stddef.h stdint.h stdio.h stdlib.h 
string.h strings.h time.h unistd.h utime.h sys/stat.h sys/time.h sys/types.h 
sys/wait.h])
+])#
+
+AC_DEFUN([mfx_ACC_CHECK_FUNCS], [
+AC_CHECK_FUNCS(access alloca atexit atoi atol chmod chown ctime difftime fstat 
gettimeofday gmtime localtime longjmp lstat memcmp memcpy memmove memset mktime 
qsort raise setjmp signal snprintf strcasecmp strchr strdup strerror strftime 
stricmp strncasecmp strnicmp strrchr strstr time umask utime vsnprintf)
+])#
+
+
+AC_DEFUN([mfx_ACC_CHECK_SIZEOF], [
+AC_CHECK_SIZEOF(short)
+AC_CHECK_SIZEOF(int)
+AC_CHECK_SIZEOF(long)
+
+AC_CHECK_SIZEOF(long long)
+AC_CHECK_SIZEOF(__int16)
+AC_CHECK_SIZEOF(__int32)
+AC_CHECK_SIZEOF(__int64)
+
+AC_CHECK_SIZEOF(void *)
+AC_CHECK_SIZEOF(size_t)
+AC_CHECK_SIZEOF(ptrdiff_t)
+])#
+
+
+# /***
+# // Check for ACC_conformance
+# /
+
+AC_DEFUN([mfx_ACC_ACCCHK], [
+mfx_tmp=$1
+mfx_save_CPPFLAGS=$CPPFLAGS
+dnl in Makefile.in $(INCLUDES) will be before $(CPPFLAGS), so we mimic this 
here
+test "X$mfx_tmp" = "X" || CPPFLAGS="$mfx_tmp $CPPFLAGS"
+
+AC_MSG_CHECKING([whether your compiler passes the ACC conformance test])
+
+AC_LANG_CONFTEST([AC_LANG_PROGRAM(
+[[#define ACC_CONFIG_NO_HEADER 1
+#include "acc/acc.h"
+#include "acc/acc_incd.h"
+#undef ACCCHK_ASSERT
+#define ACCCHK_ASSERT(expr) ACC_COMPILE_TIME_ASSERT_HEADER(expr)
+#include "acc/acc_chk.ch"
+#undef ACCCHK_ASSERT
+static void test_acc_compile_time_assert(void) {
+#define ACCCHK_ASSERT(expr) ACC_COMPILE_TIME_ASSERT(expr)
+#include "acc/acc_chk.ch"
+#undef ACCCHK_ASSERT
+}
+#undef NDEBUG
+#include 
+static int test_acc_run_time_assert(int r) {
+#define ACCCHK_ASSERT(expr) assert(expr);
+#include "acc/acc_chk.ch"
+#undef ACCCHK_ASSERT
+return r;
+}
+]], [[
+test_acc_compile_time_assert();
+if (test_acc_run_time_assert(1) != 1) return 1;
+]]
+)])
+
+mfx_tmp=FAILED
+_AC_COMPILE_

Re: [OE-core] [PATCH] Revert "lzop: remove recipe from oe-core"

2023-11-24 Thread Marek Vasut

On 11/24/23 23:28, Khem Raj wrote:

On Fri, Nov 24, 2023 at 12:18 AM Martin Jansa  wrote:


On Fri, Nov 24, 2023 at 8:52 AM Alexander Kanavin  
wrote:


On Thu, 23 Nov 2023 at 22:07, Marek Vasut  wrote:


The lzop is called in oe-core and I was under the impression that
oe-core shouldn't depend on anything except bitbake . So either this
stuff should be moved to meta-oe too (which would be unfortunate growth
of dependencies) or the lzop should be reinstated . I would obviously be
in favor of the later.


There are plenty of recipes in oe-core that have optional features
(enabled via PACKAGECONFIG) that depend on recipes that are not in
core. If you enable them, bitbake will say that the needed recipe is
missing and then you need to figure out which layer to add (typically
something in meta-openembedded tree). This is not that different:
optional feature, disabled by default, and the error will be the same:
missing lzop recipe.



I think this case is slightly different as this optional dependency might be 
"enabled" by MACHINE config in some BSP layer and BSP layer depending on 
meta-oe just to build the kernel (with BSP preferred compression) isn't great - compared 
with some DISTRO config enabling some additional PACKAGECONFIG in some other recipe the 
DISTRO uses.



do we have some data on how many machines are needing this ? if not
then I think we can say that
its not actively needed and few machines if any needing this can house
the recipe in the BSP layer
core support is still in core so that's good.


At least if Marek agrees to maintain it instead of restoring Denys as 
maintainer :).


That's good although it will be nicer to see a wider use case to keep
it in core.


I can think of at least two SoM vendors that actively use this.
I don't think that's "a few machines if any".

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#191221): 
https://lists.openembedded.org/g/openembedded-core/message/191221
Mute This Topic: https://lists.openembedded.org/mt/102759947/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] Revert "lzop: remove recipe from oe-core"

2023-11-24 Thread Marek Vasut

On 11/24/23 09:18, Martin Jansa wrote:

On Fri, Nov 24, 2023 at 8:52 AM Alexander Kanavin 
wrote:


On Thu, 23 Nov 2023 at 22:07, Marek Vasut  wrote:


The lzop is called in oe-core and I was under the impression that
oe-core shouldn't depend on anything except bitbake . So either this
stuff should be moved to meta-oe too (which would be unfortunate growth
of dependencies) or the lzop should be reinstated . I would obviously be
in favor of the later.


There are plenty of recipes in oe-core that have optional features
(enabled via PACKAGECONFIG) that depend on recipes that are not in
core. If you enable them, bitbake will say that the needed recipe is
missing and then you need to figure out which layer to add (typically
something in meta-openembedded tree). This is not that different:
optional feature, disabled by default, and the error will be the same:
missing lzop recipe.



I think this case is slightly different as this optional dependency might
be "enabled" by MACHINE config in some BSP layer and BSP layer depending on
meta-oe just to build the kernel (with BSP preferred compression) isn't
great - compared with some DISTRO config enabling some additional
PACKAGECONFIG in some other recipe the DISTRO uses.

At least if Marek agrees to maintain it instead of restoring Denys as
maintainer :).


The recipe seems low maintenance anyway and I use it often, so yeah, why 
not.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#191181): 
https://lists.openembedded.org/g/openembedded-core/message/191181
Mute This Topic: https://lists.openembedded.org/mt/102759947/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] Revert "lzop: remove recipe from oe-core"

2023-11-23 Thread Marek Vasut

On 11/23/23 09:26, Alexander Kanavin wrote:

I'm not sure I agree. It's totally ok to depend on things that are not
in core, if they're not enabled or tested on the AB by default, and
what layer they're in is well known (meta-oe in this case).


The lzop is called in oe-core and I was under the impression that 
oe-core shouldn't depend on anything except bitbake . So either this 
stuff should be moved to meta-oe too (which would be unfortunate growth 
of dependencies) or the lzop should be reinstated . I would obviously be 
in favor of the later.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#191175): 
https://lists.openembedded.org/g/openembedded-core/message/191175
Mute This Topic: https://lists.openembedded.org/mt/102759947/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] Revert "lzop: remove recipe from oe-core"

2023-11-22 Thread Marek Vasut
This reverts commit dea5e8863792dc7bb3324b543e04da4c94a060aa.

The original commit claims that lzop is unused in OE-core.
That is not correct, the following places still use it and
became unbuildable now:
"
meta/classes-recipe/image_types.bbclass:CONVERSION_CMD:lzo = "lzop -9 
${IMAGE_NAME}.${type}"
meta/classes-recipe/image_types.bbclass:CONVERSION_DEPENDS_lzo = "lzop-native"
meta/classes-recipe/kernel-uboot.bbclass:   lzop -9 
linux.bin
meta/classes-recipe/kernel.bbclass:DEPENDS += 
"${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lzo", "lzop-native", "", d)}"
meta/classes-recipe/kernel.bbclass: lzop -df 
${B}/usr/${INITRAMFS_IMAGE_NAME}.$img
"

Furthermore, LZO is the best compromise between kernel decompression
time and size on low end ARM systems, that is why it is often used
with e.g.:
FIT_KERNEL_COMP_ALG = "lzo"
FIT_KERNEL_COMP_ALG_EXTENSION = ".lzo"

Reinstate the package to avoid breaking this use case.

Signed-off-by: Marek Vasut 
---
Cc: Ross Burton 
Cc: Richard Purdie 
---
 meta/conf/distro/include/maintainers.inc|   1 +
 meta/recipes-support/lzop/lzop/acinclude.m4 | 390 
 meta/recipes-support/lzop/lzop_1.04.bb  |  27 ++
 3 files changed, 418 insertions(+)
 create mode 100644 meta/recipes-support/lzop/lzop/acinclude.m4
 create mode 100644 meta/recipes-support/lzop/lzop_1.04.bb

diff --git a/meta/conf/distro/include/maintainers.inc 
b/meta/conf/distro/include/maintainers.inc
index 35f8a72fa4..e95ab59d0d 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -484,6 +484,7 @@ RECIPE_MAINTAINER:pn-lua = "Alexander Kanavin 
"
 RECIPE_MAINTAINER:pn-lz4 = "Denys Dmytriyenko "
 RECIPE_MAINTAINER:pn-lzo = "Denys Dmytriyenko "
 RECIPE_MAINTAINER:pn-lzip = "Denys Dmytriyenko "
+RECIPE_MAINTAINER:pn-lzop = "Denys Dmytriyenko "
 RECIPE_MAINTAINER:pn-m4 = "Robert Yang "
 RECIPE_MAINTAINER:pn-m4-native = "Robert Yang "
 RECIPE_MAINTAINER:pn-make = "Robert Yang "
diff --git a/meta/recipes-support/lzop/lzop/acinclude.m4 
b/meta/recipes-support/lzop/lzop/acinclude.m4
new file mode 100644
index 00..0029c19c7d
--- /dev/null
+++ b/meta/recipes-support/lzop/lzop/acinclude.m4
@@ -0,0 +1,390 @@
+
+AC_DEFUN([mfx_ACC_CHECK_ENDIAN], [
+AC_C_BIGENDIAN([AC_DEFINE(ACC_ABI_BIG_ENDIAN,1,[Define to 1 if your machine is 
big endian.])],[AC_DEFINE(ACC_ABI_LITTLE_ENDIAN,1,[Define to 1 if your machine 
is little endian.])])
+])#
+
+AC_DEFUN([mfx_ACC_CHECK_HEADERS], [
+AC_HEADER_TIME
+AC_CHECK_HEADERS([assert.h ctype.h dirent.h errno.h fcntl.h float.h limits.h 
malloc.h memory.h setjmp.h signal.h stdarg.h stddef.h stdint.h stdio.h stdlib.h 
string.h strings.h time.h unistd.h utime.h sys/stat.h sys/time.h sys/types.h 
sys/wait.h])
+])#
+
+AC_DEFUN([mfx_ACC_CHECK_FUNCS], [
+AC_CHECK_FUNCS(access alloca atexit atoi atol chmod chown ctime difftime fstat 
gettimeofday gmtime localtime longjmp lstat memcmp memcpy memmove memset mktime 
qsort raise setjmp signal snprintf strcasecmp strchr strdup strerror strftime 
stricmp strncasecmp strnicmp strrchr strstr time umask utime vsnprintf)
+])#
+
+
+AC_DEFUN([mfx_ACC_CHECK_SIZEOF], [
+AC_CHECK_SIZEOF(short)
+AC_CHECK_SIZEOF(int)
+AC_CHECK_SIZEOF(long)
+
+AC_CHECK_SIZEOF(long long)
+AC_CHECK_SIZEOF(__int16)
+AC_CHECK_SIZEOF(__int32)
+AC_CHECK_SIZEOF(__int64)
+
+AC_CHECK_SIZEOF(void *)
+AC_CHECK_SIZEOF(size_t)
+AC_CHECK_SIZEOF(ptrdiff_t)
+])#
+
+
+# /***
+# // Check for ACC_conformance
+# /
+
+AC_DEFUN([mfx_ACC_ACCCHK], [
+mfx_tmp=$1
+mfx_save_CPPFLAGS=$CPPFLAGS
+dnl in Makefile.in $(INCLUDES) will be before $(CPPFLAGS), so we mimic this 
here
+test "X$mfx_tmp" = "X" || CPPFLAGS="$mfx_tmp $CPPFLAGS"
+
+AC_MSG_CHECKING([whether your compiler passes the ACC conformance test])
+
+AC_LANG_CONFTEST([AC_LANG_PROGRAM(
+[[#define ACC_CONFIG_NO_HEADER 1
+#include "acc/acc.h"
+#include "acc/acc_incd.h"
+#undef ACCCHK_ASSERT
+#define ACCCHK_ASSERT(expr) ACC_COMPILE_TIME_ASSERT_HEADER(expr)
+#include "acc/acc_chk.ch"
+#undef ACCCHK_ASSERT
+static void test_acc_compile_time_assert(void) {
+#define ACCCHK_ASSERT(expr) ACC_COMPILE_TIME_ASSERT(expr)
+#include "acc/acc_chk.ch"
+#undef ACCCHK_ASSERT
+}
+#undef NDEBUG
+#include 
+static int test_acc_run_time_assert(int r) {
+#define ACCCHK_ASSERT(expr) assert(expr);
+#include "acc/acc_chk.ch"
+#undef ACCCHK_ASSERT
+return r;
+}
+]], [[
+test_acc_compile_time_assert();
+if (test_acc_run_time_assert(1) != 1) return 1;
+]]
+)])
+
+mfx_tmp=FAILED
+_AC_COMPILE_IFELSE([], [mfx_tmp=yes])
+rm -f conftest.$ac_ext conftest.$ac_objext
+
+C

[OE-core] [dunfell][PATCH] libtiff: Add fix for tiffcrop CVE-2023-1916

2023-10-11 Thread Marek Vasut
Add fix for tiffcrop tool CVE-2023-1916 [1].

A flaw was found in tiffcrop, a program distributed by the libtiff
package. A specially crafted tiff file can lead to an out-of-bounds
read in the extractImageSection function in tools/tiffcrop.c, resulting
in a denial of service and limited information disclosure. This issue
affects libtiff versions 4.x.

The tool is no longer part of newer libtiff distributions, hence the
fix is rejected by upstream in [2]. The backport is still applicable
to older versions of libtiff, pick the CVE fix from ubuntu 20.04 [3].

[1] https://nvd.nist.gov/vuln/detail/CVE-2023-1916
[2] https://gitlab.com/libtiff/libtiff/-/merge_requests/535
[3] https://packages.ubuntu.com/source/focal-updates/tiff

Signed-off-by: Marek Vasut 
---
 .../libtiff/files/CVE-2023-1916.patch | 91 +++
 meta/recipes-multimedia/libtiff/tiff_4.1.0.bb |  1 +
 2 files changed, 92 insertions(+)
 create mode 100644 meta/recipes-multimedia/libtiff/files/CVE-2023-1916.patch

diff --git a/meta/recipes-multimedia/libtiff/files/CVE-2023-1916.patch 
b/meta/recipes-multimedia/libtiff/files/CVE-2023-1916.patch
new file mode 100644
index 00..9915b77645
--- /dev/null
+++ b/meta/recipes-multimedia/libtiff/files/CVE-2023-1916.patch
@@ -0,0 +1,91 @@
+From 848434a81c443f59ec90d41218eba6e48a450a11 Mon Sep 17 00:00:00 2001
+From: zhailiangliang 
+Date: Thu, 16 Mar 2023 16:16:54 +0800
+Subject: [PATCH] Fix heap-buffer-overflow in function extractImageSection
+
+CVE: CVE-2023-1916
+Upstream-Status: Submitted 
[https://gitlab.com/libtiff/libtiff/-/commit/848434a81c443f59ec90d41218eba6e48a450a11
 https://gitlab.com/libtiff/libtiff/-/merge_requests/535]
+Signed-off-by: Marek Vasut 
+---
+ archive/tools/tiffcrop.c | 62 +---
+ 1 file changed, 45 insertions(+), 17 deletions(-)
+
+--- tiff-4.1.0+git191117.orig/tools/tiffcrop.c
 tiff-4.1.0+git191117/tools/tiffcrop.c
+@@ -5549,6 +5549,15 @@ getCropOffsets(struct image_data *image,
+  crop->combined_width += (uint32)zwidth;
+else
+  crop->combined_width = (uint32)zwidth;
++
++   /* When the degrees clockwise rotation is 90 or 270, check the 
boundary */
++   if (((crop->rotation == 90) || (crop->rotation == 270))
++   && ((crop->combined_length > image->width) || 
(crop->combined_width > image->length)))
++   {
++   TIFFError("getCropOffsets", "The crop size exceeds the image 
boundary size");
++   return -1;
++   }
++
+break;
+   case EDGE_BOTTOM: /* width from left, zones from bottom to top */
+zwidth = offsets.crop_width;
+@@ -5579,6 +5588,15 @@ getCropOffsets(struct image_data *image,
+else
+  crop->combined_length = (uint32)zlength;
+crop->combined_width = (uint32)zwidth;
++
++   /* When the degrees clockwise rotation is 90 or 270, check the 
boundary */
++   if (((crop->rotation == 90) || (crop->rotation == 270))
++   && ((crop->combined_length > image->width) || 
(crop->combined_width > image->length)))
++   {
++   TIFFError("getCropOffsets", "The crop size exceeds the image 
boundary size");
++   return -1;
++   }
++
+break;
+   case EDGE_RIGHT: /* zones from right to left, length from top */
+zlength = offsets.crop_length;
+@@ -5606,6 +5624,15 @@ getCropOffsets(struct image_data *image,
+  crop->combined_width += (uint32)zwidth;
+else
+  crop->combined_width = (uint32)zwidth;
++
++   /* When the degrees clockwise rotation is 90 or 270, check the 
boundary */
++   if (((crop->rotation == 90) || (crop->rotation == 270))
++   && ((crop->combined_length > image->width) || 
(crop->combined_width > image->length)))
++   {
++   TIFFError("getCropOffsets", "The crop size exceeds the image 
boundary size");
++   return -1;
++   }
++
+break;
+   case EDGE_TOP: /* width from left, zones from top to bottom */
+   default:
+@@ -5632,6 +5659,15 @@ getCropOffsets(struct image_data *image,
+else
+  crop->combined_length = (uint32)zlength;
+crop->combined_width = (uint32)zwidth;
++
++   /* When the degrees clockwise rotation is 90 or 270, check the 
boundary */
++   if (((crop->rotation == 90) || (crop->rotation == 270))
++   && ((crop->combined_length > image->width) || 
(crop->combined_width > image->length)))
++   {
++   TIFFError("getCropOffsets", "The crop size exceeds the image 
boundary size");
++   return -1;
++ 

[OE-core] [dunfell][PATCH] systemd: Backport systemd-resolved: use hostname for certificate validation in DoT

2023-10-10 Thread Marek Vasut
Widely accepted certificates for IP addresses are expensive and only
affordable for larger organizations. Therefore if the user provides
the hostname in the DNS= option, we should use it instead of the IP
address.

This fixes https://nvd.nist.gov/vuln/detail/CVE-2018-21029 per
suggestion https://github.com/systemd/systemd-stable/issues/72 .

CVE: CVE-2018-21029
Signed-off-by: Marek Vasut 
---
NOTE: Here it would be good if someone took a close look at this backport.
---
Cc: Alban Bedel 
Cc: Richard Purdie 
Cc: Jermain Horsman 
Cc: Steve Sakoman 
---
 .../systemd/systemd/CVE-2018-21029.patch  | 120 ++
 meta/recipes-core/systemd/systemd_244.5.bb|   1 +
 2 files changed, 121 insertions(+)
 create mode 100644 meta/recipes-core/systemd/systemd/CVE-2018-21029.patch

diff --git a/meta/recipes-core/systemd/systemd/CVE-2018-21029.patch 
b/meta/recipes-core/systemd/systemd/CVE-2018-21029.patch
new file mode 100644
index 00..8d3801a248
--- /dev/null
+++ b/meta/recipes-core/systemd/systemd/CVE-2018-21029.patch
@@ -0,0 +1,120 @@
+From 3f9d9289ee8730a81a0464539f4e1ba2d23d0ce9 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= 
+Date: Tue, 3 Mar 2020 23:31:25 +
+Subject: [PATCH] systemd-resolved: use hostname for certificate validation in
+ DoT
+
+Widely accepted certificates for IP addresses are expensive and only
+affordable for larger organizations. Therefore if the user provides
+the hostname in the DNS= option, we should use it instead of the IP
+address.
+
+(cherry picked from commit eec394f10bbfcc3d2fc8504ad8ff5be44231abd5)
+
+CVE: CVE-2018-21029
+Upstream-Status: Backport [ff26d281aec0877b43269f18c6282cd79a7f5529]
+Signed-off-by: Marek Vasut 
+---
+ man/resolved.conf.xml | 16 +++-
+ src/resolve/resolved-dnstls-gnutls.c  | 20 
+ src/resolve/resolved-dnstls-openssl.c | 15 +++
+ 3 files changed, 34 insertions(+), 17 deletions(-)
+
+diff --git a/man/resolved.conf.xml b/man/resolved.conf.xml
+index 818000145b..37161ebcbc 100644
+--- a/man/resolved.conf.xml
 b/man/resolved.conf.xml
+@@ -193,11 +193,17 @@
+   
+ DNSOverTLS=
+ 
+-Takes a boolean argument or opportunistic.
+-If true all connections to the server will be encrypted. Note that
+-this mode requires a DNS server that supports DNS-over-TLS and has
+-a valid certificate for it's IP. If the DNS server does not support
+-DNS-over-TLS all DNS requests will fail. When set to 
opportunistic
++Takes a boolean argument or opportunistic. If
++true all connections to the server will be encrypted. Note that this
++mode requires a DNS server that supports DNS-over-TLS and has a valid
++certificate. If the hostname was specified in DNS=
++by using the format format address#server_name it
++is used to validate its certificate and also to enable Server Name
++Indication (SNI) when opening a TLS connection. Otherwise
++the certificate is checked against the server's IP.
++If the DNS server does not support DNS-over-TLS all DNS requests will 
fail.
++
++When set to opportunistic
+ DNS request are attempted to send encrypted with DNS-over-TLS.
+ If the DNS server does not support TLS, DNS-over-TLS is disabled.
+ Note that this mode makes DNS-over-TLS vulnerable to "downgrade"
+diff --git a/src/resolve/resolved-dnstls-gnutls.c 
b/src/resolve/resolved-dnstls-gnutls.c
+index ed0a31e8bf..c7215723a7 100644
+--- a/src/resolve/resolved-dnstls-gnutls.c
 b/src/resolve/resolved-dnstls-gnutls.c
+@@ -56,15 +56,19 @@ int dnstls_stream_connect_tls(DnsStream *stream, DnsServer 
*server) {
+ }
+ 
+ if (server->manager->dns_over_tls_mode == DNS_OVER_TLS_YES) {
+-stream->dnstls_data.validation.type = GNUTLS_DT_IP_ADDRESS;
+-if (server->family == AF_INET) {
+-stream->dnstls_data.validation.data = (unsigned 
char*) >address.in.s_addr;
+-stream->dnstls_data.validation.size = 4;
+-} else {
+-stream->dnstls_data.validation.data = 
server->address.in6.s6_addr;
+-stream->dnstls_data.validation.size = 16;
++if (server->server_name)
++gnutls_session_set_verify_cert(gs, 
server->server_name, 0);
++else {
++stream->dnstls_data.validation.type = 
GNUTLS_DT_IP_ADDRESS;
++if (server->family == AF_INET) {
++stream->dnstls_data.validation.data = 
(unsigned char*) >address.in.s_addr;
++stream->dnstls_data.validation.size = 4;
++} else {
++stream->dnstls_data.validation.data = 
serve

Re: [OE-core] [dunfell][PATCH v2] gawk: Backport CVE-2023-4156 fix

2023-10-09 Thread Marek Vasut

On 10/9/23 23:15, Steve Sakoman wrote:

Sorry I didn't catch this earlier, but I stopped reviewing after
noticing the Signed-off-by omission.


What Signed-off-by omission ?


There was already a patch submitted for this CVE:

https://lists.openembedded.org/g/openembedded-core/message/188624


OK

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188869): 
https://lists.openembedded.org/g/openembedded-core/message/188869
Mute This Topic: https://lists.openembedded.org/mt/101859964/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [dunfell][PATCH] gawk: Backport CVE-2023-4156 fix

2023-10-09 Thread Marek Vasut

On 10/9/23 19:29, Steve Sakoman wrote:

On Mon, Oct 9, 2023 at 6:27 AM Marek Vasut  wrote:


Pick fix for CVE-2023-4156 from ubuntu 20.04

A heap out-of-bounds read flaw was found in builtin.c in the gawk
package. This issue may lead to a crash and could be used to read
sensitive information.

https://nvd.nist.gov/vuln/detail/CVE-2023-4156

https://packages.ubuntu.com/source/focal/gawk
gawk_5.0.1+dfsg-1ubuntu0.1.debian.tar.xz / 12.9 kB / 
12d878acc04cd6328b793455547c870f

Signed-off-by: Marek Vasut 
---
  .../gawk/gawk/CVE-2023-4156.patch | 26 +++
  meta/recipes-extended/gawk/gawk_5.0.1.bb  |  1 +
  2 files changed, 27 insertions(+)
  create mode 100644 meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch

diff --git a/meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch 
b/meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch
new file mode 100644
index 00..ecfd974af0
--- /dev/null
+++ b/meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch
@@ -0,0 +1,26 @@
+From e709eb829448ce040087a3fc5481db6bfcaae212 Mon Sep 17 00:00:00 2001
+From: "Arnold D. Robbins" 
+Date: Wed, 3 Aug 2022 13:00:54 +0300
+Subject: [PATCH] Smal bug fix in builtin.c.
+
+CVE: CVE-2023-4156


Missing Upstream-Status.  Note that ubuntu isn't upstream so please
link to upstream gawk commit.


Should be fixed in V2, sorry for the mess.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188865): 
https://lists.openembedded.org/g/openembedded-core/message/188865
Mute This Topic: https://lists.openembedded.org/mt/101856223/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] ncurses: Mitigate CVE-2023-29491

2023-10-09 Thread Marek Vasut

On 10/9/23 18:44, Richard Purdie wrote:

On Mon, 2023-10-09 at 18:31 +0200, Marek Vasut wrote:

Configure with "--disable-root-environ" to disallow loading of
custom terminfo entries in setuid/setgid programs, mitigating the
impact of CVE-2023-29491.

This is taken from debian:
https://salsa.debian.org/debian/ncurses/-/commit/1c530aad772f7aeef039b8780d51cd09bd5a08ac

Signed-off-by: Marek Vasut 
---
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
  meta/recipes-core/ncurses/ncurses.inc | 1 +
  1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/ncurses/ncurses.inc 
b/meta/recipes-core/ncurses/ncurses.inc
index 367f3b19f4..1bc07ec2d4 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -87,6 +87,7 @@ ncurses_configure() {
--enable-sigwinch \
--enable-pc-files \
--disable-rpath-hack \
+   --disable-root-environ \
${EXCONFIG_ARGS} \
--with-manpage-format=normal \
--without-manpage-renames \


Should the patch add a CVE_STATUS entry as well so the cve tooling can
tell we've mitigated this?


I think I will try to backport the actual fix for this CVE from 
Kirkstone first.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188864): 
https://lists.openembedded.org/g/openembedded-core/message/188864
Mute This Topic: https://lists.openembedded.org/mt/101856335/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] ncurses: Mitigate CVE-2023-29491

2023-10-09 Thread Marek Vasut

On 10/9/23 19:27, Marko, Peter wrote:

-Original Message-
From: Marek Vasut 
Sent: Monday, October 9, 2023 18:57
To: Marko, Peter (ADV D EU SK BFS1) ; 
richard.pur...@linuxfoundation.org
Cc: Alexandre Belloni ; st...@sakoman.com; 
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] ncurses: Mitigate CVE-2023-29491


On 10/9/23 18:51, Marko, Peter wrote:

-Original Message-
From: openembedded-core@lists.openembedded.org
 On Behalf Of Richard Purdie
via lists.openembedded.org
Sent: Monday, October 9, 2023 18:44
To: Marek Vasut ; st...@sakoman.com;
openembedded-core@lists.openembedded.org
Cc: Alexandre Belloni 
Subject: Re: [OE-core] [PATCH] ncurses: Mitigate CVE-2023-29491


On Mon, 2023-10-09 at 18:31 +0200, Marek Vasut wrote:

Configure with "--disable-root-environ" to disallow loading of
custom terminfo entries in setuid/setgid programs, mitigating the
impact of CVE-2023-29491.

This is taken from debian:
https://salsa.debian.org/debian/ncurses/-/commit/1c530aad772f7aeef03
9b
8780d51cd09bd5a08ac

Signed-off-by: Marek Vasut 
---
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
   meta/recipes-core/ncurses/ncurses.inc | 1 +
   1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/ncurses/ncurses.inc
b/meta/recipes-core/ncurses/ncurses.inc
index 367f3b19f4..1bc07ec2d4 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -87,6 +87,7 @@ ncurses_configure() {
--enable-sigwinch \
--enable-pc-files \
--disable-rpath-hack \
+   --disable-root-environ \
${EXCONFIG_ARGS} \
--with-manpage-format=normal \
--without-manpage-renames \


Should the patch add a CVE_STATUS entry as well so the cve tooling can tell 
we've mitigated this?


ncurses 6.4 is not affected and not shown in CVE report, not sure why this is 
submitted for master.
Peter


Just wanted to make sure the configuration is consistent across all the 
releases.


I think that the commit message should be changed.
It's misleading when it only says that it mitigates already fixed CVE.


Will do, how does this sound:

"
ncurses: disallow loading of custom terminfo entries in 
setuid/setgid programs


Configure with "--disable-root-environ" to disallow loading of
custom terminfo entries in setuid/setgid programs. This is related
to CVE-2023-29491, even though CVE-2023-29491 itself is fixed in
this OE release by a backport patch.

This is taken from debian:

https://salsa.debian.org/debian/ncurses/-/commit/1c530aad772f7aeef039b8780d51cd09bd5a08ac
"

?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188863): 
https://lists.openembedded.org/g/openembedded-core/message/188863
Mute This Topic: https://lists.openembedded.org/mt/101856335/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH v2] gawk: Backport CVE-2023-4156 fix

2023-10-09 Thread Marek Vasut
Pick fix for CVE-2023-4156 from ubuntu 20.04

A heap out-of-bounds read flaw was found in builtin.c in the gawk
package. This issue may lead to a crash and could be used to read
sensitive information.

https://nvd.nist.gov/vuln/detail/CVE-2023-4156

Upstream commit:
https://git.savannah.gnu.org/cgit/gawk.git/commit/?id=e709eb829448ce040087a3fc5481db6bfcaae212

https://packages.ubuntu.com/source/focal/gawk
gawk_5.0.1+dfsg-1ubuntu0.1.debian.tar.xz / 12.9 kB / 
12d878acc04cd6328b793455547c870f

Signed-off-by: Marek Vasut 
---
V2: Add Upstream-Status for

https://git.savannah.gnu.org/cgit/gawk.git/commit/?id=e709eb829448ce040087a3fc5481db6bfcaae212
---
 .../gawk/gawk/CVE-2023-4156.patch | 27 +++
 meta/recipes-extended/gawk/gawk_5.0.1.bb  |  1 +
 2 files changed, 28 insertions(+)
 create mode 100644 meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch

diff --git a/meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch 
b/meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch
new file mode 100644
index 00..8c88b93795
--- /dev/null
+++ b/meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch
@@ -0,0 +1,27 @@
+From e709eb829448ce040087a3fc5481db6bfcaae212 Mon Sep 17 00:00:00 2001
+From: "Arnold D. Robbins" 
+Date: Wed, 3 Aug 2022 13:00:54 +0300
+Subject: [PATCH] Smal bug fix in builtin.c.
+
+CVE: CVE-2023-4156
+Upstream-Status: Backport [e709eb829448ce040087a3fc5481db6bfcaae212]
+Signed-off-by: Marek Vasut 
+---
+ ChangeLog | 6 ++
+ builtin.c | 5 -
+ 2 files changed, 10 insertions(+), 1 deletion(-)
+
+--- gawk-5.1.0.orig/builtin.c
 gawk-5.1.0/builtin.c
+@@ -957,7 +957,10 @@ check_pos:
+   s1++;
+   n0--;
+   }
+-  if (val >= num_args) {
++  // val could be less than zero if someone 
provides a field width
++  // so large that it causes integer overflow. 
Mainly fuzzers do this,
++  // but let's try to be good anyway.
++  if (val < 0 || val >= num_args) {
+   toofew = true;
+   break;
+   }
diff --git a/meta/recipes-extended/gawk/gawk_5.0.1.bb 
b/meta/recipes-extended/gawk/gawk_5.0.1.bb
index 1b29ec3113..7ca4cb77e4 100644
--- a/meta/recipes-extended/gawk/gawk_5.0.1.bb
+++ b/meta/recipes-extended/gawk/gawk_5.0.1.bb
@@ -17,6 +17,7 @@ PACKAGECONFIG[mpfr] = "--with-mpfr,--without-mpfr, mpfr"
 
 SRC_URI = "${GNU_MIRROR}/gawk/gawk-${PV}.tar.gz \
file://remove-sensitive-tests.patch \
+   file://CVE-2023-4156.patch \
file://run-ptest \
 "
 
-- 
2.40.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188862): 
https://lists.openembedded.org/g/openembedded-core/message/188862
Mute This Topic: https://lists.openembedded.org/mt/101859964/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [kirkstone][PATCH] ncurses: Mitigate CVE-2023-29491

2023-10-09 Thread Marek Vasut

On 10/9/23 18:47, Marko, Peter wrote:

Hi Marek,

Could you please describe why you add this configuration in kirkstone branch?
This CVE is already patched:
https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/ncurses/files/CVE-2023-29491.patch?h=kirkstone

Peter

-Original Message-
From: openembedded-core@lists.openembedded.org 
 On Behalf Of Marek Vasut via 
lists.openembedded.org
Sent: Monday, October 9, 2023 18:32
To: st...@sakoman.com; openembedded-core@lists.openembedded.org
Cc: Marek Vasut 
Subject: [OE-core] [kirkstone][PATCH] ncurses: Mitigate CVE-2023-29491


Configure with "--disable-root-environ" to disallow loading of custom terminfo 
entries in setuid/setgid programs, mitigating the impact of CVE-2023-29491.

This is taken from debian:
https://salsa.debian.org/debian/ncurses/-/commit/1c530aad772f7aeef039b8780d51cd09bd5a08ac

Signed-off-by: Marek Vasut 
---
  meta/recipes-core/ncurses/ncurses.inc | 1 +
  1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/ncurses/ncurses.inc 
b/meta/recipes-core/ncurses/ncurses.inc
index 1abcfae1fe..7e85044bdb 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -87,6 +87,7 @@ ncurses_configure() {
--enable-sigwinch \
--enable-pc-files \
--disable-rpath-hack \
+   --disable-root-environ \
${EXCONFIG_ARGS} \
--with-manpage-format=normal \
--without-manpage-renames \


See my reply to the master branch patch.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188857): 
https://lists.openembedded.org/g/openembedded-core/message/188857
Mute This Topic: https://lists.openembedded.org/mt/101856357/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] ncurses: Mitigate CVE-2023-29491

2023-10-09 Thread Marek Vasut

On 10/9/23 18:51, Marko, Peter wrote:

-Original Message-
From: openembedded-core@lists.openembedded.org 
 On Behalf Of Richard Purdie via 
lists.openembedded.org
Sent: Monday, October 9, 2023 18:44
To: Marek Vasut ; st...@sakoman.com; 
openembedded-core@lists.openembedded.org
Cc: Alexandre Belloni 
Subject: Re: [OE-core] [PATCH] ncurses: Mitigate CVE-2023-29491


On Mon, 2023-10-09 at 18:31 +0200, Marek Vasut wrote:

Configure with "--disable-root-environ" to disallow loading of custom
terminfo entries in setuid/setgid programs, mitigating the impact of
CVE-2023-29491.

This is taken from debian:
https://salsa.debian.org/debian/ncurses/-/commit/1c530aad772f7aeef039b
8780d51cd09bd5a08ac

Signed-off-by: Marek Vasut 
---
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
  meta/recipes-core/ncurses/ncurses.inc | 1 +
  1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/ncurses/ncurses.inc
b/meta/recipes-core/ncurses/ncurses.inc
index 367f3b19f4..1bc07ec2d4 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -87,6 +87,7 @@ ncurses_configure() {
--enable-sigwinch \
--enable-pc-files \
--disable-rpath-hack \
+   --disable-root-environ \
${EXCONFIG_ARGS} \
--with-manpage-format=normal \
--without-manpage-renames \


Should the patch add a CVE_STATUS entry as well so the cve tooling can tell 
we've mitigated this?


ncurses 6.4 is not affected and not shown in CVE report, not sure why this is 
submitted for master.
Peter


Just wanted to make sure the configuration is consistent across all the 
releases.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188856): 
https://lists.openembedded.org/g/openembedded-core/message/188856
Mute This Topic: https://lists.openembedded.org/mt/101856335/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [kirkstone][PATCH] ncurses: Mitigate CVE-2023-29491

2023-10-09 Thread Marek Vasut
Configure with "--disable-root-environ" to disallow loading of
custom terminfo entries in setuid/setgid programs, mitigating the
impact of CVE-2023-29491.

This is taken from debian:
https://salsa.debian.org/debian/ncurses/-/commit/1c530aad772f7aeef039b8780d51cd09bd5a08ac

Signed-off-by: Marek Vasut 
---
 meta/recipes-core/ncurses/ncurses.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/ncurses/ncurses.inc 
b/meta/recipes-core/ncurses/ncurses.inc
index 1abcfae1fe..7e85044bdb 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -87,6 +87,7 @@ ncurses_configure() {
--enable-sigwinch \
--enable-pc-files \
--disable-rpath-hack \
+   --disable-root-environ \
${EXCONFIG_ARGS} \
--with-manpage-format=normal \
--without-manpage-renames \
-- 
2.40.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188848): 
https://lists.openembedded.org/g/openembedded-core/message/188848
Mute This Topic: https://lists.openembedded.org/mt/101856357/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] ncurses: Mitigate CVE-2023-29491

2023-10-09 Thread Marek Vasut
Configure with "--disable-root-environ" to disallow loading of
custom terminfo entries in setuid/setgid programs, mitigating the
impact of CVE-2023-29491.

This is taken from debian:
https://salsa.debian.org/debian/ncurses/-/commit/1c530aad772f7aeef039b8780d51cd09bd5a08ac

Signed-off-by: Marek Vasut 
---
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
 meta/recipes-core/ncurses/ncurses.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/ncurses/ncurses.inc 
b/meta/recipes-core/ncurses/ncurses.inc
index 367f3b19f4..1bc07ec2d4 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -87,6 +87,7 @@ ncurses_configure() {
--enable-sigwinch \
--enable-pc-files \
--disable-rpath-hack \
+   --disable-root-environ \
${EXCONFIG_ARGS} \
--with-manpage-format=normal \
--without-manpage-renames \
-- 
2.40.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188847): 
https://lists.openembedded.org/g/openembedded-core/message/188847
Mute This Topic: https://lists.openembedded.org/mt/101856335/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] ncurses: Mitigate CVE-2023-29491

2023-10-09 Thread Marek Vasut
Configure with "--disable-root-environ" to disallow loading of
custom terminfo entries in setuid/setgid programs, mitigating the
impact of CVE-2023-29491.

This is taken from debian:
https://salsa.debian.org/debian/ncurses/-/commit/1c530aad772f7aeef039b8780d51cd09bd5a08ac

Signed-off-by: Marek Vasut 
---
 meta/recipes-core/ncurses/ncurses.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/ncurses/ncurses.inc 
b/meta/recipes-core/ncurses/ncurses.inc
index ee0b15ecf0..38826a6231 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -86,6 +86,7 @@ ncurses_configure() {
--enable-sigwinch \
--enable-pc-files \
--disable-rpath-hack \
+   --disable-root-environ \
${EXCONFIG_ARGS} \
--with-manpage-format=normal \
--without-manpage-renames \
-- 
2.40.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188846): 
https://lists.openembedded.org/g/openembedded-core/message/188846
Mute This Topic: https://lists.openembedded.org/mt/101856232/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] gawk: Backport CVE-2023-4156 fix

2023-10-09 Thread Marek Vasut
Pick fix for CVE-2023-4156 from ubuntu 20.04

A heap out-of-bounds read flaw was found in builtin.c in the gawk
package. This issue may lead to a crash and could be used to read
sensitive information.

https://nvd.nist.gov/vuln/detail/CVE-2023-4156

https://packages.ubuntu.com/source/focal/gawk
gawk_5.0.1+dfsg-1ubuntu0.1.debian.tar.xz / 12.9 kB / 
12d878acc04cd6328b793455547c870f

Signed-off-by: Marek Vasut 
---
 .../gawk/gawk/CVE-2023-4156.patch | 26 +++
 meta/recipes-extended/gawk/gawk_5.0.1.bb  |  1 +
 2 files changed, 27 insertions(+)
 create mode 100644 meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch

diff --git a/meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch 
b/meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch
new file mode 100644
index 00..ecfd974af0
--- /dev/null
+++ b/meta/recipes-extended/gawk/gawk/CVE-2023-4156.patch
@@ -0,0 +1,26 @@
+From e709eb829448ce040087a3fc5481db6bfcaae212 Mon Sep 17 00:00:00 2001
+From: "Arnold D. Robbins" 
+Date: Wed, 3 Aug 2022 13:00:54 +0300
+Subject: [PATCH] Smal bug fix in builtin.c.
+
+CVE: CVE-2023-4156
+Signed-off-by: Marek Vasut 
+---
+ ChangeLog | 6 ++
+ builtin.c | 5 -
+ 2 files changed, 10 insertions(+), 1 deletion(-)
+
+--- gawk-5.1.0.orig/builtin.c
 gawk-5.1.0/builtin.c
+@@ -957,7 +957,10 @@ check_pos:
+   s1++;
+   n0--;
+   }
+-  if (val >= num_args) {
++  // val could be less than zero if someone 
provides a field width
++  // so large that it causes integer overflow. 
Mainly fuzzers do this,
++  // but let's try to be good anyway.
++  if (val < 0 || val >= num_args) {
+   toofew = true;
+   break;
+   }
diff --git a/meta/recipes-extended/gawk/gawk_5.0.1.bb 
b/meta/recipes-extended/gawk/gawk_5.0.1.bb
index 1b29ec3113..7ca4cb77e4 100644
--- a/meta/recipes-extended/gawk/gawk_5.0.1.bb
+++ b/meta/recipes-extended/gawk/gawk_5.0.1.bb
@@ -17,6 +17,7 @@ PACKAGECONFIG[mpfr] = "--with-mpfr,--without-mpfr, mpfr"
 
 SRC_URI = "${GNU_MIRROR}/gawk/gawk-${PV}.tar.gz \
file://remove-sensitive-tests.patch \
+   file://CVE-2023-4156.patch \
file://run-ptest \
 "
 
-- 
2.40.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188845): 
https://lists.openembedded.org/g/openembedded-core/message/188845
Mute This Topic: https://lists.openembedded.org/mt/101856223/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] busybox: Backport CVE-2022-48174 fix

2023-10-09 Thread Marek Vasut
There is a stack overflow vulnerability in ash.c:6030 in busybox before
1.35. In the environment of Internet of Vehicles, this vulnerability can
be executed from command to arbitrary code execution.

https://nvd.nist.gov/vuln/detail/CVE-2022-48174

CVE: CVE-2022-48174
Signed-off-by: Marek Vasut 
---
Cc: Martin Jansa 
Cc: Richard Purdie 
Cc: Steve Sakoman 
---
 .../busybox/busybox/CVE-2022-48174.patch  | 82 +++
 meta/recipes-core/busybox/busybox_1.31.1.bb   |  1 +
 2 files changed, 83 insertions(+)
 create mode 100644 meta/recipes-core/busybox/busybox/CVE-2022-48174.patch

diff --git a/meta/recipes-core/busybox/busybox/CVE-2022-48174.patch 
b/meta/recipes-core/busybox/busybox/CVE-2022-48174.patch
new file mode 100644
index 00..dfba2a7e0f
--- /dev/null
+++ b/meta/recipes-core/busybox/busybox/CVE-2022-48174.patch
@@ -0,0 +1,82 @@
+From c18ebf861528ef24958dd99a146482d2a40014c7 Mon Sep 17 00:00:00 2001
+From: Denys Vlasenko 
+Date: Mon, 12 Jun 2023 17:48:47 +0200
+Subject: [PATCH] shell: avoid segfault on ${0::0/0~09J}. Closes 15216
+
+function old new   delta
+evaluate_string 10111053 +42
+
+CVE: CVE-2022-48174
+Upstream-Status: Backport [d417193cf37ca1005830d7e16f5fa7e1d8a44209]
+Signed-off-by: Denys Vlasenko 
+---
+ shell/math.c | 39 +++
+ 1 file changed, 35 insertions(+), 4 deletions(-)
+
+diff --git a/shell/math.c b/shell/math.c
+index af1ab55c0..79824e81f 100644
+--- a/shell/math.c
 b/shell/math.c
+@@ -578,6 +578,28 @@ static arith_t strto_arith_t(const char *nptr, char 
**endptr)
+ # endif
+ #endif
+ 
++//TODO: much better estimation than expr_len/2? Such as:
++//static unsigned estimate_nums_and_names(const char *expr)
++//{
++//unsigned count = 0;
++//while (*(expr = skip_whitespace(expr)) != '\0') {
++//const char *p;
++//if (isdigit(*expr)) {
++//while (isdigit(*++expr))
++//continue;
++//count++;
++//continue;
++//}
++//p = endofname(expr);
++//if (p != expr) {
++//expr = p;
++//count++;
++//continue;
++//}
++//}
++//return count;
++//}
++
+ static arith_t FAST_FUNC
+ evaluate_string(arith_state_t *math_state, const char *expr)
+ {
+@@ -585,10 +607,12 @@ evaluate_string(arith_state_t *math_state, const char 
*expr)
+   const char *errmsg;
+   const char *start_expr = expr = skip_whitespace(expr);
+   unsigned expr_len = strlen(expr) + 2;
+-  /* Stack of integers */
+-  /* The proof that there can be no more than strlen(startbuf)/2+1
+-   * integers in any given correct or incorrect expression
+-   * is left as an exercise to the reader. */
++  /* Stack of integers/names */
++  /* There can be no more than strlen(startbuf)/2+1
++   * integers/names in any given correct or incorrect expression.
++   * (modulo "09v09v09v09v09v" case,
++   * but we have code to detect that early)
++   */
+   var_or_num_t *const numstack = alloca((expr_len / 2) * 
sizeof(numstack[0]));
+   var_or_num_t *numstackptr = numstack;
+   /* Stack of operator tokens */
+@@ -657,6 +681,13 @@ evaluate_string(arith_state_t *math_state, const char 
*expr)
+   numstackptr->var = NULL;
+   errno = 0;
+   numstackptr->val = strto_arith_t(expr, (char**) );
++  /* A number can't be followed by another number, or a 
variable name.
++   * We'd catch this later anyway, but this would require 
numstack[]
++   * to be twice as deep to handle strings where _every_ 
char is
++   * a new number or name. Example: 
09v09v09v09v09v09v09v09v09v
++   */
++  if (isalnum(*expr) || *expr == '_')
++  goto err;
+   if (errno)
+   numstackptr->val = 0; /* bash compat */
+   goto num;
+-- 
+2.40.1
+
diff --git a/meta/recipes-core/busybox/busybox_1.31.1.bb 
b/meta/recipes-core/busybox/busybox_1.31.1.bb
index d062f0f7dd..94aa1467df 100644
--- a/meta/recipes-core/busybox/busybox_1.31.1.bb
+++ b/meta/recipes-core/busybox/busybox_1.31.1.bb
@@ -55,6 +55,7 @@ SRC_URI = 
"https://busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
file://CVE-2021-42374.patch \
file://CVE-2021-42376.patch \
file://CVE-2021-423xx-awk.patch \
+   file://CVE-2022-48174.patch \

file://0001-libbb-sockaddr2str-ensure-only-printable-characters-.patch \

file://0002-nslookup-sanitize-all-printed-strings-with-printable.patch \
"
-- 
2.40.1


-=-=-

[OE-core] [dunfell][PATCH] cpio: Replace fix wrong CRC with ASCII CRC for large files with upstream backport

2023-10-09 Thread Marek Vasut
Replace the original "Wrong CRC with ASCII CRC for large files"
patch with upstream backport, and add additional fix on top of
the same problem which upstream detected and fixed.

Signed-off-by: Marek Vasut 
---
 ...g-CRC-with-ASCII-CRC-for-large-files.patch |  39 ---
 ...-calculation-of-CRC-in-copy-out-mode.patch |  58 
 ...appending-to-archives-bigger-than-2G.patch | 312 ++
 meta/recipes-extended/cpio/cpio_2.13.bb   |   3 +-
 4 files changed, 372 insertions(+), 40 deletions(-)
 delete mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
 create mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
 create mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch

diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
deleted file mode 100644
index 4b96e4316c..00
--- 
a/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
+++ /dev/null
@@ -1,39 +0,0 @@
-From 77ff5f1be394eb2c786df561ff37dde7f982ec76 Mon Sep 17 00:00:00 2001
-From: Stefano Babic 
-Date: Fri, 28 Jul 2017 13:20:52 +0200
-Subject: [PATCH] Wrong CRC with ASCII CRC for large files
-
-Due to signedness, the checksum is not computed when filesize is bigger
-a 2GB.
-
-Upstream-Status: Submitted 
[https://lists.gnu.org/archive/html/bug-cpio/2017-07/msg4.html]
-Signed-off-by: Stefano Babic 

- src/copyout.c | 8 
- 1 file changed, 4 insertions(+), 4 deletions(-)
-
-diff --git a/src/copyout.c b/src/copyout.c
-index 1f0987a..727aeca 100644
 a/src/copyout.c
-+++ b/src/copyout.c
-@@ -34,13 +34,13 @@
-compute and return a checksum for them.  */
- 
- static uint32_t
--read_for_checksum (int in_file_des, int file_size, char *file_name)
-+read_for_checksum (int in_file_des, unsigned int file_size, char *file_name)
- {
-   uint32_t crc;
-   char buf[BUFSIZ];
--  int bytes_left;
--  int bytes_read;
--  int i;
-+  unsigned int bytes_left;
-+  unsigned int bytes_read;
-+  unsigned int i;
- 
-   crc = 0;
- 
--- 
-2.7.4
-
diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
new file mode 100644
index 00..2dfd348d7c
--- /dev/null
+++ 
b/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
@@ -0,0 +1,58 @@
+From d257e47a6c6b41ba727b196ac96c05ab91bd9d65 Mon Sep 17 00:00:00 2001
+From: Sergey Poznyakoff 
+Date: Fri, 7 Apr 2023 11:23:37 +0300
+Subject: [PATCH 3/4] Fix calculation of CRC in copy-out mode.
+
+* src/copyout.c (read_for_checksum): Fix type of the file_size argument.
+Rewrite the reading loop.
+
+Original patch by Stefano Babic 
+
+Upstream-Status: Backport [a1b2f7871c3ae5113e0102b870b15ea06a8f0e3d]
+Signed-off-by: Marek Vasut 
+---
+ src/copyout.c | 16 +++-
+ 1 file changed, 7 insertions(+), 9 deletions(-)
+
+diff --git a/src/copyout.c b/src/copyout.c
+index 8b0beb6..f1ff351 100644
+--- a/src/copyout.c
 b/src/copyout.c
+@@ -34,27 +34,25 @@
+compute and return a checksum for them.  */
+ 
+ static uint32_t
+-read_for_checksum (int in_file_des, int file_size, char *file_name)
++read_for_checksum (int in_file_des, off_t file_size, char *file_name)
+ {
+   uint32_t crc;
+-  char buf[BUFSIZ];
+-  int bytes_left;
+-  int bytes_read;
+-  int i;
++  unsigned char buf[BUFSIZ];
++  ssize_t bytes_read;
++  ssize_t i;
+ 
+   crc = 0;
+ 
+-  for (bytes_left = file_size; bytes_left > 0; bytes_left -= bytes_read)
++  while (file_size > 0)
+ {
+   bytes_read = read (in_file_des, buf, BUFSIZ);
+   if (bytes_read < 0)
+   error (PAXEXIT_FAILURE, errno, _("cannot read checksum for %s"), 
file_name);
+   if (bytes_read == 0)
+   break;
+-  if (bytes_left < bytes_read)
+-bytes_read = bytes_left;
+-  for (i = 0; i < bytes_read; ++i)
++  for (i = 0; i < bytes_read; i++)
+   crc += buf[i] & 0xff;
++  file_size -= bytes_read;
+ }
+   if (lseek (in_file_des, 0L, SEEK_SET))
+ error (PAXEXIT_FAILURE, errno, _("cannot read checksum for %s"), 
file_name);
+-- 
+2.39.2
+
diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch
new file mode 100644
index 00..c212bddf7d
--- /dev/null
+++ 
b/meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch
@@ -0,0 +1,312 @@
+From 8513495ab5cfb63eb7c4c933fdf0b78c6196cd27 Mon Sep 17 00:00:00 2001
+From: Sergey Poznyakoff 
+Date: Fri, 28 Apr 2023 15:23:46 +0300
+Subject: [PATCH 4/4] Fix ap

[OE-core] [dunfell][PATCH] linux-firmware: Fix mediatek mt7601u firmware path

2023-08-10 Thread Marek Vasut
The following linux-firmware commit moved the mt7601u firmware blob
into a mediatek/ subdirectory, update the path accordingly.
8451c2b1 ("mt76xx: Move the old Mediatek WiFi firmware to mediatek")

(From OE-Core rev: 6fa5c4967a7e70192e9233c92534f27ec3e394c8)

Fixes: 64603f602d ("linux-firmware: upgrade 20230404 -> 20230515")
Signed-off-by: Marek Vasut 
---
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
Cc: Trevor Gamblin 
Cc: Steve Sakoman 
---
NOTE: Adjusted to the old syntax with underscores
---
 meta/recipes-kernel/linux-firmware/linux-firmware_20230515.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20230515.bb 
b/meta/recipes-kernel/linux-firmware/linux-firmware_20230515.bb
index a367a9fd01..206de1bcd1 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_20230515.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20230515.bb
@@ -411,7 +411,7 @@ LICENSE_${PN}-mt7601u-license = 
"Firmware-ralink_a_mediatek_company_firmware"
 
 FILES_${PN}-mt7601u-license = 
"${nonarch_base_libdir}/firmware/LICENCE.ralink_a_mediatek_company_firmware"
 FILES_${PN}-mt7601u = " \
-  ${nonarch_base_libdir}/firmware/mt7601u.bin \
+  ${nonarch_base_libdir}/firmware/mediatek/mt7601u.bin \
 "
 
 RDEPENDS_${PN}-mt7601u += "${PN}-mt7601u-license"
-- 
2.40.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#185737): 
https://lists.openembedded.org/g/openembedded-core/message/185737
Mute This Topic: https://lists.openembedded.org/mt/100660921/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [kirkstone][PATCH] linux-firmware: Fix mediatek mt7601u firmware path

2023-08-10 Thread Marek Vasut
The following linux-firmware commit moved the mt7601u firmware blob
into a mediatek/ subdirectory, update the path accordingly.
8451c2b1 ("mt76xx: Move the old Mediatek WiFi firmware to mediatek")

(From OE-Core rev: 6fa5c4967a7e70192e9233c92534f27ec3e394c8)

Fixes: 64603f602d ("linux-firmware: upgrade 20230404 -> 20230515")
Signed-off-by: Marek Vasut 
---
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
Cc: Trevor Gamblin 
Cc: Steve Sakoman 
---
 meta/recipes-kernel/linux-firmware/linux-firmware_20230515.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20230515.bb 
b/meta/recipes-kernel/linux-firmware/linux-firmware_20230515.bb
index 3470131294..d304b75c5f 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_20230515.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20230515.bb
@@ -417,7 +417,7 @@ LICENSE:${PN}-mt7601u-license = 
"Firmware-ralink_a_mediatek_company_firmware"
 
 FILES:${PN}-mt7601u-license = 
"${nonarch_base_libdir}/firmware/LICENCE.ralink_a_mediatek_company_firmware"
 FILES:${PN}-mt7601u = " \
-  ${nonarch_base_libdir}/firmware/mt7601u.bin \
+  ${nonarch_base_libdir}/firmware/mediatek/mt7601u.bin \
 "
 
 RDEPENDS:${PN}-mt7601u += "${PN}-mt7601u-license"
-- 
2.40.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#185736): 
https://lists.openembedded.org/g/openembedded-core/message/185736
Mute This Topic: https://lists.openembedded.org/mt/100660918/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] linux-firmware: Fix mediatek mt7601u firmware path

2023-08-08 Thread Marek Vasut
The following linux-firmware commit moved the mt7601u firmware blob
into a mediatek/ subdirectory, update the path accordingly.
8451c2b1 ("mt76xx: Move the old Mediatek WiFi firmware to mediatek")

Fixes: 64603f602d ("linux-firmware: upgrade 20230404 -> 20230515")
Signed-off-by: Marek Vasut 
---
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
Cc: Trevor Gamblin 
Cc: Steve Sakoman 
---
NOTE: It would be good to apply to kirkstone and dunfell too
---
 meta/recipes-kernel/linux-firmware/linux-firmware_20230625.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20230625.bb 
b/meta/recipes-kernel/linux-firmware/linux-firmware_20230625.bb
index 3c88bdeb7e..6765226b9d 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_20230625.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20230625.bb
@@ -419,7 +419,7 @@ LICENSE:${PN}-mt7601u-license = 
"Firmware-ralink_a_mediatek_company_firmware"
 
 FILES:${PN}-mt7601u-license = 
"${nonarch_base_libdir}/firmware/LICENCE.ralink_a_mediatek_company_firmware"
 FILES:${PN}-mt7601u = " \
-  ${nonarch_base_libdir}/firmware/mt7601u.bin \
+  ${nonarch_base_libdir}/firmware/mediatek/mt7601u.bin \
 "
 
 RDEPENDS:${PN}-mt7601u += "${PN}-mt7601u-license"
-- 
2.40.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#185681): 
https://lists.openembedded.org/g/openembedded-core/message/185681
Mute This Topic: https://lists.openembedded.org/mt/100634395/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 1/2] u-boot: Switch to nobranch=1

2023-07-15 Thread Marek Vasut

On 7/15/23 15:00, Alexander Kanavin wrote:

If you don’t list which branch a commit is on, it may be not in a branch at
all


That itself is not a problem as long as the commit is referenced, right?


and not intended for downstream consumption


We do know that specific U-Boot commit is intended for consumption.


, or on a private or
personal branch which is also not intended for private consumption.


This is also not applicable here.


Requiring to name the branch guards us from either possibility, and means I
do not have to go and check that manually or trust you blindly.


This protection is really weak, this check fails on every single 
possibly bogus commit which is already on any random branch, so what is 
the gain here really ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#184410): 
https://lists.openembedded.org/g/openembedded-core/message/184410
Mute This Topic: https://lists.openembedded.org/mt/100144566/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 1/2] u-boot: Switch to nobranch=1

2023-07-15 Thread Marek Vasut

On 7/15/23 06:56, Alexander Kanavin wrote:

Then we’ll consider options, such as moving variable bits out of .inc or
introducing a variable that strips last number from PV. I would want to
avoid recipes fetching from dangling branch-less commits in core. The
commit being on a branch is a QA check by the fetcher.


What difference does it make whether the commit is in a branch or not , 
as long as it is referenced ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#184310): 
https://lists.openembedded.org/g/openembedded-core/message/184310
Mute This Topic: https://lists.openembedded.org/mt/100144566/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [kirkstone][PATCH] systemd: Backport nspawn: make sure host root can write to the uidmapped mounts we prepare for the container payload

2023-07-11 Thread Marek Vasut
Backport fix for systemd nspawn uidmap handling from systemd v253 .
Without this, attempt to start mkosi generated debian stable 12
container would ultimately fail (per "$ strace -ff") with:
"
symlinkat("usr/lib/aarch64-linux-gnu", 8, "lib64") = -1 EOVERFLOW (Value too 
large for defined data type)
"

Command to generate test container:
"
mkosi --distribution debian --release stable --architecture arm64 \
  --cache-dir /home/oe/cache/ --format tar --compress-output xz \
  --output-dir /home/oe/output/ --checksum 1 --root-password root \
  --package systemd --package udev --package dbus
"

Command to import test container and start it, which triggers the failure:
"
$ machinectl pull-tar http://192.168.1.300/image.tar.xz default
$ machinectl read-only default false
$ rm -f /var/lib/machines/default/etc/machine-id
$ dbus-uuidgen --ensure=/var/lib/machines/default/etc/machine-id
$ machinectl start default
"

Minimal command to trigger the failure once container is imported:
"
$ strace -ff systemd-nspawn --keep-unit --boot --link-journal=try-guest 
--network-veth -U --settings=override --machine=default
"

Extracted from systemd MR:
https://github.com/systemd/systemd/pull/22774

Further explanation by Christian Brauner at second half of:
https://github.com/systemd/systemd/issues/20989

Signed-off-by: Marek Vasut 
---
Cc: Alexandre Belloni 
Cc: Steve Sakoman 
---
 ...-host-root-can-write-to-the-uidmappe.patch | 216 ++
 meta/recipes-core/systemd/systemd_250.5.bb|   1 +
 2 files changed, 217 insertions(+)
 create mode 100644 
meta/recipes-core/systemd/systemd/0001-nspawn-make-sure-host-root-can-write-to-the-uidmappe.patch

diff --git 
a/meta/recipes-core/systemd/systemd/0001-nspawn-make-sure-host-root-can-write-to-the-uidmappe.patch
 
b/meta/recipes-core/systemd/systemd/0001-nspawn-make-sure-host-root-can-write-to-the-uidmappe.patch
new file mode 100644
index 00..8715019c99
--- /dev/null
+++ 
b/meta/recipes-core/systemd/systemd/0001-nspawn-make-sure-host-root-can-write-to-the-uidmappe.patch
@@ -0,0 +1,216 @@
+From e34fb1a4568bd080032065bb1506ab9b6c6606f1 Mon Sep 17 00:00:00 2001
+From: Lennart Poettering 
+Date: Thu, 17 Mar 2022 13:46:12 +0100
+Subject: [PATCH] nspawn: make sure host root can write to the uidmapped mounts
+ we prepare for the container payload
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+When using user namespaces in conjunction with uidmapped mounts, nspawn
+so far set up two uidmappings:
+
+1. One that is used for the uidmapped mount and that maps the UID range
+   0…65535 on the backing fs to some high UID range X…X+65535 on the
+   uidmapped fs. (Let's call this mapping the "mount mapping")
+
+2. One that is used for the userns namespace the container payload
+   processes run in, that maps X…X+65535 back to 0…65535. (Let's call
+   this one the "process mapping").
+
+These mappings hence are pretty much identical, one just moves things up
+and one back down. (Reminder: we do all this so that the processes can
+run under high UIDs while running off file systems that require no
+recursive chown()ing, i.e. we want processes with high UID range but
+files with low UID range.)
+
+This creates one problem, i.e. issue #20989: if nspawn (which runs as
+host root, i.e. host UID 0) wants to add inodes to the uidmapped mount
+it can't do that, since host UID 0 is not defined in the mount mapping
+(only the X…X+65536 range is, after all, and X > 0), and processes whose
+UID is not mapped in a uidmapped fs cannot create inodes in it since
+those would be owned by an unmapped UID, which then triggers
+the famous EOVERFLOW error.
+
+Let's fix this, by explicitly including an entry for the host UID 0 in
+the mount mapping. Specifically, we'll extend the mount mapping to map
+UID 2147483646 (which is INT32_MAX-1, see code for an explanation why I
+picked this one) of the backing fs to UID 0 on the uidmapped fs. This
+way nspawn can creates inode on the uidmapped as it likes (which will
+then actually be owned by UID 2147483646 on the backing fs), and as it
+always did. Note that we do *not* create a similar entry in the process
+mapping. Thus any files created by nspawn that way (and not chown()ed to
+something better) will appear as unmapped (i.e. as overflowuid/"nobody")
+in the container payload. And that's good. Of course, the latter is
+mostly theoretic, as nspawn should generally chown() the inodes it
+creates to UID ranges that actually make sense for the container (and we
+generally already do this correctly), but it#s good to know that we are
+safe here, given we might accidentally forget to chown() some inodes we
+create.
+
+Net effect: the two mappings will not be identical anymore. The mount
+mapping has one entry more, and the only reason it exists is so that
+nspawn can access the uidmapp

Re: [OE-core] [kirkstone][PATCH] cpio: Replace fix wrong CRC with ASCII CRC for large files with upstream backport

2023-07-01 Thread Marek Vasut

On 6/28/23 00:05, Steve Sakoman wrote:

On Tue, Jun 27, 2023 at 11:59 AM Marek Vasut  wrote:


On 6/27/23 16:08, Steve Sakoman wrote:

On Sun, Jun 25, 2023 at 3:50 AM Marek Vasut  wrote:


Replace the original "Wrong CRC with ASCII CRC for large files"
patch with upstream backport, and add additional fix on top of
the same problem which upstream detected and fixed.


Your replacement patches are missing Upstream-Status and Signed-off-by tags:

ERROR: cpio-2.13-r0 do_patch: Missing Upstream-Status in patch
/home/steve/builds/poky-contrib-kirkstone/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
Please add according to
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status
.
ERROR: cpio-2.13-r0 do_patch: Missing Upstream-Status in patch
/home/steve/builds/poky-contrib-kirkstone/meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch
Please add according to
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status


Upstream-Status was indeed missed.

What do I put into SoB line if the original patches have no SoB line
(which btw is common in other backports in OE-core and e.g. oelint-adv
warns about that too) ?


Probably common because only missing Upstream-Status generates an error!

The Signed-off-by should be your name/email if you are kind enough to add it.


V2 should have those fixed.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#183773): 
https://lists.openembedded.org/g/openembedded-core/message/183773
Mute This Topic: https://lists.openembedded.org/mt/99769144/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [kirkstone][PATCH v2] cpio: Replace fix wrong CRC with ASCII CRC for large files with upstream backport

2023-07-01 Thread Marek Vasut
Replace the original "Wrong CRC with ASCII CRC for large files"
patch with upstream backport, and add additional fix on top of
the same problem which upstream detected and fixed.

Signed-off-by: Marek Vasut 
---
NOTE: There is no oe-core/master counterpart, since oe-core/master
  updated to cpio 2.14 in the meantime.
---
V2: Add U-S and SoB lines
---
Cc: Alexandre Belloni 
Cc: Khem Raj 
Cc: Richard Purdie 
Cc: Richard Purdie 
Cc: Ross Burton 
Cc: Steve Sakoman 
---
 ...g-CRC-with-ASCII-CRC-for-large-files.patch |  39 ---
 ...-calculation-of-CRC-in-copy-out-mode.patch |  58 
 ...appending-to-archives-bigger-than-2G.patch | 312 ++
 meta/recipes-extended/cpio/cpio_2.13.bb   |   3 +-
 4 files changed, 372 insertions(+), 40 deletions(-)
 delete mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
 create mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
 create mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch

diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
deleted file mode 100644
index 4b96e4316c..00
--- 
a/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
+++ /dev/null
@@ -1,39 +0,0 @@
-From 77ff5f1be394eb2c786df561ff37dde7f982ec76 Mon Sep 17 00:00:00 2001
-From: Stefano Babic 
-Date: Fri, 28 Jul 2017 13:20:52 +0200
-Subject: [PATCH] Wrong CRC with ASCII CRC for large files
-
-Due to signedness, the checksum is not computed when filesize is bigger
-a 2GB.
-
-Upstream-Status: Submitted 
[https://lists.gnu.org/archive/html/bug-cpio/2017-07/msg4.html]
-Signed-off-by: Stefano Babic 

- src/copyout.c | 8 
- 1 file changed, 4 insertions(+), 4 deletions(-)
-
-diff --git a/src/copyout.c b/src/copyout.c
-index 1f0987a..727aeca 100644
 a/src/copyout.c
-+++ b/src/copyout.c
-@@ -34,13 +34,13 @@
-compute and return a checksum for them.  */
- 
- static uint32_t
--read_for_checksum (int in_file_des, int file_size, char *file_name)
-+read_for_checksum (int in_file_des, unsigned int file_size, char *file_name)
- {
-   uint32_t crc;
-   char buf[BUFSIZ];
--  int bytes_left;
--  int bytes_read;
--  int i;
-+  unsigned int bytes_left;
-+  unsigned int bytes_read;
-+  unsigned int i;
- 
-   crc = 0;
- 
--- 
-2.7.4
-
diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
new file mode 100644
index 00..2dfd348d7c
--- /dev/null
+++ 
b/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
@@ -0,0 +1,58 @@
+From d257e47a6c6b41ba727b196ac96c05ab91bd9d65 Mon Sep 17 00:00:00 2001
+From: Sergey Poznyakoff 
+Date: Fri, 7 Apr 2023 11:23:37 +0300
+Subject: [PATCH 3/4] Fix calculation of CRC in copy-out mode.
+
+* src/copyout.c (read_for_checksum): Fix type of the file_size argument.
+Rewrite the reading loop.
+
+Original patch by Stefano Babic 
+
+Upstream-Status: Backport [a1b2f7871c3ae5113e0102b870b15ea06a8f0e3d]
+Signed-off-by: Marek Vasut 
+---
+ src/copyout.c | 16 +++-
+ 1 file changed, 7 insertions(+), 9 deletions(-)
+
+diff --git a/src/copyout.c b/src/copyout.c
+index 8b0beb6..f1ff351 100644
+--- a/src/copyout.c
 b/src/copyout.c
+@@ -34,27 +34,25 @@
+compute and return a checksum for them.  */
+ 
+ static uint32_t
+-read_for_checksum (int in_file_des, int file_size, char *file_name)
++read_for_checksum (int in_file_des, off_t file_size, char *file_name)
+ {
+   uint32_t crc;
+-  char buf[BUFSIZ];
+-  int bytes_left;
+-  int bytes_read;
+-  int i;
++  unsigned char buf[BUFSIZ];
++  ssize_t bytes_read;
++  ssize_t i;
+ 
+   crc = 0;
+ 
+-  for (bytes_left = file_size; bytes_left > 0; bytes_left -= bytes_read)
++  while (file_size > 0)
+ {
+   bytes_read = read (in_file_des, buf, BUFSIZ);
+   if (bytes_read < 0)
+   error (PAXEXIT_FAILURE, errno, _("cannot read checksum for %s"), 
file_name);
+   if (bytes_read == 0)
+   break;
+-  if (bytes_left < bytes_read)
+-bytes_read = bytes_left;
+-  for (i = 0; i < bytes_read; ++i)
++  for (i = 0; i < bytes_read; i++)
+   crc += buf[i] & 0xff;
++  file_size -= bytes_read;
+ }
+   if (lseek (in_file_des, 0L, SEEK_SET))
+ error (PAXEXIT_FAILURE, errno, _("cannot read checksum for %s"), 
file_name);
+-- 
+2.39.2
+
diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch
new file mode 100644
index 00..c212bddf7d
--- /dev/null
+++ 
b/meta/recipes-extended/

Re: [OE-core] [kirkstone][PATCH] cpio: Replace fix wrong CRC with ASCII CRC for large files with upstream backport

2023-06-27 Thread Marek Vasut

On 6/27/23 16:08, Steve Sakoman wrote:

On Sun, Jun 25, 2023 at 3:50 AM Marek Vasut  wrote:


Replace the original "Wrong CRC with ASCII CRC for large files"
patch with upstream backport, and add additional fix on top of
the same problem which upstream detected and fixed.


Your replacement patches are missing Upstream-Status and Signed-off-by tags:

ERROR: cpio-2.13-r0 do_patch: Missing Upstream-Status in patch
/home/steve/builds/poky-contrib-kirkstone/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
Please add according to
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status
.
ERROR: cpio-2.13-r0 do_patch: Missing Upstream-Status in patch
/home/steve/builds/poky-contrib-kirkstone/meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch
Please add according to
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status


Upstream-Status was indeed missed.

What do I put into SoB line if the original patches have no SoB line 
(which btw is common in other backports in OE-core and e.g. oelint-adv 
warns about that too) ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#183503): 
https://lists.openembedded.org/g/openembedded-core/message/183503
Mute This Topic: https://lists.openembedded.org/mt/99769144/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [kirkstone][PATCH] cpio: Replace fix wrong CRC with ASCII CRC for large files with upstream backport

2023-06-25 Thread Marek Vasut
Replace the original "Wrong CRC with ASCII CRC for large files"
patch with upstream backport, and add additional fix on top of
the same problem which upstream detected and fixed.

Signed-off-by: Marek Vasut 
---
NOTE: There is no oe-core/master counterpart, since oe-core/master
  updated to cpio 2.14 in the meantime.
---
Cc: Alexandre Belloni 
Cc: Khem Raj 
Cc: Richard Purdie 
Cc: Richard Purdie 
Cc: Ross Burton 
Cc: Steve Sakoman 
---
 ...g-CRC-with-ASCII-CRC-for-large-files.patch |  39 ---
 ...-calculation-of-CRC-in-copy-out-mode.patch |  55 
 ...appending-to-archives-bigger-than-2G.patch | 309 ++
 meta/recipes-extended/cpio/cpio_2.13.bb   |   3 +-
 4 files changed, 366 insertions(+), 40 deletions(-)
 delete mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
 create mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
 create mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch

diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
deleted file mode 100644
index 4b96e4316c..00
--- 
a/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
+++ /dev/null
@@ -1,39 +0,0 @@
-From 77ff5f1be394eb2c786df561ff37dde7f982ec76 Mon Sep 17 00:00:00 2001
-From: Stefano Babic 
-Date: Fri, 28 Jul 2017 13:20:52 +0200
-Subject: [PATCH] Wrong CRC with ASCII CRC for large files
-
-Due to signedness, the checksum is not computed when filesize is bigger
-a 2GB.
-
-Upstream-Status: Submitted 
[https://lists.gnu.org/archive/html/bug-cpio/2017-07/msg4.html]
-Signed-off-by: Stefano Babic 

- src/copyout.c | 8 
- 1 file changed, 4 insertions(+), 4 deletions(-)
-
-diff --git a/src/copyout.c b/src/copyout.c
-index 1f0987a..727aeca 100644
 a/src/copyout.c
-+++ b/src/copyout.c
-@@ -34,13 +34,13 @@
-compute and return a checksum for them.  */
- 
- static uint32_t
--read_for_checksum (int in_file_des, int file_size, char *file_name)
-+read_for_checksum (int in_file_des, unsigned int file_size, char *file_name)
- {
-   uint32_t crc;
-   char buf[BUFSIZ];
--  int bytes_left;
--  int bytes_read;
--  int i;
-+  unsigned int bytes_left;
-+  unsigned int bytes_read;
-+  unsigned int i;
- 
-   crc = 0;
- 
--- 
-2.7.4
-
diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
new file mode 100644
index 00..aa478b5126
--- /dev/null
+++ 
b/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
@@ -0,0 +1,55 @@
+From d257e47a6c6b41ba727b196ac96c05ab91bd9d65 Mon Sep 17 00:00:00 2001
+From: Sergey Poznyakoff 
+Date: Fri, 7 Apr 2023 11:23:37 +0300
+Subject: [PATCH 3/4] Fix calculation of CRC in copy-out mode.
+
+* src/copyout.c (read_for_checksum): Fix type of the file_size argument.
+Rewrite the reading loop.
+
+Original patch by Stefano Babic 
+---
+ src/copyout.c | 16 +++-
+ 1 file changed, 7 insertions(+), 9 deletions(-)
+
+diff --git a/src/copyout.c b/src/copyout.c
+index 8b0beb6..f1ff351 100644
+--- a/src/copyout.c
 b/src/copyout.c
+@@ -34,27 +34,25 @@
+compute and return a checksum for them.  */
+ 
+ static uint32_t
+-read_for_checksum (int in_file_des, int file_size, char *file_name)
++read_for_checksum (int in_file_des, off_t file_size, char *file_name)
+ {
+   uint32_t crc;
+-  char buf[BUFSIZ];
+-  int bytes_left;
+-  int bytes_read;
+-  int i;
++  unsigned char buf[BUFSIZ];
++  ssize_t bytes_read;
++  ssize_t i;
+ 
+   crc = 0;
+ 
+-  for (bytes_left = file_size; bytes_left > 0; bytes_left -= bytes_read)
++  while (file_size > 0)
+ {
+   bytes_read = read (in_file_des, buf, BUFSIZ);
+   if (bytes_read < 0)
+   error (PAXEXIT_FAILURE, errno, _("cannot read checksum for %s"), 
file_name);
+   if (bytes_read == 0)
+   break;
+-  if (bytes_left < bytes_read)
+-bytes_read = bytes_left;
+-  for (i = 0; i < bytes_read; ++i)
++  for (i = 0; i < bytes_read; i++)
+   crc += buf[i] & 0xff;
++  file_size -= bytes_read;
+ }
+   if (lseek (in_file_des, 0L, SEEK_SET))
+ error (PAXEXIT_FAILURE, errno, _("cannot read checksum for %s"), 
file_name);
+-- 
+2.39.2
+
diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch
new file mode 100644
index 00..677702c0bc
--- /dev/null
+++ 
b/meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch
@@ -0,0 +1,309 @@
+From 8513495ab5cfb63eb7c4c933fdf0b78c6196cd

[OE-core] [kirkstone][PATCH] nghttp2: Deleted the entries for -client and -server, and removed a dependency on them from the main package.

2023-05-19 Thread Marek Vasut
From: leimaohui 

By default there is nothing in nghttp2-client and nghttp2-server ,nghttp2-client
and nghttp2-server aren't created. So there are dependences error if install
main package.

Problem: conflicting requests
  - nothing provides nghttp2-client >= 1.52.0 needed by 
nghttp2-1.52.0-r0.core2_64
  - nothing provides nghttp2-server >= 1.52.0 needed by 
nghttp2-1.52.0-r0.core2_64

Upstream-Status: Backport [OE-core d2cbe060955c598bd81923ecd554fbe82c17af99]
Signed-off-by: Lei Maohui 
Signed-off-by: Alexandre Belloni 
---
 meta/recipes-support/nghttp2/nghttp2_1.47.0.bb | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-support/nghttp2/nghttp2_1.47.0.bb 
b/meta/recipes-support/nghttp2/nghttp2_1.47.0.bb
index becacd4502..90d3286ac6 100644
--- a/meta/recipes-support/nghttp2/nghttp2_1.47.0.bb
+++ b/meta/recipes-support/nghttp2/nghttp2_1.47.0.bb
@@ -23,17 +23,15 @@ EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=OFF 
-DENABLE_HPACK_TOOLS=OFF
 #
 EXTRA_OECMAKE += "-DENABLE_PYTHON_BINDINGS=OFF"
 
-PACKAGES =+ "lib${BPN} ${PN}-client ${PN}-proxy ${PN}-server"
+PACKAGES =+ "lib${BPN} ${PN}-proxy "
 
-RDEPENDS:${PN} = "${PN}-client (>= ${PV}) ${PN}-proxy (>= ${PV}) ${PN}-server 
(>= ${PV})"
+RDEPENDS:${PN} = "${PN}-proxy (>= ${PV})"
 RDEPENDS:${PN}:class-native = ""
 RDEPENDS:${PN}-proxy = "openssl python3-core python3-io python3-shell"
 
 ALLOW_EMPTY:${PN} = "1"
 FILES:${PN} = ""
 FILES:lib${BPN} = "${libdir}/*${SOLIBS}"
-FILES:${PN}-client = "${bindir}/h2load ${bindir}/nghttp"
 FILES:${PN}-proxy = "${bindir}/nghttpx ${datadir}/${BPN}/fetch-ocsp-response"
-FILES:${PN}-server = "${bindir}/nghttpd"
 
 BBCLASSEXTEND = "native nativesdk"
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181558): 
https://lists.openembedded.org/g/openembedded-core/message/181558
Mute This Topic: https://lists.openembedded.org/mt/99014998/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] perf: Depend on native setuptools3

2023-05-15 Thread Marek Vasut
From: Khem Raj 

perf has need for python setuptools when scripting is enabled
from 6.0.0 onwards it seems to throw an explicit error

Signed-off-by: Khem Raj 
Cc: Bruce Ashfield 
Signed-off-by: Ross Burton 
Signed-off-by: Richard Purdie 
(cherry picked from commit da3d00178809bbf7cc453401e0c5937796ebc2c1)
Signed-off-by: Steve Sakoman 
---
 meta/recipes-kernel/perf/perf.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index 9c9bf1647f..91bf648caa 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -13,7 +13,7 @@ PR = "r9"
 
 PACKAGECONFIG ??= "scripting tui libunwind"
 PACKAGECONFIG[dwarf] = ",NO_DWARF=1"
-PACKAGECONFIG[scripting] = ",NO_LIBPERL=1 NO_LIBPYTHON=1,perl python3"
+PACKAGECONFIG[scripting] = ",NO_LIBPERL=1 NO_LIBPYTHON=1,perl python3 
python3-setuptools-native"
 # gui support was added with kernel 3.6.35
 # since 3.10 libnewt was replaced by slang
 # to cover a wide range of kernel we add both dependencies
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181268): 
https://lists.openembedded.org/g/openembedded-core/message/181268
Mute This Topic: https://lists.openembedded.org/mt/98908758/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] cpio: Fix wrong CRC with ASCII CRC for large files

2023-05-15 Thread Marek Vasut
Due to signedness, the checksum is not computed when filesize is bigger
a 2GB. Pick a fix for this problem from CPIO ML, where the fix has been
posted for 5 years. Since CPIO upstream is effectively unresponsive and
any and all attempts to communicate with the maintainer and get the fix
applied upstream failed, add the fix here instead.

(From OE-Core rev: bfff138af4bdd356ac66571e6ad91c1a5599b935)

Signed-off-by: Marek Vasut 
Signed-off-by: Richard Purdie 
---
 ...g-CRC-with-ASCII-CRC-for-large-files.patch | 39 +++
 meta/recipes-extended/cpio/cpio_2.13.bb   |  1 +
 2 files changed, 40 insertions(+)
 create mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch

diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
new file mode 100644
index 00..4b96e4316c
--- /dev/null
+++ 
b/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
@@ -0,0 +1,39 @@
+From 77ff5f1be394eb2c786df561ff37dde7f982ec76 Mon Sep 17 00:00:00 2001
+From: Stefano Babic 
+Date: Fri, 28 Jul 2017 13:20:52 +0200
+Subject: [PATCH] Wrong CRC with ASCII CRC for large files
+
+Due to signedness, the checksum is not computed when filesize is bigger
+a 2GB.
+
+Upstream-Status: Submitted 
[https://lists.gnu.org/archive/html/bug-cpio/2017-07/msg4.html]
+Signed-off-by: Stefano Babic 
+---
+ src/copyout.c | 8 
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/src/copyout.c b/src/copyout.c
+index 1f0987a..727aeca 100644
+--- a/src/copyout.c
 b/src/copyout.c
+@@ -34,13 +34,13 @@
+compute and return a checksum for them.  */
+ 
+ static uint32_t
+-read_for_checksum (int in_file_des, int file_size, char *file_name)
++read_for_checksum (int in_file_des, unsigned int file_size, char *file_name)
+ {
+   uint32_t crc;
+   char buf[BUFSIZ];
+-  int bytes_left;
+-  int bytes_read;
+-  int i;
++  unsigned int bytes_left;
++  unsigned int bytes_read;
++  unsigned int i;
+ 
+   crc = 0;
+ 
+-- 
+2.7.4
+
diff --git a/meta/recipes-extended/cpio/cpio_2.13.bb 
b/meta/recipes-extended/cpio/cpio_2.13.bb
index 7c8a465cd0..86527da744 100644
--- a/meta/recipes-extended/cpio/cpio_2.13.bb
+++ b/meta/recipes-extended/cpio/cpio_2.13.bb
@@ -10,6 +10,7 @@ SRC_URI = "${GNU_MIRROR}/cpio/cpio-${PV}.tar.gz \
file://0001-Unset-need_charset_alias-when-building-for-musl.patch \

file://0002-src-global.c-Remove-superfluous-declaration-of-progr.patch \
file://CVE-2021-38185.patch \
+   file://0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch \
"
 
 SRC_URI[md5sum] = "389c5452d667c23b5eceb206f5000810"
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181267): 
https://lists.openembedded.org/g/openembedded-core/message/181267
Mute This Topic: https://lists.openembedded.org/mt/98908748/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [kirkstone][PATCH] cpio: Fix wrong CRC with ASCII CRC for large files

2023-05-15 Thread Marek Vasut
Due to signedness, the checksum is not computed when filesize is bigger
a 2GB. Pick a fix for this problem from CPIO ML, where the fix has been
posted for 5 years. Since CPIO upstream is effectively unresponsive and
any and all attempts to communicate with the maintainer and get the fix
applied upstream failed, add the fix here instead.

(From OE-Core rev: bfff138af4bdd356ac66571e6ad91c1a5599b935)

Signed-off-by: Marek Vasut 
Signed-off-by: Richard Purdie 
---
 ...g-CRC-with-ASCII-CRC-for-large-files.patch | 39 +++
 meta/recipes-extended/cpio/cpio_2.13.bb   |  1 +
 2 files changed, 40 insertions(+)
 create mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch

diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
new file mode 100644
index 00..4b96e4316c
--- /dev/null
+++ 
b/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
@@ -0,0 +1,39 @@
+From 77ff5f1be394eb2c786df561ff37dde7f982ec76 Mon Sep 17 00:00:00 2001
+From: Stefano Babic 
+Date: Fri, 28 Jul 2017 13:20:52 +0200
+Subject: [PATCH] Wrong CRC with ASCII CRC for large files
+
+Due to signedness, the checksum is not computed when filesize is bigger
+a 2GB.
+
+Upstream-Status: Submitted 
[https://lists.gnu.org/archive/html/bug-cpio/2017-07/msg4.html]
+Signed-off-by: Stefano Babic 
+---
+ src/copyout.c | 8 
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/src/copyout.c b/src/copyout.c
+index 1f0987a..727aeca 100644
+--- a/src/copyout.c
 b/src/copyout.c
+@@ -34,13 +34,13 @@
+compute and return a checksum for them.  */
+ 
+ static uint32_t
+-read_for_checksum (int in_file_des, int file_size, char *file_name)
++read_for_checksum (int in_file_des, unsigned int file_size, char *file_name)
+ {
+   uint32_t crc;
+   char buf[BUFSIZ];
+-  int bytes_left;
+-  int bytes_read;
+-  int i;
++  unsigned int bytes_left;
++  unsigned int bytes_read;
++  unsigned int i;
+ 
+   crc = 0;
+ 
+-- 
+2.7.4
+
diff --git a/meta/recipes-extended/cpio/cpio_2.13.bb 
b/meta/recipes-extended/cpio/cpio_2.13.bb
index e72a114de9..dd3541096f 100644
--- a/meta/recipes-extended/cpio/cpio_2.13.bb
+++ b/meta/recipes-extended/cpio/cpio_2.13.bb
@@ -10,6 +10,7 @@ SRC_URI = "${GNU_MIRROR}/cpio/cpio-${PV}.tar.gz \
file://0001-Unset-need_charset_alias-when-building-for-musl.patch \

file://0002-src-global.c-Remove-superfluous-declaration-of-progr.patch \
file://CVE-2021-38185.patch \
+   file://0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch \
"
 
 SRC_URI[md5sum] = "389c5452d667c23b5eceb206f5000810"
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181266): 
https://lists.openembedded.org/g/openembedded-core/message/181266
Mute This Topic: https://lists.openembedded.org/mt/98908735/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] cpio: Fix wrong CRC with ASCII CRC for large files

2023-04-05 Thread Marek Vasut
Due to signedness, the checksum is not computed when filesize is bigger
a 2GB. Pick a fix for this problem from CPIO ML, where the fix has been
posted for 5 years. Since CPIO upstream is effectively unresponsive and
any and all attempts to communicate with the maintainer and get the fix
applied upstream failed, add the fix here instead.

Signed-off-by: Marek Vasut 
---
Cc: Khem Raj 
Cc: Luca Ceresoli 
Cc: Richard Purdie 
Cc: Stefano Babic 
Cc: Steve Sakoman 
---
 ...g-CRC-with-ASCII-CRC-for-large-files.patch | 39 +++
 meta/recipes-extended/cpio/cpio_2.13.bb   |  1 +
 2 files changed, 40 insertions(+)
 create mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch

diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
new file mode 100644
index 00..4b96e4316c
--- /dev/null
+++ 
b/meta/recipes-extended/cpio/cpio-2.13/0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch
@@ -0,0 +1,39 @@
+From 77ff5f1be394eb2c786df561ff37dde7f982ec76 Mon Sep 17 00:00:00 2001
+From: Stefano Babic 
+Date: Fri, 28 Jul 2017 13:20:52 +0200
+Subject: [PATCH] Wrong CRC with ASCII CRC for large files
+
+Due to signedness, the checksum is not computed when filesize is bigger
+a 2GB.
+
+Upstream-Status: Submitted 
[https://lists.gnu.org/archive/html/bug-cpio/2017-07/msg4.html]
+Signed-off-by: Stefano Babic 
+---
+ src/copyout.c | 8 
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/src/copyout.c b/src/copyout.c
+index 1f0987a..727aeca 100644
+--- a/src/copyout.c
 b/src/copyout.c
+@@ -34,13 +34,13 @@
+compute and return a checksum for them.  */
+ 
+ static uint32_t
+-read_for_checksum (int in_file_des, int file_size, char *file_name)
++read_for_checksum (int in_file_des, unsigned int file_size, char *file_name)
+ {
+   uint32_t crc;
+   char buf[BUFSIZ];
+-  int bytes_left;
+-  int bytes_read;
+-  int i;
++  unsigned int bytes_left;
++  unsigned int bytes_read;
++  unsigned int i;
+ 
+   crc = 0;
+ 
+-- 
+2.7.4
+
diff --git a/meta/recipes-extended/cpio/cpio_2.13.bb 
b/meta/recipes-extended/cpio/cpio_2.13.bb
index 3350ba710e..df5e09cae8 100644
--- a/meta/recipes-extended/cpio/cpio_2.13.bb
+++ b/meta/recipes-extended/cpio/cpio_2.13.bb
@@ -12,6 +12,7 @@ SRC_URI = "${GNU_MIRROR}/cpio/cpio-${PV}.tar.gz \
file://0001-obstack-Fix-a-clang-warning.patch \
file://CVE-2021-38185.patch \
file://0001-Use-__alignof__-with-clang.patch \
+   file://0001-Wrong-CRC-with-ASCII-CRC-for-large-files.patch \
file://run-ptest \
"
 
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#179751): 
https://lists.openembedded.org/g/openembedded-core/message/179751
Mute This Topic: https://lists.openembedded.org/mt/98092561/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] yocto-check-layer: scan additional layers for tested layer dependencies

2023-04-05 Thread Marek Vasut

On 4/5/23 08:48, Nicolas Dechesne wrote:

On Tue, Apr 4, 2023 at 11:36 PM Marek Vasut  wrote:


In case a LAYERDEPENDS of a tested layer contains a dependency which is
present in additional layers, such dependency does not get pulled into
the layer test as a dependency be default and instead of YCL stops and
reports it cannot find dependent layers.



Hmm. I know this script is slightly (!) convoluted.


Well ... yes.


But I think this is done 'by design'. Since you are expected to list all
your dependencies with --dependency when you are testing a layer.


I am not sure that is correct. I believe the script is designed to 
attempt to look up the dependencies of a layer automatically. That is 
what the --additional-layers parameter is for, to specify the search 
paths for the automatic layer dependency lookup. The --dependency is 
there to hard-include a layer in the test, e.g. in case it cannot be 
automatically detected because that dependency (layer) is somehow not 
resolvable.


At least that is my understanding.

And the result then is, you can have a directory with various layers, 
but the YCL with --additional-layers pointed into that directory will 
only pick the layers which are really required for validation of that 
tested layer, not the rest of them layers in that directory, which makes 
YCL runtime shorter . And that way, YCL can be used to test multiple 
arbitrary layers, which is useful in CI.



An example of this is a layer with LAYERDEPENDS = " core openembedded-core
"
and then by running YCL on such layer using the following invocation:
$ yocto-check-layer -d --additional-layers ../meta-openembedded/ --
../meta-board-distro



In this specific example, you are supposed to use --dependency
../meta-openembedded instead of --additional-layers, no?


I don't think so, the YCL should auto-lookup and auto-add the layers 
into dependencies from --additional-layers. That is my understanding of 
what --additional-layers is for, to do the auto-lookup/auto-add without 
having to explicitly list the dependencies on command line.



--additional-layers (see 31e53430f1bb6f73b82698b20ef7f1047313214a) is
supposed to bring extra layers when parsing/testing to mimic a full distro
or to manually force optional layers to be present. But --dependency is
still required to contain all potential dependencies.


Errr, uhhh.

That is really weird, the first question which comes to my mind 
regarding that commit message is -- why not use --dependency to cover 
those use cases listed in the commit message.


The second question which comes to my mind is, why does the 
additional-layers do automatic layer look up (based on LAYERDEPENDS) in 
the specified additional-layer directories, but then fails to actually 
add those layers into the build during the test (I think maybe that is 
what I am solving with this patch, without describing it well).


Well that turned out to be a wall of text too, sigh ...

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#179735): 
https://lists.openembedded.org/g/openembedded-core/message/179735
Mute This Topic: https://lists.openembedded.org/mt/98069983/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] yocto-check-layer: scan additional layers for tested layer dependencies

2023-04-04 Thread Marek Vasut
In case a LAYERDEPENDS of a tested layer contains a dependency which is
present in additional layers, such dependency does not get pulled into
the layer test as a dependency be default and instead of YCL stops and
reports it cannot find dependent layers.

An example of this is a layer with LAYERDEPENDS = " core openembedded-core "
and then by running YCL on such layer using the following invocation:
$ yocto-check-layer -d --additional-layers ../meta-openembedded/ -- 
../meta-board-distro
...
ERROR: Layer meta-board-distro depends on openembedded-layer and isn't found.
...

The fix here adds all layers in the --additional-layers list into layers
which are searched for dependencies of the tested layer. That way, even
layers present in additional-layers list are searched and possibly used
as dependencies for the layer check.

Signed-off-by: Marek Vasut 
---
Cc: Alexandre Belloni 
Cc: Nicolas Dechesne 
Cc: Richard Purdie 
---
 scripts/yocto-check-layer | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/yocto-check-layer b/scripts/yocto-check-layer
index 67cc71950f..fbb715c0af 100755
--- a/scripts/yocto-check-layer
+++ b/scripts/yocto-check-layer
@@ -144,7 +144,7 @@ def main():
 if not args.no_auto_dependency:
 depends = []
 for layer in layers:
-layer_depends = get_layer_dependencies(layer, dep_layers, logger)
+layer_depends = get_layer_dependencies(layer, dep_layers + 
additional_layers, logger)
 if layer_depends:
 for d in layer_depends:
 if d not in depends:
@@ -188,7 +188,7 @@ def main():
 missing_dependencies = not add_layer_dependencies(bblayersconf, layer, 
dep_layers, logger)
 if not missing_dependencies:
 for additional_layer in additional_layers:
-if not add_layer_dependencies(bblayersconf, additional_layer, 
dep_layers, logger):
+if not add_layer_dependencies(bblayersconf, additional_layer, 
dep_layers + additional_layers, logger):
 missing_dependencies = True
 break
 if missing_dependencies:
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#179710): 
https://lists.openembedded.org/g/openembedded-core/message/179710
Mute This Topic: https://lists.openembedded.org/mt/98069983/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] systemd-systemctl: Create machine-id with "uninitialized" text in it

2023-03-20 Thread Marek Vasut

On 3/20/23 03:23, ChenQi wrote:

On 3/20/23 06:55, Marek Vasut wrote:

On 3/17/23 15:32, Chen, Qi wrote:

Hi Marek,


Hi,

sorry for the delay


I used the following line in local.conf and the firstboot worked:
IMAGE_PREPROCESS_COMMAND:remove = "systemd_preset_all;"


But doesn't that also inhibit the rootfs-time preset-all ? I would 
like to keep that, I just need for the systemd firstboot units to run 
on first boot to do first boot system setup things, which they won't 
without the 'uninitialized' in /etc/machine-id .



1) Lacking of /etc/machine-id file also triggers firstboot.

2) systemd firstboot does 'preset-all'. If you enable firstboot, then 
you don't need rootfs-time preset-all.


All right, thank you. Please go ahead with the revert.

But can you please document this IMAGE_PREPROCESS_COMMAND:remove = 
"systemd_preset_all;" somewhere at least in the commit message, so 
others who run into non-working firstboot won't have to struggle with it 
? Maybe even add this into the comment in 'systemctl' script ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#178810): 
https://lists.openembedded.org/g/openembedded-core/message/178810
Mute This Topic: https://lists.openembedded.org/mt/97273986/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] systemd-systemctl: Create machine-id with "uninitialized" text in it

2023-03-19 Thread Marek Vasut

On 3/17/23 15:32, Chen, Qi wrote:

Hi Marek,


Hi,

sorry for the delay


I used the following line in local.conf and the firstboot worked:
IMAGE_PREPROCESS_COMMAND:remove = "systemd_preset_all;"


But doesn't that also inhibit the rootfs-time preset-all ? I would like 
to keep that, I just need for the systemd firstboot units to run on 
first boot to do first boot system setup things, which they won't 
without the 'uninitialized' in /etc/machine-id .



-Original Message-----
From: Marek Vasut 
Sent: Friday, March 17, 2023 7:54 PM
To: Chen, Qi ; openembedded-core@lists.openembedded.org
Cc: Alexandre Belloni ; Armin Kuster ; Bob Henz 
; Kristian Klausen ; Nick Potenski 
; Richard Purdie 
Subject: Re: [OE-core] [PATCH] systemd-systemctl: Create machine-id with 
"uninitialized" text in it

On 3/15/23 11:10, ChenQi wrote:

Hi,


This patch is forcing systemd to do preset-all at boot time (first
boot) in a function that simulates 'preset-all' at rootfs time.

If we look at the comments above the changed line, we can see that the
/etc/machine-id file was deliberately created as empty, for the
purpose of making systemd not treat the system as first boot.
"""
      # If we populate the systemd links we also create
/etc/machine-id, which
      # allows systemd to boot with the filesystem read-only before
generating
      # a real value and then committing it back.
      #
      # For the stateless configuration, where /etc is generated at
runtime
      # (for example on a tmpfs), this script shouldn't run at all and
we
      # allow systemd to completely populate /etc.
"""

I'm going to send out a patch to revert this patch.


Hmmm, the problem is that without this patch, systemd firstboot does not work 
and I would like to use that. How can we accommodate both options, i.e. no 
breakage for you and working systemd-firstboot ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#178797): 
https://lists.openembedded.org/g/openembedded-core/message/178797
Mute This Topic: https://lists.openembedded.org/mt/97273986/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] systemd-systemctl: Create machine-id with "uninitialized" text in it

2023-03-17 Thread Marek Vasut

On 3/15/23 11:10, ChenQi wrote:

Hi,

This patch is forcing systemd to do preset-all at boot time (first boot) 
in a function that simulates 'preset-all' at rootfs time.


If we look at the comments above the changed line, we can see that the 
/etc/machine-id file was deliberately created as empty, for the purpose 
of making systemd not treat the system as first boot.

"""
     # If we populate the systemd links we also create /etc/machine-id, 
which
     # allows systemd to boot with the filesystem read-only before 
generating

     # a real value and then committing it back.
     #
     # For the stateless configuration, where /etc is generated at runtime
     # (for example on a tmpfs), this script shouldn't run at all and we
     # allow systemd to completely populate /etc.
"""

I'm going to send out a patch to revert this patch.


Hmmm, the problem is that without this patch, systemd firstboot does not 
work and I would like to use that. How can we accommodate both options, 
i.e. no breakage for you and working systemd-firstboot ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#178750): 
https://lists.openembedded.org/g/openembedded-core/message/178750
Mute This Topic: https://lists.openembedded.org/mt/97273986/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] systemd-systemctl: Create machine-id with "uninitialized" text in it

2023-02-27 Thread Marek Vasut
Instead of creating empty /etc/machine-id file using touch, write
text "uninitialized" into it. Systemd requires "uninitialized" in
the /etc/machine-id file to trigger systemd-firstboot .

Signed-off-by: Marek Vasut 
---
Cc: Alexandre Belloni 
Cc: Armin Kuster 
Cc: Bob Henz 
Cc: Kristian Klausen 
Cc: Nick Potenski 
Cc: Richard Purdie 
---
 meta/recipes-core/systemd/systemd-systemctl/systemctl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/systemd/systemd-systemctl/systemctl 
b/meta/recipes-core/systemd/systemd-systemctl/systemctl
index cddae75a06..45b29671ee 100755
--- a/meta/recipes-core/systemd/systemd-systemctl/systemctl
+++ b/meta/recipes-core/systemd/systemd-systemctl/systemctl
@@ -302,7 +302,7 @@ def preset_all(root):
 # For the stateless configuration, where /etc is generated at runtime
 # (for example on a tmpfs), this script shouldn't run at all and we
 # allow systemd to completely populate /etc.
-(root / SYSCONFDIR / "machine-id").touch()
+(root / SYSCONFDIR / "machine-id").write_text("uninitialized")
 
 
 def main():
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177804): 
https://lists.openembedded.org/g/openembedded-core/message/177804
Mute This Topic: https://lists.openembedded.org/mt/97273986/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] systemd: Make importd depend on glib-2.0 again

2022-12-17 Thread Marek Vasut
It seems importd still requires glib-2.0, add the missing dependency.

Signed-off-by: Marek Vasut 
---
Cc: Khem Raj 
Cc: Richard Purdie 
---
 meta/recipes-core/systemd/systemd_251.8.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/systemd/systemd_251.8.bb 
b/meta/recipes-core/systemd/systemd_251.8.bb
index 5fb0e86982..8f2fb90455 100644
--- a/meta/recipes-core/systemd/systemd_251.8.bb
+++ b/meta/recipes-core/systemd/systemd_251.8.bb
@@ -144,7 +144,7 @@ PACKAGECONFIG[hostnamed] = 
"-Dhostnamed=true,-Dhostnamed=false"
 PACKAGECONFIG[idn] = "-Didn=true,-Didn=false"
 PACKAGECONFIG[ima] = "-Dima=true,-Dima=false"
 # importd requires journal-upload/xz/zlib/bzip2/gcrypt
-PACKAGECONFIG[importd] = "-Dimportd=true,-Dimportd=false"
+PACKAGECONFIG[importd] = "-Dimportd=true,-Dimportd=false,glib-2.0"
 # Update NAT firewall rules
 PACKAGECONFIG[iptc] = "-Dlibiptc=true,-Dlibiptc=false,iptables"
 PACKAGECONFIG[journal-upload] = "-Dlibcurl=true,-Dlibcurl=false,curl"
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#174782): 
https://lists.openembedded.org/g/openembedded-core/message/174782
Mute This Topic: https://lists.openembedded.org/mt/95738488/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] package_rpm: Fix Linux 6.1.0 perf 1.0 version mistranslation

2022-12-16 Thread Marek Vasut
With Linux 6.1.0 and perf 1.0-r9, a build which includes perf-dev fails due
to perf-dev depending on perf 6.6.1.0-r9 . This is because translate_vers()
operates on perf-dev and mangles its version. The following scenario occurs:

  ver=6.1.0-r9
  pv=1.0
  pkgv=6.1.0
  reppv=6.1.0

With Linux 6.1.0, a corner case is hit where pv is a substring of ver, which
yields this corrupted version 6.6.1.0-r9 . Example in python3:

  >>> "6.1.0-r9".replace("1.0", "6.1.0")
  '6.6.1.0-r9'
  >>> "6.0.13-r9".replace("1.0", "6.0.13")
  '6.0.13-r9'

The fix is to only replace pv with reppv in case pv is at the beginning
of ver , instead of replacing all occurences.

Signed-off-by: Marek Vasut 
---
Cc: Alexandre Belloni 
Cc: Pavel Zhukov 
Cc: Richard Purdie 
---
 meta/classes-global/package_rpm.bbclass | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/classes-global/package_rpm.bbclass 
b/meta/classes-global/package_rpm.bbclass
index 81a2060b68..39efcc328e 100644
--- a/meta/classes-global/package_rpm.bbclass
+++ b/meta/classes-global/package_rpm.bbclass
@@ -159,7 +159,9 @@ python write_specfile () {
 pv = subd['PV']
 pkgv = subd['PKGV']
 reppv = pkgv.replace('-', '+')
-ver = ver.replace(pv, reppv).replace(pkgv, reppv)
+if ver.startswith(pv):
+ver = ver.replace(pv, reppv)
+ver = ver.replace(pkgv, reppv)
 if 'PKGR' in subd:
 # Make sure PKGR rather than PR in ver
 pr = '-' + subd['PR']
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#174767): 
https://lists.openembedded.org/g/openembedded-core/message/174767
Mute This Topic: https://lists.openembedded.org/mt/95725182/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v3] bluez5: Point hciattach bcm43xx firmware search path to /lib/firmware

2022-11-01 Thread Marek Vasut
Currently the hciattach bcm43xx firmware loader looks up the firmware
blob in /etc/firmware . Change this to /lib/firmware instead, so that
the path is consistent with Linux kernel which also looks up firmware
for the WiFi part in /lib/firmware .

Signed-off-by: Marek Vasut 
---
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
V2: Replace hard-coded /lib with ${nonarch_base_libdir}
V3: Use CFLAGS += instead
---
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc 
b/meta/recipes-connectivity/bluez5/bluez5.inc
index f07e318897..a8eaba1dd6 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -68,6 +68,8 @@ EXTRA_OECONF = "\
   --without-zsh-completion-dir \
 "
 
+CFLAGS += "-DFIRMWARE_DIR=\\"${nonarch_base_libdir}/firmware\\""
+
 # bluez5 builds a large number of useful utilities but does not
 # install them.  Specify which ones we want put into ${PN}-noinst-tools.
 NOINST_TOOLS_READLINE ??= ""
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172391): 
https://lists.openembedded.org/g/openembedded-core/message/172391
Mute This Topic: https://lists.openembedded.org/mt/94721433/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] bluez5: Point hciattach bcm43xx firmware search path to /lib/firmware

2022-11-01 Thread Marek Vasut

On 11/1/22 21:41, Khem Raj wrote:

On 11/1/22 4:54 AM, Marek Vasut wrote:

Currently the hciattach bcm43xx firmware loader looks up the firmware
blob in /etc/firmware . Change this to /lib/firmware instead, so that
the path is consistent with Linux kernel which also looks up firmware
for the WiFi part in /lib/firmware .

Signed-off-by: Marek Vasut 
---
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
V2: Replace hard-coded /lib with ${nonarch_base_libdir}
---
  meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc 
b/meta/recipes-connectivity/bluez5/bluez5.inc

index f07e318897..a2aa7b86c4 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -68,6 +68,8 @@ EXTRA_OECONF = "\
    --without-zsh-completion-dir \
  "
+CFLAGS:append = " -DFIRMWARE_DIR=\\"${nonarch_base_libdir}/firmware\\""


why do we use append and not += here ?


Isn't the override syntax preferred now ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172389): 
https://lists.openembedded.org/g/openembedded-core/message/172389
Mute This Topic: https://lists.openembedded.org/mt/94707064/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2] bluez5: Point hciattach bcm43xx firmware search path to /lib/firmware

2022-11-01 Thread Marek Vasut
Currently the hciattach bcm43xx firmware loader looks up the firmware
blob in /etc/firmware . Change this to /lib/firmware instead, so that
the path is consistent with Linux kernel which also looks up firmware
for the WiFi part in /lib/firmware .

Signed-off-by: Marek Vasut 
---
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
V2: Replace hard-coded /lib with ${nonarch_base_libdir}
---
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc 
b/meta/recipes-connectivity/bluez5/bluez5.inc
index f07e318897..a2aa7b86c4 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -68,6 +68,8 @@ EXTRA_OECONF = "\
   --without-zsh-completion-dir \
 "
 
+CFLAGS:append = " -DFIRMWARE_DIR=\\"${nonarch_base_libdir}/firmware\\""
+
 # bluez5 builds a large number of useful utilities but does not
 # install them.  Specify which ones we want put into ${PN}-noinst-tools.
 NOINST_TOOLS_READLINE ??= ""
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172359): 
https://lists.openembedded.org/g/openembedded-core/message/172359
Mute This Topic: https://lists.openembedded.org/mt/94707064/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] bluez5: Point hciattach bcm43xx firmware search path to /lib/firmware

2022-10-31 Thread Marek Vasut

On 10/31/22 20:18, Jose Quaresma wrote:

Hi Marek,


Hi,


Marek Vasut  escreveu no dia segunda, 31/10/2022 à(s) 16:30:


Currently the hciattach bcm43xx firmware loader looks up the firmware
blob in /etc/firmware . Change this to /lib/firmware instead, so that
the path is consistent with Linux kernel which also looks up firmware
for the WiFi part in /lib/firmware .

Signed-off-by: Marek Vasut 
---
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
  meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc
b/meta/recipes-connectivity/bluez5/bluez5.inc
index f07e318897..fe10be7324 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -68,6 +68,8 @@ EXTRA_OECONF = "\
--without-zsh-completion-dir \
  "

+CFLAGS:append = " -DFIRMWARE_DIR=\\"/lib/firmware\\""



Escape chars can be tricky when parsing and as the path
doesn't have any space we can have " -DFIRMWARE_DIR=/lib/firmware"
or not?


No, because then the macro gets expanded in place in hciconfig_bcm43xx.c 
to something like printf(/lib/firmware); which the compiler does not 
like obviously. The quotes are really mandatory there, I tried various 
combinations (sigh) until I arrived at this working one.



Another options to avoid escape chars can be
CFLAGS:append = ' -DFIRMWARE_DIR="/lib/firmware"'


[...]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172340): 
https://lists.openembedded.org/g/openembedded-core/message/172340
Mute This Topic: https://lists.openembedded.org/mt/94689423/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] bluez5: Point hciattach bcm43xx firmware search path to /lib/firmware

2022-10-31 Thread Marek Vasut
Currently the hciattach bcm43xx firmware loader looks up the firmware
blob in /etc/firmware . Change this to /lib/firmware instead, so that
the path is consistent with Linux kernel which also looks up firmware
for the WiFi part in /lib/firmware .

Signed-off-by: Marek Vasut 
---
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc 
b/meta/recipes-connectivity/bluez5/bluez5.inc
index f07e318897..fe10be7324 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -68,6 +68,8 @@ EXTRA_OECONF = "\
   --without-zsh-completion-dir \
 "
 
+CFLAGS:append = " -DFIRMWARE_DIR=\\"/lib/firmware\\""
+
 # bluez5 builds a large number of useful utilities but does not
 # install them.  Specify which ones we want put into ${PN}-noinst-tools.
 NOINST_TOOLS_READLINE ??= ""
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172331): 
https://lists.openembedded.org/g/openembedded-core/message/172331
Mute This Topic: https://lists.openembedded.org/mt/94689423/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [dunfell][PATCH] lttng-modules: Backport Linux 5.18+, 5.15.44+, 5.10.119+ fixes

2022-06-25 Thread Marek Vasut

On 6/26/22 02:01, Steve Sakoman wrote:

I can add the extra info.


Nice, thanks !

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#167302): 
https://lists.openembedded.org/g/openembedded-core/message/167302
Mute This Topic: https://lists.openembedded.org/mt/91992313/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [dunfell][PATCH] lttng-modules: Backport Linux 5.18+, 5.15.44+, 5.10.119+ fixes

2022-06-25 Thread Marek Vasut

On 6/26/22 01:26, Jason A. Donenfeld wrote:

On Sun, Jun 26, 2022 at 12:39:36AM +0200, Marek Vasut wrote:

The Linux kernel commit 14c174633f349 ("random: remove unused tracepoints")
removed unused tracepoints and has been backported to stable Linux kernel
releases. This causes build failure of lttng-modules:

"
lttng-modules-2.11.6/probes/lttng-probe-random.c:18:10: fatal error: 
trace/events/random.h: No such file or directory
|18 | #include 
|   |  ^~~
| compilation terminated.
"

Backport patches from lttng-modules master branch to address the build
failure on all of Linux 5.18.y, 5.15.y and 5.10.y kernel versions.


Also 5.4, 4.19, 4.14, and 4.9.


Do you want a V2 with this updated commit message ?
(or, can Steve add this line when applying?)

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#167300): 
https://lists.openembedded.org/g/openembedded-core/message/167300
Mute This Topic: https://lists.openembedded.org/mt/91992313/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] lttng-modules: Backport Linux 5.18+, 5.15.44+, 5.10.119+ fixes

2022-06-25 Thread Marek Vasut
The Linux kernel commit 14c174633f349 ("random: remove unused tracepoints")
removed unused tracepoints and has been backported to stable Linux kernel
releases. This causes build failure of lttng-modules:

"
lttng-modules-2.11.6/probes/lttng-probe-random.c:18:10: fatal error: 
trace/events/random.h: No such file or directory
|18 | #include 
|   |  ^~~
| compilation terminated.
"

Backport patches from lttng-modules master branch to address the build
failure on all of Linux 5.18.y, 5.15.y and 5.10.y kernel versions.

Signed-off-by: Marek Vasut 
Cc: Bruce Ashfield 
Cc: Steve Sakoman 
---
 ...ndom-remove-unused-tracepoints-v5.18.patch | 46 +
 ...emove-unused-tracepoints-v5.10-v5.15.patch | 45 
 ...racepoints-removed-in-stable-kernels.patch | 51 +++
 .../lttng/lttng-modules_2.11.6.bb |  3 ++
 4 files changed, 145 insertions(+)
 create mode 100644 
meta/recipes-kernel/lttng/lttng-modules/0017-fix-random-remove-unused-tracepoints-v5.18.patch
 create mode 100644 
meta/recipes-kernel/lttng/lttng-modules/0018-fix-random-remove-unused-tracepoints-v5.10-v5.15.patch
 create mode 100644 
meta/recipes-kernel/lttng/lttng-modules/0019-fix-random-tracepoints-removed-in-stable-kernels.patch

diff --git 
a/meta/recipes-kernel/lttng/lttng-modules/0017-fix-random-remove-unused-tracepoints-v5.18.patch
 
b/meta/recipes-kernel/lttng/lttng-modules/0017-fix-random-remove-unused-tracepoints-v5.18.patch
new file mode 100644
index 00..3fc7fd733d
--- /dev/null
+++ 
b/meta/recipes-kernel/lttng/lttng-modules/0017-fix-random-remove-unused-tracepoints-v5.18.patch
@@ -0,0 +1,46 @@
+From 25b70c486bb96de0caf7cea1da42ed07801cca84 Mon Sep 17 00:00:00 2001
+From: Michael Jeanson 
+Date: Mon, 4 Apr 2022 14:33:42 -0400
+Subject: [PATCH 17/19] fix: random: remove unused tracepoints (v5.18)
+
+See upstream commit :
+
+  commit 14c174633f349cb41ea90c2c0aaddac157012f74
+  Author: Jason A. Donenfeld 
+  Date:   Thu Feb 10 16:40:44 2022 +0100
+
+random: remove unused tracepoints
+
+These explicit tracepoints aren't really used and show sign of aging.
+It's work to keep these up to date, and before I attempted to keep them
+up to date, they weren't up to date, which indicates that they're not
+really used. These days there are better ways of introspecting anyway.
+
+Upstream-Status: Backport [369d82bb1746447514c877088d7c5fd0f39140f8]
+Change-Id: I3b8c3e2732e7efdd76ce63204ac53a48784d0df6
+Signed-off-by: Michael Jeanson 
+Signed-off-by: Mathieu Desnoyers 
+---
+ probes/Kbuild | 5 -
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/probes/Kbuild b/probes/Kbuild
+index 3ae2d39e..58da82b8 100644
+--- a/probes/Kbuild
 b/probes/Kbuild
+@@ -215,8 +215,11 @@ ifneq ($(CONFIG_FRAME_WARN),0)
+   CFLAGS_lttng-probe-printk.o += -Wframe-larger-than=2200
+ endif
+ 
++# Introduced in v3.6, remove in v5.18
+ obj-$(CONFIG_LTTNG) +=  $(shell \
+-if [ $(VERSION) -ge 4 \
++if [ \( ! \( $(VERSION) -ge 6 -o \( $(VERSION) -eq 5 -a $(PATCHLEVEL) -ge 
18 \) \) \) \
++  -a \
++  $(VERSION) -ge 4 \
+   -o \( $(VERSION) -eq 3 -a $(PATCHLEVEL) -ge 6 \) \
+   -o \( $(VERSION) -eq 3 -a $(PATCHLEVEL) -eq 5 -a $(SUBLEVEL) -ge 2 \) \
+   -o \( $(VERSION) -eq 3 -a $(PATCHLEVEL) -eq 4 -a $(SUBLEVEL) -ge 9 \) \
+-- 
+2.35.1
+
diff --git 
a/meta/recipes-kernel/lttng/lttng-modules/0018-fix-random-remove-unused-tracepoints-v5.10-v5.15.patch
 
b/meta/recipes-kernel/lttng/lttng-modules/0018-fix-random-remove-unused-tracepoints-v5.10-v5.15.patch
new file mode 100644
index 00..5c324a9bde
--- /dev/null
+++ 
b/meta/recipes-kernel/lttng/lttng-modules/0018-fix-random-remove-unused-tracepoints-v5.10-v5.15.patch
@@ -0,0 +1,45 @@
+From da956d1444139883f5d01078d945078738ffade4 Mon Sep 17 00:00:00 2001
+From: He Zhe 
+Date: Thu, 2 Jun 2022 06:36:08 +
+Subject: [PATCH 18/19] fix: random: remove unused tracepoints (v5.10, v5.15)
+
+The following kernel commit has been back ported to v5.10.119 and v5.15.44.
+
+commit 14c174633f349cb41ea90c2c0aaddac157012f74
+Author: Jason A. Donenfeld 
+Date:   Thu Feb 10 16:40:44 2022 +0100
+
+  random: remove unused tracepoints
+
+  These explicit tracepoints aren't really used and show sign of aging.
+  It's work to keep these up to date, and before I attempted to keep them
+  up to date, they weren't up to date, which indicates that they're not
+  really used. These days there are better ways of introspecting anyway.
+
+Upstream-Status: Backport [1901e0eb58795e850e8fdcb5e1c235e4397b470d]
+Signed-off-by: He Zhe 
+Signed-off-by: Mathieu Desnoyers 
+Change-Id: I0b7eb8aa78b5bd2039e20ae3e1da4c5eb9018789
+---
+ probes/Kbuild | 5 -
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/probes/Kbuild b/probes/Kbuild
+index 58da82b8..87f2d681 100644
+--- a/probes/Kbuild
 b/probes/Kbuild
+@@ -217,7 +217,10 @@ endif
+ 
+ # Introduced in v3.6, remove in v5.18

[OE-core] [dunfell][PATCH] perf-tests: add bash into RDEPENDS (v5.12-rc5+)

2022-03-09 Thread Marek Vasut
From: Bruce Ashfield 

Upstream commit:

   commit 1dc481c0b0cf18d3952d93a73c4ece90dec277f0
   Author: Leo Yan 
   Date:   Sat Mar 20 18:45:54 2021 +0800

   perf test: Change to use bash for daemon test

   When executing the daemon test on Arm64 and x86 with Debian (Buster)
   distro, both skip the test case with the log:

Changes tools/perf/tests/shell/daemon.sh to be explicitly bash
(it was already required, but was just skipped on various
distros).

We add it into our RDEPENDS for perf-tests to fixup 5.12+
builds.

We already have relatively heavy RDEPENDS for perf tests (python3), so
adding bash into the RDEPENDS isn't signifcant even for older perf
builds that use the same recipe.

(cherry picked from commit 159cdb159ad0e9d3ed73cfc07f9acd5c0b608e7b)
Signed-off-by: Bruce Ashfield 
Signed-off-by: Richard Purdie 
---
 meta/recipes-kernel/perf/perf.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index e04047e85a..9c9bf1647f 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -267,7 +267,7 @@ RDEPENDS_${PN} += "elfutils bash"
 RDEPENDS_${PN}-archive =+ "bash"
 RDEPENDS_${PN}-python =+ "bash python3 python3-modules 
${@bb.utils.contains('PACKAGECONFIG', 'audit', 'audit-python', '', d)}"
 RDEPENDS_${PN}-perl =+ "bash perl perl-modules"
-RDEPENDS_${PN}-tests =+ "python3"
+RDEPENDS_${PN}-tests =+ "python3 bash"
 
 RSUGGESTS_SCRIPTING = "${@bb.utils.contains('PACKAGECONFIG', 'scripting', 
'${PN}-perl ${PN}-python', '',d)}"
 RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#162992): 
https://lists.openembedded.org/g/openembedded-core/message/162992
Mute This Topic: https://lists.openembedded.org/mt/89673138/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] cml1.bbclass: Handle ncurses-native being available via pkg-config

2022-03-01 Thread Marek Vasut
From: Nathan Rossi 

The linux kernel will by default use pkg-config to get ncurses(w) paths,
falling back to absolute path checks otherwise. If the build host does
not have ncurses installed this will fail as pkg-config will not search
the native sysroot for ncurses.

To more all kernel/kconfig sources, inject the equivalent native
pkg-config variables similar to what is done by the pkg-config-native
script. This only affects the menuconfig python task itself and the
oe_terminal call inside it.

(cherry picked from commit abb95c421bb67d452691819e3f63dabd02e2ba37)
Signed-off-by: Nathan Rossi 
Signed-off-by: Richard Purdie 
---
 meta/classes/cml1.bbclass | 8 
 1 file changed, 8 insertions(+)

diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index 8ab240589a..46a19fce32 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -36,6 +36,14 @@ python do_menuconfig() {
 except OSError:
 mtime = 0
 
+# setup native pkg-config variables (kconfig scripts call pkg-config 
directly, cannot generically be overriden to pkg-config-native)
+d.setVar("PKG_CONFIG_DIR", 
"${STAGING_DIR_NATIVE}${libdir_native}/pkgconfig")
+d.setVar("PKG_CONFIG_PATH", 
"${PKG_CONFIG_DIR}:${STAGING_DATADIR_NATIVE}/pkgconfig")
+d.setVar("PKG_CONFIG_LIBDIR", "${PKG_CONFIG_DIR}")
+d.setVarFlag("PKG_CONFIG_SYSROOT_DIR", "unexport", "1")
+# ensure that environment variables are overwritten with this tasks 'd' 
values
+d.appendVar("OE_TERMINAL_EXPORTS", " PKG_CONFIG_DIR PKG_CONFIG_PATH 
PKG_CONFIG_LIBDIR PKG_CONFIG_SYSROOT_DIR")
+
 oe_terminal("sh -c \"make %s; if [ \\$? -ne 0 ]; then echo 'Command 
failed.'; printf 'Press any key to continue... '; read r; fi\"" % 
d.getVar('KCONFIG_CONFIG_COMMAND'),
 d.getVar('PN') + ' Configuration', d)
 
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#162582): 
https://lists.openembedded.org/g/openembedded-core/message/162582
Mute This Topic: https://lists.openembedded.org/mt/89490972/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] bootchart2: Add missing python3-math dependency

2022-03-01 Thread Marek Vasut
Without this dependency, generating the bootchart may fail with:
"
ModuleNotFoundError: No module named 'random'
"

(cherry picked from commit 487e9f16a00f895159b79f1865fe8b626b47ddc2)
Signed-off-by: Marek Vasut 
Cc: Mingli Yu 
Cc: Richard Purdie 
---
 meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb 
b/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
index 66bd897a9a..7f05bd1b0b 100644
--- a/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
+++ b/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
@@ -144,7 +144,7 @@ do_install () {
 
 PACKAGES =+ "pybootchartgui"
 FILES_pybootchartgui += "${PYTHON_SITEPACKAGES_DIR}/pybootchartgui 
${bindir}/pybootchartgui"
-RDEPENDS_pybootchartgui = "python3-pycairo python3-compression python3-image 
python3-shell python3-compression python3-codecs"
+RDEPENDS_pybootchartgui = "python3-pycairo python3-compression python3-image 
python3-math python3-shell python3-compression python3-codecs"
 RDEPENDS_${PN}_class-target += "${@bb.utils.contains('DISTRO_FEATURES', 
'sysvinit', 'sysvinit-pidof', 'procps', d)}"
 RDEPENDS_${PN}_class-target += "lsb-release"
 DEPENDS_append_class-native = " python3-pycairo-native"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#162581): 
https://lists.openembedded.org/g/openembedded-core/message/162581
Mute This Topic: https://lists.openembedded.org/mt/89490963/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] kernel-fitimage: Add missing dependency for UBOOT_ENV

2022-02-10 Thread Marek Vasut

On 1/29/22 01:57, Marek Vasut wrote:

For $UBOOT_ENV file to appear in sysroot, virtual/bootloader
must populate sysroot first. Add the missing dependency.

Signed-off-by: Marek Vasut 
Cc: Richard Purdie 
---
  meta/classes/kernel-fitimage.bbclass | 4 
  1 file changed, 4 insertions(+)

diff --git a/meta/classes/kernel-fitimage.bbclass 
b/meta/classes/kernel-fitimage.bbclass
index 1e3bc21f1f..507e0a2213 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -36,6 +36,10 @@ python __anonymous () {
  if image:
  d.appendVarFlag('do_assemble_fitimage_initramfs', 'depends', ' 
${INITRAMFS_IMAGE}:do_image_complete')
  
+ubootenv = d.getVar('UBOOT_ENV')

+if ubootenv:
+d.appendVarFlag('do_assemble_fitimage', 'depends', ' 
virtual/bootloader:do_populate_sysroot')
+
  #check if there are any dtb providers
  providerdtb = d.getVar("PREFERRED_PROVIDER_virtual/dtb")
  if providerdtb:


I think "bump" is in order by now.

Can you please pick this one ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161630): 
https://lists.openembedded.org/g/openembedded-core/message/161630
Mute This Topic: https://lists.openembedded.org/mt/88758951/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-02-02 Thread Marek Vasut

On 2/2/22 07:51, Valek, Andrej wrote:

Marek,


Hello Andrej,


Sorry, but these are still not an arguments, why to do that.


I'm sorry, I am lost and confused ... what part of the email are you 
referring to ?



On Mon, 2022-01-31 at 10:39 +0100, Marek Vasut wrote:

On 1/31/22 08:01, Valek, Andrej wrote:

Hi,


Hello Andrej,

(please avoid top-posting)


Sorry, but personally I don't like your idea. What's the benefit of
reverting this? I would keep the ${} for bitbake and $ for shell. The
{} has to be placed only for variables like $a${b}c.


That's exactly the benefit of using ${} in shell scripts consistently -
-
you don't have to worry about variable names being accidentally
conflated with surrounding strings, either due to your own mistake, or
some automated transformation that was applied incorrectly .


We should respect the workflow on all recipes otherwise we're braking
the "unwritten" rules.


The workflow on all recipes ? What does this mean ?

broken by people. Better update the documentation.

There is one technical counter-argument to this revert from Peter,
quote:
"
There is actually a technical reason to not use ${foo} for shell
variables unless necessary in bitbake files and it is because
bitbake will treat them all as potential bitbake variables. This
means they are unnecessarily included in the taskhashes that
bitbake calculates.
"

But the patch being reverted here addresses the problem only partly,
because it still contains remnants like this:
"
conf_desc="$conf_desc${sep}setup"
"

Just for your information, this is not remnants, this is exactly the
right {} usage. If you didn't place the {}, it will be
conf_desc="$conf_desc$sepsetup", which doesn't  make any sense.


OK, one more time then.

Either your patch attempted to change the coding style of this script to 
match your personal preference, and did it only partly, so the result is 
inconsistent.


Or

You were fixing the aforementioned taskhash issue, in which case the 
taskhash issue is also fixed only partly.


The commit message is not clear on what the intention was.

[...]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161184): 
https://lists.openembedded.org/g/openembedded-core/message/161184
Mute This Topic: https://lists.openembedded.org/mt/88758521/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-01-31 Thread Marek Vasut

On 1/31/22 08:01, Valek, Andrej wrote:

Hi,


Hello Andrej,

(please avoid top-posting)


Sorry, but personally I don't like your idea. What's the benefit of
reverting this? I would keep the ${} for bitbake and $ for shell. The
{} has to be placed only for variables like $a${b}c.


That's exactly the benefit of using ${} in shell scripts consistently -- 
you don't have to worry about variable names being accidentally 
conflated with surrounding strings, either due to your own mistake, or 
some automated transformation that was applied incorrectly .



We should respect the workflow on all recipes otherwise we're braking
the "unwritten" rules.


The workflow on all recipes ? What does this mean ?

The "unwritten" rules ? If they are unwritten, of course they will be 
broken by people. Better update the documentation.


There is one technical counter-argument to this revert from Peter, quote:
"
There is actually a technical reason to not use ${foo} for shell
variables unless necessary in bitbake files and it is because
bitbake will treat them all as potential bitbake variables. This
means they are unnecessarily included in the taskhashes that
bitbake calculates.
"

But the patch being reverted here addresses the problem only partly, 
because it still contains remnants like this:

"
conf_desc="$conf_desc${sep}setup"
"

[...]


third alternative ? I mean, besides rewriting the fitimage
generation into python, which might make it more flexible too.


Replacing shell code that has grown beyond a couple of hundred
(tens?) lines with something written in a better language is
almost always a good idea.


It's grown to almost 800 LoC, so maybe it is time to reevaluate the
python conversion then.


So a rewrite into something more suitable might be a good idea ^ , 
probably python in this case.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161120): 
https://lists.openembedded.org/g/openembedded-core/message/161120
Mute This Topic: https://lists.openembedded.org/mt/88758521/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-01-28 Thread Marek Vasut

On 1/29/22 03:01, Peter Kjellerstedt wrote:

Hi,

[...]


Personally I do not see it as inconsistent, it is just the way
shell handles variables. It is just something to get used to (I
also had a colleague who would review any shell code changes we
made and comment on every single unnecessary character so one
quickly learned to use $foo everywhere possible rather than
${foo}...)


On the other hand, once you get burnt ${foo}bar / $foobar , you might 
quickly start putting the {} everywhere. That's my case.


(we should likely stop this ^ discussion thread before it turns into a 
flamewar)



That said, I have never looked at this code so I
have no real idea of how bad it is or isn't.


This patch lists pretty much all the vars, so you can get a pretty 
decent idea from just looking at that.



third alternative ? I mean, besides rewriting the fitimage
generation into python, which might make it more flexible too.


Replacing shell code that has grown beyond a couple of hundred
(tens?) lines with something written in a better language is
almost always a good idea.


It's grown to almost 800 LoC, so maybe it is time to reevaluate the 
python conversion then.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161094): 
https://lists.openembedded.org/g/openembedded-core/message/161094
Mute This Topic: https://lists.openembedded.org/mt/88758521/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-01-28 Thread Marek Vasut

On 1/29/22 02:06, Peter Kjellerstedt wrote:

-Original Message-
From: openembedded-core@lists.openembedded.org  On Behalf Of Marek Vasut
Sent: den 29 januari 2022 01:29
To: openembedded-core@lists.openembedded.org
Cc: Marek Vasut ; Andrej Valek ;
Richard Purdie 
Subject: [OE-core] [PATCH] Revert "featimage: refactor style"

This reverts commit f44bb458884da64356ee188917094b5515d3b159.

The reverted patch attempted to perform some sort of clean up, however
it only brought in style inconsistencies like this:

```
conf_desc="$conf_desc${sep}setup"
```

The curly brackets around variables were placed in the kernel-fitimage
bbclass deliberately, since when assembling the fitimage ITS there are
multiple variables where it is difficult to identify where the variable
ends and some sort of follow up string starts.


There is actually a technical reason to not use ${foo} for shell
variables unless necessary in bitbake files and it is because
bitbake will treat them all as potential bitbake variables. This
means they are unnecessarily included in the taskhashes that
bitbake calculates.


Yikes. (it would be good to include this gem in the commit message)

So are we stuck with this inconsistent coding style change or is there a 
third alternative ? I mean, besides rewriting the fitimage generation 
into python, which might make it more flexible too.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161090): 
https://lists.openembedded.org/g/openembedded-core/message/161090
Mute This Topic: https://lists.openembedded.org/mt/88758521/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] kernel-fitimage: Add missing dependency for UBOOT_ENV

2022-01-28 Thread Marek Vasut
For $UBOOT_ENV file to appear in sysroot, virtual/bootloader
must populate sysroot first. Add the missing dependency.

Signed-off-by: Marek Vasut 
Cc: Richard Purdie 
---
 meta/classes/kernel-fitimage.bbclass | 4 
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/kernel-fitimage.bbclass 
b/meta/classes/kernel-fitimage.bbclass
index 1e3bc21f1f..507e0a2213 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -36,6 +36,10 @@ python __anonymous () {
 if image:
 d.appendVarFlag('do_assemble_fitimage_initramfs', 'depends', ' 
${INITRAMFS_IMAGE}:do_image_complete')
 
+ubootenv = d.getVar('UBOOT_ENV')
+if ubootenv:
+d.appendVarFlag('do_assemble_fitimage', 'depends', ' 
virtual/bootloader:do_populate_sysroot')
+
 #check if there are any dtb providers
 providerdtb = d.getVar("PREFERRED_PROVIDER_virtual/dtb")
 if providerdtb:
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#161088): 
https://lists.openembedded.org/g/openembedded-core/message/161088
Mute This Topic: https://lists.openembedded.org/mt/88758951/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] Revert "featimage: refactor style"

2022-01-28 Thread Marek Vasut
This reverts commit f44bb458884da64356ee188917094b5515d3b159.

The reverted patch attempted to perform some sort of clean up, however
it only brought in style inconsistencies like this:

```
conf_desc="$conf_desc${sep}setup"
```

The curly brackets around variables were placed in the kernel-fitimage
bbclass deliberately, since when assembling the fitimage ITS there are
multiple variables where it is difficult to identify where the variable
ends and some sort of follow up string starts.

Signed-off-by: Marek Vasut 
Cc: Andrej Valek 
Cc: Richard Purdie 
---
 meta/classes/kernel-fitimage.bbclass | 289 +--
 meta/classes/uboot-sign.bbclass  |  56 +++---
 2 files changed, 171 insertions(+), 174 deletions(-)

diff --git a/meta/classes/kernel-fitimage.bbclass 
b/meta/classes/kernel-fitimage.bbclass
index b0c971b0eb..1e3bc21f1f 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -73,7 +73,7 @@ FIT_SIGN_INDIVIDUAL ?= "0"
 #
 # $1 ... .its filename
 fitimage_emit_fit_header() {
-   cat << EOF >> $1
+   cat << EOF >> ${1}
 /dts-v1/;
 
 / {
@@ -94,24 +94,24 @@ EOF
 fitimage_emit_section_maint() {
case $2 in
imagestart)
-   cat << EOF >> $1
+   cat << EOF >> ${1}
 
 images {
 EOF
;;
confstart)
-   cat << EOF >> $1
+   cat << EOF >> ${1}
 
 configurations {
 EOF
;;
sectend)
-   cat << EOF >> $1
+   cat << EOF >> ${1}
};
 EOF
;;
fitend)
-   cat << EOF >> $1
+   cat << EOF >> ${1}
 };
 EOF
;;
@@ -137,28 +137,28 @@ fitimage_emit_section_kernel() {
awk '$3=="${UBOOT_ENTRYSYMBOL}" {print "0x"$1;exit}'`
fi
 
-   cat << EOF >> $1
-kernel-$2 {
+   cat << EOF >> ${1}
+kernel-${2} {
 description = "Linux kernel";
-data = /incbin/("$3");
+data = /incbin/("${3}");
 type = "kernel";
 arch = "${UBOOT_ARCH}";
 os = "linux";
-compression = "$4";
+compression = "${4}";
 load = <${UBOOT_LOADADDRESS}>;
-entry = <$ENTRYPOINT>;
+entry = <${ENTRYPOINT}>;
 hash-1 {
-algo = "$kernel_csum";
+algo = "${kernel_csum}";
 };
 };
 EOF
 
-   if [ "${UBOOT_SIGN_ENABLE}" = "1" -a "${FIT_SIGN_INDIVIDUAL}" = "1" -a 
-n "$kernel_sign_keyname" ] ; then
-   sed -i '$ d' $1
-   cat << EOF >> $1
+   if [ "${UBOOT_SIGN_ENABLE}" = "1" -a "${FIT_SIGN_INDIVIDUAL}" = "1" -a 
-n "${kernel_sign_keyname}" ] ; then
+   sed -i '$ d' ${1}
+   cat << EOF >> ${1}
 signature-1 {
-algo = "$kernel_csum,$kernel_sign_algo";
-key-name-hint = "$kernel_sign_keyname";
+algo = "${kernel_csum},${kernel_sign_algo}";
+key-name-hint = "${kernel_sign_keyname}";
 };
 };
 EOF
@@ -186,26 +186,26 @@ fitimage_emit_section_dtb() {
elif [ -n "${UBOOT_DTB_LOADADDRESS}" ]; then
dtb_loadline="load = <${UBOOT_DTB_LOADADDRESS}>;"
fi
-   cat << EOF >> $1
-fdt-$2 {
+   cat << EOF >> ${1}
+fdt-${2} {
 description = "Flattened Device Tree blob";
-data = /incbin/("$3");
+data = /incbin/("${3}");
 type = "flat_dt";
 arch = "${UBOOT_ARCH}";
 compression = "none";
-$dtb_loadline
+${dtb_loadline}
 hash-1 {
-algo = "$dtb_csum";
+algo = "${dtb_csum}";
 };
 };
 EOF
 
-   if [ "${UBOOT_SIGN_ENABLE}" = "1" -a "${FIT_SIGN

Re: [OE-core][RFC PATCH 01/12] gstreamer1.0: 1.18.5 -> 1.20.0

2022-01-26 Thread Marek Vasut

On 1/26/22 11:28, Claudius Heine wrote:

[...]


diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-source.inc 
b/meta/recipes-multimedia/gstreamer/gstreamer1.0-source.inc
new file mode 100644
index 00..ca38322576
--- /dev/null
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-source.inc
@@ -0,0 +1,5 @@
+REVISION = "4f7e881fcc2e6df3ce04584cf5edb07b2682891a"
+
+SRC_BASE = "${WORKDIR}/gstreamer-${REVISION}"
+SRC_URI = 
"https://gitlab.freedesktop.org/gstreamer/gstreamer/-/archive/${REVISION}/gstreamer-${REVISION}.tar.gz;
+SRC_URI[sha256sum] = 
"bc9f6b9402d7575d8a7490f0aae347e6b524741cc459cb7aa25040fb55fcb606"


Would it make sense to fetch gstreamer sources from git instead of 
tarballs ?


Then you just set SRCREV to point to specific commit .

Git also seems to make development a bit easier .

[...]


diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.18.5.bb 
b/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.20.0.bb


Maybe the filename should be 1.19.90 until 1.20 is out ?

[...]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160978): 
https://lists.openembedded.org/g/openembedded-core/message/160978
Mute This Topic: https://lists.openembedded.org/mt/88693641/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] [dunfell] binutils: Backport Include members in the variable table used when resolving DW_AT_specification tags.

2022-01-22 Thread Marek Vasut
Backport binutils upstream patch fixing sporadic link errors in c++ code.
This triggers at least on arm32 and aarch64 with qt5 based applications.

The ChangeLog part of the patch as well as space change is omitted.

Binutils bug report for this problem is here:
https://sourceware.org/bugzilla/show_bug.cgi?id=26520

Signed-off-by: Marek Vasut 
Cc: Richard Purdie 
Cc: Steve Sakoman 
---
 .../binutils/binutils-2.34.inc|  1 +
 ...in-the-variable-table-used-when-reso.patch | 32 +++
 2 files changed, 33 insertions(+)
 create mode 100644 
meta/recipes-devtools/binutils/binutils/0018-Include-members-in-the-variable-table-used-when-reso.patch

diff --git a/meta/recipes-devtools/binutils/binutils-2.34.inc 
b/meta/recipes-devtools/binutils/binutils-2.34.inc
index 6104bec591..903b9d7b01 100644
--- a/meta/recipes-devtools/binutils/binutils-2.34.inc
+++ b/meta/recipes-devtools/binutils/binutils-2.34.inc
@@ -42,6 +42,7 @@ SRC_URI = "\
  file://0015-sync-with-OE-libtool-changes.patch \
  file://0016-Check-for-clang-before-checking-gcc-version.patch \
  file://0017-binutils-drop-redundant-program_name-definition-fno-.patch \
+ file://0018-Include-members-in-the-variable-table-used-when-reso.patch \
  file://CVE-2020-0551.patch \
  file://0001-gas-improve-reproducibility-for-stabs-debugging-data.patch \
  file://CVE-2020-16592.patch \
diff --git 
a/meta/recipes-devtools/binutils/binutils/0018-Include-members-in-the-variable-table-used-when-reso.patch
 
b/meta/recipes-devtools/binutils/binutils/0018-Include-members-in-the-variable-table-used-when-reso.patch
new file mode 100644
index 00..dc1e09d46b
--- /dev/null
+++ 
b/meta/recipes-devtools/binutils/binutils/0018-Include-members-in-the-variable-table-used-when-reso.patch
@@ -0,0 +1,32 @@
+From bf2252dca8c76e4c1f1c2dbf98dab7ffc9f5e5af Mon Sep 17 00:00:00 2001
+From: Nick Clifton 
+Date: Sat, 29 Aug 2020 08:03:15 +0100
+Subject: [PATCH] Include members in the variable table used when resolving
+ DW_AT_specification tags.
+
+   PR 26520
+   * dwarf2.c (scan_unit_for_symbols): Add member entries to the
+   variable table.
+
+Upstream-Status: Backport 
[https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e6f04d55f681149a69102a73937d0987719c3f16]
+---
+ bfd/dwarf2.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
+index dd3568a8532..ef2f6a3c63c 100644
+--- a/bfd/dwarf2.c
 b/bfd/dwarf2.c
+@@ -3248,7 +3248,8 @@ scan_unit_for_symbols (struct comp_unit *unit)
+   else
+   {
+ func = NULL;
+-if (abbrev->tag == DW_TAG_variable)
++if (abbrev->tag == DW_TAG_variable
++|| abbrev->tag == DW_TAG_member)
+   {
+ bfd_size_type amt = sizeof (struct varinfo);
+ var = (struct varinfo *) bfd_zalloc (abfd, amt);
+-- 
+2.34.1
+
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160861): 
https://lists.openembedded.org/g/openembedded-core/message/160861
Mute This Topic: https://lists.openembedded.org/mt/88618210/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] ffmpeg: Update from 4.4.1 to 5.0

2022-01-20 Thread Marek Vasut

On 1/20/22 21:15, Khem Raj wrote:

there are bunch of failures in meta-openembedded as well  see

https://errors.yoctoproject.org/Errors/Build/138784/


So, how shall we proceed here ?

I suspect Alex will send a patch for the problem detected in oe-core and 
then oe-core with ffmpeg 5.0 won't be broken anymore.


As for the rest of the recipes in meta-openembedded, they will likely be 
catching up to ffmpeg 5.0 over time, so we can either upgrade them, or 
patch them. I suspect the former is more favorable approach.


However, what is not clear to me is whether this breakage in 
meta-openembedded is a blocker for this patch to be applied to oe-core 
(with the fix from Alex), or not ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160782): 
https://lists.openembedded.org/g/openembedded-core/message/160782
Mute This Topic: https://lists.openembedded.org/mt/88516624/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] [dunfell] Revert "weston: Use systemd notify,"

2022-01-19 Thread Marek Vasut
Commit 4efdcc1090 ("weston: Use systemd notify,") has non-trivial to
backport dependencies without which it cannot work, revert backport.

In oe-core dunfell, weston is still started using /usr/bin/weston-start
script in meta/recipes-graphics/wayland/weston-init/weston@.service .
Since 76ed534267 ("weston-init: Use weston-launch when starting weston
as the first windowing system"), the weston-start script starts weston
using weston-launch executable in case $DISPLAY is not set, i.e. when
weston is started as the primary compositor.

When weston is started via weston-launch, the notification to systemd
is not delivered, and weston service fails to start with the following:
"
weston@root.service: start operation timed out. Terminating.
"

The weston systemd service has been reworked considerably since oe-core
dunfell in commit c21fa5a291 ("weston-init: Redefine weston service and
add socket activation option"), which replaced the use of weston-start
in weston@.service with plain weston, and has been further improved in
commit dd83fb40f7 ("weston-init: Stop running weston as root") . The
commit reverted here, oe-core/master commit c8aa0222ce ("weston: wrapper
for weston modules argument"), landed only with the two aforementioned
reworks already in place, therefore the commit could have never been
tested with weston started via weston-launch executable and the timeout
at delivering systemd notification could not have happened in master.

Both c21fa5a291 ("weston-init: Redefine weston service and add socket
activation option") and dd83fb40f7 ("weston-init: Stop running weston
as root") are large feature patches and thus unsuitable for stable
backports, hence this revert seems to be the least problematic way.

Signed-off-by: Marek Vasut 
Cc: Alexandre Belloni 
Cc: Joshua Watt 
Cc: Pavel Zhukov 
Cc: Steve Sakoman 
---
 .../wayland/weston-init/weston-start | 12 
 .../wayland/weston-init/weston@.service  |  6 --
 .../wayland/weston/systemd-notify.weston-start   |  9 -
 .../wayland/weston/xwayland.weston-start |  3 ++-
 meta/recipes-graphics/wayland/weston_8.0.0.bb|  6 --
 5 files changed, 2 insertions(+), 34 deletions(-)
 delete mode 100644 
meta/recipes-graphics/wayland/weston/systemd-notify.weston-start

diff --git a/meta/recipes-graphics/wayland/weston-init/weston-start 
b/meta/recipes-graphics/wayland/weston-init/weston-start
index 97471df80d..ccc7093425 100755
--- a/meta/recipes-graphics/wayland/weston-init/weston-start
+++ b/meta/recipes-graphics/wayland/weston-init/weston-start
@@ -23,15 +23,6 @@ add_openvt_argument() {
openvt_args="$openvt_args $1"
 }
 
-## Add module to --modules argument
-add_weston_module() {
-   if [ -z "${weston_modules}" ]; then
-   weston_modules="--modules "
-   fi;
-   weston_modules="${weston_modules}${1},"
-}
-
-
 if [ -n "$WAYLAND_DISPLAY" ]; then
echo "ERROR: A Wayland compositor is already running, nested Weston 
instance is not supported yet."
exit 1
@@ -74,9 +65,6 @@ if [ -d "$modules_dir" ]; then
# process module
. $m
done
-   if [ -n "${weston_modules}" ]; then
-   add_weston_argument "${weston_modules} "
-   fi;
 fi
 
 if test -z "$XDG_RUNTIME_DIR"; then
diff --git a/meta/recipes-graphics/wayland/weston-init/weston@.service 
b/meta/recipes-graphics/wayland/weston-init/weston@.service
index 70c706d75c..39e193014a 100644
--- a/meta/recipes-graphics/wayland/weston-init/weston@.service
+++ b/meta/recipes-graphics/wayland/weston-init/weston@.service
@@ -1,7 +1,3 @@
-# SPDX-FileCopyrightText: Huawei Inc.
-#
-# SPDX-License-Identifier: Apache-2.0
-
 [Unit]
 Description=Weston Wayland Compositor
 RequiresMountsFor=/run
@@ -9,8 +5,6 @@ Conflicts=plymouth-quit.service
 After=systemd-user-sessions.service plymouth-quit-wait.service
 
 [Service]
-Type=notify
-NotifyAccess=all
 User=%i
 PAMName=login
 EnvironmentFile=-/etc/default/weston
diff --git a/meta/recipes-graphics/wayland/weston/systemd-notify.weston-start 
b/meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
deleted file mode 100644
index fdb48cb609..00
--- a/meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
+++ /dev/null
@@ -1,9 +0,0 @@
-#!/bin/sh
-
-# SPDX-FileCopyrightText: Huawei Inc.
-# SPDX-License-Identifier: Apache-2.0
-
-
-if [[ -x "/usr/lib/weston/systemd-notify.so" ]]; then
-   add_weston_module "systemd-notify.so"
-fi
diff --git a/meta/recipes-graphics/wayland/weston/xwayland.weston-start 
b/meta/recipes-graphics/wayland/weston/xwayland.weston-start
index 22984f50a4..b483c97cf1 100644
--- a/meta/recipes-graphics/wayland/weston/xwayland.weston-start
+++ b/meta/recipes-graphics/wayland/weston/

[OE-core] [PATCH] ffmpeg: Update from 4.4.1 to 5.0

2022-01-18 Thread Marek Vasut
Update ffmpeg to 5.0 , release notes and changelog below:
https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/refs/heads/release/5.0:/RELEASE_NOTES
https://git.ffmpeg.org/gitweb/ffmpeg.git/shortlog/n5.0

The avresample has been removed before 5.0 release in ffmpeg commit
420cedd497 ("libavresample: Remove deprecated library")

The ffmpeg 5.0 might be an LTS release, see:
http://www.jbkempf.com/blog/post/2022/FFmpeg-5.0

Signed-off-by: Marek Vasut 
Cc: Alexander Kanavin 
Cc: Richard Purdie 
---
 .../ffmpeg/{ffmpeg_4.4.1.bb => ffmpeg_5.0.bb}| 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)
 rename meta/recipes-multimedia/ffmpeg/{ffmpeg_4.4.1.bb => ffmpeg_5.0.bb} (95%)

diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.4.1.bb 
b/meta/recipes-multimedia/ffmpeg/ffmpeg_5.0.bb
similarity index 95%
rename from meta/recipes-multimedia/ffmpeg/ffmpeg_4.4.1.bb
rename to meta/recipes-multimedia/ffmpeg/ffmpeg_5.0.bb
index 3ba07c31d6..4ba5ff4537 100644
--- a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.4.1.bb
+++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_5.0.bb
@@ -11,7 +11,6 @@ LICENSE:libavcodec = "${@bb.utils.contains('PACKAGECONFIG', 
'gpl', 'GPLv2+', 'LG
 LICENSE:libavdevice = "${@bb.utils.contains('PACKAGECONFIG', 'gpl', 'GPLv2+', 
'LGPLv2.1+', d)}"
 LICENSE:libavfilter = "${@bb.utils.contains('PACKAGECONFIG', 'gpl', 'GPLv2+', 
'LGPLv2.1+', d)}"
 LICENSE:libavformat = "${@bb.utils.contains('PACKAGECONFIG', 'gpl', 'GPLv2+', 
'LGPLv2.1+', d)}"
-LICENSE:libavresample = "${@bb.utils.contains('PACKAGECONFIG', 'gpl', 
'GPLv2+', 'LGPLv2.1+', d)}"
 LICENSE:libavutil = "${@bb.utils.contains('PACKAGECONFIG', 'gpl', 'GPLv2+', 
'LGPLv2.1+', d)}"
 LICENSE:libpostproc = "GPLv2+"
 LICENSE:libswresample = "${@bb.utils.contains('PACKAGECONFIG', 'gpl', 
'GPLv2+', 'LGPLv2.1+', d)}"
@@ -26,7 +25,7 @@ LIC_FILES_CHKSUM = 
"file://COPYING.GPLv2;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
 SRC_URI = "https://www.ffmpeg.org/releases/${BP}.tar.xz \

file://0001-libavutil-include-assembly-with-full-path-from-sourc.patch \
"
-SRC_URI[sha256sum] = 
"eadbad9e9ab30b25f5520fbfde99fae4a92a1ae3c0257a8d68569a4651e30e02"
+SRC_URI[sha256sum] = 
"51e919f7d205062c0fd4fae6243a84850391115104ccf1efc451733bc0ac7298"
 
 # Build fails when thumb is enabled: 
https://bugzilla.yoctoproject.org/show_bug.cgi?id=7717
 ARM_INSTRUCTION_SET:armv4 = "arm"
@@ -41,7 +40,7 @@ DEPENDS = "nasm-native"
 
 inherit autotools pkgconfig
 
-PACKAGECONFIG ??= "avdevice avfilter avcodec avformat swresample swscale 
postproc avresample \
+PACKAGECONFIG ??= "avdevice avfilter avcodec avformat swresample swscale 
postproc \
alsa bzlib lzma pic pthreads shared theora zlib \
${@bb.utils.contains('AVAILTUNES', 'mips32r2', 'mips32r2', 
'', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xv xcb', 
'', d)}"
@@ -54,7 +53,6 @@ PACKAGECONFIG[avformat] = 
"--enable-avformat,--disable-avformat"
 PACKAGECONFIG[swresample] = "--enable-swresample,--disable-swresample"
 PACKAGECONFIG[swscale] = "--enable-swscale,--disable-swscale"
 PACKAGECONFIG[postproc] = "--enable-postproc,--disable-postproc"
-PACKAGECONFIG[avresample] = "--enable-avresample,--disable-avresample"
 
 # features to support
 PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
@@ -153,7 +151,6 @@ PACKAGES =+ "libavcodec \
  libavdevice \
  libavfilter \
  libavformat \
- libavresample \
  libavutil \
  libpostproc \
  libswresample \
@@ -163,7 +160,6 @@ FILES:libavcodec = "${libdir}/libavcodec${SOLIBS}"
 FILES:libavdevice = "${libdir}/libavdevice${SOLIBS}"
 FILES:libavfilter = "${libdir}/libavfilter${SOLIBS}"
 FILES:libavformat = "${libdir}/libavformat${SOLIBS}"
-FILES:libavresample = "${libdir}/libavresample${SOLIBS}"
 FILES:libavutil = "${libdir}/libavutil${SOLIBS}"
 FILES:libpostproc = "${libdir}/libpostproc${SOLIBS}"
 FILES:libswresample = "${libdir}/libswresample${SOLIBS}"
@@ -175,7 +171,6 @@ INSANE_SKIP:${MLPREFIX}libavdevice = "textrel"
 INSANE_SKIP:${MLPREFIX}libavfilter = "textrel"
 INSANE_SKIP:${MLPREFIX}libavformat = "textrel"
 INSANE_SKIP:${MLPREFIX}libavutil = "textrel"
-INSANE_SKIP:${MLPREFIX}libavresample = "textrel"
 INSANE_SKIP:${MLPREFIX}libswscale = "textrel"
 INSANE_SKIP:${MLPREFIX}libswresample = "textrel"
 INSANE_SKIP:${MLPREFIX}libpostproc = "textrel"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160676): 
https://lists.openembedded.org/g/openembedded-core/message/160676
Mute This Topic: https://lists.openembedded.org/mt/88516624/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] bootchart2: Add missing python3-math dependency

2022-01-15 Thread Marek Vasut
Without this dependency, generating the bootchart may fail with:
"
ModuleNotFoundError: No module named 'random'
"

Signed-off-by: Marek Vasut 
Cc: Mingli Yu 
Cc: Richard Purdie 
---
 meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb 
b/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
index 87f7631ddc..f0349dacf0 100644
--- a/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
+++ b/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
@@ -151,7 +151,7 @@ do_install () {
 
 PACKAGES =+ "pybootchartgui"
 FILES:pybootchartgui += "${PYTHON_SITEPACKAGES_DIR}/pybootchartgui 
${bindir}/pybootchartgui"
-RDEPENDS:pybootchartgui = "python3-pycairo python3-compression python3-image 
python3-shell python3-compression python3-codecs"
+RDEPENDS:pybootchartgui = "python3-pycairo python3-compression python3-image 
python3-math python3-shell python3-compression python3-codecs"
 RDEPENDS:${PN}:class-target += "${@bb.utils.contains('DISTRO_FEATURES', 
'sysvinit', 'sysvinit-pidof', 'procps', d)}"
 RDEPENDS:${PN}:class-target += "lsb-release"
 DEPENDS:append:class-native = " python3-pycairo-native"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160603): 
https://lists.openembedded.org/g/openembedded-core/message/160603
Mute This Topic: https://lists.openembedded.org/mt/88457016/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] u-boot: upgrade 2021.10 -> 2022.01

2022-01-10 Thread Marek Vasut
Signed-off-by: Marek Vasut 
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
 meta/recipes-bsp/u-boot/u-boot-common.inc   | 2 +-
 .../u-boot/{u-boot-tools_2021.10.bb => u-boot-tools_2022.01.bb} | 0
 .../recipes-bsp/u-boot/{u-boot_2021.10.bb => u-boot_2022.01.bb} | 0
 3 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-bsp/u-boot/{u-boot-tools_2021.10.bb => 
u-boot-tools_2022.01.bb} (100%)
 rename meta/recipes-bsp/u-boot/{u-boot_2021.10.bb => u-boot_2022.01.bb} (100%)

diff --git a/meta/recipes-bsp/u-boot/u-boot-common.inc 
b/meta/recipes-bsp/u-boot/u-boot-common.inc
index 5a3fc17ad1..c09b1c2876 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common.inc
@@ -12,7 +12,7 @@ PE = "1"
 
 # We use the revision in order to avoid having to fetch it from the
 # repo during parse
-SRCREV = "d80bb749fab53da72c4a0e09b8c2d2aaa3103c91"
+SRCREV = "d637294e264adfeb29f390dfc393106fd4d41b17"
 
 SRC_URI = "git://git.denx.de/u-boot.git;branch=master \
   "
diff --git a/meta/recipes-bsp/u-boot/u-boot-tools_2021.10.bb 
b/meta/recipes-bsp/u-boot/u-boot-tools_2022.01.bb
similarity index 100%
rename from meta/recipes-bsp/u-boot/u-boot-tools_2021.10.bb
rename to meta/recipes-bsp/u-boot/u-boot-tools_2022.01.bb
diff --git a/meta/recipes-bsp/u-boot/u-boot_2021.10.bb 
b/meta/recipes-bsp/u-boot/u-boot_2022.01.bb
similarity index 100%
rename from meta/recipes-bsp/u-boot/u-boot_2021.10.bb
rename to meta/recipes-bsp/u-boot/u-boot_2022.01.bb
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160384): 
https://lists.openembedded.org/g/openembedded-core/message/160384
Mute This Topic: https://lists.openembedded.org/mt/88341443/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] weston: Backport patches to always activate the top-level surface

2022-01-05 Thread Marek Vasut

On 1/5/22 23:40, Steve Sakoman wrote:

On Wed, Jan 5, 2022 at 12:25 PM Marek Vasut  wrote:


On 1/5/22 23:21, Marek Vasut wrote:

In case the device has only touchscreen input device and no keyboard or mouse,
the top level surface is never activated. The behavior differs from a device
which has a keyboard (or gpio-keys, or even uinput-emulated keyboard), where
callchain activate()->weston_view_activate()->weston_seat_set_keyboard_focus()->
weston_keyboard_set_focus()->wl_signal_emit(>focus_signal, keyboard)->
handle_keyboard_focus()->weston_desktop_surface_set_activated(..., true); sets
the top level surface as activated. On device with touchscreen, the above is
never called, hence the top level surface is never activated. Add explicit
weston_desktop_surface_set_activated(shsurf->desktop_surface, true); into
activate() to always active the top level surface.

This fixes at least two known issues on such devices:
- Wayland terminal cursor is an empty bar (full bar with keyboard present)
- Chromium dropdown menus are randomly placed (they are placed correctly
when keyboard is present, because then chromium can find the activated
top level surface)

Signed-off-by: Marek Vasut 
Cc: Steve Sakoman 


And that Subject should've had [dunfell] tag, sorry.
Do you need a resend ?


No, I've got it!

Thanks,


Thanks

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160218): 
https://lists.openembedded.org/g/openembedded-core/message/160218
Mute This Topic: https://lists.openembedded.org/mt/88225658/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] weston: Backport patches to always activate the top-level surface

2022-01-05 Thread Marek Vasut

On 1/5/22 23:21, Marek Vasut wrote:

In case the device has only touchscreen input device and no keyboard or mouse,
the top level surface is never activated. The behavior differs from a device
which has a keyboard (or gpio-keys, or even uinput-emulated keyboard), where
callchain activate()->weston_view_activate()->weston_seat_set_keyboard_focus()->
weston_keyboard_set_focus()->wl_signal_emit(>focus_signal, keyboard)->
handle_keyboard_focus()->weston_desktop_surface_set_activated(..., true); sets
the top level surface as activated. On device with touchscreen, the above is
never called, hence the top level surface is never activated. Add explicit
weston_desktop_surface_set_activated(shsurf->desktop_surface, true); into
activate() to always active the top level surface.

This fixes at least two known issues on such devices:
- Wayland terminal cursor is an empty bar (full bar with keyboard present)
- Chromium dropdown menus are randomly placed (they are placed correctly
   when keyboard is present, because then chromium can find the activated
   top level surface)

Signed-off-by: Marek Vasut 
Cc: Steve Sakoman 


And that Subject should've had [dunfell] tag, sorry.
Do you need a resend ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160216): 
https://lists.openembedded.org/g/openembedded-core/message/160216
Mute This Topic: https://lists.openembedded.org/mt/88225658/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] weston: Backport patches to always activate the top-level surface

2022-01-05 Thread Marek Vasut
In case the device has only touchscreen input device and no keyboard or mouse,
the top level surface is never activated. The behavior differs from a device
which has a keyboard (or gpio-keys, or even uinput-emulated keyboard), where
callchain activate()->weston_view_activate()->weston_seat_set_keyboard_focus()->
weston_keyboard_set_focus()->wl_signal_emit(>focus_signal, keyboard)->
handle_keyboard_focus()->weston_desktop_surface_set_activated(..., true); sets
the top level surface as activated. On device with touchscreen, the above is
never called, hence the top level surface is never activated. Add explicit
weston_desktop_surface_set_activated(shsurf->desktop_surface, true); into
activate() to always active the top level surface.

This fixes at least two known issues on such devices:
- Wayland terminal cursor is an empty bar (full bar with keyboard present)
- Chromium dropdown menus are randomly placed (they are placed correctly
  when keyboard is present, because then chromium can find the activated
  top level surface)

Signed-off-by: Marek Vasut 
Cc: Steve Sakoman 
---
 ...move-no-op-de-activation-of-the-xdg-.patch | 32 ++
 ...name-gain-lose-keyboard-focus-to-act.patch | 57 +++
 ...bed-keyboard-focus-handle-code-when-.patch | 99 +++
 meta/recipes-graphics/wayland/weston_8.0.0.bb |  3 +
 4 files changed, 191 insertions(+)
 create mode 100644 
meta/recipes-graphics/wayland/weston/0002-desktop-shell-Remove-no-op-de-activation-of-the-xdg-.patch
 create mode 100644 
meta/recipes-graphics/wayland/weston/0003-desktop-shell-Rename-gain-lose-keyboard-focus-to-act.patch
 create mode 100644 
meta/recipes-graphics/wayland/weston/0004-desktop-shell-Embed-keyboard-focus-handle-code-when-.patch

diff --git 
a/meta/recipes-graphics/wayland/weston/0002-desktop-shell-Remove-no-op-de-activation-of-the-xdg-.patch
 
b/meta/recipes-graphics/wayland/weston/0002-desktop-shell-Remove-no-op-de-activation-of-the-xdg-.patch
new file mode 100644
index 00..fb36d3817a
--- /dev/null
+++ 
b/meta/recipes-graphics/wayland/weston/0002-desktop-shell-Remove-no-op-de-activation-of-the-xdg-.patch
@@ -0,0 +1,32 @@
+From 5c74a0640e873694bf60a88eceb21f664cb4b8f7 Mon Sep 17 00:00:00 2001
+From: Marius Vlad 
+Date: Fri, 5 Mar 2021 20:03:49 +0200
+Subject: [PATCH 2/5] desktop-shell: Remove no-op de-activation of the xdg
+ top-level surface
+
+The shsurf is calloc'ed so the surface count is always 0.  Not only
+that but the surface is not set as active by default, so there's no
+need to de-activate it.
+
+Upstream-Status: Backport [05bef4c18a3e82376a46a4a28d978389c4c0fd0f]
+Signed-off-by: Marius Vlad 
+---
+ desktop-shell/shell.c | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
+index 442a625f..3791be25 100644
+--- a/desktop-shell/shell.c
 b/desktop-shell/shell.c
+@@ -2427,8 +2427,6 @@ desktop_surface_added(struct weston_desktop_surface 
*desktop_surface,
+   wl_list_init(>children_link);
+ 
+   weston_desktop_surface_set_user_data(desktop_surface, shsurf);
+-  weston_desktop_surface_set_activated(desktop_surface,
+-   shsurf->focus_count > 0);
+ }
+ 
+ static void
+-- 
+2.34.1
+
diff --git 
a/meta/recipes-graphics/wayland/weston/0003-desktop-shell-Rename-gain-lose-keyboard-focus-to-act.patch
 
b/meta/recipes-graphics/wayland/weston/0003-desktop-shell-Rename-gain-lose-keyboard-focus-to-act.patch
new file mode 100644
index 00..dcd0700fca
--- /dev/null
+++ 
b/meta/recipes-graphics/wayland/weston/0003-desktop-shell-Rename-gain-lose-keyboard-focus-to-act.patch
@@ -0,0 +1,57 @@
+From edb31c456ae3da7efb668a37ab88075c4b67 Mon Sep 17 00:00:00 2001
+From: Marius Vlad 
+Date: Fri, 5 Mar 2021 21:40:22 +0200
+Subject: [PATCH 3/5] desktop-shell: Rename gain/lose keyboard focus to
+ activate/de-activate
+
+This way it better reflects that it handles activation rather that input
+focus.
+
+Upstream-Status: Backport [ab39e1d76d4f6715cb300bc37f5c2a0e2d426208]
+Signed-off-by: Marius Vlad 
+---
+ desktop-shell/shell.c | 8 
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
+index 3791be25..c4669f11 100644
+--- a/desktop-shell/shell.c
 b/desktop-shell/shell.c
+@@ -1869,14 +1869,14 @@ handle_pointer_focus(struct wl_listener *listener, 
void *data)
+ }
+ 
+ static void
+-shell_surface_lose_keyboard_focus(struct shell_surface *shsurf)
++shell_surface_deactivate(struct shell_surface *shsurf)
+ {
+   if (--shsurf->focus_count == 0)
+   weston_desktop_surface_set_activated(shsurf->desktop_surface, 
false);
+ }
+ 
+ static void
+-shell_surface_gain_keyboard_focus(struct shell_surface *shsurf)
++shell_surface_activate(struct shell_surface *shsurf)
+ {
+   if (shsurf->focus_count++ == 0)
+   weston_desktop_surface_set_activated(shsurf->desktop_surface, 
true);
+@@ -1

Re: [OE-core] [dunfell][PATCH] piglit: upgrade to latest revision

2021-11-06 Thread Marek Vasut

On 11/6/21 5:01 PM, Steve Sakoman wrote:

On Sat, Nov 6, 2021 at 2:59 AM Marek Vasut  wrote:


Update piglit to latest git revision and update the branch name,
since the original one is no longer updated. Make sure the VK
tests are only enabled if VK is also enabled in PACKAGECONFIG,
and that this is opt-in, otherwise older systems fail to build.

Cherry picked from squashed commits:
   eb3a8d4c7b ("piglit: upgrade to latest revision")
   a27b06f73a ("piglit: upgrade to latest revision")
   bb091bc0be ("piglit: upgrade to latest revision")
   394746d1cb ("piglit: upgrade to latest revision")
   5aec8cff94 ("piglit: upgrade to latest revision")
   fc4c82773d ("piglit: fix reproducibility")
   6fbec0f12a ("piglit: update to latest revision")
   8d23a0d498 ("piglit: upgrade to latest revision")
   5144d515fe ("piglit: upgrade to latest revision")
   dd085bd577 ("piglit: upgrade to latest revision")
   9ba6df1b2c ("piglit: upgrade to latest revision")
   1ccd71eb3e ("piglit: upgrade to latest revision")

Signed-off-by: Marek Vasut 
Signed-off-by: Alexander Kanavin 
Signed-off-by: Alexandre Belloni 
Cc: Anuj Mittal 
Cc: Richard Purdie 
Cc: Steve Sakoman 
---
NOTE: Why backport this -- because graphics testing on oe-core dunfell


I am having trouble parsing the reason.  Could you explain?


I just want to be able to run latest GPU tests with all the fixes in 
place on the LTS versions of OE builds, not some obsolete broken version 
of those tests, that's all.


Since piglit isn't something which you deploy as production application, 
but rather something you use to test your drivers (both kernel and 
userspace), I think it is OK to keep it up to date.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#157942): 
https://lists.openembedded.org/g/openembedded-core/message/157942
Mute This Topic: https://lists.openembedded.org/mt/86862445/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] piglit: upgrade to latest revision

2021-11-06 Thread Marek Vasut
Update piglit to latest git revision and update the branch name,
since the original one is no longer updated. Make sure the VK
tests are only enabled if VK is also enabled in PACKAGECONFIG,
and that this is opt-in, otherwise older systems fail to build.

Cherry picked from squashed commits:
  eb3a8d4c7b ("piglit: upgrade to latest revision")
  a27b06f73a ("piglit: upgrade to latest revision")
  bb091bc0be ("piglit: upgrade to latest revision")
  394746d1cb ("piglit: upgrade to latest revision")
  5aec8cff94 ("piglit: upgrade to latest revision")
  fc4c82773d ("piglit: fix reproducibility")
  6fbec0f12a ("piglit: update to latest revision")
  8d23a0d498 ("piglit: upgrade to latest revision")
  5144d515fe ("piglit: upgrade to latest revision")
  dd085bd577 ("piglit: upgrade to latest revision")
  9ba6df1b2c ("piglit: upgrade to latest revision")
  1ccd71eb3e ("piglit: upgrade to latest revision")

Signed-off-by: Marek Vasut 
Signed-off-by: Alexander Kanavin 
Signed-off-by: Alexandre Belloni 
Cc: Anuj Mittal 
Cc: Richard Purdie 
Cc: Steve Sakoman 
---
NOTE: Why backport this -- because graphics testing on oe-core dunfell
  Why squash the patches -- because it is the same thing all over
(except for the reproducibility fix, which is hard to rebase
 to the end)
---
 ...ssing-include-for-htobe32-definition.patch | 27 
 ...file.py-make-test-lists-reproducible.patch | 31 +
 ...gen_tcs-tes_input_tests.py-do-not-ha.patch | 44 +++
 ...lizer.py-make-.gz-files-reproducible.patch | 30 +
 ...sort-the-file-list-before-working-on.patch | 28 
 ...t-shader.c-do-not-hardcode-build-pat.patch | 30 +
 meta/recipes-graphics/piglit/piglit_git.bb| 12 -
 7 files changed, 200 insertions(+), 2 deletions(-)
 create mode 100644 
meta/recipes-graphics/piglit/piglit/0001-Add-a-missing-include-for-htobe32-definition.patch
 create mode 100644 
meta/recipes-graphics/piglit/piglit/0001-framework-profile.py-make-test-lists-reproducible.patch
 create mode 100644 
meta/recipes-graphics/piglit/piglit/0001-generated_tests-gen_tcs-tes_input_tests.py-do-not-ha.patch
 create mode 100644 
meta/recipes-graphics/piglit/piglit/0001-serializer.py-make-.gz-files-reproducible.patch
 create mode 100644 
meta/recipes-graphics/piglit/piglit/0001-tests-shader.py-sort-the-file-list-before-working-on.patch
 create mode 100644 
meta/recipes-graphics/piglit/piglit/0002-tests-util-piglit-shader.c-do-not-hardcode-build-pat.patch

diff --git 
a/meta/recipes-graphics/piglit/piglit/0001-Add-a-missing-include-for-htobe32-definition.patch
 
b/meta/recipes-graphics/piglit/piglit/0001-Add-a-missing-include-for-htobe32-definition.patch
new file mode 100644
index 00..caa48e088d
--- /dev/null
+++ 
b/meta/recipes-graphics/piglit/piglit/0001-Add-a-missing-include-for-htobe32-definition.patch
@@ -0,0 +1,27 @@
+From d623e9797b7ee9b3739a8a4afe1a01f7e03754aa Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin 
+Date: Sun, 1 Nov 2020 20:08:49 +
+Subject: [PATCH] Add a missing include for htobe32 definition
+
+Upstream-Status: Pending
+Signed-off-by: Alexander Kanavin 
+---
+ tests/spec/nv_copy_depth_to_color/nv_copy_depth_to_color.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/tests/spec/nv_copy_depth_to_color/nv_copy_depth_to_color.c 
b/tests/spec/nv_copy_depth_to_color/nv_copy_depth_to_color.c
+index 5f45e0c23..c755ee29a 100644
+--- a/tests/spec/nv_copy_depth_to_color/nv_copy_depth_to_color.c
 b/tests/spec/nv_copy_depth_to_color/nv_copy_depth_to_color.c
+@@ -34,6 +34,8 @@
+ 
+ #include "piglit-util-gl.h"
+ 
++#include 
++
+ #define IMAGE_WIDTH 60
+ #define IMAGE_HEIGHT 60
+ 
+-- 
+2.17.1
+
diff --git 
a/meta/recipes-graphics/piglit/piglit/0001-framework-profile.py-make-test-lists-reproducible.patch
 
b/meta/recipes-graphics/piglit/piglit/0001-framework-profile.py-make-test-lists-reproducible.patch
new file mode 100644
index 00..cc9482c047
--- /dev/null
+++ 
b/meta/recipes-graphics/piglit/piglit/0001-framework-profile.py-make-test-lists-reproducible.patch
@@ -0,0 +1,31 @@
+From 9086d42df1f3134bafcfe33ff16db7bbb9d9a0fd Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin 
+Date: Mon, 30 Nov 2020 23:08:22 +
+Subject: [PATCH] framework/profile.py: make test lists reproducible
+
+These are created with os.walk, which yields different
+order depending on where it's run.
+
+Upstream-Status: Pending
+Signed-off-by: Alexander Kanavin 
+---
+ framework/profile.py | 6 +-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/framework/profile.py b/framework/profile.py
+index c210e535e..9b5d51d68 100644
+--- a/framework/profile.py
 b/framework/profile.py
+@@ -528,7 +528,11 @@ class TestProfile(object):
+ else:
+ opts[n] = self.test_list[n]
+ else:
+-opts 

[OE-core] [PATCH] piglit: upgrade to latest revision

2021-10-14 Thread Marek Vasut
Update piglit to latest git revision and update the branch name,
since the original one is no longer updated. Make sure the VK
tests are only enabled if VK is also enabled in PACKAGECONFIG,
and that this is opt-in, otherwise older systems fail to build.

Signed-off-by: Marek Vasut 
Cc: Anuj Mittal 
Cc: Richard Purdie 
---
 meta/recipes-graphics/piglit/piglit_git.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-graphics/piglit/piglit_git.bb 
b/meta/recipes-graphics/piglit/piglit_git.bb
index 2e0dfeee42..4b515cc537 100644
--- a/meta/recipes-graphics/piglit/piglit_git.bb
+++ b/meta/recipes-graphics/piglit/piglit_git.bb
@@ -6,7 +6,7 @@ BUGTRACKER = 
"https://gitlab.freedesktop.org/mesa/piglit/-/issues;
 LICENSE = "MIT & LGPLv2+ & GPLv3 & GPLv2+ & BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b2beded7103a3d8a442a2a0391d607b0"
 
-SRC_URI = "git://gitlab.freedesktop.org/mesa/piglit.git;protocol=https \
+SRC_URI = 
"git://gitlab.freedesktop.org/mesa/piglit.git;protocol=https;branch=main \
file://0001-cmake-install-bash-completions-in-the-right-place.patch 
\
file://0001-cmake-use-proper-WAYLAND_INCLUDE_DIRS-variable.patch \
file://0001-Add-a-missing-include-for-htobe32-definition.patch \
@@ -18,7 +18,7 @@ SRC_URI = 
"git://gitlab.freedesktop.org/mesa/piglit.git;protocol=https \
"
 UPSTREAM_CHECK_COMMITS = "1"
 
-SRCREV = "6a4be9e9946df310d9402f995f371c7deb8c27ba"
+SRCREV = "014c9d09115e15f5a074457a753bf3a43173ef7f"
 # (when PV goes above 1.0 remove the trailing r)
 PV = "1.0+gitr${SRCPV}"
 
@@ -43,6 +43,7 @@ do_compile[dirs] =+ "${B}/temp/"
 PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)}"
 PACKAGECONFIG[freeglut] = "-DPIGLIT_USE_GLUT=1,-DPIGLIT_USE_GLUT=0,freeglut,"
 PACKAGECONFIG[x11] = 
"-DPIGLIT_BUILD_GL_TESTS=ON,-DPIGLIT_BUILD_GL_TESTS=OFF,${X11_DEPS}, 
${X11_RDEPS}"
+PACKAGECONFIG[vulkan] = 
"-DPIGLIT_BUILD_VK_TESTS=ON,-DPIGLIT_BUILD_VK_TESTS=OFF,vulkan-loader"
 
 export PIGLIT_BUILD_DIR = "../../../../git"
 
-- 
2.33.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156979): 
https://lists.openembedded.org/g/openembedded-core/message/156979
Mute This Topic: https://lists.openembedded.org/mt/86326704/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] rng-tools: add systemd-udev-settle wants to service

2021-10-12 Thread Marek Vasut
From: Claudius Heine 

rngd needs to start after `systemd-udev-settle` in order for the kernel
modules of the random source hardware to be loaded before it is started.

However, since the `rngd.service` does not require or want
`systemd-udev-settle.service` it might not be scheduled for start and
the `After=systemd-udev-settle.service` there has no effect.

Adding `Wants=systemd-udev-settle.service` provides a weak requirement
to it, so that the `rngd` is started after it, if possible.

Signed-off-by: Claudius Heine 
Signed-off-by: Richard Purdie 
(cherry picked from commit e9715d4234eb7b45dee8b323799014646f0a1b07)
Cc: Steve Sakoman 
---
 meta/recipes-support/rng-tools/rng-tools/rngd.service | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-support/rng-tools/rng-tools/rngd.service 
b/meta/recipes-support/rng-tools/rng-tools/rngd.service
index a29074..f296a99e1f 100644
--- a/meta/recipes-support/rng-tools/rng-tools/rngd.service
+++ b/meta/recipes-support/rng-tools/rng-tools/rngd.service
@@ -3,6 +3,7 @@ Description=Hardware RNG Entropy Gatherer Daemon
 DefaultDependencies=no
 After=systemd-udev-settle.service
 Before=sysinit.target shutdown.target
+Wants=systemd-udev-settle.service
 Conflicts=shutdown.target
 
 [Service]
-- 
2.33.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156886): 
https://lists.openembedded.org/g/openembedded-core/message/156886
Mute This Topic: https://lists.openembedded.org/mt/86269400/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH 2/2] mtd-utils: upgrade 2.1.2 -> 2.1.3

2021-09-23 Thread Marek Vasut
From: Stefano Babic 

Drop also --enable-install-tests from configuration options because this
was removed in 2.1.3.

(cherry picked from commit c95c852b84f02f5e2ad5c575ab683bba0471f221)
Signed-off-by: Stefano Babic 
CC: David Oberhollenzer 
CC: Alexandre Belloni 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Richard Purdie 
---
 meta/recipes-devtools/mtd/mtd-utils_git.bb | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb 
b/meta/recipes-devtools/mtd/mtd-utils_git.bb
index 55f05dc8f9..d8355bbad3 100644
--- a/meta/recipes-devtools/mtd/mtd-utils_git.bb
+++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb
@@ -11,17 +11,15 @@ inherit autotools pkgconfig update-alternatives
 DEPENDS = "zlib e2fsprogs util-linux"
 RDEPENDS_mtd-utils-tests += "bash"
 
-PV = "2.1.2"
+PV = "2.1.3"
 
-SRCREV = "7b986779342021bda87c04da3bf729718736d8ab"
+SRCREV = "42ea7cd48d2b3c306d59bb6c530d79f8c25bf9f5"
 SRC_URI = "git://git.infradead.org/mtd-utils.git \
file://add-exclusion-to-mkfs-jffs2-git-2.patch \
"
 
 S = "${WORKDIR}/git/"
 
-EXTRA_OECONF += "--enable-install-tests"
-
 # xattr support creates an additional compile-time dependency on acl because
 # the sys/acl.h header is needed. libacl is not needed and thus enabling xattr
 # regardless whether acl is enabled or disabled in the distro should be okay.
-- 
2.33.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156283): 
https://lists.openembedded.org/g/openembedded-core/message/156283
Mute This Topic: https://lists.openembedded.org/mt/85829112/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH 1/2] mtd-utils: upgrade 2.1.1 -> 2.1.2

2021-09-23 Thread Marek Vasut
From: Richard Purdie 

Drop backported patch.

(cherry picked from commit e38fd1ac331d824b2db94a7ae46026b111257e83)
Signed-off-by: Richard Purdie 
---
 ...-utils-Fix-return-value-of-ubiformat.patch | 62 ---
 meta/recipes-devtools/mtd/mtd-utils_git.bb|  7 +--
 2 files changed, 3 insertions(+), 66 deletions(-)
 delete mode 100644 
meta/recipes-devtools/mtd/mtd-utils/0001-mtd-utils-Fix-return-value-of-ubiformat.patch

diff --git 
a/meta/recipes-devtools/mtd/mtd-utils/0001-mtd-utils-Fix-return-value-of-ubiformat.patch
 
b/meta/recipes-devtools/mtd/mtd-utils/0001-mtd-utils-Fix-return-value-of-ubiformat.patch
deleted file mode 100644
index d43f7e1a7a..00
--- 
a/meta/recipes-devtools/mtd/mtd-utils/0001-mtd-utils-Fix-return-value-of-ubiformat.patch
+++ /dev/null
@@ -1,62 +0,0 @@
-From 4d19bffcfd66e25d3ee74536ae2d2da7ad52e8e2 Mon Sep 17 00:00:00 2001
-From: Barry Grussling 
-Date: Sun, 12 Jan 2020 12:33:32 -0800
-Subject: [PATCH] mtd-utils: Fix return value of ubiformat
-Organization: O.S. Systems Software LTDA.
-
-This changeset fixes a feature regression in ubiformat.  Older versions of
-ubiformat, when invoked with a flash-image, would return 0 in the case no error
-was encountered.  Upon upgrading to latest, it was discovered that ubiformat
-returned 255 even without encountering an error condition.
-
-This changeset corrects the above issue and causes ubiformat, when given an
-image file, to return 0 when no errors are detected.
-
-Tested by running through my loading scripts and verifying ubiformat returned
-0.
-
-Upstream-Status: Backport [2.1.2]
-
-Signed-off-by: Barry Grussling 
-Signed-off-by: David Oberhollenzer 
-Signed-off-by: Otavio Salvador 

- ubi-utils/ubiformat.c | 7 +--
- 1 file changed, 5 insertions(+), 2 deletions(-)
-
-diff --git a/ubi-utils/ubiformat.c b/ubi-utils/ubiformat.c
-index a90627c..5377b12 100644
 a/ubi-utils/ubiformat.c
-+++ b/ubi-utils/ubiformat.c
-@@ -550,6 +550,7 @@ static int format(libmtd_t libmtd, const struct 
mtd_dev_info *mtd,
-   struct ubi_vtbl_record *vtbl;
-   int eb1 = -1, eb2 = -1;
-   long long ec1 = -1, ec2 = -1;
-+  int ret = -1;
- 
-   write_size = UBI_EC_HDR_SIZE + mtd->subpage_size - 1;
-   write_size /= mtd->subpage_size;
-@@ -643,8 +644,10 @@ static int format(libmtd_t libmtd, const struct 
mtd_dev_info *mtd,
-   if (!args.quiet && !args.verbose)
-   printf("\n");
- 
--  if (novtbl)
-+  if (novtbl) {
-+  ret = 0;
-   goto out_free;
-+  }
- 
-   if (eb1 == -1 || eb2 == -1) {
-   errmsg("no eraseblocks for volume table");
-@@ -669,7 +672,7 @@ static int format(libmtd_t libmtd, const struct 
mtd_dev_info *mtd,
- 
- out_free:
-   free(hdr);
--  return -1;
-+  return ret;
- }
- 
- int main(int argc, char * const argv[])
--- 
-2.27.0
-
diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb 
b/meta/recipes-devtools/mtd/mtd-utils_git.bb
index 9c05dc03dc..55f05dc8f9 100644
--- a/meta/recipes-devtools/mtd/mtd-utils_git.bb
+++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb
@@ -11,13 +11,12 @@ inherit autotools pkgconfig update-alternatives
 DEPENDS = "zlib e2fsprogs util-linux"
 RDEPENDS_mtd-utils-tests += "bash"
 
-PV = "2.1.1"
+PV = "2.1.2"
 
-SRCREV = "4443221ce9b88440cd9f5bb78e6fe95621d36c8a"
+SRCREV = "7b986779342021bda87c04da3bf729718736d8ab"
 SRC_URI = "git://git.infradead.org/mtd-utils.git \
file://add-exclusion-to-mkfs-jffs2-git-2.patch \
-   file://0001-mtd-utils-Fix-return-value-of-ubiformat.patch \
-"
+   "
 
 S = "${WORKDIR}/git/"
 
-- 
2.33.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156284): 
https://lists.openembedded.org/g/openembedded-core/message/156284
Mute This Topic: https://lists.openembedded.org/mt/85829113/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] weston: Add rdp PACKAGECONFIG

2021-08-30 Thread Marek Vasut
Weston has RDP backend support. This can be used e.g. for screen mirroring.
Add PACKAGECONFIG so it can be enabled by the user. By default, this is not
enabled, to retain the old behavior of the recipe.

Below is an example testcase of using the RDP backend for screen mirroring,
i.e. two devices display the same content across ethernet link, input on
either is passed across the link.

- Add the following to weston.ini:
  [core]
  modules=screen-share.so
  screen-share=true
  [screen-share]
  command=/usr/bin/weston --backend=rdp-backend.so --shell=fullscreen-shell.so 
--no-clients-resize --rdp-tls-cert=/path/to/board.crt 
--rdp-tls-key=/path/to/board.key --no-config

- Generate keys on the board (the board.key and board.crt above):
  $ winpr-makecert -rdp -path /path/to/

- Restart weston on the board. To start screen sharing, press
  Ctrl-Alt-S
  on the keyboard (see weston compositor/screen-share.c).

- Connect to the weston using freerdp, e.g.:
  $ xfreerdp /v:192.168.1.300

Signed-off-by: Marek Vasut 
Cc: Joshua Watt 
Cc: Khem Raj 
Cc: Richard Purdie 
---
NOTE: I didn't find any example of setting up the screen mirroring,
  so I hope this example will be useful to someone.
---
 meta/recipes-graphics/wayland/weston_9.0.0.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/wayland/weston_9.0.0.bb 
b/meta/recipes-graphics/wayland/weston_9.0.0.bb
index fbf181b4a6..295cddc57d 100644
--- a/meta/recipes-graphics/wayland/weston_9.0.0.bb
+++ b/meta/recipes-graphics/wayland/weston_9.0.0.bb
@@ -32,7 +32,7 @@ LDFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'lto', 
'-Wl,-z,undefs', '',
 
 WESTON_MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:1])}"
 
-EXTRA_OEMESON += "-Dbackend-default=auto -Dbackend-rdp=false -Dpipewire=false"
+EXTRA_OEMESON += "-Dbackend-default=auto -Dpipewire=false"
 
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'kms 
fbdev wayland egl clients', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'x11 wayland', 
'xwayland', '', d)} \
@@ -58,6 +58,8 @@ PACKAGECONFIG[x11] = 
"-Dbackend-x11=true,-Dbackend-x11=false,virtual/libx11 libx
 PACKAGECONFIG[headless] = "-Dbackend-headless=true,-Dbackend-headless=false"
 # Weston on framebuffer
 PACKAGECONFIG[fbdev] = "-Dbackend-fbdev=true,-Dbackend-fbdev=false,udev mtdev"
+# Weston on RDP
+PACKAGECONFIG[rdp] = "-Dbackend-rdp=true,-Dbackend-rdp=false,freerdp"
 # weston-launch
 PACKAGECONFIG[launch] = "-Dweston-launch=true,-Dweston-launch=false,drm"
 # VA-API desktop recorder
-- 
2.33.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#155489): 
https://lists.openembedded.org/g/openembedded-core/message/155489
Mute This Topic: https://lists.openembedded.org/mt/85250120/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] image_types: Restore pre-btrfs-tools 4.14.1 mkfs.btrfs shrink behavior

2021-08-23 Thread Marek Vasut
Currently the mkfs.btrfs generates large images with a lot of wasted
space. This happens since OE-core updated btrfs-tools from 4.13.3 to
4.15.1 in commit 94b645aa77 ("btrfs-tools: update to 4.15.1") .

Note in mkfs.btrfs(8) manpage section -r says the following:
"
  -r|--rootdir 
...
   Note This option may enlarge the image or file to ensure
   it’s big enough to contain the files from rootdir. Since
   version 4.14.1 the filesystem size is not minimized. Please
   see option --shrink if you need that functionality.

  --shrink
 Shrink the filesystem to its minimal size, only works with
 --rootdir option.
...
   Note prior to version 4.14.1, the shrinking was done
   automatically.
"

Add the --shrink option to EXTRA_IMAGECMD_btrfs to reinstate the
original behavior and un-waste the space.

Signed-off-by: Marek Vasut 
Cc: Alexander Kanavin 
Cc: Richard Purdie 
Cc: Ross Burton 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Richard Purdie 
(cherry picked from commit c4a99d36967302c176b62fad840b5e79486ea356)
Cc: Steve Sakoman 
---
 meta/classes/image_types.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index ff42ac9423..6dc0e094d0 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -240,7 +240,7 @@ EXTRA_IMAGECMD_jffs2 ?= "--pad ${JFFS2_ENDIANNESS} 
--eraseblock=${JFFS2_ERASEBLO
 EXTRA_IMAGECMD_ext2 ?= "-i 4096"
 EXTRA_IMAGECMD_ext3 ?= "-i 4096"
 EXTRA_IMAGECMD_ext4 ?= "-i 4096"
-EXTRA_IMAGECMD_btrfs ?= "-n 4096"
+EXTRA_IMAGECMD_btrfs ?= "-n 4096 --shrink"
 EXTRA_IMAGECMD_f2fs ?= ""
 
 do_image_cpio[depends] += "cpio-native:do_populate_sysroot"
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#155198): 
https://lists.openembedded.org/g/openembedded-core/message/155198
Mute This Topic: https://lists.openembedded.org/mt/85101728/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] kernel-uboot: Handle gzip and lzo compression options

2021-07-27 Thread Marek Vasut
Since 5c72105e29 ("kernel-uboot: allow compression option to be configurable")
it is possible to select kernel compression method, however the resulting
image is always compressed with gzip, so selecting any other method than
gzip results in unbootable images. Add support for lzo for starters, since
that is fast to decompress and useful in low boot time scenarios.

Note that we should likely add some check for unsupported compression
methods. We should also add dependency on lzop-native I think.

Signed-off-by: Marek Vasut 
Cc: Richard Purdie 
Cc: Sinan Kaya 
---
 meta/classes/kernel-uboot.bbclass | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meta/classes/kernel-uboot.bbclass 
b/meta/classes/kernel-uboot.bbclass
index b1e7ac05c2..2daa068298 100644
--- a/meta/classes/kernel-uboot.bbclass
+++ b/meta/classes/kernel-uboot.bbclass
@@ -22,7 +22,11 @@ uboot_prep_kimage() {
[ -n "${vmlinux_path}" ] && ${OBJCOPY} -O binary -R .note -R .comment 
-S "${vmlinux_path}" linux.bin
 
if [ "${linux_comp}" != "none" ] ; then
-   gzip -9 linux.bin
+   if [ "${linux_comp}" = "gzip" ] ; then
+   gzip -9 linux.bin
+   elif [ "${linux_comp}" = "lzo" ] ; then
+   lzop -9 linux.bin
+   fi
mv -f "linux.bin${linux_suffix}" linux.bin
fi
 
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154172): 
https://lists.openembedded.org/g/openembedded-core/message/154172
Mute This Topic: https://lists.openembedded.org/mt/84485611/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] image_types: Restore pre-btrfs-tools 4.14.1 mkfs.btrfs shrink behavior

2021-07-27 Thread Marek Vasut
Currently the mkfs.btrfs generates large images with a lot of wasted
space. This happens since OE-core updated btrfs-tools from 4.13.3 to
4.15.1 in commit 94b645aa77 ("btrfs-tools: update to 4.15.1") .

Note in mkfs.btrfs(8) manpage section -r says the following:
"
  -r|--rootdir 
...
   Note This option may enlarge the image or file to ensure
   it’s big enough to contain the files from rootdir. Since
   version 4.14.1 the filesystem size is not minimized. Please
   see option --shrink if you need that functionality.

  --shrink
 Shrink the filesystem to its minimal size, only works with
 --rootdir option.
...
   Note prior to version 4.14.1, the shrinking was done
   automatically.
"

Add the --shrink option to EXTRA_IMAGECMD_btrfs to reinstate the
original behavior and un-waste the space.

Signed-off-by: Marek Vasut 
Cc: Alexander Kanavin 
Cc: Richard Purdie 
Cc: Ross Burton 
---
 meta/classes/image_types.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index 954d6739ec..6b28cdbb3c 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -230,7 +230,7 @@ EXTRA_IMAGECMD_jffs2 ?= "--pad ${JFFS2_ENDIANNESS} 
--eraseblock=${JFFS2_ERASEBLO
 EXTRA_IMAGECMD_ext2 ?= "-i 4096"
 EXTRA_IMAGECMD_ext3 ?= "-i 4096"
 EXTRA_IMAGECMD_ext4 ?= "-i 4096"
-EXTRA_IMAGECMD_btrfs ?= "-n 4096"
+EXTRA_IMAGECMD_btrfs ?= "-n 4096 --shrink"
 EXTRA_IMAGECMD_f2fs ?= ""
 
 do_image_cpio[depends] += "cpio-native:do_populate_sysroot"
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#154171): 
https://lists.openembedded.org/g/openembedded-core/message/154171
Mute This Topic: https://lists.openembedded.org/mt/84485606/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH][hardknott] linux-firmware: Package RSI 911x WiFi firmware

2021-07-11 Thread Marek Vasut
The RSI 911x WiFi firmware is already part of the linux-firmware
repository, package it to make it easily available.

Signed-off-by: Marek Vasut 
Cc: Richard Purdie 
Cc: Steve Sakoman 
---
NOTE: Small firmware backport, similar to the one picked for dunfell
---
 .../linux-firmware/linux-firmware_20210511.bb | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20210511.bb 
b/meta/recipes-kernel/linux-firmware/linux-firmware_20210511.bb
index ed6e78175a..26091fba70 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_20210511.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20210511.bb
@@ -229,6 +229,7 @@ PACKAGES =+ "${PN}-ralink-license ${PN}-ralink \
  ${PN}-sd8887 ${PN}-sd8897 ${PN}-sd8997 ${PN}-usb8997 \
  ${PN}-ti-connectivity-license ${PN}-wlcommon ${PN}-wl12xx 
${PN}-wl18xx \
  ${PN}-vt6656-license ${PN}-vt6656 \
+ ${PN}-rs9113 ${PN}-rs9116 \
  ${PN}-rtl-license ${PN}-rtl8188 ${PN}-rtl8192cu ${PN}-rtl8192ce 
${PN}-rtl8192su ${PN}-rtl8723 ${PN}-rtl8821 \
  ${PN}-rtl8168 \
  ${PN}-cypress-license \
@@ -529,6 +530,16 @@ RDEPENDS_${PN}-nvidia-gpu += "${PN}-nvidia-license"
 RDEPENDS_${PN}-nvidia-tegra += "${PN}-nvidia-license"
 RDEPENDS_${PN}-nvidia-tegra-k1 += "${PN}-nvidia-license"
 
+# For RSI RS911x WiFi
+LICENSE_${PN}-rs9113 = "WHENCE"
+LICENSE_${PN}-rs9116 = "WHENCE"
+
+FILES_${PN}-rs9113 = " ${nonarch_base_libdir}/firmware/rsi/rs9113*.rps "
+FILES_${PN}-rs9116 = " ${nonarch_base_libdir}/firmware/rsi/rs9116*.rps "
+
+RDEPENDS_${PN}-rs9113 += "${PN}-whence-license"
+RDEPENDS_${PN}-rs9116 += "${PN}-whence-license"
+
 # For rtl
 LICENSE_${PN}-rtl8188 = "Firmware-rtlwifi_firmware"
 LICENSE_${PN}-rtl8192cu = "Firmware-rtlwifi_firmware"
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#153731): 
https://lists.openembedded.org/g/openembedded-core/message/153731
Mute This Topic: https://lists.openembedded.org/mt/84136556/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH][dunfell] bootchart2: update 0.14.8 -> 0.14.9

2021-07-11 Thread Marek Vasut
From: Alexander Kanavin 

Signed-off-by: Alexander Kanavin 
Signed-off-by: Richard Purdie 
---
NOTE: We need this in dunfell too, since it fixes python 3.8 compatibility.
---
 .../bootchart2/{bootchart2_0.14.8.bb => bootchart2_0.14.9.bb}  | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
 rename meta/recipes-devtools/bootchart2/{bootchart2_0.14.8.bb => 
bootchart2_0.14.9.bb} (99%)

diff --git a/meta/recipes-devtools/bootchart2/bootchart2_0.14.8.bb 
b/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
similarity index 99%
rename from meta/recipes-devtools/bootchart2/bootchart2_0.14.8.bb
rename to meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
index a938b2da49..6571c19938 100644
--- a/meta/recipes-devtools/bootchart2/bootchart2_0.14.8.bb
+++ b/meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb
@@ -97,8 +97,7 @@ SRC_URI = "git://github.com/xrmx/bootchart.git \
   "
 
 S = "${WORKDIR}/git"
-SRCREV = "331ada031f1d65f6d934d918f896e1c708c64bf7"
-PV .= "+git${SRCPV}"
+SRCREV = "868a2afab9da34f32c007d773b77253c93104636"
 
 inherit systemd update-rc.d python3native update-alternatives
 
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#153725): 
https://lists.openembedded.org/g/openembedded-core/message/153725
Mute This Topic: https://lists.openembedded.org/mt/84131990/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] update-rc.d: update SRCREV to pull in fix for non-bash shell support

2021-07-09 Thread Marek Vasut

On 7/9/21 8:32 PM, Steve Sakoman wrote:

I'll cherry-pick this into dunfell once it hits master.


Thank you

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#153710): 
https://lists.openembedded.org/g/openembedded-core/message/153710
Mute This Topic: https://lists.openembedded.org/mt/84097520/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH][dunfell] update-rc.d: update SRCREV to pull in fix for non-bash shell support

2021-07-09 Thread Marek Vasut
This pulls in non-bash shell fix for enable/disable command, upstream
commit 8636cf4 ("update-rc.d: Fix enable/disable command"). This way
update-rc.d works with e.g. dash shell again.

Signed-off-by: Marek Vasut 
Cc: Changqing Li 
Cc: Richard Purdie 
Cc: Steve Sakoman 
---
 meta/recipes-core/update-rc.d/update-rc.d_0.8.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/update-rc.d/update-rc.d_0.8.bb 
b/meta/recipes-core/update-rc.d/update-rc.d_0.8.bb
index 75632d9434..da716674c3 100644
--- a/meta/recipes-core/update-rc.d/update-rc.d_0.8.bb
+++ b/meta/recipes-core/update-rc.d/update-rc.d_0.8.bb
@@ -7,7 +7,7 @@ LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = 
"file://update-rc.d;beginline=5;endline=15;md5=d40a07c27f535425934bb5001f2037d9"
 
 SRC_URI = "git://git.yoctoproject.org/update-rc.d"
-SRCREV = "4b150b25b38de688d25cde2b2d22c268ed65a748"
+SRCREV = "8636cf478d426b568c1be11dbd9346f67e03adac"
 
 UPSTREAM_CHECK_COMMITS = "1"
 
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#153708): 
https://lists.openembedded.org/g/openembedded-core/message/153708
Mute This Topic: https://lists.openembedded.org/mt/84097520/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] update-rc.d: update SRCREV to pull in fix for non-bash shell support

2021-07-09 Thread Marek Vasut
This pulls in non-bash shell fix for enable/disable command, upstream
commit 8636cf4 ("update-rc.d: Fix enable/disable command"). This way
update-rc.d works with e.g. dash shell again.

Signed-off-by: Marek Vasut 
Cc: Changqing Li 
Cc: Richard Purdie 
---
 meta/recipes-core/update-rc.d/update-rc.d_0.8.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/update-rc.d/update-rc.d_0.8.bb 
b/meta/recipes-core/update-rc.d/update-rc.d_0.8.bb
index 75632d9434..da716674c3 100644
--- a/meta/recipes-core/update-rc.d/update-rc.d_0.8.bb
+++ b/meta/recipes-core/update-rc.d/update-rc.d_0.8.bb
@@ -7,7 +7,7 @@ LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = 
"file://update-rc.d;beginline=5;endline=15;md5=d40a07c27f535425934bb5001f2037d9"
 
 SRC_URI = "git://git.yoctoproject.org/update-rc.d"
-SRCREV = "4b150b25b38de688d25cde2b2d22c268ed65a748"
+SRCREV = "8636cf478d426b568c1be11dbd9346f67e03adac"
 
 UPSTREAM_CHECK_COMMITS = "1"
 
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#153707): 
https://lists.openembedded.org/g/openembedded-core/message/153707
Mute This Topic: https://lists.openembedded.org/mt/84097501/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] pulseaudio: Drop pulseaudio-conf

2021-07-08 Thread Marek Vasut
The pulseaudio.inc currently contains these two assignments:
  FILES_${PN}-conf = "${sysconfdir}"
  FILES_${PN}-server = "... ${sysconfdir} ..."
This results in pulseaudio-server shipping the configuration
in /etc/pulse/ , and based on CONFFILES_${PN}-server and co.,
this is how it was intended to work.

However, that also means FILES_${PN}-conf is not useful. In fact,
FILES_${PN}-conf is likely meant for MACHINE specific configuration,
which would better be packaged in separate recipe like e.g. systemd
does in systemd-conf_%.bb . Better yet, such pulseaudio-conf_%.bb
could ship MACHINE specific configuration overrides, which according
to pulse-daemon.conf(5) are picked from /etc/pulse/daemon.conf.d ,
while pulseaudio-server would ship the default configuration files.

Remove FILES_${PN}-conf .

Signed-off-by: Marek Vasut 
Cc: Tanu Kaskinen 
Cc: Richard Purdie 
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc 
b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 005cb36b8e..2c9e8167c4 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -183,7 +183,6 @@ FILES_libpulse-simple = "${libdir}/libpulse-simple.so.*"
 FILES_libpulse-mainloop-glib = "${libdir}/libpulse-mainloop-glib.so.*"
 
 FILES_${PN}-dev += "${libdir}/pulse-${PV}/modules/*.la ${datadir}/vala 
${libdir}/cmake"   
-FILES_${PN}-conf = "${sysconfdir}"
 FILES_${PN}-bin += "${sysconfdir}/default/volatiles/04_pulse"
 FILES_${PN}-pa-info = "${bindir}/pa-info"
 FILES_${PN}-server = "${bindir}/pulseaudio ${bindir}/start-* ${sysconfdir} 
${bindir}/pactl */udev/rules.d/*.rules */*/udev/rules.d/*.rules 
${systemd_user_unitdir}/*"
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#153688): 
https://lists.openembedded.org/g/openembedded-core/message/153688
Mute This Topic: https://lists.openembedded.org/mt/84067638/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [dunfell][PATCH] make-mod-scripts: add HOSTCXX definitions and gmp-native dependency

2021-05-05 Thread Marek Vasut
From: Bruce Ashfield 

With kernel v5.8+ and gcc10 plugins, we can run into the following build error:

  HOSTCXX -fPIC scripts/gcc-plugins/arm_ssp_per_task_plugin.o
In file included from

/home/pokybuild/yocto-worker/qemuarm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/make-mod-scripts/1.0-r0/recipe-sysroot-native/usr/bin/arm-poky-linux-gnueabi/../../lib/arm-poky-linux-gnueabi/gcc/arm-poky-linux-gnueabi/10.1.0/plugin/include/gcc-plugin.h:28,
 from

/home/pokybuild/yocto-worker/qemuarm/build/build/tmp/work-shared/qemuarm/kernel-source/scripts/gcc-plugins/gcc-common.h:7,
 from

/home/pokybuild/yocto-worker/qemuarm/build/build/tmp/work-shared/qemuarm/kernel-source/scripts/gcc-plugins/arm_ssp_per_task_plugin.c:3:

/home/pokybuild/yocto-worker/qemuarm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/make-mod-scripts/1.0-r0/recipe-sysroot-native/usr/bin/arm-poky-linux-gnueabi/../../lib/arm-poky-linux-gnueabi/gcc/arm-poky-linux-gnueabi/10.1.0/plugin/include/system.h:687:10:
fatal error: gmp.h: No such file or directory
  687 | #include 
  |  ^~~

Signed-off-by: Bruce Ashfield 
Signed-off-by: Richard Purdie 
(cherry picked from commit cb055446e0fe4771c8bd6122e79d43ef8db2e45b)
---
 meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb 
b/meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb
index 87b7d240f5..b58fa9a603 100644
--- a/meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb
+++ b/meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb
@@ -16,8 +16,10 @@ do_compile[depends] += 
"virtual/kernel:do_compile_kernelmodules"
 RDEPENDS_${PN}-dev = ""
 
 DEPENDS += "bc-native bison-native"
+DEPENDS += "gmp-native"
 
 EXTRA_OEMAKE = " HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}" 
HOSTCPP="${BUILD_CPP}""
+EXTRA_OEMAKE += " HOSTCXX="${BUILD_CXX} ${BUILD_CXXFLAGS} ${BUILD_LDFLAGS}""
 
 # Build some host tools under work-shared.  CC, LD, and AR are probably
 # not used, but this is the historical way of invoking "make scripts".
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151348): 
https://lists.openembedded.org/g/openembedded-core/message/151348
Mute This Topic: https://lists.openembedded.org/mt/82613649/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH V2] linux-firmware: Package RSI 911x WiFi firmware

2021-04-24 Thread Marek Vasut

On 3/25/21 7:47 PM, Marek Vasut wrote:

On 3/12/21 9:57 PM, Marek Vasut wrote:

The RSI 911x WiFi firmware is already part of the linux-firmware
repository, package it to make it easily available.

Signed-off-by: Marek Vasut 
Cc: Richard Purdie 
Cc: Steve Sakoman 
---
V2: Rebase on current oe-core/master


Bump ?


Any news on this patch ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#150881): 
https://lists.openembedded.org/g/openembedded-core/message/150881
Mute This Topic: https://lists.openembedded.org/mt/81290193/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH V2] linux-firmware: Package RSI 911x WiFi firmware

2021-03-25 Thread Marek Vasut

On 3/12/21 9:57 PM, Marek Vasut wrote:

The RSI 911x WiFi firmware is already part of the linux-firmware
repository, package it to make it easily available.

Signed-off-by: Marek Vasut 
Cc: Richard Purdie 
Cc: Steve Sakoman 
---
V2: Rebase on current oe-core/master


Bump ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149946): 
https://lists.openembedded.org/g/openembedded-core/message/149946
Mute This Topic: https://lists.openembedded.org/mt/81290193/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] linux-firmware: Package RSI RS911x WiFi firmware

2021-03-12 Thread Marek Vasut

On 3/12/21 5:55 PM, Richard Purdie wrote:

On Fri, 2021-03-12 at 16:30 +0100, Marek Vasut wrote:

The RSI 911x WiFi firmware is already part of the linux-firmware
repository, package it to make it easily available.

Signed-off-by: Marek Vasut 
Cc: Richard Purdie 
Cc: Steve Sakoman 
---
  .../linux-firmware/linux-firmware_20201218.bb | 11 +++
  1 file changed, 11 insertions(+)


Doesn't seem to apply against master?


Argh, I rebased and sent V2. That should work better, sorry for the 
inconvenience.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149370): 
https://lists.openembedded.org/g/openembedded-core/message/149370
Mute This Topic: https://lists.openembedded.org/mt/81281470/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH V2] linux-firmware: Package RSI 911x WiFi firmware

2021-03-12 Thread Marek Vasut
The RSI 911x WiFi firmware is already part of the linux-firmware
repository, package it to make it easily available.

Signed-off-by: Marek Vasut 
Cc: Richard Purdie 
Cc: Steve Sakoman 
---
V2: Rebase on current oe-core/master
---
 .../linux-firmware/linux-firmware_20210208.bb | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20210208.bb 
b/meta/recipes-kernel/linux-firmware/linux-firmware_20210208.bb
index 1881a8e065..f1d049f1d5 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_20210208.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20210208.bb
@@ -229,6 +229,7 @@ PACKAGES =+ "${PN}-ralink-license ${PN}-ralink \
  ${PN}-sd8887 ${PN}-sd8897 ${PN}-sd8997 ${PN}-usb8997 \
  ${PN}-ti-connectivity-license ${PN}-wlcommon ${PN}-wl12xx 
${PN}-wl18xx \
  ${PN}-vt6656-license ${PN}-vt6656 \
+ ${PN}-rs9113 ${PN}-rs9116 \
  ${PN}-rtl-license ${PN}-rtl8188 ${PN}-rtl8192cu ${PN}-rtl8192ce 
${PN}-rtl8192su ${PN}-rtl8723 ${PN}-rtl8821 \
  ${PN}-rtl8168 \
  ${PN}-cypress-license \
@@ -522,6 +523,16 @@ RDEPENDS_${PN}-nvidia-gpu += "${PN}-nvidia-license"
 RDEPENDS_${PN}-nvidia-tegra += "${PN}-nvidia-license"
 RDEPENDS_${PN}-nvidia-tegra-k1 += "${PN}-nvidia-license"
 
+# For RSI RS911x WiFi
+LICENSE_${PN}-rs9113 = "WHENCE"
+LICENSE_${PN}-rs9116 = "WHENCE"
+
+FILES_${PN}-rs9113 = " ${nonarch_base_libdir}/firmware/rsi/rs9113*.rps "
+FILES_${PN}-rs9116 = " ${nonarch_base_libdir}/firmware/rsi/rs9116*.rps "
+
+RDEPENDS_${PN}-rs9113 += "${PN}-whence-license"
+RDEPENDS_${PN}-rs9116 += "${PN}-whence-license"
+
 # For rtl
 LICENSE_${PN}-rtl8188 = "Firmware-rtlwifi_firmware"
 LICENSE_${PN}-rtl8192cu = "Firmware-rtlwifi_firmware"
-- 
2.30.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149369): 
https://lists.openembedded.org/g/openembedded-core/message/149369
Mute This Topic: https://lists.openembedded.org/mt/81290193/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] linux-firmware: Package RSI RS911x WiFi firmware

2021-03-12 Thread Marek Vasut
The RSI 911x WiFi firmware is already part of the linux-firmware
repository, package it to make it easily available.

Signed-off-by: Marek Vasut 
Cc: Richard Purdie 
Cc: Steve Sakoman 
---
 .../linux-firmware/linux-firmware_20201218.bb | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20201218.bb 
b/meta/recipes-kernel/linux-firmware/linux-firmware_20201218.bb
index 700a79b118..c293d56767 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_20201218.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20201218.bb
@@ -225,6 +225,7 @@ PACKAGES =+ "${PN}-ralink-license ${PN}-ralink \
  ${PN}-sd8887 ${PN}-sd8897 ${PN}-sd8997 ${PN}-usb8997 \
  ${PN}-ti-connectivity-license ${PN}-wlcommon ${PN}-wl12xx 
${PN}-wl18xx \
  ${PN}-vt6656-license ${PN}-vt6656 \
+ ${PN}-rs9113 ${PN}-rs9116 \
  ${PN}-rtl-license ${PN}-rtl8188 ${PN}-rtl8192cu ${PN}-rtl8192ce 
${PN}-rtl8192su ${PN}-rtl8723 ${PN}-rtl8821 \
  ${PN}-rtl8168 \
  ${PN}-cypress-license \
@@ -518,6 +519,16 @@ RDEPENDS_${PN}-nvidia-gpu += "${PN}-nvidia-license"
 RDEPENDS_${PN}-nvidia-tegra += "${PN}-nvidia-license"
 RDEPENDS_${PN}-nvidia-tegra-k1 += "${PN}-nvidia-license"
 
+# For RSI RS911x WiFi
+LICENSE_${PN}-rs9113 = "WHENCE"
+LICENSE_${PN}-rs9116 = "WHENCE"
+
+FILES_${PN}-rs9113 = " ${nonarch_base_libdir}/firmware/rsi/rs9113*.rps "
+FILES_${PN}-rs9116 = " ${nonarch_base_libdir}/firmware/rsi/rs9116*.rps "
+
+RDEPENDS_${PN}-rs9113 += "${PN}-whence-license"
+RDEPENDS_${PN}-rs9116 += "${PN}-whence-license"
+
 # For rtl
 LICENSE_${PN}-rtl8188 = "Firmware-rtlwifi_firmware"
 LICENSE_${PN}-rtl8192cu = "Firmware-rtlwifi_firmware"
-- 
2.30.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149354): 
https://lists.openembedded.org/g/openembedded-core/message/149354
Mute This Topic: https://lists.openembedded.org/mt/81281470/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH][dunfell] kernel.bbclass: Configuration for environment with HOSTCXX

2021-03-12 Thread Marek Vasut
From: Zhang Qiang 

When compiling xilinx-zynq board linux-kernel-dev(v5.8) if
"GCC_PLUGINS=y", The following error will appear:

"HOSTCXX -fPIC scripts/gcc-plugins/arm_ssp_per_task_plugin.o
fatal error: gmp.h: No such file or directory"

the GCC_PLUGINS depend on return result of gcc-plugin.sh execution
however in gcc-plugin.sh use HOSTCC to detect the feature of GNU
extension of gcc, this will result that HOSTCC can compile the file
successfully, but HOSTCXX is used in the actual compilation process.

Signed-off-by: Zhang Qiang 
Signed-off-by: Bruce Ashfield 
Signed-off-by: Richard Purdie 
Cc: Armin Kuster 
---
NOTE: I am running into the same problem when compiling v5.10.y, so
  it would be helpful to backport this patch.
  740d87766c ("kernel.bbclass: Configuration for environment with HOSTCXX")
---
 meta/classes/kernel.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 83a574efcd..22b1224d79 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -194,6 +194,8 @@ UBOOT_LOADADDRESS ?= "${UBOOT_ENTRYPOINT}"
 KERNEL_EXTRA_ARGS ?= ""
 
 EXTRA_OEMAKE = " HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}" 
HOSTCPP="${BUILD_CPP}""
+EXTRA_OEMAKE += " HOSTCXX="${BUILD_CXX} ${BUILD_CXXFLAGS} ${BUILD_LDFLAGS}""
+
 KERNEL_ALT_IMAGETYPE ??= ""
 
 copy_initramfs() {
-- 
2.30.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149346): 
https://lists.openembedded.org/g/openembedded-core/message/149346
Mute This Topic: https://lists.openembedded.org/mt/81279573/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH][dunfell] weston-init: Fix weston-keyboard path in weston.ini

2021-02-14 Thread Marek Vasut
The weston-keyboard executable is installed into /usr/libexec
instead of /usr/lib/weston , correct the path in weston.ini .

Signed-off-by: Marek Vasut 
Cc: Khem Raj 
Cc: Richard Purdie 
---
NOTE: this could be applied at least all the way to Dunfell / 3.1.y
---
 meta/recipes-graphics/wayland/weston-init/weston.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/wayland/weston-init/weston.ini 
b/meta/recipes-graphics/wayland/weston-init/weston.ini
index 1e6dff68fd..40c5195887 100644
--- a/meta/recipes-graphics/wayland/weston-init/weston.ini
+++ b/meta/recipes-graphics/wayland/weston-init/weston.ini
@@ -42,7 +42,7 @@ require-input=false
 #path=/build/weston-0lEgCh/weston-1.11.0/weston-flower
 
 #[input-method]
-#path=/usr/lib/weston/weston-keyboard
+#path=/usr/libexec/weston-keyboard
 
 #[output]
 #name=LVDS1
-- 
2.30.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#148020): 
https://lists.openembedded.org/g/openembedded-core/message/148020
Mute This Topic: https://lists.openembedded.org/mt/80631327/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] weston-init: Fix weston-keyboard path in weston.ini

2021-02-14 Thread Marek Vasut
The weston-keyboard executable is installed into /usr/libexec
instead of /usr/lib/weston , correct the path in weston.ini .

Signed-off-by: Marek Vasut 
Cc: Khem Raj 
Cc: Richard Purdie 
---
NOTE: this could be applied at least all the way to Dunfell / 3.1.y
---
 meta/recipes-graphics/wayland/weston-init/weston.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/wayland/weston-init/weston.ini 
b/meta/recipes-graphics/wayland/weston-init/weston.ini
index b48726d59c..6bd5aef55a 100644
--- a/meta/recipes-graphics/wayland/weston-init/weston.ini
+++ b/meta/recipes-graphics/wayland/weston-init/weston.ini
@@ -42,7 +42,7 @@ require-input=false
 #path=/build/weston-0lEgCh/weston-1.11.0/weston-flower
 
 #[input-method]
-#path=/usr/lib/weston/weston-keyboard
+#path=/usr/libexec/weston-keyboard
 
 #[output]
 #name=LVDS1
-- 
2.30.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#148019): 
https://lists.openembedded.org/g/openembedded-core/message/148019
Mute This Topic: https://lists.openembedded.org/mt/80631296/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 1/2] meta: toolchain-shar-relocate.sh: Do not use $target_sdk_dir as regex

2020-12-23 Thread Marek Vasut
The $target_sdk_dir path might contain special characters, for example if
the path is /opt/poky/3.2+snapshot . Prevent grep from interpreting those
as part of the regex by using the -F parameter and multiple -e parameters
to specify which strings to filter out. Also note that the previous regex
was using asterisk as wildcard (e.g. environment-setup-*), but that should
have been regex (e.g. environment-setup-.*, with dot) to match correctly,
this is also fixed by this change.

Fixes: 9721378688 ("toolchain-shar-template.sh: Make relocation optional.")
Signed-off-by: Marek Vasut 
Cc: Joshua Watt 
Cc: Krzysztof Zawadzki 
Cc: Randy Witt 
Cc: Richard Purdie 
Cc: Ross Burton 
---
 meta/files/toolchain-shar-relocate.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/files/toolchain-shar-relocate.sh 
b/meta/files/toolchain-shar-relocate.sh
index e3c10018ef..9c358a53e2 100644
--- a/meta/files/toolchain-shar-relocate.sh
+++ b/meta/files/toolchain-shar-relocate.sh
@@ -56,7 +56,9 @@ for replace in "$target_sdk_dir -maxdepth 1" 
"$native_sysroot"; do
$SUDO_EXEC find $replace -type f
 done | xargs -n100 file | grep ":.*\(ASCII\|script\|source\).*text" | \
 awk -F':' '{printf "\"%s\"\n", $1}' | \
-grep -Ev "$target_sdk_dir/(environment-setup-*|relocate_sdk*|${0##*/})" | \
+grep -Fv -e "$target_sdk_dir/environment-setup-" \
+ -e "$target_sdk_dir/relocate_sdk" \
+ -e "$target_sdk_dir/${0##*/}" | \
 xargs -n100 $SUDO_EXEC sed -i \
 -e "s:$DEFAULT_INSTALL_DIR:$target_sdk_dir:g" \
 -e "s:^#! */usr/bin/perl.*:#! /usr/bin/env perl:g" \
-- 
2.29.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#146127): 
https://lists.openembedded.org/g/openembedded-core/message/146127
Mute This Topic: https://lists.openembedded.org/mt/79184140/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 2/2] meta: toolchain-shar-relocate.sh: Filter out post-relocate-setup script

2020-12-23 Thread Marek Vasut
The toolchain-shar-extract.sh script updates the SDK relocation paths in
post-relocate-setup.sh, so avoid doing this twice. This is generally not
a problem, unless the SDK path is a subset of the SDK relocation path, in
which case the resulting path is substituted twice. To trigger the issue,
  $ 
./tmp/deploy/sdk/poky-glibc-x86_64-core-image-base-core2-64-qemux86-64-toolchain-3.2+snapshot.sh
 -y -d /home/oe/.local/opt/poky/3.2+snapshot
which generates relocation path
  /home/oe/.local/home/oe/.local/opt/poky/3.2+snapshot
instead of
  /home/oe/.local/opt/poky/3.2+snapshot

Fixes: 93ec145f42 ("toolchain-shar-extract: Add post-relocate scripts")
Signed-off-by: Marek Vasut 
Cc: Joshua Watt 
Cc: Krzysztof Zawadzki 
Cc: Randy Witt 
Cc: Richard Purdie 
Cc: Ross Burton 
---
 meta/files/toolchain-shar-relocate.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/files/toolchain-shar-relocate.sh 
b/meta/files/toolchain-shar-relocate.sh
index 9c358a53e2..94d288ce05 100644
--- a/meta/files/toolchain-shar-relocate.sh
+++ b/meta/files/toolchain-shar-relocate.sh
@@ -58,6 +58,7 @@ done | xargs -n100 file | grep 
":.*\(ASCII\|script\|source\).*text" | \
 awk -F':' '{printf "\"%s\"\n", $1}' | \
 grep -Fv -e "$target_sdk_dir/environment-setup-" \
  -e "$target_sdk_dir/relocate_sdk" \
+ -e "$target_sdk_dir/post-relocate-setup" \
  -e "$target_sdk_dir/${0##*/}" | \
 xargs -n100 $SUDO_EXEC sed -i \
 -e "s:$DEFAULT_INSTALL_DIR:$target_sdk_dir:g" \
-- 
2.29.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#146126): 
https://lists.openembedded.org/g/openembedded-core/message/146126
Mute This Topic: https://lists.openembedded.org/mt/79184139/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



  1   2   3   4   5   >