Re: Cryptic exception when drawing in huge canvas

[Kevin Rushforth]

There is already a bug filed on this:

https://bugs.openjdk.java.net/browse/JDK-8089835

Yes, a more meaningful error message would be useful.

-- Kevin


On 11/8/2018 11:35 AM, Selim Dincer wrote:

Hey,

this morning I was doing something with the canvas control and got its size
wrong. It was way taller than I expected and I had an NPE somewhere in
NGCanvas but I didn't really understand what was wrong because nothing was
pointing to my code. I don't know how it behaves on linux, I was running
Windows 10.

A minimal example looks like following:

import javafx.application.Application;
import javafx.scene.Scene;
import javafx.scene.canvas.Canvas;
import javafx.scene.image.Image;
import javafx.scene.layout.BorderPane;
import javafx.stage.Stage;

public class CanvasTest extends Application {
 @Override
 public void start(Stage primaryStage) throws Exception {
 Canvas canvas = new Canvas(128, 1);
 Image img = new
Image("https://www.google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png;);
 canvas.getGraphicsContext2D().drawImage(img, 0, 0, 128, 128);

 primaryStage.setScene(new Scene(new BorderPane(canvas)));
 primaryStage.show();
 }
}

The StackTrace of the NPE looks like following:
java.lang.NullPointerException
at com.sun.javafx.sg.prism.NGCanvas$RenderBuf.validate(NGCanvas.java:213)
at com.sun.javafx.sg.prism.NGCanvas.initCanvas(NGCanvas.java:640)
at com.sun.javafx.sg.prism.NGCanvas.renderContent(NGCanvas.java:603)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:576)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
at com.sun.javafx.tk.quantum.ViewPainter.doPaint(ViewPainter.java:477)
at com.sun.javafx.tk.quantum.ViewPainter.paintImpl(ViewPainter.java:330)
at
com.sun.javafx.tk.quantum.PresentingPainter.run(PresentingPainter.java:91)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at com.sun.javafx.tk.RenderJob.run(RenderJob.java:58)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at
com.sun.javafx.tk.quantum.QuantumRenderer$PipelineRunnable.run(QuantumRenderer.java:125)
at java.lang.Thread.run(Thread.java:748)

I guess you might have to make the canvas a little larger than that to
reproduce it on your system. I was creating the canvas as graphic of a
listcell and didn't realize that it was so large until I started debugging
(in this example the stage height indicates that something's wrong).
Maybe there should be a check with a more meaningful error message?

Thanks,
Selim

RFR: JDK-8088418: Reintroducing the JFR Pulse Logger

[Marcus Hirt]

Hi all,

Please review this PR to reintroduce the JFR Pulse Logger.

Jira:   https://bugs.openjdk.java.net/browse/JDK-8088418
PR: https://github.com/javafxports/openjdk-jfx/pull/272

Kind regards,
Marcus

Re: Problems building openjfx

[Michael Ennen]

Indeed it requires choco package manager and it is meant to be run in
powershell.

Thank you for taking the time to report what worked for you. If there are
any changes
you think should be added to the script, feel free to open a PR on
https://github.com/javafxports/openjdk-jfx
as it is now officially part of the GitHub repository. I sort of hacked it
together very quickly and
only tested it on my local dev machine so improvements are definitely
welcome.

On Thu, Nov 8, 2018 at 9:38 AM Dean Wookey  wrote:

> Hi Johan,
>
> Michael's build script helped me a lot. I'm on windows 10. It just runs in
> powershell after installing chocolatey, (.\tools\scripts\build1.ps from
> the openjdk root dir). The only environment variables I've got set are
> JAVA_HOME/JDK_HOME. I did have to make some modifications however to
> install the other dependencies and to handle the .dll's that weren't
> packaged. Everything ran fine on my machine, but as soon as I tried using
> the jars on another machine, I got linker errors. Below is the modified
> version. It won't package the correct dlls if DebugNative is used though,
> but as it is, it's working for me.
>
> Dean
>
> .\gradlew --stop
> choco install ant
> choco install vswhere
> choco install zip
> choco install visualstudio2017community
> choco install visualstudio2017-workload-nativedesktop
> choco install windows-sdk-7.1
> choco install cygwin
>
> $cygwinPath = (Get-ItemProperty -Path
> "HKLM:\SOFTWARE\Cygwin\setup").rootdir
> $env:Path += ";$($cygwinPath)\bin"
>
> $env:WINSDK_DIR = (Get-ItemProperty -Path
> "HKLM:\SOFTWARE\Wow6432Node\Microsoft\Windows Kits\Installed
> Roots").KitsRoot10
> $env:VCINSTALLDIR = "$(vswhere -legacy -latest -property
> installationPath)\VC\Auxiliary\Build"
> $vcRoot = "$(vswhere -legacy -latest -property installationPath)"
> $msvcToolsVer = Get-Content
> "$env:VCINSTALLDIR\Microsoft.VCToolsVersion.default.txt"
> $msvcRedistVer = Get-Content
> "$env:VCINSTALLDIR\Microsoft.VCRedistVersion.default.txt"
>
> if ([string]::IsNullOrWhitespace($msvcToolsVer)) {
>   # The MSVC tools version file can have txt *or* props extension.
>   $msvcToolsVer = Get-Content
> "$env:VCINSTALLDIR\Microsoft.VCToolsVersion.default.props"
> }
> $env:MSVC_VER = $msvcToolsVer
> $env:MSVC_REDIST_VER = $msvcRedistVer
>
> $files = Get-ChildItem
> "$($vcRoot)/VC/Redist/MSVC/$($msvcRedistVer)/x86/*.CRT/"
> $crtVer = $files[0].Name.replace("Microsoft.VC","").replace(".CRT","")
> $env:WINDOWS_CRT_VER = $crtVer
>
>
> $env:VS150COMNTOOLS = $env:VCINSTALLDIR
> $env:VSVARS32FILE = "$env:VCINSTALLDIR\vcvars32.bat"
> refreshenv
> if ($env:APPVEYOR -eq "true") {
>   .\gradlew all test -PCOMPILE_WEBKIT=false -PCONF=Debug --stacktrace -x
> :web:test --info --no-daemon
>   if ($lastexitcode -ne 0) {
> exit $lastexitcode
>   }
> } else {
>   .\gradlew all test -PCOMPILE_WEBKIT=false -PCONF=Debug --stacktrace -x
> :web:test --info
> }
>
> On Fri, Nov 2, 2018 at 8:57 PM Johan Vos  wrote:
>
>> Hi Michael,
>>
>> What environment do you use to run that Windows build script?
>> The windows builds are the ones I still feel least comfortable about. We
>> tried to automate those on AdoptOpenJDK infrastructure, but they are using
>> Ansible for provisioning machines (for very good reasons), and we spent
>> days trying to come up with an Ansible script that allowed to build on
>> Windows, without 100% success.
>> Hence, we currently create the windows build on a Windows machine with a
>> fixed setup. It would be better of course to move more of the environment
>> and context parameters to the build procedure itself, and your script
>> seems
>> a step in that direction. But what infrastructure do you use to run this?
>>
>> - Johan
>>
>> On Thu, Nov 1, 2018 at 11:17 PM Michael Ennen 
>> wrote:
>>
>> > Also don't forget about the Windows build script:
>> >
>> >
>> >
>> https://github.com/javafxports/openjdk-jfx/blob/develop/tools/scripts/build.ps1
>> >
>> > It is what I use to automate the process of building OpenJFX on Windows
>> as
>> > much as
>> > possible. Any improvements to the script would be appreciated.
>> >
>> > On Wed, Oct 31, 2018 at 7:03 AM  wrote:
>> >
>> > > forgot the link to the instruction page, just in case there's another:
>> > >
>> > >
>> > >
>> >
>> https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-EnvironmentVariables
>> > >
>> > > Zitat von faste...@swingempire.de:
>> > >
>> > > > first try, following the instructions (for win10) at:
>> > > >
>> > > > that is having downloaded, installed the required tools, added env
>> > > > vars as desribed.
>> > > >
>> > > > Then in cygwin, navigate to the git working dir, typing
>> > > >
>> > > > gradle tasks
>> > > >
>> > > > fails with:
>> > > >
>> > > > FAILURE: Build failed with an exception.
>> > > >
>> > > > * Where:
>> > > > Script
>> > > >
>> > >
>> >
>> 'C:\Daten\data-for-work\eclipse\gitrep-openjdk\openjdk-jfx\buildSrc\win.gradle'
>> > > line:
>> > > > 92
>> > > >
>> > > > * What went wrong:
>> > 

RE: COMPILE_MEDIA Error on 8udev - DirectShow Question

[carl]

Thanks for your help Artur.  I’ve compiled successfully and AudioClip is 
working without throwing the glib lite link error.

 

For those also interested in compiling on a new machine, download the Windows 7 
SDK.  Before installing, make sure that you’ve removed the VC++ 2010 
Redistributable (x86+64).  The installer will give you a warning, but press OK. 
 The files will show up in the program files / Microsoft sdks / windows / v7.1 
folder.

 

Return to the hg/rt source and run gradle -PCOMPILE_MEDIA=true

 

From: Artur Khusainov  
Sent: Thursday, November 8, 2018 2:18 PM
To: c...@bekwam.com
Cc: openjfx-dev@openjdk.java.net
Subject: Re: COMPILE_MEDIA Error on 8udev - DirectShow Question

 

(misleading attachment in previous message, sorry)

пт, 9 нояб. 2018 г. в 0:15, Artur Khusainov mailto:turik...@gmail.com> >:

This is known issue. You probably already installed Microsoft Visual C++ 2010 
Redistributable. Uninstall both x64 and x86, then try again. 

 

 

чт, 8 нояб. 2018 г. в 23:53, mailto:c...@bekwam.com> >:

Thanks.  I tried installing the Windows 7 SDK from you link, but the installer 
errored out mentioning that I needed the RTM .NET Framework 4.  Should I try to 
install this as well from here?

 

https://www.microsoft.com/en-us/download/details.aspx?id=17851

 

Is it possible to compile and link against the Windows 10 SDK or is everyone 
still on 7?

 

-Carl 

 

From: Artur Khusainov mailto:turik...@gmail.com> > 
Sent: Thursday, November 8, 2018 1:21 PM
To: c...@bekwam.com  
Cc: openjfx-dev@openjdk.java.net  
Subject: Re: COMPILE_MEDIA Error on 8udev - DirectShow Question

 

Hi,

 

Try installing this: 
https://www.microsoft.com/en-us/download/details.aspx?id=8279

чт, 8 нояб. 2018 г., 22:54 mailto:c...@bekwam.com> >:

Hi,



I'm able to build a non-media version of 8udev successfully.  However, when
I try the -PCOMPILE_MEDIA option, I'm getting an error 



> Task :media:buildWinPlugins

make: Entering directory
'/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
ugins'

make
TARGET=/cygdrive/d/hg/rt/modules/media/build/native/win/Release/baseclasses.
lib -f Makefile.BaseClasses

cygpath: cannot create short name of C:\Program Files\Microsoft
SDKs\Windows\v7.1\Samples\multimedia\directshow\baseclasses

make[1]: Entering directory
'/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
ugins'

Usage: cygpath (-d|-m|-u|-w|-t TYPE) [-f FILE] [OPTION]... NAME...



I have a new computer with Visual Studio 2017.   I understand that the
DirectShow libraries have now been incorporated into the Windows SDK.  I
found header files like dshow.h in my hard drvie, but I don't have a
BaseClasses folder.



Has anyone compiled media with a recent VSS or are most people compiling
against residual artifacts from a while ago?



Thanks,

Carl

Cryptic exception when drawing in huge canvas

[Selim Dincer]

Hey,

this morning I was doing something with the canvas control and got its size
wrong. It was way taller than I expected and I had an NPE somewhere in
NGCanvas but I didn't really understand what was wrong because nothing was
pointing to my code. I don't know how it behaves on linux, I was running
Windows 10.

A minimal example looks like following:

import javafx.application.Application;
import javafx.scene.Scene;
import javafx.scene.canvas.Canvas;
import javafx.scene.image.Image;
import javafx.scene.layout.BorderPane;
import javafx.stage.Stage;

public class CanvasTest extends Application {
@Override
public void start(Stage primaryStage) throws Exception {
Canvas canvas = new Canvas(128, 1);
Image img = new
Image("https://www.google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png;);
canvas.getGraphicsContext2D().drawImage(img, 0, 0, 128, 128);

primaryStage.setScene(new Scene(new BorderPane(canvas)));
primaryStage.show();
}
}

The StackTrace of the NPE looks like following:
java.lang.NullPointerException
at com.sun.javafx.sg.prism.NGCanvas$RenderBuf.validate(NGCanvas.java:213)
at com.sun.javafx.sg.prism.NGCanvas.initCanvas(NGCanvas.java:640)
at com.sun.javafx.sg.prism.NGCanvas.renderContent(NGCanvas.java:603)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:576)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
at com.sun.javafx.tk.quantum.ViewPainter.doPaint(ViewPainter.java:477)
at com.sun.javafx.tk.quantum.ViewPainter.paintImpl(ViewPainter.java:330)
at
com.sun.javafx.tk.quantum.PresentingPainter.run(PresentingPainter.java:91)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at com.sun.javafx.tk.RenderJob.run(RenderJob.java:58)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at
com.sun.javafx.tk.quantum.QuantumRenderer$PipelineRunnable.run(QuantumRenderer.java:125)
at java.lang.Thread.run(Thread.java:748)

I guess you might have to make the canvas a little larger than that to
reproduce it on your system. I was creating the canvas as graphic of a
listcell and didn't realize that it was so large until I started debugging
(in this example the stage height indicates that something's wrong).
Maybe there should be a check with a more meaningful error message?

Thanks,
Selim

Re: COMPILE_MEDIA Error on 8udev - DirectShow Question

[Artur Khusainov]

(misleading attachment in previous message, sorry)

пт, 9 нояб. 2018 г. в 0:15, Artur Khusainov :

> This is known issue. You probably already installed Microsoft Visual C++
> 2010 Redistributable. Uninstall both x64 and x86, then try again.
>
>
> чт, 8 нояб. 2018 г. в 23:53, :
>
>> Thanks.  I tried installing the Windows 7 SDK from you link, but the
>> installer errored out mentioning that I needed the RTM .NET Framework 4.
>> Should I try to install this as well from here?
>>
>>
>>
>> https://www.microsoft.com/en-us/download/details.aspx?id=17851
>>
>>
>>
>> Is it possible to compile and link against the Windows 10 SDK or is
>> everyone still on 7?
>>
>>
>>
>> -Carl
>>
>>
>>
>> *From:* Artur Khusainov 
>> *Sent:* Thursday, November 8, 2018 1:21 PM
>> *To:* c...@bekwam.com
>> *Cc:* openjfx-dev@openjdk.java.net
>> *Subject:* Re: COMPILE_MEDIA Error on 8udev - DirectShow Question
>>
>>
>>
>> Hi,
>>
>>
>>
>> Try installing this:
>> https://www.microsoft.com/en-us/download/details.aspx?id=8279
>>
>> чт, 8 нояб. 2018 г., 22:54 :
>>
>> Hi,
>>
>>
>>
>> I'm able to build a non-media version of 8udev successfully.  However,
>> when
>> I try the -PCOMPILE_MEDIA option, I'm getting an error
>>
>>
>>
>> > Task :media:buildWinPlugins
>>
>> make: Entering directory
>>
>> '/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
>> ugins'
>>
>> make
>>
>> TARGET=/cygdrive/d/hg/rt/modules/media/build/native/win/Release/baseclasses.
>> lib -f Makefile.BaseClasses
>>
>> cygpath: cannot create short name of C:\Program Files\Microsoft
>> SDKs\Windows\v7.1\Samples\multimedia\directshow\baseclasses
>>
>> make[1]: Entering directory
>>
>> '/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
>> ugins'
>>
>> Usage: cygpath (-d|-m|-u|-w|-t TYPE) [-f FILE] [OPTION]... NAME...
>>
>>
>>
>> I have a new computer with Visual Studio 2017.   I understand that the
>> DirectShow libraries have now been incorporated into the Windows SDK.  I
>> found header files like dshow.h in my hard drvie, but I don't have a
>> BaseClasses folder.
>>
>>
>>
>> Has anyone compiled media with a recent VSS or are most people compiling
>> against residual artifacts from a while ago?
>>
>>
>>
>> Thanks,
>>
>> Carl
>>
>>
>>

Re: COMPILE_MEDIA Error on 8udev - DirectShow Question

[Artur Khusainov]

This is known issue. You probably already installed Microsoft Visual C++
2010 Redistributable. Uninstall both x64 and x86, then try again.


чт, 8 нояб. 2018 г. в 23:53, :

> Thanks.  I tried installing the Windows 7 SDK from you link, but the
> installer errored out mentioning that I needed the RTM .NET Framework 4.
> Should I try to install this as well from here?
>
>
>
> https://www.microsoft.com/en-us/download/details.aspx?id=17851
>
>
>
> Is it possible to compile and link against the Windows 10 SDK or is
> everyone still on 7?
>
>
>
> -Carl
>
>
>
> *From:* Artur Khusainov 
> *Sent:* Thursday, November 8, 2018 1:21 PM
> *To:* c...@bekwam.com
> *Cc:* openjfx-dev@openjdk.java.net
> *Subject:* Re: COMPILE_MEDIA Error on 8udev - DirectShow Question
>
>
>
> Hi,
>
>
>
> Try installing this:
> https://www.microsoft.com/en-us/download/details.aspx?id=8279
>
> чт, 8 нояб. 2018 г., 22:54 :
>
> Hi,
>
>
>
> I'm able to build a non-media version of 8udev successfully.  However, when
> I try the -PCOMPILE_MEDIA option, I'm getting an error
>
>
>
> > Task :media:buildWinPlugins
>
> make: Entering directory
>
> '/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
> ugins'
>
> make
>
> TARGET=/cygdrive/d/hg/rt/modules/media/build/native/win/Release/baseclasses.
> lib -f Makefile.BaseClasses
>
> cygpath: cannot create short name of C:\Program Files\Microsoft
> SDKs\Windows\v7.1\Samples\multimedia\directshow\baseclasses
>
> make[1]: Entering directory
>
> '/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
> ugins'
>
> Usage: cygpath (-d|-m|-u|-w|-t TYPE) [-f FILE] [OPTION]... NAME...
>
>
>
> I have a new computer with Visual Studio 2017.   I understand that the
> DirectShow libraries have now been incorporated into the Windows SDK.  I
> found header files like dshow.h in my hard drvie, but I don't have a
> BaseClasses folder.
>
>
>
> Has anyone compiled media with a recent VSS or are most people compiling
> against residual artifacts from a while ago?
>
>
>
> Thanks,
>
> Carl
>
>
>

RE: COMPILE_MEDIA Error on 8udev - DirectShow Question

[carl]

Thanks.  I tried installing the Windows 7 SDK from you link, but the installer 
errored out mentioning that I needed the RTM .NET Framework 4.  Should I try to 
install this as well from here?

 

https://www.microsoft.com/en-us/download/details.aspx?id=17851

 

Is it possible to compile and link against the Windows 10 SDK or is everyone 
still on 7?

 

-Carl 

 

From: Artur Khusainov  
Sent: Thursday, November 8, 2018 1:21 PM
To: c...@bekwam.com
Cc: openjfx-dev@openjdk.java.net
Subject: Re: COMPILE_MEDIA Error on 8udev - DirectShow Question

 

Hi,

 

Try installing this: 
https://www.microsoft.com/en-us/download/details.aspx?id=8279

чт, 8 нояб. 2018 г., 22:54 mailto:c...@bekwam.com> >:

Hi,



I'm able to build a non-media version of 8udev successfully.  However, when
I try the -PCOMPILE_MEDIA option, I'm getting an error 



> Task :media:buildWinPlugins

make: Entering directory
'/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
ugins'

make
TARGET=/cygdrive/d/hg/rt/modules/media/build/native/win/Release/baseclasses.
lib -f Makefile.BaseClasses

cygpath: cannot create short name of C:\Program Files\Microsoft
SDKs\Windows\v7.1\Samples\multimedia\directshow\baseclasses

make[1]: Entering directory
'/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
ugins'

Usage: cygpath (-d|-m|-u|-w|-t TYPE) [-f FILE] [OPTION]... NAME...



I have a new computer with Visual Studio 2017.   I understand that the
DirectShow libraries have now been incorporated into the Windows SDK.  I
found header files like dshow.h in my hard drvie, but I don't have a
BaseClasses folder.



Has anyone compiled media with a recent VSS or are most people compiling
against residual artifacts from a while ago?



Thanks,

Carl

Re: COMPILE_MEDIA Error on 8udev - DirectShow Question

[Kevin Rushforth]

Sorry, that should be 'v7.1' (not 7.1a).

-- Kevin


On 11/8/2018 10:23 AM, Kevin Rushforth wrote:

You need the Windows SDK v7.1a, which has the DirectShow Base Classes.

-- Kevin


On 11/8/2018 9:53 AM, c...@bekwam.com wrote:

Hi,


I'm able to build a non-media version of 8udev successfully. However, 
when

I try the -PCOMPILE_MEDIA option, I'm getting an error



Task :media:buildWinPlugins

make: Entering directory
'/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl 


ugins'

make
TARGET=/cygdrive/d/hg/rt/modules/media/build/native/win/Release/baseclasses. 


lib -f Makefile.BaseClasses

cygpath: cannot create short name of C:\Program Files\Microsoft
SDKs\Windows\v7.1\Samples\multimedia\directshow\baseclasses

make[1]: Entering directory
'/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl 


ugins'

Usage: cygpath (-d|-m|-u|-w|-t TYPE) [-f FILE] [OPTION]... NAME...


I have a new computer with Visual Studio 2017.   I understand that the
DirectShow libraries have now been incorporated into the Windows SDK.  I
found header files like dshow.h in my hard drvie, but I don't have a
BaseClasses folder.


Has anyone compiled media with a recent VSS or are most people compiling
against residual artifacts from a while ago?


Thanks,

Carl

Re: COMPILE_MEDIA Error on 8udev - DirectShow Question

[Kevin Rushforth]

You need the Windows SDK v7.1a, which has the DirectShow Base Classes.

-- Kevin


On 11/8/2018 9:53 AM, c...@bekwam.com wrote:

Hi,

  


I'm able to build a non-media version of 8udev successfully.  However, when
I try the -PCOMPILE_MEDIA option, I'm getting an error

  


Task :media:buildWinPlugins

make: Entering directory
'/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
ugins'

make
TARGET=/cygdrive/d/hg/rt/modules/media/build/native/win/Release/baseclasses.
lib -f Makefile.BaseClasses

cygpath: cannot create short name of C:\Program Files\Microsoft
SDKs\Windows\v7.1\Samples\multimedia\directshow\baseclasses

make[1]: Entering directory
'/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
ugins'

Usage: cygpath (-d|-m|-u|-w|-t TYPE) [-f FILE] [OPTION]... NAME...

  


I have a new computer with Visual Studio 2017.   I understand that the
DirectShow libraries have now been incorporated into the Windows SDK.  I
found header files like dshow.h in my hard drvie, but I don't have a
BaseClasses folder.

  


Has anyone compiled media with a recent VSS or are most people compiling
against residual artifacts from a while ago?

  


Thanks,

Carl

  

COMPILE_MEDIA Error on 8udev - DirectShow Question

[carl]

Hi,

 

I'm able to build a non-media version of 8udev successfully.  However, when
I try the -PCOMPILE_MEDIA option, I'm getting an error 

 

> Task :media:buildWinPlugins

make: Entering directory
'/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
ugins'

make
TARGET=/cygdrive/d/hg/rt/modules/media/build/native/win/Release/baseclasses.
lib -f Makefile.BaseClasses

cygpath: cannot create short name of C:\Program Files\Microsoft
SDKs\Windows\v7.1\Samples\multimedia\directshow\baseclasses

make[1]: Entering directory
'/cygdrive/d/hg/rt/modules/media/src/main/native/gstreamer/projects/win/fxpl
ugins'

Usage: cygpath (-d|-m|-u|-w|-t TYPE) [-f FILE] [OPTION]... NAME...

 

I have a new computer with Visual Studio 2017.   I understand that the
DirectShow libraries have now been incorporated into the Windows SDK.  I
found header files like dshow.h in my hard drvie, but I don't have a
BaseClasses folder.

 

Has anyone compiled media with a recent VSS or are most people compiling
against residual artifacts from a while ago?

 

Thanks,

Carl

 

RE: Gradle File Rename Error in 8u Dev Build

[carl]

Hi,

No open files and I've tried a few variations of gradle with and without the 
daemon.  I can issue a quick rm following the failed gradle so I don't think 
there's contention.

-Carl

-Original Message-
From: Kevin Rushforth  
Sent: Thursday, November 8, 2018 11:53 AM
To: c...@bekwam.com; openjfx-dev@openjdk.java.net
Subject: Re: Gradle File Rename Error in 8u Dev Build

Two questions:

1) Are you using the gradle daemon?
If so, you might try disabling it.

2) Are you running any applications that might still have jfxrt.jar open?
If so, you should stop them before rebuilding.

-- Kevin





On 11/8/2018 6:57 AM, c...@bekwam.com wrote:
> Hi,
>
>   
>
> I was wondering if anyone's solved a renaming error I get when I run gradle.
> I have a reliable workaround which is to delete the file prior to 
> running gradle.
>
>   
>
>> Unable to rename old file (D:\hg\rt\build\sdk\rt\lib\ext\jfxrt.jar) 
>> to
> temporary file
>
>   
>
> Thanks in advance,
>
> Carl
>
>   
>
>   
>
>   
>

Re: Gradle File Rename Error in 8u Dev Build

[Kevin Rushforth]

Two questions:

1) Are you using the gradle daemon?
If so, you might try disabling it.

2) Are you running any applications that might still have jfxrt.jar open?
If so, you should stop them before rebuilding.

-- Kevin





On 11/8/2018 6:57 AM, c...@bekwam.com wrote:

Hi,

  


I was wondering if anyone's solved a renaming error I get when I run gradle.
I have a reliable workaround which is to delete the file prior to running
gradle.

  


Unable to rename old file (D:\hg\rt\build\sdk\rt\lib\ext\jfxrt.jar) to

temporary file

  


Thanks in advance,

Carl

  

  

  

Re: Problems building openjfx

[Dean Wookey]

Hi Johan,

Michael's build script helped me a lot. I'm on windows 10. It just runs in
powershell after installing chocolatey, (.\tools\scripts\build1.ps from the
openjdk root dir). The only environment variables I've got set are
JAVA_HOME/JDK_HOME. I did have to make some modifications however to
install the other dependencies and to handle the .dll's that weren't
packaged. Everything ran fine on my machine, but as soon as I tried using
the jars on another machine, I got linker errors. Below is the modified
version. It won't package the correct dlls if DebugNative is used though,
but as it is, it's working for me.

Dean

.\gradlew --stop
choco install ant
choco install vswhere
choco install zip
choco install visualstudio2017community
choco install visualstudio2017-workload-nativedesktop
choco install windows-sdk-7.1
choco install cygwin

$cygwinPath = (Get-ItemProperty -Path "HKLM:\SOFTWARE\Cygwin\setup").rootdir
$env:Path += ";$($cygwinPath)\bin"

$env:WINSDK_DIR = (Get-ItemProperty -Path
"HKLM:\SOFTWARE\Wow6432Node\Microsoft\Windows Kits\Installed
Roots").KitsRoot10
$env:VCINSTALLDIR = "$(vswhere -legacy -latest -property
installationPath)\VC\Auxiliary\Build"
$vcRoot = "$(vswhere -legacy -latest -property installationPath)"
$msvcToolsVer = Get-Content
"$env:VCINSTALLDIR\Microsoft.VCToolsVersion.default.txt"
$msvcRedistVer = Get-Content
"$env:VCINSTALLDIR\Microsoft.VCRedistVersion.default.txt"

if ([string]::IsNullOrWhitespace($msvcToolsVer)) {
  # The MSVC tools version file can have txt *or* props extension.
  $msvcToolsVer = Get-Content
"$env:VCINSTALLDIR\Microsoft.VCToolsVersion.default.props"
}
$env:MSVC_VER = $msvcToolsVer
$env:MSVC_REDIST_VER = $msvcRedistVer

$files = Get-ChildItem
"$($vcRoot)/VC/Redist/MSVC/$($msvcRedistVer)/x86/*.CRT/"
$crtVer = $files[0].Name.replace("Microsoft.VC","").replace(".CRT","")
$env:WINDOWS_CRT_VER = $crtVer


$env:VS150COMNTOOLS = $env:VCINSTALLDIR
$env:VSVARS32FILE = "$env:VCINSTALLDIR\vcvars32.bat"
refreshenv
if ($env:APPVEYOR -eq "true") {
  .\gradlew all test -PCOMPILE_WEBKIT=false -PCONF=Debug --stacktrace -x
:web:test --info --no-daemon
  if ($lastexitcode -ne 0) {
exit $lastexitcode
  }
} else {
  .\gradlew all test -PCOMPILE_WEBKIT=false -PCONF=Debug --stacktrace -x
:web:test --info
}

On Fri, Nov 2, 2018 at 8:57 PM Johan Vos  wrote:

> Hi Michael,
>
> What environment do you use to run that Windows build script?
> The windows builds are the ones I still feel least comfortable about. We
> tried to automate those on AdoptOpenJDK infrastructure, but they are using
> Ansible for provisioning machines (for very good reasons), and we spent
> days trying to come up with an Ansible script that allowed to build on
> Windows, without 100% success.
> Hence, we currently create the windows build on a Windows machine with a
> fixed setup. It would be better of course to move more of the environment
> and context parameters to the build procedure itself, and your script seems
> a step in that direction. But what infrastructure do you use to run this?
>
> - Johan
>
> On Thu, Nov 1, 2018 at 11:17 PM Michael Ennen 
> wrote:
>
> > Also don't forget about the Windows build script:
> >
> >
> >
> https://github.com/javafxports/openjdk-jfx/blob/develop/tools/scripts/build.ps1
> >
> > It is what I use to automate the process of building OpenJFX on Windows
> as
> > much as
> > possible. Any improvements to the script would be appreciated.
> >
> > On Wed, Oct 31, 2018 at 7:03 AM  wrote:
> >
> > > forgot the link to the instruction page, just in case there's another:
> > >
> > >
> > >
> >
> https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-EnvironmentVariables
> > >
> > > Zitat von faste...@swingempire.de:
> > >
> > > > first try, following the instructions (for win10) at:
> > > >
> > > > that is having downloaded, installed the required tools, added env
> > > > vars as desribed.
> > > >
> > > > Then in cygwin, navigate to the git working dir, typing
> > > >
> > > > gradle tasks
> > > >
> > > > fails with:
> > > >
> > > > FAILURE: Build failed with an exception.
> > > >
> > > > * Where:
> > > > Script
> > > >
> > >
> >
> 'C:\Daten\data-for-work\eclipse\gitrep-openjdk\openjdk-jfx\buildSrc\win.gradle'
> > > line:
> > > > 92
> > > >
> > > > * What went wrong:
> > > > A problem occurred evaluating script.
> > > >> FAIL: WINSDK_DIR not defined
> > > >
> > > > to me, it looks the env var WINSDK_DIR is not set - what should go in
> > > there?
> > > >
> > > > Thanks, Jeanette
> > > >
> > > > BTW: did I ever mention that I hate command line tools - and they
> > > > feel it, fighting back with all they got ;)
> > >
> > >
> > >
> > >
> >
> > --
> > Michael Ennen
> >
>

Gradle File Rename Error in 8u Dev Build

[carl]

Hi,

 

I was wondering if anyone's solved a renaming error I get when I run gradle.
I have a reliable workaround which is to delete the file prior to running
gradle. 

 

> Unable to rename old file (D:\hg\rt\build\sdk\rt\lib\ext\jfxrt.jar) to
temporary file

 

Thanks in advance,

Carl

 

 

 

Re: [11] Request approval to backport 8211304: [macOS] Crash on focus loss from dialog on macOS 10.14 Mojave

[Johan Vos]

+1 for this backport.

On Thu, Nov 8, 2018 at 2:15 PM Kevin Rushforth 
wrote:

> Hi Johan,
>
> I request approval to backport the following critical bug to 11-dev (for
> 11.0.2).
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8211304
> Changeset: http://hg.openjdk.java.net/openjfx/jfx-dev/rt/rev/e864311d97e6
>
> The changeset patch applies cleanly to 11-dev.
>
> -- Kevin
>
>

[11] Request approval to backport 8211304: [macOS] Crash on focus loss from dialog on macOS 10.14 Mojave

[Kevin Rushforth]

Hi Johan,

I request approval to backport the following critical bug to 11-dev (for 
11.0.2).


JBS: https://bugs.openjdk.java.net/browse/JDK-8211304
Changeset: http://hg.openjdk.java.net/openjfx/jfx-dev/rt/rev/e864311d97e6

The changeset patch applies cleanly to 11-dev.

-- Kevin