Re: [Rev 03] RFR: 8218973: SVG with masking is not rendering image with mask effect
On Mon, 18 May 2020 08:00:38 GMT, Bhawesh Choudhary wrote: >> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp >> in WebKit was not implemented, so masking >> doesn't take place at all while rendering SVGRect. to fix this issue add >> implementation of function clipToImageBuffer() >> in GraphicsContextJava.cpp and send clip image to >> WCGraphicsPrismContext.java While rendering in >> WCGraphicsPrismContext.java if image clip mask is available, use it for >> rendering using MaskTextureGraphics interface >> otherwise use usual way of rendering. > > Bhawesh Choudhary has updated the pull request incrementally with one > additional commit since the last revision: > > Refactoring, Utilize getFilterContext() function modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java line 536: > 535: RTTexture paintRtTexture = > g.getResourceFactory().createRTTexture( > 536: (int) Math.ceil(transformedRect.width), > 537: (int) Math.ceil(transformedRect.height), transformedRect's height and width are already of type int - PR: https://git.openjdk.java.net/jfx/pull/213
Re: RFR: 8244531: Tests: add support to identify recurring issues with controls et al
On Mon, 18 May 2020 13:27:52 GMT, Jeanette Winzenburg wrote: >> I have not reviewed this PR yet, but a quick comment - Can we enable and >> fix currently Ignored ControlSkinTest with >> this? > >> Can we enable and fix currently Ignored ControlSkinTest with this? > > will check, always ignored that test :) direct re-enable probably is not possible, but I think we can re-write most of it (not sure about the css stuff) - that would be a follow-up issue. - PR: https://git.openjdk.java.net/jfx/pull/223
Re: RFR: 8244531: Tests: add support to identify recurring issues with controls et al
On Mon, 18 May 2020 12:29:05 GMT, Ajit Ghaisas wrote: > Can we enable and fix currently Ignored ControlSkinTest with this? will check, always ignored that test :) - PR: https://git.openjdk.java.net/jfx/pull/223
Re: RFR: 8244531: Tests: add support to identify recurring issues with controls et al
On Mon, 18 May 2020 12:07:30 GMT, Jeanette Winzenburg wrote: > It's a task to support cross-control/skin testing for recurring issues (like > memory leaks on switching skins) > > Basically, there's a utility class > - to access lists of all control/classes, > - to access/create all behaviors > - has alternative skins classes for all controls and utility to > install/replace skins > > POC: > - has test examples (not run in normal testing due to not following naming > conventions) for using > - changed SkinDisposeContractTest to use I have not reviewed this PR yet, but a quick comment - Can we enable and fix currently Ignored ControlSkinTest with this? - PR: https://git.openjdk.java.net/jfx/pull/223
RFR: 8244531: Tests: add support to identify recurring issues with controls et al
It's a task to support cross-control/skin testing for recurring issues (like memory leaks on switching skins) Basically, there's a utility class - to access lists of all control/classes, - to access/create all behaviors - has alternative skins classes for all controls and utility to install/replace skins POC: - has test examples (not run in normal testing due to not following naming conventions) for using - changed SkinDisposeContractTest to use - Commit messages: - 8244531: Tests: add support to identify recurring issues with controls Changes: https://git.openjdk.java.net/jfx/pull/223/files Webrev: https://webrevs.openjdk.java.net/jfx/223/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8244531 Stats: 1243 lines in 6 files changed: 1141 ins; 97 del; 5 mod Patch: https://git.openjdk.java.net/jfx/pull/223.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/223/head:pull/223 PR: https://git.openjdk.java.net/jfx/pull/223
Re: [Integrated] RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list
On Wed, 29 Apr 2020 04:40:59 GMT, Ambarish Rapte wrote: > Issue: > When tabs are permuted as mentioned in the issue description as, > 1. TabPane.getTabs().setAll(tab0, tab1) > 2. TabPane.getTabs().setAll(tab0, tab1, tab2, tab3); > the tab headers do not get permuted in same order as `TabPane.getTabs()`. > > => tab headers should be shown in order as tab0, tab1, tab2, tab3. > => but are show in order as tab2, tab3, tab0, tab1 > > Cause: > Newly added tabs(tab2, tab3) are not inserted at correct index. The index > `Change.getFrom()` (0) used from Change does > not remain valid after the tabs to be moved(tab0, tab1) are removed from > `tabsToAdd` list. > Fix: > Use the index of first newly added tab, from `TabPane.getTabs()`, which would > be always reliable. > > Verification: > No existing tests fail due to this change. > Added a system test which fails without and pass with fix. This pull request has now been integrated. Changeset: 6e039302 Author:Ambarish Rapte URL: https://git.openjdk.java.net/jfx/commit/6e039302 Stats: 71 lines in 2 files changed: 2 ins; 65 del; 4 mod 8237602: TabPane doesn't respect order of TabPane.getTabs() list Reviewed-by: kcr, fastegal - PR: https://git.openjdk.java.net/jfx/pull/201
Re: [Rev 01] RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list
On Mon, 11 May 2020 04:12:22 GMT, Ambarish Rapte wrote: >> Issue: >> When tabs are permuted as mentioned in the issue description as, >> 1. TabPane.getTabs().setAll(tab0, tab1) >> 2. TabPane.getTabs().setAll(tab0, tab1, tab2, tab3); >> the tab headers do not get permuted in same order as `TabPane.getTabs()`. >> >> => tab headers should be shown in order as tab0, tab1, tab2, tab3. >> => but are show in order as tab2, tab3, tab0, tab1 >> >> Cause: >> Newly added tabs(tab2, tab3) are not inserted at correct index. The index >> `Change.getFrom()` (0) used from Change does >> not remain valid after the tabs to be moved(tab0, tab1) are removed from >> `tabsToAdd` list. >> Fix: >> Use the index of first newly added tab, from `TabPane.getTabs()`, which >> would be always reliable. >> >> Verification: >> No existing tests fail due to this change. >> Added a system test which fails without and pass with fix. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > review-update: change test name tests are passing, what else can we achieve with a fix :) Looks good! - Marked as reviewed by fastegal (Author). PR: https://git.openjdk.java.net/jfx/pull/201
Re: [Rev 02] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar
On Mon, 18 May 2020 05:52:21 GMT, Ajit Ghaisas wrote: >> Issue : >> https://bugs.openjdk.java.net/browse/JDK-8244418 >> >> Root Cause : >> Incorrect assumption about menu list size. >> >> Fix : >> Added check for empty menu list before trying to access it. >> >> Test : >> Added a unit test that fails before fix and passes after it. > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > review fixes and test addition looks fine :) - Marked as reviewed by fastegal (Author). PR: https://git.openjdk.java.net/jfx/pull/216
Re: [Rev 02] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar
On Mon, 18 May 2020 05:42:17 GMT, Ajit Ghaisas wrote: >> hmm .. yeah I'm aware of getContainer vs. getMenus - but they should be the >> same size, shouldn't they? >> >> Anyway, if focusedIndex != getMenus().indexOf all users of focusedIndex have >> to include a check for validity. That >> might be prevented by not allowing it here in the method, in setting its >> value not unconditionally to the given index >> but guard it against being valid: >> focusedMenuIndex = index >= getMenus().size() ? -1 : index >> >> Then focused is either valid or -1. > > Good suggestion on not setting the foucusedMenuIndex unconditionally. > Also, we need to check for index < -1 : just to tighten up this method. > I have added this check. glad we came to an agreement at last :) - PR: https://git.openjdk.java.net/jfx/pull/216
Re: [Rev 03] RFR: 8218973: SVG with masking is not rendering image with mask effect
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp > in WebKit was not implemented, so masking > doesn't take place at all while rendering SVGRect. to fix this issue add > implementation of function clipToImageBuffer() > in GraphicsContextJava.cpp and send clip image to WCGraphicsPrismContext.java > While rendering in > WCGraphicsPrismContext.java if image clip mask is available, use it for > rendering using MaskTextureGraphics interface > otherwise use usual way of rendering. Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision: Refactoring, Utilize getFilterContext() function - Changes: - all: https://git.openjdk.java.net/jfx/pull/213/files - new: https://git.openjdk.java.net/jfx/pull/213/files/5b85b47d..a55f9f23 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/213/webrev.03 - incr: https://webrevs.openjdk.java.net/jfx/213/webrev.02-03 Stats: 8 lines in 1 file changed: 0 ins; 7 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/213.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/213/head:pull/213 PR: https://git.openjdk.java.net/jfx/pull/213
Re: [Rev 01] RFR: 8181775: JavaFX WebView does not calculate border-radius properly
> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering > of rounded corner rectangle if four > corners have different radii. but same can be achieved via Path. to fix the > issue, in GraphicsContextJava.cpp while > rendering fillRoundedRect, check if all four corners have same radii. if yes, > use FILL_ROUNDED_RECT to draw it > otherwise construct a path from given rounded rect and draw it. Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision: Removed wildcard import statement - Changes: - all: https://git.openjdk.java.net/jfx/pull/218/files - new: https://git.openjdk.java.net/jfx/pull/218/files/a742ba43..e7cb98fe Webrevs: - full: https://webrevs.openjdk.java.net/jfx/218/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/218/webrev.00-01 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/218.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/218/head:pull/218 PR: https://git.openjdk.java.net/jfx/pull/218
