Re: RFR: 8262276: Debug build of WebKit fails [v3]
On Tue, 20 Apr 2021 20:03:28 GMT, Arun Joseph wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Arun Joseph has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > > - Merge > - Fix InternalFunction crash > - 8262276: Debug build of WebKit fails I can't reproduce my previous issues, so I assume there was something wrong with my local environment (which is likely). Looks good now. - Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails [v3]
On Tue, 20 Apr 2021 20:03:28 GMT, Arun Joseph wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Arun Joseph has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > > - Merge > - Fix InternalFunction crash > - 8262276: Debug build of WebKit fails I'll re-run my tests - PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails [v3]
On Tue, 20 Apr 2021 20:03:28 GMT, Arun Joseph wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Arun Joseph has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > > - Merge > - Fix InternalFunction crash > - 8262276: Debug build of WebKit fails Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails [v3]
> Fixing the Debug build of WebKit. > > Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test > using a simple HelloWebView app. Arun Joseph has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge - Fix InternalFunction crash - 8262276: Debug build of WebKit fails - Changes: https://git.openjdk.java.net/jfx/pull/417/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=417=02 Stats: 34 lines in 6 files changed: 21 ins; 0 del; 13 mod Patch: https://git.openjdk.java.net/jfx/pull/417.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/417/head:pull/417 PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails [v2]
> Fixing the Debug build of WebKit. > > Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test > using a simple HelloWebView app. Arun Joseph has updated the pull request incrementally with one additional commit since the last revision: Fix InternalFunction crash - Changes: - all: https://git.openjdk.java.net/jfx/pull/417/files - new: https://git.openjdk.java.net/jfx/pull/417/files/6cab829e..31ea28c0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=417=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=417=00-01 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/jfx/pull/417.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/417/head:pull/417 PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails
On Tue, 9 Mar 2021 15:46:06 GMT, Arun Joseph wrote: >> I think this is actually a lack of physical memory. I was doing tests inside >> Windows Sandbox which has 4GB of memory by default. >> >> After repeating the build procedure inside VM with 16GB of memory the build >> succeeded. >> >> Side question - I see there was: >> `C:\jfx\build\modular-sdk\modules_libs\javafx.web\jfxwebkit.dll` >> produced but I don't see any PDB files (debugging and project state >> information) despite `CONF = DebugNative` is present. Am I missing something? > > The PDB files are located in > `modules\javafx.web\build\win\Debug\bin\jfxwebkit.pdb`. At present, they are > not copied to sdk. This bug > (https://bugs.openjdk.java.net/browse/JDK-8263259) is created to fix the same. @arun-Joseph , thanks. This is exactly where PDB files were located. To give something back to the community I've prepared a script ([openjfx-build-env.zip](https://github.com/openjdk/jfx/files/6114811/openjfx-build-env.zip)) which installs [Chocolatey ](https://chocolatey.org/) and all required dependencies needed to came up with `JavaFX` & `WebKit` Windows build environment quickly - _please use at your own risk_). I suggest using dedicated/clean Windows 10 Virtual machine or Windows Sandbox ([with 8GB memory](https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-sandbox/windows-sandbox-configure-using-wsb-file#memory-in-mb)). Steps needed to create JavaFX build from JFX Github repository (with included pull/417): 1. Run `PowerShell` as `Administrator` 2. Run `openjfx-build-env.bat` (extracted from [openjfx-build-env.zip](https://github.com/openjdk/jfx/files/6114811/openjfx-build-env.zip)) 3. Run `Cygwin` 4. Run (last two commands won't be needed anymore after this pull request will be merged to the master): `git clone https://github.com/openjdk/jfx.git` (from `C:`) `git fetch https://git.openjdk.java.net/jfx pull/417/head:pull/417`(from `C:/jfx`) `git checkout pull/417` (from `C:/jfx`) 5. OPTIONAL: Only if `WebKit` and native debug is needed: Edit `gradle.properties` (renamed from `gradle.properties.template`) inside `C:/jfx` and set: `COMPILE_WEBKIT = true` `CONF = DebugNative` 6. Run `chmod +x gradlew` (from `C:/jfx`) 7. Run `./gradlew --console=plain` (from `C:/jfx`) Side notes: - Due to [JDK-8263259](https://bugs.openjdk.java.net/browse/JDK-8263259), the PDB files will be placed inside `c:/jfx/modules/javafx.web/build/win/Debug/bin/jfxwebkit.pdb`. - PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails
On Tue, 9 Mar 2021 14:55:59 GMT, PrimosK wrote: >>> when passing `--info` to gradle, the build succeeds. Without passing >>> `--info` it fails. I'll do more testing later. >> >> Interesting. I don't see this problem. I am able to build with or without >> `--info`. I am also now (with this patch) able to build with or without >> `-PCONF=DebugNative`. >> >> As mentioned earlier, some of the unit tests fail to run in debug mode. Arun >> will look into these failures. > > I think this is actually a lack of physical memory. I was doing tests inside > Windows Sandbox which has 4GB of memory by default. > > After repeating the build procedure inside VM with 16GB of memory the build > succeeded. > > Side question - I see there was: > `C:\jfx\build\modular-sdk\modules_libs\javafx.web\jfxwebkit.dll` > produced but I don't see any PDB files (debugging and project state > information) despite `CONF = DebugNative` is present. Am I missing something? The PDB files are located in `modules\javafx.web\build\win\Debug\bin\jfxwebkit.pdb`. At present, they are not copied to sdk. This bug (https://bugs.openjdk.java.net/browse/JDK-8263259) is created to fix the same. - PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails
On Tue, 9 Mar 2021 12:41:41 GMT, Kevin Rushforth wrote: >> when passing `--info` to gradle, the build succeeds. Without passing >> `--info` it fails. I'll do more testing later. > >> when passing `--info` to gradle, the build succeeds. Without passing >> `--info` it fails. I'll do more testing later. > > Interesting. I don't see this problem. I am able to build with or without > `--info`. I am also now (with this patch) able to build with or without > `-PCONF=DebugNative`. > > As mentioned earlier, some of the unit tests fail to run in debug mode. Arun > will look into these failures. I think this is actually a lack of physical memory. I was doing tests inside Windows Sandbox which has 4GB of memory by default. After repeating the build procedure inside VM with 16GB of memory the build succeeded. Side question - I see there was: `C:\jfx\build\modular-sdk\modules_libs\javafx.web\jfxwebkit.dll` produced but I don't see any PDB files (debugging and project state information) despite `CONF = DebugNative` is present. Am I missing something? - PR: https://git.openjdk.java.net/jfx/pull/417
Re: Re: RFR: 8262276: Debug build of WebKit fails
Silly question, when building, at what point would any sort of memory setting be provided? Is that a lack of enough physical memory, not enough memory based on an environment variable or config file? Eric Bresie ebre...@gmail.com (mailto:ebre...@gmail.com) > On March 9, 2021 at 12:42:05 AM CST, PrimosK > (mailto:github.com+1519324+prim...@openjdk.java.net)> wrote: > On Tue, 9 Mar 2021 06:30:46 GMT, PrimosK > (mailto:github.com+1519324+prim...@openjdk.org)> wrote: > > > > > > The build failed again. The only difference I can spot at this time > > > > > is the line at which the build failed (it changed from 3445 to 3453): > > > > > ... > > > > > Please let me know if you need any further information. > > > > > > > > You might be running into a different problem then, since this patch > > > > solve the compilation problem for Arun, for me, and for our CI build > > > > systems, when building with `-PCONF=DebugNative` (as a side note, we > > > > have some problems running the unit tests, but that's a separate > > > > issue). I have a couple questions for you: > > > > > > > > 1. Does the build work if you build without `-PCONF=DebugNative`? If it > > > > still fails, then you are definitely running into a different problem, > > > > likely something in your environment. > > > > 2. Can you double-check the versions of the build tools that you are > > > > using? We build using Visual Studio 2019 rather than the 2017 that you > > > > are using, although it will build with the latest VS2017 update. The > > > > versions of the other tools should be: > > > > > > > > * gradle 6.3 > > > > * cmake 3.13.3 > > > > * ninja 1.8.2 > > > > > > > > 1. Have you tried building on a platform other than Windows? > > > > > > **1.** > > > No, it doesn't work. As already stated in the > > > [JDK-8262276](https://bugs.openjdk.java.net/browse/JDK-8262276), the > > > build fails for me with the exactly same error also when I set: > > > COMPILE_WEBKIT = true > > > CONF = Release > > > > > > in `gradle.properties`. > > > > > > **2.** > > > ATM I am using these libraries: > > > > > > - Javafx (`pull/417`) > > > - Java 15 (installed on Windows) > > > - Ant 1.10.5 (installed on Windows) > > > - **CMake 3.13.3** (installed on Windows) > > > - Visual Studio 2017 community edition (**Ninja 1.8.2**) > > > - **Gradlew 6.3** > > > - CygWin (installed on Windows) with the following packages: > > > - bison 3.0.4-1 > > > - flex 2.6.4-2 > > > - gcc-g++ 10.2.0-1 > > > - git 2.30.0-1 > > > - gperf 3.1-1 > > > - make 4.3-1 > > > - makedepend 1.0.6-1 > > > - openssh 8.4p1-2 > > > - perl 5.32.1-1 > > > - python27 2.7.18-4 > > > - ruby 2.6.4-1 > > > - unzip 6.0-17 > > > - zip 3.0-12 > > > > > > But I am seeing exactly the same error. > > > > > > **3.** > > > No - I've tried it only with Windows as we need debug symbols there... > > > > > > Side note: > > > > > > Could you guys please provide me with the versions of the above libraries > > > that are used in the case of your CI build system? Is now Visual Studio > > > the only difference? I tried to check it by myself by going through the > > > log files at https://github.com/arun-Joseph/jfx/runs/2028653928 but I > > > couldn't found CygWin plugin versions (bison, flex...). > > > > > > Tomorrow I will try building it using Visual Studio 2019. > > > > Hi everyone, > > > > Today I've tried to create a build using **Visual Studio 2019** but with no > > success. I am seeing the same error. > > > > There is a complete output of `./gradlew --scan`: > > [build-output.txt](https://github.com/openjdk/jfx/files/6106294/build-output.txt) > > > > The build scan is available there: > > https://scans.gradle.com/s/dimrfirscg7hm > > > > OS: > > - Windows 10 > > > > Repository: > > - JavaFx (pull/417) > > > > Installed libraries: > > - Java 15 (15+36-1562) > > - Ant 1.10.5 > > - Gradlew 6.3 > > - CMake 3.13.3 > > - Visual Studio 2019 community edition (VS2019-16.7.2+1.0) > > - Ninja 1.8.2 > > > > CygWin (installed on Windows) with the following packages: > > - bison 3.0.4-1 > > - flex 2.6.4-2 > > - gcc-g++ 10.2.0-1 > > - git 2.30.0-1 > > - gperf 3.1-1 > > - make 4.3-1 > > - makedepend 1.0.6-1 > > - openssh 8.4p1-2 > > - perl 5.32.1-1 > > - python27 2.7.18-4 > > - ruby 2.6.4-1 > > - unzip 6.0-17 > > - zip 3.0-12 > > > > `gradle.properties`: > > COMPILE_WEBKIT = true > > CONF = DebugNative > > > > Content of `windows.tools`: > > WINDOWS_VS_DEVENVDIR=C:/Program Files (x86)/Microsoft Visual > > Studio/2019/Community/Common7/IDE > > WINDOWS_VS_DEVENVCMD=C:/Program Files (x86)/Microsoft Visual > > Studio/2019/Community/Common7/IDE/devenv.com (http://devenv.com) > > WINDOWS_VS_VCINSTALLDIR=C:/Program Files (x86)/Microsoft Visual > > Studio/2019/Community/VC > > WINDOWS_VS_VSINSTALLDIR=C:/Program Files (x86)/Microsoft Visual > > Studio/2019/Community > > WINDOWS_VS_MSVCDIR=C:/Program Files (x86)/Microsoft Visual > > Studio/2019/Community/VC > > WINDOWS_VS_INCLUDE=C:/Program Files (x86)/Microsoft Visual
Re: RFR: 8262276: Debug build of WebKit fails
On Mon, 8 Mar 2021 15:07:30 GMT, Johan Vos wrote: > when passing `--info` to gradle, the build succeeds. Without passing `--info` > it fails. I'll do more testing later. Interesting. I don't see this problem. I am able to build with or without `--info`. I am also now (with this patch) able to build with or without `-PCONF=DebugNative`. As mentioned earlier, some of the unit tests fail to run in debug mode. Arun will look into these failures. - PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails
On Tue, 9 Mar 2021 06:30:46 GMT, PrimosK wrote: > Please let me know if I should rather discuss this through another channel > (maybe mailing list?). If you still have problems after resolving your "out of heap space" issue, then asking on the [openjfx-dev](https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev) mailing list is probably best, given that you are unable to compile WebKit even without `-PCONF=DebugNative`. - PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails
On Tue, 9 Mar 2021 06:30:46 GMT, PrimosK wrote: >>> > The build failed again. The only difference I can spot at this time is >>> > the line at which the build failed (it changed from 3445 to 3453): >>> > ... >>> > Please let me know if you need any further information. >>> >>> You might be running into a different problem then, since this patch solve >>> the compilation problem for Arun, for me, and for our CI build systems, >>> when building with `-PCONF=DebugNative` (as a side note, we have some >>> problems running the unit tests, but that's a separate issue). I have a >>> couple questions for you: >>> >>> 1. Does the build work if you build without `-PCONF=DebugNative`? If it >>> still fails, then you are definitely running into a different problem, >>> likely something in your environment. >>> 2. Can you double-check the versions of the build tools that you are using? >>> We build using Visual Studio 2019 rather than the 2017 that you are using, >>> although it will build with the latest VS2017 update. The versions of the >>> other tools should be: >>> >>> * gradle 6.3 >>> * cmake 3.13.3 >>> * ninja 1.8.2 >>> >>> 1. Have you tried building on a platform other than Windows? >> >> **1.** >> No, it doesn't work. As already stated in the >> [JDK-8262276](https://bugs.openjdk.java.net/browse/JDK-8262276), the build >> fails for me with the exactly same error also when I set: >> COMPILE_WEBKIT = true >> CONF = Release >> >> in `gradle.properties`. >> >> **2.** >> ATM I am using these libraries: >> >> - Javafx (`pull/417`) >> - Java 15 (installed on Windows) >> - Ant 1.10.5 (installed on Windows) >> - **CMake 3.13.3** (installed on Windows) >> - Visual Studio 2017 community edition (**Ninja 1.8.2**) >> - **Gradlew 6.3** >> - CygWin (installed on Windows) with the following packages: >> - bison 3.0.4-1 >> - flex 2.6.4-2 >> - gcc-g++ 10.2.0-1 >> - git 2.30.0-1 >> - gperf 3.1-1 >> - make 4.3-1 >> - makedepend 1.0.6-1 >> - openssh 8.4p1-2 >> - perl 5.32.1-1 >> - python27 2.7.18-4 >> - ruby 2.6.4-1 >> - unzip 6.0-17 >> - zip 3.0-12 >> >> But I am seeing exactly the same error. >> >> **3.** >> No - I've tried it only with Windows as we need debug symbols there... >> >> Side note: >> >> Could you guys please provide me with the versions of the above libraries >> that are used in the case of your CI build system? Is now Visual Studio the >> only difference? I tried to check it by myself by going through the log >> files at https://github.com/arun-Joseph/jfx/runs/2028653928 but I couldn't >> found CygWin plugin versions (bison, flex...). >> >> Tomorrow I will try building it using Visual Studio 2019. > > Hi everyone, > > Today I've tried to create a build using **Visual Studio 2019** but with no > success. I am seeing the same error. > > There is a complete output of `./gradlew --scan`: > [build-output.txt](https://github.com/openjdk/jfx/files/6106294/build-output.txt) > > The build scan is available there: > https://scans.gradle.com/s/dimrfirscg7hm > > OS: > - Windows 10 > > Repository: > - JavaFx (pull/417) > > Installed libraries: > - Java 15 (15+36-1562) > - Ant 1.10.5 > - Gradlew 6.3 > - CMake 3.13.3 > - Visual Studio 2019 community edition (VS2019-16.7.2+1.0) > - Ninja 1.8.2 > > CygWin (installed on Windows) with the following packages: > - bison 3.0.4-1 > - flex 2.6.4-2 > - gcc-g++ 10.2.0-1 > - git 2.30.0-1 > - gperf 3.1-1 > - make 4.3-1 > - makedepend 1.0.6-1 > - openssh 8.4p1-2 > - perl 5.32.1-1 > - python27 2.7.18-4 > - ruby 2.6.4-1 > - unzip 6.0-17 > - zip 3.0-12 > > `gradle.properties`: > COMPILE_WEBKIT = true > CONF = DebugNative > > Content of `windows.tools`: > WINDOWS_VS_DEVENVDIR=C:/Program Files (x86)/Microsoft Visual > Studio/2019/Community/Common7/IDE > WINDOWS_VS_DEVENVCMD=C:/Program Files (x86)/Microsoft Visual > Studio/2019/Community/Common7/IDE/devenv.com > WINDOWS_VS_VCINSTALLDIR=C:/Program Files (x86)/Microsoft Visual > Studio/2019/Community/VC > WINDOWS_VS_VSINSTALLDIR=C:/Program Files (x86)/Microsoft Visual > Studio/2019/Community > WINDOWS_VS_MSVCDIR=C:/Program Files (x86)/Microsoft Visual > Studio/2019/Community/VC > WINDOWS_VS_INCLUDE=C:/Program Files (x86)/Microsoft Visual > Studio/2019/Community/VC/Tools/MSVC/14.28.29910/ATLMFC/include;C:/Program > Files (x86)/Microsoft Visual > Studio/2019/Community/VC/Tools/MSVC/14.28.29910/include;C:/Program Files > (x86)/Windows Kits/10/include/10.0.19041.0/ucrt;C:/Program Files > (x86)/Windows Kits/10/include/10.0.19041.0/shared;C:/Program Files > (x86)/Windows Kits/10/include/10.0.19041.0/um;C:/Program Files (x86)/Windows > Kits/10/include/10.0.19041.0/winrt;C:/Program Files (x86)/Windows > Kits/10/include/10.0.19041.0/cppwinrt;C:/Program Files (x86)/Microsoft Visual > Studio/2019/Community/VC/Tools/MSVC/14.28.29910/ATLMFC/include;C:/Program > Files (x86)/Microsoft Visual > Studio/2019/Community/VC/Tools/MSVC/14.28.29910/include;C:/Program
Re: RFR: 8262276: Debug build of WebKit fails
On Mon, 8 Mar 2021 16:20:21 GMT, PrimosK wrote: >> when passing `--info` to gradle, the build succeeds. Without passing >> `--info` it fails. I'll do more testing later. > >> > The build failed again. The only difference I can spot at this time is the >> > line at which the build failed (it changed from 3445 to 3453): >> > ... >> > Please let me know if you need any further information. >> >> You might be running into a different problem then, since this patch solve >> the compilation problem for Arun, for me, and for our CI build systems, when >> building with `-PCONF=DebugNative` (as a side note, we have some problems >> running the unit tests, but that's a separate issue). I have a couple >> questions for you: >> >> 1. Does the build work if you build without `-PCONF=DebugNative`? If it >> still fails, then you are definitely running into a different problem, >> likely something in your environment. >> 2. Can you double-check the versions of the build tools that you are using? >> We build using Visual Studio 2019 rather than the 2017 that you are using, >> although it will build with the latest VS2017 update. The versions of the >> other tools should be: >> >> * gradle 6.3 >> * cmake 3.13.3 >> * ninja 1.8.2 >> >> 1. Have you tried building on a platform other than Windows? > > **1.** > No, it doesn't work. As already stated in the > [JDK-8262276](https://bugs.openjdk.java.net/browse/JDK-8262276), the build > fails for me with the exactly same error also when I set: > COMPILE_WEBKIT = true > CONF = Release > > in `gradle.properties`. > > **2.** > ATM I am using these libraries: > > - Javafx (`pull/417`) > - Java 15 (installed on Windows) > - Ant 1.10.5 (installed on Windows) > - **CMake 3.13.3** (installed on Windows) > - Visual Studio 2017 community edition (**Ninja 1.8.2**) > - **Gradlew 6.3** > - CygWin (installed on Windows) with the following packages: > - bison 3.0.4-1 > - flex 2.6.4-2 > - gcc-g++ 10.2.0-1 > - git 2.30.0-1 > - gperf 3.1-1 > - make 4.3-1 > - makedepend 1.0.6-1 > - openssh 8.4p1-2 > - perl 5.32.1-1 > - python27 2.7.18-4 > - ruby 2.6.4-1 > - unzip 6.0-17 > - zip 3.0-12 > > But I am seeing exactly the same error. > > **3.** > No - I've tried it only with Windows as we need debug symbols there... > > Side note: > > Could you guys please provide me with the versions of the above libraries > that are used in the case of your CI build system? Is now Visual Studio the > only difference? I tried to check it by myself by going through the log files > at https://github.com/arun-Joseph/jfx/runs/2028653928 but I couldn't found > CygWin plugin versions (bison, flex...). > > Tomorrow I will try building it using Visual Studio 2019. Hi everyone, Today I've tried to create a build using **Visual Studio 2019** but with no success. I am seeing the same error. There is a complete output of `./gradlew --scan`: [build-output.txt](https://github.com/openjdk/jfx/files/6106294/build-output.txt) The build scan is available there: https://scans.gradle.com/s/dimrfirscg7hm OS: - Windows 10 Repository: - JavaFx (pull/417) Installed libraries: - Java 15 (15+36-1562) - Ant 1.10.5 - Gradlew 6.3 - CMake 3.13.3 - Visual Studio 2019 community edition (VS2019-16.7.2+1.0) - Ninja 1.8.2 CygWin (installed on Windows) with the following packages: - bison 3.0.4-1 - flex 2.6.4-2 - gcc-g++ 10.2.0-1 - git 2.30.0-1 - gperf 3.1-1 - make 4.3-1 - makedepend 1.0.6-1 - openssh 8.4p1-2 - perl 5.32.1-1 - python27 2.7.18-4 - ruby 2.6.4-1 - unzip 6.0-17 - zip 3.0-12 `gradle.properties`: COMPILE_WEBKIT = true CONF = DebugNative Content of `windows.tools`: WINDOWS_VS_DEVENVDIR=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/Common7/IDE WINDOWS_VS_DEVENVCMD=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/Common7/IDE/devenv.com WINDOWS_VS_VCINSTALLDIR=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC WINDOWS_VS_VSINSTALLDIR=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community WINDOWS_VS_MSVCDIR=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC WINDOWS_VS_INCLUDE=C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.28.29910/ATLMFC/include;C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.28.29910/include;C:/Program Files (x86)/Windows Kits/10/include/10.0.19041.0/ucrt;C:/Program Files (x86)/Windows Kits/10/include/10.0.19041.0/shared;C:/Program Files (x86)/Windows Kits/10/include/10.0.19041.0/um;C:/Program Files (x86)/Windows Kits/10/include/10.0.19041.0/winrt;C:/Program Files (x86)/Windows Kits/10/include/10.0.19041.0/cppwinrt;C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.28.29910/ATLMFC/include;C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.28.29910/include;C:/Program Files (x86)/Windows Kits/10/include/10.0.19041.0/ucrt;C:/Program Files
Re: RFR: 8262276: Debug build of WebKit fails
On Mon, 8 Mar 2021 15:07:30 GMT, Johan Vos wrote: >>> The build failed again. The only difference I can spot at this time is the >>> line at which the build failed (it changed from 3445 to 3453): >>> ... >>> >>> Please let me know if you need any further information. >> >> You might be running into a different problem then, since this patch solve >> the compilation problem for Arun, for me, and for our CI build systems, when >> building with `-PCONF=DebugNative` (as a side note, we have some problems >> running the unit tests, but that's a separate issue). I have a couple >> questions for you: >> >> 1. Does the build work if you build without `-PCONF=DebugNative`? If it >> still fails, then you are definitely running into a different problem, >> likely something in your environment. >> >> 2. Can you double-check the versions of the build tools that you are using? >> We build using Visual Studio 2019 rather than the 2017 that you are using, >> although it will build with the latest VS2017 update. The versions of the >> other tools should be: >> * gradle 6.3 >> * cmake 3.13.3 >> * ninja 1.8.2 >> >> 3. Have you tried building on a platform other than Windows? > > when passing `--info` to gradle, the build succeeds. Without passing `--info` > it fails. I'll do more testing later. > > The build failed again. The only difference I can spot at this time is the > > line at which the build failed (it changed from 3445 to 3453): > > ... > > Please let me know if you need any further information. > > You might be running into a different problem then, since this patch solve > the compilation problem for Arun, for me, and for our CI build systems, when > building with `-PCONF=DebugNative` (as a side note, we have some problems > running the unit tests, but that's a separate issue). I have a couple > questions for you: > > 1. Does the build work if you build without `-PCONF=DebugNative`? If it still > fails, then you are definitely running into a different problem, likely > something in your environment. > 2. Can you double-check the versions of the build tools that you are using? > We build using Visual Studio 2019 rather than the 2017 that you are using, > although it will build with the latest VS2017 update. The versions of the > other tools should be: > > * gradle 6.3 > * cmake 3.13.3 > * ninja 1.8.2 > > 1. Have you tried building on a platform other than Windows? **1.** No, it doesn't work. As already stated in the [JDK-8262276](https://bugs.openjdk.java.net/browse/JDK-8262276), the build fails for me with the exactly same error also when I set: COMPILE_WEBKIT = true CONF = Release in `gradle.properties`. **2.** ATM I am using these libraries: - Javafx (`pull/417`) - Java 15 (installed on Windows) - Ant 1.10.5 (installed on Windows) - **CMake 3.13.3** (installed on Windows) - Visual Studio 2017 community edition (**Ninja 1.8.2**) - **Gradlew 6.3** - CygWin (installed on Windows) with the following packages: - bison 3.0.4-1 - flex 2.6.4-2 - gcc-g++ 10.2.0-1 - git 2.30.0-1 - gperf 3.1-1 - make 4.3-1 - makedepend 1.0.6-1 - openssh 8.4p1-2 - perl 5.32.1-1 - python27 2.7.18-4 - ruby 2.6.4-1 - unzip 6.0-17 - zip 3.0-12 But I am seeing exactly the same error. **3.** No - I've tried it only with Windows as we need debug symbols there... Side note: Could you guys please provide me with the versions of the above libraries that are used in the case of your CI build system? Is now Visual Studio the only difference? I tried to check it by myself by going through the log files at https://github.com/arun-Joseph/jfx/runs/2028653928 but I couldn't found CygWin plugin versions (bison, flex...). Tomorrow I will try building it using Visual Studio 2019. - PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails
On Mon, 8 Mar 2021 14:06:02 GMT, Kevin Rushforth wrote: >> Hi dear OpenJdk team, >> >> At first I would like to thank you for looking into this. I am the author of >> original `8262276` ticket. >> >> I would just like to share some additional information with you. I've >> fetched and checked out this pull request (`pull/417`) and tried to run the >> build once more inside exactly the same environment in which original >> `8262276` ticket was produced. >> >> The build failed again. The only difference I can spot at this time is the >> line at which the build failed (it changed from 3445 to 3453): >> >> * Where: >> Build file 'C:\jfx-arun-joseph\build.gradle' line: 3453 >> >> Please let me know if you need any further information. > >> The build failed again. The only difference I can spot at this time is the >> line at which the build failed (it changed from 3445 to 3453): >> ... >> >> Please let me know if you need any further information. > > You might be running into a different problem then, since this patch solve > the compilation problem for Arun, for me, and for our CI build systems, when > building with `-PCONF=DebugNative` (as a side note, we have some problems > running the unit tests, but that's a separate issue). I have a couple > questions for you: > > 1. Does the build work if you build without `-PCONF=DebugNative`? If it still > fails, then you are definitely running into a different problem, likely > something in your environment. > > 2. Can you double-check the versions of the build tools that you are using? > We build using Visual Studio 2019 rather than the 2017 that you are using, > although it will build with the latest VS2017 update. The versions of the > other tools should be: > * gradle 6.3 > * cmake 3.13.3 > * ninja 1.8.2 > > 3. Have you tried building on a platform other than Windows? when passing `--info` to gradle, the build succeeds. Without passing `--info` it fails. I'll do more testing later. - PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails
On Mon, 8 Mar 2021 08:16:51 GMT, PrimosK wrote: >> Fixing the Debug build of WebKit. >> >> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test >> using a simple HelloWebView app. > > Hi dear OpenJdk team, > > At first I would like to thank you for looking into this. I am the author of > original `8262276` ticket. > > I would just like to share some additional information with you. I've fetched > and checked out this pull request (`pull/417`) and tried to run the build > once more inside exactly the same environment in which original `8262276` > ticket was produced. > > The build failed again. The only difference I can spot at this time is the > line at which the build failed (it changed from 3445 to 3453): > > * Where: > Build file 'C:\jfx-arun-joseph\build.gradle' line: 3453 > > Please let me know if you need any further information. > The build failed again. The only difference I can spot at this time is the > line at which the build failed (it changed from 3445 to 3453): > ... > > Please let me know if you need any further information. You might be running into a different problem then, since this patch solve the compilation problem for Arun, for me, and for our CI build systems, when building with `-PCONF=DebugNative` (as a side note, we have some problems running the unit tests, but that's a separate issue). I have a couple questions for you: 1. Does the build work if you build without `-PCONF=DebugNative`? If it still fails, then you are definitely running into a different problem, likely something in your environment. 2. Can you double-check the versions of the build tools that you are using? We build using Visual Studio 2019 rather than the 2017 that you are using, although it will build with the latest VS2017 update. The versions of the other tools should be: * gradle 6.3 * cmake 3.13.3 * ninja 1.8.2 3. Have you tried building on a platform other than Windows? - PR: https://git.openjdk.java.net/jfx/pull/417
Re: RFR: 8262276: Debug build of WebKit fails
On Thu, 4 Mar 2021 06:41:53 GMT, Arun Joseph wrote: > Fixing the Debug build of WebKit. > > Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test > using a simple HelloWebView app. Hi dear OpenJdk team, At first I would like to thank you for looking into this. I am the author of original `8262276` ticket. I would just like to share some additional information with you. I've fetched and checked out this pull request (`pull/417`) and tried to run the build once more inside exactly the same environment in which original `8262276` ticket was produced. The build failed again. The only difference I can spot at this time is the line at which the build failed (it changed from 3445 to 3453): * Where: Build file 'C:\jfx-arun-joseph\build.gradle' line: 3453 Please let me know if you need any further information. - PR: https://git.openjdk.java.net/jfx/pull/417
