Re: RFR: 8293883: Add test/.classpath (Eclipse) [v2]
> Adding a tests/.classpath file to include tests/manual/controls source folder > so Eclipse could see/execute manual tests there. > > Also, I would rather move the sources there to a specific package > (test.manual ?) instead of a default package. Any objections? > edit: won't be done as a part of this PR. Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: 8293883: more dirs under manual/ and performance/ - Changes: - all: https://git.openjdk.org/jfx/pull/901/files - new: https://git.openjdk.org/jfx/pull/901/files/06877a4b..9949c68b Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=901&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=901&range=00-01 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/901.diff Fetch: git fetch https://git.openjdk.org/jfx pull/901/head:pull/901 PR: https://git.openjdk.org/jfx/pull/901
Re: RFR: 8293883: Add test/.classpath (Eclipse)
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote: > Adding a tests/.classpath file to include tests/manual/controls source folder > so Eclipse could see/execute manual tests there. > > Also, I would rather move the sources there to a specific package > (test.manual ?) instead of a default package. Any objections? > edit: won't be done as a part of this PR. Added more dirs under manual/ and performance/ - had to skip certain directories that looked like projects in their own right, or that required additional dependencies. - PR: https://git.openjdk.org/jfx/pull/901
Re: RFR: 8293883: Add test/.classpath (Eclipse)
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote: > Adding a tests/.classpath file to include tests/manual/controls source folder > so Eclipse could see/execute manual tests there. > > Also, I would rather move the sources there to a specific package > (test.manual ?) instead of a default package. Any objections? > edit: won't be done as a part of this PR. The default package is pre-existing bad practice, but doesn't pose an issue, I tried it myself. It makes little sense to add just one source folder while neglecting all the others. If we are editing this classpath to make the tests runnable (even if with the incorrect configuration), then we should make the tests runnable. - PR: https://git.openjdk.org/jfx/pull/901
Re: RFR: 8293883: Add test/.classpath (Eclipse)
On Thu, 22 Sep 2022 19:54:41 GMT, Nir Lisker wrote: > There are sources under `tests/performance` and `tests/manual` that should > also be included in the classpath. I would like to limit the scope of this PR. The problem is that one thing leads to another - and the fact that all these manual tests are using the default package instead of their own individual packages might lead to issues and/or require more time and attention. - PR: https://git.openjdk.org/jfx/pull/901
Re: RFR: 8293883: Add test/.classpath (Eclipse)
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote: > Adding a tests/.classpath file to include tests/manual/controls source folder > so Eclipse could see/execute manual tests there. > > Also, I would rather move the sources there to a specific package > (test.manual ?) instead of a default package. Any objections? > edit: won't be done as a part of this PR. There are sources under `tests/performance` and `tests/manual` that should also be included in the classpath. I was actually reviewing it just now. Same as with apps, this is not the way the tests should be ordered. While it allows to run them from Eclipse, the way the tests are currently divided means that they should be (sub-) projects. We will need a follow-up on this. @kevinrushforth Are you planning on continuing the cleanup of apps and tests soon? If so, we should wait for it with the Eclipse changes. - Changes requested by nlisker (Reviewer). PR: https://git.openjdk.org/jfx/pull/901
Re: RFR: 8293883: Add test/.classpath (Eclipse)
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote: > Adding a tests/.classpath file to include tests/manual/controls source folder > so Eclipse could see/execute manual tests there. > > Also, I would rather move the sources there to a specific package > (test.manual ?) instead of a default package. Any objections? > edit: won't be done as a part of this PR. @nlisker : could you please review this small change, I wanted to publish a demo/manual test for the constrained resize policy in [JDK-8293119](https://bugs.openjdk.org/browse/JDK-8293119) to the mailing list? thank you in advance! -andy - PR: https://git.openjdk.org/jfx/pull/901
Re: RFR: 8293883: Add test/.classpath (Eclipse)
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote: > Also, I would rather move the sources there to a specific package > (test.manual ?) instead of a default package. Any objections? That should probably be done via a separate cleanup bug, since it is outside the scope of this IDE-only fix. It would make sense to at least look at all of the manual tests (since they all exist in the unnamed package), even if you want to limit the scope of the follow-on bug to the manual controls tests. - PR: https://git.openjdk.org/jfx/pull/901
RFR: 8293883: Add test/.classpath (Eclipse)
Adding a tests/.classpath file to include tests/manual/controls source folder so Eclipse could see/execute manual tests there. Also, I would rather move the sources there to a specific package (test.manual ?) instead of a default package. Any objections? - Commit messages: - 8293883: added tests/.classpath Changes: https://git.openjdk.org/jfx/pull/901/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=901&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293883 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx/pull/901.diff Fetch: git fetch https://git.openjdk.org/jfx pull/901/head:pull/901 PR: https://git.openjdk.org/jfx/pull/901
