Re: RFR: 8316372: Monkey Tester Application Part 3 [v7]
On Mon, 25 Mar 2024 22:36:48 GMT, Andy Goryachev wrote: >> Further changes to the MonkeyTester application: >> >> - remember split pane divider ✔ >> - use 'private' instead of 'protected' in many cases ✔ >> - added more scripts to the 'writing systems' text sample ✔ >> - added RTL window control menu ✔ >> - added embedded swing/fx in tools ✔ >> - added copy popup menu in clipboard viewer ✔ >> - added the custom css field to the css playground tool ✔ >> - added many new pages ✔ >> - split XYChartPage into separate pages ✔ >> - switched to use property sheets (some choices might be incomplete) ✔ >> >> https://github.com/andy-goryachev-oracle/jfx/blob/8316372.monkey/tests/manual/monkey/README.md >> >> These are all the changes I could make in this test sprint, other >> improvements will go to the follow-up ticket >> https://bugs.openjdk.org/browse/JDK-8328828 > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > spinner Looks good. I ran through several of the new and existing pages. - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1406#pullrequestreview-1967067101
Re: RFR: 8316372: Monkey Tester Application Part 3 [v7]
On Mon, 25 Mar 2024 22:36:48 GMT, Andy Goryachev wrote: >> Further changes to the MonkeyTester application: >> >> - remember split pane divider ✔ >> - use 'private' instead of 'protected' in many cases ✔ >> - added more scripts to the 'writing systems' text sample ✔ >> - added RTL window control menu ✔ >> - added embedded swing/fx in tools ✔ >> - added copy popup menu in clipboard viewer ✔ >> - added the custom css field to the css playground tool ✔ >> - added many new pages ✔ >> - split XYChartPage into separate pages ✔ >> - switched to use property sheets (some choices might be incomplete) ✔ >> >> https://github.com/andy-goryachev-oracle/jfx/blob/8316372.monkey/tests/manual/monkey/README.md >> >> These are all the changes I could make in this test sprint, other >> improvements will go to the follow-up ticket >> https://bugs.openjdk.org/browse/JDK-8328828 > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > spinner Marked as reviewed by kpk (Committer). - PR Review: https://git.openjdk.org/jfx/pull/1406#pullrequestreview-1962296060
Re: RFR: 8316372: Monkey Tester Application Part 3 [v7]
On Tue, 26 Mar 2024 09:59:24 GMT, Karthik P K wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> spinner > > tests/manual/monkey/src/com/oracle/tools/fx/monkey/settings/FxSettingsSchema.java > line 280: > >> 278: >> 279: // FIX some kind of a bug, the dividers move slightly >> each time >> 280: sp.setDividerPositions(divs); > > Since we are calling this outside FX thread it won't throw exception in any > scenario right? I checked and couldn't find anything. Wanted to make sure. No, we are not calling this from outside the FX app thread. What happens here is that the resulting dividers are slightly off if we don't follow up with `Platform.runLater()`, and I am not sure why. I suspect this is a bug in SplitPane, but I can't easily come up with a SCCE. - PR Review Comment: https://git.openjdk.org/jfx/pull/1406#discussion_r1539855183
Re: RFR: 8316372: Monkey Tester Application Part 3 [v7]
On Mon, 25 Mar 2024 22:36:48 GMT, Andy Goryachev wrote: >> Further changes to the MonkeyTester application: >> >> - remember split pane divider ✔ >> - use 'private' instead of 'protected' in many cases ✔ >> - added more scripts to the 'writing systems' text sample ✔ >> - added RTL window control menu ✔ >> - added embedded swing/fx in tools ✔ >> - added copy popup menu in clipboard viewer ✔ >> - added the custom css field to the css playground tool ✔ >> - added many new pages ✔ >> - split XYChartPage into separate pages ✔ >> - switched to use property sheets (some choices might be incomplete) ✔ >> >> https://github.com/andy-goryachev-oracle/jfx/blob/8316372.monkey/tests/manual/monkey/README.md >> >> These are all the changes I could make in this test sprint, other >> improvements will go to the follow-up ticket >> https://bugs.openjdk.org/browse/JDK-8328828 > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > spinner I have completed sanity testing all the pages. Added a comment inline. This change has added lot of options to the MT and it will be useful in testing the controls. Since you have already created a bug for next set of changes, I think this looks good for now. tests/manual/monkey/src/com/oracle/tools/fx/monkey/settings/FxSettingsSchema.java line 280: > 278: > 279: // FIX some kind of a bug, the dividers move slightly > each time > 280: sp.setDividerPositions(divs); Since we are calling this outside FX thread it won't throw exception in any scenario right? I checked and couldn't find anything. Wanted to make sure. - PR Review: https://git.openjdk.org/jfx/pull/1406#pullrequestreview-1959880649 PR Review Comment: https://git.openjdk.org/jfx/pull/1406#discussion_r1538919751
Re: RFR: 8316372: Monkey Tester Application Part 3 [v7]
> Further changes to the MonkeyTester application: > > - remember split pane divider ✔ > - use 'private' instead of 'protected' in many cases ✔ > - added more scripts to the 'writing systems' text sample ✔ > - added RTL window control menu ✔ > - added embedded swing/fx in tools ✔ > - added copy popup menu in clipboard viewer ✔ > - added the custom css field to the css playground tool ✔ > - added many new pages ✔ > - split XYChartPage into separate pages ✔ > - switched to use property sheets (some choices might be incomplete) ✔ > > https://github.com/andy-goryachev-oracle/jfx/blob/8316372.monkey/tests/manual/monkey/README.md > > These are all the changes I could make in this test sprint, other > improvements will go to the follow-up ticket > https://bugs.openjdk.org/browse/JDK-8328828 Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: spinner - Changes: - all: https://git.openjdk.org/jfx/pull/1406/files - new: https://git.openjdk.org/jfx/pull/1406/files/5f234e78..014e3796 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1406&range=06 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1406&range=05-06 Stats: 12 lines in 1 file changed: 5 ins; 4 del; 3 mod Patch: https://git.openjdk.org/jfx/pull/1406.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1406/head:pull/1406 PR: https://git.openjdk.org/jfx/pull/1406
