Re: Samba with_docs option.
On Thu, Aug 21, 2003, Bill Campbell wrote: > The attached patch for the samba.spec file adds the option with_docs which > installs the documentation and image files, many of which are used by > ``swat'', the web base configuration tool. > > One of the primary reasons we use and recommend others to use swat rather > than editing the samba smb.conf file directly is that it provides excellent > links to the documentation for all configuration options -- which can be a > bit arcane and confusion for the samba clued, much less the casual users. > > One could argue that the ``using_samba'' documentation isn't really > necessary, The entire using_samba directory is about 2.7M. > > The attached patch is against the 1.3 release version, and would work on > current except for the build number part. Hmm... good point, but because the stuff is for SWAT only, how about making it a with_swat option and even remove swat also if this option is not a set? Index: samba.spec === RCS file: /e/openpkg/cvs/openpkg-src/samba/samba.spec,v retrieving revision 1.57 diff -u -d -u -d -u -d -r1.57 samba.spec --- samba.spec 1 Aug 2003 09:42:51 - 1.57 +++ samba.spec 22 Aug 2003 08:04:06 - @@ -37,6 +37,7 @@ # package options %option with_pam no +%option with_swat no # list of sources Source0: http://download.samba.org/samba/ftp/samba-%{version}.tar.gz @@ -137,9 +138,12 @@ $RPM_BUILD_ROOT%{l_prefix}/libexec/samba/$file done rm -rf $RPM_BUILD_ROOT%{l_prefix}/share/samba/using_samba +%if "%{with_swat}" != "yes" rm -rf $RPM_BUILD_ROOT%{l_prefix}/share/samba/help rm -rf $RPM_BUILD_ROOT%{l_prefix}/share/samba/images rm -rf $RPM_BUILD_ROOT%{l_prefix}/share/samba/include +rm -f $RPM_BUILD_ROOT%{l_prefix}/sbin/swat +%endif strip $RPM_BUILD_ROOT%{l_prefix}/bin/* >/dev/null 2>&1 || true strip $RPM_BUILD_ROOT%{l_prefix}/sbin/* >/dev/null 2>&1 || true strip $RPM_BUILD_ROOT%{l_prefix}/libexec/samba/* >/dev/null 2>&1 || true Ralf S. Engelschall [EMAIL PROTECTED] www.engelschall.com __ The OpenPKG Projectwww.openpkg.org Developer Communication List [EMAIL PROTECTED]
Re: Samba with_docs option.
On Fri, Aug 22, 2003, Ralf S. Engelschall wrote: >On Thu, Aug 21, 2003, Bill Campbell wrote: > >> The attached patch for the samba.spec file adds the option with_docs which >> installs the documentation and image files, many of which are used by >> ``swat'', the web base configuration tool. >> >> One of the primary reasons we use and recommend others to use swat rather >> than editing the samba smb.conf file directly is that it provides excellent >> links to the documentation for all configuration options -- which can be a >> bit arcane and confusion for the samba clued, much less the casual users. >> >> One could argue that the ``using_samba'' documentation isn't really >> necessary, The entire using_samba directory is about 2.7M. >> >> The attached patch is against the 1.3 release version, and would work on >> current except for the build number part. > >Hmm... good point, but because the stuff is for SWAT only, how about >making it a with_swat option and even remove swat also if this option is >not a set? That would certainly work. Personally I would prefer a general with_docs option that would be common to all packages because I like to have examples and documentation handy on the systems. Yesterday I was on-site at a customer with no internet access, and it's much easier to have the docs readily available than to have to unpack the SRPMS to get at it. >Index: samba.spec >=== >RCS file: /e/openpkg/cvs/openpkg-src/samba/samba.spec,v >retrieving revision 1.57 >diff -u -d -u -d -u -d -r1.57 samba.spec >--- samba.spec 1 Aug 2003 09:42:51 - 1.57 >+++ samba.spec 22 Aug 2003 08:04:06 - >@@ -37,6 +37,7 @@ > > # package options > %option with_pam no >+%option with_swat no > > # list of sources > Source0: http://download.samba.org/samba/ftp/samba-%{version}.tar.gz >@@ -137,9 +138,12 @@ >$RPM_BUILD_ROOT%{l_prefix}/libexec/samba/$file > done > rm -rf $RPM_BUILD_ROOT%{l_prefix}/share/samba/using_samba >+%if "%{with_swat}" != "yes" > rm -rf $RPM_BUILD_ROOT%{l_prefix}/share/samba/help > rm -rf $RPM_BUILD_ROOT%{l_prefix}/share/samba/images > rm -rf $RPM_BUILD_ROOT%{l_prefix}/share/samba/include >+rm -f $RPM_BUILD_ROOT%{l_prefix}/sbin/swat >+%endif > strip $RPM_BUILD_ROOT%{l_prefix}/bin/* >/dev/null 2>&1 || true > strip $RPM_BUILD_ROOT%{l_prefix}/sbin/* >/dev/null 2>&1 || true > strip $RPM_BUILD_ROOT%{l_prefix}/libexec/samba/* >/dev/null 2>&1 || true > > Ralf S. Engelschall > [EMAIL PROTECTED] > www.engelschall.com > >__ >The OpenPKG Projectwww.openpkg.org >Developer Communication List [EMAIL PROTECTED] > -- Bill -- INTERNET: [EMAIL PROTECTED] Bill Campbell; Celestial Software LLC UUCP: camco!bill PO Box 820; 6641 E. Mercer Way FAX:(206) 232-9186 Mercer Island, WA 98040-0820; (206) 236-1676 URL: http://www.celestial.com/ ``... because most politicians and bureaucrats are technological idiots, it's going to be crucial for the rank and file members of the IT community to find its collective voice soon.'' --Michael Vizard, InfoWorld Editor in Chief. __ The OpenPKG Projectwww.openpkg.org Developer Communication List [EMAIL PROTECTED]
Re: Samba with_docs option.
On Fri, Aug 22, 2003, Bill Campbell wrote: > [...] > >Hmm... good point, but because the stuff is for SWAT only, how about > >making it a with_swat option and even remove swat also if this option is > >not a set? > > That would certainly work. > > Personally I would prefer a general with_docs option that would be common > to all packages because I like to have examples and documentation handy on > the systems. Yesterday I was on-site at a customer with no internet > access, and it's much easier to have the docs readily available than to > have to unpack the SRPMS to get at it. > [...] Yes, sure. In the long-term we should provide something like global with_dso (for shared library) and with_doc (for included documentation) and similar options. This is on our TODO list. But speaking just about this package here, I think we should stick with a local solution for now (until a global solution exist) and use this with_swat option. I've comitted it to CVS now: http://cvs.openpkg.org/chngview?cn=11812 Ralf S. Engelschall [EMAIL PROTECTED] www.engelschall.com __ The OpenPKG Projectwww.openpkg.org Developer Communication List [EMAIL PROTECTED]
Re: Samba with_docs option.
On Fri, Aug 22, 2003, Ralf S. Engelschall wrote: >On Fri, Aug 22, 2003, Bill Campbell wrote: > >> [...] >> >Hmm... good point, but because the stuff is for SWAT only, how about >> >making it a with_swat option and even remove swat also if this option is >> >not a set? >> >> That would certainly work. >> >> Personally I would prefer a general with_docs option that would be common >> to all packages because I like to have examples and documentation handy on >> the systems. Yesterday I was on-site at a customer with no internet >> access, and it's much easier to have the docs readily available than to >> have to unpack the SRPMS to get at it. >> [...] > >Yes, sure. In the long-term we should provide something like global >with_dso (for shared library) and with_doc (for included documentation) >and similar options. This is on our TODO list. Sounds good to me. Regarding the with_dso option, I think that's really necessary for a few programs (myodbc, unixodbc, perl if one is to build postgres with perl support, etc.), and should be added to them before a general solution is implemented. So long as they use the option names that will be used in the overall solution, they won't require further work then. Bill -- INTERNET: [EMAIL PROTECTED] Bill Campbell; Celestial Software LLC UUCP: camco!bill PO Box 820; 6641 E. Mercer Way FAX:(206) 232-9186 Mercer Island, WA 98040-0820; (206) 236-1676 URL: http://www.celestial.com/ ``If the personal freedoms guaranteed by the Constitution inhibit the government's ability to govern the people, we should look to limit those guarantees.'' -President Bill Clinton, August 12, 1993 __ The OpenPKG Projectwww.openpkg.org Developer Communication List [EMAIL PROTECTED]