[devel] [PATCH 0 of 2] Review Request for IMM: add support for forwards compatibility of attribute flags [#116]
Summary: IMM: add support for forwards compatibility of attribute flags [#116] Review request for Trac Ticket(s): 116 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): opensaf-4.2.x Development branch: opensaf-4.2.x Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - changeset 7f121b591dd1c5464ee9f1070058ded74650b913 Author: Zoran Milinkovic Date: Tue, 18 Feb 2014 15:56:38 +0100 IMM: add support for forwards compatibility of attribute flags [#116] changeset 46e2af8f3017b450b8e714574df02b3dcea20a98 Author: Zoran Milinkovic Date: Tue, 18 Feb 2014 16:06:11 +0100 IMMTOOLS: add support for forwards compatibility of attribute flags [#116] For forwards compatibility, OpenSAF schema, where unknown attribute flags are defined, must be provided to IMM tools (immcfg, immlist, immfind) using -X flag. If immload finds unknown attribute flag, immload will try to find the attribute flag in the schema defined in the top element of the loading IMM XML file. Complete diffstat: -- osaf/services/saf/immsv/immnd/ImmModel.cc | 39 ++ osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +- osaf/services/saf/immsv/immnd/ImmSearchOp.hh |4 +- osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.01.02_OpenSAF.xsd | 10 +++--- osaf/tools/safimm/immcfg/imm_cfg.c | 31 + osaf/tools/safimm/immcfg/imm_import.cc | 196 +++-- osaf/tools/safimm/immdump/imm_dumper.cc| 170 --- osaf/tools/safimm/immdump/imm_dumper.hh|2 + osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 13 - osaf/tools/safimm/immlist/Makefile.am |4 ++ osaf/tools/safimm/immlist/imm_list.c | 191 +- osaf/tools/safimm/immload/imm_loader.cc| 164 ++- 12 files changed, 789 insertions(+), 37 deletions(-) Testing Commands: - immcfg -X schema_with_unknown_flags.xsd imm.xml immlist -X schema_with_unknown_flags.xsd -c test_class immdump -X schema_with_unknown_flags.xsd test.xml Testing, Expected Results: -- Beside IMM tools test, it must be tested that unknown flags imported into IMM will survive OpenSAF restart. Conditions of Submission: - Ack from Neelakanta Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You
[devel] [PATCH 0 of 2] Review Request for IMM: add support for forwards compatibility of attribute flags [#116]
Summary: IMM: add support for forwards compatibility of attribute flags [#116] Review request for Trac Ticket(s): 116 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): opensaf-4.3.x Development branch: opensaf-4.3.x Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - changeset 4e107d75f25bb46d71db0de3fd6ca8700be57f61 Author: Zoran Milinkovic Date: Tue, 18 Feb 2014 15:57:23 +0100 IMM: add support for forwards compatibility of attribute flags [#116] changeset 91e6dc516587d64e91c4ad3c5e1e6b6db4d8ca0b Author: Zoran Milinkovic Date: Tue, 18 Feb 2014 16:06:28 +0100 IMMTOOLS: add support for forwards compatibility of attribute flags [#116] For forwards compatibility, OpenSAF schema, where unknown attribute flags are defined, must be provided to IMM tools (immcfg, immlist, immfind) using -X flag. If immload finds unknown attribute flag, immload will try to find the attribute flag in the schema defined in the top element of the loading IMM XML file. Complete diffstat: -- osaf/libs/common/immsv/immpbe_dump.cc |2 +- osaf/services/saf/immsv/immloadd/imm_loader.cc | 164 +- osaf/services/saf/immsv/immnd/ImmModel.cc | 36 -- osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +- osaf/services/saf/immsv/immnd/ImmSearchOp.hh |4 +- osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.12.xsd | 14 +- osaf/tools/safimm/immcfg/imm_cfg.c | 31 ++ osaf/tools/safimm/immcfg/imm_import.cc | 196 +++-- osaf/tools/safimm/immdump/imm_dumper.cc| 168 ++-- osaf/tools/safimm/immdump/imm_dumper.hh|2 + osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 11 osaf/tools/safimm/immlist/Makefile.am |4 ++ osaf/tools/safimm/immlist/imm_list.c | 191 +- 13 files changed, 780 insertions(+), 45 deletions(-) Testing Commands: - immcfg -X schema_with_unknown_flags.xsd imm.xml immlist -X schema_with_unknown_flags.xsd -c test_class immdump -X schema_with_unknown_flags.xsd test.xml Testing, Expected Results: -- Beside IMM tools test, it must be tested that unknown flags imported into IMM will survive OpenSAF restart. Conditions of Submission: - Ack from Neelakanta Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___
[devel] [PATCH 0 of 2] Review Request for IMM: add support for forwards compatibility of attribute flags [#116]
Summary: IMM: add support for forwards compatibility of attribute flags [#116] Review request for Trac Ticket(s): 116 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): opensaf-4.4.x, default(4.5) Development branch: default(4.5) Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - changeset 3112b9aeccd503e2f876afb3909480aed2d53bcb Author: Zoran Milinkovic Date: Tue, 18 Feb 2014 15:57:47 +0100 IMM: add support for forwards compatibility of attribute flags [#116] changeset ea5a93c4f68d3f8f620309356acb101165148893 Author: Zoran Milinkovic Date: Tue, 18 Feb 2014 16:07:47 +0100 IMMTOOLS: add support for forwards compatibility of attribute flags [#116] For forwards compatibility, OpenSAF schema, where unknown attribute flags are defined, must be provided to IMM tools (immcfg, immlist, immfind) using -X flag. If immload finds unknown attribute flag, immload will try to find the attribute flag in the schema defined in the top element of the loading IMM XML file. Complete diffstat: -- osaf/libs/common/immsv/immpbe_dump.cc |2 +- osaf/services/saf/immsv/immloadd/imm_loader.cc | 165 +- osaf/services/saf/immsv/immnd/ImmModel.cc | 36 ++- osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +- osaf/services/saf/immsv/immnd/ImmSearchOp.hh |4 +- osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.12.xsd | 14 osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.13.xsd | 16 +- osaf/tools/safimm/immcfg/imm_cfg.c | 29 +-- osaf/tools/safimm/immcfg/imm_import.cc | 218 ++--- osaf/tools/safimm/immdump/imm_dumper.cc| 172 -- osaf/tools/safimm/immdump/imm_dumper.hh|2 + osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 11 +++ osaf/tools/safimm/immlist/Makefile.am |4 ++ osaf/tools/safimm/immlist/imm_list.c | 192 +++- 14 files changed, 802 insertions(+), 65 deletions(-) Testing Commands: - immcfg -X schema_with_unknown_flags.xsd imm.xml immlist -X schema_with_unknown_flags.xsd -c test_class immdump -X schema_with_unknown_flags.xsd test.xml Testing, Expected Results: -- Beside IMM tools test, it must be tested that unknown flags imported into IMM will survive OpenSAF restart. Conditions of Submission: - Ack from Neelakanta Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup ch
[devel] [PATCH 0 of 2] Review Request for IMM: add support for forwards compatibility of attribute flags [#116]
Summary: IMM: add support for forwards compatibility of attribute flags [#116] Review request for Trac Ticket(s): 116 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): opensaf-4.2.x Development branch: opensaf-4.2.x Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - changeset 5d03eb30ac8a399dfef00880331ac5673c5842ac Author: Zoran Milinkovic Date: Fri, 21 Feb 2014 17:18:28 +0100 IMM: add support for forwards compatibility of attribute flags [#116] changeset fa1c55912ed6115122be1960ad4d31631fe42de3 Author: Zoran Milinkovic Date: Fri, 21 Feb 2014 17:21:37 +0100 IMMTOOLS: add support for forwards compatibility of attribute flags [#116] For forwards compatibility, OpenSAF schema, where unknown attribute flags are defined, must be provided to immcfg using -X flag. If immload finds unknown attribute flag, immload will try to find the attribute flag in the schema defined in the top element of the loading IMM XML file. Complete diffstat: -- osaf/services/saf/immsv/immnd/ImmModel.cc| 39 -- osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +- osaf/services/saf/immsv/immnd/ImmSearchOp.hh |4 +- osaf/tools/safimm/immcfg/imm_cfg.c | 31 ++- osaf/tools/safimm/immcfg/imm_import.cc | 178 +++ osaf/tools/safimm/immlist/imm_list.c |6 - osaf/tools/safimm/immload/imm_loader.cc | 150 + 7 files changed, 368 insertions(+), 42 deletions(-) Testing Commands: - immcfg -X schema_with_unknown_flags.xsd imm.xml Testing, Expected Results: -- When OpenSAF starts without PBE enabled, immload must successfuly load imm.xml with unknown flags, if unknown flags are defined in a schema of loading imm.xml file. The schema must be in the same directory as imm.xml. Conditions of Submission: - Ack from Neelakanta Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your
[devel] [PATCH 0 of 2] Review Request for IMM: add support for forwards compatibility of attribute flags [#116]
Summary: IMM: add support for forwards compatibility of attribute flags [#116] Review request for Trac Ticket(s): 116 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): opensaf-4.3.x Development branch: opensaf-4.3.x Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - changeset a4a323a7c56dc5db04cbbf373a7585de0a456074 Author: Zoran Milinkovic Date: Fri, 21 Feb 2014 17:28:23 +0100 IMM: add support for forwards compatibility of attribute flags [#116] Add support for 64-bit attribute flags to IMM service. If immload finds unknown attribute flag, immload will try to find the attribute flag in the schema defined in the top element of the loading IMM XML file. changeset 437a840e80d0dca16408a6341d8f37969056b8f0 Author: Zoran Milinkovic Date: Fri, 21 Feb 2014 17:29:00 +0100 IMMTOOLS: add support for forwards compatibility of attribute flags [#116] For forwards compatibility, OpenSAF schema, where unknown attribute flags are defined, must be provided to immcfg using -X flag. Complete diffstat: -- osaf/libs/common/immsv/immpbe_dump.cc |2 +- osaf/services/saf/immsv/immloadd/imm_loader.cc | 140 +++- osaf/services/saf/immsv/immnd/ImmModel.cc | 36 osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +- osaf/services/saf/immsv/immnd/ImmSearchOp.hh |4 +- osaf/tools/safimm/immcfg/imm_cfg.c | 31 ++- osaf/tools/safimm/immcfg/imm_import.cc | 172 ++--- 7 files changed, 358 insertions(+), 29 deletions(-) Testing Commands: - immcfg -X schema_with_unknown_flags.xsd imm.xml Testing, Expected Results: -- When OpenSAF starts without PBE enabled, immload must successfuly load imm.xml with unknown flags, if unknown flags are defined in a schema of loading imm.xml file. The schema must be in the same directory as imm.xml. Conditions of Submission: - Ack from Neelakanta Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You hav
[devel] [PATCH 0 of 2] Review Request for IMM: add support for forwards compatibility of attribute flags [#116]
Summary: IMM: add support for forwards compatibility of attribute flags [#116] Review request for Trac Ticket(s): 116 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): opensaf-4.4.x, default(4.5) Development branch: default(4.5) Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - changeset 4d742de378fe7a3f25f7e80637d4f41be5c29544 Author: Zoran Milinkovic Date: Fri, 21 Feb 2014 17:30:37 +0100 IMM: add support for forwards compatibility of attribute flags [#116] Add support for 64-bit attribute flags to IMM service. If immload finds unknown attribute flag, immload will try to find the attribute flag in the schema defined in the top element of the loading IMM XML file. changeset 950ce6e540c64d839a94607037574912bbf21acf Author: Zoran Milinkovic Date: Fri, 21 Feb 2014 17:31:05 +0100 IMMTOOLS: add support for forwards compatibility of attribute flags [#116] For forwards compatibility, OpenSAF schema, where unknown attribute flags are defined, must be provided to immcfg using -X flag. Complete diffstat: -- osaf/libs/common/immsv/immpbe_dump.cc |2 +- osaf/services/saf/immsv/immloadd/imm_loader.cc | 140 ++- osaf/services/saf/immsv/immnd/ImmModel.cc | 36 ++--- osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +- osaf/services/saf/immsv/immnd/ImmSearchOp.hh |4 +- osaf/tools/safimm/immcfg/imm_cfg.c | 29 +-- osaf/tools/safimm/immcfg/imm_import.cc | 191 +++-- 7 files changed, 365 insertions(+), 39 deletions(-) Testing Commands: - immcfg -X schema_with_unknown_flags.xsd imm.xml Testing, Expected Results: -- When OpenSAF starts without PBE enabled, immload must successfuly load imm.xml with unknown flags, if unknown flags are defined in a schema of loading imm.xml file. The schema must be in the same directory as imm.xml. Conditions of Submission: - Ack from Neelakanta Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misc
Re: [devel] [PATCH 0 of 2] Review Request for IMM: add support for forwards compatibility of attribute flags [#116]
Hi zoran, Reviewed the patches for 4.2.x, 4.3.x, 4.4.x(default). Tested with 4.2.x . Ack for all patches. /Neel. On Friday 21 February 2014 10:07 PM, Zoran Milinkovic wrote: > Summary: IMM: add support for forwards compatibility of attribute flags [#116] > Review request for Trac Ticket(s): 116 > Peer Reviewer(s): Neelakanta > Pull request to: Zoran > Affected branch(es): opensaf-4.2.x > Development branch: opensaf-4.2.x > > > Impacted area Impact y/n > > Docsn > Build systemn > RPM/packaging n > Configuration files n > Startup scripts n > SAF servicesy > OpenSAF servicesn > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > - > > changeset 5d03eb30ac8a399dfef00880331ac5673c5842ac > Author: Zoran Milinkovic > Date: Fri, 21 Feb 2014 17:18:28 +0100 > > IMM: add support for forwards compatibility of attribute flags [#116] > > changeset fa1c55912ed6115122be1960ad4d31631fe42de3 > Author: Zoran Milinkovic > Date: Fri, 21 Feb 2014 17:21:37 +0100 > > IMMTOOLS: add support for forwards compatibility of attribute flags > [#116] > > For forwards compatibility, OpenSAF schema, where unknown attribute > flags > are defined, must be provided to immcfg using -X flag. If immload finds > unknown attribute flag, immload will try to find the attribute flag in > the > schema defined in the top element of the loading IMM XML file. > > > Complete diffstat: > -- > osaf/services/saf/immsv/immnd/ImmModel.cc| 39 > -- > osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +- > osaf/services/saf/immsv/immnd/ImmSearchOp.hh |4 +- > osaf/tools/safimm/immcfg/imm_cfg.c | 31 > ++- > osaf/tools/safimm/immcfg/imm_import.cc | 178 > +++ > osaf/tools/safimm/immlist/imm_list.c |6 - > osaf/tools/safimm/immload/imm_loader.cc | 150 > + > 7 files changed, 368 insertions(+), 42 deletions(-) > > > Testing Commands: > - > immcfg -X schema_with_unknown_flags.xsd imm.xml > > > Testing, Expected Results: > -- > When OpenSAF starts without PBE enabled, immload must successfuly load > imm.xml with unknown flags, if unknown flags are defined in a schema of > loading imm.xml file. The schema must be in the same directory as imm.xml. > > > Conditions of Submission: > - > Ack from Neelakanta > > > Arch Built StartedLinux distro > --- > mipsn n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > --- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached t
Re: [devel] [PATCH 0 of 2] Review Request for IMM: add support for forwards compatibility of attribute flags [#116]
Too late for the 4.2 patch. /AndersBj Neelakanta Reddy wrote: > Hi zoran, > > Reviewed the patches for 4.2.x, 4.3.x, 4.4.x(default). > Tested with 4.2.x . > Ack for all patches. > > /Neel. > > > On Friday 21 February 2014 10:07 PM, Zoran Milinkovic wrote: > >> Summary: IMM: add support for forwards compatibility of attribute flags >> [#116] >> Review request for Trac Ticket(s): 116 >> Peer Reviewer(s): Neelakanta >> Pull request to: Zoran >> Affected branch(es): opensaf-4.2.x >> Development branch: opensaf-4.2.x >> >> >> Impacted area Impact y/n >> >> Docsn >> Build systemn >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF servicesy >> OpenSAF servicesn >> Core libraries n >> Samples n >> Tests n >> Other n >> >> >> Comments (indicate scope for each "y" above): >> - >> >> changeset 5d03eb30ac8a399dfef00880331ac5673c5842ac >> Author: Zoran Milinkovic >> Date:Fri, 21 Feb 2014 17:18:28 +0100 >> >> IMM: add support for forwards compatibility of attribute flags [#116] >> >> changeset fa1c55912ed6115122be1960ad4d31631fe42de3 >> Author: Zoran Milinkovic >> Date:Fri, 21 Feb 2014 17:21:37 +0100 >> >> IMMTOOLS: add support for forwards compatibility of attribute flags >> [#116] >> >> For forwards compatibility, OpenSAF schema, where unknown attribute >> flags >> are defined, must be provided to immcfg using -X flag. If immload finds >> unknown attribute flag, immload will try to find the attribute flag in >> the >> schema defined in the top element of the loading IMM XML file. >> >> >> Complete diffstat: >> -- >> osaf/services/saf/immsv/immnd/ImmModel.cc| 39 >> -- >> osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +- >> osaf/services/saf/immsv/immnd/ImmSearchOp.hh |4 +- >> osaf/tools/safimm/immcfg/imm_cfg.c | 31 >> ++- >> osaf/tools/safimm/immcfg/imm_import.cc | 178 >> +++ >> osaf/tools/safimm/immlist/imm_list.c |6 - >> osaf/tools/safimm/immload/imm_loader.cc | 150 >> + >> 7 files changed, 368 insertions(+), 42 deletions(-) >> >> >> Testing Commands: >> - >> immcfg -X schema_with_unknown_flags.xsd imm.xml >> >> >> Testing, Expected Results: >> -- >> When OpenSAF starts without PBE enabled, immload must successfuly load >> imm.xml with unknown flags, if unknown flags are defined in a schema of >> loading imm.xml file. The schema must be in the same directory as imm.xml. >> >> >> Conditions of Submission: >> - >> Ack from Neelakanta >> >> >> Arch Built StartedLinux distro >> --- >> mipsn n >> mips64 n n >> x86 n n >> x86_64 n n >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> --- >> [Submitters: make sure that your review doesn't trigger any checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in
Re: [devel] [PATCH 0 of 2] Review Request for IMM: add support for forwards compatibility of attribute flags [#116]
Hi AndersBj, The ticket is already pushed in 4.2.x stream. /Neel. On Tuesday 04 March 2014 02:13 PM, Anders Bjornerstedt wrote: > Too late for the 4.2 patch. > > /AndersBj > > Neelakanta Reddy wrote: >> Hi zoran, >> >> Reviewed the patches for 4.2.x, 4.3.x, 4.4.x(default). >> Tested with 4.2.x . >> Ack for all patches. >> >> /Neel. >> >> >> On Friday 21 February 2014 10:07 PM, Zoran Milinkovic wrote: >>> Summary: IMM: add support for forwards compatibility of attribute >>> flags [#116] >>> Review request for Trac Ticket(s): 116 >>> Peer Reviewer(s): Neelakanta >>> Pull request to: Zoran >>> Affected branch(es): opensaf-4.2.x >>> Development branch: opensaf-4.2.x >>> >>> >>> Impacted area Impact y/n >>> >>> Docsn >>> Build systemn >>> RPM/packaging n >>> Configuration files n >>> Startup scripts n >>> SAF servicesy >>> OpenSAF servicesn >>> Core libraries n >>> Samples n >>> Tests n >>> Other n >>> >>> >>> Comments (indicate scope for each "y" above): >>> - >>> >>> changeset 5d03eb30ac8a399dfef00880331ac5673c5842ac >>> Author:Zoran Milinkovic >>> Date:Fri, 21 Feb 2014 17:18:28 +0100 >>> >>> IMM: add support for forwards compatibility of attribute flags >>> [#116] >>> >>> changeset fa1c55912ed6115122be1960ad4d31631fe42de3 >>> Author:Zoran Milinkovic >>> Date:Fri, 21 Feb 2014 17:21:37 +0100 >>> >>> IMMTOOLS: add support for forwards compatibility of attribute >>> flags [#116] >>> >>> For forwards compatibility, OpenSAF schema, where unknown >>> attribute flags >>> are defined, must be provided to immcfg using -X flag. If >>> immload finds >>> unknown attribute flag, immload will try to find the attribute >>> flag in the >>> schema defined in the top element of the loading IMM XML file. >>> >>> >>> Complete diffstat: >>> -- >>> osaf/services/saf/immsv/immnd/ImmModel.cc| 39 >>> -- >>> osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +- >>> osaf/services/saf/immsv/immnd/ImmSearchOp.hh |4 +- >>> osaf/tools/safimm/immcfg/imm_cfg.c | 31 >>> ++- >>> osaf/tools/safimm/immcfg/imm_import.cc | 178 >>> +++ >>> osaf/tools/safimm/immlist/imm_list.c |6 - >>> osaf/tools/safimm/immload/imm_loader.cc | 150 >>> + >>> 7 files changed, 368 insertions(+), 42 deletions(-) >>> >>> >>> Testing Commands: >>> - >>> immcfg -X schema_with_unknown_flags.xsd imm.xml >>> >>> >>> Testing, Expected Results: >>> -- >>> When OpenSAF starts without PBE enabled, immload must successfuly >>> load imm.xml with unknown flags, if unknown flags are defined in a >>> schema of loading imm.xml file. The schema must be in the same >>> directory as imm.xml. >>> >>> >>> Conditions of Submission: >>> - >>> Ack from Neelakanta >>> >>> >>> Arch Built StartedLinux distro >>> --- >>> mipsn n >>> mips64 n n >>> x86 n n >>> x86_64 n n >>> powerpc n n >>> powerpc64 n n >>> >>> >>> Reviewer Checklist: >>> --- >>> [Submitters: make sure that your review doesn't trigger any >>> checkmarks!] >>> >>> >>> Your checkin has not passed review because (see checked entries): >>> >>> ___ Your RR template is generally incomplete; it has too many blank >>> entries >>> that need proper data filled in. >>> >>> ___ You have failed to nominate the proper persons for review and push. >>> >>> ___ Your patches do not have proper short+long header >>> >>> ___ You have grammar/spelling in your header that is unacceptable. >>> >>> ___ You have exceeded a sensible line length in your >>> headers/comments/text. >>> >>> ___ You have failed to put in a proper Trac Ticket # into your commits. >>> >>> ___ You have incorrectly put/left internal data in your comments/files >>> (i.e. internal bug tracking tool IDs, product names etc) >>> >>> ___ You have not given any evidence of testing beyond basic build >>> tests. >>> Demonstrate some level of runtime or other sanity testing. >>> >>> ___ You have ^M present in some of your files. These have to be >>> removed. >>> >>> ___ You have needlessly changed whitespace or added whitespace crimes >>> like trailing spaces, or spaces before tabs. >>> >>> ___ You have mixed
