Re: [opensc-devel] gerrit - howto?
Le 27 mars 2012 07:01, Peter Stuge pe...@stuge.se a écrit : Ludovic Rousseau wrote: If you want to follow the OpenSC development is very important to subscribe to gerrit notifications (I think). I agree with this as well. It would of course be possible for gerrit to automatically send notifications for all new patches to the opensc-devel mailing list, we do this in several other projects, but it will of course result in more email traffic proportionate to the patches sent. Linux developers can handle it fine though.. I agree with Peter. New patches sent to gerrit should be sent to opensc-devel list. We do not (yet) have so many patches. And this should remind people that a new patch has to be reviewed. Peter, can you explain how to setup gerrit for that? I think only Martin can do that change as the gerrit admin. Bye -- Dr. Ludovic Rousseau ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] gerrit - howto?
Le mardi 27 mars 2012 à 09:14 +0200, Ludovic Rousseau a écrit : Peter, can you explain how to setup gerrit for that? I think only Martin can do that change as the gerrit admin. This has to change. We cannot have one admin on important software. On reason is that each of us can have an accident or become hill. Recently, Martin fell into cold water and got very cold. This is something that could happen to each of us, so it would be better to have several admins. Sharing resources is why we set up recently a buid farm with Viktor to be able to compile whatever happens. I can only encourage you to open the door of gerrit and jenkins to other members of the community, or we will one day or another set-up our own tools and share them. Kind regards, -- Jean-Michel Pouré - Gooze - http://www.gooze.eu smime.p7s Description: S/MIME cryptographic signature ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] gerrit - howto?
Ludovic Rousseau wrote: automatically send notifications for all new patches to the opensc-devel mailing list, Peter, can you explain how to setup gerrit for that? I think only Martin can do that change as the gerrit admin. It requires adding a patchset-created hook into the magic hooks directory in the gerrit install. The hook has to format and send the email to the list. It should send from an address which is subscribed to the list. //Peter ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] gerrit - howto?
Ludovic Rousseau wrote: I think you are doing the good thing. Thanks. I agree! I encourage every user of the opensc-devel list to: - create a gerrit account - subscribe to the Email notifications. Go in Settings - Watched Projects and check the 3 notifications boxes for the OpenSC project - review patches and add comments I second this! If you want to follow the OpenSC development is very important to subscribe to gerrit notifications (I think). I agree with this as well. It would of course be possible for gerrit to automatically send notifications for all new patches to the opensc-devel mailing list, we do this in several other projects, but it will of course result in more email traffic proportionate to the patches sent. Linux developers can handle it fine though.. //Peter ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
[opensc-devel] gerrit - howto?
I have registered to gerrit, because saying stuff is one thing, doing it is another. I guess I am supposed to verify and/or review. Which is what, and how? I have choosen Change I1e6f787d to experiment with, which is a nice oneliner. Some guy have changed an email address in a comment to his own. I believe reviewing means I should take a look at the patch to ensure that it is up to the standards. Well, I don't know the standards still, but as it is in the same form as the previous, I would think it is. so my verdict here is PASS. Also I believe verifying normally means testing the patch. But in this case maybe verifying the authenticity of the contact change would be the correct way. So I write an email to the old guy, and to the email address in the same source code which is from the same domain, and to some guy I guess is associated with the driver in question. If any one says yes and none says no, then I will push the verify button. Is it what someone supposed to do with this gerrit thingie? ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] gerrit - howto?
Hello, Le 23 mars 2012 21:53, Magosányi, Árpád m4g...@gmail.com a écrit : I have registered to gerrit, because saying stuff is one thing, doing it is another. I guess I am supposed to verify and/or review. Which is what, and how? I have choosen Change I1e6f787d to experiment with, which is a nice oneliner. Some guy have changed an email address in a comment to his own. I believe reviewing means I should take a look at the patch to ensure that it is up to the standards. Well, I don't know the standards still, but as it is in the same form as the previous, I would think it is. so my verdict here is PASS. Also I believe verifying normally means testing the patch. But in this case maybe verifying the authenticity of the contact change would be the correct way. So I write an email to the old guy, and to the email address in the same source code which is from the same domain, and to some guy I guess is associated with the driver in question. If any one says yes and none says no, then I will push the verify button. Is it what someone supposed to do with this gerrit thingie? I think you are doing the good thing. Thanks. For the others, the patch Árpád refers to is discussed at https://www.opensc-project.org/codereview/#/c/252/ I encourage every user of the opensc-devel list to: - create a gerrit account - subscribe to the Email notifications. Go in Settings - Watched Projects and check the 3 notifications boxes for the OpenSC project - review patches and add comments I was not subscribed to the notifications at the beginning and then missed a lot of patch submissions. If you want to follow the OpenSC development is very important to subscribe to gerrit notifications (I think). Regards, -- Dr. Ludovic Rousseau ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
