Re: Revised DOS patch for openssl-0.9.7

[Corinna Vinschen]

On Sat, Apr 20, 2002 at 03:09:18PM -0700, Doug Kaufman wrote:
> Here is a revised patch for DOS (and other platforms that don't
> support symbolic links). With this patch openssl-0.9.7 snapshot from
> 19 April 2002 compiles without problems. Make test show no errors,
> except inability to load 'random state' (related to no built-in
> method of gathering entropy). I also built on Cygwin 1.3.2 with the
> patch applied. Make and "make test" show no problems. The DJGPP build
> was configured with "no-threads no-idea no-rc5". Cygwin build was
> configured with "no-idea no-rc5".
>   Doug

I don't understand what this patch has to do with Cygwin since Cygwin
supports symbolc links since years now.  Could you explain, please?

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Richard Levitte - VMS Whacker]

In message <[EMAIL PROTECTED]> on Sun, 21 Apr 2002 00:42:24 
+0200, Corinna Vinschen <[EMAIL PROTECTED]> said:

vinschen> I don't understand what this patch has to do with Cygwin since Cygwin
vinschen> supports symbolc links since years now.  Could you explain, please?

Note that Doug's changes shouldn't affect CygWin in that case.  I
believe that he mentioned CygWin to mean "it didn't get broken by what
I did".

-- 
Richard Levitte   \ Spannvägen 38, II \ [EMAIL PROTECTED]
Redakteur@Stacken  \ S-168 35  BROMMA  \ T: +46-8-26 52 47
\  SWEDEN   \ or +46-708-26 53 44
Procurator Odiosus Ex Infernis-- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/

Unsolicited commercial email is subject to an archival fee of $400.
See  for more info.
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Corinna Vinschen]

On Sun, Apr 21, 2002 at 12:53:06AM +0200, Richard Levitte - VMS Whacker wrote:
> In message <[EMAIL PROTECTED]> on Sun, 21 Apr 2002 00:42:24 
>+0200, Corinna Vinschen <[EMAIL PROTECTED]> said:
> 
> vinschen> I don't understand what this patch has to do with Cygwin since Cygwin
> vinschen> supports symbolc links since years now.  Could you explain, please?
> 
> Note that Doug's changes shouldn't affect CygWin in that case.  I
> believe that he mentioned CygWin to mean "it didn't get broken by what
> I did".

I see.  Thanks for the explanation,

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Doug Kaufman]

On Sun, 21 Apr 2002, Richard Levitte - VMS Whacker wrote:

> In message <[EMAIL PROTECTED]> on Sun, 21 Apr 2002 00:42:24 
>+0200, Corinna Vinschen <[EMAIL PROTECTED]> said:
> 
> vinschen> I don't understand what this patch has to do with Cygwin since Cygwin
> vinschen> supports symbolc links since years now.  Could you explain, please?
> 
> Note that Doug's changes shouldn't affect CygWin in that case.  I
> believe that he mentioned CygWin to mean "it didn't get broken by what
> I did".

Sorry I wasn't more clear. That is exactly what I meant. This was at
least one platform whose build was not broken by my proposed patch.
 Doug
__ 
Doug Kaufman
Internet: [EMAIL PROTECTED]

__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Corinna Vinschen]

On Sun, Apr 21, 2002 at 12:42:24AM +0200, Corinna Vinschen wrote:
> On Sat, Apr 20, 2002 at 03:09:18PM -0700, Doug Kaufman wrote:
> > Here is a revised patch for DOS (and other platforms that don't
> > support symbolic links). With this patch openssl-0.9.7 snapshot from
> > 19 April 2002 compiles without problems. Make test show no errors,
> > except inability to load 'random state' (related to no built-in
> > method of gathering entropy). I also built on Cygwin 1.3.2 with the
> > patch applied. Make and "make test" show no problems. The DJGPP build
> > was configured with "no-threads no-idea no-rc5". Cygwin build was
> > configured with "no-idea no-rc5".
> >   Doug
> 
> I don't understand what this patch has to do with Cygwin since Cygwin
> supports symbolc links since years now.  Could you explain, please?

Oh and, btw., current Cygwin is 1.3.10, 1.3.11 coming soon.  Why are
you testing with a version which is almost a year old?

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Doug Kaufman]

On Sun, 21 Apr 2002, Corinna Vinschen wrote:

> Oh and, btw., current Cygwin is 1.3.10, 1.3.11 coming soon.  Why are
> you testing with a version which is almost a year old?

It was just what was installed on my machine. I hadn't updated in a
while. Thanks for the reminder. I am now at 1.3.10.
Doug
__ 
Doug Kaufman
Internet: [EMAIL PROTECTED]

__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Lutz Jaenicke]

On Sun, Apr 21, 2002 at 11:40:56AM -0700, Doug Kaufman wrote:
> On Sun, 21 Apr 2002, Corinna Vinschen wrote:
> 
> > Oh and, btw., current Cygwin is 1.3.10, 1.3.11 coming soon.  Why are
> > you testing with a version which is almost a year old?
> 
> It was just what was installed on my machine. I hadn't updated in a
> while. Thanks for the reminder. I am now at 1.3.10.

Does it work now without your patches?
Lutz
-- 
Lutz Jaenicke [EMAIL PROTECTED]
http://www.aet.TU-Cottbus.DE/personen/jaenicke/
BTU Cottbus, Allgemeine Elektrotechnik
Universitaetsplatz 3-4, D-03044 Cottbus
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Richard Levitte - VMS Whacker]

In message <[EMAIL PROTECTED]> on Sun, 21 Apr 2002 
21:06:16 +0200, Lutz Jaenicke <[EMAIL PROTECTED]> said:

Lutz.Jaenicke> On Sun, Apr 21, 2002 at 11:40:56AM -0700, Doug Kaufman wrote:
Lutz.Jaenicke> > It was just what was installed on my machine. I hadn't updated in a
Lutz.Jaenicke> > while. Thanks for the reminder. I am now at 1.3.10.
Lutz.Jaenicke> 
Lutz.Jaenicke> Does it work now without your patches?

I'd be surprised if it didn't, since Doug's patches aren't really
about VygWin...

-- 
Richard Levitte   \ Spannvägen 38, II \ [EMAIL PROTECTED]
Redakteur@Stacken  \ S-168 35  BROMMA  \ T: +46-8-26 52 47
\  SWEDEN   \ or +46-708-26 53 44
Procurator Odiosus Ex Infernis-- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/

Unsolicited commercial email is subject to an archival fee of $400.
See  for more info.
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Doug Kaufman]

On Sun, 21 Apr 2002, Lutz Jaenicke wrote:

> On Sun, Apr 21, 2002 at 11:40:56AM -0700, Doug Kaufman wrote:
> > On Sun, 21 Apr 2002, Corinna Vinschen wrote:
> > 
> > > Oh and, btw., current Cygwin is 1.3.10, 1.3.11 coming soon.  Why are
> > > you testing with a version which is almost a year old?
> > 
> > It was just what was installed on my machine. I hadn't updated in a
> > while. Thanks for the reminder. I am now at 1.3.10.
> 
> Does it work now without your patches?

Actually, no. There are problems with the Cygwin build without
the patch. I checked this for 0.9.7 19 April 2002 snapshot using
"Configure no-idea no-rc5 Cygwin" and also with "config no-idea
no-rc5". Both stop with the same errors. The first problem is that
without the patch, the idea.h file is not linked to include/openssl.
It is not needed for the compile, since OPENSSL_NO_IDEA is defined,
but it is listed in the depends section of the makefile, and stops the
compile with an error. The lines from the log files are long. I hope
that they are readable via email. I can send as attachments if they
don't come through OK.

> gcc -I.. -I../.. -I../../include -DOPENSSL_SYSNAME_CYGWIN32 -DOPENSSL_THREADS  
>-DDSO_WIN32 -DOPENSSL_NO_KRB5 -DOPENSSL_NO_IDEA -DOPENSSL_NO_RC5 -DTERMIOS -DL_ENDIAN 
>-fomit-frame-pointer -O3 -m486 -Wall   -c -o e_bf.o e_bf.c
> make[2]: *** No rule to make target `../../include/openssl/idea.h', needed by 
>`e_idea.o'.  Stop.
> make[2]: Leaving directory 
>`/d/CYGWIN/ssl097-0419/openssl-0.9.7-stable-SNAP-20020419/crypto/evp'
> make[1]: *** [subdirs] Error 1
> make[1]: Leaving directory 
>`/d/CYGWIN/ssl097-0419/openssl-0.9.7-stable-SNAP-20020419/crypto'
> make: *** [sub_all] Error 1

This problem can be fixed by running "make depend". After running "make
depend", the next error is due to lack of "bn_sub_part_words". This was
addressed in my patch for both DJGPP and Cygwin.

> if [ "cygwin-shared" = "hpux-shared" ] ; then \
>   gcc -o openssl -DMONOLITH -I.. -I../include  -DOPENSSL_SYSNAME_CYGWIN32 
>-DOPENSSL_THREADS  -DDSO_WIN32 -DOPENSSL_NO_KRB5 -DOPENSSL_NO_IDEA -DOPENSSL_NO_RC5 
>-DTERMIOS -DL_ENDIAN -fomit-frame-pointer -O3 -m486 -Wall openssl.o verify.o 
>asn1pars.o req.o dgst.o dh.o dhparam.o enc.o passwd.o gendh.o errstr.o ca.o pkcs7.o 
>crl2p7.o crl.o rsa.o rsautl.o dsa.o dsaparam.o x509.o genrsa.o gendsa.o s_server.o 
>s_client.o speed.o s_time.o apps.o s_cb.o s_socket.o app_rand.o version.o sess_id.o 
>ciphers.o nseq.o pkcs12.o pkcs8.o spkac.o smime.o rand.o engine.o ocsp.o  ../libssl.a 
> ../libcrypto.a  ; \
> else \
>   gcc -o openssl -DMONOLITH -I.. -I../include  -DOPENSSL_SYSNAME_CYGWIN32 
>-DOPENSSL_THREADS  -DDSO_WIN32 -DOPENSSL_NO_KRB5 -DOPENSSL_NO_IDEA -DOPENSSL_NO_RC5 
>-DTERMIOS -DL_ENDIAN -fomit-frame-pointer -O3 -m486 -Wall openssl.o verify.o 
>asn1pars.o req.o dgst.o dh.o dhparam.o enc.o passwd.o gendh.o errstr.o ca.o pkcs7.o 
>crl2p7.o crl.o rsa.o rsautl.o dsa.o dsaparam.o x509.o genrsa.o gendsa.o s_server.o 
>s_client.o speed.o s_time.o apps.o s_cb.o s_socket.o app_rand.o version.o sess_id.o 
>ciphers.o nseq.o pkcs12.o pkcs8.o spkac.o smime.o rand.o engine.o ocsp.o  -L.. -lssl  
>-L.. -lcrypto  ; \
> fi
> ../libcrypto.a(bn_mul.o)(.text+0x44b):bn_mul.c: undefined reference to 
>`bn_sub_part_words'
> ../libcrypto.a(bn_mul.o)(.text+0x49d):bn_mul.c: undefined reference to 
>`bn_sub_part_words'
> ../libcrypto.a(bn_mul.o)(.text+0x4c5):bn_mul.c: undefined reference to 
>`bn_sub_part_words'
> ../libcrypto.a(bn_mul.o)(.text+0x4f5):bn_mul.c: undefined reference to 
>`bn_sub_part_words'
> ../libcrypto.a(bn_mul.o)(.text+0x525):bn_mul.c: undefined reference to 
>`bn_sub_part_words'
> ../libcrypto.a(bn_mul.o)(.text+0x55d):bn_mul.c: more undefined references to 
>`bn_sub_part_words' follow
> collect2: ld returned 1 exit status
> make[1]: *** [openssl] Error 1
> make[1]: Leaving directory 
>`/d/CYGWIN/ssl097-0419/openssl-0.9.7-stable-SNAP-20020419/apps'
> make: *** [sub_all] Error 1

I don't know what others did to get Cygwin to compile without problems
without the patch. I believe Corinna Vinschen was able to compile
successfully. I would be interested in learning what caused the
different outcomes of our attempts. These latest compiles were done
with Cygwin 1.3.10-1, bash 2.05a-3, and binutils 20011002-1.

I haven't yet tested 0.9.6d-beta1 without the patch under Cygwin.
Doug
__ 
Doug Kaufman
Internet: [EMAIL PROTECTED]


__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Doug Kaufman]

On Sun, 21 Apr 2002, Doug Kaufman wrote:

> On Sun, 21 Apr 2002, Lutz Jaenicke wrote:
> 
> > On Sun, Apr 21, 2002 at 11:40:56AM -0700, Doug Kaufman wrote:
> > > On Sun, 21 Apr 2002, Corinna Vinschen wrote:
> > > 
> > > > Oh and, btw., current Cygwin is 1.3.10, 1.3.11 coming soon.  Why are
> > > > you testing with a version which is almost a year old?
> > Does it work now without your patches?
> ... 
> I haven't yet tested 0.9.6d-beta1 without the patch under Cygwin.

I just finished testing 0.9.6d-beta1 under Cygwin without my patch
applied. It compiles without problem and "make test" shows no errors.
It seems the only problem I find with the Cygwin compile is with
the snapshot of 0.9.7 (and that is fixed by my patch for 0.9.7).
0.9.6d-beta1 was compiled with GCC 2.95.3-4, Cygwin 1.3.10-1,
bash 2.05a-3, and binutils 20011002-1.
Doug
__ 
Doug Kaufman
Internet: [EMAIL PROTECTED]

__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Richard Levitte - VMS Whacker]

In message <[EMAIL PROTECTED]> on Sun, 21 Apr 
2002 22:20:53 -0700 (PDT), Doug Kaufman <[EMAIL PROTECTED]> said:

dkaufman> > gcc -I.. -I../.. -I../../include -DOPENSSL_SYSNAME_CYGWIN32 
-DOPENSSL_THREADS  -DDSO_WIN32 -DOPENSSL_NO_KRB5 -DOPENSSL_NO_IDEA -DOPENSSL_NO_RC5 
-DTERMIOS -DL_ENDIAN -fomit-frame-pointer -O3 -m486 -Wall   -c -o e_bf.o e_bf.c
dkaufman> > make[2]: *** No rule to make target `../../include/openssl/idea.h', needed 
by `e_idea.o'.  Stop.
dkaufman> > make[2]: Leaving directory 
`/d/CYGWIN/ssl097-0419/openssl-0.9.7-stable-SNAP-20020419/crypto/evp'
dkaufman> > make[1]: *** [subdirs] Error 1
dkaufman> > make[1]: Leaving directory 
`/d/CYGWIN/ssl097-0419/openssl-0.9.7-stable-SNAP-20020419/crypto'
dkaufman> > make: *** [sub_all] Error 1
dkaufman> 
dkaufman> This problem can be fixed by running "make depend".

Not just "can be fixed".  That is what you have to do when you have
changed the configuration, period.

dkaufman> After running "make depend", the next error is due to lack
dkaufman> of "bn_sub_part_words". This was addressed in my patch for
dkaufman> both DJGPP and Cygwin. 

Ah, so that's what that is about.

Tell me something, do you get those same errors when you configure
without excluding any algorithm (basically, just a plain "./config")?
If not, it might be worth looking into what gets different with the
exclusions...

-- 
Richard Levitte   \ Spannvägen 38, II \ [EMAIL PROTECTED]
Redakteur@Stacken  \ S-168 35  BROMMA  \ T: +46-8-26 52 47
\  SWEDEN   \ or +46-708-26 53 44
Procurator Odiosus Ex Infernis-- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/

Unsolicited commercial email is subject to an archival fee of $400.
See  for more info.
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Doug Kaufman]

On Mon, 22 Apr 2002, Richard Levitte - VMS Whacker wrote:

> Not just "can be fixed".  That is what you have to do when you have
> changed the configuration, period.

The patch I submitted got around the problem by making the header files
available even when the algorithm was excluded, so "make depend" wasn't
needed. I would think that if we want the configure script to be robust,
and you want "make depend" to be run, we should uncomment the "make
depend" line in Configure (line 1419 in 0.9.7).
  
> dkaufman> After running "make depend", the next error is due to lack
> dkaufman> of "bn_sub_part_words". This was addressed in my patch for
> dkaufman> both DJGPP and Cygwin. 
> 
> Ah, so that's what that is about.
> 
> Tell me something, do you get those same errors when you configure
> without excluding any algorithm (basically, just a plain "./config")?
> If not, it might be worth looking into what gets different with the
> exclusions...

I've never tried compiling with all algorithms included. I'll try to
make a compilation tomorrow.
  Doug
__ 
Doug Kaufman
Internet: [EMAIL PROTECTED]

__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Corinna Vinschen]

On Mon, Apr 22, 2002 at 08:21:42AM +0200, Richard Levitte - VMS Whacker wrote:
> dkaufman> After running "make depend", the next error is due to lack
> dkaufman> of "bn_sub_part_words". This was addressed in my patch for
> dkaufman> both DJGPP and Cygwin. 
> 
> Ah, so that's what that is about.
> 
> Tell me something, do you get those same errors when you configure
> without excluding any algorithm (basically, just a plain "./config")?
> If not, it might be worth looking into what gets different with the
> exclusions...

This is for the current version as in CVS.  I did 

  make depend && ./config && make
  
on Cygwin and the above errors still strike:

gcc -o openssl -DMONOLITH -I.. -I../include  -DOPENSSL_SYSNAME_CYGWIN32 
-DOPENSSL_THREADS  -DDSO_WIN32 -DOPENSSL_NO_KRB5 -DTERMIOS -DL_ENDIAN 
-fomit-frame-pointer -O3 -m486 -Wall openssl.o verify.o asn1pars.o req.o dgst.o dh.o 
dhparam.o enc.o passwd.o gendh.o errstr.o ca.o pkcs7.o crl2p7.o crl.o rsa.o rsautl.o 
dsa.o dsaparam.o ecdsa.o ecdsaparam.o x509.o genrsa.o gendsa.o s_server.o s_client.o 
speed.o s_time.o apps.o s_cb.o s_socket.o app_rand.o version.o sess_id.o ciphers.o 
nseq.o pkcs12.o pkcs8.o spkac.o smime.o rand.o engine.o ocsp.o  -L.. -lssl  -L.. 
-lcrypto  ; \
fi
../libcrypto.a(bn_mul.o)(.text+0x44b):bn_mul.c: undefined reference to 
`bn_sub_part_words'
[...]

so it's pretty generic.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Corinna Vinschen]

On Mon, Apr 22, 2002 at 10:11:08AM +0200, Corinna Vinschen wrote:
> gcc -o openssl -DMONOLITH -I.. -I../include  -DOPENSSL_SYSNAME_CYGWIN32 
>-DOPENSSL_THREADS  -DDSO_WIN32 -DOPENSSL_NO_KRB5 -DTERMIOS -DL_ENDIAN 
>-fomit-frame-pointer -O3 -m486 -Wall openssl.o verify.o asn1pars.o req.o dgst.o dh.o 
>dhparam.o enc.o passwd.o gendh.o errstr.o ca.o pkcs7.o crl2p7.o crl.o rsa.o rsautl.o 
>dsa.o dsaparam.o ecdsa.o ecdsaparam.o x509.o genrsa.o gendsa.o s_server.o s_client.o 
>speed.o s_time.o apps.o s_cb.o s_socket.o app_rand.o version.o sess_id.o ciphers.o 
>nseq.o pkcs12.o pkcs8.o spkac.o smime.o rand.o engine.o ocsp.o  -L.. -lssl  -L.. 
>-lcrypto  ; \
> fi
> ../libcrypto.a(bn_mul.o)(.text+0x44b):bn_mul.c: undefined reference to 
>`bn_sub_part_words'
> [...]
> 
> so it's pretty generic.

The problem is line 61 in crypto/bn/bn_mul.c:

  #if defined(OPENSSL_NO_ASM) || !(defined(__i386) || defined(__i386__))/* ...

This is used to decide if `bn_sub_part_words' should be defined or not.
Unfortunately this function doesn't exist in Cygwin but the __i386 and
__i386__ defines are set by gcc's config file.

Two questions:

- Why is the above `#if' used for bn_sub_part_words() but not for
  bn_add_part_words()?

- Should Cygwin always be build with "no-asm", perhaps?  Or would it
  make more sense to redefine the above `#if'?

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Doug Kaufman]

On Mon, 22 Apr 2002, Corinna Vinschen wrote:

> > ../libcrypto.a(bn_mul.o)(.text+0x44b):bn_mul.c: undefined reference to 
>`bn_sub_part_words'
> > [...]
> > 
> > so it's pretty generic.
> 
> The problem is line 61 in crypto/bn/bn_mul.c:
> 
>   #if defined(OPENSSL_NO_ASM) || !(defined(__i386) || defined(__i386__))/* ...

I also built 0.9.7 under Cygwin, as "./Configure Cygwin", then "make"
and get the same error. See a fix in previously submitted patch.
  Doug
__ 
Doug Kaufman
Internet: [EMAIL PROTECTED]

__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Revised DOS patch for openssl-0.9.7

[Corinna Vinschen]

On Mon, Apr 22, 2002 at 07:51:27AM -0700, Doug Kaufman wrote:
> On Mon, 22 Apr 2002, Corinna Vinschen wrote:
> 
> > > ../libcrypto.a(bn_mul.o)(.text+0x44b):bn_mul.c: undefined reference to 
>`bn_sub_part_words'
> > > [...]
> > > 
> > > so it's pretty generic.
> > 
> > The problem is line 61 in crypto/bn/bn_mul.c:
> > 
> >   #if defined(OPENSSL_NO_ASM) || !(defined(__i386) || defined(__i386__))/* ...
> 
> I also built 0.9.7 under Cygwin, as "./Configure Cygwin", then "make"
> and get the same error. See a fix in previously submitted patch.

Oh, sorry, I've missed that part of the patch.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

[openssl.org #12] Re: Revised DOS patch for openssl-0.9.7

[Richard Levitte via RT]

Hmm, out of curiosity, Ulf Moeller made a change to Configure 
(revisions 1.328 and 1.314.2.12) that affects Cygwin.  Could it be 
that his change fixes this problem?

Note that I haven't addressed the DJGPP issue yet, only Cygwin.

[jaenicke - Thu Apr 25 17:31:12 2002]:

> [[EMAIL PROTECTED] - Thu Apr 25 17:27:59 2002]:
> 
> > The only problem in Cygwin so far is that it defines __i386 but
> > it has no bn_sub_part_words() defined, though.  So it needs the
> > C implementation in crypto/bn/bn_mul.c.  Doug's patch contains
> > the following hunk:
> > 
> > --- openssl-0.9.7/crypto/bn/bn_mul.c.orig   Sun Oct 14 
00:57:16
> > 2001
> > +++ openssl-0.9.7/crypto/bn/bn_mul.cThu Apr 18 18:42:26 2002
> > @@ -66,7 +66,7 @@
> >  #include "cryptlib.h"
> >  #include "bn_lcl.h"
> > 
> > -#if defined(OPENSSL_NO_ASM) || !(defined(__i386) ||
> > defined(__i386__))/* Assembler implementation exists only for 
x86 */
> > +#if defined(OPENSSL_NO_ASM) || !(defined(__i386) ||
> > defined(__i386__)) || defined(__DJGPP__) ||
> > defined(OPENSSL_SYSNAME_CYGWIN32) /* Assembler implementation 
exists
> > only for x86 */
> >  /* Here follows specialised variants of bn_add_words() and
> > bn_sub_words().  They have the property performing 
operations on
> > arrays of different sizes.  The sizes of those arrays is 
expressed
> > through
> > 
> > which solves the problem for Cygwin (and probably DJGPP).
> 
> Thanks. We have to tidy up for 0.9.7...


-- 
Richard Levitte
[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

[openssl.org #12] Re: Revised DOS patch for openssl-0.9.7

[Richard Levitte via RT]

[levitte - Thu May 30 08:00:40 2002]:

> Hmm, out of curiosity, Ulf Moeller made a change to Configure
> (revisions 1.328 and 1.314.2.12) that affects Cygwin.  Could it be
> that his change fixes this problem?

[EMAIL PROTECTED] just confirmed that Cygwin now has no problems.

> Note that I haven't addressed the DJGPP issue yet, only Cygwin.

I'd like to know what state the DJGPP support is at right now.  
Since the large patch for DJGPP support that was sent to openssl-dev 
some time ago never made it into the ticket database, I'm a bit 
unsure about what to do with it.

I suggest that the patch for DJGPP support gets resubmitted if 
nedded, so it can make it's way into our ticket database.  This 
ticket will change state to "resolved".

> 
> [jaenicke - Thu Apr 25 17:31:12 2002]:
> 
> > [[EMAIL PROTECTED] - Thu Apr 25 17:27:59 2002]:
> >
> > > The only problem in Cygwin so far is that it defines __i386 but
> > > it has no bn_sub_part_words() defined, though.  So it needs the
> > > C implementation in crypto/bn/bn_mul.c.  Doug's patch contains
> > > the following hunk:
> > >
> > > --- openssl-0.9.7/crypto/bn/bn_mul.c.orig   Sun Oct 14
> 00:57:16
> > > 2001
> > > +++ openssl-0.9.7/crypto/bn/bn_mul.cThu Apr 18 18:42:26 
2002
> > > @@ -66,7 +66,7 @@
> > >  #include "cryptlib.h"
> > >  #include "bn_lcl.h"
> > >
> > > -#if defined(OPENSSL_NO_ASM) || !(defined(__i386) ||
> > > defined(__i386__))/* Assembler implementation exists only for
> x86 */
> > > +#if defined(OPENSSL_NO_ASM) || !(defined(__i386) ||
> > > defined(__i386__)) || defined(__DJGPP__) ||
> > > defined(OPENSSL_SYSNAME_CYGWIN32) /* Assembler implementation
> exists
> > > only for x86 */
> > >  /* Here follows specialised variants of bn_add_words() and
> > > bn_sub_words().  They have the property performing
> operations on
> > > arrays of different sizes.  The sizes of those arrays is
> expressed
> > > through
> > >
> > > which solves the problem for Cygwin (and probably DJGPP).
> >
> > Thanks. We have to tidy up for 0.9.7...
> 


-- 
Richard Levitte
[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: [openssl.org #12] Re: Revised DOS patch for openssl-0.9.7

[Corinna Vinschen]

On Thu, May 30, 2002 at 08:00:43AM +0200, Richard Levitte via RT wrote:
> 
> Hmm, out of curiosity, Ulf Moeller made a change to Configure 
> (revisions 1.328 and 1.314.2.12) that affects Cygwin.  Could it be 
> that his change fixes this problem?

I'm getting the following message in link stage now when building
from current CVS:

gcc -shared -o cygcrypto.dll -Wl,-Bsymbolic -Wl,--whole-archive libcrypto.a -W
l,--out-implib,libcrypto.dll.a -Wl,--no-whole-archive -L.
libcrypto.a(bn86-out.o)(.text+0x738):bn-586.s: multiple definition of `bn_sub_pa
rt_words'
libcrypto.a(bn_mul.o)(.text+0x0):bn_mul.c: first defined here

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: [openssl.org #12] Re: Revised DOS patch for openssl-0.9.7

[Richard Levitte - VMS Whacker]

In message <[EMAIL PROTECTED]> on Thu, 30 May 2002 09:34:04 
+0200, Corinna Vinschen <[EMAIL PROTECTED]> said:

vinschen> On Thu, May 30, 2002 at 08:00:43AM +0200, Richard Levitte via RT wrote:
vinschen> > 
vinschen> > Hmm, out of curiosity, Ulf Moeller made a change to Configure 
vinschen> > (revisions 1.328 and 1.314.2.12) that affects Cygwin.  Could it be 
vinschen> > that his change fixes this problem?
vinschen> 
vinschen> I'm getting the following message in link stage now when building
vinschen> from current CVS:
vinschen> 
vinschen> gcc -shared -o cygcrypto.dll -Wl,-Bsymbolic -Wl,--whole-archive libcrypto.a 
-W
vinschen> l,--out-implib,libcrypto.dll.a -Wl,--no-whole-archive -L.
vinschen> libcrypto.a(bn86-out.o)(.text+0x738):bn-586.s: multiple definition of 
`bn_sub_pa
vinschen> rt_words'
vinschen> libcrypto.a(bn_mul.o)(.text+0x0):bn_mul.c: first defined here

Did you 'make clean'?

-- 
Richard Levitte   \ Spannvägen 38, II \ [EMAIL PROTECTED]
Redakteur@Stacken  \ S-168 35  BROMMA  \ T: +46-8-26 52 47
\  SWEDEN   \ or +46-708-26 53 44
Procurator Odiosus Ex Infernis-- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/

Unsolicited commercial email is subject to an archival fee of $400.
See  for more info.
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: [openssl.org #12] Re: Revised DOS patch for openssl-0.9.7

[Corinna Vinschen]

On Thu, May 30, 2002 at 10:30:10AM +0200, Richard Levitte - VMS Whacker wrote:
> vinschen> I'm getting the following message in link stage now when building
> vinschen> from current CVS:
> vinschen> 
> vinschen> gcc -shared -o cygcrypto.dll -Wl,-Bsymbolic -Wl,--whole-archive 
>libcrypto.a -W
> vinschen> l,--out-implib,libcrypto.dll.a -Wl,--no-whole-archive -L.
> vinschen> libcrypto.a(bn86-out.o)(.text+0x738):bn-586.s: multiple definition of 
>`bn_sub_pa
> vinschen> rt_words'
> vinschen> libcrypto.a(bn_mul.o)(.text+0x0):bn_mul.c: first defined here
> 
> Did you 'make clean'?

$ make clean
[...]
$ config --prefix=/usr shared no-idea no-rc5 no-mdc2
[...]
$ make
[...]

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: [openssl.org #12] Re: Revised DOS patch for openssl-0.9.7

[Richard Levitte - VMS Whacker]

In message <[EMAIL PROTECTED]> on Thu, 30 May 2002 11:01:53 
+0200, Corinna Vinschen <[EMAIL PROTECTED]> said:

vinschen> On Thu, May 30, 2002 at 10:30:10AM +0200, Richard Levitte - VMS Whacker 
wrote:
vinschen> > vinschen> I'm getting the following message in link stage now when building
vinschen> > vinschen> from current CVS:
vinschen> > vinschen> 
vinschen> > vinschen> gcc -shared -o cygcrypto.dll -Wl,-Bsymbolic -Wl,--whole-archive 
libcrypto.a -W
vinschen> > vinschen> l,--out-implib,libcrypto.dll.a -Wl,--no-whole-archive -L.
vinschen> > vinschen> libcrypto.a(bn86-out.o)(.text+0x738):bn-586.s: multiple 
definition of `bn_sub_pa
vinschen> > vinschen> rt_words'
vinschen> > vinschen> libcrypto.a(bn_mul.o)(.text+0x0):bn_mul.c: first defined here
vinschen> > 
vinschen> > Did you 'make clean'?
vinschen> 
vinschen> $ make clean
vinschen> [...]
vinschen> $ config --prefix=/usr shared no-idea no-rc5 no-mdc2
vinschen> [...]
vinschen> $ make
vinschen> [...]

And you're running with a fresh bn_mul.c, or does it implement
bn_sub_part_words() for Cygwin (i.e., do you have the proposed patch
applied)?

In bn_mul.c, line 69 should read like this:

#if defined(OPENSSL_NO_ASM) || !(defined(__i386) || defined(__i386__))/* Assembler 
implementation exists only for x86 */


-- 
Richard Levitte   \ Spannvägen 38, II \ [EMAIL PROTECTED]
Redakteur@Stacken  \ S-168 35  BROMMA  \ T: +46-8-26 52 47
\  SWEDEN   \ or +46-708-26 53 44
Procurator Odiosus Ex Infernis-- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/

Unsolicited commercial email is subject to an archival fee of $400.
See  for more info.


__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: [openssl.org #12] Re: Revised DOS patch for openssl-0.9.7

[Corinna Vinschen]

On Thu, May 30, 2002 at 11:33:42AM +0200, Richard Levitte - VMS Whacker wrote:
> In message <[EMAIL PROTECTED]> on Thu, 30 May 2002 11:01:53 
>+0200, Corinna Vinschen <[EMAIL PROTECTED]> said:
> 
> vinschen> On Thu, May 30, 2002 at 10:30:10AM +0200, Richard Levitte - VMS Whacker 
>wrote:
> vinschen> > vinschen> I'm getting the following message in link stage now when 
>building
> vinschen> > vinschen> from current CVS:
> vinschen> > vinschen> 
> vinschen> > vinschen> gcc -shared -o cygcrypto.dll -Wl,-Bsymbolic 
>-Wl,--whole-archive libcrypto.a -W
> vinschen> > vinschen> l,--out-implib,libcrypto.dll.a -Wl,--no-whole-archive -L.
> vinschen> > vinschen> libcrypto.a(bn86-out.o)(.text+0x738):bn-586.s: multiple 
>definition of `bn_sub_pa
> vinschen> > vinschen> rt_words'
> vinschen> > vinschen> libcrypto.a(bn_mul.o)(.text+0x0):bn_mul.c: first defined here
> vinschen> > 
> vinschen> > Did you 'make clean'?
> vinschen> 
> vinschen> $ make clean
> vinschen> [...]
> vinschen> $ config --prefix=/usr shared no-idea no-rc5 no-mdc2
> vinschen> [...]
> vinschen> $ make
> vinschen> [...]
> 
> And you're running with a fresh bn_mul.c, or does it implement
> bn_sub_part_words() for Cygwin (i.e., do you have the proposed patch
> applied)?
> 
> In bn_mul.c, line 69 should read like this:
> 
> #if defined(OPENSSL_NO_ASM) || !(defined(__i386) || defined(__i386__))/* Assembler 
>implementation exists only for x86 */

I'm sorry.  I had the patch applied.  Reverting to the above line
fixed my problem.  Now it builds fine on Cygwin.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: [openssl.org #12] Re: Revised DOS patch for openssl-0.9.7

[Richard Levitte - VMS Whacker]

In message <[EMAIL PROTECTED]> on Thu, 30 May 2002 13:33:51 
+0200, Corinna Vinschen <[EMAIL PROTECTED]> said:

Thank you!

vinschen> On Thu, May 30, 2002 at 11:33:42AM +0200, Richard Levitte - VMS Whacker 
wrote:
vinschen> > In message <[EMAIL PROTECTED]> on Thu, 30 May 2002 
11:01:53 +0200, Corinna Vinschen <[EMAIL PROTECTED]> said:
vinschen> > 
vinschen> > vinschen> On Thu, May 30, 2002 at 10:30:10AM +0200, Richard Levitte - VMS 
Whacker wrote:
vinschen> > vinschen> > vinschen> I'm getting the following message in link stage now 
when building
vinschen> > vinschen> > vinschen> from current CVS:
vinschen> > vinschen> > vinschen> 
vinschen> > vinschen> > vinschen> gcc -shared -o cygcrypto.dll -Wl,-Bsymbolic 
-Wl,--whole-archive libcrypto.a -W
vinschen> > vinschen> > vinschen> l,--out-implib,libcrypto.dll.a 
-Wl,--no-whole-archive -L.
vinschen> > vinschen> > vinschen> libcrypto.a(bn86-out.o)(.text+0x738):bn-586.s: 
multiple definition of `bn_sub_pa
vinschen> > vinschen> > vinschen> rt_words'
vinschen> > vinschen> > vinschen> libcrypto.a(bn_mul.o)(.text+0x0):bn_mul.c: first 
defined here
vinschen> > vinschen> > 
vinschen> > vinschen> > Did you 'make clean'?
vinschen> > vinschen> 
vinschen> > vinschen> $ make clean
vinschen> > vinschen> [...]
vinschen> > vinschen> $ config --prefix=/usr shared no-idea no-rc5 no-mdc2
vinschen> > vinschen> [...]
vinschen> > vinschen> $ make
vinschen> > vinschen> [...]
vinschen> > 
vinschen> > And you're running with a fresh bn_mul.c, or does it implement
vinschen> > bn_sub_part_words() for Cygwin (i.e., do you have the proposed patch
vinschen> > applied)?
vinschen> > 
vinschen> > In bn_mul.c, line 69 should read like this:
vinschen> > 
vinschen> > #if defined(OPENSSL_NO_ASM) || !(defined(__i386) || defined(__i386__))/* 
Assembler implementation exists only for x86 */
vinschen> 
vinschen> I'm sorry.  I had the patch applied.  Reverting to the above line
vinschen> fixed my problem.  Now it builds fine on Cygwin.

-- 
Richard Levitte   \ Spannvägen 38, II \ [EMAIL PROTECTED]
Redakteur@Stacken  \ S-168 35  BROMMA  \ T: +46-8-26 52 47
\  SWEDEN   \ or +46-708-26 53 44
Procurator Odiosus Ex Infernis-- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/

Unsolicited commercial email is subject to an archival fee of $400.
See  for more info.
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: [openssl.org #12] Re: Revised DOS patch for openssl-0.9.7

[Doug Kaufman]

On Thu, 30 May 2002, Richard Levitte via RT wrote:

> I'd like to know what state the DJGPP support is at right now.  
> Since the large patch for DJGPP support that was sent to openssl-dev 
> some time ago never made it into the ticket database, I'm a bit 
> unsure about what to do with it.
> 
> I suggest that the patch for DJGPP support gets resubmitted if 
> nedded, so it can make it's way into our ticket database.  This 
> ticket will change state to "resolved".

I'll try to review the patch this weekend and resubmit. I presume
you mean the patch for 0.9.7, or would you like the patch for 0.9.6
resubmitted also? Thanks.
  Doug
__ 
Doug Kaufman
Internet: [EMAIL PROTECTED]

__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: [openssl.org #12] Re: Revised DOS patch for openssl-0.9.7

[Richard Levitte - VMS Whacker]

In message <[EMAIL PROTECTED]> on Thu, 30 May 
2002 07:54:17 -0700 (PDT), Doug Kaufman <[EMAIL PROTECTED]> said:

dkaufman> I'll try to review the patch this weekend and resubmit. I presume
dkaufman> you mean the patch for 0.9.7, or would you like the patch for 0.9.6
dkaufman> resubmitted also? Thanks.

0.9.7.  Sorry, but as I recall, the change is too big to safely be
applied to 0.9.6.

-- 
Richard Levitte   \ Spannvägen 38, II \ [EMAIL PROTECTED]
Redakteur@Stacken  \ S-168 35  BROMMA  \ T: +46-8-26 52 47
\  SWEDEN   \ or +46-708-26 53 44
Procurator Odiosus Ex Infernis-- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/

Unsolicited commercial email is subject to an archival fee of $400.
See  for more info.
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]