Re: [Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4
For 2.6, I think we should drop openvpn-build for Windows (VS) building and switch to vcpkg for dependencies (openssl, lz4 etc) and cmake as a project file (also supported by VS). -- -Lev ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4
Hi, On Mon, Mar 22, 2021 at 07:29:30AM +, Simon Rozman wrote: > Thank you and Arne for explaining this. I should have followed > the discussion on the OpenVPN meetings. Unfortunately, my workload > doesn't allow me to follow on anything these days. So, I am not in > condition to prepare LZ4 building in openvpn-build/msvc either. Understood. Thanks for sending these patches anyway :-) > I can live with LZ4 disabled in my sandbox only. > > Shall we drop this patch for now? I have set it to "Rejected" (and the discussion is visible in patchwork). "It should not be so hard", so I'll try to talk Heiko / Arne / Lev into it :-) - might actually be easier than getting generic/build right for MinGW. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4
Hi,
> > Commit 24596b25 ("build: Remove compat-lz4") removed lz4 compat layer,
> > but openvpn-build\msvc doesn't provide LZ4 library either.
>
> What would be needed to actually *build* with LZ4 on MSVC? That is,
> build it as prerequisite as LZO is built?
>
> The idea wasn't to remove LZ4 from builds, just to remove the bundled
> LZ4 "because all platforms have it now, so we do not need to maintain
> our own copy". But it seems that was a bit shortsighted wrt windows
> building...
Thank you and Arne for explaining this. I should have followed the discussion
on the OpenVPN meetings. Unfortunately, my workload doesn't allow me to follow
on anything these days. So, I am not in condition to prepare LZ4 building in
openvpn-build/msvc either.
I can live with LZ4 disabled in my sandbox only.
Shall we drop this patch for now?
Regards, Simon
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4
Hi,
On Sun, Mar 21, 2021 at 03:46:23PM +0100, Simon Rozman via Openvpn-devel wrote:
> Commit 24596b25 ("build: Remove compat-lz4") removed lz4 compat layer,
> but openvpn-build\msvc doesn't provide LZ4 library either.
What would be needed to actually *build* with LZ4 on MSVC? That is,
build it as prerequisite as LZO is built?
The idea wasn't to remove LZ4 from builds, just to remove the bundled
LZ4 "because all platforms have it now, so we do not need to maintain
our own copy". But it seems that was a bit shortsighted wrt windows
building...
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4
Am 21.03.21 um 15:46 schrieb Simon Rozman via Openvpn-devel:
> Commit 24596b25 ("build: Remove compat-lz4") removed lz4 compat layer,
> but openvpn-build\msvc doesn't provide LZ4 library either.
We should either add lz4 to openvpn-build or change the default of lz4
to disabled in all variant. I don't like the idea that windows has a
different default than the other variants.
Arne
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH 1/5] MSVC: Disable LZ4
Commit 24596b25 ("build: Remove compat-lz4") removed lz4 compat layer,
but openvpn-build\msvc doesn't provide LZ4 library either.
Signed-off-by: Simon Rozman
---
config-msvc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/config-msvc.h b/config-msvc.h
index e430ca96..53d97902 100644
--- a/config-msvc.h
+++ b/config-msvc.h
@@ -9,7 +9,6 @@
#define ENABLE_FRAGMENT 1
#define ENABLE_HTTP_PROXY 1
#define ENABLE_LZO 1
-#define ENABLE_LZ4 1
#define ENABLE_MANAGEMENT 1
#define ENABLE_MULTIHOME 1
#define ENABLE_PKCS11 1
--
2.30.0.windows.2
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
