Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Robert Osfield
Hi Mourad,

On 15 May 2017 at 14:52, Mourad Boufarguine
 wrote:
> You're right we need both :
>
> COLLADA_BOOST_BUILDNAME : to follow boost naming convention with 3 digits
> for MSVC toolset version
> COLLADA_BUILDNAME : to follow collada naming convention with 1/2 digits for
> MSVC toolset version

I've been thinking along the same lines, I've refactored the
FindCOLLADA.cmake to use a combination of your and Toroben's versions,
the changes are :


diff --git a/CMakeModules/FindCOLLADA.cmake b/CMakeModules/FindCOLLADA.cmake
index f086069..5fb2cec 100644
--- a/CMakeModules/FindCOLLADA.cmake
+++ b/CMakeModules/FindCOLLADA.cmake
@@ -23,37 +23,38 @@ ELSE ()
 ENDIF()


-
-
-
 IF(APPLE)
 SET(COLLADA_BUILDNAME "mac")
-SET(COLLADA_BOOST_BUILDNAME "mac")
+  SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BUILDNAME})
 ELSEIF(MINGW)
 SET(COLLADA_BUILDNAME "mingw")
-SET(COLLADA_BOOST_BUILDNAME "mingw")
-ELSEIF(MSVC14)
+  SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BUILDNAME})
+ELSEIF(MSVC_VERSION EQUAL 1900 OR MSVC_VERSION EQUAL 1910 )
 SET(COLLADA_BUILDNAME "vc14")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSEIF(MSVC12)
+SET(COLLADA_BOOST_BUILDNAME "vc140")
+ELSEIF(MSVC_VERSION EQUAL 1800)
 SET(COLLADA_BUILDNAME "vc12")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSEIF(MSVC11)
+SET(COLLADA_BOOST_BUILDNAME "vc120")
+ELSEIF(MSVC_VERSION EQUAL 1700)
 SET(COLLADA_BUILDNAME "vc11")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSEIF(MSVC10)
+SET(COLLADA_BOOST_BUILDNAME "vc110")
+ELSEIF(MSVC_VERSION EQUAL 1600)
 SET(COLLADA_BUILDNAME "vc10")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSEIF(MSVC90)
+SET(COLLADA_BOOST_BUILDNAME "vc100")
+ELSEIF(MSVC_VERSION EQUAL 1500)
 SET(COLLADA_BUILDNAME "vc9")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSEIF(MSVC80)
+SET(COLLADA_BOOST_BUILDNAME "vc90")
+ELSEIF(MSVC_VERSION EQUAL 1400)
 SET(COLLADA_BUILDNAME "vc8")
-string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
-ELSE(APPLE)
+SET(COLLADA_BOOST_BUILDNAME "vc80")
+ELSE()
   SET(COLLADA_BUILDNAME "linux")
-  SET(COLLADA_BOOST_BUILDNAME "linux")
-ENDIF(APPLE)
+  SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BUILDNAME})
+ENDIF()
+
+IF(${CMAKE_VS_PLATFORM_TOOLSET})
+string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
+ENDIF()


I have now checked this into git master, I'd appreciate testing out
under Windows, fingers crossed we are getting a bit closer.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Mourad Boufarguine
You're right we need both :

COLLADA_BOOST_BUILDNAME : to follow boost naming convention with 3 digits
for MSVC toolset version
COLLADA_BUILDNAME : to follow collada naming convention with 1/2 digits for
MSVC toolset version

On Mon, May 15, 2017 at 3:32 PM, Robert Osfield 
wrote:

> Hi Mourad,
>
> On 15 May 2017 at 14:16, Mourad Boufarguine
>  wrote:
> > You are missing the ending 0s.
>
> I was just following Torben's usage, if we add back the 0's then the
> search names would change.  I presume this is why Torben introduced
> using two variables COLLADA_BUILDNAME & COLLADA_BOOST_BUILDNAME.
>
> > By the way the MSVCXX vars are discouraged (there is no var defined
> starting
> > from Visual 2017), MSVC_VERSION is the recommended way now :
> > https://cmake.org/cmake/help/v3.8/variable/MSVC14.html?highlight=msvc14
> >
> > IF(APPLE)
> > SET(COLLADA_BUILDNAME "mac")
> > ELSEIF(MINGW)
> > SET(COLLADA_BUILDNAME "mingw")
> > ELSEIF(MSVC_VERSION EQUAL 1900 OR MSVC_VERSION EQUAL 1910 )
> > SET(COLLADA_BUILDNAME "vc140")
> > ELSEIF(MSVC_VERSION EQUAL 1800)
> > SET(COLLADA_BUILDNAME "vc120")
> > ELSEIF(MSVC_VERSION EQUAL 1700)
> > SET(COLLADA_BUILDNAME "vc110")
> > ELSEIF(MSVC_VERSION EQUAL 1600)
> > SET(COLLADA_BUILDNAME "vc100")
> > ELSEIF(MSVC_VERSION EQUAL 1500)
> > SET(COLLADA_BUILDNAME "vc90")
> > ELSEIF(MSVC_VERSION EQUAL 1400)
> > SET(COLLADA_BUILDNAME "vc80")
> > ELSE()
> >   SET(COLLADA_BUILDNAME "linux")
> > ENDIF()
>
> Have you tested the above suggestion on your system?  I'm curious how
> things are working w.r.t Windows with COLLADA being installed.
>
> Hopefully Torben will join this thread as it's his changes that were
> meant to resolve building under Windows.
>
> Robert.
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Robert Osfield
Hi Mourad,

On 15 May 2017 at 14:16, Mourad Boufarguine
 wrote:
> You are missing the ending 0s.

I was just following Torben's usage, if we add back the 0's then the
search names would change.  I presume this is why Torben introduced
using two variables COLLADA_BUILDNAME & COLLADA_BOOST_BUILDNAME.

> By the way the MSVCXX vars are discouraged (there is no var defined starting
> from Visual 2017), MSVC_VERSION is the recommended way now :
> https://cmake.org/cmake/help/v3.8/variable/MSVC14.html?highlight=msvc14
>
> IF(APPLE)
> SET(COLLADA_BUILDNAME "mac")
> ELSEIF(MINGW)
> SET(COLLADA_BUILDNAME "mingw")
> ELSEIF(MSVC_VERSION EQUAL 1900 OR MSVC_VERSION EQUAL 1910 )
> SET(COLLADA_BUILDNAME "vc140")
> ELSEIF(MSVC_VERSION EQUAL 1800)
> SET(COLLADA_BUILDNAME "vc120")
> ELSEIF(MSVC_VERSION EQUAL 1700)
> SET(COLLADA_BUILDNAME "vc110")
> ELSEIF(MSVC_VERSION EQUAL 1600)
> SET(COLLADA_BUILDNAME "vc100")
> ELSEIF(MSVC_VERSION EQUAL 1500)
> SET(COLLADA_BUILDNAME "vc90")
> ELSEIF(MSVC_VERSION EQUAL 1400)
> SET(COLLADA_BUILDNAME "vc80")
> ELSE()
>   SET(COLLADA_BUILDNAME "linux")
> ENDIF()

Have you tested the above suggestion on your system?  I'm curious how
things are working w.r.t Windows with COLLADA being installed.

Hopefully Torben will join this thread as it's his changes that were
meant to resolve building under Windows.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Mourad Boufarguine
You are missing the ending 0s.
By the way the MSVCXX vars are discouraged (there is no var defined
starting from Visual 2017), MSVC_VERSION is the recommended way now :
https://cmake.org/cmake/help/v3.8/variable/MSVC14.html?highlight=msvc14

IF(APPLE)
SET(COLLADA_BUILDNAME "mac")
ELSEIF(MINGW)
SET(COLLADA_BUILDNAME "mingw")
ELSEIF(MSVC_VERSION EQUAL 1900 OR MSVC_VERSION EQUAL 1910 )
SET(COLLADA_BUILDNAME "vc140")
ELSEIF(MSVC_VERSION EQUAL 1800)
SET(COLLADA_BUILDNAME "vc120")
ELSEIF(MSVC_VERSION EQUAL 1700)
SET(COLLADA_BUILDNAME "vc110")
ELSEIF(MSVC_VERSION EQUAL 1600)
SET(COLLADA_BUILDNAME "vc100")
ELSEIF(MSVC_VERSION EQUAL 1500)
SET(COLLADA_BUILDNAME "vc90")
ELSEIF(MSVC_VERSION EQUAL 1400)
SET(COLLADA_BUILDNAME "vc80")
ELSE()
  SET(COLLADA_BUILDNAME "linux")
ENDIF()

On Mon, May 15, 2017 at 2:50 PM, Robert Osfield 
wrote:

> On 15 May 2017 at 13:08, Robert Osfield  wrote:
> > Looks like we'll need to rewrite this problem block for the case when
> > CMAKE_VS_PLATFORM_TOOLSET is not set.
> >
> > Don't yet know what this might be though...
>
> Would the following approach work better?
>
> -- Modified CMakeModues/FindCOLLADA.camke script :
>
> IF(APPLE)
> SET(COLLADA_BUILDNAME "mac")
> ELSEIF(MINGW)
> SET(COLLADA_BUILDNAME "mingw")
> ELSEIF(MSVC14)
> SET(COLLADA_BUILDNAME "vc14")
> ELSEIF(MSVC12)
> SET(COLLADA_BUILDNAME "vc12")
> ELSEIF(MSVC11)
> SET(COLLADA_BUILDNAME "vc11")
> ELSEIF(MSVC10)
> SET(COLLADA_BUILDNAME "vc10")
> ELSEIF(MSVC90)
> SET(COLLADA_BUILDNAME "vc9")
> ELSEIF(MSVC80)
> SET(COLLADA_BUILDNAME "vc8")
> ELSE()
>   SET(COLLADA_BUILDNAME "linux")
> ENDIF()
>
> SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BOOST_BUILDNAME})
>
> IF(${CMAKE_VS_PLATFORM_TOOLSET})
> string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
> ${CMAKE_VS_PLATFORM_TOOLSET})
> ENDIF()
>
> --
>
> I've moved the string(REPLACE...) lines into a single block wrapped in a
> check.
>
> Robert.
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Robert Osfield
On 15 May 2017 at 13:08, Robert Osfield  wrote:
> Looks like we'll need to rewrite this problem block for the case when
> CMAKE_VS_PLATFORM_TOOLSET is not set.
>
> Don't yet know what this might be though...

Would the following approach work better?

-- Modified CMakeModues/FindCOLLADA.camke script :

IF(APPLE)
SET(COLLADA_BUILDNAME "mac")
ELSEIF(MINGW)
SET(COLLADA_BUILDNAME "mingw")
ELSEIF(MSVC14)
SET(COLLADA_BUILDNAME "vc14")
ELSEIF(MSVC12)
SET(COLLADA_BUILDNAME "vc12")
ELSEIF(MSVC11)
SET(COLLADA_BUILDNAME "vc11")
ELSEIF(MSVC10)
SET(COLLADA_BUILDNAME "vc10")
ELSEIF(MSVC90)
SET(COLLADA_BUILDNAME "vc9")
ELSEIF(MSVC80)
SET(COLLADA_BUILDNAME "vc8")
ELSE()
  SET(COLLADA_BUILDNAME "linux")
ENDIF()

SET(COLLADA_BOOST_BUILDNAME ${COLLADA_BOOST_BUILDNAME})

IF(${CMAKE_VS_PLATFORM_TOOLSET})
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ENDIF()

--

I've moved the string(REPLACE...) lines into a single block wrapped in a check.

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Vanishing letters in osg::Text

2017-05-15 Thread Maxim Gammer
Here is the solution:

text->setFontResolution(18,18);



2017-04-25 17:13 GMT+05:00 Volckaert, Guy (CA - MTS) <
guy.volcka...@meggitt.com>:

> Hi,
>
> I'm using OSG v3.4.0 and I resolved this issue by adding a
> glTexParameteri( GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER,...) before calling
> glTexSubImage2D() in glyph.cpp. This problem was occurring if I was using
> an Intel video driver.
>
> void Glyph::subload() const
> {
> [...]
>
> // MTSI_BEGIN
> // This line was added to resolve a problem with intel chipsets. In
> essence, some of the
> // numeric glyphs would not display correctly. They would appear grey
> or transparent.
> if( getTexture() )
> {
> glTexParameteri( GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER,
> getTexture()->getFilter( osg::Texture::MIN_FILTER ) );
> }
> // MTSI_END
>
> glTexSubImage2D(GL_TEXTURE_2D,0,
> _texturePosX,_texturePosY,
> s(),t(),
> (GLenum)getPixelFormat(),
> (GLenum)getDataType(),
> data());
> [...]
> }
>
> void GlyphTexture::apply(osg::State& state) const
> {
> [...]
> // MTSI_BEGIN
> // This line was added to resolve a problem with intel
> chipsets. In essence, some of the
> // numeric glyphs would not display correctly. They would
> appear grey or transparent.
> glTexParameteri( GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER,
> _min_filter);
> // MTSI_END
> // Subload the image once
> glTexSubImage2D( GL_TEXTURE_2D, 0, 0, 0,
> getTextureWidth(),
> getTextureHeight(),
> OSGTEXT_GLYPH_FORMAT, GL_UNSIGNED_BYTE, local_data);
> [...]
> }
>
> Regards,
>
> -Original Message-
> From: osg-users [mailto:osg-users-boun...@lists.openscenegraph.org] On
> Behalf Of Tim Hartter
> Sent: April-25-17 7:29 AM
> To: OpenSceneGraph Users
> Subject: Re: [osg-users] Vanishing letters in osg::Text
>
> Setting OSG_TEXT_INCREMENTAL_SUBLOADING to off does not make a difference
> and YES it happens on Intel cards (not on Nvidia) (Win 7 OSG 3.4)
>
> Maybe the patched OSG text works better...
>
> Mit AquaMail Android
> http://www.aqua-mail.com gesendet
>
>
> Am 25. April 2017 10:18:21 vorm. schrieb Robert Osfield
> :
>
> > On 25 April 2017 at 06:34, Wouter Roos  wrote:
> >> I've experienced a similar issue lately where we were running a
> >> project on lower spec systems with only an integrated GPU. On those
> >> systems the frame rate would not show properly, having the same issue
> >> as described here, with some numbers not showing properly.
> >> I did a test on my laptop, and when I force it to use the integrated
> >> GPU
> >> (4600) the problems shows up as well. If I switch to use the GTX970M
> >> everything is fine again. This is all on Windows 10, osg 3.4.0 I
> >> haven't done any further investigation as the project is not using
> >> any Text objects, but maybe this might help somehow.
> >
> > Some hardware/drivers don't support texture sub-loading correctly so
> > the osgText subloading of new glyphs could cause problems, perhaps
> > this is what you are seeing.  It's problem that originally occurred on
> > Radeon's and some SGI hardware so there is a workaround in osgText
> > that detects these combinations in drivers, you can also enable the
> > workaround by setting the env var OSG_TEXT_INCREMENTAL_SUBLOADING to
> > OFF i.e. under bash you'd do:
> >
> >   export OSG_TEXT_INCREMENTAL_SUBLOADING=OFF
> >   osgtext
> >
> > Under windows I think it's something like:
> >
> >   set OSG_TEXT_INCREMENTAL_SUBLOADING=OFF
> >   osgtext
> >
> > The OSG master version has a had a major rewrite of osgText so it no
> > longer uses the texture subloading as may well just work out of the
> > box on the Intel GPU/drivers that you have.
> >
> > Robert.
> > ___
> > osg-users mailing list
> > osg-users@lists.openscenegraph.org
> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.
> > org
>
>
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
> 
>
>
> This e-mail may contain proprietary information and/or copyright material.
> This e-mail is intended for the use of the addressee only. Any unauthorized
> use may be unlawful. If you receive this e-mail by mistake, please advise
> the sender immediately by using the reply facility in your e-mail software.
>
> Information contained in and/or attached to this document may be subject
> to export control regulations of the European Community, USA, or other
> countries. Each recipient of this document is responsible to ensure that
> usage and/or transfer of any information contained in this document
> complies with all relevant export control 

Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Mourad Boufarguine
Hi Robert,

I think it is more correct to use the same logic (testing against the
compiler version CMAKE_CXX_COMPILER_VERSION  ) as in the mainstream
FindBoost.cmake :
https://github.com/Kitware/CMake/blob/master/Modules/FindBoost.cmake#L432-L453


Cheers,
Mourad

On Mon, May 15, 2017 at 2:08 PM, Robert Osfield 
wrote:

> Hi Mourad,
>
> On 15 May 2017 at 12:58, Mourad Boufarguine
>  wrote:
> > CMAKE_VS_PLATFORM_TOOLSET is not set unless the user explicitely
> specifies a
> > toolset when invoking cmake :
> >
> > cmake -G "Visual Studio XX" -T v1YY srcDir
> >
> > If the user does not specify a toolset, the default toolset of the chosen
> > Visual Studio version will be used, but the CMAKE_VS_PLATFORM_TOOLSET
> > variable will not be set, and this is what is causing the problem here.
>
> Thanks for the clarification.
>
> Looks like we'll need to rewrite this problem block for the case when
> CMAKE_VS_PLATFORM_TOOLSET is not set.
>
> Don't yet know what this might be though...
>
> Robert.
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Robert Osfield
Hi Mourad,

On 15 May 2017 at 12:58, Mourad Boufarguine
 wrote:
> CMAKE_VS_PLATFORM_TOOLSET is not set unless the user explicitely specifies a
> toolset when invoking cmake :
>
> cmake -G "Visual Studio XX" -T v1YY srcDir
>
> If the user does not specify a toolset, the default toolset of the chosen
> Visual Studio version will be used, but the CMAKE_VS_PLATFORM_TOOLSET
> variable will not be set, and this is what is causing the problem here.

Thanks for the clarification.

Looks like we'll need to rewrite this problem block for the case when
CMAKE_VS_PLATFORM_TOOLSET is not set.

Don't yet know what this might be though...

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Stuart Mentzer

Hi Robert (and Mourad),

I tried -T v140 but I still didn't seem to get that variable set, with or 
without the -G option. And note that I use MinGW makefiles even when building 
with MSVC so deducing partially from -G won't work right in that case anyway.

From this page 
(https://cmake.org/cmake/help/latest/variable/CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION.html)
 it looks like Windows 10 may do things a little differently (I'm on Win10).

I guess the discussion from 
http://forum.openscenegraph.org/viewtopic.php?t=16592 may not be fully resolved 
yet.

Cheers,
Stuart
--
Stuart Mentzer
Objexx Engineering
/Office/  +1 781 455 1150 x11
/Mobile/ +1 781 708 3872

On 5/15/2017 7:58 AM, Mourad Boufarguine wrote:

Hi Robert,

CMAKE_VS_PLATFORM_TOOLSET is not set unless the user explicitely specifies a 
toolset when invoking cmake :

cmake -G "Visual Studio XX" -T v1YY srcDir

If the user does not specify a toolset, the default toolset of the chosen 
Visual Studio version will be used, but the CMAKE_VS_PLATFORM_TOOLSET variable 
will not be set, and this is what is causing the problem here.

Cheers,
Mourad



On Mon, May 15, 2017 at 1:23 PM, Robert Osfield > wrote:

Hi Stuart,

On 15 May 2017 at 12:07, Stuart Mentzer > wrote:
> https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_PLATFORM_TOOLSET.html 

>
> Which mentons that it's set for VC10 and above. Torben uses the
> CMAKE_VS_PLATFORM_TOOLSET for vc8 and vc9 above, so I'm not what would
> happen here.
>
> What VC number is reported on your system?
>
> Visual C++ 2015 corresponds to MSVC14.

Looking at the CMake docs it would seem CMAKE_VS_PLATFORM_TOOLSET
should be defined, but given your error it would seem on your system
it's not.

Could you check whether CMAKE_VS_PLATFORM_TOOLSET is defined and what
it's value is?


> [Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015 
but
> the prev version builds OK]
>
> Is this a build error in curl, or the OSG plugin building against curl
> 7.54.0?
>
> It is in the curl build itself. Here is the bug report I filed:
> https://github.com/curl/curl/issues/1482 


OK, this isn't an OSG issue then so I can safely leave this to someone
else to resolve:-)

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org 

http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org 





___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Mourad Boufarguine
Hi Robert,

CMAKE_VS_PLATFORM_TOOLSET is not set unless the user explicitely specifies
a toolset when invoking cmake :

cmake -G "Visual Studio XX" -T v1YY srcDir

If the user does not specify a toolset, the default toolset of the chosen
Visual Studio version will be used, but the CMAKE_VS_PLATFORM_TOOLSET
variable will not be set, and this is what is causing the problem here.

Cheers,
Mourad



On Mon, May 15, 2017 at 1:23 PM, Robert Osfield 
wrote:

> Hi Stuart,
>
> On 15 May 2017 at 12:07, Stuart Mentzer  wrote:
> > https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_
> PLATFORM_TOOLSET.html
> >
> > Which mentons that it's set for VC10 and above.  Torben uses the
> > CMAKE_VS_PLATFORM_TOOLSET for vc8 and vc9 above, so I'm not what would
> > happen here.
> >
> > What VC number is reported on your system?
> >
> > Visual C++ 2015 corresponds to MSVC14.
>
> Looking at the CMake docs it would seem CMAKE_VS_PLATFORM_TOOLSET
> should be defined, but given your error it would seem on your system
> it's not.
>
> Could you check whether CMAKE_VS_PLATFORM_TOOLSET is defined and what
> it's value is?
>
>
> > [Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015
> but
> > the prev version builds OK]
> >
> > Is this a build error in curl, or the OSG plugin building against curl
> > 7.54.0?
> >
> > It is in the curl build itself. Here is the bug report I filed:
> > https://github.com/curl/curl/issues/1482
>
> OK, this isn't an OSG issue then so I can safely leave this to someone
> else to resolve:-)
>
> Robert.
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Robert Osfield
Hi Stuart,

On 15 May 2017 at 12:07, Stuart Mentzer  wrote:
> https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_PLATFORM_TOOLSET.html
>
> Which mentons that it's set for VC10 and above.  Torben uses the
> CMAKE_VS_PLATFORM_TOOLSET for vc8 and vc9 above, so I'm not what would
> happen here.
>
> What VC number is reported on your system?
>
> Visual C++ 2015 corresponds to MSVC14.

Looking at the CMake docs it would seem CMAKE_VS_PLATFORM_TOOLSET
should be defined, but given your error it would seem on your system
it's not.

Could you check whether CMAKE_VS_PLATFORM_TOOLSET is defined and what
it's value is?


> [Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015 but
> the prev version builds OK]
>
> Is this a build error in curl, or the OSG plugin building against curl
> 7.54.0?
>
> It is in the curl build itself. Here is the bug report I filed:
> https://github.com/curl/curl/issues/1482

OK, this isn't an OSG issue then so I can safely leave this to someone
else to resolve:-)

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Stuart Mentzer

Hi Robert,

On 5/15/2017 5:13 AM, Robert Osfield wrote:

Hi Stuart,

On 12 May 2017 at 14:32, Stuart Mentzer  wrote:

I always build from scratch in an empty build directory.

Thanks for the clarification.


Adding " around the 3rd and 4th args in the REPLACE lines did indeed
eliminate the error. Torben should check that this is still OK when the
Collada plugin is in use.

I'm currently looking at the changes and the error report, trying to
make sense of what is the root of the issue and how to resolve it.
Unfortunately I haven't heard from Torben yet so don't yet know what
his thoughts are.  Form what I understand Torben introduced the
COLLADA_BOOST_BUILDNAME to cope with variations under Windows related
to the platform tools set, hence the introduction of the
CMAKE_VS_PLATFORM_TOOLSET in the lines like:


ELSEIF(MSVC14)
 SET(COLLADA_BUILDNAME "vc14")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC12)
 SET(COLLADA_BUILDNAME "vc12")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC11)
 SET(COLLADA_BUILDNAME "vc11")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC10)
 SET(COLLADA_BUILDNAME "vc10")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC90)
 SET(COLLADA_BUILDNAME "vc9")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC80)
 SET(COLLADA_BUILDNAME "vc8")
 string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSE(APPLE)

CMaker docs for the CMAKE_VS_PLATFORM_TOOLSET} are:

 https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_PLATFORM_TOOLSET.html

Which mentons that it's set for VC10 and above.  Torben uses the
CMAKE_VS_PLATFORM_TOOLSET for vc8 and vc9 above, so I'm not what would
happen here.

What VC number is reported on your system?

Visual C++ 2015 corresponds to MSVC14.

[Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015 but
the prev version builds OK]

Is this a build error in curl, or the OSG plugin building against curl 7.54.0?

It is in the curl build itself. Here is the bug report I filed: 
https://github.com/curl/curl/issues/1482

Thanks,
Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Cheers,
Stuart
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Call for testing, preparing for 3.5.6 dev release again :-)

2017-05-15 Thread Robert Osfield
Hi Stuart,

On 12 May 2017 at 14:32, Stuart Mentzer  wrote:
> I always build from scratch in an empty build directory.

Thanks for the clarification.

> Adding " around the 3rd and 4th args in the REPLACE lines did indeed
> eliminate the error. Torben should check that this is still OK when the
> Collada plugin is in use.

I'm currently looking at the changes and the error report, trying to
make sense of what is the root of the issue and how to resolve it.
Unfortunately I haven't heard from Torben yet so don't yet know what
his thoughts are.  Form what I understand Torben introduced the
COLLADA_BOOST_BUILDNAME to cope with variations under Windows related
to the platform tools set, hence the introduction of the
CMAKE_VS_PLATFORM_TOOLSET in the lines like:


ELSEIF(MSVC14)
SET(COLLADA_BUILDNAME "vc14")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC12)
SET(COLLADA_BUILDNAME "vc12")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC11)
SET(COLLADA_BUILDNAME "vc11")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC10)
SET(COLLADA_BUILDNAME "vc10")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC90)
SET(COLLADA_BUILDNAME "vc9")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSEIF(MSVC80)
SET(COLLADA_BUILDNAME "vc8")
string(REPLACE "v" "vc" COLLADA_BOOST_BUILDNAME
${CMAKE_VS_PLATFORM_TOOLSET})
ELSE(APPLE)

CMaker docs for the CMAKE_VS_PLATFORM_TOOLSET} are:

https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_PLATFORM_TOOLSET.html

Which mentons that it's set for VC10 and above.  Torben uses the
CMAKE_VS_PLATFORM_TOOLSET for vc8 and vc9 above, so I'm not what would
happen here.

What VC number is reported on your system?

> [Separate issue: curl 7.54.0 (latest) has a build error under VC++ 2015 but
> the prev version builds OK]

Is this a build error in curl, or the OSG plugin building against curl 7.54.0?

Thanks,
Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org