[Bug 596659] Review Request: ofl-sorts-mill-goudy-fonts - Goudy Oldstyle and Italic fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596659 Daiki Ueno changed: What|Removed |Added Status|NEW |ASSIGNED CC||du...@redhat.com AssignedTo|nob...@fedoraproject.org|du...@redhat.com Flag||fedora-review? --- Comment #2 from Daiki Ueno 2010-05-28 02:53:59 EDT --- Mostly ok. How about including FONTLOG to doc? Cosmetic things: - the "Version" is 003.000 (which came from the font, right?), but the upstream uses simpler naming for the archive: ofl-goudy-3.0.zip. I think we could use 3.0. - rpmlint spews a couple of warnings (harmless, I think): ofl-sorts-mill-goudy-fonts.src: W: invalid-url Source0: http://sortsmill.googlecode.com/files/ofl-goudy-3.0.zip HTTP Error 404: Not Found ofl-sorts-mill-goudy-fonts.src: W: uncompressed-zip ofl-goudy-3.0.zip I have no idea how to workaround them :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 --- Comment #17 from Fedora Update System 2010-05-28 02:55:12 EDT --- nitrogen-1.5.1-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/nitrogen-1.5.1-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 --- Comment #16 from Fedora Update System 2010-05-28 02:53:54 EDT --- nitrogen-1.5.1-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/nitrogen-1.5.1-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 576839] Review Request: bdii - The Berkeley Database Information Index (BDII)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=576839 Mattias Ellert changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Mattias Ellert 2010-05-28 02:41:41 EDT --- Thank you for the review! New Package CVS Request === Package Name: bdii Short Description: The Berkeley Database Information Index (BDII) Owners: ellert Branches: F-12 F-13 EL-4 EL-5 EL-6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 337791] Review Request: php-channel-symfony - Adds symfony project channel to PEAR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=337791 --- Comment #9 from Remi Collet 2010-05-28 01:49:24 EDT --- @Jason : my RFE for this branch in EL-6 is bug #592528 And yes, I'm ok to maintain it in EPEL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 337791] Review Request: php-channel-symfony - Adds symfony project channel to PEAR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=337791 --- Comment #8 from Christof Damian 2010-05-28 01:25:35 EDT --- I am sorry, here is the correct one. Remi asked me to create the branch, because he needs the channel for another package he has for EL-6. Would it help if I put myself also in as additional owner for EL-6 ? Package Change Request == Package Name: php-channel-symfony New Branches: EL-6 Owners: remi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596659] Review Request: ofl-sorts-mill-goudy-fonts - Goudy Oldstyle and Italic fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596659 --- Comment #1 from Parag 2010-05-28 01:13:38 EDT --- https://fedoraproject.org/wiki/OFL_Sorts_Mill_Goudy_fonts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596660] Review Request: crimson-text-fonts - A latin font for the production of technical books and papers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596660 --- Comment #1 from Parag 2010-05-28 01:13:34 EDT --- https://fedoraproject.org/wiki/Crimson_text_fonts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596661] Review Request: molengo-fonts - A Latin typeface for documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596661 --- Comment #3 from Parag 2010-05-28 01:13:53 EDT --- https://fedoraproject.org/wiki/Molengo_fonts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592668] Review Request: ladspa-autotalent-plugins - A pitch correction LADSPA plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592668 --- Comment #5 from David Cornette 2010-05-28 01:03:00 EDT --- Upstream has issued a new tarball with the license for the Pure Data source files. I made a new version: Spec URL: http://www.davidcornette.com/ladspa-autotalent-plugins.spec SRPM URL: http://www.davidcornette.com/ladspa-autotalent-plugins-0.2-3.fc11.src.rpm Would you like to take a look at it before I proceed? Or is this just a case of updating a package after it has been approved, even though it hasn't even been put in CM? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569366] Review Request: ipa-ex-gothic-fonts - Japanese Gothic-typeface OpenType font by IPA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569366 Akira TAGOH changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #12 from Akira TAGOH 2010-05-28 01:00:59 EDT --- Thanks. the package has been imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569368] Review Request: ipa-ex-mincho-fonts - Japanese Mincho-typeface OpenType font by IPA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569368 Akira TAGOH changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #10 from Akira TAGOH 2010-05-28 00:53:34 EDT --- Apparently there are no F-13 and F-12 branches though. do I need to wait some time? set ? to fedora-cvs again to grab someone. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596461] Review Request: lzma - SDK for lzma compression
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596461 --- Comment #5 from Bruno Wolff III 2010-05-28 00:30:28 EDT --- Once the devel version of squashfs started building against the xz lib I didn't worry about it. I am still not in a hurry, as despite what the kernel newbies page says, lzma squashfs file systems are not supported by the upstream kernel yet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596461] Review Request: lzma - SDK for lzma compression
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596461 --- Comment #4 from Chen Lei 2010-05-27 22:55:12 EDT --- (In reply to comment #3) > I think it is better to package it once and have things pull source from it > there, rather than bundle copies. Can squashfs build agaist lzma465? We now have one source package in repo - xorg-x11-server-source? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597035] Review Request: ibus-table-others - Various tables for IBus-Table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597035 Caius 'kaio' Chance changed: What|Removed |Added Keywords||i18n -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597035] New: Review Request: ibus-table-others - Various tables for IBus-Table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: ibus-table-others - Various tables for IBus-Table https://bugzilla.redhat.com/show_bug.cgi?id=597035 Summary: Review Request: ibus-table-others - Various tables for IBus-Table Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ccha...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://kaio.fedorapeople.org/pkgs/ibus-table-others.spec SRPM URL: http://kaio.fedorapeople.org/pkgs/ibus-table-others-1.3.0.20100528-1.fc13.src.rpm Description: Various tables for IBus-Table -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: rabbitvcs - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #36 from Fedora Update System 2010-05-27 20:21:45 EDT --- rabbitvcs-0.13.1-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rabbitvcs-0.13.1-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: rabbitvcs - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #35 from Fedora Update System 2010-05-27 20:20:50 EDT --- rabbitvcs-0.13.1-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rabbitvcs-0.13.1-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: rabbitvcs - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #34 from Juan Manuel Rodriguez 2010-05-27 20:09:39 EDT --- Thanks Jason! rabbitvcs packages are on the way. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: rabbitvcs - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #33 from Jason Tibbitts 2010-05-27 19:52:18 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: rabbitvcs - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 Jason Tibbitts changed: What|Removed |Added Summary|Review Request: RabbitVCS - |Review Request: rabbitvcs - |Easy version control|Easy version control -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: rabbitvcs - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #32 from Jason Tibbitts 2010-05-27 19:48:31 EDT --- Our scripts complain if the package name in the bugzilla ticket doesn't match the package name in the CVS request. This helps catch typos. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: RabbitVCS - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #31 from Juan Manuel Rodriguez 2010-05-27 19:22:16 EDT --- I think lowercase would be better. I usually download packages just doing "fedora-cvs packagename", and it wouldn't find RabbitCVS, only rabbitvcs. So, rabbitcvs please. Should I rename the ticket name? Thanks for double checking :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #5 from Dave Malcolm 2010-05-27 18:56:02 EDT --- I went ahead and added a link to this review to the list of Python runtimes here: https://fedoraproject.org/wiki/SIGs/Python#Python_Runtimes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591730
--- Comment #4 from Dave Malcolm 2010-05-27 18:51:31 EDT
---
Thanks - this is looking good.
There are a couple of issues I think need fixing:
(i) Please fix the python-bytecode-inconsistent-mtime" from pylint as this will
make "import pyjd" slower than it could be
(ii) Please fix the "License" metadata (see below)
Details:
NEEDSWORK: rpmlint must be run on every package. The output should be posted in
the review.[1]
$ rpmlint ~/rpmbuild/RPMS/noarch/pyjamas-*0.7-3*
pyjamas.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyjs/pyjampiler.py 0644L /usr/bin/python
pyjamas.noarch: E: non-executable-script
/usr/share/pyjamas/pyjs/tests/test-coverage.py 0644L /usr/bin/env
pyjamas.noarch: E: non-executable-script
/usr/share/pyjamas/pyjs/src/pyjs/lib/base64.py 0644L /usr/bin/env
pyjamas.noarch: E: zero-length /usr/share/pyjamas/library/jsonrpc/json.py
pyjamas-desktop.noarch: W: no-documentation
pyjamas-desktop.noarch: E: python-bytecode-inconsistent-mtime
/usr/lib/python2.6/site-packages/pyjd/__init__.pyc 2010-05-27T18:07:12
/usr/lib/python2.6/site-packages/pyjd/__init__.py 2010-05-27T18:07:14
pyjamas-desktop.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyjd/idlparser.py 0644L /usr/bin/env
pyjamas-desktop.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyjd/modcompile.py 0644L /usr/bin/env
pyjamas-desktop.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyjd/pywebkitgtk.py 0644L /usr/bin/env
pyjamas-doc.noarch: W: no-documentation
pyjamas-examples.noarch: W: no-documentation
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/uitest/public/testLabelAdd.removelabel.txt
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/maparea/Hello.py
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/uitest/public/testButtonClick.removeButton.txt
pyjamas-examples.noarch: E: non-executable-script
/usr/share/pyjamas/examples/jsonrpc/public/PythonCGIServer.py 0644L
/usr/bin/env
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/maparea/Map.py
pyjamas-examples.noarch: E: script-without-shebang
/usr/share/pyjamas/examples/flowpanel/FlowPanel.py
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/uitest/public/testDivText.removeDiv.txt
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/uitest/public/testDivAdd.removeDiv.txt
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/maparea/public/Hello.html
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/uitest/public/testDivHTML.removeDiv.txt
pyjamas-ui.noarch: W: no-documentation
5 packages and 0 specfiles checked; 18 errors, 4 warnings.
Please can you fix the "python-bytecode-inconsistent-mtime" error: this will
force Python to recompile pyjd/__init__.py every time you import it, if run as
non-root.
Everything else looks waivable to me.
OK: The package must be named according to the Package Naming Guidelines
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
NEEDSWORK: The License field in the package spec file must match the actual
license. [3]
The file "copyright" in the source tree handily lists the licences. Most files
are indeed under Apache, but there's a mixture of others: some GPL-2, Other,
ZPL-2.1, MIT, PSF, LGPL-2.1. All appear to be Fedora-approved licenses.
Note that each subpackage can have its own "License" tag; see
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
OK: The spec file must be written in American English. [5]
OK: The spec file for the package MUST be legible. [6]
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
$ md5sum pyjamas-0.7.tgz pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz
8441b60bb3c88051799537852cceefd0 pyjamas-0.7.tgz
8441b60bb3c88051799537852cceefd0 pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz
$ sha256sum pyjamas-0.7.tgz pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz
648f62c1ddf99392fb926ca8d3900c39109b09e06d93cc7de3668933d7084d2b
pyjamas-0.7.tgz
648f62c1ddf99392fb926ca8d3900c39109b09e06d93cc7de3668933d7084d2b
pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz
OK: The package MUST successfully compile and build into binar
[Bug 595220] Review Request: buildnumber-maven-plugin - Build Number Maven Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=595220 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Dennis Gilmore 2010-05-27 18:52:11 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596125] Review Request: maven-skins - Maven Skins
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596125 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Dennis Gilmore 2010-05-27 18:50:31 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596638] Review Request: maven-antrun-plugin - Maven AntRun Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596638 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Dennis Gilmore 2010-05-27 18:46:24 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594839] Review Request: kpartsplugin - KParts technology to embed file viewers into non-KDE browsers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594839 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Dennis Gilmore 2010-05-27 18:48:53 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596684] Review Request: maven-source-plugin - Maven Source Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596684 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Dennis Gilmore 2010-05-27 18:47:07 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594943] Review Request: libnoise - A general-purpose library that generates three-dimensional coherent noise
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594943 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #25 from Dennis Gilmore 2010-05-27 18:49:40 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 595994] Review Request: cardo-fonts - A font for scholarly use in classical and medieval languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=595994 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Dennis Gilmore 2010-05-27 18:45:43 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 595993] Review Request: josefinsansstd-light-fonts - A latin font that is geometric, elegant, and kind of vintage
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=595993 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Dennis Gilmore 2010-05-27 18:45:02 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 595269] Review Request: lobster-fonts - Hand written font with various ligatures for better connecting of letters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=595269 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Dennis Gilmore 2010-05-27 18:44:28 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 595268] Review Request: tangerine-fonts - Tangerine is a calligraphy font inspired by many italic chancery hands
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=595268 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Dennis Gilmore 2010-05-27 18:41:50 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569366] Review Request: ipa-ex-gothic-fonts - Japanese Gothic-typeface OpenType font by IPA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569366 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Dennis Gilmore 2010-05-27 18:39:30 EDT --- CVS Done Except F-11 whihc is no longer a valid branch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569368] Review Request: ipa-ex-mincho-fonts - Japanese Mincho-typeface OpenType font by IPA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569368 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Dennis Gilmore 2010-05-27 18:40:42 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592655] yelp-xsl XSL stylesheets for use with yelp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592655 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Dennis Gilmore 2010-05-27 18:37:07 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: RabbitVCS - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #30 from Jason Tibbitts 2010-05-27 18:36:38 EDT --- Just double checking: the ticket summary says "RabbitVCS", the CVS request says "rabbitvcs". Please verify that you want the package name to be lower case. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555990] Review Request: rubygems-acts-as-list - Sorting and reordering capabilities for ActiveRecord model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555990 --- Comment #6 from Jason Tibbitts 2010-05-27 18:37:09 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #20 from Christoph Wickert 2010-05-27 18:12:18 EDT --- (In reply to comment #17) > I believe the > correct way to deal with these .py file is to remove the shebang (I could be > wrong, perhaps a more experienced packager could confirm this). Right. BTW: There are missing Requires for pm-utils (for dorectory ownership), pygtk2-libglade (instead of pygtk2) and ethtool. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 337791] Review Request: php-channel-symfony - Adds symfony project channel to PEAR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=337791 --- Comment #7 from Jason Tibbitts 2010-05-27 18:18:27 EDT --- This is a bit confusing. "pkgname" obviously isn't what you intended to put there; I can guess, but as these are processed by a script, please do try to make proper requests. I see the owner has recently changed so that you own this package. However, since you won't own the EL-6 branch, we need an ack from remi. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596746] Review Request: bzr-explorer - A bzr GUI
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=596746
--- Comment #3 from Terje Røsten 2010-05-27 17:33:28
EDT ---
Some more comments:
- use version macro in source url
- summary is a bit short?
- don't builds in F12 (missing defs) okay?
- use globbing for egg-info to simplify upgrade?
pedantic
- remove some empty lines
- some places you use %{name}, some you don't.
For later reference, koji builds it fine:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2214002
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #18 from leigh scott 2010-05-27 16:54:28 EDT --- I am getting some selinux noise. https://bugzilla.redhat.com/show_bug.cgi?id=596982 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=593841
--- Comment #19 from leigh scott 2010-05-27
16:56:58 EDT ---
And this.
Summary:
SELinux is preventing /sbin/consoletype "append" access to /var/log/wicd.log.
Detailed Description:
[consoletype has a permissive type (consoletype_t). This access was not
denied.]
SELinux denied access requested by consoletype. /var/log/wicd.log may be a
mislabeled. /var/log/wicd.log default SELinux type is var_log_t, but its
current
type is NetworkManager_log_t. Changing this file back to the default type, may
fix your problem.
File contexts can be assigned to a file in the following ways.
* Files created in a directory receive the file context of the parent
directory by default.
* The SELinux policy might override the default label inherited from the
parent directory by specifying a process running in context A which creates
a file in a directory labeled B will instead create the file with label C.
An example of this would be the dhcp client running with the dhclient_t
type
and creating a file in the directory /etc. This file would normally receive
the etc_t type due to parental inheritance but instead the file is labeled
with the net_conf_t type because the SELinux policy specifies this.
* Users can change the file context on a file using tools such as chcon, or
restorecon.
This file could have been mislabeled either by user error, or if an normally
confined application was run under the wrong domain.
However, this might also indicate a bug in SELinux because the file should not
have been labeled with this type.
If you believe this is a bug, please file a bug report against this package.
Allowing Access:
You can restore the default system context to this file by executing the
restorecon command. restorecon '/var/log/wicd.log', if this file is a
directory,
you can recursively restore using restorecon -R '/var/log/wicd.log'.
Fix Command:
/sbin/restorecon '/var/log/wicd.log'
Additional Information:
Source Contextsystem_u:system_r:consoletype_t:s0
Target Contextsystem_u:object_r:NetworkManager_log_t:s0
Target Objects/var/log/wicd.log [ file ]
Sourceconsoletype
Source Path /sbin/consoletype
Port
Host localhost.localdomain
Source RPM Packages initscripts-9.12-1.fc13
Target RPM Packages
Policy RPMselinux-policy-3.7.19-15.fc13
Selinux Enabled True
Policy Type targeted
Enforcing ModeEnforcing
Plugin Name restorecon
Host Name localhost.localdomain
Platform Linux localhost.localdomain
2.6.33.4-95.fc13.x86_64 #1 SMP Thu May 13
05:16:23
UTC 2010 x86_64 x86_64
Alert Count 3
First SeenThu 27 May 2010 21:47:18 BST
Last Seen Thu 27 May 2010 21:48:04 BST
Local ID 982f2b67-8dc4-4393-8355-c661686d7d85
Line Numbers
Raw Audit Messages
node=localhost.localdomain type=AVC msg=audit(1274993284.87:235): avc: denied
{ append } for pid=7110 comm="consoletype" path="/var/log/wicd.log" dev=sdd3
ino=310527 scontext=system_u:system_r:consoletype_t:s0
tcontext=system_u:object_r:NetworkManager_log_t:s0 tclass=file
node=localhost.localdomain type=SYSCALL msg=audit(1274993284.87:235):
arch=c03e syscall=59 success=yes exit=0 a0=ce4bf0 a1=ce32a0 a2=ce1470 a3=10
items=0 ppid=7109 pid=7110 auid=4294967295 uid=0 gid=0 euid=0 suid=0 fsuid=0
egid=0 sgid=0 fsgid=0 tty=(none) ses=4294967295 comm="consoletype"
exe="/sbin/consoletype" subj=system_u:system_r:consoletype_t:s0 key=(null)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596991] Review Request: z-push - ActiveSync over-the-air implementation for mobile syncing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596991 Robert Scheck changed: What|Removed |Added Depends on||182235(FE-Legal) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596991] New: Review Request: z-push - ActiveSync over-the-air implementation for mobile syncing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: z-push - ActiveSync over-the-air implementation for mobile syncing https://bugzilla.redhat.com/show_bug.cgi?id=596991 Summary: Review Request: z-push - ActiveSync over-the-air implementation for mobile syncing Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: redhat-bugzi...@linuxnetz.de QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, tcall...@redhat.com, fedora-package-rev...@redhat.com, m...@oostergo.net Estimated Hours: 0.0 Classification: Fedora Spec URL: [Will come soon] SRPM URL: [Will come soon] Description: Z-Push is an implementation of the ActiveSync protocol which is used 'over-the-air' for multi platform ActiveSync devices, including Windows Mobile, Android, iPhone, Sony Ericsson and Nokia mobile devices. With Z-Push any groupware can be connected and synced with these devices. Sorry for being so unprecise so far, but there will be some upstream changes in the near future and some other facts changed in the meantime. Before we go to a technical review, Fedora Legal needs to give the okay; so please don't take/assign the Package Review so far. I will add a spec file and a source RPM once the legal stuff has been solved. Right now, the usage and distribution of current z-push in the US is forbidden per GPLv2 with clause 8 invoked. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #17 from leigh scott 2010-05-27 16:34:01 EDT --- Hi David, I believe you have made a mistake making the .py file executable, I believe the correct way to deal with these .py file is to remove the shebang (I could be wrong, perhaps a more experienced packager could confirm this). http://dl.dropbox.com/u/6907158/wicd.spec Thanks Leigh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 520569] Review Request: uboot-mkimage - U-Boot mkimage utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=520569
--- Comment #8 from Dan Horák 2010-05-27 15:48:24 EDT ---
(In reply to comment #7)
> We need mkimage for kernel building for ARM and for the ESIA package.
Thanks for the review and did you checked the uboot-tools package based on the
U-Boot source code?
> [N] MUST: Each package must consistently use macros. [16]
>
> *** Avoid mixing environment variables ($RPMBUILDROOT) with macros (e.g., use
> %{buildroot})
using $RPM_BUILD_ROOT and %{_*dir} is valid, the guideline doesn't to see using
both $RPM_BUILD_ROOT and %{buildroot} in one spec
> [Y] MUST: The package must contain code, or permissable content. [17]
> [NA] MUST: Large documentation files must go in a -doc subpackage. (The
> definition of large is left up to the packager's best judgement, but is not
> restricted to size. Large can refer to either size or quantity). [18]
> [NA] MUST: If a package includes something as %doc, it must not affect the
> runtime of the application. To summarize: If it is in %doc, the program must
> run properly if it is not present. [18]
>
> *** !No %doc present
yes, I will add some and I open to suggestions what should be included
>
> Additional comments:
> - Should have a more detailed %desc/%summary
will be updated
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591982] Review Request: batti - Simple battery monitor for the system tray
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591982
Martin Gieseking changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de
Flag||fedora-review+
--- Comment #4 from Martin Gieseking 2010-05-27
15:23:13 EDT ---
(In reply to comment #3)
> AFAIK there is no need to select a python version. batti should build both
> with
> python 2 and 3 so I prefer to make the switch when Fedora finally switches.
> This is easier with a simple "python-devel".
OK, that's fine.
Here's the formal review. I couldn't find any further issues needed to be
addressed. The package looks fine and works as expected.
$ rpmlint /var/lib/mock/fedora-13-x86_64/result/batti-*.rpm
batti.noarch: W: spelling-error %description -l en_US batterymon -> battery,
batterer, batter
batti.noarch: W: spelling-error %description -l en_US un -> UN, nu, in
batti.noarch: W: invalid-url URL: http://batti-gtk.googlecode.com/
IncompleteRead(0 bytes read)
batti.src: W: spelling-error %description -l en_US batterymon -> battery,
batterer, batter
batti.src: W: spelling-error %description -l en_US un -> UN, nu, in
batti.src: W: invalid-url URL: http://batti-gtk.googlecode.com/
IncompleteRead(0 bytes read)
batti.src: W: invalid-url Source0:
http://batti-gtk.googlecode.com/files/batti-0.3.7.tar.gz HTTP Error 404: Not
Found
2 packages and 0 specfiles checked; 0 errors, 7 warnings.
All warnings are false positive (URLs are valid, spelling is correct)
-
keys used in following checklist:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
- GPLv2+ according to source file headers
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
- file COPYING present in %doc
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum batti-0.3.7.tar.gz*
f855b28e4bb84fb33565d2668c33e221 batti-0.3.7.tar.gz
f855b28e4bb84fb33565d2668c33e221 batti-0.3.7.tar.gz.1
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- noarch package
- builds correctly for F-12, F-13 and rawhide
[.] MUST: If the package does not successfully compile, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: The spec file MUST handle locales properly.
[.] MUST: Packages storing shared library files ...
- no shared libs
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix ...
- no libs
[.] MUST: devel packages must require the base package.
- no devel package
[.] MUST: Packages must NOT contain any .la libtool archives.
- no .la files
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
- .desktop file present and valid
[+] .desktop file must be properly installed with desktop-file-install.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[+] MUST: Python eggs must be built from source.
[+] MUST: Python eggs must not download any dependencies during the build
process.
[+] MUST: If egg-info files are generated by the modules build scripts they
must be included in the package.
[.] MUST: When building a compat package, ...
[.] MUST: When building multiple versions (for a compat package) ...
[+] MUST: The
[Bug 592655] yelp-xsl XSL stylesheets for use with yelp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592655 Matthias Clasen changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Matthias Clasen 2010-05-27 15:14:11 EDT --- New Package CVS Request === Package Name: yelp-xsl Short Description: XSL Stylesheets for yelp Owners: mclasen, mbarnes Branches: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592668] Review Request: ladspa-autotalent-plugins - A pitch correction LADSPA plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592668 Orcan 'oget' Ogetbil changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Orcan 'oget' Ogetbil 2010-05-27 14:49:54 EDT --- Alright then. Based on your patent investigation and FE-Legal's license approval, this package is good to go. This package (ladspa-autotalent-plugins) is APPROVED by oget -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596449] Review Request: NetworkManager-openswan - NetworkManager VPN plugin for Openswan (IPsec)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596449 --- Comment #16 from Tomas Mraz 2010-05-27 14:37:10 EDT --- Chen Lei, will you do the formal review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 576839] Review Request: bdii - The Berkeley Database Information Index (BDII)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=576839 Steve Traylen changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581280] Review Request: erlang-oauth - An Erlang OAuth implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581280 --- Comment #15 from Fedora Update System 2010-05-27 14:33:40 EDT --- couchdb-0.10.2-4.fc11, erlang-oauth-0-0.3.gite8aecf0.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update couchdb erlang-oauth'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/couchdb-0.10.2-4.fc11,erlang-oauth-0-0.3.gite8aecf0.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581280] Review Request: erlang-oauth - An Erlang OAuth implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581280 --- Comment #16 from Fedora Update System 2010-05-27 14:34:11 EDT --- couchdb-0.10.2-4.fc13, erlang-oauth-0-0.3.gite8aecf0.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update couchdb erlang-oauth'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/couchdb-0.10.2-4.fc13,erlang-oauth-0-0.3.gite8aecf0.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577974 --- Comment #7 from Fedora Update System 2010-05-27 14:24:27 EDT --- glite-security-trustmanager-2.5.5-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/glite-security-trustmanager-2.5.5-4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581280] Review Request: erlang-oauth - An Erlang OAuth implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581280 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #14 from Fedora Update System 2010-05-27 14:29:44 EDT --- couchdb-0.10.2-4.fc12, erlang-oauth-0-0.3.gite8aecf0.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update couchdb erlang-oauth'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/couchdb-0.10.2-4.fc12,erlang-oauth-0-0.3.gite8aecf0.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 337791] Review Request: php-channel-symfony - Adds symfony project channel to PEAR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=337791 Christof Damian changed: What|Removed |Added CC||chris...@damian.net Flag|fedora-cvs+ |fedora-cvs? --- Comment #6 from Christof Damian 2010-05-27 14:25:24 EDT --- Package Change Request == Package Name: pkgname New Branches: EL-6 Owners: remi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577974 --- Comment #8 from Fedora Update System 2010-05-27 14:24:34 EDT --- glite-security-trustmanager-2.5.5-4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/glite-security-trustmanager-2.5.5-4.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #3 from Kevin Fenzi 2010-05-27 14:16:31 EDT --- > I found the above specfile comment a little unclear; it looks like it was > copied from upstream instructions, but it immediately raises questions: do the > pyjamas libraries get installed, and if so where? yeah, I copied this from upstream. Reworded it now. New wording: # NOTE: we only byte-compile the library files installed in the normal # fedora python_sitelib. All other .py files are left alone. # This is due to those files replacing/overriding core modules. # They should never be run from anything but pyjamas itself, nor # should they be byte compiled. Fixed description typo. Changed sitelib to not use a wildcard. On licensing: - I think it does boil down to ASL2 - The pygwt.js should be ASL2 (at least google web toolkit is ASL2.0). - The contrib/copyright_check.py doesn't run, and I can't see how it would be useful here, but it seems a pain to just do a special tar for this. Will ask upstream I guess. It looks like they may have just dropped this post 0.7. New spec at: http://www.scrye.com/~kevin/fedora/pyjamas/pyjamas.spec Should we ask spot to look over the licensing here? I could have missed something... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: RabbitVCS - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 Juan Manuel Rodriguez changed: What|Removed |Added Flag||fedora-cvs? --- Comment #29 from Juan Manuel Rodriguez 2010-05-27 13:55:43 EDT --- New Package CVS Request === Package Name: rabbitvcs Short Description: RabbitVCS is a set of graphical tools written to provide simple and straightforward access to the version control systems you use. Owners: nushio Branches: F-12 F-13 devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596449] Review Request: NetworkManager-openswan - NetworkManager VPN plugin for Openswan (IPsec)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=596449
--- Comment #15 from Avesh Agarwal 2010-05-27 13:43:18
EDT ---
(In reply to comment #14)
> Some comment:
> 1.
> Source:%{name}-%{realversion}.tar.gz
> Should add some comments about how to genrate the tarball
> See http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
>
Done.
> 2.Epoch: 1
>
> Remove it from spec, when possible packager should avoid of using epoch.
>
Done.
>
> 3.
> BuildRoot: %{_tmppath}/%{name}-%{version}-root
> Only needed for epel5
>
Did not change as this package may be built for epel5 too. However, I have
modified it to have as per fedora packaging guidelines:
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
> 4.
> %post
> /sbin/ldconfig
>
> %postun
> /sbin/ldconfig
>
> It's a plugin, I don't think ldconfig is necesscery
>
Done.
> 5.
> %define nm_version 1:0.7.997-1
> %define dbus_version1.1
> %define gtk2_version2.10.0
> %define shared_mime_version 0.16-3
>
> Those lines are useless, all branches in fedora match those versions.
>
>
Done.
> 6.%{_datadir}/icons/hicolor/48x48/apps/gnome-mime-application-x-openswan-ipsec-vpn-settings.png
>
> Is this file useful for openswan?
Done.
>
>
> 7.
> %files -f %{name}.lang
> %defattr(-, root, root)
> ->
> %files -f %{name}.lang
> %defattr(-, root, root,-)
>
Done.
>
> 8.
> Requires: gtk2 >= %{gtk2_version}
> Requires: dbus >= %{dbus_version}
> Requires: shared-mime-info >= %{shared_mime_version}
> Requires: GConf2
> Those dependicies may not need, please reconsider it, normally rpmbuild will
> pull in shlib depenpencies automatically.
Done.
In addition, added requires for openswan, and also made a few other changes.
Current versions are avilable at
http://people.redhat.com/avagarwa/files/NetworkManager-openswan/
Thanks for your detailed comments.
Avesh
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 520569] Review Request: uboot-mkimage - U-Boot mkimage utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=520569
Chris Tyler changed:
What|Removed |Added
CC||ch...@tylers.info
AssignedTo|nob...@fedoraproject.org|ch...@tylers.info
--- Comment #7 from Chris Tyler 2010-05-27 13:36:48 EDT ---
We need mkimage for kernel building for ARM and for the ESIA package.
Review results:
[N] MUST: rpmlint must be run on every package. The output should be posted in
the review.[1]
*** rpmlint output:
$ rpmlint */uboot*spec */uboot*rpm */*/uboot*rpm
uboot-tools.x86_64: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 1 warnings.
[Y] MUST: The package must be named according to the Package Naming Guidelines
.
[Y] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
[Y] MUST: The package must meet the Packaging Guidelines .
[Y] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[Y] MUST: The License field in the package spec file must match the actual
license. [3]
[N] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]
[Y] MUST: The spec file must be written in American English. [5]
[Y] MUST: The spec file for the package MUST be legible. [6]
[Y] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
[Y] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture. [7]
[Y] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
[Y] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[NA] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
[NA] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
[Y] MUST: Packages must NOT bundle copies of system libraries.[11]
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
[Y] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. [13]
[Y] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. [14]
[Y] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. [15]
[N] MUST: Each package must consistently use macros. [16]
*** Avoid mixing environment variables ($RPMBUILDROOT) with macros (e.g., use
%{buildroot})
[Y] MUST: The package must contain code, or permissable content. [17]
[NA] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity). [18]
[NA] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present. [18]
*** !No %doc present
[NA] MUST: Header files must be in a -devel package. [19]
[NA] MUST: Static libraries must be in a -static package. [20]
[NA] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package. [19]
[NA] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} [21]
[NA] MUST: Packages must NOT contain any .la libtool
[Bug 582106] Review Request: lifeograph - Private digital diary.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=582106
--- Comment #10 from Mamoru Tasaka 2010-05-27
13:28:01 EDT ---
(Now this package builds also on rawhide)
For -2:
* %clean section
- '[ "${RPM_BUILD_ROOT}" != "/" ] &&' part is not needed.
* %changelog
- It is recommended that you put one line between each %changelog
entry like:
--
* Thu May 27 2010 Gowrishankar Rajaiyan - 0.6.2-2
- Update the spec file as per Mamoru's review in comment 7 of BZ-582106.
* Mon May 24 2010 Gowrishankar Rajaiyan - 0.6.2-1
- Update the spec file as per Mamoru's review in comment 1 of BZ-582106.
Forgot to update the version number.
* Fri Apr 09 2010 Gowrishankar Rajaiyan - 0.6.2-1
- initial spec
--
(In reply to comment #9)
> I shall definitely pre-review of other person's review request or file a new
> review request at the earliest.
>
> Thank you once again.
Thanks.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: RabbitVCS - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 Kalev Lember changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #28 from Kalev Lember 2010-05-27 13:25:54 EDT --- (In reply to comment #27) > rpmlint seems to complain that: > rabbitvcs.src: W: invalid-url Source0: > http://rabbitvcs.googlecode.com/files/rabbitvcs-0.13.1.tar.gz HTTP Error 404: > Not Found > > However, the file *is* there, and I can download it from the same computer I > used rpmlint. Weird, huh? No idea how rpmlint does the check, but I've seen it report the same bogus invalid-url warning for other googlecode urls too. The package looks good now. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594943] Review Request: libnoise - A general-purpose library that generates three-dimensional coherent noise
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594943 Robin Norwood changed: What|Removed |Added Flag||fedora-cvs? --- Comment #24 from Robin Norwood 2010-05-27 13:27:12 EDT --- New Package CVS Request === Package Name: libnoise Short Description: A general-purpose library that generates three-dimensional coherent noise Owners: rnorwood Branches: F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594943] Review Request: libnoise - A general-purpose library that generates three-dimensional coherent noise
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594943 --- Comment #23 from Robin Norwood 2010-05-27 13:25:29 EDT --- Thanks, Martin! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594943] Review Request: libnoise - A general-purpose library that generates three-dimensional coherent noise
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594943 Martin Gieseking changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #22 from Martin Gieseking 2010-05-27 13:19:56 EDT --- The spec file and the resulting packages look fine now. Package APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 Dave Malcolm changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588941] Review Request: pypy - Implementation of the Python language, using Python itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588941 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ke...@tummy.com Flag||fedora-review? --- Comment #4 from Kevin Fenzi 2010-05-27 13:10:09 EDT --- I'll look at reviewing this soon. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: RabbitVCS - Easy version control
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542715
--- Comment #27 from Juan Manuel Rodriguez
2010-05-27 13:00:58 EDT ---
Talked with upstream about the 'shebang' issue. I patched it out for 0.13.1,
but it's been fixed upstream:
http://code.google.com/p/rabbitvcs/source/detail?r=2529
Now Obsoletes rabbitvcs since I do care about the users that installed
rabbitvcs rpms I provided :)
Changed the glob to %{_datadir}/icons/hicolor/scalable/*/*.svg
Fixed the spec permissions
SPEC: http://nushio.fedorapeople.org/rabbitvcs/rabbitvcs.spec
SRPM: http://nushio.fedorapeople.org/rabbitvcs/rabbitvcs-0.13.1-3.fc13.src.rpm
rpmlint seems to complain that:
rabbitvcs.src: W: invalid-url Source0:
http://rabbitvcs.googlecode.com/files/rabbitvcs-0.13.1.tar.gz HTTP Error 404:
Not Found
However, the file *is* there, and I can download it from the same computer I
used rpmlint. Weird, huh?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526567] Review Request: mongodb - high-performance, open source, schema-free document-oriented database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526567 Peter Lemenkov changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com Flag||fedora-review? --- Comment #17 from Peter Lemenkov 2010-05-27 12:38:12 EDT --- I'll review it. First, I would like o say that I'll very reluctantly approve application with static libraries. I'll take a closer look at the package later. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596866] New: Review Request: apache-commons-configuration - rename of jakarta-commons-configuration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: apache-commons-configuration - rename of jakarta-commons-configuration https://bugzilla.redhat.com/show_bug.cgi?id=596866 Summary: Review Request: apache-commons-configuration - rename of jakarta-commons-configuration Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: socho...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- This is a re-review of existing package! Spec URL: http://sochotni.fedorapeople.org/apache-commons-configuration-1.6-1.fc14.src.rpm SRPM URL: http://sochotni.fedorapeople.org/apache-commons-configuration.spec Description: Configuration is a project to provide a generic Configuration interface and allow the source of the values to vary. It provides easy typed access to single, as well as lists of configuration values based on a 'key'. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563844] Review Request: zim - A Desktop Wiki Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563844 --- Comment #51 from Toshio Ernie Kuratomi 2010-05-27 12:33:46 EDT --- Fesco meeting ticket was opened by Kevin Fenzi here: https://fedorahosted.org/fesco/ticket/385 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593353] Review Request: pyliblzma - Python bindings for lzma
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593353 --- Comment #1 from seth vidal 2010-05-27 12:21:06 EDT --- okay, I've updated the pkgs and I think they are inline with python specs now. This package cannot, yet, build for python3 and that's fine this one is only targeted for python2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: RabbitVCS - Easy version control
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542715
--- Comment #26 from Kalev Lember 2010-05-27 12:13:46 EDT
---
Fedora review rabbitvcs-0.13.1-2.fc13.src.rpm 2010-05-27
+ OK
! needs attention
rpmlint output:
rabbitvcs-cli.noarch: W: no-documentation
rabbitvcs-cli.noarch: W: no-manual-page-for-binary rabbitvcs
rabbitvcs-nautilus.i686: W: only-non-binary-in-usr-lib
rabbitvcs-nautilus.i686: W: no-documentation
rabbitvcs-core.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/rabbitvcs/debug/ipython_view.py 0644L
/usr/bin/python
rabbitvcs-gedit.i686: W: only-non-binary-in-usr-lib
rabbitvcs-gedit.i686: W: no-documentation
rabbitvcs.src: W: strange-permission rabbitvcs.spec 0777L
rabbitvcs.src:64: W: macro-in-comment %package
rabbitvcs.src:67: W: macro-in-comment %{version}
rabbitvcs.src:67: W: macro-in-comment %{release}
rabbitvcs.src:72: W: macro-in-comment %description
rabbitvcs.src:114: W: macro-in-comment %{_libdir}
rabbitvcs.src:115: W: macro-in-comment %{title}
rabbitvcs.src:115: W: macro-in-comment %{_libdir}
rabbitvcs.src:115: W: macro-in-comment %{title}
rabbitvcs.src:157: W: macro-in-comment %files
rabbitvcs.src:158: W: macro-in-comment %defattr
rabbitvcs.src:159: W: macro-in-comment %{_libdir}
rabbitvcs.src:159: W: macro-in-comment %{title}
rabbitvcs.src: W: invalid-url Source0:
http://rabbitvcs.googlecode.com/files/rabbitvcs-0.13.1.tar.gz HTTP Error 404:
Not Found
5 packages and 0 specfiles checked; 1 errors, 20 warnings.
E: non-executable-script is because ipython_view.py has python shebang. I don't
think it's something that should be fixed up in Fedora's rpm package, but you
can mention it to upstream instead.
! rabbitvcs.src: W: strange-permission rabbitvcs.spec 0777L
Chmod the .spec file to 644.
Other rpmlint warnings can be ignored.
+ The package is named according to the Package Naming Guidelines.
+ Spec file name matches the base package name
+ The package follows the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
861590f60bf2367a92861e44c1852b0d rabbitvcs-0.13.1.tar.gz
861590f60bf2367a92861e44c1852b0d Download/rabbitvcs-0.13.1.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file handles locales properly
+ Package does not bundle copies of system libraries
n/a Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package contains code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
! Packages must not own files or directories owned by other packages
hicolor-icon-theme already owns these directories:
/usr/share/icons/hicolor/scalable/actions
/usr/share/icons/hicolor/scalable/apps
/usr/share/icons/hicolor/scalable/emblems
To fix that, I'd suggest to change the glob from:
%{_datadir}/icons/hicolor/scalable/*
to:
%{_datadir}/icons/hicolor/scalable/*/*.svg
+ Filenames must be valid UTF-8
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581279
Peter Lemenkov changed:
What|Removed |Added
Flag|needinfo?(lemen...@gmail.co |
|m) |
--- Comment #5 from Peter Lemenkov 2010-05-27 12:02:47 EDT
---
(In reply to comment #4)
> [+] PASS[-] FAIL [N/A] Not Applicable
>
> - MUST: rpmlint must be run on every package. The output should be posted in
> the review.
>
> $ rpmlint erlang-ibrowse-1.5.6-2.fc13.src.rpm
> erlang-ibrowse.src: W: invalid-url Source0: erlang-ibrowse-1.5.6.tar.bz2
> 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
>
> The Source0 line needs to use the %{alphatag} naming format since you are
> pulling from git. I see you're pulling from a git commit, but if there's a
> tag
> for the 1.5.6 release, that might be better to use.
> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages
Done. I'm explicitly using git commit's name in tarball now.
> - MUST: The License field in the package spec file must match the actual
> license.
>
> The License field indicates 'BSD or LGPLv2' but it should be 'BSD and LGPLv2'.
I'm afraid that you're wrong here.
"ibrowse is available under two different licenses. LGPL and the BSD license."
This sounds for me like ibrowse can be used either under LGPLv2+ (2+ is
explicitly stated in the attached license) or under BSD.
> - MUST: The spec file for the package MUST be legible.
>
> These are really just my own opinion. In general I think the spec file is
> perfectly legible, but since we are in review, I figured I'd point out these
> things:
>
> 1) The Requires: lines do not use a tab character to indent the value to the
> 16th column like the Name through BuildRequires lines.
Fixed. I added all these 'Requires' automatically, by using script, so this
discrepancy can probably occur.
> 2) The iconv line in the %prep section is long. I would suggest breaking up
> the line because the spill over on an 80 column terminal makes the "rm -f
> README.utf8" appear to be its own line, when really it's part of the entire
> iconv line.
Splitted in two lines.
New srpm+spec:
http://peter.fedorapeople.org/erlang-ibrowse.spec
http://peter.fedorapeople.org/erlang-ibrowse-1.6.0-0.1.gita114ed3b.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: RabbitVCS - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #25 from Kalev Lember 2010-05-27 11:47:44 EDT --- (In reply to comment #24) > I don't think it requires provides/obsoletes, as a simple version check would > make this package newer than the other one, and replace it properly. A simple version check would update the package if the name remained the same, but that's not the case here. What used to be rabbitvcs is now rabbitvcs-core. If someone installed rabbitvcs + rabbitvcs-nautilus from upstream page and now updates to the newer version in Fedora repos, the following will happen: 1) rabbitvcs package has no update so it will stay on the upstream version 2) rabbitvcs-nautilus will be updated 3) rabbitvcs-nautilus will pull in rabbitvcs-core 4) yum transaction check will fail because files from old rabbitvcs upstream package and rabbitvcs-core from Fedora repos will conflict. Proper way to fix it is by adding Obsoletes to rabbitvcs-core, but the question is if you want to preserve clean upgrade path from upstream packages or not. > I removed the unresolved dependency for rabbitvcs. It resolved here because I > wasn't properly removing and installing the rpms. I'll get a VM to properly > test the RPMs on a clean install. Yeah, I think it'd be a good idea to install packages from upstream page and try to update them to make sure they can be properly updated without having to uninstall anything by hand. > Thanks a lot for your time and observations. Glad to be of help. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591011] Review Request: kfilefactory - An easy to use filefactory.com uploader
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591011 --- Comment #8 from Magnus Tuominen 2010-05-27 11:39:14 EDT --- All issues mentioned are fixed, an icon is still missing and the %changelog in the spec is the wrong version. Other than that, I think it is good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592655] yelp-xsl XSL stylesheets for use with yelp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592655 Matthew Barnes changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Matthew Barnes 2010-05-27 11:32:35 EDT --- Approved. The timestamp thing seems silly to me, but we comply. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: RabbitVCS - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #24 from Juan Manuel Rodriguez 2010-05-27 11:11:00 EDT --- Hey Kalev, I've been providing upstream with their current RPMs based on an older snapshot of the rabbitvcs spec (In fact, I've been uploading them to the downloads list) I don't think it requires provides/obsoletes, as a simple version check would make this package newer than the other one, and replace it properly. I uploaded a newer spec/srpm, making rabbitvcs-cli noarch. The rest can't be noarch though. I removed the unresolved dependency for rabbitvcs. It resolved here because I wasn't properly removing and installing the rpms. I'll get a VM to properly test the RPMs on a clean install. SPEC: http://nushio.fedorapeople.org/rabbitvcs/rabbitvcs.spec SRPM: http://nushio.fedorapeople.org/rabbitvcs/rabbitvcs-0.13.1-2.fc13.src.rpm Thanks a lot for your time and observations. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596746] Review Request: bzr-explorer - A bzr GUI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596746 Terje Røsten changed: What|Removed |Added CC||terje...@phys.ntnu.no --- Comment #2 from Terje Røsten 2010-05-27 11:09:06 EDT --- Thanks for packaging this, I will have a closer look later. btw :bzr-gtk is orphaned in rawhide and seeking a maintainer: https://admin.fedoraproject.org/pkgdb/acls/name/bzr-gtk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582106] Review Request: lifeograph - Private digital diary.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582106 --- Comment #9 from Gowrishankar Rajaiyan 2010-05-27 11:04:38 EDT --- Hi Mamoru, New spec file and srpm have been uploaded. spec: http://gowrishankar.fedorapeople.org/spec/lifeograph.spec srpm: http://gowrishankar.fedorapeople.org/srpms/lifeograph-0.6.2-2.fc12.src.rpm I shall definitely pre-review of other person's review request or file a new review request at the earliest. Thank you once again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594943] Review Request: libnoise - A general-purpose library that generates three-dimensional coherent noise
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594943 --- Comment #21 from Robin Norwood 2010-05-27 10:56:39 EDT --- Oops - fixed the issue you mentioned in %install. How do these look? http://www.norwoodfamily.info/rpms/libnoise.spec http://www.norwoodfamily.info/rpms/libnoise-1.0.0-5.fc12.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=2213043 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596449] Review Request: NetworkManager-openswan - NetworkManager VPN plugin for Openswan (IPsec)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=596449
--- Comment #14 from Chen Lei 2010-05-27 11:00:11 EDT
---
Some comment:
1.
Source:%{name}-%{realversion}.tar.gz
Should add some comments about how to genrate the tarball
See http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
2.Epoch: 1
Remove it from spec, when possible packager should avoid of using epoch.
3.
BuildRoot: %{_tmppath}/%{name}-%{version}-root
Only needed for epel5
4.
%post
/sbin/ldconfig
%postun
/sbin/ldconfig
It's a plugin, I don't think ldconfig is necesscery
5.
%define nm_version 1:0.7.997-1
%define dbus_version1.1
%define gtk2_version2.10.0
%define shared_mime_version 0.16-3
Those lines are useless, all branches in fedora match those versions.
6.%{_datadir}/icons/hicolor/48x48/apps/gnome-mime-application-x-openswan-ipsec-vpn-settings.png
Is this file useful for openswan?
7.
%files -f %{name}.lang
%defattr(-, root, root)
->
%files -f %{name}.lang
%defattr(-, root, root,-)
8.
Requires: gtk2 >= %{gtk2_version}
Requires: dbus >= %{dbus_version}
Requires: shared-mime-info >= %{shared_mime_version}
Requires: GConf2
Those dependicies may not need, please reconsider it, normally rpmbuild will
pull in shlib depenpencies automatically.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 548795] Review Request: belier - Generates scripts allowing you to chain many ssh connections
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548795 --- Comment #8 from Florent Le Coz 2010-05-27 10:49:05 EDT --- SPEC URL: http://louizatakk.fedorapeople.org/rpm/belier.spec SRPM URL: http://louizatakk.fedorapeople.org/rpm/belier-1.2-3.fc13.src.rpm I changed python-setuptools-devel to python-setuptools. Also, it builds on koji, see: http://koji.fedoraproject.org/koji/taskinfo?taskID=2213026 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596449] Review Request: NetworkManager-openswan - NetworkManager VPN plugin for Openswan (IPsec)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596449 --- Comment #13 from Avesh Agarwal 2010-05-27 10:36:30 EDT --- (In reply to comment #10) > You've attached tar.gz instead of src.rpm. > Please put the updated .src.rpm to the fedorapeople web server as suggested by > Chen Lei above. Done: http://people.redhat.com/avagarwa/files/NetworkManager-openswan/ > > Note that you cannot comment out %define like you do: > #%define snapshot .git20100411 > Macros are expanded in comments in .spec. You have to remove the %. Not that > it > matters much. Instead commenting it, I have included it to make it consistent with other packages like NetworkManager-vpnc and NetworkManager-openvpn . > > Also please add the COPYING file as %doc in %files. Done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591011] Review Request: kfilefactory - An easy to use filefactory.com uploader
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591011 --- Comment #7 from Aditya Patawari 2010-05-27 10:37:45 EDT --- Latest Spec URL: http://adimania.fedorapeople.org/specs/kfilefactory.spec Latest src.rpm URL: http://adimania.fedorapeople.org/src.rpms/kfilefactory-0.1.1-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596449] Review Request: NetworkManager-openswan - NetworkManager VPN plugin for Openswan (IPsec)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596449 --- Comment #11 from Avesh Agarwal 2010-05-27 10:33:29 EDT --- Hello Chen, and Tomas, Thanks for comments: Here is the public link for the files: http://people.redhat.com/avagarwa/files/NetworkManager-openswan/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596449] Review Request: NetworkManager-openswan - NetworkManager VPN plugin for Openswan (IPsec)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=596449
--- Comment #12 from Avesh Agarwal 2010-05-27 10:34:52
EDT ---
(In reply to comment #9)
> It'll be better to change %define snapshot .git20100411 to %define snapshot
> .20100411git or .%{gitdate}git%{githash}.
>
> The naming style for the NetworkManger seems a little different compared to
> other packages in fedora.
>
> See http://fedoraproject.org/wiki/PackageNamingGuidelines#Pre-Release_packages
The naming style for NetworkManager-openswan, I have taken, is based on
NetworkManager-vpnc and NetworkManager-openvpn , so that this new package is
consistent with them.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591011] Review Request: kfilefactory - An easy to use filefactory.com uploader
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591011 --- Comment #6 from Aditya Patawari 2010-05-27 10:35:05 EDT --- I have updated the package and spec for new version and fixed all the issues pointed out by Magnus Tuominen. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592655] yelp-xsl XSL stylesheets for use with yelp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592655 --- Comment #4 from Matthias Clasen 2010-05-27 10:26:09 EDT --- New version http://mclasen.fedorapeople.org/yelp-xsl.spec http://mclasen.fedorapeople.org/yelp-xsl-2.31.1-2.fc14.src.rpm changes - use install -p - fix %version} typo - add Group tag -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562470] Review Request: openvas-client - Client component of Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562470 --- Comment #19 from Sergio Pascual 2010-05-27 10:14:16 EDT --- I was testing the application. The users manual under help doesnt work, The popup menu says: PDF file //usr/share/doc/openvas-manual/users-manual.pdf not found. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562470] Review Request: openvas-client - Client component of Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562470 --- Comment #18 from Sergio Pascual 2010-05-27 10:11:09 EDT --- (In reply to comment #9) > Hello guys, > If I can add opinion to the discussion - I would preffer the sysconfdir owned > by 1 package and as the libraries is the common baseline, it seems logical it > will be this package ovning the directory. > Best regards > Michal Ambroz What about creating a openvas-common subpackage that owns the common directories? There are quite a few -common subpackages with this purpose -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592655] yelp-xsl XSL stylesheets for use with yelp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592655 --- Comment #3 from Matthias Clasen 2010-05-27 09:54:47 EDT --- > As per http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps, you > should > use following > > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" I still have to find somebody who can explain a tangible benefit of this, other than giving reviewers the good feeling that they have something to criticize. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555990] Review Request: rubygems-acts-as-list - Sorting and reordering capabilities for ActiveRecord model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555990 Karel Klíč changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Karel Klíč 2010-05-27 09:39:39 EDT --- New Package CVS Request === Package Name: rubygems-acts-as-list Short Description: Sorting and reordering capabilities for Active Record models Owners: kklic Branches: F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594839] Review Request: kpartsplugin - KParts technology to embed file viewers into non-KDE browsers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594839 Thomas Janssen changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-cvs? --- Comment #5 from Thomas Janssen 2010-05-27 09:43:21 EDT --- Thanks for the review Magnus, will fix that in cvs. New Package CVS Request === Package Name: kpartsplugin Short Description: KParts technology to embed file viewers into non-KDE browsers Owners: thomasj Branches: F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582106] Review Request: lifeograph - Private digital diary.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582106 Bug 582106 depends on bug 596433, which changed state. Bug 596433 Summary: Behavior change for .private dependency causes rpm dependency detection breakage https://bugzilla.redhat.com/show_bug.cgi?id=596433 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596746] New: Review Request: bzr-explorer - A bzr GUI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: bzr-explorer - A bzr GUI https://bugzilla.redhat.com/show_bug.cgi?id=596746 Summary: Review Request: bzr-explorer - A bzr GUI Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: julian.fed...@googlemail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://julian.fedorapeople.org/bzr-explorer/bzr-explorer.spec SRPM URL: http://julian.fedorapeople.org/bzr-explorer/bzr-explorer-1.0.1-1.fc13.src.rpm Description: Bazaar Explorer is a desktop application for using the Bazaar Version Control System. It provides a high level interface to all commonly used features. Functionality of this package can be extended by installing bzr-gtk. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
