[Bug 760897] Review Request: libeasyfc - Easy configuration generator interface for fontconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760897 Akira TAGOH changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Akira TAGOH 2011-12-08 01:54:41 EST --- Thanks for the review. will fix the doc thing once the package is imported. New Package SCM Request === Package Name: libeasyfc Short Description: Easy configuration generator interface for fontconfig Owners: tagoh Branches: f15 f16 InitialCC: i18n-team -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 470696] Review Request: rubygem-passenger - Passenger Ruby on Rails deployment system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470696 --- Comment #105 from Hongli Lai 2011-12-08 00:25:26 EST --- Glad to hear. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760897] Review Request: libeasyfc - Easy configuration generator interface for fontconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760897 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review+ --- Comment #3 from Parag AN(पराग) 2011-12-08 00:01:45 EST --- Review: + koji scratch build in f17 ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3573455 + rpmlint on rpms gave libeasyfc.src: W: spelling-error Summary(en_US) fontconfig -> configuration libeasyfc.src: W: spelling-error %description -l en_US fontconfig -> configuration libeasyfc.x86_64: W: spelling-error Summary(en_US) fontconfig -> configuration libeasyfc.x86_64: W: spelling-error %description -l en_US fontconfig -> configuration libeasyfc-devel.x86_64: W: spelling-error %description -l en_US fontconfig -> configuration libeasyfc-gobject.x86_64: W: spelling-error %description -l en_US fontconfig -> configuration libeasyfc-gobject-devel.x86_64: W: spelling-error %description -l en_US fontconfig -> configuration 5 packages and 0 specfiles checked; 0 errors, 7 warnings. + source verified with upstream as 3e130155e357f26bb8112dad10ac1eca2d8ce608 libeasyfc-0.1.tar.bz2 3e130155e357f26bb8112dad10ac1eca2d8ce608 ../SOURCES/libeasyfc-0.1.tar.bz2 suggestions: 1) If not planning for RHEL then remove a) buildroot b) %clean section c) cleaning of buildroot in %install d) %defattr(-, root, root, -) 2) I think only base package should add docs files in %doc and not subpackages. See http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697247] Review Request: gsmartcontrol - Graphical user interface for smartctl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697247 Eric Smith changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Eric Smith 2011-12-07 23:39:58 EST --- New Package SCM Request === Package Name: gsmartcontrol Short Description: Graphical user interface for smartctl Owners: brouhaha Branches: f16 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761319] New: Fedora 17 feature GTKD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Fedora 17 feature GTKD https://bugzilla.redhat.com/show_bug.cgi?id=761319 Summary: Fedora 17 feature GTKD Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: bioinfornat...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Created attachment 542346 --> https://bugzilla.redhat.com/attachment.cgi?id=542346 spec file scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3573442 rpmlint spec: $ rpmlint ~/rpmbuild/SPECS/gtkd.spec ../SPECS/gtkd.spec:20: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 20) ../SPECS/gtkd.spec: W: invalid-url Source0: gtkd-20111024svn906.tar.xz 0 packages and 1 specfiles checked; 0 errors, 2 warnings. $ rpmlint ~/rpmbuild/SRPMS/gtkd-1.5.1-5.20111024svn906.fc16.src.rpm $ rpmlint ~/rpmbuild/SRPMS/gtkd-1.5.1-5.20111024svn906.fc16.src.rpm gtkd.src: W: spelling-error Summary(fr) It -> T, Itô, Dt gtkd.src: W: spelling-error Summary(fr) is -> si, us, os gtkd.src: W: spelling-error Summary(fr) binding -> building gtkd.src: W: spelling-error Summary(fr) and -> ans, an, ad gtkd.src: W: spelling-error Summary(fr) wrapper -> rapper, frapper, w rapper gtkd.src: W: spelling-error Summary(fr) of -> off, if, or gtkd.src: W: spelling-error %description -l fr multi -> mufti, multiple gtkd.src: W: invalid-url Source0: gtkd-20111024svn906.tar.xz 1 packages and 0 specfiles checked; 0 errors, 8 warnings. Source files contain lgl v2 and COPYING lgpl v3 this will be fixed soon by upstream: http://www.dsource.org/projects/gtkd/ticket/113#comment:1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721174] Review Request: cryptominisat - SAT solver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721174 --- Comment #10 from Fedora Update System 2011-12-07 20:54:26 EST --- cryptominisat-2.9.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/cryptominisat-2.9.1-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 748329] Review Request: ibus-panel-extensions - Additional UI service components for IBus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=748329 --- Comment #4 from Daiki Ueno 2011-12-07 20:51:31 EST --- I finally released a new version and updated the package. It should reflect both of your suggestions 1 and 2. Spec URL: http://ueno.fedorapeople.org/ibus-panel-extensions/ibus-panel-extensions.spec SRPM URL: http://ueno.fedorapeople.org/ibus-panel-extensions/ibus-panel-extensions-1.4.99.20111207-1.fc17.src.rpm Sorry for taking so long. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721174] Review Request: cryptominisat - SAT solver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721174 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 470696] Review Request: rubygem-passenger - Passenger Ruby on Rails deployment system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470696 --- Comment #104 from Brett Lentz 2011-12-07 19:39:22 EST --- I'm pleased to report that Boost has accepted the EINTR patch in its entirety. https://svn.boost.org/trac/boost/ticket/6200 This just leaves the stack trace bits as the last major portion to be upstreamed, AFAIK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 722640] Review Request: R-qcc - SQC package for R
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722640 --- Comment #17 from John J. McDonough 2011-12-07 19:21:21 EST --- New Package SCM Request === Package Name: R-qcc Short Description: An R package for quality control charting and statistical process control. Owners: jjmcd Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754698] Review Request: idjc - DJ application with streaming capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754698 --- Comment #12 from Fedora Update System 2011-12-07 16:47:58 EST --- idjc-0.8.6-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/idjc-0.8.6-4.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755093] Review Request: mactel-boot - boot tools for Intel Apple hardware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755093 --- Comment #23 from Chris Murphy 2011-12-07 16:51:47 EST --- I'm not sure what is meant by "firmware update capsule". The binary data and version is identical for this file on two different hardware models, which each claim different EFI firmware revisions. EFI firmware updates have always required user authentication to be applied. This file is dropped without any user notification at all. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754698] Review Request: idjc - DJ application with streaming capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754698 Nikos Roussos changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE Last Closed||2011-12-07 16:22:04 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755066] Review Request: chromaprint - Library implementing the AcoustID fingerprinting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755066 --- Comment #9 from Ismael Olea 2011-12-07 12:30:37 EST --- New Package SCM Request === Package Name: chromaprint Short Description: Library implementing the AcoustID fingerprinting Owners: olea Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761063 --- Comment #8 from Jayson Vaughn 2011-12-07 16:22:36 EST --- Ok, I've made the suggested changes to the spec file. I've also added OGG and FLAC support to this application upstream so I re-packaged it. Here are the new files: Spec URL: http://69.164.204.114/cover_grabber.spec SRPM URL: http://69.164.204.114/cover_grabber-1.0.0-1.fc16.src.rpm rpmlint output: cover_grabber.src: W: spelling-error %description -l en_US ogg -> egg, org, boggy cover_grabber.src: W: spelling-error %description -l en_US covergrabber -> cover grabber, cover-grabber, recoverable cover_grabber.noarch: W: spelling-error %description -l en_US ogg -> egg, org, boggy cover_grabber.noarch: W: no-manual-page-for-binary covergrabber 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3573245 I really appreciate all your help! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 504151] Review Request: python-iterthreader - Threaded itertools.imap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504151 Simon Green changed: What|Removed |Added CC||rvo...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755093] Review Request: mactel-boot - boot tools for Intel Apple hardware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755093 --- Comment #21 from Matthew Garrett 2011-12-07 16:32:32 EST --- No, I'm suggesting that /boot/efi be HFS+ - there's no requirement that it be the EFI system partition. The secure boot side of things is something that we're going to have to manage on non-Apple EFI platforms, and we don't want to build separate grub images for the two situations. The nvram information is, as far as I've been able to tell, used by some of the Apple UI tools rather than being something necessary for the firmware, but that's something we may need to play with. The Firmware.scap files are firmware update capsules. They've probably been dropped there by the Apple software update utility. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755093] Review Request: mactel-boot - boot tools for Intel Apple hardware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755093 --- Comment #25 from Chris Murphy 2011-12-07 17:49:53 EST --- Interesting. I'm not sure if this file is significant for EFI boot or CSM-BIOS or both or neither. Just today for the first time I am (was) able to get an EFI boot with X starting up (anaconda from F16 DVD, and gnome from the resulting installation). On a MBP 4,1, previous attempts resulted in display hang as described in bug 751147. It's been a while, but in previous attempts I'm pretty sure they were bare disks and the Firmware.scap file could not have been present if true. Today's attempt is on a MBP4,1 with this Firmware.scap file on its EFI System partition. However, the problem I'm now having after one successful boot and startup to Gnome's login window (and logging in then rebooting) is that without any changes I can't get a successful boot+startup to a gnome login. I get a different boot experience each time, usually a hang in GRUB Legacy which I can ESC from to reload GRUB but subsequent boots fail the same way. The second most frequent boot experience is failure to unpack initramfs followed by a kernel panic. And the one after that, completely black screen but apparently a successful boot as I was able to blindly switch to F2 tty shell, login as root, save dmesg to file and reboot. Getting such wildly different boot results while not seemingly changing any parameters, is making testing very difficult. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759855] Review Request: sslh - A SSL/SSH multiplexer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759855 --- Comment #3 from Christian Vanguers 2011-12-07 17:12:57 EST --- Thanks for the comments Aleksandra. I'm currently reviewing the spec file to take your remarks in account, and I'll come back with a new spec and srpm. Regards, Chris -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728504] Review Request: jboss-sasl - SASL Provider for J2SE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728504 Alexander Kurtakov changed: What|Removed |Added CC||akurt...@redhat.com --- Comment #5 from Alexander Kurtakov 2011-12-07 10:24:36 EST --- Fails to build [INFO] [INFO] Skipping jboss-sasl [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 4.187s [INFO] Finished at: Wed Dec 07 15:16:25 UTC 2011 [INFO] Final Memory: 27M/379M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.10:test (default-test) on project jboss-sasl: Unable to generate classpath: org.apache.maven.artifact.resolver.MultipleArtifactsNotFoundException: Missing: [ERROR] -- [ERROR] 1) org.apache.maven.surefire:surefire-junit4:jar:2.10 [ERROR] [ERROR] Try downloading the file manually from the project website. [ERROR] [ERROR] Then, install it using the command: [ERROR] mvn install:install-file -DgroupId=org.apache.maven.surefire -DartifactId=surefire-junit4 -Dversion=2.10 -Dpackaging=jar -Dfile=/path/to/file [ERROR] [ERROR] Alternatively, if you host your own repository you can deploy the file there: [ERROR] mvn deploy:deploy-file -DgroupId=org.apache.maven.surefire -DartifactId=surefire-junit4 -Dversion=2.10 -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] [ERROR] [ERROR] Path to dependency: [ERROR] 1) dummy:dummy:jar:1.0 [ERROR] 2) org.apache.maven.surefire:surefire-junit4:jar:2.10 [ERROR] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755890
--- Comment #15 from Richard Shaw 2011-12-07 17:19:33
EST ---
Ack! Sorry I keep finding stuff :)
1. There's no documentation in the main package. I would include a line like
this, with our without the PDF depending on if it's relevant:
%files
%doc CHANGELOG LICENSE README docs/paper.pdf
... rest of %files section ...
2. Do we need python2 if we're building with python3?
If not change your BuildRequires to:
%if 0%{?with_python3}
BuildRequires: python3-devel
%else
BuildRequires: python2-devel
%endif # if with_python3
Richard
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754698] Review Request: idjc - DJ application with streaming capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754698 --- Comment #13 from Fedora Update System 2011-12-07 16:48:50 EST --- idjc-0.8.6-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/idjc-0.8.6-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755890
--- Comment #14 from Mo Morsi 2011-12-07 16:53:19 EST ---
Thanks for the review. Will try to take a look at your package in a bit.
Updated Submission:
New Spec: http://mo.morsi.org/files/rpms/snap.spec
New SRPM: http://mo.morsi.org/files/rpms/snap-0.5-5.fc15.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3573274
(In reply to comment #12)
> Ok, I took a look at the new spec ans srpm. I ran rpmlint on the results:
>
> $ rpmlint mockbuild/15/snap/*.rpm
> snap.src: W: file-size-mismatch snap-0.5.tgz = 706769,
> http://mo.morsi.org/files/snap/snap-0.5.tgz = 702522
> snap-gtk.noarch: W: spelling-error %description -l en_US frontend -> fronted,
> front end, front-end
> snap-gtk.noarch: W: spelling-error %description -l en_US snapshotter -> snaps
> hotter, snaps-hotter, snapshot
> snap-gtk.noarch: W: no-documentation
> snap-gtk.noarch: W: no-manual-page-for-binary gsnap
> 3 packages and 0 specfiles checked; 0 errors, 5 warnings.
>
> Since you're technically "upstream" for this I assume you can fix the
> file-size-mismatch issue?
>
Done. Updated source uploaded and the srpm rebuilt.
> The other warnings can be ignored.
>
> Also, I changed two things in your spec. Not functional issues but more
> readability/good practices related.
>
> 1. Right at the beginning of %install where you create directories I changed
> it
> to:
> %install
> mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1 \
> $RPM_BUILD_ROOT%{_iconsscaldir} \
> $RPM_BUILD_ROOT%{_icons48dir}
>
> instead of letting them wrap at 80 characters.
Done
>
> 2. Although rpmlint didn't complain about the symbolic links for the manpage
> (it will if the source path is absolute path rather than relative). It still
> has a much longer path than necessary. The better practice is to change to one
> of the directories (in this case the source and destination paths are the
> same)
> and create the link there with a minimal path, i.e.:
>
> pushd $RPM_BUILD_ROOT/%{_mandir}/man1
> ln -s snap.1.gz snaptool.1.gz
>
> which will change the result from:
> -rw-r--r--. 1 build build 485 Dec 7 08:38 snap.1.gz
> lrwxrwxrwx. 1 build build 29 Dec 7 08:38 snaptool.1.gz ->
> /usr/share/man/man1/snap.1.gz
>
> to:
> -rw-r--r--. 1 build build 485 Dec 7 08:38 snap.1.gz
> lrwxrwxrwx. 1 build build 29 Dec 7 08:38 snaptool.1.gz -> snap.1.gz
Done
(In reply to comment #13)
> Ok, two more things:
>
> 1. If python 2.7 is going to be supported you need to update the Requires for
> snap-gtk to something like:
>
> %if 0%{?with_python3}
> Requires: pygobject3
> %else
> Requires: pygobject2
> %endif
>
> Since pygobject3 doesn't exist on F15 and even if it did it would require that
> python3 be used.
Done
>
> 2. Also, I tried running it on a remote X11 session over ssh and when I
> clicked
> the "Backup" button I got the following in the terminal:
>
> $ gsnap
> Traceback (most recent call last):
> File "/usr/bin/gsnap", line 83, in show_backup_window
> backup_window = BackupOperationWindow()
> File "/usr/bin/gsnap", line 122, in __init__
> snapfile = snap.options.DEFAULT_SNAPFILE + "-" + snapfile_id + ".tgz"
> AttributeError: 'module' object has no attribute 'DEFAULT_SNAPFILE'
>
> Richard
Ah ya this is an upstream bug. Will look into fixing for the next release.
Appreciate it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755093] Review Request: mactel-boot - boot tools for Intel Apple hardware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755093 --- Comment #24 from Matthew Garrett 2011-12-07 17:02:44 EST --- If you pull it apart with one of the efi capsule management tools you'll find a pile of guids that match uefi functions. They may simply be overrides for some machine non-specific code. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755093] Review Request: mactel-boot - boot tools for Intel Apple hardware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755093 --- Comment #22 from Chris Murphy 2011-12-07 16:42:04 EST --- Created attachment 542205 --> https://bugzilla.redhat.com/attachment.cgi?id=542205 nvram -p output from MBP8,2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761063 --- Comment #6 from Jayson Vaughn 2011-12-07 14:24:19 EST --- Oh, Duh. I knew these would be variables anyway. OK I made the changes you mentioned. Same URLs as above for the new SRPM and new spec file. Here is the Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3573082 Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760645] Review Request: ergo - A quantum chemistry program for large-scale self-consistent field calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760645 --- Comment #6 from Terje Røsten 2011-12-07 16:03:34 EST --- Very nice, F16 build not needed, thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=761063
--- Comment #7 from Terje Røsten 2011-12-07 15:59:15
EST ---
I like line up the tags like this:
Summary: Download album cover art
Name: cover_grabber
Version: 0.0.2
Release: 1%{?dist}
you might want that.
Your BuildRoot: tag seems too simple. (Or you can remove it.)
%setup -q cover_grabber-0.0.2
You can drop the cover_grabber-0.0.2 here
Please use the %changelog and increase release when you do changes.
Also innclude links to updated spec and srpm in each update comment.
It's them much simpler for the reviewer to follow the process.
koji build looks good, thanks.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757156] Review Request: perl-Env-C - Get/Set/Unset Environment Variables on the C level
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=757156
--- Comment #9 from Jan "Yenya" Kasprzak 2011-12-07 15:53:41
EST ---
Re: comment #7
> Regarding your plans for participation in Fedora, do you see yourself sticking
> to perl modules or might you have other things to bring in in the future?
I want to contribute packages which I need myself, but recently everything I
have needed was already packaged except some Perl modules. So for now, I will
stick with Perl modules. (context: I have been building RPM packages for at
least 12 years now, does anybody here remember Red Hat Contrib|Net, the early
community packaging effort for Red Hat Linux?).
> Are there any more "leaf" packages, that don't have any non-Fedora
> dependencies?
E.g. perl-TeX-Encode, perl-Scalar-String, perl-IO-Socket-Multicast,
perl-Data-Integer, perl-Data-Float, or perl-DBD-ODBC.
> > Also, they all currently have
> > the problem mentioned in comment #1 (directory ownership of
> > %{perl_vendorarch}... as created by cpanspec).
>
> This is more a matter of taste.
Well, perhaps the Packaging:Perl wiki page should be modified to not have this
requirements then? (I cannot check the exact wording as Fedora wiki currently
says 503 Service Unavailable for me).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760897] Review Request: libeasyfc - Easy configuration generator interface for fontconfig
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760897
--- Comment #2 from Fabien Archambault 2011-12-07
16:15:08 EST ---
Hi again,
I made the informal review using guidelines:
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint libeasyfc-0.1-1.fc16.src.rpm
libeasyfc.src: W: spelling-error Summary(en_US) fontconfig -> configuration
libeasyfc.src: W: spelling-error %description -l en_US fontconfig ->
configuration
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint libeasyfc-0.1-1.fc16.x86_64.rpm
libeasyfc.x86_64: W: spelling-error Summary(en_US) fontconfig -> configuration
libeasyfc.x86_64: W: spelling-error %description -l en_US fontconfig ->
configuration
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint libeasyfc-debuginfo-0.1-1.fc16.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint libeasyfc-devel-0.1-1.fc16.x86_64.rpm
libeasyfc-devel.x86_64: W: spelling-error %description -l en_US fontconfig ->
configuration
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint libeasyfc-gobject-0.1-1.fc16.x86_64.rpm
libeasyfc-gobject.x86_64: W: spelling-error %description -l en_US fontconfig ->
configuration
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint libeasyfc-gobject-devel-0.1-1.fc16.x86_64.rpm
libeasyfc-gobject-devel.x86_64: W: spelling-error %description -l en_US
fontconfig -> configuration
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
-> OK
MUST: The package must be named according to the Package Naming Guidelines.
-> OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
-> OK
MUST: The package must meet the Packaging Guidelines.
-> OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
-> OK
MUST: The License field in the package spec file must match the actual license.
Checking against COPYING file
-> OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
-> OK
MUST: The spec file must be written in American English.
-> OK
MUST: The spec file for the package MUST be legible.
-> OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
md5sum:
4f8b7096878ef6e955a31f5e6f622242 libeasyfc-0.1.tar.bz2
-> OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
-> OK
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
-> N/A
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
-> OK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
-> N/A
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
-> OK
MUST: Packages must NOT bundle copies of system libraries.
-> OK
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
-> N/A
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
-> OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
-> OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example.
-> OK
MUST: Each package must consistently use macros.
-> OK
MUST: The package must contain code, or permissable content.
-> OK
MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not rest
[Bug 755093] Review Request: mactel-boot - boot tools for Intel Apple hardware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755093 --- Comment #20 from Chris Murphy 2011-12-07 16:12:39 EST --- > The model here is for /boot/efi to be an HFS+ partition rather than a FAT one. 1. Am I reading this correctly? Are you suggesting an hfs+ EFI System partition rather than FAT32? Apple's own EFI System partition is FAT32. The UEFI spec requires that it be FAT (FAT32 for all practical purposes). I understand that this is not UEFI, but do you propose a 2nd EFI System partition that's hfs+? Or reformatting the existing one? 2. When referred to "secure boot" and Apple hardware, do you mean UEFI 2.3.1 secure boot? Or Intel TXT Trusted Boot? Or other? I ask because none of Apple's hardware has UEFI 2.x compliant firmware, let alone 2.3.1. 3. Question: Is there something in NVRAM that Apple's EFI depends on that efibootmgr doesn't use? The Mac OS X 'nvram -p' produces more information than efibootmgr. Attached is output from that command for a MacBookPro 8,2. 4. On the EFI System partition I'm finding a 15MB file /EFI/APPLE/EXTENSIONS/Firmware.scap on two computers. Apple MBP 4,1 (2008), MBP 8,2 (2011). Diff claims they are identical. The file is not present after partitioning/formatting with Apple Disk Utility, or after installation of either Mac OS 10.6.x or 10.7.x. It appears within a few minutes of the very first login following Mac OS installation if the system has an internet connection. Does anyone know what this file is? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757156] Review Request: perl-Env-C - Get/Set/Unset Environment Variables on the C level
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757156 --- Comment #8 from Jan "Yenya" Kasprzak 2011-12-07 15:34:19 EST --- OK, here is the quoted discussion with the upstream package author. Lines prefixed with ">" are mine, and lines prefixed with ":" are written by the package author: : > : Personally, I don't really care which exact of the free-as-a-beer : > : license is used, GPL, Artistic XYZ, or whatever you'd like it to be. : > : > OK. So "the same terms as Perl itself" would be OK with you? : [...] : > So if you say "the same terms as Perl itself" or "Artistic 2.0" : > or "Artistic clarified" is OK with you, I would be able to package : > Env::C for Fedora. : : Yes, either of the above works. I doubt I'll release a new version of : the module just to tweak this, unless it's really important. Perhaps : you can just quote this communication as a proof. Is it sufficient to have it this way and keep License: Artistic 2.0 in the spec file? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760897] Review Request: libeasyfc - Easy configuration generator interface for fontconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760897 Fabien Archambault changed: What|Removed |Added CC||marbolan...@gmail.com --- Comment #1 from Fabien Archambault 2011-12-07 15:34:26 EST --- Hi, I am willing to do an informal review of your package but first, within the Package Review Guidelines [1] you: MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [1] http://fedoraproject.org/wiki/Packaging:ReviewGuidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755093] Review Request: mactel-boot - boot tools for Intel Apple hardware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755093 Adam Williamson changed: What|Removed |Added CC||awill...@redhat.com, ||bugzi...@colorremedies.com --- Comment #19 from Adam Williamson 2011-12-07 13:25:35 EST --- I'm going to take the liberty of CCing Chris Murphy on this, as he's fairly clued up on Mac booting issues and may be able to help with testing/review. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749299] Review Request: lcgdm-dav - HTTP/DAV frontend to the DPM/LFC services
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749299 --- Comment #12 from Steve Traylen 2011-12-07 14:41:12 EST --- You asked about the scripts: %preun server if [ $1 -eq 0 ] ; then /sbin/service httpd stop > /dev/null 2>&1 fi %postun server if [ $1 -ge 1 ]; then /sbin/service httpd condrestart > /dev/null 2>&1 || : fi so definitely the server should not be stopped on removal since it may well be doing another job as well. In all cases a service httpd reload is really what you want. Finally you load modules that are already loaded which results in an ugly warning at start up. # service httpd start Starting httpd: [Wed Dec 07 20:39:10 2011] [warn] module dav_module is already loaded, skipping [Wed Dec 07 20:39:10 2011] [warn] module dav_fs_module is already loaded, skipping [Wed Dec 07 20:39:10 2011] [warn] module deflate_module is already loaded, skipping [Wed Dec 07 20:39:10 2011] [warn] module expires_module is already loaded, skipping [Wed Dec 07 20:39:10 2011] [warn] module ssl_module is already loaded, skipping [Wed Dec 07 20:39:10 2011] [warn] module gridsite_module is already loaded, skipping I appreciate you may need to do some ordering here in /etc/httpd/conf.d by renaming. It's also possible to conditionally load modules that are not loaded. Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761063 Jayson Vaughn changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749299] Review Request: lcgdm-dav - HTTP/DAV frontend to the DPM/LFC services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=749299
--- Comment #11 from Steve Traylen 2011-12-07 14:35:19
EST ---
Hi,
The explicit
%if %{?fedora}%{!?fedora:0} >= 10 || %{?rhel}%{!?rhel:0} >= 6
BuildRequires: libcurl-devel
%else
BuildRequires: curl-devel
%endif
on devel package is not needed, it's there on the main package which
is good enough.
Regarding the static html files
/var/www/css
/var/www/css/lcgdm-dav.css
/var/www/icons
/var/www/icons/dpm20.png
these are a web application so move them to
/usr/share/lcgdm-dav
and update alias to use them.
http://fedoraproject.org/wiki/Packaging:Guidelines#Web_Applications
Also the httpd configuration takes of the web server with
DAV dpm
so now everything is dpmdav regardless of what else is installed.
could this be restricted to some default path prefix?
Also the configuration contains:
ProxyCache /var/proxycache
this directory does not exist but more importantly it if is needed
it should be in /var/lib/lcgdpm-dav or something.
Steve.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754137] Review Request: nagios-plugins-bdii - Nagios Probe for the BDII
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754137 Steve Traylen changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #20 from Steve Traylen 2011-12-07 13:34:08 EST --- Source matches after s/_1_0_12/_1_0_13/ svn export http://svnweb.cern.ch/guest/gridinfo/nagios-plugins-bdii/tags/R_1_0_13 nagios-plugins-bdii-1.0.13 I believe the %description should be longer but it is not a requirement. Check it basically runs: /usr/lib64/nagios/plugins/check_bdii_entries Error: Hostname ( -H option ) not specified. Usage: check_bdii_entries -H host [OPTION] Options: -p The port of the BDII -b The base of the BDII -f The filter to use for the search -f Note: Shortcuts 'site', 'service' and 'stats' can be Fine Only problem As there is now a license file please include it : https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text Please fix the above before import. PACKAGE APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754137] Review Request: nagios-plugins-bdii - Nagios Probe for the BDII
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754137 Steve Traylen changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752829] Review Request: glue-validator - A validation framework for GLUE 2.0 information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752829 --- Comment #18 from Steve Traylen 2011-12-07 13:48:12 EST --- I see there are some tests in 'tests/' can they be executed in a %check. http://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752829] Review Request: glue-validator - A validation framework for GLUE 2.0 information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752829 Steve Traylen changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760645] Review Request: ergo - A quantum chemistry program for large-scale self-consistent field calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760645 --- Comment #3 from Mohamed El Morabity 2011-12-07 12:05:03 EST --- (In reply to comment #1) > Are you sure that this is the GPLv3+ version? The project site states only GPL > without proper versioning, so you probably need to clarify it. Each source file refer to the GPLv3 or more in its comments. > And it seems that except man-pages and small license question, the package > fits > all the guidelines. Hope to see it soon in the repos. Man pages are not mandatory, it's up to upstream developers, it's not a blocker for a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760645] Review Request: ergo - A quantum chemistry program for large-scale self-consistent field calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760645 --- Comment #5 from Fabien Archambault 2011-12-07 13:43:17 EST --- Hi, I have build against F17 the rpms in koji: - http://koji.fedoraproject.org/koji/taskinfo?taskID=3572928 Also for Epel6: - http://koji.fedoraproject.org/koji/taskinfo?taskID=3572936 Do I need to build it against F16? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752829] Review Request: glue-validator - A validation framework for GLUE 2.0 information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752829 --- Comment #17 from Steve Traylen 2011-12-07 13:22:13 EST --- As upstream has now added a LICENSE file please include it as a %doc in the package. The description appears to have got even shorter, can it not be made useful to strangers. It's not a requirement but it's probably better if it was expanded. Fails at runtime: # glue-validator Traceback (most recent call last): File "/usr/bin/glue-validator", line 7, in import validator.utils ImportError: No module named validator.utils on centos6 + cl + epel. Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761063 --- Comment #5 from Terje Røsten 2011-12-07 12:54:08 EST --- Yes, remove all %define, these will be variables any way (just try), expect unmangled_version, however unmangled_version == version any way. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755890
--- Comment #12 from Richard Shaw 2011-12-07 09:43:04
EST ---
Ok, I took a look at the new spec ans srpm. I ran rpmlint on the results:
$ rpmlint mockbuild/15/snap/*.rpm
snap.src: W: file-size-mismatch snap-0.5.tgz = 706769,
http://mo.morsi.org/files/snap/snap-0.5.tgz = 702522
snap-gtk.noarch: W: spelling-error %description -l en_US frontend -> fronted,
front end, front-end
snap-gtk.noarch: W: spelling-error %description -l en_US snapshotter -> snaps
hotter, snaps-hotter, snapshot
snap-gtk.noarch: W: no-documentation
snap-gtk.noarch: W: no-manual-page-for-binary gsnap
3 packages and 0 specfiles checked; 0 errors, 5 warnings.
Since you're technically "upstream" for this I assume you can fix the
file-size-mismatch issue?
The other warnings can be ignored.
Also, I changed two things in your spec. Not functional issues but more
readability/good practices related.
1. Right at the beginning of %install where you create directories I changed it
to:
%install
mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1 \
$RPM_BUILD_ROOT%{_iconsscaldir} \
$RPM_BUILD_ROOT%{_icons48dir}
instead of letting them wrap at 80 characters.
2. Although rpmlint didn't complain about the symbolic links for the manpage
(it will if the source path is absolute path rather than relative). It still
has a much longer path than necessary. The better practice is to change to one
of the directories (in this case the source and destination paths are the same)
and create the link there with a minimal path, i.e.:
pushd $RPM_BUILD_ROOT/%{_mandir}/man1
ln -s snap.1.gz snaptool.1.gz
which will change the result from:
-rw-r--r--. 1 build build 485 Dec 7 08:38 snap.1.gz
lrwxrwxrwx. 1 build build 29 Dec 7 08:38 snaptool.1.gz ->
/usr/share/man/man1/snap.1.gz
to:
-rw-r--r--. 1 build build 485 Dec 7 08:38 snap.1.gz
lrwxrwxrwx. 1 build build 29 Dec 7 08:38 snaptool.1.gz -> snap.1.gz
Full review to come.
Richard
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760270] Review Request: lv2-ams-plugins - LV2 port of the Alsa Modular Synth modules
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760270
--- Comment #2 from Brendan Jones 2011-12-07
13:18:32 EST ---
LV2 is basically analogous to the windows VST plugin framework developed by
Steinberg, albeit much more advanced in many ways. LV2 plugins are used in many
audio / pro-audio host software applications such as Ardour and QTractor,
lv2rack and the like.
From http://lv2plug.in/trac/
LV2 is a plugin standard for audio systems. It defines a minimal yet extensible
C API for plugin code and a format for plugin "bundles".
LV2 is a successor of LADSPA that aims to remain simple yet adds extensibility
which enables more advanced plugin functionality (e.g. MIDI or graphical
interfaces).
From yum info lv2core:
Name: lv2core
Arch: x86_64
Version : 4.0
Release : 3.fc16
Size: 50 k
Repo: installed
From repo : fedora
Summary : Audio Plugin Standard
URL : http://lv2plug.in
License : LGPLv2+ and MIT
Description : LV2 is a standard for plugins and matching host applications,
mainly
: targeted at audio processing and generation.
:
: There are a large number of open source and free software
synthesis
: packages in use or development at this time. This API ('LV2')
attempts
: to give programmers the ability to write simple 'plugin' audio
: processors in C/C++ and link them dynamically ('plug') into a
range of
: these packages ('hosts'). It should be possible for any host and
any
: plugin to communicate completely through this interface.
:
: LV2 is a successor to LADSPA, created to address the limitations
of
: LADSPA which many hosts have outgrown.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721174] Review Request: cryptominisat - SAT solver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721174 --- Comment #9 from Jon Ciesla 2011-12-07 12:53:18 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755066] Review Request: chromaprint - Library implementing the AcoustID fingerprinting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755066 Ismael Olea changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761063 --- Comment #2 from Jayson Vaughn 2011-12-07 12:05:47 EST --- I had to update GPL license info on all files to get rid of "incorrect-fsf-address" error in rpmlint. Here is newest rpmlint output: cover_grabber.src: W: spelling-error %description -l en_US covergrabber -> cover grabber, cover-grabber, recoverable cover_grabber.noarch: W: no-manual-page-for-binary covergrabber 2 packages and 1 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760270] Review Request: lv2-ams-plugins - LV2 port of the Alsa Modular Synth modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760270 Terje Røsten changed: What|Removed |Added CC||terje...@phys.ntnu.no --- Comment #1 from Terje Røsten 2011-12-07 12:47:07 EST --- Could you add a bit more to description? I have no idea what LV2 is :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #35 from Ulrich Schwickerath 2011-12-07 11:24:01 EST --- ok, no problem. I rolled back this link thing. http://uschwick.web.cern.ch/uschwick/software/rubygem-xmlparser.spec http://uschwick.web.cern.ch/uschwick/software/rubygem-xmlparser-0.6.81-8.el6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721174] Review Request: cryptominisat - SAT solver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721174 Jerry James changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Jerry James 2011-12-07 12:49:48 EST --- OK, I've got a patch that I'm discussing with upstream. I'll tentatively add it to the package for now, and work with upstream on a permanent solution. Thanks for the review, Brendan! New Package SCM Request === Package Name: cryptominisat Short Description: SAT solver Owners: jjames Branches: f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761063 --- Comment #4 from Jayson Vaughn 2011-12-07 12:45:46 EST --- Thanks Terje. So I should remove all %define lines? I use these as variables in my spec file. Should I just hard code the values instead? Yes, I am the upstream. Currently the tool only works on mp3s however I will probably have flac and ogg support added this weekend when I have the time. Now that I am using python-mutagen, it should be a rather simple refactor. I already have a FAS account and will perform a koji scratch build shortly. Thanks again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755066] Review Request: chromaprint - Library implementing the AcoustID fingerprinting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755066 --- Comment #10 from Jon Ciesla 2011-12-07 12:47:16 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754698] Review Request: idjc - DJ application with streaming capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754698 Nikos Roussos changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Nikos Roussos 2011-12-07 11:10:41 EST --- New Package SCM Request === Package Name: idjc Short Description: DJ application with streaming capabilities Owners: comzeradd Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761094] Review Request: asn1c - An ASN.1 Compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761094 --- Comment #1 from Nathaniel McCallum 2011-12-07 12:13:58 EST --- asn1c.x86_64: W: spelling-error %description -l en_US marshalled -> marshaled, marshal led, marshal-led asn1c.x86_64: W: spelling-error %description -l en_US unmarshalled -> marshaled asn1c.x86_64: W: manual-page-warning /usr/share/man/man1/unber.1.gz 11: warning: macro `Dt' not defined asn1c.x86_64: W: manual-page-warning /usr/share/man/man1/asn1c.1.gz 1: warning: macro `Dt' not defined asn1c.x86_64: W: manual-page-warning /usr/share/man/man1/enber.1.gz 11: warning: macro `Dt' not defined asn1c.x86_64: W: no-manual-page-for-binary clyx2asn1.pl asn1c.x86_64: W: no-manual-page-for-binary crfc2asn1.pl 1 packages and 1 specfiles checked; 0 errors, 110 warnings. [nmccallu@localhost SPECS]$ rpmlint /home/remote/nmccallu/RPMs/RPMS/x86_64/asn1c-0.9.21-1.fc16.x86_64.rpm asn1c.spec asn1c.x86_64: W: spelling-error %description -l en_US marshalled -> marshaled, marshal led, marshal-led asn1c.x86_64: W: spelling-error %description -l en_US unmarshalled -> marshaled asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constraints.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_system.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_CHOICE.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ber_decoder.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constraints.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ber_decoder.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_CHOICE.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/xer_decoder.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/xer_decoder.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/per_encoder.c asn1c.x86_64: W: manual-page-warning /usr/share/man/man1/unber.1.gz 11: warning: macro `Dt' not defined asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/TeletexString.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/T61String.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/TeletexString.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/der_encoder.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/der_encoder.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/xer_support.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/xer_support.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/REAL.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_codecs.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BOOLEAN.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/IA5String.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BOOLEAN.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/IA5String.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BMPString.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/GeneralizedTime.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BMPString.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/GeneralizedTime.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_SEQUENCE_OF.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_SEQUENCE_OF.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/GeneralString.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/VisibleString.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/VisibleString.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/GraphicString.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NativeInteger.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BIT_STRING.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/GraphicString.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BIT_STRING.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NativeInteger.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/per_support.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_codecs_prim.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/per_support.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_codecs_prim.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/UTF8String.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/UTF8String.c asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ber_tlv_tag.h asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/UTCTim
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719854
--- Comment #31 from Ulrich Schwickerath
2011-12-07 08:53:59 EST ---
I've tried to follow the rule for moving the .so files. If I do so, i.e. if I
move the library to %{ruby_sitearch}/lib/, the package no longer works, at
least not on my test machine. Adding a link solved this problem.
Concerning %{gemdir}/gems/%{gemname}-%{version} which was created but not owned
by the package, I have added it as %dir in the new version.
Here's a new version of the package:
http://uschwick.web.cern.ch/uschwick/software/rubygem-xmlparser.spec
http://uschwick.web.cern.ch/uschwick/software/rubygem-xmlparser-0.6.81-7.el6.src.rpm
The spec file in the src.rpm and the one given are identical (I've checked) but
maybe I misinterpreted this comment from Steve.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754583] Review Request: dnssec-trigger - Update/reconfigure DNSSEC resolving
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754583 --- Comment #6 from Adam Tkac 2011-12-07 12:28:40 EST --- (In reply to comment #5) > [paul@bofh ~]$ cat /etc/redhat-release > Fedora release 16 (Verne) > > [paul@bofh ~]$ sudo mock rebuild /tmp/dnssec-trigger-0.7-1.fc14.src.rpm > INFO: mock.py version 1.1.17 starting... > State Changed: init plugins > INFO: selinux disabled > State Changed: start > INFO: Start(/tmp/dnssec-trigger-0.7-1.fc14.src.rpm) Config(fedora-14-x86_64) > State Changed: lock buildroot > State Changed: clean > INFO: chroot (/var/lib/mock/fedora-14-x86_64) unlocked and deleted > State Changed: unlock buildroot > State Changed: init > State Changed: lock buildroot > Mock Version: 1.1.17 > INFO: Mock Version: 1.1.17 > INFO: calling preinit hooks > INFO: enabled root cache > State Changed: unpacking root cache > INFO: enabled yum cache > State Changed: cleaning yum metadata > INFO: enabled ccache > State Changed: running yum > State Changed: unlock buildroot > State Changed: setup > State Changed: build > INFO: Done(/tmp/dnssec-trigger-0.7-1.fc14.src.rpm) Config(default) 1 minutes > 39 > seconds > INFO: Results and/or logs in: /var/lib/mock/fedora-14-x86_64/result > State Changed: end > > > Can you tell me exactly how your mock is failing? Build must pass in current rawhide buildroot, not in F14 buildroot. Please try this: $ sudo mock -r fedora-rawhide-i386 dnssec-trigger-0.7-1.fc14.src.rpm This failed on my machine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761063 Jayson Vaughn changed: What|Removed |Added Alias|FF-NEEDSPONSOR | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761094] Review Request: asn1c - An ASN.1 Compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761094 --- Comment #2 from Nathaniel McCallum 2011-12-07 12:19:21 EST --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3572760 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753513] Review Request: minetest - Multiplayer infinite-world block sandbox with survival mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753513 --- Comment #13 from Jon Ciesla 2011-12-07 11:50:13 EST --- Good. :) Post an updated SRPM/SPEC fixing %doc, and let me know your FAS account name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761094] Review Request: asn1c - An ASN.1 Compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761094 Jakub Hrozek changed: What|Removed |Added CC||jhro...@redhat.com AssignedTo|nob...@fedoraproject.org|jhro...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761094] New: Review Request: asn1c - An ASN.1 Compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: asn1c - An ASN.1 Compiler https://bugzilla.redhat.com/show_bug.cgi?id=761094 Summary: Review Request: asn1c - An ASN.1 Compiler Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: nathan...@natemccallum.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://npmccallum.fedorapeople.org/asn1c/asn1c.spec SRPM URL: http://npmccallum.fedorapeople.org/asn1c/asn1c-0.9.21-1.fc16.src.rpm Description: Compiles ASN.1 data structures into C source structures that can be simply marshalled to/unmarshalled from: BER, DER, CER, BASIC-XER, CXER, EXTENDED-XER, PER. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755066] Review Request: chromaprint - Library implementing the AcoustID fingerprinting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755066 --- Comment #8 from Ismael Olea 2011-12-07 12:27:53 EST --- @Christoph: Just added your suggestions. Thanks both! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761063 Jayson Vaughn changed: What|Removed |Added Alias||FF-NEEDSPONSOR -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754698] Review Request: idjc - DJ application with streaming capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754698 --- Comment #11 from Jon Ciesla 2011-12-07 11:21:27 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698405] Review Request: mcollective - A framework to build server orchestration or parallel job execution systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698405 --- Comment #15 from Jeffrey C. Ollie 2011-12-07 12:20:22 EST --- (In reply to comment #14) > Nice try, thank you. Unfortunately I can see another two perl lines still > present in %build section. Doh! Completely forgot about those. Spec URL: http://jcollie.fedorapeople.org/mcollective.spec SRPM URL: http://jcollie.fedorapeople.org/mcollective-1.3.1-6.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760645] Review Request: ergo - A quantum chemistry program for large-scale self-consistent field calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760645 --- Comment #2 from Fabien Archambault 2011-12-07 11:48:22 EST --- Hi, Thank you for this informal review. > Are you sure that this is the GPLv3+ version? I know within the website it is only GPL but the COPYING file is GPLv3+. I was helped by someone who is already an approved Fedora packager to pinpoint the right license. Concerning the man-pages as I stated in my initial message, I am already in touch with the developers and they are going to build one for the next version (due in a short amount of time). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760645] Review Request: ergo - A quantum chemistry program for large-scale self-consistent field calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760645 Terje Røsten changed: What|Removed |Added CC||terje...@phys.ntnu.no --- Comment #4 from Terje Røsten 2011-12-07 12:43:48 EST --- Nice work! Could you please create a FAS account and provide link to koji scratch build too? Some help here: http://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=761063
Terje Røsten changed:
What|Removed |Added
CC||terje...@phys.ntnu.no
--- Comment #3 from Terje Røsten 2011-12-07 12:38:49
EST ---
# Remove, not needed at all
%define name cover_grabber
%define version 0.0.2
%define unmangled_version 0.0.2
%define release 1
# You are upstream too?
Source0: http://69.164.204.114/%{name}-%{unmangled_version}.tar.gz
# Remove
Prefix: %{_prefix}
# Remove
Vendor: Jayson Vaughn
# Remove
URL: http://github.com/thedonvaughn/cover_grabber
Requires: python-mutagen
# Does the tool only work for mp3, not flac et al?
%description
Cover Grabber will recursively traverse a specified directory of mp3s
and download album cover art from LastFM.
For instance:
$ covergrabber "/home/user/Music"
%prep
%setup -q %{name}-%{unmangled_version}
%build
python setup.py build
%install
# Don't use --record
# Please read this: http://fedoraproject.org/wiki/Packaging:Python
python setup.py install --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES
%clean
rm -rf $RPM_BUILD_ROOT
# use hand built files list.
%files -f INSTALLED_FILES
# change to %defattr(-,root,root,-)
%defattr(-,root,root)
Please create a FAS account and do a koji scratch build, post link to build
here.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] New: Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: cover_grabber - Download album cover art https://bugzilla.redhat.com/show_bug.cgi?id=761063 Summary: Review Request: cover_grabber - Download album cover art Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: vaughn.jay...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://69.164.204.114/cover_grabber.spec SRPM URL: http://69.164.204.114/cover_grabber-0.0.2-1.fc16.src.rpm Description: Cover Grabber will recursively traverse a specified directory of mp3s and download album cover art from LastFM. For instance: $ covergrabber "/home/user/Music" This is my first package and I am seeking sponsorship. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761063] Review Request: cover_grabber - Download album cover art
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761063 --- Comment #1 from Jayson Vaughn 2011-12-07 11:16:10 EST --- rpmlint output: cover_grabber.src: W: spelling-error %description -l en_US covergrabber -> cover grabber, cover-grabber, recoverable cover_grabber.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cover_grabber/media_dir_walker.py cover_grabber.noarch: E: incorrect-fsf-address /usr/bin/covergrabber cover_grabber.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cover_grabber/mp3_handler.py cover_grabber.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cover_grabber/__init__.py cover_grabber.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/cover_grabber/lastfm_downloader.py cover_grabber.noarch: W: no-manual-page-for-binary covergrabber 2 packages and 1 specfiles checked; 5 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758166] [EPEL] - Review Request -- thrift 0.6.1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758166 --- Comment #10 from Nelson Marques 2011-12-07 10:58:55 EST --- (In reply to comment #9) > I'm not sure why people would prefer to build the ruby gem themselves, but > even > if they did, we should still provide it in a package for those who do not. Ok, this is already done. > As to C#, and Java, obviously, if they don't work, you should file bugs > upstream and not enable them at this time. I think as far as which java, I > would say openjdk6 for everything except rawhide, which should use openjdk7. While I'm certain C# issue needs to be fixed by upstream, I'm not sure about the current JAVA issue which needs a bit more of attention and investigation. I'll update the request tomorrow once I test properly the JAVA build and investigate the C# history on JIRA. I've used the same spec for Fedora and RHEL and so far everything seems to be working and it's not really that confusing (at least for me). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755890
--- Comment #13 from Richard Shaw 2011-12-07 10:35:30
EST ---
Ok, two more things:
1. If python 2.7 is going to be supported you need to update the Requires for
snap-gtk to something like:
%if 0%{?with_python3}
Requires: pygobject3
%else
Requires: pygobject2
%endif
Since pygobject3 doesn't exist on F15 and even if it did it would require that
python3 be used.
2. Also, I tried running it on a remote X11 session over ssh and when I clicked
the "Backup" button I got the following in the terminal:
$ gsnap
Traceback (most recent call last):
File "/usr/bin/gsnap", line 83, in show_backup_window
backup_window = BackupOperationWindow()
File "/usr/bin/gsnap", line 122, in __init__
snapfile = snap.options.DEFAULT_SNAPFILE + "-" + snapfile_id + ".tgz"
AttributeError: 'module' object has no attribute 'DEFAULT_SNAPFILE'
Richard
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728504] Review Request: jboss-sasl - SASL Provider for J2SE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728504 --- Comment #6 from Marek Goldmann 2011-12-07 10:39:56 EST --- Ouch, I forgot to run a scratch build... Below you can find version with required BR added. I haven't bumped the release. And the scratch build itself: http://koji.fedoraproject.org/koji/taskinfo?taskID=3572488 Spec URL: http://goldmann.fedorapeople.org/package_review/jboss-sasl/5/jboss-sasl.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/jboss-sasl/5/jboss-sasl-1.0.0-0.1.Beta9.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #34 from Vít Ondruch 2011-12-07 10:14:55 EST --- (In reply to comment #33) > Hi, Vít, > > thanks for the explanation. I admit that I'm not a ruby geek ;-) I did the > change in this latest version because of comment 28. What you suggest now is > what I did before. Personally I have a slight preference for the original > approach because it is simpler, I have no problem to roll back. Let me know. Sorry for the confusion. In comment 28, I just tried to point out that Shawn was not right, that the guideline is clear, but I apparently achieved the opposite effect ;) > About upgrading: this was discussed earlier in this thread already. I agree > that it is a good idea to ping the original author to get an updated package. > For the time being though this one seems to be the best we can do. It's needed > for OpenNebula. Not an issue. It was just note. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758166] [EPEL] - Review Request -- thrift 0.6.1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758166 --- Comment #9 from Tom "spot" Callaway 2011-12-07 09:34:53 EST --- I'm not sure why people would prefer to build the ruby gem themselves, but even if they did, we should still provide it in a package for those who do not. As to C#, and Java, obviously, if they don't work, you should file bugs upstream and not enable them at this time. I think as far as which java, I would say openjdk6 for everything except rawhide, which should use openjdk7. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719854
--- Comment #32 from Vít Ondruch 2011-12-07 09:33:48 EST
---
(In reply to comment #31)
> I've tried to follow the rule for moving the .so files. If I do so, i.e. if I
> move the library to %{ruby_sitearch}/lib/, the package no longer works, at
> least not on my test machine. Adding a link solved this problem.
You should first understand how Ruby together with RubyGems are treating load
paths. I'll try to shortly explain:
1) If you do "require 'foo'", Ruby searches all the load paths and if finds the
file on some of them, it loads it. Ruby has some set of default load paths and
%{buildroot}%{ruby_sitearch} is one of them. I.e. if you place file foo.rb (or
foo.so) into that path, then you can do later "require 'foo'".
2) If the file is not found in load paths, then the RubyGems loading mechanism
kicks in. RubyGems goes through all installed gems and looks for suitable file
to load. When it is found, RubyGems will insert its paths (which are specified
by #require_paths method in .gemspec file) into Ruby's load paths and issues
again regular Ruby's require.
So if you place the library into the %{buildroot}%{ruby_sitearch}/xmlparser.so
location, then there is no need to do any link, since Ruby can find the file on
its load path. And that is the way how it should be done currently.
And I have some additional notes:
* It seems that the author of the gem is somebody else then the original
upstream. However, it would be nice if the link to homepage was somehow useful,
may be http://www.yoshidam.net/Ruby.html#xmlparser is the correct one?
* It might make sense to ask the author of the gem for update to the latest
upstream version of the library?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752452] Review Request: contour - A context sensitive user interface for Plasma Active
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752452 --- Comment #5 from Jon Ciesla 2011-12-07 09:54:16 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #33 from Ulrich Schwickerath 2011-12-07 09:52:22 EST --- Hi, Vít, thanks for the explanation. I admit that I'm not a ruby geek ;-) I did the change in this latest version because of comment 28. What you suggest now is what I did before. Personally I have a slight preference for the original approach because it is simpler, I have no problem to roll back. Let me know. About upgrading: this was discussed earlier in this thread already. I agree that it is a good idea to ping the original author to get an updated package. For the time being though this one seems to be the best we can do. It's needed for OpenNebula. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752452] Review Request: contour - A context sensitive user interface for Plasma Active
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752452 Jaroslav Reznik changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Jaroslav Reznik 2011-12-07 09:48:12 EST --- New Package SCM Request === Package Name: contour Short Description: A context sensitive user interface for Plasma Active Owners: jreznik rdieter ltinkl than kkofler rnovacek Branches: f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752452] Review Request: contour - A context sensitive user interface for Plasma Active
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752452 --- Comment #3 from Jaroslav Reznik 2011-12-07 09:46:23 EST --- License fixed, thanks Rex, probably copy/paste issue... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755890 Richard Shaw changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|hobbes1...@gmail.com Flag||fedora-review? --- Comment #11 from Richard Shaw 2011-12-07 09:05:32 EST --- Yes, sorry. I got busy with family and other projects I was working on. Since T.C. hasn't taken the review officially, I'll take it. If you don't mind a swap, have a look at: https://bugzilla.redhat.com/show_bug.cgi?id=753453 It should be a very easy one. Thanks, Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728504] Review Request: jboss-sasl - SASL Provider for J2SE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728504 --- Comment #4 from Marek Goldmann 2011-12-07 08:43:27 EST --- Updated to Beta9. Spec URL: http://goldmann.fedorapeople.org/package_review/jboss-sasl/4/jboss-sasl.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/jboss-sasl/4/jboss-sasl-1.0.0-0.1.Beta9.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 618354] Review Request: cwallpaper - A front end for fbsetbg, Esetroot, feh, and other wallpaper changers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618354 Martin Gieseking changed: What|Removed |Added Status Whiteboard||StalledSubmitter --- Comment #6 from Martin Gieseking 2011-12-07 07:59:06 EST --- Any progress here? Germán, if you're no longer interested in this package, please close the ticket (I will close it if there's no response within a week). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608852
--- Comment #21 from Jon Ciesla 2011-12-07 07:58:28 EST
---
Sure, something like this (assuming 6, modify for 1, etc):
In install:
mkdir -p %{buildroot}%{_mandir}/man6
install -p -m644 .6 %{buildroot}%{_mandir}/man6/.6
In files:
%{_mandir}/man6/.6.gz
That should do it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752771] Review Request: darkserver - A GNU build-id details service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752771 --- Comment #10 from Jon Ciesla 2011-12-07 07:51:55 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758166] [EPEL] - Review Request -- thrift 0.6.1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758166 --- Comment #8 from Nelson Marques 2011-12-07 07:40:49 EST --- Tom, Regarding the Fedora stuff here's the deal: 1. C# - upstream doesn't provide a strong name, if I try to install the assembly with gacutil, it fails. will contact upstream regarding this. 2. JAVA - build is broken against java-openjdk. Either way, which java should link against? 3. Erlang - Done. 4. Ruby - Should we really provide the ruby gem? Most people I know prefer to build the gems themselves. Please advice. NM -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752771] Review Request: darkserver - A GNU build-id details service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752771 Kushal Das changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760943] New: Review Request: perl-Messaging-Message - This perl module provides an abstraction of a "message", as used in messaging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Messaging-Message - This perl module provides an abstraction of a "message", as used in messaging https://bugzilla.redhat.com/show_bug.cgi?id=760943 Summary: Review Request: perl-Messaging-Message - This perl module provides an abstraction of a "message", as used in messaging Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: laurence.fi...@cern.ch QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://lfield.web.cern.ch/lfield/perl-Messaging-Message.spec SRPM URL: http://cern.ch/lfield/perl-Messaging-Message-0.7-1.fc17.noarch.rpm Description: This module provides an abstraction of a "message", as used in messaging, see for instance: http://en.wikipedia.org/wiki/Enterprise_messaging_system. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760177] Review Request: knot - Authoritative DNS server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760177 --- Comment #2 from Stanislav Petr 2011-12-07 06:22:03 EST --- Thanks for your comment. Fixed: http://my.glux.org/fedora/packages/knot/knot.spec http://my.glux.org/fedora/packages/knot/knot-0.8.1-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760943] Review Request: perl-Messaging-Message - This perl module provides an abstraction of a "message", as used in messaging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760943 --- Comment #1 from laurence.fi...@cern.ch 2011-12-07 07:09:23 EST --- Here is the link to a koji scratch build. http://koji.fedoraproject.org/koji/taskinfo?taskID=3571869 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225749] Merge Review: fetchmail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225749 Michal Hlavinka changed: What|Removed |Added Flag||needinfo?(vcrhonek@redhat.c ||om) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698405] Review Request: mcollective - A framework to build server orchestration or parallel job execution systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698405 --- Comment #14 from Vít Ondruch 2011-12-07 07:29:16 EST --- Nice try, thank you. Unfortunately I can see another two perl lines still present in %build section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #30 from Ulrich Schwickerath 2011-12-07 05:49:09 EST --- I've done an informal review done on https://bugzilla.redhat.com/show_bug.cgi?id=760357 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760357] Review Request: rubygem-systemu - Universal capture of stdout and stderr and handling of child process pid
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760357
Ulrich Schwickerath changed:
What|Removed |Added
CC||ulrich.schwicker...@cern.ch
--- Comment #8 from Ulrich Schwickerath
2011-12-07 05:31:03 EST ---
I may be a bit late now I just realised but it took me a while to do an
Informal Package Review
===
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[ ] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on:
[ ] Rpmlint output:
$ rpmlint rubygem-systemu-2.4.1-1.fc17.src.rpm
rubygem-systemu.src: W: spelling-error Summary(en_US) stdout -> stout, std out,
std-out
rubygem-systemu.src: W: spelling-error Summary(en_US) stderr -> std err,
std-err, stander
rubygem-systemu.src: W: spelling-error Summary(en_US) pid -> peed, dip, pud
rubygem-systemu.src: W: spelling-error %description -l en_US stdout -> stout,
std out, std-out
rubygem-systemu.src: W: spelling-error %description -l en_US stderr -> std err,
std-err, stander
rubygem-systemu.src: W: spelling-error %description -l en_US pid -> peed, dip,
pud
rubygem-systemu.src: W: non-standard-group Unspecified
rubygem-systemu.src: W: no-cleaning-of-buildroot %install
1 packages and 0 specfiles checked; 0 errors, 8 warnings.
$ rpmlint rubygem-systemu-2.4.1-1.fc17.noarch.rpm
rubygem-systemu.noarch: W: spelling-error Summary(en_US) stdout -> stout, std
out, std-out
rubygem-systemu.noarch: W: spelling-error Summary(en_US) stderr -> std err,
std-err, stander
rubygem-systemu.noarch: W: spelling-error Summary(en_US) pid -> peed, dip, pud
rubygem-systemu.noarch: W: spelling-error %description -l en_US stdout ->
stout, std out, std-out
rubygem-systemu.noarch: W: spelling-error %description -l en_US stderr -> std
err, std-err, stander
rubygem-systemu.noarch: W: spelling-error %description -l en_US pid -> peed,
dip, pud
rubygem-systemu.noarch: W: non-standard-group Unspecified
1 packages and 0 specfiles checked; 0 errors, 7 warnings.
[?] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type:
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package: b7c29f05686420511861276594fa64f5
MD5SUM gem package from source rpm: c95eb1dd231cac73b11224a9d3ee35c2
MD5SUM upstream package: c95eb1dd231cac73b11224a9d3ee35c2
[x] Package is not known to require ExcludeArch, OR:
Arches excluded: none
Why:
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should te
[Bug 751119] Review Request: perl-Judy - Perl wrapper for Judy
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751119
--- Comment #2 from Tomas Smetana 2011-12-07 04:47:32 EST
---
Hello,
I tried to run rpmlint with the provided src.rpm:
perl-Judy.src: E: no-changelogname-tag
perl-Judy.src: W: invalid-license GPL
perl-Judy.src: W: no-url-tag
perl-Judy.src:21: W: unversioned-explicit-provides perl(Judy::1::_impl)
perl-Judy.src:21: W: unversioned-explicit-provides perl(Judy::1::_obj)
perl-Judy.src:21: W: unversioned-explicit-provides perl(Judy::1::_tie)
perl-Judy.src:22: W: unversioned-explicit-provides perl(Judy::L::_impl)
perl-Judy.src:22: W: unversioned-explicit-provides perl(Judy::L::_obj)
perl-Judy.src:22: W: unversioned-explicit-provides perl(Judy::L::_tie)
perl-Judy.src:23: W: unversioned-explicit-provides perl(Judy::SL::_impl)
perl-Judy.src:23: W: unversioned-explicit-provides perl(Judy::SL::_obj)
perl-Judy.src:23: W: unversioned-explicit-provides perl(Judy::SL::_tie)
perl-Judy.src:23: W: unversioned-explicit-provides perl(Judy::SL::_dump)
perl-Judy.src:24: W: unversioned-explicit-provides perl(Judy::HS::_impl)
perl-Judy.src:24: W: unversioned-explicit-provides perl(Judy::HS::_obj)
perl-Judy.src:24: W: unversioned-explicit-provides perl(Judy::HS::_tie)
perl-Judy.src:25: W: unversioned-explicit-provides perl(Judy::Mem::_impl)
perl-Judy.src:26: W: unversioned-explicit-provides perl(Judy::_tie)
perl-Judy.src:33: W: setup-not-quiet
perl-Judy.src:37: W: rpm-buildroot-usage %build perl Build.PL --install_path
arch=${RPM_BUILD_ROOT}/%{perl_sitearch} --install_path
libdoc=$RPM_BUILD_ROOT/%{_mandir}/man3
perl-Judy.src:50: W: macro-in-comment %{_name_version}
1 packages and 0 specfiles checked; 1 errors, 20 warnings
The missing changelog is definitely not OK. According to the README file the
license should be the same as Perl itself, which is "(GPL+ or Artistic) and
(GPLv2+ or Artistic) and Copyright Only and MIT and Public Domain and UCD"
however the Perl packaging guildelines [0] suggest "GPL+ or Artistic"... I'm
lost.
As for the other warnings: the %clean version suggests the provided .spec is
not a final version(?). So it would be good to finalize it probably...
Since this is a Perl package I would rather someone more experienced to take a
look at it. However: there are errors that have to be corrected anyway.
[0] https://fedoraproject.org/wiki/Packaging/Perl
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #20 from Ratnadeep Debnath 2011-12-07 04:49:40 EST --- I have added the doc files. I have also written a man page for epris. But it seems that the make file isn't configured for man pages. I have patched the source directory to include the man file. Is there a way to copy the man file directly without patching the makefiles? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758470] Review Request: vmmlib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758470 Jan Kaluža changed: What|Removed |Added Status|NEW |ASSIGNED CC||jkal...@redhat.com AssignedTo|nob...@fedoraproject.org|jkal...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
