[Bug 761319] Fedora 17 feature GTKD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761319 --- Comment #5 from MERCIER Jonathan bioinfornat...@gmail.com 2012-01-08 04:34:52 EST --- http://bioinfornatics.fedorapeople.org/gtkd-1.5.1-8.20111024svn906.fc16.src.rpm http://bioinfornatics.fedorapeople.org/gtkd.spec minor update use python as command for generate devhelp book -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 Mattia Verga mattia.ve...@tiscali.it changed: What|Removed |Added CC||mattia.ve...@tiscali.it --- Comment #1 from Mattia Verga mattia.ve...@tiscali.it 2012-01-08 04:41:44 EST --- Are the ldconfig calls in %post and %postun really needed? This package seems to not add any library. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759779] Review Request: rachota - Straightforward timetracking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759779 MERCIER Jonathan bioinfornat...@gmail.com changed: What|Removed |Added CC||bioinfornat...@gmail.com --- Comment #6 from MERCIER Jonathan bioinfornat...@gmail.com 2012-01-08 05:11:15 EST --- Dear, like you use cvs for take sources files, you should read this https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages In last you can use install command instead cp -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728302] Review Request: pjproject - Libraries written in C language for building embedded/non-embedded VoIP applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728302 --- Comment #21 from Mario Santagiuliana fed...@marionline.it 2012-01-08 05:44:52 EST --- Reply to comment 17: Thanks Rex! :) Should be ok now...isn't? SPEC: http://marionline.fedorapeople.org/packages/SPECS/pjproject.spec SRPM: http://marionline.fedorapeople.org/packages/SRPMS/pjproject-1.10-7.fc16.src.rpm I write to upstream ML to understand if I can and how compile pjproject using external libresample and libsrtp libraries already included in fedora repository. For the iLBC, are there news? Should we ask to fedora-legal-list? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759779] Review Request: rachota - Straightforward timetracking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759779 MERCIER Jonathan bioinfornat...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|bioinfornat...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757348] Review Request: mgarepo - Tools for Mageia repository access and management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757348 --- Comment #2 from Michael Scherer m...@zarb.org 2012-01-08 06:05:00 EST --- Fixed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761319] Fedora 17 feature GTKD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761319 Sébastien Willmann sebastien.willm...@gmail.com changed: What|Removed |Added CC||sebastien.willm...@gmail.co ||m AssignedTo|nob...@fedoraproject.org|sebastien.willm...@gmail.co ||m -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2012-01-08 06:18:02 EST --- csslint-0.9.2-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/csslint-0.9.2-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2012-01-08 06:16:45 EST --- csslint-0.9.2-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/csslint-0.9.2-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2012-01-08 06:19:25 EST --- csslint-0.9.2-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/csslint-0.9.2-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2012-01-08 06:19:25 EST --- csslint-0.9.2-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/csslint-0.9.2-1.el5 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2012-01-08 06:19:26 EST --- csslint-0.9.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/csslint-0.9.2-1.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 --- Comment #2 from Volker Fröhlich volke...@gmx.at 2012-01-08 06:29:15 EST --- Thanks, they're rubbish. Spec URL: http://www.geofrogger.net/review/spatialite-gui.spec SRPM URL: http://www.geofrogger.net/review/spatialite-gui-1.4.0-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 Mattia Verga mattia.ve...@tiscali.it changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 Mattia Verga mattia.ve...@tiscali.it changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mattia.ve...@tiscali.it Flag||fedora-review? --- Comment #3 from Mattia Verga mattia.ve...@tiscali.it 2012-01-08 06:57:35 EST --- I'm going to review this -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708402] Review Request: tophat - A spliced read mapper for RNA-Seq
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708402 --- Comment #8 from Adam Huffman bl...@verdurin.com 2012-01-08 06:55:50 EST --- Yes, I'm looking at SeqAn again now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772406] Review Request: cpulimit - CPU Usage Limiter for Linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772406
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #2 from Volker Fröhlich volke...@gmx.at 2012-01-08 07:11:40 EST
---
Use Fedora's optflags when compiling. You can gather some inspiration from
https://bugzilla.redhat.com/show_bug.cgi?id=513541
http://fedoraproject.org/wiki/PackagingGuidelines#Compiler_flags
Please use the %{_bindir} macro instead of /usr/bin and the name macro for
cpulimit. Also use it in Source0.
Defattr is obsolete.
If you don't go for EPEL 5, remove the buildroot definition, the clean section
and the rm in the install section.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717473] Review Request: SeqAn - Biological sequence analysis library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717473 --- Comment #5 from Adam Huffman bl...@verdurin.com 2012-01-08 07:19:41 EST --- Taking another look at this now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #5 from Adam Huffman bl...@verdurin.com 2012-01-08 07:18:25 EST --- Yes, I ended up ignoring the upstream makefiles. However, it still needs config.h, which is why I still run configure. New version at: http://verdurin.fedorapeople.org/reviews/libircclient/libircclient.spec http://verdurin.fedorapeople.org/reviews/libircclient/libircclient-1.3-7.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Mohamed El Morabity pikachu.2...@gmail.com 2012-01-08 07:23:31 EST --- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 Mattia Verga mattia.ve...@tiscali.it changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Mattia Verga mattia.ve...@tiscali.it 2012-01-08 07:50:13 EST --- - rpmlint checks return: spatialite-gui.x86_64: W: no-manual-page-for-binary spatialite_gui 3 packages and 1 specfiles checked; 0 errors, 1 warnings. Warning can be ignored: OK - naming guidelines and .spec file name: OK - packaging guidelines: OK - license: OK (GPLv3), in %doc - spec file legible, in am. english: OK - source matches upstream: OK - package compiles on (i686/x86_64): OK + Build Requires / Requires: NOTE 1 - no locales - no libraries - not relocatable - no directories created - no duplicate files - file permissions: OK - macros: OK - code/content: OK - no need for -docs - nothing in %doc affects runtime - no headers / no need for -devel - .desktop file: OK - ownership: OK - filenames: OK NOTES: -- 1: The required packages are automatically added by rpm, however I'm thinking about the opportunity to specify a 'require: libspatialite', since this package has no functionality without it. What do you think? That is not a blocker, so I mark this as APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #6 from Jussi Lehtola jussi.leht...@iki.fi 2012-01-08 07:34:49 EST --- The warnings dcc.c: In function 'libirc_dcc_process_descriptors': dcc.c:333:8: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] dcc.c:369:31: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] should be fixed before the package is approved. This kind of pointer handling can cause crashes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Mario Blättermann mario.blaetterm...@gmail.com 2012-01-08 08:05:06 EST --- New Package SCM Request === Package Name: Temperature.app Short Description: Window Maker applet which fetches local temperature information Owners: mariobl Branches: f16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2012-01-08 08:04:08 EST --- csslint-0.9.2-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/csslint-0.9.2-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #13 from Mario Blättermann mario.blaetterm...@gmail.com 2012-01-08 08:00:52 EST --- Many thanks for your approval! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694994] Review Request: yoshimi - Rewrite of ZynAddSubFx aiming for better JACK support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694994 --- Comment #18 from Adam Huffman bl...@verdurin.com 2012-01-08 07:32:47 EST --- I'll upload a new version with the latest upstream changes later today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2012-01-08 08:06:08 EST --- csslint-0.9.2-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/csslint-0.9.2-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #21 from Fedora Update System upda...@fedoraproject.org 2012-01-08 08:07:08 EST --- csslint-0.9.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/csslint-0.9.2-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 --- Comment #5 from Volker Fröhlich volke...@gmx.at 2012-01-08 08:07:23 EST --- Thank you for the review! Why do you want to have an explicit Requires? The binary is linked to libspatialite thus it effectively is required in order to install spatialite-gui. It also should not be done, as far as I know: http://fedoraproject.org/wiki/PackagingGuidelines#Requires -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772217] Review Request: libyuv - YUV conversion and scaling functionality library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772217 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added CC||brendan.jones...@gmail.com AssignedTo|nob...@fedoraproject.org|brendan.jones...@gmail.com Flag||fedora-review? --- Comment #1 from Brendan Jones brendan.jones...@gmail.com 2012-01-08 08:09:52 EST --- I will take this review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755275] Review Request: csslint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2012-01-08 08:06:42 EST --- csslint-0.9.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/csslint-0.9.2-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772217] Review Request: libyuv - YUV conversion and scaling functionality library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772217 --- Comment #2 from Brendan Jones brendan.jones...@gmail.com 2012-01-08 08:37:33 EST --- Formal review still pending, but here's a few comments for your review: - %defattr(-, root, root) no longer required rpmbuild = 4.4 See http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions - BuildRoot tag and clean sections only required for EPEL 5 and under See http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag - Mixed use of macros $RPM_BUILD_ROOT and %buildroot - Also to to provide explicit requires on the devel package to the base package. See http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package rpmlint output mostly OK, just the W: spelling-error %description, W: unused-direct-shlib-dependency and W: summary-not-capitalized need reviewing bsjones@f15laptop SPECS$rpmlint /home/bsjones/rpmbuild/RPMS/x86_64/libyuv-* libyuv.x86_64: W: spelling-error %description -l en_US webcam - web cam, web-cam, became libyuv.x86_64: W: spelling-error %description -l en_US bilinear - bi linear, bi-linear, linear libyuv-devel.x86_64: W: summary-not-capitalized C development files for libyuv libyuv-devel.x86_64: W: spelling-error %description -l en_US Asdditional - Additional, Traditional, Conditional libyuv-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 5 warnings. bsjones@f15laptop SPECS$rpmlint libyuv libyuv.x86_64: W: spelling-error %description -l en_US webcam - web cam, web-cam, became libyuv.x86_64: W: spelling-error %description -l en_US bilinear - bi linear, bi-linear, linear libyuv.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libyuv.so.0.0.0 linux-vdso.so.1 libyuv.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libyuv.so.0.0.0 /usr/lib64/libstdc++.so.6 1 packages and 0 specfiles checked; 0 errors, 4 warnings. bsjones@f15laptop SPECS$rpmlint libyuv-devel libyuv-devel.x86_64: W: summary-not-capitalized C development files for libyuv libyuv-devel.x86_64: W: spelling-error %description -l en_US Asdditional - Additional, Traditional, Conditional libyuv-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 --- Comment #6 from Mattia Verga mattia.ve...@tiscali.it 2012-01-08 08:41:04 EST --- (In reply to comment #5) Thank you for the review! Why do you want to have an explicit Requires? The binary is linked to libspatialite thus it effectively is required in order to install spatialite-gui. It also should not be done, as far as I know: http://fedoraproject.org/wiki/PackagingGuidelines#Requires Yes, it's right like Packaging Guidelines say (so I approved it). In my opinion I would expect a [foo]-gui package depends on a [foo] package, since there's no 'spatialite' package in repos I think this is a bit weird to have 'spatialite-gui'. But this is only a personal opinion! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Volker Fröhlich volke...@gmx.at 2012-01-08 08:55:31 EST --- New Package SCM Request === Package Name: spatialite-gui Short Description: GUI to manage Spatialite databases Owners: volter Branches: f15 f16 el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760294] Review Request: freexl - Library to extract data from within an Excel spreadsheet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760294 Richard Shaw hobbes1...@gmail.com changed: What|Removed |Added CC||hobbes1...@gmail.com --- Comment #1 from Richard Shaw hobbes1...@gmail.com 2012-01-08 09:02:33 EST --- Spec looks good. Very thorough. One question. The website says this version is Stable but you're using a pre-release type Release: tag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760294] Review Request: freexl - Library to extract data from within an Excel spreadsheet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760294 --- Comment #2 from Volker Fröhlich volke...@gmx.at 2012-01-08 09:26:03 EST --- I just took the version number as upstream put it: 1.0.0a As far as I get it, this is the way to go: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release Please correct me, if I'm wrong! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772406] Review Request: cpulimit - CPU Usage Limiter for Linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772406
adev ade...@gmail.com changed:
What|Removed |Added
CC||ade...@gmail.com,
||pin...@pingoured.fr
--- Comment #3 from adev ade...@gmail.com 2012-01-08 09:30:27 EST ---
Informal package Review, I am not a sponsor.
[FAIL] MUST: rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.
cpulimit.x86_64: W: incoherent-version-in-changelog 1.1-1 ['1.1-1.el5.centos',
'1.1-1.centos']
cpulimit.x86_64: W: no-documentation
cpulimit-debuginfo.x86_64: E: debuginfo-without-sources
no-documentation - no man pages or documentation files
incoherent-version-in-changelog - need to be set properly
cpulimit-debuginfo - compiled without -g flag
[PASS] MUST: The package must be named according to the Package Naming
Guidelines .
[PASS] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[FAIL] MUST: The package must meet the Packaging Guidelines .
- Usage of %{optflags} for compilation flags if possible
- No debuginfo because of no -g opts
- why several src rpm ?
[PASS] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
[PASS] MUST: The License field in the package spec file must match the actual
license.
[PASS] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[PASS] MUST: The spec file must be written in American English.
[PASS] MUST: The spec file for the package MUST be legible.
[PASS] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
- rpmdev-md5 cpulimit-1.1-1.el5.src.rpm
00d6d2fabdcb2ecfa2355724e9dc3f4b cpulimit-1.1-1.el5.src.rpm
f4ff6d4bfaef1258e8f5cd2041e2e2a3 cpulimit-1.1.tar.gz
e5a087539a57670534d019f92f19e119 cpulimit.spec
- md5sum cpulimit-1.1.tar.gz
f4ff6d4bfaef1258e8f5cd2041e2e2a3 cpulimit-1.1.tar.gz
- md5sum cpulimit-1.1.tar.gz specs/cpulimit.spec
e5a087539a57670534d019f92f19e119 specs/cpulimit.spec
[PASS] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[PASS] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[PASS] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[PASS] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[PASS] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[PASS] MUST: Packages must NOT bundle copies of system libraries.
[PASS] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[PASS] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[PASS] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[PASS] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example.
[FAIL] MUST: Each package must consistently use macros.
- /usr/bin paths can be replaced by %{_bindir} macro
[PASS] MUST: The package must contain code, or permissable content.
[PASS] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[PASS] MUST: If a package
[Bug 760294] Review Request: freexl - Library to extract data from within an Excel spreadsheet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760294 --- Comment #3 from Volker Fröhlich volke...@gmx.at 2012-01-08 09:33:32 EST --- http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages I think you're right! A 1.0.0b was released on the 29th of December. It is not on the frontpage though. http://www.gaia-gis.it/FreeXL/freexl-sources/ If the schema is kept like this, I can put that all in Version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772406] Review Request: cpulimit - CPU Usage Limiter for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772406 --- Comment #4 from Christos Triantafyllidis christos.triantafylli...@gmail.com 2012-01-08 09:42:42 EST --- Thanks for the comments Volker! EPEL 5 is a target for this RPM (actually this is the main use for me). Minor comment, defattr comes with default f14 (i know i'm a bit obsolete there) vim template, i removed it. New .spec and SRPMs updated. Scratch builds: Fedora 17 (rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=3629981 Fedora 16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3629990 EPEL 6: http://koji.fedoraproject.org/koji/taskinfo?taskID=3629993 EPEL 5: http://koji.fedoraproject.org/koji/taskinfo?taskID=362 Christos -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added CC||brendan.jones...@gmail.com Flag||needinfo? --- Comment #1 from Brendan Jones brendan.jones...@gmail.com 2012-01-08 09:51:52 EST --- Hi Hans, I'm just wondering whether flightcrew should be packaged on its own? I found this link http://www.mobileread.com/forums/showthread.php?t=140946 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772406] Review Request: cpulimit - CPU Usage Limiter for Linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772406
--- Comment #5 from Christos Triantafyllidis
christos.triantafylli...@gmail.com 2012-01-08 09:56:15 EST ---
Many thanks adev for the informal review!!
(In reply to comment #3)
Informal package Review, I am not a sponsor.
[FAIL] MUST: rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.
cpulimit.x86_64: W: incoherent-version-in-changelog 1.1-1 ['1.1-1.el5.centos',
'1.1-1.centos']
cpulimit.x86_64: W: no-documentation
cpulimit-debuginfo.x86_64: E: debuginfo-without-sources
no-documentation - no man pages or documentation files
No man page from UPSTREAM, there is a bug report with a man page for too long
but never included. I decided not to put it on my self based on:
https://bugzilla.redhat.com/show_bug.cgi?id=513541
incoherent-version-in-changelog - need to be set properly
I guess i miss a %{dist} there... is it required? changelog (at least to this
point) is not dist specific. Rpmlint on rawhide binaries doesn't through this
as an error. (trivial to fix if needed)
cpulimit-debuginfo - compiled without -g flag
Fixed in meanwhile :).
[PASS] MUST: The package must be named according to the Package Naming
Guidelines .
[PASS] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[FAIL] MUST: The package must meet the Packaging Guidelines .
- Usage of %{optflags} for compilation flags if possible
Fixed
- No debuginfo because of no -g opts
Fixed
- why several src rpm ?
One per dist, this is required i think.
[PASS] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
[PASS] MUST: The License field in the package spec file must match the actual
license.
[PASS] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[PASS] MUST: The spec file must be written in American English.
[PASS] MUST: The spec file for the package MUST be legible.
[PASS] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this
task.
If no upstream URL can be specified for this package, please see the Source
URL
Guidelines for how to deal with this.
- rpmdev-md5 cpulimit-1.1-1.el5.src.rpm
00d6d2fabdcb2ecfa2355724e9dc3f4b cpulimit-1.1-1.el5.src.rpm
f4ff6d4bfaef1258e8f5cd2041e2e2a3 cpulimit-1.1.tar.gz
e5a087539a57670534d019f92f19e119 cpulimit.spec
- md5sum cpulimit-1.1.tar.gz
f4ff6d4bfaef1258e8f5cd2041e2e2a3 cpulimit-1.1.tar.gz
- md5sum cpulimit-1.1.tar.gz specs/cpulimit.spec
e5a087539a57670534d019f92f19e119 specs/cpulimit.spec
[PASS] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[PASS] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work
on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[PASS] MUST: All build dependencies must be listed in BuildRequires, except
for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[PASS] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[PASS] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default
paths,
must call ldconfig in %post and %postun.
[PASS] MUST: Packages must NOT bundle copies of system libraries.
[PASS] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[PASS] MUST: A package must own all directories that it creates. If it does
not
create a directory that it uses, then it should require a package which does
create that directory.
[PASS] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[PASS] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example.
[FAIL] MUST: Each package must consistently use macros.
[Bug 760294] Review Request: freexl - Library to extract data from within an Excel spreadsheet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760294 --- Comment #4 from Richard Shaw hobbes1...@gmail.com 2012-01-08 10:20:05 EST --- (In reply to comment #2) I just took the version number as upstream put it: 1.0.0a As far as I get it, this is the way to go: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release Please correct me, if I'm wrong! The guidelines could be more clear here. This is definitely a post-release package so we need to start there[1], however, in that section of the guidelines it goes back to showing examples of the progression from pre-release, release, and then post-release. The first post-release examples is: foo-1.1.0-2.GA1 (post release, GA1) Of course this one starts at Release 2 because the 1 was used by the initial release of the package. Since this package didn't exist in Fedora yet it would start at 1 [1] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages (In reply to comment #3) http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages I think you're right! A 1.0.0b was released on the 29th of December. It is not on the frontpage though. http://www.gaia-gis.it/FreeXL/freexl-sources/ If the schema is kept like this, I can put that all in Version. No, I think the b still goes in the release field. Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 Dan Horák d...@danny.cz changed: What|Removed |Added CC||d...@danny.cz Flag|needinfo? | --- Comment #2 from Dan Horák d...@danny.cz 2012-01-08 10:43:01 EST --- Please see for my work on unbundling stuff in sigil - http://fedora.danny.cz/sigil/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #3 from Dan Horák d...@danny.cz 2012-01-08 10:54:33 EST --- ZipArchive needs unbundling, see URL above, bzip2 is not needed at all in the GPLed version of ZipArchive. And please also see Debian effort in packaging Sigil at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=590180 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760294] Review Request: freexl - Library to extract data from within an Excel spreadsheet
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760294
--- Comment #5 from Volker Fröhlich volke...@gmx.at 2012-01-08 11:10:52 EST
---
Kevin Fenzi suggested to try the first approach from the guidelines:
Properly ordered simple versions. These are usually due to quick bugfix
releases, such as openssl-0.9.6b or gkrellm-2.1.7a. As new versions come out,
the non-numeric tag is properly incremented (e.g. openssl-0.9.6c) or the
numeric version is increased and the non-numeric tag is dropped
(openssl-0.9.7). In this case, the non-numeric characters are permitted in the
Version: field.
... and switch to the other approach and epoch, should upstream not follow the
ordered schema any more.
That'd be:
Version: 1.0.0a
Release: 1%{?dist}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760294] Review Request: freexl - Library to extract data from within an Excel spreadsheet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760294 --- Comment #6 from Volker Fröhlich volke...@gmx.at 2012-01-08 11:24:03 EST --- Spec URL: http://www.geofrogger.net/review/freexl.spec SRPM URL: http://www.geofrogger.net/review/freexl-1.0.0a-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760294] Review Request: freexl - Library to extract data from within an Excel spreadsheet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760294 Richard Shaw hobbes1...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|hobbes1...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760294] Review Request: freexl - Library to extract data from within an Excel spreadsheet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760294 --- Comment #7 from Richard Shaw hobbes1...@gmail.com 2012-01-08 12:27:22 EST --- Ok, now I see it. That should probably be highlighted somehow to make it more evident. I'll try to do my review tomorrow. Are you setup as a contributor on RPM Fusion? If so I could use a review of: https://bugzilla.rpmfusion.org/show_bug.cgi?id=2112 As long as you don't have an aversion to the non-free repo. SMESH itself it GPL licensed but it links against OCE which has a license that was determined to be non-free by Fedora legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #7 from Adam Huffman bl...@verdurin.com 2012-01-08 12:31:52 EST --- I've contacted upstream about these warnings. If there's no response then I'll fix them myself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759779] Review Request: rachota - Straightforward timetracking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759779 --- Comment #7 from Sébastien Willmann sebastien.willm...@gmail.com 2012-01-08 13:04:57 EST --- Update taking your remarks into account: http://wilqu.fr/rpms/rachota/rachota.spec http://wilqu.fr/rpms/rachota/rachota-2.3-2.20111231cvs.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761319] Fedora 17 feature GTKD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761319 Sébastien Willmann sebastien.willm...@gmail.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737286] Review Request: salt - A parallel remote execution system
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737286
--- Comment #12 from Thomas Spura toms...@fedoraproject.org 2012-01-08
13:58:00 EST ---
- You added the systemctrl reloads for non-systemd releases. '%if !' and not
plain '%if' needed.
- %{name}.service doens't expand to salt-master.service and salt-minion.service
(salt-syndic.service is missing all the way).
- Deletion is missing, e.g. see:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
%preun
if [ $1 -eq 0 ] ; then
# Package removal, not upgrade
/bin/systemctl --no-reload disable apache-httpd.service /dev/null 21 ||
:
/bin/systemctl stop apache-httpd.service /dev/null 21 || :
fi
- The service is disabled by default (enabled by default would require an
exception: https://fedoraproject.org/wiki/Starting_services_by_default )
But the sysV have it enabled by default... Could you change that to match the
same behaviour like in F17?
(Same %post etc scripts for them would be great too)
- I *guess*, the new R MySQL-python PyXML libvirt-python yum won't be the
same on el5. Could you check that? (assuming you have better access to el5
installs as salt upstream seems to be using that mainly)
- Requires: salt = %{version}-%{release} would be safer than =.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772485] New: Review Request: wmnd - Dockapp for monitoring network interfaces
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: wmnd - Dockapp for monitoring network interfaces https://bugzilla.redhat.com/show_bug.cgi?id=772485 Summary: Review Request: wmnd - Dockapp for monitoring network interfaces Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mario.blaetterm...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmnd.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/wmnd-0.4.16-1.fc16.src.rpm Description: WMND is a dockapp for monitoring network interfaces under WindowMaker and other compatible window managers. WMND can monitor multiple interfaces at the same time, sports several display modes and can also monitor remote interfaces through SNMP. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3630158 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Flag||needinfo?(hdegoede@redhat.c ||om) --- Comment #4 from Brendan Jones brendan.jones...@gmail.com 2012-01-08 15:05:58 EST --- Thanks Dan. Hans, Unbundling is line with Fedora policy unless we can find good reason to make an exception. http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries As it looks like part of the work has already done, I would recommend against seeking an exception. I leave it for the two of you to discuss how you'd like to proceed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737286] Review Request: salt - A parallel remote execution system
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737286
--- Comment #13 from Clint Savage her...@gmail.com 2012-01-08 15:10:41 EST ---
Okay, I think I've cleaned up those things.
- You added the systemctrl reloads for non-systemd releases. '%if !' and not
plain '%if' needed.
Yep, my logic was bad there, fixed it so it should work now.
- %{name}.service doens't expand to salt-master.service and salt-minion.service
(salt-syndic.service is missing all the way).
I just decided to get rid of the macros and use the full names.
- Deletion is missing, e.g. see:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
%preun
if [ $1 -eq 0 ] ; then
# Package removal, not upgrade
/bin/systemctl --no-reload disable apache-httpd.service /dev/null 21 ||
:
/bin/systemctl stop apache-httpd.service /dev/null 21 || :
fi
Added!
- The service is disabled by default (enabled by default would require an
exception: https://fedoraproject.org/wiki/Starting_services_by_default )
But the sysV have it enabled by default... Could you change that to match the
same behaviour like in F17?
(Same %post etc scripts for them would be great too)
I'm not 100% on whether I did this part right, please advise.
- I *guess*, the new R MySQL-python PyXML libvirt-python yum won't be the
same on el5. Could you check that? (assuming you have better access to el5
installs as salt upstream seems to be using that mainly)
There is a python26-PyXML, which I've moved properly, but there isn't a yum or
libvirt-python *specifically* for 2.6. I am not sure it affects the
functionality of salt in those areas. I'll bug Thatch and see how he wants to
proceed.
- Requires: salt = %{version}-%{release} would be safer than =.
Fixed.
I should have new rpms up shortly.
Clint
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737286] Review Request: salt - A parallel remote execution system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737286 --- Comment #14 from Clint Savage her...@gmail.com 2012-01-08 16:04:12 EST --- Updated everything. SPEC: http://herlo.fedorapeople.org/rpms/salt.spec SRPM: http://herlo.fedorapeople.org/rpms/salt-0.9.4-5.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672555] Review Request: icc-profiles-openicc - The OpenICC profiles
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672555
Thibault North thibault.no...@gmail.com changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #15 from Thibault North thibault.no...@gmail.com 2012-01-08
16:43:45 EST ---
In comment#11, you wrote: Summary: The OpenICC profiles, but the SPEC summary
is still The Color Management Data (CMD). Also, the package %description must
be updated for coherence.
Besides,
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.OK
MUST: The package must be named according to the Package Naming Guidelines OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this. OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. N/A
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense. OK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. OK
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. N/A
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. N/A
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations) OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. OK
MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). N/A
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release} N/A
MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built. OK
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 --- Comment #8 from Jon Ciesla limburg...@gmail.com 2012-01-08 17:10:04 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752454] Review Request: qca-cyrus-sasl - Cyrus-SASL plugin for the Qt Cryptographic Architecture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752454 --- Comment #4 from Jon Ciesla limburg...@gmail.com 2012-01-08 17:08:47 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 --- Comment #15 from Jon Ciesla limburg...@gmail.com 2012-01-08 17:05:30 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731456] Review Request: jreen - Qt XMPP Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731456 --- Comment #42 from Jon Ciesla limburg...@gmail.com 2012-01-08 17:06:57 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766154 --- Comment #9 from Brendan Jones brendan.jones...@gmail.com 2012-01-08 17:12:18 EST --- Thanks for the fast review!! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769029] Review Request: oxygen-gtk3 - Oxygen GTK+3 theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769029 --- Comment #9 from Jon Ciesla limburg...@gmail.com 2012-01-08 17:11:28 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754004] Review Request: lv2-abGate - an LV2 Noise Gate plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754004 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Brendan Jones brendan.jones...@gmail.com 2012-01-08 17:13:51 EST --- New Package SCM Request === Package Name: lv2-abGate Short Description: LV2 noisegate plugin Owners: bsjones Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766154 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Brendan Jones brendan.jones...@gmail.com 2012-01-08 17:11:51 EST --- New Package SCM Request === Package Name: lv2-kn0ck0ut Short Description: A spectral subtraction LV2 plugin Owners: bsjones Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772499] New: Review Request: python-anfft - ANFFT is an FFT package for Python, based on FFTW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-anfft - ANFFT is an FFT package for Python, based on FFTW https://bugzilla.redhat.com/show_bug.cgi?id=772499 Summary: Review Request: python-anfft - ANFFT is an FFT package for Python, based on FFTW Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: thibault.no...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://tnorth.fedorapeople.org/python-anfft.spec SRPM URL: http://tnorth.fedorapeople.org/python-anfft-0.1-1.fc15.src.rpm Description: ANFFT is intended to be used in situations where large numbers of expensive FFTs must be performed, and for which the speed of the built-in NumPy or SciPy functions has been found insufficient. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754004] Review Request: lv2-abGate - an LV2 Noise Gate plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754004 --- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-01-08 17:20:03 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766154 --- Comment #10 from Jon Ciesla limburg...@gmail.com 2012-01-08 17:22:29 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694994] Review Request: yoshimi - Rewrite of ZynAddSubFx aiming for better JACK support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694994 --- Comment #19 from Adam Huffman bl...@verdurin.com 2012-01-08 17:21:20 EST --- New 0.060.12 version at: http://verdurin.fedorapeople.org/reviews/yoshimi/yoshimi.spec http://verdurin.fedorapeople.org/reviews/yoshimi/yoshimi-0.060.12-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772485] Review Request: wmnd - Dockapp for monitoring network interfaces
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772485 --- Comment #2 from Christos Triantafyllidis christos.triantafylli...@gmail.com 2012-01-08 17:29:07 EST --- BTW, shouldn't this have WindowMaker or something in Requires:? (sorry i'm not WindowMaker user) Christos -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772485] Review Request: wmnd - Dockapp for monitoring network interfaces
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772485
Christos Triantafyllidis christos.triantafylli...@gmail.com changed:
What|Removed |Added
CC||christos.triantafyllidis@gm
||ail.com
--- Comment #1 from Christos Triantafyllidis
christos.triantafylli...@gmail.com 2012-01-08 17:25:30 EST ---
Hi Mario,
an informal review for your package:
[CHECK] MUST: rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.
- There are several warning/errors on rpmlint results:
wmnd.spec:28: E: use-of-RPM_SOURCE_DIR
wmnd.spec:44: W: macro-in-comment %doc
wmnd.src: W: spelling-error Summary(en_US) Dockapp - Dock app, Dock-app,
Dockage
wmnd.src: I: enchant-dictionary-not-found de
wmnd.src: W: spelling-error %description -l en_US dockapp - dock app,
dock-app, dockage
wmnd.src:28: E: use-of-RPM_SOURCE_DIR
wmnd.src:44: W: macro-in-comment %doc
wmnd.src: W: file-size-mismatch wmnd-0.4.16.tar.gz = 188628,
http://www.thregr.org/~wavexx/software/wmnd/releases/wmnd-0.4.16.tar.gz =
188614
wmnd.i686: W: spelling-error Summary(en_US) Dockapp - Dock app, Dock-app,
Dockage
wmnd.i686: W: spelling-error %description -l en_US dockapp - dock app,
dock-app, dockage
wmnd.i686: W: unstripped-binary-or-object /usr/bin/wmnd
wmnd.i686: W: file-not-utf8 /usr/share/doc/wmnd/NEWS
wmnd.i686: E: incorrect-fsf-address /usr/share/doc/wmnd/COPYING
wmnd.x86_64: W: spelling-error Summary(en_US) Dockapp - Dock app, Dock-app,
Dockage
wmnd.x86_64: W: spelling-error %description -l en_US dockapp - dock app,
dock-app, dockage
wmnd.x86_64: W: unstripped-binary-or-object /usr/bin/wmnd
wmnd.x86_64: W: file-not-utf8 /usr/share/doc/wmnd/NEWS
wmnd.x86_64: E: incorrect-fsf-address /usr/share/doc/wmnd/COPYING
3 packages and 1 specfiles checked; 4 errors, 13 warnings.
[OK] MUST: The package must be named according to the Package Naming Guidelines
.
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption. [2] .
[CHECK] MUST: The package must meet the Packaging Guidelines .
- Check the comments on the other 'MUSTs'
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[CHECK] MUST: The License field in the package spec file must match the actual
license. [3]
- The README states ... distributed under GNU GPL v2 or above ... thus
correct version should be GPLv2+
[CHECK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]
- The %doc macro is hashed out
[OK] MUST: The spec file must be written in American English. [5]
[OK] MUST: The spec file for the package MUST be legible. [6]
[CHECK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
rpmlint complains about filesize so md5sum check should fail
[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture. [7]
[OK] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[OK] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
[OK] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
[OK] MUST: Packages must NOT bundle copies of system libraries.[11]
[OK] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then
[Bug 770740] Review Request: Morse - Simulates robots using the Blender Game Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770740 --- Comment #4 from Spencer Jackson spencerandrewjack...@yahoo.com 2012-01-08 17:32:16 EST --- Thanks, adev! I've applied your recommendations to the spec. New spec URL: http://dl.dropbox.com/u/4517312/morse.spec New SRPM URL: http://dl.dropbox.com/u/4517312/morse-0.4.1-2.fc16.src.rpm rpmlint morse morse-debuginfo RPMS/x86_64/morse-0.4.1-2.fc16.x86_64.rpm RPMS/x86_64/morse-debuginfo-0.4.1-2.fc16.x86_64.rpm SRPMS/morse-0.4.1-2.fc16.src.rpm SPECS/morse.spec morse.x86_64: W: no-manual-page-for-binary morseexec morse.x86_64: W: no-manual-page-for-binary morse morse.x86_64: W: no-manual-page-for-binary morseexec morse.x86_64: W: no-manual-page-for-binary morse morse.src: W: spelling-error %description -l en_US middleware - middle ware, middle-ware, middleweight morse.src: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz SPECS/morse.spec: W: invalid-url Source0: laas-morse-0.4.1-0-g15dc857.tar.gz 5 packages and 1 specfiles checked; 0 errors, 7 warnings. I just sent an email to the packaging list, ( http://lists.fedoraproject.org/pipermail/packaging/2012-January/008067.html ) basically asking what to do about the middleware protocols which are supported by Morse, but not packaged in Fedora. Some of these, like ROS, might take a while to be supported. Any thoughts on how to handle that would be appreciated. Upstream also recommended that I create subpackages for each middleware. That makes a lot of sense, but I should probably figure out what's the best way to handle the unsupported middlewares before I do that... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769029] Review Request: oxygen-gtk3 - Oxygen GTK+3 theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769029 nucleo alekc...@googlemail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-08 17:34:51 --- Comment #10 from nucleo alekc...@googlemail.com 2012-01-08 17:34:51 EST --- Built for Rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771318] Review Request: showoff - Ruby web app that reads simple configuration files for a presentation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771318
Lubomir Rintel lkund...@v3.sk changed:
What|Removed |Added
CC||lkund...@v3.sk
--- Comment #5 from Lubomir Rintel lkund...@v3.sk 2012-01-08 17:48:36 EST ---
* Name alright
* Versioning correct
* Source file matches upstream
* SPEC file clean and legible
* Builds fine in mock
1.) Require list not correct
Requires: ruby(abi) = 1.8
Please drop this -- you don't install modules into 1.8 release specific
location and thus don't need to require a particular ABI.
2.) Licensing is suspicious
You need to clarify this:
# Unknown license (same as JQuery?)
%{app_root}/public/js/jquery.batchImageLoad.js
%{app_root}/public/js/jquery.uuid.js
3.) Rpmlint not happy
showoff.src:60: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built. Add default attributes using
%defattr before it in the %files section, or use per line %attr's.
showoff.src: W: no-%clean-section
The spec file doesn't contain a %clean section to remove the files installed
by the %install section.
showoff.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 11)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance. Use either spaces or tabs for indentation, not both.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772503] New: Review Request: perl-Marpa-XS - Language grammar parser module for Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Marpa-XS - Language grammar parser module for Perl https://bugzilla.redhat.com/show_bug.cgi?id=772503 Summary: Review Request: perl-Marpa-XS - Language grammar parser module for Perl Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: lkund...@v3.sk QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- SPEC: http://v3.sk/~lkundrak/SPECS/perl-Marpa-XS.spec SRPM: http://v3.sk/~lkundrak/SRPMS/perl-Marpa-XS-1.002000-1.el6.src.rpm Description: Marpa::XS is a XS version of Marpa. Marpa parses any language whose grammar can be written in BNF. That includes recursive grammars, ambiguous grammars, infinitely ambiguous grammars and grammars with useless or empty productions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772485] Review Request: wmnd - Dockapp for monitoring network interfaces
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772485
--- Comment #3 from Christos Triantafyllidis
christos.triantafylli...@gmail.com 2012-01-08 17:51:13 EST ---
Some more comments on SPEC file:
Replace:
zcat %{_sourcedir}/%{name}-%{version}.tar.gz | tar -xvzf -
with:
%setup -q
Your make should include Fedora's optflags:
http://fedoraproject.org/wiki/PackagingGuidelines#Compiler_flags
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772504] New: Review Request: btkbdd - Software bluetooth keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: btkbdd - Software bluetooth keyboard https://bugzilla.redhat.com/show_bug.cgi?id=772504 Summary: Review Request: btkbdd - Software bluetooth keyboard Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: lkund...@v3.sk QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- SPEC: http://v3.sk/~lkundrak/SPECS/btkbdd.spec SRPM: http://v3.sk/~lkundrak/SRPMS/btkbdd-1.1-1.el6.src.rpm Description: This tool starts a Bluetooth HID Keyboard service, serving keystrokes obtained via Linux Input subsystem's event device (evdev). In practical terms, it turns your Linux box with a physical keyboard into a Bluetooth keyboard, which can be used by various Bluetooth HID capable devices, including desktop or tablet computers, smart phones, game consoles and so on. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769029] Review Request: oxygen-gtk3 - Oxygen GTK+3 theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769029 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-01-08 18:05:25 EST --- oxygen-gtk3-1.2.0-0.1.20111219.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/oxygen-gtk3-1.2.0-0.1.20111219.fc15 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2012-01-08 18:05:26 EST --- oxygen-gtk3-1.2.0-0.1.20111219.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/oxygen-gtk3-1.2.0-0.1.20111219.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769029] Review Request: oxygen-gtk3 - Oxygen GTK+3 theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769029 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-01-08 18:05:25 EST --- oxygen-gtk3-1.2.0-0.1.20111219.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/oxygen-gtk3-1.2.0-0.1.20111219.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749752] Review Request: dmg2img - Uncompress the Apple compressed disk image files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=749752
--- Comment #5 from Lubomir Rintel lkund...@v3.sk 2012-01-08 18:10:24 EST ---
Thank you for your review.
Updated packages:
SPEC: http://v3.sk/~lkundrak/SPECS/dmg2img.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/dmg2img-1.6.2-2.el6.src.rpm
(In reply to comment #3)
Some issues I see:
1. I think license should be GPLv2+ and MIT. Since the COPYING file included
in the upstream tarball contains GPLv2 I think we should use GPLv2+ instead
of GPL+.
No. Comment is what decides and author obviously removed the version
intentionally.
2. As noted by Richard in comment #1, BuildRequires: openssl-devel is
required to build vfdecrypt
Fixed.
3. Dist tag in release field should be %{?dist} instead of %{dist}
Fixed.
4. Unless you're packaging for EPEL 5, I recommend you:
Remove the BuildRoot tag
Use make instead of %{__make}
Remove rm -rf $RPM_BUILD_ROOT in the %install section
Remove the %clean section
Remove %defattr from the %files section
I want el5 builds to work and will probably be submitting the package for el5.
I changed the %make macro for make though.
5. The dmg2img-1.6.2-nostrip.patch already used in the patch and the patch I
attached both work to produce non empty debuginfo packages. I think my version
has a better chance of being accepted in a future upstream version but that
may
just be wishful thinking.
I believe conditional stripping is not a good idea. If upstream accepts your
patch, I'll gladly drop mine though.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737286] Review Request: salt - A parallel remote execution system
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737286
--- Comment #15 from Thomas Spura toms...@fedoraproject.org 2012-01-08
19:23:45 EST ---
- %if ! (0%{?rhel} 7 || 0%{?fedora} 15) doesn't work on f16 as rhel is
undefined and 0 is 7 -- sysV is installed.
e.g. this should work: %if (0%{?rhel} 7 || 0%{?fedora} 15)
and below where is %if (0%{?rhel} 7 || 0%{?fedora} 15) it should be:
%if ! (0%{?rhel} 7 || 0%{?fedora} 15)
-
http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_spec_file_scriptlets
:
%preun -n salt-master/minion is missing
It seems there are some more errors in the initscripts:
salt.src:230: W: macro-in-%changelog %post
salt.src:230: W: macro-in-%changelog %postun
salt.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/salt/utils/find.py 0644L /usr/bin/env
salt-master.noarch: E: init-script-without-chkconfig-preun
/etc/rc.d/init.d/salt-master
salt-master.noarch: W: missing-lsb-keyword Required-Stop in
/etc/rc.d/init.d/salt-master
salt-master.noarch: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/salt-master
salt-master.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-master
salt-master.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-master
salt-master.noarch: E: subsys-not-used /etc/rc.d/init.d/salt-master
salt-master.noarch: E: init-script-without-chkconfig-preun
/etc/rc.d/init.d/salt-syndic
salt-master.noarch: W: missing-lsb-keyword Required-Stop in
/etc/rc.d/init.d/salt-syndic
salt-master.noarch: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/salt-syndic
salt-master.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-syndic
salt-master.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-syndic
salt-master.noarch: W: no-reload-entry /etc/rc.d/init.d/salt-syndic
salt-master.noarch: E: subsys-not-used /etc/rc.d/init.d/salt-syndic
salt-minion.noarch: E: init-script-without-chkconfig-preun
/etc/rc.d/init.d/salt-minion
salt-minion.noarch: W: missing-lsb-keyword Required-Stop in
/etc/rc.d/init.d/salt-minion
salt-minion.noarch: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/salt-minion
salt-minion.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-minion
salt-minion.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-minion
salt-minion.noarch: E: subsys-not-used /etc/rc.d/init.d/salt-minion
It seems you have a half copy of a debian initscript or something...
You could compare it to
http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscript_template and
try to clean up rpmlint till it's error/warning free and then correct the
macros above to include the systemd scripts.
(I didn't need to write one yet, so I won't be of great help here...)
(In reply to comment #13)
There is a python26-PyXML, which I've moved properly, but there isn't a yum or
libvirt-python *specifically* for 2.6. I am not sure it affects the
functionality of salt in those areas. I'll bug Thatch and see how he wants to
proceed.
Ok, having those deps in %if (0%{?rhel} 7 || 0%{?fedora} 15) would be
best, I think. Then it doesn't clutter in the python26 package, but might lead
to a crash (but Thatch will probably fix that ;))
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760294] Review Request: freexl - Library to extract data from within an Excel spreadsheet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760294 --- Comment #8 from Volker Fröhlich volke...@gmx.at 2012-01-08 21:14:25 EST --- No, I'm not. I can register, but I guess you need some sort of privileges, right? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670088] Review Request: smlnj - Standard ML of New Jersey
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670088 Simon Green sgr...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772521] New: Review Request: clib - A Library for providing advanced C functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: clib - A Library for providing advanced C functions https://bugzilla.redhat.com/show_bug.cgi?id=772521 Summary: Review Request: clib - A Library for providing advanced C functions Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: arangamani.kan...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: https://github.com/downloads/arangamani/clib/clib.spec SRPM URL: https://github.com/downloads/arangamani/clib/clib-0.2.3-1.fc16.src.rpm Description: clib is a development library which provides the end user with hashes, arrays and other features that are very useful for programming in the C programming language. Note: This is my first package for fedora, and I need a SPONSOR. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737286] Review Request: salt - A parallel remote execution system
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737286
--- Comment #16 from Clint Savage her...@gmail.com 2012-01-08 22:26:43 EST ---
I believe I've cleaned up all of the rpmlint. I really should have run that
last time and just missed it :(
$ rpmlint ~/rpmbuild/SPECS/salt.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[clints@x201 (master) rpm]$ rpmlint ~/rpmbuild/SRPMS/salt-0.9.4-6.fc16.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
If you check all of the binary rpms, they should be just as clean. I won't put
their output here for brevity.
As for the rest:
- %if ! (0%{?rhel} 7 || 0%{?fedora} 15) doesn't work on f16 as rhel is
undefined and 0 is 7 -- sysV is installed.
e.g. this should work: %if (0%{?rhel} 7 || 0%{?fedora} 15)
and below where is %if (0%{?rhel} 7 || 0%{?fedora} 15) it should be:
%if ! (0%{?rhel} 7 || 0%{?fedora} 15)
Yep, missed that. In fact, I missed it in quite a few places and that is what
cleaned up a bunch of the rpmlint problems.
-
http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_spec_file_scriptlets
:
%preun -n salt-master/minion is missing
Fixed this too.
It seems you have a half copy of a debian initscript or something...
You could compare it to
http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscript_template and
try to clean up rpmlint till it's error/warning free and then correct the
macros above to include the systemd scripts.
(I didn't need to write one yet, so I won't be of great help here...)
It really looks like the main problem I had wasn't with the scripts, but with
my login in the spec file. Once I adjusted it, things are good. I did make
minor adjustments to the lsb headers in the init scripts, however.
Ok, having those deps in %if (0%{?rhel} 7 || 0%{?fedora} 15) would be
best, I think. Then it doesn't clutter in the python26 package, but might lead
to a crash (but Thatch will probably fix that ;))
Actually, I don't know if that would be the best approach. It seems that there
might be no real reason to not have them in both. For the time being, I'm going
to leave them. When I am able to chat with Thatch, I may change them at that
point.
SPEC: http://herlo.fedorapeople.org/rpms/salt.spec
SRPM: http://herlo.fedorapeople.org/rpms/salt-0.9.4-6.fc16.src.rpm
Thanks,
Clint
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772521] Review Request: clib - A Library for providing advanced C functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772521 --- Comment #1 from Arangamanikkannan Manickam arangamani.kan...@gmail.com 2012-01-08 23:23:26 EST --- rpmlint clib.spec ../SRPMS/clib* ../RPMS/*/clib* clib.x86_64: W: no-documentation clib-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770781] Review Request: jboss-logging-spi - JBoss Logging Programming Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770781 Ricardo Arguello ricardo.argue...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG Last Closed||2012-01-09 00:08:46 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 740687] Review Request: python-pygraphviz - PyGraphviz package for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=740687 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added CC||robinlee.s...@gmail.com AssignedTo|nob...@fedoraproject.org|robinlee.s...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771171] Review Request: django-tastypie - A webservice API framework for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771171 Bohuslav Kabrda bkab...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-09 01:42:49 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 Bohuslav Kabrda bkab...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Bohuslav Kabrda bkab...@redhat.com 2012-01-09 01:42:03 EST --- Looks good now, package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 740687] Review Request: python-pygraphviz - PyGraphviz package for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=740687 --- Comment #5 from Robin Lee robinlee.s...@gmail.com 2012-01-09 01:55:38 EST --- The specfile can't build since the '%files doc' section is commented out. And it should be cleaned up a bit before beginning serious review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772521] Review Request: clib - A Library for providing advanced C functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772521 Arangamanikkannan Manickam arangamani.kan...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 Matthias Runge mru...@matthias-runge.de changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Matthias Runge mru...@matthias-runge.de 2012-01-09 02:29:40 EST --- Bohuslav, thanks for the review. It has been a pleasure for me! New Package SCM Request === Package Name: python-ladon Short Description: Multiprotocol approach to creating a webservice Owners: mrunge Branches: f16, el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771837] Review Request: gubbi-fonts - Free Kannada Opentype serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771837 Pravin Satpute psatp...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Pravin Satpute psatp...@redhat.com 2012-01-09 02:32:50 EST --- Thank you Parag for review, i will do the suggested changes during git import. New Package SCM Request === Package Name: gubbi-fonts Short Description: Free Kannada Opentype serif font Owners: pravins Branches: f16 InitialCC: i18n-team -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771842] Review Request: navilu-fonts - Free Kannada Opentype sans-serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771842 Pravin Satpute psatp...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Pravin Satpute psatp...@redhat.com 2012-01-09 02:31:32 EST --- Thank you Parag for review, i will do the suggested changes during git import. New Package SCM Request === Package Name: navilu-fonts Short Description: Free Kannada Opentype sans-serif font Owners: pravins Branches: f16 InitialCC: i18n-team -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-01-09 02:40:24 EST --- spatialite-gui-1.4.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/spatialite-gui-1.4.0-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759941] Review Request: spatialite-gui - GUI to manage Spatialite databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759941 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-01-09 02:40:32 EST --- spatialite-gui-1.4.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/spatialite-gui-1.4.0-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
