[Bug 969877] Review Request: rubygem-timers - Pure Ruby one-shot and periodic timers
https://bugzilla.redhat.com/show_bug.cgi?id=969877 --- Comment #10 from Björn Esser --- (In reply to Axilleas Pipinellis from comment #7) > Can I ping you in irc? Better not "pollute" BZ. You can ping me on IRC now,too. My nick is: besser82, hanging around in #fedora, #fedora-de, #fedora-mentors -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AFYN9PX06v&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970896] New: Review Request: sugar-paths - Paths is a sliding tile game where the goal is to create closed paths
https://bugzilla.redhat.com/show_bug.cgi?id=970896 Bug ID: 970896 Summary: Review Request: sugar-paths - Paths is a sliding tile game where the goal is to create closed paths Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: danis...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://snavin.fedorapeople.org/packages/sugar-paths/sugar-paths.spec SRPM URL: http://snavin.fedorapeople.org/packages/sugar-paths/sugar-paths-18-1.fc18.src.rpm Description: Paths is a sliding tile game where the goal is to create closed paths Fedora Account System Username: snavin -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kL8c48Hbv2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970009] Review Request: stoken - Token code generator compatible with RSA SecurID 128-bit (AES) token
https://bugzilla.redhat.com/show_bug.cgi?id=970009 --- Comment #23 from David Woodhouse --- Hm. For an application the question is a bit simpler. If the app needs to generate random numbers often and fast, then using rdrand directly is the way to go. Otherwise, just use the library and don't worry about it. However, it's a bit harder for the library. I suppose it wants to be optional, and the distribution packager needs to do the right thing. Or perhaps this is just another case of Debian and Ubuntu being a bit behind the curve. We update the libraries to assume that rngd is doing it, and when we finally have current software in .deb form it'll all work out OK. Getting back vaguely on-topic... it occurs to me that stoken could probably just open /dev/random and read from it to get a random number. You don't do this often, right? It's only for 'stoken import --random'? And thus it is /dev/random not /dev/urandom that you need? In that case I could have just used nettle instead of gnutls, and not had to worry about the library initialisation issues. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O4179VOD53&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841239] Review Request: sugar-story - an activity that uses images to prompt the learner to tell stories
https://bugzilla.redhat.com/show_bug.cgi?id=841239 --- Comment #7 from Kalpa Welivitigoda --- License should be GPLv3 I guess -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lb42tw7bVv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 842101] Review Request: sugar-yupana - A counting and calculating device used by the Incan
https://bugzilla.redhat.com/show_bug.cgi?id=842101 Kalpa Welivitigoda changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #9 from Kalpa Welivitigoda --- Package APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lkej6OugX6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 842101] Review Request: sugar-yupana - A counting and calculating device used by the Incan
https://bugzilla.redhat.com/show_bug.cgi?id=842101
Kalpa Welivitigoda changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #8 from Kalpa Welivitigoda ---
Looks for for me
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package requires other packages for directories it uses.
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package is not known to require ExcludeArch.
[ ]: Package complies to the Packaging Guidelines
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"MIT/X11 (BSD like)", "GPL (v3 or later)", "Unknown or generated". 1
files have unknown license. Detailed output of licensecheck in
/home/kalpa/fedora-review/842101-sugar-yupana/licensecheck.txt
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macro is (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Package must own all directories that it creates.
[ ]: Package does not own files or directories owned by other packages.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 40960 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
Python:
[ ]: Python eggs must not download any dependencies during the build process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: R
[Bug 970896] Review Request: sugar-paths - Paths is a sliding tile game where the goal is to create closed paths
https://bugzilla.redhat.com/show_bug.cgi?id=970896 --- Comment #1 from Danishka Navin --- well I need to patch this as FSF address is incorrect. Please do not review this package till I submit the reverted srpm and spec. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HbZPg2MaSu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882481] Review Request: python-doit - Automation Tool
https://bugzilla.redhat.com/show_bug.cgi?id=882481 --- Comment #20 from José Matos --- (In reply to Mario Blättermann from comment #18) > The files LICENSE and README should appear in both python2 and python3 > versions. One can install them independently from each other, so the python3 > package would remain without license declaration and basic docs. TODO.txt > should be added to the -docs subpackage. > Or another way for the docs: Move all doc files to the -docs package and > mark it as required by the python2 and python3 packages. This way the docs > would be always present, independently from which python version is used. I chose the first option as it is the least invasive: Spec URL: http://jamatos.fedorapeople.org/python-doit.spec SRPM URL: http://jamatos.fedorapeople.org/python-doit-0.21.0-2.fc20.src.rpm To have all the subpackages depending on -doc would defeat the reason to have a separate -doc in the first place. (In reply to Christopher Meng from comment #19) > (In reply to Mario Blättermann from comment #18) > > The files LICENSE and README should appear in both python2 and python3 > > versions. One can install them independently from each other, so the python3 > > package would remain without license declaration and basic docs. TODO.txt > > should be added to the -docs subpackage. > > Or another way for the docs: Move all doc files to the -docs package and > > mark it as required by the python2 and python3 packages. This way the docs > > would be always present, independently from which python version is used. > > Nice suggestion. > > BTW, this package seems has test problem during %check section, can we > ignore this section? We should not but there is a strange random problem as it is documented in the package. It fails sometimes in one or two places and sometimes it works. I took a look into debian package and there is not any special code for this case and after spending lots of time with it I am lost here. > I need this package for another package, so... FWIW I will be busy until next week so I will return to this in one week. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZkQC5bTOsi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970896] Review Request: sugar-paths - Paths is a sliding tile game where the goal is to create closed paths
https://bugzilla.redhat.com/show_bug.cgi?id=970896 Danishka Navin changed: What|Removed |Added CC||pnem...@redhat.com --- Comment #2 from Danishka Navin --- the remaining (there are two rpmlint errors for rpm, in uploaded srpm. i fixed one in local copy) issue is the incorrect fsf address in the constants.py Please advice me how to do this. Do I need to patch the constants.py within the .spec file itself? if yes, can I have an example? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WUMQvsaYTD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970896] Review Request: sugar-paths - Paths is a sliding tile game where the goal is to create closed paths
https://bugzilla.redhat.com/show_bug.cgi?id=970896 --- Comment #3 from Danishka Navin --- I will inform to the upstream developer while i fix this in downstream. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LJFn8zcB4n&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959509] Review Request: trac10 - Enhanced wiki and issue tracking system
https://bugzilla.redhat.com/show_bug.cgi?id=959509 --- Comment #14 from Dan Mashal --- [dan@localhost srpm]$ rpmlint trac10-1.0.1-3.el6.src.rpm trac10.src: W: spelling-error %description -l en_US Trac -> Traci, Tracy, Tran trac10.src: W: spelling-error %description -l en_US changesets -> change sets, change-sets, changeless trac10.src:36: W: macro-in-comment %patch0 1 packages and 0 specfiles checked; 0 errors, 3 warnings. [dan@localhost srpm]$ rpmlint trac10.spec trac10.spec:36: W: macro-in-comment %patch0 0 packages and 1 specfiles checked; 0 errors, 1 warnings. Scratch build here: koji build --scratch dist-6E-epel trac10-1.0.1-3.el6.src.rpm Uploading srpm: trac10-1.0.1-3.el6.src.rpm [] 100% 00:00:08 3.34 MiB 399.02 KiB/sec Created task: 5469395 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5469395 Watching tasks (this may be safely interrupted)... 5469395 build (dist-6E-epel, trac10-1.0.1-3.el6.src.rpm): open (buildvm-20.phx2.fedoraproject.org) 5469398 buildArch (trac10-1.0.1-3.el6.src.rpm, noarch): free 5469398 buildArch (trac10-1.0.1-3.el6.src.rpm, noarch): free -> open (buildvm-22.phx2.fedoraproject.org) 5469398 buildArch (trac10-1.0.1-3.el6.src.rpm, noarch): open (buildvm-22.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 5469395 build (dist-6E-epel, trac10-1.0.1-3.el6.src.rpm): open (buildvm-20.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 5469395 build (dist-6E-epel, trac10-1.0.1-3.el6.src.rpm) completed successfully I think the BSD license coversr the MIT if you want to be super cautious about it, change the license to BSD + MIT (or X11). Other than that we have a comment from someoen confirming that the package works. NOTE: Okay so one thing, does the BSD license cover MIT/X11? That's all I have minus the fact that Requires: python-genshi06 >= 0.6 is obsoleted in Fedora. NOTE: This is not for Fedora it's for EPEL. SHOULD: Get rid of unused patch files in the spec. Other than that looks GOOD to ME. And confirmed working by another comment. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wpBRerUxyg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959509] Review Request: trac10 - Enhanced wiki and issue tracking system
https://bugzilla.redhat.com/show_bug.cgi?id=959509 --- Comment #15 from Dan Mashal --- Also note, fedora-review fails, (packages should build on rawhide). Maybe add a provides for Fedora builds? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MUeaFDFInK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 842101] Review Request: sugar-yupana - A counting and calculating device used by the Incan
https://bugzilla.redhat.com/show_bug.cgi?id=842101 --- Comment #10 from Danishka Navin --- New Package SCM Request === Package Name: sugar-yupana Short Description: A counting and calculating device used by the Incan Owners: snavin Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kYEhOMgDG6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 842101] Review Request: sugar-yupana - A counting and calculating device used by the Incan
https://bugzilla.redhat.com/show_bug.cgi?id=842101 Danishka Navin changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nJeN9Ddu8w&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970927] New: Review Request: php-channel-nrk - Adds pear.nrk.io channel to PEAR
https://bugzilla.redhat.com/show_bug.cgi?id=970927 Bug ID: 970927 Summary: Review Request: php-channel-nrk - Adds pear.nrk.io channel to PEAR Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: https://raw.github.com/remicollet/remirepo/9790fd8c5c196bef38189466634411ea11a0e10c/php/channel/php-channel-nrk/php-channel-nrk.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-channel-nrk-1.3-1.remi.src.rpm Description: Adds pear.nrk.io channel to PEAR Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=quYwo3TLxY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970929] Review Request: php-nrk-Predis - PHP client library for Redis
https://bugzilla.redhat.com/show_bug.cgi?id=970929 Remi Collet changed: What|Removed |Added Depends On||970927 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g8sIDYJwRR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970927] Review Request: php-channel-nrk - Adds pear.nrk.io channel to PEAR
https://bugzilla.redhat.com/show_bug.cgi?id=970927 Remi Collet changed: What|Removed |Added Blocks||970929 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NJbmtuhxku&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970929] New: Review Request: php-nrk-Predis - PHP client library for Redis
https://bugzilla.redhat.com/show_bug.cgi?id=970929 Bug ID: 970929 Summary: Review Request: php-nrk-Predis - PHP client library for Redis Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: https://raw.github.com/remicollet/remirepo/391bea69f62cda0ef358dbf8de8f94fac49855d9/php/php-nrk-Predis/php-nrk-Predis.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-nrk-Predis-0.8.3-1.remi.src.rpm Description: Flexible and feature-complete PHP client library for Redis. Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qn1PWI4VLn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970930] New: Review Request: php-horde-Horde-HashTable - Horde Hash Table Interface
https://bugzilla.redhat.com/show_bug.cgi?id=970930 Bug ID: 970930 Summary: Review Request: php-horde-Horde-HashTable - Horde Hash Table Interface Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: https://raw.github.com/remicollet/remirepo/fbb687effde57f878d33f2be63982d52f6db5fbe/php/horde/php-horde-Horde-HashTable/php-horde-Horde-HashTable.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-HashTable-1.0.0-1.remi.src.rpm Description: Provides an abstract API to access various hash table implementations. Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KTajpMOJ4h&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858818] Review Request: sugar-srilanka - Game about the geography of Sri Lanka
https://bugzilla.redhat.com/show_bug.cgi?id=858818
--- Comment #5 from Peter Robinson ---
> Please note that, I got an warning while running rpmlint.
> "strange-permission i_know_sri_lanka-1.xo 0640L"
>
> I have added following entry under %files but no luck.
>
> %attr(644,-,-)%{sugaractivitydir}/IknowSriLanka.activity/
Because it's the source file that's got the issues not the files that are
installed as part of the build. Check the i_know_sri_lanka-1.xo in
~/rpmbuild/SOURCES or where ever your building it. I suspect "chmod 660
i_know_sri_lanka-1.xo" will likely fix the problem
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=s8OqQgc1Tq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970930] Review Request: php-horde-Horde-HashTable - Horde Hash Table Interface
https://bugzilla.redhat.com/show_bug.cgi?id=970930 Remi Collet changed: What|Removed |Added CC||n...@fedoraproject.org Depends On||970929 Alias||Horde_HashTable --- Comment #1 from Remi Collet --- New dependency of Horde_Cache. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YF64sFfCsm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970931] New: Review Request: pythonqt - Lightweight script binding of the Qt framework to the Python language
https://bugzilla.redhat.com/show_bug.cgi?id=970931 Bug ID: 970931 Summary: Review Request: pythonqt - Lightweight script binding of the Qt framework to the Python language Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jkal...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://jkaluza.fedorapeople.org/pythonqt.spec SRPM URL: http://jkaluza.fedorapeople.org/pythonqt-2.1-1.fc18.src.rpm Description: PythonQt is a dynamic and lightweight script binding of the Qt framework to the Python language. It can be easily embedded into Qt applications and makes any QObject derived object scriptable via Python without the need of wrapper code generation. Fedora Account System Username: jkaluza -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZWndnbVIQ0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970929] Review Request: php-nrk-Predis - PHP client library for Redis
https://bugzilla.redhat.com/show_bug.cgi?id=970929 Remi Collet changed: What|Removed |Added Blocks||970930 (Horde_HashTable) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wovPqB5gn8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890769] Review Request: embryo - Small Pawn based virtual machine and compiler.
https://bugzilla.redhat.com/show_bug.cgi?id=890769 Dan Mashal changed: What|Removed |Added Flags||fedora-cvs? --- Comment #17 from Dan Mashal --- Package Change Request == Package Name: embryo New Branches: f18 f19 Owners: vicodan mether -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6cB3gAB5EA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913200] Review Request: python-testrepository - A repository of test results
https://bugzilla.redhat.com/show_bug.cgi?id=913200 Pádraig Brady changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Pádraig Brady --- New Package SCM Request === Package Name: python-testrepository Short Description: A repository of test results Owners: pbrady mrunge Branches: f18 f19 el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9Feu3Xzsla&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858818] Review Request: sugar-srilanka - Game about the geography of Sri Lanka
https://bugzilla.redhat.com/show_bug.cgi?id=858818 --- Comment #6 from Danishka Navin --- Thanks Peter for the point. 664 fixed the issue. SPEC file URL: http://snavin.fedorapeople.org/packages/sugar-srilanka/sugar-srilanka.spec SRPM URL: http://snavin.fedorapeople.org/packages/sugar-srilanka/sugar-srilanka-1-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k71Azjui5w&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837587] Review Request: cargo-core - Cargo container wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=837587 --- Comment #6 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/cargo-core.spec SRPM URL: http://gil.fedorapeople.org/cargo-core-1.4.2-1.fc18.src.rpm Update to 1.4.2 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5469562 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3pwoBnoPwD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970009] Review Request: stoken - Token code generator compatible with RSA SecurID 128-bit (AES) token
https://bugzilla.redhat.com/show_bug.cgi?id=970009 --- Comment #24 from Simone Caronni --- (In reply to Kevin Cernekee from comment #21) > (In reply to Simone Caronni from comment #13) > If you do manage to revive the libtomcrypt package, it might be a good idea > to see if dropbear (which currently bundles libtomcrypt) can use it. True, I will file a bug on it. > > Actually I preferred the GnuTLS patch, including the 5 files from > > libtomcrypt makes things more complicated when packaging. > > OK - I don't have a strong opinion one way or the other. The "5 files" code > was experimental and I can just kill off that branch. Actually libtomcrypt is used now only by 1 package (2 if we count dropbear not using the bundled library): # repoquery --whatrequires "libtomcrypt.so.0()(64bit)" libtomcrypt-devel-0:1.17-14.fc18.x86_64 libtomcrypt-devel-0:1.17-15.fc18.x86_64 olpc-os-builder-0:6.0.0-1.fc19.x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=syUOG3lAA1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970956] New: Review Request: libclens - A convenience library to aid in porting code from OpenBSD
https://bugzilla.redhat.com/show_bug.cgi?id=970956 Bug ID: 970956 Summary: Review Request: libclens - A convenience library to aid in porting code from OpenBSD Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: cicku...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://cicku.me/libclens.spec SRPM URL: http://cicku.me/libclens-0.7.0-1.fc20.src.rpm Description: clens is a convenience library to aid in porting code from OpenBSD to different operating systems. Operating systems traditionally have different enough APIs that porting code is painful and can litter pretty code with ugly ifdef goo. In order to keep code readable and drastically reduce the number of ifdefs needed, clens brings other APIs or missing functions into specific OS "focus". Fedora Account System Username: cicku -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b2DxZUM3vw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884674] Review Request: kde-plasma-alsa-volume -- ALSA Volume Control plasmoid
https://bugzilla.redhat.com/show_bug.cgi?id=884674 Fl@sh changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #25 from Fl@sh --- New Package SCM Request === Package Name: kde-plasma-alsa-volume Short Description: ALSA Volume Control plasmoid Owners: f1ash Branches: f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IsgusdbXNJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970009] Review Request: stoken - Token code generator compatible with RSA SecurID 128-bit (AES) token
https://bugzilla.redhat.com/show_bug.cgi?id=970009
David Woodhouse changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|dw...@infradead.org
Flags||fedora-review+
--- Comment #25 from David Woodhouse ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in stoken-
devel , stoken-libs , stoken-cli , stoken-gui
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked when required
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
I would prefer to see BuildRequires: pkgconfig(libtomcrypt) pkgconfig(gtk+-2.0)
instead of the package names libtomcrypt-devel and gtk2-devel.
In fact, I'd much rather see pkgconfig(gtk+-3.0) and it doesn't look
particularly hard, but neither of those observations make it a review failure.
Review passed; thanks for contributing to Fedora.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=bLAe9bq0B3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 842101] Review Request: sugar-yupana - A counting and calculating device used by the Incan
https://bugzilla.redhat.com/show_bug.cgi?id=842101 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nMa4WrnD35&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 842101] Review Request: sugar-yupana - A counting and calculating device used by the Incan
https://bugzilla.redhat.com/show_bug.cgi?id=842101 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IeV6Y0V89z&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913200] Review Request: python-testrepository - A repository of test results
https://bugzilla.redhat.com/show_bug.cgi?id=913200 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vHjPh0za4T&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913200] Review Request: python-testrepository - A repository of test results
https://bugzilla.redhat.com/show_bug.cgi?id=913200 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mE3Ha0O4l8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964072] Review Request: ghc-text - An efficient packed Unicode text type
https://bugzilla.redhat.com/show_bug.cgi?id=964072 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vKpxz7G6zl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964072] Review Request: ghc-text - An efficient packed Unicode text type
https://bugzilla.redhat.com/show_bug.cgi?id=964072 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2FtHfk0kiW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969848] Review Request: python-catkin-sphinx - Sphinx plugins for Catkin projects
https://bugzilla.redhat.com/show_bug.cgi?id=969848 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NPR59sccS5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969848] Review Request: python-catkin-sphinx - Sphinx plugins for Catkin projects
https://bugzilla.redhat.com/show_bug.cgi?id=969848 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mwh2jZNtqw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969929] Review Request: nodejs-callsite - Provides access to V8's "raw" CallSites from Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=969929 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f03T36idGW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969929] Review Request: nodejs-callsite - Provides access to V8's "raw" CallSites from Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=969929 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zXc1KhfTyf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969931] Review Request: nodejs-better-assert - C-style assert() for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=969931 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L5n1EWUgDi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969931] Review Request: nodejs-better-assert - C-style assert() for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=969931 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GhLx7QeT6y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969938] Review Request: nodejs-normalize-package-data - Normalizes npm/package.json metadata
https://bugzilla.redhat.com/show_bug.cgi?id=969938 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FVofQ4SkmW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969933] Review Request: nodejs-github-url-from-git - Parse a GitHub git URL and return the GitHub repository URL
https://bugzilla.redhat.com/show_bug.cgi?id=969933 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AUSqcIcJn3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969933] Review Request: nodejs-github-url-from-git - Parse a GitHub git URL and return the GitHub repository URL
https://bugzilla.redhat.com/show_bug.cgi?id=969933 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8eCqlXztdb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969938] Review Request: nodejs-normalize-package-data - Normalizes npm/package.json metadata
https://bugzilla.redhat.com/show_bug.cgi?id=969938 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JXZGqWaiZv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884674] Review Request: kde-plasma-alsa-volume -- ALSA Volume Control plasmoid
https://bugzilla.redhat.com/show_bug.cgi?id=884674 --- Comment #26 from Jon Ciesla --- Already exists. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P312fX0G6Y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884674] Review Request: kde-plasma-alsa-volume -- ALSA Volume Control plasmoid
https://bugzilla.redhat.com/show_bug.cgi?id=884674 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y1sBHdtqwn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890769] Review Request: embryo - Small Pawn based virtual machine and compiler.
https://bugzilla.redhat.com/show_bug.cgi?id=890769 --- Comment #18 from Jon Ciesla --- mether lacks a FAS account. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4xvnDm8gRH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890769] Review Request: embryo - Small Pawn based virtual machine and compiler.
https://bugzilla.redhat.com/show_bug.cgi?id=890769 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZL0e8zogwc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949324] Review Request: oath-toolkit - One-time password components
https://bugzilla.redhat.com/show_bug.cgi?id=949324
David Woodhouse changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|dw...@infradead.org
--- Comment #12 from David Woodhouse ---
Working through the rest of the review guidelines... should the pam_oath
package require %{_libdir}/security (or 'pam')?
And should the Requires: Requires: libpskc = %{version}-%{release} in
libpskc-devel actually be Requires: libpskc{?_isa} = %{version}-%{release}
(and other packages likewise)?
In addition to the rpmlint warnings in comment 11, I also see the following:
libpskc.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpskc.so.0.0.1
/lib64/libltdl.so.7
libpskc.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpskc.so.0.0.1
/lib64/libxslt.so.1
libpskc.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpskc.so.0.0.1
/lib64/libz.so.1
libpskc.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpskc.so.0.0.1
/lib64/libdl.so.2
libpskc.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpskc.so.0.0.1
/lib64/libm.so.6
Other than that, I think everything looks fine. If you can submit an update
with these fixed I'll go ahead and approve it.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=DnoTvZP2jC&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970964] New: Review Request: jboss-annotations-1.2-api - Common Annotations 1.2 API
https://bugzilla.redhat.com/show_bug.cgi?id=970964 Bug ID: 970964 Summary: Review Request: jboss-annotations-1.2-api - Common Annotations 1.2 API Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mgold...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://goldmann.fedorapeople.org/package_review/jboss-annotations-1.2-api/1/jboss-annotations-1.2-api.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/jboss-annotations-1.2-api/1/jboss-annotations-1.2-api-1.0.0-0.1.Alpha1.fc19.src.rpm Fedora Account System Username: goldmann Description: This package contains Common Annotations 1.2 API. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5469722 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JXHrVQcr6s&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970964] Review Request: jboss-annotations-1.2-api - Common Annotations 1.2 API
https://bugzilla.redhat.com/show_bug.cgi?id=970964 Marek Goldmann changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8Gkgsiq9HF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837589] Review Request: cargo-extensions - Tools for manipulate Java EE containers
https://bugzilla.redhat.com/show_bug.cgi?id=837589 --- Comment #4 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/cargo-extensions.spec SRPM URL: http://gil.fedorapeople.org/cargo-extensions-1.4.2-1.fc18.src.rpm - Update to 1.4.2 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GjAc0Z4thN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965930] Review Request: spec-version-maven-plugin - Spec Version Maven Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=965930 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SFW3uJCSmv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947511] Review Request: glassfish-jax-rs-api - JAX-RS API Specification (JSR 339)
https://bugzilla.redhat.com/show_bug.cgi?id=947511 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rm2j2orlRv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970213] Review Request: fros - Universal screencasting fronted with pluggable support for various backends
https://bugzilla.redhat.com/show_bug.cgi?id=970213 --- Comment #3 from Jiri Moskovcak --- Uploaded fixed spec and srpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8cMIPgExUn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970931] Review Request: pythonqt - Lightweight script binding of the Qt framework to the Python language
https://bugzilla.redhat.com/show_bug.cgi?id=970931 --- Comment #1 from Jan Včelák --- I will review the package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y4jM0AXodg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915923] Review Request: qt5-qtxmlpatterns - Qt5 - QtXmlPatterns component
https://bugzilla.redhat.com/show_bug.cgi?id=915923
Erik Schilling changed:
What|Removed |Added
CC||ablu.erikschilling@googlema
||il.com
--- Comment #2 from Erik Schilling ---
Not sure where to mention this issue (here or in the qt quick part), but:
I installed your qt5 packages and then tried to build a project which uses QML.
The build itself works fine. However if I run the binary then my UI is not
working since there is an error in the qml files:
file:///home/ablu/mana/manamobile/qml/main/ServerPage.qml:76:5: Qt was built
without support for xmlpatterns
XmlListModel {
^
I installed the xmlpatterns package using your SRPM here. The qt5-base is from
the repositories, the other qt5 packages are all SRPM builds from your review
requests.
The project I tried to compile is https://github.com/mana/manamobile/
The project itself builds fine against the precompiled qt version of
qt-project. So it does not seem to be an issue in that project.
ablu@ablu: ~$ yum info qt5-qtbase
Installed Packages
Name: qt5-qtbase
Arch: i686
Version : 5.0.2
Release : 3.fc19
[...]
Repo: installed
[...]
ablu@ablu: ~$ yum info qt5-qtxmlpatterns
Loaded plugins: auto-update-debuginfo, langpacks, refresh-packagekit
Installed Packages
Name: qt5-qtxmlpatterns
Arch: i686
Version : 5.0.2
Release : 1.fc19
[...]
Repo: installed
From repo : /qt5-qtxmlpatterns-5.0.2-1.fc19.i686
[...]
Regards and Thanks a lot for working on this qt5 stuff (I would help doing
reviews, but I guess this is out of my league),
Erik
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=knsx5eAZMW&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970972] New: Review Request: cuisine - Chef-like functionnality for Fabric
https://bugzilla.redhat.com/show_bug.cgi?id=970972 Bug ID: 970972 Summary: Review Request: cuisine - Chef-like functionnality for Fabric Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: nils.fed...@anotherhomepage.org QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://medias.anotherhomepage.org/rpms/cuisine.spec SRPM URL: http://medias.anotherhomepage.org/rpms/cuisine-0.6.4-1.fc18.src.rpm Description: Cuisine is a small set of functions that sit on top of Fabric, to abstract common administration operations such as file/dir operations, user/group creation, package install/upgrade, making it easier to write portable administration and deployment scripts. Fedora Account System Username: ahpnils Hi, I just finished packaging up cuisine, and I would appreciate a review so it can be added to Fedora. It might be good to know that I am not an official Fedora Packager, I just created my accounts. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ongoOo2nVB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970972] Review Request: cuisine - Chef-like functionnality for Fabric
https://bugzilla.redhat.com/show_bug.cgi?id=970972 Nils Ratusznik changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fRHVnUSaaT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970972] Review Request: cuisine - Chef-like functionnality for Fabric
https://bugzilla.redhat.com/show_bug.cgi?id=970972 --- Comment #1 from Nils Ratusznik --- I forgot to add that this is my first package, and I am seeking a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eqXiCFANOn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970009] Review Request: stoken - Token code generator compatible with RSA SecurID 128-bit (AES) token
https://bugzilla.redhat.com/show_bug.cgi?id=970009
--- Comment #26 from Simone Caronni ---
(In reply to David Woodhouse from comment #25)
> Package Review
> ==
>
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
>
>
>
> = MUST items =
>
> C/C++:
> [x]: Package does not contain kernel modules.
> [x]: Package contains no static executables.
> [x]: Header files in -devel subpackage, if present.
> [x]: ldconfig called in %post and %postun if required.
> [x]: Package does not contain any libtool archives (.la)
> [x]: Rpath absent or only used for internal libs.
> [x]: Development (unversioned) .so files in -devel subpackage, if present.
>
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
> [x]: %build honors applicable compiler flags or justifies otherwise.
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [x]: Development files must be in a -devel package
> [x]: Package requires other packages for directories it uses.
> [x]: Package uses nothing in %doc for runtime.
> [x]: Package is not known to require ExcludeArch.
> [x]: Fully versioned dependency in subpackages, if present.
> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in stoken-
> devel , stoken-libs , stoken-cli , stoken-gui
> [x]: Package complies to the Packaging Guidelines
> [x]: License field in the package spec file matches the actual license.
> [x]: License file installed when any subpackage combination is installed.
> [x]: Package consistently uses macro is (instead of hard-coded directory
> names).
> [x]: Package is named according to the Package Naming Guidelines.
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [x]: If the package is a rename of another package, proper Obsoletes and
> Provides are present.
> [x]: Package must own all directories that it creates.
> [x]: Package does not own files or directories owned by other packages.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [x]: Package contains systemd file(s) if in need.
> [x]: update-desktop-database is invoked when required
> [x]: Useful -debuginfo package or justification otherwise.
> [x]: Large documentation must go in a -doc subpackage.
> [x]: All build dependencies are listed in BuildRequires, except for any that
> are listed in the exceptions section of Packaging Guidelines.
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
> beginning of %install.
> [x]: Each %files section contains %defattr if rpm < 4.4
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Package contains desktop file if it is a GUI application.
> [x]: Package installs a %{name}.desktop using desktop-file-install if there
> is
> such a file.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: If (and only if) the source package includes the text of the license(s)
> in its own file, then that file, containing the text of the license(s)
> for the package is included in %doc.
> [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
> work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: Package do not use a name that already exist
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as provided
> in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
> %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local
> [x]: Package successfully compiles and builds into binary rpms on at least
> one
> supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
>
>
> I would prefer to see BuildRequires: pkgconfig(libtomcrypt)
> pkgconfig(gtk+-2.0) instead of the package names libtomcrypt-devel and
> gtk2-devel.
Done.
> In fact, I'd much rather see pkgconfig(gtk+-3.0) and it doesn't look
> particularly hard, but neither of those observations make it a review
> failure.
Looking into it, is not my domain of expertise and could be good for learning
on something simple like this gui.
I will post something here before asking for fedora-cvs?.
> Review passed; thanks for contributing to Fedora.
Thank you very much as well for all your contributions :)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=u2chF3dqXK&a=cc_unsubscribe
__
[Bug 970009] Review Request: stoken - Token code generator compatible with RSA SecurID 128-bit (AES) token
https://bugzilla.redhat.com/show_bug.cgi?id=970009 --- Comment #27 from David Woodhouse --- (In reply to Simone Caronni from comment #26) > > In fact, I'd much rather see pkgconfig(gtk+-3.0) and it doesn't look > > particularly hard, but neither of those observations make it a review > > failure. > > Looking into it, is not my domain of expertise and could be good for > learning on something simple like this gui. > > I will post something here before asking for fedora-cvs?. No, go ahead and ship it as-is, matching the upstream release. We can update to gtk3 later, when there's an upstream release that does so. FWIW I think there's only one build *failure*; the rest is just warnings about using deprecated gtk functions that do still work anyway. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zHbWcoJeWZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970972] Review Request: cuisine - Chef-like functionnality for Fabric
https://bugzilla.redhat.com/show_bug.cgi?id=970972 François Cami changed: What|Removed |Added Assignee|nob...@fedoraproject.org|f...@fcami.net --- Comment #2 from François Cami --- I'll review this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XTkUSFPUWs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968594] Review Request: nodejs-console-log - A console.log implementation that plays nice with large amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=968594 Stephen Gallagher changed: What|Removed |Added CC||sgall...@redhat.com --- Comment #2 from Stephen Gallagher --- I'd recommend that we probably want to name this package nodejs-consoledotlog (or console-dot-log), honestly. That would eliminate the confusion. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cQBUa0smxl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967258] Review Request: snowbox - A POP3 server written in Go
https://bugzilla.redhat.com/show_bug.cgi?id=967258 Douglas Schilling Landgraf changed: What|Removed |Added CC||dougsl...@redhat.com Assignee|nob...@fedoraproject.org|dougsl...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XV41eUIeju&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970213] Review Request: fros - Universal screencasting fronted with pluggable support for various backends
https://bugzilla.redhat.com/show_bug.cgi?id=970213 Jakub Filak changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XUWeCHCPT0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970213] Review Request: fros - Universal screencasting fronted with pluggable support for various backends
https://bugzilla.redhat.com/show_bug.cgi?id=970213 Jakub Filak changed: What|Removed |Added Assignee|nob...@fedoraproject.org|jfi...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=exFwr9Jg2d&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894834] Review Request: mingw-gtkglext - OpenGL Extension to GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=894834 --- Comment #25 from Fedora Update System --- mingw-gtkglext-1.2.0-10.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-gtkglext-1.2.0-10.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bfugPssKSj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894834] Review Request: mingw-gtkglext - OpenGL Extension to GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=894834 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aFpXp1cji6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894834] Review Request: mingw-gtkglext - OpenGL Extension to GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=894834 --- Comment #26 from Fedora Update System --- mingw-gtkglext-1.2.0-10.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mingw-gtkglext-1.2.0-10.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UpUwwm070a&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 955804] Review Request: nzbget - Command-line based binary newsgrabber for nzb files
https://bugzilla.redhat.com/show_bug.cgi?id=955804 --- Comment #8 from Marcel Wysocki --- BuildError: package nzbget is blocked for tag f19-updates-candidate who can unblock the package for f18 and f19 ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cLbXNl7l5I&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 955804] Review Request: nzbget - Command-line based binary newsgrabber for nzb files
https://bugzilla.redhat.com/show_bug.cgi?id=955804 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QT9n1LQLD7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 955804] Review Request: nzbget - Command-line based binary newsgrabber for nzb files
https://bugzilla.redhat.com/show_bug.cgi?id=955804 --- Comment #9 from Fedora Update System --- nzbget-10.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/nzbget-10.2-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=URBmJ8z0Wm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968262] Review Request: xboxdrv - Userspace Xbox/Xbox360 Gamepad Driver for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=968262
Douglas Schilling Landgraf changed:
What|Removed |Added
Status|ASSIGNED|NEW
Flags||fedora-review+
--- Comment #3 from Douglas Schilling Landgraf ---
Hi package reviewed manually + fedora-review tool 0.4.1 b2e211f
[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review
Rpmlint
---
Checking: xboxdrv-0.8.5-2.fc18.x86_64.rpm
xboxdrv.x86_64: W: spelling-error Summary(en_US) Userspace -> User space,
User-space, Users pace
xboxdrv.x86_64: W: spelling-error %description -l en_US gamepad -> game pad,
game-pad, gamed
xboxdrv.x86_64: W: spelling-error %description -l en_US userspace -> user
space, user-space, users pace
xboxdrv.x86_64: W: spelling-error %description -l en_US xpad -> pad, x pad
xboxdrv.x86_64: W: spelling-error %description -l en_US gamepads -> game pads,
game-pads, gamekeepers
xboxdrv.x86_64: W: only-non-binary-in-usr-lib
xboxdrv.x86_64: W: doc-file-dependency
/usr/share/doc/xboxdrv-0.8.5/examples/responsecurve-generator.py /usr/bin/env
1 packages and 0 specfiles checked; 0 errors, 7 warnings.
Rpmlint (installed packages)
# rpmlint xboxdrv
xboxdrv.x86_64: W: spelling-error Summary(en_US) Userspace -> User space,
User-space, Users pace
xboxdrv.x86_64: W: spelling-error %description -l en_US gamepad -> game pad,
game-pad, gamed
xboxdrv.x86_64: W: spelling-error %description -l en_US userspace -> user
space, user-space, users pace
xboxdrv.x86_64: W: spelling-error %description -l en_US xpad -> pad, x pad
xboxdrv.x86_64: W: spelling-error %description -l en_US gamepads -> game pads,
game-pads, gamekeepers
xboxdrv.x86_64: W: only-non-binary-in-usr-lib
It's the service file.
xboxdrv.x86_64: W: doc-file-dependency
/usr/share/doc/xboxdrv-0.8.5/examples/responsecurve-generator.py /usr/bin/env
1 packages and 0 specfiles checked; 0 errors, 7 warnings.
All above warnings can be ignored.
[OK] MUST: The package must be named according to the Package Naming Guidelines
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption
[OK] MUST: The package must meet the Packaging Guidelines .
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines
[OK] MUST: The License field in the package spec file must match the actual
license.
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use sha256sum for this
task as it is used by the sources file once imported into git. If no upstream
URL can be specified for this package, please see the Source URL Guidelines for
how to deal with this.
CHECKSUM(SHA256) this package :
411195c4f5310a1a5f21f015daaf00b277f75da89df710308f8abfcf8f337e78
CHECKSUM(SHA256) upstream package :
411195c4f5310a1a5f21f015daaf00b277f75da89df710308f8abfcf8f337e78
[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense
[OK] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[OK] MUST: Packages must NOT bundle copies of system libraries
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[OK] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[OK] MUST: Each package must consistently use macros.
[OK] MUST: The package must contain code, or permissable content.
[OK] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[OK] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built
[OK] MUST: All filenames in rpm packages must be valid UTF-8.
[OK] SHOULD: Package functions as described.
[OK] SHOULD: Latest version is packaged.
[OK] SHOULD: Packager, Vendor, PreReq, Copyrig
[Bug 970009] Review Request: stoken - Token code generator compatible with RSA SecurID 128-bit (AES) token
https://bugzilla.redhat.com/show_bug.cgi?id=970009 --- Comment #28 from Simone Caronni --- Spec URL: http://slaanesh.fedorapeople.org/stoken.spec SRPM URL: http://slaanesh.fedorapeople.org/stoken-0.2-4.fc19.src.rpm - Change gtk and libtomcrypt build requirements (pkgconfig). - Remove useless "--with-libtomcrypt" parameter from %configure. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1pxypaLBfc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970009] Review Request: stoken - Token code generator compatible with RSA SecurID 128-bit (AES) token
https://bugzilla.redhat.com/show_bug.cgi?id=970009 Simone Caronni changed: What|Removed |Added Flags||fedora-cvs? --- Comment #29 from Simone Caronni --- New Package SCM Request === Package Name: stoken Short Description: Token code generator compatible with RSA SecurID 128-bit (AES) token Owners: slaanesh Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0wDQFZhOPM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970009] Review Request: stoken - Token code generator compatible with RSA SecurID 128-bit (AES) token
https://bugzilla.redhat.com/show_bug.cgi?id=970009 --- Comment #30 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gQESyfu6Dw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970009] Review Request: stoken - Token code generator compatible with RSA SecurID 128-bit (AES) token
https://bugzilla.redhat.com/show_bug.cgi?id=970009 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mv4yR19uDF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959509] Review Request: trac10 - Enhanced wiki and issue tracking system
https://bugzilla.redhat.com/show_bug.cgi?id=959509 Jon Ciesla changed: What|Removed |Added Flags||fedora-cvs? --- Comment #16 from Jon Ciesla --- It says modified BSD in README, and they're all in the same family, so I'll leave it. Thanks! New Package SCM Request === Package Name: trac10 Short Description: Enhanced wiki and issue tracking system Owners: limb Branches: el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tyeYN1Bt5I&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890769] Review Request: embryo - Small Pawn based virtual machine and compiler.
https://bugzilla.redhat.com/show_bug.cgi?id=890769 Dan Mashal changed: What|Removed |Added Flags||fedora-cvs? --- Comment #19 from Dan Mashal --- Package Change Request == Package Name: embryo New Branches: f18 f19 Owners: vicodan sundaram My sincerest apologies. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dxjlkYrgj8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812
Douglas Schilling Landgraf changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #1 from Douglas Schilling Landgraf ---
[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review
Rpmlint
---
Checking: hg-git-0.4.0-1.fc18.noarch.rpm
hg-git.noarch: W: spelling-error %description -l en_US changesets -> change
sets, change-sets, changeless
hg-git.noarch: W: spelling-error %description -l en_US losslessly ->
colorlessly, bloodlessly, sleeplessly
hg-git.noarch: W: spelling-error %description -l en_US changeset -> change set,
change-set, changeless
hg-git.noarch: E: incorrect-fsf-address /usr/share/doc/hg-git-0.4.0/COPYING
1 packages and 0 specfiles checked; 1 errors, 3 warnings.
Rpmlint (installed packages)
# rpmlint hg-git
hg-git.noarch: W: spelling-error %description -l en_US changesets -> change
sets, change-sets, changeless
hg-git.noarch: W: spelling-error %description -l en_US losslessly ->
colorlessly, bloodlessly, sleeplessly
hg-git.noarch: W: spelling-error %description -l en_US changeset -> change set,
change-set, changeless
hg-git.noarch: E: incorrect-fsf-address /usr/share/doc/hg-git-0.4.0/COPYING
1 packages and 0 specfiles checked; 1 errors, 3 warnings.
Please see my suggestion later.
[OK] MUST: The package must be named according to the Package Naming Guidelines
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[OK] MUST: The package must meet the Packaging Guidelines
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines
[OK] MUST: The License field in the package spec file must match the actual
license
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use sha256sum for this
task as it is used by the sources file once imported into git. If no upstream
URL can be specified for this package, please see the Source URL Guidelines for
how to deal with this.
CHECKSUM(SHA256) this package :
e82e28805d5e22eb8c7501282ddf9083499f7edf8977c86deaf7557d6f58b40a
CHECKSUM(SHA256) upstream package :
e82e28805d5e22eb8c7501282ddf9083499f7edf8977c86deaf7557d6f58b40a
[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture
[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[OK] MUST: Packages must NOT bundle copies of system libraries.
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[OK] MUST: Permissions on files must be set properly.
[OK] MUST: Each package must consistently use macros.
[OK] MUST: The package must contain code, or permissable content.
[OK] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present
[OK] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[OK] MUST: All filenames in rpm packages must be valid UTF-8.
[OK] MUST: Package contains BR: python2-devel or python3-devel
[OK] MUST: Binary eggs must be removed in %prep
[OK] SHOULD: Packager, Vendor, PreReq, Copyright tags should not be in spec
file
[OK] SHOULD: Sources can be downloaded from URI in Source: tag
[OK] SHOULD: Reviewer should test that the package builds in mock.
[OK] SHOULD: Buildroot is not present
[OK] SHOULD: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[OK] SHOULD: Dist tag is present.
[OK] SHOULD: No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[OK] SHOULD: SourceX tarball generation or download is documented.
[OK] SHOULD: SourceX is a working URL.
[OK] SHOULD: Spec use %global instead of %define.
[OK] SHOULD: Package functions as described.
[OK] SHOULD: Latest version is packaged.
Suggestion
=
Please work with upstream to update the COPYING file with the new FSF address.
hg-git.noarch: E: incorrect-fsf-address /usr/share/doc/hg-git-0.4.0/COPYING
The above suggested ca
[Bug 890769] Review Request: embryo - Small Pawn based virtual machine and compiler.
https://bugzilla.redhat.com/show_bug.cgi?id=890769 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rnDxE9jp8R&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959509] Review Request: trac10 - Enhanced wiki and issue tracking system
https://bugzilla.redhat.com/show_bug.cgi?id=959509 --- Comment #17 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sI5wxQpYNr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959509] Review Request: trac10 - Enhanced wiki and issue tracking system
https://bugzilla.redhat.com/show_bug.cgi?id=959509 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YwwEt9Hei8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890769] Review Request: embryo - Small Pawn based virtual machine and compiler.
https://bugzilla.redhat.com/show_bug.cgi?id=890769 --- Comment #20 from Jon Ciesla --- Branches already exists, handle co-maintainers in pkgdb. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JA3bXBULli&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913200] Review Request: python-testrepository - A repository of test results
https://bugzilla.redhat.com/show_bug.cgi?id=913200 --- Comment #14 from Fedora Update System --- python-testrepository-0.0.15-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-testrepository-0.0.15-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zi4DIAaQAl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913200] Review Request: python-testrepository - A repository of test results
https://bugzilla.redhat.com/show_bug.cgi?id=913200 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3ylgt1Fx1Z&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913200] Review Request: python-testrepository - A repository of test results
https://bugzilla.redhat.com/show_bug.cgi?id=913200 --- Comment #15 from Fedora Update System --- python-testrepository-0.0.15-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-testrepository-0.0.15-4.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ing39LegA7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913200] Review Request: python-testrepository - A repository of test results
https://bugzilla.redhat.com/show_bug.cgi?id=913200 --- Comment #16 from Fedora Update System --- python-testrepository-0.0.15-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-testrepository-0.0.15-4.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tf3midTppi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890769] Review Request: embryo - Small Pawn based virtual machine and compiler.
https://bugzilla.redhat.com/show_bug.cgi?id=890769 Dan Mashal changed: What|Removed |Added Flags||fedora-cvs? --- Comment #21 from Dan Mashal --- Package Change Request == Package Name: embryo New Branches: f20 Owners: vicodan sundaram f20 is still marked as an orphan if you could please. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xpduVtN637&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949324] Review Request: oath-toolkit - One-time password components
https://bugzilla.redhat.com/show_bug.cgi?id=949324 Jaroslav Škarvada changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SN9zU1LCF6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949324] Review Request: oath-toolkit - One-time password components
https://bugzilla.redhat.com/show_bug.cgi?id=949324
--- Comment #13 from Jaroslav Škarvada ---
New files:
Spec URL: http://fedorapeople.org/~jskarvad/oath-toolkit/oath-toolkit.spec
SRPM URL:
http://fedorapeople.org/~jskarvad/oath-toolkit/oath-toolkit-2.0.2-3.fc18.src.rpm
(In reply to David Woodhouse from comment #12)
> Working through the rest of the review guidelines... should the pam_oath
> package require %{_libdir}/security (or 'pam')?
>
Yes, I forget :) Fixed.
> And should the Requires: Requires: libpskc = %{version}-%{release} in
> libpskc-devel actually be Requires: libpskc{?_isa} = %{version}-%{release}
> (and other packages likewise)?
>
Probably, they reference arch libs, so I fixed both devel packages. Probably no
need for other packages.
> In addition to the rpmlint warnings in comment 11, I also see the following:
>
> libpskc.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpskc.so.0.0.1 /lib64/libltdl.so.7
> libpskc.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpskc.so.0.0.1 /lib64/libxslt.so.1
> libpskc.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpskc.so.0.0.1 /lib64/libz.so.1
> libpskc.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpskc.so.0.0.1 /lib64/libdl.so.2
> libpskc.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpskc.so.0.0.1 /lib64/libm.so.6
>
I was unable to reproduce this (f18/f19), but to be sure I linked it with
--as-needed.
Man pages also fixed, patch sent upstream.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=i9SFYZbcGB&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959509] Review Request: trac10 - Enhanced wiki and issue tracking system
https://bugzilla.redhat.com/show_bug.cgi?id=959509 --- Comment #18 from Jon Ciesla --- Sigh. And now it won't build, test failure. Will fix prior to import. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qmBJduLSWc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959509] Review Request: trac10 - Enhanced wiki and issue tracking system
https://bugzilla.redhat.com/show_bug.cgi?id=959509 --- Comment #19 from Dan Mashal --- Odd...there was a few minutes ago. Don't know if that's related but the scratch build is less than 12 hours old -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iSmHSpccqy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959509] Review Request: trac10 - Enhanced wiki and issue tracking system
https://bugzilla.redhat.com/show_bug.cgi?id=959509 --- Comment #20 from Dan Mashal --- Sorry, there was an infrastructure issue* -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JugvD5od1K&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959509] Review Request: trac10 - Enhanced wiki and issue tracking system
https://bugzilla.redhat.com/show_bug.cgi?id=959509 --- Comment #21 from Jon Ciesla --- I meant locally, not koji. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IjMx5TZSHY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 971049] New: Review Request: davix - Toolkit for Http-based file management
https://bugzilla.redhat.com/show_bug.cgi?id=971049 Bug ID: 971049 Summary: Review Request: davix - Toolkit for Http-based file management Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ade...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/davix.spec SRPM URL: http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/davix-0.2.0-1.el5.centos.src.rpm Description: Davix is a toolkit designed for file operations with Http based protocols (WebDav, Amazon S3, ...). Davix provides an API and a set of command line tools. Fedora Account System Username: adev rpmlint : rpmlint /var/lib/mock/epel-5-x86_64/result/*.rpm davix.x86_64: W: incoherent-version-in-changelog 0.2.0-1 ['0.2.0-1.el5.centos', '0.2.0-1.centos'] davix.x86_64: W: no-documentation davix-devel.x86_64: W: no-documentation Koji rawhide : http://koji.fedoraproject.org/koji/taskinfo?taskID=5471071 Koji EL6 : http://koji.fedoraproject.org/koji/taskinfo?taskID=5471088 Koji EL5 : http://koji.fedoraproject.org/koji/taskinfo?taskID=5471084 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uOZIjBb4KC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
