[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC|cicku...@gmail.com  |



--- Comment #8 from Christopher Meng cicku...@gmail.com ---
(In reply to Julio Merino from comment #7)

Yes, it's more like a warning now for packagers.

Hope will Mario will do the review soon.

Thanks.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033800] Review Request: rubygem-pkgwat - Check your gems against Fedora/EPEL

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033800



--- Comment #4 from Achilleas Pipinellis axill...@archlinux.gr ---
(In reply to Ken Dreyer from comment #3)
 (In reply to Achilleas Pipinellis from comment #2)
  Looks good, APPROVED. One minor detail: removal of Gemfile/Rakefile could go
  in %prep but that's not a stopper, do as you wish.
 
 Well, it's happening in %prep already :) See
 https://github.com/axilleas/fedora/commit/
 fff1092a5a6261b751a565fb3c8089e7ebe86ff2
 

Oops, you're right!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033413] Review Request: smuxi - An user-friendly IRC client based on GNOME/GTK+

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033413



--- Comment #3 from Mirco Bauer mmmba...@gnome.org ---
The needed Mono version is lower (= 2.6) if  you disable the JabbR engine. In
the Debian source package I detect if Mono is current enough and enable/disable
the JabbR version, e.g.:
https://github.com/meebey/smuxi/blob/master/debian/rules#L9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033413] Review Request: smuxi - An user-friendly IRC client based on GNOME/GTK+

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033413



--- Comment #4 from Christopher Meng cicku...@gmail.com ---
(In reply to Mirco Bauer from comment #3)
 The needed Mono version is lower (= 2.6) if  you disable the JabbR engine.
 In the Debian source package I detect if Mono is current enough and
 enable/disable the JabbR version, e.g.:
 https://github.com/meebey/smuxi/blob/master/debian/rules#L9

I want to bring more functions to users, and in fact, Fedora mono will be
updated to 3.2.3 soon(Yes, we are only waiting for arm hfp support ready).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033413] Review Request: smuxi - An user-friendly IRC client based on GNOME/GTK+

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033413



--- Comment #5 from Mirco Bauer mmmba...@gnome.org ---
I understand, but I didn't mean to disable JabbR always, only if the Mono
version is too old. Which Mono version is in fedora currently? Maybe I can
supply a patch that allows to build it on that version then...

With Mono 3.2 on armhf, oh yes that will make smuxi-server on raspberry pi
awesome :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033413] Review Request: smuxi - An user-friendly IRC client based on GNOME/GTK+

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033413



--- Comment #6 from Christopher Meng cicku...@gmail.com ---
(In reply to Mirco Bauer from comment #5)
 I understand, but I didn't mean to disable JabbR always, only if the Mono
 version is too old. Which Mono version is in fedora currently? Maybe I can
 supply a patch that allows to build it on that version then...
 
 With Mono 3.2 on armhf, oh yes that will make smuxi-server on raspberry pi
 awesome :-)

You can search mono-devel in http://pkgs.org to get the information. This
website is very helpful for comparing pkg version in different distros.

Very old now:

[rpmaker@fab dev]$ rpm -qa |grep mono-devel
mono-devel-2.10.8-5.fc20.i686

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033413] Review Request: smuxi - An user-friendly IRC client based on GNOME/GTK+

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033413

Mirco Bauer mmmba...@gnome.org changed:

   What|Removed |Added

 CC|mmmba...@gnome.org  |
 CC||mmmba...@gnome.org



--- Comment #7 from Mirco Bauer mmmba...@gnome.org ---
I am not aware of any build issues with Smuxi 0.9 on Mono 2.10.8, that is what
Debian Stable and Testing contains and successfully compiled Smuxi 0.9. So do
you have a compile issue? (because of your comment it needs a newer version to
compile)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821406] Review Request: eiskaltdcpp - QT Direct Connect client

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=821406



--- Comment #22 from Ivan Romanov dr...@land.ru ---
Sources use various licenses (BSD, GPLv2+ and GPLv3+). You must clarify this in
spec.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario

Also EiskaltDC++ uses bunlded miniupnpc and jsoncpp.
These packages allready is in Fedora. You must explicity remove them in %prep
stage
https://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries#Packages_with_Bundled_Libraries
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033413] Review Request: smuxi - An user-friendly IRC client based on GNOME/GTK+

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033413



--- Comment #8 from Christopher Meng cicku...@gmail.com ---
Just had the dinner.

Well build is aborted:

+ ./configure --build=i686-redhat-linux-gnu --host=i686-redhat-linux-gnu
--program-prefix= --disable-dependency-tracking --prefix=/usr
--exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc
--datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib
--libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib
--mandir=/usr/share/man --infodir=/usr/share/info --enable-frontend-stfl
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether UID '1000' is supported by ustar format... yes
checking whether GID '1000' is supported by ustar format... yes
checking how to create a ustar tar archive... gnutar
checking whether to enable maintainer-specific portions of Makefiles... no
checking for pkg-config... /usr/bin/pkg-config
checking build system type... i686-redhat-linux-gnu
checking host system type... i686-redhat-linux-gnu
checking how to print strings... printf
checking for style of include used by make... GNU
checking for i686-redhat-linux-gnu-gcc... no
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... none
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands +=... yes
checking how to convert i686-redhat-linux-gnu file names to
i686-redhat-linux-gnu format... func_convert_file_noop
checking how to convert i686-redhat-linux-gnu file names to toolchain format...
func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for i686-redhat-linux-gnu-objdump... no
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for i686-redhat-linux-gnu-dlltool... no
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for i686-redhat-linux-gnu-ar... no
checking for ar... ar
checking for archiver @FILE support... @
checking for i686-redhat-linux-gnu-strip... no
checking for strip... strip
checking for i686-redhat-linux-gnu-ranlib... no
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for i686-redhat-linux-gnu-mt... no
checking for mt... no
checking if : is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... no
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking whether NLS is requested... yes
checking for intltool = 0.25... 0.50.2 found
checking for intltool-update... /usr/bin/intltool-update
checking for intltool-merge... /usr/bin/intltool-merge
checking for intltool-extract... /usr/bin/intltool-extract
checking 

[Bug 1033413] Review Request: smuxi - An user-friendly IRC client based on GNOME/GTK+

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033413



--- Comment #9 from Christopher Meng cicku...@gmail.com ---
Ignore the last comment.

If I set build without jabbr support, the build process is perfect.

So I just need a 4.0 compiler now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033848] Review Request: greenisland - Compositor and shell for the Hawaii desktop environment

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033848

Marek Mahut mma...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mma...@redhat.com
   Assignee|nob...@fedoraproject.org|mma...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905240] Review Request: rubygem-log4r - Comprehensive and flexible logging library for ruby

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=905240



--- Comment #7 from Michael Scherer m...@zarb.org ---
New activity on this bug ?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033413] Review Request: smuxi - An user-friendly IRC client based on GNOME/GTK+

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033413



--- Comment #10 from Mirco Bauer mmmba...@gnome.org ---
You can override the compiler with: ./configure MCS=/usr/bin/dmcs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033848] Review Request: greenisland - Compositor and shell for the Hawaii desktop environment

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033848



--- Comment #1 from Marek Mahut mma...@redhat.com ---
Scratch build evaluted
http://koji.fedoraproject.org/koji/taskinfo?taskID=6219031

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970896] Review Request: sugar-paths - A sliding tile game to create closed paths

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=970896



--- Comment #16 from Danishka Navin danis...@gmail.com ---
SPEC file: http://snavin.fedorapeople.org/packages/sugar-paths/sugar-paths.spec

SRPM file:
http://snavin.fedorapeople.org/packages/sugar-paths/sugar-paths-19-3.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033848] Review Request: greenisland - Compositor and shell for the Hawaii desktop environment

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033848

Marek Mahut mma...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Marek Mahut mma...@redhat.com ---
This package looks sane, thank you for your review request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 894482] Review Request: rubygem-openshift-origin-auth-kerberos - OpenShift plugin for kerberos auth service

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=894482

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

  Flags|needinfo?(m...@zarb.org)|



--- Comment #21 from Michael Scherer m...@zarb.org ---
A few issue to fix, once they are fixed, i will approve the package.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly. This part couldn't be tested because
of a bug in openshift-broker rpm, see #1033928
- mocha is not really used or needed, so it should be dropped from Requires
- same goes for json, not used anywhere in the code, should be dropped in
gemspec
and Requires 

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
[x]: Package contains Requires: ruby(release).

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary 

[Bug 1033848] Review Request: greenisland - Compositor and shell for the Hawaii desktop environment

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033848

Lubomir Rintel lkund...@v3.sk changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #3 from Lubomir Rintel lkund...@v3.sk ---
Thank you Marek!

New Package SCM Request
===
Package Name: greenisland
Short Description: Compositor and shell for the Hawaii desktop environment
Owners: lkundrak cicku plfiorini
Branches: f18 f19 f20 el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 894482] Review Request: rubygem-openshift-origin-auth-kerberos - OpenShift plugin for kerberos auth service

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=894482



--- Comment #22 from Michael Scherer m...@zarb.org ---
See https://github.com/openshift/origin-server/pull/4242 also, not sure if we
want to keep in sync the spec file, and how

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 564537] Review Request: grc - simple python logfile colouriser

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=564537



--- Comment #10 from Terje Røsten terje...@phys.ntnu.no ---
Hi Carl,

still interest in this package? 

There is 1.5 release available upstream.

Are you sponsored?

@Buland,
are you going to start the review any time soon?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 981707] Review Request: bmon - bandwidth monitor and rate estimator

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=981707



--- Comment #13 from Terje Røsten terje...@phys.ntnu.no ---
Thomas,

can you please push bmon to stable?

Or any reason to keep it in testing for many weeks?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 761063] Review Request: cover_grabber - Download album cover art

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=761063



--- Comment #13 from Terje Røsten terje...@phys.ntnu.no ---
Still any interest or should this request be closed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 766932] Review Request: icfg - utiltiy for scriptable editing of network interface files

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=766932

Terje Røsten terje...@phys.ntnu.no changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2013-11-24 08:43:00



--- Comment #22 from Terje Røsten terje...@phys.ntnu.no ---
Package seems to imported and available in repos, closing ticket.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970896] Review Request: sugar-paths - A sliding tile game to create closed paths

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=970896



--- Comment #17 from Christopher Meng cicku...@gmail.com ---
[!]: Final provides and requires are sane.

[rpmaker@fab Paths-19]$ grep env * -R
genpieces.py:#!/usr/bin/env python
path.py:#!/usr/bin/env python


[?]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/locale/quz,
 /usr/share/locale/mvo/LC_MESSAGES, /usr/share/locale/tzm/LC_MESSAGES,
 /usr/share/locale/ayc/LC_MESSAGES, /usr/share/locale/fa_AF,
 /usr/share/locale/hus, /usr/share/locale/quz/LC_MESSAGES,
 /usr/share/locale/tzo, /usr/share/locale/tzm,
 /usr/share/locale/fa_AF/LC_MESSAGES, /usr/share/locale/hus/LC_MESSAGES,
 /usr/share/locale/ayc, /usr/share/locale/tzo/LC_MESSAGES,
 /usr/share/locale/mvo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 997679] Rename Request: sfml - Simple and Fast Multimedia Library

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=997679



--- Comment #39 from Michael Schwendt bugs.mich...@gmx.net ---
If there's still interest in moving forward with this rename request, the
remaining item from comment 31 and comment 23 is to present an updated spec and
src.rpm for review based on the latest
http://pkgs.fedoraproject.org/cgit/SFML.git/tree/ with proper
Obsoletes/Provides pairs - possibly considering bug 1033924 (SFML 2.1 upgrade
request).

This is the only hurdle left for the renaming. ;)

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 977128] Review Request: nodejs-grunt - The JavaScript Task Runner

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=977128

Thomas Spura toms...@fedoraproject.org changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org



--- Comment #8 from Thomas Spura toms...@fedoraproject.org ---
It seems this package is reviewed. Could it please added to the repositories
too? :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #9 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build fails:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6219513

It is due to an unresolvable dependency in Rawhide:
DEBUG util.py:266:  Error: Package: kyua-cli-0.5-3.fc19.i686 (build)
DEBUG util.py:266: Requires: liblutok.so.0

New attempt for f20:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6219521

Same dependency problem there. The current lutok-0.3 package has liblutok.so.2,
the mentioned liblutok.so.0 is in the f19 package only. Seems to be a problem
in kyua-cli, which pulls lutok. It has to be resolved before we can continue on
this review. There are still f19 packages for kyua-cli in Rawhide, so I assume
it has build problems.

And last but not least an issue from build.log:
»warning: bogus date in %changelog: Mon Feb 19 2013 Julio Merino
ju...@meroh.net 0.1-1«

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 518317] Review Request: perdition - Mail Retrieval Proxy

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=518317



--- Comment #37 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 
---
Ok, let it be
Changes:
https://github.com/Hubbitus/Fedora-packaging/commit/d107557be9dd7ff14936e9946ce7563d2d12340e
Spec:
https://raw.github.com/Hubbitus/Fedora-packaging/d107557be9dd7ff14936e9946ce7563d2d12340e/SPECS/perdition.spec
Srpm: http://hubbitus.info/rpm/Fedora20/perdition/perdition-2.0-4.fc20.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6219551

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1027187] Review Request: rubygem-coercible - Powerful, flexible and configurable coercion library

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1027187

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #7 from Mario Blättermann mario.blaetterm...@gmail.com ---
Rubygem-backports has been build for f20 and imported in Bodhi:
https://admin.fedoraproject.org/updates/FEDORA-2013-21697/rubygem-backports-3.3.4-1.fc20
So I assume we can set the ON_QA status for this ticket now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #10 from Julio Merino julio+red...@meroh.net ---
So the issue with kyua-cli is that somebody attempted to upgrade it to 0.6,
committed the results, but I guess didn't even try to build the package. 
kyua-cli-0.6 requires kyua-testers, so no new versions can be built against the
right version of liblutok at the moment.

Question: Is it an OK procedure if I revert the bogus update of kyua-cli to 0.5
and rebuild a working version?  Because no binaries have been built for 0.6
yet, I suppose this is fine.  Alternatively I'd tweak the initial addition of
kyua-testers to not require kyua-cli.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 954074] Review Request: RemoteBox - Open Source VirtualBox Client with Remote Management

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=954074

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|RemoteBox-1.6-2.fc20|RemoteBox-1.1-1.el6



--- Comment #25 from Fedora Update System upda...@fedoraproject.org ---
RemoteBox-1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #11 from Mario Blättermann mario.blaetterm...@gmail.com ---
Don't understand completely. The kyua-testers package is needed for updating
kyua to 0.6, but we require kyua-cli. This is an unresolvable ping-pong
dependency, as far as I can evaluate. As you see in the scratch builds, they
fail already with kyua-cli-0.5. I'm a bit confused about this situation.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033961] New: Review Request: powerline - The ultimate statusline/prompt utility

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033961

Bug ID: 1033961
   Summary: Review Request: powerline - The ultimate
statusline/prompt utility
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: a...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://xor.cryptomilk.org/rpm/powerline/powerline.spec
SRPM URL:
http://xor.cryptomilk.org/rpm/powerline/powerline-0.0.1.20131123gitdb80fc-1.fc19.src.rpm

Description: Powerline is a statusline plugin for vim, and provides statuslines
and prompts for several other applications, including zsh, bash, tmux, IPython,
Awesome and Qtile.

https://github.com/Lokaltog/powerline

Fedora Account System Username: asn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1031342] Review Request: xorg-x11-drv-freedreno - xorg ddx driver for snapdragon/adreno arm SoC's

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031342

Hans de Goede hdego...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|hdego...@redhat.com



--- Comment #20 from Hans de Goede hdego...@redhat.com ---
Hi,

(In reply to Xavier Bachelot from comment #19)
 I know the perfect reviewer for this package. Hans, I hope you don't mind me
 dropping some (more) work on your shoulders ;-)

Ok, I'll bite, I'm now yum distro-syncing my trimslice to F-20, when that is
done I'll review this (likely tomorrow).

Regards,

Hans

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #12 from Julio Merino julio+red...@meroh.net ---
kyua-testers _only_ needs kyua-cli because of the %check target in the spec
file.  Getting rid of that would also let us kill the BuildRequires stanza on
kyua-cli and not introduce any cycles.  But doing so means we lose the
execution of the tests for kyua-testers during the build of a package; not a
huge deal given that these can be run later via the -tests subpackage.

The reason I sent it this way is because I thought that this could be OK as
long as at least one build for kyua-cli existed in the tree.  (This build could
exist with kyua-cli-0.5 if fixed.) 

What do you suggest?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #13 from Mario Blättermann mario.blaetterm...@gmail.com ---
I suggest to disable the %check section for the time being so that I can do a
proper scratch build and approve your package, unless some other blocker issues
come up. This way we get the package at least into Rawhide and you might
re-enable the tests once kyua-cli has the right version. Well, we would have a
ping-pong-scenario similar to that one I already mentioned, but it would work
as long as both packages are available from the repos. Currently, with one repo
package and one which has to be scratch-built it wouldn't work. Is this
imagineable for you to do so?

BTW, instead of disabling the checks you could add a condition which makes it
more simple to switch them on and off:

%global with_checks 1

Then, in the %check section itself, you use the if/then constructs to
enable/disable it.

Moreover, you are using the %define macro. In most cases, %global is the better
choice. See
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033961] Review Request: powerline - The ultimate statusline/prompt utility

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033961

Simo Sorce sso...@redhat.com changed:

   What|Removed |Added

 CC||sso...@redhat.com



--- Comment #1 from Simo Sorce sso...@redhat.com ---
rpmlint complaints
| powerline.src: W: spelling-error %description -l en_US zsh - sh, ssh, ash
| powerline.src: W: invalid-url Source0:
powerline-0.0.1.20131123gitdb80fc.tar.gz
| 1 packages and 0 specfiles checked; 0 errors, 2 warnings.

1 is obviously bogus
however 2 indicates some errors:
- Source0 is supposed to be the URL where to find the package, I suppose the
git tree when it is a checkout ?
- you should use %{checkout} in Version and set Checkout: 20131123gitdb80fc,
  see
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033961] Review Request: powerline - The ultimate statusline/prompt utility

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033961



--- Comment #2 from Andreas Schneider a...@redhat.com ---
* Sun Nov 24 2013 - Andreas Schneider a...@redhat.com -
0.0.1.20131123gitdb80fc-2
- Set checkout.
- Set source url
- Fix default configuration path.


The spelling error is no error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033967] New: Review Request: SchellCheck - Tool for checking common errors in shell scripts

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033967

Bug ID: 1033967
   Summary: Review Request: SchellCheck - Tool for checking common
errors in shell scripts
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: dridi.boukelmo...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://bitbucket.org/dridi/fedora_packages/downloads/ShellCheck.spec
SRPM URL:
https://bitbucket.org/dridi/fedora_packages/downloads/ShellCheck-0.2.0-1.fc19.src.rpm
Description:
The goals of ShellCheck are:

  - To point out and clarify typical beginner's syntax issues,
that causes a shell to give cryptic error messages.

  - To point out and clarify typical intermediate level semantic problems,
that causes a shell to behave strangely and counter-intuitively.

  - To point out subtle caveats, corner cases and pitfalls, that may cause an
advanced user's otherwise working script to fail under future
circumstances.

Fedora Account System Username: dridi

Successful builds from f18 to f21:
https://koji.fedoraproject.org/koji/taskinfo?taskID=6220156
https://koji.fedoraproject.org/koji/taskinfo?taskID=6220140
https://koji.fedoraproject.org/koji/taskinfo?taskID=6220101
https://koji.fedoraproject.org/koji/taskinfo?taskID=6220047

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033967] Review Request: SchellCheck - Tool for checking common errors in shell scripts

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033967

Dridi Boukelmoune dridi.boukelmo...@gmail.com changed:

   What|Removed |Added

  Alias||SchellCheck



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033961] Review Request: powerline - The ultimate statusline/prompt utility

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033961

Michele Baldessari mich...@acksyn.org changed:

   What|Removed |Added

 CC||mich...@acksyn.org



--- Comment #3 from Michele Baldessari mich...@acksyn.org ---
Thanks for this package ;)

Just a drive-by comment as a happy powerline user. You need to add
python2-devel or python3-devel in the BuildRequires:
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033961] Review Request: powerline - The ultimate statusline/prompt utility

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033961



--- Comment #4 from Andreas Schneider a...@redhat.com ---
I don't see why python-devel is needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033961] Review Request: powerline - The ultimate statusline/prompt utility

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033961



--- Comment #5 from Jakub Hrozek jhro...@redhat.com ---
Here is a koji build with latest Andreas' package:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6220268

The only thing in the specfile that might need changing is that subpackages
(vim-plugin-powerline and tmux-powerline) should require the main package with
full NVR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033961] Review Request: powerline - The ultimate statusline/prompt utility

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033961



--- Comment #6 from Jakub Hrozek jhro...@redhat.com ---
python-devel is not needed, powerline is written entirely in Python,
python-devel is normally needed for python bindings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy-player - An open-source Gnome media player

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640



--- Comment #21 from Fedora Update System upda...@fedoraproject.org ---
snappy-player-0.3.7-2.20131121git0bd0c0c3.fc20 has been submitted as an update
for Fedora 20.
https://admin.fedoraproject.org/updates/snappy-player-0.3.7-2.20131121git0bd0c0c3.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy-player - An open-source Gnome media player

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640



--- Comment #22 from Fedora Update System upda...@fedoraproject.org ---
snappy-player-0.3.7-2.20131121git0bd0c0c3.fc19 has been submitted as an update
for Fedora 19.
https://admin.fedoraproject.org/updates/snappy-player-0.3.7-2.20131121git0bd0c0c3.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026376

Thomas Spura toms...@fedoraproject.org changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org
 Blocks||1006575




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1006575
[Bug 1006575] ipython: please package new upstream version (1.1)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033961] Review Request: powerline - The ultimate statusline/prompt utility

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033961



--- Comment #7 from Michele Baldessari mich...@acksyn.org ---
Well I guess the Python guidelines need an update or fedora-review needs fixing 
then

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033970] New: Review Request: d52 - Disassemblers for 8051, 8048, and Z80 families

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033970

Bug ID: 1033970
   Summary: Review Request: d52 - Disassemblers for 8051, 8048,
and Z80 families
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: space...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://fedorapeople.org/~brouhaha/d52/d52.spec
SRPM URL: http://fedorapeople.org/~brouhaha/d52/d52-3.4.1-1.fc19.src.rpm
Description: D52 is collection of disassemblers for the 8051, 8048, and Z80
families of microcontrollers and microprocessors.
Fedora Account System Username: brouhaha

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033975] New: Review Request: python-enum34 - Backport of Python 3.4 Enum

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033975

Bug ID: 1033975
   Summary: Review Request: python-enum34 - Backport of Python 3.4
Enum
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: space...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://fedorapeople.org/~brouhaha/python-enum34/python-enum34.spec
SRPM URL:
http://fedorapeople.org/~brouhaha/python-enum34/python-enum34-0.9.19-1.fc19.src.rpm
Description: Python 3.4 introduced official support for enumerations.  This is
a
backport of that feature to Python 3.3, 3.2, 3.1, 2.7, 2.5, 2.5, and 2.4.
Fedora Account System Username: brouhaha

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970418] Review Request: mingw-flac - Free Lossless Audio Codec Library

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=970418

František Dvořák val...@civ.zcu.cz changed:

   What|Removed |Added

 CC||val...@civ.zcu.cz



--- Comment #1 from František Dvořák val...@civ.zcu.cz ---
Hello,

my observations of the packaging:

1) there were many changes in native package (source URL, descriptions, new
version - currently 1.3.0, patches, build flags, ...).

MinGW packages should follow the native packages as closely as possible. With
the new version and different patches, it will probably need a lot changes...

2) I guess the macros mingw_build_win32 and mingw_build_win64 are not needed?

3) having just two static subpackages mingw32-flac-static and
mingw64-flac-static would simplify the packaging (= merging C and C++ static
subpackages), but that's mere suggestion

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 957529] Review Request: solaar - Device manager for Logitech Unifying Receiver

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=957529



--- Comment #18 from Fedora Update System upda...@fedoraproject.org ---
solaar-0.9.2-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/solaar-0.9.2-2.el6

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015765



--- Comment #16 from Mosaab Alzoubi moc...@hotmail.com ---
Yes, This program (OTHMAN) needs islamic-menus:

http://rpmfind.net/linux/RPM/sourceforge/o/oj/oji/repo/othman-0.2.7-1.oj5.noarch.html
http://rpmfind.net/linux/RPM/sourceforge/o/oj/oji/repo/python-othman-0.2.7-1.oj5.noarch.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1001028] Review Request: python-bna - Battle.net Authenticator routines in Python

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1001028

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|python-bna-3.2-2.fc20   |python-bna-3.2-2.fc19



--- Comment #16 from Fedora Update System upda...@fedoraproject.org ---
python-bna-3.2-2.fc19 has been pushed to the Fedora 19 stable repository.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033967] Review Request: SchellCheck - Tool for checking common errors in shell scripts

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033967

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cicku...@gmail.com
   Assignee|nob...@fedoraproject.org|cicku...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033986] New: Review Request: perl-Lingua-EN-Syllable - Routine for estimating syllable count in words

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033986

Bug ID: 1033986
   Summary: Review Request: perl-Lingua-EN-Syllable - Routine for
estimating syllable count in words
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: r.landm...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://rlandmann.fedorapeople.org/packages/perl-Lingua-EN-Syllable.spec
SRPM URL:
http://rlandmann.fedorapeople.org/packages/perl-Lingua-EN-Syllable-0.251-1.fc19.src.rpm
Description: Lingua::EN::Syllable::syllable() estimates the number of syllables
in the word passed to it.
Fedora Account System Username: rlandmann

rpmlint output:

$ rpmlint SPECS/perl-Lingua-EN-Syllable.spec
SRPMS/perl-Lingua-EN-Syllable-0.251-1.fc19.src.rpm
RPMS/noarch/perl-Lingua-EN-Syllable-0.251-1.fc19.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Koji scratchbuild:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6220559

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033987] New: Review Request: perl-Lingua-EN-Fathom - Measure readability of English text

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033987

Bug ID: 1033987
   Summary: Review Request: perl-Lingua-EN-Fathom - Measure
readability of English text
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: r.landm...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://rlandmann.fedorapeople.org/packages/perl-Lingua-EN-Fathom.spec
SRPM URL:
http://rlandmann.fedorapeople.org/packages/perl-Lingua-EN-Fathom-1.15-1.fc19.src.rpm
Description: This module analyses English text in either a string or file.
Totals are then calculated for the number of characters, words, sentences,
blank and non blank (text) lines and paragraphs.
Fedora Account System Username: rlandmann

rpmlint output:

$ rpmlint SPECS/perl-Lingua-EN-Fathom.spec
SRPMS/perl-Lingua-EN-Fathom-1.15-1.fc19.src.rpm
RPMS/noarch/perl-Lingua-EN-Fathom-1.15-1.fc19.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033987] Review Request: perl-Lingua-EN-Fathom - Measure readability of English text

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033987

Ruediger Landmann r.landm...@redhat.com changed:

   What|Removed |Added

 Depends On||1033986
 Whiteboard||NotReady




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1033986
[Bug 1033986] Review Request: perl-Lingua-EN-Syllable - Routine for
estimating syllable count in words
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033986] Review Request: perl-Lingua-EN-Syllable - Routine for estimating syllable count in words

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033986

Ruediger Landmann r.landm...@redhat.com changed:

   What|Removed |Added

 Blocks||1033987




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1033987
[Bug 1033987] Review Request: perl-Lingua-EN-Fathom - Measure readability
of English text
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 991689] Review Request: dislocker - Utility to access BitLocker encrypted volumes

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=991689

Robert Scheck redhat-bugzi...@linuxnetz.de changed:

   What|Removed |Added

 Depends On||1033989




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1033989
[Bug 1033989] Please build polarssl for EPEL 5
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 991689] Review Request: dislocker - Utility to access BitLocker encrypted volumes

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=991689

Robert Scheck redhat-bugzi...@linuxnetz.de changed:

   What|Removed |Added

  Flags|needinfo?(redhat-bugzilla@l |
   |inuxnetz.de)|



--- Comment #7 from Robert Scheck redhat-bugzi...@linuxnetz.de ---
Regarding the build issue on Rawhide: Since the initial review submission the
newer PolarSSL 1.3 (including API changes) entered Fedora, however this is now
fixed (to support both). The building for EL-5 is fixed as well, however there
is no polarssl package for EL-5 so far; I filed bug #1033989 for that.

Spec URL: http://labs.linuxnetz.de/bugzilla/dislocker.spec
SRPM URL:
http://labs.linuxnetz.de/bugzilla/dislocker-0.2.3-2.20130131git.src.rpm

I guess the missing EL-5 dependency is not a real show stopper for the overall
review so far?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 991689] Review Request: dislocker - Utility to access BitLocker encrypted volumes

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=991689



--- Comment #8 from Christopher Meng cicku...@gmail.com ---
No. 

The blocker is that you must package the latest stable 0.3 OR checkout from git
again. 

https://github.com/Aorimn/dislocker/releases

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #14 from Julio Merino julio+red...@meroh.net ---
Alright, so:

- Changed %define with %global.
- Added a %_with_checks global, defaulting to 0 for now.
- Updated the changelog entry, which apparently also fixes the date.

Because of the new %_with_checks, it is not worth attempting to fix the current
kyua-cli package.  It's just easier and better to finish this package and
properly update kyua-cli to 0.7 which should just work.

New URLs (because of the SRPM name change):

Spec URL: http://www.NetBSD.org/~jmmv/kyua-testers.spec
SRPM URL: http://www.NetBSD.org/~jmmv/kyua-testers-0.1-1.fc20.src.rpm

Thanks!

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 991689] Review Request: dislocker - Utility to access BitLocker encrypted volumes

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=991689



--- Comment #9 from Robert Scheck redhat-bugzi...@linuxnetz.de ---
Right, so here we go with an updated package. And I obviously did not yet
run extensive tests with this new dislocker like it happened with 0.2.3 for
6+ months now. But my daily future usage will of course be done using this
updated package:

Spec URL: http://labs.linuxnetz.de/bugzilla/dislocker.spec
SRPM URL:
http://labs.linuxnetz.de/bugzilla/dislocker-0.3.1-1.20131102git.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819687] Review Request: python-rtkit - Python Api for Request Tracker's REST interface

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819687



--- Comment #28 from Tomas Dabašinskas tdaba...@redhat.com ---
Hi Christopher, many thanks for the review and catching the %check  I'm not in
dire need to get the package out, but I agree let's get this package out and
start working on packaging %check deps.

I haven't bumped the spec version, just extended last rev message, the updated
rpm:

Spec URL:
http://people.fedoraproject.org/~tdabasin/python-rtkit/python-rtkit.spec
SRPM URL:
http://people.fedoraproject.org/~tdabasin/python-rtkit/python-rtkit-0.6.0-1.fc19.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025012] Review Request: libetonyek - a library for import of Apple Keynote presentations

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025012

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

   Assignee|dtar...@redhat.com  |mario.blaetterm...@gmail.co
   ||m



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1020456] Review Request: vagrant - an automation tool used to manage development environments

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020456

Stephen Gordon sgor...@redhat.com changed:

   What|Removed |Added

 CC||sgor...@redhat.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1020456] Review Request: vagrant - an automation tool used to manage development environments

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020456

Stephen Gordon sgor...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |



--- Comment #6 from Stephen Gordon sgor...@redhat.com ---
I've removed the review flag and set a block on the FE-NEEDSPONSOR bug as the
specified FAS user 'adrahon' does not appear to be in the 'packager' group.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1020456] Review Request: vagrant - an automation tool used to manage development environments

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020456

Stephen Gordon sgor...@redhat.com changed:

   What|Removed |Added

   Assignee|saga...@gmail.com   |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 518317] Review Request: perdition - Mail Retrieval Proxy

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=518317

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #38 from Christopher Meng cicku...@gmail.com ---
A belated approval.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033986] Review Request: perl-Lingua-EN-Syllable - Routine for estimating syllable count in words

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033986

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cicku...@gmail.com
   Assignee|nob...@fedoraproject.org|cicku...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Christopher Meng cicku...@gmail.com ---
Question before review, do you want to support EL5?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033986] Review Request: perl-Lingua-EN-Syllable - Routine for estimating syllable count in words

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033986



--- Comment #2 from Ruediger Landmann r.landm...@redhat.com ---
Yeah, I'd like to make this available for EPEL5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015765



--- Comment #17 from Christopher Meng cicku...@gmail.com ---
http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033961] Review Request: powerline - The ultimate statusline/prompt utility

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033961



--- Comment #8 from Christopher Meng cicku...@gmail.com ---
1. Please sort your spec for readability:

Move:

BuildRequires:  python-setuptools python-sphinx fdupes fontconfig tmux
vim-minimal
BuildArch: noarch

after

Url:https://github.com/Lokaltog/powerline

2. 
%define checkout 20131123gitdb80fc

--


%global checkout 20131123gitdb80fc

And ask upstream to tag the project.

3. %build

Add a note like 

#nothing to build.

4. install with -p option to preserve the timestamp.

5. %fdupes %{buildroot}%{python_sitelib}

What's this crap?

6. Just one line in %files:

%{_datadir}/%{name}

No need to 

%dir %{_datadir}/%{name}
%{_datadir}/%{name}/fontpatcher-symbols.sfd

7. python setup.py install --prefix=%{_prefix} --root=%{buildroot} --optimize=1

Use:

%{__python2} setup.py install --prefix=%{_prefix} --root=%{buildroot}
--optimize=1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033986] Review Request: perl-Lingua-EN-Syllable - Routine for estimating syllable count in words

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033986



--- Comment #3 from Christopher Meng cicku...@gmail.com ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 Unknown or generated. 2 files have unknown license. Detailed output of
 licensecheck:


Unknown or generated

/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/Lingua-EN-Syllable-0.251/Syllable.pm
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/Lingua-EN-Syllable-0.251/test.pl


[x]: If the package is under multiple licenses, the licensing breakdown must
 be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/perl5/vendor_perl/Lingua(perl-Lingua-Preferred, perl-Lingua-
 Stem-Ru, perl-Lingua-Identify, perl-Lingua-Stem-It, perl-Lingua-EN-
 Inflect, perl-Lingua-EN-Numbers-Ordinate, perl-Snowball-Norwegian, perl-
 Snowball-Swedish, perl-Lingua-EN-Inflect-Phrase, perl-Lingua-Stem-Fr,
 perl-Lingua-EN-Numbers-Easy, perl-Lingua-EN-Alphabet-Shaw, perl-Lingua-
 Flags, perl-Lingua-Stem, perl-Lingua-PT-Stemmer, perl-Lingua-StopWords,
 perl-Lingua-Stem-Snowball-Da, perl-Lingua-EN-Numbers),
 /usr/share/perl5/vendor_perl/Lingua/EN(perl-Lingua-EN-Inflect, perl-
 Lingua-EN-Numbers-Ordinate, perl-Lingua-EN-Numbers, perl-Lingua-EN-
 Alphabet-Shaw, perl-Lingua-EN-Inflect-Phrase, perl-Lingua-EN-Numbers-
 Easy)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm  4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

= SHOULD items =

Generic:
[x]: Buildroot is not present
 Note: Buildroot: present but not needed
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: %clean present but not required
[x]: If the source package does not 

[Bug 564537] Review Request: grc - simple python logfile colouriser

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=564537

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||cicku...@gmail.com



--- Comment #11 from Christopher Meng cicku...@gmail.com ---
WARNING!

https://admin.fedoraproject.org/pkgdb/acls/name/grc

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1034017] Review Request: perl-Test-Name-FromLine - Auto fill test names from caller line

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1034017

Mathieu Bridon boche...@fedoraproject.org changed:

   What|Removed |Added

 Blocks||1033481




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1033481
[Bug 1033481] Review Request: perl-Test-Time - Overrides the time() and
sleep() core functions for testing
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033481] Review Request: perl-Test-Time - Overrides the time() and sleep() core functions for testing

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033481

Mathieu Bridon boche...@fedoraproject.org changed:

   What|Removed |Added

 Depends On||1034017




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1034017
[Bug 1034017] Review Request: perl-Test-Name-FromLine - Auto fill test
names from caller line
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1034017] New: Review Request: perl-Test-Name-FromLine - Auto fill test names from caller line

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1034017

Bug ID: 1034017
   Summary: Review Request: perl-Test-Name-FromLine - Auto fill
test names from caller line
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: boche...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://bochecha.fedorapeople.org/packages/perl-Test-Name-FromLine.spec
SRPM URL:
http://bochecha.fedorapeople.org/packages/perl-Test-Name-FromLine-0.11-1.fc20.src.rpm

Description:
Test::Name::FromLine is test utility that fills test names from its file.
Just use this module in test and this module fill test names to all test
except named one.

Fedora Account System Username: bochecha

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033481] Review Request: perl-Test-Time - Overrides the time() and sleep() core functions for testing

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033481



--- Comment #2 from Mathieu Bridon boche...@fedoraproject.org ---
Thanks for the feedback Petr.

I've opened a new review request for Test::Name::FromLine.

And here's a new package with the fixes. :)

Spec URL: http://bochecha.fedorapeople.org/packages/perl-Test-Time.spec
SRPM URL:
http://bochecha.fedorapeople.org/packages/perl-Test-Time-0.04-2.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033967] Review Request: SchellCheck - Tool for checking common errors in shell scripts

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033967

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|cicku...@gmail.com  |nob...@fedoraproject.org
  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1027512] Review Request: rubygem-tiltout - Tilt templates with layouts and helpers

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1027512

Mamoru TASAKA mtas...@fedoraproject.org changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Mamoru TASAKA mtas...@fedoraproject.org ---
Okay, no issue found.

* Builds successfully on koji.
* Spec file clean
* Can be installed
* At least the following works:

$ ruby -e require 'tiltout' ; puts Tiltout::VERSION
1.4.0

-
  This package (rubygem-tiltout) is APPROVED by mtasaka
-

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033961] Review Request: powerline - The ultimate statusline/prompt utility

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033961



--- Comment #9 from Andreas Schneider a...@redhat.com ---
Thanks for your comment.

1. Moved BuildArch, prefer BuildRequires on top!
2. done
3. done
4. -a now
5. no crap (man fdupes)
6. wont change, I prefer two or more
7. done

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018090] Review Request: python-argcomplete - Bash tab completion for argparse

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018090

Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2013-11-25 02:47:30



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018092] Review Request: barman - Backup and Recovery Manager for PostgreSQL

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018092

Bug 1018092 depends on bug 1018090, which changed state.

Bug 1018090 Summary: Review Request: python-argcomplete - Bash tab completion 
for argparse
https://bugzilla.redhat.com/show_bug.cgi?id=1018090

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 991689] Review Request: dislocker - Utility to access BitLocker encrypted volumes

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=991689

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|cicku...@gmail.com
  Flags||fedora-review?



--- Comment #10 from Christopher Meng cicku...@gmail.com ---
1. You can use tarball downloaded from tag and don't need to write down git in
the release tag.

2. https://github.com/Aorimn/dislocker#readme

just https://github.com/Aorimn/dislocker will be fine.

I will review it formally later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review