[Bug 1204176] Review Request: perl-Authen-SCRAM - Salted Challenge Response Authentication Mechanism (RFC 5802)
https://bugzilla.redhat.com/show_bug.cgi?id=1204176 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Authen-SCRAM-0.005-1.f ||c23 Resolution|--- |RAWHIDE Last Closed||2015-03-27 03:33:17 --- Comment #4 from Petr Pisar ppi...@redhat.com --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library
https://bugzilla.redhat.com/show_bug.cgi?id=1206086
Chandan Kumar chku...@redhat.com changed:
What|Removed |Added
CC||chku...@redhat.com
--- Comment #1 from Chandan Kumar chku...@redhat.com ---
This is un-official review of the package.
Suggestions:
[1.] Group tag is optional in Fedora and is only needed if you want this
package to be built for EPEL5. See
http://fedoraproject.org/wiki/EPEL:Packaging#Group_tag. You can remove Group
tag from both package and sub-package.
[2.] Change the URL from launchpad to pypi,
URL: https://pypi.python.org/pypi/oslo.versionedobjects
[3.] Use %{version} tag in Source0
Source0:
https://pypi.python.org/packages/source/o/%{sname}/%{sname}-%{version}.tar.gz
[4.] Move doc building steps from %install section to %build section
export PYTHONPATH=$( pwd ):$PYTHONPATH
pushd doc
sphinx-build -b html -d build/doctrees source build/html
popd
# Fix hidden-file-or-dir warnings
rm -fr doc/build/html/.buildinfo
[5.] Mock build is failing and giving:
Extension error:
Could not import extension oslosphinx (exception: No module named oslosphinx)
To fix this:
Add this line in %prep section:
# make doc build compatible with python-oslo-sphinx RPM
sed -i 's/oslosphinx/oslo.sphinx/' doc/source/conf.py
[6.] in %files section, please include other files also present in the python
package tarball.
%doc AUTHORS CONTRIBUTING.rst README.rst PKG-INFO ChangeLog
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202431] Review Request: libical-glib - GObject wrapper for libical library
https://bugzilla.redhat.com/show_bug.cgi?id=1202431 --- Comment #9 from Milan Crha mc...@redhat.com --- Thanks. There seems to fail something, I imported my spec file into the git, then sources, then tried to build it for the rawhide [1] and this is the failure output I've got: 9344173 buildArch (libical-glib-1.0.2-1.fc23.src.rpm, armv7hl): open (arm04-builder11.arm.fedoraproject.org) - closed 0 free 1 open 4 done 0 failed 9344126 build (rawhide, /libical-glib:c11ca5f9a29913e7e0904b7773a6755071cc5d80): open (arm04-builder21.arm.fedoraproject.org) - FAILED: BuildError: mismatch when analyzing libical-glib-doc-1.0.2-1.fc23.noarch.rpm, rpmdiff output was: error: cannot open Packages index using db5 - Permission denied (13) error: cannot open Packages database in /var/lib/rpm error: cannot open Packages database in /var/lib/rpm removed REQUIRES libical-glib(armv7hl-32) = 1.0.2-1.fc23 added REQUIRES libical-glib(x86-64) = 1.0.2-1.fc23 0 free 0 open 4 done 1 failed [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=9344126 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1201662] Review Request: wiredtiger - WiredTiger data storage engine
https://bugzilla.redhat.com/show_bug.cgi?id=1201662 --- Comment #13 from Marek Skalický mskal...@redhat.com --- (In reply to Jonathan Underwood from comment #12) Package Review Issues: === - Packages have proper BuildRequires/Requires on jpackage-utils The -java package should Require jpackage-utils (which owns /usr/lib/java). See: https://fedoraproject.org/wiki/Packaging:Java Fixed. - Package contains BR: python2-devel or python3-devel You currently have a BR for python-devel - this should be python2-devel. Also, you might consider building a python3 sub-package if that is supported too - Fedora will eventually move to python 3 as the default. See: http://fedoraproject.org/wiki/Packaging:Python Fixed. I will ask upstream about supporting python3... Spec URL: https://mskalick.fedorapeople.org/wiredtiger/wiredtiger.spec SRPM URL: https://mskalick.fedorapeople.org/wiredtiger/wiredtiger-2.5.1-5.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206067] Review Request: python-oslo-log - OpenStack Oslo Log library
https://bugzilla.redhat.com/show_bug.cgi?id=1206067 --- Comment #2 from Haïkel Guémar karlthe...@gmail.com --- 1. group tag = good catch 2. launchpad is also valid 3. does not harm having it but not necessary (we won't have older python-six in targeted distros) 4. could you explain ? oslo.log is just a log library, I can't think of a clearer description :/ 5. I wouldn't mess with compressed javascript files :/ 6. Yes, this is known, but it only causes a warning during documentation building, when python-oslo-context will be approved, the BuildRequires will be uncommented. Should not be a blocker. 7. +1 for ChangeLog and AUTHORS but bundling the other suggested documents are not useful (PKG-INFO is not recommended) = updated, thanks for your review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Parag AN(पराग) panem...@gmail.com --- Looks good now :) APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206222] Review Request: perl-Dist-Zilla-Plugin-Test-Compile - Common tests to check syntax of your modules, only using core modules
https://bugzilla.redhat.com/show_bug.cgi?id=1206222 Jitka Plesnikova jples...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jples...@redhat.com Assignee|nob...@fedoraproject.org|jples...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] New: Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528 Bug ID: 1206528 Summary: Review Request: python-oslo-middleware - OpenStack Oslo Middleware library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ape...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://apevec.fedorapeople.org/python-oslo-middleware.spec SRPM URL: https://apevec.fedorapeople.org/python-oslo-middleware-1.0.0-1.fc23.src.rpm Description: The OpenStack Oslo Middleware library. Oslo middleware library includes components that can be injected into wsgi pipelines to intercept request/response flows. The base class can be enhanced with functionality like add/delete/modification of http headers and support for limiting size/connection etc. Fedora Account System Username: apevec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528 --- Comment #1 from Alan Pevec ape...@gmail.com --- Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=9345630 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library
https://bugzilla.redhat.com/show_bug.cgi?id=1201325 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200955] Review Request: python-wrapt - A Python module for decorators, wrappers and monkey patching
https://bugzilla.redhat.com/show_bug.cgi?id=1200955 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 --- Comment #8 from Chandan Kumar chku...@redhat.com --- Hi Parag, Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-debtcollector.spec SRPM: https://chandankumar.fedorapeople.org/python-debtcollector-0.3.0-3.fc21.src.rpm Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206067] Review Request: python-oslo-log - OpenStack Oslo Log library
https://bugzilla.redhat.com/show_bug.cgi?id=1206067 Chandan Kumar chku...@redhat.com changed: What|Removed |Added CC||chku...@redhat.com --- Comment #1 from Chandan Kumar chku...@redhat.com --- This is un-official review of the package. + License is ASL 2.0 which is valid and its license text is installed in LICENSE file. Suggestions: [1.] Group tag is optional in Fedora and is only needed if you want this package to be built for EPEL5. See http://fedoraproject.org/wiki/EPEL:Packaging#Group_tag. You can remove Group tag from both package and sub-package. [2.] Change the URL from launchpad to pypi, URL: https://pypi.python.org/pypi/oslo.log [3.] Since this package requires python-six =1.9.0, please change Requires to: Requires:python-six = 1.9.0 [4.] Description of the package is not clear. Please add some more information about the package. [5.] rpmlint on all generated rpms and specfile give result: python-oslo-log-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-oslo-log-doc/html/_static/jquery.js 3 packages and 1 specfiles checked; 0 errors, 1 warnings. = It can be fixed by adding dos2unix doc/build/html/_static/jquery.js in %install section but this will require you to add in spec file BuildRequires: dos2unix [6.] From mock build.log, ImportError: No module named oslo_context Since, python-oslo-context package is not available in Fedora, Once it is availablle, Please add this package in BuildRequires in the spec file. [7.] in %files section, please include other files also present in the python package tarball. %doc AUTHORS CONTRIBUTING.rst README.rst PKG-INFO ChangeLog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library
https://bugzilla.redhat.com/show_bug.cgi?id=1206086 --- Comment #2 from Haïkel Guémar karlthe...@gmail.com --- 1. good catch 2. launchpad url is valid too 3. good catch 4. good catch 5. does not fail in rawhide, you probably use an older release chroot with an older python-oslo-sphinx (we dropped these kind of patches) scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9345063 build.log: https://kojipkgs.fedoraproject.org//work/tasks/5064/9345064/build.log During reviews, we should focus on rawhide support unless stated otherwise (packager expresses his intent to package on released Fedora, which is not the case for openstack kilo builds) 6. good catch for AUTHORS and ChangeLog, other files are not really relevant for packaging = updated -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805
Paul Howarth p...@city-fan.org changed:
What|Removed |Added
CC||p...@city-fan.org
--- Comment #3 from Paul Howarth p...@city-fan.org ---
Things I noticed from a quick look at the spec file:
The package does not need to provide itself:
Provides: owncloud-client = %{version}-%{release}
Should the Obsoletes have associated Provides? Will the package be going to
anywhere other than Rawhide?
The description and summary of the common sub-package need tidying up:
... common files for owncloud-client and owncloud-client ...
(Summaries and Descriptions should also generally start with a capital letter)
Use %license rather than %doc for COPYING
There should be a virtual -static provide for the libhttpbf.a static library:
http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library
https://bugzilla.redhat.com/show_bug.cgi?id=1201325 Chandan Kumar chku...@redhat.com changed: What|Removed |Added CC||chku...@redhat.com --- Comment #8 from Chandan Kumar chku...@redhat.com --- Hello Parag, Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-oslo-context.spec SRPM: https://chandankumar.fedorapeople.org/python-oslo-context-0.2.0-5.fc21.src.rpm and Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9345006 Thanks, Chandan Kumar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library
https://bugzilla.redhat.com/show_bug.cgi?id=1201325 --- Comment #10 from Parag AN(पराग) panem...@gmail.com --- update looks good again :) Thanks for the reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202063] Review Request: Classified ads - Internet messaging done right
https://bugzilla.redhat.com/show_bug.cgi?id=1202063 --- Comment #14 from Antti Järvinen antti.jarvi...@katiska.org --- And according to http://koji.fedoraproject.org/koji/taskinfo?taskID=9345035 it seems to compile also on ARM.. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library
https://bugzilla.redhat.com/show_bug.cgi?id=1201325 --- Comment #9 from Chandan Kumar chku...@redhat.com --- Done review of following package review requests: https://bugzilla.redhat.com/show_bug.cgi?id=1206067 and https://bugzilla.redhat.com/show_bug.cgi?id=1206086 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
https://bugzilla.redhat.com/show_bug.cgi?id=474603 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688408] Review Request: xfce4-cpufreq-plugin - CPU frequency scaling plugin for the Xfce4 panel
https://bugzilla.redhat.com/show_bug.cgi?id=688408 --- Comment #17 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 474603] Review Request: irrlicht - A high performance realtime 3D engine
https://bugzilla.redhat.com/show_bug.cgi?id=474603 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688408] Review Request: xfce4-cpufreq-plugin - CPU frequency scaling plugin for the Xfce4 panel
https://bugzilla.redhat.com/show_bug.cgi?id=688408 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1204614] Review Request: gofed - Tool for development of golang devel packages
https://bugzilla.redhat.com/show_bug.cgi?id=1204614 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
--- Comment #2 from Haïkel Guémar karlthe...@gmail.com ---
few minor issues:
* missing fallback macros for %license (required for EL7)
%{!?_licensedir:%global license %%doc}
* missing Requires: python-oslo-context (just approved)
https://bugzilla.redhat.com/show_bug.cgi?id=1201325
= I was able to confirm that it works with that package installed
Everything else is good, should be approved as soon as these points are fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872783] Review Request: Ray - Parallel genome assemblies for parallel DNA sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=872783 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142491] Review Request: rubygem-ox - Fast XML parser and object serializer
https://bugzilla.redhat.com/show_bug.cgi?id=1142491 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142491] Review Request: rubygem-ox - Fast XML parser and object serializer
https://bugzilla.redhat.com/show_bug.cgi?id=1142491 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1199055] Review Request: mediawiki123 - A wiki engine
https://bugzilla.redhat.com/show_bug.cgi?id=1199055
Andrea Veri andrea.v...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review-
--- Comment #9 from Andrea Veri andrea.v...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- The doc/ directory is than 1M in size, please consider moving it to its own
sub-package.
- The licenses breakdown should be more detailed, please provide a
PACKAGE-LICENSING
file containing a list of files (you can ideally use directories and
wildcards if you prefer making
sure that specific dir has no files licensed under a different license than
the one you are listing)
and their respective license.
- The package ships with 5 LICENSE files but none is showing under %license,
ideally we'd want them
renamed to something like LICENSE.$LICENSE_NAME on %license given we're
targeting EPEL 7. (which
should not need any patch for the new %license field to work properly as per
https://fedorahosted.org/fpc/ticket/411)
- As Orion pointed out /var/www/mediawiki123 contains a mw-config dir and
within it another
mw-config dir in the form of a symlink.
- File includes/libs/jsminplus.php seems to be triple licensed (MPL 1.1/GPL
2.0/LGPL 2.1) but no mention of it
appears under License.
- Latest release is not installed, the chosen release seems to be a LTS which
makes sense for our target. This
comment is purely informative.
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
[!]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[X]: Each %files section contains %defattr if rpm 4.4 (we're targeting EPEL 7
which ships with rpm 4.11.1)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[X]: Package complies to the Packaging Guidelines
[X]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[X]: Package installs properly.
[X]: Rpmlint is run on all rpms the build produces.
[X]: Package requires other packages for directories it uses.
[X]: Package must own all directories that it creates.
[X]: Package does not own files or directories owned by other packages.
[X]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[X]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[X]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[X]: Macros in Summary, %description expandable at SRPM build time.
[X]: Package does not contain duplicates in %files.
[X]: Permissions on files are set properly.
[X]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[X]: Package is named using only allowed ASCII characters.
[X]: Package do not use a name that already exist
[X]: Package is not relocatable.
[X]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[X]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[X]: File names are valid UTF-8.
[X]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[X]: Package contains the mandatory BuildRequires and Requires: use
{strict,warnings,Data::Dumper,Cwd
were found and they do match the provided Requires.
Python:
[-]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[X]: Package contains BR: python2-devel or python3-devel
[-]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[X]: Sources can be
[Bug 1206067] Review Request: python-oslo-log - OpenStack Oslo Log library
https://bugzilla.redhat.com/show_bug.cgi?id=1206067 Lukas Bezdicka soc...@v3.sk changed: What|Removed |Added CC||soc...@v3.sk Assignee|nob...@fedoraproject.org|soc...@v3.sk Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1201662] Review Request: wiredtiger - WiredTiger data storage engine
https://bugzilla.redhat.com/show_bug.cgi?id=1201662 --- Comment #14 from Jonathan Underwood jonathan.underw...@gmail.com --- Hmm... You've put the Requires: jpackage-utils in the main package, rather than the -java sub-package. I believe it should be in the -java sub-package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 872783] Review Request: Ray - Parallel genome assemblies for parallel DNA sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=872783 --- Comment #55 from Jon Ciesla limburg...@gmail.com --- Complete. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206067] Review Request: python-oslo-log - OpenStack Oslo Log library
https://bugzilla.redhat.com/show_bug.cgi?id=1206067
--- Comment #3 from Lukas Bezdicka soc...@v3.sk ---
Please fix the description section, you have several typos there.
Rest seems to be fine.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
Note: Cannot find LICENSE in rpm(s)
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
2 files have unknown license. Detailed output of licensecheck in
/home/social/1206067-python-oslo-log/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[!]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Python:
[x]: Binary eggs must be removed in %prep
Note: Test run failed
[x]: Python eggs must not download any dependencies during the build process.
Note: Test run failed
[x]: A package which is used by another package via an egg interface should
provide egg info.
Note: Test run failed
[x]: Package meets the Packaging Guidelines::Python
Note: Test run failed
[x]: Package contains BR: python2-devel or python3-devel
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
oslo-log-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #18 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847571] Review Request: python-tbgrep - Extract Python Tracebacks from text
https://bugzilla.redhat.com/show_bug.cgi?id=847571 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847571] Review Request: python-tbgrep - Extract Python Tracebacks from text
https://bugzilla.redhat.com/show_bug.cgi?id=847571 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1204614] Review Request: gofed - Tool for development of golang devel packages
https://bugzilla.redhat.com/show_bug.cgi?id=1204614 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206295] Review Request: python-curtsies - Curses-like terminal wrapper, with colored strings
https://bugzilla.redhat.com/show_bug.cgi?id=1206295 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206295] Review Request: python-curtsies - Curses-like terminal wrapper, with colored strings
https://bugzilla.redhat.com/show_bug.cgi?id=1206295 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon-qt5 - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 --- Comment #12 from Daniel Vrátil dvra...@redhat.com --- Looks like Chris is busy or is not available atm. Mario, could you please finish the review? We need the whole signon/libaccounts/KAccounts stack ready for upcomming KDE Applications 15.04 update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1161483] Review Request: o3dgc - an open 3D graphics compression library
https://bugzilla.redhat.com/show_bug.cgi?id=1161483 David Tardon dtar...@redhat.com changed: What|Removed |Added CC||dtar...@redhat.com --- Comment #1 from David Tardon dtar...@redhat.com --- Spec URL: https://dtardon.fedorapeople.org/rpm/o3dgc.spec SRPM URL: https://dtardon.fedorapeople.org/rpm/o3dgc-0-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library
https://bugzilla.redhat.com/show_bug.cgi?id=1201325 Chandan Kumar chkumar...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Chandan Kumar chkumar...@gmail.com --- New Package SCM Request === Package Name: python-oslo-context Short Description: OpenStack Oslo context library Upstream URL: https://pypi.python.org/pypi/oslo.context Owners: chandankumar Branches: f22 InitialCC: apevec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206067] Review Request: python-oslo-log - OpenStack Oslo Log library
https://bugzilla.redhat.com/show_bug.cgi?id=1206067 Lukas Bezdicka soc...@v3.sk changed: What|Removed |Added Assignee|soc...@v3.sk|nob...@fedoraproject.org Flags|fedora-review? |fedora-review+ --- Comment #4 from Lukas Bezdicka soc...@v3.sk --- Remaining rpmlint warnings are acceptable, mock failed because of missing python-oslo-context which already passed review in bug #1201325. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library
https://bugzilla.redhat.com/show_bug.cgi?id=1206086
--- Comment #3 from Lukas Bezdicka soc...@v3.sk ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
Note: Cannot find LICENSE in rpm(s)
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
1 files have unknown license. Detailed output of licensecheck in
/home/social/1206086-python-oslo-versionedobjects/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Python:
[x]: Binary eggs must be removed in %prep
Note: Test run failed
[x]: Python eggs must not download any dependencies during the build process.
Note: Test run failed
[x]: A package which is used by another package via an egg interface should
provide egg info.
Note: Test run failed
[x]: Package meets the Packaging Guidelines::Python
Note: Test run failed
[x]: Package contains BR: python2-devel or python3-devel
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
oslo-versionedobjects-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[Bug 1204614] Review Request: gofed - Tool for development of golang devel packages
https://bugzilla.redhat.com/show_bug.cgi?id=1204614 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- gofed-0-0.1.gitcab0f0b.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/gofed-0-0.1.gitcab0f0b.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1204614] Review Request: gofed - Tool for development of golang devel packages
https://bugzilla.redhat.com/show_bug.cgi?id=1204614 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1204614] Review Request: gofed - Tool for development of golang devel packages
https://bugzilla.redhat.com/show_bug.cgi?id=1204614 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- gofed-0-0.1.gitcab0f0b.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/gofed-0-0.1.gitcab0f0b.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200955] Review Request: python-wrapt - A Python module for decorators, wrappers and monkey patching
https://bugzilla.redhat.com/show_bug.cgi?id=1200955 Chandan Kumar chkumar...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Chandan Kumar chkumar...@gmail.com --- New Package SCM Request === Package Name: python-wrapt Short Description: A Python module for decorators, wrappers and monkey patching Upstream URL: https://github.com/GrahamDumpleton/wrapt Owners: chandankumar Branches: f22 InitialCC: apevec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Chandan Kumar chkumar...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Chandan Kumar chkumar...@gmail.com --- New Package SCM Request === Package Name: python-debtcollector Short Description: A collection of Python deprecation patterns and strategies Upstream URL: https://pypi.python.org/pypi/debtcollector Owners: chandankumar Branches: f22 InitialCC: apevec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library
https://bugzilla.redhat.com/show_bug.cgi?id=1206086 Lukas Bezdicka soc...@v3.sk changed: What|Removed |Added CC||soc...@v3.sk Assignee|nob...@fedoraproject.org|soc...@v3.sk Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206086] Review Request: python-oslo-versionedobjects - OpenStack common versionedobjects library
https://bugzilla.redhat.com/show_bug.cgi?id=1206086 Lukas Bezdicka soc...@v3.sk changed: What|Removed |Added Assignee|soc...@v3.sk|nob...@fedoraproject.org Flags|fedora-review? |fedora-review+ --- Comment #4 from Lukas Bezdicka soc...@v3.sk --- mock failed because of missing python-oslo-client and python-oslo-concurrency which both just passed reviews, the issue with different SPEC/SRPM is now resolved, giving + -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206067] Review Request: python-oslo-log - OpenStack Oslo Log library
https://bugzilla.redhat.com/show_bug.cgi?id=1206067 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Haïkel Guémar karlthe...@gmail.com --- New Package SCM Request === Package Name: python-oslo-log Short Description: OpenStack Oslo Log library Upstream URL: http://launchpad.net/oslo Owners: hguemar,apevec Branches: f22 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1204614] Review Request: gofed - Tool for development of golang devel packages
https://bugzilla.redhat.com/show_bug.cgi?id=1204614 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- gofed-0-0.1.gitcab0f0b.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/gofed-0-0.1.gitcab0f0b.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1204614] Review Request: gofed - Tool for development of golang devel packages
https://bugzilla.redhat.com/show_bug.cgi?id=1204614 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- gofed-0-0.1.gitcab0f0b.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/gofed-0-0.1.gitcab0f0b.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142491] Review Request: rubygem-ox - Fast XML parser and object serializer
https://bugzilla.redhat.com/show_bug.cgi?id=1142491 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- rubygem-ox-2.1.8-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/rubygem-ox-2.1.8-2.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142491] Review Request: rubygem-ox - Fast XML parser and object serializer
https://bugzilla.redhat.com/show_bug.cgi?id=1142491 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142491] Review Request: rubygem-ox - Fast XML parser and object serializer
https://bugzilla.redhat.com/show_bug.cgi?id=1142491 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- rubygem-ox-2.1.8-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/rubygem-ox-2.1.8-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142491] Review Request: rubygem-ox - Fast XML parser and object serializer
https://bugzilla.redhat.com/show_bug.cgi?id=1142491 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- rubygem-ox-2.1.8-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-ox-2.1.8-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142491] Review Request: rubygem-ox - Fast XML parser and object serializer
https://bugzilla.redhat.com/show_bug.cgi?id=1142491 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- rubygem-ox-2.1.8-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/rubygem-ox-2.1.8-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
https://bugzilla.redhat.com/show_bug.cgi?id=812137 --- Comment #16 from Miro Hrončok mhron...@redhat.com --- From the history of Clipper API changes I'd say it will change rapidly in the future as well and maintaining it in EPEL7 will be pain. So I'm definitely not doing it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907261] Review Request: poly2tri - A 2D constrained Delaunay triangulation library
https://bugzilla.redhat.com/show_bug.cgi?id=907261 --- Comment #26 from Miro Hrončok mhron...@redhat.com --- I could. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202890] Review Request: kaccounts-providers - Additional service providers for KAccounts framework
https://bugzilla.redhat.com/show_bug.cgi?id=1202890 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|1135103 (plasma5) |1135564 (ktp-kf5) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1135103 [Bug 1135103] Plasma 5 Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1135564 [Bug 1135564] ktp-presence-applet: plasma5 support (RFE) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202887] Review Request: signon-ui - Online Accounts Sign-on Ui
https://bugzilla.redhat.com/show_bug.cgi?id=1202887 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks||1135564 (ktp-kf5) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1135564 [Bug 1135564] ktp-presence-applet: plasma5 support (RFE) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework
https://bugzilla.redhat.com/show_bug.cgi?id=1205793 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks|1135103 (plasma5) |1135564 (ktp-kf5) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1135103 [Bug 1135103] Plasma 5 Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1135564 [Bug 1135564] ktp-presence-applet: plasma5 support (RFE) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon-qt5 - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon-qt5 - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Assignee|i...@cicku.me |rdie...@math.unl.edu Flags|fedora-review? | |needinfo?(i...@cicku.me) | --- Comment #13 from Rex Dieter rdie...@math.unl.edu --- I can -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies
https://bugzilla.redhat.com/show_bug.cgi?id=1200520 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206067] Review Request: python-oslo-log - OpenStack Oslo Log library
https://bugzilla.redhat.com/show_bug.cgi?id=1206067 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206067] Review Request: python-oslo-log - OpenStack Oslo Log library
https://bugzilla.redhat.com/show_bug.cgi?id=1206067 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200955] Review Request: python-wrapt - A Python module for decorators, wrappers and monkey patching
https://bugzilla.redhat.com/show_bug.cgi?id=1200955 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566560] Review Request: libaesgm - Library implementation of AES (Rijndael) cryptographic methods
https://bugzilla.redhat.com/show_bug.cgi?id=566560 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #17 from Orion Poplawski or...@cora.nwra.com --- Package Change Request == Package Name: libaesgm New Branches: epel7 Owners: orion InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
https://bugzilla.redhat.com/show_bug.cgi?id=812137 --- Comment #17 from Orion Poplawski or...@cora.nwra.com --- Thanks for the explanation. That sounds like a good reason to exclude it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015253] Review Request: svn2git - A tool for migrating SVN projects to Git
https://bugzilla.redhat.com/show_bug.cgi?id=1015253 --- Comment #13 from Ken Dreyer ktdre...@ktdreyer.com --- (In reply to Anders Blomdell from comment #12) BTW: whats the harm in specifying BuildRequires: ruby? If a Ruby package is noarch, it should BuildRequires: ruby(release), because in theory it could work with any Ruby interpreter. If a Ruby package is arch-dependent, it should BuildRequires: ruby-devel. There is not much harm in specifying BuildRequires: ruby in svn2git's case, but we might as well be correct :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070406] Review Request: signon-qt5 - Accounts framework for Linux and POSIX based platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1070406
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #14 from Rex Dieter rdie...@math.unl.edu ---
Naming: ok, but... small suggestion:
1. I'd prefer this pkg follow upstream name and just call it 'signon'. We can
then choose to make signon-qt5 subpkgs from it.
Not a blocker, especially if you feel strongly otherwise.
2. 8.57-1 update missed %changelog entry, please fix prior to doing official
builds
3. SHOULD do out-of-src tree build, something like:
%build
mkdir build
pushd build
...
%{qmake_qt5} ..
...
popd
4. SHOULD fix or document this explicit -devel dependency:
Requires: glib2-devel%{?_isa}
(either fix by adding a pkg-config dependency or document in a comment why that
would be insufficient and needed anyway)
License: OK
macros: ok
scriptlets: ok
Not strict blockers, though ideally I'd still like to see this named 'signon'
instead (see item 1), in which case, I'd like to see one more update with that
implemented.
(In case you disagree with renaming), consider this APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566560] Review Request: libaesgm - Library implementation of AES (Rijndael) cryptographic methods
https://bugzilla.redhat.com/show_bug.cgi?id=566560 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1161487] Review Request: collada2gltf - an open-source command-line pipeline tool that converts COLLADA to glTF
https://bugzilla.redhat.com/show_bug.cgi?id=1161487 --- Comment #1 from David Tardon dtar...@redhat.com --- Spec URL: https://dtardon.fedorapeople.org/rpm/collada2gltf.spec SRPM URL: https://dtardon.fedorapeople.org/rpm/collada2gltf-0-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206639] New: Review Request: dibbler - Portable DHCPv6 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1206639 Bug ID: 1206639 Summary: Review Request: dibbler - Portable DHCPv6 implementation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ihrac...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ihrachyshka.fedorapeople.org/dibbler.spec SRPM URL: https://ihrachyshka.fedorapeople.org/dibbler-1.0.1-0.RC1.fc21.src.rpm Description: Dibbler is a portable DHCPv6 implementation. It supports stateful (i.e. IPv6 address granting and IPv6 prefix delegation) as well as stateless (i.e. option granting) autoconfiguration for IPv6. Fedora Account System Username: ihrachyshka -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library
https://bugzilla.redhat.com/show_bug.cgi?id=1201325 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1201325] Review Request: python-oslo-context - OpenStack Oslo context library
https://bugzilla.redhat.com/show_bug.cgi?id=1201325 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1200955] Review Request: python-wrapt - A Python module for decorators, wrappers and monkey patching
https://bugzilla.redhat.com/show_bug.cgi?id=1200955 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566560] Review Request: libaesgm - Library implementation of AES (Rijndael) cryptographic methods
https://bugzilla.redhat.com/show_bug.cgi?id=566560 --- Comment #18 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203105] Review Request: rubygem-amq-protocol - AMQP 0.9.1 encoder decoder
https://bugzilla.redhat.com/show_bug.cgi?id=1203105 --- Comment #13 from Ken Dreyer ktdre...@ktdreyer.com --- By the way, the rpmdev-bumpspec utility does take some of the manual work out of bumping the release number when making changes :) Maybe you already knew about that; just figured I'd mention it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206639] Review Request: dibbler - Portable DHCPv6 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1206639 Kashyap Chamarthy kcham...@redhat.com changed: What|Removed |Added CC||kcham...@redhat.com Assignee|nob...@fedoraproject.org|kcham...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203018] Review Request: baculum - WebGUI tool for Bacula Community program
https://bugzilla.redhat.com/show_bug.cgi?id=1203018 --- Comment #8 from Marcin Haba marcin.h...@bacula.pl --- I updated new Spec file and SRPM. Location is the same as previously: Spec URL: http://www.bacula.pl/baculum.spec SRPM URL: http://www.bacula.pl/baculum-7.0.6-0.1.a.fc21.src.rpm I also built on Koji the Baculum. Here is this task: https://koji.fedoraproject.org/koji/taskinfo?taskID=9349633 After three failed builds, now the build finished successfully. I needed to add to build requirements systemd-units. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206684] Review Request: python-oslo-policy - OpenStack Oslo Policy library
https://bugzilla.redhat.com/show_bug.cgi?id=1206684 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206684] Review Request: python-oslo-policy - OpenStack Oslo Policy library
https://bugzilla.redhat.com/show_bug.cgi?id=1206684
Haïkel Guémar karlthe...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Haïkel Guémar karlthe...@gmail.com ---
Since this package complies with Fedora packaging guidelines, I hereby approve
it into Fedora Packages Collection. Please submit a SCM request.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
1 files have unknown license. Detailed output of licensecheck in
/home/haikel/1206684-python-oslo-policy/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
oslo-policy-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 Dennis Gilmore dgilm...@redhat.com changed: What|Removed |Added CC||dgilm...@redhat.com --- Comment #4 from Dennis Gilmore dgilm...@redhat.com --- a bug I noticed is that the client complains that it can not verify the ca for my server. even though firefox and everything else is able to validate it just fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206684] New: Review Request: python-oslo-policy - OpenStack Oslo Policy library
https://bugzilla.redhat.com/show_bug.cgi?id=1206684 Bug ID: 1206684 Summary: Review Request: python-oslo-policy - OpenStack Oslo Policy library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ape...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://apevec.fedorapeople.org/python-oslo-policy.spec SRPM URL: https://apevec.fedorapeople.org/python-oslo-policy-0.3.1-1.fc23.src.rpm Description: The OpenStack Oslo Policy library. RBAC policy enforcement library for OpenStack. Fedora Account System Username: apevec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206528] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
--- Comment #3 from Alan Pevec ape...@gmail.com ---
* missing fallback macros for %license (required for EL7)
%{!?_licensedir:%global license %%doc}
You mean required for EL6? %license seems to work out of the box on EL7
but I'll add it for possible EL6 rebuilds.
* missing Requires: python-oslo-context (just approved)
Also stevedore in requirements.txt.
Spec URL: https://apevec.fedorapeople.org/python-oslo-middleware.spec
SRPM URL:
https://apevec.fedorapeople.org/python-oslo-middleware-1.0.0-2.fc23.src.rpm
Description: The OpenStack Oslo Middleware library.
Oslo middleware library includes components that can be injected into wsgi
pipelines to intercept request/response flows. The base class can be
enhanced with functionality like add/delete/modification of http headers
and support for limiting size/connection etc.
Fedora Account System Username: apevec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- libwebp-0.4.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libwebp-0.4.3-1.el6 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206684] Review Request: python-oslo-policy - OpenStack Oslo Policy library
https://bugzilla.redhat.com/show_bug.cgi?id=1206684 --- Comment #1 from Alan Pevec ape...@gmail.com --- Rawhide scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=9348869 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707389] Review Request: libwebp - Library and tools for the WebP graphics format
https://bugzilla.redhat.com/show_bug.cgi?id=707389 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- libwebp-0.4.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libwebp-0.4.3-2.el6 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206732] Review Request: python-gccjit - Python bindings for libgccjit
https://bugzilla.redhat.com/show_bug.cgi?id=1206732 --- Comment #1 from Dave Malcolm dmalc...@redhat.com --- Specfile can also be seen at https://github.com/davidmalcolm/python-gccjit-srpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206739] New: Review Request: python-crypto2.1 - Cryptography library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1206739 Bug ID: 1206739 Summary: Review Request: python-crypto2.1 - Cryptography library for Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: athma...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://athmane.fedorapeople.org/pkgs/fabric-el6/python-crypto2.1.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/fabric-el6/python-crypto2.1-2.1.0-1.el6.src.rpm Description: Python-crypto is a collection of both secure hash functions (such as MD5 and SHA), and various encryption algorithms (AES, DES, RSA, ElGamal etc.). This is a parallel update for EPEL6 Fedora Account System Username: athmane -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206739] Review Request: python-crypto2.1 - Cryptography library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1206739 --- Comment #1 from Athmane Madjoudj athma...@gmail.com --- PS. I need this to push fabric in EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206739] Review Request: python-crypto2.1 - Cryptography library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1206739 Athmane Madjoudj athma...@gmail.com changed: What|Removed |Added Blocks||1206737 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1206737 [Bug 1206737] Review Request: python-paramiko1.10 - SH2 protocol library for python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
