[Bug 1197517] Review Request: elmon - Performance monitoring tool
https://bugzilla.redhat.com/show_bug.cgi?id=1197517 --- Comment #19 from Fedora Update System --- elmon-13b1-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0631ee4ae6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383434] Review Request: python-ntlm3 - Python 3 compatible NTLM library
https://bugzilla.redhat.com/show_bug.cgi?id=1383434 --- Comment #8 from Fedora Update System --- python-ntlm3-1.0.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-42d15484cc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1383445] Review Request: python-requests_ntlm - HTTP NTLM authentication using the requests library
https://bugzilla.redhat.com/show_bug.cgi?id=1383445 --- Comment #7 from Fedora Update System --- python-requests_ntlm-0.3.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-cfd7f83ae9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382926] Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1382926 Petr Pisar changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar --- Spec file changes: --- perl-HTTP-MultiPartParser.spec.old 2016-10-08 13:44:41.0 +0200 +++ perl-HTTP-MultiPartParser.spec 2016-10-26 19:25:39.0 +0200 @@ -1,6 +1,6 @@ Name: perl-HTTP-MultiPartParser Version:0.01 -Release:1%{?dist} +Release:2%{?dist} Summary:HTTP MultiPart Parser License:GPL+ or Artistic Group: Development/Libraries @@ -10,14 +10,28 @@ BuildArch: noarch BuildRequires: perl-generators BuildRequires: perl >= 1:5.8.1 + BuildRequires: perl(Carp) +BuildRequires: perl(Cwd) +BuildRequires: perl(Data::Dumper) +BuildRequires: perl(Exporter) BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(FindBin) +BuildRequires: perl(IO::File) BuildRequires: perl(Scalar::Util) -BuildRequires: perl(Test::Deep) BuildRequires: perl(Test::More) >= 0.88 +BuildRequires: perl(Test::Deep) + +BuildRequires: perl(lib) BuildRequires: perl(strict) +BuildRequires: perl(vars) BuildRequires: perl(warnings) +BuildRequires: perl(inc::Module::Install) +BuildRequires: perl(Module::Install::ReadmeFromPod) + +BuildRequires: %{__make} + Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %description @@ -26,24 +40,28 @@ %prep %setup -q -n HTTP-MultiPartParser-%{version} +%{__rm} -rf inc %build %{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 -make %{?_smp_mflags} +%{__make} %{?_smp_mflags} %install -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +%{__make} pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT %{_fixperms} $RPM_BUILD_ROOT/* %check -make test +%{__make} test %files -%doc Changes README +%doc Changes README eg/ %{perl_vendorlib}/* %{_mandir}/man3/* %changelog +* Wed Oct 26 2016 Ralf Corsépius - 0.01-2 +- Reflect feedback from review. + * Sat Oct 08 2016 Ralf Corsépius - 0.01-1 - Initial Fedora package. > FIX: Build-requires `make' (perl-HTTP-MultiPartParser.spec:32). -make %{?_smp_mflags} +%{__make} %{?_smp_mflags} Now when you call macro instead of the command, I think is a problem of the rpm now. > FIX: Build-require `perl(Cwd)' (t/030_basic.t:11). +BuildRequires: perl(Cwd) Ok. > FIX: Build-require `perl(Data::Dumper)' (t/lib/PAML.pm:8). +BuildRequires: perl(Data::Dumper) Ok. > FIX: Build-require `perl(Exporter)' (t/lib/PAML.pm:17). +BuildRequires: perl(Exporter) Ok. > FIX: Build-require `perl(FindBin)' (t/030_basic.t:6). +BuildRequires: perl(FindBin) Ok. > FIX: Build-require `perl(IO::File)' (t/lib/PAML.pm:9). +BuildRequires: perl(IO::File) Ok. > FIX: Build-require `perl(lib)' (t/030_basic.t:7). +BuildRequires: perl(lib) Ok. > FIX: Build-require `perl(vars)' (t/035_headers.t:28). +BuildRequires: perl(vars) Ok. > FIX: Either unbundle the ./inc files and build-require the Module::Install* > modules whose functions are called from Makefile.PL or build-require > dependencies of the bundled code (`perl(File::Find)' in > inc/Module/Install.pm:23, `perl(File::Path)' im inc/Module/Install.pm:24 > etc.). +BuildRequires: perl(inc::Module::Install) +BuildRequires: perl(Module::Install::ReadmeFromPod) [...] +%{__rm} -rf inc TODO: I recommend to build-require these modules in addition: perl(Module::Install::Metadata) (Makefile.PL:5) perl(Module::Install::WriteAll) (Makefile.PL:17) > TODO: Package eg/example.pl as a documentation. -%doc Changes README +%doc Changes README eg/ Ok. $ rpmlint perl-HTTP-MultiPartParser.spec ../SRPMS/perl-HTTP-MultiPartParser-0.01-2.fc26.src.rpm ../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-2.fc26.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Package build in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=16220702). Ok. Please consider fixing the `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1385180] Review Request: purple-facebook - Facebook protocol plugin for purple2
https://bugzilla.redhat.com/show_bug.cgi?id=1385180 --- Comment #12 from Fedora Update System --- purple-facebook-0.0.0.20160409-0.4.git66ee773.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1385180] Review Request: purple-facebook - Facebook protocol plugin for purple2
https://bugzilla.redhat.com/show_bug.cgi?id=1385180 --- Comment #11 from Fedora Update System --- purple-facebook-0.0.0.20160409-0.4.git66ee773.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1381935] Review Request: python-distro - Linux Distribution - a Linux OS platform information API
https://bugzilla.redhat.com/show_bug.cgi?id=1381935 --- Comment #19 from Fedora Update System --- python-distro-1.0.0-6.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379432] Review Request: odoo - Suite of web based open source business apps
https://bugzilla.redhat.com/show_bug.cgi?id=1379432 --- Comment #6 from Björn "besser82" Esser --- (In reply to Alec Leamas from comment #5) > Some initial remarks, before going into the review: > >- I see all sorts of licenses in the code: Apache, BSD, GPLv3, MIT... can > you review this? The LGPLv3 for everything doesn't seem OK. > - Here seems to be some bundled, minified javascript libraries such as > react. Please refer to https://fedoraproject.org/wiki/Packaging:JavaScript. > > Here is also things like (./odoo/addons/l10n_cr/__init__.py:) Yeah, I found a lot of stuff to unbundle: fonts, js, python-code :/ > At top; > # Part of Odoo. See LICENSE file for full copyright and licensing details. > > line 8-9 > #First author: Carlos Vásquez > (ClearCorp S.A.) > #Copyright (c) 2010-TODAY ClearCorp S.A. (http://clearcorp.co.cr). All > rights reserved > > To me, this doesn't make sense. It looks like the author has claimed all > rights, and published under a MIT license. And then odoo has pasted there > own license on top, more or less hijacking the code. I am not a lawyer, but > this looks fishy. Thoughts? For the MIT-License it is fine this way, since this license explicitly allows relicensing / sublicensing. See fulltext: https://opensource.org/licenses/MIT -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1103555] Review Request: fcl - The Flexible Collision Library
https://bugzilla.redhat.com/show_bug.cgi?id=1103555 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-10-26 18:30:29 --- Comment #14 from Fedora Update System --- fcl-0.5.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364618] Review Request: embree - Collection of high-performance ray tracing kernels developed at Intel
https://bugzilla.redhat.com/show_bug.cgi?id=1364618 Bug 1364618 depends on bug 1299922, which changed state. Bug 1299922 Summary: update 1.6.0 https://bugzilla.redhat.com/show_bug.cgi?id=1299922 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382935] Review Request: python-visitor - A tiny python visitor implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1382935 --- Comment #5 from Fedora Update System --- python-visitor-0.1.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-784d83ab22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1197517] Review Request: elmon - Performance monitoring tool
https://bugzilla.redhat.com/show_bug.cgi?id=1197517 --- Comment #18 from Fedora Update System --- elmon-13b1-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-01d362b04d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1388344] Review Request: javapoet - API for generating .java sources
https://bugzilla.redhat.com/show_bug.cgi?id=1388344 --- Comment #6 from Fedora Update System --- javapoet-1.7.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9142662ab1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1387538] Review Request: python-typing - Type Hints for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1387538 Orion Poplawski changed: What|Removed |Added Status|ASSIGNED|POST CC||or...@cora.nwra.com --- Comment #3 from Orion Poplawski --- We may want to revive this, at least for EPEL. See https://bugzilla.redhat.com/show_bug.cgi?id=1342693#c15 We may even want to replace the python2-typing package in Fedora with this one, but I don't see a big reason to do so there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1342693] Review Request: python2-typing - Typing defines a standard notation for type annotations
https://bugzilla.redhat.com/show_bug.cgi?id=1342693 Orion Poplawski changed: What|Removed |Added CC||chku...@redhat.com, ||or...@cora.nwra.com --- Comment #15 from Orion Poplawski --- I have need of python34-typing now in EPEL. I see two options forward: - There was a python-typing package approved (though quickly retired in Fedora in favor of this package), see bug #1387538. We could use the EPEL branches of that to ship both python2- and python34-typing and retire the EPEL branches of python2-typing. - We could review a separate python34-typing package for EPEL. I have a package ready to go - https://www.cora.nwra.com/~orion/fedora/python34-typing-3.5.2.2-1.el7.src.rpm I think I lean towards the first option. Any other thoughts? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1388396] Review Request: python-pynlpl - A Python library for Natural Language Processing
https://bugzilla.redhat.com/show_bug.cgi?id=1388396 --- Comment #4 from Miro Hrončok --- You can use %package doc Instead of %package -n python-%{pkg_name}-doc --- The docs generation tracebacks a lot, have a look at that and investigate please. --- The docs would be better generated with python 3 to show our love of Python 3, however, if that would be too complicated, just keep it as is. --- The links in /usr/bin should normally follow this pastern: less specific -> more specific I.e. the other way around than: /usr/bin/pynlpl-computepmi-3 /usr/bin/pynlpl-computepmi-3.5 -> /usr/bin/pynlpl-computepmi-3 /usr/bin/pynlpl-makefreqlist-3 /usr/bin/pynlpl-makefreqlist-3.5 -> /usr/bin/pynlpl-makefreqlist-3 /usr/bin/pynlpl-sampler-3 /usr/bin/pynlpl-sampler-3.5 -> /usr/bin/pynlpl-sampler-3 Also, in this case I would say just omit the Python version at all, as the version thing is there just to distinguish between the Python 2 and Python 3 executables and here the executables are only in Python 3 subpackage. --- I was quite curious, how it is possible that after %py3_install there is stuff in /usr/bin to move around and after %py2_install, there is none. So I've looked at the sources and it's explicitly only allowed on Python 3, so it works as expected. I recommend adding a comment after %py2_install, something like: # the executables are only installed on python 3 (by statement in setup.py) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379432] Review Request: odoo - Suite of web based open source business apps
https://bugzilla.redhat.com/show_bug.cgi?id=1379432 --- Comment #5 from Alec Leamas --- Some initial remarks, before going into the review: - I see all sorts of licenses in the code: Apache, BSD, GPLv3, MIT... can you review this? The LGPLv3 for everything doesn't seem OK. - Here seems to be some bundled, minified javascript libraries such as react. Please refer to https://fedoraproject.org/wiki/Packaging:JavaScript. Here is also things like (./odoo/addons/l10n_cr/__init__.py:) At top; # Part of Odoo. See LICENSE file for full copyright and licensing details. line 8-9 #First author: Carlos Vásquez (ClearCorp S.A.) #Copyright (c) 2010-TODAY ClearCorp S.A. (http://clearcorp.co.cr). All rights reserved To me, this doesn't make sense. It looks like the author has claimed all rights, and published under a MIT license. And then odoo has pasted there own license on top, more or less hijacking the code. I am not a lawyer, but this looks fishy. Thoughts? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1386563] Review Request: python-ruamel-yaml - YAML 1.2 loader/ dumper package for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1386563 --- Comment #10 from Orion Poplawski --- Hmm, python2 tests fail on EPEL7. First due to a bug in python-py, see bug #1389113. Updating python-py on my system I then get: === FAILURES === TestAnchorsAliases.test_reused_anchor _ self = def test_reused_anchor(self): yaml = ''' - &a x: 1 - <<: *a - &a x: 2 - <<: *a ''' > with pytest.warns(ReusedAnchorWarning): E AttributeError: 'module' object has no attribute 'warns' _test/test_anchor.py:243: AttributeError which is probably due to an old pytest. With python34 I get: E ImportError: No module named 'typing' Looks like the typing module can in with python 3.5. Perhaps we can get a python34-typing package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1386563] Review Request: python-ruamel-yaml - YAML 1.2 loader/ dumper package for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1386563 --- Comment #9 from Orion Poplawski --- python2-typing update for EPEL7 - https://bodhi.fedoraproject.org/updates/python2-typing-3.5.2.2-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1386563] Review Request: python-ruamel-yaml - YAML 1.2 loader/ dumper package for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1386563 Orion Poplawski changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #8 from Orion Poplawski --- I've checked in some changes to enable building the python3 package on Fedora and EPEL, and to run the tests. We'll need python2-typing in epel before it will build there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389091] Review Request: tang - Network Presence Binding Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1389091 --- Comment #2 from Nathaniel McCallum --- tang.x86_64: W: no-documentation tang.x86_64: W: non-standard-uid /var/cache/tang tang tang.x86_64: W: non-standard-gid /var/cache/tang tang tang.x86_64: E: non-standard-dir-perm /var/cache/tang 750 tang.x86_64: W: non-standard-uid /var/db/tang tang tang.x86_64: W: non-standard-gid /var/db/tang tang tang.x86_64: E: non-standard-dir-perm /var/db/tang 2570 tang.x86_64: W: non-standard-dir-in-var db These need some explaining. Tang has a "human readable" database in /var/db/tang. You stick key files in that directory. When the directory changes, systemd fires /usr/libexec/tangd-update. This regenerates the "computer readable" database in /var/cache/tang. The tangd-update script runs as the tang user and reads from /var/db/tang and writes to /var/cache/tang. The tangd process reads from /var/cache/tang exclusively. Thus, users who have access to keys get membership in the tang group. They can create/remove files in /var/db/tang. Since this directory is setuid, everyone else in the group can manage the keys as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1385534] Review Request: python-ruamel-ordereddict - Ordered dictionary with Key Insertion Order
https://bugzilla.redhat.com/show_bug.cgi?id=1385534 Orion Poplawski changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #7 from Orion Poplawski --- I checked in a change to run the tests and bring the master and epel7 branches in sync. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382875] Review Request: psad - Port Scan Attack Detector (psad) watches for suspect traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1382875 Fedora Update System changed: What|Removed |Added Status|NEW |ON_QA --- Comment #14 from Fedora Update System --- psad-2.4.3-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7eada51d4c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389091] Review Request: tang - Network Presence Binding Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1389091 Patrick Uiterwijk changed: What|Removed |Added Status|NEW |ASSIGNED CC||puiterw...@redhat.com Assignee|nob...@fedoraproject.org|puiterw...@redhat.com Flags||fedora-review? --- Comment #1 from Patrick Uiterwijk --- I'll do this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1381307] Review Request: perl-BibTeX-Parser - Pure Perl BibTeX parser
https://bugzilla.redhat.com/show_bug.cgi?id=1381307 --- Comment #6 from Fedora Update System --- perl-BibTeX-Parser-0.69-1.fc25, perl-LaTeX-ToUnicode-0.04-1.fc25, texlive-2016-17.20160520.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-50a2bc7997 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389091] New: Review Request: tang - Network Presence Binding Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1389091 Bug ID: 1389091 Summary: Review Request: tang - Network Presence Binding Daemon Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: npmccal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/npmccallum/tang/tang.git/plain/tang.spec?id=9f8aa97ab434efdbf3c0b931220febf14aba6085 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/npmccallum/tang/fedora-rawhide-x86_64/00469872-tang/tang-3-1.fc26.src.rpm Description: Network Presence Binding Daemon Fedora Account System Username: npmccallum -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1381303] Review Request: perl-LaTeX-ToUnicode - Convert LaTeX commands to Unicode
https://bugzilla.redhat.com/show_bug.cgi?id=1381303 --- Comment #6 from Fedora Update System --- perl-BibTeX-Parser-0.69-1.fc25, perl-LaTeX-ToUnicode-0.04-1.fc25, texlive-2016-17.20160520.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-50a2bc7997 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382935] Review Request: python-visitor - A tiny python visitor implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1382935 --- Comment #4 from Fedora Update System --- python-visitor-0.1.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-260a2acc98 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1197517] Review Request: elmon - Performance monitoring tool
https://bugzilla.redhat.com/show_bug.cgi?id=1197517 Fedora Update System changed: What|Removed |Added Status|POST|ON_QA --- Comment #17 from Fedora Update System --- elmon-13b1-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-808126209f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1388344] Review Request: javapoet - API for generating .java sources
https://bugzilla.redhat.com/show_bug.cgi?id=1388344 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #5 from Fedora Update System --- javapoet-1.7.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-97f387face -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1169926] Review Request: zram - Enable compressed swap in memory
https://bugzilla.redhat.com/show_bug.cgi?id=1169926 --- Comment #3 from Pavel Alexeev --- Version 1.0.1 Changes: https://github.com/Hubbitus/rpm-zram/commit/779559575e5a60312e19bb81ac6982438d0d7c70 Spec: https://github.com/Hubbitus/rpm-zram/blob/779559575e5a60312e19bb81ac6982438d0d7c70/zram.spec Srpm: http://rpm.hubbitus.info/epel7/zram/zram-1.0.1-1.git.f662370.el7.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379432] Review Request: odoo - Suite of web based open source business apps
https://bugzilla.redhat.com/show_bug.cgi?id=1379432 Alec Leamas changed: What|Removed |Added CC||leamas.a...@gmail.com Assignee|nob...@fedoraproject.org|leamas.a...@gmail.com --- Comment #4 from Alec Leamas --- Being the responsible for the predecessor (which should have been orphaned long time ago) this is my duty. WIll look into into it on a few days. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379432] Review Request: odoo - Suite of web based open source business apps
https://bugzilla.redhat.com/show_bug.cgi?id=1379432 --- Comment #3 from Björn "besser82" Esser --- Updated package: Dependencies have fully landed in fc25 and Rawhide. Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16211714 Urls: Spec URL: https://besser82.fedorapeople.org/review/odoo.spec SRPM URL: https://besser82.fedorapeople.org/review/odoo-10.0.20161026-0.1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382935] Review Request: python-visitor - A tiny python visitor implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1382935 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #3 from Fedora Update System --- python-visitor-0.1.3-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-29501c3376 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346060] Review Request: python-pintail-asciidoc - Use AsciiDoc pages in Pintail sites
https://bugzilla.redhat.com/show_bug.cgi?id=1346060 Julien Enselme changed: What|Removed |Added Flags|needinfo?(juj...@jujens.eu) | --- Comment #4 from Julien Enselme --- - The name of the SPEC must be python-pintail-asciidoc.spec - The name of the SRPM must be like ptyhon-pintail-asciidoc-0.3-1.20161022gitb391be8.fc24.src.rpm To achieve this, you need to change the Name to python-pintail-asciidoc and add a subpackage as describe in https://fedoraproject.org/wiki/Packaging:Python - I still get ImportError: No module named 'pintail.site' in mock. If I install locally on f24 I can import it. Could this be a problem in the rawhide version of pintail? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382926] Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1382926 --- Comment #2 from Ralf Corsepius --- Update: Spec URL: https://corsepiu.fedorapeople.org/packages/perl-HTTP-MultiPartParser.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-HTTP-MultiPartParser-0.01-2.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)
https://bugzilla.redhat.com/show_bug.cgi?id=1389016 --- Comment #3 from Dominik 'Rathann' Mierzejewski --- I was planning to package this, actually, so thanks for being here first! Please update to 1.5.1 which fixes a serious bug in 1.5: https://github.com/hfp/libxsmm/releases/tag/1.5.1 [...] fixed bug in the Fortran interface (SMM functionality), where requesting a JIT kernel never returned a suitable PROCEDURE POINTER (always NULL). I'll be happy to build cp2k with libxsmm support on x86_64 once this package approved. Please add me (FAS: rathann) to co-maintainers list if you don't mind. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)
https://bugzilla.redhat.com/show_bug.cgi?id=1389016 --- Comment #2 from Antonio Trande --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Default compiler flags are not honored. - doc sub-package does not provide any license. - libxsmm-debuginfo.x86_64: E: debuginfo-without-sources - libxsmm 1.5.1 is available - W: mixed-use-of-spaces-and-tabs - OMP support is disabled, but libs are linked to libgomp anyway. Can unused-direct-shlib-dependency warnings be silenced? = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 57 files have unknown license. Detailed output of licensecheck in /home/sagitter/1389016-libxsmm/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libxsmm- doc , libxsmm-debuginfo [ ]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Desc
[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)
https://bugzilla.redhat.com/show_bug.cgi?id=1389016 Antonio Trande changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? --- Comment #1 from Antonio Trande --- If you can 'numcosmo' is ready for reviewing: https://bugzilla.redhat.com/show_bug.cgi?id=1387927 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)
https://bugzilla.redhat.com/show_bug.cgi?id=1389016 Dave Love changed: What|Removed |Added Blocks||505154 (FE-SCITECH) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=505154 [Bug 505154] Tracker: Review Requests for Science and Technology related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 505154] Tracker: Review Requests for Science and Technology related packages
https://bugzilla.redhat.com/show_bug.cgi?id=505154 Dave Love changed: What|Removed |Added Depends On||1389016 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1389016 [Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1389016] New: Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)
https://bugzilla.redhat.com/show_bug.cgi?id=1389016 Bug ID: 1389016 Summary: Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: d.l...@liverpool.ac.uk QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://loveshack.fedorapeople.org/review/libxsmm.spec SRPM URL: https://loveshack.fedorapeople.org/review/libxsmm-1.5-4.el6.src.rpm Description: Library for small matrix-matrix multiplications targeting Intel Architecture (x86). The library generates code for the instruction set extensions Intel SSE3, Intel AVX, Intel AVX2, IMCI (KNCni) for Intel Xeon Phi coprocessors ("KNC"), and Intel AVX-512 as found in the Intel Xeon Phi processor family ("KNL") and future Intel Xeon processors. cp2k is the Fedora package for which this is currently relevant. Fedora Account System Username: loveshack See https://copr.fedorainfracloud.org/coprs/loveshack/livhpc/package/libxsmm/ for builds. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1381661] Review Request: obs-build - A generic package build script
https://bugzilla.redhat.com/show_bug.cgi?id=1381661 --- Comment #8 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/obs-build -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1388396] Review Request: python-pynlpl - A Python library for Natural Language Processing
https://bugzilla.redhat.com/show_bug.cgi?id=1388396 Dominika Krejčí changed: What|Removed |Added CC||dkre...@redhat.com Assignee|nob...@fedoraproject.org|dkre...@redhat.com Flags||fedora-review? --- Comment #3 from Dominika Krejčí --- Hi Iryna, there are my comments: * [!]: Requires correct, justified where necessary. Please be more specific in (Build)Requires and put python2-* instead of just python- wherever it is possible. Add python-numpy, it is listed in requires.txt in upstream. * Current Source0 creates folder named "v1.0.9.tar.gz", it should be rather "pynlpl-1.0.9.tar.gz" (add #/%{pkg_name}-%{version}.tar.gz to the current URL) ;) * [!]: License file installed when any subpackage combination is installed. Please add license to python-pynlpl-doc package. * You can use macro %{summary}, which will contain content of the Summary tag (it's generated automatically, you do not have to define it). Just keep the first Summary tag as it is and in python2/3- subpackages you can use `Summary: %{summary}`. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [!]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully
[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents
https://bugzilla.redhat.com/show_bug.cgi?id=1382937 --- Comment #5 from Dominika Krejčí --- Hi David, I noticed you do not run any test `Ran 0 tests in 0.000s`. You will probably need to add pytest to BuildRequires and use another command in the check section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1388945] New: Review Request: gnome-shell-extension-media-player-indicator - Control MPRIS2 capable media players : Rhythmbox, Banshee, Clementine and more
https://bugzilla.redhat.com/show_bug.cgi?id=1388945 Bug ID: 1388945 Summary: Review Request: gnome-shell-extension-media-player-indicator - Control MPRIS2 capable media players: Rhythmbox, Banshee, Clementine and more Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mgans...@alice.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/gnome-shell-extension-media-player-indicator.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/gnome-shell-extension-media-player-indicator-0.1-0.1.20161010gite2cc6d4.fc25.src.rpm Description: %description This GNOME Shell extension controls any MPRIS v2.1 capable media player. This extension will monitor D-Bus for active players and automatically display them in the GNOME Shell's volume menu by default. Fedora Account System Username: martinkg %changelog * Wed Oct 26 2016 Martin Gansser - 0.1-0.1.20161010gite2cc6d4 - initial build for Fedora rpmlint -i /home/martin/rpmbuild/SRPMS/gnome-shell-extension-media-player-indicator-0.1-0.1.20161010gite2cc6d4.fc25.src.rpm /home/martin/rpmbuild/RPMS/noarch/gnome-shell-extension-media-player-indicator-0.1-0.1.20161010gite2cc6d4.fc25.noarch.rpm gnome-shell-extension-media-player-indicator.src: W: spelling-error Summary(en_US) Rhythmbox -> Rhythm box, Rhythm-box, Biorhythm The value of this tag appears to be misspelled. Please double-check. gnome-shell-extension-media-player-indicator.noarch: W: spelling-error Summary(en_US) Rhythmbox -> Rhythm box, Rhythm-box, Biorhythm The value of this tag appears to be misspelled. Please double-check. 2 packages and 0 specfiles checked; 0 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382926] Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1382926 --- Comment #1 from Petr Pisar --- URL and Source0 addresses are usable. Ok. Source archive (SHA-256: f834cf093b16d4ba813ccd8e72c44b759e50a23726bb50004da2b7a3cca5a0aa) is original. Ok. Summary verified from lib/HTTP/MultiPartParser.pod. Ok. Description verified from lib/HTTP/MultiPartParser.pod. Ok. License verified from README, lib/HTTP/MultiPartParser.pod. Ok. inc/Module/Install/Can.pm contains XS code but is not used, noarch BuildArch is Ok. FIX: Build-requires `make' (perl-HTTP-MultiPartParser.spec:32). FIX: Build-require `perl(Cwd)' (t/030_basic.t:11). FIX: Build-require `perl(Data::Dumper)' (t/lib/PAML.pm:8). FIX: Build-require `perl(Exporter)' (t/lib/PAML.pm:17). FIX: Build-require `perl(FindBin)' (t/030_basic.t:6). FIX: Build-require `perl(IO::File)' (t/lib/PAML.pm:9). FIX: Build-require `perl(lib)' (t/030_basic.t:7). FIX: Build-require `perl(vars)' (t/035_headers.t:28). FIX: Either unbundle the ./inc files and build-require the Module::Install* modules whose functions are called from Makefile.PL or build-require dependencies of the bundled code (`perl(File::Find)' in inc/Module/Install.pm:23, `perl(File::Path)' im inc/Module/Install.pm:24 etc.). TODO: Package eg/example.pl as a documentation. All tests pass. Ok. $ rpmlint perl-HTTP-MultiPartParser.spec ../SRPMS/perl-HTTP-MultiPartParser-0.01-1.fc26.src.rpm ../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-1.fc26.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p ../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-1.fc26.noarch.rpm drwxr-xr-x2 rootroot0 Oct 26 15:08 /usr/share/doc/perl-HTTP-MultiPartParser -rw-r--r--1 rootroot 42 Oct 23 2013 /usr/share/doc/perl-HTTP-MultiPartParser/Changes -rw-r--r--1 rootroot 4260 Oct 23 2013 /usr/share/doc/perl-HTTP-MultiPartParser/README -rw-r--r--1 rootroot 2937 Oct 26 15:08 /usr/share/man/man3/HTTP::MultiPartParser.3pm.gz drwxr-xr-x2 rootroot0 Oct 26 15:08 /usr/share/perl5/vendor_perl/HTTP -rw-r--r--1 rootroot 8285 Oct 22 2013 /usr/share/perl5/vendor_perl/HTTP/MultiPartParser.pm -rw-r--r--1 rootroot 4064 Oct 23 2013 /usr/share/perl5/vendor_perl/HTTP/MultiPartParser.pod File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Carp) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(HTTP::MultiPartParser) = 0.01 1 perl-HTTP-MultiPartParser = 0.01-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=16208042). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' items, consider fixing `TODO' items, and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382926] Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1382926 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1387626] Review Request: perl-Term-Chrome - DSL for colors and other terminal chrome
https://bugzilla.redhat.com/show_bug.cgi?id=1387626 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Term-Chrome-2.00-1.fc2 ||6 Resolution|--- |RAWHIDE Last Closed||2016-10-26 08:35:46 --- Comment #3 from Petr Pisar --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1388908] New: Review Request: python-Flask-Bootstrap - Python flask bootstrap
https://bugzilla.redhat.com/show_bug.cgi?id=1388908 Bug ID: 1388908 Summary: Review Request: python-Flask-Bootstrap - Python flask bootstrap Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: david.hanneq...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-Bootstrap/python-Flask-Bootstrap.spec SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-Bootstrap/python-Flask-Bootstrap-3.3.7.0-1.fc24.src.rpm Description: FlaskBootstrap packages Bootstrap into an extension that mostly consists of a blueprint named 'bootstrap'. It can also create links to serve Bootstrap from a CDN and works with no boilerplate code in your application Fedora Account System Username: hvad -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1387626] Review Request: perl-Term-Chrome - DSL for colors and other terminal chrome
https://bugzilla.redhat.com/show_bug.cgi?id=1387626 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Term-Chrome -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1388344] Review Request: javapoet - API for generating .java sources
https://bugzilla.redhat.com/show_bug.cgi?id=1388344 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/javapoet -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1387626] Review Request: perl-Term-Chrome - DSL for colors and other terminal chrome
https://bugzilla.redhat.com/show_bug.cgi?id=1387626 Jitka Plesnikova changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-Term-Chrome-2.00-1.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Carp) 1 perl(Exporter) >= 5.57 1 perl(Scalar::Util) 1 perl(constant) 1 perl(overload) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-Term-Chrome-2.00-1.fc26.noarch.rpm | sort | uniq -c 1 perl(Term::Chrome) = 2.00 1 perl-Term-Chrome = 2.00-1.fc26 Binary provides are Ok. $ rpmlint ./perl-Term-Chrome* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok The package is good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1197517] Review Request: elmon - Performance monitoring tool
https://bugzilla.redhat.com/show_bug.cgi?id=1197517 --- Comment #15 from Pavel Alexeev --- I'll drop BR GCC. Meantime: > - The %make_build macro is available mostly but not recommended. Maybe use 'make %{?_smp_mflags}' instead that works in all distributions. That macro recommended in https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25build_section -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1197517] Review Request: elmon - Performance monitoring tool
https://bugzilla.redhat.com/show_bug.cgi?id=1197517 --- Comment #16 from Pavel Alexeev --- And thank you Jon Ciesla. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1387626] Review Request: perl-Term-Chrome - DSL for colors and other terminal chrome
https://bugzilla.redhat.com/show_bug.cgi?id=1387626 Jitka Plesnikova changed: What|Removed |Added Status|NEW |ASSIGNED CC||jples...@redhat.com Assignee|nob...@fedoraproject.org|jples...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1387634] Review Request: perl-Devel-Gladiator - Walk Perl's arena
https://bugzilla.redhat.com/show_bug.cgi?id=1387634 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Devel-Gladiator-0.07-1 ||.fc26 Resolution|--- |RAWHIDE Last Closed||2016-10-26 04:59:08 --- Comment #3 from Petr Pisar --- Thank you for the review and the repository. I added the dependency on findutils. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1387626] Review Request: perl-Term-Chrome - DSL for colors and other terminal chrome
https://bugzilla.redhat.com/show_bug.cgi?id=1387626 Bug 1387626 depends on bug 1387619, which changed state. Bug 1387619 Summary: Review Request: perl-Test-Is - Skip test in a declarative way https://bugzilla.redhat.com/show_bug.cgi?id=1387619 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1387619] Review Request: perl-Test-Is - Skip test in a declarative way
https://bugzilla.redhat.com/show_bug.cgi?id=1387619 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Test-Is-20140823.1-1.f ||c26 Resolution|--- |RAWHIDE Last Closed||2016-10-26 04:51:59 --- Comment #3 from Petr Pisar --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1387604] Review Request: perl-Filter-Encoding - Write your script in any encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1387604 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Filter-Encoding-0.01-1 ||.fc26 Resolution|--- |RAWHIDE Last Closed||2016-10-26 04:45:45 --- Comment #3 from Petr Pisar --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.
https://bugzilla.redhat.com/show_bug.cgi?id=480727 Piotr Dobrogost changed: What|Removed |Added CC||p...@fedora.dobrogost.net --- Comment #46 from Piotr Dobrogost --- I understand that some/most part of daemontools package is not needed on modern system but what about small utility programs like envdir included in this package? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1381661] Review Request: obs-build - A generic package build script
https://bugzilla.redhat.com/show_bug.cgi?id=1381661 Miroslav Suchý changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Miroslav Suchý --- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org