[Bug 1421142] Review Request: perl-RDF-RDFa-Generator - Generate data in RDFa

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421142

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-RDF-RDFa-Generator-0.1
   ||03-1.fc26
 Resolution|--- |RAWHIDE
Last Closed||2017-02-14 02:36:16



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409288] Review Request: rubygem-clutter-gdk - Ruby binding of GDK specific API of Clutter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409288

Mamoru TASAKA  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-02-14 02:11:09



--- Comment #4 from Mamoru TASAKA  ---
This is already in repository, closing.

Thank you for review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409355] Review Request: rubygem-tk - Tk interface module using tcltklib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409355



--- Comment #3 from Mamoru TASAKA  ---
Hello, again sorry for long delay...

(In reply to František Dvořák from comment #1)
> It looks like, there is a problem with stability. I've tested:
> /usr/share/gems/gems/tk-0.1.1/sample/demos-en/widget dialog2
> And there are two problems:
> 
> 1) Occasionally there is a cryptic error message:
> 
>   invalid command name ".w00010.msg"
> 
> This message occurs also on F25 (with both: ruby-tcltk package, or
> recompiled rubygem-tk), so this is already existing problem (not a
> show-stopper for upgrade from ruby-tcltk).

Currently I don't see this issue (yet?)


> 2) When closing the demo window, ruby crashes.
> 
> Ruby won't crash in F25, so this is a new problem with F26.
> 
> I'm not sure, what to do with the second problem. Continue with packaging
> and report upstream? It is possible it is only bug in the demo code? (there
> are used threads, ...).

Will try on F-26, however currently I think this is ruby issue (perhaps), may
be bug 1417590 : GC issue with gcc7, hopefully fixed in ruby-2.4.0-76.fc26


> Now the packaging itself, the easier part: :-)
> 
> 3) the modification of gem.build_complete
> 
> It is interesting way, how to solve the rpmlint error. But the real fix
> probably belongs to the rpmlint. Maybe it could be better to know about it
> in the bodhi tests (and keep the error)?
> 
> Another way (without the real fix though) could be to use ".rpmlint" config
> file in the fedora git package sources.

Well, as you know this is just to suppress rpmlint error (if reviewer does not
like rpmlint error). If you are okay, I can just make gem.build.complete
unmodified (i.e. just empty).


> 4) gcc dependency is not needed
Unfortunately now this is MUST :(
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires

> 5) it could be safer to replace '/usr/local' and '/usr/bin/env ruby' only in
> 'sample' subdirectory (just a hint to consider, checking everything is
> probably fine and desired?)

Because rpmlint warns these :( (Well, anyway we don't support /usr/local so I
think this is okay)

> 6) missing the "Provides: ruby-tcltk"
> 
> There is comment about it, so it is probably OK a there is reason for it
> (not full functionality provided by 'tk' gem?). I've noticed there is still
> a TCL part available - at least the variable Tk::TCL_VERSION.

The reason for this is that while I think (believe) ruby-tcltk functionality is
fully provided by rubygem-tk, I am not sure at a moment.

Let me know it if you think it is better to modify. Again sorry for long
delay...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421346] Review Request: extracturl - perl script for url extraction

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421346

klaatu  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421914] New: Review Request: js-responsive-elements - A library that helps element to adapt and respond to the area they occupy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421914

Bug ID: 1421914
   Summary: Review Request: js-responsive-elements - A library
that helps element to adapt and respond to the area
they occupy
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ra...@electronsweatshop.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://bowlofeggs.fedorapeople.org/js-responsive-elements.spec
SRPM URL:
https://bowlofeggs.fedorapeople.org/js-responsive-elements-1.0.2-1.fc26.src.rpm
Description: Responsive elements makes it possible for any element to adapt and
respond to the area they occupy. It's a tiny JavaScript library that you
can drop into your projects today.
Fedora Account System Username: bowlofeggs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #25 from Fedora Update System  ---
libslz-1.1.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-62625ee2aa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411166] Review Request: js-jquery-knob - Nice, downward compatible, touchable, jQuery dial

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411166



--- Comment #6 from Fedora Update System  ---
js-jquery-knob-1.2.13-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-81e2d68733

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386563] Review Request: python-ruamel-yaml - YAML 1.2 loader/ dumper package for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386563

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #19 from Fedora Update System  ---
python-ruamel-yaml-0.13.13-3.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b6e6e0d463

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420605] Review Request: nodejs-grunt-wrap - A Grunt plugin for wrapping project text files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420605



--- Comment #7 from Fedora Update System  ---
nodejs-grunt-wrap-0.3.0-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c95b33872d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415410] Review Request: js-jquery-mousewheel - A jQuery plugin that adds cross-browser mouse wheel support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415410



--- Comment #6 from Fedora Update System  ---
js-jquery-mousewheel-3.1.13-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-67486793eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411157] Review Request: js-tag-it - A jQuery UI plugin handling multi-tag fields and suggestions/ autocomplete

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411157



--- Comment #6 from Fedora Update System  ---
js-tag-it-2.0-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1d21546291

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411195] Review Request: js-jquery-iframe-transport - A jQuery Ajax transport plugin for iframe-based file uploads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411195



--- Comment #7 from Fedora Update System  ---
js-jquery-iframe-transport-1.0.1-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d164ae3332

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #24 from Fedora Update System  ---
libslz-1.1.0-2.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a02e36c349

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418426] Review Request: js-php-date-formatter - A JS date-time formatting/ manipulation library using PHP date-time formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418426



--- Comment #6 from Fedora Update System  ---
js-php-date-formatter-1.3.4-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f937b3381d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420153] Review Request: js-jquery-jstree - A jQuery tree plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420153



--- Comment #7 from Fedora Update System  ---
js-jquery-jstree-3.3.3-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-91afd0dfdf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413434] Review Request: php-gettext-languages - Generate gettext language lists with plural rules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413434



--- Comment #14 from Fedora Update System  ---
php-gettext-languages-2.1.3-4.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-46016c3a74

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379174



--- Comment #9 from Fedora Update System  ---
vmod-querystring-1.0.1-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b4b39da465

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421406] Review Request: python-libtmux - Scripting library for tmux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421406

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
python-libtmux-0.6.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b8db93ec64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412801] Review Request: python-networkmanager - Easy communication with NetworkManager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412801



--- Comment #14 from Fedora Update System  ---
python-networkmanager-1.2.1-7.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-79ea18d53b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #14 from Miro Hrončok  ---
(In reply to Thomas Spura from comment #11)
> > If the above is true but the notebook module is to be imported form other
> > packages, then keep the package split, but just include the executable in
> > the Python 3 subpackage.
> > 
> > Guidelines:
> > 
> > If the executables provide the same functionality independent of whether
> > they are run on top of Python 2 or Python 3, then only the Python 3 version
> > of the executable should be packaged. Transitioning from python2 to python3
> > is left to individual package maintainers except for packages in Fedora's
> > critical path. For these, we want to port to python3 versions in the same
> > Fedora release if possible.
> 
> I removed the executable from the python2-notebook.

Thanks. In that case, I think the mv + ln section in %install is not necessary
and providing only the unversioned executables is enough.

More importantly, running %py2_install after %py3_install is overwriting the
executables with the py2 version.

$ LANG=C.utf-8 rpm -qlvp python3-notebook-4.4.1-1.fc26.noarch.rpm | grep bin
-rwxr-xr-x 1 root root 101 Feb 14 01:01 /usr/bin/jupyter-nbextension
lrwxrwxrwx 1 root root  23 Feb 14 01:01 /usr/bin/jupyter-nbextension-3 ->
jupyter-nbextension-3.6
-rwxr-xr-x 1 root root 101 Feb 14 01:01 /usr/bin/jupyter-nbextension-3.6
-rwxr-xr-x 1 root root 100 Feb 14 01:01 /usr/bin/jupyter-notebook
lrwxrwxrwx 1 root root  20 Feb 14 01:01 /usr/bin/jupyter-notebook-3 ->
jupyter-notebook-3.6
-rwxr-xr-x 1 root root 100 Feb 14 01:01 /usr/bin/jupyter-notebook-3.6
-rwxr-xr-x 1 root root 105 Feb 14 01:01 /usr/bin/jupyter-serverextension
lrwxrwxrwx 1 root root  27 Feb 14 01:01 /usr/bin/jupyter-serverextension-3 ->
jupyter-serverextension-3.6
-rwxr-xr-x 1 root root 105 Feb 14 01:01 /usr/bin/jupyter-serverextension-3.6

$ rpm -qp --requires python3-notebook-4.4.1-1.fc26.noarch.rpm | grep bin
/usr/bin/python2
/usr/bin/python3

$ head -n1 usr/bin/jupyter-notebook
#!/usr/bin/python2 -s

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411166] Review Request: js-jquery-knob - Nice, downward compatible, touchable, jQuery dial

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411166

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
js-jquery-knob-1.2.13-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d91061fd3e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411195] Review Request: js-jquery-iframe-transport - A jQuery Ajax transport plugin for iframe-based file uploads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411195

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
js-jquery-iframe-transport-1.0.1-1.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-83eb5c922c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411157] Review Request: js-tag-it - A jQuery UI plugin handling multi-tag fields and suggestions/ autocomplete

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411157

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
js-tag-it-2.0-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-65c3c63231

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420605] Review Request: nodejs-grunt-wrap - A Grunt plugin for wrapping project text files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420605

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
nodejs-grunt-wrap-0.3.0-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b304ee57e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415410] Review Request: js-jquery-mousewheel - A jQuery plugin that adds cross-browser mouse wheel support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415410

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
js-jquery-mousewheel-3.1.13-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3c8a8f3c00

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418426] Review Request: js-php-date-formatter - A JS date-time formatting/ manipulation library using PHP date-time formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418426

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
js-php-date-formatter-1.3.4-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e99dbbc6ff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420153] Review Request: js-jquery-jstree - A jQuery tree plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420153

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
js-jquery-jstree-3.3.3-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b5ba680299

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379174

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
vmod-querystring-1.0.1-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-75ddb4ed26

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #23 from Fedora Update System  ---
libslz-1.1.0-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fdeb7cb901

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413434] Review Request: php-gettext-languages - Generate gettext language lists with plural rules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413434

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
php-gettext-languages-2.1.3-4.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-aca77236c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409363] Review Request: llvm3.9 - Versioned LLVM 3.9

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409363



--- Comment #25 from Orion Poplawski  ---
My updated install_dirs.patch doesn't quite work with your current -2 llvm
package.  I get:

CMake Error at /usr/lib64/cmake/llvm3.9/LLVMConfig.cmake:165 (include):
  include could not find load file:

/usr//usr/lib64/cmake/llvm3.9/LLVMExports.cmake

because LLVM_INSTALL_PACKAGE_DIR is being specified as a complete path and the
LLVMConfig.cmake file doesn't support that.

-DLLVM_INSTALL_PACKAGE_DIR=%{_libdir}/cmake/%{name} \

But I don't think that should be too hard to fix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411467] Review Request: bitlbee-steam - Steam protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411467

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
bitlbee-steam-1.4.2-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-bcc2712ec1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #22 from Fedora Update System  ---
libslz-1.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-ba2ede3701

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412801] Review Request: python-networkmanager - Easy communication with NetworkManager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412801

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
python-networkmanager-1.2.1-7.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9e514f6254

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409363] Review Request: llvm3.9 - Versioned LLVM 3.9

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409363



--- Comment #24 from Orion Poplawski  ---
Here's my current version:

https://www.cora.nwra.com/~orion/fedora/llvm3.9.spec
https://www.cora.nwra.com/~orion/fedora/llvm3.9-3.9.1-4.el7.src.rpm

* Fri Feb 10 2017 Orion Poplawski  - 3.9.1-4
- Add patch to add sonames to libraries
- Make -static require ncurses-devel

* Thu Feb 9 2017 Orion Poplawski  - 3.9.1-3
- Install into libdir prefix

This sets a SOVERSION for libraries, and by extension for clang since it uses
llvm's cmake macros.  This prevents the versioned llvm or clang from loading
the wrong libraries.

This also updates the install_dirs.patch to allow clang to be able to do
find_package(LLVM).

I'm doing some builds locally and at
https://copr.fedorainfracloud.org/coprs/orion/llvm_versioned/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418006] Review Request: perl-Test-Abortable - Simple system for handling some exceptions in tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418006
Bug 1418006 depends on bug 1417984, which changed state.

Bug 1417984 Summary: Review Request: perl-failures - Minimalist exception 
hierarchy generator
https://bugzilla.redhat.com/show_bug.cgi?id=1417984

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385534] Review Request: python-ruamel-ordereddict - Ordered dictionary with Key Insertion Order

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385534



--- Comment #9 from Fedora Update System  ---
python-ruamel-ordereddict-0.4.9-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368157] Review Request: python-pika-pool - Pools for pikas ( rename of python-pika_pool)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368157

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-02-13 17:22:06



--- Comment #11 from Fedora Update System  ---
python-pika-pool-0.1.3-6.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1417984] Review Request: perl-failures - Minimalist exception hierarchy generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1417984

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-02-13 17:22:09



--- Comment #9 from Fedora Update System  ---
perl-failures-0.004-2.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419032] Review Request: mingw-jimtcl - MinGW small embeddable Tcl interpreter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419032

Kees de Jong  changed:

   What|Removed |Added

 CC||keesdejong+b...@gmail.com



--- Comment #2 from Kees de Jong  ---
I'm trying to gain some reputation to get my own package sponsored, so I will
give it a go ahead to review yours. If you want you could give my much simpler
package a review in return [1], if you don't see any improvements, then please
leave a comment that you approve the package.

According to the Fedora package documentation, the BuildRoot should be left
untouched [2].

Another remark, the use of %defattr is no longer necessary unless the
permissions need to be altered [3].

The group tag is deprecated [2].

Please also note that %clean section is redundant [2], unless you also build
for EPEL. If not then the %clean section with the 'rm -rf $RPM_BUILD_ROOT'
could be left out. The 'rm -rf $RPM_BUILD_ROOT' in the %install could probably
also be left out?

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1411984
[2]
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview
[3] https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_basics

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419032] Review Request: mingw-jimtcl - MinGW small embeddable Tcl interpreter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419032



--- Comment #3 from Kees de Jong  ---
Also make sure you preserve the time stamps in the %install section with
install commands (-p switch).
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421858] Review Request: flannel-container - system container for flannel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421858

Yu Qi Zhang  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421858] New: Review Request: flannel-container - system container for flannel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421858

Bug ID: 1421858
   Summary: Review Request: flannel-container - system container
for flannel
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jzehrar...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Dockerfile URL:
https://github.com/projectatomic/atomic-system-containers/blob/master/flannel/Dockerfile

Source:
https://github.com/projectatomic/atomic-system-containers/tree/master/flannel

Description: 
flannel is an etcd driven virtual network that gives a subnet to each host for
use with container runtimes. This package is intended to be ran as a system
container.

More information on system containers here:
http://www.projectatomic.io/blog/2016/09/intro-to-system-containers/
A quick guide:
https://github.com/yuqi-zhang/atomic-system-containers-quickstart

Fedora Account System Username: yzhang

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421856] Review Request: etcd-container - system container for etcd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421856

Yu Qi Zhang  changed:

   What|Removed |Added

Version|rawhide |25
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415634] Review Request: python-murano-pkg-check - Murano package validator tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415634

Randy Barlow  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Randy Barlow  ---
I recommend adding versions to the Provides bundled() statements, but I don't
think that's required to approve.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
 generated", "*No copyright* Apache (v2.0)". 32 files have unknown
 license. Detailed output of licensecheck in
 /home/rbarlow/reviews/1415634-python-murano-pkg-check/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
 randy: bundled js libraries are declared.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python2-murano-pkg-check (description), python3
 -murano-pkg-check (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
 -murano-pkg-check , python-murano-pkg-check-doc , 

[Bug 1421856] New: Review Request: etcd-container - system container for etcd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421856

Bug ID: 1421856
   Summary: Review Request: etcd-container - system container for
etcd
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jzehrar...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Dockerfile URL:
https://github.com/projectatomic/atomic-system-containers/blob/master/etcd/Dockerfile

Source:
https://github.com/projectatomic/atomic-system-containers/tree/master/etcd

Description: 
etcd is a key-value store for shared configuration and service discovery. This
package is intended to be ran as a system container.

More information on system containers here:
http://www.projectatomic.io/blog/2016/09/intro-to-system-containers/
A quick guide:
https://github.com/yuqi-zhang/atomic-system-containers-quickstart

Fedora Account System Username: yzhang

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421851] Review Request: asdcplib - AS-DCP File Access Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421851



--- Comment #1 from Nicolas Chauvet (kwizart)  ---
Seems like there is another stalled review: rhbz#1096138
Currently waiting for reporter.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #13 from Thomas Spura  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #12)
> Links give 404.

Sorry. It should work now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1096138] Review Request: asdcplib - AS-DCP file access library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1096138

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 CC||i...@cicku.me,
   ||kwiz...@gmail.com
  Flags||needinfo?(i...@cicku.me)



--- Comment #5 from Nicolas Chauvet (kwizart)  ---
@christopher
This review has stalled I've submitted another one at #1421851
Your review URL currently lead to 404 errors, can you please re-upload your
spec and src.rpm or would you mind closing this review ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421851] New: Review Request: asdcplib - AS-DCP File Access Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421851

Bug ID: 1421851
   Summary: Review Request: asdcplib - AS-DCP File Access Library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: kwiz...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://dl.kwizart.net/review/asdcplib.spec
SRPM URL: http://dl.kwizart.net/review/asdcplib-2.7.19-1.fc24.src.rpm
Description: AS-DCP File Access Library
Fedora Account System Username: kwizart

Koji scratch build:
It's currently only building on x86_64 up to f24
https://koji.fedoraproject.org/koji/taskinfo?taskID=17846025

rpmlint , missing man pages on utils.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1417646] Review Request: mingw-wxWidgets3 - MinGW port of the wxWidgets GUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1417646



--- Comment #8 from Thomas Sailer  ---
3.0.2 builds, see the copr repo sailer/mingw

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403600



--- Comment #16 from Luya Tshimbalanga  ---
In reply to Simone Caronni from comment #8)
> Sorry, now that you implemented the conditionals for setting source urls
> with conditionals you might want to do the same for the release tag so it
> avoids the date and the "git" word if it's a snapshot:
> 
> %date 20170212
> 
> Release:16%{?date:.%{date}git}%{?dist}

Thanks for the tip.

Here is the updated files with all fixes

Spec URL: https://luya.fedorapeople.org/packages/SPECS/YafaRay.spec 
SRPMS URL:
https://luya.fedorapeople.org/packages/SRPMS/YafaRay-3.2.0-0.3.20170212git.fc25.src.rpm

Presets from blender add-on is temporarily disabled resulting a successful
build and I filed the issue upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409363] Review Request: llvm3.9 - Versioned LLVM 3.9

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409363



--- Comment #23 from Orion Poplawski  ---
It's really not that different from how we handle MPI packages:
http://fedoraproject.org/wiki/Packaging:MPI

What would really be good to do is to have clang's CMakeLists.txt do:

find_package(LLVM 3.9 REQUIRED)
list(APPEND CMAKE_MODULE_PATH "${LLVM_CMAKE_DIR}")

but this will require more fixes to LLVMConfig.cmake.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421081] Review Request: perl-Code-TidyAll-Plugin-Test-Vars - Provides Test::Vars plugin for Code: :TidyAll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421081



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Code-TidyAll-Plugin-Test-Vars

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411166] Review Request: js-jquery-knob - Nice, downward compatible, touchable, jQuery dial

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411166



--- Comment #3 from Fedora Update System  ---
js-jquery-knob-1.2.13-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-81e2d68733

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411166] Review Request: js-jquery-knob - Nice, downward compatible, touchable, jQuery dial

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411166



--- Comment #4 from Fedora Update System  ---
js-jquery-knob-1.2.13-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d91061fd3e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411166] Review Request: js-jquery-knob - Nice, downward compatible, touchable, jQuery dial

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411166

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411166] Review Request: js-jquery-knob - Nice, downward compatible, touchable, jQuery dial

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411166

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||js-jquery-knob-1.2.13-2.fc2
   ||6



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386563] Review Request: python-ruamel-yaml - YAML 1.2 loader/ dumper package for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386563

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411157] Review Request: js-tag-it - A jQuery UI plugin handling multi-tag fields and suggestions/ autocomplete

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411157



--- Comment #3 from Fedora Update System  ---
js-tag-it-2.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-65c3c63231

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411157] Review Request: js-tag-it - A jQuery UI plugin handling multi-tag fields and suggestions/ autocomplete

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411157



--- Comment #4 from Fedora Update System  ---
js-tag-it-2.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1d21546291

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411157] Review Request: js-tag-it - A jQuery UI plugin handling multi-tag fields and suggestions/ autocomplete

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411157

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386563] Review Request: python-ruamel-yaml - YAML 1.2 loader/ dumper package for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386563



--- Comment #18 from Fedora Update System  ---
python-ruamel-yaml-0.13.13-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b6e6e0d463

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411157] Review Request: js-tag-it - A jQuery UI plugin handling multi-tag fields and suggestions/ autocomplete

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411157

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||js-tag-it-2.0-1.fc26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411195] Review Request: js-jquery-iframe-transport - A jQuery Ajax transport plugin for iframe-based file uploads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411195

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411195] Review Request: js-jquery-iframe-transport - A jQuery Ajax transport plugin for iframe-based file uploads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411195



--- Comment #5 from Fedora Update System  ---
js-jquery-iframe-transport-1.0.1-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-83eb5c922c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411195] Review Request: js-jquery-iframe-transport - A jQuery Ajax transport plugin for iframe-based file uploads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411195



--- Comment #4 from Fedora Update System  ---
js-jquery-iframe-transport-1.0.1-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d164ae3332

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411195] Review Request: js-jquery-iframe-transport - A jQuery Ajax transport plugin for iframe-based file uploads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411195

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||js-jquery-iframe-transport-
   ||1.0.1-1.fc26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420605] Review Request: nodejs-grunt-wrap - A Grunt plugin for wrapping project text files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420605



--- Comment #4 from Fedora Update System  ---
nodejs-grunt-wrap-0.3.0-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b304ee57e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420605] Review Request: nodejs-grunt-wrap - A Grunt plugin for wrapping project text files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420605



--- Comment #5 from Fedora Update System  ---
nodejs-grunt-wrap-0.3.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c95b33872d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420605] Review Request: nodejs-grunt-wrap - A Grunt plugin for wrapping project text files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420605

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420605] Review Request: nodejs-grunt-wrap - A Grunt plugin for wrapping project text files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420605

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||nodejs-grunt-wrap-0.3.0-2.f
   ||c26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415410] Review Request: js-jquery-mousewheel - A jQuery plugin that adds cross-browser mouse wheel support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415410



--- Comment #4 from Fedora Update System  ---
js-jquery-mousewheel-3.1.13-1.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3c8a8f3c00

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415410] Review Request: js-jquery-mousewheel - A jQuery plugin that adds cross-browser mouse wheel support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415410



--- Comment #3 from Fedora Update System  ---
js-jquery-mousewheel-3.1.13-1.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-67486793eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415410] Review Request: js-jquery-mousewheel - A jQuery plugin that adds cross-browser mouse wheel support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415410

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415410] Review Request: js-jquery-mousewheel - A jQuery plugin that adds cross-browser mouse wheel support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415410

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||js-jquery-mousewheel-3.1.13
   ||-1.fc26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411195] Review Request: js-jquery-iframe-transport - A jQuery Ajax transport plugin for iframe-based file uploads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411195



--- Comment #3 from Randy Barlow  ---
I sent a pull request upstream to correct the package.json version:

https://github.com/cmlenz/jquery-iframe-transport/pull/47

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418426] Review Request: js-php-date-formatter - A JS date-time formatting/ manipulation library using PHP date-time formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418426



--- Comment #4 from Fedora Update System  ---
js-php-date-formatter-1.3.4-1.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f937b3381d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418426] Review Request: js-php-date-formatter - A JS date-time formatting/ manipulation library using PHP date-time formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418426

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418426] Review Request: js-php-date-formatter - A JS date-time formatting/ manipulation library using PHP date-time formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418426



--- Comment #3 from Fedora Update System  ---
js-php-date-formatter-1.3.4-1.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e99dbbc6ff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420605] Review Request: nodejs-grunt-wrap - A Grunt plugin for wrapping project text files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420605



--- Comment #3 from Randy Barlow  ---
I fixed the /usr/bin/env node as you suggested, but the added test you
suggested doesn't appear to work:

https://kojipkgs.fedoraproject.org//work/tasks/3040/17843040/build.log

I had attempted this when writing the spec file and hit that issue, but the
package's own tests pass and it also does work when used. Thus, I determined
that this check test wasn't needed. What do you think?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #21 from Fedora Update System  ---
libslz-1.1.0-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-ba2ede3701

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418426] Review Request: js-php-date-formatter - A JS date-time formatting/ manipulation library using PHP date-time formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418426

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||js-php-date-formatter-1.3.4
   ||-1.fc26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #20 from Fedora Update System  ---
libslz-1.1.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a02e36c349

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #19 from Fedora Update System  ---
libslz-1.1.0-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-62625ee2aa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #18 from Fedora Update System  ---
libslz-1.1.0-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fdeb7cb901

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421081] Review Request: perl-Code-TidyAll-Plugin-Test-Vars - Provides Test::Vars plugin for Code: :TidyAll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421081

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --provides perl-Code-TidyAll-Plugin-Test-Vars-0.04-1.fc26.noarch.rpm
| sort | uniq -c
  1 perl(Code::TidyAll::Plugin::Test::Vars) = 0.04
  1 perl-Code-TidyAll-Plugin-Test-Vars = 0.04-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Code-TidyAll-Plugin-Test-Vars*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

$ rpm -qp --requires perl-Code-TidyAll-Plugin-Test-Vars-0.04-1.fc26.noarch.rpm
| sort | uniq -c
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(Code::TidyAll) >= 0.50
  1 perl(Moo)
  1 perl(PPI::Document)
  1 perl(Path::Tiny)
  1 perl(Test::Vars) >= 0.008
  1 perl(autodie)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Please add missing run-require perl(Code::TidyAll::Plugin)
 
Code-TidyAll-Plugin-Test-Vars-0.04/lib/Code/TidyAll/Plugin/Test/Vars.pm:17

 Moo 'extends' keyword is not recognize by perl-generators (similar to
BZ#742478)

BuildRequires:
FIX: Please remove duplicity 'perl(strict)' from build-requires.
FIX: Please add the version restriction for perl(ExtUtils::MakeMaker) to
 6.76 or higher, because NO_PACKLIST option was added in this version.


Please correct all 'FIX' issues before commit.

Otherwise the package is good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420153] Review Request: js-jquery-jstree - A jQuery tree plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420153



--- Comment #5 from Fedora Update System  ---
js-jquery-jstree-3.3.3-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b5ba680299

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420153] Review Request: js-jquery-jstree - A jQuery tree plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420153

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420153] Review Request: js-jquery-jstree - A jQuery tree plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420153



--- Comment #4 from Fedora Update System  ---
js-jquery-jstree-3.3.3-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-91afd0dfdf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420153] Review Request: js-jquery-jstree - A jQuery tree plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420153

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||js-jquery-jstree-3.3.3-1.fc
   ||26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #12 from Zbigniew Jędrzejewski-Szmek  ---
Links give 404.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421081] Review Request: perl-Code-TidyAll-Plugin-Test-Vars - Provides Test::Vars plugin for Code: :TidyAll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421081

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419226] Review Request: prelude-correlator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419226

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
So now there's a circular dependency, between the main package and the python3
subpackage. That's a bit unusual, but OTOH, it doesn't cause any real issues.

+ package name is OK
+ license is acceptable for Fedora (GPLv2+)
+ license is specified correctly
+ provides and requires are OK
+ scriptlets are OK
+ builds and installs OK

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421245] Review Request: libcrush - C library to control placement in a hierarchy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421245

Kees de Jong  changed:

   What|Removed |Added

 CC||keesdejong+b...@gmail.com



--- Comment #2 from Kees de Jong  ---
I'm trying to gain some reputation to get my own package sponsored, so I will
give it a go ahead to review yours. If you want you could give my much simpler
package a review in return [1], if you don't see any improvements, then please
leave a comment that you approve the package.

According to the Fedora package documentation, the BuildRoot should be left
untouched [2].

Another remark, the use of %defattr is no longer necessary unless the
permissions need to be altered [3].

Your changelog is empty, you could bump it with `rpmdev-bumpspec -c 'this is my
first package'`.

The release tag should be like '1%{?dist}' [2]. The group tag is deprecated
[2].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1411984
[2]
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview
[3] https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_basics

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415634] Review Request: python-murano-pkg-check - Murano package validator tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415634

Javier Peña  changed:

   What|Removed |Added

  Flags|needinfo?(jp...@redhat.com) |



--- Comment #2 from Javier Peña  ---
Thanks for the review Randy. I have uploaded an updated version to:

- Spec:
https://jpena.fedorapeople.org/murano-pkg-check/python-murano-pkg-check.spec
- SRPM:
https://jpena.fedorapeople.org/murano-pkg-check/python-murano-pkg-check-0.3.0-1.fc26.src.rpm

Koji scratch build available at
https://koji.fedoraproject.org/koji/taskinfo?taskID=17840954

A couple notes:

- The bundled JS is added by the doc building tools, so I've opted to declare
those as Provides: bundled()

- About the unit tests, this is the norm with all OpenStack projects (unit
tests always get installed), so I've excluded them from the resulting packages
for simplicity.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421150] Container Review Request: mariadb - MariaDB is a multi-user, multi-threaded SQL database server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421150



--- Comment #1 from Matus Kocka  ---
Hello Honza, 
I am going to review this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421150] Container Review Request: mariadb - MariaDB is a multi-user, multi-threaded SQL database server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421150

Matus Kocka  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421150] Container Review Request: mariadb - MariaDB is a multi-user, multi-threaded SQL database server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421150

Matus Kocka  changed:

   What|Removed |Added

 CC||mko...@redhat.com
   Assignee|nob...@fedoraproject.org|mko...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org