[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 Emmanuel Seyman emman...@seyman.fr changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-03-22 10:55:26 --- Comment #10 from Emmanuel Seyman emman...@seyman.fr --- Included in rawhide, released as an update for F20. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 David Dick dd...@cpan.org changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from David Dick dd...@cpan.org --- yeah, this is my first review. :) i've thought about the licensing issue. I think it's safe to use the license link on http://search.cpan.org/~avar/Hijk-0.12/, which points to http://www.opensource.org/licenses/mit-license.php as the source file for the license. to finish the review, put the content of this file, namely - The MIT License (MIT) Copyright (c) year copyright holders Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the Software), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. -- into a file called LICENSE.txt (or equivalent) and then you can release it. package APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 Emmanuel Seyman emman...@seyman.fr changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Emmanuel Seyman emman...@seyman.fr --- Thanks, David. New Package SCM Request === Package Name: perl-Hijk Short Description: Specialized HTTP client Owners: eseyman Branches: f20 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 --- Comment #7 from Emmanuel Seyman emman...@seyman.fr --- David, is there a reason you cleared the fedora-review flag? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 David Dick dd...@cpan.org changed: What|Removed |Added CC||dd...@cpan.org Assignee|nob...@fedoraproject.org|dd...@cpan.org Flags||fedora-review? --- Comment #1 from David Dick dd...@cpan.org --- Items marked as TODO are optional but recommended fixes; FIX are review blockers. TODO: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines notes that the MIT license requires the license file itself to be included in a distribution of the package. The MIT license file is not included in the package. Please co-ordinate with upstream to correct this. TODO: Utilize DESTDIR instead of PERL_INSTALL_ROOT, line 34. TODO: Remove META.json and cpanfile from %doc; these files are of no use to the end users, line 45 Dependencies: You'll need to BuildRequire all the use'd and require'd modules to prevent possible future build failures caused by buildroot change FIX: BR perl FIX: BR perl(File::Temp) FIX: BR perl(strict) FIX: BR perl(warnings) FIX: BR perl(FindBin) FIX: BR perl(Fcntl) FIX: BR perl(Socket) FIX: BR perl(POSIX) FIX: BR perl(URI::Escape) FIX: BR perl(Cwd) FIX: BR perl(Carp) FIX: BR perl(vars) FIX: BR perl(Config) FIX: BR perl(base) FIX: BR perl(File::Find) FIX: BR perl(File::Path) FIX: BR perl(Plack::Runner) FIX: Drop the Plack BR, it is not use'd or require'd. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 David Dick dd...@cpan.org changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 --- Comment #2 from Emmanuel Seyman emman...@seyman.fr --- (In reply to David Dick from comment #1) TODO: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines notes that the MIT license requires the license file itself to be included in a distribution of the package. The MIT license file is not included in the package. Please co-ordinate with upstream to correct this. Indeed. I've filed bug #93868 on rt.cpan.org, asking the author to include the text of the MIT license with the tarball. TODO: Utilize DESTDIR instead of PERL_INSTALL_ROOT, line 34. Done. TODO: Remove META.json and cpanfile from %doc; these files are of no use to the end users, line 45 Agreed. Done. Dependencies: You'll need to BuildRequire all the use'd and require'd modules to prevent possible future build failures caused by buildroot change FIX: BR perl I have to admit that putting perl as a BR seems a little strange. Nevertheless, I've included it. FIX: BR perl(File::Temp) FIX: BR perl(strict) FIX: BR perl(warnings) FIX: BR perl(FindBin) FIX: BR perl(Fcntl) FIX: BR perl(Socket) FIX: BR perl(POSIX) FIX: BR perl(URI::Escape) FIX: BR perl(Cwd) FIX: BR perl(Carp) FIX: BR perl(vars) FIX: BR perl(Config) FIX: BR perl(base) FIX: BR perl(File::Find) FIX: BR perl(File::Path) FIX: BR perl(Plack::Runner) Added. FIX: Drop the Plack BR, it is not use'd or require'd. Removed. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Hijk/perl-Hijk.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Hijk/perl-Hijk-0.12-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 --- Comment #3 from David Dick dd...@cpan.org --- Missing BR perl. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 --- Comment #4 from Emmanuel Seyman emman...@seyman.fr --- My bad. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Hijk/perl-Hijk.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Hijk/perl-Hijk-0.12-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 David Dick dd...@cpan.org changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from David Dick dd...@cpan.org --- Looks fine apart from the missing license. As per https://fedoraproject.org/wiki/Packaging:LicensingGuidelines, we'll give upstream a chance to provide the full text of the license. The package looks to be in a maintained state, so hopefully the bug will be fixed soon. It might be worth mentioning in the rt bug that the reason for the licensing bug is to package the module for Fedora. This could encourage the maintainer to fix the bug quickly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074268] Review Request: perl-Hijk - Specialized HTTP client
https://bugzilla.redhat.com/show_bug.cgi?id=1074268 David Dick dd...@cpan.org changed: What|Removed |Added Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
